Unreviewed r123761 follow-up, inspector closure compilation fix.

* inspector/front-end/Script.js:
(WebInspector.Script.Location.prototype.uiLocation):
* inspector/front-end/ScriptSnippetModel.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
https://bugs.webkit.org/show_bug.cgi?id=92387

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in EWK2UnitTestServer.cpp.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
(EWK2UnitTestServer::EWK2UnitTestServer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit should expose @title as label (AXTitle or AXDescription) sometimes instead of AXHelp, according to the ARIA text alt computation
https://bugs.webkit.org/show_bug.cgi?id=91911

Reviewed by Anders Carlsson.

Source/WebCore: 

The ARIA spec states that the title attribute should be used as the last resort for a description of an element. WebKit needs to honor that.

Test: platform/mac/accessibility/title-attribute-used-as-last-resort.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::accessibilityDescription):

LayoutTests: 

* platform/mac/accessibility/title-attribute-used-as-last-resort-expected.txt: Added.
* platform/mac/accessibility/title-attribute-used-as-last-resort.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: SASS source mapping straw man (behind experiment)
https://bugs.webkit.org/show_bug.cgi?id=92265

Reviewed by Vsevolod Vlasov.

This change introduces SASS mapping support (behind the experiment).

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.resourceBinding):
(WebInspector.CSSStyleModel.prototype.setSourceMapping):
(WebInspector.CSSStyleModel.prototype.resetSourceMappings):
(WebInspector.CSSStyleModel.prototype._rawLocationToUILocation):
(WebInspector.CSSLocation):
(WebInspector.CSSRule):
(WebInspector.CSSRule.prototype.get isRegular):
(WebInspector.CSSRule.prototype.uiLocation):
* inspector/front-end/ContentProviders.js:
(WebInspector.StaticContentProvider.prototype.contentType):
* inspector/front-end/SASSSourceMapping.js: Added.
(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._populate):
(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(rawLocationToUILocation):
(uiLocationToRawLocation):
(uiSourceCodes):
(reset):
(WebInspector.SASSSource):
(WebInspector.SASSSource.prototype.isEditable):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/StylesPanel.js:
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.rawLocationToUILocation):
(WebInspector.StylesUISourceCodeProvider.prototype.uiLocationToRawLocation):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/UISourceCode.js:
(WebInspector.UILocation.prototype.uiLocationToRawLocation):
(WebInspector.UILocation.prototype.url):
* inspector/front-end/Workspace.js:
(WebInspector.Workspace):
* inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][WK2] Implement Network Information provider
https://bugs.webkit.org/show_bug.cgi?id=92343

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Moved Network Information provider code from WebKit1
to WebCore so that it can be shared with WebKit2.

No new tests, no behavior change.

* PlatformEfl.cmake:
* platform/efl/NetworkInfoProviderEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp.
(WebCore):
(WebCore::NetworkInfoProviderEfl::NetworkInfoProviderEfl):
(WebCore::NetworkInfoProviderEfl::startUpdating):
(WebCore::NetworkInfoProviderEfl::stopUpdating):
(WebCore::NetworkInfoProviderEfl::bandwidth):
* platform/efl/NetworkInfoProviderEfl.h: Added.
(WebCore):
(NetworkInfoProviderEfl):

Source/WebKit:

WebKit EFL not longer needs to link against EEZE
library since the Network Information provider
was moved to WebCore.

* CMakeLists.txt:
* PlatformEfl.cmake:

Source/WebKit/efl:

Make NetworkInfoClientEfl use NetworkInfoProviderEfl
from WebCore to avoid code duplication with WebKit2.

* WebCoreSupport/NetworkInfoClientEfl.cpp:
(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):
(WebCore):
* WebCoreSupport/NetworkInfoClientEfl.h:
(WebCore):
(NetworkInfoClientEfl):

Source/WebKit2:

Add Network Information provider for WebKit2 EFL
by using NetworkInfoProviderEfl class from
WebCore.

* CMakeLists.txt:
* PlatformEfl.cmake:
* UIProcess/API/efl/NetworkInfoProvider.cpp: Added.
(toNetworkInfoProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(getBandwidthCallback):
(isMeteredCallback):
(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):
(NetworkInfoProvider::bandwidth):
(NetworkInfoProvider::metered):
(NetworkInfoProvider::startUpdating):
(NetworkInfoProvider::stopUpdating):
* UIProcess/API/efl/NetworkInfoProvider.h: Added.
(NetworkInfoProvider):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: simplify handling of status bar items
https://bugs.webkit.org/show_bug.cgi?id=92143

Reviewed by Pavel Feldman.

- split status bars into "global" (always in the bottom) and "panel"
    (on top of the drawer when drawer is shown)
- use "inner" status bar section in global status bar to display either
    panel status bar items or drawer view items (depending on drawer visibility)
- let panels/views manage their counters as part of their status bar
    items, not through special interface members;
- get rid of absolute positioning in the status bars where possible;

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.get statusBarItems):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide.animationFinished):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._startStatusBarDragging):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype.willHide):
* inspector/front-end/elementsPanel.css:
(.crumbs):
* inspector/front-end/inspector.css:
(#main):
(body.drawer-visible #main-panels):
(.status-bar):
(.status-bar-item):
(#panel-status-bar-placeholder):
(body.drawer-visible #panel-status-bar-placeholder):
(#panel-status-bar-resizer):
(#panel-status-bar):
(#panel-status-bar > div):
(#error-warning-count):
(#drawer):
(#drawer-contents):
(.status-bar-items):
(.drawer-header):
(#inner-status-bar):
(.search-status-bar-item):
(.search-status-bar-message):
(.search-status-bar-progress):
(body:not(.platform-mac) .search-status-bar-progress):
(body.platform-mac .search-status-bar-progress):
(.search-status-bar-stop-button-item):
(.search-status-bar-stop-button .glyph):
(.search-results-status-bar-message):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector.showViewInDrawer):
(WebInspector._closePreviousDrawerView):
* inspector/front-end/timelinePanel.css:
(.timeline-records-counter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Remove redundant surface origin transforms
https://bugs.webkit.org/show_bug.cgi?id=91815

Reviewed by Stephen White.

Source/WebCore:

Bug 91417 changed draw transforms to become equivalent to origin
transforms for surfaces. This change removes them as they are no
longer needed for anything.

No new tests. Just a refactoring.

* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::leaveToRenderTarget):
(WebCore::::unoccludedContributingSurfaceContentRect):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit/chromium:

Clean up use of origin transforms in tests. Where possible, test
against the equivalent draw transform.

* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCRenderSurfaceTest.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore: [chromium] Remove redundant surface origin transforms
https://bugs.webkit.org/show_bug.cgi?id=91815

Reviewed by Stephen White.

Bug 91417 changed draw transforms to become equivalent to origin
transforms for surfaces. This change removes them as they are no
longer needed for anything.

No new tests. Just a refactoring.

* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::leaveToRenderTarget):
(WebCore::::unoccludedContributingSurfaceContentRect):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit2: [EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
https://bugs.webkit.org/show_bug.cgi?id=92387

Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in EWK2UnitTestServer.cpp.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
(EWK2UnitTestServer::EWK2UnitTestServer):

LayoutTests: [Qt] css3/filters, editing/undo, fast/block/lineboxcontain, fast/js and tables/layering tests need update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92292

Reviewed by Alexis Menard.

* platform/qt-5.0/Skipped:
* platform/qt/css3/filters/effect-blur-expected.txt:
* platform/qt/css3/filters/effect-blur-hw-expected.txt:
* platform/qt/css3/filters/regions-expanding-expected.txt:
* platform/qt/editing/undo/5378473-expected.txt:
* platform/qt/editing/undo/undo-misspellings-expected.txt:
* platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-box-expected.txt:
* platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.txt:
* platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-replaced-expected.txt:
* platform/qt/fast/block/lineboxcontain/none-expected.png:
* platform/qt/fast/block/lineboxcontain/none-expected.txt:
* platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
* platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/qt/fast/block/lineboxcontain/replaced-expected.png:
* platform/qt/fast/block/lineboxcontain/replaced-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add FastMalloc statistics in window.internals
https://bugs.webkit.org/show_bug.cgi?id=91274

Patch by Olivier Blin <olivier.blin@softathome.com> on 2012-07-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/harness/fastmallocstatistics-object.html

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCoreTestSupport.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* testing/FastMallocStatistics.h: Added.
(WebCore):
(FastMallocStatistics):
(WebCore::FastMallocStatistics::create):
(WebCore::FastMallocStatistics::reservedVMBytes):
(WebCore::FastMallocStatistics::committedVMBytes):
(WebCore::FastMallocStatistics::freeListBytes):
(WebCore::FastMallocStatistics::FastMallocStatistics):
* testing/FastMallocStatistics.idl: Added.
* testing/Internals.cpp:
(WebCore::Internals::fastMallocStatistics):
(WebCore):
* testing/Internals.h:
(WebCore):
(Internals):
* testing/Internals.idl:

Tools:

* GNUmakefile.am:

LayoutTests:

* fast/harness/fastmallocstatistics-object-expected.txt: Added.
* fast/harness/fastmallocstatistics-object.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][WK2] Regression(r123731): Linking errors due to efreet functions
https://bugs.webkit.org/show_bug.cgi?id=92378

Unreviewed build fix.

The library list created by PlatformEfl.cmake was being erased by a
SET called after including the platform specific file. Luckily the
dependencies were fulfilled by other targets until efreet was add.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-26

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add setting to enable and disable diagnostic logging.
https://bugs.webkit.org/show_bug.cgi?id=92337

Reviewed by Anders Carlsson.

Source/WebCore:

Add a new entry in Settings, defaulting to false.

* page/Settings.cpp:
(WebCore::Settings::Settings): Default the new setting to false.
* page/Settings.h:
(WebCore::Settings::setDiagnosticLoggingEnabled): Simple accessor.
(WebCore::Settings::diagnosticLoggingEnabled): Ditto.

Source/WebKit/mac:

Add a WebKit WebPreferences API to set set the WebCore diagnosticLoggingEnabled setting.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Register the default value to false.
(-[WebPreferences diagnosticLoggingEnabled]): Simple userDefaults accessor.
(-[WebPreferences setDiagnosticLoggingEnabled:]): Ditto.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Ensure this preference is propagated to Settings
    whenever the preferences change.

Source/WebKit2:

Add a WebKit2 WKPreferences API to set set the WebCore diagnosticLoggingEnabled setting.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetDiagnosticLoggingEnabled):
(WKPreferencesGetDiagnosticLoggingEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Ensure this preference is propagated to Settings
    whenever the preferences change.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[nrwt] get rid of --skip-pixel-test-if-no-baseline
https://bugs.webkit.org/show_bug.cgi?id=92377

Reviewed by Adam Barth.

Remove the option and all code paths that handled it.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.should_run_as_pixel_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_repeat_each):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
expectations change for skia rev. 4771
https://bugs.webkit.org/show_bug.cgi?id=92402

Reviewed by NOBODY : expectations change only

* platform/chromium/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add a ChromeClient method to send diagnostic logging messages from WebCore to the client.
https://bugs.webkit.org/show_bug.cgi?id=92340

Reviewed by Anders Carlsson.

Source/WebCore:

Add a new ChromeClient menthod, to be implemented by WebKit and WebKit2, which sends
a diagnostic logging message up to the client.

* page/ChromeClient.h:
(WebCore::ChromeClient::logDiagnosticMessage):
* page/ChromeClient.h:
(WebCore::ChromeClient::logDiagnosticMessage):
(ChromeClient):
* page/DiagnosticLoggingKeys.cpp: Added.
(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::passKey):
(WebCore::DiagnosticLoggingKeys::failKey):
(WebCore::DiagnosticLoggingKeys::noopKey):
* page/DiagnosticLoggingKeys.h: Added.
(DiagnosticLoggingKeys):

Add the new files DiagnosticLoggingKeys.cpp,h to the project:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Pipe the ChromeClient logDiagnosticMessage() function through WebKit2 to a new bundle class
InjectedBundlePageDiagnosticLoggingClient, to be implemented by the client.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetDiagnosticLoggingClient): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::logDiagnosticMessage):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleDiagnosticLoggingClient):

Add a convenience class to retrieve the diagnostic message keys:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):

Add the InjectedBundlePageDiagnosticLoggingClient.cpp,h files.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* win/WebKit2.vcproj:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r123159, r123165, r123168, r123492,
and r123650.
http://trac.webkit.org/changeset/123159
http://trac.webkit.org/changeset/123165
http://trac.webkit.org/changeset/123168
http://trac.webkit.org/changeset/123492
http://trac.webkit.org/changeset/123650
https://bugs.webkit.org/show_bug.cgi?id=92406

allowing inline-table anonymous wrappers is a bad idea due to
tons of corner cases that should be properly handled
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

Source/WebCore:

* rendering/RenderInline.cpp:
(WebCore::RenderInline::addChildIgnoringContinuation):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::createAnonymousWithParentRenderer):

LayoutTests:

* css2.1/20110323/inline-table-002b-expected.htm: Removed.
* css2.1/20110323/inline-table-002b.html: Removed.
* fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
* fast/table/inline-block-generates-table-wrapper-expected.html: Removed.
* fast/table/inline-block-generates-table-wrapper.html: Removed.
* fast/table/inline-table-in-continuation-expected.html: Removed.
* fast/table/inline-table-in-continuation.html: Removed.
* fast/table/inline-table-with-caption-expected.html: Removed.
* fast/table/inline-table-with-caption.html: Removed.
* platform/chromium-linux/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-mac-snowleopard/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-win/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug3037-1-expected.txt:
* platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
* platform/efl/tables/mozilla/bugs/bug3037-1-expected.txt: Renamed from LayoutTests/tables/mozilla/bugs/bug3037-1-expected.txt.
* platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug3037-1-expected.txt:
* platform/mac-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
* platform/mac-wk2/mathml/msub-anonymous-child-render-crash-expected.txt: Removed.
* platform/mac-wk2/tables/mozilla/bugs/bug3037-1-expected.txt: Removed.
* platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
* platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add diagnostic messages when media and plugins load or fail to load.
https://bugs.webkit.org/show_bug.cgi?id=92341

Reviewed by Anders Carlsson.

Send diagnostic messages when a media or plugin element loads or fails to load. Include in
the trace the media engine description, error code, or plugin mime type.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget): Send a diagnostic message.
* html/HTMLMediaElement.cpp:
(WebCore::stringForNetworkState): Added convenience function to stringify network states.
(WebCore::HTMLMediaElement::mediaLoadingFailed): Send a diagnostic message.
(WebCore::HTMLMediaElement::setReadyState): Send a diagnostic message.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget): Send a diagnostic message.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Build broken when svg is disabled.
https://bugs.webkit.org/show_bug.cgi?id=92393.

Patch by Chang Shu <cshu@webkit.org> on 2012-07-26
Reviewed by Laszlo Gombos.

Need to surpress unused parameters warning.

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::buildReferenceFilter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore: Contained div with right 0 sometimes overlaps parent div
https://bugs.webkit.org/show_bug.cgi?id=91521

Reviewed by Levi Weintraub.

Due to unnecessary rounding in clientLogicalWidth and clientLogicalHeight
we lost precision when computing the width and position of render boxes.
Change clientLogicalWidth/Height to return values with subpixel precision
to avoid this.

Test: fast/sub-pixel/position-right-aligns-with-container.html

* rendering/RenderBox.h:
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
Remove unnecessary rounding.

Source/WebKit2: Add a ChromeClient method to send diagnostic logging messages from WebCore to the client.
https://bugs.webkit.org/show_bug.cgi?id=92340

Reviewed by Anders Carlsson.

Pipe the ChromeClient logDiagnosticMessage() function through WebKit2 to a new bundle class
InjectedBundlePageDiagnosticLoggingClient, to be implemented by the client.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetDiagnosticLoggingClient): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::logDiagnosticMessage):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleDiagnosticLoggingClient):

Add a convenience class to retrieve the diagnostic message keys:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):

Add the InjectedBundlePageDiagnosticLoggingClient.cpp,h files.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* win/WebKit2.vcproj:
* WebKit2.xcodeproj/project.pbxproj:

Tools: [nrwt] get rid of --skip-pixel-test-if-no-baseline
https://bugs.webkit.org/show_bug.cgi?id=92377

Reviewed by Adam Barth.

Remove the option and all code paths that handled it.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.should_run_as_pixel_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_repeat_each):

LayoutTests: Contained div with right 0 sometimes overlaps parent div
https://bugs.webkit.org/show_bug.cgi?id=91521

Reviewed by Levi Weintraub.

Add test for elements positioned based on the right edge and update two
existing tests that where affected by the rounding.

* fast/sub-pixel/position-right-aligns-with-container-expected.html: Added.
* fast/sub-pixel/position-right-aligns-with-container.html: Added.
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
Mark new subpixel test as skipped on platforms that do not enable
subpixel layout.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Regression: r123696 made css3/flexbox tests failing
https://bugs.webkit.org/show_bug.cgi?id=92352

Reviewed by Levi Weintraub.

Source/WebCore:

Use roundedLayoutUnit so ports without subpixel layout still pass existing tests.

Covered by css3/flexbox/flex-algorithm-min-max.html which should pass again.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):

LayoutTests:

Skip css3/flexbox/flex-rounding.html on ports that don't enable subpixel layout.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] InputHandler failure logs should be logAlways and critical.
https://bugs.webkit.org/show_bug.cgi?id=92403

Reviewed by Rob Buis.

Update Log level for failures and fix mask in log.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertStringToWchar):
(BlackBerry::WebKit::convertStringToWcharVector):
(BlackBerry::WebKit::convertSpannableStringToString):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::setTextAttributes):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123784 268f45cc-cd09-0410-ab3c-d52691b4dbfc