labofsahil/github-event-dataset-2012 huggingface dataset:
Description has no support for Pattern (at the moment). to build the Filter from List\<Description\> I need to generate a list of methods aka Suite. this leaks the logic from BlockJUnit4ClassRunner#computeTestMethods which is bad. 

An alternative could be to build Pattern support into Description e.g. Description(clazz,pattern) but this would require a redesign of Description because className, methodName are not stored in separate fields instead stored in a string of format method(class), see also #327
by using patterns in Description equals()/contains() can no longer be used in the "pattern filter", each entry from desiredDescription has to be tested one by one (not a problem, just a different approach)
i dont recall what the point of this was ATM, removing it may not be the right way to go
Technically a payload can be sent with a GET request, though the server behavior is not well defined.  So perhaps just check if there is a payload.  I'm not sure though, whether you'd need to explicitly set the `Content-Length` to zero.

Also, can you update the unit tests to assert that the header is set correctly.
Should we put this in a namespace so if we want to do it for other things later there aren't a bunch of toplevel functions just chilling? `Shopify.clickEvent` seems like a weird place for this handler to end up
yep, this was carry over when I was figuring things out. Will remove.
Passing multiple files to this method doesn't seem right. While multiple files can be added to the working set, only a single file can be selected.
lowercase versión
We should definitely improve the docs, but I also think if we renamed this ```addMenuItem()``` per your suggestion above, that would help make expectations about the return value less strong.
I didn't notice a significant lag, but the number of bytes could be reduced by setting a ``var s = highlight.style;``

I am not sure if ``highlight.style`` gets cached by JS, but this might also save keep it from getting dereferenced 12-18 times.
typo: nowtcreate
Is there something this function can return if live changing isn't supported?
You can set params as the second argument to urlopen: http://docs.python.org/2/library/urllib2.html#urllib2.urlopen
BAM?
Comment is a bit misplaced I guess, but I'm referring to the fact that you can use library routines in guava to avoid verbosity of doing it yourself here. According to the example I linked to, it replaces lines 59-72, not the early-out tests at the beginning of this function.
By "sensitive information" I basically mean file paths (BTW, in the debugger, the traceback file paths are not filtered).
I think you just want to call this ``profile_edit``.
handler.option instanceof NamedOptionDef == false in case when handler.option == null
partial 的檔名也一樣改和 topbar 格式
Why you test that? Just try to convert, if you fail, that request will be ignored.
fix indent of these two lines.
http://caniuse.com/#feat=namevalue-storage
your. come on.
semicolon plz!
Yeah, I think that's possible. It's slightly different than one might want though...
Fair enough. `re` does cache compiled regexes, but this does allow us to be more explicit about what's cached.
JEMALLOC -> USE_JEMALLOC and put it forward after ZLIB?
concat是Tengine的标准文档，不需要通过第三方的方式来写。可以说明--with-http_concat_module
这行换到变量声明的最后一行，从短到长，最长的变量类型和变量名称相隔不要超过2个空格
this is a bit hard to read.

a better pattern might be:
```
Locale locale = Locale.getDefault();
if(arrayBinaryContains(locale.getLanguage(), "ja", "ko", "zh") || arrayBinaryContains(locale.getCountry(), "BZ", "CA", "KE", "MN", "US")) 
    ... do stuff
```

and define the method
```
private boolean arrayBinaryContains(String search, String... sortedValues) {
    return Arrays.binarySearch(sortedValues, search) >= 0;
}
```
Using different class name
You're way to quick at this.
Why moving this to devel deps?
Addressing within this file; however, this is a fairly common issue throughout the codebase; therefore, we may want to address it more globally outside of the pull.
it is prefered to use:
  'type' in csset
instead of
 cset.has_key('type')

ACK anyway
You trolling me?
Ah yes, i had put it here cause the tested method is in the model class, but i think it makes sense for that method to be  moved to authorization.  Will do that and move the test there.
actually, I wanted to leave this one, these aren't the sort of errors that should be hidden
Namespaces are inside the namespace...
The pan event provides the distance panned as convenient dx,dy in both absolute (since start of gesture) and relative (since last pan event) forms. The swipe event provides absolute dx,dy values and also velocity, angle, and direction ('up' or 'down' or 'left' or 'right') of the overall swipe.

But more importantly, these events work correctly with 2-finger pinch gestures.
Because I need the `return;` at line 11 :P
nit: the name of your anonymous function seems wrong
There's no "options" section in the documentation spec - you include these as parameters, but you say "optional" along with the type - e.g., the first one should be:

```
fft_pad: bool, optional
  Default on.  Zero-pad image to the nearest 2^n
```
After ``-no-javascript-jit`` there is an unneeded space, which you could remove. And btw. now I know where the Qt static build is coming from ^^ ``-static``. I have 2 additional switches in my local configure line, which are ``-no-dsp -no-vcproj``. As far as I remember they are only needed for MSVC support.
Hmm, am I missing something or this results looks like duplicated of the one above it.
I'm guessing the portability issues on windows are that the 7 log levels don't exist and there are only 3 levels instead?  I wouldn't worry about it too much, we're currently not actually calling syslog so I wouldn't think offering the unix log levels would be an issue.  Unless I'm misunderstanding the question.
I think you want to use a Camptocamp copyright :)
Yep you can find this by registering a new email address or reseting the password of existing one.

A different locator or wait could be used but I wanted to target the tag that contained the email address that was being tested with. There was a bug involving the email not being displayed so I wanted to get it and assert against it in the 123done tests. so while it's a more complex locator we can use it for two things.
VS hates me.
Please don't use ``sizeof`` which is only an alias for ``count``. and here, you could simply use ``! empty($classes)``
probably "since ApplicationView has no template"
I'd like to understand why we're doing "class << self" rather than the previous self.x method names
Hmmm, dit zou er niet in mogen zitten.
Dat lijkt iets met de multipleselect voor dropdowns te maken hebben.

On 10-jul.-2012, at 22:34, Tijs Verkoyen wrote:

>> @@ -1256,7 +1256,7 @@
>> 				if(index > -1) elements.splice(index, 1);
>> 
>> 				// set new value
>> -				$('#' + id).val(elements.join(options.splitChar));
> 
> Wat is dit?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/forkcms/forkcms/pull/273/files#r1135241
Ticks isn't seconds, so it just needs to reverse this operation:
https://github.com/tmaul/ppsspp/blob/fcfeeb8319c0efd865d68aae125afa8e03ffd1c0/Core/HLE/sceRtc.cpp#L178

Or in other words maybe something like (untested):

```
u64 ticks = Memory::Read_U64(tickPtr);
time_t sec = (time_t) ((ticks - rtcMagicOffset) / 1000000ULL);
```

-[Unknown]
I understand Brian's position better now, consider my question resolved.
Nice, will fix that for the already existing controls, too
Not that I know of.

@ranyefet, anything I missed?
It might, I'll try and add a test for both.
Why not use a template like below? It'd be a lot cleaner and more flexible for the future.
How about `[en-US] English (7)`? That way I don't have to guess what some of those languages with weird characters are.
Was this for temporary debugging or do you want to keep it around for enabling quickly?
`"mr.t.quotes"` is the pref, where are the white space you mean?
50 will be `logging.CRITICAL`. It's probably not you want to use here. Instead it should get a value between `logging.INFO` and `logging.WARNING`.
I'm sure there's a reason for this hack. Can you add a comment to justify it?
You're missing the MPL in this file.
Bother, they're not. Correcting the methods individually.
Note to self, consider just calling the ReminderMailer, this just saves us one line of code.
Tak jsem šťouchal do CoffeeScriptu a nějak začínám chápat, jak ty whitespace věci fungujou. První parametr funkce musí být na stejným řádku a všechny další se pak musí uvíst čárkou. Tímhle způsobem by to ten parser měl mít snad jednoznačný.
Its not. I shouldnt have pushed that.
"현재 EPUB은 이 컨[테]츠를 위한 미디어 오버레이가 포함되어 있지 않습니다."
should be changed to 
"현재 EPUB은 이 컨[텐]츠를 위한 미디어 오버레이가 포함되어 있지 않습니다."

It is a kind of typo.
Thank you
якщо GaufretteBundle не юзається, то можна його не писати. в нас не юзається
I understand why you have done that, but `Niet-ondersteund type` doesn't sound like correct Dutch for me.
or null now
the listener id is a string
No need for `static` here.
ah, it is indeed private. I forgot it
Now, we disable openssl only for PHP < 5.3.4
@drak should I also tag it with @api ?
@stloyd Your suggestion is ok, but the order of parameters was wrong:

    0 === strpos($this->currentLine, '- ')

I updated https://github.com/symfony/symfony/pull/4126
no typehint for classFinder?
コメントありがとうございます。
>(:all)の中ではmockを作成できないので注意
知りませんでした。。。
以後、注意します。
Constants should start with UpperCase -- this is actually not only a matter of style, but the pattern matching does not bind uppercase names, so it allows you to match against constants without further ado. And I also believe the optimizer only folds UppercaseConstants.
I would split this line as well, but I also agree that the line length in templates varies
Yes, ```removePhoto()``` only deletes if the current user owns the image.
Seems simpler to me to have this be:

```ruby
guest_email = 'guest@example.com'
```

With the build_stubbed in effect, shouldn't make much practical difference, but I think the fewer layers of dependencies is a little nicer. Interested in the team's opinion.
фигня в том, что бэкбон работает с коллекциями через url, у нас же дэшборд одни, поэтому приходится писать кастомыне контроллеры.
You can simplify the whole file as a single hsG3DDeviceModeRecord, instead of reading its fields separately.
pop can start at an arbitrary position, as requested by this issue, that's why we need to keep track of current position while walking through.

That's also the reason why we might need to "reconstitute" in the general case, where we removed something from the middle.
Yea, it is redundant and `install_requires` is a stronger requirement since there is no way to turn them off with setup parameters.
at the moment the user profile is different from allother edit screens in that we are not saving on blur, and we are only saving if the user hits save. this could be frsutrating for the user...
Absolutely agree,  rewritten with CountDownLatch. Thanks for making me do it, the migrated code was nasty.
Hmm, actually the method name implies "started" as well. How about isHornetQServiceInstalled()? That's vague if you don't understand MSC (hence the method javadoc) but is technically accurate for those who do.
nit: remove '==='. (I think '[ ]' will be better.)
Do you mean "logItem"? I do not know what you mean with "llogIteml" :O
`loadingIcon: document.getElementById('statusbar-loading'),`

We are using `defer` to load our scripts, there is no point writing a lazy loading function any more.
If the ftu leave outside settings you don't need that right?
typo: initialDefaultAdapter
You would probably get the actual icons in **the** follow up ... :P

Just remember to do so next time (same thing apply to the R and L placeholder labels in HTML)
Let's move this part and write an Github issue about this TODO item.
Isn't this a duplicate from the `csHInfoPrimary` property?
Should access through `CallScreen` anyway also.
Do we really need 1000ms or this can simply be 0? Have you test it?
We're still loading Account/Calendar.load up front so it's not needed at this point - but shouldn't hurt anything either :) Might be good to keep as a placeholder when I update that branch upstream.
Hey guys, sorry for the lag!
There is already some code to do that in apps/contacts/js/contacts.js with a similar but slightly different syntax. I don't know if the code should be shared or not but having the same syntax would make sense at least. (I wish there is an easier way to do that somewhere in the platform).
The only possible or error `req.result['ril.data.disabled']` could be a string `"true"` or string `"false"`. But that's going away with new setting api fixes, I don't mind if you don't check it.
opt 应该换成 params，为什么不应该是 opts？因为 imageMogr 的参数列表是次序相关的。
I think we should start getting into the habit within swiz to put tests in async.* blocks, because if the API truly becomes async then we will have more tests to upgrade later.
This is already documented here: http://rubydoc.info/gems/rspec-core/RSpec/Core/Formatters
`to -> too`
this is just a subsection of the above
This needs to be removed. Before "memoizing" the ongreeting -> onmessage, I did it conditionally within the callback... It was slow as shit! so I came up with this setup.
Ah, those should be "raise".
We agreed that this service was to be written in Python 2.7, not 2.6.
The usual way of doing this in Leaflet is get it from constructor options. Please replace with `className` in options of `Path.js`. Also note that Leaflet uses camelCase naming for everything.
I think you forgot to finish the description. In this case, a docstring probably isn't needed as the method's name is good enough.
Putting `'use strict'` outside of the function may cause problems when concatenating with code that isn't strict.
In vim, do `:set spell` to run spellchecking. There are a few spelling mistakes/typos (`accuracely`)
OK, we're now using that factory, and I removed the file with the old factory.
This looks like more than 4 spaces indentation
Yeah -- I wasn't 100% on this part. I'd appreciate if someone more familiar with SSL could double check both how I'm assuming the CA / top certificate and also how I get and verify the CN / alternative names. The fact that I'm skip the intermediary certificates is almost certainly wrong; I'd appreciate any pointers or links o docs/specs that would give a clue how to do that part properly.
to verify, if you comment this line out, the test you wrote fails, right?
Also, it's maybe better to use `which $CMD` instead of running the command, in case it has any side-effects.
A software switch might be able to handle an arbitrary number of actions, so a fixed number like 4000 isn't going to work.
`votes_count.zero? ? votes_count : (100.0 / votes_count * upvotes)`
"a theme defines colours and images that give your application or site its look and feel."
please copy and fill ipa header from https://github.com/ipa320/setup/blob/master/templates/license_header.py
Aren't those using a variable the components supporting categories so they have to accommodate multiple categories?

Guess no gain no harm.

Would something like this be helpful? https://gist.github.com/2852267 As far as I can tell that part of the code is the same in all these methods.
Sure, I can change this. What should `open`return?
Some empty object that will be used to fetch the nsIZipWriter instance via namespace, or the nsIZipWriter instance itself directly, or some other object?
Could you also add tests for `tabs[index]` access to make sure it works.
Why not using `[f, this].concat(Array.slice(arguments))` instead?
or `var args = Array.slice(arguments); [f, this].concat(args)`
It highlights the issue of `arguments`, and we are used to Array.slice in our codebase.

Is it possible to process only `arguments` to reduce. It is really really hard to get why arguments and `f`/`this` are processed into the reduce function!? It would be way easier to follow with something like this:
   
      let self = this;
      return
        // create real array for `arguments`, with `reduce` method
        Array.slice(arguments).
        // reduce it via `promisedConcat` to get promised array of fulfillments
        reduce(promisedConcat, resolve([], prototype)).
        // finally map that to promise of array with `f`
        then(function(args) { return f.apply(self, args); });

Note that `execute` shortcut doesn't necessary improve comprehension of this code.
@Mossop @ochameau maybe we can just call it `getDescriptor` ?
That's what I have mentioned on IRC. As long as you do not have created a log, the folder will not exist. We simply should make sure to create it whenever the extension gets started.
Hmm. Well I wouldn't want consumers to use nextIndex but this is an interesting point. I would prefer to return an array with all the current elements in order and have the consumer traverse that since I'm not sure if there's an in-place method of handling this.
I would propose we better define an object with the observe method contained.
Would You mind to add `"extensions.checkCompatibility.4.0",` too? It would fix [Bug 650634](https://bugzilla.mozilla.org/show_bug.cgi?id=650634 "Cannot get NTT to turn Force Addon Compatibility ... for FF4").
:) If you want it updated just let me know.
Please don't change this -- this is a change in the CS we'll be making do to the php-fig PSR-1 and PSR-2 proposals.
Yes, you are right indeed. Fixed it.
Iirc, the row object no longer is restricted to ArrayObject.

On Wednesday, August 15, 2012, Marc Bennewitz wrote:

> In library/Zend/Db/ResultSet/ResultSet.php:
>
> > @@ -47,7 +47,8 @@ class ResultSet extends AbstractResultSet
> >      /**
> >       * Constructor
> >       *
> > -     * @param  null|ArrayObject $arrayObjectPrototype
> > +     * @param string           $returnType
> > +     * @param null|ArrayObject $arrayObjectPrototype
>
> I think ArrayObject could be a type-hint ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zendframework/zf2/pull/2169/files#r1380065>.
>
>


-- 
Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/
Per the remaining files, you'd add something like "Copyright (C) 2012 Some Name" at this line here.
I'm just pointing this out for consistency.
The indentation here is broken.  Please review the full pull-request and ensure that the indentation is proper everywhere -- use 4 spaces, never use tabs and be consistent.
We will find out another solution for this as soon as possible.
What's the rationale behind this change? The problem as I see it is that 2 Config objects will be created and I don't see the point in exposing this new method, since we already have the app.development and app.release methods to isolate development/release settings in the Rakefile.
But then you have to add `mod.` twice. So why?
Those two regexps are never used, so should be removed.
The 3 iteration for loop, combined with these 2 lines fixes a bug in Minecraft that allows players to create 2 nether portals that are touching, causing some of both portals to become invisible. (Minecraft Bug Fix)
Use .which instead of keyCode. Same on the one below.
would be better if it is explicitely defined to `False` rather than any None value.
not sure why, I added this. Perhaps it was to test something and should possibly be reverted.
ok, then lets handle the "delete large tree" in the documentation and be consistent.

what about throwing an exception if cascade is not activated and there are undeleted children? or is deleting the children implicitly the same as having delete cascade on sql database level and we just accept it?
Please indent these ones?

    case real_pos >= 0 do
      true -> ...
      false -> ...
http://paste2.org/p/2569582 :-/
Actually, all these lines should have  a comma too at the end :-D
only in case of more then one element. i like it like that to prevent very strange bugs
I think this is indented by 3 too many spaces.
Yeah, let's do that. If we ever create a konacha binary, we can support something like rspec's `--out` option, but for now let's keep it simple.
This check breaks ie8 because in ie8 0 in [undefined] returns false.
can you replace `&` with `&amp;` ? Thanks!
not actual
Could the current year/month be the default values here (or in the method, if default args in Python are set once and cached, which I think maybe they are)?
I say optimize templates for developer readability, not how it'll look when rendered out as HTML. You can do that `{% for -%}` thing maybe? But who cares what the rendered HTML looks like in terms of indentation levels? Or at least, if the trade-off for better View Source is worse source code for developers working on it, I say favour the developers.
A docstring should describe the class/method in question... we aren't as set on docstrings for classes, so this should either the tests contained in this, or just not exist.
@tofumatt : Why not just do list comprehension if you're gonna cast it as a dict() anyway? Also, you can probably just return it instead of assigning then returning on the next line.
@tallowen: I don't understand your comment. This is what I'm doing in my mind. list comprehension to get a list of tuples --> throw it into a dict to get a dictionary, return said dictionary.
So lets do it this way then.
Well, thinking more about and it makes sense. So leave it in here.
They're also so that people can customise them using skins if they want.
This one could even be changed into `DEFAULT_LIST_PAGE_SIZE = 50`
Should it have resolve options too, the other flavors with parse options also have resolve IIRC
Use CAPS for constants. MANIFEST instead of manifest.
That would be fine, this just seemed like the lowest-impact way to fix the system in the short term.

Under the old config system, somehow the Node's *config dictionary* would make it into this code path, which IMO it absolutely should not have.
Intentional newline?

"excersise" -> "exercise"
Mention automod somewhere! :-O
Um...yeah, I have no idea what I was thinking when I wrote that :)
Check out this test case:
http://codepad.org/Ez8sqsL1
у тебя защитники все в разные одежды разодеты
@railsjedi: I have a test refactoring that I'm rebasing on top of this, so could you explain for me what the `:format => :xhtml` is testing please?
Comment on line added after line 30
looks like this should throw an IllegalArgumentException
Oh, I see now that you simply extracted this method from ``initialize``. Still, if it's not useful we should just remove it. @dragos WDYT?
No, there is nothing more than making it easier to access URI segments via a 1:1 relationship between the number of the segment and the number of the segment array key. It prevents the need to type `$n - 1` every time you access one (why calculate it repeatedly when you don't have to?). It's easier to write, manage, and add to.
Кстати, алгоритм ну совсем не эффективный... После каждого изменения бежать по массиву и считать не сходные элементы... Хорошо, что у нас 100 элементов, при большом количестве что-то совсем не круто каждый раз наворачивать по такому количеству итераций.
Тут вот какая штука - если в вашу функцию передать значение больше 100
то она никогда не закончится
Вместо этого можно переопределить метод
```objective-c
- (NSString *) description;
```

При вызове
```objective-c
NSLog(@"%@", obj);
```
в лог печатается результат посылки сообщения description объекту obj.
мне кажется, или у вас mutate может мутировать одни и те самые елементы по несколько раз...
Хорошим тоном считается вынесение категории в отдельный файл.
The point of this class is to be used in MaterialData, you need to actually call those methods properly...
Is it possible to move glyph extraction to gfx/fonts/fonts.c then? Path lookup of fonts could certainly be moved there as well.
@felipemorais ^
Fixed. I made it so any string passed to this function works with or without a trailing backslash.
<img src="http://www.questionpro.com/images/sony-psp.jpg" />
Totally nit-picking (so don't be offended), but for global classes, can we avoid `use` statements and stick to prefixing them with `\` in the doc blocks and code? Otherwise there's some ambiguous cases where we refer to `\ReflectionProperty` but also `ReflectionClass`.
アプリ名は「見出し」なのか? (それもレベル3の) というのが気になりますねえ。
ここは単純なリンクでいいんじゃないでしょうか。役割を明示するために rel='home' を付けておくといいと多います。
When do you envision that being useful?

I think we should leave it out unless we know of a case right now where it'd be handy.
I think we should still have `+backgroundScheduler` (not `+sharedBackgroundScheduler`), which would be equivalent to the default priority for convenience.
Yeah, it seems to work in the examples I was viewing. 



On Mar 30, 2012, at 5:14 PM, dandover<reply@reply.github.com> wrote:

>> @@ -0,0 +1,65 @@
> 
> Does github recognize .markdown?  I thought it was .md?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/joinwire/pipewise.rb/pull/1/files#r629217
can also be a list of stc
parameters should be in the first docstring of the class before Attributes
Yes ok, I was wondering why it was used here. Do we really want to enable minification in closure compiler? For me this task was now handled by requireJS. So shouldn't we disable it in any case?
I think this needs to be `Github.setup(gh_user, gh_password)`
that appears to be another valid case..

but then that cold also occur within raw's implementation don't you think..
--

Ikenna



On Thu, Dec 13, 2012 at 11:34 PM, Josef Šimánek <notifications@github.com>wrote:

> In doc/guides/3 - Advanced Techniques and Tips/3 - Using Custom View or
> Layout Templates.textile:
>
> > @@ -61,6 +61,7 @@ name of the file you whitelisted.
> >
> >  * Inside of this file, you can either +render '/refinery/content_page'+, or you
> >  can use +@page.content_for(:body)+ to output the content of a specific page part.
> > +NB: You may want to invoke html_safe like this (@page.content_for(:body).html_safe) in some cases.
>
> If some method can return nil (@page.content_for can!), I'm using raw to
> avoid NoMethodError: undefined method `html_safe' for nil:NilClass.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/refinery/refinerycms/pull/2078/files#r2415453>.
>
>
Small deal, but it's more common to do the `application::` syntax here, and then remove the `.. code-block:: php` below
单位为毫秒，精度是毫秒
What is the reason behind this change?
I'd suggest `ensure_mutable` for the name, because that's what we're really testing. Also wouldn't use a `!`, as the whole purpose of the method is to potentially raise an exception, so in that sense it is not surprising (also that's consistent with `ensure_not_nested`).
Но тогда при удалении произойдет 2 удаления: сначала share, потом Qt
Ну и звездочка слева от равно не там, да. Вот почему лучше юзать auto! :)
Свитч не отбиваем же.
Use PropertiesConfiguration.PropertiesReader functions to match on prop delimiters.
Not needed.  (name :foo) -> "foo"
see DataManager comment; try to get rid of the internal add; use the config object
I'm just copying what was done before but I can fix that if you want to.....
`if (!view)` is easier to read and more flexible, don't you think?
Need to add ``query`` parameters to the ``path`` in this if-branch.
Probably to make sure it's integral, I bet
Typo: asynPutInCache instead of asyncPutInCache
Actually: does it make sense running any of the state trasfer code if state trasfer is not enabled(above condition)?
The same three lines of code occur twice for the same reason. Can we DRY up this bit by abstracting it as a helper method?
I think you mean "at triangulation points", not "at triangles"; the latter would be the same as using facecolors.
Would be nice if we could have a better folder name. Presumably this is done to have somewhere to store the result images?
I think these two lines probably need a comment...
As far as I can tell, this was a typo in the docs.  There has never been a method called `trisurface`.
If I'm understanding this comment correctly, then I'm not sure it's needed. Are you suggesting checking that each character is an integer between 0-9? If so, this is test data and controlled by the test, so I don't see the value. Perhaps I'm missing the context.
have you deleted your last comment? I cant find it :-(

On Tue, Aug 7, 2012 at 11:26 PM, François Thillen
<notifications@github.com>wrote:

> In testproject/ETMTCP/ETMTCP.cs:
>
> > +using System.Net.Sockets;
> > +using System.Threading;
> > +using System.Net;
> > +using Protocols;
> > +using System.Collections.Concurrent;
> > +using Protocols.ActiveMQ;
> > +using Apache.NMS.ActiveMQ.Commands;
> > +using System.Collections;
> > +using log4net;
> > +
> > +namespace TCPHandling
> > +{
> > +    /// <summary>
> > +    /// ETM witch is listening on TCP
> > +    /// </summary>
> > +    public class ETMTCP : IDisposable
>
> a) Are all changed
> b) I don't find a way, to remove one. All the variables in the class
> header are needed in the complete class. Could you pls give me an example?
> c) I looked the code, but I can't split something. Everything looks so
> complicated because listen, receive and send are all asynchronous. Every
> method is somehow depending to one in this class.
> d)done.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1326624>.
>
>
could it be simply `if (len == 1) {` ?
You forgot to remove this fixed example.
Yeah you're right, the max-width can be applied regardless.
Oh, sorry. I remember I fixed this, no idea why it is still there.
You'll need to change the SCSS file, and then recompile the CSS (via compass-style.org)
Decided to go with 'description updated'
cool refactor]
They look right to me.
You did it yourself you cockroach!
这里不应该改动的。
Cleaned this, and many similar. User mostly `$id` instead of `$key` / `$number` etc., also renamed `$repo` to `$repository` to be more consistent.
Duplicated `$`
isBlackberry has new use in this file but creating window reverted back to the origin
Cuidado con estas. En JS/Coffee es más seguro `not channel?` porque `!channel` es `true` si `channel` es `0`, `''`, `[]`, `{}` y otras combinaciones absurdas.

Tienes varias de estas repartidas por ambos plugins.
There is a way to do looping over the second dimension, but it involves a double method call - in the first one you extract the indices, and you call the second one with a single-dimensional array. It's probably more trouble than it's worth.
I forgot to delete that (this was from last week).

2012/3/30 denlab <
reply@reply.github.com
>

> > -                             "<div class='input'>"
> > -                             "<label id='label-" % "'>"
> > -                             "<span>" % "</span>"
> > -                             "<input id='id-fn-" % "' size='30' type=
> 'text'/>"
> > -                             "</label>"
> > -                             " <div id='id-input-error-"% "'
> class='small error'>&nbsp;</div>"
> > -                             "</div>")) args)))
> > +  [fnd fname args]
> > +
> > +  (let [arity (count args)
> > +        fnar (fn-ar fname arity)]
> > +
> > +    ;; display the inputs
> > +    (append! fnd (str "<h3>Input the arguments - Arity - " arity
> "</h3>"))
> > +
> > +    ;; find a way to use the templating... enlive?!
>
> > ... enlive?!
>
> nope, there's no enlive in prod
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/clojure-consulting/fnx/pull/48/files#r627679
>
font-family:  $monoFontFamily;
@technoweenie I see this was changed in ebfbc436422ae83795afdb1987d356bba2a57dd1 to `sender`, but I don't see `sender` in the data returned by `https://api.github.com/repos/puppetlabs/facter/pulls/306`.
Since I don't have any authoritative data on the actual payload of a pull request (since using web hook doesn't seem to work), I had to guess by the content of the pull itself.
I'd hate for this to cause regressions for you.
Fix a linker issue under GCC 4.7.x
JViewLegacy?
Since the rest of JSession is not chainable (and not easily made so) wouldn't that cause more confusion that utility?
Useless comments should be removed as well. Thanks.
Staying with submit for consistency. Its behavior is the only one possible with UDP.
I don't think so.

This is doc'ed as `id`. I also think that some of the JavaScript SDK tests actually set this value as "id".
Does inheritDoc actually work here?
Because I forgot to change it before submitting :) Will fix tomorrow.
в users_controller#show  пагинация постов
`updateUnreadCount` -> `updateHiddenPostsCount`.
TODO. Please read my comment from before.
Put `url` at the beginning, to be consistent.
OK, only KeyError from get_provider()??
Can you move also `<li>` into comment?
You are modifying for the whole application, which asset asset package class is used.
I think it should be configurable, by defining a package name (in annotations for example).
We can leave this class out and just use the `ActiveMerchant::Billing::Integrations::PayflowLink::Notification` class directly in the module. Doesn't need to be subclassed, as far as I can tell.
correct, commit inc
I'm not sure what these # <----- comments are left over from. Can we just remove these?
Yes. BytesRefArrayWritable is what is returned by base RCFile. 'Refs' are used to minimize buffer copies (we could not avoid the copy since we need to make a DataByteArray).
Keep the comment about infiniteSequence
Yep.  If I recall, when this method was an instance method of `viewHeater`, in the base case for recursion, the line `this.showNewHeatmap()` resulting in an error where `this` was undefined, or at least wasn't the `viewHeater` object any more.
default email address could be persona_server instead of 123donetest
You mean Yahoo
`r` will always be at least an empty array here, so you could do `var r = this._network_logger.get_resources([msg.id])[0];` and then check if you have it and so on.
Agree. That's the best.

when you run such command under the "mod_pagespeed/src/net/instaweb/automatic" directory:

    make BUILDTYPE=Debug all

it may encouter the compile error:

    undefined reference to `DoAssert'
8192? Because your input buffer size is already 4096.
the requirement has to be matched. _locale is special, since that attribute is always set .. even if its not even in the route definition itself.
I found your answers and found them helpful :)
Change to SISU locks, for configuration we should not use  j.u.c locks -- but this statement is not true in general (or the other way around). so SISU locks are not to be used _everywhere_.
We don't really even need this any longer, right?  You just leaving it in "just in case"?
I should add that I don't think the `.view()` should be required.  But if it turns out that it is required for some reason, you could just have the constructor check the type of image and convert if necessary.
view --> viewed
In most practical uses, this won't be the only thing you are using a random number generator for.  You'll be randomizing things about the galaxy profiles, adding noise the image, etc.  

So our usual practice in other functions has been to accept any rng as input and use that, converting to the kind of rng needed.  So the root program makes one rng with a particular seed, and then passes that to everything.  That seems cleaner than making the caller convert to a GaussianDeviate if their rng happens to be a UniformDeviate, for example.
I've created new request and response objects for update consumer
there might be question from Opscode on why you changed the Gemfile
Okay--I will amend what I said, so ignore the previous comment about the two clauses not making a difference.  It obviously does.

The code still relies on the orderBy('group_id', 'level') clause in getByCourse(), otherwise the code would break. It would be nice to note this in a comment.
Next time can you do this kind of renaming in its own branch + pull request, so it can get into master a lot sooner and so that it doesn't flood the driver pull request with so many unrelated changes?
I think configure should only be called by the thread creating the entity instance, so should not have to synchronize.
You don't need the "env" if it matches the field name, I believe.
will also need a testUndeploy asap.
Ah ouais ils continuent a prendre leur tarif la
It is mere replacing of int to objc.id. Result of deleting duplicate codes, line is shifted.
This might be a good place to mention the Augeas dependency for the lens, e.g. the release beyond 0.10.0.
This, which forces <code>0 <= theta <= 2&pi;</code>
Yep—I'll cancel this request and build it into the main.js file
The same problem...devise
ですね！消します！
Hannes Magnusson <notifications@github.com> wrote:

> > @@ -393,6 +398,41 @@ int mongo_store_option(mongo_con_manager
> *manager, mongo_servers *servers, char
> >  		return 0;
> >  	}
> >  
> > +	if (strcasecmp(option_name, "fireAndForget") == 0) {
> > +		mongo_manager_log(manager, MLOG_PARSE, MLOG_INFO, "- Found option
> 'fireAndForget': %s", option_value);
> > +		if (strcmp(option_value, "true") == 0) {
> > +			servers->default_fire_and_forget = 1;
> 
> That just feels wrong. The option name itself is case insensitive, but
> the boolean value - which by nature of php is case insensitive - is
> case senstive?

We already had this discussion :-) The spec is vague and therefore I'd rather be strict and have the possibility to relax it later.
Oh, I usually do not ship with it because I don't think that's useful to have this in the tar.gz, but that could be a mistake :-)

I wanted to only ship something that's installable (so no tests and no docs) but it means that people would need to install from the git repo to have ecerything available.

Not sure what makes more sense. I usually prefer to avoid adding content to the distributions to have an faster installation phase, but that's at the detriment of having a self descriptive distribution.

what's the motivation behind the fact that you usually ship with the doc?
Indentation as before
Aberto ticket para repensarmos essa situação em todas as views. tk: http://trac.scielo.org/trac/scielo-manager/ticket/195
No, unfortunately. I have no guarantees in the code whether the path is absolute or not.

Ideally, I would strip the whole thing down and store only relative paths and namespaces until the final moment of dispatch.
Other changes in this diff are related to *promoting* manual path logic to delegate to `_abspath()`. Why is this use of `_abspath()` being demoted to manual manipulation?
Remove the To Do. Keep them in a separate file.
eure entscheidung :-1: Ich mein das ist doch jetzt nicht schlimm? Was hat das jetzt für einen Sinn??? Ich bau gerade die Möglichkeit auch per NMA und Prowl Feedback zu geben spätestens da brauch ichs ... soll ich da dann 3 verschiedne GUIDs verwenden :D Sinn?!
ñ ÎÅ ÚÎÁÀ ËÁË ÓÄÅÌÁÔØ ÔÅÐÅÒØ ÔÁË, ÞÔÏÂÙ ËÏÎÆÌÉËÔÁ ÂÏÌØÛÅ ÎÅ ÂÙÌÏ...

2012/11/30 Dmitriy Komanov <notifications@github.com>

> In src/ru/fizteh/fivt/bind/test/Permissions.java:
>
> > @@ -1,67 +0,0 @@
> > -package ru.fizteh.fivt.bind.test;
>
> á ÐÏÞÅÍÕ ÔÙ ÕÄÁÌÑÅÛØ ÍÏÉ ÆÁÊÌÙ?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/dkomanov/fizteh-java-task/pull/271/files#r2272379>.
>
>



-- 
ó õ×ÁÖÅÎÉÅÍ
æÅÄÀÎÉÎ ÷ÁÌÅÒÉÊ
íæôé æé÷ô ÇÒ. 195
Не только пробельные символы являются разделителем слов.
Сделай три экземпляра PerformanceTest, у которых свой Runnable, но пусть используют один и тот же map.
In real life we might want to choose one of the Gem-powered approaches, like the mighty mighty ffake. But figuring out a location/library for a test fixture that appears only once in my code didn't seem like a great use of the time I had available.
I guess we'd also need to add in the space still, or also make that a requirement for the preface so that we don't end up with "video:title".
target.tab = tab?
ホットリローディング処理
が旧に横文字出てきた気がした。自動再読み込み処理とかでも良いかも。
Don't use dashes in ruby filenames - this should be lib/rhc/coverage_helper.rb (everything RHC related goes into the lib/rhc folder except for rhc.rb, this is standard gem practice).  Require as 'rhc/coverage_helper.rb'.
Fwiw, the default is actually ["80"]
Oooh, true!
+1  I'd just display "original" as one of the filter results -- i.e., the last, and perfect, filter result.
@glouppe We should add that to the other estimators that support ``sample_weights`` - what do you think about a new ``WeightedRegressorMixin`` and ``WeightedClassifierMixin``?
Maybe you want to insert a 'check_random_state' here also, if it is no longer in the __init__
I'll remove it, it's just a leftover to see how much speedup the move to Cython brings.
`member_id = member` sounds weird here. Why are we removing the id?
shouldn't we return only one item? Why are we returning a list?
i think this initialization of the timer should move to `main()`. As it is now, it will not fire if a connection never receives a message.
Indentation still a mess here, please use 4 spaces to indent each level.
This switch is missing a default case.
The look of it is not so good. We need to figure out how can native look reused.
It stops Webmock from being required in dev/production environments in the Sinatra app - it was throwing WebMock::NetConnectNotAllowedError errors whenever the app was trying to access the Licensify API.
PEP8 whitespace.  ignore.
This needs to walk the annotations, and process as you find them, rather than searching for particular annotations.
That would allow you to have multiple annotations of the same kind.
The top reply on http://stackoverflow.com/questions/729379/why-not-use-exceptions-as-regular-flow-of-control is relevant to my interests.
I wouldn't care of the results type. We do not call the method of the base class. So it should be fine. Still not sure about the method name in general and if we should change it in mozmill itself. What do you think?
Player to ban, String to unban
Where is the consistency?
you should not use ``else`` as the ``if`` returns. Thus, it seems weird to allow the case where ``$parameters`` is not an array IMO
Introduced interactiveAddBashCloseWaitCTS to prevent calling RescanChanges() in a disposed form.
Why not do: data.getBytes()? You might wanna pass a Charset as well (i.e. UTF-8), if you wanna avoid environment dependant charset being selected.
Expand line to
```python
num_xy, _ = coords.shape
src = np.vstack((coords[:,0], coords[:,1], np.ones(num_xy)))
```
An extra tab?
I see.  Because we added `fromCartesian3` below?  Why have both?  I thought less was more.
This method should no longer be needed based on other changes.
I think this should be default behavior.
too many `install` names man. maybe you should call argument `installer` ?

```js
installer.addListener(listener);
installer.install();
```
+1 Thanks for reviewing @chrisroberts
A little known tip is that `ensure` takes `true`/`false` as `running`/`stopped` so you can avoid the `$service_ensure` structure above for simplicity.
Почему нет, обычный атрибут же как и name.
Does this need to be in brackets? (Just curious.)
Эта штука не умеет копироваться, ибо unique_ptr. Собственно, разрешить копироваться без какого шаманства я не представляю как.

Ну вижу что-то такого:
Смотрим на *it 
Копируем его (BaseIterator)
Берем на него указателяль
Создаем от этого указателя Iterator.

Собственно, пользы от такого копирования итератора не вижу. Как стоит показать, что мы такое явно запрещаем. Ошибка компиляции  про unique_ptr кажется не труЪ
removed everything.
[`function()`](#L2R69) vs. [`function ( element )`](#L2R73) - should probably stay consistent
when undefined, zg_utils are called anyway. wrap the calls with #ifdefs or remove the disabling bits from ./configure.ac and here
Actually I agree with @phiggins here. I'd have an internal collection of items that I exposed functions for. e.g.

```ruby
  def collection
    @collection ||= something
  end
```
two space indent?
```
failed: #<ActionView::Template::Error: undefined method `sha' for nil:NilClass>
````

I think you  mean:
```
<%= commit_repo_url(@sha) %>
```
I don't think this will work.  The error we were not catching (from Bug 740731) is

java.lang.IllegalStateException: Connection is not open at ch.boye.httpclientandroidlib.impl.SocketHttpClientConnection.assertOpen(SocketHttpClientConnection.java)

I thought that was the indicator that we needed to try again, right?
Some checks for Admin privilege started by checking the ID returned from AccessControlManager.getCurrentUserId(). This is problematic because it does not identify members of the "administrators" group. Since the AccessControlManagerImpl already has a reference to the current User object it seemed best to provide access to that object so client code can simply call User.isAdmin(), which does implement the group check.
it should be ``<2.3-dev``.

``2.2-dev`` would be a tagged dev version, so considered before any alpha. So the branch will always be considered higher than that.
I guess,

(psr2)[https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md]

> The term "class" refers to all classes, interfaces, and traits

Section 4.3

Or method on Interfaces are not targeted about this ?
Is this test supposed to be passing? Could use assertions if so... Not totally sure what's up here.
This simpler code approach uses the BIF get/put functions instead of passing around the Config bat.
I overlooked that one! Brb, fixin' it…
you need to change the constant name here as well.
Just asking because I've removed the special handling for traversables in the master branch. However, in that case we can probably keep it. 

Could you add an extra test case to avoid regressions?
When playing around with this it works but also breaks the placeholders in contentauthoring. I suggest we leave them as links for now and I've created SAKIII-5069 to take a closer look at this issue to avoid regressions so close to the release date.
What you say make no sense.

Theses properties are strongly typed. The property is meant to be a shortcut to a deeper field in the structure. Such shortcut exists, whatever the version of linux, whatever the platform, whatever whatever. They always have the type of the pointed field.

The property isn't the authoritative representation of the type, so they are auto. It have nothing to do with with static typing. It would if I chose to use Variant, but I did use auto, which isn't the same.

It have to do with having only one authoritative representation of knowledge in the system. Or, as stated in pragmatic programmer : « Every piece of knowledge must have a single, unambiguous, authoritative representation within a system. » . This one unambiguous authoritative representation is lying in the variable itself, not in the shortcut to access it.

It have nothing to do with future version of linux, at is is highly unlikely that they break binary compatibility, but it have everything to do with adapting to newer platform (other CPU arch or new ABI linux x32 ).
(The template htat calls this one will loop over each encounter)
Oops - forget that
Don't think there is too much overlap - but they are conceptually similar.
Oh, nevermind, html5, not xhtml.
Agreed. They should be changed to "DynDNS" and "Cloud DNS" respectively. Need to make sure than the same spelling is used in the input pulldown selector as well.
(Don't use that Django code because I am preparing a better version where you will be able to prefill some values. The template tag above is not useful for Tastypie URLs because it has too many open parts (like API version).)
I think this sentence needs little revising.

My suggestion: "Just like the other derivation functions, the more time (and memory) that is required to run the algorithm, the more secure the derived key will be."
This call to JLog isn't in the other drivers so let's remove it.
didn't you mean `README.md`?
E ok în principal, dar ne trebuie un widget top-level, astfel încât din template să zici doar:

{{ mk.widget(person_schema) }}
Same question as `evenName` above, this is only valid when using `polling`, correct?  As we add new link types, the number of properties could get pretty big.  Wouldn't it be better to have a `connectionType` property or something similar that was an object that had whatever options were specific to that connection?
just one last bit .. please also undo the use of ``contains()``
Crib from `pk_relations.py`, and create a `nested_relations.py`.
We're going to have an absolute **stack** of serializer tests so need to start breaking them out into properly testing all the various relationship types.