labofsahil/github-event-dataset-2012 huggingface dataset:
Ack, sorry about that. I opened the pull request on master and kept committing to master. This was committed after I opened the request. I'll branch and re-open the pull request.

However, this fixes a scrolling container that is outside the viewport. Currently if the `container` option is passed, images within the viewport of the container will load even if they are not within the viewport of the window. When a container other than the window is used, both it and the window should be checked.

I'll create an example page for this.
I'm happy to accept this as an addition.
I think that this can be done in the db.
ah :)

p.s. thank you for your updates.
peer not connected SSL error is still happening
with git push -f
Just a general case for more exploratory testing.
On 08-02-12 17:20, Bruno Binet wrote:
> Do you mind using collective.eggproxy repository from my organisation rather than this one?
> https://github.com/camptocamp/collective.eggproxy
> We plan to add a collective.eggproxy team and add you to that team.

That's fine.

I just pushed some doc changes to your repo, I'll move them over.


Reinout

-- 
Reinout van Rees                         reinout@vanrees.org
                http://reinout.vanrees.org/
"Military engineers build missiles. Civil engineers build targets."
how could this be set to true ? there is no setter AFAICS
Am 02.01.2012 23:49, schrieb John MacFarlane:
> Thanks. These are sensible changes. I had a few suggestions for revision:
>
> 1.  No version bump is needed, because 0.4 isn't released yet.

I didn't know that. :)

> 2.  I'd be inclined to keep the error for "the impossible happened" in splitBySemi.  This condition really is impossible, if I understand how 'break' works.  So if it occurred, I'd want to be notified.  Returning a Left value which is converted to a False by matchGlobs just loses the information.

Ok, if it truly never happens, keep it.

> 3.  I'd be inclined to have compileRegex and matchRegex return a KateParser Regex rather than an Either String Regex.  That makes the code slightly cleaner -- the "fail" will just propagate out, and you don't need to complicate the code with tests for "Left" and "Right". Does that make sense?

Yup, of course, that's even better. :)


-McManiaC
I solved the problem by declaring target as 'all'. May be it should be all by default?
One issue with this that’s worth bringing up early: Django’s admin won’t let you sort by score, because it’s not a field in the database. I’m not sure there’s a good way around this within the admin, unfortunately.
Having this along with ntfs-3g enables us to mount NTFS drives via OTG.
Hmm, obviously this is easy for me to say but the test suite passed when I ran it....
git doesn't work like this.
since you added the files, they will always be a part of history since the commits still exist in history.
http://stackoverflow.com/questions/3458685/how-can-i-completely-remove-a-file-from-a-git-repository

i'll do this at some point, when i have time.  or you can mess around with it.

make an announcement when you do it though because everyone who has the parts of history with those files will have to do a git pull --force, or re clone.
Also, you probably want `size_t` for `DEFAULT_KEY_SIZE` and `DEFAULT_SALT_SIZE`, and give an information about what a "reasonable" size is.
ValidateInteger raises a GAE exception (datastore_errors.BadValueError), should we re-raise as a DatabaseError?
You need to update the user test when you remove this, so that the test still passes.
Therefore, it's good time to have another function or rename for more logical name or make a more descriptive POD :)
Unfortunately, Your commit has something wrong. See this https://github.com/byeonggon/lynx-nexus-s/commit/286eb6da2cd0ad10854ecbf862fb669c90b4db6f
Also, I checked my line endings. They are valid. This file originally had incorrect line endings?
Oh, this is interesting.  Does this work okay in grails 2.0?  In grails 2.0, it's encouraged that you define actions as methods, not as closures.  We need to account for both cases to be truly grails 2.0 kosher.
Hi Lupohirp, already tried this, didn't work.
Camera is no longer handled by libcamera.so and liboemcamera.so but is moved to libhardware.
Need to find another solution for camera, probably need to rewrite drivers for msm7x27 as there are no ICS sources out for it.
snag() is a bit buggy - the bot occasionally does not snag or will snag several minutes after this command is issued.
Bye is a more encompassing way to part ways. It does away with the time of day and such insignificant details.
It only looks ok if you add ?w=1 to the commit URL so that it ignores the white space changes
this too :)
There is code that detects the maxVersion automatically by looking at the version of the installed xulrunner executable.
Try if this works for you:
https://github.com/infinity0/firefox-gnome-keyring
If not, you could try with "make VERSION=8.0".
I will ask prash who is the master man of those topics, thanks for your input

KalimAz
Hi Henry, just letting you know that this change has been made in the next branch (just merged next-nodePkgr to next)
@GaryJones You can say whatever you want about the WP coding standards. Imho, they're crap. If you [want to take a look at mine, then you can do it here](http://meta-box.tenderapp.com/kb/development/coding-guidelines). And yes, I'm not applying them here, as it's not my own project. So far the current state with this request simply is better and more readable than the original draft was and that was the _only_ goal of this request.

If you got additions to the actual code, please fork my repo, make a pull request and I'll move stuff in. Currently the discussion completely a) spams my github mail folder (one mail for every one of your notes) and b) doesn't add value and c) wastes time. GitHub is collaborate, so please just make a request. That's much faster than discussing personal preferences inline.
Mně jde především o to, že se ti nepovedlo ten pullrequest poslat. [Koukni se na diff](https://github.com/dg/dibi/pull/76/files) ;)
That's weird. Are those two `?`? Should the second one be a `:`?

Also if `options` is optional this will break. It's missing `options = options || {}`.
These lines may also be possible to be put in that function?
This can also be implemented in a base ListItem widget which creates a child widget for each zone
The follow up to my annoying question would be does that mean we need a Factory for Kryo?
def enqueue(receiver: ActorRef, envelope: Envelope): Unit = storage.push(serialize(envelope))
I'd just use a pattern match instead
umm, seems wasteful, why not just a type match and return the value itself?
Boy Scouting :-)
The “in” does not parse for me, should be deleted?

“lowest resolution” is ambiguous: “low res” means coarse, but “seconds” is actually the finest resolution allowed
soo nice, hard to resist
yea, I like that even better
About this, av_get_default_channel_layout appeared in libav/ffmpeg git repos 9 days ago, so I suspect none of the releases have this (it's definitely not in libav-0.8.*).
Don't reformat here, remove dav(s) add a ifclause above or below. (mentioned on the old diff).
Actually I just realized that it already works that way. dirty is a reference parameter passed to ProcessSelector() from Process() so Process() will get dirty == true if it is marked as such in ProcessSelector() and will also handle it there. Should I change that to passing dirty back as a return value instead of a reference parameter?
Is it possible to record the exceptions in your log? It sounds like your using Momoko in a production environment and that would give us a better view on what's happening.

        if connection is not None:
            try:
                connection.cursor(function, function_args, callback, cursor_kwargs)
                return
            except (DatabaseError, InterfaceError) as e:  # Recover from lost connection
                logging.warning('Requested connection was closed; exception: %r'  % e)
                self._pool.remove(connection)

Would be cool. :D
You can put this on the previous line.
internal_name should be camel cased.
Do you have a testcase which proves the problem?
Please change this so there aren't nested ternary expressions (use one or two `if` statements instead).
@galaxas0 Not necessarily a private property per se, seeing as he is declaring a backing iVar after all.  The public property should suffice.  It's also good to throw a smattering of documentation in along with whatever you add to the class.
Similar to above, but instead of pre-packaged `drawFrames`, it's a pre-packaged animation array. (It's usually a single animation, too).
If your program uses readline, you can always bind to `readline.on('SIGINT', ...)`. Readline picks up ^C through stdin keypresses.
i < ARRAY_SIZE(tab) (and drop the { NULL })
These should be H2's, since their directly attached to the top-level module, not a class that the module generates.
I agree;  I pushed a commit to change this to SparkException.
Oops, `scalaMap.toIterable.iterator` should be replaced by `scalaMap.iterator`.
Tohle by mohlo být 

    $this->injectSession($this->presenter->session);
I've got rid of the array-specific section, and generalised the scalar section. It still gives me the performance boost I'm after.
64 bit linux allow negative time, it seems it is windows where it is unsigned. That's not to say the comment is incorrect for the code ;)
Your whitespace has gone wonky here (some tab problem perhaps)
Hmm, is it OK that PyArray_ITER_RESET is called before the exit? That's the only reason I can see that the loop was constructed that way.
I removed the by-ref restrictions for foreach. More info in this commit message: https://github.com/nikic/php-src/commit/de80e3ce4b5b7a9ec0cfdd0778e77027a7ebfcc2

(Same for the test)
эти строчки отвечают за какое-то смещение - конечно надо
Возможно, стоит вынести в константу цвет и размер
NodeElement* under = dynamic_cast<NodeElement *>(scene->itemAt(eScenePos));
тогда так же?
лучше его переместить в CommonRepoApi
Yeah, even just `config = current_config` would be fine.
Updated "type" with rdoc code formatting. I did a git ammend - is that an OK practice (for rails) for something like this?
Hm, but this mean that i need to add  extra logic into [order function](https://github.com/rails/rails/blob/v3.2.8.rc2/activerecord/lib/active_record/relation/query_methods.rb#L88) and  parse order function arguments just for indicate if hash was passed correctly(all values are in `[:asc, :desc]`). Also i need to modify `reorder` function. 

So maybe better use `:asc` as default direction and set it even if value not in `[:asc, :desc]`
Yes. Nowhere used. Let me update this.
Would it be enough to go for `tl.last0 if (tl.len == 0) tl.first0 else last0`? Or could you elaborate with a patch?
This code again! Will this hack never tire of creating new issues.
You could fix the typo while you are at it.
I'd maybe move these to inner functions to the test_* routines --- then you can use variables from the outer scope rather than passing them via yield (which pollutes the test output with unnecessary information, which, being arrays, doesn't print correctly). Fixing this is not a pre-req for merging, but would be nice to have.
Does this change the supported combinations of types?
You should hash in the type as well. But actually, I think this should just re-use the hash method of basic. But actually, if you don't implement __eq__ and __ne__ (see above), then you don't need __hash__ either.
Yeah, this way's probably better, as it avoids unnecessary rebuilding.
`Transpose(MatrixSymbol('X', 3,3))[1,2]`  doesn't actually have a value, though, so it's not really "lazy". I think LazyMatrix is a good name for this.
SOPform and POSform could remain stand-alone (to deal with truth-tables). However, as you suggest, simplify_logic could be integrated into the more general simplify function.
Done.

What is the recommended way to do that? With a "\" escaping the line end
or using "(" and ")"  and exploiting that python allows arbitrary breaks inside lists/tuples?

And how to deal with the doctests? My second commit introduces doctest failures because of broken lines.
(Hence we should strip that one of and replace by a new final commit.)
That is, the blank line before the changelog entry - it helps prevent a conflict merge.
it seemed like a good value, but I will drop a comment here
Why not calling the ``terminate`` method of the HttpKernel so that listener written for the ``kernel.terminate`` event can be triggered too ? Currently, this event will not be triggered with your implementation
What's wrong with a for-each?
Also things like ````"frb" + "#{@id}"```` should be ````"frb#{@id}"````.  This is in a couple of places.
I'm actually going to change the signature of this method in a follow-up branch for the exact reason I noted elsewhere - that null start/end values don't interact well with Interval.
Oh, and equivalently for date/time:
DateTimeFormatter dateTimeParser =
    new DateTimeFormatterBuilder().append(null, new DateTimeParser[] { ISODateTimeFormat.dateTime().getParser() }).
      toFormatter().withZone(DateTimeZone.UTC);

I can't see any instances of appending multiple parsers into the builder to get a multi-format parser.  In any case, we can do something like that for date and date/time with ISODateTimeFormat.dateOptionalTimeParser().withZoneUTC().
Are null names allowed?
s/This option is useful when working with/Use this option with/
there are no sharded databases except those in a shard cluster. 

I think you're trying to say. "you can use these commands with unsharded databases in a shard cluster when you're connected directly to the mongod," but in that case, we should be explicit about this fact, rather than oblique.
They need to be top-level since they don't really want to end up under docs/ and subject to the documentation URL hierarchy. Agree that we need to keep the prefixer off 'em, and I don't actually know how to do that.
Hmm ... that makes sense, but it also scares me that I was able to blow away changes I made thru the web UI. But I guess with the revision and api key tracking we can revert things if we need to. I'd also like to stick a big warning box on the docs about it.
Je n'ai pas reussi a marier un container avec row-fluid. C'est pour ca que les pages index et contact ont des row non-fluid.

Pourquoi tiens-tu a row-fluid de toute facon?
Well, that is a general change throughout phpBB.
And what happened here?
What does the empty string method mean?
You may have forgotten to "global $phpbb_dispatcher;"
I'm not sure. Perhaps I should just add it back and the event would simply overrule the hook but the hook would still work if no event was used?
Same for stuff below, of course.
This has a few other reasons than just loading the files to test them.
@p I'll find a succinct name, in that case. Just don't expect it to be as explicit as it is.
That idea you gave may catch, also.
So, instead of:
ROLE_DESCRIPTION_FORUM_STANDARD_NO_OTHER
Use:
ROLE_DESCRIPTION_FORUM_STD_PRIVATE
And for:
ROLE_DESCRIPTION_FORUM_LIMITED_NO_OTHER
Use:
ROLE_DESCRIPTION_FORUM_LTD_PRIVATE

Those 2 fit the size and seem reasonably concise.
Should I also apply this to lines 152-154?
@nickvergessen 
I'm ok with both options, I still think we should vote which one should we use (or both).
You should not retab all the things in this list.
I'd rather not introduce another level. http://semver.org/ is enough.
Reducing might come in handy:

```js
AssetHandler.MIME_TYPES = tools.reduce(
  typeof navigator !== 'undefined' ? navigator.mimeTypes : '', // '' is a zero-length iterable
  function(mimeTypes, navMimeType) {    // in most cases the name of the handler is part of the description
    var mediaType = navMimeType.description.match(/audio|video|image/i);

    // return early when the mime-type is irrelevant
    if (mediaType) {
      // case insensitive, support "video" and "Video"
      mediaType = mediaType[0].toLowerCase();

      // store a mime-type per suffix (overwrites existing suffixes)
      forEach(navMimeType.suffixes.split(',').filter(Boolean), function(suffix) {
        mimeTypes[mediaType][suffix] = navMimeType.type;
      });
    }

    return mimeTypes;
  },
  { audio: {}, video: {}, image: {} }
);
```
What is potential about the returned bounds?
ino commit kardam to project
I checked it again, and it isn't changing anything. My fault.

I dabbled around with that a few days ago and forgot why it was there. I only got it working yesterday, by bypassing the detection completely by submitting the correct values via environment variables from within Python to the build system (see line 26 following).

Should I resubmit the pull request?
As far as I can tell, there is no JQuery method for opening a window, and window.open is supported across all browsers.
Test are named using the _Should_xxxxxx_ naming convention
(beautified) Code moved to controller
I'll throw an exception and catch it in quick-serve so it's not a skyphp killer.

In cases that we don't want to throw and exception:
I think returning `false` for soft fail should be standard procedure. It's the php way.
If it returns a string you should be able to assume it worked.
Add a comment explaining that this code is formatting up to 50 characters of data content for the exception message.
Put { on the same line as "function"
braces around multi-line if bodies please.
I should have been more direct: @gidden can you describe the difference between <limits> and "Limits.h"? just curious
Do you mind if I take a shot at the don't pollute the cache approach? That would be a pull request to your branch. I have an idea how to implement this relatively painlessly, and the easiest way to show the idea and check it works is coding it...
I see, thanks for the advice I'll take it in consideration when I'll have all the stuff I need to complete the qa tests.
Is this equivalent? It seems like the two string arguments to `usageFlags` got swapped around.
As first approximation we can provide build timestamp as a such identifier.
Looks like you're using spaces and this was written in tabs.  Mind fixing and resubmitting?
`this.nodeType % 10 === 1` is shorter only for plain and minified versions. Gzipped file will have the same size as for `this.nodeType === 1 || this.nodeType === 11` 

#### Sizes - compared to master

    251386       (+10)  dist/jquery.js                                         
     92029        (+6)  dist/jquery.min.js                                     
     33177        (+5)  dist/jquery.min.js.gz 

I also think that `this.nodeType === 1 || this.nodeType === 11` is more clear than modulo. But if the size of uncompressed version are important too we can use `this.nodeType % 10 === 1` and add some comments for clarity.
`nonce` was made explicit so these prefixes would form a pair, and derived from a timestamp rather than pseudo-random number for smaller size.
I am wondering why the whole paragraph shows as a single line. Have you added newlines here?
remove 2nd "for"
There was something with prefix / abs on Windows so I decided to just not check it here, I don't see when source file would be outside parent on Windows.
Code reuse was really just a side bonus, real thing that has me thinking along those lines is the lastfm backend idea. For it we would first want to ask the current tracks playback provider to set a new url, and then if it was not handled have the next tracks backend give it a go. With the current approach it would be possible with just ``_get_backend()`` calls and maybe some good naming of the variables we store it in, but the ``_get_backend(track=None)`` type API would also make it very clear IMO.

Any way, most likely this can just wait until the lastfm backend where we will see if we need it or not - idea just kept popping into my head to thought I would share it :-)
Noted. Confusing errors => strings are hard.

PS: Hahaha, I didn't realize you could put images in here.

...this might end badly....
Why GitHubGistFormula? This isn't installing from a Gist.
Ah, now I see your reasoning. Perhaps, as jack pointed out, define this outside of the class, so it's the same style for all homebrew formulae.

From a software architecture point of view your way may even be the better one :-)
Explicit version not needed; Homebrew will detect this from the URL.
Could you document why it's necessary too? E.g.

```ruby
# Fixes build failure on Lion due to foo
```
Root permissions are not necessary to bind to ports over 1024.
Would be nice to break this long line, maybe something like (just an illustration)

```rb
def describe_xcode
  @describe_xcode ||= begin
    xcode = MacOS.xcode_version
    xcode += ' (guessed)' unless MacOS.xcode_installed?
    xcode += " , CLT #{MacOS.clt_version}" if MacOS.clt_installed?
    xcode
  end
end
```
And yet another non-descriptive string constant.
Should use `current_time( 'mysql' )` or just `false`.
I wonder if that should be before the .startsExecutor

Probably shouldn't matter
In iOS 4.3 you still need the -webkit prefix. But maybe we should assume if the user is on 4.3 then it's a slow device, and not bother with the shadow. I could go either way.
Not exactly the same. Here we have "g" flag, but the one in main.js does not have the global flag and if I try with your suggestion to share it and use RegExp.exec in main.js, then inline color editor won't be able to invoke with Ctrl/Cmd-E all the time. Why? because exec call remember the last matched location and search from that location for subsequent invocations. So we can't share it.
And other important metadata like OS, timestamp, etc.?
I'm not sure if I missed it, but it looks like there aren't any tests covering having a multiline block comment, with the selection being larger than the comment, testing that it becomes uncommented. (The tests above have some multi-line cases, but they only use the toggle-block test, where the selection will always exactly surround the comment before uncommenting.)

Perhaps one way to add this easily is to add an extra step to `testToggleBlock()` that, after verifying the toggling, re-comments the original selection, then expands the selection outward slightly before uncommenting again.
I don't see how, but this is an optional param in the spec. Remove ``!`` and add ``=``. Same for the callbacks.
@RaymondLim  can you take a look at this?
Rather than modifying every each logging line of code in Raven.Client.Lightweight, I just created a logging extension that matched the signature that originally called a method NLog's Logger here. This could be extended to match NLog's Logger in it's entirety or just extended as needed.
Yes, this is a very hot path.
I'm pretty sure self.CLASSMETHOD() is the same as self.__class__.CLASSMETHOD()
some as comment above - the abstract class StoredValue links to a Location

my convention: dataLocation when it can only be dataLocation, location when it can be both
Right, the `var` is in the scope not in the if.
I'll make a PR for that.
Second mistake I made, these aren't translated exactly how I'd think they are.
I did my tests but it worked since I used it in the browser.
I don't think this file desreves two headers :-)
I wonder if there's a benefit to essentially reproducing the jQuery API docs here. Perhaps we should simply mark these as “calls the jQuery click function on a given object” with some top-level docs on JqJE, of the style:

```
These functions are meant to be combined using the ~> operator. For example:

  JqJE.Jq("button") ~> JqClick(AnonFunc(...))
```

So JqGetAttr would be “calls the jQuery attr function on a given object with the given attribute name”, etc. It seems like it makes sense to delegate to the jQuery docs on that. We could even link to the jQuery docs on the relevant function. Just a thought, though.
First letter upper case in TODO.
This is not really a constant, so it should be lower case.
Hahaha wow. Good catch.
Spacing (indentation) on all of these tick children.
There's too much going on in this setup to really justify a loop. several of the elements need to be set up, I need to handle defaults in different ways. This only happens once per load anyways.
no mozTransitionEnd? :(
can we use templates like we do baseDir, so {{templates}} since we alread write it out above
Why is this a comment?
Would it be better to def them? Long term it's easier to maintain than in comments.
#define PVR_RES_INFORMATION 19033
no need to use `princ`
Okay, now I really wish it had a PEP-8. :-) I've seen this so many times, to avoid calculating the length on each iteration.

Guess I'm just going back to jQuery.each then.
When baking the HTML this method is an acknowledgement that src, href, and other tags will need adjusting to be consistent with their static location.
This is a copy of the repo author's own podspec. They don't have tags.
This is a pretty uninspired "line two"
Yeah it prints very nice overview which is actually nicely wrapped. I ask everyone to write rich description texts, but in few cases (start a service) it's very short. Nothing to say really :-D
Just tested this and it turns out that it is needed as the locale attribute is not a part of the user but the user's preferences attribute.
@stof @Seldaek Use monolog `use` statements for classes without any namespace?
spelling: paRtition

I'm not following what this function is supposed to be doing. 
This is somewhat related to how ambitious you are about handling the various cases of combining child statements that are SP or MP over partitioned or replicated data.
Cool--I don't think I even would have thought of this, but I like the idea.
That's an interesting idea.  The meta stuff there now is just to make everything round trip when converting to a Table and back...  I think it's probably best to just have the user set these things after the fact (since this set of things may change over time).  But I'll think on it -- my view may change.  In any case, that probably doesn't matter for this PR.
yes we should, but that should be a separate PR (this one doesn't have qunatity in it yet and it would be better not to rebase and destroy the comment history)
One last nit to pick: `OrderedDict` should be imported from `astropy.utils`. It's not in the stdlib in Python 2.6.
本来不想加的，但是在调用的地方看起来语义上总觉得少了点啥
Wouldn't it make more sense to add a boolean/methods to COutPoint?
while I correct this, what do you think of lorenzo's hint about renaming beginning? and for consistency, should we then also change tuncate's ending?
用类名
yeah I think what I did here was merge from upstream but I squashed the merge commit into this commit thus it appears twice. It was my mistake to include the merge in the squish.
no, just a fallback. you can try it out http://jabbr-nick.apphb.com/#/rooms/toast
is it bool or boolean?
this doesnt work correctly with namespaces.
I agree, but the other interfaces are not called like that in doctrine2. This may be a good change for 3.0 (along with all other interfaces)
@davidcoallier I'm confused - have you ever programmed in R before? ;)  But I did just try it on a windows VM, and it worked without errors.
"Python2" doesn't exist on Mac, possible solutions are: python, python2.6, python2.5 - "python" command use always the newest version
That's what I was trying to say, I guess :)
How do code cells get typeset now?
It happens on a lower level, in interactiveshell: https://github.com/ipython/ipython/blob/master/IPython/core/interactiveshell.py#L2573
copy/pasting code from superclass is not acceptable.  please revert all this and raise a question relating to what you are trying to do which led you to copy/paste reuse.
DatatypeCoverter isn't url safe either. going to try the other suggestions you mentioned.

PS: the equals signs are actually part of the specification, they are just not present in the url safe version.
PPS: datatype converter actually strays from the spec because it doesn't add new lines
Any specific reason for this variant instead of just ``` var dict = {}``` ?
What should I give the user, then?
list of maps?
do you mean like `[{"foo":"bar"},{"foo":"baz"}]` ?
that would be covered by `dust.isArray(value)` 

if you mean objects like `{"foo":"bar","baz":"bal"}`, that would be a good idea, will make a commit!
Do we need to open this binary?
Usually yeah but it looks like sometimes the video pause/play stuff throws errors, I think because of the "[0]" part, which shouldn't be necessary but jquery won't play the video without it. I get a "$(...).foo is undefined" error if I try to play or pause a video that doesn't exist. 

I think they're redundant in functions that are only called when something is clicked (when the video's existence can be safely assumed), but for stuff that runs on page load the existence checks prevent those errors.
__whimboo__ wrote:
> Hm, but is it really necessary to have this test? ...

Not sure about it. I vote for keeping it. 
It's safe against black magic while we are in `waitFor`. :)
I was surprised too, but that's what assert said and it passes now!
@AdrianGaudebert I think the problem is that it says "aliases" in the comment. But in fact, it's really important. 

The [documentation](http://socorro.readthedocs.org/en/latest/middleware.html#crashes-frequency) says "from" and "to" but the code really needs it to be "from_date" and "to_date". https://github.com/peterbe/socorro/blob/bb51fe28cffe1b0e0010f970040a31a2e12bf830/socorro/external/postgresql/base.py#L129

If anything, I should remove the comment `# aliases` and leave it as is. 

@twobraids to answer your question. The code below expects `from_date` to be defined in `kwargs`. By using `.get()` I get either the from date or a None.
I'm not sure about that. I'd actually prefer us to use Setting, because it is a better name... But that is a minor detail, the point is that the public API (currently GraphDatabaseSetting) is too fat. And I actually believe that as a public API the Setting class is too fat as well. Our users should not have to be concerned with reading config (possibly as strings only), and not with the internal type of the setting, the string representation should suffice.
Please always use const QString& in the method signature. Parse into a QUrl and use .toString(QUrl::RemoveScheme) instead of writing custom code.
This is actually correct :)  Feedback from sam needs the association to a presentation and not a presentation feedback.  The tests should be using this and all of them pass.
да, але його можна використовувати не тільки один раз, а будь-коли, можливо при випадкових розсинхронізаціях (наприклад лежачий сервер з апи мейлчимпа). Він обновить записи якщо є, або створить якщо їх немає.
Is this necessary?
Seems like we could just do `return moto;` according to [this](http://requirejs.org/docs/node.html#nodeModules)

*//The value returned from the function is
//used as the module export visible to Node.*
this does not respect the interface as you wrote it should return ``false`` in this case (I don't agree with the choice of the interface but this is a different discussion)
Missing info about new params.
I think this whole thing should be wrapped in a `if ($headers)` (before explode) because explode will return `array('')` (one element) if you give it an empty string, and then it'll call `header('', false)` which isn't great.
See comments above about eliminating the need for all of these conditionals.
Why? We want to inherit from field like we did before (for BC reasons).
why marking is_array as being html safe ?
Mhh ... probably picked the wrong test method - should add a new one. Note sure why the tests are failing ...
these last two conditionals should also be else-if's to the QUICK_ACTION_LOCK conditionals since it's one or the other.
Also, wouldn't it be smarter to compare the style first as this involves less math?
couldn't the hidden navigation bar be set in the storyboard? 
would take out two lines here.
我不认为这是一个很好的解决方案
- 引入了不必要的自定义命令
- 完全可以通过 {\bf \verb #1} 来实现相同的效果，如 {\bf \verb \somecommand}
  不需要\textbackslash，而且这个只能针对一个命令，如果是多个连续命令，这个自定义命令就更完败了
Quite right. I will restrict it to the 3-channel case.
Yes, I think that should do it :)
The binary search method of collections is overloaded to accept a
comparator.
On Apr 15, 2012 2:59 PM, "achance" <
reply@reply.github.com>
wrote:

> >       {
> > -             return notes;
> > +             List<Note> results = new ArrayList<Note>();
> > +
> > +             for(Note note : notes)
> > +                     if(comp.compare(noteToFind, note) == 0)
>
> I didn't realize you were using Comparators for the search
> functionality...they are really only meant to sort things (see the docs:
> http://docs.oracle.com/javase/7/docs/api/java/util/Comparator.html).
>  However, if it works, then it's good enough for me!
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/achance/notebook/pull/3/files#r686175
>
I think forced should be injected as a map, but I would leave that out of this particular PR and focus only on the values for now.
Yeah. Trying to distill down to a documentable rule.
Thanks. Merged!
Do we need to assign the attributes to current_attributes?
The flags now go missing. They should be added to the attribute definitions
`) {` should be on same line as rest of `if` statement  #nikpick
ahh yeah, some other syntax doesn't work either, like the 'value if condition else value2' stuff that's already in here. hmm
It occurs to me now that this is technically not correct since the panels can be descendants deeper than direct children. However, I think this will be rare enough that this is fine; just like we take a short cut and ignore collapsing margins for element siblings.
Not the best place to enable the actual sounding of the alarm, let's fix this in a follow up.
dcontact -> deviceContact
fbdata -> fbData
So this will probably be:
```
var messageBody = decodeURIComponent(message.body);
```
All the magic is here...
The descendant selector worries me a little because they're slow.
I don’t care of an empty menu.

The Media Storage part comes with l10n items that haven’t been added to settings.en-US.properties. I’d have preferred to either remove this part or be able to review it. *sigh*
Good point, will check that 'undefined' and modify the handle_call test cases to check it.
I did this.  I did things like "3min" over "3m" in order to avoid ambiguity between minute and month.
s/operator.variant.{mcc, mnc}/operatorvariant.{mcc, mnc} but you should drop that log though.
and this into `bootstrap.js` if you don't want to create another file!
Sorry, forgot to delete it when cleaning comments
You convinced me on using %s
ok not time of export - but still, if sometimes timestamp is data centric & sometimes it is participant centric - i think it will lead to confusion
perhaps user_data.setdefault('participant_timestamp', timestamp) ?
My feeling is that it is more probable that someone is using these settings for something else and can now fail on deployment than someone actually wants to change these values for the regular deployment (since in custom deployment there is no problem in doing so).

So I still think we should keep it like this.
Add tracing for this step.
I copied that code mostly unchanged other than removing a couple things. But I'll add that check. Initialize should not be called more than once.
Really want to keep this delayed e64765eb4261ec6f9122d42940056b4d9d8b9028
@alexch -- isn't that the standard OSS flow for non-committers?  I think the "giving back" workshop is a great idea, because we noobs need to get through the phase of being non-committers before we can become committers, so that's the hill we need to empower our ambitious students and vols to climb.  Doing it "at home" should be the safest and most hassle-free way to start, so that's my goal with this endeavor.

Timely processing of pull reqs also makes this a lot simpler -- just pull from upstream/master and push to origin/master at the start of every edit cycle (ok, since I haven't read the manual, maybe there's a wrinkle or two).  If my local repo is only dirty long enough to get feedback and then a pull, I don't have to worry much about getting out of sync (especially with the "heads-up" collaboration signalling I recommended elsewhere).  If I have some kind of long-running experiment, then maybe we need a flow that keeps a running branch on the upstream, where at least one of the committers is engaged to review and handle pull reqs to that branch.
This line overflows to the next line and doesn't look good in its container box. Can you change that and improve the look?
~~~
(例 file:/path/to/job/options/optA.json).
~~~

~~~
(例 `file:/path/to/job/options/optA.json`).
~~~
okay. wait is a Ember method?
Should this be: "The maximum number of results to return"?
We don't stop the tag identifier.
You've a typo here, this maybe should be `'SassTemplate' => array('scss', 'sass'),`.
Perhaps we should check if the talk was actually removed? (Similar to how we check the talk was actually added.)
Make sure this is correct.
You can drop the `else` since you `return`ed with the previous condition.
s/into//
Gotcha, yeah I think a --quiet that makes it virtually silent would be a really good option to have.  My comment wasn't about the option itself, more-so the help text and functionality.
I tried your suggestion but it confirmed my initial suspicion that not every client might be sending a list. In fact, the constructor itself was converting changes into a tuple, so not even the clone() method within this class was working correctly.
I removed the conversion to allow the in-place sorting, and just in case someone out there is sending a tuple, I'm converting it into a list before sorting it.
Let me know if you think this enhancement is worth that risk.
Changed to Jareds cb_info.get proposal.
It's not possible to build for platform=None, a value must be specified. 
How can I handle such misconfig?
s/sever/serve
why not using ``$this->packages[$package->getUniqueName()] = $package;`` ? I find it more readable than using += for arrays (which is never used in the codebase AFAIK)
do you really need the extra parenthesis?
derp, nevermind
Well, we will have to ask @etirelli. But AFAIK, the expected behavior here is that only 'rule1-modify' gets executed.
don't define the <version>, it's already inherited from droolsjbpm-parent pom
Here's what I'm getting:

https://gist.github.com/442ae2b1f522486c5eec
@NARKOZ  maybe better move it to libs?
We don't use short form.
No, modules will be available with an `id` matching a keys you've used. In SDK we just prefix such modules with `@` character to make it clear that these are special. Although we hope to minimize / get rid of such modules.
In fact it will be following:

```
resources://modules/sdk/chrome.js
resources://modules/@loader/unload.js
resources://modules/@loader/options.js
```

but it's not really relevant I guess. 

> Is there any usecase of modules Loader argument where we are going to generate URL for existing files?
> I'd just use invalid URLS instead: chrome, @loader/unload, ...

The main reason to do this here is to avoid ugly checks I've being doing in `resolve` function that was looking into modules first and then doing resolution. Not to say that in that case resolve had to have reference to `modules` which was awkward. This way resolving here an at load will
resolve to same URL so no additional checks are required there.
Ah ok, pulling out...
I lowered the range to allow us to continue to work on travis-ci, which is still at 0.8.11.

My view is that package.json expresses the node.js version you must have to develop on the software, while browserid.spec defines the precise version we'll use in production.  It does mean we're expressing ranges in two places, but this isn't us repeating ourselves because the ranges *mean* different things.
All this setup stuff is orthogonal to what you are testing, and can use lib/secondary.js - not a merge blocker
This needs a `.distinct()` added, otherwise you'll get duplicate project names listed if any project has multiple datasets. Of course this comment isn't relevant if you rework this method to use just a single query - in that case you just need to make the list of project names for each batch type a set so that dupes can't occur).
The objectstore_error_report management command was updated and it now uses the objectstore_stats methods.  Not all of them are used by mgmt commands yet.  Not sure if this management command is useful if we have the webservice methods for the same info.  What do you think?
Renamed as suggested.
Just pass the error message with glwtErrorPrintf and return an error code, do not trigger funny side effects like this.
TBH. Should be:

```php
$score = $this->em->getRepository('Knp\Bundle\KnpBundlesBundle\Entity\Score')
    ->findOneBy(array(
        ...
    ))
;
```
@NinjaZidane wrote that code i believe...
This path is till incorrect. If you are loading that record locally the image would still not be displayed. I think you should keep it relative to record.html in src/main/webapp/html
Why not use `loadAll` here?
yeah i was thinking about the same .. might indeed be better to introduce a specific exception.
You can probably do something like this with simple forms `error_notification` method. Take a look.
You mean using this:
  S="${WORKDIR}/${My_PN}${PV}-${_arch}"
  _destination=/opt/${My_PN}
  cd ${WORKDIR}
  dodir `dirname ${_destination}`
  cp -a ${S} ${D}${_destination}
?
Basically, reverting 1c3745a?


On Mon, Apr 30, 2012 at 12:22 PM, jlec <
reply@reply.github.com
> wrote:

> > +
> > +RDEPEND="virtual/libstdc++"
> > +DEPEND="${RDEPEND}"
> > +
> > +RESTRICT="mirror strip"
> > +
> > +_dest_folder=/opt
> > +_destination=${_dest_folder}/${My_PN}
> > +
> > +_extracted_folder=${My_PN}${PV}-${_arch}
> > +S="${WORKDIR}/${_extracted_folder}"
> > +
> > +src_install() {
> > +    insinto ${_dest_folder}
> > +    doins -r ${S}
> > +     mv ${D}${_dest_folder}/${_extracted_folder} ${D}/${_destination}
>
> You are right about this one. Your approach before was much better.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/gentoo-science/sci/pull/3/files#r751480
>
True, cleaner, done.
split into multiple lines (e.g. 100-char max width or somesuch)
Woops indeed, fixed!
Sande has recently aligned all the quickstart readmes. Could you take a look at that, and bring this one itno line as well?
We'll have to be careful regarding dependency conflicts with Pig for example. I'd like to keep the dependencies to a bare minimum especially in the modules that everything is going to depend on
this would not be an ioexception at that point
Also, glDeleteShader is void, and should not return anything.
Ya, it's a bit of a hack.  This function is only used on the search page right now.  I need to perform those checks, so maybe I could move it into a search helper, so it's not considered a base helper.
Oh, you're totally right about not needing the `\`. Oh well.
oooo this is a cool statement
Ok, that all makes sense—thanks for the explanation :)

Could I ask one favor? Do you mind adding this explanation as a comment over th readyState >= 1 line, for future reference—thanks!
Should be _io_encoding, right?
The file is on the main repo and is useless. Shouldn't we delete it?

On Wed, Sep 26, 2012 at 12:20 AM, Zaiste! <notifications@github.com> wrote:
>
> In .sparkleshare:
>
> > @@ -1 +0,0 @@
> > -69ce402f86963a6128becc68163ec1fdce61083e
>
> @albanlv please, remove this file from the pull request
>
> —
> Reply to this email directly or view it on GitHub.
Hey Scott, I'm sorry, but this IMO isn't a good idea -- we will get flagged as spam for sure. 

I suggest as a quick first-pass solution, just go with the first collection on the work, send the notification for that, and call it a day. The only effect is the cosmetic one of seeing the collection header, so it's IMO not worth both the added expense and overhead of sending multiple emails, and the guaranteed annoyance of users. 

A larger fix would be collecting all the collection ids into an array, passing that, and then iterating over the names to send a notification saying in the collections "X Y Z" etc. But really, nearly all gifts are going to be posted (at least initially) into a single collection anyway. So I think it's kind of not worth the extra work to do that larger fix, at least not now.
It's better to use Hash structure instead of Array to `calls` to speed things up
hmm.. why?
Don't need this if statement either.
Yeah, its the one i used in the bookviewer to display mods there.  It has css classes on the different elements (e.g. top level, vs second level) so it can be styled, but im not sure where the css would have to go
nit: space after //
`ValidatorError` should always be returned regardless of number of errors. We should probably just modify it to accept multiple errors instead of creating a new type.
Avoid importing the implementation, see comment below
You are correct, I will lock down access to `self._future`
Thanks, I will return the sprite. Just didn't come to it during the development stage.
название могло бы содержать слово вершина, что хоть что-то отражать
лучше структуру для вершины целиком
Agreed, removed in newest commit.
we should also change the litmus if we are making this change
Heh, that can be read wrong. :P I'm not a fan of conditional logic in tests.
Seems like the return structure should be a sorted-set, as no duplicates are allowed, correct?
I doubt we'll have something like `foo.jssssss` in Refinery and `admin.jssssss` wont match files like admin.js.
Do you just mean I should wrap the documentation in `[ .. ]` ? same with all the `additionalOptions` properties, right?
That's because we don't have a way to "download" a file in the unit tests yet.
That said, I think I can get the root dir from the config API, append the uri and open the file directly, rather than downloading it. WDYT?
err and revision should be between [] as well.
Added a check for the body and level as well.
I think the Resource model isn't used in this file.
The documentation for field can be removed. I'll go ahead and do this.
Wouldn't this use the memberOf function?
These optional parameters can be wrapped up into an optional object.
Any objections to the name change?
can be removed. No need for an empty default constructor.
changed this, but not sure whether it makes sense ... you could want to use this to have an extra query parameter with your generated url ...
oh you mean that class i see now, so all has to be updated  as well? I thought i just have to update this one class
Абсолютно лишняя проверка, не которая ничего полезного не сделает, так как в подавляющем большинстве случаев — массивы будут различаться, так что это — лишний проход
На мой взгляд, было бы лучше вынести размер массива в константу класса и обращаться во всех циклах уже к ней.
А это, по-вашему, что:

`self = [super init]`?

Это и есть вызов родительского init в перезагруженном собвстенном init
Я поначалу делал цикл, в котором в NSMutableIndexSet заносил использованные индексы. О самом классе узнал из документации.
А не проще взять i-й элемент arrayOfChars, а не вырезать подстроку длиной в один символ? Если так делается для безопасности, то все равно это никак в дальнейшем коде не обрабатывается.
You should handle this AUTOMATED_TESTS_ENGINE_ON constant in the same way as the other ones. Perhaps it would work here, but it's more explicit to do something like:

def is_test_engine_on?
  if defined(? AUTOMATED_TESTS_ENGINE_ON) && AUTOMATED_TESTS_ENGINE_ON == true
    return true
  else
    return false
  end
end

Then use

def something_else
  if is_test_engine_on? && defined? CONSTANT_SOMETHING)
    # something here
  end
end

You get the idea. Consider some user setting AUTOMATED_TESTS_ENGINE_ON = 10. The above would just ignore it. Your implementation would treat it as true I believe.
Fixed this up.
Same concept applies here for phpDoc2 syntax
Looks like it's only limited by what you have in: show variables like 'max_allowed_packet'
Maybe should check this variable and create statements based on that.