labofsahil/github-event-dataset-2012 huggingface dataset:
Yeah, he can be in any number of rooms, as defined by the HUBOT_CAMPFIRE_ROOMS environment variable.

I did some quick checking if there was an easy hubot way to see who is in a room, but it doesn't look like it. The next best thing would be to use the campfire api to see the users in the room. Some starting points:

* https://github.com/github/hubot/blob/master/src/adapters/campfire.coffee#L94-L99
* https://github.com/37signals/campfire-api/blob/master/sections/rooms.md#get-room

A problem there is that kind of couples it to the Campfire adapter. Maybe there needs to be a `robot.usersForRoom(roomId)`?
I don't think there is anything different between the gplus_video and the picasa_video json input?
Yes, makes sense, was more a mater of convenience to use bunch to see
whether it works, but named tuple, in this case makes even more sense. Next
time one of the related APIs changes we can add fields.
Please put 'parsedBody.news[i].title' in a var as it is used more than once
You are right, in this case it doesn't make any difference, as you said it's only using it as a default value, and not performing any operations on the list.
Remove all the marketing content styling. No longer need.
I had created this file earlier to test url.open connection to use the file:/// protocol instead of the http:// protocol so that I could mock the url openconnection call. This is not needed anymore will take this off in my next commit
This comment is no longer correct...
"crob" should be "cron"
Level-0 remark : add a prefix to enum or constants (like _9P_FLUSH_BUCKETS) if value is specific to 9P.
We don't need this commit. It makes sense now, but probably won't in 2 weeks. :)
That looks good to me, however I think you should pull this method up to the `WithHeaders` trait.
I'll have to look at that, the cpk code does not back port fixes, I neglected to realize that oracle enhanced does.
All other rules which are part of PSR-2 have already been removed by @fabpot a few days ago.
Why did this return from the dead?
i think we are good here. any others that you spotted?
You should normally try to not produce such empty line modifications.  Usually, such things are fixed in separate, catch-all clean-up commits.
ты уверен? Как-то уебищно выглядит
should `.block.intro`
Tenés razón, gracias. El resto está ok por mí, ahora sale merge.
Oops, that [] is a mistake.  It was meant to simply utilize the existing function as a positive test.
```php
$app['url_generator']->generate('login_forgot_password', array('toen' => $token));
```
 (k) of token is missing and to generate absolute URL you can pass true as third argument

```php
$app['url_generator']->generate('login_forgot_password', array('token' => $token), true);
```
Yes, that's definately better.

What about putting a -synchronization call in -clear and -applicationWillTerminate: to make sure the value isn't lost?
We use translateable="false" only in values/strings.xml
this is the line @neilmiddleton is talking about use:

```
@user = current_user
```

instead
Interesting. Thanks for pointing this out. I wonder why this hasn't failed for me. I'll fix it soon enough.
This code is mirroring what you wrote in the `Book` model. You could instead call that `search()` method that you wrote. You can replace this entire if/else conditional with 

```ruby
@books = Book.search(params[:search)
```
Hi, thanks a lot for the changes! 
Do we really need to add a dependency to bullet here? Shouldn't that be brought in by tf?
Best, Markus
This is what worries me most in your patch. I wasn’t aware of the .textContent / .innerText thing.
No, because in the `get_keyword` method above, we used to access data using sometimes a symbol and sometimes a string. Using the approach of the patch, we use only strings everywhere.
do u have to pass this in if the instance has the reference to self.errors? i understand for readability sake, but im not sure this is entirely necessary, right?
Missing @LogMessage annotation, is this intentional?
Mircea, If we use Util which I do not mind then users cannot (in that extreme case they might want to) customize the  exception root cause finding algorithm
I think this logic is right because:
- tx.getRemoteLocksAcquired().isEmpty  means that the transaction hasn't left the node. I.e. it hasn't prepared not send a lock acquisition command remotely (remoteLocksAcquired  gets populated IFF the transaction prepares remotely or a remote lock is acquired)
- so we don't send as part of the state transfer a *local* transaction that hasn't left the node yet. This transaction will be correctly sent remotely when it needs to, i.e. when it will prepare or when it will try to acquire a lock. What's the point in sending it as part of the state transfer?
Very odd… seems I moved the submodule pointer at some stage. No idea why or how. But I've just placed it back to where it is on `master` and things are much happier. Will update the signatures accordingly.
I was trying to avoid any types outside of your friendly neighbourhood cocoa. It's not like we are really concerned about space usage and proper documentation (when added) will provide plenty of information about what it's function is.
I would not go so far as to say it is absolutely essential, but it seems like the best course of action is to fully support plotting np.histogram2d, with all its kwargs as they are, and further it seems like this can be done very easily using pcolorfast.
It is the default, so I used that fact.
Set up your editor to strip trailing white spaces.
can we split this find elements on 2 lines
Do we have a bug tracking this? cc @malini
There's an extra space after `content:`.
"incase" -> "in case"... or rather, just "if"

"has been" -> "was"
For `longs` and `t-stats`, we're just replacing any `nil` values with `nodata`.
@dooremont shouldn't this be `non`?
this should not be included in a header file but in the .cpp
also, I think std classes should be avoided
and use SG_ADD here...
Done, didn't know about that earlier. :)
I would use the the Ruby-provided `block_given?` and `yield`.  According to http://stackoverflow.com/questions/1410160/ruby-proccall-vs-yield, it's twice as fast.
A wrapper would suffice and satisfy my expectations. Also we have this `before_filter` concept on the database which would still work.

I'm going to make a refactoring within this branch.
Can we get rid of this horrible output buffer mess?
* At minimum: append the output to a variable and return that.
* Better: Build an array of data and use the built in fputcsv() function (http://www.php.net/manual/en/function.fputcsv.php)..
this works with a file pointer, but you can use something like php://temp (http://www.php.net/manual/en/wrappers.php.php)
actually that's the main reason, and jquery's is 13.
+1ms for luck.
you track a list of urls, but don't distingush between bind and connect.  Is there a reason to track them, and if so, should they be tracked separately?
Are you sure that the method "getConnection()" exists?
That's the second image that is not available from the server.  Please let appcelerator know and ask if we should use a different url.  This likely affects all platforms running KS
Ich habe die Umlaute bei den Tags und den Usernames entfernt. Beide werden als Identifier für die Resource verwendet und darum in der URI verwendet. Bei den Usernames macht das sind finde ich, hab ich mit Chrigi auch schon besprochen (der Username hat folgender Voraussetuzungen "\w{3,}). Beim Tag macht das allerdings wenig Sinn, da müssen wir einen neuen Identifier einführen.
Nice(r).  +1.
Probably you want to use [Date.parse](https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Date/parse)?
So she is prevented to enter any text for 10 seconds (at worst)? Users will see her posting, but not yet as logged in.
It is by default, but you could pass user to this tag and get it's image.
Do we want to do a message, that registration was successful? We do! ;-)
Hmm. ;-)
This is not correct. Where you mark the notification user just read as read? You have to set this before you count. :-) So in callback from request, you set read to true in data/notification object, and then you count what is the new number.
Move this to `UserCurrentPasswordForm`. It is there where is needed. And then you will not have to repeat it. And also all code will be together.
Cool - that's done now.
Can this be filled in with some real data so that the test actually tests something?
country code instead of currency codes?
Mistaken what? I didn't change the code in any way. As mentioned, I only made a pull request so it can be adapted and pushed quickly. I do not possess too much knowledge about Cpp.
make that array static
The `TestController` constant should be defined before `::ActionView::TestCase::Behavior` is included.
voui tu as raison
identify firmware version you tested on (this, and all the above, is indicated in developer's guide under 'The "adding a new network device module in PacketFence" checklist')
I am not using it, just like we are not using the other ones.  It's there in case of.
They do not include explicitly a link between dbpedia resources and wikipedia webpages in the infobox file (which is the file where Bio2RDF relevant triples are). 

See http://downloads.dbpedia.org/3.8/en/infobox_properties_en.nt.bz2
by watcher or globally ? (imo globally may be better)
Space on the wrong side of the comma.
Switched to `ngx_pstrdup()`.

> Move the header name memory copy part before the value?

If `name` is `"Content-Type"` then we don't need to copy it, but we do still need to copy `value`, so I copy value at the top regardless.
I'm not sure I understand how making ngx_pagespeed not use new/delete would help.  PSOL is full of new/delete and is where we'll be allocating most of our memory, so unless we rewrite PSOL to not use new/delete won't our risk of a std::bad_alloc be basically undiminished?
Yeah, I was thinking about this this weekend. I'm going to move a (lazy, cached) check up to the data stuff as part of ticket #423. I was also thinking of moving (lazy) discrete and count regressor checks up to data too, but that's a different PR.
yes it does.  In fact, in the introduction to Owen's Empirical Likelihood, he plots the confidence region for Skewness and Kurtosis of number of segments on an earthworm, which he shows is clearly not normally distributed.
I don't see any unit tests for the kernel functions themselves.
residue from prior version. removed.
I don't know about the convolution version, but if I understand correctly, the cdf can be obtained from

```
class gamma_gen(rv_continuous):

def _cdf(self, x, a):
        return special.gammainc(a, x)
```
Hashtag entities are under .hashtags property, but each entity has .text property to store the hashtag value, and only hashtag entity has .text property.

E.g.,

    "hashtags": [
      {
        "text": "devnestSF"
        "indices": [
          6,
          16
        ]
      }
    ]
I will check if is possible to configure the results based on the location and I will get back to you with my findings.
ну да.
I can do that.  It seemed short enough not to bother, but I see your point.
Could add here that the Image must not be `None`.
Getting rid of it now
is_storage_local().  Boo on hungarian.
No it is not necessary - if you think M:N is an acceptable way to handle it I can do it that way; problem with providing a pool size of "10" could be that if you have a four node list (or larger) - that's 40 connections if the default pool_size isn't changed. Which isn't bad per-se but that many connections seems like over-kill to me?

Maybe I'm being too conservative with that...
On second thought, it's probably a lot cleaner to do this:

```
Help.help(parser.getMetadata(), ImmutableList.of("brooklyn"),help);
help.append("See 'brooklyn help <command>' for more information on a specific command.");
```

Will update this in the next commit.
Seems strange to use a variable here.  It might be more clear to just pass a four digit value on line 124 and use the same here.
bah ca m'arrangereait que tu fasses comme the economist alors :P
Just a quick FYI, but `onready` is undocumented / deprecated. It'll be replaced by `onmatch` as per mozilla/browserid#2648 some time next month. We'll probably shoot for dropping `onready` altogether ~3 months after `onmatch` goes live.
Ah, nvm, you mean for this to be a different line. Can you make it 80 char? (all of bloom is this way)
would recommend vehicle code to be updated with webinos/test/client/image..
please add the comma to avoid unnecessary changes in the diff when adding a new element in the array
i find it easier to add the line to config myself /shrug
Э, зачем все это пееписывать на питон?
use 'should' here as well. For example, shouldReturnOneForOne
Looks like the constructor below is never used.
No, it's used all the time, just not in any tests in the project (see todo app)
Ah! You are correct. My change in line 197 is not needed. I just tested this out and works without it.
This section should probably lead saying this is disabled in PHP 5.4. We're trying to suggest people use the latest versions, so at least 5.3 and 5.4. That probably means we should avoid giving people advice about PHP 4.x, but if we DO lead clearly along the lines of "this is not a problem anymore, but used to be".
То, что можно "падать и валить" - это поблажка. Работа со стримами должна вестись корректно, как если бы этот код был частью другой большой программы, которая не должна падать, если что-то там не так в одном из её модулей (точнее, сама программа должна решать, в зависимости от типа исключения и т.п.).
Без удаления этого файла мёржить не буду.
space before and after !=
Makes sense - your suggestion of 'clearStaticEnv' sounds good to me.
This expression always return true because sfp[n].asObject is NonNullable.
You should use Assert.equal instead of true, because it's more suitable in this context.
Need Info: Why the default value? Just curious.
@amueller AFAIK you're right, you can't get independent iterators like yield gives you without another class. If this is, in your judgement, a pain, then leave it for later / never.
Maybe the message could be further improved by giving more information on "where" it stopped, either in terms of number of iterations on the path, value of alpha, or condition number of the subproblem.
There's no input validation here. Also, with `safe_sparse_dot`, sparse matrix input can be supported trivially.
Добавил описание и пример без getUrl()
We need to check both, because it seems Apache (which most of the time we've been using) sets all variables inside `$_SERVER` as environment variables, too. Not sure if other webservers / SAPIs do this, too.

The PHP manual states:
* $_SERVER — Server and execution environment information
* $_ENV — Environment variables

See http://php.net/manual/en/reserved.variables.php
shlex is not used
use options.ndk instead

should also be decoded
Where's the signature of this constructor? I didn't find anything like that...
Strictly speaking I think size32_t is the type of the size/count fields.
I had been thinking that the function would be called multiple times(with different values of version)  if there were multiple extra pieces of information.

Otherwise a newer version calling an older version wouldn't work (since the extra information needs to go on the end so it can be ignored).
This should be subtracting off PackedFixedSizeHeaplet::chinkheaderSize!
slightly odd spacing around '='
still slightly odd spacing around expression and one below too (line 475)
I think this needs a critical section - otherwise the number of commitable rows might change.
More problematic rows might be reallocated while the sort is occurring.
Should be hugeMemorySize
Note that, after a run(), "file" will NOT be named after "logicalname" here, but after "newName". Thus, the need to re-calculate it here.
Hmm I copied this from the old site, is it not working in Selenium?
Yes. Totally agree.
Then it should be commented maybe.
Fair enough - updated to use regular expressions.
These links don't work. Looks like you need a space after `]:`.
I think this needs to handle normalizing self.path
Just "Author" -- classnames in annotations are resolved based on the current namespace and/or import statements.
There's error checking further down the road.
Does not look to be used.
Yeah. I'll just remove that before pushing it in.  Thanks for reviewing.
I think it's the moment to say something about what a collaborator can expect from the review process. I think mainly:

* His pull request is merged and closed.
* His pull request is rejected and closed.
* He is asked to make changes => the collaborator can update the same branch in his repo and changes will be updated in the pull request
* He is asked to accept changes from a r7 person => the collaborator will need to land a pull request in his forked repo and branch in order to see the "original" pull request updated.
The Author format must be fixed:

<pre>
['Dhiru Kholia <dhiru[at]openwall.com>']
</pre>
.flatten? Are you expecting more than one fault string? If so, more appropriate ways of doing this exist.
I'm worried that this doesn't check for when people have a default value of false (e.g. boolean columns) but don't set an explicit `@default_value`. In those cases, `value` would be false, making this fail incorrectly.

What about this instead?

```ruby
if @default_value.nil?  # test is just checking for any default value
  # Assume that people don't set NULL as a default value.  
  value != nil
else
  # Otherwise, check that the actual value and the expected value are the same.
  value == @default_value
end
```
Need to figure out a convention to refer to other widgets. On the wiki we use uppercase widget names, e.g. "Using the Position utility".
Added in 200 response check
Sounds good, I'll change it to startRenderLoop.
That's fine by me, if we ever see it in the profiler, we can address the issue then.
Right. When I found dat.gui was not flexible enough, I once considered using other library, but gave up because I thought that was of low priority, plus you are much better in designing GUI than me:)
Why are you removing comments?
notification not needed here. Will automatically happen in firePropertyChanges
Don't need this block at all. JS will automatically get `valueForUndefinedKey`
This is kind of confusing...
Many of these props are not supported in Android.
Didn't you mean null !== $channnelId ?
Apologies for not adding the new information to the README. Thanks for filling this in @jtimberman and for doing it much more eloquently than I would have!
I proposed adding popFrontExactly in the message boards, but did not get any feedback. I may get to formalizing it, but I have a few too many requests right now...
Now to be pedantic it can't work as you are converting const struct to mutable. 
If we are to fix anything here it should be inout(ByCodepoint) save() inout { return this; }

And a minor unittest that it at least compiles ..
Variable names should be `likeThis`. The first letter is lowercase, the first letter of any other words are uppercase, and all the other letters are lowercase. I really think that it's better to do `_vPrime` and `newVPrime`. The capitalization of `_Vprime` is backwards. If they were public variables, then they'd definitely have to be changed. As they're not, it's probably getting too picky to absolutely insist that they be `_vPrime` and `newVPrime`. Having `S` and `V` though definitely can't stay, because they're captilized like type names, which makes reading the code much harder.
Just noticed that in http://d.puremagic.com/test-results/pull-history.ghtml?projectid=3&pullid=748.
There are some other functions in std.range that are using `ulong` however which mislead me.
Was committing the patch as you posted this.
Oooooh whoops. I thought it was in the right brackets. Thanks :)
:) I didn't like "Generic..." either, got rid of it.
this comment is great. might be worth creating a README file on disk though, including information about the Dartium flags to run it.
I can't figure out why, but this line is getting echoed twice during the build output, like this:

       [success] Total time: 1 s, completed May 3, 2012 7:12:49 PM
-----> Dropping ivy cache from the slug
-----> Dropping ivy cache from the slug
-----> Discovering process types
some people might be using this in scripts.
It seems like there's a bunch of state that's shared between these calls — issuer, audience, a key pair, etc.

Does it make sense to you to bundle these into a constructed object that exposes assertion/cert/etc. generation?
Excellent! Thank you for the thorough explanation! :)
I have incorrectly tried to fix it for #637 ( I only rolled back his changes, but did not test properly ). I am writing up a review request for my solution to this problem atm.
Yep, listener similiar to a FormatListener should be added (like ContentTypeListener or smthing) with logic similar to the Format one - imho it should be considered as a next issue/pull request :-P
Al: we're not doing single-line definitions in general, we prefer a more readable, whitespace-driven code style for a lot of this kind of thing.

Also, in my experience, it's very rare to see single-line *methods* even when they are so short. (This is not a property)
I agree with the above. I think version bumps should not be included in pull requests.

Let's make a decision on this, and get everyone on board with the same workflow!
The big change here is that we're including scenario ID.  This will be passed down to the steps so that we can lookup info per scenario.  I am planning to use this in the future.
ah yes, forgot to mention - the user facing lingo is always using single noun - "activity" while in backend we have facts and activities
Is it possible to add a @param annotation for parameter ``$values`` which defines the array type; using "array<SomeType>", or "SomeType[]"? This would help me, and IDEs to better understand your code.
from campfire discussion: reminder to change `sha1` to `sha1sum`
This can be abbreviated as `[noteData valueForKeyPath:@"subject.icon"]`. The downside is that instead of returning nil if the path is invalid, it'll throw a `NSUnknownKeyException`
Ok, I tried to clarify.  Hopefully this is better.
Excellent. Thanks @bartvde.
Again, this shouldn't be done in corev1.css. It should only happen in htmlblock and tinyMCE, so please move the CSS over there.
Maybe we'll name it StatusArchive? It's not so ugly as StatusArch, but not confusing too...
Also, the BannerInfo has its "official" StatusArchive too.
should be ``import_data``
The only asserts here should be on `self.model.Case.objects.count()`, `result.num_cases`, and the warning.
overrideExiting -> overrideExisting
setMessage __Row__ Mapper()
Then I'd recommend changing the message to say "does not take advantage of optimized correlation" or something. My main point is that it's not "using optimized-correlation without caching" that *degrades* performance.
Yeah, i wasnt modifying this, but you are right. will fix.
Why did you make user_id required?
I really don't like this sound!
add a "the" before "request"
put that at the same level as "urls" (i.e., all the way to the left)
@christianv If we're only going to have one mention of the "Sakai OAE release page" be linked, it should be the first time that it's mentioned.
@christianv I think we should update this link as a result of https://jira.sakaiproject.org/browse/OAEWDGT-186
@dbu: i didnt want to change the template inside SimpleCmsBundle to prevent making CreateBundle a required dependency ..
I think we can drop the TODO; if someone else wants this they can submit a PR for it.
Yeah, doing this type of debugging in your own branch of the gem is probably on ok way.  You should be able to do sufficient testing in your app without doing this however.
Let's discuss this.  I'm actually not sure I understand what is being recommended here.

For the issue regarding dropping a line, I think I've done the same thing here that was done on line 100 above so want to confirm what is correct here.

Regarding waterfalling functions too much, for this code block I had a hard time figuring out a way to define functions that would be invoked as success callback for the plugin functions.  The challenge is that the functions need access to variables not defined in the callback interfaces expected by the plugin.  But I'm new to JS so I'm sure there is a better way to do this.

So let's discuss.  Or if you can provide a specific recommendation (in code), that would help me to understand and learn.
Ok! I will change it
There is no sorting going on in EmbeddedSortedListField. It really should have been called EmbeddedIndexedListField, the "Sorted" part of the name is very misleading. In fact, I would recommend renaming EmbeddedSortedListField to EmbeddedIndexedListField, then defining EmbeddedSortedListField as a subclass EmbeddedIndexedListField and documenting it as deprecated.

In any case, no sorting ever happens, just indexing. So whatever index is assigned here will remain the same when the list is retrieved.
I would prefer a more meaningful Exception than IllegalStateException... why not throw an IOException? The caller then knows what to expect...
moved the creation of new corpus's session and data list into the corpus where it belongs.
You are missing the pointy brackets <> around _PARAMETER_INDEX_
Is this true? I would have thought that the creator would have been set as "anonymous" in the FOXML.
I am worried that this will not pickle.
it should follow same convention, add spaces `if (is_string($id)) {` same convention is all over the code
이거 맞네요~!!!!
I'd like to remove the comment explaining what the matcher means. What can we rename this matcher such that this is possible?

    it { should have_a_default_of(0).for(:count) }
    it { should default_to(0).on_the(:count).column }
    its(:count) { should default_to(0) }

?
Good question. stop() should stop the loading of the WebView and the contents should remain in the same state as when stop() was called. Since stop() on mobileweb is unreliable, we added a "hardStop" that *destroys* the entire WebView (i.e. the iframe) leaving a big white area where the WebView is. Not ideal, but a workaround.
Put it inside the if.
Add a constructor for `ClientRecord` that takes all three values. Avoids mutation outside the constructor, which might well allow you to make `ClientRecord`'s fields final… immutability is awesome.
Ah I see. LGTM
Hmm, not only does it not send email with comment update, it doesn't let me reply to the original one.  I think you have a good point about not setting it in the host app, so I am fine with leaving it as is for now.  However, I prefer the look of your second option better, as that uses a rails method instead of creating our own.
Agree, we should edit SN_IM_PRESS_TO_CLOSE too to 'Close chat box'. Why is there %s?
How about "when using instrumental_agent with Ruby 1.8.x"

Also, only warn on that condition.