labofsahil/github-event-dataset-2012 huggingface dataset:
Usually this is a good practice to declare the variable close to where it is used. Please move the declaration next to the for ... loop.
Here are the changes to css to include p inside the label properly
The `role=lists` cases a lot of pains for the validation process because all the direct childs should be a `role=listitem` and a `<li>` can not be that, so the only one chance is to use `role=presentation` which is kind of unnecesary.
Also we are providing the selector at that top level for controlling the middle headings w/o extra classnames
This method could be moved to `js/utils.js`, too.
why return here?
What does `1515` means?

Could you please add some comments here?
pageHideBySwipe is true only if the user manually swipes to the right.
if the home button is tapped, pageHideBySwipe will be false.

we use it since both of the actions (swipe and home button) cause the same hashchange event.
why `<h3>` instead of `<h1>`?
why are we using px instead of rem?
Same as previous. I won't be offense by an intermediary variable :)
Anymore than one tag and this should probably be extracted out of the method, but for now this is cool.
Actually, more this:
https://github.com/mozilla/elasticutils/blob/master/elasticutils/__init__.py#L870
I think we should be passing `'0.4'` to the version checker, not `'0.4.2'`.  That argument is meant to be the max warning-free minor version.  I generally assume that patch releases won't break compatibility but, for projects that have not adopted SemVer, minor releases might--so I'd want VCR to not print a warning when 0.4.3, 0.4.4, etc come out, but I do want it to print a warning for 0.5 since that will potentially break compatibility and I obviously don't know for sure if it'll automatically work.
I removed the postgres test-case and refactored the original to work 
with whatever plug-in that is currently configured.

On 2012-10-24 18:32, Daniel Pittman wrote:
>
> In spec/persist/rz_persist_postgres_controller_spec.rb:
>
> > +    it "should see the last update to a Model in the collection and version number should be 3" do
> > +      model_hash_array = @persist.object_hash_get_all(:model)
> > +      model_hash_array.should keys_with_values_count_equals({"@uuid" => @model1.uuid , "@name" => "rspec_modelname03", "@version" => 3},1)
> > +    end
> > +    it "should return a array of Models from the Model collection without duplicates" do
> > +      model_hash_array = @persist.object_hash_get_all(:model)
> > +      model_hash_array.should keys_with_values_count_equals({"@uuid" => @model1.uuid },1)
> > +    end
> > +    it "should remove a Model from the Model collection" do
> > +      @persist.object_hash_remove(@model3.to_hash, :model).should == true # should get positive return
> > +      model_hash_array = @persist.object_hash_get_all(:model)
> > +      model_hash_array.should keys_with_values_count_equals({"@uuid" => @model1.uuid },0)
> > +    end
> > +  end
> > +
> > +  #describe ".Policy" do
>
> Dead code like this shouldn't make it into a pull request.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/puppetlabs/Razor/pull/224/files#r1930571>.
>
`else if` should be on the same line (or different - I prefer same, but just so its consistent with the one above).
我不打明白你什么意思？
We shouldn´t need `get` here.. you neither use it in line 64 and in the `Recordable` mixin ..
This could be one line:

`@set 'isLastRunNewHighscore', time is @raceTime`
Can't we use MD5 here until we find an implementation of murmur128 that doesn't pull in all of guava?
actually, we might want Option[Manifest[T]] since we can't get the Manifest from a cascading field, and as such this method would prevent us from being able to go from cascading Fields -> List[Field] which is something we probably want to be able to do.
That's weird! I've tried it again today and couldn't reproduce it either... So for now I would suggest we remove the filtering and I will provide another patch if the problem ever occures again.
`if (inline) {`
Rename this - doesn't it collide with the `sys` library you imported?
That's really hardcoded -- why do we need this?
Humm - Well, It's certainly possible I've made a mistake somewhere!

But - I'm fairly confident `validate_ref` was being called before `_schema` was set.

I'll re-check as soon as I can today
nono, temporary or not is fine,  all I meant was maybe expand it out a little, so it's more obvious at a glance, like this:

<pre><code>int_l_zero = int(l[0])
int_l_one = int(l[1])
int_l_two = int(l[2])
ret_one = float( ret[int_l_one] )
ret_two = float( ret[int_l_two] )
ret[int_l_zero] = ret_one / ret_two
</code></pre>

Another option I've used when forced to deal with lists of lists and cross-references, is to instead use a single list of dicts with descriptive keys (who's values could be lists).  Then readers benefit from seeing descriptive dict. key names instead of index numbers.

Finally, yet another option is to just comment the heck out of it.  Then the code can be as complicated as you like :D
The start() method already declares that it throws Exception.  There's no need to catch and throw a RuntimeException here.
OK, that should be fine then.
Ah, I think I'm answering a different question.  This is already unicode-safe.  All strings in the database are unicode.  So you have have a builder named "الأسد التصحيح" without any difficulty.

In fact, this is such a strong requirement that it causes discomfort in a few places where we deal with bytestrings without encodings involved or, worse, with multiple encodings.  Specifically, filenames (e.g., in changes) and logfiles (gcc loves to spit out smart quotes) are going to be tricky.  Under the new system, we can't just pass these along to the buildbot outputs and let those make a best effort at rendering.  We have to convert filenames and logfiles to unicode before they go into the DB or get transmitted in data API messages.
What's the usecase for subviews then? Just in a CollectionView?
Concurrency should probably be an option.
Hi Ming, sorry, I'm cloning on windows now.  It's a C99 initialization.  Whoops.
`$operation->getJobType() === 'install'`
Could it be possible for a CompositeRepository to contain another CompositeRepository ? If yes, the inner one will not benefit from the StreamableRepositoryInterface for its repositories.
I did wanted to do it, but I couldn't find a profile for it in our maven build. If you can point me to it I'll gladly add the needed logic in this script.
these seem to have gotten moved around unnecessarily
Seems like a Github bug. 

Need to use diff view .
A bit unorthodox here with the `""`. Have a no arg constructor.
Is this because we can't detect articles from URLs?
How about:

```
when /(http[^\s]+)/
when /(git@[^\s]+)/
```

It should do the same thing but be less concerned with validating the url. Make sense?
What about using htp_config_flags ? not too long and really explicit.
So blank lines are supposed to be blank, not tabbed out to the indent level?
このコメントいらないよね？
I will try to submit patch that would refactor parts of loader out in a similar way you've suggested. I'd rather see this change land on top of that one.
Should we really try to provision anyways? That seems unfortunate if we know we don't need to. But I guess we can fix that later.
I like that this shows a user visible error if returnTo is not allowable.  this seems a reasonable way to surface the error to devs.
this line is missing a close paren.
This looks like something that was left in by accident. I don't think it should be here.
Sorry, the comment was not totally clear for me. I guess the first line says it all, I'd drop the second one: To me it sounds like the parse() function did some kind of initialization of the parser.
This comment should move to before the method (like an rdoc comment).
``RLIMIT_NPROC`` doesn't really work for me, since it limits the number of forked processes, but then trying to fork off another kernel hangs. AFAIK this is because when ``RLIMIT_NPROC`` is reached, the process group isn't actually killed, an OSError just occurs on subsequent calls to ``fork()``, so when the resource limits are applied to another kernel, things hang since the processes share the same real user ID (``RLIMIT_NPROC`` limits the number of threads that can be created by the process's real user ID), and there are already the max number of processes running for that ID. I'm not really sure of a good way to get around this, since changing the user ID generally requires permissions we don't want to give to the untrusted process.

Also, some other resource limits (especially those relating to files), also don't cause the process to be killed, just another OS or IO error to be returned from the kernel. Only ``RLIMIT_CPU`` and ``RLIMIT_AS`` have actually killed off the process for me.

I think the following changes would be good:

* Have only ``RLIMIT_CPU`` and ``RLIMIT_AS`` by default, and have good documentation about what the default values mean, e.g. ::

```
"resource_limits": {
  "RLIMIT_CPU": 30, # CPU time in seconds
  "RLIMIT_AS": 1024*(2**20), # Maximum address space in bytes; this sets 1024 MB
}
``` 



* Add a documentation note about ``RLIMIT_NPROC`` not working
* Add a documentation note about other resource limits working, but not killing off the offending process
This will cause your reap task to deadlock as you're not communicating before existing, and you're expecting `lim` communications from all goroutines.
`~> 1.2.0` would be great, but I think using the twiddle-waka ignores release candidates.
haha...I see your point. Updated :)
`è leggero` -> `è di poco rilevante impatto` 
`forzando` -> `forza`
You should use single quotes (or apostrophe) here
The `MvcEvent` has the current response object -- if the controller returned one, then that's what will be in the Event at this point. As such, instead of setting the `Response` as a property of the `ResponseSender`, you'd simply pass it as an **argument** to the `ResponseSender`'s `sendResponse()` method.

I guess my point is: shouldn't a typical `ResponseSender` implementation be able to handle _any_ response type, or at least raise an error if it cannot? And if you will be using a custom type, you could potentially inject the `SendResponseListener` manually with an approriate `ResponseSender`; we could even create a controller plugin and/or application listeners around this.
Yes, I had used the "PHP-CS-Fixer" :)
All `@uses has been removed from the project`
AbstractService have references to this file
Also they need to be exactly `// CraftBukkit start` and `// CraftBukkit end` (note the spacing and capitals) to aid updating (it makes the diffs easier).
It's old text, but yeah, it's better to use "the bundles with top score first"
First, it is not called Configurator but Configuration when following the standard convention.
And second, you are trying to use ``Knp\Bundle\KnpBundlesBundle\Github\Configurator`` here as you access a class in the current namespace
this can't be true, we are not in the FOS\FacebookBundle here
Makes sense, though I suggest adding comments so you don't forget about these things =).
consider making element and toggleElement private for better encapsulation.
e.g.
_element
and 
_toggleElement
Let's make the 1000000 a constant
does it work properly when ``$fromClassName`` is ``null`` ? I don't think this is a valid argument for ``strpos``
you should remove the extra space
Thanks for your comment. It **is** relevant actually, but I have just not processed this file yet.
I understand this can be confusing, but I've fixed the `it's => its` mistakes as a separate commit, that spanned the whole repository, while I work on docblocks on a file-by-file basis.
I'll continue working on the individual files, and when I'll have reviewed all the project, I'll let you know here!
same issues than in XML
Not important. I'll track the change (my rebar_exunit plugin relies on exunit_server)
I don't like that we need to parse the regex here. Can we simply ask the user to pass the users he wants to retrieve? As I said before, just something like:

    Regex.scan(regex, binary, captures: ["Group1", "Group2"])
Then do we want separate SlashemGeoFields for Solr / ES?  This should behave the same for ES / Solr with the current impl.
I would have preferred not to, but if we want draft pages and draft articles I wanted to prevent possible conflicts, make the file structure a little easier to read, etc... by using "drafts/articles/" and "drafts/pages/ for the locations.

If you see my comments on this issue I specifically ask if you guys think I should make some settings to make this configurable. I personally think we should, but I wanted to ask because the draft destination location was hardcoded in the first place so I didn't want to presume and I didn't know if there was a good reason that it was hardcoded to "drafts/" to begin with.

Tonight I will work on two settings DRAFT_PAGES_OUTPUT_PATH, and DRAFT_ARTICLES_OUTPUT_PATH (unless you like different names) and have something to make that configurable.
fix docstring, Tornado, not TBB
drop excessive whitespace
insert empty line (just style)
Doh, no those should go higher, good catch!
Yeah better to do the latter IMO as it's specific to those pages (and that's what a page object is by definition).
No padding around object or array literals:

`p.integrityTest( { start: 2, end: 5 } );` => `p.integrityTest({ start: 2, end: 5 });`
Is it hard to do?
Ya. You're right about that. I had changed it while I was having problems and forgot to undo the note change.
No, I need to change this.
the MockContact is really only to represent an address contact rather than be a method of generating random data.
This can sometimes be problematic. Not a huge deal I suppose, but if the search results contain no matches, then clicking the URL bar icon will throw an error about calling `selectItems` with no items. I have recently been switching to having a function that will return nodes for multiples, which I call from both detectWeb and doWeb to check if there are actually results
This is still broken because it's missing the ```i--``` you added above.
What's the purpose of the code here above? (just for my understanding of the use case for this logic)
In the longer term, though, we may want to split the databases at some
point, so that migrations can be tested on staging first. At that point
we'll also want a script that can copy all the production data into staging
and reset the database, so we've got realistic data that can be used for
testing.

On 6 October 2012 22:58, Skud <notifications@github.com> wrote:

> In config/database.yml:
>
> > @@ -20,4 +20,10 @@ production:
> >    password: thisisnottherealpassword
> >
> >  staging:
> > -  production
> > +  adapter: postgresql
> > +  database: growstuff_prod
>
> No, Cesy and I decided just to point it at the same database for now. This
> seems to be a pretty common configuration, and it's what's suggested in the
> docs we were working from -- when we actually have a real "production"
> server, we'll want people to be able to test the almost-ready-to-deploy
> code against real up to date data. A.
> … <#13a3816448be9d1a_>
> On Sat, Oct 6, 2012 at 10:52 PM, pozorvlak <notifications@github.com>
> wrote: In config/database.yml: > @@ -20,4 +20,10 @@ production: > password:
> thisisnottherealpassword > > staging: > - production > + adapter:
> postgresql > + database: growstuff_prod Shouldn't this be
> "growstuff_staging" or something? — Reply to this email directly or view it
> on GitHub<https://github.com/Growstuff/growstuff/pull/37/files#r1779971>.
>  -- Alex "Skud" Bayley skud@infotrope.net http://infotrope.net/
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Growstuff/growstuff/pull/37/files#r1779980>.
>
>
Another reference to your OpenShift instance.
...and refactor it into a util module since there are now a couple exercises using it
this line needs work too
They were dynamic, so any change in the configuration was applied immediately.
Might I suggest the ternary operator here?
rewriting history!?  sheesh.... i bow down before you.  i did a non-auto merge on another issue (adding the meta viewport)... involved creating a local branch for thematic5, creating a new fork, pulling the changes from my helga fork, then merging to the master and uploading.  we might get the hang of this yet.

on topic: ok, we're agreed. we'll keep as many of the naming conventions as possible from thematic.  #header and #footer being known exceptions because <header id="header"> and <footer id="footer"> are ridiculous.
Should this kind of model querying be in the template layer, or should it get pulled out into a helper?

Also worth noting: I think this will run the query once for every section on the artefact, rather than once per page view.
arrays -> lists
почему ты тип incList называеь с маленькой буквы?
зачем тут слово Type?
гораздо красивее, чем запихнуть все в одну функцию. давай весь код писать в функции в одной
Is there a particular reason why the visibilities are stored as a hash under a `profile`?
This is a special case where a method needs to be used frequently within the API. This way I can just run:

`getAllTenants(...` instead of `module.exports.getAllTenants(...` or maybe `exports.getAllTenants(...`
I sometimes write lines like this using the one-line syntax:

    urllib_debuglevel = 1 if config['log_level'] <= logging.DEBUG else 0
Can you revert this change?
Geocoder support a installation without composer. 
So we need a autoloading without composer.
Extra tab + move `&&` here too.
I thought you said you removed the thread pool witth this pull
Попробуйте написать тест, считающий среднее количество итераций цикла, которое уходит на заполнение массива changed_indexes для percent == 100. У меня получилось примерное 500. В 5 раз больше, чем нужно.)
Ну во-первых, это не переменная, а макрос, и определяя его в этом месте, мы получаем доступ к нему из любого сорса. Тем самым мы определяем длину ДНК на этапе компиляции.
@lilumi вижу, получается, я мыслями был в другом методе. =) Простите меня. А про throw и NSAssert стоит почитать - это выталкивание ошибки, теоретически поможет программисту, который будет пользоваться вашим классом.
Запись не эквивалентна. В первом случае будет просто целая часть дробного числа, а во втором - округленное число. 
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
Я еще вчера хотел доделать все мелочи, но моя бубунта отказалась грузиться, а заводить ее было лень, ибо после учебы не сильно то мозги уже работали.
(this convo continued offline, FYI...)
These are the files the tools I am using dump with the code... not really needed or helpful to anyone else... lets keep them from coming upstream
Good point.  I didn't notice that this was the `dependencyMangement` section.  I put it back in.
这里以及下面的多个def可以加上:const元数据标明是常量
> that would be to simple ;-) and it would still break stuff for users, so they will need to download the huge tar file over and over again..

> I was thinking of having the mne-sample data directory tree on the web server; each file gzip compressed + md5 checksums. We would define the version of the sample in a file in the sample data directory. Then, when "import sample" is called, it would compare the version of the sample data with that of mne-python and if it is older update it incrementally (by computing the hashes of the local files and download the new ones if needed)

that seems a bit too much of engineering to me all the more so as we
don't have real access to the web server.

I am tempted to offer the sample data as a git repo which would do all
this for us (compression, version control etc.) But we need to host it
somewhere as 2GB is too much of github unless we pay.

I think our user can leave with a download every 2 or 3 months

my 2 cents
float(up) / down

is enough

float is standar python. No need of numpy here
indeed it can only work with preloaded data (in RAM or memmap)
If you want to be able to avoid inplace modification I find it much more
pythonic
to introduce a .copy() method to Raw maybe in the future.
Ah, cool. If we eventually need them in more places then I'll add that `ANON_ALWAYS`. Thanks alfredo!
Instead, we should simply uncomment this line.
the function should also remove the directory (rmdir).
Same problem here as you had last week, this should be: (space + brace)

    if (!$isDebug) {
Not safe, use akka.util.NonFatal
Oh that was an error. I actually think it should be imported as np.fft rather than each function separately.
How come this change?
I took a look at that article.  I think I understand it, this is my interpretation.

Every time you create a string, you're creating an instance of the String class.  So "This is confusing" and "The Smiths on Charlie's Bus" are completely  separate instances of the String class.  

So if I use instance eval to add a new method to "This is confusing," it only adds that method to that specific instance of the class String.  The method will not be available to "The Smiths on Charlie's Bus" because it is a completely separate instance of the String class.

In that paragraph, I think the author is just stating exactly that (though in a bit of a confusing way).  Methods you define through instance eval only apply to specific instances of the String class, not to the String class itself.

Does that help?
remove login, replace by usr_id
```false === $sxcaption```
Maybe this could be named `_rowNotColumn:(BOOL)isRow forView:(CPView)aView` so that when you send the message it looks like `_rowNotColumn:YES forView:aView` for a row and `_rowNotColumn:NO forView:aView` for a column and you can understand the difference between a YES and a NO from just reading that.
Can you use [rdflib's normalizeUri functionalty](http://readthedocs.org/docs/rdflib/en/latest/_modules/rdflib/namespace.html#NamespaceManager.normalizeUri)?
Saying that, shoulda is only there to give me context's which makes test much cleaner and more DRY which is a good thing.  If you know of a better way of doing this without then I'm all ears :ear:
sorry i meant

```ruby 
should_authenticate verb, action, success_code, params = {}
```

is same as

```ruby
should_authenticate(verb, action, success_code, params = {})
```
Why is this run in series? Worth a comment.
(nit: sp before func)
@jazminschroeder was my bad to say it was my bad :D, something is up with it, made #17 for it
@stof ?
ok .. i think i will remove this line again. its an ugly hack for the CMF and i think we need to implement https://github.com/symfony-cmf/RoutingExtraBundle/issues/22
Created Product for iPad 2,4
This breaks production.
I just don't know what it means.
I don't think so, these bind to different elements and do different things.
these kind of beatifications should be in a separate pull request..
Umm, no? The original assertion was assertNotNull, I'm just making the test work again.
> It's enough for me to be sure that possible changes will be applied easily.

This also costs, and you have to pay that cost now, not knowing if it ever be needed.
active? indicates whether or not an experiment is complete (!active? => outcome will show).
enabled? indicates whether or not an experiment is enabled (!enabled? => default will show).

Also, only active experiments can be enabled or disabled and inactive experiments will always show the outcome (unless collecting is off).
The "entries" statistic is not btree-specific: it applies to any data source.
I was wondering if there was a non-prince-specific way to accomplish the same thing...
Is it possible to add a ``@param`` annotation for parameter ``$count`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
Minor point, but I feel *this* function should be named as `popup-preferred-width-1`.  So why not rename `popup-calculate-width` to `popup-preferred-width-1` and `popup-preferred-width-1` to `popup-calculate-width`?

Also, `popup-preferred-width-1` returns `(* (ceiling (/ total 10.0)) 10)` (you can't see it here. it's at L163).  It seems that width is constrained to be a multiple of 10.  Why is that? > @m2ym

If we want to keep this behavior, we need to take into account `popup-max-menu-width` before `ceiling` the width.
I am not sure to understand this part of the code. 
In my understanding is correct the goal is to only load the latest version of a lib.
1) if someone is trying to load a lower version => ignore
2) if someone is trying to load a higher version => replace

$key = array_keys($this->libraries[$name]);
$currVersion = $key[0];

$currVersion will be equal to the word "version" not to X.X.X ?

And I was more expecting a code like

if (isset($this->libraries[$name]) {
	if (version_compare($version,$this->libraries[$name]['version'],'>')) {
		unset($this->libraries[$name]);
	} else {
		return $this;
	}
} 

But also should the code merged the pre and post script ?
Hmm, if the check is behind basicauth (which mine are not) then they are needed, so maybe add a note about that instead?
Um pouco, mas também não consegui melhor xD.
There's a tmux package in epel, we could install it from a package after include_recipe "yum::epel".
This is generally true for any kind of business logic in templates. We shouldn't expose that to the public.
Good. Just name it the same as template, *registration*.
You need to views! One to send the token. The other to go to with the token and confirm. Use FormView, I suggest!
Why not using `node.get_full_node_id()` here?
It is so confusing when more people are doing translates, and than merging this file is just nightmare :)
`email_confirmation_token_is_valid` -> `is_valid`. ;-)
Ты ведь про 71-ую строку спрашиваешь?
Definitely -- the lack of a common connection & stream signature is
beginning to hurt. It's probably a good time to see if we can figure it
out, now that we have done a couple of experiments.

On Sun, Sep 23, 2012 at 4:49 PM, Anil Madhavapeddy <notifications@github.com
> wrote:

> In lwt/xen_api_lwt_unix.ml:
>
> > +	let port = match Uri.port uri with
> > +		| Some x -> x
> > +		| None -> if ssl then 443 else 80 in
> > +	let sockaddr = match domain with
> > +		| Unix.PF_INET | Unix.PF_INET6 -> Unix.ADDR_INET(addr, port)
> > +		| Unix.PF_UNIX -> assert false in (* XXX: it would be good to support this *)
> > +	let address = if ssl then Ssl(domain, sockaddr) else Plaintext(domain, sockaddr) in
> > +	let connection = M.make address in
> > +	return (fun xml ->
> > +		lwt result = M.rpc connection xml in
> > +		match result with
> > +			| Ok x -> return x
> > +			| Error e ->
> > +				Printf.fprintf stderr "Caught: %s\n%!" (exn_to_string e);
> > +				fail e
> > +	)
>
> Need to abstract out this a little, as it's now duplicated in Cohttp_lwt
> too, and is needed by pretty much all the protocol implementations we plan
> to functorise. I guess it fits in the eventual actor library...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xen-org/xen-api-client/pull/2/files#r1669063>.
>
>



-- 
Dave Scott
Ideally 32-bit support needs to work out of the box, as we still support Leopard and 32-bit Snow Leopard.

the `--32-bit` switch is usually reserved for forcing 32-bit where it would otherwise be built 64-bit.
Note that currently `brew test` works by raising if e.g. `system` fails, and does not actually check the return value of Formula#test.
missing semicolon ;)
you delete my comment :-( so i write it again:

you don't need to iterate over all quests for this query

and should we really delete all other quests?
I'm pulling this locally to try it out, since, as said, objects can also be identifiers, like a `DateTime` instance.
may be we can mention that 'ant -p' lists the available targets including 'fatjar'?
was it supposed to be called ne:)

unit tests please
this is the part where i get confused - how do I display the error in the disconnect page?
since this is a public method, the $parsed should be valid here.
Alright, pushing more then.
`this._expandables.contains(event.type)`
Maybe I should create an `OriginRewriteOptions` that both `NgxRewriteOptions` and `ApacheConfig` inherit from?  Sounds like a bit of a pain, but it would reduce duplication here somewhat.
This line takes only a few percent of the total time; the for-loop under it is the expensive part. Reviewing/optimizing that now.
Note for later: ``basestring`` might cause compatibility problems with python 3.x, but I don't know out of hand what the compatible way is.
This can be combined like: `strings = tokens.map { |token| token[:value] }`
I pushed a fix for what I'm guessing is a typo in the specification of `default rel_err=1.e-12` for `abs_err`... Please check!
I think these examples might be clearer if you explicitly called the second argument as ```image_dir='images'```.  You refer to this argument in the description as ```image_dir``` so we should explictly name it in the examples (here and below).
I would suggest leaving this in.  With the NR code the Poisson deviate routine became very, very slow at large N so I added this.  And the difference between Poisson and Gaussian noise will be completely unimportant at these levels.  A simple timing experiment on the machine of your choice should tell you what the speed of PoissonDeviate is vs its mean value, and tell you whether it's slower than a sqrt.

On Apr 23, 2012, at 7:52 PM, Barnaby Rowe wrote:

>> +        void setReadNoise(double readNoise) {
>> +            _readNoise = readNoise;
>> +            if (_readNoise > 0.) _gd.setSigma( _readNoise / (_gain > 0. ? _gain : 1.));
>> +        }
>> +
>> +        /**
>> +         * @brief Add noise to an Image
>> +         *
>> +         * Poisson and/or Gaussian noise are added to each pixel of the image according
>> +         * to standard CCD model.
>> +         * @param[in,out] data The Image to be noise-ified.
>> +         */
>> +        template <typename T>
>> +        void operator()(Image<T>& data) {
>> +            // Above this many e's, assume Poisson distribution =Gaussian 
>> +            static const double MAX_POISSON=1.e5;
> 
> I think I agree, but would like to check with @gbernstein as the author of this piece of code!
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/116/files#r723944
>
GetImportedVoucherRequest.
Finally making a README is a really neat idea!
Just followed Spring Integration configuration in that regard as well as the Spring AMQP's pom settings.

			<plugin>
				<groupId>org.apache.maven.plugins</groupId>
				<artifactId>maven-compiler-plugin</artifactId>
				<configuration>
					<source>1.5</source>
					<target>1.5</target>
					<compilerArgument>-Xlint:all</compilerArgument>
					<showWarnings>true</showWarnings>
					<showDeprecation>false</showDeprecation>
				</configuration>
			</plugin>
Is it possible for us to test more of this stuff at a lower level, so we can run through a bunch of live tests that don't create any VMs (and thus don't charge us)? Not suggesting that for this pull request, but would definitely be a good thing to have - we could even include those in the automated build then.
I've tried to tidy/unify what we've had.  Making config its own standalone package would be good, with some way to inject the entity-resolution behaviour.
Because we want the user to see this. However there are some improvements to this code in the in the latest version of the branch now.

I'm thinking it might be a good idea to log everything that goes to standard out/err to avoid some code duplication when we want both logging and user output.
I like `if !` It's one less construct to parse while reading code. More importantly `if COND` and `unless COND` are not intrinsically different. I prefer letting the condition decide the control flow, rather than the syntax.
Should we do a console.log here? Or is it too frequent for that?
Missing one closing parenthesis
DRY. Much cleaner way, thanks.
I always use an explicit test when the default is None (or any non-bool), because otherwise, "if not settings" works for [], {} '' etc
Sweet, merging!
baaaaaah. refactor gone bad. I *think* I need to import this macro with context :-/
yeah, you're right, it's confusing. we should just make supply points into
locations....

On Thu, Sep 27, 2012 at 5:20 PM, Cory Zue <notifications@github.com> wrote:

> In logistics/models.py:
>
> >
> >      def __unicode__(self):
> >          return self.name
> > -
> > +
> > +    def display_location(self):
> > +        """
> > +        It's pretty confusing for the location of Ada Health Clinic to be Ada Health Clinic
> > +        This function returns what you would expect: that Ada HC is in Dangme East district
> > +        """
>
> Not sure if i agree with this. Isn't it more confusing that
> .display_location is not a display version of .location but rather a
> display version of .location.parent? it seems like this should be called
> something like "parent" or "region" or something.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/rapidsms-logistics/pull/3/files#r1712217>.
>
>
Ooops missed Travis
On Jul 21, 2012 11:31 AM, "Harlan T Wood" <h@rlan.me> wrote:

> Glad to have this conversation rolling! Björn is a dear friend, a
> meditator and programmer living in germany. Travis is currently my closest
> enlightened structure collaborator, and has had a lot of a chance to think
> about unbounded graph structures while working for archive.org.
>
> This is a bit about the bottom of the rabbit hole where travis' work and
> mine meet:
>
> http://enlightenedstructure.org/BaseParadigm/
>
> Warmest regards,
> Harlan
> On Jul 21, 2012 2:34 AM, "Björn Grossmann" <
> reply@reply.github.com>
> wrote:
>
>> > @@ -32,20 +33,16 @@ We can have this now.
>> >
>> >  One and two I'm working on, in the context of a project called
>> [Software Zero](http://enlightenedstructure.org/Software_Zero/) --
>> currently pre-alpha and fit only for ruby coders.  [Contact me](
>> https://github.com/harlantwood) if you want to play.  Three and four are
>> dead easy.
>> >
>> > -## What's in it for GitHub?
>> > -
>> > -I'll tell you why I would love this idea if I were them.
>> > -
>> > -GitHub makes their money from private collaborations, while public
>> projects are hosted for free.
>> > -If the forking of content takes off like the forking of code has,
>> there will be many use cases for private as well as public collaborations
>> around written works -- potentially a much larger market than that which
>> exists for code.
>>
>> yes, it totally makes sense to me, to use github to store comments and
>> changes.
>> I was impressed the other week when I listened to a talk given by Dan
>> Yoder, http://fluentconf.com/fluent2012/public/schedule/detail/25798
>> He suggested storing all client data in gists on github or on similar
>> services and doing all the heavy lifting on the client side, so that
>> projects could be done without expensive server infrastructure. He said,
>> his clients loved the fact that data was stored on github and even
>> considered this a plus.
>>
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/harlantwood/Harlan_T_Wood/pull/1/files#r1210659
>>
>
Este metodo no existe en el DataTable
i dislike the fact that you're doing a test in a page object. if the actual test ever fails, you will have no idea why because it will just be saying 'not true' rather than showing the two strings that didn't match. see if you can use Assert.contains() in the test instead.
this is the place where you aren't testing for False that could be returned from get_text_from_location()
Ah, ok, I see what you mean, that's a quick fix.
Yes! A Mixin!
Wow cool .. that works. I'll update the pull.
I'd suggest filtering for all dot-files
Сравнивать что-то с глобальным `undefined`, в общем случае небезопасно. В некоторых браузерах можно переопределить `var undefined = 1`. "Strict mode"  при этом, скорее всего, не поможет.
Don't know if it changes anything, but at least it's clearer :)
I can't remember/find why `from __future__ import division` was needed.
I thought about that. I would prefer that as it is somewhat "flatter".
Would this mean that there is one instance per score? I.e. this namespace contains an object called ``AUCScore ``?
How would you handle the case where there are additional parameters, such as ``fbeta`` or ``precision@k``?
Yes, the value could theoretically be different. We just didn't met such case yet, with current sssd configuration.
The output when creating a buffer with a number works, but not a string:
```
Ti.API.info('string buffer: ' + Ti.createBuffer({ value: "hello world" }).toString());
outputs:
[INFO]:string buffer: 2.48473e+184
```
ok, I will move it during the merge
I'd like to keep the YourKit stuff out of the oae module.
You can deliver a custom setenv.sh.erb template via the setenv_template param to oae::app::server 

If you add the YK java arguments to localconfig/templates/oae-setenv.sh.erb then the oae module wouldn't need any references to YK.
Just create the directory in the app node definition or in the YK module.

https://github.com/efroese/puppet-oae-example/blob/master/modules/oae/manifests/app/server.pp#L45
Which was already obvious in this case...
> At the moment it looks like it needs to check names, as if there could be separate instances.

I see what you mean, if the file has been resolved already, it should point to the same object. However, that is only true if you're talking about the same instance of the file, which might not be the case.

If some code does a look up directly in the distributed directory and then tries to insert that in the transaction's cache (where it already exists from a previous look up), the instance returned by the directory won't be the same instance as the one in the cache (since dir creates a new object every time), thus the comparison will always fail.

What I was trying to avoid there is to propagate the double-resolution of the same file in the cache, that was the cause of some grief in the order which add/del/create were happening.
Not sure it's a good idea to include hqlatom.hpp in deftype.hpp just for the sake of this test... But I'm open to suggestions...
I'm not convinced about the inheritance structure.  I can see why you want to do it.  My concern is that it is too easy to assume something in the base class is thread safe when it isn't.

Possibly there should be a shared base class which spillable and non spillable both derive.  That might help.
Believe it or not, I couldn't find where this is calculated for migrations. There's some sort of magic going on and I couldn't figure out how it works, so this is the best I could do for now. Hoping we might be able to get feedback on this.
we don't use this import here you should remove it
Import the REST client.
I believe it was a migration involving the property of 'primary' to an image, which has subsequently been made redundant by the numbering system we have for the images
should this be "isHeaderCorrect"
Since the  Javascript Date() object seems to have no native way to access am/pm, maybe at some point we should install a 3rd part datetime lib and make it part of the API? Hate to see us adding multiple lines of code in function bodies for something we'll likely use in several areas.
This decorator is a bit confusing, because I'd expect the `TaskDecorator` to decorate plain old `Task` objects, but in this case it doesn't. Instead it wraps a `Task` object and `StudentDecorator ` object, which in the class is called a `participant`. This is what I'd call a `StudentTask` and isn't really a decorator. I think creating a proper `StudentTask` class is the right way to go here. That class should be able to build all the tasks for a student, much like `StudentDecorator#tasks` does. It should also handle returning the status of the task and contain the code from `CourseMembership` that has to do with tasks. How does that sound? It should help consolidate all the student task code which is spread across 2 or 3 classes.
Why not simply this one?
100 characters out of the description means nothing, but company and city matters to developers.

                = truncate(sanitize("Chez #{job.company}, à #{job.city}"), length: 100).html_safe
Also, since you're checking to see that it's "00", why not just do this?
```ruby
if data == "\x00"
```
hunh?
Trailing comma, please remove
This comment means, that someone can implement the OSX version for this exploit :-)
Sorry, I'm terribly familiar with Laplacian pyramids, but based on the paper, I would have expected something that looks more like:

```python
def build_laplacian_pyramid(image):
    prev_image = img_as_float(image)
    iter_pyramid = build_gaussian_pyramid(image, max_layer=5)
    iter_pyramid.next() # dump 1st pyramid layer, which is just original image.
    for p in iter_pyramid:
        # This subtraction won't work unless original image is power of 2 in size
        layer_image = prev_image - pyramid_expand(p)
        yield layer_image
        prev_image = p
```
This logic isn't quite right.  Perhaps

```
if array.ndim > 2:
    array_channels = array.shape[-1]
else:
    array_channels = 1

if not array_channels == channels: ...
```
I'd prefer "arbitrary_string" here - we know we're testing uniqueness, and CamelCase is for Javascript.
Would you prefer

        urlpatterns += patterns(
            '',
            *pattern_list
        )
Sure, done in next commit.
I'm ok with such change. Will you open new issue for it, or should I do that ?
This needs to be reverted back to flavorRef, since that's what we are checking in that line, volume is checked for in the next line implicitly
I know we discussed this in depth before, but one thing that we do if `result` is `undefined` is initialize the object's properties twice - once in the constructor function and once after.  Not sure if we care.  The alternative is to duplicate some code:

<pre>
if (typeof result === 'undefined') {
    return new Cartesian2(cartesian.x, cartesian.y);
}

result.x = cartesian.x;
result.y = cartesian.y;
return result;
</pre>

or

<pre>
if (result) {
    result.x = cartesian.x;
    result.y = cartesian.y;
    return result;
}

return new Cartesian2(cartesian.x, cartesian.y);
</pre>
Ultimately it's all kind of arbitrary and the clock is unbounded by default anyway.  That being said, I don't have a strong preference so I changed it so startTime and currentTime always match unless they are both specified to be different.
Actually `updateRenderState` is probably best since it is called from `update` and doesn't return anything.
I'm not suppose to nitpick local variables I know, but `positions` is not the best name here.  We use `positions` most commonly to denote an array of `Cartesian` positions; here it is an array of arrays.
I'd say it's not worth the extra memory.  The undefined check is fast.
这个文件是？……测试文件？是的话放到src/test里面去吧。
Please included required course heading.
Hi Thomas,

I appreciate your idea (-: this simplifies the code a lot. I merged your commit into a new branch v0.5_DataPointHook

there are a few changes. 

- I removed the require.js stuff. (other plugins do not use something like that either)
- instead of {data: d1, lines: {show: true, curved: true}}  I switched to {data: d1, lines: {show:true}, curvedLines: {apply: true}}
  while this not as beautiful as the former code it has the advantage that it doesn't add options to "line" and it allows to set all
 curved line properties (like nr of points, fit) for each data series.
- finally I adjusted the example code

I would appreciate additional comments on the changes
regards Michael
this is just a temp implementation that was put in while I was trying to run down a issue with node not shutting down and it just fell between the cracks.  changing
Let's be more explicit and say "using the data-webworks-context attribute" instead of "the above tag"
One thought here is that using `&` matches your use of `-` below for managing array contents.
i suggest we document the minimum you need to get running, so lets remove it. afaik security extra adds things like annotations for controller methods to define security.
sorry, again not looked closely enough at the current document. makes sense as is
leave spaces between in the CSS selectors for better readability.
The outer `foreach` uses `i`.
You have also probably forgot to mention function parameter storage classes, those are not taken care of now.
Most comments were addressed but I have one question regarding transitivity of const&co when used as delegate function type qualifiers. I.e.:
```
class Sample
{
  const(void delegate() const) dg;
}

Is inner const excessive here or required? My understanding is both are needed as one refers to transitive constancy of delegate type and second qualifies hidden class context. Is it correct?
```
OK. I was just alluding to the fact that there's a strong current to allow paren-less invocations for parameterless functions.
Please remove the comma, and given that you're talking about two functions, it would probably be better to say "but they call" rather having call be singular like it is right now.
Can anyone tell whether that's E.x or E.z? It's an unobservable difference.
equal sign position
The smallest problem with that line is that it is over 80 chars. :)

On Tue, Aug 21, 2012 at 2:41 PM, John Messerly <notifications@github.com>wrote:

> In components_polyfill_boostrap.dart:
>
> > + * scripts into a page after dart code has already run (b/4636).
> > + *
> > + * The script does an XMLHTTP request, so
> > + * to test using locally defined custom elements you must run chrome with the
> > + * flag -allow-file-access-from-files.
> > + */
> > +
> > +#library('webcomponents_bootstrap');
> > +
> > +#import('dart:html');
> > +
> > +// TODO(jacobr): this is a complete hack.  Figure out the correct relative URL or
> > +// embed the polyfill script directly in this script.
> > +//String polyfilLibraryLocation = "../../../../dart-web-components/webcomponents.dart";
> > +
> > +String polyfilLibraryLocation = "http://127.0.0.1:3030/Users/jacobr/src/dart-web-components/webcomponents.dart";
>
> nit: 80 col
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/dart-web-components/pull/16/files#r1429900>.
>
>
"Middleware LLC"  = ", Inc."

Did I say that I think we should update that everywhere to the current name and adapt the CheckStyle rule ;)
That actually makes a lot of sense. Incorporated in the newest commit.
FYI: while the symbol looks nicer, the symbol uses a plain HTTP connection vs. the string which is specifying an HTTPS connection.
To be honest, I didn't know I had.
the actual issue is that registrations.length will return 0 if there are no registrations, and thus divide by zero
Das Versteh ich jetzt nicht... Ich habe es folgendermassen in Erinnerung:

- Form mit allen Angaben und Feld zum Dokument laden
- Beim Dokument laden Worte zählen und mögliche Modelle zur Auswahl zeigen
- Dann abschicken... und Order gemäss Angaben erstellen (auf offeriert)
- Diese Offerte zum gegenlesen anzeigen (unveränderbar)
- Beim Kaufen dann Order von Offeriert auf Offen stellen...
- Bei Zurück Offerte löschen und neue erstellen (oder nur neue erstellen... und alte Offerten von einem periodischen Job löschen lassen)
Обоснуйте.
Can you explain this `for` loop?

I assume this is some legacy code where uneven/even rows had different different classes.
Could you use `$.parseJSON` instead of `eval`?
reverting restoreSlashes
Sorry, not having a good day today. That comment doesn't make sense ;)
We prefer to use the builder pattern...


		if (this.contentTypeShouldBePopulated) {
			return MessageBuilder.withPayload(marshalledPayload)
					.copyHeaders(message.getHeaders())
					.setHeader("content-type", JSON_CONTENT_TYPE)
					.build();
		}
		else {
			return marshalledPayload;
		}
with __the__ 'cacheConsumers'
Maybe too much, but do you think a green mongo leaf may be good here?
Instead of calling `obj.blur()`, which triggers the `blur` event on the object (which may have side-effects) I think you should rather call the `blur()` function defined inside defaultText, which only re-displays the texts.
s/Mozwebqa/Web QA
Same here, jquery into its own subdirectory (this is useful when you also add jquery-ui).
Please write everything in English.
Yes! Tagged and bagged!