labofsahil/github-event-dataset-2012 huggingface dataset:
Why not just add a typehint to $plupload in the function signature. Then you really just need to check if ($plupload)
occured -> "encountered, or false if successful"
Inject in constructor always?
it seems like we should be more explicit here, rather than just tossing everything and its mother in with a nil type
Ok, pulled the edges method out and updated the spec to use the
prs.map.  I thought it was a good convenience method, but I see your
point about the overhead created by having it.

   ...scott

inter prospera et adversa and dragons never quit



On Mon, Apr 9, 2012 at 8:35 PM, Randy Morgan
<reply@reply.github.com>
wrote:
>> @@ -35,6 +35,13 @@ def initialize(options={})
>>        end
>>      end
>>
>> +    # Return list of edge names applied to this border
>> +    def edges
>
> Hi Scott,
>
> Have a look at the updated specs on master. border.prs.map { |pr| pr.name } is going to give you the same thing as that method on Border.
> As it is only used in the specs, I don't see the benefit of adding another method (e.g documentation, and specs and maintenance) to the interface.
>
>
> Best
>
> randym
>
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/randym/axlsx/pull/77/files#r663299
haha. very good point. It was early when I did that, I swear.
I'd suggest adding either 'data-time' suffix or auto-increasing picture number to the saved picture file name.
I was speculation on whether to add the SKIDROW folder as a new path as a temporary fix until a different solution is added.
Missing XML documentation of the _textResource_ parameter
Looks like you've added a tab at the end here
I would leave that to y'all--- but it should probably be done in a different PR, just for organizations sake.
ha! the very next line! I was confused by diff.
It may just be me not remembering well how this works, but it seems to me that usually one does not need to check that the provided gradient is not None when defining the grad() method. How come you need it here?
I'm a bit confused where the don't SP-update replicated tables check is being applied now. Can you point me there?
missing ordering attribute.
Если файла нет - нода не создастся и зависящие от него ноды будут работать по-другому. Например будет ясно что вероятно у нас нет bemjson, а decl нужно не собирать и использовать как исходник.
if i set the presenter to the view in the constructor you cant test with jmock cause it expect this method in every test which is wrong . that is why i made a different method so it is not required in the tests.
probably, so how can we solve the situation? CakePHP will enforce some kind of naming prefixes like `Citates.Citate` will become `Citates.CitatesCitate` so there cannot be two plugins with the same model and thus the problem will not appear?
"register a handler"
Sorry my confusion: i thought you were referring to test_naive_call, which I've kept, but yes, I've removed test_fixed call.
The only thing that I could see that it tested was the fact that 'UniqueFilter.unfilter' works, which is not a feature of cheetah or something that needs to be maintained.

Is it testing more than that?
Just so I'm clear - not that the items are being deleted in reverse order, using remove() here should work now, right?
Will fix it on monday
Double quotes mon ami :)
`glue = ( rmultiplebg.exec( posX ) || [""]; )[ 0 ];`
I thought we had talked about adding modes to sampledata so that the different kinds of data could be represented.

If you have a need to extend sampledata to do something different, you should put that in a separate pull request so that we can work out an architecture that meets your additional needs.
So, this is the million dollar question: if the user sends an HTTP request with an invalid search_date_start, what should we do? The options are probably:

1. show an error to the user
2. ignore the field altogether

If there is an actual user (i.e. it's not a fuzzing script) then, the second will be puzzling. Further, the ui doesn't specify the format for these date fields or even tell you whether it's a date field or a date/time field. So I think with the current ui, it's very likely that someone will have invalid values for their search start and end dates.
It's now inlined.
I guess an alternative is to add 'sent' support back but that makes the implementation less clean (i.e. there's a pseudo-event type 'sent' that is around in some places).
Typo -- `disalow`.
Never mind about the testing, I see that the reference to this also has the typo.
having a lot of text generated for a successful operation violates unix principles. normally you shouldn't output anything in case of success, but i would provide a verbosity parameter for displaying this. by default it should be quiet. for the create project operation this isn't that obvious, but printing a lot of stuff for the create component every time on how to access the component (see the comment there) is really bothersome.
Ich glaub am einfachsten ist es den relBase teil hier reinzukopieren und die vererbung komplett aufzuloesen
Versteh ich nicht... Wann ist timing=late bzw. Was ist die information davon?
I'd use `NULL` instead of `0`.
I don't think the `!post_type_exists()` is beneficial. Developers should just be careful not to define the same post type twice in their code.

Idem for taxonomies.
I think `IllegalArgumentException` would be a better than `IllegalStateException`, but I wonder if we should simply throw an `IOException`
@wrapAccessor
Also testing code, should be removed.
Should this be a relative offset as well (some reference + 1) instead of a constant?
It looks like toggle_node can also happen without being followed by a select_node (seems like any time you toggle _other_ than the #935 case... i.e. if there's no selection, the selection is on the node being toggled instead of inside it, or the selection is somewhere completely outside that subtree).  In all those cases, the flag still gets set, so the next time the user clicks a folder it won't toggle it.  So I think we need to check where the selection is located before setting the flag here.
Since the script ID can change if the page is reloaded, we must not store it in the document. Instead, we resolve it as needed using the function defined below.
another typo: PopUPManager
tagName isn't escaped
If you look at the file fully it has indentation. Probably a cock-up of my tab settings.
also this line
```by_submission_time = getattr(self, 'by_submission_time', True)```
Last thing: The PATCH method should also be blocked by Sabre_DAV_Locks_Plugin
I guess the comment is simply wrong, but then where are the unit tests for the insured losses? I see that we have the qa_tests, though, perhaps you removed them because the qa_tests are enough?
Were you unable to get convention based visibility binding to work?
Must be documented.
you are going to need to undo all these pom changes as they have gradientx specific items. undo and resubmit with just the port change.
Why all of the commented out code?
`.text_button:hover`, not `.text_button: hover`
shouldn't these two lines still be called before calling `site.process`?
It should already be included, actually. To be absolutely certain though probe Chris about the status of this, https://webmademovies.lighthouseapp.com/projects/65733/tickets/1231-insert-shims-on-startup.
I have added tests for these.

I think though, if i understand you, I disagree that "3661" should end up as "3661". Instead, it should end up as "1:01:01", no?
#555
Where are you dealing with failures?
This should rather be: `if certfile` instad of `if not certfile`
Are we sure empty string and not None is what we want to check for?
That's actually a good question. I wasn't sure how to make the JS respond with something that the ruby could understand - I suppose I could have done a zero or something but it comes back a string anyway.
okay, done :)
Oh, this is very neat. However I do not think that it is of practical importance here, as we are subdividing a region and not simply sampling it. However this can be added to the sampling itself.
Could you guys please stop sending useless comments? Unused use statements don't do any harm, and they will be removed next time I run the php-cs-fixer on the project. I have better things to do with my life than deleting a billion emails about stuff that php-cs-fixer handles transparently, and you should too.
Nifty, I never thought of adding attributes to functions like this.

I like it.

Your idea or a trick you picked up somewhere?
I don't understand this FIXME line. What's broken?
For @tombye, this particular line seems to be causing the JS-enabled issue for benefits pages. We'll talk about it tomorrow.
F**ck didn't push the right version.
Fixed.
I think this would even be better using python tempfile
Probably should use pWalletMap->GetDefaultWallet() wherever pwalletMain appears anywhere in the application.
You mean boost::thread, please no more boost::interprocess :)

OK, let's do that then.
It's a bad idea to include another HTML-string which contains invalid HTML and a font only available on Ubuntu. It's an issue already, see: https://github.com/bitcoin/bitcoin/issues/945.
If casting is missing, then maybe we should use SQLLEN
Shoudn't this be `emergency` ?
Indentation is not OK.
bez database changelog, to są mysql'owe fusy
I have built all versions, but only tested with GitTfs.Vs2010.
Is it worth defining all of these if we'll only use INFS in the end?
This method checks if you've fired at something that's solid, for example a door or a wall. This was based off of the Enemy's logic, and we can keep it once we add logic in the clone to actually fire at the enemies and not at us.
Just do the cmp thing here:
```python
list_of_processors_and_loads.sort(lambda x,y: cmp(x[1], y[1]))
```
Much less complexity for such a basic task.
Might have a "blond morning" but I've been reading this method several times now and I still don't get what it does.
I think you should test the case when the method is called ``update`` or ``create`` because that's what we expect in our actual middleware classes.
`0 === $sent` is incorrect.  0 means no data was written to the buffer and that is not an error.  This typically means the buffer is full and to try adding data to the buffer at a later time.
It'd be nice if these had the same name.  either `timer` for both the module and class level or `get_timer` for both.  I don't really have a strong opinion.
composer при встановленні сам додав це посилання, забрати?
why changing it ? Symfony only uses ``false ===`` when it is absolutely needed (for instance ``strpos`` which can also return ``0`` on success), not each time we want to check a boolean
``Boolean``
@simon-n that was only a suggestion (see the "?"), I didn't expect to trigger a passionate debate ! I am fine with your solution. The suggestion what about semantic: the method counts the number of row with the given token (0 or 1) and not related to perf at all. _(btw `fetchAll()` never returns false)_
space between `CommentCell` and `*`
The minimum length of VALID_USERNAME would be a problem for shorter nickmasks.
I named it unite because union is reserved keyword. Any other suggestion? Will rename intersection though.

I made them friends not for access reasons, but just to be there in the ROI class when one looks at it. Just so you can look at the class and see all the things it can do. Want me to change this?
I was able to remove two more of these.  One more is for pugi, another for our code (and I'm not sure I want to change it without more thought, despite the warning).
No, its caching is a bit of a mystery to me too. I tend to assume it works without reload until it breaks...

The difference here is that `cash` is a column on `Player`, so you have to `reload` the object; but `cards` and `hand` are relations (and hence methods rather than attributes), so you can reload just the associated objects by passing `true`. See [docs - first added function](http://apidock.com/rails/ActiveRecord/Associations/ClassMethods/has_many)
I thought some one could want do in a template
````
{{#if view.isBeingPresented}}
  I am entering the screen!
{{/if}}
````
Therese aren't needed
This should be module.get(DESCRIPTION); (not "flag")
This client has to be closed when the test is done.
horstart doesn't appear to be used here
Implemented in 52fc8e3c709f4be1866f888838323a1bb80e1d6e
This obviously needs some work... The overloads aren't really clear...
I must have figured it out wrong. The equations I had were
    Theta_t <-- Theta_{t-1} + v_t,
    v_t <-- mu*v_{t-1} - epsilon*grad(Theta)_{t-1}
which needed to be in the form
    Theta_t <-- Theta_{t-1} - epsilon*search_direction
to be used by SGD, so I factored -epsilon in the expression of v_t, which gave me
    v_t <--   - epsilon(grad(Theta_{t-1}) - mu/epsilon*v_{t-1}) = -epsilon * search_direction,
    search_direction = grad(Theta_{t-1}) - mu/epsilon*v_{t-1}

Is it correct?
Is this taking the correct font-size/weight without any css?
Use click event for `areaCamera`
Do we store this _firstTime in any local db or storage?

I mean, will be always be true and each time that i open the cost control will go through the fte for cc?
`'input[name="alarm.label"]'`
Yes, that really wont help in country code issue.
In this case, we should use 'equals' to avoid additional problems.
Thanks for the fixing :)
I still don't think the characters are self explanatory ;)
The system modal dialog needs some VISUALInput. I just gave a simple style. :)
`self.prepopulated = true`
This is a legit protocol-relative URL in case anyone asking.
I'm glad to see these methods kept for backwards compatibility, but I'd like to see them deprecated (with the plant to remove them in 3.0) so that formatter authors will be notified to use the new methods (which respect the user's color configs) instead.
My fingers almost did that and then stopped after deleting braces from distinct.  I don't mind further suggestions, BTW, I'll apply them.  Examples should absolutely show a cleanest model; otherwise we nulis get the wrong idea and won't unlearn it for years.  (Years in java time, maybe months in Scala time.)
Can we put this in separate module?
I wonder if a better name, in the spirit of groupBy and groupAll, would be groupRandomly?
Sure. Can you at least make the range start at 8001? ;)
I'm allowing the exceptions to be tossed higher. I don't see what is gained by catching them here.
the machine this code is running on
Add ``#description`` with the original values.
But that would not return true/false; it would return the `translateTo` function, right?

``` if(hd.isScratch(foo)) ``` would work but ```if(hd.isScratch(foo) === false)``` would not.
I think it would work, wouldn't that make your sab folder your working folder?
That would be one way to handle distribution.  I was envisioning just rolling them into the deployment process, so they'd just naturally appear in the `repository/equipment` folder on install.  I admit, I did have a few lingering questions like: "What do we do when we want to update a "built in" item.  Do we overwrite the item in the repository?  What if the user has made customizations to the item?

I'm open to adding in the items if and only if the user has no existing database, but the only problem I see is that we still don't have an ordering system in place for bootjobs.  So we can't rely on the `Equipment.yap` file already having been converted by the Databse bootjob.  This new bootjob would have to know how to both check for JSON items in the repository, but also have to check for the Equipment.yap file.  If neither of those items existed, it could extract the "default items".
unused var can be removed
there's a few other places in the code using `deferredGenerator`.  I'll make another sweep in a few weeks once all of the pending patches are merged.  Although this would be easy to fix now.
```python
import urllib2, json
forcesched = urllib2.Request('http://localhost:1080/api/v2/schedulers/forcesched1', headers={'Content-type': 'application/json'})
r = urllib2.urlopen(req, date=json.dumps(dict(param1=2, param2=3))
```
Locker loading uses package->getVersion() to find exact match, so it strange to use package->getPrettyVersion() value to write to locker file.
If prettyVersion has invariant $package->getVersion() === VersionParser::normalize($package->getPrettyVersion()), it should be checked at MemoryPackage::__constructor.
do you really need a separate method here ? Other archivers are putting the logic in ``archive`` directly
+1 for `id -nG`
If it's appropriate.
The feature that lets us handle the MetaData extension is not available in 2.3.2.Final of RESTeasy which is the version bundled with AS7, so otherwise we would have had to wait until 2.3.4.Final is bundled with AS7 in order to take advantage of the feature. Also this gives us more control. The only file I could find a copyright statement in was package-info.java which shows that it is also licensed under ASL. I happened to duplicate the license text in that file.
@vsizov this solution not good, but it is better, what we can do at this moment.

INOUT - correct, but needed with super user. For many other solutions - it's awful, but it is normal for Gitlab as the decision itself - the product and the infrastructure is controlled by administrators.

@dmke thanks for answer
Yeah, kill it, otherwise it is still there months from now
It's testing that the "current" class gets removed from the old active item, which in turn means it's been hidden - quite important from the module point-of-view as this breaks the ajax-style UI otherwise. There's already Selenium tests making sure the links render the correct items for the correct indices -- this test is making sure that the prev/next links are bound to the JS events and don't trigger full-page reloads.
What is the 1000 here ?
trailing spaces added?
I think you are right. The final user may have some difficulty to see why an IPv6 packet is IPv4 too small.
Yikes... yep.  I've changed this to key+min(1,strlen(key)), but I'm not sure this isn't overkill.  While this debug message was very helpful in diagnosing the issue and verifying the fix, I'm not sure how helpful it is going forward.
This activates a tab if it has the id of the location hash in the url. So <code>user/.../edit#email</code> will go to the email tab.
I would argue that this is not a tutorial but rather an explanation of why you would want to use an MVC architecture like the one Backbone provides. The explanations are not actually specific to Ribcage or even Bootstrap. (Although the code is.)

Recommend rename of file. Maybe to something like `why_mvc.org`.
remove this action if not used
Not sure how we do low level error handling. My gut is to avoid nulls. This is currently only used by this validation script and the error will be caught at a higher level.
Rename the "emails" parameter to the "success" callback to "info" or "resp" - something that better conveys what the object is. It is no longer emails only.
fixed-ish? accidentally used """ in places in datazillamodel, will change that later maybe?
The function name is still awkward. Can we please find a better one?
Maybe I'm being daft here, but what are we protecting against here?  It seems to me that making this a === would just make the code less flexible for no real increase in reliability.
Please check the line below. The release target is calling the build target, which itself is the default one.
will this line direct to its page? seems like more to the folder than a php page.
``break`` is useless as there is a return statement above
As for export, this should probably report an error with both arguments and a block supplied.
alright, change this back to the regex style, it looks nicer
It's the factory getting memoized here, right?
Are these two lines useful here? In order to test, I had to create an `onBootstrap()`:

    public function onBootstrap($e)
    {
        $application    = $e->getParam('application');
        $serviceManager = $application->getServiceManager();
        $serviceManager->get('ViewJsonStrategy');
    }        

in addition to:

    public function getServiceConfiguration()
    {
        return array(
            'factories' => array(
                'ViewJsonRenderer' => 'Zend\Mvc\Service\ViewJsonRendererFactory',
                'ViewJsonStrategy' => 'Zend\Mvc\Service\ViewJsonStrategyFactory',
            ),
        );
    }


as I couldn't see how to get the strategy attached automatically.
I thought we modified options to be value => label pairs?
Obfuscated or not doesn't matter.  When CraftBukkit is updated, the update process will repoint any obfuscated name changes appropriately.
Why `== APR_INCOMPLETE` instead of `!= APR_SUCCESS`?
You suggest to completely remove the /compiled directory ?
I don't get why we need lessc in our path if we are specifying the complete location to it in the setting. Any reason?
What is missing? I'm a bit reluctant to merge code with such comments, even if might be a nice application.
then it is fine. I thought PHP was throwing some E_NOTICE in such case, but I probably confused with another function.
Just remove the preg_quote()
Is it possible for us to split the "use"s in logical blocks? Like Doctrine\DBAL and Doctrine\ORM ones?
A comparison with `nil` will be false, so this isn't needed.
Ruby 1.8.7 wants the gsub's arguments parenthesized here or it chokes.
Wouldn't it be better to load the DOM here and pass it each converter ? This would avoid to load the XML and transform it back in XML in each converter.
Looks like this shouldn't be part of this PR
Why did you choose to log to `STDOUT`? I imagine this makes the progress-bars more annoying because they are reprinted whenever something gets logged. I think it could make sense to have some log output go to a file and some to the `STDOUT`.
try and keep lines shorter than 100 chars, certainly don't go over 120

so, use

```
* http://fossies.org/dox/netcdf-4.2.1.1/escapes_8c_source.html
  in effect, current names are a lower case derivative of this one
```

and so on...

No need to try and break up URLs that are too long, that's just bad luck.
no! :)
see icc example easyconfigs
skipping sanitycheck
Yeah, add it, every code file should have the GPL header.

There's a script available that checks this, see scripts/prep_for_release.py
Dude, I am already confused :-D
Sounds good. The more I think about it, I'm not sure what we can do, since you can import macros dynamically. That means we can't check at compile-time.
what if release changed to nil? self.release.name will fail
True, although I prefer this form because it doesn't rely on the click goal always being a user-facing milestone, regardless of how that would never happen. :P
its gotta for the plugin :/
Ha, nitpicking remark: it's gstreamer's clock that is used.. It'd be nice to update the param name and description. Also, the operator could mention that it uses gstreamer as a backend so the user can know that he needs to also have gstreamer working on his machine..
Plugin is not used?
The kgNoSort css class turns the cursor back to the default when hovering over a column header that does not support sorting.
Yes, it's a possible performance optimization which I don't have the time to investigate now in the scope of this issue.
@clemherreman @tmartin An idea?
Yes, but if you look at the CSS, you need to have a total of 940px.

```css
    .container .sixteen.columns                 { width: 940px; }
...
    .container .twelve.columns                  { width: 700px; }
...
    .container .three.columns                   { width: 160px; }
    .container .four.columns                    { width: 220px; }

```

;)
We should use <code>Assert.equal</code> here.
The Clojure idiom is "-" instead of "_"
Looking at this more closely, looks like none of the POST functionality we have is checking for this. This should probably be moved into a separate issue and dealt with all at once?
Not sure I understand this either. If this is the bucket name, shouldn't it be oae-files?
Note that the HTML formatting has already been cleaned up in master.
Perhaps we can split this out in two checks?
* `isArray`
* `min(1)`
It might be worth renaming this to getStorageBackend to improve readability.
The name of this method doesn't really express what it's doing.
The other one is "Given a user and their password, check that the password is correct", this is a utility function that just performs the hash-related utilities of verifying one password against another.

I suppose it doesn't have to be a public function right now, because AuthenticationAPI is probably the only consumer, so I'll just move it internal.
collectCorrections should be the correct method to call (assists are for code that doesn't need fixing, like refactoring suggestions)
Sorry, I meant 'named parameter'. I got confused :)
That was exactly my first aproach. But then I discovered I had a memory leak in my code. After some dumping I found that the leak was produced by the next sequence:

Since the close executed, the selector was null and the ClientRequestExecutor where never properly closed. The memory dump was pointing clearly to a leak in the ClientRequestExecutors (I think I had around 60% of the dump with ClientRequestExecutor objects).

When I modified the code to this approach, the memory leak disappeared and I don't have connections leaks anymore, AFAIK.

If you can think of a cleaner solution I'll be happy to test it :)
Does this var need to be global?
for converting hacky activerecord implementations like datetime_select
Хорошо, спасибо.
На самом деле она не нужна в данном случае, т.к. NSIndexSet хранит только уникальные значения  http://developer.apple.com/library/IOs/#documentation/Cocoa/Reference/Foundation/Classes/NSIndexSet_Class/Reference/Reference.html
This if test combines the previous "if" and "elseif" (which repeated the same code in each), plus adds the case when $int is passed in empty. When $int is empty, every dyndns interface will now be checked, so the cron job /etc/rc.dyndns.update will check all dyndns interfaces each day.
Good call - just added it.
no; I wasn't sure how to build the factories due to the crypted_password field. the create user action takes a pswd/pswd confirm field, and simplest auth does the rest.  how make do work?
is it me or it seems you compute iir params event if method==fft ?
titles is still there ...
Fix this to be <pre>Live demo using canplayall</pre>
use RelationshipType.class.isAssignableTo(c)
Not sure... I only use them here.
I'm not sure if it changes anything, but using a `while` and `if` statements here, wouldn't be way faster than using `foreach` + Pattern Matching? I'm not for micro-optimisation, but it looks like most data generated by templates will end here.
Ah ok, I have added a note
"each message" or "every message" or _really_ "each and every message"?
Don't modify the `options` object. It's provided (and owned) by the user, it should not be touched.
w00p, how the hell did I miss the fact that the caller is "self"?
Yes, I didn't realize you could import "hidden" functions.
You should declare the full namespace use at the top of the file
This change the bahavior, thus it does not work
you filtered `last_four` but didn't add in the obfuscated `account_number`
Eliminate the name after `function`, it's redundant and capp_lint will complain.
Great idea :) I will look into reusing their function...
> One possible work-around could be to set line-height on the body while setting font-size on html.

That's fugly.

> Another could be to set line-height in ems in establish-baseline only, even when font-unit is rem.

Much better idea! :-D
maybe one argument is since this applies to every table cell in the form, it should just be a subclass.
Gridcentric VMS-enabled
Each of these lines with name does exactly one thing, and I'd like to keep it that way for readability and in case we need to modify this function later to take care of another special case along the way.
We actually approved the change here. I know u are following the spec but we are changing it for this as per josh.
Do you really want a clean patch for this, or can we forgo it just for once ? ;)
can you not simply synchronize on `this` instead of `lock`?
Is there a reason why this method uses maxBatchQueueSize and onEntryHit uses maxBatchQueueSize * batchThresholdFactor? The javadoc doesn't say anything...
yes, i would like to be more consistant with `cache/*` (line 1)
what if the file does not exist in the last load path either ? It seems to me that it will break later when doing a file_get_contents
Sorry for any confusion about that. The way the diffs are stored internally, they are keeping spans of data in the original files, so they are not so lightweight. I could / would be open to writing a `git_diff_patch_flatten` API that discards the blobs and just keeps the minimal amount of memory to store the diff if that would help you make a more natural feeling API. Just let me know...
Ah - yes your right @jenshnielsen - I still read the two as the same thing (but obviously are completely different beasts...). Seems the warning should stay.
@NelleV @efiring I understand you both have your opinions. They are also both valid opinions. That being said, it seems as though the best course of action here is to agree to disagree.
I don't think we can do this here at least without setting the preference.  If we find the port, it will not work without the preference set, so just finding a free port does us no good in the MozMill constructor
A comment about where/when we WILL dispose of this might be good.
Will amend the documentation and add a link
I missed dependencies. It need to be
```javascript
"define(['underscore'], function (_) { \n  return " + content + ";});\n");
```
Ahah, all right, let's sum it up :
1) the route is matched
2) its linked routes middlewares are triggered
3) the "before" Silex global filter is triggered
4) the route callback is triggered
During 2 and 3, the process can be short circuited if any of the callback returns a Symfony Response.

Do you think we should sum up this into the Silex documentation ?
Ah you override it? Then you should put the "override" keyword in front of "def" ("override def read(...)").
That's something like Java's annotation @Override, sometimes even enforced by the compiler.
The class name is not autoloadable using a PSR0 autoloader. It should be in the sub-path "ZendTest/ServiceManager/Di/DiStrictAbstractServiceFactoryTest.php".
Are you sure you want to override the parameter ``$url``? This often makes code less readable.
Are you sure that the property "startLine" exists? Did you maybe forget to declare it?
wrap into a transaction block, so it will rollback when seed fails.
Was ist eml/iml?
@carlasouza  Any ideas on how I can do this without disabling the VZ validation?
yeah messageType should probably be message_type in that response.
So this is all kind of ugly, but I'm not sure I have a better suggestion…
If we got headers and an empty body, I'm not sure this is necessarily an exception.
Tinha o rescue por causa do Date.parse. Caso tente fazer o parse de data não válida é disparada uma excepção. Assim aproveitei para capturar se as datas eram inconsistentes.
Same as above (this comment is only here as a reminder for myself)
I just added a method setVaadinUserTheme(and so no more final because you know) because it was juts e get
nothing other changed
`rvm: rbx-19mode`
Yes: I followed the procedure from the original XFCE template blog post, and could not reproduce 'squareese'.
minor: `task.mturk_hit.nil?`
`user` variable is defined here??? Move to method and use `self`.
`!== null`? Or would it be enough to do `if (marker.getAnimation()) ...`?
You are right that `inArray` is not suitable for here. But grep is also ugly. I think that I have been using it in my code, but I don't like it.

I would extend jQuery object with `.is` function. Similar to how they have [is](http://api.jquery.com/is/) for elements, I would define utility function (compare [this](http://api.jquery.com/each/) and [this](http://api.jquery.com/jQuery.each/)).

You can define this in `common.js` and then use it.
Ох с колонками загрузка картинок просто мозг выносит :D Это все очень хорошо. :) Я как пользователь ожидал, что картинки будут появляться слева на право.
Oh yes, from a performance standpoint, I think if statements vs virtual method calls is probably about the same (or at least, compared to the OpenGL calls themselves, negligible).  If there aren't very many places with differences, if statements is probably easier to understand.

For the features, I think we may need to get the opinions of other contributors.  It would be nice if an application on XNA on Windows Phone 7 could expect very similar behavior with MonoGame on iOS/Android.  But, as you say OpenGL and DirectX are quite different, so we may not be able to achieve an exact mirror of XNA's functionality.

At this stage, I wouldn't worry too much about subtle differences.  Eventually we'll have more tests that compare XNA's functionality to MonoGame's, and at that point we can start to worry more about how much effort to put into exact conformance with XNA Reach.
okay wesko it'd be good if you can commit a quick patch for these.
Yeah, I like to make it explicit though.
I don't understand your comment. If the condition "values.size() == 1" fails, then the last line of the method is executed, creating a TXXX frame.
you don't need an other pointer to instancescript, it already declared in bossai

since you use bossai, you can also use _Reset() _EnterCombat() and _JustDied(), so you don't need to call SetBossState manually

your tornados are already saved in summonlist, and will despawn on reset and justdied if you use the functions above and makes your cleanup function smaller
Looks like you need to update your IDE to the default import order (which comes from the Android style guidelines):
https://github.com/WhisperSystems/RedPhone/wiki/Code-style-Guidelines

...otherwise every commit we make will include this diff back and forth.
Remove spaces at end of line.
I'm not sure how it's wrong. Please detail.
Sorry, my fault, merge error.  Should be after the super
s/nonat/routed ?
In fact, I'd probably just not use raw strings at all. Backslashes rarely appear in URLs (and certainly not in well-formed ones) and so the distinction's just extra noise and confusion for new users.
Can you add a small bit of explication here about some caveats with `one`:

1) If you attach to multiple event types with `one`, eg `.one("click keyup focus", fn), the event will be run once on each event, i.e., once the element has been focused, the handler will still fire once for the first keyup, as well.
2) If you use `.one` on a collection with more than one element, the handler will be run once the first time the event happens to *each* element, i.e., `$("div").one("click", fn)` , the click will be run the first time each div is clicked, rather than being removed from *all* divs in the DOM the first time *any* div is clicked.

(These are some common points of confusion I'd like to capture here)
Может так и оставаться, ничего страшного пока.
Я должен был сказать в прошлую субботу, что строка кодируется вместе со своей длиной.
Ага, в презентации точно написал.
talked on IRC: we will first get rid of optparse in circustct - see #158
You've removed error 104 from console/config/locales/en.yml, but it is still part of the raise() here; is this intentional?
`service.satisfies_version()` returns a boolean.
Not sure if I already pointer this out, but maybe do:
```javascript
var id = ctx.allocated_res_ids[data.fromResourceID];
if (id)
  ctx.allocated_res_ids[data.toResourceID] = id;
```
(Again, assuming id can't be falsey.)
Is scoped_ptr not available?
Looks nice, but you need packages to feed a package manager with. The best package manager is useless if there are no packages for it. That's why I'm using Arch: Because there is this huge repository of packages in the core and in the AUR. I can cope with a limited package manager, but I can't create all the packages myself ;)

Maybe that's the actual strength and advantage of Arch: The complete lack of QA and packaging policy, combined with a dump package manager with a dead simple package format. No complicated building, and no bloated policies for licencing, QA, and the like. Any idiot can create Arch packages, and hence there is a PKGBUILD for almost anything you could ever want to use, and most of these are even up to date. Most are blatantly bad, but I rather use a bad, but working package instead of wasting hours in creating my own (quite the same reason, why I use homebrew on OS X ;) ). This makes up a good distribution for experienced power users, exactly what Arch is know and popular for, but a bad one for servers and production environments, and generally everything that has even low requirements on QA.
Any specific reason for `make_blobs` instead of `make_classification`?
reminds me i should put the shib stuff into the example--though that's pretty stanford specific.
Only important if it were to happen regularly :-)
Ruby 1.9.3, su Archlinux. Ora che ci penso ho installato tutto il resto con bundle e il Gemfile del progetto, quindi le versioni dovrebbero corrispondere (rails è alla 3.1.0). Forse non c'entra.
De maniere generale je suis pas hyper fan des parentheses je prefere quand c'est inséré dans le flow du texte
Thanks for adding the comment about where the grace period is.
which is irrelevant for a testcase for PHP-343
But if I had it, I could just change it. Nobody else is using it. I did not check it explicitly, but I have no s10 in my code and all my examples work fine. I had 's10', however, in the query part of my code and I fixed that.

On 01. 10. 12, at 22:46, Mitar <notifications@github.com> wrote:

> In datastream/api.py:
> 
> >          _order = -1
> > +        _key = 's10'
> Yes, but check it. Is is there? Because if it is, then we cannot change to 10s.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
The default encoding is platform dependent (not perhaps the best design, but that's the way things are), so we should explicitly specify `encoding='utf-8'` for reading & writing JSON files.
I'll have to test it out at some point. Google tells me it's fixable without a reinstall, so that's handy.
Si acestea trebuiau sterse.
Not sure. It could be useful. Could we log it, which is pretty safe?
You are correct, fixed. Although it is not possible to fetech the database data, in our case only the sender name is needed - and that can be get from Email object.
Peux tu supprimer le a en trop ?
You need to support the locked-icon image.
Во-первых, об этом я говорил на семинаре.
Во-вторых, как ещё можно понять ```После точки должно осуществляться получение соответствующего поля у объекта```?
I like this blank line.
So, how should we call these optimized filter functions?
Hi Jake, you're right. I'll try the string formatting approach.
you could add the Ng, Jordan ref. The Luxburg one is a very good summary and maybe should be the first.
Maybe some advice on which solve tends to be the best in different scenarios would be useful.
Well, all test passed but  only if I wrote a lot other stuff in there. (the JukeboxTest´s methods are all super long, that can´t be right, right?) :/
I'd still think this is excessive nit picking, since it is part of a block that has changed a lot. But.... will do :)
We have surveys with over 20,000 points so this needs to be done before we can merge
He didn't know the PR gets automatically updated :P
Why is sRelDir empty? Can it be changed?
Done. alert removed from TiRootObject
Should the container layout be absolute?  Maybe it doesn't matter as there will be only one control in it..
why do we need this? I hope we don't require it!
Right ok, makes sense.
duplicated comment: I would just go for outputting %0 if it wasn't visited - i.e.. remove the if
What about replacing the item in the list - would still need to unwind for that?
Would look clearer with a switch? Maybe not necessary for now...
I would normally use a StringAttr as a member of a class instead of a StringBuffer (since it is smaller/indicates it won't be changed).
True, realized that a bit afterwards.
Nice, very clear!
We might have a caching problem. 
How could this test have ever worked. You mocked it incorrectly (easy mistake) so then I would expect the mistake to also be in the test. I.e. 
```
eq_(info['hits'][0]['name'], 'Windows')
```

To check, stop using "WIndows", "Linux", "Mac OS X" and use some made up crazy ones like: "BeOS", "Amiga", "Sparc".
Do any of these test the %0A thing?
I doubt this works. `len(somestring.split('/', 2)) == 3` not 2 iff `somestring` has >= '/' characters.
We need to talk about whether we want this to default on or off. I would say that since `django-authority` is still in the zero-dot release series, making it default on is the way to go since almost all users will want it.
This certainly deserves a deeper discussion. My current preferred approach to give clients an instruction how to build a uri and the corresponding request content is to give them a form (following Mike Amundsen and Jon Moore, see Moore's Oredev 2010 talk http://oredev.org/2010/sessions/hypermedia-apis) , either an xhtml form or a similar mechanism. With a bare uri template you need a lot of information about a rel and its media type, which is not the case with a form. Fielding mentions uri-templates as well as forms when he talks about the server telling the client appropriate Uris: 
"A REST API must not define fixed resource names or hierarchies (an obvious coupling of client and server). Servers must have the freedom to control their own namespace. Instead, allow servers to instruct clients on how to construct appropriate URIs, such as is done in HTML forms and URI templates, by defining those instructions within media types and link relations. " 

With a form, a client only needs three well-defined things: the rel which points to the document containing one or more forms, the form name and the field names the client is able to fill in. The form knows the http method, the proper request format, allowed field types (with html5), allowed values to choose from, it can provide default values and hidden fields etc. If you use an api documentation together with uri-templates and media types containing all this, you might be forced to have such a document because you have a requirement which is not covered by a form. But there are many cases where imo a form is exactly what a hateoas enabled client should be given if the server wants to tell the client "and now I need the following input". Or to put it differently, a hateoas client should be able to submit forms.
Convinced? If not, please take a look at my sample Rest client for spring-hateoas here on github :-) 
Best regards, 
Dietrich Schulten
Yup. Leftover from the port. Should not have the _ indeed.
is this image size always the same? If not this should be parameterized and passed from the calling test.
rhost?
Hmm,... I think I've been persuaded that making `sigma` adjustable (independently of `block_size`) is unnecessary.
oops .. how did i over look this? will fix it asap
I don't have a good explanation as to why it was removed.  I think there were some other refactoring going on that made it unneeded at the time.  Feel free to put it back.
Does `TextureAtasBuilder` still exist?
Why change this?  On the plane, the point is defined by just `x` and `y`.  `z` is not needed.
The default height is `0.0`.  Perhaps leave it off because less is more I hear.
40 characters is safely log, fixes #638
That is UIViewContentModeScaleAspectFill. UIViewContentModeScaleToFill scales independent of aspect ratio.
This style is automatically generated. I guess @ayeung made that template for code style.
Yes, I mean appendRow.  animated is not
This should mirror the add route behavior
это надо переделать, да. в этом PR я только ввел Uploader, который декорирует все это говно
Не просто закрыть окошко, а принудительно, минуя пользовательское действие. Как Сталин. Точно нужно?
а эта функция вообще выглядит как баг: операция "открыть диалог для конкретного виджета" не выполняется если "если любой диалог открыт"
Ah gotcha - very nice look and feel otherwise.

One more question was about using multiple choice here: is the existence of the x^2 term preventing it from being a custom-answer type?
I'll check tomorrow. need more time for that.

The problem by the way was not the "null", but the getValue() on a weakreference property in the first place. But as #97 doesn't have a getValue() anymore, either. I guess it's ok :)
Good point (replying via email as I can't find the comment on the site).

Andrei
btw would be cool to have marginalia
One solution is to put coffee-script module in the dependencies. It's the way other modules like mocha go.
s/Uri/URI
> I don't think we can override if it's static. Am I right?
> 
Yes.

If you don't need it parameterized, though, maybe just compute a value in the constructor and use a final local String member instead of a method? IIRC you can then just set that to a different value in the subclass's constructor.
dont comment code pls
The ones I replicated were the `development_dependency`s, for Bundler's benefit -- I think they need to be in either the Gemfile or the gemspec as development dependencies.

I should also say that I don't well understand the interplay among an app's `Gemfile`, it's gemspec's `development_dependency` and `dependency`, and the  `development_dependency`/`dependency` of the gems it specifies.

I can confirm though that commenting eg `tilt` out of the gemspec (but leaving the `goliath` dependency) means that bundler doesn't include it:

    worblehat ~/ics/ext/goliath-contrib$ bundle exec ruby -e 'require "tilt"'
    -e:1:in `require': cannot load such file -- tilt (LoadError)
        from -e:1:in `<main>'

Anyway: I think things like `em-http-request` aren't brought over by the simple dependency on goliath, so they need to either be here or in the gemfile.  I put it here because I figured it could thus be easily diff'ed (which is also why I brought over the full list, not just the ones the examples referenced).
or maybe give them the appropriate command to update only the needed package: http://getcomposer.org/doc/03-cli.md#update
Agreed, we should be avoiding all runtime perf costs where possible.
Yes, right. The connectedness is not a property of the value, it's a property of the variable, but it's transitive with respect to the pass-by-reference semantics of OSL functions.
With all the namespacing, "OSL" and "osl" appear in the middle of the mangled symbols.

I'll see if I can refine this somehow to make it less likely to conflict with anything in LLVM in the future, but I can say that currently it does not.
Drop the `$` prefix.
What about something like:

```python
try:
    from django.utils.timezone import utc
except ImportError:
    utc = None
return datetime.datetime(year=2008, month=7, day=1, tzinfo=utc)
```

I mean:

* same call to datetime.datetime()
* ability to move the try/import/except to the beginning of the module ?
@nicolaasmatthijs would it be possible to revert the formatting changes on this file? Didn't we agree to "only apply the new style style guidelines to newly written or changed lines of files".

This would also make it easier to see what actually changed to this file.
We should throw a RangeError for these cases.
from __a__ Redis List
Add `<para>`
Maybe I missed something while I was heads-down on my own stuff, but I thought the plan was to transparently wrap the CCF internally within the JOG, rather than subclassing the CCF.

Subclassing will require them to change their config from CCF to ICCF, and then back again when SPR-9648 is implemented.
I don't have time for any further review, so if you guys are happy with everything, merge.
That is only reason - sleeker, shorter ;)
丸カッコの閉じ括弧は改行しないみたいです。
mapper.updatedAt.get) みたいに。
参考 → http://docs.scala-lang.org/style/indentation.html
no you can't specify an interface but need to specify the exact class that will be used when loading. however, this parameter is *optional* and most of the time you do not want to set it, so you can reference any target document.
that was done so that the default implementation of a CompositeView will produce a recursive hierarchical structure - a composite view of composite views.

but looking at the implementation now, that line of code should be moved in to the composite view's `getItemView` method.