syscall: don't clobber source files if mksyscall.pl fails.

R=golang-dev, minux.ma, r, rsc
CC=golang-dev
http://codereview.appspot.com/6353069

Committer: Russ Cox <rsc@golang.org>
misc/vim: fix :Import insertion heuristic.

If a factored import group has a blank line, assume it is dividing
separate groups of imports (e.g. standard library vs. site-specific).
        import (
                "bytes"
                "io"

                "mycorp/package"
        )

The most common case is inserting new standard library imports,
which are usually (stylistically) the first group, so we should drop
"net" in the above example immediately after "io".

Since this logic is getting non-trivial, add a test.

R=golang-dev, minux.ma, franciscossouza
CC=golang-dev
http://codereview.appspot.com/6445043
runtime/cgo: fix netbsd build

Copy over freebsd.c to netbsd.c.

Fixes issue 3823.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6398045

Committer: Russ Cox <rsc@golang.org>
syscall: workaround accept() bug on Darwin

Darwin kernels have a bug in accept() where error result from
an internal call is not checked and socket is accepted instead
of ECONNABORTED error. However, such sockets have no sockaddr,
which results in EAFNOSUPPORT error from anyToSockaddr, making
Go http servers running on Mac OS X easily susceptible to
denial of service from simple port scans with nmap.
Fixes issue 3849.

R=golang-dev, adg, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/6456045

Committer: Andrew Gerrand <adg@golang.org>
syscall: apply comment from Mikioh

This comment was suggested in CL 6456045
but never got applied.

R=mikioh, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/6447056
net/http: don't modify Request Method's case

This fixes a data race (usually just harmlessly updating
"GET" to "GET"), but also follows RFC 2616 Sec 5.1.1 which
says that the request method is case-sensitive.

Fixes issue 3881

R=golang-dev, rsc, dsymonds
CC=golang-dev
http://codereview.appspot.com/6446063
misc/dashboard/codereview: recognize "NOT LGTM".

A "NOT LGTM" overrules a previous "LGTM" by the same person, and vice versa.
"NOT LGTM"s are shown in the same location as LGTMs, colored red.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6453062
misc/dashboard/codereview: fix tag nesting.

R=golang-dev, rsc, minux.ma
CC=golang-dev
http://codereview.appspot.com/6454062
misc/dashboard/codereview: make all active CL tables hold up to 50 CLs.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6449060
cmd/gc: point "no new variables" error at right line number.

Fixes issue 3856.

R=dsymonds, rsc
CC=golang-dev
http://codereview.appspot.com/6455056

Committer: Russ Cox <rsc@golang.org>
misc/dashboard/codereview: interpret zero reviewers as the CL being closed.

This is the state when the CL has been submitted by someone other than
the CL author, but before the CL author has synched their client.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6458044
net/http: don't allow zero byte in FileServer paths

Should probably be fixed in the syscall package, either
additional or instead of this CL.

Fixes issue 3842

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6442061
misc/dashboard/codereview: bump user-specific table limits to 100.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6457051
misc/dashboard/codereview: switch to using gobot to update CL reviewer info.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6453063
cmd/go: show $GOPATH in 'go env' output

Also, sort output.

R=golang-dev, patrick, dave, iant
CC=golang-dev, patrick
http://codereview.appspot.com/6446064
misc/dashboard/codereview: pass user information to gobot when assigning reviewer.

R=bradfitz
CC=gobot, golang-dev, rsc
http://codereview.appspot.com/6457052
doc: remove mention of weekly tag from source install doc

R=golang-dev, dsymonds, bradfitz
CC=golang-dev
http://codereview.appspot.com/6442062
cmd/gc: fix initialization order involving method calls.

They were previously ignored when deciding order and
detecting dependency loops.
Fixes issue 3824.

R=rsc, golang-dev
CC=golang-dev, remy
http://codereview.appspot.com/6455055