labofsahil/github-event-dataset-2012 huggingface dataset:
Does this really make sense? IIUC, exog for the KaplanMeier model should be a categorical variable. Here I suppose we're treating these IP levels as categories, but really we shouldn't be testing the difference between levels of the continuous variable no?
Wheeeee dawgy! Can probably shave this down a bit, but it's relatively slim already. Given, I may have been able to skip Forms and Buttons.
You can use `TwitterCldr.get_resource` here for conformance with the rest of the code.
不要加“类”这个字，C语言没有类的概念。
Do we want to support image search?
This looks wrong.  I don't think you can audit after handleError - there's no guarantee that message.getResponse() is anything sane, is there?  Or does auditResponseMessage handle null & other non-sensical values?
also can use jdoc
Given that this clearly isn't HTML5, you need a `type` attribute here.
Will do.  This ends up being an `ImageView` doesn't it?
Yes, I think that's right (unless another SBProfile is constructed which does not have random photon order).  It may be more efficient to shuffle the SBAdd photons then to shuffle everything for every convolution.  The shuffling adds 1 RNG call per photon.
Yes, NP, as long as you do it since I am currently surrounded by lunatics (of the small variety) and unable to focus.
Sounds good to me - we use a mix of selectors, so good to have a common function name around them.
need `locations==null || Iterables.isEmpty(locations)` otherwise get an NPE if --locations not set
Do you mean in the schema.rb?
Can you add () around the & bit?
Ouh.. Ok.. You think this test is enough?
Just check the log message for the default db name rather then actually connecting?
That log message used to be seriously broken, although the dbname was detected correctly, so what guarantees do we have that it won't happen again the other way around (the log being correct, but the dbname being wrong)?
^ I am not a fan of this name. Too generic. I am not even sure what its purpose 

Is this intended to be used as a public API ? if so we need a name that tells us what its purpose is.
Should be named `FacilityType` for consistency, I think.
Where does with_translations come from?
Given that on line 262 you set rows to an empty OrderedHash and then return those rows at the end of the functions call (whether they get populated with anything or not), it seems that real_get_all_indexed_slices will return an OrderedHash no matter what.  It seems like you could eliminate this function and simple rename 'real_get_all_indexed_slices' to 'get_all_indexed_slices'.
Should this method complain if there is no restart message to clear?

Either way, the behavior should be documented.
We have just made a change in pzp using path.resolve(__dirname,"../../somewhere/in/the/source.js") and it works on aNode
The git_buf should always be kept NUL terminated now, so this probably needs a final line: buf->ptr[buf->size] = '\0'
Yes, I refactored this a bunch of times and it ended here but I should have done that :-). Will fix.
Is there anyway to measure scrollHeight without nullify CSS height first?
Please create seperate pull request for this new file. It is not part of the Async functionality.
*blames Sky* He had it right the first time. :P
You can uncomment these two lines.
Should the homepage not be openmodelica.org?
16000000
if this is analogous to standard terminal columns, we should use about 70 to keep consistent with our coding guidelines.
Лучше вынести в пакет frolovNikolay - и использовать его в своих программах (чтобы не было copy-paste).
Для слов разделителем является не только пробел.
Shouldn't this method return the extended token value? after all is called getExtendedAccessToken, right?
https://wiki.mozilla.org/QA/Execution/Web_Testing/Docs/Automation/StyleGuide#General

Page Objects should not do asserts. This should be done within the test. 
make it return true or false if that page is available and add the assert in the test
``$item`` ? There is no such variable
This is only checking for strings that JMS defines as "types" in it's documentation.   If someone has added custom types, I'm not sure if I could support it without knowing explicitly how they're represented in the `@Jms\Type()` annotation... I haven't looked into it, though, do you know if that's even possible?
But if you have an array of string, you will only say it is an array in the doc, not that each element should be a string
no, i'd rather see you remove the commented out lines
w.run ? 0 : 1
For app builder can I say "Builds an app"? :)
I intentionally left out hints since Foundation doesn't support them out of the box, as @naoisegolden mentioned. Maybe it would be better if I included hints but just left them ugly/unstyled by default. What do you think?
Ah, I see. And the original change came from you.
I think n_jobs > 1 is avoided in examples for windows (to be confirmed)
Please use `if (NULL !== $content)` - we don't need the overhead of a function call here.
As Paul says this should not be needed
Good catch, the `getEntity()` method doesn't even exist on ODM's LifecycleEventArgs implementation.

@r1pp3rj4ck: can you fix this and revert to using `$document` as the variable name throughout the file?
You can discuss this with Dave.  My take is that we already have conversion functions in NativeUIControl and adding this file, fractures the set of conversion helpers in 2 places.  I don't really have any preference where this goes, but the functions should all be in the same place.  I think for now it's probably easier to keep them in NativeUIControl as Dave is likely making changes to it also and moving the functions now could mean more merge conflicts.  So it would be easier to do a later refactoring when things have stabilized.
If the method doesn't do any specialization then it shouldn't be defined in this class
This class needs to be removed.  It shouldn't be needed anymore with Dave's work to have the built in JS keywords working
is android the only platform requiring this?
There is a multi-byte test case, but what you saying is different (and my code is vulnerable to it), which is that an escaped escape is not removed because of flaws in other parts of the code (see my previous comment), not by design.
I'm not 100% sure if dictionary should be included here or not.  I can't see any harm, and some potential benefit, so probably fine.
Yes, and requiring it not to exist to enter the "adding" block won't help with that.
This could be outside the ```if (retVal)```, simply:

    if (bAborted || retVal == 0)
        return 0;
    if (retVal < 0) // error
        throw ...
    else if (findfds(...))
        ...
    else
        throw ...
Should really be in CCycleTimer I think. But not a showstopper
Is that new option used anywhere?
I agree that it shouldn't go in models, but why not in views? Aren't views preparing data for templates? I'm happy to learn here.
This is good but I think Adrian's approach wins me over :)

https://github.com/ossreleasefeed/socorro-crashstats/blob/4fe538e75e0884dcb0aa6fd6818b6a2a6563ed31/crashstats/crashstats/static/crashstats/js/socorro/query.js

That way he doesn't have to say `$` and `window` are globals.
Simplify:
```python
def handler500(request):
     data = {'product': settings.DEFAULT_PRODUCT}
     return render(request, '500.html', data, status=500)
```
this array contains line with the template name and an array of parameters
Do we actually even need these lines of checking x1, x2, y1 and y2? Maybe we could get icons little bit in a wrong position but at least maps would be rendered
Not changing that on this change. We assume windows per default nevertheless for the samples. Just updating to give examples on connection strings which make it much easier. The previous code would still work.
this always return's false. you need to handle this with the return value of iselementpresnet.
color_class? Feel free to add some definitions to https://jira.media.berkeley.edu/jira/browse/CLC-658
@shacker very interesting!
@ctweney yeah, more berkeley-ian schemes.
is it possible to add assertions?
Just to further explain my thinking - if we add a default scope then Guides will be ordered everywhere they appear on the site - possibly in undesired ways.  If we want a specific guide to appear in a specific place for SEO reasons, it doesn't seem appropriate to apply an ordering to all guides all the time.
This works without `@course` as an argument!? Rails magic :sparkles:
This logic is used multiple times so I suggest you define a helper function.
micro-optimisation: hashKey.left(2).toString() is almost certainly going to be more efficient. casting hashKey to QString is going to alloc & copy the entire thing, only to chop it off - whereas that will only take two bytes into the string
AFAIK xrange is deprecated
Oops, don't actually use the passed-in `url`.
fixed in head.
added the resize down test.
I removed all coercion for now.  We'll have to figure out how we eventually want to handle data of the wrong type.
Missing the word "merge", I think.
How much do we trust `Date.now`?  If `timeSlice` is 1 or 2, is it possible that we will never enter this while loop due to process scheduling, timing precision, etc.?  Perhaps we need a do...while if `typeof tile !== 'undefined'`.
There are a ton changes to low-level public classes.  We don't need to list them all, but we should list ones that are likely to be of interest to most users.
There's no need for the break tags if you use seealso as I suggest below.
Would it be a bad idea to retain some of the previous example (simple read() operation without offset) to show a simpler use case than what is shown with the new example?
Nm, ignore this comment, I thought you were calling tiView.getBottom below =)
remove inline style and replace with a class.
I wasn't really sure what was happening here. This could likely be removed.
I can talk to Eric Bidelman about it, but I don't want to let it block this commit.
It feels very weird to pass a field from 'self' to a method on 'self'. What's the reasoning behind doing this instead of having self._log_request use self.connection directly?

(Sorry about sending this twice. Too many logins.)
can you please change this line? Maybe console.log('read + req.params.collection);
I'd have `return if hidden?` because I'm a sucker for truthy statements
Should be add different pred tests, e.g. nextPermutation!("a > b")(a)?
bool type init value is ```false```.
This initialization isn't needed.
And, TypeInfo.toString() sometimes returns a bad representation of the type. The lack of qualifier for delegate types is one of them.
I'm a bit concerned about this approach. Is allocating a TypeInfo object really necessary? Not only does it incur a run-time cost, it also means emplace is now never nothrow nor safe (I think right now, it could at least be implicitly nothrow...)

Why not just keep it as is, but while simply adding T.init initialization?

```D
static T i = T.init;
memcpy(chunk, &i, T.sizeof);
return chunk;
```

AFAIK, the only object for which this would not work, are objects that wouldn't be emplaceable anyways, such as immutables. Am I missing any other types?

Worst case scenario, wouldn't it be a better approach to fallback to your mechanism, only when the simpler T.init approach fails? At least this way the allocation only occurs when it is justified...

What do you think?
> How does this even compile?

Probably doesn't. I can't believe I missed that. I'll add an unit test so that the code is at *least* covered.

> Also, I'd advise checking whether hasLength!Range and asserting with length first if it's true and forgo this assert entirely in that case

My rationale is that once we are in release mode, then both code branches would be the same anyways, so it didn't warrant a conditional branch. Still, you are probably right that there is no point in making non-release excessively slow.

> (and I'd lean towards neither of them)

Ok.
I'd be happy to. I would love to learn how to update the guide. :-)

On 07/20/2012 09:37 AM, Pete Muir wrote:
>> @@ -52,6 +52,7 @@
>>   
>>      @Override
>>      protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
>> +      resp.setContentType("text/html");
> Sande, for this one, we should update the guide as well. Do you want to try doing that, so you get familiar with it?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jboss-jdf/jboss-as-quickstart/pull/304/files#r1205312
Hi Pete,
I actually copied this from lines 38 - 45 in the kitchensink pom.xml 
file. Should it be changed there too?

On 07/26/2012 07:10 PM, Pete Muir wrote:
>> @@ -34,6 +34,14 @@
>>         <!-- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
>>            resources, i.e. build is platform dependent! -->
>>         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>> +      <!-- Define the version of JBoss' Java EE 6 APIs and Tools we want
>> +          to import. -->
> I think you wanted to change this to the Hibernate line
>
> Define the version of JBoss' Java EE 6 APIs, and of the Hibernate family BOM we want to import
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jboss-jdf/jboss-as-quickstart/pull/316/files#r1249307
Use an `AtomicInteger` for this.
Committed a change that will allow the creation of setters if required, simply add a `set_[var_name]` method to the object and the rest is handled. I do not like the idea of using setters for the sake of using setters because maybe somewhere in the future something gets added. They just add a lot of clutter to the code.
I don't know what your browser or jquery do when node == -1 ... I guess the function either failed or returned nothing useful
Let's make this method package visible, so you can reuse it in GrapheneWebDriverFactory
Need docstring explaining purpose!
You won't need to support the deprecated service topic, so feel free to remove 'build_cloud_2'.
I don't understand how this else makes sense here?
Почему бы геттеру не быть констом?
Actually, we use this in various places as an indication of a container that will be filled during rendering. I don't think it should be removed, it should just be `<!-- -->` instead of `<!---->`.
I am going to clarify the comment to say that "testMode automatically prepares itself in loadModules"

testMode adds a really hairy complication, because it dynamically loads all of its scripts as part of prepareSite, including jQuery, which means I can't even bind to the event here in test mode.

I'm open to suggestions here, but keeping testMode working w/ all that dynamic loading hasn't been clean.
Hmm, I'm on the latest master, and it works fine on my system. Am I missing something?
Fair enough; I'll change all occurrences of this to use lambdas.
Just to add

INT-2610 describes an existing behavior that does not result in exception and we are changing it, thus introducing a regression. And that is exactly the conversation we had on another issue few month back ;). So we need to find a way to stay consistent especially giving the fact that this is a minor release where breaking changes are allowed as long as they are easy to mitigate and in this case it is.
FWIW, I am not a big fan of @DirtiesContext; it should be used very judiciously.

One of the reasons for using @ContextConfiguration is that it caches the application context so it's loaded once for all tests. This can significantly speed up testt execution and build times.

IMHO it should only be used when a test actually modifies beans in the context that could cause side-effects in other tests (hence "Dirties").

I have seen people use it all the time, but that defeats the purpose and unnecessarily extends builds time (because the AC has to be reloaded after each annotated test completes).
this is infinite streaming from server.  each data comes in chunk and we need to client to get callback for each chunk without waiting for the data "end" completion (in fact it will never end until server is recycled).
Did this get pasted from a doc sample?
Not sure whether this is a good idea. The DB should be in a fresh state for each test.
I presume $nameservers is likely to arrive as a comma-separated string, whereas real_nameservers should be an array. are you actually passing an array from from ENC at the moment?
LiveDox must have his own subtitle
This should take a resource type and return the correct processor for that type.
Module name changed (formerly 'credit_hax') so this function name needs to change.
phpdoc out of sync
This line is invalid as it is checking for the existence of a global variable named `EmptyView`. What was the purpose and intent behind this?
Oh oops... I thought this was part of `LoadedTooLateError`.
Please remove the whole service declaration.
The title of the book is actuall `Pro Git` and should be added back in.
Дучше писать «так как» вместо «т.к.», место экономить нам нужды нет. Это не печатное издание.
this must be a property
I think that would be great to not have it sorted as it is unnecessary. The
sorting is important only for computing the sha-1 and for humans.

On Fri, Mar 9, 2012 at 10:05 AM, Zoran Simic <
reply@reply.github.com
> wrote:

> > @@ -40,6 +41,39 @@ public class TestGroovyIOUtils extends GroovyTestCase
> >      }
> >    }
> >
> > +  public void testJsonSortedSerialization()
> > +  {
> > +    def str1 = 'foo'
> > +    def str2 = 'bar'
> > +    def map = [b: 'v1', a: "${str1}!=${str2}"]    // This map contains
> a groovy.lang.GString descendant
> > +    assertEquals('{"a":"foo!=bar","b":"v1"}',
> JsonUtils.compactRepresentation(map))
>
> Yes, we can do this (have the non-pretty-printed version also avoid
> sorting the keys). I wasn't sure whether we wanted keys sorted all the time
> or not, I kind of assumed we did because I didn't see anything proving that
> we did indeed want them non-sorted in the "compact representation".
>
> For that, we would need a 2nd mapper in JsonUtils: one that is created
> with the regular MapSerializer.
>
> The "regular" map serializer is almost 4 times faster than the "sorting"
> one I introduced here - it's blazing fast! :)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/linkedin/linkedin-utils/pull/6/files#r538170
>
Instead of matching string to string, let's change this to:

```
Result expected = new Result("Anet Test Oloo");
Result actual = mohNamesRule.evaluate(null, 8, null);
Assert.assertEquals("...", expected, actual);
```
Heu... reste zen hein ! S'pas bien grave ^^
Ben manifestement Git c'est de la merde alors...
you have {{status}} in two spots, is this intentional?
Please delete the above... I believe it's a leftover debug comment?
Do we somewhere discuss the distinction between return value constraints and property constraints in case we have a getFoo()? Maybe we should add something somewhere
"In this scenario, all we do is ~~to~~ spawn..."

I think it sounds more natural without "to".
Is this intended for human consumption?  If so, I'd change the call as such:

string = JSON.stringify(string, null, 2);  // or 3 or whatever your preferred tabbing amount is.

Also, since the string may not necessarily be a string, does it make sense to alter the name of the parameter to something more appropriate?  E.g., obj or object?
in that case I say we're asking too much for an interview. Especially with the no libraries but jquery requirement.
rename to TalktoNotification, should have taken a hint from previous similar comment :)
я с двух раз не заметил эту скобку :(
Incomplete statement. This is `cancel` property if set or -1
I don't think our current doc system will allow this. At some point, the enumeration values would have to be defined as properties, and properties must have types.

There might be some value to leaving out the type information, but if we were to use a virtual enumeration and simply list the alternative values in text, those constants wouldn't be available to the code assist feature in studio. So I think we should table a discussion of what to do with these constants for a post-2.0 timeframe.
Can you verify the behavior if you pass `hideOptions` on Android? If it does not work at all might make sense to define two hide functions. One hide without any options that works on both IOS and Android and the other with options that works only on iPhone, iPAD
@semmons99 that would be [Pathname](http://www.ruby-doc.org/stdlib-1.9.3/libdoc/pathname/rdoc/Pathname.html).
I was thinking the same thing, we could normalize on the way to get the client Id etc on the native side as well.
trying not to be nit picky but can you put the else on the previous line with the closing brace, this is the code style we use here, would like to keep it consistant, I notice it in other parts of the file, if you could update it that would be great
Better reuse the same S3 client.