labofsahil/github-event-dataset-2012 huggingface dataset:
And similarly,

    case ddef: DefDef if ddef.symbol.isLazy =>

This suggests it is more than likely further duplication could be eliminated like so:

    case defn: ValOrDefDef if defn.symbol.isLazy =>
Cool, thanks for preventing unnecessary bytes from being transferred :)
Ignoring the tree logic, the line is suboptimal:

    enclTrees collectFirst { case x: ImplDef => x } getOrElse EmptyTree
In fact, it seems these are Attributes.
Please get rid of this. This is polluting the database and is not necessary IMHO.
Even if the order object needs a user object we could use a fake / double object.

@radar: keep up the good work. You are kicking ass!

>>         self.email = user.email if self.user and not user.anonymous?
>> -        self.user ||= User.anonymous!
> 
> Previously, when an item was added to a cart and there was no current_order, an anonymous user was created with that new order (I was never a fan of that approach, but @schof had reasons for it).
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/spree/spree/pull/1512/files#r866255
So I have addressed this in one of the comments earlier where Jason discusses the 'decorators'. Let me tag you on that comment.
-> `if rv is None and (e.is_Add or e.is_Pow or e.is_Function):`
It does get confusing; that's why I expanded the default_sort_key docstring.

Now there is still some confusion (in my mind) about the use of
Basic.compare for sorting. (I wonder if that's part of the old system;
and Vladimer said that the use of `cmp_to_key` should be phased out
and the Basic.compare that I saw was the arg to that function.)
when I tried this, Aaron mentioned that this breaks the API. Perhaps you should add this to the end of the parse_expr parameters and call it here with keywords e.g. `parse_expr(a, locals=locals, globals=globals, transformations=transformations)`. BTW, since locals = None is already handled in `parse_expr` (as I recall) you don't need to provide a {} here.
On 11.06.2012 15:25, Christopher Smith wrote:
>> +.. autofunction:: sdp_mul
>> +.. autofunction:: sdp_sqr
>> +.. autofunction:: sdp_pow
>> +.. autofunction:: sdp_monic
>> +.. autofunction:: sdp_content
>> +.. autofunction:: sdp_primitive
>> +.. autofunction:: sdp_div
>> +.. autofunction:: sdp_rem
>> +.. autofunction:: sdp_quo
>> +.. autofunction:: sdp_exquo
>> +.. autofunction:: sdp_lcm
>> +.. autofunction:: sdp_gcd
>> +
>> +In commutative algebra, one often studys not only polynomials, but also
>> +*modules* over polynomial rings. The polynomial manipulation module provides
>> +rudimentary lowlevel support for finitely generated free modules. This is
>
> lowlevel->low-level
>

yes, I changed all occurrences.
This should raise a NotImplementedError until it works
Oh, no, I thought I pulled only the changes associated with the stream (first 2 commits). But I pulled all my changes.

This functionality is necessary for me because I save some fields of the tweet, but sometimes I need to rebuild the structure.
In this case, the stored raw tweets string helps. 
By default, the parser does not emits raw data.
"SQLite does not support column comments at all"
`else if` is used across the framework. Maybe change it for keeping consistency? :)
This code has been moved to `setEnabled()`
return node_dict.values(), edge_list
IMO `$this->mail()` is not really shorter than `$this['mailer']->send()` and mail is not a good name for a method who sending a message.
I forgot to mention that this check should be removed. We bundle a libeio with a patched API and ABI, compiling or linking against the system libeio won't work.
Possessives of method/object names should be avoided.
we should use some code like https://github.com/mozilla/kuma/blob/master/apps/demos/models.py#L641 to black-list certain mime-types.
On Mon, 2012-06-18 at 10:50 -0700, Edna Piranha wrote:
> > @@ -22,9 +21,7 @@ function initialize_map() {
> >          if (val != '') {
> >              search_string = '';
> >              $('input#searchfield').val(search_string);
> > -            qs.search(search_string);
> > -            qs.cache();
> > -            redraw_grid();
> > +            $('input#searchfield').trigger('input');
> 
> do you have more than one id named #searchfield? if not, you can just simplify and call $('#searchfield') instead
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/remo/pull/195/files#r1003627

ok!
If it's just about unit testing, I will be creating unit tests for everything for the service, so I already know what is all needed.

If there were a case that someone needed to find out all of the dependencies of this service, they'd just need to run a search for phpbb_container->get( within the includes/notification directory (it's just db, user, template, phpbb_root_path, and php_ext for now).

While I do see your point, I don't think that the added difficulties of working directly with dependencies outweigh the benefits of just using the container.
```
$('textarea[name=message]').value(phpbb_autosave_prompt(data));
```
The changes in this file are in https://github.com/phpbb/phpbb3/pull/629

I put them in this branch without meaning to commit them so that I could test them (and they make it work).
Add parameter and return value documentation please.
We are keeping the old hooks system.
added a timer in 1ba57f5
well, that's ok. i think you can do it one way or the other. as you noticed, going the inherited-way would require changes to the interface.
i'm fine with the more explicit interface you proposed!
integers ordering :)

never mind
k, initializers :)
The `set(option, value=nil)` interface came out of it mirroring the lua script, but I think you make a good point. In the interest of keeping the interfaces relatively similar across different languages, I think I might go with `all`, `[]`, `[]=` and `clear`.
Are you using haml?  It looked like your'e only using ERB.
Because of the way component works. If you return a stream of `null`'s from a component it will turn it into `{ id: null }` which is delete
Cool. Can we add a comment here that mentions that?
same note as above ... try out sencha layout properties
Dang! If only you received a commission for every PEP8 non-compliance, you'd be able to retire early as a happy man :)
There should be a test with axis=None.
Oh, I see that is down in the crash fix. I think it belongs in wrong result fix because if clip were an intermediate node in the graph people might not realize that some gradient terms were getting dropped. They'd still get values for all of their wrt variables but they'd be missing 2 of the 3 contributions from the clip node.
I'm guessing that the <stream> include is NOT required by the .h, so please demote/defer it at least to after unionnode.h, preferably as the LAST include in the .cpp . 

There's not a total team consensus here on the (extreme?) practice of listing system includes last, but, FWIW, it is my own personal preference.
I'll clean it up. Thanks.
Maybe the exception can be rethrown?
Personally I prefer asserts for "unpossible" conditions because it makes the expected unpossibleness explicit. I'm not sure you need to check after an assert. If asserts are off and you NPE, that's fine with me, though it would speak poorly of our testing.
All right, leave it up to the caller to make sure it is true for now sounds good, I will change the caller other than the constructor.
Does this make replicated table writes become single partition as well?
This comment is copied  and pasted from IndexScanPlanNode,  I remove these comments.
FWIW, the gsb-async-nifs branch uses:

    #ifdef PULSE_NO_REALLY_JUST_USE_THE_REGULAR_SEND

Removing the unused code would be good because it's, well, unused.  However, I think it's also a useful placeholder for later discussion with Hans & Ulf & the rest of the Quviq folk: it's only 52% clear to me why you'd want to use a PULSE-instrumented send here in the NIF code, but it's 100% clear that actually using a PULSE-instrumented send here in the NIF code causes all kinds of deadlock problems for PULSE.  Some kind of "TODO" reminder would be good.  {shrug}
Лучше подвинуть на 55 строку
could you add a space between assignments?
I made an issue for it.


On Tue, Sep 4, 2012 at 11:41 AM, Katy Huff <notifications@github.com> wrote:

> In src/Core/Utility/MassTable.cpp:
>
> > @@ -63,9 +63,11 @@ void MassTable::initializeSQL() {
> >      nuclide_t n = {Znum,Anum,mass};
> >      nuclide_vec_.push_back(n);
> >      // create an index and log it accordingly
> > -    int tope = Znum*1000 + Anum;
> > +    int tope = Anum*1000 + Znum ;
>
> You're right that we should change the local terminology in this function
> to be correct. I'm happy to change that too in this fix. The trouble is
> that it will continue to be labelled wrong in the sqlite table. I'd like to
> leave that as another bug fix, which I mentioned a few standups ago.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cyclus/cyclus/pull/361/files#r1524665>.
>
>
simpler: datetime.now().strftime(''%B %d, %Y - %X')
Ok yep, sounds good to me!

On Friday, 9 November 2012, Sergey Nartimov wrote:

> In Gemfile:
>
> > @@ -104,4 +104,5 @@ group :assets do
> >    gem 'uglifier',     '>= 1.0.3'
> >  end
> >
> > +gem 'underscore-rails'
>
> We just need to modify config/application.rb to have the same lines as
> every new rails 3.2 app:
>
> if defined?(Bundler)
>   Bundler.require(*Rails.groups(:assets => %w(development test)))end
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/errbit/errbit/pull/327/files#r2074803>.
>
>
PEP8 is weeping at your lack of spaces after commas here :D Same problem in a few other spots too. Please fix ;)
Same thing here, and below as well; the trailing colon is missing.
So it prints the same error message as `build`. By the time we enter `run`, we know that all is well.
Is this construct_array?
Yes, it should. Good catch!
This isn't a classmethod, so the first arg is ``self``.
CS..methodenname
Here you could use the following format:

#ifdef FPM_ENABLED
// FPM block
#else
// RT block
#endif /* FPM_ENABLED */

I think it is more intuitive . =)
I don't think the cast is necessary, is it?
Yes, this makes sense.
I will prepare some simple class-level Javadoc in next few days.

btw, do you agree with me to keep the method-level javadoc for the factory methods since they throw unchecked exceptions and have restrictions like number of threads, etc? These details should not move to the class-level javadoc, right?
For some reason this code blows my mind, but when I try to explain why, it all makes sense when I try to pick it apart.

Can you explain why 'canSetImplicitly' is all about, maybe that would help. It is always set once the value changes (at least once)?
Ya, the issue was, if the default was say, 1 hours and a custom frequency was set to 6 hours, backoff could easily take that to 24 hours. So this was my compromise. In the calling function, it logs when this happens, so we can see if it happens a lot.

Thinking about it now, feels better to return `null` and log that.
this should read something more specific like: "should return app sharing text if node sharing text isn't set"
Any JSON property name without quotes thrown an error on launch. So we have to keep them in quotes.
These have different percentages than the non-highDPI variants above.  Are we sure it's safe to remove them?
`{string}` should be lowercase.  Also, same note here about the "unmodified" bit.
What happens when you disable or enable the revisions plugin? I don't see specific code for that yet...
Can you use the Retry() extension method here instead?
Why are you catching a NPE here?
rescuable? checks if you have any rescue handlers set for an exception. It would evaluate to true if you had explicitly setup a rescue handler for Base (which you don't want to do, since it falls back on the default handler). I'll think a little bit about how to make this clearer.

Will also find some time in the next few days to address some old comments from other pull requests and updating the documentation.
I think you can replace this with `Check_Type(type, T_SYMBOL)`
You'd think this would break something?
For now leave it as it is. We will change the design many times over. ;-) So please finalize the feature, we will discuss design later. (Also when I will see how it integrates with the footer anyway.)
*Returns user's avatar URL.*
Is that hint in any of my pull requests? ;)
I really like your argument and completely agree that we should just restructure the views and not change the code itself. But not too much. In this case it is something plain wrong. ;-) Or at least not explained. So I would fix it.
Can we change addy.address to localhost instead? This really slowed me down this morning when trying to get the login stuff working as this told me the server was started at "127.0.0.1:8888" but in reality the login stuff only works on "localhost:8888".
I did this in this order, because _popcorn.paused is more likely to be false than the media is to be not ready, thus we'll break sooner, more often.

That was my thinking, anyway.

I was also under the impression checking media.paused is safe when the media is not loaded, no?
Use JS naming vs. Python (e.g., no _ )
This should be initialized to `""`
I'm just curious about why you've attached `editorHelper` to `Butter`. Why not just have it be its own object on the global namespace?
Is this style consistent with the rest of the file? Style's still a mess, but let's at least try our best.
Spacing after the e
This looks suspicious, was it intended?
It might be useful to make all of these references to "options" something more meaningful now too. Perhaps make a variable at the top of this function to store `uiConfig` or something. Options doesn't even need to be passed in anymore, right?
Use a general variable in the container PHP file, with a variable that sets the Domain name. And use that. So, when changing the base domain name/path, one one change has to be made & it will apply everywhere.

I'd suggest something like this:
```
<?php
$PATH = "/CoinCod/";
$HOSTNAME = $_SERVER['HTTP_HOST'] . $PATH;
?>
```

Now use this $HOSTNAME everywhere to represent the complete URL while developing. But when setting the produstion release, set the `$PATH = "/"` that's it!

Understood?
retry 只是 --retryTime 和 seek
aren't confirmations and errors shown in divs with IDs?  like #errors or whatever.  It would be better to check the content of that div rather than just look for it anywhere on the page.
Why? Deserves a comment.
needs a space between the comma and dirname for pep8.
You can write this as just `println()` — no arguments necessary.
again. Duplicated from katello-configure/bin/katello-configure
We're trying to switch over to using underscore.js's  each function:

KT.utils.each(data, function(item) {} )
I was inspired by subscription-manager spec file that adds rhsmd script to cron.daily, without %config flag. I'm not 100% convinced %config flag is right since we don't expect to let users edit it. Is there any othere reason for this case?
Removing it from the haml is good, I would also remove its references in content_search.js

I believe the only reference is in the KT.widgets variable on line 19.  Removing the autocomplete key/value should suffice.
Consider import ugettext instead of gettext.

See Spacewalk BZ 683546 and spacewalk commit   ceb71f81a3b64d8a71781f65f9d82b88340601e8
Well, options are subject of more complex validation (in the validate method). And I am not sure if add_option method is ours, or is from API (wrapper would be required).

ACK
hmm, it should.
let me work on adding the error message passing.

On Tue, Jul 17, 2012 at 11:53 AM, Jared Wilkening <
reply@reply.github.com
> wrote:

> >    } else {
> > -    %$job_map = map { $_->name, $_ } grep { $user->has_right(undef,
> 'edit', 'metagenome', $_->metagenome_id) } @$jobs;
> > +    %$job_map = map {$_->name, $_} grep {$user->has_right(undef,
> 'edit', 'metagenome', $_->metagenome_id) || $user->has_star_right('edit',
> 'metagenome')} @$jobs;
> > +  }
> > +  if (scalar(keys %$job_map) < scalar(@$jobs)) {
> > +    print STDERR "user lacks permission to edit ".(scalar(@$jobs) -
> scalar(keys %$job_map))." metagenome(s)";
>
> does/should this information also get displayed to the user?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/MG-RAST/MG-RAST/pull/62/files#r1180356
>
removed


On Fri, Nov 30, 2012 at 3:22 PM, Christophe Coevoet <
notifications@github.com> wrote:

> In src/Monolog/Handler/PusherHandler.php:
>
> > +namespace Monolog\Handler;
> > +
> > +use Monolog\Logger;
> > +use Monolog\Formatter\
> JsonFormatter;
> > +use \Pusher;
> > +
> > +
> > +class PusherHandler extends AbstractProcessingHandler
> > +{
> > +    /**
> > +     * @var internal variables
> > +     */
> > +    protected $pusherKey;
> > +    protected $pusherSecret;
> > +    protected $pusherApp_id;
> > +    protected $channel;
>
> lots of unused properties here
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Seldaek/monolog/pull/132/files#r2278120>.
>
>
This is actually a workaround because the `write()` method of the SocketHandler takes the `$record['formatted']` and writes it to the socket. I am rewriting it right now.
Add some comments describing how it works.
This pull request is mainly on mocking out the UI layout, so I only added and changed some JS base on the original code.
I will reorganise the JS code into module pattern or constructor function in a follow up.
Yeah, it's another TODO of sorts... visuald doesn't support per-file options, which is a bug with the author.
Done (as ``LOG_FILE_FORMAT``)
Why define a function for what is one (pretty straightforward) line anyway? Or do you plan to extend this?
Yes, when a SOCKS4 proxy is specified, -proxy will not be used for Tor and IPv6, which is what I wanted to clarify with ``if no -socks=4``.
I'm also for changing it. Splitting up lines can be useful when they get too long for convenient reading, but this really breaks the flow of reading.
sure, just like passing not existing value as 2nd parameter to currency() all the method does is predefine the default value for 2nd parameter, so you dont need to write it out in the application.

For instance i used burzums Cart plugin, this method allows to change the default currency without the need to change the plugin code or use a Configure::write() in the app, and Configure::read() in the plugin.
Style checker will complain about two spaces before `=`.
`elseif` is generally preferred over `else if`.
Do you mean you just want any type/tab that is both in `gridByType` and `currentType`?
There are no such situations in the current modules.
Were conditioning facilities deemed not worth maintaining?
I removed it altogether

that particular middleware was just being defensive - in case the http server didn't provide a new ExecutionContext per http connection. In the end it probably makes more sense to require the http server handlers for firefly and gate to ensure there's a new execution context that "sticks" to each of the calls coming in for a request.
can we use single-quotes in the `switch` statement instead of double quotes? (unless there is a switch statement specific issue with using single-quotes).
(array) false == array(false) so that wont work
``Annotation|null`` would be better IMO (giving the most important part first). Thus, it is wrong. Any class could be an annotation so the only possible phpdoc is ``@return mixed`` (same for previous methods too)
@stof the abstract class metadata factory already handles this (see https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Persistence/Mapping/AbstractClassMetadataFactory.php#L346 )

So this and the block can simply be removed. Not sure about the one using `ReflectionClass`, since `isTransitient` is quite simple.
Also, if you call `$this->getAliasNamespace()` you have at least to define it as abstract method.
After we're done with this feature we should have a go at refactoring our events to use polymorphism and refactor the case statements out of here and out of the notifications partial.
refactored, pushing shortly
This should also say, "use import ..." so that users know what the new API is.  Just a bit of user-friendly sugar.
lhs is normally 'Class.trait', so I would have to split it, and *technically* it can be arbitrarily deep.
Is there a reason why we are using numpy to do the equality testing?
Aha, yes right.  Thanks.
please review and correct all instances of missing license header
take out the blacklist property and put in a property for vsphere.template
this should be changed in the archetype
This should be

``` clojure
(change-memory :pc pc)
```

as we are setting the PC to start at a different value
This block of code seems like a waste to me. `git_filters_apply` should just copy the input to the output if the `filter_count` is zero and you should not have to special case that situation. If that is not the behavior of `git_filters_apply` then let's fix it instead of requiring 10 lines of code just to load and apply an array of filters.
`git_note_data` sounds more intuitive.
Well, as long as you're using the build directory all the junk is going to get ignored anyway, but I'll readd this and add an exclusion for the find script instead.
This would describe the table better if it was a `<caption>`
Isn't 60 seconds a little short considering this shoots off http requests?
changed this to a hex value for consistency
Hmm, I guess if no authorization is specified, the default ReadOnlyAuthentication sort of automatically limits to GET?
https://github.com/mozilla/zamboni/blob/master/mkt/ratings/tests/test_views.py#L112 would be a good test to base your test off of. You can just copy it and add in some URL stuff and test that it's flagged. Bish bash bosh
V8 is normally able to inline such statements also but other engine have a larger problem with inlining method calls. but it all comes down to performance testing. But it doesn't seem as bad now as I taught it would be by reading your code.
Would be better without if/else, because there's a lot of dublicate code now. 
Better would be to fill the configuration (simple object) just with the items needed and then initialize the panel (var panel) once.
I like the failure() callback. Could RetrofitError extend from `Exception`/`RuntimeException`? That way you could throw that object with all of its context when a synchronous request fails.
здається є стандартні
<pre>Given /^(?:|I )am on homepage$/
 When /^(?:|I )go to homepage$/</pre>
And `-mtime` here
this one should extend the ConsoleInitEvent to have the input and the output too
why is dropping guessMinLength() not noted as a BC break?
you can use `isset($a, $b)` here
As I've been working with CourseInstance model today, I find the parameter name instance to be potentially missleading :).
What was the need to toggle separator style here?  I woulda thought you were safe leaving it in SingleLine mode all the time.

Keep in mind for count == 0 you will have 1 cell, with styleNone and for count == 1 you will get 1 cell, with StyleSingleLine.
Seems convoluted - why don't we just declare get_logger in config, and have it encapsulate all this
 -> no need to import logging everywhere
 -> no mandatory combination of two libs and one incantation to get things to work

Also, I hate "logger." with a passion, as a name.  I am deeply in love with "log." though.
You solved a similar issue with drops by only setting drops after all materials have been initialized. Valid bases need to be set after all materials are initialized, am I correct?
The `configureCell:` method is just an abstracted method that prepares cells which is in their example **only**, it’s not part of the protocol. I’m not sure where I saw the full example code in the past, but the implementation basically does what you normally do in `tableView:cellForRowAtIndexPath:`, so you should be able to figure that out yourself.
will do.

Also: github needs some sort of annotation that means, 'I agree, will fix, otherwise no comment'.
This should say 'Deletes' :)
the overwritten function getItemName() in RequestUploadDocItem isn't needless, isn't it?because its declared in RequestDocItem.
Yeah, I think that maybe someone would connect a news post to more than one library (might not happen, but someone have asked for the possibility before in ding1).
I think all it needs is a callable right?  So I imagine ``SortedDict`` would work fine on its own.
+1 on skipping jquery event, if someone needs a jquery event they can write their own version of `transitionTo`
This changes the behavior from the comment above.

`g.run_action(:create)` creates the group at compile time.
I'm going to change this so it's done via the OTAD constructor instead of the builder. Otherwise existing subclasses that don't use the builder will break.
This seems like less work on the critical path:

Principal auditPrincipal = principal;

boolean authenticated = false;
if (principal == null) {
   ...
   auditPrincipal = unauthenticatedIdentity.asPrincipal();
   subject.getPrincipals().add(auditPrincipal);
   ....
}

AuditManager auditManager = context.getAuditManager();
if (auditManager != null) {
  audit(authenticated ? AuditLevel.SUCCESS : AuditLevel.FAILURE, auditManager, auditPrincipal, null);
}

The null check in audit() could be dropped then. Leaving it there and just doing

audit(authenticated ? AuditLevel.SUCCESS : AuditLevel.FAILURE, context.getAuditManager(), auditPrincipal, null);

is probably about the same result though since the JIT compiler will likely optimize this.
yeah, copyright plugin got "unconfigured" :) fixed.
Yeah, that fixes it, i will push one more commit that has also this fix.
Did you un-indent this section due to a code sniffer warning?
Also, we should make this configurable as an `icons` option, similar to accordion's. Let's wait for @scottgonzalez  on that, though.
"We should consider cleaning up the SGD class 
a bit, since some old options might have become redundant."
->
    # TODO: remove SGD.momentum and implement momentum as a SearchDirection
Yeah wow, this beauty needs some refactoring love!
`App.`?
Nice fix!
Could you please create an issue explaining the remaining task here and put aTODO pointing to it?
why do you pass both the app and the icon as parameters, if the app is in `icon.app` ?
I really wish we could do this **after** the `faded` removal transition.
It makes the animation much smoother.
> I changed "capabilities" property to "security". So to write a code which can work on both APIs is impossible.

If you do something like:

```javascript
var keys = network.security || network.capabilities; // XXX remove network.capabilities when bug 790231 lands
```

would that work?
nit: Line too long (88 characters).
You may not know: we do gjslint checking before submit a patch. :)
(https://developers.google.com/closure/utilities/docs/linter_howto)
please rename s var, thanks
I started doing that for compatibility reason since it needs a pref in `mc/app/b2g.js`
I will *gladly* remove it, so verbose.

I'll add the pref to the gaia profile and remove the 2 occurrences of this in a follow up.
jslint suggests not using `'use strict;` in the global scope in case of third-party widgets, or, in this case, snippets that aren't valid in strict mode.
From reading the [changes](http://developer.github.com/changes/2012-10-17-org-members-redirection/) it appears that we can't always pivot on `authenticated?` since it may be a matter of not having the right OAuth scope or not being a member of that org. I would suggest we make the call to `orgs/:org/members` and check for a `200` or `302` and either return the body or follow `Location` header. I think we might be able to do it via middleware with [this](https://github.com/pengwynn/faraday_middleware/blob/master/lib/faraday_middleware/response/follow_redirects.rb).

/cc @pezra
I've recovered this interface and set `serverNeedLocalAddr' default to `False', so keep the most of compatibility.
~~~
また、Node Executors への入力にもつかえません。
~~~

~~~
また、Node Executors への入力にも使えません。
~~~
when is it ever not supporting merging of class name arrays? do we even need this bool?
Better to normalize this in route config stage, and set it explicitly to default there.
Should be "an IP address that should be used for database access".
Document this method and its args.
Addressing this in a follow up pull request.
I'm not going to be building the app so I need the class files, just like how we have it in sample apps.
Yes, talk # can be different than talk id. If I get correctly the id generation, let's suppose that I store 3 presentations on a cleared database, so we have 3 presentations with id's 1,2 and 3, respectively. If a remove the talk with the id 1 and add another one, we have now 3 talks with ids 2,3 and 4, but # is only a counting in order to give the user control of how many presentations his query has returned, so it always starts on one.

Regarding the room and talk issue, I agree it must be shown and have already performed the changes. The commit can be checked here https://github.com/felipevieira/freeseer/commit/d438ec1f5aac5135a04f50384b68ac59b572f887
``data-il-ref`` => ``data-inventory-line``
The grab prefixed methods are the ones where I appended parameters to the URL and enqueued the request manually. It seems long and clunky to me. Is there a better way I should have done this?
Also depends on CONFIG_EXPERT.
I really like  hte idea of banning suhosin alerts. But the above Fail-Regex is a bit to general, this way some WordPress-Installations get banned. 

I have implemented this file manually on a Server with some Joomla and WP-Installations and changed the fail regex a little bit. 

``` suhosin\[\d*\]:.*\sASCII-NUL\s.*\(attacker\s'<HOST>'.* ``` 
```  suhosin\[\d*\]:.*configured\srequest\svariable\sname\slength\slimit\sexceeded\s.*\(attacker\s'<HOST>'.* ``` 
This way most of the CAPTCHA-attackers get blocked. 
 
Should i resubmit the suhosin.conf to get at least this one in the next release?
`trailblock.trails.filter { !usedTrails.contains(_) }` ?
Is the code in there same as in line 119+? Should it be moved to its own template file to improve readability and to make the template more robust against changes?
What's the value in this else? It seems confusing
archive -> achieve
property won't work as we won't be able to change it after since loader is frozen. But sure I'll do `let main;` instead of argument.
great to make it clear that the second argument can contain anything.  **evil** was more dramatic, your word choice here is more clear.
This was never used, so I took it and its tests out.
the `+` is not necessary here
Shouldn't this be aBrowser.currentURI? You are calling this method with `tabbrowser.mCurrentBrowser` as parameter.
__whimboo__ wrote
> I would change the id of the tree to something more descriptive and which is loosely bound to the type of object, like 'variables'.

For example: `variableList`, `variablesList`, `variablesTree`?

> Also I wouldn't set a height but would it auto-adjust by the window size.

Without `style="height: xxxxx"` or `rows="xxx"` `<tree>` gets collapsed! Try it! :)

> It should be stored inside of localstore.rdf so it keeps the latest width/height across sessions.

This is irrelevant here. Resizing of the `<tree>` would be managed by the `<prefpane>`'s flexibility! See changes for `customize.xul` in #79! This issue is about __columns__! :P
Good idea. `rm *.bmp` wouldn't even work for me.
This isn't entirely clear to me: is that the count of nestings, or a stack containing them all, or something else?
Yeah, it can. Thank you.
This isn't a really useful test, as in it doesn't have anything to do with what we're testing here. We can assume that Class.new() works as it should, this isn't the place to test that :).
lolol but that makes the code one line longer
why move this out isActive
add the comma the trailling comma, avoid to have two lines changed in future commits
Come sopra.
Odd, when I add the type hinting it fails with:

Argument 1 passed to Zend\Form\Element\Color::setValidator() must be an instance of Zend\Form\Element\ValidatorInterface, instance of Zend\Validator\Regex given, called in /Users/cmartin/Sites/zf2/tests/Zend/Form/Element/ColorTest.php on line 72 and defined

Yet Zend\Validator\Regex extends from AbstractValidator, which implements ValidatorInterface. Is this a bug in my php version? (5.3.9)
True - CS decision from before my AWOL months. Also, it should be moved into Exception namespace I think.
Maybe you could think that this is incompatible with #1550, but don't change this now because even removing this line will be a conflict in the merge with #1550 and one PR will be need to be rebased.
Converting to UTF-16BE here so we can call bin2hex() on the char.
Argh! This is what you get from using 3 different editors. - Fixed in the last commit.
throwing the exception when sslcapth is null force to set the option previously, however PHP.net manual take this value as recommended but not mandatory.

So I think that `null` shouldn't throw the exception.
ftw.tagging is allready installed... remove it from upgrade step
@q--  Told me the processing was faster if the string were more precise, it seem logical....
I also added a call to `array_unique` to ensure that a given field is specified more than once, as that would just waste time
`var ENTER_KEY = 0x0D;` -> `var ENTER_KEY = 13;`
Yeah, I guess I see the decoder as responsible for decoding json data, not necessarily an http response (again, my hope is to re-use the decoder for websocket payload)
Actually shouldn't these be in lambda's so the time is calculated when the scope is run not when the class is loaded.
This is usually set from the parent class.  I think if you get the latest master, this is mostly fixed.
Is it possible to define `nth` with a call to `__getitem__` instead of duplicating `__getitem__`'s code?
or we make a new class LdapQueryExtended that has eg the VO and project functions; or make a class with the Vo functions, and one with the project and then use a new class that inherits from both
I think the more descriptive parts should be added in the docstrings of configure/make/make_install/..., no?
Why do we only allow these keywords to be changed?
Should be well documented.
wrong indentation here. It should use 4 spaces per level only
When I push to the jboss-as-quickstart@jboss.org domain I get an error about a missing pom for every quickstart, for example:

                    remote: [ERROR]     Child module /var/lib/stickshift/a4c2a37ddfe24123aac368c440dbebb9/helloworldrs/runtime/repo/bean-validation of /var/lib/stickshift/a4c2a37ddfe24123aac368c440dbebb9/helloworldrs/runtime/repo/pom.xml does not exist

Obviously, I don't get these errors pushing to a domain I created with my own account so I'm not sure what's wrong with the open shift domain. Any ideas?
We could at least make the checking bit a function, that way it would be a bit more DRY?

I haven't really used much bash scripting before, I'll try to make it a bit better once I'm done with my exams this week.
Why drop this completely?
This sort of style clean-up is more OK because it's right in the middle of a file you obviously edited. The `users/urls.py` change below is strange because you otherwise didn't touch it.
But what about when there's no JS? Why have it be a link at all then?
Because it doesn't exist in our code.
Yep, that's what we (collectively) mean by it!
Why not use standard `/.../` regex syntax? There aren't any slashes necessitating `%r`.
Too much English for the code. Use a template instead and do something like 
```python
message = render_to_string('manage/_email_approval.txt', {'group_name': group.name, ....
```
I wanted to show how to create a self-reference URI since it is not easy to guess. Arguably it doesn't belong to a bootstrap app but to some examples confluence page.

What to do? Delete, comment out, leave as is, modify somehow (how)?
Committed fix by using require_once.
yup! :-)  Get the user to actually read the information rather than just "oh, I see ice cream, must be this order of words"
取到的数据结构是要给host的配置？这个返回值是由什么来决定的呢？
This might take people by surprise a bit? Might be worth having some friendlier formatting here.

```puts "Migrating #{args[:tag_id]} to be a child of #{args[:new_parent]}"```

?
I'm not sure how to interpret this. How is rotation determined unless the PSF and the data both have WCS info attached?
Straight quotes, pelase
Could also use a little note on what the class is for / used by etc.
is `iif` a mathematical term? I've heard of `iff` but never this
@tallowen Good! As in, good that you're aware of the Django 1.4 changes. Now I can sleep at night.
Straggler debugging statement?
Do you know some Python folks I should be asking? The alternative is to use [urlparse](http://docs.python.org/2/library/urlparse.html).
Oops, this shouldn't be here any more.
The responsibility here seems a bit wierd.  You're creating a file at plugin install time (that is essentially a static file, so it could just be checked in and copied at build time).  The file you create is reading dynamic configuration, but updating global attributes that belong to the application.

Because plugins are rails engines they will get loaded as part of the broker load sequence - you could just move this content to a real file in your own gem, then in your initialization code for the gem, read the config and apply it to the broker.  Putting the file into the broker dir seems wrong.
As above.  systemd based distros will be addressed later.
I thought that Nick recently changed this instance of "node" back to "certname"?
I removed this because rails_admin trips on this but I would love to hear a better workaround.
Weird that the tests all passed - I'm guessing there's no test case for this? :trollface:
Can probably be removed for now.
I think I need to see some rationale behind this. My initial thought is that casting these values to boolean is the concern of the consumer of Cassandra.js, not Cassandra.js itself.

Also I would be concerned of the impact on performance for taking this on, in every single query, for every row and column received from cassandra.
Will this eventually have to change to support the "custom name" functionality that OAE currently has? i.e., it checks if the "URL name" exists, if so, it lets you specify a different one. This API would likely need to take **that** name in as a parameter, rather than stemming it down under the hood.
If the url can be created so that it works with our without the extra `/:replyTo` I agree.
In 25 words or less discuss the pros and cons of putting this additional stuff in the setter :)
Но, как мне кажется, это не очень правильно, а как же обращаться к родительскому init-у?
Спасибо за замечение, учту в будущем. Если необходимо могу исправить название метода и залить повторно.
@lilumi пардон, я не то посмотрел. Действительно, тот метод возвращает созданный массив. Но всё равно, человек создал свойство (readwrite), автоматически есть доступ к сеттеру, так что сделать что-то вроде
```
Cell *cellObj = [[Cell alloc] init];
[cellObj setDNA:[NSMutableArray array]];
```
После этой манипуляции у cellObj пустой массив DNA.
В данный момент переменная DNA у вас доступна для изменения из вне.
```objective-c
Cell *c = [[Cell init] alloc];
c.DNA = [NSMutableArray array]; // разрешенная операция
[c.DNA removeAllObjects]; // разрешенная операция
```

Советую изменить определение свойства на такое:
```objective-c
@property (readonly) NSArray *DNA;
```
Тогда  с указателем на массив и самим массивом за пределами определения класса можно будет работать только как с константой.
of course :)  but I didn't see a test for the DocumentPersister class... hmm looking more closely it seems I should add it to the PersistenceBuilderTest?
As above, this should be precise lifetime'd.
This should just be `-map:` or `-mapReplace:RACUnit.defaultUnit`
I must verify what is the exactly error this generated. But as I can remember, PostgreSQL is not so fair like MySQL with bad SQL.
Nazwijmy to może pytaniem pomocniczym. Czyli "Odpowiedź na pytanie pomocnicze jest niepoprawna".
src.info should always be defined. The branch is I think unnecessary.
Do you mean the result is an int32 (long / `i4`)? Why is that a problem? Can you give an example?

One possibility is that if the first number (`event[0]`) is smaller than the second (`res[0][0]`) and they are both `uint32`, one might expect a negative result, but this would get wrapped to a very large positive number since the integers are unsigned. Is this what you're seeing?

In any case, it's probably better to cast everything to `i4`, since this allows for a larger range of lags. (Why limit it if we don't need to?) I'd also recommend casting prior to the subtraction to avoid any undesired results in case the subtraction goes negative (response leads event), which I could imagine happening in some cases.
Will try with Cacheable, the think it worries me is how will the property listener invalidate these entries. I guess I should read Spring documentation.
Maybe add a note that domain names can be used, and that "salt" default value is for when you configure your domain with a "salt" entry poiniting to the salt master serve.

master IP address / FQDN / master's hostname.
Done. Good catch
Should be 'apklib' if anything
Have you tested what happens if the mongo object has already had authenticate called on it prior to this?  My recollection (which I fully admit might be inaccurate) was that it throws an exception.  That might occur in cases where the user has multiple libraries that use Mongo and support authentication in their Spring configuration.  I'll try testing this.
This should be:

    // the Eventdispatcher used by the HttpKernel
    $dispatcher = ...;
Some of these *may* not work - I won't know until I render it. The markup has to be just right with multi-line numbers for sphinx to recognize that we're continuing to (2) and not starting a new list.
if able_to_store_created_at?
pretty sure there is `helper.isDefined()`
Ты уверен, что у тебя такая фамилия? )
This part I don't understand
Gracias, lo tengo en cuenta
Ruby methods actually often don't an explicit return statement. The method returns the value of the last statement executed by the method.  So you could just say "greeting" on this line and you would get the same result.
you must catch exceptions here
Please avoid configuration options based on properties. Let's use normal config pojos :)
Just the restart. It's this test that detected the ComponentRegistry bug.
I'm not sure how much fun it is.
Nah the API will be fine… it was just me misinterpreting how `git_diff_patch` was implemented. I doubt people will want to do more than simply iterate over the diff anyway.
Also, I think this is mistake. Should this be `self.auto_scale_xyz(jX, jY, jZ, had_data)`? Or am I overlooking something?
Let `xs = [1, 2]` and `ys = [[1], [2]]`. This will evaluate to true. Does it make sense to pass `xs` and `ys` with different shapes?
Then again, the assignment of font would pretty much mess up any ternary...
Either is fine in my opinion, though I think I'd prefer just to stick with numpy.

Let's leave the decision up to @NelleV regarding which one to use. Once that change has been made I think this is fine to merge.
What is the point of this? When would you ever _not_ want to return on success, given that you can just discard the return value.
Why does this file exist? Bit of a weird filename...
it is convenient to bootstrap the autoloader of composer; it helps in autoloading the tests and thus doing less requires
Remove this .old file.
Red flag when we see `(pack)` getting called (it should be internal to thrift namespace). In `p/chunk` we're just creating a `DataChunk` via its constructor which should accept the raw `?chunk`. Submitted issue #86 for this.
please use this style for else conditions:

if( ... ) {
  ...
}
else {
  ...
}
Code and functionality looks good, I'll fix this typo when merging.
@arnodeclercq could you also add a regular background statement with no gradient (to support IE8)
@arnodeclercq always make sure you have an extra line for each file so git doesn't complain about it.
get_sigma could be there as well
go left
Putting SQL in the docs slightly defeats the purpose of the abstraction layer, but its a much more distinct way of actually describing the feature to people who know SQL, so worth the tradeoff in my opinion.
Can your speak "ctxs"? %)
isContextsEqual
this.assertEqual('function', typeof $('element-insertions-main').down().onclick);

will be better - at least it will show difference between expected and actual type
Stylewise, this should be probably be `supportsLocalStorage`.
application -> application's
> I understand your frustration, but I'd say that's a reason to fix and improve the test framework, not a reason to give up on testing. We haven't had a change like this which can really only be tested functionally in a while, so this is just going to take a while longer to work out.

Well, if you can figure out why $db->sql_escape() is returning no value from its use around line 158 in extension manager, but only when called from a test (and while other dbal methods work fine, afaik), that'd be great. I'm stumped.
You're right!
It's done and pushed :-)
Same line as WHERE please
直接require吧，文件不存在就抛异常。
Again, removing this could be a BC break if people are depending on it.
This class needs to be broken out into its own file.  We really want to have a 1:1 relationship between classes and files everywhere unless there is an incredibly important exception to be made.
How about changing it to FlipViewController(Context context, int orientation)? The valid values of orientation could be the constants you've already declared.
What is the base date?
I can't see any JavaDoc on the method or an explanation about why you're now using this.
The approved sort is synonymous with the best date sort if ``use_original_date`` is ``False``, and sometime in the future, ``use_original_date`` is slated to be removed. It doesn't seem very useful to support sorting by approval date twice. If this is a major backwards-compatibility issue, then I could add it back in for now.
I suggest changing the meaning?
not needed anymore then :)
"The ReceiverBehavior interface represents actions to be taken given an output stream connected to Splunk over which a program can stream events."
It didn't even show in diff
```
LAZY_USER_EXPIRATION = 30 # days
```
That would be tricky since the `RandonNumericSequenceGenerator` class does not return duplicates. If this is changed, then the same numbers will be returned after some point. By default, this happens only if a client generates more than 2.147.483.647 on a single instance.

On a custom, smaller, range it might be annoying to throw an exception. Noted down.
Würde ich auf 120'000 setzen und ins Config zeugs schreiben.
Zweidimensionale noch böser! ;-)
I think we could simplify this view a bit by making the form's save() method return (search, status). Then we could use search, status = form.save() here.
`ServiceFactory` -> `AuthenticationServiceFactory` ?
minitest is included with Ruby 1.9. The ActionController test stuff depends on the 1.9 stuff, adding this as a dependency here results in bundler requiring a newer version.
move this outside the candidate loop
Since this line continues a statement on the previous line, it should be indented again?

Not sure on this because it's a continued statement within a continued statement. What do you want to do with those style wise? I vote for another indent.
Здесь хватило бы простого return. SytemExit стоит бросать из вложенных в глубь стека функций
I all other cases you are pushing the 'value_template' but here you are replacing it. Is that OK? If so it's not really clear why.
isn't a regular `push` OK ?
This might be for consistency, but we should use `_request_id` for our own code.
"0deg"
Old code, but I don't know why 4 is significant here. A comment would help.
I don't think this does the same thing.  Your version overwrites the value returned by `ngx_array_push` when it does `ngx_list_push` below.  It will correctly add the cache control header to `r->headers_out.headers` but it won't add it to `r->headers_out.cache_control`.
I prefer `zstyle -a ':omz:plugin:gnu-utils' prefix 'prefix' || prefix='g'` since it's more clear.