labofsahil/github-event-dataset-2012 huggingface dataset:
Thanks for getting the cruft out. Forgot to remove this when I made it a "reusable" app. Yeah, I use that term lightly.
hmm.. this one I had changed according to WPP :P
Hi.

I see you write http://www.pymolwiki.org/index.php/Pycheshift in the info box.
Please change to: http://pymolwiki.org/index.php/cheshift
Unfortunately, it's not clearly specced [in the documentation or in practice](http://stackoverflow.com/questions/1074928/should-the-junit-message-state-the-condition-of-success-or-failure), which is one of the many reasons why I hate JUnit :-) Either way, "GIF should match 'test.gif'" &c. should be clearer to read in both the test output and - more importantly - the code itself than "GIF does not match 'test.gif'" &c.
We normally have the templates in the default location. I.e. home/index.tt instead of home.tt
We need to update the text, to give the right answer, and also tell why this should be redirect in a comment or something.
And the sql support ? :o it works ?
This is poor modeling. The PageList should have an "activePage" attribute and send "change:activePage" events for views to subscribe to. Then the PageListview should listen to that and add or remove the active class on that right page. This same pattern will be followed for paragraphs when we add the idea of selecting a specific paragraph (for editing).
Actually, it would make more sense for me just to delete those files and pull your versions instead, so I'll do that.
funguje list.remove(..) aj pri iterovani, alebo to sposobi preskakovanie prvkov?
Well, havent been able to throughly test this yet, but sending MMS to myself does works fine.. but I never really noticed any issues before either..so cant really say for sure (also I havent really had any reports of any MMS issues either from my users).. But my whole source is based off of 'master' branch instead of 'ics-mr1' or 'android-4.0.3_r1' tag.. so there could be something thats different between them that always fixed it for me.
So far we haven't used mail addresses within the listings. I think we should align on one style.
I think those parts are better places in the issue tracker. Basically it's ok to also keep track of those points here, but for every point there should be al ink to the issue tracker
You can play with the feature of conditional evaluation to put two chunks in the same document, but evaluate one this time, and another next time, e.g.

```r
<<>>=
bw_version = TRUE # change it to FALSE for colored version
@ 
```r
<<hist-bw, eval=bw_version, echo=bw_version>>=
qplot(...) + scale_gray()
@ 
<<hist-color, eval=bw_version, echo=bw_version>>=
qplot(...)
@ 
```

It is unbelievable that experts like Hadley and Baptiste do not use `\tableofcontents` and they prefer hand-made table of contents! No, no, no...
lmao thanks
Probably I just didn't notice.

-Darius

On Wed, Mar 7, 2012 at 11:59 AM, mogoodrich <
reply@reply.github.com
> wrote:

> Any reason you didn't change the connection and developerConnection tags
> here as well?  I just updated the HFE pom, but don't really know how to
> test if it is configured correctly until I try the next release:prepare.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/OpenMRS/openmrs-module-htmlformentry19ext/commit/89fdb08636f15b59b0f5690fa260a1e37534536d#commitcomment-1054376
>
No, absolutely not. Now all is getting into the build, and the kernel :-) without using my copy script
Perhaps:
```def dependsOn = [springSecurityCore: '1.2.7.1 > *']```
You could set up a virtual host on your machine for static.getnightingale.com and then map this domain to your local loopback 127.0.0.1 using your /etc/hosts.
It would be baller if this did a `detect` and checked the address wasn't RFC1918 in the second clause, or used `last` since they *seem* to be stable, and public are usually added last.  Still a huge improvement though.
1. This function needs phpDoc comments.
2. Can we pass $accept_language and $available_languages as parameters to this and then write some tests to verify correctness and help me understand what's going on? That'd be the sweetness.
if you want to log anything, we should probably use a Log instance
Interface comments would be specially helpful to understand the component's purpose.
Indeed, that was a specimen FIXME for all other classes. The same goes for all the `__call__` functions which are yet untested.
It's worth noting that node pool names set here should never be seen by the user, only used for backward compatibility.
move down "(if using"
it is optional, with the default being off. Note that this is *not* used by the ActorLogging framework – it's only if someone wants to have the AkkaLogging API available in a non-Actor context (and here it will be implemented by Java Logging)
FiniteDurations?
Same thing here with comment at beginning of line.
Here we have something that might be (at least) confusing.
We are in Closed and some call triggers transition to Open. Another call started in Closed and is running in parallel and when that is sucessful it will set the failureCount to 0 even though we are in Open.
PR-675-merge: here you will use settings.MetricsEnabled
Yes, @arokem please change get_sphere to return a sphere object. I can happily merge after that.
I'd like this to use the helper functions h.add_url_param() like in group controller so we can slowly move the functionality out of the controller but maybe that's just my desires
fixed. added extra line between all methods in the file
we can't hit the DOM from in these templates, they execute rows*colums times every render, so that's a performance killer. i thought the plan was to only set the width of the top row, what's your thinking?
Looks like copy paste from another test class...not super important, but refactoring would be nice to ensure all SequenceActor have the same properties.
You can drop itemSourcePath and just set itemSource.strPath and itemSource.strName directly.
same global issue here.
instead of "you should buy" lets call it "optimal pool of reserved instances that minimizes cost" ..or something more objective.
optparse weirdness. Better to explain in person. In short, if you specify `-M x -R y -M z`, then optparse will actually parse them in the order `-M x -M z -R y`, even if they have the same `dest`.
Remove the factory because it is a dictionary table
Please use audited transaction - the changes should be attributed to the htgt robot, not individual users.
Please use '@mi_attempt.mi_attempt_status.name' - I want to make 'MiAttempt#status' the association name rather than a string to be consistent with the other models eventually, so we need to stop using that.
this should probably be 

    loc_seed = max_seed*g_proc_id + (seed + step*max_seed) % max_seed;

or

    loc_seed = (seed + step*max_seed) % 2147483647;

making it unique.

The current solution limits the loc_seed to the region 2147483647/g_nproc
Really?  I could add a completion block in five seconds.  @maxgoedjen literally only needs to add one line of code
Thanks! So aside from the (what I think, is a bad idea) if statement spacing, is this good to go?
errno = 0;
yes, its all the same static class LibPD. the lock is the static class itself. so it should be safe.
Well, in C you start writing at the given pointer; if you want an offset, you can just add it to the pointer, and so the C function doesn't need a second offset parameter.  The Java version, on the other hand, has a second offset parameter.  As I said, PdBase.java should really be the model for the C# bindings.
_list_outputs returns abspath - isn't that enough?
The output of this method is a map. Therefore ICC is calculated independently for every voxel. HAving just two input volumes (one subject scanned twice) you will end up with two numbers for every voxel. There is not much you can do with that (by analogy it would be similar to answering the question of what is the correaltion betwen numbers 1 and 2).

NPAIRS, as far as I understand, calculates one Person r for every half-split run. In other words it takes two measurements for every voxel and outputs one value for the whole volume.
Else clause dropped...
<del>word</del>  clause
Do we really need for so many resp formats? It would be good to include some additional tests for the following:

* Key normalization
* Keys longer than the cache can support
* Values larger than the cache can support
Строка влезает в 120 символов (3.4)
`.blank?` fails the tests, because the left half checks that it's not nil or false.
Is better to use `tr`. `tr('_confirmation', '')`
That should work almost as well, since the Result isn't per returned instance.
We should not reference ActiveRecord from the Rails directory. Or we should move this validation to the Active Record migration generator or provide a similar error in Rails. Given that this validation is specific to Active Record, I would do the former.
Sure. Give me something and I'll use it; I think since the guide is already mostly about AJAX, that's a bad idea. But I'm not tied to Fibs, it's just my go-to.
Rails uses the +debugger+ gem to set breakpoints and step through live code. To install it, ...
It'd be good to also add a test where the hash contains more keys than the required ones, and it should not raise.
What are we optimizing?
You're absolutely right. 7cbe52e adds another test case for it.
Hm, I guess I took it out because of the context of "explicitly render" in the test suite. The tests which deal with passing a block to mail are called "explicit" and those where mail is not passed a block are called "implicit". So the documentation as written, when it says "explicitly render", is referring to the block syntax. And, of course, I've removed the ability to set the mimepart ordering when "explicitly rendering".

But... I just realized I'm not sure what you mean by "it still works" - what exactly still works?
@guilleiguaran ask to  made a new update pr to continue the discussion about [this revert](https://github.com/rails/rails/commit/4b20cd9c663a417353e4d0388189af71cc642fca). Thanks for your patience
Reads much easier on one line for such a simple condition. 

Just realized it should do comparison on symbolic and numeric status so should be:

```ruby
self.response_body = include_content?(self.status) ? " " : ""
```
This variable looks like it's still available -- why are you removing it?
No need to preach to the choir.  


On Friday, July 6, 2012 at 10:08 AM, Jason Zaugg wrote:

> >  
> > def unapply(t: Throwable): Option[Throwable] = t match {
> > case e: StackOverflowError ⇒ Some(e) // StackOverflowError ok even though it is a VirtualMachineError
> > // VirtualMachineError includes OutOfMemoryError and other fatal errors
> > - case _: VirtualMachineError | _: ThreadDeath | _: InterruptedException | _: LinkageError ⇒ None
> > + case _: VirtualMachineError | _: ThreadDeath | _: InterruptedException | _: LinkageError | _: ControlThrowable | _: NotImplementedError => None
> >  
>  
>  
> Whatever we call it, it is important to Scaladoc it well enough that someone doesn't need to read the source code to know which throwables are caught.
>  
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/scala/scala/pull/830/files#r1111390
>  
>
Tacking booleans onto established methods is extremely ad-hoc and I hate it.  Please don't inflict a meaningless boolean onto changeOwner.
Please remove this line and the following line. They are outdated.
remove html in `<pre>`?
This should be [elem["frm_name"] for elem in result]
Nope, my mistake. I was supposed to replace that with abs once I finished comparing the results with what QuTip was producing. Will fix it, now!
Should I then delete kauers.py and take that finite_diff into polytools.py?
This doctest is the only test that we have for this function. Can you also add a regular test for this?
Meaning that this function is probably not even needed, given that LT already exists and does the same thing.
But there shouldn't be any problem with custom numpy/scipy.sparse logic in density.py though right?
And if they are made global, probably they should go to `util`?
I think I like that better, here [i.e. without the extra import].
我新的的确是，现在又pull request了。
I think this can be further simplified as a one-liner:

```r
rst2pdf = function(input, rst2pdfpath = "rst2pdf", options = '') {
  system2(rst2pdfpath, paste(input, options))
}
```

`options` default to `''` so that you do not need to check if it is `NULL`
Yes i've tested it. Testing code:

```php
<?php

var_dump(phpversion());

class TestClass1{}

class TestClass2{
	public $className='TestClass1';
	public $obj1;
	public function run(){
		$this->obj1=new $this->className();
		var_dump(get_class($this->obj1));
	}
}

$obj2=new TestClass2();
$obj2->run();
```

Results of executing this code in various environments:

My Win64 workstation:
```
string(5) "5.4.3"
string(10) "TestClass1"
```

http://writecodeonline.com/php/
```
string(6) "5.2.17"
string(10) "TestClass1" 
```

My production server (CentOS 5.*):
```
string(6) "5.2.17"
string(10) "TestClass1"
```

Another production server (CentOS 6.*):
```
string(6) "5.3.14"
string(10) "TestClass1"
```
Because this file is being translated now by another person. He is supposed to be pull-request this file shortly.
Да не же... Просто использование массива $this->aBlocks вы полностью убили в Shutdown и заменили его на

$this->Viewer_AddBlock('right', 'block.info.tpl', array('plugin' => 'mhb'), 100);

Я вот о чем.
It's actually the constraint someString=qq that is invalid - not the content.

On 12/03/2012, at 18:07, Ben Hood
<reply@reply.github.com>
wrote:

>> +      ))
>> +      fail("Request should have failed with BadInventoryException")
>> +    } catch {
>> +      case e:InvalidInventoryException =>
>> +        assertEquals(
>> +          "Inventory was invalid: Entry 1 was invalid. Identified issues were: someDate: property is missing",
>> +          e.getMessage)
>> +    }
>> +  }
>> +
>> +  @Test
>> +  def shouldRejectAnInventoryUploadWithInvalidConstraintsWithABadRequestResponse() {
>> +    try {
>> +      env.inventoryClient.uploadInventory(env.upstreamEpName, Seq(new SetConstraint("someString", Set("qq"))), csv(
>> +        "id,vsn,someString,someDate",
>> +        "id2,v2,qq,2012-03-10T10:05:12Z",
>
> What is the invalid constraint here - is 2012-03-10T10:05:12Z supposed to be a date or a datetime?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lshift/diffa/pull/60/files#r544333
Copyrights precede the package definition in a file .....
I think this one should be listReportsForPair too, same with the comment above it
Same here – Changes reverted
It extends DBConnectorConfig
re-flowing these paragraphs makes reviewing more difficult. 

avoid doing this unless you making a significant substantive change, otherwise it wastes time.
collection == collections
"level" isn't meaningful in this context 

when enabling profiling, you also configure a threshold for the operations that the profiler will capture.
Nit: single-quotes.
So does this fall back on `get` if  `is` doesn't exist?
Fixed them all locally.
I understand that perfectly, hence what I wrote above applies.
Analogously to my comment for viewforum, the list of forums where reading is allowed must be intersected against queried forum list, if all topics in all forums can be read then do not add this condition to the query.
min and max length of what?
Always cast to integer here.
`normalise_filename($name)` ?
De exemplu, într-un form:
câmp = forms.CharField(max_length=30, label='New password')
projection -> component
because they are of built in types, not objects.
* minimum required  msvc is 2010
* msvc 2012 is recommended

Guess that  would be better
callback check. I'll stop noting them individually, I'd just like us to adopt a common pattern of checking they are real.
@param contextPath missing
A scalar cube e.g.
```python
cube = iris.cube.Cube(23)
```
will cause this to blow up.
As above, this if statement can never be true.
The or should be at the end of the line according to PEP8.
Can you make it work with axis = None?
You can have a look at the latest version of SortOp, where it works.
It's probably a good practice to escape commands to avoid aliases when you rely on the output format, e.g. \ls -1 ...
Ditto not public.
Why do it on every call to that function?
Shouldn't the caller free doc? Always dangerous to have functions free data structured allocated by calling code.
Ok, thanks for giving it a try anyway
is doing this enough to get window as the context?
Oooh, dead sexy.
The order for options you choose seems as random as the one we had before. Why not put them at last in alphabetical? Or is it the proper order for better compression?
Check the tree_id is within a valid range.
This event handler looks like something that could be merged into the on("click", "a.delete.desc") handler with some clever rearranging/renaming of code.
I think you forgot to write this file to disk?  I ask because this clause is unused.
bad indent of doc string
Yeah, to be honest I was a bit surprised here also – just try removing everything except .primary and it won’t look good. The keyword is selector specificity: http://stuffandnonsense.co.uk/archives/css_specificity_wars.html

The issue here is that if, say, input[type="submit"].primary isn’t there, then the simpler input[type="submit"] takes precedence over .primary – which leads to the button being the simple white one. I’m confused because I presumed that .primary had a higher specificity anyway, but apparently that’s not the case.

@Raydiation do you know more? The only thing I know is that ownCloud CSS definitely has to be simplified. :)
Thanks, I didn't know about that one.
Should be protected I suppose ?
I did think about doing that but for reason didn't, I'll add it in.
Why did you leave the commented out code? Lines 24 & 25 too.
@dsaff 
pls see my latest commit
not very clear
`class @LifeCycleStateMachine extends Batman.StateMachine`
Why are we using `newColor` here instead of `correctedColor` (as in the "input" case)?
I added a task to this backlog Card #126 "Remember user mode per file extension	As a user when I open a file and specify a specific mode I want Brackets to remember my descision"
сборку translates to “assembly”; I think “версию” (version) would be better?
Actually, that won't work because I need to detect when the context menu is shown (not when the user clicks in it). There isn't really a way to do this right now without injecting something into the context menu code. I'm inclined to defer that issue until we fix up popup management.
Noone relies on this state object anymore but the noderunner
So, two things. (1) Why is this wrapped in a try/except? What are you expecting to fail, and if nothing, don't let it fail silently!! (2) if you look at the two if blocks you'll notice they look exactly the same except for a single string that's used twice. Python actually has a special built-in block type made for exactly this use-case: the for-loop!
This is checked automatically. You have to use CSRF in the form, though.

Write `TODO` comments like:

```
# TODO: Use POST instead of GET
# TODO: Use CSRF token in the form
```

In this way IDEs can parse them and display them.
I'm curious, why do we need to update a trackevent immediately here right after creating it?
Yea I don't know about the line above, let me do some testing and report back
Here, this API key stuff...
You can just chain the .forEach to the filter above
ah yes! missed that :)
I'm not sure there's a clear use case for a timeout.  If there is some AWS outage that makes the background job fail repeatedly, I don't think that necessarily means we should stop trying to do the update - we just want to keep trying until AWS comes back up and it works.

I think if you have a use case in mind for a timeout then we should express that as a user story and add it to the backlog.  It's not a feature I'd want to add without a clear understanding of the requirements.  Since the timeout can be a separate feature, we don't need to add it in this PR.
This header looks wrong...
should be an absolute path
See if you can use a case here instead of _1 as in the other class
You could skip this line since you're creating a notification before and after now neither of which are going to show in the same test.
Actually, why not replace the ternary and just combine the check with the if statement on line 132.
@jsomara YOU'RE CODE IS AMBIGUOUS!
Just curious on this one - is `{}` a shortcut for `do..end` ?
I didn't write the code. Add yourself, it's your work. :-)
Besides this and a couple of other minor things I have mentioned, the patch looks great.

Please update JIRA ticket with the latest patch when you are done with addressing those things and I will proceed with testing and merging it into trunk :)
Because there are more things to come as I add proper cleanup of unused networks, and unsubscribe is just the first.
另外，好像$data不能是null啊，如果是null，下面所有的setter就没用了，而且没有其他地方能塞一个data进来
http://msdn.microsoft.com/en-us/library/windows/desktop/ms647581(v=vs.85).aspx
MF_HELP = 0x00004000L -- Indicates that the menu item has a vertical separator to its left.
Every half a second is not fast, even in human terms. I'd prefer the simple semantics of "if there is outstanding immature balance, poll every half a second".
We generally avoid private methods, favoring protected ones instead.
@jellehenkens: for your interest:
http://www.php.net/manual/en/language.types.php
all of these calls to freeaddrinfo() are kind of a mess, is the storage size of `struct addrinfo` defined in the header files? can we put it on the stack and have a wrapper function which does the getaddrinfo(); Bits_memcpyConst(); freeaddrinfo(); instead?
please use ``call_user_func`` to allow any callable type on 5.3
The logic of this check doesn't appear to be correct. If the toolkit option is 'default' and the ETS_TOOLKIT flag is set to 'wx', then the warning should be emitted but it won't be. I don't think the "toolkit_option != 'default'" should be there.
Let's not use camel case in the Javascript, so `add_dropdown_list` here.
I'm actually working to change the hardcoded network for hostonly. Tomorrow I will commit to the same pull request, if you don't mind.

@jclouds: adrian please wait before merging this pull request
Why do you undent here? You can only copy ace when it's compiled...
a `git_free((P)); (P)=NULL;` is missing here.
I did not copied a lot. I looked at the code and wrote it without looking at the old code all the time. So maybe some of this stuff is correct in old client. But I will check it.
There needs to be a ``not is_list`` check for the first half of this condition, I think. Also on line 74 and 185.
You'd still need `S.in_directives = false` here. ;-)
`base.html` is gonna disappear as we responsify everything.
what browsers still need prefixes? boo
We should probably give them a heads up today that it's coming. I suspect this affects a bunch of people and they're going to be happier with more notice before the fact than after the fact.
This seems like an unrelated change?
Did you mean "True" here? If not I am confused what you are suggesting :)
It is indeed in a lot of different places. I intend to clean that up with a lot of other middleware things when I am done moving services.
We should specify a commit so there's no unexpected surprises.
are you trying to save the memcard profile after every song here?
Instead of doing this, why not just populate a cache file or some other writable file in a writable directory, then simply include that into the main routes.php?
I think this "hack" might work in this case because you only need to use the QObject information to hook a signal to a slot. This avoids you needing to link to the module. (I assume the AvatarModule loads).

If you wanna do it proper and the linking is not a problem.

https://github.com/evktalo/naali/blob/7dc1831b84f9f233a473a01a001763b0367cc515/src/Application/AvatarModule/CMakeLists.txt#L25
<pre>
use_core_modules(Framework Math Scene OgreRenderingModule Asset Console ECEditorModule) // same as before
use_app_modules(JavascriptModule)

// change this link_modules(Framework Math Scene OgreRenderingModule Asset Console ECEditorModule) to
link_modules(Framework Math Scene OgreRenderingModule Asset Console ECEditorModule JavascriptModule)

I can see that our startup xml:s always load AvatarModule after JS module so this wont be a problem for you. If you change that in your cmake, you can make this the proper `#include "JavascriptModule.h"`
Actually this is a base class of `ClientHttpException`, `ServerHttpExeception`, and `UnauthorizedHttpException`. Made `abstract`.
yeah thought about that too
No need to document protected/private methods.
missing spaces around the operators
What about just `path()` and `notPath()` for the method names? `contains` is used to check the file content, so it seems wrong to reuse the word here. And `path()` is more consistent with `name()` as well.
I didn't run a script.  Might be emacs automatic indentation fix.
Why don't you create new message into JsonParserWorkaround -  ```- (id)objectForKey:(id)key orDefault:(id)defaultValue;```   with 2 params 'key' and 'defaultValue' and implement null check there?
this is going to leak a very unhelpful `Not_found` if the file is not well-formed for any reason. Shouldn't `read_config` below transform that into a better error?
waarom 123?
Yes, this file needed for manual js debug of test file.
let it be a normal member, not a pointer.
std::cerr << "--histogram: invalid size " << size << "\n";

Give a bit more of a clue about exactly what went wrong.
The docs here need some work - can you condense down the behaviour that has been specified on the mailing list with respect to things like how the ROI works and how it interacts with data/full/overscan regions, how alpha works, what the threads parameter does (in particular, what -1 does), etc?
prefer 'fgetc' for this?
Not sure about this. It will mean that any features which cross the dateline only get one half drawn?
I agree, superfluous php tags removed with commit https://github.com/ding2tal/ddbasic/commit/714ee85634cfb24fc0792f1d36d9d057e1c4af47
Good catch. Simultaneously doing collection view docs was probably a bad idea.
I had that, but then it would start inserting enable-statistics where none would be set.
I just find the #getRequiredService() method but the following code give me a null Cache :
```java
final ServiceController<?> cacheService = context.getServiceRegistry(false).getRequiredService(cacheServiceName);
final Cache cache = Cache.class.cast(cacheService.getValue());
```
What is the best way to "fail accordingly". I can check if the Cache is null or if the state of the service is not UP but I don't want to manually throw a new exception. There must be a common way to achieve this right ? :persevere:
Why are you blanking out the exception stack traces?
No it doesn't, because CSS files can reference the assets using relative path, but Javascript files can't (everything is relative to HTML for "path" in Javascript)
Might be related to other crash.
Event listener can be bound on the upper level DOM element.
bot.io has a queue two jobs cannot be run at the same time.

Your right though I should probably use a pid file.
Can you also remove telephony and power? (and then we're good to go!)
The end of those cases are the same. why don't you simply set view/fakeView/ this.onCallInitialFontSize part of the switch and apply the common logic once.
Did you know that events have constructors now?
You could do openFrame.dispatchEvent(new CustomEvent('appopen', { bubbles: true, cancelable: false, detail: {origin: displayedApp}});
Eric told me the platform API will do the check before notify the 'bluetooth-opp-receiving-file-confirmation' message.
So, I do the double-check after user accepted the prompt. I also feel that is unnecessary. But I agree to do the check before showReceivePrompt().
Why are we changing the algorithm of 'counting' how many items we have to delete? I think is out of the scope of this pull...
Probably we should remove this alert ... this was added for debugging and testing purpose but not needed at all :)
If it comes from debugging code while developing please remove.
`this.markMessageRead(list.shift(), value, function readCb(result) {`
This line could be moved to the top of this file.
Might want to add a quick note as to what syncing the repository does. I see the "At this point" at the bottom, maybe incorporate that up here. My rationale is that people who come here just for Puppet support and look here first don't fully understand what a Pulp sync is yet, so a little orientation might be helpful.
You should make sure you document this running code as root direct from the Internet somewhere visible to the user.
How an improvement you could puts all the administrator routes in admin namespace. To be a pattern.
Perhaps package_options = "" to initialize here, them remove the duplication below.
Add an "Arguments" section.
Add a Raises section here, and add a try/except below for any DB-related exceptions that can be thrown.
You're always comparing method with a string. Use a case/switch here.
`protected` methods should be after `public` ones.
Topic subscriptions
couldn't this just be `this.lookup()`?
I think you can do a fake cast here

private final static Object DUMMY_OBJECT = new Object();

...
...
...

return castList(object, type, (List<T>)DUMMY_OBJECT);

However, worth testing it first, might give a runtime error.
But you also use substring in getting the line length.
Either implement json-rpc (or use an existing implementation) or use a custom encoding. Don't create a non-conforming implementation. My suggestion for a custom "encoding" is to have a dict of parameters (i.e. the obvious json-encoding of the equivalent `application/x-www-form-urlencoded` data).
I think it was "right now" when I wrote it.
How about add 

    assert(factor != 0)

before return?
Linux port set resource root path in CCApplication.
Because this interface is platform dependent, so i think it is better to set resource root path at CCApplication.
And the application should set resource path at platform dependent codes, a good place is  proj.win32/main.cpp.

What's your opinion?
please always use the curly braces for the ``if`` statements
Move to header.m4
believe it or not, this file is only used by galleries.
unlikely macro?
So is this an invisible GUI component? Is it an uneditable text label?

What is the GUI representation of this class?
Anyway it was just a suggestion that IMO would have improved maintainability, but I'm ok leaving as is. On your argument regarding moz-central, I'm not fully convinced, we do try to innovate which is very hard without doing things old way. Not very important here anyway.
It will.  However, none of the applications that are actively using our dev environment can reach MPT from their production environments, with the exception of talos.  So no project has integrated the old url structure in their production systems.  I figured they might as well start using the new url structure for both production and dev.  I don't see a strong argument for providing backwords compatibility since neither b2g or stone ridge has posted much data to the dev environment.  I will notify all of the projects using datazilla in development regarding the change, then all the new projects will start with the same url format.
I thought we were going to keep the try/except around just this one line, so we can return a 403 instead of a 500 on bad credentials? That's not really critical, though.
paddings can be merge https://developer.mozilla.org/en-US/docs/CSS/padding
This probably does want to run "as if run by Puppet", which is the `-p` or `--puppet` option.
@daniel-pittman So disabling becomes a larger problem here because upstart supports start on declarations that can span multiple lines (a common example is tty1 on precise). Commenting out the start on then makes the upstart conf file syntax invalid, which means that 'service tty1 {status,start,stop}' returns 1 with invalid job. I'll need to move this regex into some sort of loop to match parens. I'll close the pull request for now and reopen when I've resolved it.
Example valid multi-line start on stanza is...

```start on stopped rc RUNLEVEL=[2345] and ((
            not-container or
            container CONTAINER=lxc or
            container CONTAINER=lxc-libvirt))```
I like this block style for handling errors; it makes the client code that's using this method much more readable.
I didn't intentionally remove the other ones.
wait the browser gives you a boxed `String`?
I am casting. Why is it better? Just because you've never seen it before?
Yoda conditioning is the best kind of conditioning
The getData() in Form have : if (!$this->hasValidated) { throw Exception }). I don't really see any other way to retrieve the bound object data if I absolutely need to validate the form to retrieve it.
Hmmm if the guidelines say so :). I must be the one who's wrong :).
Use the obfuscated method, and in all probability it will be deobfuscated next update.
This space should not be removed for proper formatting.
Ah, cool, sorry I missed that.
Probably want this commented by default.
Lets start all "events" with "on"
add a continue after this instead of use the else block.
The latest protocol version is 47
Oh ok, I just read about the plural zero!
Sorry I'm not english ;)
Can you not move all this into compile.js and allow comment directives to "contain" DOM elements generically?
This would also resolve the issue of needing to pass down the $$originalNodeType into the link function.
You will be.. rather than user, since you are the user.
hi @Ocramius

This is just a doctrine quote token, not used in SQL level
Method should have plural name if you set multiple names
ok done.

and now we dont have logging yet
Possibly

    from copy import copy
    # ...
    context_dict = copy(site_config)

?
While rethinking XmlText, I thought that with the new design, it was more obvious that an ```XmlText\Converter``` would convert an ```XmlText``` and as such ```XmlText\Converter\Html5``` would simply convert XmlText to Html5.

If that isn't obvious, I will change it, but I don't really have a good alternative since to me ```XmlText\ConverterTo\Html5``` doesn't really solve the problem since it can be interpreted as "Html5 being ConvertedTo XmlText" or the opposite way around as well.
Great that you use on() compared to the deprecated delegate() ;)
use "if ec == 0:", to make it more explicit that this corresponds to a successful run of config.guess
I think the plugin's name should be 'improx' and the dependency should be described in BuildConfig.groovy as follows:
```
build ':improx:0.1' 
```

 Without the "app.name", is it no problem?
Hi Jon,

 oops. That should have gone before committing. Fixed.

Cheers

Martin 

------------------------------------------------------
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www:   http://www.knobisoft.de


>________________________________
> From: Jon Stevens <notifications@github.com>
>To: lookfirst/jmxtrans <jmxtrans@noreply.github.com> 
>Cc: knobi <knobi@knobisoft.de> 
>Sent: Tuesday, September 18, 2012 7:51 PM
>Subject: Re: [jmxtrans] Hi, (#42)
> 
>
>In src/com/googlecode/jmxtrans/model/output/GangliaWriter.java:
>> @@ -125,13 +138,15 @@ public void doWrite(Query query) throws Exception {
>                  for (final Map.Entry<String, Object> resultValue : result.getValues().entrySet()) {
>                      final String name = JmxUtils.getKeyString2(query, result, resultValue, getTypeNames(), null);
>                      final String value = resultValue.getValue().toString();
> -                    log.debug("Sending Ganglia metric {}={}", name, value);
> +                    log.debug("Sending Ganglia metric {}={}", host+": "+ name, value); 
>small formatting issue, please be consistent with spaces between the +   it should be: host + ": " + name
>—
>Reply to this email directly or view it on GitHub.  
>
>
yeah absolutely if its not there now dd it.
This doesn't actually work during the install process. I altered it to:

-e git://github.com/django/django.git@origin/stable/1.3.x#egg=django
Ah, yes, options.location is false, so location is set, not options.location.

Perfect.
Add 1 space padding before the equals sign!

var DEFAULT_LIMIT = 500;
This will be replaced by Persistence Management.
"but you don’t want them" Can you change that from a smart/curly apostrophe to a straight apostrophe?
what if there is an existing search query? I think we need to pad with whitespace?
Definitely, but I think we can do it post-merge. One other thing we could do is store the data from the relationship to taxonomies and objects (Subnets/domains/OS's/etc added to a taxonomy) and those from other objects (adding a location or tenant to an existing subnet/domain/etc) in the same table. The current architecture stores this data separately which means a join needs to happen to build the ancestry.
Maybe say (in some elegant way) that step() and step_func() _always_ gets called with `this` its object as the test?
This is a fundamental change in that instances where this is used on the prototype stack will all share the same loadInfo. The prototype stack is the primary place that we are using this https://github.com/walmartlabs/thorax/blob/master/src/loading.js#L394 meaning that every view instance is going to share the same loading info which seems incorrect to me.
Would you mind also adding the priority to the get_mozmill-environment job?
Заменил на `DELETE`.
@adrn I think it should be `unit`
@eteq Yes that is `True` addition (and multiplication in that matter) is not always commutative - but it is in the realms of quantities and arrays.
We could be explicit here:

```coffeescript
[trans_card_name, language, trans_language] = $(this).children('td')
```
зачем это хранить?
Vulnerable to SQL injection.
Typo in "Returns".
If its not set here its left as `@firefox`.
Oops. Interestingly, the tests that verify that this behaves corectly still pass.

Is this `undefined` -> `false` behavior even needed? Or can we rely on `undefined` being falsey?
This probably needs to be paged as well.
can we change the name of this function to be in line with the function name in the API (getSectionOverview) ?
Removed the check.
You have some trailing whitespace here
Feels like we don't really need this function. We could always use getRole and just do:

if (rolesAPI.getRole(principal, principalSubject)) {

}

when checking if someone has a role.
Oh, nice. I was cleaning up stuff and didn't notice this. I'm definitely not relying on side-effects happening here :)
I would review the sentence "Several GA versions may be made available before the engineering team releases an EE version." This is not fully accurate (think 6.1 CE GA2 and 6.1 EE GA2) and subject to change.
Extend the PragmaHicudaKernelInfo struct.
@lilumi потому что сеттер нам не нужен. Содержимое объекта (массива) мы можем менять, да, на то он и mutable, но извне нам не нужно разрешать его выставление. nonatomic это относится к работе с потоками (threads), пока не заморачивайся.
В любом случае, требование "Метод mutate: создан в отдельной категории, он ЗАМЕНЯЕТ СТРОГО X процентов" выпонено не полностью (метод хоть и создан в отдельной категории, но не заменяет строго х процентов), так что проверяющий запросто может снизить за этот пункт оценку. Насколько - зависит от самого проверяющего.
Indenting in this file should be 4 spaces.
Done here:

https://github.com/worldofchris/cucumber-js/commit/575305844a3dda6e9919385eedf721b9b4e1ff7f

On 24 Jul 2012, at 22:54, Julien Biezemans wrote:

>> @@ -15,6 +15,11 @@ var Configuration = function(argv) {
>>       case Configuration.PRETTY_FORMAT_NAME:
>>         formatter = Cucumber.Listener.PrettyFormatter();
>>         break;
>> +      case Configuration.JSON_FORMAT_NAME:
>> +        var JSONFormatter = require('gherkin/lib/gherkin/formatter/json_formatter');
>> +        var jsonFormatter = new JSONFormatter(process.stdout);
>> +        formatter = Cucumber.Listener.JsonFormatterWrapper(jsonFormatter);
> 
> I'd prefer the formatter to follow the naming conventions of the other formatters. This should be `JsonFormatter`.
> 
> The Gherkin formatter constructor could be known as `GherkinJsonFormatter` in Cucumber.js (and its instances would be `gherkinJsonFormatter`). I think it would clarify things.
> 
> ```javascript
> var GherkinJsonFormatter = require('gherkin/lib/gherkin/formatter/json_formatter');
> var gherkinJsonFormatter = new GherkinJsonFormatter(process.stdout);
> formatter = Cucumber.Listener.JsonFormatter(jsonFormatter);
> ```
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cucumber/cucumber-js/pull/79/files#r1230208
what does the width mean here? does it mean the maximum end x offset for the text?
恩，确实。
It goes into a tight loop otherwise.  Alternatively we can kill the thread
and start a new one when the user selects a new process

-Jlew

Sent from android
On Mar 15, 2012 1:28 PM, "Luke Macken" <
reply@reply.github.com>
wrote:

> >                  else:
> > -                    rip, rport = conn.remote_address
> > -                connections.append({
> > -                    'type': type,
> > -                    'status': conn.status,
> > -                    'local': '%s:%s' % (lip, lport),
> > -                    'remote': '%s:%s' % (rip, rport),
> > -                    })
> > -            open_connections = connections
> > -
> > -            # Open files
> > -            files = []
> > -            for open_file in self.process.get_open_files():
> > -                files.append(open_file.path)
> > -            open_files = files
> > +                    time.sleep(1)
>
> Is this sleep necessary?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lmacken/pyrasite-gui/pull/1/files#r564215
>
I'd just use None for this rather than "Not_Valid"
How about adding an "sfreq" parameter which would cause the frequencies to be returned in Hz (for convenience)?
to be consistent you should remove empty lines between parameters
this may
I think you want to write `def unbind(key: String, value: B) = self.unbind(toA(value))`
This should be reformatted to:

```ruby
  sections.push :cookbook_title, [
    :docstring,
    :generated_docs,
    [
      :recipes,
      :resources,
      :providers,
      :attributes,
      :definitions,
      :libraries,
      :element_details,
      [T('recipe'), T('provider'), T('definition')]
    ]
  ]
```
I suggest make this a `.. versionadded:: 2.1` block (and remove the next 2 lines)
self.name is the queue sid, correct? so updating the friendly name should not affect self.name.
Thanks for your fix, I had missed it.  
I think that get_uv_dlerror_message() would fail if the module path is very long near 1k which is included in the error message.
What if we change this comment to:

    # Force body to be read in case the
    # template is being streamed.
should be `@param string`.
self.commuting = kwds.get('commuting', True)
Только я бы тут с конца `Policy` поубирал, иначе тавтология, ну. `SwitchingPolicy::GlobalPolicy`.
Внутри `{}` пробелами отбивать лучше.
strange, it works for me. did you test it while using all the related code and using the MetroDemo?
You can only make a new commit and then a push, and the pull-request will be completed by your commit.
This can be removed as bootstrap is setup aware
By making the StringBuffer variable local to the function, you no longer have to worry about resetting the value every time the function is called. Java does it for you.
I like the capability to make a custom statistic. However it reminded me that when photometry of a calibrated NDData object is run, meaning there are units of Jy/pixel or MJy/sr or whatever, it's nice to get units of Jy or whatever out in the output table. Perhaps this should be done by a later "aperture correction" stage.
This class may be in the `GitList\Component\Git\Model` namespace.
This is the first peace of small-scale refactoring I want to apply to the site, language and page loading.
This call (and the next) "works", but never actually gets the linefmt.  It is left behind in *args.  plot() and scatter() has to do this sort of crap too.  Essentially, you go through all of the remaining positional args, supplying them for the defaults to the pops of the kwargs.
Why do this when we just move it into $out/b2g below?
Is there a special reason why you're not using print?

If you prefer stdout, it's cool. But please `import sys`, that's how I import everything from the standard library.
Resource ?
I was just about to merge your work, but I noticed that there are missing commas in the numbers above which make them pretty difficult to read.
E.g.: ```9223372036854775808``` -> ```9,223,372,036,854,775,808```
Tabbing is all wonky here.
Can you remove the underscore (_) before the variable name? Just for style consistency.
Does the `/api/ui/widgets` endpoint return the results wrapped in a `results` object? If so we should probably assign `data.results` to `manifests`
Should probably say 'CSS formatting'?
It was what it's called in the translation files. It might not need it though? I couldn't get it to work without it, but the translations were giving me all sorts of other issues, so it was potentially unrelated.
So I need to fork https://github.com/silverstripe/sapphire/tree/translation-staging and pull on this?
Jo, dobrý. Já se k tomu teď stejně minimálně do zítřejšího večera nedostanu, takže nad tím můžeš v klidu bádat..
remove more comments?
OK. Looks good :+1:
I'm not sure if documenting the dependance on cache_pool is the best solution.
Yes. It is var dump. :( Noticed it myself and am ashamed.
I would maybe exlicitly import Query(..) and select and rexport them that way, but all good
Could probably do without "(and not disable)". A purged extension is obviously disabled.

Possible rewording?

> Are you sure you wish to purge this extension's data? This cannot be undone.
perhaps this should be renamed .art-exercise
Ah, thanks. So I'll add exports.require guard to this.
In the future, we should consider how to build esmangle script for browser, this is related to #32
It "feels" weird to create an HTML element, and then look it up right after it

just a feeling, ....
Change this to `(collection, ...)` and delete line 816?
break this up into mutliple lines
Given that the URI spec limits the use of colons in path parts, I'd suggest supporting them shouldn't be a high priority or even be a requirement.
@malkowitch if you can make this small fix we can get this merged.  Thanks in advance.
when doesn't it return an array with those methods?
I think, its better to avoid using the string's "split" method on filesystem paths, since there is a specialized method for that. This also (AFAIK) breaks this code for Windows.
I would write this line as ``target_path = self.base.preauthChild(file_name)`` (see http://twistedmatrix.com/documents/current/api/twisted.python.filepath.FilePath.html#preauthChild)
Why DictField? Why don't define document with those possible fields? Or document and then inherit subdocuments for different kinds of data, if there are cases that there are different combinations of fields which are provided. (The other approach is simply to not set them. But it really depends on how data is structured.)
I don't understand what are you doing here?
I don't like the mode. I would just store data as we have it. So timespan (from and to which time), when data was generated, and then all possible values. And then when displaying, you can select the most appropriate data from the database.

So, please improve both this and parsing. Really, check the example, see what values are provided. Try to use that.
Use braces around this line. It is more readable.
Nooo. First, template tags do not work in JS. Because of that we will construct URL in Python.

In fact, concatenating STATIC_URL like that is not the best way to do it. We should use `static` template tag. Please update also templates.

[Read here more](https://docs.djangoproject.com/en/dev/howto/static-files/#staticfiles-in-templates) on the subject.

And then when you will know how to do that in templates, you can call the same function which is used in `static` template tag to get also URL in the code.
Should coordinates be 2 or 3 values? Can you check based on the stream Def?
You could use meleeHasteAura.merge here
Awful name, get creative ffs.