labofsahil/github-event-dataset-2012 huggingface dataset:
Hang on, that's old I think.  There are no TODOs let in the INSTALL file, and I think I caught that one earlier.

--
Barnaby Rowe
Postdoctoral Research Associate

Department of Physics & Astronomy
University College London
Gower Street
London WC1E 6BT
United Kingdom

On 5 Sep 2012, at 13:43, rmandelb wrote:

> In INSTALL:
> 
> >  
> > -ii) Mac OSX  (#TODO: Expand this, maybe move it to a Wiki FAQ)
> > +The solution may be to install Boost C++ manually, which luckily is relatively straightforward. This
> Sorry, I AM a pain!
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
observed-->observed
I think this should be the same as above: No Materials assigned to this class.
Fair enough - (and yes I did mean `* .02`). Seems to just be personal preference (or how we learned math).

I'll give you leading zero as a best practice for those reasons, although I've never actually had trouble with any of those confusions.
Inverse _to play..._ et _from this position_
* `truly`
* `uphold` a la place de `endorse` (endorse ne marche pas dans ce sens)
And you'd be right.  Who uses 2 space indents anyway? ;)

I'll adjust it.
Actually, this change yields one of the most glaring performance boosts: http://jsperf.com/functions-typeof/2

Also, isn't _.functions/methods purpose to return callable functions?

> functions_.functions(object) Alias: methods 
> Returns a sorted list of the names of every method in an object — that is to say, the name of every function property of the object.

This still returns callable functions, but about 2-6x faster than checking the `[[Class]]`.  This change also *does not* affect any of the tests in the underscore test suite.  All tests still pass with these changes made:  http://raymondmayjr.com/underscore/test/test.html
You could just call super() here, since the code is identical
Yeah probably... not really up with how gems work to be honest. Do I add it to the Gemfile?
Have you gone through all the cases were we read the property back to make sure we truly support it as string?
So far we don't need to list out GETs, only SETs (because you need to provide them). Right? Or do you need this list in order to GET it?
Probably want to deleteLater() it here, or in source::removeListeningRoom()
Where does this variable come from?
This is not the base uri. The base uri should include the base path necessary to reach your web root
Same as above would apply here.
Looks like the method below is never used. Delete?
Both `:macvim` and `:mvim` will be working... :)
Мегахак на основе new Array ;-) 

```javascript
Event.prototype.starsToString= function() {
    return new Array(this.stars + 1).join('*');
};
```
file_path would be unset here, no?
If they have enough in common then a common region to extend might make sense but I would certainly hesitate on that. A base PageRegion is definitely an idea I support (and have suggested in the past).
this method does nothing, just the same as the implementation in pvrclient-mediaportal.cpp which the nextpvr addon was originally created from. I'd never checked if anything called it, but my assumption was it was something the framework was calling.
Yay for fixing imports!
ok then +1.  I'd rather have readability
typo: `BernoulliRandomProjection`
We call random state parameters `random_state` and usually set them to `None` by default.
ja, just left that in for now while the example is in __main__.. will fix it now now :)
the previous comment should be rephrased a bit to explain the `break`. In particular it should be explained that checking dual gap is expensive and in some cases we might judge that the cheapest `d_w_max` convergence check is good enough if one is interested in raw speed.
It seems to me that you could use np.minimum, and be more readable. No?
Поменять выборку категории, на getSingleResult()
test.pdf is hardcoded as the pdf name.
This change might cause incorrect replacement. If the test result contains `"hello/world"`, the forward slash will be replaced to backward one.
I'll also clarify this one.
I think a better name would `isAnnotatedWith()`
could you reformat this with proper whitespaces?
There are modes as follows:

1. ecl code compiled down to an executable, which is then executed to run the query a single time
2. ecl code compiled down to an executable, which is then executed to start a server listening for queries
3. roxie executable given a .so to run via command line, to be executed once
4. roxie executable give a .so to run via command line, to listen for queries on a port
5. roxie executable loading .so files from a QuerySet, and listening for queries on a port and/or a dali queue

In all cases if a dali is specified it should be used for file resolution (in conjunction with any packages loaded). in cases 1 and 3, and in case 5 for those queries received via dali queue, dynamic resolution should be used.
Should maybe also not use keys if the consumer of this activity holds onto the rows.  At least add a comment about it?
I thought [ elseresult ] was optional...
We should change the for loop to
```python
for c in len(bins[i])
```
Or continue as before but just fix the original line to be `logmin + c * binwidth`
This else clause is unnecessary. Throwing the exception in the if clause will prevent further execution.
Is it common practice to use filter_var in Silex service provider ? Do we really need that ?
Yeah, more unit tests would be great. I found the overhead of learning Vows (and BDD) a bit much though.
I believe that is true in setup(), but not TestEnquePendingFiles.

Rename to TestEnqueuePendingFiles?
When we do this you should also take care of the listener for graphics.
I haven't fully addressed the Exception situation, I am not sure if there is time before beta3, but perhaps I can get to this one today.  Reason being, is that since this is an adapter pattern, I really want to be able to nest exceptions correctly and be able to get as much meaning out of them as possible.
don't understand, with which?
In thinking about this again, I don't see the benefit of rolling to different things into a single setting.

Why doesn't ``SENDGRID_CREATE_MISSING_EMAIL_MESSAGES`` cover the case of Newsletters anyway?
For this line, I am not quite sure the usage about the 'for loop's condition', so I passed it in the debug process.
Doesn't it simply be "for (int i = 1; i < cmdLen; i +=1)" ?
@raydavis makes sense indeed, thanks for spotting this one
do someone really needs such detailed comments?
That is actually tested here already, but it's a little unclear since it's all done in one go. I'll split apart the pieces so it's easier to see what's going on.
elsif with the if above
85117 : XODA File Upload Page Arbitrary File Upload
This is in the db_mysql attributes file:

case platform
when "redhat","centos","fedora","suse"
  set[:db_mysql][:socket] = "/var/lib/mysql/mysql.sock"
  set_unless[:db_mysql][:log] = ""
  set_unless[:db_mysql][:log_error] = ""  
when "debian","ubuntu"
  set[:db_mysql][:socket] = "/var/run/mysqld/mysqld.sock"
  set_unless[:db_mysql][:log] = "log = /var/log/mysql.log"
  set_unless[:db_mysql][:log_error] = "log_error = /var/log/mysql.err" 
else
  raise "Unsupported platform #{platform}"
end
Also remember to define the type for rr and cc, i.e.

```python
cdef:
    list rr = list()
    list cc = list()
```
Did you make the FileUploadBean request scoped?
Probably doesn't hurt, but if there's nothing that needs escaping, we should consider removing the CDATA wrapper.
This is not right. The second argument is the `ui` object, with an `item` property. Check tooltip.xml, I think I got it right there.
this is gonna conflict with my pull...rather than doing self.base_url + [whatever] in each command, i implemented Page.open(url_fragement) that does it for you
No i dont think this should be reverted. The only time `_validate()` is called is when the there is a create instance call, and the flavorRef is never used in the create instance call. Let me know what you think about that.
Punkt "." am Ende fehlt.
Isn't the logic of this, and related, functions cleaner if it went like:

<pre>
           if (!this.isSampled(rgba)) {
                return [Color.byteToFloat(rgba[0]),
                        Color.byteToFloat(rgba[1]),
                        Color.byteToFloat(rgba[2]),
                        Color.byteToFloat(rgba[3])];
            }

            var len = rgba.length;
            rgbaf = new Array(len);
            for ( var i = 0; i < len; i += 5) {
                rgbaf[i] = rgba[i];
                rgbaf[i + 1] = Color.byteToFloat(rgba[i + 1]);
                rgbaf[i + 2] = Color.byteToFloat(rgba[i + 2]);
                rgbaf[i + 3] = Color.byteToFloat(rgba[i + 3]);
                rgbaf[i + 4] = Color.byteToFloat(rgba[i + 4]);
            }
            return rgbaf;
</pre>

Now the function flows like "return without conversion; return with conversion; return converted array;"
Did you test this?  I know we've broke it before.
What would be your preferred place to put TODO? I put in in Github issues and assigned it to you, as most of projects hosted on Github do. But obviously it is not the best way for you.

I don't expect you do remember everything we talked, but I expect when you think some code is not needed, and need to be deleted, look at that code first. And I also assume that if you read and understand #32, the content of BindableSpec.js should look familiar to you.
This is actually an improvement over ScoutForce's code in that if the current course from the session can't be found, it reverts to the current_user's default course. It's an edge case, but I remember seeing exceptions in ScoutForce caused by that.
yeah, I think this started as ==, which I usually do the other way, to prevent a silent logic error
Just out of curiousity, do we need to pass in an empty object for ios or android? You do not need to pass anything in for mobile web.
Shouldn't this be "keyPressed" instead? "keypressed" doesn't follow the standard capitalization format.
On Android, this property works to all the heavyweight windows except modal windows ('modal: true'). BTW, a heavyweight window is created if any of the properties - "fullscreen", "navBarHidden", "modal", "windowSoftInputMode" are specified in the createWindow method or in the open method, no matter it's true or false.
Similar to backgroundDisabledImage.
Cap. Or change to:
'Titanium.UI.ImageView.url' property is deprecated; use 'image'.
My change then:
```diff
@@ -336,7 +342,9 @@
 		$( "p", themeroller ).tooltip({
 			items: "img[alt]",
 			content: function() {
-				return $( this ).attr( "alt" );
+				var alt = $( this ).attr( "alt" );
+				// Escape alt, since we're going from an attribute to raw HTML
+				return $( "<a>" ).text( alt ).html();
 			}
 		});
 	}
```
Hmm. nao saquei muito o que vc quis dizer nao. hehehe

Mas tipo, se for necessario so nos testes nao rola colocar isso no spec_helper? Pq as vezes isso pode quebrar o funcionamento da gem no projeto que tiver usando ela.
This, and the following, was better as non-bulleted intro text for the section. E.g. I don't write tests against either of these two, and it makes it more natural to nest the specifications for argument handling under text that describes the arguments, instead of as sibling bullet points.
Шаблон лучше положить к шаблонам в папку с шаблонами.
Needs some justification
https://github.com/D-Programming-Language/phobos/blob/master/std/range.d#L4500
https://github.com/D-Programming-Language/phobos/blob/master/std/range.d#L4574

Only 2, but they were the first I found and assumed were correct.
Generaly a faster way would be to go ahead and compare byte by byte and only back-pedal with stride at the very end.

In UTF-8 that'd be while
r1[i] & 0b1100_0000 == 0x80  //i.e. not a start of UTF-8 codepoint
though care needs to be taken to make sure not to "underflow" on incorrect UTF.
I belive reverse iterating up to 4 bytes or the start of of r1 is okay since if it's longer it's damage UTF-8 anyway.
There is also strideBack  in std.utf that probably does all of this safely.

For  some real short strings it might not be faster though.
@jmdavis: this is a matter of dimensionality, not size, so bringing `T[1]` into the discussion is a red herring. Consider a non-array type `T` (int, double, class etc). On top of it we build array types of different dimensions: `T[24]`, `T[24][42]` etc. These have 1, 2, and so on dimensions. On occasion the dimensionality of `T` itself comes into question, and the correct answer is it's 0.
Simply removing code because you don't know what it does is _not_ a good idea.
This may be acceptable in the first paragraph, but I wouldn't use it further down in the lab...
Would be better to call toMutableMap just like at TreeMap
Don't need this, as above :-)
"is essentially" is redundent imo.
The connector-parent is still there
revert all those non-changes
Line isn't necessary here.
New event system! Yay!
@wireframe done
I try to avoid framework-specific asserts, as it makes the task of porting tests from one language to another more difficult.
@KingCrunch Why not use sprintf in your example?
:hand:

See my [comment](https://github.com/php-fig/fig-standards/pull/16/files#r532945).
We probably don't need to concatenate `px` in here.

From the jQuery docs about [height](http://api.jquery.com/height/):

> If no explicit unit was specified (like 'em' or '%') then "px" is concatenated to the value.
We should initialize this to `''`'
@alexrp - from a quick scan, first thing that pops out is core/thread.d: ```import core.sys.posix.sys.mman; // munmap```

That publicly imports posix.sys.types. :-)
Seemed ashame to lose this functionality, especially as its already namespaced off into its own specialised area (config::file).
hook_forms() for both the date range filters and the date range sliders. We need hook_forms() when we want to display the same form multiple times in one page.
This should use the func.formatDate method in this ticket: https://tickets.openmrs.org/browse/HLQRY-39
Guys, but I really don't like this name...
We write code, which is reading by many-many people...
For me Spring always is archetype. And I can say the same about others.
No; I am saying if they, say, pass in null in the constructor; sequenceAware will be set to true; if they then pass in some other release strategy in setReleaseStrategy, the boolean will stay true even though it's not a SequenceSizeReleaseStrategy.

You need to set the boolean to false if it's __not__ a SSRS; hence my suggested syntax.
I *thought* that the default ip_mask that I had put in there would never match any real ip address ( 0.0.0.0/32 ), which should make that line effectively a no-op.  That was my goal anyway...
Well, not quite what we are looking for in terms of coding quality
"see getHeaders()", but later on getHeaders say/show nothing about value setting ...
To avoid poor api design like what I had done with the if else, you should explicitly check if the the call is 'void' to return this api.

So that the next time some other method is implemented, this is not broken.
you should use the interface instead
again, I'd prefer array
callbacks for this DOMRequest?
On that note ... show I be designing this project with the idea that only one email account will be accessed? Or that multiple email accounts may want to be visualized in the same way?
I was actually about to write that feature request up.
sounds g00d
IOUtils already checks for null...
Again, rather than adding a new class, let's just add patch to `RetrieveUpdateDestroyAPIView`
better to push the view controller with animation
Ah, yeah. Hm. Can you not even do it with a PartialFunction (i.e., `exists { (id, files) => files.contains(file.getName) }`)?
Для логина есть же отдельная функция, она что, не работает с слениумом?
There's a typo here... "@largeMemSize" vs "largeMemSize", consequence would be that "@largeMemSize" setting was being ignored!
This was an old bug fixed in 702, that seems to have never made into LCR.
"...should return ... an OutputStream for writing to the file."
Should read `Protocol for views that can receive keyboard focus`.
si se te ocurre otro bienvenido sea =)

a mi me sono el mas expresivo, destruye la cola y destruye los elementos :P
Actually it occurs on both the app index and show pages
I assume `comsumeEntity` will just pass null down to EntityUtils.consume() which simply returns when it gets a null. What wouldn't result in quietness here?
I may have moved the code around - that = this is required for the class variables to be accessible inside eventListeners. I may have just added the code in different locations, I can remove it so its only set once.
Is the comment above something we expect to need/use later, or a leftover that can be trimmed?
Was that the logic around not having it for exit ? We've had issues in the past where there is no success because the whole event loop is waiting for it and the client JS is waiting as well.
Yeah on further inspection we need to fix this, we may need to wrap the threads in their own respective classes to avoid global variables
so like the console.log or you want it gone
I can't find them in any documentation. I found them in the netstatus.h
to be clear, `for row in range(0, rows, 2)` where 2 is the step.
Display should be "Anonymous"
Turn off fair by default for greater interoperability
not required anymore in wrapped-parent 7