labofsahil/github-event-dataset-2012 huggingface dataset:
Got it. Should I use

1.    function myHandlerFunction($args, &$request) {

or

2.    function myHandlerFunction($args, $request) {

? I'm noticing that other functions in this class don't use the old "pass in as pointer" php syntax (i.e., they use #2). Should I keep consistent with that?
I'm wondering how you imagine this json data passing? Sth like:

<script type="text/javascript">
var elgg.profile.data = <?php json_encode($data); ?>
</script>

put inline?
At line 93, `should_add_backend_to_commandline` is called, which calls `get_xml_file_tags`. Previously `get_xml_file_tags` was defined after line 93, which caused a problem.
No because size might be None. We validate that size is an int in the runtime version.
The other option is to spawn a child that sends the messages. So buffer until CPO is received, when CPO is received spawn a child with the CPO info, then send all the queued messages to the child, then all new messages that come in go straight to the child. No stash needed, just a queue (which of course needs to be bounded in some sense to avoid OOMEs). See any issues with that?
Excellent, thanks. Please create a branch off of master and open a pull request with the renames + comments!
This line should be changed to wipe out everything (yourself will be added at the end).
Java API alias for apply
we should probably do some processing on prefix so that you can specify `%h` to be replaced with hostname. (And include that in the default)
Just to be clear: it's this one that needs to be removed ;-) ^^^^^^
This looks wrong, we are adding organizations as a new model alongside groups, not replacing groups with organizations
The less dependencies the better especially just for tests
I'm guessing not, existing instances using groups will just continue to use groups? Not aware of any existing instances who are using ckanext/organizations and that we want to plan a migration route for at this time.
Copying how existing code works is fair enough and usually a good approach. But some code in CKAN is, how shall we say? A little misleading :) Do as we say, not as we do and everything. So when the [CKAN Coding Standards](http://docs.ckan.org/en/latest/coding-standards.html) disagree with the existing code, follow the coding standards not the existing code.
Pulp is always capitalized.
This should be moved to utils ;) It's not only useful here!
Check `__toString()` of other exceptions. Like
https://github.com/Behat/Mink/blob/master/src/Behat/Mink/Exception/ElementHtmlException.php#L45-L64
Hi, why have you added products DAOs import?
thinking this is unnecessary.
Not fully worked out for posting xml/json data, but it should parse it here, not in the action methods as it does.
I think it will loop if you don't catch String, and just return it.
We should do this inside the library. Transmit the messages individually, rather than returning an array here.
Please no spaces on the inside of parenthesis.
My current plan is to defer gesture support for post-2.1.1 so I can try to get work on Kindle Fire HD done.  From reading the MS docs, in order to get the MSGesture events, you have to call a special registration method using a nonce you get from the MSPointerDown event, and I've not yet figured out that logic for our code.
yes, leave them in for reminding us...!
I would name it `Twig_ExistableLoaderInterface` (or something better) and I would not make it extend `Twig_LoaderInterface`. That way, we can have more extensions in the future.
The shadow changes should be in a separate pull request.
If simplicity is best, he could reduce it to `_footerView.hidden != footerView.hidden;`
Turns out that the `scala-maven-plugin` doesn't enforce the same classfile version for java code it compiles (in incremental mode) as for scala (scalac generates 1.5 classfiles currently, i.e. 49.0). This affects the twirl maven plugin (not the twirl-api artifact which is pure scala) and the spark project itself, so I'll update both accordingly.
Any reason why you call `SelectionKey.cancel()` twice?
тут nextToPaste ссылкой, может, сделать? копировать это все не хочется очень
Please don't implement the logic twice. Here's what you could do here :

    def transform_values(&block)
      dup.transform_values! &block
    end
Piotr aready did it in d1887d384a4038d67bcad50a46a6dc67abfebe04
Services will take types as discussed.
I was talking about switching from `sym.owner.isPackageClass` to `sym.owner.isPackage*Object*Class`

I can't imagine how that would affect initialization. I tried closing my eyes and visualizing it with my mind's eye. Thinking out of the box. Being mindful. Nope. Could you make it illuminated?
But *this* blank line is BETTER!
The original formulation misuses the word "line" (i.e. infinite line).
A "segment" is the part of the line between two points.

The wikipedia article uses the terms "line" and "segment" correctly,
however the meaning of "altitude" changes from "line" to "segment"
throughout the text.

This method returns the "altitude segment" so I think that the new
docstring is better.
oh...we're in the test file. Never mind.
Because f and g are not Basic, so they shouldn't be allowed as args in a Tuple.
The `stabilizer_cosets`  method has been eliminated.
Can you change the variable `l` to something else, it is very difficult to differentiate between `l` and `1`.
object?

wow, typeof an *execution*? wow. it's bullshit.
>Use "Yii::getPathOfAlias('application.runtime')".

Right. Didn't knew that it points to the unit test application runtime directory.
This is not necessary, reporter will already raise an exception with a message about the requirement.
Also... I wouldn't mind breaking this pattern of shove-everything-on-one-line and expanding this to be a bit more readable...
This should be a hash whose key is the relationship name.
the question would be, if this service is intended to encode/decode only responses to the client or if it also would be a usecase to read/write files on server side...
Да основные скрипты подгружаются в конце для более быстрой загрузки самой страницы, а POS_READY выполняется после полной загрузки
and really it returns documents and extra information (phrase however you see fit,) "results" are a bit vauge.
This is not something I want to spend time arguing, I gave you my opinion, do it whichever way you want.
If it's not too much work please check against zlib an bz2 rather than using a magic number.
Please, no. Invoke stop normally.
The function should probably be called `phpbb_get_banned_user_ids()` without the `s` as well.
Specify which callback please, I'm sure at some point someone will add another function above this one.
确保代码格式 可以从pull request 入手
而不是先入为主的强制规定每个人的配置
I suggest not build-time dependencies (as its related to INSTALL paper) but Package dependencies or something. Make it neutral to building process.
While it's not normal to do so, you can use a ruby expression in a rescue clause.  Given that, I think you can simplify things a lot by doing something like:

``` ruby
def retryable_exceptions
  return [] unless job.klass.respond_to?(:retryable_exceptions)
  job.klass.retryable_exceptions
end

def perform(job)
  around_perform(job)
rescue *retryable_exceptions
  job.retry
rescue Exception => error
  fail_job(job, error)
end
```

You also wouldn't need to define `retryable_exception?` (with it's `any?`/`is_a?` logic)
actually, you'll need to nest the DB calls in `index()` as well:


```coffeescript
# UsersController
index: ->
  User.find({}).populate('team').asc('username').run (error, users) ->
    throw error if error
  
    respond_to
      json: ->
        JSON.stringify users
      html: ->
        'users/index',
          title: 'List of Users'
          users: users
  
```
This is a valid optimization for libs/ycb, since this is code that is called at runtime.  However, the resource store redesign didn't introduce this inefficiency, so I'm going to punt.  (I'm trying to keep the RS redesign from growing even larger than it already is...)
coffescripts --> javascripts
Are you sure this is the right place to put that? I would rather put that in the virtualhost configuration, or at least check the current environment. (we don't really want this in production, I think?)
Screener tabs are looking better, but it is still a little difficult to see when a tab is selected. The text is selected, but the background is still the same. My suggestion is to follow the style guide, make background grey and selected tab blue.
remove commented code if not necessary. Else, write TODO and file a bug to track this issue if it's something that needs to be fixed
Rather than using 
if (condition) 
   { //nothing } 
else 
    something

You can try 
if ( !(condition) )
   something
remove this file from pull request, if not ready for commit
Not sure about this. ```lbuser``` is a tuple, but you are converting it to a list so it is mutable and hoping test code remembers to convert it back to a tuple. It may save a couple of lines, but I prefer the previous explicit conversion to list and back to tuple if the test in question needs to modify it.
Can I get away with it?
http://www.python.org/dev/peps/pep-0257/#multi-line-docstrings
'"The summary line may be on the same line as the opening quotes or on the next line."'
The license is the 2-clause BSD . Although not stated the license text has been copied into the beginning of the source code files. Example unpack_ppfield.c. What details do you want in the separate PR?
So... `get_xy_grids()` and `get_xy_contiguous_bounded_grids()` are only used (in Iris) by:
 - `iris.analysis.cartography.xy_range()`
 - `iris.plot._map_common()`

And `xy_range()` is only used in `iris.plot.map_setup()`... which we'd like to replace with `iris.plot.crs_and_extent()` or similar.

So right now these are just mapping support functions.
I saw it. done.
Get it. But we do not need the failed node test case.
I guess that could be changed so that the check after the for loop doesn't depend on i.
I'm not sure what this policy is for. It returns null in all cases.
Are the line 37 - 62 the test or example data? What would happen if one or more element values are not overridden by the caller? If this is the example data, rather than assigning here, you may want to add it into a comment block as well as explaining what fields are required or all is required.
The only reason I kept the StandardError rescue around was in case there is another Java error that could be thrown from one of the chained methods on that line besides ClassNotFoundException that I'm not aware of. Under JRuby 1.7 the StandardError rescue wouldn't catch that, but it would at least prevent any regressions under JRuby 1.6.x since StandardError was the implied rescue when none was specified.

All tests do pass with StandardError taken out of the rescue clause so I'm open to either way.
@daveschaefer - would you like me to take it from here then?
You're a wily one, @mikesherov. [Now](https://github.com/jquery/jquery/commit/14e1501b89491bad5744af4f2a8d084834f9c295) that it's possible to test no-ajax builds, I can confirm that this PR passes. :triumph:
Why plus 1 here, can we use the following code directly?
{code}
       float8      rand_num  = rand()/(float8)(RAND_MAX);	
        int64        selection  = (int64)(rand_num*(high-low)+low);
{code}

or

{code}
   int64 selection = (int64)(low + rand()/(high - low));
{code}
In both client and server, it might be useful to specify that this is specified in the shared models.js file. Because this is one of the very first examples, it might be unclear when people see that Lists / Todos is suddenly being used but not know where it is defined.
wtf git :)
I'm totally fine with this notation, but it's likely someone who doesn't know interval notation will get confused. I'm not sure whether that's worth addressing, but figured I'd mention it.
I think the example pages had some sort of auto detect mobile switching in the JS, so I figure this is for that. I don't think we need it here.
This is soooo cheating.
Unforutnately, I couldn't make this work. When I specified these as command-line arguments they were ignored and the Makefile used the defaults.

I'm no Makefile expert, but it seems to be that the Makefile defines those variables at the start and they will override whatever is passed in as command line arguments.

Any suggestions?
Again, changing quotes is unrelated to the stated purpose of this commit. But there is a more important reason why random cosmetic changes are frowned upon: it makes it unnecessarily difficult to follow the history of this line. As it stands now I can do this

```
$ git blame -L/fails_with_llvm/,+1 -- Library/Formula/cairo.rb
00fb91fe (Charlie Sharpsteen 2011-12-25 15:49:45 -0800 14)   fails_with_llvm "Throws an 'lto could not merge' error during build.", :build => 2336
$ git show 00fb91fe
commit 00fb91fe06889a6d11077f79a2deb8a2de1809b9
Author: Charlie Sharpsteen <source@sharpsteen.net>
Date:   Sun Dec 25 15:49:45 2011 -0800

    Cairo: Bump fails_with_llvm version
    
    Still failing on Xcode 4.2.1.

[snip]
```

But that changes if I apply this patch as-is. In that case, blame would report \_this_ commit as the last to modify this line, then I would look at it, realize it has \_nothing to do_ with fails_with_llvm, and then have to restart the blame operation using the parent commit as the starting point.

It is a less egregious offense to make cosmetic changes to "unimportant" or "uninteresting" lines, but the history of an annotation like fails_with_llvm is important, so it is worth extra care to make it easy to follow.

I'll just drop these changes when I apply the patch.
Can #:nocov: be on the end of a line?  Because this is impairing readability
Oui. Ca serra dans le logger
moved this method to the platform's UnitRemoveCommand
My only gripe with "Plugin" is that I think of plugins as being optional. But Plugin is good enough for now.
Alternately, you can declare it as a dependency of the maven-compiler-plugin. It has the advantage of playing well with m2e-apt to auto-configure annotation processing in Eclipse.
See https://community.jboss.org/en/tools/blog/2012/05/20/annotation-processing-support-in-m2e-or-m2e-apt-100-is-out
不会，但是一般用Mac的一般是自己的机器，不太可能会碰到工作站以及多用户的情况。
If we add an `else` case here, we should invert the `if` statement. I find:

    if (!something)
    {
    }
    else
    {
    }

Harder to read and grok than:

    if (something)
    {}
    else
    {}

Also, at first glance, I'm not sure how this works properly. Is it because if the edge exists, we must have already added this commit and its parents?
Can we, instead, just kill trying to load the class here?  Are there still situations after this change in which clients will _not_ call the constructor that passes a class, but _will_ expect getTestClass to return something useful?
The intention w/ these stats is to track the activity at a partition level, not a db level, so that partitions can be compared against each other equally to see how busy they are from the outside.

writeTo is currently only one but it could be multiple for short periods of time where we want overlap between two storage locations, or if we want to syndicate all entries at this layer for some reason.
How much of this normalization do you think is due to differences between rss and atom vs weirdness in NBC's feed?
This should be:

if (!currentEditor) {

So it also checks for "undefined".
@GarthDB will review the UI here. We won't need to fix anything immediately for this pull request.
It'd be good to be more specific about the problem.  Something like "make sure CodeMirror hasn't expanded the selection to include the line we inserted below."
I think I brought this up for CSSUtils as well, but should we take out the nested function creation here? See http://jsperf.com/nested-named-functions

The impact isn't terrible since we only compute the offsetEnd for matched functions, which in theory shouldn't grow very large.
Also, it seems like we should be creating menu groups and then populating them.
i think this should go into `createProcessLog` since it is used only for view
inline styling, let me know if this is an issue.
It's not obvious where count comes from. Instead of having this as a property of YMCA, it would probably be better to declare count within this function, probably next to where you define `newLine`
I'm confused - isn't annotate just used with vectors, and not with vars mapped from a data frame?
As of now, our ViewModels don't have access to the elements in the view so we can't just loginFormStackPanel.Visibility = Visibility.X

If you have any idea of how to do this, we all ears.
Why is good to define the element type and not leave it just with class?
HomePage loads SignIn loads AccountManager loads HomePage.

so it won't run if i put it at the top of the file. i like marking them that way so that the less experienced people don't think that they should always put the imports in the method calls.
Why double the timeout?
spppppppaaaaaaaaaceeeeeeeeee
Why use the `itemLabel` and `.toLowerCase` for this?  You may as well check the `name`.
External css file.
I'm fairly certain nothing uses `trackeventmouseout` anywhere in the codebase. Perhaps its whole presence should be eradicated.
Now zoom is default 1?
ah good call, thanks
Also, I did this already, but then you adjusted the opacity of the main section of the box, so I didn't bother committing the fix.

Are we now going back to solid colours? 'Cause I rather liked the effect of the background image showing through!

And how does this background image affect the background image required for the `.submit_now` box?
It might have been me being stupid but I thought that entry.slug was still returning the OLD value (before it changed) so in the case of an edit I assigned it to a value to use. I might have been wrong so will check again...
I think a newline before this would help things breathe a bit, but it's a bit of a nit.
`set_initial_status` looks like just the kind of code you'd normally put in `initialize` - is there a reason not to put it there?

For `save_deployed_data` and `save_iq_file`... it's a bit strange that these are called through the before_save hook.  It looks like the idea with deployments is that the actual deployment happens on save.  I'm not sure that's the best idea in the long term - we might want to have some state for the deployment like 'initialized', 'in-progress' and 'complete' so we can queue this work to be done later, but that's not really the core problem right now.  

The problem here, as I understand it, is that you actually want to test a deployment that's completed so the PIR can be merged, but you don't want to actually save a deployment for some reason - why is that?  If it's because of a performance impact, I would say a clean test is much more important.  If it's because there's too much going on during the save to test the PIR merge effectively, then that's a good indication that you should split up the interface to the class so you can test a particular action on its own -  so perhaps you should have a `generate_iq` method that handles the PDF files, which you can test independently by speccing #generate_iq, and you can verify that it's called on save by speccing #save and setting an expectation that it calls #generate_iq.
With slf4j api version we use now you do not need anymore the new Object[]
Well, ENV isn't actually written out to the real environment in Ruby until you exec. So in this case, you're basically just emptying and re-filling a hash. Doesn't really have any significance inside of Ruby unless you access it.

So might be a problem with threads, but that shouldn't be in play here.
Is there anything we can do to avoid this step? Seems annoying that we'd require a third party http server for just that.
These two lines probably should be an #else.
When assigning, should you assign to both (i,j) and (j,i) to keep the matrix symmetric?
No need to specify again license and group for subpackage if they do not differ from main package.
Yeah kill the double quotes around `name`, it's not needed.
Just add a check in the callback then. if(_connection != null && _connection.State == ConnectionState.Connected), it's kinda ugly but it works.
You might also want to add an ``Attributes`` section  with entries for `value` and `unit` (it' should be formatted just like the other sections).  As it is right now, it's not obvious that one uses `value` to access the value, because `unit` is a property, but `value` is not.

Alternatively, you could make a `value` property.
I think this has to be a little clearer - you mean it has the same shift as `nump.fft.fftshift`, right?  If so, specify that, because right now it's ambiguous what kind of shift this is.
I think `CartesianCoordinates` would be confusing, because then users might think it's a fully-featured class like the other corodinates, e.g., they can trasnform to/from `CartesianCoordinates` (which of course doesn't make sense without specifying *which* cartesian coordinates you are in).  

As for plural, in my mind "coordinates" is plural because there are multiple coordinates - e.g. lat and long are two coordinates, so there are two "coordinates".  I admit this is confusing, though, because in spoken English people (including myself) don't always use this consistently. (E.g., "one coordinate" might mean just the lat-coordinate, or it might mean just one r,lat,long triplet.)  But it seems clear to me that a single x,y,z triplet is a "cartesian point" singular, and that's the logic behind the naming here.  That said, in the future, this might be an array, in which case it should be "points."  So I'm not actually sure. 

 @astrofrog @demitri @adrn do you have thoughts on this?
If you put backticks around "get_w" (`` `get_w` `` instead of `` get_w ``), the docs will hyperlink to the relevant method.

Also, "overwridden" -> "overwritten"
convinience -> convenience
没地方用？
@luke-jr good point. I shall change these. Thanks.
Why main.h? For assert you need the header &lt;cassert> (which seems to be included in serialize.h)
This simply attempts to open the message_queue, which will fail as we never set up the message_queue listener in ipcInit on OSX.  There is no point having an ugly ifdef here, especially since we are never gonna get called with a bitcoin: URI on osx on the command line unless a user does it manually.
I think people who rename the App dir are generally not the same people as those who rely on the outer index.php.  I'm happy to change it down the road should that not be the case.
You should have spaces after these `-` or the api docs won't understand what you mean.
You can use the `single` option here, which is more elegant is my opinion.
Perhaps this should be ```corner_radius```?
You're using both `on conflict replace` and `insert or replace`, which seems redundant.
`value` is not guaranteed to be a string (and in fact generally isn't).
Unused variables give me warnings, so I just removed them. Feel free to keep them if you think you'll need them later. ;)
Out of curiosity, is there any example of something using `display_json`?
`compiler_flags`, I think. Explicit is better than implicit, and this parameter seems like something few people will need, so there's no need to make it quick to type.
please reformat this file
These comments should wrap to 100 characters.
The pause check was redundant but it looks like it still needs the existence check or I get an error on the FAQ page where the video doesn't exist.
the mozorg app doesn't have one, not sure why/when Django checks that since you have to explicitly install an app. Either way I'm fine leaving it in.
There was a highly technical reason for that. Though I can probably remove it because I think we handle all the possible tags now.
The docs say this is related to highlighting, Not sure I understood completely :)
Why are these tuples, when they are only a single value and get unpacked anyways?
Why is there both a constructor (line 9) and this init function? Is there some advantage to splitting it up like this?
you can also just use `case__prefix="pref"` here and not have to create the case separately.
Can we get a `console.log` up in here?
If you're going to use `xrange()`, you'd might as well make this a generator expression.
please correct the indentation
`$fphandle`?
Bind the ``Defaults`` object to the configuration, instead of it being a global (see further below).
Elasticsearch documentation says: "The filter can be defined using Query DSL" so  I think that this function must be prepared to take a Elastica_Query as a filter, but I don't know how to obtain a text with the query :-/
Who wants this? We should make 'em provide a real content type
What about settings the default to `null` to use the php.ini settings unless overriden ?
this should be changed to ``2.2.*``
You're right that was a concrete example, not a generic one.
`client browser` should be `user agent`.
if we're doing this now using a timestamp do we need the lastID property at all?
Probably should cd to /tmp first.  Rather than CDing around and relying on CWD, I usually prefer to use explict paths:

wget -qNP /tmp URL
tar -C /usr/local -zxf /tmp/file
rm -f /tmp/file


e.g.
https://github.com/wr0ngway/rubber/blob/master/templates/zookeeper/config/rubber/deploy-zookeeper.rb#L14-17
Really? That's all it took to get working?

Damn. Good sleuthing.
Yes we can do this. Since the existing code was doing two seperate steps I stuck with that pattern. I'm cool with doing the setup and delivery in one step.
硕士和博士的论文规范都是同一个，没必要分开。只是“作者简介”这个，规范里明确说了硕士不必提供作者简介。所以不需要将硕士博士分开。
Use std::set<Vertex> perhaps. It is more generic than vector and avoids repetitions.
This will fail in a lot of firewalled setups since the keyserver runs on a high port. We should test for that and provide instructions for getting around it. There are two options:
* manually import the key
* blast through that firewall
Can you just use a try/except AttributeError here? I don't like hasattr too much.
I don't like that the test has been deleted :-) Apart from that it looks good. I'll do a model comparison and post the results here
Ok, i updated the PR, added a setReload() method and deprected the current one.
this part of the code could be done in populateModel if AbstractAddStepHandler was used.
createResource is part of AbstractAddStepHandler  code.
that is why i asked why not use AASH
agreed, nice find
@larryweya would you consider writing a re-usable function for this, i see exactly the same code as the above success.
data in not needed
Can this live in CSS file instead of here?
nit: applys -> applies
Actually I would make this activity a "one way" one.
When I'm done creating a contact it's weird to be taken back to the source app right away.

What do you think?
if the manifest mentions no permission we add a `null` at the end of the `perms` array causing an ugly warning later on.

```
let perms = manifest.permissions ? commonPermissionList.concat(manifest.permissions) : commonPermissionList;
```

?
Thanks @stasm ! Good to know ;).
Same that avobe
Ok, i'm agree!!
Why not call this PrefixMatchMultiplier?  I don't get SourceTerm
Absolutely, we can talk tomorrow in Madrid about it :-)

Anyhow, the /shared/style/confirm.css is not needed in the contacts' index.html file since the "confirm" BBs are really placed in the dialer's (main) index.html file (which indeed has the link to the shared confirm.css) so that the dialog screens cover the whole Communications app screen ;-) But good catch! ;-)
maybe, its going to happen automagically, the refresh just forces it to happen faster right?
I think, this should look like:

'logs': [
        LogRecord.getMessage(m) for m in self._stats_manager.logs]

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Line_length#Line_length
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Indentation#Indentation
Should we explicitly mention in the comments that if you are doing an innerJoin and there is at least one common field name in the join, then all right side fields will be dropped?
Nevermind, i realized what you mean! I will add the Freeseer Headers!
what? `pwd` is defined at the top of the method
Fair enough. Opened #540.
This isn't a bad idea, really.  It has the fringe benefit of allowing users to change descriptions to suit changing circumstances, while keeping the builder name the same for historical purposes (e.g., add an Ubuntu test and the old "Linux" builder becomes a "CentOS" builder).  There will be some complications with changes to the configuration, but those are manageable.

I'll give this a shot and see what weirdnesses I run into.
Some whitespace after `,`s would be nice. :)
That's not completely true, because you changed http urls to https above (getcomposer.org & packagist). In those cases a downgrade to http is possible. Maybe it can just always try to downgrade and if it fails with http then fail hard.
i still dont know what this does differently than built in jasmine mocks... Any idea/opinion? @denniscollective
I'd  try building `@key_ring` through the association, something like this..
`@key_ring = current_user.person.key_ring.build`
http://www.miranda-im.org/download/ says the latest version is 0.10.4, is this still relevant?
+ даже не придется парсить json на клиенте
move to I18n
|  `param` is not imported at this point and - should `topo.version` be populated before it is imported and the message displayed after the import?

param doesn't know anything about topo.version or even topo itself, so
it should be safe to import param before anything to do with topo
versioning.

-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.
Can you keep these tests?
Printing a usefull stacktrace is one important feature of this module.
Ok you mention it below so this in not necessary just ignore .
We talked on IRC about this. Since `resolve` is exported by loader module, custom `resolve` function can wrap it if it want's to, which we agreed is better than pre-reslove or post-reslove as it may be wrong thing to do in some cases.
nit: the negative form doesn't help reading this code.
nit: the intermediate `none` attribute might be removed:

    var sources = freeze( owns(options, 'implements') ? map(options.implements, prototypeOf) : [] );
Sadmaking. We should make some of our key files exempt from that parsing at some point.
I agree this should fix ie9, based on my understanding of the problem.
hmm.  because this is a user initiated password update, is there any good reason to not reset their active sessions if they're resetting their password to the same thing?  I feel like going the other way would be safer - always resetting sessions on password update.
ok, did that.  this should be good now.
Given that we determine the iGC vs. GC state in main.js we totally loose this feature now with the above change. Do you mind using the labels as given in the config for now as output properties?
It's just a better structure and it also limits the amount of data located in the top level folder. It's annoying when coding and you see all those files in the project pane.
Yeah, I can see that - with the extra clarification that makes reasonable sense, and a clearer error message would address the problem well.
Well, as long as the pattern has no false positives we're good.

Looks good to me otherwise.
same top level comments as for above class
Thanks @domenic :) Always good to learn new things!
such comments often indicate that it should be moved to own method. I think it can look better if you have
```
define map FromAY(map input)
{
    y2debug("input %1", input);
    list<map<string,any> > ifaces = TranslateInterfaceNamesFromAY(input["interfaces"]:[]);
    ...
}

list<map<string,any>  TranslateInterfaceNamesFromAY ( list<map<string,any> ay_interfaces)
{
...
}

Of course if ycp is object oriented, that it should be moved to own object, but it is another story.
Per previous comments, track this in the SendResponseListener.
From the original docs

```
 <section xml:id="zend.mvc.quick-start.install.using-git">
      <title>Using Git</title>

      <para>
        Simply clone the <classname>ZendSkeletonApplication</classname>
        repository, using the <varname>--recursive</varname> option, which
        will also grab ZF.
      </para>

      <programlisting language="php"><![CDATA[
prompt> git clone --recursive git://github.com/zendframework/ZendSkeletonApplication.git my-application
]]></programlisting>
    </section>
```
There is not need for import subnamespaces. You only  need import namespaces when you need to go at least one namespace up

```
A
 > B
    > D
 > C

From D to B, D|B|C to A, C to B|D.
But not from B to D or A to B|C|D
```
this construct is weird. Is returning false.

Seems this was a method before. If this must be a construct $list can use typehinting and the default value must be removed
i only brought it upp because i didn't see anything about it in the coding standards
Two things.

- First, plugins can't necessarily expect that the controller will have overloading for plugins. As such, you should check if they have a getPluginManager() method, and pull the plugin from there. If they do not, you can instantiate the Redirect plugin directly -- but you'll need to only use its toUrl() method in that case, as you won't have the router injected.
- Second, I don't like using try/catch as a form of conditional. I'd prefer using an optional flag as a second argument to the method, indicating whether or not the $redirect argument is a fully qualified URL. (If it's a route, and the controller doesn't compose a plugin manager, you would then raise an exception.)
Ha, yeah :).
I would use "label" here, actually. This is more similar to what we did in ZF1, and would be more in line with the verbiage surrounding buttons (you usually talk about the button label, not content).
This line includes the year 2012, which might be confusing to some. We might consider updating it.
@samiluukkonen @jonikanerva Herrat. Tässä mentiin nyt mönkään. Tuo oli koodattu niin, että toimitustavalla oli mahis yliajaa yhtiön oletukset, mutta ei pakko yliajaa niitä. Siksi tossa oli noi OR:it, saatiin resulttiin ikään kuin kaikki ne toimitustavat joille ei oo eksplisiittisesti kielletty kuljetusvakuutuslaskenta.
because there is no such conf in ezp-next, no idea how it should be done. that is where you come in :)
shouldn't it be
if ! use extensions
?
I actually want all the files, not the first one.
why storing it in a property of the object ? you only use it in this method.
OTT indent!!!!

8 spaces only!
Missing a `var` here.
I'm not sure we really need this state. The caller is feeding in characters one-at-a-time anyway. If they care about whether or not there's a literal `@` in the authority, they can check for themselves. The only thing information is used for in `parse_url_char()` is to make sure that we don't have consecutive `@`s, but even that's not a complete check -- we should really be checking for whether or not there are more than one. Again, the caller is pretty well positioned to do this with a simple counter.
The sys.exit(0) has the same indention as the print statement proceeding it.
I prefer keeping the explicit version. Otherwise the too lines look like this and I find it hard to read.

    (function($) {
        $(function() {

I'll remove the $ parameter though.
Oh? Why not just update it? This is weird.
`models.signals.post_save` -> `dbsignals.post_save`
Maybe change the message here? I don't know, just nit picking.
This can reduced:

```js
// Call the plugins defined update method if provided
if ( trackEvent._natives._update ) {
  trackEvent._natives._update.call( this, trackEvent, options );

  // Update track event's array positioning
  addToArrays( this, trackEvent );
} else {
  options = Popcorn.extend( {}, trackEvent, options );

  Popcorn.addTrackEvent( this, options );
}

return this;

```
うまく動かなかったっす…
I changed this to be forward moving which this change can't be applied to
login is there for User model to be able to be queried by login
good catch, however i think it should be

if compute and capabilities.includes(:build)

@abenari can we access the selected provisioning type in this stage (assuming the value is not always set)?
you can use a scope instead

e.g. dns_proxies.paginate...

see https://github.com/theforeman/foreman/blob/develop/app/models/smart_proxy.rb#L23
how about
`date = datetime.strftime('%m/%d/%Y')`
Is that not the same?
Same here with the title. Also I think a more descriptive name for this exercise would be "Prism volume and surface area", so the filename will need to be updated too.
pluralize?
I wouldn't name it `:valid` as this will need to be a class name too. Something like `cssvalidation` since you test both `:valid` and `:invalid`.
Blockquote and break tag
позвонить вершине?
Esto es una mierda, no compro!
Why not use the global `irc_client` variable?
Style: catch statement on new line
I don't know that this needs to be part of this pull request or anything, but does it make sense for these random functions to be in the main source tree as opposed to the "test" source tree?  Do we want to ship them as part of the uberjar?
Groups in the Groups API and groups in the Authz API are different. The groups in the Authz module are a low-level concept of something that aggregates memberships, and pushes permissions down a chain of principals. You can get the members of those without "having permission to do so".. it's a library, not a user-facing high-level function. Content can use it to aggregate "memberships" and propagate permission across embedded content.

Groups in the Groups API are a high-level "Group" that a user creates. They have profiles, specify a visibility, worry about what information different users can see, etc... Some of their functionality (such as managing members) can be delegated directly to the AuthzAPI if it wanted to (and it currently does). At this level it probably isn't really considered a "principal" anymore, it's really a high-level entity.
Excessive space?
This and line 850 should be replaced with:

    $output = trim(preg_replace(array('/\r/', '/\n+/'), "\n", $output));
This is missing a comma.

Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ')' in D:\www-life\apps\dev\dan\uds-cbord-to-excel-stable\application\libraries\MY_Upload.php on line 111
Не оптимальный алгоритм мутирования. Его можно улучшить.
test_eigh
Yes

Le 6 déc. 2012 à 19:38, "Denis A. Engemann" <notifications@github.com> a écrit :

> In examples/plot_topo_compare_conditions.py:
> 
> > +
> > +print epochs_au, epochs_au
> > +
> > +layout = read_layout('Vectorview-all')
> > +
> > +evoked_au, evoked_vi = epochs_au.average(), epochs_vi.average()
> > +
> > +
> > +###############################################################################
> > +# Show topography for two different conditions
> > +
> > +pl.close('all')
> > +for evoked in [evoked_au, evoked_vi]:
> > +    pl.figure()
> > +    title = 'MNE sample data (condition : %s)' % evoked.comment
> > +    plot_topo(evoked, layout, title=title)
> Sure! As to the plot. So what you have in mind is to iterate over channels and plot e.g. two conditions inside a channel window rendered in MNE analyze colors?
> …
> —
> Reply to this email directly or view it on GitHub.
>
You shouldn't mix comma styles. Pick one and stick to it (preferably the one with comma after the value). Same with the space after some of the keys.
Maybe not for this changeset, but we should move the `@devlopment_cors` decorator to `decorators.py` and delete `cors.py`.
And actually, it does exactly the 2 steps defined here (plus some validation on what you write in the requirement)
We do you use this format? Doesn't a normal `:method:` role work that same?
Doh!  That was some debugging code that was left in by accident while I was trying to get Guard running.
What is body? It's not documented in the above documentation.
`platform.faq.search.title`
Might make the initialization separate since you reuse res in the rest of the code and it might keep the logic better separated.
Could you make it so that it only disallows it when the dtype size changes?  Also, it would be better if the error message called it an "NA-masked array", because NumPy contains a separate masked array implementation in the numpy.ma namespace.
Creo que moment.js tiene un feature para hacer estos fuzzy-dates.
Ok for the 2nd and 3rd point. But we are not actually creating a service check here. We are just configuring it.

Users will be able to create service checks in the future, so we should keep this terminology when they will actually create it.
What do you think ?
New `Move` in each turn with `hit` method.
please use `$app['request']->attributes->get('bas_id')`
doc the function
Wow, glad to be wrong about this! I'll refactor this and update.
Thanks -- updated https://github.com/customink/chef-cookbooks/pull/1 which will show up here when CustomInk merges on their end.
Could you go through the patch and avoid all the whitespace changes? I know, it's annoying but it might prevent a lot of annoying conflicts.

You might be able to achieve this just reconfiguring your IDE to auto-format consistently with the existing format - as I guess this happened auto-formatting the file.
Instead of replacing ids, leave them unused and create new ones. It'll make it easier to deal with all data if we need to at some point.
totally agree, was just asking if things could break completely because the lib would not expect to have no links and not be able to handle that.
Ok. Good point.

P.S. If this were against master, I would consider auto generating the table in ```boilerplate.py``` rather than doing it on import of pyplot.
Whatever feels right. If the docstring is enough for a source code reader to understand fully what is going on, then just a docstring is fine.
Seems a little redundant. Perhaps this dictionary could go in the ```conf.py```?
@WeatherGod To clarify, you're going to address the PEP8 issues here (along with the rest of the mplot3d module) in a different pull request?
Too many blank lines(3)
styling related (I'd prefer to see this fixed, I know we don't yet have nemo-wide recommendations, but we should) is generally that there's a space after Item before {
Тоже кажется что клонировать форму тут не надо.
Так же PrimitiveRule и все связанное с ним отсюда вообще желательно в отдельный request вынести что б не мешался и ему не мешали.
excellent point, seems we missed that the exception might also be thrown on save only.
ok.  I think that, frankly, it's fine to just note it in basecamp -- which I've done.  I'll take this out.
It's probably less expensive to keep the generated ID in a variable and use it here instead of going to the element.
You would suggest `fromNull()`?
Just a thought: Do you think it'll help fellow frontend devs if we add a description on every mixin? Given that the intention is for them to be reusable, we should do everything we can to ensure that's an easy process - and it starts with docs. At least for me, its really hard to read through the mixing styles and figure out how its supposed to look :)
I forgot about this one... let me take another look.
I've updated the docs and clarified that cursors cannot cross transaction boundaries.  That was already enforced by the API layer (__session_begin_transaction and __session_commit_transaction).
- Are you sure ``'test.php'`` has the correct type as "string" is not a sub-type of "string"?
- Are you sure ``'< 1'`` has the correct type as "string" is not a sub-type of "integer"?
- Are you sure ``$locations`` has the correct type as "array<integer,string>" is not a sub-type of "string|array"?
Diese Methode scheint mehrmals, für jedes Model, vorzukommen. Wäre schöner an einem Ort mit Type Parameter.
Bin bei solchen check Methoden eher der boolean Typ. Gibts mit Exceptions einen Vorteil den ich gerade nicht sehe?
When you're going to test, please take a thorough look at this function. I believe I've coded it right, but I am somewhat unsure that it all works out properly for everyone else.
Is there a reason you changed these?  It'll break all old fisheye hooks.
Will those lines be uncommented later?
if don't think else is necessary
What is Service.<init>? And can we use something that's readable in text as well as marked up?
Delete this one. It is redundant now.
Indendation!
So, still, you should define a new signal here and then hook onto it.
There are special atomic operations for such things. And you continue only if you succeeded.
Why is `parseJSON` needed? JSON should be parsed automatically?
I did that, it's just not yet committed. What I'm saying is that using this format we get dates formatted like "Sat, 23 Mar...:" so if the user has different language selected (Slovenian for example), he will receive date with Slovenian abbreviations for days and months. And that's not good when sending updates with the pushserver, because javascript can't parse Slovenian date, it only knows English. :)
There should be a default overload for `updateAssign(arith)` so that overloading `updateAssign(add)` etc. still work as before. I think `arith` should be an implementation detail unless you actually need to do something unusual with precedence or fixity.
Please check each iteration including the stop iteration for this one
In this case there is no given target, so I'd just reproduce the default value for target in plain_link calls, which is the empty string. The same logic needs to apply in r2/templates/link.html, too.
this service could be private as the listener is the only place using it
If that makes sense to you and your users , it is more than OK with me. I am not familiar with Minkowski Functionals and the relevant notation so that through me off. I equally agree that really long names are not nice either. I made the suggestion/comment for your consideration. Feel free to do what makes sense to you.
installed by hand? reason?
Oops, sorry for that, I had added this null check, but apparently did not
push it to the branch. Sorry again


On Mon, Dec 10, 2012 at 5:32 PM, Lee <notifications@github.com> wrote:

> In src/test/java/org/kiji/schema/testutil/AbstractKijiIntegrationTest.java:
>
> > @@ -107,22 +172,41 @@
> >     * @return an HBase configuration to work against.
> >     */
> >    protected Configuration createConfiguration() {
> > -    return HBaseConfiguration.create();
> > +    return HBaseConfiguration.create(mStandaloneConf);
>
> I just added a null check here and pushed the rest of these changes.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/kijiproject/kiji-schema/pull/16/files#r2372811>.
>
>
Nit: The top of this comment block is not lined up correctly.
seems some change was forgotten here :p
where is it used in `circus.` ?
If you could have a repro for any such scenario forward that to me and I'd investigate more in how to avoid and improve that.
It's accessed and checked a lot, so i think it wouldn't be worth it. And what I'd want to express is not that this is actually private. I'd more like to make `resource_id`into `RESOURCE_ID`, but as I said it's not set from the start. I'll leave it like that, I should maybe actually write some small bit of documentation how it works.
@ColinHebert's suggestion is not necessary. I don't think the script belongs in `/bin` but `/etc/profile.d`, but it is what it is.
is this the full hessian of the new ``objective_func``?
Btw, that reminded me of what I didn't like about `ya2yaml`. It's the way it dumps symbols:

```ruby
1.9.3p194 > YAML.dump :foo
 => "--- :foo\n...\n" 
1.9.3p194 > :foo.ya2yaml
 => "--- !ruby/symbol foo\n"
```
Not that it's a serious issue, but result from `ya2yaml` doesn't looks as nice and clean as the one from the default dumper (if you ignore this `...\n` thing at the end).
Whoops, looks like there's a [builtin String function](http://www.ruby-doc.org/core-1.9.3/String.html#method-i-rjust) for this. So I guess we can do

```ruby
code_point.rjust(4, '0')
```
@timothyandrew, you can use [`Struct`](http://www.ruby-doc.org/core-1.9.3/Struct.html) class for that purpose. Creating `CodePoint` struct will be pretty easy, but in return you'll be able to do `unicode_data.codepoint` and any mistype in the name of the attribute won't stay unnoticed.
I tested both languages, but there is no difference if i change the language, not by search result, not by search engine language.
Why @Ignore?