labofsahil/github-event-dataset-2012 huggingface dataset:
Actually these are missing too:

# Disable blackscreen issue after a call
ro.lge.proximity.delay=25
mot.proximity.delay=25

# Hardware rendering (GPU)
debug.sf.hw=1
debug.composition.type=mdp


#
# system props for the MM modules
#
media.stagefright.enable-player=true
media.stagefright.enable-meta=false
media.stagefright.enable-scan=false
media.stagefright.enable-http=true



BoardConfig.mk:

TARGET_AVOID_DRAW_TEXTURE_EXTENSION := true
TARGET_USES_16BPPSURFACE_FOR_OPAQUE := true
As with => Like 
(a tiny bit simpler)
Shouldn't we be using namespaces for our URLs?  I think it's likely we'll have any number of 'detail's view and as we discussed in the best practices I gave on this, namespacing helps avoid naming collisions which will crash the application and allow it to be more extensible later.
vam_known_repositories is too large name for function prefix. But I do not know, what will break if I rename existing functions.
Am 01.01.2012 14:46, schrieb zachariasmaladroit:
> bleibt der Bildschirm für immer aus ?
>
> ich musste mindestens 5-Mal jetzt mit dem neuen Kernel auf die Home-Taste drücken, damit er wieder aufgewacht ist :P
>
> das schien aber nur beim ersten Mal so zu sein,
>
> ich lasse das Handy jetzt so vor sich hinträumen und versuche es später wieder aufzuwecken - ob wohl das gleiche passieren wird ? hm :/
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zachariasmaladroit/android_kernel_samsung_aries/commit/04f33dfc725d8ab999d0569c0428a97f71920cc4#commitcomment-830277
>    
ich haber auch mehrmals gedrückt. allerdings recht schnell 
hintereinander. hab es dann jeweils mit lange power knopf neu gestartet.

was ich mich grad noch frage. hast du denn vorher auch schon etwas 
angezeigt bekommen bei TOP = on? ich nämlich erst, seit ich die varibale 
geändert habe. vorher hat ns tools immer nur deep sleep gezeigt.
We really need a function to change a node's property which is of "url-loadable" type. The prototype of this function may looks like:
ADMNode.replaceURL(searchString, replacement)
"Ordered List" might be better than "OrderedList"
It doesn't necessarily have to be injected, but it MUST be the same instance to work correctly, so a factory design would be the safest to enforce that requirement.  Yet I simply don't have any use cases for this functionality, and without use cases it's easy to get wrong and it would come at the cost of complexity.  I'd recommend going with the present design, which supports extension albeit with some caveats.
Perfectly agreed. I do hate the noise as well. In the next release of the plugin, I'll attempt to provide a goal that is part of the default lifecycle and then we can remove the extra bits here. Noted this down to get to it sooner than later
Please use parseHashType() here.
actually we have to do that, because the actor in the message is different
I don't know. I think Patrik wrote that line. Can perhaps be removed.
Umm, maybe this should be backported to cluster as well?
this should delete the entry from `data_timestamp` when the connection is removed. (or if the connection was already removed?)
According to the [manual](http://www.opengl.org/sdk/docs/man/xhtml/glTexImage2D.xml):

    **target**: Specifies the target texture. Must be GL_TEXTURE_2D, GL_PROXY_TEXTURE_2D,
    GL_TEXTURE_1D_ARRAY, GL_PROXY_TEXTURE_1D_ARRAY, GL_TEXTURE_RECTANGLE,
    GL_PROXY_TEXTURE_RECTANGLE, GL_TEXTURE_CUBE_MAP_POSITIVE_X,
    GL_TEXTURE_CUBE_MAP_NEGATIVE_X, GL_TEXTURE_CUBE_MAP_POSITIVE_Y,
    GL_TEXTURE_CUBE_MAP_NEGATIVE_Y, GL_TEXTURE_CUBE_MAP_POSITIVE_Z,
    GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, or GL_PROXY_TEXTURE_CUBE_MAP.
Could you explain this in a bit more detail?  It looks right, but I'm trying to wrap my head around it.
Yes, since in the new db as well is display_name is not explicitly specified, we are setting it to be same as id and not None.
I'll add a comment. They're disabled because I couldn't get them to work, even they work at runtime...
If this brings on the beginnings of namespaces, I think we should start that sooner rather than later.

I think if we aren't really ready for this, we put the whole thing off until we are.  It isn't that intertwined with other changes.
This it a really device property from registry. :)
This doesn't look right. It will change the sort method of the tvshow view to whatever the user set it to in the movies view.
foreach оберни
Is dat niet al?
Like the MiAttempt, this should be in a write-only block
This is the first blank line.
Ça change que c’est la façon normale de nommer un fichier YAML, il n’y a aucune raison valable pour changer l’extension en `.txt`.
Let's change this to "Failed to make target dir ~p: ~s\n".
Is the * 10 / 10.0 really needed? isnt round enough
I disagree…
I'm having trouble finding the link at the moment, but this is the way Apple actually recommends doing it.
Imports go at the top, sorted alphabetically.
It's note for CURRENT implementation for Linux. I'm think more information can be see in source code.
2 space tabs are used in node's source.
That's only useful if you're creating the same string many times, which isn't the case here. Frankly, we're overusing (abusing) String::NewSymbol() a great deal in node.
Merge conflicts are one of the trickier things to handle and are handled differently for rebasing and pulls. I don't know how much instruction to include here. Maybe just a link to a source providing more detail. A link to the to [Pro Git](http://git-scm.com/book) could be helpful.
It was the only way to make sure. Movie ends before the popcorn ;)
I think that is taking place in [lines 1135 to 1137](https://github.com/ElDeveloper/qiime/blob/issue_492/qiime/util.py#L1135-1137).
здесь тоже
Ahh Yes. Updated thanks.
@tenderlove this would work if you're have some visceral hatred of `flatten`:

``` ruby
def select!(*fields)
  fields = fields.shift if fields.first.is_a?(Array)
  self.select_values += fields
  self
end
```
`||=` ensures calling `Rais.initialized?` won't throw an exception because the class variable  `@@initialized` was uninitialized. Now that I refactored and use an instance variable the problem goes away. So I'm pushing a new commit now. Thanks!
Great! Also remember to add a CHANGELOG entry for the deprecation.
For starters, that causes an exception as it isn't valid ruby. We also only have one data attribute, so it seems a bit overkill to use a hash when we don't need one.
What we should be doing is ...

```ruby
if config.action_controller.perform_caching
  begin
    require 'rack/cache'
  rescue LoadError => error
    error.message << ' Be sure to add rack-cache to your Gemfile'
    raise
  end
  require "action_dispatch/http/rack_cache"
  middleware.use ::Rack::Cache, { :metastore => "rails:/",
                                                              :entitystore => "rails:/",
                                                              :verbose => false
                                                            }
end
```

And removing this https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/railtie.rb#L16-21
Isn't that triggering an extra save call here, that might be unwanted? Not sure it will affect anything, haven't looked further.
I think yes.

If we had error here - is infinity cycle. We set time limit and it's garantee that thread was worked correctly. It's protect us if thread suddenly don't stoped -> will be returned nil and -> test case will be failed.

Without limit, test case will be hung.
How about calling this simply `all_for` ? Using the word "full" implies that there's a way to ask for a summary of some sort; this way it's also shorter and it reads nicely: `@person.errors.all_for(:name)`
This commit originated in a bugfix which fell apart; that was from the
salvage operation.  It's an obvious missing piece of LazyType.  I work
pretty hard on breaking everything up but I also try to avoid pointless bit
jockeying and since nothing calls it yet and its purpose is self-apparent,
it seemed like busywork to break it off.

On Wed, Oct 3, 2012 at 12:14 AM, Josh Suereth <notifications@github.com>wrote:

> In src/reflect/scala/reflect/internal/Types.scala:
>
> > @@ -3427,6 +3427,13 @@ trait Types extends api.Types { self: SymbolTable =>
> >      override def safeToString = "<?>"
> >      override def kind = "LazyType"
> >    }
> > +  object LazyType {
>
> Is this a sneak preview of an upcoming commit or am I missing something?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scala/scala/pull/1438/files#r1747257>.
>
>
thanks for noticing, making them `private final val` has exactly the right effect (i.e. inline the constants and hide them from Java).
Well, it's a tradeoff, and this might require rewriting a few docs.
Some people argued heavily in favour of explicit selection. For compatibility reasons, it might make sense to leave an implicit default in the parallel package and deprecate it.
Could you add some tests for a value class wrapping `String` and one wrapping `Any`? I'm not sure these are treated correctly.
I think these two checks should be checking for the content within a specific element on the page.
I renamed the function, and expanded the comment at the function implementation.
search and replace /__class__ == /is_/
leave a blank line between functions.
Did you intend to show what s is?
never mind...I see they are all 'pass'...are these place holders for functionality that should have been added?
perhaps a hint should be 'meta' and all the meta hints go there, e.g. `expand(mul=True, meta=dict(force=True))`
we need to check if callee is modal here and prevent replacing the content of __deactivatedManagers
Since it does not hurt to use `\text{}` in the non-math mode, I tend not to check if `inherits(x, 'AsIs')`; I can change this by myself

Thanks!
It's possible that chmod may fail.
I am not sure that CSS or images are covered by GPL, but if it is, we cannot include anything which is under the GPL license.  Permissible licenses must be GPLv3 compatible but not GPL as it forces all our code, and therefor all 3rd party modules to require to be licensed as GPL which is unacceptable for our ecosystem.
check style will complain, add /** */
__==" ---> __ == "
er was this a mistake @sr?
Этот экшн должен выводить ТОЛЬКО все ивенты, выводом ивентов, принаджежащих юзеру должен заниматься контроллер User::EventsController (см. его, там тоже правки надо)
Can these colors not be defined in a stylesheet?
- see above regarding semantics for copyDatabase
- s/commands/commnad/
- member of what.
Also, though I don't mind it, some other dev team members don't like inline assignments when they aren't for whatever reason necessary, so define $avatar first on its own line.
This seems to be unnecessarily complex. it should be possible to build a query using the two individual cases m_approve and m_report with two independent ifs below
If the user has a file called ".php" in the api directory, that makes them a stupid user :-D
This line shouldn't be removed.
51988a495a33e515030bbbe78811f01c9aa5fcd5, validation also happens in the API endpoint.
How is this test going to pass?
These methods could be one. First that comes in mind:
```cpp
enum Face { FRONT, BACK, RIGHT, LEFT, TOP, BOTTOM };

bool setFaceImage(CubeTexture::Face face, const Image &image);
```
Just a comment, but `rescue ActiveRecord::RecordNotFound => exception` would seem more 'ruby-ish' to me than running the exception through an if construct.
For ref, there was unresolved conflict there!
remove commented code (applies throughout)
looks like formatting got messed up here. please review
I don't find this line an improvement (though I agree that the original isn't good either). Hmmm....
On first appearances, I'm not a fan. I'd rather the "sloppy" check in iris.analysis.cartography.rotate_pole was made more rigorous.
Happy to discuss elsewhere, but on reflection @ajdawson has convinced me and I'm happy to see this function only accept numpy array like things. This certainly isn't a blocker once the docstring is updated.
This won't work in DebugMode as it don't call std_fgraph().
That would make more sense, but I'm not sure I want to make validate, which should only run in assertions, a public method on core. It's bad code, but it's "contained" bad code.
This is suitable for code that would not grow much, not a case here for perl oneliners. sorry.
__unicode__ missing
use int on parameter one time, and just == in all comparisons for simplicity
Done in 56b31e9
Also, please use bool. by returning an int im expecting something like bytesWritten or something else.
sounds like e method more than a test method :)
Any reason why this is removed? It seems important for security.
I wanted to leave it out, but was instructed by higher powers that it had to remain. :P
Everywhere else, regex is expanded to the long form. If, in this instance , it is an allusion to the kwarg, it might be prudent to mark it up, or denote it in some way.
Sorry I'd split up some paragraphs and nor properly proof read them.
You right, But I check the code and no need ActiveRecord dependencies. I do a pull request to depend of railties instead of rails. I do a lot of pull request of this kind.
Sounds like you could have done that as {receiving, Opcode, <<>>}.
Thx I forgot that this model it's used for all the different hazard calculations. I'll fix it.
A TODO for the future: we probably want to make InstallContext and InstallArgs into proper data types with documented fields.
Missing closing single quote.
Right, my question is whether `[0]` is just ok or if it's required.
Could you split this line to keep it under 80 columns, please?
Two reasons:
1) There is no need to generate the subsets of the itemsets in the current iteration, since we will generate all of them after the end of the loop. As you see from the code, we did self-join on assoc_rule_sets.
2) I did a full search for the text "assoc_set_list_parts", "tot_parts", "tot_parts1" and "tot_parts2", there are no reference on them. And list_c has the values in column "set_list" as the column in list_b.

```
  EXECUTE 'SELECT MADLIB_SCHEMA.assoc_svec_list_parts(''set_list '', '' list_b'', ''assoc_set_list_parts'')';
 
  EXECUTE 'DROP TABLE IF EXISTS list_c'; 
  EXECUTE 'CREATE TEMP TABLE list_c AS 
  SELECT
    d.set_list
    , c.*
  FROM (
    SELECT
      p.hash_key
      , count(*) as tot_parts 
      , count(a.hash_key) as tot_part1 
      , count(b.hash_key) as tot_part2 
    FROM
      assoc_set_list_parts p
    LEFT JOIN
      assoc_rule_sets a 
       ON MADLIB_SCHEMA.svec_hash(p.subset_x)=a.hash_key
    LEFT JOIN
      assoc_rule_sets b 
       ON MADLIB_SCHEMA.svec_hash(p.subset_y)=b.hash_key 
    WHERE
      MADLIB_SCHEMA.svec_l1norm(p.set_list)= '|| n+1 || '
    GROUP BY 1
    HAVING 
      count(*)=count(a.hash_key)
      AND count(*)=count(b.hash_key)
    ) c 
  JOIN
    list_b d 
      ON c.hash_key=d.hash_key 
  m4_ifdef(`GREENPLUM',`DISTRIBUTED BY (hash_key)') 
  ';
```
Can you explain why this is a valid weighted sampling?  It seems to me this code accumulates the weight from the beginning of the row and randomly select the row identifier value if it's success.  Doesn't this mean it relies on the order of input, since the weight_sum sees only the rows seen up to now and it gets different if the order changes.  In that sense, I don't think this can be achieved with a single simply aggregate, but it needs something like window functions or multiple queries.  Please point me if I'm wrong.
1. Output theoretically has unstable sort order since the array_agg is not ordered.  This wouldn't produce wrong results, but could make testing more difficult.

2. Looks like we are using an svec as a compressed bitmap here.  I'd have to look at the rest of the AR code, but if we're treating the svec as a bitmap universally then we have room for an optimization.
Good point.  I pushed as it stands.
I think we should use the reserved hostnames from [the RFC](http://www.faqs.org/rfcs/rfc2606.html), like example.com, so that we make sure we don't hit an actual server.
There was some talk about adding something like

```rb
depends_on :autotools
```

that would encapsulate all these conditionals using the new Dependency framework that @adamv worked on.
Or `(Pathname.pwd+"CMAKE_FIND_ROOT_PATH.txt").write "...."`
generally we prefer to pass in a full `redis_config` dictionary that is read from the YAML config file like we do [here](https://github.com/praekelt/vumi/blob/develop/vumi/dispatchers/base.py#L256-259). Gives us a bit more flexibility & less hard coding.
Crud, I miss clicked again. the "previous bullet" referred to the first one about automatic retrieval.
ok.. isn argument..
Could you please factor out the duplication:

```scala
def osgiExport(packs: Seq[String]) = OsgiKeys.exportPackage := packs.map(_ + ".*;version=${Bundle-Version}");
```
Don't need `else` after a `return`.
Callback hell!!!
Changed this to a init hook: e3fabda
Why not name this "hashToArray" as you had it before?
only use f prefix on fields, not locals.
Also, JUnit style is to name loop variables "each", that is: for (Class<?> each : categories) {
missing space before =?
I think this needs to be a true existence check since someone could accidentally try to loop over false.
Why do the first four vars have `Module` in the name, but the last three don't?
Nice--thanks for starting to refactor this out into a config file.
This comment line should be split so that it fits in 80 columns.
Typo: constas -> constants

Also: AddMenuItem() -> addMenuitem(), I think?
I'd like to treat `complete_util` and `base_handler` as public API, where we don't just remove something but deprecate it instead. We don't have many third party plugins yet, but let's do everything we can now and in the future to not break them.
I'm a pretty big fan of never, ever using `==`—just not something I want to have to think about every time.
That makes sense. What is good practice when choosing a "TAG" for `android.util.Log.e(TAG, msg)`? I would think the name of the class, but in this instance it seems too generic.
It's aliased as Array() too. I <3 it.
Shouldn't you also for `ul` define that it is not a list anymore?
the `else` is not really necessary because the if statement is exiting. This can be rewritten as:

```ruby
if type.nil? || !['post', 'site'].include?(type)
  ...
end

if type.casecmp('post') == 0
  title = options['title']
...
```
i find it mildly interesting that some of the classes i'm being told to add docstrings to are ones i copied that either you or @zacc wrote. but that's fine. if you want docstrings on every click, i'll put them there.
"This is the current popcorn instance"
does this fix the undefined _defaultTarget on the Butter object?
If you move this to an external .css file, our csslint will check it automatically, and the browser will be able to cache it.
This can be left as `ready`. The `onMediaReady` function above already calls `updateUI`.
Do you need to put this in a `DOMContentLoaded` listener? What are you waiting to be initialized before you go ahead and insert this on Butter? It looks like the only thing that relies on `Butter`'s existence is the code you have to hook `editorHelper` onto it.
Namespace path missing
Even in tests, we should really avoid this coding style. It's a poor example of how to manage files.
We are doing manual merges of the generated webpages. So we are trying to keep everybody on the same version, and right now we are using 1.1.2.
When we eventually get an automated system going, we would be less strict on the version.
This "Authentication" section is a sub-heading under "What's new in version 3?" The focus is less about providing a general overview of authentication and more about describing what has changed about authentication since version 2. I'm happy to include this information somewhere in the `README`, but I'm not sure this is the right place.
try to use `com.twitter.logging.Logger` rather than `println` in prod code
When you close it should also wrap it in a `try{...} finally{<close here>}` to make sure it closes even if you have exceptions
Здесь точно нужно во freeze передавать результат `FREEZE.realpathSync()`?
Какой смысл у этого теста?
I had to add that in rc8 to be able to compile but I don't know why everyone else seem to be able to compile without this...
to ke baz img gozashti ke !
repo ro update kon man img ro hazf kardam, goftam span bezar display block kon
For the constants below, the type will default to Int. Is that compatible with zlib, or should you ensure that all the constants are Int32, for example?
Shouldn't the guy with register_systems, create_systems also be able to delete ?
Yes, good catch. I thought he had a patch that fixed these but I see more in this file too. I'd rather not mix these changes into the PR.
I'll ping @pitr-ch and coordinate a different PR.
See previous comment above with links to to Koji builds of rubygem-hooks RPM
Good point on sub-mgr version. Definitely check into that
This doesn't work like we would expect it. If you remove the file, new update will put the file there back anyway. Additionally, if you edit it, it will create .rpmsave file in the same directory (which is executable as well) and you will end up with 2 scheduled scripts. %config(noreplace) doesn't work either (it creates .rpmnew file instead, but the problem is the same).
Just curious, why not allowing `<ol>` too ? =)
Same thing here all the braces should be on the same line for if/else (and try/catch below), also this should be `>=` and not `==`.
Not quite sure what you mean about the first point "return a respons/broadcast themselves"
I guess altering the alter the parameters before invocation should be possible.

Do you want me to continue working with it? I'll take a peek inside MVC source code for some more details there.
This is a bit ugly, I would write these lines in a src/scripts/add-zentyal-desktop-service bash script and then execute it with EBox::Sudo::root()
You should try to catch more specific error, `OSError` should work in this case I think.
convolve.py doesn't have it either; I've added it to both
Cool!  I didn't know about this feature of IPython.
I sent a message about this a few days ago but I think it got lost in the e-mail.  My message also pointed out the factory class pattern, and I agree with @taldcroft.
shouldn't `self.meta` be *copied* instead of passed by reference?
那也至少叫DayBased 而不是 Daybased~
I think a timeout, infinity, or maybe somewhat shorter, is needed here. I've done some testing on Joyent where it can take 10 seconds or more to calculate the stats.
Success is reported before the nodes stop
I think this is insufficient. The help string should describe what subset of BIP 22 is supported by this implementation, or maybe points to a wiki page that describes exactly what this version of bitcoind supports.
IMO, that's an "irrational user expectation", not a requirement :p
Maybe use `->read(1024)` here instead of `->readAll()`;  I agree that MITM attacks cannot inject any useful information, but they could be used to DDoS by sending a very large response.
Agreed. Updating now.
I'm with gruez on this one. LegalCopyright is a separate unit, but I don't see why split LegalTradeMarks1 / LegalTradeMarks2 at a illogical place between two words.
This should be `And "fake@email.com" is a member of the group`
I can't tell if this line has a ls (label-separator) or not.  
The M language requires such following a label.  
The word "fox" is clearly the label,  but it isn't clear whether a space or tab character is following it.


This is documented for the current standard at this URL:
http://71.174.62.16/Demo/AnnoStd?Frame=Main&Page=a106007&Edition=1995
i.e.: 
6.2.4 Label separator ls

A label separator (ls) precedes the linebody of each line. A ls consists of one or more spaces. The flexible number of spaces allows programmers to enhance the readability of their programs.

   	ls	::=	SP	...

this is referenced from the URL:
http://71.174.62.16/Demo/AnnoStd?Frame=Main&Edition=1995&Page=a106003#Def_0002

6.2 Routine body routinebody

The routinebody is a sequence of lines terminated by an eor. Each line starts with one ls which may be preceded by an optional label and formallist. The ls is followed by zero or more li (level-indicator) which are followed by zero or more commands and a terminating eol. If there is a comment it is separated from the last command of a line by one or more spaces.

   	routinebody	::=	line	...	eor
   	line	::=	│	levelline		|	 formalline	│
   	eor	::=	CR FF
Yes, setting `self.notebook_dir` triggers another call:

```python
        if not os.path.isabs(new):
            # If we receive a non-absolute path, make it absolute.
            abs_new = os.path.abspath(new)
            self.notebook_dir = abs_new
            return
        self.log.info('Prints me')
```
Will print the log.
needs to expose Clatrix block functions here
not sure if the caps will work here, should just be "execution.execute"
Why having two loops?

<pre>
versions_list = []
products_list = []
for x in range(0, len(params["products_versions"]), 2):
    products_list.append(params["products_versions"][x])
    versions_list.append(params["products_versions"][x + 1])
</pre>
Won't all of these sleeps drastically slow down the test suite?

If we can make it configurable, we can make it 0.1 and 0.2 seconds instead of 1.0 and 2.0 just for the test suite.
Only one `as` left! 
You're making me happy!
We only put one instance of each class in factories. It is supposed to represent the bare minimum necessary to create a class that is valid. If you need this, move it into teams.rb and I would give it a more meaningful name
Hi Phil, don't understand what I have to do to make it correct.

I have a look at my file.
I would prefer to keep the default comprehensible. For Resx catalogs, just set it to base64. Here's what it looks like in our WP app:

    Catalog.Implementation = new ResourceCatalog {
        ResourceIdType = Vernacular.ResourceIdType.Base64,
        GetResourceById = id => AppResources.ResourceManager.GetString (id, AppResources.Culture),
        MessageFilter = Partner.GetBrandedString
    };

I'd be okay with having a ResxCatalog or something that takes an AppResources instance. Not sure if this is just a WP thing though?
passing an object storing a reference to PDO and displaying thanks to its __toString method ?

Anyway, the only ways to pass an object to the escaper are to display it with its __toString method, or doing crap explicitly (this second case should not happen). I'm not sure trying to cache things there is really needed. Thus, the __toString method of an object could depend on some properties excluded form the serialized data, meaning this checksum could be wrong.
@asm89, what was the intended behavior for this handlers? By the current code I think the idea is to spawn a new default handler for each factory.
Better `isStarted()`
I don't think so. But the latest version (4.0.3 here. I haven't tried the 5.0 EAP from yesterday) takes them into account when generating in some cases.

If you find a way to configure it, tell me :)
It doesn't really validate the regex anyway. It just makes sure there the delimiters are there.
please remove this comment and the extra empty lines
this setup does not allow caching the annotations (it does not even wrap the reader in a CachedReader using the ArrayCache, leading to bad performances). The builder should allow passing an annotation reader instead of creating a new one IMO
this was the only point where the Sf2 CS were not matching the PSR-2 rules so @fabpot switched the Sf2 rule a few months ago.
this is wrong as the RouteCollection is typehinted.
%b って <b> Title: </b> ってことですっけ??
The rescue statement is there to catch the exceptions raised  by URI when parsing an invalid URL.
aside behtare
mitooni age lazem bood dakhelesh aside begzari
推荐把pageref{}也加上。这个可以引用到标签所在页的页码。
@huxuan 代码块需要一定的空白较好。另外，除了listings环境，是否需要Verbatim 环境以满足不同的要求/需求？
@description 和上面一样，需要修改下描述。
There is also Constants.DEFAULT_ROOT if you want to use that if it changes in the future.
StandardError is gone in 3.x, but I don't think supporting everything from 2.4 - 3.x with the same code is a reasonable goal.

`daemon.py` does some process magic that calls `sys.exit()` a few times and results in ugly stack traces in 2.4. I think clean logs are more valuable than being 3.x compatible.
I would take out the check on A, clearly F and Aprime depend on the values of B and C too.

As for the max ... I guess it depends on the units of majorlength here. Is it measuring the length on the unit square? or in texels?
I think you still "leak" this.  How about instead making this a std::vector<uint32_t>, and then do a resize() instead of new[], and you won't have to worry about a free, it will automatically reclaim when the object destructs?
This was the reason I had to remove the ```rivers-lakes-centerlines``` shapefile (its name has changed to ```rivers_lakes_centerlines```)
@Sunight  写操作放在`viewWillDisappear`可能会写得过于频繁，把向`searchHistory`添加数据和写入plist都放去`searchBarSearchButtonClicked `会不会好些？这样只有搜新文本时才写plist
This becomes 2
My precious empty trailing line!!!
Remove this empty function. and the property.
Totally correct, should remove "both" here.
!!! ?
Then the method should be called `_checkDBReady` and this way you won't need the comment :)
curretnContact.category = curretnContact.category || []; is more legible IMHO
you dont' want to declare 'use strict' outside? or you have stuff that is specifically not in strict mode that is also being used?
n -> steps ?
剥离出  bucket，是一种强耦合，可能容易误限 bucket 与原图是同一个。save_as 目前的实现是将 bucket 设为可选的，如果 bucket 不传入，那么就是和原图同一个bucket，如果 bucket 有传入，那么该就存入到指定的 bucket 里边去。

假设了客户有这样的需求，对所有 转化过的缩略图 设置为 publish  然后静态链接访问，而不是通过 api get 多走几步 。如果缩略图和原图在同一个 bucket，那么该  bucket 显然是不适合 publish 的。

当然，另外定义一个  rs.Service(conn, yet_another_bucket) 也行，但是要开发者好区分出是 不同的 rs 对象调用特定的方法。
This looks fine and descriptive. Not sure if we need 2 such small before_filters or if they could just be wrapped into one. You can probably leave this, have to see what the @dhh preference is.
Because we thought all code comments should be in English as @embs pointed out [here](https://github.com/redu/apps/pull/76#issuecomment-10351068).
I think we need associativity here.

scale(scale(a, x), y) == scale(a, x*y)

Otherwise our intuition will be bad.
the hogan.js -> hogan still doesn't make sense to me (sorry, might be being dense). But we distribute hogan as "hogan.js" on npm - not as hogan. In node you require hogan as `var Hogan = require('hogan.js')`. I therefore think that hogan should stay as hogan.js. 

Best practices are fine, but things should work in both cases. You could just change it to conditionally write a name when `outputdir` is present. Like:

```js
'define(' + (!options.outputdir ? path.join(path.dirname(file), name) : '') + ', ["hogan.js"]....
``
Some note about units?
Note that reconnect time can still exceed MAX_RECONNECT_TIME. If reconnect time was 59 seconds and MAX_RECONNECT_TIME is 60 seconds, then the reconnect time will get doubled to 118 seconds. Add a comment here if that's your intention.
false => Fase and true => True
forgot the console.log :)
Would it be possible to extract the html into erb partial? Just to prevent further misuse of this approach to insert HTML code
I don't see any functional difference with this hunk - am I missing it, or is this just incidental?
Indeed. My "advanced" version of this has to be passed the repository URL at configuration time when i create it so that it can do just that.
Yeah. :) Sorry. That will be cleaned in the final set of patches. Thanks for catching!
Agreed. Vi mistake.
or even better, you could do the error handling directly in this method instead of throwing the exception after calling it
These should be static `NSString` constants. Like `static NSString *const kFoursquareToken = ...`
Not sure why this is here.
test class, ignore...
Okay fixed it with an inner loop of the form:

      for( int u = 0; u < npoints; u++ ){
                double dz = scaleZ * u;
                double z = zmin+dz;
Ahhh, I think that I was assuming something different about the code.  I assumed the length of the array of caps is always `MAX_STATIC_CAP`, so we don't need a variable in the `spd` to track that.  I assumed that `spd->ncaps` is the number of *used* capabilities in the component.  We could honestly avoid even doing this by defining an "unused" capability to be one that simply has `destination == NULL`.  I think this might be the way to go:  we don't need ncaps, as we know the length of the array is always bounded by the static constant, and when we need to validate a capability, we simply need to check that the destination is set.  

What do you think?
Can you explain in the comment what you expect here?
Is it the same css as the one in IPython ?
It seems like the parent class is able to get it from IPython dir. 
If we can avoid having duplicate files, it would be nice as in the end nbconvert  will  be merged into ipython.
Why was this done with the Function call before? Just curious about what this actually means.
let's reuse `sourceURI` from `lib/toolkit/loader.js` and remove `deParentifyURL`
My understanding is that it is for all RPs based on @benadida's requirements.
Sample pseudocode:

```
batches = {}
for source in cls.objects.filter(contenttype="perftest"):
    batches.setdefault(source.cron_batch, set()).add(source.project)
```
for some commands, we differentiate between batches.  for some we don't.  process_objects just uses the same interval for all batch groups, but populate_summary_cache has different intervals for different groups.

True about medium.  We don't have anything in that group yet, so I didn't add it here.  But perhaps we should add something we think might work.  Or perhaps the medium batch shouldn't exist?  Jeads, what do you think?
Move this down too, please.
@rbillings odd, it does here: <img src="http://i.imgur.com/2Rozc.jpg">
possibly move footer js to an include file?
hardcoded path again here...
I have just added new entries in the file but I didn't remove the original contents
@vrthra should be upgradeable
Can't you just iterate over the items in ``recentfiles``? Eg.:
    
    for i in self.recentfiles:
        dosomething(i)
yes pls
This takes o(n) time... do we know how often the gauge is triggered?
This while only has zero or 1 round because you set $count with a zero.
Agreed -- if it's going to throw an exception there, we might as well just let the fatal error happen, and save ourselves the class_exists(). The fatal error gives the user the same amount of information as the exception, really.
Why add a ZendMonitor LogWriter by default? I don't understand...
This needs to be translatable and english. There are also more strings to be translatable.
See: https://jenkins.4teamwork.ch/job/ftw.book/Translation_Report
why does this have to be a global?
Right now, this breaks ZfcUser, EdpGithub, and any other modules using ZfcBase that depend on the toArray() functionality for doing inserts/updates. We should work out how we're going to do this properly before we merge this PR so that I can update the other modules accordingly. This is the primary thing holding me back from merging this pull request.
these expressions are not javascript expressions. they are angular expressions which use javascript like syntax. angular expressions currently don't support the `=== ` operator.
It would be good to move these vendor prefix bits to the frontend toolkit.
I'm not sure why it needs to check the user can access all editions?  Although, as there's likely to only be a single edition before publication, maybe this is moot.
```true``` doit etre l'option par défaut pour ne pas changer le comportement précédent
Why do we get the list of modules if not to use them?
why using an underscore in the argument name ? this does not follow any existing CS I know of.
Are there restrictions for managing others' accounts?
Fixed in https://github.com/ezsystems/ezp-next/commit/958d3ffde6b0c1ad659125b9793e093e11b5d7f0, thanks :-)
`%footer.footer`って冗長な感じがしました。
普通にscssで`%footer`にプロパティ生やす感じじゃまずいでしょうか？
And rewrite it as S="${WORKDIR}/${MY_P}"
What is the +6 part here? What are you trying to do exactly?
HPC LDAP
Ok, consistent with others, but I'd turn this around, since the f should be last if you use -xjf filename.bz2
A bit of an explanation as to what this does would be helpful...
On python3 the equivalent to StringIO is a io.BytesIO. Because python2 str becomes bytes on python3 ;)
If you're using funfactory's `LocaleURLMiddleware` the current language should be `request.locale`.
link should be *link else tests will fail
Just FYI, you don't need the square brackets here. Using a generator would work fine as well and it wouldn't need to store the list in a variable. Not that it matters much for small lists like this.
fixed here and l. 31
I think your proposed `"predis/predis": "If you want to use predis"` is still valid even if `predis` is already listed as `require-dev`.
can you add some api documentation here?
it should include the search param etc
I guess it should be `user.resources('posts',...`?
I guess synchronously, not immediately.
If it is not required, it might be renamed to lockWithTimeout(). Datapoint: At least I would have understood that.
You should also add `interactive` in the `moduleDependencies` since you're using stuff from it.
Do you mean like, if the sentence is not flipped?
What happens if the $object is not of eZContentObjectTreeNode class? :)
The main problem is that a `Quantity` or `NDData` are essentially wrappers around a scalar or an array, and the class itself has no specific physical interpretation.  Hence, `unit` is necessary, because a raw number needs a unit to have meaning.

`Coordinate` (or `SphericalPoint`, or whatever - i can see your point on the wording, but it can be discussed there) is a point in space, essentially. It intentionally hides any details of how its stored.  So then `unit` is not necessary, because a point in space is a concept that requires no specific units to have meaning.

That said, one *could* subclass from `NDData`, I suppose, and just force `unit` to always be radians... but then the `coord.radian` and `coord.degree` and so on end up rather confusing, because they then get confused with the `NDData` representation.  I can see the merit of this being used internally (maybe), but to actually be part of the public API as an `NDData` is more restrictive.  Oh, and also `Coordinates` is (intentionally) a mix of a `Quantity` and `NDData` (it can be a scalar or array) because most of the operations you want to do on coordinates are the same either way.  That's *different* from things like constants or spectra, where a scalar spectrum or an array-constant just don't make sense.
Don't need to wait till DOMReady or window-load to bind key events on document
use funtion is_null
getSamples() -> getSamplesCount()
I don't like empty lines :P
I hadn't thought about null values. This might need to be reverted.
I wonder if we want to do the same here as for application and name the default value directly. This would not cause any regression if another build type gets added.
Why 0700 ? that's just binary that can be fetched from git.
+1, good catch on moving that function
Should this be `test_config`?
Yeah; looks like implementing the protocol is left as an exercise to the consumer - or contributor. :)
Note: this needs to worked into the UI deployment strategy and should be removed from node
Contexts is an object when created.
Shouldn't id be a String?
A use statement is missing :-)
Op de zelfde manier kan je dus tracking doen:

```js
heathBar.track(this);
```

Op die manier hoeft de `HealthBar` dus niet te weten dat de entity die hij tracked een Enemy of een Character is.
OK, how does it look now?
I've been told for some of these occurences (not necessarily in the license agreement) that this is actually proper English. It's not my native language and I haven't been taught on this specifically, but my guess is that it's a way of separating paragraphs in tiny texts such as notes.
Да, здесь я въехал в суть, спасибо!
return [@"ACGT" substringWithRange:NSMakeRange(arc4random() % 4, 1)];
Спасибо, не знал про это. Либо не было в лекции либо я просмотрел :)
Есть, советую изучить. Также советую изучить NSCAssert, меня на него натолкнул преподаватель.
А почему бы не так:
```objective-c
static NSString *alphabet[4] = {@"A", @"T", @"G", @"C"};
return alphabet[arc4random() % 4];
```
Можно ещё NSAssert/NSCAssert
я только что понял, что неправильно тестировал, ничего там не ломается, все ок
тем не менее, второй вопрос открыт, что это за магия? =)
А в задании не сказано, что мы сможем менять последовательность напрямую. Всё же, идеология объектов такова, что нужно стараться делать внутренние переменные закрытыми (так меня учили, и так всегда и стараюсь делать).
Разумеется, вышесказанное применимо далеко не всегда. но в данном случае, когда у нас есть объект с последовательностью ДНК, я считаю, что не нужно давать возможность напрямую менять последовательность. Максимум - можно сделать @property (readonly) для данной переменной, но опять же, не вижу в этом практического смысла исходя из задания.
@derats ещё раз - методы категории работают с состоянием класса, состояние класса описывается в интерфейсе **класса**. Мне как данность не совсем понятно, зачем расширения придумали, вот это действительно может запутать. А категории работают логично - с теми переменными, что описаны в состоянии класса. Для генерации символа и символа на замену можно реализовать метод класса.
trackAndProcessResources seems nice!
Naming here as well.
by doing this "self.data[picks]" you do a copy even if picks is None. Is that on purpose?
It should be while not if. See http://docs.oracle.com/javase/6/docs/api/java/lang/Object.html#wait()
"backend busyness" - can you elaborate on this I'm not sure I understand what that is.
ah that's a remnant of the initial branch. will remove those
Oh yeah, under construction...
@weaverryan what's exactly wrong with this? I have deleted the `_form_is_choice_selected(...)` function and added the `selectedchoice` test, because Symfony2.1 created a test instead of a function.
There is only one per ActorSystem. (ActorSystem to Camel/CamelExtension is always one to one)
should be realigned
Because I needed a specific apply method to create the Node instance. Same signature as the generated one but different impl: 
   def apply(name: String): Node = new Node(hash(name))
It is, but at least the race was harmless: fail fast if you don't have a chance to succeed anyway. (By the time we do the rest the remaining capacity might be even smaller and the subsequent enqueueFirst would fail.)

This method is gone now anyway (see above).
I only changed it because my code wasn't running when I didn't have internet access :)
Should we include the MiSeq FCs as well (I think so)? In that case, adding a '-' to the last section of these patterns should suffice.
This seems to be the only "Hey" we have...would a "Dear" be nicer?
There is also
```$txt['paid_subscription_error_body'] = '{REALNAME},```
that could be changed to:
```$txt['paid_subscription_error_body'] = 'Dear {REALNAME},```
what do you think?
Logo should not be in a header
You should use `reporters` variable on 33 line instead of `['text-summary', 'html']`
Why &quot; and not "" like the rest?
random whitespace is random
Thanks for the catch, the raise needs a clause over it checking that the mode is in "DELETING." This way if instances are fubar'd we at least see them.

Now that I think on it though, all the tests passed. It would probably be better to set the status to "ERROR" here, so we're clued into the bug.
We already have: org.infinispan.util.SysPropertyActions
yes, especially for JDG in server mode which uses non-transactional caches.
On 12 Dec 2012, at 08:02, Dan Berindei wrote:

> @mmarkus, this seems like a new feature, do we really need it?
> 
> 
> On Tue, Dec 11, 2012 at 8:37 PM, Mircea Markus <notifications@github.com> wrote:
> In core/src/main/java/org/infinispan/configuration/cache/LockingConfiguration.java:
> 
> > @@ -53,6 +55,15 @@ public int concurrencyLevel() {
> >     }
> >  
> >     /**
> > +    * For non-transactional caches only: if set to true(default value) the cache keeps data consistent in the case of
> > +    * concurrent updates. For clustered caches this comes at the cost of an additional RPC, so if you don't expect your
> @danberidei yes it does make a difference for local caches. when this is explicitly disabled (it is enabled by default) we don't add a locking interceptor to the interceptor chain. So concurrent updates are very un-predictable. I think (this would require more though though) that this would only affect consistency, but I really want to discourage people doing concurrent updates on a cache that doesn't have the locking interceptor in the stack as this would open a can of worms.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 
>
Seems to be working fine in 1.8.7, 1.9.2 & 1.9.3. What version of ruby are you using?
No, I don't. I'll move everything back to FileAsset 'till someone needs it.
mPoket.getPoketCard()および、mField.getFieldCard()はインスタンス作成直後のため、結果は帰らないはずです。
上記2行は意味のないコードと思います。
To check: this was removed because `pyflakes` flagged it as unused?
Additionally, it would be nice to use full sphinx cross linking here (even if the thing you are linking to is not documented). e.g.

```
... which can be found in :class:`~matplotlib.cm.cmap_d`.
```
I'd prefer to see this added to `cbook.py`, the current location for utility functions.  cbook is large and disorganized, but I'd rather do that reorganization properly than start adding things in unexpected places right now.
I can write for another case after this one : )
the the -> in the
you added a trailing whitespace here
Shouldn't the vienna example use style.mobile.css?
Please use SG_ADD and MS_NOT_AVAILABLE
Getting the object on the relationship should probably be done somewhere else, like in DataObject, rather than UploadField doing the discovery itself.
I can't recall if we already have something that does this or not. @sminnee?
The original file is executable. I can add a `chmod a+x` to the copy if necessary. Will copying the file lose its permissions?
can it be an org? i thought orgs can't have oauth tokens on github?
Tried 
          <a href="{% url profiles_view_profile
                   pageuser.userprofile.added_by.userprofile.display_name %}">
            {{ pageuser.userprofile.added_by.userprofile.display_name }}
          </a>

but template engine won't parse it this way :(

The best I can do is to split at href, what do you think?
== false?
Are you sure ``version_compare($install...ersion, '5.3.16', '!=')`` has the correct type as ``*`` is not a sub-type of ``boolean``?
Is `return;` more idiomatic?
Will be removed after debugging, these errors are entirely for the client and will be logged on their end if at all.
Should tags be optional?
This seems somewhat random for this pull request.  Can you explain what this is for?
The line is too long (checkstyle)
we do with `String.uniqueID`, `DOMEvent`, `Fx.CSS`, .. , but not really with `[...].hexToRgb`. So I would say we usually do this.
sloppy parens
отступы опять
Or move this to a function. Like function which initializes textbox, and you call it around, at the beginning and every other time.
Using template tags in Python code? Are you sure this works? :-) Read documentation on static files in Django and how to use this in Python code (not templates).
Spaces around binary operators.
So, spaces around `-` and commas in tuples, but not around `=` as this function arguments.
how does the regex perform vs the strict comparison?
Use the full path to the executable, e.g. `#{bin}/root`.
I took that part away and it worked fine.
symbolizer.fill = symbolizer.stroke = false;

should also work and would be safer.
Well, be solved in another way by you, or tell me I should change it to accept ...
I assume, I don't know how it works, that by naming this $exceptionHandler it overrides the built-in one?
I didn't even think about `'0'` having a boolean value of `false`, good catch.  I'm a huge fan of setting key once, and returning, as opposed to doing `+s` twice.
`.gitignore` has been updated in this pull request, and .Rapp.history` was removed. See commits below
You're right, this code was from pre-bundler days and is probably not needed now.
"as being a method"? Not clear...