labofsahil/github-event-dataset-2012 huggingface dataset:
I'm having trouble compiling with this changeset

[info] Compiling 9 Scala sources to /usr/local/users/bmccann/Play20/framework/src/play/target/scala-2.9.1/classes...
[error] /usr/local/users/bmccann/Play20/framework/src/play/src/main/scala/play/api/Application.scala:33: not found: value Threads
[error]   private val initialConfiguration = Threads.withContextClassLoader(classloader) {
[error]                                      ^
[error] /usr/local/users/bmccann/Play20/framework/src/play/src/main/scala/play/api/Application.scala:64: not found: value Threads
[error]   val global: GlobalSettings = Threads.withContextClassLoader(classloader) {
[error]                                ^
[error] /usr/local/users/bmccann/Play20/framework/src/play/src/main/scala/play/api/Application.scala:139: not found: value Threads
[error]   val plugins: Seq[Plugin] = Threads.withContextClassLoader(classloader) {
[error]                              ^
[error] /usr/local/users/bmccann/Play20/framework/src/play/src/main/scala/play/core/Invoker.scala:34: not found: value Threads
[error]           Threads.withContextClassLoader(app.classloader) {
[error]           ^
[warn] /usr/local/users/bmccann/Play20/framework/src/play/src/main/scala/play/core/Invoker.scala:149: non variable type-argument A in type pattern A => A is unchecked since it is eliminated by erasure
[warn]       case action: Function1[A, A] => a = action(a)
[warn]                    ^
[error] /usr/local/users/bmccann/Play20/framework/src/play/src/main/scala/play/core/server/NettyServer.scala:142: object Threads is not a member of package play.utils
[error]     play.utils.Threads.withContextClassLoader(this.getClass.getClassLoader) {
[error]                ^
[warn] one warning found
[error] 5 errors found
[error] {file:/usr/local/users/bmccann/Play20/framework/}Play/compile:compile: Compilation failed
[error] Total time: 12 s, completed Jan 9, 2012 3:24:12 PM
On Mon, Feb 20, 2012 at 2:11 AM, Keshav Kini
<reply@reply.github.com>
wrote:
> Hi William,
>
> You should base these commits on the branch `master` and not the branch `github-master`. The latter contains an extra file (README.rst) which you won't want in your eventual trac patch. To fix this now, do:
>
> {{{
> $ git checkout lfun
> $ git rebase upstream/github-master --onto upstream/master
> }}}
>
> (The `--onto` stuff might be a bit confusing. Normally you shouldn't need to do rebasing, though.)

So the above doesn't work.  However, if I use "git diff" as mhansen
suggested I get patches that don't
include the README.txt, so no worries.

>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/williamstein/sagelib/commit/f4104efd87cb421923f884f8ea5c571fa52d583b#commitcomment-985116



-- 
William Stein
Professor of Mathematics
University of Washington
http://wstein.org
Hey, thanks for your interest in the project. If you build something cool on this fork, I'd be happy to merge it into the main repo.
I know jquery is very useful.  Mainly an issue of personal preference here.  I like seeing the event assignments in the same place as the HTML where possible, just makes it more clear (for me at least) what's going on without having to go searching for code somewhere else that modifies the elements.
El crash sucede debido a los parámetros que le envías en el case EVENT_RENDING_THROW, especificamente en el me->getVictim().

Slds
Пустой (пока) беджик.
WTF HOW DOES THIS WORK>
can you also push this to the dev branch, please?
I'm not sure this is a good idea. Using swap is not recommended in Android...
I don't think we should be generating stuff inside a src module, right?
solang keiner contributed, wird auch nix kommen. leistung gegen leistung, so einfach
@Blaizer what's up with all the ```void*```?
It's a bad idea.  This problem only affects users of a couple ISPs in Belgium.  The problem began because the BAPF can get the Belgian courts to force Belgian companies to block DNS queries for such domains.  The response here in this patch is to have your all your users in the entire world rely on a Belgian company (dns.be) for resolving tpb domains.  That is totally backward, having everyone count on one of the few DNS providers least resilient to this censorship.  You're committing your entire user base to a game of DNS whack-a-mole for the sake of a very small minority who have other simple workarounds at their disposal.  

If you're going to address this problem at all, it should be by allowing configurability of the hostname used instead of hard-coding them.  If we do continue hard-coding them, the last domain name in the world we'd want to use would be one with a DNS SOA in Belgium.
> Exactly, it might have a value "undefined", that's why I added the other boolean definedMaxResults . . same logic on the rest of the patch, the cost of box > numbers is just too high.

sorry, got it now. I somehow thought there was no need for the undefined value anymore, but now I see the _definedMaxResults_ flag.

While I agree dealing with the two fields is not ideal, having to deal with "might be null" is even worse imho..

> fair enough. You are saying autoboxing is a big overhead? Would JIT not take care of this?
I'm no longer getting the exception, and your test files work, but I tried making a version of testCommunicate that was python-to-python and it's still giving me trouble.  It may be due to my limited knowledge of how otr works, though.  The following output appears:

WARNING:root:invalid fragmented message: ['', '2', '32', 'AAAAEAAAABA', '']

and the sent message isn't received
why QtTestingIcons.qrc ?
A qrc file can contain more than just icons.
Rename into QtTesting.qrc ?
sorry, not MaxPerPage.
I added $maxPageLinks
static DWORD WINAPI playlist_stop_thread(void *arg)
"Old timers" ;)

However, the check is incomplete as 

```
: --
```

or 

```sh
: whatever junk here
```

etc. works too which this change won't recognize.
Need to add Javadoc to this class...

Tracks non-nullable transient entities that would cause a particular entity insert to fail.
assert is always debug-only - you don't need to wrap it in a #ifdef _DEBUG
Marius, you should use the JUnit @Ignore annotation instead.

Note: I'm not sure it's a good idea to exclude the tests, I don't think that'll make us fix it sooner.
this commit revert this https://github.com/TrinityCore/TrinityCore/commit/cc88681dc5da60218e36ca00873cdf3033bcc5b5 ?
i am not gamer...thanks..
You are correct, @GUID+3 should have been 38041.

```DIFF
-(@GUID+3,38040,0,1,1,0,0,-4915.43,-979.532,501.448,2.31443,300,0,0,42,0,0,2,0,8), -- Kwee Q. Peddlefeet <Crown Chemical Co.>
+(@GUID+3,38041,0,1,1,0,0,-4915.43,-979.532,501.448,2.31443,300,0,0,42,0,0,2,0,8), -- Kwee Q. Peddlefeet <Crown Chemical Co.>
```

and:

```SQL
UPDATE `creature` SET `id`=38041 WHERE `guid`=40484;
```
@3kids The data on that wowwiki article has not been updated to Cataclysm yet
There is a small issue with vehicles flags (VEHICLE_FLAG_NO_JUMPING | VEHICLE_FLAG_NO_STRAFE) etc..like cannons.
Player get these flags too and can't jump, strafe after exit such vehicles.
this may be a good change (2000 -> 200), but I'm not sure it's related...
The concept neighbourhood service returns a neighbourhood which does not actually include the resource whose concept id is queried.  That is the main reason we have so many REST calls - one to get basic information (resource) using term service, followed up by another to get the resource neighbourhood whose partial properties we apply to the resource returned by the term service.  This makes me think what we really want is a third service which is a term service except using the FullTermParser to obtain all relationship information.
I don't want code like this:

````
<div style="page-break-after: always;">
	<span style="display: none;">&nbsp;</span>
</div>
````

I want ...

````
<div class="pagebreak"></div><!--pagebreak-->
````

The first div to have a optical separator in the editor. 
And the second tag (the comment) to set the pagebreak at this position.


---

The problem is:
If you toggle between the editor and the html source code, the optical separator must appear again. Just try it and you know what I mean. :-)
Having "verbose" and "silent" is bloat, compared to "True" and "true"?

Using different capitalization to distinguish between different things *only* belongs in deliberately obfuscated code.
Sorry for it being in different parts making it unclear ; but I pushed some updates during the developping so people could see, give feedback,...
Do you think Ground Pound should use MELEE_ATTACK (so have a chance to miss) or directly deal damage?
Hi Sean. Sorry I added to the confusion with the wording of my remark about `Any`. I was trying to point out exactly what you mentioned about `False`/`(||)` being only one of the possible choices of `Bool` monoid (together with Haskell requiring at most one instance per type) as a reason to use `newtype` wrappers like `Any` and `All` for their `Monoid` instances and have no instance for `Bool`. So I'd expect similar wrappers on `Exp Bool`.

In my last "BTW", I was checking my assumption that you'd added a `Monoid BoolE` instance, since I figured it must be there and I hadn't noticed it yet.

I think what you're trying to accomplish is `toColor mempty == clear`. Since for colors, `mempty == clear`, we might entertain the idea of wanting `toColor` to be a monoid morphism wherever it's defined, implying not only `toColor mempty == clear` but also the additional property that ``toColor (a `mappend` b) == toColor a `mappend` toColor b``. I don't think this `HasColor`/`Monoid` link had occurred to me, and I don't know what would motivate this particular TCM. I always want semantic functions to be TCMs, but I don't think of `toColor` that way, because we can distingish between values that `toColor` identifies. As a way into and through this question, we could look for other `HasColor` instances and see what they have to say. One is gray-scale.

If we really want a general way to talk about values mapped to `clear` by `toColor`, and the `Monoid` connection doesn't turn out to be a natural (unforced) fit, then we could add a `HasColor` method. Something like `preClear` with a class law that `toColor preClear == clear`. What leads you to want such a thing?
What about <head>?
Finalmente el problema era que el nombre causaba conflicto, tomando la longitud de 732px definida en .turistaPage .bodyText
I've extended the test suite.
# 再次成功

**结论:** 我还是使用Gui吧

## 当前Git的部分设置

* **操作系统**

    Windows 2003 SP2

* **Git\etc\gitconfig**

    ```
    [core]
        symlinks = false
        autocrlf = false
    [color]
        diff = auto
        status = auto
        branch = auto
        interactive = true
    [gui]
        encoding = utf-8
    [i18n]
        commitencoding = utf-8
        logoutputencoding = gbk
    [svn]
        pathnameencoding = gbk
    ```

* **Git\etc\inputrc**

    ```
    # disable/enable 8bit input
    set meta-flag on
    set input-meta on
    set output-meta on
    set convert-meta off
    ```

* **Git\etc\profile**

    ```
    export LESSCHARSET=utf-8
    ```

* **Git\etc\git-completion.bash**

    ```
    alias ls='ls --show-control-chars --color=auto'
    ```
i see. didn't know that.
then which lines should be edited to solve my problem here?

my absolute media paths were prefixed with PIPE_ROOT. 
from url('/static/media/images/xx.png') to url('/static/static/media/images/xx.png')
it did solve the segfault, thanks)  now when i compile and run it, it looks like this
http://s12.radikal.ru/i185/1201/04/022691a248b3.png
@hafriedlander @normann Agreed that we should stay within the selector "scope" for class-based selectors. Although in practice it makes little difference at the moment, as it would be strange to have multiple $('.cms-content') or $('.cms-container') elements in a single DOM tree. Hamish, what's your feeling about making the toplevel elements ID-based instead? (which would speed up selectors).
for cooper , yes, but gio, dunno, LOL
Could you check this didn't kill my other changes? This could in theory affect both file names and directory layout.

 -- John

On Feb 15, 2012, at 12:08 PM, Drew Conway <reply@reply.github.com> wrote:

> Rolling this back so that the file names for chapter 1 are consistent with the book.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/johnmyleswhite/ML_for_Hackers/commit/3a7a3d52b562b0738de05d23c01dcf888ce34e70#commitcomment-970208
Eeeuw! Trailing comma deleted in c445550cdc3182394e17bd385a1a649967e1d2d0.
QSD8x50 does not have any known errata(s).

Errata is an error produced to manufacturing defect or design defect, disabling should save you both (a lot) performance and the a few bytes in the kernel.
Did you test this?  From the auto tester:

Error: don't know how to make 'import\core\sys\posix\sys\un.di'
Ok, my mistake for letting this one go by. Let's dig around with this further and I'll reopen the issue that triggered it. #25 I believe.
So far I've seen `name` in the context of property constraints only. But we could also do the following:

* add `getPropertyDescriptor()` to offer a descriptor for all kinds of node instances
* always return a simple string representation via `getName()`
I just changed the file format so I'm adding this song back in now too.
Hi, is there a reason why you've not submitted your changes as a pull request?
Just remember the Version & Date for future fixes
No, these shouldn't definitely be methods of the extender class. It makes rebounding them unnecessary hard. I know it's not very pretty but they must live outside the class.
Не забудь поместить "use strict;" в начале. С ним браузер выполняет некоторые операции быстрее (например `this.`).
Changed several of the funtion parameters to accept arrays as well as strings.  This allowed the functions to be called dynamically and with less markup.
これって `context` ではなくって `describe` なんですか？
There isn't anything that actually makes this a requirement instead of nice-to-have, is there?  I'm not seeing `binding.pry` or similar calls.
Why did this one gain a require here?  Just ask as I don't think other services had this (they just had the setup commands).
Technically, they should all be using &$request.  We need to invest some time in correcting the others for consistency.
Unusual comment style.
:+1: to that too. Shorter is better, and I don't think we're likely to release YUI 4 anytime soon and cause a naming collision.
Stop being a dope and use `if` statements for these.
`positions_reversed_merged[position.ticket.pk]['amount'] += 1`?
Should be `MEMCACHED_OPERATION_NOT_SUPPORTED`
damn that intellij...
Oh, I interpreted the docs as "Override this method if you want to use the resizer defined in code if not defined in config."

Drop "Override" and just say "Uses the resizer of the given Routerconfig if this RouterConfig doesn't have one."
\p{XDigit}	A hexadecimal digit: [0-9a-fA-F]

- http://docs.oracle.com/javase/6/docs/api/java/util/regex/Pattern.html
Good point, I’ll cap the sleep time by akka.actor.creation-timeout.
Why use String.format here and not the {} substitution?
I don't remember where I read it, but I think Paul Phillips said that mapValues was horribly slow.
It's a reasonable thing to do if Vault.upload_archive has been given a file, because with a file it can find out ahead of time how big the file it, but unfortunately it isn't a reasonable thing if it's been given a file descriptor instead. (like stdin) In that case the current code calls compute_hashes_from_fileobj() without being able to do any validation on the file object. To allow Vault.upload_archive() to raise the error you'd have to give compute_hashes_from_fileobj() it's own "empty file" error message, because tree_hash() just doesn't make sense without something to hash. (well, it should have just done sha256('').digest(), but that's not how Amazon defined it)

And actually, even with a file of a known length, someone could still truncate the file between the check of it's length and when we upload it, so putting a similar check in the Writer class as opposed to upload_archive() still makes sense too.

IMO Amazon really should have allowed zero-length uploads...
might have been a dumb comment.  seemed like it wasn't necessarily user specific code.  I think I need to catch up a bit.
I don't like all the WagbotID business.  maybe just an as_bot (in Session class).  Session.as_bot do...
I'm not sure it needed to be moved down, but maybe it needs to be in the file named for the new class to lib/wagn/views.rb
I attempted to get rid of this, but there are clearly dependencies.  What I intended for this is that it would be 'automatic', generated if necessary when you assemble all your packs with the core and deploy.
I am not sure why this is not used here. That is a bit strange.
gravatar(email_hash=user.email_hash, size=avatar, id=user.id)

None is a the default so don't override it
@aron @tobes I'm sure there must be plenty of stuff I'm missing from this section of guidelines when developing templates.  Can you think of anything?

I'm happy to leave out anything genshi-specific if we're moving to jinja2 soon.
The values ... *are*
soooo much nicer!
It shouldn't be kill since I think it's only for cleanup purpose. Spnl really kills the task, not the feeder
mutable map?
why are you changing this?
What if i want to graph a subset of the jobflows? That's the job of the filter?
you don't seem to use this
This looks to me like several test cases in one. Can you split into one test case per thing you are testing?
This leaks the created map instance.
Agree! Merge!
These bit masks are either using two spaces or a tab after the `<<`, whereas below they use a single space. Please correct this.
Since this code is generated automatically, we should ensure it is 99.9% valid PHP code. Getting a fatal error from a random file from a cache would not be good for the user.
we use 1 in all our tests.. thats why I used it here too ;) But maybe we should use 10 in all of our tests.
@nikic The string length could theoretically be negative if it exceeds the length of an `int` (overflow). I would rather check if `hash_len` is less than `SIZE_MAX`, but that's not defined on all systems...
Done. Pushed updated version.
@homakove no need for new pull request, please do `git commit --amend` to amend to the last commit and `git push  --force` to overwrite your branch
remove extra lines  of whitespace please,  on 529 and 532
I normally wouldn't do this, but I didn't want to extract yet another helper method for such a short bit of code.
This is implicitly type-casting the attribute value to a boolean using similar rules to the database adapters. That seems inappropriate.
@rafaelfranca should I change to

```
Changed inclusion and exclusion validators to accept a symbol for `:in` option, i.e.:
```

?
Shouldn't we have some assertion that checks if passed symbol corresponds to enumeration value?

It doesn't look like this method will be too hot.
You probably don't need an interpolated string here.
"contains now" --> "now contains"
nit: `if (success)`
No good. You need to import matplotlib from the plotting module. That specific import_module is what fails for me in that bot run.  And checking numpy should not be necessary, as it will show up anyway if matplotlib is not working.
It could be instructive to know why so. Could you add a docstring explaining the edge cases that need special handling?
Then the Or(y, Not(z)) can be changed to Or(w, Not(z))...I'm just trying to show the 3 different things that might remain after simplification.
You need to somehow generalize what it means to be "identical".  Does frequencies allow you to define a key function?
circle seems not to be used here?
is `res` a global?
No, see the issue. This is an empty sum.
Better to descibe it like `CHttpRequest::sendFile() now always sends valid content-header `.
Why not? What if they later authorize; is that the point at which a session is created? Could we create a session here since the application is actually running and only send the sessions on successful authorization?
defaults can go in the common instance scope with the rest of the constans
Aaaahhhh magic numbers. I would love a more descriptive comment describing what exactly this line does
Style:

lower()=='true' ---> lower() == 'true'
No problem, I'll update them.
Oups, it is `DoctrineDBALServiceProvider`. Sorry.
This is good, as it tests the behaviour and not the data. Though I would have used the Router's match method instead of the Route's.
add:
require 'params'
- you define the bounds of the shape for the query, not the operator.

- the first sentence needs reworking: 

  - the operator specifies the constraints of a query (say this in a different way,) but it in and for itself doesn't return anything.
  - the operator doesn't "using spherical representation," it assumes the points exist in a spherical system. 

It's totally appropriate to cross reference here.
We expose "string" variables in C#, not NSString.
s/defaultSearchUrl/searchUrl/: this is a member of the `defaults` dict, so another 'default' is redundant.
Pick one of tags or bbcodes?
That prevents the file to be edited?
If those lines don't exceed 80 characters it should be ok to have the comments on the same line.
controller was advertised to be a string, how did this happen?
Personal preference.
Because the line above it now reads "Information on MODs can be found at:" instead of "These third party modifications ... can be found at:"
I'm pretty sure you can specify parameters to constructors in services.yml, what is this referring to exactly?
Looks like we just conflicted in the spec... I took your version and
pushed up the result.

   ...scott

inter prospera et adversa and dragons never quit



On Wed, Apr 11, 2012 at 12:01 AM, Randy Morgan
<reply@reply.github.com>
wrote:
>> @@ -35,6 +35,13 @@ def initialize(options={})
>>        end
>>      end
>>
>> +    # Return list of edge names applied to this border
>> +    def edges
>
> Hi Scott,
>
> Sorry mate, I was not clear enough in my previous post. I've already pulled in your changes, altered the border class / specs and pushed to master.
> Can you update your fork with the latest master code? Hopefully there wont be too many conflicts.
>
> Really sorry for the extra work on your part due to my poor communication skills!
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/randym/axlsx/pull/77/files#r669072
Confirmed this commit is bogus, we can ditch it.
Doh. Brainfart.
but I thought that they were floats, so not exactly 4, right ?
The approach is good
IMHO this is a very clunky function name.  Perhaps `readConfigSimple()` (as a counterpart to `readConfigYCB()`).

Also the description still says `Reads and parses a JSON file`.
Убери это в validationService
Wouldn't some of these, at least inventory, be final?
Util.saveBasicAuthHeader should come here first, we need authentication before we can do anything else.
Then maybe we should show the loading splash? The calls in user privileges could take a while and it would be nice to have an immediate loading screen.
How about ```TestFF_HEADER```? I'm concerned about the two classes having the same name except for capitalisation.
Vertical alignement required here.
This is the reason I want to get rid of ```map_setup```. As a function it is completely redundant other than for setting up a map given a cube, which I feel could be done better if we had an interface such as:

```
projection, extent = iplt.crs_and_extent(cube)
ax = plt.axes(projection=projection)
ax.set_extent(extent, projection)
```
Remove this line and ```cf_changes```. Once the content of ```cf_changes``` isn't skeletal, it can be put in a PR, but they don't need to be tightly bound.
Another thing you can do, if you're not depending on `inputs_val` being mutable, is use an empty tuple. That simplifies code a bit, I find.
"other projects"
move this at the top of the file.
I think [None, self.shape] should be the right thing if the first output is generic. Does that work?
it was for debug purpose and it's should be removed.
<pre>
default_deprecation_kind = DeprecationKind.objects.get(
    default=True
)
</pre>
True - it's not documented as a public API, it's just that quite a few people use it. I can fix get_field_type to return tuples in all backends for all types and very easily add a database error in if you run get_table_description on a nonexistent table under sqlite, if people think that's in the scope of this patch.
I've fixed this to check that the error is about the table not existing, using a slightly nasty string-comparison method. Suggested improvements to that welcome.
This new import isn't actually used that i can see.
This is also wrong, `LANGUAGE_COOKIE_NAME` is the name of the cookie, not the name used in the session.
Let me insist the name if very misleading, contrary to `$.getScript()` this "helper" overrides global options implicitely. Also, @rwldrn: http://bugs.jquery.com/ticket/12838
ah ok, didn't thought about the @link, which makes this of course an error

just thought about the british spelling
Modified to use construct_array.  I want to learn the difference of of this two interface. For simplicity and encapsulation, I think no doubt that construct_md_array is much better.
{rel_state} AS _state is forcing the confusing use of _state._state in the query. I am changing it to be _rel_state in my later pull request to Florian's kmeans branch.
Yup. Also, array_ops and utilities are only needed for unit testing.
Is it time to have some better way of setting up log levels in the settings? Personally I have log setting overrides in my settings.py but there should probably be a more config file based way of doing this. Either directly with logging's own config support or just simple {logger: level} type dict mappings.
On another note, this seems kind of out of place. It is the only time we talk about OS specific details, and it is something as simple as "here is how you start a daemon."
On 27 March 2012 23:45, Misty De Meo
<reply@reply.github.com>
wrote:
>>    depends_on 'spidermonkey'
>>    depends_on 'icu4c'
>> +  depends_on 'openssl'
>
> I know you were talking about it on IRC, but could you elaborate in the pull request on why there's an OpenSSL dep?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mxcl/homebrew/pull/11243/files#r612075

CouchDB needs Erlang which needs OpenSSL. So you're right I *could*
remove that now that I have a working "installs 64-bit OpenSSL" brew
done.

What's the best way to update the pull req? add another commit in, or
delete & redo it?
This is not needed. Setting the CMAKE_C_FLAGS this way causes trouble because it seems to prevent CMAKE from using our cflags.
Specify the path to the binary in the test, e.g.

```rb
system "echo 'foo' | #{bin}/smu"
```
PPS: Please rebase to master as well, as it can't be merged directly now.
I checked what the HTTP DELETE returns without catching the exception:
It's a 500 Internal Server Error with body:
``<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Exception</s:exception>
  <s:message>You do not have the permissions to delete this contact.</s:message>
  <s:sabredav-version>1.6.4</s:sabredav-version>
</d:error>``

Not the best response, as it should better respond with a 403 Forbidden.

However, with catching the exception I receive 204 No Content, pretending that everything is fine.
anyway - this is aesthetic not functional - just saying this makes me stop & go WAT! for a moment
Our generic WASP is "sphex", not "spehx". ;-)
Also, you need to inherit from the base ``Notes`` class (after requiring it in the module's ``define`` line): ``util.inherits(FlowNotes, Notes);``
Diese Methoden müssten dann aber rüberkopiert werden und wären doppelt vorhanden: https://github.com/redaxo/redaxo/blob/19f9ffa6baa64bb90b84f7d5de4a6c2d1f052f58/redaxo/src/core/lib/path.php#L32-98
```js
.on('end', function(){
        if(args[0] === 'install' && directory){
          grunt.helper('bower:copy', directory, cb);
        }else if(args[0] === 'uninstall' || args[0] === 'update' && directory){
          grunt.helper('bower:sync', directory);
        }else{
          cb();
        }
      });
```
That sounds a lot simpler, and there is already the pipe creation code in session_base. Will give it a go.
I'll be honest--I'm keep coming back to review this, and end up balking at this block of javadoc.  I think we have to find a clearer way to express what's going on here in order to make it useful to users.  Unfortunately, time is pretty tight for me, so it will be a while before I have time to make specific line-by-line suggestions.

I have two thoughts for moving forward:
- Copy the Javadoc into a Google doc for some collaborative editing as time allows--once we've iterated to a good point, we can copy back here.
- Ask on the junit@yahoogroups.com list for a collaborator that does have time to give this an edit with a critical eye.

Ideas?
again. dont use xor! also you check exlcudeany one line later. this can be simplified for the benefit of readability. i really have problems adopting whats going on theres. also: junit code lacks comments big time. this is one spot where you really cannot leave it out.
afaiconcerned the whole methods needs to be changed in something more easy to adopt. this is important because its the core of Categories.
No it shouldn't, the idea is that you can add handlers which execute before handlers which execute on the transition.
Yes and Yes. It's easier for me to incorporate that change in #1044 since those changes already break down the algorithm between searching and parsing for the end offset. Do you mind if I hold off on that suggestion for the sake of this pull?
I think data-minSize is probably a better solution because it eliminates the timing of calling an API method to set it. It's ok to wait until the sidebar refactoring.

Also, I'm writing an extension that uses the bottom-panel with the resizer and I ran into the problem where I had to call makeResizable is not automatically called because extensions are not yet loaded when htmlReady() is called. I think this is fixed if you use appReady() instead. Let me know if you want me to send you a copy of the extension.
Verifying that site-root relative URLs are resolved correctly is one of the key tests, so no we can't be flexible on this one. Your URL is a path to a local file outside of the site, which is not very common.

I haven't had time to play with it, but maybe we can map the site to the files. If not, I don't think that manually copying the files as a one time setup task is too much to ask.
I'm wondering if Params may be too generic. Maybe UrlParams ?
Are the ``template`` and ``hide`` classes still required now that this isn't baked into main-view.html?
Reminder: fix this typo
Could you add comments on these methods?
cute/elegant but hard to read.
OK, I made the changes for (1): all the stats do not use expansion, with `scale_dimension(scales$x, c(0, 0))`.

(2) is presently done in `train_position()`, which is a panel function, but it could be moved. (Because of this, the default expand values are calculated twice, but this is no longer necessary.)

Should it be moved out of `train_position`, and if so, where to?
protected methods are part of the API and deserve some documentation.
I didn't knew that either before. :) I changed ID's so now are consistent and also fixed what was wrong. I think that now everything is OK.
Can this be `/external/stamen/...`?
No, good point
Again, I'd like to make the case that readability is good here. This doesn't need to be a hot loop, right?
Just wondering but why do you actually have to put this here? Like why not just have `trackEvent.update` where it used to be and do `callBack = callBack || function() {}`
You should add an h264 version of this movie as well
`function tween( rM, t ) {`
`err` from the callback is ignored
I don't think we really need to worry about smoothing parameters  < 1.4E-45, so this shouldn't really be an issue, right?
+1 to y/n with no default option
I always like to `||` my variables with themselves just in case they're not defined the first time I call them.
you could get rid of the ``$data`` variable as you use it only once :)
Leave it as int.
Why did you change this logic?
Read that again, this code is broken as it maps things in the global resolver. A user can call `RouteTable.Routes.MapHubs("~/foo", myresolver);` This needs to happen inside of that call (which you removed from the other file)
esta muy bien! :+1:
I see... then why the resistance to cleaning up the legacy stuff now then, or can we start doing that too?

PS: Check IRC?
agreed - too much voodoo.
This could actually **cause** double execution errors. You prevent them by setting this to `false`, telling rails to ignore `/public/assets/` and go through the asset pipeline every time. I'm pretty sure this is off by default though, so I think we should just leave it alone.
ACK, we really should do this.
Indeed, I just used what was there. Sometimes I have not that wide view/knowlegde you have in the area of coding :).
Rebroadcasts already happen every (at most) 30 minutes, on average faster.
When using a `::` binding with only a single statement, that statement can go on the same line:

`text :: self.value = float(text)`

Prefer not using `self` unless explicitly required.
Hah :) It is my first public R code-contribution and I'm sure you can tell from the first version of this pull-request ;)

From having worked with many other projects, the "Sys"-like libraries are usually the only ones I've noticed with a knack to degrade nicely, now I assume no other R library is going to be that gentle :P
Is there a reason why we shouldn't end on a newline always anyway?
We might need to move functionality like this to the "Runtime" category.
Validating in both build() and the metricName method: I have no strong feelings. Other methods do the check for null in both places which is a bit of a precedent.
I've spent a bit of time on jclouds's Base64 impl. I tried adding URL safeness by implementing configurable alphabets and although it works sometimes other times it messes everything up. moreover jclouds base64 encoder insists on adding two equals signs to the end of the encoding.

personally since guava 14 will include what we need, I'd rather not spend more time chasing this. one thing we could do is change the jclouds base 64 impl to use commons-codec (copy paste) and keep the copyright.

wdyt?
please remove this generated javadoc and replace it with something useful like a link to the cloudstack doc on extended options.
This should be ```editorDoc.setOption('onChange', null)``` for codemirror 2+
This in particular looks like a lot of code duplication - can we do something clever with templates instead??

Similarly with the ProjectFEMSolution vs ProjectSolution classes - could their common functionality be in a base class or templated class?
Sir! Fixed, Sir!

I also took the liberty to fix the `int -> bool` issue you previously pointed.
Same as hacking_howto
And what shoud `saveScreenshot` do if `asyncCopy` fails? Bailing out with error? Or just fail silently. Or ...?
Please give some suggestion!

Just call `aCallback` (only if failing - of course)?
oops.  wrong window when I was going to IRC with "rbillings"  fixed...
yes, it was inadvertently omitted.  it is used in the handlers for several error cases
@Vader19695: I probably should have left this to you to do, but I wanted a chance to explain it. Basically, we need to add a URL so that this action is accessible. The call to `resources` gives us the standard REST verbs and actions, but `export` is not standard REST, so we must add it. We pass a block to `resources` so that we can add more routes under the `/prospies` URL. The call to `get "export"` automatically routes to `prospies#export` (that syntax means `ProspiesController`, `export` action), because Rails is smart like that. The call to `on: :collection` means that we're doing it on the collection of objects and, thus, the URL will be `/prospies/export`, rather than on a member (which would be `on: :member` with the URL `/prospies/:id/export`, where `:id` is some ID, such as 1). This collection versus member pattern is a part of REST. Basically it's an array versus a single item.
Silly node question: is there any reason not to use build.actions.forEach?
Because you renamed it to '$spec' :')
IntelliJ yells at me if I don't. This comparison is only used internally by tests. Once Retrofit supports specifying the type to use to deserialize server errors this class will disappear completely from the public API. As such, I'm going to leave it for now (but I did make the class final).
Guava's tests suggest that charset can be in upper case.
I don't like the method signature change. I would prefer to add a new method for this use case. It also makes things more explicit.
I did it because it's how FilesystemTest is written. I don't know much about PHP issues on Windows and I don't want to reinvent the wheel :)
My bad. I didn't see that coming. The fix is coming.
should be `Resource\ResourceInterface[]`
I got that, but I could do that also by having a class that implements both the property and propertycontainer interface. It's just that by having a separated interface getPropertyMetadata() would be optional - not a big deal though.
As @stof said, I don't think that would make sense.
please don't do this. It breaks all form type optimizations (and in the case where they are the more sensible: collections)
Your variant is 2x faster than mine, but malformed headers (with spaces) will not be equal to original. I don't know if that's good or not.
the parent collection is not used
Hi @Koc . This PR is interesting! You could add some PHP doc here, even if the method's name is pretty straight forward
so how are we supposed to have these as intial data i was going off post 129 in piazza
Remove the systemout.
Can we include this at the top of the fake class instead of the bottom? Helps me understand what the purpose is.
1) 版本号的定义没有什么规定，如果按照你说的也挺好的。
2) 目前没有到版本1.0就是没有到版本1.0，1.0版本正式发布了才是1.0，ubuntu没有正式发布之前也是beta，rc之类的，这样直接写会有奇异的，如果别人再放到网上传播就更容易混淆了。
3) 我觉得可行的两个解决方案 (1) 用比1.0小的数，如0.9，(2) 除了版本号再增加一个version type之类的，可以就设定为 develop 之类的，或者其他的也行，目标就是要体现出这还在开发，等到真正发布的时候要能体现出来区别。
I think this is not used?
is these becoming spaces infront which breaks the PSR ?
I'm not a huge fan of forcing users to add an `Outlet` suffix on their classes. This doesn't address the core concern that the reference provided is a subclass of `Ember.ContainerView`. I would ditch the naming restrictions and just add:

```javascript
Ember.assert(
  'must be a subclass of Ember.ContainerView',
  Ember.ContainerView.detect(property)
);
```
The formatter doesn't have the same meaning in other locales. You've specialized a bit too much.
ok im looking over it now.

On Mon, Jul 23, 2012 at 10:52 AM, cesine <
reply@reply.github.com
> wrote:

> > +            if(lines[l].match(/^\\/) ){
> > +              var pieces = lines[l].split(/ +/);
> > +              columnhead = pieces[0].replace('\\',"");
> > +              matrix[currentDatum][columnhead] =
> lines[l].replace(pieces[0],"");
> > +              header.push(columnhead);
> > +            }else{
> > +              //add it to the current column head in the current datum,
> its just another line.
> > +              if(lines[1].trim() != ""){
> > +                matrix[currentDatum][columnhead] += lines[l];
> > +              }
> > +            }
> > +          }
> > +        }
> > +      }
> > +      //only keep the unique headers
> > +      header = _.unique(header);
>
> ah! i think i found something i forgot to test, this might be the source
> of 428 column headings, they might repeat! that would be awesome if that
> was the case. I will check this code and commit any changes.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/iLanguage/iField/pull/424/files#r1215863
>
déplacé dans PrettyDateUtil
tmcw - perhaps we should covert the node-get tests to use request as a benchmark? Are there any large file downloads as part of the node-get tests?
Every line that concerns `tablist` copes with a `:not(.filter)` selector, so yes we do have a dependency.
Is being replaced by a new standard not being deprecated that's right: https://developer.mozilla.org/en-US/docs/CSS/Flexbox#box-_implementation
nit: please be consistent with quotes — as you’re mainly using double quotes everywhere else, `"MozTT"` would look nicer. ;-)
It looks like it was UTF-8 for me... maybe a GitHub bug? I can't commit it like it is now, so I'll add a space somewhere and re-commit this file.
In reviewing Dale's video player, I've noticed that he pauses the video while seeking and then resumes playing on mouseup. I've noticed that you have a comment in here about too much seeking causing problems.  Maybe pausing here would help.

In bug 823619, the way mouse events are delivered may change substantially.  I've written a shim for apps like yours that need to get mousemove events like yours does.  It doesn't work for the Music app.  And now that I see this code, I know why: my shim generates synthetic mouse events from touch events, but the synthetic events don't have the (non-standard) layerX property.  You should use clientX or pageX I think (but I never remember which is right).

Also, I don't know whether the shim will work with setCapture() or not.

It is a separate bug, but if the mouse event change in 823619 goes ahead, this code will have to change
you could iniline this method in the `findByNumber` call and name it `contactCallback` for example.
> remove the Top Sites title if there are no top sites?

That's my inclination, but I'll connect w/ Larissa on it, since she's given Browser more thought than I.
nit: it is in ascending order above but this is out of order here. Doesn't actually matter but stylistically bothers me.
The `ref` param is optional, should it be excluded from the method signature and simply documented as something for the `options` hash?
why is there still a TODO?
Would it be correct to constuct this script dir path relatively to DeploymentContext.OutputPath (e.g. `C:\projects\kudu\apps\test1\live\wwwroot`) as 

```
Path.Combine(context.OutputPath, "..\\..\\..\\Kudu.Services.Web\\bin\\scripts")
```

Or did you have something else in mind?
As I said, I'll leave it to a commiter to decide.

On Tuesday, November 6, 2012, Ayrton De Craene wrote:

> In lib/assets/javascripts/turbolinks.js.coffee:
>
> > @@ -183,11 +183,14 @@ noTurbolink = (link) ->
> >      link = link.parentNode
> >    ignore
> >
> > +targetLink = (link) ->
> > +  link.target.length isnt 0
>
> @stevenbristol <https://github.com/stevenbristol> I mistakenly typed
> inline before, but corrected this shortly after. I agree that it's
> generally not used, but this might be useful to cover the edge cases.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rails/turbolinks/pull/107/files#r2046815>.
>
>


-- 


Cheers,
Steven Bristol
steve@lesseverything.com
--------------------------------------------------
http://lesseverything.com
http://lessaccounting.com
https://github.com/greggroth/rspec-core/commit/b240daaf83dbb9d8fdcc5993bc1c2e5b0df1d75d
then we should rediscuss the complete cli probably -- `visor root scale` doesn't really make a lot of sense imo
`IsRecordPersistentlySavedObservable`?
Ah, ok, seems more complicated than I thought. I didn't realize there were two different ways to store history. I wouldn't necessarily hold up the pull for this, but it might merit a TODO or something.
Can we also get the manifest here:

def manifest : Manifest[T]
Actually... Don't pull yet.  I forgot to handle the joinWithTiny case as well.  That needs the same treatment.
Same as before - return the reason why the config was invalid.
Some guy I know used a tab instead of spaces! I'm looking at you @shatterednirvana
Use tirenary condition (``?:``)
Yes, I think using the additional queues for silent actions would make  
sense, since that would add chaining functionality to them. Soft  
doesn't make much sense on parallel queues, since every call produces  
a new queue. I'll look into the proposed changes when I get home,  
right now I'm at work.
I'll also try to set up a clean branch for the pull request, this one  
is kinda messy, I first tried to rename master to minesweeper, but I  
ended up creating a new branch, leaving master unchanged, so I reset  
it with a commit.
Maybe it didn't work because I tried it directly in eclipse and not on  
the command line. I don't know if it's even possible, I'm not really  
familiar with branching in git.
Pour une homogenéité au sein du projet : le nom du controlleur donné avec un symbole et non une chaîne de caractères, et lors d'un id, indiquer l'objet et non à l'id (`:id => @idea.box` par exemple).
typo -> an expected error
Ah, I forgot I had subclassed -- which probably isn't a good idea.
Urgh.  Agreed.  Pushed new commit with the style applied.
Without the second '%s', the svn command will use the local svn-repository, if composer is called from inside one and not the one, which is specified in $this->baseUrl
Well we do it in methods because phpdoc was/is dumb in that regard. For the property, you clearly see that the description applies to this variable, so I don't see the need for this duplication.
returning 1 should be handled by the console
This looks good to me – I'd probably use `PHP_EOL` instead of `\n` – but besides it looks all OK? :)
What's a shit with indentations?
Why /dev/null ?
Fixed that :)
If user don't want to pass some parameter, then GitLab should use default parameters.
Github won't let me comment on line 99 (`if(config.page.pageId === "") {`) but I think we have an `isNetworkFront()` method somewhere for this which reads a bit better, to my eyes.
This is an oooooold thing that I just decided to clean up while in there
Good answer :wink:
Here I swapped the conditions because of the semantic switch in the default config file.
got it 8dfbebe5.
I would also mentioned than local modules are required as `./foo/bar` or `../foo/bar`.
Extra mocks, woot!
I thought exports.main was the startup method.
In this case we should use `np.inf` instead of `None`[
Also, for the URL, I would recommend using your "additional documentation" link (http://fubar.ath.cx/weblog/Internet/breadcrumbs-fuer-google-und-co.html)
Yes it's needed. We don't want to delete every object that has a _yz_rk, only the siblings with the given key. I'll change the function sig to be clearer.

https://github.com/rzezeski/yokozuna/pull/4/files#L6R124
This needs some styling
I think it's cleaner to do it this way; it discourages using generic elements when more granular behavior is desired.
What exactly do you think isset() does?
CS: need a space between "if" and opening paren.
Yes -- means the filename was invalid for the operation.
Makes it easier to see, go and test out, etc.
I think this check should happen on loginStatus.loginExpiry and before the multiplication (higher in this function).
@samiluukkonen @jonikanerva Herrat. Tässä mentiin vielä enemmän mönkään. Tämä kysely palautti kaikki tietylle laskulle tulevat tilausnumerot. Muutos pitää tehdä "foreach ($yhdista as $otsikot) {" loopin sisälle.
Are there restrictions for managing comments or is this controlled by CanCan?
add a metadata.xml file. You find it in REPO_ROOT/skel.metadata.xml
Maybe we ought to allow users to use something besides Exception, while retaining the exception trace? For example, if I wanted to raise and exception in some module, say, WeirdModuleException because I just caught a BizarreException, then I ought to be able to do so? Which is not going to happen here, since I then need to raise an Exception, not a WeirdModuleException.
'separately' :-p
log.warning?
cplex -> CPLEX
All the comparisons to undefined seem non-idiomatic to me.
Here too, just JBoss AS 7
Can't this be `#include "http_parser.h"`?
eg:

    <dt>Location</dt>
    <dd>
      {{ city }}, {{ region }}<br>
      {{ country }}
    </dd>

Works for me.