labofsahil/github-event-dataset-2012 huggingface dataset:
It has gone in the next commit.
Why add wp-config.php to repository? 
I don't use the same database settings on my production, staging and development environments, so I don't want my config in my repository.
I'm guessing you meant to remove this?
Ok, li=logged in. If li==false the coords are scrambled. li is independant of the member status, too. Right ?!
+ 4 spaces in stead of tabs
That's what I wanted to do first but then I saw bemacs commit and he did it like that....
@rafBM oui c sur que déjà en partant jsuis habitué de terminer toutes mes lignes avec des ; (quand je fais du Ruby j'en met pas par contre!)

Pendant qu'on y est, tu mets des espaces après tes if, while, else, etc? Jtrouve que ça c quasiment + du noise que les ;
@DAddYE 

Why was this reverted? 

The current HTML 5 specification allows both forms of tags and is backwards compatible with existing XHTML. The only difference here is that those using old XHTML doctypes will have "invalid" HTML. Despite of this every web browser should accurately the page.

Additionally everything outside of ERB will automatically close your tags based on your provided doctype.
Sorry for the late reply, but yeah it's no problem. None of us care about a beautiful revision history, just making cool things :). 

-- 
Jake McGinty
ACM@UIUC Chair


On Friday, February 17, 2012 at 8:09 PM, Joe Betz wrote:

> I apologize for my previous three commits, the first was accidental and the last two were attempts to undo what it changed.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/acm-uiuc/twitter-music-pd/commit/5f67e043c46d4f0ddcf9c14a965f4617b6eb3b59#commitcomment-980522
> 
>
Yeah I usually use that, but that day it was ignoring my forced commit.
dividerはInnerClassクラス化しちゃってもいいかも？
<pre>
private static class Divider extends InlineHTML {
 protected Divider() {
  super("/"):
  setStyleName("divider");
 }
}
</pre>
Thanks - I'm just going to change it and commit. Could you have a look if the new commit makes sense?
declare j in the loop directly:
for (int j = 0; ...)
esto que es un merge del sd2?
happy new year Mambasoft!!! :D

have you made any progress on kernel?

and may I have the permission to compile from your source a kernel to use in xubuntu thread on slatedroid?

Kind regards
you can drop the condition here entirely, change the line to:

    else

Reasons: it's more efficient (barely :P), and having more logic than you need can lead to hard-to-track-down bugs e.g. if you had a typo.
sneeky
I hadn't intended for the comment link to be more prominent I just wasn't sure where else to put it.

I've done a version of the patch with the link on the top navigation line.  I am worried that this line is starting to get to long.  Adding "my comments" will increase the number of screen-size/language combinations that the line will wrap for.

I also am not sure "comments" should go at the end of the line or after "diary", or after "traces" I am not sure what the ordering logic is that I should be trying to be consistent with. I have put it at the end.
Suspicious: are you reading only one byte?
Scope on this method had to be changed to protected in order for Eclipse not complain.
Files in org.mozilla.android aren't copied to Fennec. What issue are you talking about, Marina?
Start with the creation of the value1,value2,...valuen part of the INSERT statement
Couple of tests had problems that presented themselves only on the jenkins servers, caught and fixed them in 3f52bf1
Well the default event priority is normal so I don't know why I did that
Ой, сейчас поправлю, спасибо.
``*`` is wrong for this one too. Basically, it should quite never be used as you should always set at least a upper bound (otherwise, it implies you know all future releases of the TwigBundle)
subline has not actually been included in the spec yet I believe - stick to hgroup for the time being.
Yeah I did. Chalk it up to being way to stressed out, and not checking a build prior to committing...
I see, no wonder I found it strange.....so now what?
msm8660 will no longer build with this commit. qsd8k and 7x30 build just fine.
hardware/qcom/display/libhwcomposer/qcom/hwcomposer.cpp:1381: error: 'HWC_DEBUG' was not declared in this scope
hardware/qcom/display/libhwcomposer/qcom/hwcomposer.cpp:1385: error: 'HWC_DEBUG' was not declared in this scope
make: *** [out/target/product/shooter/obj/SHARED_LIBRARIES/hwcomposer.msm8660_intermediates/hwcomposer.o] Error 1

any idea what i am missing?
Any particular reason why the word "icon" is capitalized here? Also the alternate text for the image says "Application icon" while this text says "App icon". The two should be consistent, one way or the other.
I think "datalist" might be a better name than "droplist"
The manager must be properly shut down after each test. Otherwise, EhCache is not able to create a new one for the incoming test by the same name.
- final on input parameter
- remove blank line
Should comment_id param have a default value either here or in function declaration?  0 or null instead of just undefined?
The prevent a compiler warning on an incomplete match.
We probably don't want to resort to a sealed trait based solution in order to have to wrap the "hot" case `ActorPath`.
if sender == self => endless loop
Well, this spec does nothing but gossip, and the intention is to test real healthy cluster. Testing with puppet would tests nothing at all, so I don't think that is necessary.
Immutable set of constants should be lifted into companion object
Very good suggestion!
ok, changed to foreachChild
Wow, this does a bit more than just creates a new Cell, it creates and Activates a new cell
Yes, there is truth in that...
This implementation seems like there should already exist such a utility function amongst the dependencies, try to find one and use that. (DRY)
You can use just `cluster.status`, it is the same thing as `cluster.self.status`. 
Same throughout the file.
what's this all about?  comment?
The code part of the *self thing, these are sprinkled around.
Arr should be prefixed with a backslash to get it from global
This does go through the auth functions it is a helper that returns a boolean rather than the {succss: ..., msg: ...}
As noted in another PR, this limits which platforms we support.
have you tested these?  don't see why this is in this branch
Not really necessary as you already initialized the whole buffer (valstr) to 0 i.e. '\0'.
Notice the typo; this wasn't doing anything at all.
I can't recall why I had that return here... is there a reason why you wanted to remove it?
Add a comment ala;
# Only start a new if we're below quota. This is how we scale down the number of workers.
no reason for this commented code to remain here?
IMO `simple` does not convey any meaning. Is there a `ComplexFilter`? I know that `Twig_Filter` is already taken. So I don't know a better name.
Maybe `CallableFilter` (which would have the technical association of PHP's callables).
So I have two hesitations with using `EXTSafeCategory`:

1. Introducing a dependency into TwUI. Not the end of the world but I'd like to avoid it.
1. My understanding of `EXTSafeCategory` is that if a method of the same name already exists, it just logs a message. So if a category method behaves differently from the framework method, we'd get behavior at runtime that we didn't expect.
How / where? I don't see any changes, Andreas.
i just tried, but then we can't use the bounds checking, since the ref float can't be cast to an array. and since this is in particular about arrays i think its ok to leave it as is. the process methods are more performance critic, which makes it more likely that one wants to use pointers/streams/ref floats.
Možná bych to dával jako suffixy ty <code>self::NAMESPACE_EXPIRATION</code>, místo na začátek.
again, i would like to keep this to whatever afni folks are most used to.
@rgommers Okay, I'll add a comment to that effect.
what this code is for? emalloc never returns NULL and sizeof(s) is a constant and you used s for sprintf anyway earlier.
I think both are needed, but neither is foolproof as node can do

    self.emit('timeout');
    self.destroy(new Error('timeout'));

In addition to setting the flag, we ought to retry the request if it is idempotent (https://github.com/ql-io/ql.io/issues/485)
пожалуйста, ага
здесь и ниже больше 120 символов и не хватает скобочек
в этом методе скобочек не хватает
if the actual_value is None, then uses the userInput, the actual_value only exists if the text it's matched in the lookup(complete method), but in cmd_togroup, for example, if the userInput isnt an existent group it create the group, with the userInput value
I prefer the old way in this case, but just personal preference. :)
The others mainly set `@options`, but that's fine no need to change. Perhaps just fix the indent to avoid the extra spaces. Thanks!
@edtsech Just a note on single-line method definitions. You don't have to use semicolons when defining them.

`def parent() nil end` and `def name() user.full_name end` are all valid method definitions.
got a failure removing it:

```
1) Failure:
test_0004_nested array with strings that should be hashes(NestedParametersTest) [/Users/guille/code/rails/actionpack/test/controller/parameters/nested_parameters_test.rb:68]:
Expected nil (NilClass) to respond to #empty?.
```
I think I tried them left_aligned, and thought it didn't read well, so kinda' made centered columns instead. I grant you that's pretty non-standard though. I'll fix those if you like.
Minor spelling and space problem here.
`context.owner.isPackage == false` means that we're currently in the package object, rather than in its package?

Also, `isPackageObjectSym` is a bit misleading, since its outcome not only depends on the `sym`, but also on the current `context.
can you be more explicit here, please?
*adds
This sentence doesn't parse anymore.
yeah, I wrote a comment about that in this code review somewhere, can't find it right now. My argument was that it's better to keep them in one place in the header (and hope that good IDE's will give you the contextual help anyway). Was awaiting your take on that before deleting the ones in queuefile.c
In the main repo, we first install sympy and then test it, so far only regular tests. It should be trivial to also do doctests, I'll provide a pull request later, once the Python 3.2 issues are all fixed, so that we finally get a green light.

The final thing that we need to test are documentation tests, we should do that.
Doesn't work. But here really doesn't make sense. I put it at the top of the function.
You can also un-XFAIL the commits that were XFAILed in 70e22ba57cb7ce61bceebb023ad5bcb3b4b9e7f4.
Nope, when I remove the comparison operators, the tests still pass.  Do you think I should just remove custom comparison?
Much of the formalism to do this is implemented at https://github.com/sympy/sympy/pull/1258.  I suppose it could/should be factored out. I tried using `ratsimpmodprime` directly, but it just hung.
I think that the "make html" failure is caused by this line.  Do we have some way to specify math in sympy? If not, just write it as:

T = 1/2 * m * v^2

That should be clear. Also, while you are at it ---- put one space before "P" in "of a particle,P, is".
okay.. thanks..
I'd rather hard code this option inside the function, since users will rarely need to customize it (in fact they are unable to do so)
Check the docs - http://www.yiiframework.com/doc/api/1.1/CJuiButton, some lines had TABs some spaces... so I unified them to be consistent :D
I'm not sure why it's displaying like that. I run netbeans and it's displaying proper (4 space wide) tab characters there. ??
Can use `switch` here.
@author, good idea. But there are mega. :) Or do we remove them as we go. 

I agree with checkstyle, but it slightly nice if its not overzealous. I could modify it to be better, it uses some sort of regex, which we could ignore the things we don't like. If we had the checkstyle correct, we wouldn't have to nag, so the my question is, should we tune it or get rid of it?
format hickup
You're right, of course.
The correct code would be:

```
if callable():
elif isinstance(basestring):
else:
   raise TypeError
```

This isn't important enough to hold up this changeset though...
"400番台" is correct.
Is `NSScrollView` 100% guaranteed to be fine without resetting the document view, or should I still keep a reference to it and reset it after swapping the content view just to be safe?
Delete lines 116, 117, 118 (all you need is ````credit = v[:credit] || ''````), right?
fix indentation please (you're using spaces not tabs right?)
Almost all of this newly added stuff has been done with a view to later refactoring it all into proper templates, and so on, since I was having some difficulty trying to mirror the type of structure found in settings.js. In this particular case, it built up around modifying `<div id="inventory-uploader">` which had/has the name of the domain on `data-domain`. It can definitely be improved to be more sensibly structured.
The indentation here is b0rked, please fix it.
not a function.
Same comment about whitespace control here.
var? or is this supposed to be a global? Looks like there may be a bunch of accidental globals in this file.
Please put comments on their own lines preceding the code.
The goal with this replacement was to reduce the filename from i.e. `ucp_avatar_options_phpbb_avatar_driver_local.html` to `ucp_avatar_options_local.html`
I agree. And I already warned him about that somewhere else.
title should be changed here too? its not board index but home...
I know there would be issues with long lengths, depending on the style design chosen, but I think it is reasonable to leave the decision of proper length to the board admin.
Do you know what the respective line would have to look like on FreeBSD?
Could add .css and .htaccess files to the ASCII list here
Oops, forgot I was reading server code now, this is OK. Sorry.
`fetch` checks to see if the requested key is present and returns it's value. This will allow `nil` to sneak in.

`options[:sudo] || true` does the same. I'm just being anal in wanting a boolean instead of nil or true I guess
Ruby hashes have something built-in to help here:

``` ruby
atts.fetch('id')
```

This will raise an error if there is no `id` entry in the hash.

You can also pass it a second arg to use as a default:

``` ruby
atts.fetch('failure', {})
```
what what, garry replaced his silly C-style comments by standard lua comments? unbelievable!
about the minimal diffs, i dont think it's necessary. i wasnt aware you redid the whole thing from garrylamp up
These two blocks look the same. Am I missing something?
Fixed as per previous comment.
I think that this was written like this beacuse this will only import TeleportCause and not the whole package PlayerTeleportEvent.
Hardcoded messages
do you see any proper fix then ?
dislike this.. might want to put args on same line instead (see same problem above at ln 420)
Can be store+model as per MVC architecture?
Repeating prev comment: Yes, src shouldn't be in the path for this to work correctly on our server. (as ROOT of our server corresponds to src)
Likewise...
这些选项，都需要写在注释里。
Fill this TODO
I mean, do we ever test with a shape bigger than maxThreadsDim0?
Does it have to stay when an Asset is deleted?
You can get this from the configured `yetibot.util/bot-id` instead of hard-coding it.
why is it a string ? You are using it as a boolean later
oh, maybe not... I want to pull in your new samples too.  I'll just merge and then fix.
In the event that a warning contains a date, `explode()` wouldn't parse the date correctly (eg for `110 test "Response is stale" "Mon, 03 Dec 2012 09:15:53 GMT", 111 test "Revalidation failed"` the first comma isn't a delimiter).

That said, after rereading the spec I'm not sure that date is ever actually of any use, so it might be better to actually ignore it if given (and if the date's different to the response's date, strip the warning completely).
This array is never initialized.
A C-style cast from `void*` to function pointer should be OK—POSIX requires it so that `dlsym` can work, and MSVC supports it as an extension.
I understand, except this code will be called all over the place: the Deferred creation path IS critical (think $.when and .then and how they'll be used all over the place in a real-life app). People expect Deferred creation to be somehow immediate and we both know it clearly isn't.

The real problem is that we cannot clearly perf this but better safe than sorry imo.
Yeah, we probably should use direct scripts a-la `echo.php`. Would simplify the folder structure anyway. I wanted to use a service-oriented approach to make it more readable, but it's actually making it woth.
After my recent patches to the finished() method, and before I merge this patch, can you make sure this code branch is actually being used when the iterator is empty?
If we support stats in GPDB 4.0, this will fail.
patches goes above install.
ah, I guess because of freetype?
These two lines can just be `mkdir 'build' do`
I'm assuming we'll fix this in a separate feature branch?
Same comment as for downvote.
You can also take a look at managers/auth/user/cud.py to see a general way how we are handling it on server side. This looks good as well, but just a suggestion to keep consistency.
will need to add some docs here for sure
I think it would be safer to also check the response status code before saving the css text.
You are always creating a new instance of Jed initialized with an empty set of locale data each time a locale is not found for a certain (id, version) component pair. You should create an instance in advance and reuse it ;)
Go all the way to final?
I considered it - and it's maybe more elegant, but I didn't want to re-define the meaning of UNRESOLVED to return no dependencies, when it isn't really that the key has no dependencies, it's that they key hasn't been resolved, and I wasn't sure if it was enough of an error condition that a null-object or default-object pattern wasn't misleading in the code.

That said, I'm not opposed - we can do that in another PR and remove the if().
perhaps we should change this to:

```cpp
template<class Value>
void endian_buffer::write(Value v)
{
    uint8_t* write_position = m_buffer+m_position;
    m_position += sizeof(v);
    assert(m_position <= m_size);
    big_endian::put<Value>(v, write_position);    
}

The we have less code :)
We can use the kirkwood_defconfig by now, as we have 2.6.35 set as kernel headers. 2.6.35 doesn't know bcmrpi_defconfig, and it isn't very relevant for the headers. Mainly, any "arm" will install the same headers.

About the kernel API used, it should be defined by glibc based on kernelMajor, but I'm not sure if it's used for native builds now.
Again, how would adding an extra deletion enable this case? And what needs to be done to the test cases to show the issue?
Naming suggestion: how about "also", "alsoHasMessage", "alsoHasCause"?

When I see "and", I think it's going to return a new Matcher combining the two inputs.  "also" feels more like it's mutating the target.  Thoughts?
Also Boolean is used here, same as @simplyianm's comment :P
imports go first: http://www.python.org/dev/peps/pep-0008/#imports
You should avoid changing the value (and possibly the type) of parameters, so I think a new var should be used here:
```
    var modeName = (typeof mode === "string") ? mode : mode.name;
    return hintProviders[modeName] || [];
```
It looks like you copied this from one of my test cases that got changed, but the filename in comment should match actual filename
I'm a little concerned about having this be the `name` field in package.json. It's a little funny to worry about it since we aren't really using package.json as an NPM package file in any sense of the word, but if we do somehow do that somewhere down the road, we'd want to be compatible, and it looks like the "name" field there is intended to be a fairly vanilla name, with no special characters (it gets used in URLs, etc.). I would guess space characters are okay, but would be a little hesitant to include things like a TM. See: https://npmjs.org/doc/json.html

Could we consider using the root name for the general UI name, and make a separate config parameter for the About box?
Also think this should be shopify side
It could be image or audio, right?
also this class
I prefer defining `compact <- function(x) Filter(Negate(is.null), x)`
Similarly, change this to `$(".popup-box")` in the first copy.
About @author I was not aware. I will do that and respect the best pratices.
deselectAll does not have a popup ?
J'ai peut être loupé un truc, pourquoi legend-monomap n'est plus une dépendance ?
```js
if (array...
  ^
```

:trollface:
Please do not override blindly things from main repository.
I will use you also to fix some thing. Values should be escaped. Use `escapejs` filter!
This looks ugly. And is wrong too; change it to Username is undefined
Spacing after `delta`.
maybe add `units: "seconds"` for start/end
The alternative here would be to make three new variables for all of these constants and it would be really awkward. Since this is only compiled once, it's not so bad if it's just in this one place, right?
Not sure either. The diff also tells me that something changes, but I have no clue what.
It will. See util.js line 40~ish.
If this is undesired behaviour and we really want it to just be written to console, we should check for the existence of the console rather than expect it to be there.
test.dn.qbox.me
set_watermark  是  EU 模块下的。Qiniu::RS 是一个全局的 Factory， Qiniu::RS.set_watermark 类似 AWS::S3.set_watermark
more overly complex logging, don't guard, use {}
# shared modules
Но тогда при чтении (пользовательском) на широких мониторах эти строки будут обрубаться, а не занимать ширину, предусмотренную вёрсткой. Посмотрел мануалы в apw, bem-tools, csso — везде смысловое деление текста.
Aligne les =.
Результат должен быть на английском, как в примерах. Это тест для зарубежных заказчиков
Oh, you didn’t have to make a new tag, just change the name of the tag in the specs is what I meant :)
why is this check required?
Please remove the extra spaces around ``!``
I'm assuming this was caught in testing?
Missing a docstring for `check` argument.
This should be an h2.  Only one h1 per page
Perhaps you should have broken up the previous soliloquy into these paragraphs?
I see you deleted this also... I think it's important that this be somewhere (although it's fine if it's a note or further down in the using section), because otherwise users will see this warning and have no idea what it's talking about.
It might be good to make this into a proper table ultimately
Is this a requirement for IPAC table files?  From http://irsa.ipac.caltech.edu/applications/DDGEN/Doc/ipac_tbl.html it seems that any extension is considered valid.  The `.tbl` extension could easily be used for other formats.  Will these be issues if the `is_ipac` identifier is registered?
I'd suggest using the return value of GetProxy here, instead of querying proxy.second later on. It's a little bit more readable.
but that would complicate things with the variables, as they would be out of scope for the tests then where they are re-used ($this->folderX then etc?)
I just add a note about that:
https://github.com/sbrunner/OpenLayers-URLCompressed/commit/cd8350022f37782d57c5c8b9b403b8d13590c893

Otherwise it's all from me.
``false`` should be written lowercased (same for ``true`` and ``null`` but I'm not sure they appear in the PR). The PHP-CS-Fixer does not handle this currently so it has to be fixed by hand
We do have to pick a language to do a demo in. If people care someone can
port it to Node or whatever other language.

On Sep 23, 2012, at 5:14 PM, Trek Glowacki <notifications@github.com> wrote:

In source/guides/router_primer.md:

> +<!-- {{{2 -->
> +
> +If you are in a situation where you have access to a computer, this guide also
> +has references to a [GitHub](http://github.com) project,
> +[Ember-Router-Application-Guide-Code][ERGC], whose commits match each of these
> +incremental steps.  As such, you can clone the repository, check out the commit
> +under discussion, adjust the code, try things out, and then move to the next
> +step.  Simply clone the project, follow its `README.md` you will have, in the
> +`workspace` subdirectory, the code that I demonstrate in the text listings.
> +
> +In each of the text listings I will include GitHub URLs that show the diffs in
> +the code so that each step is easily digested.  GitHub links are noted by links
> +with the text content:  _Diff View_.
> +
> +The code is housed in a minimal application framework built on Ruby and Sinatra
> +called [Halbert](https://github.com/sgharms/halbert).  If the terms "git,"

We've just lost every non-Rubyist. I hear complaints about this all the
time.

—
Reply to this email directly or view it on
GitHub<https://github.com/emberjs/website/pull/108/files#r1669679>.
This should be moved to a model method named something like `discussion.set_title!(title)`.
This can be deleted as it is no longer being used.
Please remove all of the commented out code. Legacy versions are always available in the repo.
@renner96 Because modules can perform more than one times an intervention into the system.
An enum of (0,1) sounds a lot like a bool. Let's use a CBool  here, in case we want to add another level in the future (C for casting - tries to convert things to boolean).
The JsonParser should come from Utils (i.e. Utils.getJson()) so Utils will need to be injected into this class.
distinct locations from available nodes
Oops sorry, word dyslexia.  I meant

return networkid.equals(checkNotNull(input).getAssociatedNetw...
zeroing its length probably has the advantage that remaining code is cleaner, i.e no need for a method ensureCacheExists() or such.
>Is this the unused return value warning you were talking about?

Yes it was.

>Because there's another p_chdir a couple lines before that hasn't been wrapped.

Dammit. Sorry for this.  Fixed with de9828d66f3b3108354655e08b2f269625fd28d5
what about maps?
Looks like these will be hard to factor out.  Let's use GECKO_OBJDIR then for the pseudo-constants.
We'll want to hide this within another script.  I think we want something like
 - run-profiler.sh: restart b2g with profiling enabled
 - get-profile.sh: trigger dumping the sample buffers on device, pull them off, then symbolicate
This could be either .span(5), or it could be .span(4); float: right; to leave an empty column between.
That wasn't as painful as I thought it might be.
`quote()` already does that.
Also shouldnt this validation be done server side? There's plenty of clients (webhooks, webops)
no Russian variables please :-)
What about if there are multiple `__future__` import lines separated by spaces?
Could you use REPLACE INTO instead? The SQLite 3 driver should have ->replace() as they have the `INSERT OR REPLACE INTO` syntax.
Do you need this check? If seems like the signin button wouldn't be there for logged in users.
yes that's right, but that's copy-paste from the original source.
Why would it be a wrong name if there is no error ?
Offset handling is fixed. I don't want to introduce an optional $name, as this is somewhat confusing from an API point of view.
Yeah, this has been fixed on my private repository. I though travis would test it before starting the pull request, but no :)

So I connected travis to my private repository, and fixed it aswell, you can see that here: https://github.com/sandvige/symfony/commit/6fc1e5ede18acfaadca93562e70aaacfb9a14531
do you not mean "There are %%count%% apples"?
I dont see how. When we're checking a scheme we will only want to know if there is a match.

```
php > $true = true;
php > var_dump($true |= false);
int(1)
```
Since you are duck-typing here, shouldn't there at least be a check whether the needed method exists?
@lyrixx If the subclass method shouldn't be called because it isn't supported, then it violates the concept that you should be able to call any method in the subclass supported by the parent class. This violates the LSP because it means that you can't universally replace a different UserProvider class with the LdapUserProvider class, since we can expect that the loadByUserName method may possibly be called somewhere.
the curly brace should be on its own line for method declarations
You should add some context as to why it is marked as public to avoid confusion.
Why are we removing this line here?
This introduces a race condition, though perhaps not a huge issue.. Is there any way to tell Jetty to use a random port?
oops sorry `--level error`
probly worth an NSLOG too
ctexbook有adobefonts选项？还是得再加些别的代码？有的此选项的话，是否留给用户来选择是否选用此字体？
I'd go with vertical alignment for consistency.
```
private

def authorized_user
```
`private` без вложений
Why are we adding a space here ?
Add a link to the docs in the exception.
Ember should be capitalized.
You'll also want to include:

    name = 'xep_0065'
The correct variable is "existing", not "server" but the reference is wrong in the existing code. The variable 'existing' shouldn't be final, and then the block could be:

        if((existing = servers.putIfAbsent(serverName, server)) != null) {
            ROOT_LOGGER.existingServerWithState(serverName, existing.getState());
            return;
        }
No, the default is `null`, which menas read the `title` attribute.
Andreas wrote the code and you removed the callback?  Or he removed the callback? :)
@davidflanagan I didn't remove but keep <code>metadata[IMAGE]</code> which stores the start and end of the embedded image. I still use <code>metadata[IMAGE]</code> to retrieve the original image, and use it in the PLAYER page.

The size of the cover image in player page is about 320 x 320 (px), and we only store the thumbnail for 210 x 210, that's why we need the original image for better quality. (I am also considering that we may need bigger resolution for bigger screen in the future)

So here the else clause is for retrieving the original image when it's needed. The <code>isCached</code> option will be omitted when we use <code>createAndSetCoverURL()</code> just like I used in https://github.com/dominickuo/gaia/blob/3d3f0543af8db546c8e1068659363b20a7f407f1/apps/music/js/music.js#L860

Sorry I didn't clarify this at the first I opened this PR.
Thanks, I will follow the updates of this patch.
Would be better to read if formatted as:
```js
var status = {
vailability: false, 
roaming: null, 
detail: null, 
fte: _fte,
```
I know you will refine this part later, but could you provide a brief idea about the contact information updater?
As a side note, this is needed when the Contacts app is used independently but not for when it is used from inside the Communications app, as an iFrame :-)
`SnoozePickerView`
Is it to emulate a select? If so why don't you fallback on the native impl?
Why do you need 2 <div> levels?

Also look at other applications and how they use data-l10n-id in order to make your application localizable :) (feel free to ask @fabi1cazenave if you have any questions about that)
you want to be loading these scripts after the dom loads? at the bottom maybe?
One of the questions was when would this be triggered,  and for me this is kind of hard to reproduce, but it's essentially Errno::ESRCH:

    def Pid.running?(pid)
      # Check if process is in existence
      # The simplest way to do this is to send signal '0'
      # (which is a single system call) that doesn't actually
      # send a signal
      begin
        Process.kill(0, pid)
        return true
      rescue Errno::ESRCH
        return false
      rescue ::Exception   # for example on EPERM (process exists but does not belong to us)
        return true
      #rescue Errno::EPERM
      #  return false
      end
    end
You probably don't have to hard code the method name here, you can just use `__method__` instead.
This should be removed to be consistent with other adapters.
you'll want to use a single object instead of multiple parameters to keep things semantic and easier to pass around.
Good catch thank you!

Could I just add a break; at line 285?
I was unable to find a way to generically tie into the equipment database system without knowing about `GsonEquipmentDatabase` and `GsonEquipment`.  It seems like there's a layer of abstraction missing around the database.

In any case, I just check for the legacy `Equipment.yap` file to confirm legacy status.  I was worried that a user may drop in an old `Equipment.yap` file into a current build, this BootJob ran *before* the `DatabaseConversionBootJob`, and thus it would extract the `Equipment.yap` contents over the top of the default database.  Granted, code is in place to `DatabaseConversionBootJob` from overwriting, but I'd rather not write the default database to file unless their database is well and truly empty.
hardcode ?
This seems like it might break the 'reconfig' command.
Well, but the arguments to call `addChange` with aren't going to change, even in nine, just the object where it is located.

Although, currently the `data...addChange` just accepts `when_timestamp` but accepts an int or a `datetime` object. (Which it converts back and forth three times, if you pass a `datetime`?!?)
It does that when we tell `shutdown start` to the irc bot.
For `shutdown now` it's supposed to do an immediate shutdown without waiting for the builders.
`None` is probably better than `-1` here. Particularly since not every vcs uses numbers for revisions.
I'd rather not do this for a new package.  Better to either have users import directly from the nested modules, or just add everything to a `master/buildbot/steps/package/deb.py`
Can you undo this? I guess github does that, but the website generates anchors without root-only because it doesn't make a lot of sense. e.g. http://getcomposer.org/doc/04-schema.md#minimum-stability works
getVersion must be used internally to identify packages, because we can't easily compare pretty versions, but in the lock file we write the pretty version because users were confused to see normalized stuff in their lock file. It's just more usable this way. As for checking it in MemoryPackage::__construct, that just doesn't make sense to verify it every time, it's an unnecessary performance hit when loading thousands of packages.

As for those that have invalid versions, I would say that they can ignored, otherwise we end up with non-deterministic behavior. If you convert 2.4.13snapshot20120629164452 and 2.4.13snapshot20100230101010 both to 2.4.13, then the solver will just pick one and it might not be the latest.
tom, this can be handled in the config file.

maybe we should include a ssh config file for our servers
On Wed, Jun 27, 2012 at 11:23:51PM -0700, laune wrote:
> >  
> >      <para>Drools started life as a specific type of rule engine called a
> > -    production rule system (PRS) and was based around the Rete algorithm. The
> > +    production rule system (PRS) and was based around the Rete algorithm
> > +    (usually pronounced as two syllables, e.g., REH-te or RAY-tay). The
> 
> Why explain the pronounciation here? This is not a detailed discussion of the Rete algorithm, which can be found elsewhere.

Because it's the first time we meet the term; readers tend to form a 
pronounciation the first time they see a new word, and it takes more
mental effort to change it later. Not that it really matters how
they pronounce it, I suppose, but it costs us nothing to get it right early on.
 
Ian
How is `@length` updated then?
`description: params[:description]`

see how it's done overall
https://github.com/gitlabhq/gitlabhq/blob/master/lib/api/projects.rb#L102
for edit. But not for new form
Likewise, not required. This is automatic.
There is no state in this UDP flow and each packet must contain a IPv6 packet. I don't see any advantage to send it to the flow engine (as the decoded packet will have a flow on its own). Am I missing something ?
There is an extra space that should be removed here 

<?php echo htmlspecialchars($params->get('moduleclass_sfx')); ?>REMOVE <?php echo $moduleClass; ?>
if bootstrap size is set to 0  it outputs   class="moduletable " instead  class="moduletable"
hum ok, so it is usefull. The name sounds really weird for me. The word lambda is about really different aspects.
Did you had any alternatives in mind? freezeFunction, protect, immutableFunction, deepFreeze ...

Last question: what is the point of freezing Function.prototype then?
window.activate won't do anything for now
This was an incorrect assumption.  If a user is logged in to the assertion status and verifies their email in a second browser, they should be forced to enter their password before they are upgrade to the password status.
we cache the entire json file in memory. notta soa biga.
Nice, I like the different status code.
Oh cool, I never knew about this! I always just defined the method to raise `NotImplementedError`, but this is even better, as it'll complain when you try to instantiate a subclass that fails to implement, not just when you try to call the method on that subclass.
This entire change block should be reverted, I think. The setting was intentionally changed to be just `DEBUG` (though the env var, if you choose to set it that way rather than via `local.py`, is still `DATAZILLA_DEBUG`). And it is intentional that you still have the option to set `SECRET_KEY` via env var if you prefer that; if you set it in `local.py` that will override this anyway.
Does this help? https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array#Syntax
I don't think we should maintain those different paths multiple times in our code. Simply assign the right pref to an internal property like _pref_gc_notifications or similar. That way we don't need another if/else in _enable.
s/ChangeSet/Changeset
Damn typo, should be >=7.99 .
Good call...updated pull with that change.
Sure np. I thought it was an odd thing, so I gave it an even odder name :)
Voj, voj is what an old Swedish lady would say, holding her head, shaking it sideways when seeing something
terrible :older_woman:  - but that joke is lost on everyone I guess :D
@benton I like your idea a lot!
I'd rather have the routes completely separated although is more DRY
Seems legit. Let it be `to_s` at least for now.
from the implementations, this seems like a getAndUpdate method, right?
Not exactly relevant to this PR, but we should probably have a use statement for this.
Just to trigger the toString of the element.
The things is that it needs to be called when the client create the player's session, before sending the handshake message, just after the player typed the connect command. So it's to avoid client's freezing while doing the request. Or if we store the id outside of the session, we can do as you said and get it at the launch.
No, but @addyosmani or @siuying does.
Use `<strong>`
```ruby
options = {}
```
Reorder these uses. Less dependent ones should be at the top.
CS: close the parenthesis on the next line
Why are you removing the check for the "read only" option?
It currently requires easyconfig files to be specified as arguments. You mean I should add something like -n OpenFoam and it generates easyconfig files for every version of OpenFoam?
should be os.path.separator (or alike) instead of '/' right?
line 106-111
`south` generates a tonne of lousy code. I usually don't change it if the file was 100% generated, but since this actually does stuff I'd argue for a real docstring.
needs to be wrapped in `{% trans %}`
$ is out of scope for the function() bound to ready below. If the idea is to safely use $ in that function, it shouldn't be up here (it also prevents a clean closure)
This is old code that for some reason looks like a re-addition - I think something went wrong with a conflict resolution somewhere.
final int ExperienceDiffence = Math.abs(XP_TABLE[beginlvl] - XP_TABLE[endlevel]);
I'd prefer a single "down" and "up" event that received an object with a property indicating which button had been pressed or released. Also, is there a way to indicate "hold"?
ugh - sorry for the bold, my markdown skills suck.
is this a mistake? it seems like the exact output ?
Huh, I was wrong. Keep it as-is.
No, the intention of those two ifs is just showing while printing to the
user the `affinityGroup` (if provided) over the serviceLocation (which is
always there)

On Wed, Jun 27, 2012 at 6:07 PM, Tomasz Janczuk <
reply@reply.github.com
> wrote:

> > @@ -1064,7 +1080,11 @@ exports.action = function (cmd) {
> >                               if (item === 'password') {
> >                                       console.log('    ' + item + ':
> <hidden>');
> >                               }
> > -                             else {
> > +                             else if(item === 'serviceLocation' &&
> config['affinityGroup']) {
> > +                                     return;
> > +                             } else if(item === 'affinityGroup' &&
> !config['affinityGroup']) {
> > +                                     return;
>
> I am not sure I understand the previous two ```if``` statements. Is the
> intent to ensure that only one of serviceLocation and affinityGroup was
> specified? If so, the right place to enforce this constraint is in the
> checkParametersSpecified() function below, similar to what I currently do
> for
> https://github.com/johnnyhalife/git-azure/blob/625ac6b6808c68d4545ce4cb56ea4e2f33667bd3/src/cli/commands/init.js#L1114
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/tjanczuk/git-azure/pull/54/files#r1063737
>
Since you don't create item if there is no title, please also check for title here as well.
Left over from debugging. Should either make this more informative or remove it.
Does this work yet? We don't want to ship this if it doesn't work.
square `<var>plural(UNIT_TEXT)</var>`

:0)
This method (and the `DEBUG` constant) should be removed, and instead all calls should directly call the logger (using parameters; see next line note below). Then, if you want to see such debug messages, all you have to do is change the module's `log4j.properties`and add this class as using debug-level logging.
Something feels icky about testing if windows (and testing if windows) this way, but I guess there's really no clean way to test if the current terminal font has proper utf support.
because `nil`, or `NilClass` will assign to the attribute without complaint. This could be explicitly set in the configuration and cause a problem at runtime.
Action no longer defaults to ``keydown`` in the latest version so you can actually just remove this line completely.
I don't understand the Travis stuff at all, honestly. I tried running my own fork off of Travis, and it wasn't building so I messed with that. I could have removed my edit of this file from git staging.
Maybe we could even do it in one line
$compoundValues = array_map(function($val){ return strtr($val, array('\,' => ',', '\;' => ';')) }), $compoundValues);

Wow this was hard using ipad ;-)
If you look at the `DefaultFinder` you will see that by default only PHP, TWIG, XML and YML files are processed. Vendor dir is excluded too.
That means you can simplify with:

``` php
<?php
$finder = Symfony\CS\Finder\DefaultFinder::create()
    ->exclude('Symfony/CS/Tests/Fixer')
    ->notName('ElseifFixer.php')
;
```
G->
I suspect there is a better name for this method, something that makes its purpose clearer.  Proposal: is_trusted_issuer.  I think "trusted" is better than "valid" in this context.
ughhh fine!  I just have to use it so many times.
ЭКПТИВ
This method maps approximately to the old ``parse_feed_entry`` method. I chose ``item`` because I wanted to emphasize that the thing the data was coming from didn't have to be any particular form - could be a feedparser entry, json, html, w/e. But ``get_video_data`` might be better - emphasizes where the data is headed, instead of where it's coming from; really, the naming I was using should've been ``get_data_from_item``, which would cumbersome.

tldr: good idea.
I think this can just be `...post('/api/content/:contentId/comment/:commentId', ... `
Nevermind, I see now that it simply relies on the first query to determine if the memberships have been expanded. This is fine.
a comment id should probably also have a isResourceId check.
well at least make it a bit more helpful instead of "zap" :)
Ok, didn't know. Actually, I was trying to emulate some Scala library API doc, I'm still lacking a comprehensive documentation on ScalaDoc...
word of caution we use ev and e elsewhere in our code. We should pick one and  be consistent  (my preference is ev)
yes, I'll fix it.
explain your reasoning on line 3 pls
Здесь ошибка. Цикл должен быть от 0 до val не включительно.
В такой реализации при мутировании на 100% происходит исключение
у вас входной пераметр rate int, а потом вы приводите его в double, зачем?
Недоглядел. По окончании прохода по массиву self нужно было добавить в distanse разницы длинны массива cell и self в случае, если первый массив длиннее.
У вас неправильно реализован hammingDistance, в описании написано: "возвращать количество позиций где символы ДНК не совпадают." , в вашем случае же возвращается количество позиций где ДНК совпадают. 
Второй момент которым вы меня поставили в тупик это этот код [self->DNA objectAtIndex:i] я уже некоторое время программирую на Objective C и впервые встречаю такую запись. Насколько я понимаю вы таким образом напрямую обращаетесь к переменной. С точки зрения OOP это не является верным и все обращения к переменной должны проходить через getter и setter. Вам стоило объявить @property NSArray *DNA; в header файле и тогда вы смогли бы обращаться к переменной через self.DNA или cell.DNA
it seems there was some old things in this branch :(
There are no test for callbacks. I suppose we should test all the callbacks, for single embedded docs, for many embedded docs, for parents, and nested nested embedded docs ?
Well seen ! It failed. I added a test and handled that case.
Why would this need to be on `RACSequence` instead of `RACStream`?
This should normally be `UniReader:drawOrCache(no, preCache)`, but if we do that then it fails in `UniReader:drawOrCacche)` because `self.doc` is `nil`. Why?
Wat ge hier eventueel kunt doen (niet 100% zeker dat het zal werken) is uw RedirectResponse direct "senden". Bij een redirect zal dit er dan voor zorgen dat ge correct doorgestuurd wordt:

https://github.com/symfony/HttpFoundation/blob/master/Response.php#L300
body.length??? is body even defined?
Good catch! Fixed in toolness/webpagemaker@bafa61e7bfab35cb8ccad6b72d49521eb02c4f2f.
Something i copied from surfire plugin configuration in core and it's meant to set the user locale, i assume it is supported by the failsafe plugin
This code was not correct. It was deactivating all the active extensions without checking if those were really depending on the deactivated one.
If you think that this function is useful I can open another pull request.
Here you can see the correct version: ba4c4f390b1fc5e2a5c12f95b360a236abdc27dd
当后端服务器的响应状态码大于等于400时，决定是否直接将响应发送给客户端，亦或将响应转发给nginx，由<link doc="ngx_http_core_module.xml" id="error_page"/>指令来处理。
AHHH ok! I see now...

Sorry! Carry on, nothing to see here
An advantage of jasmine - the syntax/api is very minimalistic and clear. Chai has many ways of doing the same, which means, we need to have conventions to keep it simple to read...
Should explicitly list the class to exclude and after the comment. We are not going to exclude all REST classes all the time.
Needs to be changed to 

``` js
.put('/' + db_name("b"))
```

Check this file for a sample:
https://github.com/dscape/nano/blob/master/tests/db/compact.js#L12