labofsahil/github-event-dataset-2012 huggingface dataset:
A not - so - standard way for only commits about REST &url parameter

When I am trying to send my pull request of only those commits about the REST server, I have some problems.

I have done 2 merges from the origin dbpedia repo to get the updates. Now if I need to cherry pick out only those commits that make REST work, I also need to involve commits in in those two merges. But if I involve them, most of my commits will be involved.

Considering I did only very simple edit in REST, I tried a stupid method, I roll a new branch to a stage before my GSoC. Then I replace the whole REST directory with my master branch's REST directory. And this will be only one commit I need to submit.

I don't know if this method works....
CB-805 - Compass API: getCurrentHeading() returns success only once. Subsequent calls quietly fail.
Forked. Removed aliased_ in order to make it work in Rails 3.1.1

since aliased_table is dprecated in rails 3.1. this small pathc will fix and make it work with rails 3.1.1
Ports interactive tests from Samples

Moves Samples/Tests into Tests/Interactive.  Eventually these
interactive tests should be made automatic where possible.  Where
automation is not possible, we should still try to streamline the
process of manually running and proofing them.
Addition of pre-built signed BAR file 

Included changes to the README.md explaining where to find the pre-built BAR
Add a new pro of Python language in the comparison page.

I believe to declare Python can embed IDL code is important.
Gnome3.4

Added a german translation for sunrise/sunset. Now 24h time display would be extra nice.
Fix for issue 138

This fixes an issue if the <Certifcates /> element has been removed from the cscfg file - previously this would result in a null collection of certifctaes, which would throw an null ref exception.  Also added unit test coverage
Fix to POM.xml
Add VLC to the list of supported players

Hello ojo !

VLC 2.0 is mpris 2.1 compliant so I believe it should be added to the whitelist.

Thanks :)
Best regards,

-- 
mirsal
Failwhale (puzzlr-012)

I've added puzzler related to lazy value computation in case we get an exception during the first time we call this val. Hope you'll like it. Not sure I've written explanation in a clean English, since it is not my first and native language, correct me, please, if you've noted something bad (or even awful) with spelling.
Fixes getter methods created when plugins are initialized.

Because the following function definition is not wrapped in a closure

    self[name] = function() { return plugin; };

`plugin`'s scope is the `TextExt.initPlugins` function. Because of this,
on each iteration of the list of plugins to create the getter methods in
`TextExt`, the return value of all created methods will be the last
value of `plugin` and not the value of `plugin` from when the function
was defined for each.

Wrapping the function definition in a closure fixes this issue.

As an explicit example:

Previously, when instantiating a new `textext(...)` instance and
defining the `plugins` option as

    plugins: 'autocomplete arrow'

All 3 of the following would return the `TextExtArrow` instance

    $('...').textext()[0].ie9();
    $('...').textext()[0].autocomplete();
    $('...').textext()[0].arrow();

After they closure from this changeset is applied, they return their
expected plugin instances

     $('...').textext()[0].ie9();          // TextExtIE9Patches
     $('...').textext()[0].autocomplete(); // TextExtAutocomplete
     $('...').textext()[0].arrow();        // TextExtArrow
Update magit branch manager function

新しい magit にも対応させてみました。

See also:
magit/magit@a5233ba3617a2df23a0735f15ba3d77f613a2629
Nice typo, man.
Update repo to include Haml package.

This fork of the official Haml text mate bundle includes improved syntax for :javascript filters and ruby code in :javascript filters.
Added currently available Phly modules

- PhlyBlog
- PhlyCommon
- PhlyContact
- SkeletonCss
Please accept this update to the README

I have made another update to the README.  Please consider adding it to your version.
update develop branch form featue branch
Initilaization
Mentions and hashtags to links

Added Convert @mentions and #hashtags to links within the convertToLinks function.
More deprecated features in druntime

A couple of cases I missed, which show up in the autotester.
response V1

To do or discuss:
 * use of an abstract factory to provide popper with contextualized objects (i.e.: http, cli or cgi typed class depending on SAPI context )
 * implements logger
 * documents
 * tests

added files:
 * modules/response/response.class.php
 * modules/response/response.module.php
 * substructure/mysfw_response.interface.php
Fixes issues when project 5 is in project 50 (regex string match is bad)
Minispade code wrapper should deal with last-line being a comment 

If the code to be registered has a comment on the last line, the closing part of the registration wrapper becomes a comment as well, resulting in invalid code.

```javascript
alert('hello world');
// Hello World
```

results in,

```javascript
minispade.register('module_id', function() {alert('hello world');
// Hello World});
```

Added a new line to the code during registration to deal with a comment as the last line of the code. Now, the registration looks like this,


```javascript
minispade.register('module_id', function() {alert('hello world');
// Hello World
});
```
Update slovakia language

Short Zapnuté and Vypnuté to Zap. and Vyp.
v2.x: Updated the use of libraries also on bigbluebuttonbn

Signed-off-by: jfederico <jesus@123it.ca>
Remove superfluous 'modules' in puppet file path.

Exactly how puppet converts ambiguous paths into absolute paths I'm not entirely
sure. I _am_ sure, however, that the path modified that this commit resolved
into:

    /etc/puppet/modules/modules/files/supervisor/logrotate

where the new path resolves to

   /etc/puppet/modules/modules/supervisor/files/logrotate

The later, of course, being correct.

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Update commit SHA for webplatform to include the fix for Web Inspector on 10.0.05

Web inspector is currently not being enabled correctly.  This patch will correctly enable it.
Node v0.8.14 support

Node v0.8.14 support
-Updated Wrench to 1.3.9
-Updated connect to 2.6.2
-Updated express to 3.0.1

Refactored code
-path.existsSync --> fs.existsSync
-path.exists --> fs.exists

This pull request should be tested from blackberry-webworks/BB10-Webworks-Packager#106
Fix for build error, and the minor uglinesses in last pull request.

Major fixes to follow.
Add support for any Google supported regions.
Sync with production

I added this branch to make this repository up to date with the oringinal
https://github.com/stefanomanfredini/serveaiuto

..perhaps, would it be better to merge this with the master..?
fixed parameters for Vagrant 0.9 and added a box that's publicly available

I had some problems to get the VM working with Vagrant 0.9, had to fix the Vagrantfile and I put a URL to a box from vagrantbox.es in it. Works now with the current Version of Vagrant and out of the box.
Would be great if you could pull this in :-) And thanks for this, it makes playing around with graphite and statsd a lot easier!
cinnamon 1.3.0

This is just a quick change to the metadata.json file to make the extension compatible with cinnamon 1.3.0. The change was tested on cinnamon 1.3.0 and it works.
Update fr.lproj/Localizable.strings

add : hide_icons

smaller text : save_or_restore_btn
Great catch @joneslee85 , I love to see commits with delete's only!
`return false;`?
Thanks, was a lot of fun to make!
Přesně tak.
Yeah, it would be good idea to decide the path we want to go. :)
Do you want to use the force from the dark side or the light side? :D
nesse caso nao, mas como o projeto vai para a Amazon, tenho medo da gem atualizar e quebrar oque agente fez manja.
já coloquei aqui, instalou a 0.2.7, confere produção?
Understood, but having var that = this or self=this throughout the code is at least equally as ugly.
This is currently not working but don't get why

<pre>
[error] application - 

! @690ma4656 - Internal server error, for request [GET /] ->

play.api.PlayException: Not initialized [?]
        at play.api.PlayException$.apply(Exceptions.scala:79) ~[play_2.9.1.jar:2.0-RC1-SNAPSHOT]
        at play.core.ReloadableApplication.<init>(ApplicationProvider.scala:70) ~[play_2.9.1.jar:2.0-RC1-SNAPSHOT]
        at play.core.server.NettyServer$.mainDev(NettyServer.scala:131) ~[play_2.9.1.jar:2.0-RC1-SNAPSHOT]
        at play.core.server.NettyServer.mainDev(NettyServer.scala) ~[play_2.9.1.jar:2.0-RC1-SNAPSHOT]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.6.0_26]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) ~[na:1.6.0_26]
</pre>
I think you can just verify if exists the data 'readonly' like:

```if ($this.data('readonly'))```

Could you add code to add or remove the data on conditional isReadOnly for me too?

Thanks.
You're right, it's unnecessary statment.
Fixed in https://github.com/soid/jenkins/commit/963edec84f93fe30290fe1a2b30edbbfafb28a9f
thank you!

On Mon, Feb 27, 2012 at 5:17 PM, Akzhan Abdulin <
reply@reply.github.com
> wrote:

> Just pulled in. Release later today.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/arya/bluepill/commit/b5858d00be44fb0039f885a8f3d05b0b18509db0#commitcomment-1017276
>
lets keep it as is. The duplicate is a symptom of a larger problem that should be fixed at the larger scale
Should those 3 lines be chained in 1?
This breaks support for centering the entire email content.
asprintf() is not documented to set errno in all cases which is why I'm using ENOMEM.  It may not be universally correct but we can't assume that errno has any meaning at all.
Cool! Never knew
Hmm. Shouldn't this be like: 
 (reads_merged(time = t2) - reads_merged(time = t1)) / (t2 - t1) ?
One caveat about estimating clock skew like this is that we don't account for "processing time" on the machine, i.e we only have three events when really there are four (a receive and a send for the NM). Probably okay to assume that time is negligible though at these scales (handful of ms).
Yes it will, but is that a problem?
Is it possible that this commit is preventing reloading a source file from replacing the definitions of functions. Because that's happening to me.
Хилять он будет?
Currently we have hard coded the options values for the docblox , what about showing the help and then asking for user input or by default using the current values ?
GetPropertyByKey ...ist vll besser...wenigstens den Anschein wahren, dass wir Englisch können ;) und nicht so ein direktes Übersetzen ;)...mach ich mal
Yes. .C is checked as C++ in Windows. 

I created a ticket about this:
https://sourceforge.net/apps/trac/cppcheck/ticket/3477
But in Windows... (Or did I read the code wrong?)
Actual Memory use is not normal, IMHO memory leak in some place.
нафига реверт? -DUSE_STD_MALLOC и ваши волосы... а на 32 битах так она мб и полезна - лучше работает с мелкими блоками. можно просто на 64 ее забанить в коде.
how about https://github.com/gc/mangos/commit/78fada09749f7e9e215babc3c2207fe17e87bb7c ?
On my tests it worked fine, will be tested by people on live server already tomorrow too. It will be useable also for IoC, after we split keep cannon spawning to 2 groups, horde and alli.
It's effectively a one-liner.  Does it warrant a dependency on a big module like Runtime?

Dojo made a conscious decision to avoid methods like this, as it contributes to code bloat.
I'm glad we didn't put these holiday features in a database.
If we are reading CD paths from baldur.ini, then it seems reasonable to use those paths for everything.
First off, thanks for taking the time to help with this document, I really appreciate it.

In JavaScript, any function can be a 'constructor'. There's nothing that makes one special.  By convention functions that are to be used as constructors are in PascalCase as opposed to camelCase.

Secondly, excellent comment about next.  It should indeed be called by the forEach function itself and I will correct this example!
extensions is misspelled (!)
The current test has no password so .login() fails, but you're still logged in as the admin from above, so the test still technically passed, it just wasn't testing the right thing.  Since the editor permissions changed with robhudson's latest patches that got more in depth than I want to mess with.  Since the test was dead anyway, I just commented it out.  See bug 731908 for more.
Nit: The indentation in a lot of places seems to be off when viewing the diffs on GitHub (e.g. ironclad.asd).  Could you make sure you're using spaces instead of tabs for indentations?

Nit: You have a number of places where forms are separated by two newlines; please use one newline for separation.
You hit the nail on the head with those comments: `connect2` is more complicated because it includes all the logic from `bufferSource` in its body.

Not only do we ditch `bsourceUnpull`, we also get rid of `unsafeBufferSource`.

Technically, this will be a breaking change, though I doubt it will actually break anyone's code. I'll release as 0.1 anyway, just to be on the safe side.
So up to here I think I understood what was going on. Why do we webfinger the object's diaspora handle? Seems like we should look it up locally first. Is this doing a synchronous WF request?
Something about this specific commit broke my master and render_vector branches.  OpenSCAD dies in a boost call when I try to compile something as simple as "cube();".
Use {{ create_folder_form }} instead of {{ form }}. We may have many forms on one page.
I know that, but putting hard limited like this on it doesn't seem like a good solution, and does there really need to be strong protection against using spout packages? This has already broken one plugin that is necessary at present: PEX.
Hi Brady..
I needed this comment line for writing something extra into the issues..I came to know of this method in the forums atleast a year ago...using it since that time..I really had no idea about any security issues. If you think it will cause security breach..I will revert it back..
This is where I am concerned about mangling unexpected dash tags.  Say `tag` is "FOO" and `extendedlabel` is "V-FOO-BAR".  We'll wind up with "FOO" in `currentextentions`, but `extendedlabel` will be trimmed to just "V".  (I think)
My apologies. I fixed the "too many open files" problem, but will look into the time issue.
you could just move this out of an `if` statement but this totally works for me
you can remove this comment, it's not necessary since you're using `loc`
di ba dapat may test to for loging in successfully and pag wala? hehe
Here identation is a bit strange. It looks like it belongs to the content of the for loop
Forgive me if my math is wrong...

I believe the code here marks any chunks within a 33x33 player-centered grid as "in use", not 21x21 as mentioned in the comments. To my knowledge, the server only loads 17x17 chunks for each player. This means at most 289 chunks are in use by a player, while Bukkit declares 1089 chunks (nearly four times as many!) as in use. The expression should check for bounds within 128 blocks, not 256, to accurately reflect chunk loading behavior.

"This is larger than the distance of loaded chunks that actually surround a player" seems to indicate that this is intentional, but I must wonder why. I'm writing a plugin which uses this function (via `org.bukkit.World.unloadChunkRequest()`), but I end up keeping hundreds of chunks loaded that aren't actually being used. Can @Dinnerbone comment since he wrote the original commit?
As it is not exactly clear what I have changed I aded inline notes
Ehm, eh... Sure? Ik heb het gevoel dat je dit naar de verkeerde persoon hebt gestuurd, aangezien ik de afgelopen week geen een keer aan de code heb gezeten.
Like I said, this is useless. You are just re-raising the exception. And the ensure will also work without the rescue
nice, extract method + remove timid code, this is definitely more readable.
Although there is no (doxygen) documentations yet, I must explain in what content this function must be used!
[ Prior to use this method, a set of keys must have been defined on this dictionary. ]
We are using guest_kernel_kernel_path in build and also in during boot. Hence i defined a new config file config.cfg that gets included from build.cfg and guest-os.cfg
Commenting a line...
two spaces between code and a comment on the same line
And yet there are some pre-install caveats too, since we only have one set of caveats to work with.
Note this commit should read version 0.7.4 not 0.7.3
Could we use our URL instead:
http://mapsdownload.cyclestreets.net/mapsforge/maps/snapshot/europe/great_britain-0.3.0-SNAPSHOT.map

Best that we use our bandwidth, not theirs!
@jmathai After this commit there was two duplicate lines for "lastCodeVersion" in the configuration file. The first set to 1.3.2 and the second to 1.3.1. So lastCodeVersion was set to 1.3.1. I changed it manually and now it works fine.
oh hah lol... 

too late now, I think mhevery fixed it already, hah
Fixed in [5da91e](https://github.com/yellowled/s9y-2k11/commit/5da91e3419e606a5bb60a174ac9fcb8beb9f3804).
Great work Strong.  Not happy about having to maintain these collection classes, but given the perf numbers you posted I agree this is the way to go.
I tried it this way too, the first time, but it isn't working properly. `wp_get_referer()` returns false for some reason. Maybe you could do a check to see if it returns false and if it does use `$woocommerce->cart->get_cart_url()` instead.
Here's the explanation:
http://www.developwebsites.net/match-backslash-preg_match-php/
why not, but what would be the advantage of a make file over a script that call the subscripts?
Maybe the signup link should either point to the signup (i.e. pledge) page or be removed entirely? I do think that when the users are redirected to the login page when they try to save their lists, it should point to the login page rather than the signup page. But it seems a bit odd that you would click on a signup link and not be taken to the signup page.
Spurious newlines, where do they come from? ;)
Should we also switch to 15? I guess so?
No, RTCommunity and AbcBuilder are not the same module. Sorry for the
confusion. Sugar doesn't seem as intuitive to me as SFDC is.

I'd just like to be able to do: RTCommunity.all and cache the result,
but it looks like that's not going to happen.

Also, when I do a RTOccupant.find_by_nnn the RTCommunity gets
dereferenced properly and the occupant has both rt_communities_id_c
and community_c populated. But a query of find(:all) only populates
community_c. Any clue?

--
Jason Rogers



On Mon, Jan 23, 2012 at 22:26, Jason Rogers <jacaetevha@gmail.com> wrote:
> There is no association for rt_communities. There is a
> communities_builder in which both module and bean_name are empty
> strings.
>
> Is it that there is something amiss in the client's Sugar instance?
> Perhaps they renamed the module? So your gem thinks there is an
> RTCommunity and AbcBuilder module, but they are one in the same? I'm
> just grasping at straws here.
>
> Thanks a lot for the support. It's very kind of you!
>
> --
> Jason Rogers
>
>
>
> On Mon, Jan 23, 2012 at 21:30, Carl Hicks
> <reply@reply.github.com>
> wrote:
>> Excellent, I should have said '''AbcBuilder''', sorry :)
>>
>> If you look at the output of "associations", and you search for a proxy_method that includes "community".  You get something like this:
>>
>>    #<SugarCRM::Namespace0::Association @proxy_methods=[communities_builder], @link_field="communities_builder", @target=false, @owner=SugarCRM::Namespace0::AbcBuilder, @cardinality=:many_to_one>
>>
>> '''@target=false''', means that the gem doesn't know which module is associated with this class.  This is probably because it wasn't provided in the module metadata we received from a '''get_module_fields''' call (we look for the module name in the "module" or "bean_name" entry of the returned metadata).
>>
>> Can you run:
>>
>>    SugarCRM.connection.get_module_fields("AbcBuilders")
>>
>> And look for a line like:
>>
>>    "rt_communities"=>
>>      {"name"=>"communities_builders",
>>       "type"=>"link",
>>       "relationship"=>"communities_builders",
>>       "module"=>"",
>>       "bean_name"=>""},
>>
>> Let me know if "module" and or "bean_name" are empty.  If so, try editing the vardefs and adding the appropriate module name.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/jacaetevha/sugarcrm/commit/0636284e801a3aa191a0427f64e7caf2f1530e0a#commitcomment-894694
Using a heredoc is even easier. ;)

```
        insert_into_file env, <<-TEXT, :after => "Application.configure do\n" if env == 'production'
    # Refinery has set config.assets.initialize_on_precompile = false by default.
    config.assets.initialize_on_precompile = false
        TEXT
```
I wonder if it *is* the right thing to "insert to my_ships."  

It seems to me that this will require increasing amounts of cleverness as attributes get added.

I'm finding I want to do multiple inserts (e.g. - need INSERT INTO ship(), INSERT INTO ship_location (), possibly more...), which doesn't seem to work very well.  

Probably what has to happen is for this to be refactored into some function calls.

Thus, something more like:

CREATE OR REPLACE RULE ship_insert AS ON INSERT TO my_ships DO INSTEAD
   perform create_ship (parameters);

Suppose create_ship() returns the new ship ID, then we want...

   perform locate_ship(create_ship(parameters), location);

That works if the ID is only used once.  If there turn out to be two functions that require the ship ID, then it all has to get wrapped together.  Perhaps that simply means that create_ship() does everything, and maybe there's no need for a trigger on ship.
are we still getting the l-bfgs log file in the tests? this would pick it up automatically

(I will need to be more careful with leaving uncommitted files around)
Yea, I think that can be arranged. I'll whip something up.
if you don't want to run something as heavy as apache, you may appreciate stunnul (http://stunnel.mirt.net/
Isn't path.join on a single string redundant?
what happened to the report id?
Any documentation about how this would be used?
Update: I tried the latter -- copying the files from the "downloads" link above into my Applications/ReplicatorG folder. Control panel is still not opening, so maybe I have a different problem.
I like the SEO improvements, but TBH I would prefer the current logo over this one.
I just got an email from Travis-CI stating that the build failed.

Job 	Duration 	Finished 	Python
6.1 	1 min 27 sec 	about 7 hours ago 	2.5  <-- success
6.2 	14 sec 	about 7 hours ago 	2.6 <-- fail
6.3 	14 sec 	about 7 hours ago 	2.7 <-- fail

Though, I'm not sure how these changes to a JavaScript file would cause any mischief.
Sure, that works. There's really no need to fork for grep here, though. Just read the sysfs file and compare it.
Sorry about that, I didn't read the diff carefully enough. It's already merged.
Any opinions on this?

I'm considering including the file, but not having it #included by l4d2_direct.inc... Since it's kind of a different purpose, here.
I'm just asking why we're testing it -- given that it's functionality you can't ever rely on.
Does it mean that mk in vms will be looking in /templates? I don't think it's a very good approach at the moment, we don't have a "shared" pool of templates by default.
Also, period skips 1 turn, and the 5 key skips 10. Great for testing out the whole time system thing.
In this specific instance I think a property would be a good idea.  It probably be a good idea to find all the places the target engine is checked and encapsulate what is being tested about that engine.
Deleting .dist file is not a good idea as you won't be able to pull from the git repo fast forward.
Thanks! Should be no problem to contribute the file. Do I still need to sign a CLA for contributing to ZF1?
Content was spread pretty thin between the home page and the about page so they were merged together into the home page.

I agree that this "link" is incorrect, but don't know what to replace it with. What if I replace it with <a>About</a> so that it has the same styling as the other elements but doesn't have any click actions?
Red herring or not, it is pretty clear that this issue started appearing after log trimming changes and there are no other places where this exception is raised. One project reported it completely going away after they fixed `before_script` but then I haven't seen it in maybe 4-5 hours. When it happens, it seems to affect every 3rd build or so.
Things has been added:
* Create views.
* Enhance exceptions handling.
* Support non Latin languages.
Ok, take a look at 476112c3f336d9940f33ccc1812562f61fe3b400 and see what you think.
Tested and working without issues so far.
Да после комита посмотрел, но пока не стал убивать, он по дефолту создался.
Hm... I don't like the blunt casting.  What if the interface is const or shared?  In reality, object.opEquals should use const objects, and Object.opEquals should be const as well.

But this would be a very disruptive change, which we should make when all Object becomes const aware.  Just keep in mind though, this will break const (it already does today).  I'll add something to the "Object is not const aware" bug.
@richardmiller: Could we change the last bit of the `transform()` method to:

```
foreach ($array as $key => $value) {
    if (null === $value) {
        unset($array[$key]);
    }
}

return new Elastica_Document($identifier, $array);
```

Alternatively, we can keep the `filterOutStrictlyNullValues()` method and just use a `foreach` internally. I'd suggest making the method itself private unless otherwise required to be available to an inheriting class.
Styleguide:

http://dojotoolkit.org/community/styleGuide

Other examples are do:

```}else {
```
instead of 
```}
else {
```
Good luck. I'm on IRC now, btw.

Looking at the board file, it seems that it should support the older and newer dhd driver. When compiled without ENABLE_BCM_4329, the board looks for the "bcm4319_wlan" name in the driver (which *does* exist in your stock driver, which you can see from grepping the strings). If it's built with the flag, then it expects the new name.
Two more tests:

Try this: http://gitorious.org/linux-on-qualcomm-s-msm/linux-msm/blobs/0cd9973c88b2a750e5a689cc9d508382d81d6032/drivers/net/wireless/bcm4329/Makefile

Or, my updated Makefile: https://github.com/psyke83/kernel_huawei_u8160/commit/36f2ddb1c4eee704b14c8e08a6ab59b36e959a8e
make short the message.
Because, when using Apple Gothic (Korean Default) Font, couldn't read message full, (hide some characters) in pref screen.
fixed it.
Removing this closing brace causes the build to fail
>[18:00:21] <EvilSeph> they're using CraftBukkit++ that is filled with hacks

Probably won't happen. :/
Oh, I didn't realize what function this was. You should probably just have every process keep a list of children exit statuses that it can reference later.
As it currently stands, FormHistoryRecords don't have a deleted flag.  I like your re-factor but it appears to assume CommonColumns and SyncColumns in all records; am I incorrect?
This throws a VerifyError on android 1.6, you may need a wrapper around resolveSizeAndState
Why not this way:

`public function sort(QueryBuilder $sortable)`

and avoid checking instance and throwing exception.

It is more readable IMO and this kind of error should be caught in tests.
The assembly file produces a warning about the format not being correct.
 Please consider using odd / even numbering or something else.  "alpha" is
not valid.

On 4 March 2012 08:15, Prabir Shrestha <
reply@reply.github.com
> wrote:

> Please don't update the AssemblyInfo.cs file.
>
> We update the VERSION file at the root manually before a new release.
> AssemblyInfo.cs file is auto generated by the build script.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/PaulECoyote/facebook-csharp-sdk/commit/843f3bc2a9b9010258bf585cf5e9b4711be379d7#commitcomment-1040120
>
I suppose things like this could (should?) be handled in settingsValidators.  it is the central place for all setting validation
the 6 colour battery bar patches no longer seem to work - they merge ok but don't compile since about 25/feb
Did you mean to add an R in there?
Interesting that this was needed.  Did you determine it's a bug in the ruby client?  Would be glad to fix it upstream.
boa! bem fixe!
does the performance setting stick on reboot??
it doesn't in my case... just asking
Scrap the comment lines 56 and 57, and add a line-break to the end of this line. It's a better short description than just repeating the name of the constant being documented :-)
This is very similar to `Fog::Storage::AWS::Mock#delete_object`.  If you could extract a helper there, that might be better.  But, I know there's a lot of corner cases around response types.  It looks like just the core mechanics of manipulating the data store are the same.  But, something to think about anyway.
For consistency, could you also check that the clockssLicense setting is filled in (as is done with the LOCKSS license)?
Would it be possible to pass n_rows as const ref setting its value in the caller?
That wouldn't quite work as written. Just for reference, here's `is_upgradeable` again:

```python
def is_upgradeable(self, requirement):
    if requirement.is_subrequirement and not requirement.is_extra:
        return self.upgrade_recursive
    else:
        return self.upgrade
```

I agree with you that it would be preferable to instead create an `upgrade` property of `InstallRequirement` if it were simply a matter of passing the value of `RequirementSet.upgrade`. The reason I used a method on `RequirementSet` is that depending on whether the requirement is top-level (either the requirement was an argument to `pip install -U `, or was one of the items in a `pip install -U -r` requirements file) or whether it was added via `install_requires`, `test_requires` etc. (what I denote with `InstallRequirement.is_subrequirement = True`) determines whether it should be a "force" upgrade or not. So you would either have to duplicate this conditional before calling the `__init__` for `InstallRequirement`, or pass both `RequirementSet.upgrade` and `RequirementSet.upgrade_recursive` to `InstallRequirement.__init__()`. When faced with those options, and considering the number of times that `InstallRequirement` is instantiated, it seemed to me that adding it as a method to `RequirementSet` was the option that had the smallest footprint.
river/object/comment/create
Formatting is off here, it seems
I mean if you use that idiom within an actor, then that actor will be the sender, which would be quite unexpected, I guess.
correct in principle, but might show errors in the wrong location: what if the first version is not entered by a node but the second one is? (hard to imagine for a cleanly written test, but nevertheless …) So I would recommend as a style that barrier names should not be reused unless good reasons force it.
Such a tool would be awesome.
Sure? 

    $ scala
    scala> IndexedSeq.empty
    res0: IndexedSeq[Nothing] = Vector()
case object vs case class, but I have made the default MixMetricsSelector a case object as well (using an extra base class)
I can't help myself... can we write it like this (`AddInt64` returns the value)

```go
for atomic.AddInt64(&c.messagesInFlight, -1) >= 0 {
    <-c.finishedMessages
}
```
IMO, I'd rather the query parameter be something like "include_repos". Looking at something named "repos" I'd expect it to be a list of some sort instead of a boolean driving how it behaves.
good call, 237 that should definitely be changed to `return self.on('dblclick', ...`
Please put the brackets on separate lines.  Also, you need at least #include "StdString.h" here.
ohja klopt. On my way!
do you really want to mark unstable steps as failure in strict mode ?
I think it is safe to remove since it isn't squawking, ever.
using _self might be cleaner
There needs to be tests for all these settings
oops, fixed now.
This will have a side-effect when passing an existing DateTime object as it will change the timezone of the existing objects. Unfortunately, PHP DateTime objects are not immutable. In case of a DateTime object passed by the user (the case which was returning early previously), you need to clone the object
Please wrap this `if` statement in brackets, as well.
It says this is the default behavior in the Apple API. I'm also in favor of changing it, so i'll do that.
no yet correct. we should test if there is an empty *item* declared in the form. We should not test if its label is empty, because the developer could want to have an empty label
I think vi + intellij might have caused tabs to creep in - will grep the source tree and replace them, my apologies.

1) I think I am violating that all over the place - will correct.

2) I started explicitly introducing types since intellij was not able to infer the types properly - so that I can get sufficient contextual information while coding (code completion, lookups, etc) ... and then it became a general practise I guess.

3) I think we made an effort to ensure all lines were <= 100 chars (unless it is overflowing by a few chars and splitting will make the line really messy). Hopefully I did not miss any.
> Your whitespace has gone wonky here (some tab problem perhaps)

Oops, sorry, messed up with my editor. Fixed
`intern` and `aht` should be `object` and `ht`. Also the `(intern->ar_flags & SPL_ARRAY_IS_REF)` thus is duplicate as it was already done in the outer `if`.
It seems that this test excess and with wrong name now because of this https://github.com/rails/rails/pull/6031/files#L1R99 :)
We need to fix the indentation here
You may as well delete this one as it's commented out.
Wouldn't be easier to give the valid options straight to the method call, instead of adding `valid_dependent_options`?
Not a fan of assert_nothing_raised seems much better to me to test the result of the query :heart:
To be consistent with the style used in the line below but I agree that it's unnecessary in this simple case.
why stringify here ?
People read "internal" methods to understand how things work, and "there is other code that is equally bad" is not a very good reason to continue writing poor code.
```scala
trait Y; trait Z extends Y
class X[+A <: Y]

(new X[Z]: X[_]) match {
  case X[Any] => // looks a little funny; `Any` is outside the bounds for `A`
  case X[Y] => // looks better, let's allow this (too)
}
```
IS this public API now?
Assuming paramss is flattening multiple parameter lists, here's one which needs a -3.

    scala> def f(xs: Any*)(ys: Any*)(zs: Any*) = 5
    f: (xs: Any*)(ys: Any*)(zs: Any*)Int

    scala> f()()()
    res0: Int = 5
One second thought, how would exists work?   Specifically "head" is important there.   The very first object found has to be the one that's top level.  For nested objects, we can use this.getClass and have this refer to the outer object safely.   We *only* want to generate this hackery if it's absolutely necessary.
I don't think this should be a heading at all.
Maybe you want `(c.lhs - c.rhs).is_zero`?
```
s_order = str(self.order)
orderstr = (" order=" + s_order) if s_order != self.default_order else ""
```
This is because substituting as you said above gives O(x**6/y**6, x, y) as a part of the expression (for (x+y)**0.3, for eg), which should actually be O(x**6) for correct further calculations.
You should wrap this line to 80 characters.
Bu eventlerin fırlatılmasına gerek yok. Bu componenti kullanan yerler ihtiyaç duyar ise kendileri focus ve blur eventlerini dinleyip gerekli işlemlerin yapılmasını sağlayabilirler. Her kullanımında event-driven kullanıma ihtiyaç olmayabilir.

Ayrıca eventlerin isimlendirmesinde de date_input ifadesini tekrar etmeye gerek yok. Zaten DateInputDlgComponent sınıfının altında yer alıyor.
Need issue number here.
mglu.h is an internal header, e.g. it's not a part of public libglosm-client api, so it shouldn't be installed. If it's needed outside, it should be moved to other headers in glosm/. Other chenages are OK.
iOS parity
alright, let's go with that, can you write some documentation about it? It will at least need to be documented in the javadoc, but If you can write a little something for users that just started to use the framework, it will help them a lot
This seems to be calling the same routine as the FEM case which is based on elements. Shouldn't there be a nodal case?
It would be preferable to have this all live within the same pair of `$` so that the baselines align correctly.  i.e.:

```
return '${0} {1}$'.format(latex_value, self.unit._repr_latex_().strip('$'))
```
What about, if we would move the code within the "send FriendshipRequestTo()"-Method to here?
- There is anyway no other way to request a Friendship then calling the Service.
- It would not lead to confuison, as the service becomes then the only place to send a FriendshipRequest
- It would decrease the size of the User-Model (which is already very large; if not to large)

(These comments apply to any User-Friendship Method)
这里的piece选项是控制一下在内存中的数组长度。默认是30w。
Can you please document the purpose of this class?
Overflow in unsigned to signed conversion is implementation defined.
it works
thanks
This is a fair point, but I think this could get included in a subsequent patch (for example when we build a widget in the UI for this).
What does `Id Ordering Case Sensitivity (on/off)` mean? Would it not be better to call it `Collation` and label the radio buttons with `ascii` and `unicode`?
Interesting, this line does not lead to a compiler error? Could be a compiler bug IMHO, the local prio variable might be never initialized but still used for comparison in the if () block, or is the compiler understanding the !Int32.TryParse() part and thus knows it will never get to the other conditions that read the int?
1. Yes. It was already discussed that we should use a completely different string for that we jsut need to discuss which string should we use.

2. It's a forum that is a private forum. I don't believe that's the best name it could get. If you don't like it, suggest another one. Probably you could find a better name for it.
I hadn't thought through the code properly, but I see your point now.

Marc, it would probably make more sense to pass the time as an argument to the function. Currently the function doesn't do exactly what the function name days.

On 16 Dec 2012, at 00:16, Igor Wiedler <notifications@github.com> wrote:

> In phpBB/styles/prosilver/template/ajax.js:
> 
> > +		}
> > +		else {
> > +			currentObject.removeClass('forum_unread_locked').addClass('forum_read_locked');
> > +		}
> > +		currentObject.children('dt[title=' + unreadTitle + ']').attr('title', readTitle);
> > +	});
> > +
> > +	// Update mark forums read links
> > +	$('[data-ajax=mark_forums_read]').each(function() {
> > +		$(this).attr('href', res.U_MARK_FORUMS);
> > +	});
> > +
> > +	// Hide alert after 3 seconds
> > +	setTimeout(function () {
> > +		$('#darkenwrapper').trigger('click');
> > +	}, 3000);
> @callumacrae Those 4 lines (including the comment) are duplicated within this PR. Thus it makes sense to extract a function, so that when that behaviour changes, it can be changed in one single place. Also, a named function communicates the intent of what that piece of code is supposed to do.
> 
> @p Do you have anything to add to that?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Do we want to make sure the user is an actual bot by joining the bot table?
fixed in 292d7fb
@kans i was seeing 'run' being ran twice.
They supposed to set particular elements in a projection matrix.
for line 12 its an element on a 4th row and 3rd column.
Or do you need a mathematical meaning of this?
Ah, duh. Sorry.
This file should not be in this package. The actual hails binary is in the hails-bin package. In fact, this one is out of date. But... seems like a simple an clean patch, so easy fix :)

Maybe we should make hails-bin a submodule or include it here with a makefile (similar to blaze-html)
Minor, but we should turn this into middleware also.
I already cc-ed him above :D
why is that change necessary? unaligned_load still allows a second argument, right?
core relies on this
alert doesn't look right to me... 
It should either redirect the user to the loginPage (simpler) or show a blocking modal login dialog (more sophisticated)
This file is missing the license header
```reload``` is a built-in function. Use an alternative variable name.
Link probably doesn't work.
Remove all that debug code.
It is used, see line 110, and 437+.
SpPromoteAlgo, too
Added ChangeType, but ignoring it, seems like a half-measure. Was there an intent to allow deletion of even a unique index? Is there some reason to defer that?
This code seems correct but hard to follow with all the repeated nested loops and names like "currentIndex" and "t" and"table".
Which of these names is supposed to suggest an existing/old definition vs. a new definition? I have trouble keeping them straight.
I suppose I could just remind myself by grepping the code for "t" -- no. wait. bad idea.

Maybe build one or more name-to-index maps and use lookups to find matches, and, as you go, remove the matches from the map and process them or migrate them into another map for later processing (as re-definitions).

It may be easier to process as we go, but it may be more useful long-term to try to batch up constructive changes before destructive changes to increase the odds of finding an index that helps in optimizing the build of another index (such as for a trailing column drop)?
`fs_utils = require 'fs_utils'` and `fs_utils.exist` because when nodejs 0.8 will be out, `sysPath.exists` will fuck stuff up
Ornament.
the end is missing
it backfires here, though: the `return retval` at the bottom looks, at a glance, like it sometimes happens after the `if` and sometimes happens after the `else`.
getSection
If this is wrong, https://github.com/extend/cowboy/pull/91 should be closed.
I'll update names, so will be more clear.
Let's flip the order of the if statement here to first handle the case of all three are set.

I tend to profile code that is this core to the library before changing things around. It turns out that in this case, using isset() is 4-5x faster than count. Instead of using ``count($statusLine) === 2`` here, let's use isset($statusLine[2]).
I think it may be worth commenting (in the code, not the warning message) on what will happen if the optimistic assumption is wrong: HPC will take the list of search paths and apply them sequentially, each one replacing the last. So, it will search only the _last_ path specified. This will break black-box tests, but only if HPC doesn't report its version correctly. As far as I know, all versions of HPC correctly report their version, so this should never happen.
I am not next to my laptop now, but aren't the  vector4 components already of a float type?
Add a test case for this change, and make it separate commit(s), and we'll merge it in right away. An independent pull request would be best.
Oo--I like that. I'll change it now.
I didn't realise p1 was the default - my bad - I'll sort that presently.
But I was under the impression that we only accepted (and would ultimately be validating) that the modules passed in here form complete modules or complete sets.
@kcooney 
Briefly as I told you in the main comment, the removeListener() must be exclusive with run().
Sorry, I misunderstood what was going on here.  Here's my suggestion:

In SingleInstanceTestClassRunnerForParameters, create a new method:

Object superCreateTest() {
  super.createTest();
}

Now, here in classBlock, rather than calling createTest, call superCreateTest() (The only reason for extracting the method is to make it easier to get to the super implementation of createTest from within an anonymous inner class).

Then, override createTest():

```
@Override Object createTest() {
  return fTestInstance;
}
```

And then you shouldn't have to override methodBlock at all.  Does that make sense?
The render need neigbour chunk to know if it need to render face on side of the chunk, i use render snapshot for the curren chunk an non-render snapshot for the neigbour ?
Do we need to guard against fs or lh having length < 2?
We don't want to return the cached data since it could be incorrect. Returning cached data would make the unit tests fail.

I agree about the offline case, so I changed the code to reject() if the resultText is empty.
I'm confused by this comment. Both ```agents``` and ```_enabledAgents``` are objects. The _keys_ must match (i.e. they must both use the same name for agents). However, _enabledAgents stores "true" for all values.

Basically, _enabledAgents is a hashSet of agent name strings (which just happen to be properties in the agents object).

So, there shouldn't be any ordering concerns. Am I missing something?

Perhaps _enabledAgents should be renamed to _enabledAgentNames?
Also the following comment needs to be cleaned up: line 61 of src/index.html
Without this patch people cannot set level names using a descriptive string, they must use integers. The built-in default of 'INFO' is invalid since handler.setLevel() takes an integer arg.
Possible null dereference. We could do
return streamSource == null ? ssd.streamSource==null : streamSource.equals(ssd.streamSource);
Magic numbers -> constants
Note that this one are commented as they were failing due to an inconsistency in libgit2. I provided a fix that have been included in libgit2, so as soon as the "local" delivery of libgit2 is renewed, we should be able to remove the comments :)
We could, but there are `facet` item types like `Instance` that has no attribute `visible` (maybe that is another feature to think about :) )
And we have in the future the possible advantage to render the facets regarding other attributes.
I'll delete that before I merge in.  This is raphael plugin I found that adds group elements, initially i was giong to use it, then I commented it out for reference. Basically the only code I'm using from it is the part that actually creates the group element, so I can probably delete it.
In such case file indeed wont be found, however when using gem you are not loading this files that way.
You just `require "picasa"` and gem is loaded.
If you want to test your changes, you can easly load current code using `bundle console` command.

When loading gem, its root directory is added to  `$LOAD_PATH`, so all directives like: `require "picasa/api/base"` are possible.
You can easly see that by:

```
wojtek@ibm:~/Projects/$ irb
1.9.3-p194 :001 > $LOAD_PATH.grep /picasa/
 => [] 
1.9.3-p194 :002 > require "picasa"
 => true 
1.9.3-p194 :003 > $LOAD_PATH.grep /picasa/
 => ["/home/wojtek/.rvm/gems/ruby-1.9.3-p194/gems/picasa-0.5.0/lib"]
```

Please, revert all `./picasa` changes
missing comma!!! GLOBAL LEAK!!
This should be relative, i.e. `js/jcarousel....`
Adjust the indent for this code block then you are :ok_hand:
Should this be more than just in the console?  Maybe we want something in the page or an alert?
Might it be possible to just add this stuff right to `layouts/editor-area.html` or `layouts/trackevent-editor-defaults.html`? In the former case, we could just assume that all editors have a title that can become a breadcrumbs-enabled title.
Wrap this is a try catch so when IE9 barfs on this it doesn't crash.
Yes - but either way I couldn't face using such a horrid class name :(
I wanted to do a render_to_string in the after_filter but kept getting bizarre errors whenever I tried doing that. This is a hack to workaround my inability to get the view html within the after_filter.