labofsahil/github-event-dataset-2012 huggingface dataset:
Move this into the GaiaApp class to launch the specific app off the app provided in that class.
let's rename count here to be `expected_count` , then it hsa the value we expect in the assertion on line #45
Add newline (and configure editor to automatically ensure there is.
but that is not the case if you call the function, at least it looks like it will force handler there.
Please remove parentheses since there are no any arguments here.
Typically, the convention I follow is to use $ for variables that store jQuery objects, and name functions _usually_ as an action (getFoo, findFoo, etc.). I hadn't considered naming functions with a prepended $. Hmm. 

Looking below, at the usage, it does make some sense...
а он тут нужен? свой ответ объясни
Same comment as above too.
I am not sure this is the right thing to do here.

In any case, this could be probably solved mathematically rather than iteratively.
Why u no thread?!
should be emitUnicode
Why 3 config file and not a single one ? What should go in /etc/sysconfig/openshift-cgroups and that would not go in /etc/stickshift/resource_limits.conf ?
That just looks like a strange line, but I guess as long as it renders correctly then it's okay.
I thought about that before too, but then I didn't think it would be a good idea because the function signature would change based on the presence of this config. So, if someone changes this option later, he'll need to review and fix all affected usages. Make sense?
done ;-) Thanks for that file!
Yes, the check is now located in the ContentAPI along with all the other checks.
As far as I can tell it's currently not possible to link to these except for writing the url yourself. Could you add a `#` to the right of the title, same style as the admin UI.
Changed to `return a.config.title > b.config.title`
What is returned when this operation fails?
Perhaps this can be split out into a module.exports.getPrincipals function
Wouldn't it be better to keep two separate endpoints?
I think we can assume that all files will be json files.
Because it's based on Java Search, and `ScalaSelectionEngine`, which is pretty opaque. It assumes having the Java counterpart everywhere, so I couldn't port it to something more abstract. We need to get rid of the selection engine eventually, but right now I wanted to make the minimal set of changes to move forward.
Definitely mention in the list of topics. You can state ...
- Using targeted, single value, and multi-valued vocabularies
According to the doc, OIOREST is better but.. it doesn't really matter. Either fix the class name, or the line you added in the README ;)
You're right but I didn't wanted to pollute the namespace with a MaxMindAbstract class. What do you think @willdurand ?
Wat doet dit?
Use `===` here, just in case of a zero, empty string, etc.
Could do the same for lines 850, 855 although it wouldn't matter there.
Вот я тоже так думаю, [self init] тут логичнее применять.
K, fixed: https://github.com/avalanche123/Imagine/pull/185 :-). Thanks.
Cross-references should use the [xref tag](http://xml.resource.org/authoring/draft-mrose-writing-rfcs.html#xref).
Also, default timeout of 30 seconds is fine, 15 seconds is too short for the legacy backend systems we sometimes have to integrate with. If anything it'd be good to increase this...
g.should include(Date.today)
should use `#image_with_fallback`
Ditto - ```.should_not be_nil```
This makes the whole branch a no-op. If that's the intention maybe just remove it?
Oops, my IDE autoformater fooled me here...
I'd prefer standard error because that's backward compatible with what MNE computed, but I'm fine to change it since it just differs by a sqrt(evoked.nave).
Also, if a list, does the list of stcs and the list of labels have to be the same length (seems this way based on the return docstring)? Or will the return value be n_stcs x n_labels in size? If they have to match, we should specify this...
Can you add  assertNotNull(Context.getService(atdServiceClass)) and assertNotNull(Context.getService(dssServiceClass))?
I don't think we want to do this. Validation should be already done in the manual flush mode. If there were places where it failed, it means a validator was used directly, whereas ValidationUtil should have been used instead.
Find an example command which also has arguments. Hint: "uname -a"
Also, can we ditch this extra epsilon? No need to have it imo, and it just makes for extra stuff to do.
Why do you have a different class for OneBestSemiringViterbi? Isn't the idea to only have to write this code once?
You can access the form factory either via a global variable or by using DICs.
Imagine that you want to query for products which cost more than 19.99, ordered....
Is it possible to add a link to *the form Field Type*?
I'm going to want to keep these type of manually-added comments. So either you should keep them, or I'll add them back :). I realize that this can't be done automatically, and I think that's ok - we shouldn't need to do a wholesale re-export like this very often.
@richardmiller I think I reduced my example a bit to much. I mean this:

    $request = new Request(
        $_GET,
        $_POST,
        array(),
        $_COOKIE,
        $_FILES,
        $_SERVER
    );

The last parenthese is on the wrong line.
That's a good point. I made the change.
I've answered this.
should be $this->_deleteParams
I would either move this up to `Garden.where(category: learn_more).all.each`, or into a select statement

```
Garden.all.select {|g| g.learn_more =~ /#{garden.category}/i}.each do |garden|
```
"^" could be omitted and re.match used instead
Personally, I'm happy to drop the command-names, and bump the version to 0.6.0, they were nice for early stuff, but integer values make more sense from an i18n sense.
this looks good for now, I want to store this data in the DB in a PG array eventually so we can actually run metrics on which of our triag-ers are active.
I don't think returning a value is necessary here. It's harmless to return a reference at this point.
The title name should reflect the difference between this scenario and the one above. Maybe "Show default Page Presenter when specified"
Tässä olisi kauniinpaa, ja tehokkaampaa, käyttää aiemmin koodattua `singleton?` predikaattia.
This is a tricky. Kinda wished we didn't extend CacheSupport in the client, cos it's hindering things more than saving us writing code. We should have implemented BasicCache instead :(. We can't really change it now in case anyone has coded againts CacheSupport.

There could some confusion here from the fact that the protocol diverges from the client API. The protocol says lifespan=0 is unlimited, whereas the client API (Cache.put(...)) says that negative values are treated as unlimited. There's no mention of what 0 as value means...

If we're making specific assumptions of what lifespan=0 means for RemoteCaches, we need to override the method in RemoteCache interface and document it accordingly. I guess negative values would still be treated as 0 in the protocol (unlimited), and 0 would be treated as DEFAULT* flag.
InequalVersionComparisonResult ? That is indeed a weird name. Should probably call it VersionComparisonResult, but not in this fat PR :)
I presume it's ok to assume "ar" is installed?
I took another look, and you are right, it really can't be refactored, I don't think.  At the least, maybe add some comments in each spot pointing out the other's similar logic?  There was a problem a year ago where someone made some fixes to the histogram function for one of the inputs, but then completely missed the almost identical logic for another input parameter elsewhere in the function.  So I ended up adding comments so that future maintainers know that if they make a change in this one spot, then they will likely need to make a change in the other spot as well.
Me too. It was a simple copy&paste and I forgot to update this part. But this file needs a style overhaul in any way. See the 2 blank indentation.
Excellent assertions
@gsilver Can we provide a valid `alt` attribute in here?
`it` should probably be reworded to `your items` or `your content` as below in the 'REMOVING_CONTENT` key.
@apex13 it seems like we're seeing an unnecessary change here, can you double check the line ending settings?
@christianv Christian unless I missed something, shouldn't `Asia` go before `Atlantic`? http://www.ngfl-cymru.org.uk/vtc/ngfl/ngfl-flash/alphabet-eng/alphabet.htm
Agreed, it should be concrete. We discussed this at the conference and I was under the impression that it was part of your refactoring staged for 1.5, I was trying not to redo that work. Is refactoring this class really necessary for 1.4?
Yep, 4 different entwine blocks - they are not strictly "calls", not different from normal event handler closures anyway. This is similar to what you currently have in terms of the amount of closures.

Also have spoken with Hamish and there is yet another advantage: we can control the ordering of the entwine handlers with this._super() calls if we get clashes with the original TabSet (I don't think we will now, but maybe in the future). You can't have this kind of control with regular `this.on`.
please don't change the file permissions (here and for the phpunit config)
Ah, I see. I'll need to reword it slightly if we're asking users to remove and reinstall every time, since 4.5.0 was still on the same package id.
What is the point of this interface?
IIRC I just copy/pasted from somewhere else. I'll check on that and get back to you.
You mean because of the ``using "array"``?
This class is not autoloadable using a PSR-0 autoloader. If you would like it to be loadable, it should be in the sub-path "ZendTest/Session/SaveHandler/MongoDBOptionsTest.php".
Could you add a ``@return`` annotation? I found this a couple of more times on lines: 21, 22, 23, 25, 26.
@denniskeefe - You can probably remove this file, too, since it does nothing.  Also, I'd recommend using RSpec from #5 instead of Test::Unit, but that's more of a question for @beverlynelson or @jameswritescode.
Maybe try this instead:

```
assert_equal CloneWar.new.war?, false
```
Não achas que os preços são muito elevados? :P
I've never used `--soft`, wouldn't this combo have the same effect as `--hard`?
Can you move all this to backends? So all this backend-specific checks to some method there, which returns true if image url can be given. And then another method which gives it?
Add TODO to remove alert. (We should push new comments automatically.)
Name argument better. We know it is an element. But it is anything more maybe? An input?
What you want to achieve? Override what?
Semicolon at the end!
Please format it as a comment, with some text explaining that it is a comment and what it does.
Yes. And it is even more awful now. Enjoy.
There is nothing better to use for `username`? Spaces around `+`.
Ehm, better name for this data could be useful. What posts have? `post?` Then `notification` here?
Well, why would you go back to the form, when you just change it, I think it is fine like that. You get redirected to your profile page to view the changes you have done.
It's precisely not a leak in the sense you are attempting to portray. The first 23 are necessary for HTML5 elements to work in oldIE: abbr, article, aside, audio, bdi, canvas, data, datalist, details, figcaption, figure, footer, header, hgroup, mark, meter, nav, output, progress, section, summary, time, video. The remaining nodes are those created by `shimCloneNode()` under _very_ specific circumstances eg. oldIE cloning a detached, "unknown" element (any of the HTML5 elements).

The first set of results is ~550 tests and produces 27 nodes, the second is a little less then 6000 tests of varying DOM related tasks that produces only 9 more nodes.
Exactly... `div` will get removed, but the wrapper elements required in special cases will still be left hanging around, and that's the entire complaint of http://bugs.jquery.com/ticket/11356.
Would it make more sense to just remove the throw
아래 한번 봐보세영
https://github.com/aanoaa/p5-hubot/issues/17

@am0c 군의 패치에 대해서 제가 다시 수정하고 싶은데 그러긴 어렵네영
긔냥 말로 때울거라능
My previous comment still apply: what about queries without a WHERE clause ?
"to" -> "two" or "the"?

Also, remove the second sentence and extend the first one saying that it's the default behaviour.
damit bin ich nicht zufrieden. Ich denke Daten aus der Bearbeitung sollten sauber abgetrennt werden. Vorschläge?
i loled :)
Interesting, I don't see ppl on ctan either. pxfonts is likely similar enough. Do you know what font requirements, if any, the grad school has?
Потенциальный race condition.
self.clients может измениться если в этот момент произойдет переключение потока и придет quit от другого подключенного клиента
you should only do this if someone requested the prio to be set via -p.

you should check the return value and noitL(noit_error...) in the event of failure.
It still looks a little strange to me, but I can't think of anything better. I prefer what you have now to something that passes ownership only some of the time.
debugging code?
What's with all the commented code here? Shouldn't it be removed if it isn't used anymore?
I don't think that 'branch' should be used. It's not guaranteed to give you one.
Is this for binary endog only ?
блин, это ужасно. это можно отключить? иначе придется во все доки вписывать
Lines here have been made longer than 120 characters. Consider using the code formatting guidelines, documented here: https://developer.connectopensource.org/display/CONNECTWIKI/Coding+templates+and+formatters

CI checks for formatting violations.
Just curious, why does the externalrefid live on the PurchaseRequest (and not the profile)?
The 'word_def' variable is not changed by this statement.
No, you did not delete it. It was added to the main repository after you forked it so when we merge you overwrite. There are more lines like this.
Would be better solved by ensuring you are only stripping attributes occring inside an element

var content ='<x sizcache23434="x" xcv="z" nodeIndex="z">';
var replaced = content;
while ( content != (replaced = content.replace(/(<[^>]*)(nodeIndex|sizcache|sizset)[\w\d]*(="[^"]*")*/, '$1'))) {
    content = replaced;
}
return content;
Old comment, will update.
Could we include in the message what was not found (e.g. which entity types, and which locations)?
Or make it an inner class? Is it just there to get the static code to execute? Hmmm...
Same here (for braces). Is space escaping still required in Augeas 0.10.0?
hopefully not needed
What are you implying when you have the user re-subscribe yearly on **04/01/12**?

* Does this demonstrate that the user can have a lapse of time?
* Does this imply that the user can subscribe yearly only on the first day of the month?
The full paths should be replaced with %s
I was actually expecting to see them all in one file, but they are spread around in the files they are thrown it seems.. so I kept that convention..

I don't think one file per-exception makes whole lot of sense.. I'd rather group them all together for simplicity, but I didn't want to do any refactoring at this stage.. maybe for 1.3.1?
I've created a ticket to fix this for 1.3.1 (support strings)
PHP_MONGO_GET_CURSOR() already does this check
Not used, taking out
What's up with these dashes after `@todo`s? I see them elsewhere in this PR but they are unnecessary.
![dashes](http://cdn.memegenerator.net/instances/400x/31459275.jpg)
Since you have a `use` statement for this above, you can use do `@throws ObjectNotFoundException`.
Updated to use a `do...end` block.
Well, it does *something*, but nothing useful. From debugging it, `instance` has useful info that goes away when you new up that error.
Строка может быть пустой.
caches_page causes html files to be written to public, and bypasses all filters (including authentication). That breaks our app, which needs a different version of the index for each user. caches_action is the right way to cache here.
Actually not.  Good catch!
Ha... thanks so much! I have not been following this section of the code so I was aware of what changes have been made recently.
Will we run this on other environments? If so, we may need this to be an argument, but this could be the default value.
this **supports**
This set of logic calls the function if it's available. Otherwise it falls back to the default behavior.
separable -> linearly separable
To stay consistent with our class naming scheme, shouldn't this be called `FactorAnalyzer`? (I admit that that's uglier.)
I am always a bit hesitant when I see a parameter (i.e. a variable without an underscore at the end) modified in the fit. Maybe we should use a local variable to the fit, rather than modify the attribute.
If there is no _trick_ that allows you to get the transformed value while fitting for free, there is no use in defining this implementation. The naive `fit_transform` as sequence of `self.fit` and `self.transform` is already defined in `TransformerMixin`.
A concept for kernel should be added. It should certainly implies CopyConstructible, Assignable ?
Use `.on` instead of `.bind`! jQuery will deprecate bind, delegate etc. in favor of the unified `.on` and `.off`
Let's be explicit about the string conversion to qstring:  Do this" `QString strValue = QString::fromUtf8(cstrValue)`; same for strKey

FYI: cstr* pointers are not necessary steps
Methods are named using camelCase.
We should also pass adb as an argument if we are going to use it here.
French vs English words :s
I think already protected, spillRows() always called within lock,
e.g. : CThorSpillableRowArray::CThorSpillableRowArrayLock block(spillableRows)

I'll add comment to spillRows() to note that is should/is
This if test is redundant (and therefore slightly confusing)
I noticed when compiling with legacy enabled that errors in OTHER ecl files in the same directory caused errors in unrelated files.
Add

```python
eq_(response.status_code, 200)
```

In fact, we should have this on all like this. 
Otherwise we might do the `ok_(some string in response.content)` in an 400 Bad Request error message.
Why the `/?`?
Ithink it can be just `r'^status/$'`. Django will automatically redirect from `/status` to `/status/`.
no need for a bracket
I think we should keep this, with some sensible default, unless it causes problems.
Might want a test to show that this doesn't do the above
This one should have been "secondary" or even better, "discrete video card".
mongonaut looks for mongoadmin.py
my bad , forgot to delete
@shacker We shouldn't have inline styles.
We already have a clearfix class that should be able to perform this functionality.

`<br class="clearfix" />`
Marked as deprecated here (so you can see it on rake -T) and in Readme.MD. I'll go refactor this afterwards.
As for the usefulness of this behaviour: In my experience, all references of the type you mentioned in you comment to the icons are not necessary and could be removed. But who am I to argue with Visual Studio ;-)
`(= name (:name x))` palauttaa booleanin sellaisenaan
I'm not sure what this is for so please put in a comment.
This will fail on our set up - jQuery is not loaded in at this stage in the page so it will error. This could be fixed using a similar technique to Google Analytics (in async mode) where you collect up goals through the page and trigger them when the JavaScript is loaded - a rough outline of what I mean:

```javascript
// In goal template tag
goal_triggers = goal_triggers || [];
goal_triggers.push('{{ goal_name }}');

// In experiments JS
$(function() {
// ...

    var triggerGoal = function(goal_name) {
        $(experiments).trigger('goal', [goal_name]);
    };

    $.each(goal_triggers, function() {
        triggerGoal(this);
    });

    goal_triggers = {
        push: triggerGoal
    };

// ...
});
```

but that's quite a lot of code for something relatively simple (and it creates another variable in the global context).

Either way it would be nice to be able to turn this on or off globally with a setting.
This is actually unnecessary. If you pass it any invalid index it will return out of the sort and not sort it. So passing -1 would have done the same thing anyways.
We have added the line in the README.rdoc
prolly should update the description for the new functionality
I did it actually see 39f5a22 in this PR :)
require in `Core/defaultValue`, and do `deep = defaultValue(deep, true)` (similar with the other parameters).  That helper was a recent addition so it probably didn't exist yet when you wrote this.
This isn't nitpicking, it's a good comment.  it used to be just `this.d` and that was confusing enough for me.  member variables should always be as descriptive as possible, `n` for `normal` and `d` for direction may make sense most of the time, but examples like this are a great reason to always spell things out.
The color mask is true or false per component, not actual color intensities.  Are we sure we want to use the `Color` type?
Should `_getPickRayPerspective` be private?
Although it's the same thing, just store the result of `getNumberOfImages`, and name things accordingly.
Hmm, if you mean that we could use toString() I'm not sure in this case. An ErrorRoute instance has both a Route and String which is the name of the attribute that will be added to the request before the request is forwarded to the view.  Wdyt?
How exactly would you change the message after calling show()? alert dialog is modal and should pause the app until the user clicks something, though that's not exactly true for mobile web. I highly doubt ios or android update the contents of the alert dialog as it's being displayed.
len and i should be initialized above in the variable declaration.
Windows paths?
this short-circuits the logic in TextField. The _updateHint method is the only method that should change the value of showingHint.
This looks unused. Can the dependency be removed?
Охохо. А поменьше плагина не было?
Might want to add a `void` initializer here for performance reasons – `peek` and `get` are likely to be called in performance-sensitive I/O code.
In general, variables should be restricted to the minimal scope possible. It reduces the odds of misusing them, and makes it clearer what they pertain to (and if they hold resources, then those resources will be released that much more quickly - especially if the type is on the stack with a destructor rather than living on the GC heap). So, in general, declaring a variable inside a for loop is preferred when it does not need to exist outside of that for loop. In this particular case, the scope that the for loop is in terminates immediately after the loop, so there isn't much impact, but that's often not the case. So stylistically, I'm very much in favor of putting the variable inside the loop, but its impact here is minimal, so it's up to you.

By the way, I'd advise using `immutable` rather than `auto` in cases like this one, because then the compiler knows that the variable won't change and is more like to be able to optimize stuff relating to it (particularly since it's an integral type and definitely won't have problems being `immutable`, unlike many user-defined types). However, given that the only place that `len` is used is the loop's condition, it will likely have zero impact here. It's still a good habit to get into though IMHO.
`= null` is missing here I guess. ;)
same as above...use 0.11.9
But EDBObjects are the main information units of the EDB (located in the edb-api) so they are known in publicity
you're kidding me, aren't you?
I don't know, but wouldn't it be better to let the Thread sleep for a short period if the service isn't available? Or will this block something? Don't know how long it normally takes until the service is available normally. Maybe it could also be interesting to set a maximum number of tries?
ohh sorry, I was just using it to debug. I should have deleted that line.

On Mon, Apr 16, 2012 at 3:31 AM, Christoph Buchner <
reply@reply.github.com
> wrote:

> > @@ -246,7 +248,12 @@ void testApp::createAndOpenPressed(bool & pressed){
> >  }
> >
> >  void testApp::changeOFRootPressed(bool & pressed){
> > -     if(!pressed) askOFRoot();
> > +     if(!pressed){
> > +             askOFRoot();
> > +             cout << getOFRootFromConfig()<<endl;
>
> would be great if you used ofLog here instead of cout. :-)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openframeworks/openFrameworks/pull/1177/files#r686977
>



-- 
*Roy Macdonald*
8-248 8478
@arturoc why this change from GL_DEPTH24_STENCIL8_OES to GL_DEPTH_STENCIL_OES ?

this is what broke iOS when I merged your PR - making it impossible for depth attachments in renderBuffer mode 
does android need this?
I used to have to copy the file around and it was easier. Since this is just an ad-hoc test app that is not related to our real tests, I figured it'd do no harm.
Could we get rid of this field here or existing code will break if we do? Since we don't use it anyway and now we replaced with a new one.
i think we default all other listeners to false
first try new method then the old. Or should it be the other way around?
Why are we changing the design around this ? Is there any advantage on doing this ?
Grrr... missed this merge!  is not fatal - will be fixed in next pull.
The ",SHA-1" should have been "SHA-1". There is a comma before SHA-1 is the corrupt portion, there is an error in the name rather than hash, the next test is for an error in hash. Not sure why it is failing on your machine
Generally if the order doesn't actually matter I prefer to use `set` rather than `sorted` for these comparisons. In either case it would be preferable if the assertion's success weren't dependent on the variable set at the top of the method being in already-sorted order (that's a non-obvious dependence that someone editing the test later could easily break accidentally), so `set` or `sorted` should be used on both sides of the assertion.
The parameter definitions here and in the `setDataOnContent` function below are backwards, it should be

```javascript
@param {Array} filesArray
```

http://code.google.com/p/jsdoc-toolkit/wiki/TagParam
Thanks for reminding this one.
here and a few lines below you are checking for an instance of TemporaryQueue, but the behavior that you are trying to bypass in the core CCF would be the same for TemporaryTopic instances as well
The reasons for using "FOR UPDATE" is primarily for use-cases where pollers are configured with task executors and thus multiple parallel threads may be hitting the database. The goal has been to prevent the polling of duplicated messages. 

If users are 100% certain that polling will occur with 1 single thread only, they they could leave off the "FOR UPDATE". 

Maybe you can provide some additional information - For which isolation levels do you see problems specifically? 

Also, we made some minor improvements to class **MessageGroupQueue** when executing the **size()** method:

* https://jira.springsource.org/browse/INT-2826

The goal is to reduce the amount of executions of the **size()** method when the channel has an infinite capacity. I experienced some locking issues with Derby in that regard.

Overall, we also added a few links to the reference documentation, explaining that generally, using a DB as a queue is problematic and a messaging solution such as JMS or RabbitMQ may be preferable.
Looks like your rebase missed this.
Not everybody defines their URLs with .:format at the end. Some would even argue that one should use the Accept header instead. Either way, it's not a good idea for include .:format for everyone. You can add it to your specs if you want to use it.
The above shouldn't be needed, it's already done in preferreedSizeOfLayer:, right?
rename `InvalidReceipt` to `InvalidReceiptException`
can you please use table of content for this? http://docutils.sourceforge.net/docs/ref/rst/directives.html#table-of-contents
Same comment as above. This page looks obsolete with the reorganisation of the developers TOC. 
Can we simply remove it?
Please revert this removal
ok added the missing file .. but honestly i am not sure how this entire event subscriber thing works and how needs to be configured properly in https://github.com/sonata-project/SonataCacheBundle/pull/24/files#L2R108

i havent tested this part yet ..
And this is a `error` inside our platform. This should be controlled by us. If this cannot parse a JSON, that means we have injected a bad JSON inside the MongoDB or Queues
Missing @return tag and I think we usually wrap 'true' and 'false' in {@code true} resp. {@code false}
this is what we do. we loop over the children of this node and store them, unless they are not new (i can move an existing node to under a newly created node. the new node has to be stored, but the moved node only needs to be moved and may not be created again)
de tenter de les développer
ahh, I thought this sentence is missing something ;-)
Hum... Bacana :)
my only suggestion/question is that this stub is stubbing out both the initial scan and the manager secondary lookup.  I personally would like to see two separate stubs so that we can distinguish the "employee" from the "manager"
Backward compat is pretty much already broken...

I also noticed a bug (that I fixed in this branch): the feature name => feature id mapping is not necessarily the same for two consecutive calls to `fit`.
Will changing the model screw things up? I'm of a mind to leave things as is at the moment.
Ok here because cancan only load the resources if it is not already initialized.
In this case, the initialization is not trivial, so you need to do it yourself.
+1 for the ref to the forum, thanks!
The other code accesses this, so I think this fullSync and SINCE check should be kicked back up a level to the caller.
@asutherland Here, I'm not sure what the best way is to tell the slice about headers we already know about. IMAP manages this because it grabs all the headers so that it can match things up, but we don't really need to do that, and it wouldn't quite work anyway.

Specifically, while we could grab the known headers and then merge them with the new/changed/deleted ones, that would only work if the known headers we got were *all* the headers in that folder. Since ActiveSync gives us updates on all headers - not just those in the date range the `FolderStorage` cares about - we'd run into issues when getting changed/deleted notifications for headers outside our expected date range (this is why I need `updateMessageHeaderByUid`).
Lazy modification sounds like a great idea for deletions, and possibly modifications too if it is too much work to find the date-stamp associated with the message.  I think since your deltas are explicit deltas, that could actually work out reasonably well.
Don't use the keyword "undefined" directly because it eats up space. Instead, use the variable undef which is defined explicitly for this purpose.
I think :require => 'reputation_system' is optional and it shouldn't be in README. Can you remove this for me?
Didn't know about setting the same id on all footer for it to work like persistant.
this look like leftover debug code? (the puts)
probably should not remove the super call... that's what enables easy extensibility (otherwise there's no point subclassing the AbstractSimpleBeanDefinitionParser).
What is the expected behavior when delete-per-row is set to true? Here as i can see it will work only if the result is an entity itself and not a collection of entities. I expected it to iterate though the collection if it is one and then invoke delete on individual entities. Am i missing something?
Oh, yeah, sorry about that...
can we do a #define for this value somewhere so it is easily changable later?
You actually don't need to check its type before Array.isArray but this is a nitpick
all files in the ext/ folder are copied into the build so even though you are manually copying it, because its a part of the ext folder it will get copied through build/build/pack.js
I have tones of other updates anyways for automated tests that are going with this so I will rearrange and just change it.
If you already have a section object, you should use `section.add_item` instead.
You were supposed to use only one comparison with three arguments. No points from this one.
закоментированный большой блок
IMO you can call them just "widgets" instead of "view widgets"... and as this is a documentation for them there is no need to write that "they have not been that well documented before" because the user is just reading the documentation for them