labofsahil/github-event-dataset-2012 huggingface dataset:
hi. i know it's good to ask for the existence of a variable ($ini->hasVariable() ). but, can't we suppose that this variable will always be present as long as is included in the audit.ini provided by a ez publish installation? 
there are more like this in other classes... dunno if we can do less operations if we think that these variables will always be present...

all the ez publish developers are well told about do not touch "anything" in the provided code, so... well, that variable will always be there...
"support"
I think this should be ```4. Create a symbolic link to uWSGI in $SERVER/sagecell:``` if ```./sagecell``` is supposed to be a subdirectory.
Creo que Flojo de trabajo también debería tener dos ##
I'm not sure what "extension" you are referring to Denis. whether you're using Velocity in wiki pages or as a templating language outside of XWiki the best practices stays the same IMO and you should probably provide a higher level Java API to be used in your Velocity code.

BTW I'm not asking to remove that collectiontool Velocity Tool. I'm just saying we're opening the door to something that can and will be abused and I'm asking that we don't use it ourselves. Said differently I'd like to see the use cases where we'll want to use it since I'm pretty sure they can be replaced by a better implementation in the majority if not all cases.
Wow, could have probably come across a little friendlier there, Phil!
Please also delete my custom image from the images folder.
Take a look at PocketIO::Pool::Redis and example chat using Redis backend.
mk.bat packs into .zip, not .7z
Please try once again, just pushed another fix to master.
(User.instance ~ Permission.instance *).map( _.groupBy(_._1).toSeq.map {
case (u,ps) => u.copy( permissions = ps.map(_._2)) } )

On Fri, Jan 6, 2012 at 3:24 PM, recalcitrant <
reply@reply.github.com
> wrote:

> Gee, thanks, it's getting near the final result.
>
> Your solution returns:
>
> ResultSetParser[scala.collection.immutable.Map[models.auth.User,List[models.auth.Permission]]]
>
> So I'll probably need one last map-operation to get the final User with
> it's permissions out of it.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/playframework/Play20/commit/f35fd305d98038ab0fe3f8076368ee7f8d90015b#commitcomment-843785
>



-- 
www.sadekdrobi.com
ʎdoɹʇuǝ
This is equivalent to saying `lastActive = activeChat || undefined;`
Not able to reproduce. Count clears for me every time. This is back on commit `f0cdf`.
Need steps to reproduce.
I actually use tab. In the next framework version I'll work with code
sniffer and probably we will use Symfony 2 or Zend 2 coding
convention!

Sent from my iPhone
`{end: false}` => `{ end: false }`
The diff view is really confusing here. I just thought: "Why the heck does SammysHP leave an empty file here?", then scrolled up and saw that the file is indeed deleted, not empty...
This TODO list is nice, but it will be better if we can use github issues page.  That way I can respond to them easily.
It would be helpful to have an actual interface to this code so we could see how it makes sense to use it and the determine if we need the defaults on the client side or if we can just get away with letting the server fill them in.
Shouldn't this be jbuid?
This migration should go in a seed file?
This code will upgrade existing instances of moonmoon from md5 to sha256 when they upgrade.
Remove one whitespace in comment
looks good, passed review
It's going to be complicated to restore throwing TransientObjectException when merging with CHECK_NULLABILITY set to true. I don't think it's worth the trouble, especially since it probably shouldn't have been changed from PropertyValueException in the first place.

Instead, When CHECK_NULLABILITY is true:
1) save/persist/merge event listeners will throw PropertyValueException;

When CHECK_NULLABILITY is false:
1) if the entity insert action is executed before the session is flushed (i.e., an "early" insert to generate an identity ID), then JDBCException is thrown;
2) otherwise, TransientObjectException is thrown when the owning entity is dirty-checked.
no he ido aun :S, que algun gm que use mana vaya y lo mire en 1 min jajaja
안녕하세요 저 1학년 1반 4번 경규성입니다.
제가 집에서 파일에디티가 왜 안돼는지는 
모르겠는데ㅠㅠ 안돼서 댓글로 수정한것을 보여줘도 돼요?
Spaces: See [here](https://github.com/mongodb/mongo/blob/master/rpm/init.d-mongod#L25-26) and [here](https://github.com/mongodb/mongo/blob/master/rpm/mongod.conf#L3-13) for examples of where this is used and not consistent.

Allcaps - that's more of a convention than requirement, since many *nix config files are sourced by another script, it makes it easier to identify a variable. It's pretty standard across many packages etc. And you're right, it might be something more for a JIRA than a doc update.
move to utility library
And is it the same behaviour with players?
I've never seen anyone in PvP videos interrupting spells by getting out of LoS
Tu usas el modúlo `log`, lo cual no es `verbose` en la consola... Pero claro, habra que cambiarlo.
Using reduce which takes a function of 2 arguments and applies this function to the pairs of consecutive elements in the list
Using intrinsic sync is error prone
looks good. I should review it twice to be sure to understand how does it work
这里`username`需要escape，不然会有SQL注入
yes, but I cant create "values-sk" in folder "res". Please, can you create it?
But the document.ready block only gets done once, when the page loads. After that, no pages are loaded. I'm talking about when the planets are clicked, if there is some sort of error with the page, it shouldn't zoom in.
Technically, the description of this push is incorrect... the jquery clears whatever is in the <ul> 'after' the db call loads, but before it appends the new html to the DOM.
I assume vendor_samsung will be coming along shortly to the organization.
What about it? The fact that it's using HTML 5 tags without the closed bracket?
I think that's good enough.  I just added added a new page (ee16fbc270c9327efada36b2bdb659eb757cb569) and linked to the page from editorconfig command man page (5b254f8d4036926fe44ddd2633fe88ff42c5e2c8).  I haven't figured out how to link to the page from `editorconfig.h` man page yet.
not pep8
aww I loved the simplicity of this line
was haltet ihr davon? so ist es für die admins viel leichter, kleinigkeiten zu ändern. 

Man kann die datenbank natürlich beliebig erweitern und noch vieles mehr veränderbar machen...

ich habe jetzt ja auch spalten für das logo und die unterschrift, habe sie jetzt allerdings noch nicht in die haml dateien eingefügt, da das logo im css definiert wird und die unterschrift unterm logo aus irgendeinem grund entzweigeteilt ist...
If you care to alter this commit, look at the work done in https://github.com/gggeek/ezcontentstaging/commit/dc07814ff6a17cb8e704f9b292b0eeabcf7e82b1 : by wrapping the call to request->getBody() vs. request->inputVariables in a separate method, we can insure that
a. the gg version is compatible with ezp 4.7
b. the gg and ez versions diverge as little as possible
This returns garbage if no error occurs! Compiler warning:

dmc -c -Iroot;\dm\include   -D -g -DUNITTEST -cpp  expression
Expression *BinAssignExp::commonSemanticAssign(Scope *sc)
         ^
expression.c(5851) : Warning 18: implied return of BinExp::incompatibleTypes at
closing '}' does not return value
rosszul hivatkoztam a commit azonosítóra. helyesen: 79674a28
Just so that everyone knows, this is due to the new version of AllPay. We deprecated pay in favor of give. The new ones are `give` and `take` which make more sense.
In this commit.
This is breaking build on my end.
Perhaps we can check for the existence of each attribute before using it and use whichever exists?

My current laptop can't even run OpenCL so I can't test this right now... any volunteers? :)
Can you please elaborate? What version of Mac and please attach a screenshot on the issue tracker.

But first, can you please clear your cache and test agian?

Thanks.
If that's the case, can you do:

this.getClass().getSimpleName()
Yeah, I wanted to avoid that, as the value must not be set on `element` at all times… In the case of a text input clone of a password inputs, the real password element should get the value.
Yea that might be useful. I removed the as err because it doesn't pass the pyflakes test and was not used. if you want to add a warning, go ahead.
Not really original man.
@cjmaclellan 

use this relative path
for the FEM mesh

submit from the hopspack directory
No worries on delays.  Letting both work should be fine.  I would prefer if one was chosen as the "right" way though.  Then for the "wrong"/deprecated way it should still work but print a warning.  In general that is the pattern fog has followed.  I like that this leaves one recommended way, which makes it easier to document and explain, and it also gives us the ability to remove the old way in the future.  Does that make sense?
PEP8 violation.
So we need to be careful here.
MatCreateSeqAIJWithArrays does /not/ copy the arrays

but
MatCreateMPIAIJWithArrays does copy the arrays.

So garbage collection will be a bit wierd.
My argument was that they should be different functions, instead of overloading a single function, and that once you split them up, you'll notice that one of the branches is never hit.  I don't see what that has to do with idempotence.
Ok. I thought it was best to use it for >=1. Shall I remove it?
Needs a metric tonne of docs
If this throws then the files won't be deleted (below=
On 2012/06/07 10:48 AM, patriknw wrote:
>> +     */
>> +    @Override
>> +    protected void engineNextBytes(byte[] bytes) {
>> +        rng.nextBytes(bytes);
>> +    }
>> +
>> +    /**
>> +     * Returns the given number of seed bytes.  This call may be used to
>> +     * seed other random number generators.
>> +     *
>> +     * @param numBytes the number of seed bytes to generate.
>> +     * @return the seed bytes.
>> +     */
>> +    @Override
>> +    protected byte[] engineGenerateSeed(int numBytes) {
>> +        return (new SecureRandom()).generateSeed(numBytes);
> how often is this invoked?
> has it been tested on linux (the blocking issue we discussed previously)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/akka/akka/pull/476/files#r942174
It is never called
Yes, I don't want the backoff, because it wastes a crapload of time.
could you send yourself a message instead?
I wanted to group 0 with Marker because they conceptually are similar (last was ACKed explicitly or implicitly); you are right that handling 0 there is not really needed logic-wise.
This didn't work out in field test, and when thinking on it we are mixing two different things here. I think we have two alternatives
1. notify listeners when there is a *change* in convergence, but then it's more like a ConvergenceChangeListener, which should pass the Gossip to the listener
2. notify the listeners when there is a *change* in members, including there status

I'm playing with number 2 now. WDYT?
Why is 0 a special case here? How does it differ from "case n => ..."?
Done and merged, pushed soon.
You could simplify this considerably (which helps maintenance) by using wildcards:

    Files: <<
      etc/dpkg/shlibs.override
      bin/dpkg-*
      share/locale/*/LC_MESSAGES/dpkg-dev.mo
      share/man/man1/dpkg-*.1
      share/man/man5/deb*.1
   <<
Okay we need to take some decisions on reconstructions and then I will RF this class. Sorry, I know it is super-ugly that this sits in the code like this at the moment.
is this really correct?
Oh, rats, those docstrings are just paste buffer garbage too :/

As for the help verbiage, agreed.  I actually whipped up this entire section last minute for the demo and really intended (as I think I noted during the demo) to redesign and re-implement it.  Actually, didn't intend to have it in the pull request but ... here we are.

Anyway, I used the term 'outstanding' but don't like it either.  Assuming I use different verbiage in description, can you suggest a better name for the section?  The intent is to search for and list bindings that have actions that have failed or are still pending.  Beyond that, I'm drawing a blank
Right, will change in a separate commit (probably after merge).
This doesn't make sense. When would hostname ever equal fhe full url??
Sorry, being nitpicky here, but isn't this "On Demand"?
Вот эта строчка была для того, чтобы plateNum вообще никогда не проставлялся. Теперь она работать не будет.
It seems sensible to me. If someone came along with a good use case, it'd probably have to be something where a given object would need to `respond_to?` some common convention, right? I don't know how else you could sensibly handle it, really. In that case it'd be a simple matter to add a `when` clause to the case statement @mauricio added to support that.

I like the clarification/definition of the semantics here otherwise.
No, that's a missing tab.
You can redirect output inside this function to /dev/null
please add a comment that this is required for Java
I think it's easy enough to just remove `|g` and have to specify the whole data as an argument to support all types.
Please add try catch block to reset default loader.
We'd have to do it for each use. Not worth the trouble, and slower.
Line is too long I believe.
When you're overriding from a trait, add the override keyword in front just to make this work well if we add/remove/rename methods in the trait. It's not obvious but we've tried to do this throughout the code.
just based on the diffs here, it looks like that maintaining old behavior would require not self.inputs.no_flatten to be False.  and if we don't have a default then there should be another check 

```
if isinstance(value, list) and isdefined(self.inputs.no_flatten) and not self.inputs.no_flatten:
    ...
```
Blank line ;)
What happens to the original new->c_metadata here?
Yeah, to be correct, I think elsewhere there needs to be a check if Python version is <2.5 in that case to check that `PyArray_DIMS` and `PyArray_STRIDES` fit `Py_ssize_t` (and possibly more?).
The `symbolizerField` - sorry for not making this clear in the first place.
To be clear: I am all for updating the output, but I see absolutely *no* reason to approve this pull request.  HTML5 give absolutely no benefit over what we already have.  HTML5 is not even finalized.  

My previous comment was a little harsh.  I meant it that way because I feel strongly about this, but I would like to say I do not intend for it to be argumentative.  I merely want to express my opinion without it being misunderstood.
No it is right. But `private` has the same indentation of the previous method. Everything bellow it is indented.
Perhaps we could cache the calls to `primary_key(from)`?
Not in this case. I think that now it is good to go. Thank you.
fetch use block too. We can use the conditional, but I just want to know why we need the delete.
TIP: You can save these settings in an +.rdebugrc+ file in your home directory. The debugger reads these global settings when it starts.
Yes, sorry for that. There was only one line in diff and I missed it.
I think we can just completely `rm` this test?
It shouldn't be necessary to convert them to symbols here.
For future reference, look at perRunCaches.newMap. I have a branch somewhere where I added a bunch of capabilities to the structures created that way, including lots of logging, so you could get something very similar to all the code above via
```
val synthetics = perRunCaches.newMap[Symbol,Tree]() loggingIf ( .... )
```
I'm getting a strange feeling of deja-vu. Didn't I comment on this before?
In any case, I wonder about the change in evaluation order of `tpe.typeSymbol`. I guess it only matters for type aliases, and I can't think of a way in which it could really _matter_. So let me just throw this out there.
Some technical remarks:

Instead of 

```
>>> Matrix._sympystr = Matrix.table
```

it is better to have a class method which switch printer method inside, Something like

```
>>> Matrix.print_as_table(parameters)
...
>>> Matrix.print_normal()
```
and in the Matrix:

```
def print_as_table(parameters):
    Matrix._parameters = parameters
    Matrix._sympystr = Matrix.table
```
You don't need brackets for `if`. Not that it is important, just looks better without the braces. Everywhere else.
One thing that's a little confusing in this file is that half of the functions are rules, and half of the functions generate rules (i.e., they return functions).
On 23.05.2012 05:27, Aaron Meurer wrote:
>> +
>> +    def submodule(self, *gens):
>> +        """
>> +        Generate a submodule.
>> +
>> +>>>  from sympy.abc import x
>> +>>>  from sympy import QQ
>> +>>>  M = QQ[x].free_module(2).submodule([x, 1])
>> +>>>  M.submodule([x**2, x])
>> +<[x**2, x]>
>> +        """
>> +        if not self.subset(gens):
>> +            raise ValueError('%s not a subset of %s' % (gens, self))
>> +        return self.__class__(gens, self.container)
>> +
>> +    def is_full_module(self):
>
> Should this be a @property?
>

I have been debating that. The reason I decided not to make these 
methods properties is that they can be very costly. But then again the 
same holds for equality comparison, which is done via ==.

If you think it's better to have them as properties I'll change it 
(since I have no strong preference either way).
Also in mater:

```python
>>> 1/( sin(x)/cos(x)) == cos(x)/sin(x)
True
>>> sin(x)/cos(x) == tan(x)
False
```
Mention here the reference [JoyOfCats] again.
I don't think you need the question mark.
That's sloppy of the vendor!
Should be a SimplePanel
Nice use of the chosen sprite. :p
I was thinking of it, but I didn't see a good example of how error reporting should work. I left it in as documentation of the allowed values.
This should have 4 spaces in front of it. Also the example below is indented with 2 spaces. Could you indent with 4 to keep consistent with other code examples? Thanks for the correction and addition!
This path needs updated, right?
This looks perfect.
I think we can skip this part altogether actually.  The down side is that the initial instrumenter stuff won't have this value, but by the time it gets to the error/response/retry instrumenter the value should already be available.  This also should cause the existing/expected connection logic to take care of needed rescue/retries/etc as needed.  Seems like that would be simpler, would it still be sufficient for your use case?
Can't guarantee an order while getWrappedModels returns an ordered set
don't use short hand like 2x.
Is there a case where the return value from this function is being used? Looks like some of the functions below doesn't have this behavior (i.e. return true if an update is done, false if not..) It would be nice if this was consistent across the functions...
Hum... 
What kind of thing do you want me to do?
I read the code, I read that post but I'm still wondering how to do that logic you are stating without the data from the DB.
null above, false here? Type hinting?
About 4: No, it's totally fine to use properties where they make sense. However, in this case, why does the following not work?
`$unlimited_reading_forums = $this->get_unlimited_reading_forums($in_fid_ary);`
Access type for interface method phpbb_notification_method_interface::empty_queue() must be omitted
Looking at this again, what extension acp test does is fine-ish it being a functional test.

But, error silencing is probably not ok. If the test requires a certain directory contents and removal fails, then quite surely you don't have the required contents as a result.
It doesn't seem to be just the name. Looks more like HTML.
Same comment here for mediumtext.
https://gist.github.com/2210546 unless I'm missing something ++ will require initialization.
If we change this so its like the posting page, I would be in favor of ordering the buttons just like they are on the posting page.
This is not correct. Consider:
```
TEST_QUEUES = {
    'default': {
        'HOST': 'host1',
        'PORT': 6379,
        'DB': 0,
    },
    'high': {
        'HOST': 'host2',
        'PORT': 6379,
        'DB': 0,
    }
}
```

Doing ``get_queues()`` will get both ``default`` and ``high`` queues on ``host1``, which is not correct; ``high`` queue should be on ``host2``.
for radians as a string as in `parseAngle('0.321512324')` or as in `parseAngle('0.321512341rad')`?
Means a new line was added
This does not seem to contain any running tests anymore. Can it be removed? If not then there are a lot of dead code that can
may be more readable to say
```
d = this.data.items[i].data;
if (d.batch !== null && d.batch != "" && d.quantity !== 0) { 
  // etc
} else {
  // etc
}
```
It'd be better for the latitude and longitude values to be different from each other. (e.g. `numpy.arange(12).reshape(3, 4)` and `numpy.arange(100, 112).reshape(3, 4)`)
Yes. In line 369.
use list comprehension like 

owners_t = ','.join(["%s %s" % (t.owner.first_name, t.owner.last_name) for t in i.ciownership_set.filter(type=1)])
Why import here ?
was it really necessary to change the whole file when you added only 2 lines ?
Sorry, I was looking at `riak_kv_put_fsm.erl`, bad Scott.
I'd like this better if were handled in the body instead of the condition: `value = jQuery( value ).not( this ).detach()`

That way we still detach elements in `value` that *aren't* in `this`, and avoid calling `jQuery( value )` twice.
If that's the case, it sounds like a bug in r.js...
`ret.splice( n--, 1 );`?
same for "temp", in the same algorithm block
I don't think we need "firstof" if we only have one variable.
Oh yes, I remember what was wrong, I was looking for percona folder, which I was deleting, but it would never create percona folder, it only can create mysql directory. Do I need to open new RP ?
okay, so regarding the functionality in this file. i admire the effort put into it :) but i think most of it actually isn't needed.

i understand the logic was to provide a powerful component creator in the sdk that takes into consideration existing components and tries to make sure there's no other component with the same id or version, and if there is, then it tries to increment the version and it has to do this with the help of a ``semver`` module that actually reimplements what we already have in the server code. 

the problem is that all this logic will not work in the near future, because you won't have all the components in one place: some of them will be provided by other teams, hosted on other servers or just simply you'll have multiple servers, so multiple projects with differenct components. these checks won't work and if this functionality would actually be needed for the sdk (to make sure you create a unique component) you would have to contact the registry, and also think about concurrency :)

so, i think the right approach would be: i would modify a bit the create component method to accept the folder name also and only check for that. you could improve it a bit and make the name optional which would mean the id would be tried and if that fails, possibly an id_version as a last try. but all that searching through the components folder and semver stuff isn't needed. just make sure the folder doesn't exist and don't duplicate the functionality that's already in rain. rain will throw out an error if there are multiple components with the same id or stuff like that.

in conclusion, i would like to see a new simpler, lighter version of this file.
artifact ID looks off?
Yep. The processing environment requires the raw type name without any generic modifiers:
```GenericType``` instead of ```GenericType<T>``` or ```GenericType<>```
FYI: all HTTPS tests are commented out until I set up a TestSSLContext to work outside of libcore.
Ok. I migrated the code to using cksum. On Darwin (MacOS X) and FreeBSD, it takes the form "cksum -o #," and I just decided to stick with algorithm #1 but I'm not completely sure of the GNU implementation. According to http://www.gnu.org/software/coreutils/manual/html_node/cksum-invocation.html, it doesn't use arguments for which algorithm to use and I wasn't able to test (I don't have a Linux box handy), so if the cdist host is running Linux, this code could fail.
afaik strip() function only eats useless spaces and tabs, not chars.
On Sat May 05, 2012 at 01:19:21PM -0700, David E. Wheeler wrote:
> > @@ -109,18 +110,20 @@ sub _bn {
> >  }
> >  
> >  sub _pod2usage {
> > -    my ($self, %params) = @_;
> > +    my ( $self, %params ) = @_;
> >      my $command = $self->command;
> >      require Pod::Find;
> >      require Pod::Usage;
> >      my $bn = _bn;
> >      $params{'-input'} ||=
> 
> This would be an example of something I would want perltidy to *not*
> fix. :-(

But spaces are free! :-)

More seriously, there are three types of "tightness" on three different
types of bracket. Please give me your thougths on:

parens:

    if ( ( my $len_tab = length( $tabstr ) ) > 0 ) {  # -pt=0
    if ( ( my $len_tab = length($tabstr) ) > 0 ) {    # -pt=1 (default)
    if ((my $len_tab = length($tabstr)) > 0) {        # -pt=2

square brackets:

    $width = $col[ $j + $k ] - $col[ $j ];  # -sbt=0
    $width = $col[ $j + $k ] - $col[$j];    # -sbt=1 (default)
    $width = $col[$j + $k] - $col[$j];      # -sbt=2

non-code braces (eg hash keys):

    $obj->{ $parsed_sql->{ 'table' }[0] };    # -bt=0
    $obj->{ $parsed_sql->{'table'}[0] };      # -bt=1 (default)
    $obj->{$parsed_sql->{'table'}[0]};        # -bt=2

-- 
Mark Lawrence
Because the WeakMap store juste one instance of client socket.
I don't understand exactly why you use it. But I can commit a new version with the WeakMap.
Ahh so then I should move this below the destination check. Good catch.
Indeed there should be. This looks like a kaboom waiting to happen.
Is there a reason this function has a suffix _2_? It seems there's no function `op_fetch_data_hdf5` this would conflict with.
Well, *humble* is literally translated as *bescheiden* or *demütig*. 
See [the LEO dictionary](http://dict.leo.org/ende?lp=ende&lang=de&searchLoc=0&cmpType=relaxed&sectHdr=on&spellToler=&search=humble).
This may not work if path start with "../". Is that a valid path?
This should be an `if` statement, since re-assigning a var to itself doesn't make much sense

```javascript
if (typeof ignore === "undefined" || typeof ignore.closeall === "undefined")
     ignore = tabEditors.getPage();
```
The underlying fs.rename (that it calls) will handle that.
This test was failing for me because the file wasn't present. Could be noting, could be something weird.
This has to be duplicated. No option here.
This is not needed on most platforms, I'm not really into having it in the gemfile.
playbackType should be an enum. It's not clear what a playbacktype of 3 is from looking at the code.
Probably placeholder for the content which is then filled from JavaScript.
I am not sure why you simply do not copy style from [nodewatcher](http://dev.wlan-si.net/browser/nodewatcher)? For example for those login and registration buttons?
Ok now i feel kind of silly, i didn't think of that. 
I was trying to send a languages via JavaScript arrays. :)
Since _popcorn can be null, and you're doing a property lookup to get at paused(), it's safer to do the check on the boolean first.  I'd flip them, yes.
Here 13ms, which is probably better still.
I thought it was a good idea to start doing it somewhere as a test. These messages were the easiest thing to pluck out of the UI because they were set mostly by inline strings in the code. Considering I set it up to transition easily into `require`'s l18n system, do you think it's not worth doing?
should this be throw new error?
another use of undefined
Nitpicking: There's an extra line in here that consists only of whitespace.
The chroot use is gone in your more recent versions, so this privilege isn't really needed.  However, you could use julien tinnes trick to chroot into a /proc/self/fd... to end up with an empty, unreachable path.  (As per code.google.com/p/setuid-sandbox )
Rather than a clunky `instance_variable_set`, I simply added an `attr_writer` to the test file.
Would have been nice to mention what calling these constructors would have been equivalent too ( null repo for example) and fill in param javadoc.
returning NXRRSet when no record is found is correct; however, we also need to return NXRRSet when RRSet contents do not match exactly
I would name it `SimpleForemanController` or something like that, it is not behaving like condlepin proxi so to avoid confusion I would use diffrent name.
Something like this tutorial. I'm going to have a play on the train later
http://clark-technet.com/2009/09/wordpress-theme-dev-tip-dynamic-stylesheets
You could simplify the code by doing this directly in write instead of adding a method sending requests with any method and used only once IMO
you don't use the issuer variable in the constructor
Ok, I think I got it. I will take one more look at how multi partition check is performed for the entire UNION
Is there a reason that the above lines are commented out? If they are not needed, can you remove them?
How many catalogs are there? What if all n return something different? And to what precision? Are we checking all n? I'd argue this is very much a convenience feature and some soft logic is appropriate. One option A:

1. look up name in default catalog server, or if the user specified one, that catalog
2. if found, return to user
3. if not found and a specific catalog not specific, move to the next catalog until not found

Another option B:

1. Search in all catalog
2. return all results

B would be annoying if it returned several results that have very small differences, and also time consuming will all the connections.

I do not like the idea of a preference-ordered list - keep things simple and wait to see what users ask for.

If one server (e.g. the default or the one explicitly asked for) returns multiple results, return a list. We can't guess, though we can put a flag `select_first=True` as a default. Again, this is a convenience feature, so it should be as simple to use as possible and not cluttered by edge cases.
If this truly modifies the data directories, it should be in `rtdev`, not `rt`, with `rt` simply handing it off there. In the future if we use remote builders over ssh (which we did in the past), we will need to have this abstracted.
GetProxy() returns a CService, but I need the CService AND SOCKS version for the requested net, see ConnectSocket().
Perhaps you need to explain a little more :).
What is the -s?
We could mock it, or prevent from running in cli, though
constant should be declared before properties
I learned that from @stof and brench on IRC explained something about missing the ! and being an assignment if not done this way
Remove archive functionality for now.
Ah, then I should be publicly berated for choosing such a long name :-) Any ideas for something shorter?
Nice, putting base_dir and user here is cleaner, I liked this one too.
Okay, then.
It's easy to get the last output, it's just `this.outputs[this.outputs.length-1]`, but I realize that after one such append, that would stop working and become immediately too complicated.  So scratch that suggestion.

I should note that there is not an actual problem now with fixCR(fixConsole), but it just makes more sense to erase output before adding all of the escapes.  Since that's not reasonably compatible with the appending here, let's ignore that, and 

> It probably wouldn't hurt anything, but it's additional unnecessary computation.

That's not quite accurate - fixConsole *must not* be called twice on the same text, because it turns colored text into raw html `<span color="red">red text</span>`
I don't think that `enable_autorefresh` and `disable_autorefresh` need to be in the `IPython` namespace.
is it valid for this to be null?
```javascript
var Changeset = {};
```
You should use test here instead of exec, since test will return a boolean.
I think it's better for readability to have `} else {` without the line break.
what are the extraneous parentheses for around ALL - and in the next line?
@Vader19695: This does not work.
I think this is the wrong import?
this should be cons_state. The cons_state can be none, cons, mono or def. Moreover, instead of proof_status, there should  be a proven_cons_state, with the same possible values.
Same here (and wherever these values are used), something like kNoTime instead of "magic" values makes the code more readable, IMHO
Is that the only way? Both PO and MO do need to process the header but it seemed, last time I looked briefly that the translation component doesnt really cater for this.
Hm... looks like two first patterns do nothing to the string. Let's say we have a **\\\\ "** string:
* first pattern will replace it with **\\" "**
* second pattern will replace it back to **\\\\ "**
* third pattern (added by me) will replace it with **\\\\ \\"**

I'm not really sure why first two patterns are there.
Keep it like this.
Private functions should be after public and protected ones.
adding ``@api`` is not needed as it is already there in the parent phpdoc
$level & $this->level & error_reporting() ?
I refactored the code to only display all the child violations if validation against `AnyOf` failed. The only bad thing here is that there is no message that there had to be ANY of those to match. But merging those messages into `AnyOf`'s own error message is not a good idea as well.
Yes, why not. Where is the best place for doing that? In the finalizeValue() method?
Please remove it (doing a check on the existing of the key is simply doing some useless work)
I think this is less readable, but will make the change. Not trying to be difficult just trying to emphasize that a lot of these changes are based on subjective things and I see them slightly differently.
Spaces around the `=`?
These should be constants
It'd also be nicer if this method didn't take in `agentConfig`, `log` or `instance`. If it had a better method signature like `_check_http(self, url, username=None, password=None)` it'd be much cleaner.
This is the downloaded `roundup` tool. It is included here so people do not have to install it.
Yikes, how did I miss that.
Because it looks so close to

roi.xbegin = i * blocksize;

which is also correct :)  (I missed it too, I remember reading this section when I looked at the code first time round)
Confirmed. Unused and undocumented. Thanks for pointing out @esc24 .
i removed these styles intentionally. please make sure they aren't added back in.
this comment seems unnecessary
In this case maybe we should keep the `+` operator and use `{}` instead of `%s` just like you did through all the code, and use format while showing the message. Did you try it out?
Why was this changed?  There's no reason for it, and a default installation/upgrade will throw directory-doesn't-exist errors.
`.bind( "keyup"`

We should be avoiding event shortcuts.
Why do you need both this and a click handler? Should the updated for-attribute take care of the click-forwarding already?
This also needs an updated test
why do we need a class here?
The banner shows regardless of whether the app was installed successfully.
Ideally, Evme.Utils.sendToOS(Evme.Utils.OSMessages.APP_INSTALL, ) should return a boolean indicating success / failure.
What we do with the red one? We keep the classname only for one of them?
explained more in the comments
I'm sorry. I didn't get your last 2 comments.
I added the new event listener to init method in Utily_tray.js
The event listener will be created only one time and will run until the program close
(you could see my new commit)
If your not ok with I can find something else
I think it's "/downloads/bluetooth", at least in my test.
I just want to sync the coding style with L133~152.
Thanks @steveck-chung ! I've included your suggestion ;)
I bet @jcarpenter will simplify this one to `Uninstall {{ app }}?`
Just to be sure. This timeout is to manage the 10 seconds timer mentioned by UX in the 2nd screen on the 3rd page at https://www.dropbox.com/s/yrd9mmj9w08x2c0/OWD%20USSD%20V02%2020120921.pdf Do you control timeouts for responses on the backend side?

On the other hand and apart from this, I will include the onerror handler in case anything happens on the DOMRequest ;-)
Which line are we talking about? :S
It should always be passed a QuerySet. I can't see a use case for only passing a title, as it would be a noop.
Add the braces for the if statement.
Why not two functions? One which sets/updates the schema, one which checks. Doesn't really make sense for a single function to do both, does it?
`!match` should suffice here
body p { margin-bottom: 0cm; margin-top: 0pt; } 
    On 9/7/2012 18:00, Argyris Zymnis
      wrote:
    
      
        @@ -0,0 +1,54 @@
+package com.twitter.scalding
+
+import cascading.tap.Tap
+import cascading.tuple.Fields
+import com.twitter.maple.hbase.HBaseScheme
+import com.twitter.maple.hbase.HBaseTap
+import cascading.tap.SinkMode
+import cascading.scheme.Scheme
+import org.apache.hadoop.mapred.OutputCollector
+import org.apache.hadoop.mapred.JobConf
+import org.apache.hadoop.mapred.RecordReader
+import org.apache.hadoop.hbase.util.Bytes
+
+
+abstract class HBaseSource extends Source {

      
      
Presumably you would never use ```HBaseSchemeSource``` outside of ```HBaseSource``` so why not merge them into a single class? That means that you would not need the class ```HBaseTable``` anymore

---
Reply to this email directly or view it on GitHub:
https://github.com/twitter/scalding/pull/121/files#r1122823

    
    you are right of course, didn't even think about it
You should be able to use JRegistry here. The instance of check will be true on JParameter objects as well. If you don't use anything from JParameter that JRegistry doesn't do as well you could even more completely to JRegistry.
Why is this still open?
Just checking these off as I go.  Done
is this really needed, or is it only copied from some other sharer?
Also, I'm not super comfortable with the hardcoded constant below...
Why is this in RootController when fetch_artefact is in ApplicationController?
'another line' is written twice
```python
class SomeEndpoint(base.Endpoint):
    link = ('master', 'i:id')
    dates = ('last_active',)
...
class base.Endpoint:
    def mungeDbData(self, data):
        data = data.copy()
        data['link'] = makeLink(self.link, data)
        for attr in self.dates:
            data[attr] = datetime2epoch(data[attr])
```
with a suitable `makeLink` function? (although I don't like the name `mungeDbData`)
why `*`? won't it be better to specify stuff more explicitly?
People tend to overuse the existential operator IMO. There are just a few cases where truthyness doesn’t work and `?` is necessary. Searching for the `?` operator in the Chaplin code shows that it’s mostly used for function calls (`func? argument` which is equivalent to `func argument if typeof func is 'function'). Of five remaining cases, three could be replaced with truthy checks because the context clearly demands an object/function or a non-empty string.
MultiTouchTest is working properly now on Win8 Ultrabook.

There is no need to collect all touch events (i.e. make 9 different dynamic arrays), because handleTouches* functions also iterate over every event the same way.
Yep, i was wrong, JS_SetElement will not trigger a GC.
Deleted it.
@stloyd changing only the condition here would not be equivalent
We could not because the code was expected a MathTransform2D (and I was unwilling to make a major modification). I did think of setting up a transform to to the WGS84_3D -> WGS84 so we could make a single clear chain but was unable to figure out how to connect it.
Yes, of course I remember it. But the rejection of validation - not a good solution, although this critical None. The only question is, what degree of freedom must be in the title. Nothing more :)
>new project name

?
Yes, but they were both using the same layout and they use the same `[whatever]_menu` partial.
Daithi suggested this - will see if I can sensibly do this. The hard part is figuring out where to put it, model-wise, that's shared by all the places it's used, but also feels like a logical place to put it.
if statement opening bracket should be in a new line.
 301 | ERROR   | Expected "if (...)\n...{...}\n...else\n"; found "if (...)
     |         | ...{...}\n...else \n"
You should do `EventTarget.prototype.initialize.call(this, options);` instead.
I would very much prefer to have more utility functions than this complex iterator. For example we already have utility function for getting window tabs:
https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/tabs/utils.js#L23

I think what we need is:

1. `window/utils/getWindows` to get all windows
2. `getAllTabs()` map all windows to tabs array and merge via reduce similar to `getTabs`
3. `getBrowser(tab) -> tab.linkedBrowser` 
4. `getWindow(tab) -> getBrowser(tab).contentWindow`
5. `getURI(tab) -> getBrowser(tab).currentURI.spec`

Than in `_applyOnExistingDocuments` you will just do:

```js
getAllTabs().
  filter(function(tab) { return isMatching(getURI(tab), this.include)) }, this).
  forEach(function(tab) { this._onContent(getWindow(tab); }, this)
})
```
What do you think about: `Elements with data-l10n-id attribute whose parent element is translated will be replaced by the content of the translation.`
was this file overwritten by accident?
So now we are back to $Server or $domain? The link you provide give me 404 error.
This should be always false in the repository, otherwise we are going to compile each time a debug version of the application even for production environments.
@pcarlisle since `next_reparse` defaults to 0, and won't be set if Puppet[:filetimeout] == 0 and we're not in agent mode, then I think we can fall into the same infinite loop.
None of this is necessary. There's no need to keep track of all the opened windows, let alone have a maximum number of windows. If windows are not properly closed before glwtQuit, it's acceptable to leak resources.
I merged locally after you made my suggested changes. All the specs pass but then when I tried it it didn't actually work as expected yet. If you change this example to use `stub` instead of `should_receive`, you'll see it fail.

The reason is that `find_almost_matching_stub` returns the stub and we never get to the next conditional. I'm thinking we can just delegate this branch to `raise_missing_default_stub_error` instead of `raise_unexpected_message_args_error` and that solves the problem. WDYT?
This needs synchronization. Also, you should probably remove collected IOs at every N adds (perhaps N = 100).
im not gonna worry about it
i'd rather call the large flag `--config <path>`
I'm sure I've seen this block of code at least twice before! Unsure of the policy related to copy/pasting blocks of code around. Can it be moved to AbstractSql?
Should be in the format "if (true) " - note space between if and (
This is where me+you+andrew gets to add what a user needs to do to accomplish this or that goal of profile completedness.

example:
name: 'Add username'
message: 'What should we call you?'
i grant you that and agree with it
No really. This code is not deprecated. In 5.4 removed was code like: `break $something;`.
Sheep has an onTick too, so all of the tick logic can go in Sheep.
You could do <%= Policy.published.count %> ...
Mostly because I did't want to muddle the main imports with template loaders and RequestContexts
I know I'm being picky here, but do we *really* need to add this? This isn't something specific to this project and not everybody likes to use virtualenv. You can use 'python setup.py develop' without using virtualenv, as well.
TODO: add visiting of attributes here
Should this be using self.cache_backend instead of looping through everything? Also, if you use that you can use whether it's set or not to determine whether you do anything fancy, rather than something in setting.CACHES, which seems a little odd.
Indentation is wrong here. Should be:

```php
$this->types[]  = isset($this->class->fieldMappings[$field]) 
    ? Type::getType($this->class->fieldMappings[$field]['type'])->getBindingType() 
    : \PDO::PARAM_STR;
```
is there any good reason to have a phpcr specific MappingException? i would assume that it is just that at the time of writing, the exception was not yet moved into the doctrine common but copied for each odm and the orm. 

@stof i see the orm still has its own MappingException https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Mapping/MappingException.php and it extends from ORMException rather than the common MappingException - is that subject to change? is the exception concept to have a specific tree for each of the backends or should we push that all into common and eliminate the impl specific exceptions? (unless there is some additional info to track in an exception, where you would extend the common exception rather than some sort of base implemenation exception)
we have 2012 now.
The code used to always have an author. Tested feedgenerator with None and empty string and None does not generates an author element, which is required by the ATOM spec, so went with empty string. Whether the spec is enforced is another matter :)
alt-n n :-p
Spaces after , and :
import order should be alphabetical.
Right, I get that.. I mean in the file itself, such that others viewing the example later can make sense of it. That, and I'd collapse the proxy examples - no need for two, just document this option.
I think this should be before the previous block, so that `-s` in the response file will be noticed.
Remove this from local-py.dist and bin/jenkins.sh
`s/mozillians-release/commtools/`
```js
if ("function" == typeof args[args.length -1]) {
    callback = args.pop();
}
```
Not being spawned imho shouldn't clear the context as the server is not left (and hence the context did not change).
Not sure what the minimum version of PHP supported by OpenPhoto is, but if it's PHP 5.3+ you could use __DIR__ instead of dirname(__FILE__)
Since this is a simple form, the fieldsets don't need classes. Bonus: taking them out will fix the alignment with the character counter. Also, contacts doesn't appear to be an ARIA role -- we might want to leave the roles off, since the article role on the post new was experimental and added primarily because it's such a complex form. Just plain fieldset tags are good for this simple form.
We could move that to a config variable so it's less of a magic number. It's just that you need a finite number, since you can't expire memcached keys with a regex, and I figured most of the traffic hit the first few pages of any tag/user/collection.

Bigger question from me: I moved that code to the work model so it could be called asynchronously, since it was making posting new works prohibitively slow, especially when they had a lot of tags. Do we know if that's been tested? If it's not slow, it's not a problem, but it was a pretty noticeable drag when I originally added it.
There has got to be a way to do this to make the code readable
Can't we keep this as `fetch` to avoid the `||=` when the key is set?

```ruby
@_memoized.fetch(name) { |k| @_memoized[k] = send(:"original_let#{k}") }
```
`@api` should be removed.
We could, though the example URL today already is HTTPS, so clearly the mistake can still be made.  IMO the bug lies in the test connection button, since it reports the connection is OK currently, even though it may later fail (rest_client refuses to follow 302s with POSTs).
Looks like I wasn't completely correct here. I added sorting to the :types in the model and will try using it for the index.
Ok I think the goal of this pull request just clicked. Sorry for being dense.

I think rather than implementing two different paths that effectively implement bind to route we should implement a cleanup option for bind to route to make it cancelable and then the ajax failure handler can call that.

What about something like:

var bound = bindToRoute(....);

this.fetch({ success: bound, failure: function() { bound.cancel(); /* other stuff */ });

Alternatively since it looks like we have changed the path to bindToRoute we can also change the return without as much concern so bind to route could return a hash for the success and error handler rather than trying to bolt it on the callback to maintain API compatibility. (The `Thorax.Router.bindToRoute` version probably should retain the old return format...)
Is that a no-op?