labofsahil/github-event-dataset-2012 huggingface dataset:
Please use proper bash syntax here. No posix tests, only bash's [[. There's some other places in the codebase where the posix style exists, but there's no reason to carry this forward.
30023 
69895

not in dbc
don, do you need a programmer to fix everything? Message me.
Ahh poop.
Not when using dependency management.
@gf3 I assume you have to publish this before reload crew works, right?
print statement.
I think this should be `params[:ad_id]`. You should really look at the "Getting Started":http://guides.rubyonrails.org/getting_started.html. Just replace the word "post" with "ad" and it's basically the same thing for you.
I get rid of those?:

```C++
    ServNumChange,
    ServDescChange,
    ServNameChange,
```
Will do when I have some time (in the next weeks). I was thinking adding a "fill meta" feature also. If the class having the attached file has a "#{attachment_name}_meta" accessor it will set a hash like:

```ruby
"style_name": {
 width: x,
 height: y,
 duration: s,
#codecs ... etc
}
```

I'm currently doing that on one of my projects on after_post_process callbacks
Looks good. I'm looking forward to when we implement the weighting of songs that haven't been played recently, and the Ban From Random button.
Naughty boy!!! Do you not use aliases in ~/.ssh/config? I think they're better as they allow you to use the aliases with scp etc.
it's done already (see discussion)
It's a little bit ugly because this doesn't work:

````
Exec {
  path +> ['/usr/local/sbin', '/usr/local/bin', '/usr/sbin', '/usr/bin', '/sbin', '/bin']
}
````

So we have to do this:

````
Exec['newrelic-add-apt-key', 'newrelic-add-apt-repo', 'newrelic-apt-get-update'] {
  path +> ['/usr/local/sbin', '/usr/local/bin', '/usr/sbin', '/usr/bin', '/sbin', '/bin']
}
````
Hmmm, good point. 

Seems the core problem here is that the raw title is being used, which is not safe as a selector. @jdlrobson or @bengillies, and ideas?
Where's your "Internet Culture", Warpten?
I'm experiencing issues with this commit too. I think its something related to VMaps, I beleave I have it enabled only for BGs and Arenas.
Like other start up errors, it will cause the thor master and the cluster to quit.
Errors will be in the redirected startup script output.
Nice, thanks man!
Вот так делать нельзя! причину описал подробно письмом
See comment from previous commit.
We can email through GitHub... That is awesome... If you can email me the
compiled kernel, I can help test for stability especially under high load.
Unfortunately with just 1.2Ghz enabled (1.1 disabled and not using 1.3+), I
still have soft reboots randomly. Don't know if it is kernel or ROM issue.
On Jan 9, 2012 4:00 PM, "Paul Blair" <
reply@reply.github.com>
wrote:

> I might just remove the 1.4 step too. As I said 1.4 has never worked for
> me either and since the whole point of my ROM is stability, removing 1.4
> completely might be the prudent course of action.  As for the voltages, I
> don't have a lot of experience with voltages which is why I didn't touch
> them.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/toadlife/CleanGB-Kernel/commit/1510b5ac031c0d1ceb2787db5470f67e41e2ce25#commitcomment-851173
>
Hm, Google has it that way on their info pages. I guess this is to support opening the play app on Android devices? Will happily go https if not.
It seems that since at line 838 you say that you shouldn't use `rescue Exception` ever, you should pick a different example here for the MoreStandardError.
Missing volatile. ;-)
But since this is a hack, no need for double-check-sync anyway.
Имя my_search мало говорит о том, что на самом деле делает функция. В идеале название функции должно быть максимально информативным не в ущерб лаконичности. Префикс my уж точно лишний. Можно findPreCycleLength, например, назвать. Find лучше, может быть, потому что search чаще значит поиск среди похожих (однотипных) элементов того, который обладает заданными свойствами.
Usually it would be a good idea to lowercase our variables.
But in this specific case, I would agree with doing it this way because they do it all the History.js [1] examples as well.

Would it be possible to add a small comment in why we make the first letter a capital?

[1] https://github.com/balupton/history.js
What makes us incompatible with DateTime 3?
Whoa, totally didn't think about backwards compatibility. That's a bit of a conundrum: 1.8's constant_defined? is the same as constant_defined? without inheritance in 1.9. The metaprogrammer in me wants to just redefine const_get on the Recurly module.
pues si xD
Dodano nowe dane testowe
Merged! Two tests failing. I'll fix 'em.
You can use Build.VERSION.SDK instead of Build.VERSION.SDK_INT in older versions. Note it's a string not an int.
*implementation
Yup, that might work as well. Can't say mine was that well thought out, It was something I came up with one the spot.

I'll just try run through the different things we have to do and we can analyse how you would do it with both systems:

Representing a connection
---------------------------------------

In my system, each connection is represented as an increment in that direction. As there will be at most 1 island in either direction, the max amount of bridges in a direction will be 2 (not 3 as I've written above in comments). I.e in order to add a bridge (forgetting for the moment about errors etc) we just need to increment the direction value for the pair of islands.
For example we want to join two nodes at coordinates (0,0) and (0,1) we can see it is left to right and a right to left. so we 

(0,0)(R) ++;
(0,1)(L) ++;

Where L and R are the direction values for that grid position.

There are a number of checks after this to make sure it is a valid grid position, such as the bridge crossing.
Lets consider the horizontal case.

x1        x2         x3
x4                     x5
x6        x7         x8

Assume that each of these are islands and there exists a bridge from 2 to 7.
We want to check if its valid for there to be a bridge between 4 and 5.
Lets assume they are (0,1) and (2,1) in terms of grid position.
we then go along each column. and check the closest island upwards for a downward bridge.
If this is the case for all columns across until we get to the island we have a valid bridge.
The same thing holds true for the vertical bridges.

Hopefully this all makes sense, Its all a bit rushed, but I think this should work. But again there is absolutely no hard feelings if you think yours better represents the grid. I'm pretty sure mine will work, and that the complexity should not be too large.
oo sorry, there is no hdmid at device_thriump.mk, I also have experienced at overlay before, maybe add 

TARGET_QCOM_HDMI_OUT := true
at boardconfig file
ah thx, nice catch.
Could be.  I'm just trying to seed some examples from live/working setups.  I got this one from an rt-users community member.
It'd really make much more sense if all this logic was encapsulated in some form of helper class that can provide state information to the NotificationProgressBar. 

Android does this, for example, with frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/policy/BatteryController.java where it has a BroadcastReceiver that is passed views that the receiver knows how to update. That way, all the logic isn't duplicated and there's only ever one receiver to update if anything needs to be debugged.
Are you sure this .gitignore works? Seems a little odd with slashes in front.
This looks like a rollback to older code. Is it needed for older binary blob libs?
Ok thanks, why this class name for left and right: "span9", "span10" ?
Definitely! The plan is to add some thin layer for sql operations (we don't need much, select a value, execute queries, ...), so lhm itself would be adapter (activerecord, datamapper, etc.) as well as mysql gem independent.
Ok, I'll do that when I get home.

Thanks again for your help.
cara, "influenciar o projeto como um todo", acho q vc no intendo oq
significa isso
instalar essas coisas no quebrou a logica de nada, vc usa se quiser ;)

no tem conhecimento da issue? pra vc ver como esta olhando elas, ela j
foi at fechada ;)

reclamar depois da parada pronta? grande ajuda esta dando pro projeto! se
no tem uma ideia melhor ou deu ideia antes, reclamar no tem se quer algo
a acrescentar

opnio! agora vc falou, isso seria de grande ajuda!



Em 29 de fevereiro de 2012 22:12, Thawan Fidelis <
reply@reply.github.com
> escreveu:

> "mas se as pessoas no leem as issues e comentam, acho q no tem o direito
> de reclamar." >> reclamar  uma forma de comentar, se todos esto no mesmo
> projeto todos tem direito de dar a opinio e reclamar. seu argumento 
> invlido!
>
> " se elas no afetarem o projeto como um todo e nem quebrarem testes de
> outras pessoas,
> no vejo o problema de serem instaladas." >> concordo plenamente. porm
> instalaram o Inherited_resource, formtastic. e acho que eles influenciam em
> TODOS os controllers/forms. novamente argumento invlido.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/douglascamata/Rick-Rocks-Academics/commit/2051dac6f31a7ab08c1a971e3de99f092a05f7c5#commitcomment-1028946
>



-- 
Pedro Henrique Passalini Soares
Graduando em Cincia da Computao e Informatica - UENF
""em grupo" dentro de aspas foi perfeito! pq nem pra comentar ou dar ideias o "grupo" ta disposto (...)  mas como o unico q as vezes  omentava era o @douglascamata, to deixando de comentar coisas q acho pequenas ... " >> Cite nomes por favor. Porém tenho certeza que estou sempre comentando, corrigindo e sugerindo coisas, além de discutir coisas com o @douglascamata.

"... pois ao add o formtastic no influenciou o projeto como um todo, pois ele trabalha em conjunto com simple_form de boa." >> Mencionei isso no meu comentário.

"Com relao a discutir outras coisas que realmente influenciam o projeto
como todo,  uma issue foi criada para isso" >> Não tenho conhecimento dessa 'issue'!

"Como vi q isso  pouco, resolvi mandar um email para todos, pra ver se assim alguem responde">> Sinceramente não consegui decifrar essa mensagem.

"estou acompanhando o que está sendo feito e leio essa bagaça toda aqui.." >> comprovo, e me incluo nisso!

" tem nada que sair instalando coisas, mudando coisas que talvez façam outros testes quebrarem não.." >> concordo em parte. não gosto de mudanças por talvez eu simplesmente não concordar com ela. obs: Acho que ninguem vai instalar algo e dar PUSH com os testes quebrando. (os arquivos inúteis que o scaffold gerou e eu commitei é um outro caso.)
Is it really required to have Ctrl + L enabled? why?
Calling getActions twice is inefficient.  Casting the result to array is probably easier.
Not yet we are still figuring out what the underlying problem is.
please don't commit the ignores.
It's possible we forget about them in the future
см. правки в пулл реквесте 33
mouseover and mouseout not needed here. it maybe achieved just using HTML and CSS.
can we optimize it? do you think user will be happy if you will use his resources efficiently?
Agreed.  I'll merge this as is, but from a UI and design perspective, it needs to be significantly improved

Also, I found my self wishing I could just pick from files I already uploaded, and not have to upload another.  I'd like to see a select menu here as well if there are already files uploaded, making sure only valid IMAGE file types are shown
"the following" is better than "this final"
The png file is already in our source.  It's a file in src/css/images folder.
This difference in the IMAGE WIDGET for can not be used
why not keep a log.info ?
Okay, @garthwebb that should be sorted out in the next batch of commits.
Does it matter if the barrier is in an `after` block or inside the test method?
I did like this in my test.

```scala
var afterBarrierNumber = 0
after {
  afterBarrierNumber += 1;
  testConductor.enter("after_" + afterBarrierNumber)
}
```
I submit that the reason was rather that neither of us bothered to actually read the comment. It might make sense to describe the solution I proposed (if you agree with it) in great detail, though.
it's the best duration in the universe so it wouldn't surprise me if it handled that also ;-)
I think this might be premature, just use "-". I'd be surprised if it doesn't return "this" if it doesn't contain the instance, it is an immutable collection.
weird line break
Nice catch! We should throw an exception.
Isn't this on by default for SBT 0.12.x? I remember removing it recently since it wasn't needed anymore for sbt-multi-jvm and the sbt-assembly plugins.
DRY, had the mail args call after each call to this.  Could be 'mail_it' or something, but we do the from processing here, so I think this is good.
Can you help me duplicate that?  (Integer/parseInt "1") works great for me.

On Sep 13, 2012, at 11:24 AM, Matthew Rocklin wrote:

> In src/hits/models/datomic.clj:
> 
> > +   "id"           :git/id
> > +   "subject"      :git/subject
> > +   "body"         :git/body
> > +   "date"         :git/date
> > +   "timestamp"    :git/timestamp
> > +   "action"       :git.change/action
> > +   "file"         :git.change/file
> > +   "commit-id"    :git.change/commit-id}
> > +   )
> > +
> > +(defn to-timestamp [s]
> > +  (->> s
> > +    (timef/parse (timef/formatter "EEE MMM dd HH:mm:ss yyyy Z"))
> > +    timec/to-timestamp))
> > +
> > +(defn parse-int [s]
> Caused by: java.lang.RuntimeException: Unable to find static field: parseInt in class java.lang.Integer
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
i prefer parenthesis too, much easier to work with.
This should be 2 Append no need to create another temporary string. Please fix it everywhere
This line should probably be moved up into the the try-except block in case one of the a's doesn't have a dtype.
Is nibabel.nicom already in the released version of nibabel?
genshi is being deprecated so should not be used - maybe this wants to be looked at in a separate ticket
I love that you're using these exit codes in the command line :)
This looks really awkward to have an empty test, why not move the assertion into here since the method has to exist anyway? It's probably bad form for a setUp to do assertions as it is, it's technically not considered a test case that could fail.
Glad the seeding stuff is removed, but I was proud of this test  :)
I don't think there was an issue here.  Once we fixed the and vs. or thing, this problem was fixed.
I know, but I suspect we will do a lot more before we must address it, so I think being lazy is ok.
final API is all on the card: card.account and card.account= work for *+*account cards and their trunks.  The final stuff used the AR save transaction and eliminates save_card.
started should be set to false...to be more precise, it should be a if (compareAndSet(true, false) ) {..then stop..} 
Similartly for start()
it's called by the add-on when updating group members in a group
Does the refresh rate matter (i.e. should we only match 60Hz and 50Hz)? If not you could just check 
```
if (modestr.Left(4).Equals("1080"))
```
It'll be define only when `find_by_something` is called. The `__getattr__` method just return a callable that will be used when some method of the object is missing. For instance: when I call `Corpus.find_by_name('Test Corpus')`, `__getattr__` will return a callable that receives `'Test Corpus'` as `value` and then search in the corpora collection.
Learn more about it: http://ynniv.com/blog/2007/08/closures-in-python.html
either it's checkAppendable() and it throws an exception or it is isAppendable() and does not
Just a proposal to factor out the hascode() and equals() logic in a different way
Faltan comentarios de cada metodo
g doesn't refer to anything, does it? It's meant to be the name for (d -> a), but that's sort of unclear...
I would vote for doing the math (sorry).

The problem with using `Timeout` is that it spawns a thread and then uses `Thread#raise` to send the timeout notification, which is a really terrible way to solve the problem (because it can cause exceptions to be raised in places that shouldn't ever raise them).

It's the best solution to the problem when there are no other solutions, but it's a bad solution when you have better ways to solve it.
And the end tag should be `}}`, not `%}`
Thanks! :]
This gets the scroll view, if there is one, then, if there are indeed rects for the index provided, it scrolls upwards, otherwise, it scrolls to the beginning of the text if there are none for the index given.
This `long` should also be a `CFIndex` and I'll make that change.
Parentheses around `self` are unnecessary here.
I'm not a huge fan of us exposing this internal `'buffer'` encoding in the docs. I think instead we should say something like "Defaults to returning a `Buffer` instance", and just never mention `'buffer'`.
They can also upgrade (e.g., if they want to keep settings, files, etc).
Is there any particular reason to freeze this string, or is this just defensive?
Thanks @frodsan, I've updated the pull request.
This follows the same style of existing helpers.
No, that statement is correct it must be `typname` because this is the column name from `pg_type` that gives me the name of type.

Thanks for your review!
Let me remove this and run the full stack test.
give space between object and () write as:
object ()
do it in all the cases we are maintaining space between every element of every sexp doesn't matter if it is the third element don't use cpp java style.
We've already broken source compatibility with the visibility changes, what's on more?
couldn't this else's block be replaced by the following?

```
{
  val dummies = unsafeTypeParams map (_.typeConstructor)

  if (settings.debug.value && dummies.nonEmpty && !kindStar)
    printCaller(s"""Call to ${this.tpe} with unapplied ${dummies mkString ", "}: call tpe_* or tpeHK""")(dummies)

  dummies
}
```
I wonder if the temptation to write it the ugly way would be reduced if we could write
```
tpe matches { case MethodType(Nil, _) => }
```
Or if only patterns were first class,
```
tpe matches MethodType(Nil, _)
```
How do we get to that last one...
AH.. I hate to be annoying, but why not just call it 'hash' if we're going to change it.   Either one is fine really.
OK fixed all header files (I'd relied on the autogenerated ones in my IDE).
how can a user pass in a header?
Ah, ``__new__`` doesn't need to be a classmethod, that's what's giving you the class in ``args`` and why you need to use ``args[1]``
Should you watch for the condition where a solution is not found because of NotImplementedError?
I would leave this as `self.args` otherwise you have to go to the method to find out what is gives you -- in this case, *un*sorted args (and I think that's confusing).
Both of these are because `Basic.__new__` doesn't play well with `Expr`s. 

Exprs need to be instantiated normally to work. In particular they need instantiation for `is_commutative` which is necessary for printing. These two statements previously raised exceptions because `construct` wouldn't respect `Expr`'s requirement of instantiation; now it does. Just running these lines is the test.
The difference isn't much except for a few differences-
>>> series((a+x)**.3, x).expand()
0.02972025*a**0.3*x**5/a**5 - 0.0401625*a**0.3*x**4/a**4 + 0.0595*a**0.3*x**3/a**3 - 0.105*a**0.3*x**2/a**2 + 0.3*a**0.3*x/a + a**0.3 + O(x**6)
>>>binomial_expand((a+x)**.3)
x**0.3 + 0.3*a*x**-0.7 - 0.105*a**2*x**-1.7 + 0.0595*a**3*x**-2.7 - 0.0401625*a**4*x**-3.7 + 0.02972025*a**5*x**-4.7 + O(a**6)

(Note the better representation of exponents)

Plus, binomial_expand can also do something like -

>>> binomialexpand((2*x+sin(x))**.3)
1.23114441334492*x**0.3 + 0.184671662001737*x**-0.7*sin(x) - 0.0323175408503041*x**-1.7*sin(x)**2 + 0.00915663657425281*x**-2.7*sin(x)**3 - 0.00309036484381032*x**-3.7*sin(x)**4 + 0.00114343499220982*x**-4.7*sin(x)**5 + O(x**6)
By the way, this should be not only here (I am talking about `np.seterr`), it should also be at the end of the try block, otherwise we do not reset it. Could you add a copy of this line just before `except Exception`
Silence operator was used here (and in some other places) before. Thought it was for a reason.
Have no arguments for it necessity.
Hard to tell.
On one hand "registerUniqueMetaTag" sounds more natural, tham "registerMetaTagUnique".
On the other hand current name follows convention, which tells similar artifacts should be named using prefixes or suffixes, but not middle changes. Currently "registerMetaTagUnique" is created from "registerMetaTag" adding suffix. This means if your IDE allows method suggestion it will show "registerMetaTagUnique" as option while developer types "registerMetaTag".
Yii's convention is `$_` name for private properties also when you have a getter, private is preferred over protected.
@qiangxue, do you think it shouldn't be supported here? But it's a cost of one simple condition.
Humor? In the source code?
Done. (I used single quote as most files here do. I fixed the double quote in my assert string above.)
What's the reason for the optional argument to `clear()`?
@ChrisR07 but why making is ``/?`` ? Removing the ``/`` entirely will match the same thing and the regex will be simpler
Why is that nasty, I see it is used in a bunch of files ?
Changed so if the solution is visible and the question is published, then Anonymous can see it.
Can the copyright go above the package declaration please?
I wonder if we should use Jackson to build a CacheBrokerMaker interface from the config which has a setCacheBroker method and use polymorphic deserialization. We may introduce additional cache types in the future.
two passive clauses in one sentence.
be consistent with having the dot on the previous or next line. I prefer it on the line w/ the method. Makes it more obvious that it's wrapped from above.
C'est `row-fluid` que ça prends ici.
URL to rfc where this was decided?
As I mentioned above, "wrongly" -> "improperly"
Why? This is consistent with the use of setTimeout in every other javavscript function.
I am unable to find where this setting is initialized.
You can remove intval().
We don't support 5.2 anymore, please investigate if we still need this.
I'm strongly in favor of this.  We should use `Y.merge()` if possible (it might not be).  This change, however, sweeps across more than just the resource store, so I'm going to punt for this PR.
The return comment says {array} but readConfigJSON's return comment says {mixed}.
> эм... а откуда возьмется перезапись? апдейты же по очереди выполняются. причем в иннодб же строки по дефолту лочатся? и если запросы к разным строкам то друг другу они не мешают же?

Да, тут я ошибся. Эту операцию можно считать атомарной. Просто есть подозрение что при небольшом усложнении транзакции возникнут проблемы с записью неверных значений, а их очень хочется избежать. Но опять же, если писать сразу при показе картинки, ты очень сильно нагрузишь базу этими локами, отчего упадет производительность. Почитай http://www.mysqlperformanceblog.com/2007/07/01/implementing-efficient-counters-with-mysql/ например.

> я имею виду делать 1 запись в таблице и обновлять, т.е. вместо создания 4х сотен строк в таблице за день, делать по 1 строке и обновлять в ней количество просмотров/кликов по интервалу
400 записей на баннер мало? т.е. если будет нужна статистика по рекламе за пару месяцев по десятку баннеров, нам нужно будет сделать запрос к ~250к строкам? 

Поэтому я и описал как будет старая статистика агрегироваться кроном.
Да и что даст 1 обновляемая запись в день? Со временем все равно наберется много данных и придется юзать крон. Так не лучше ли сразу сделать хорошо. Я не хочу вообще делать обновление. Только добавление, чтобы не задумываться над возможными проблемами.

> а зачем нодам то их лопатить? я так понимаю, от них требуется только запись в базу просмотров за определенный период?

Нода не должна решать что баннер больше не нужно показывать. Она должна только получать список активных баннеров и показывать их. Решать должен php на основании статистики.
you can add `darcs` to the previous match clause (ie.
```
| (`git|`local|`darcs as k) ->
```
XML editing probably? What is a model here?
This is an unused import - `strftime` is a method of the `datetime` instance
This line is incorrect; *generic* views were functions. Class based views weren't implemented.
Triple quotes for all docstrings please.
Much simpler, thanks for the feedback. Updated!
<blockquote>
On the first point
</blockquote>

Yeah, i get that, i'm asking why two arguments should be passed to <code>setTimeout</code> function.

You propose this –
```js
setTimeout(function() {
    jQuery.event.dispatch.call( self, event );
}, 0 );
```
right?

Why not –
```js
setTimeout(function() {
    jQuery.event.dispatch.call( self, event );
});
```
?

<blockquote>
total of -38
</blockquote>
Awesome! Can you open pull request to my branch?
I was following the convention from this file and kmeans. Will change if <> is preferred.
Simply I don't know...
Thinking about it again, I find this is a deficiency in boost. It simply violates the boost documentation: ["This gives no more than the requested probability in the tails"](http://www.boost.org/doc/libs/1_46_1/libs/math/doc/sf_and_dist/html/math_toolkit/policy/pol_tutorial/understand_dis_quant.html)
Possibly it will break. And we can easily add these things. I suspect though that such bugs were oddities in GCC that no longer apply. Superenv only does `-Os -march=native` anyway. What I should do I guess is put a warning in for these so at least we can track them if they do cause breakages.
"operation lock" could be reworded to be a bit more user friendly. Just simply a "you can't run Homebrew in two places at once" would probably suffice.
This needs a'doin.
Ok, i working that this week-end ;)
maybe you can just hide them and not store them in the object. It's still there but it should work right?
thanks, I just committed a fix.
That bug docs belong in the above part about synccing, which is where that Red Hat CA will come into play.
I'll give you a cookie if you can find someone who can actually explain what a push count is. Try Cliff.
Nitpicky, but perhaps `log.set_debugging(False)` should be called here too?  This is dependent on the default value of _debugging, which there is no test for.
FYI: these 5 lines is the satisfying part of this change.
-> `if [ $1 == "installed" ]; then`
language is ignored for the changes method so I removed it.
Comparison of both solutions:

<table>
<tr>
<th>State</th> <th>Old Version (direct throw)</th> <th>New Version (error collecting)</th>
</tr>
<tr>
<td>
<ul>
<li>Success: skipped()</li>
<li>Success: finished()</li>
</td>
<td><code>AssumptionViolatedException</code> is thrown directly.</td>
<td><code>AssumptionViolatedException</code> is thrown through `MultipleFailureException.assertEmpty()` (if only one exception collected this exception will be returned).</td>
</tr>
<tr>
<td>
<ul>
<li>Failure: skipped()</li>
<li>Success: finished()</li>
</td>
<td>Exception from skipped() will be reported, causing <code>AssumptionViolatedException</code> is invisible.</td>
<td>Both exceptions are reported as multiple failure; but: the outer framework is not able to determine the assumption failure.</td>
</tr>
<tr>
<td>
<ul>
<li>Success: skipped()</li>
<li>Failure: finished()</li>
</td>
<td>Exception from finished() will be reported, causing <code>AssumptionViolatedException</code> is invisible.</td>
<td>Both exceptions are reported as multiple failure; but: the outer framework is not able to determine the assumption failure.</td>
</tr>
<tr>
<td>
<ul>
<li>Failure: skipped()</li>
<li>Failure: finished()</li>
</td>
<td>Exception from finished() will be reported, causing all other exceptions to be invisible.</td>
<td>All three exceptions are reported as multiple failure; but: the outer framework is not able to determine the assumption failure.</td>
</tr>
</table>

If I did not misjudge any behavior I think the new implementation is what we want. It will tell the one who is debugging the tests all what he needs to know and does not hide anything. Of course outer frameworks and CI implementations like Jenkins won't recognize the "skipped" state - but I think this is fine as obviously something more serious went wrong.

All this of course depends on the contract of `MultipleFailureException.assertEmpty()` to throw a singleton exception rather than creating a new one. But the last time I looked up the code it was exactly this way.
I feel like changing this to `nextStateForEvent` makes it sound like it will return something, whereas `nextStateOnEvent` makes it sound like it's actually going to take an action.
This was here because of our annoying plugin VoxelBorder. It blocks people otherwise.
Oopsies. Fixed.
It feels like this case should insert a quoted attribute, since the unquoted value after it is being treated as unrelated (i.e. not getting replaced by the insertion).  And in the absence of an existing unquoted value that we're replacing, I think we should always default to quoted values.

Ditto for the case below, and the `<div dir=` case I suggested above.

If this would be a big change, I can spin it off as a new bug -- just let me know.
We should save off the original values of these config objects and restore them after running tests. Otherwise, if other tests load these modules, they will get our version of the config.
Pull request #1197 addresses a couple of these issues:

* `ChangedDocumentTracker` no longer forces us to load docs up front
* New `afterDocumentCreate` and `beforeDocumentDelete` events are added to better track document lifecycle. These are sent when the refCount goes from/to 0.

https://github.com/adobe/brackets/pull/1197/files
I wonder if adding these handlers to global.brackets is dangerous. It means that people could write code that registers handlers without actually loading this module. That allows the race condition we're trying to avoid with this refactoring.

Given that this module will be loaded asynchronously by require, I think it's certainly the case that if there was a not-using-require script include that immediately accessed brackets.ready, it would not yet be defined.
Should use `editor.document.getLine()` instead of accessing `_codeMirror` here.
Could be but that means patching socket.io.
I removed the sticky_slave option (it's now essentially hardcoded to true). We choose a new slave at the start of each request.
Looking at the code below, it seems like this should return a function which takes two params: a callback and a period (in ms). Firing after 17ms would be surprising if I asked you to fire after 100, wouldn't it?
Oh. Is there a way to fix that like you're doing for some macros?
So what would that line do that prevents one from having to do that?
And I did sign out, that didn't fix it.



On May 9, 2012, at 6:32 PM, "Gareth G. Aye"
<reply@reply.github.com>
wrote:

>> @@ -6,5 +6,6 @@ class ApplicationController < ActionController::Base
>>
>>   def current_user
>>     @current_user ||= User.find(session[:user_id]) if session[:user_id]
>> +     rescue ActiveRecord::RecordNotFound
>
> You have to log out (ie visit /signout or clear your cookies).
>
> On Wed, May 9, 2012 at 6:29 PM, Daniel Trauner <
> reply@reply.github.com
>> wrote:
>
>>> @@ -6,5 +6,6 @@ class ApplicationController < ActionController::Base
>>>
>>>   def current_user
>>>     @current_user ||= User.find(session[:user_id]) if session[:user_id]
>>> +     rescue ActiveRecord::RecordNotFound
>>
>> Dude I probably dropped and re migrated the database 15 times and
>> couldn't get rid of the user with ID 1 not found bug.  That fixed it;
>> I can give you the Stack Overflow link.
>>
>> Dan
>>
>>
>>
>> On May 9, 2012, at 6:25 PM, "Gareth G. Aye"
>> <reply@reply.github.com>
>> wrote:
>>
>>>> @@ -6,5 +6,6 @@ class ApplicationController < ActionController::Base
>>>>
>>>>  def current_user
>>>>    @current_user ||= User.find(session[:user_id]) if session[:user_id]
>>>> +     rescue ActiveRecord::RecordNotFound
>>>
>>> Kill this. If there is a user_id key in the session hash, then it should
>> be in the database. The only reason you'd ever lose it is if you change the
>> database in which case you'd want to have the user log out.
>>>
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/gaye/rideshare/pull/22/files#r798494
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/gaye/rideshare/pull/22/files#r798524
>>
>
>
>
> --
> Best,
> Gareth
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/gaye/rideshare/pull/22/files#r798533
Hm, I'm not sure it'll be so simple. If it is something that is called *after* `ggplot_build()`, I think the `plot` object needs to be modified -- specifically, `plot$scales` needs to be changed. But this can't be done from inside of `coord_train()`.

But I might not fully understand all of this. You should feel free to fetch this branch and make the changes...
If it's only used in one example then you can just use a local variable and remove the `before` block.
Can we do better than this error message?
can't this and the style above be applied using the open class? this applies to the block below too.
Just move the listener to before the css classlist remove/add.
Each `fileStore` reference here should probably be surrounded by back-ticks.
and could you stick this in 1 if statement please
Exactly. We can then just call `set_keepalive`, which either actually sets the keepalive, or is a no-op.

E.g.

```ruby
if [:SOL_SOCKET, ...].all? { |e| Socket.const_defined?(e) }
  def set_tcp_keepalive(keepalive)
    # ...
  end
else
  def set_tcp_keepalive(keepalive)
    # Nothing
  end
end
```
I used libfaac because aac is marked <b>experimental</b> (at least on my system)
"trustedads" has nothing to do with this project. Use m_ExtensionId.
Good question. I was under the impression that this would not affect REST clients, because the behavior would be effectively the same as before:
* before the change, resources and clients would see html entities in incoming data
* after the change, resources sees literal values and clients see html entities in incoming data

If the clients use the same XStream configuration, they always did the wrong thing, because clients would escape the already escaped values in incoming data (right?):

`client -*server-side escape*-> resource -*client-side escape*-> client`

So after this change, they would do:

`client -*client-side escape*-> resource -*server-side escape*-> client`
看起来用指针就可以了？
This doesn't sound right
you have two independent methods there - unquote " and unquote '. I think it would be nice to separate it to better readability
I think this kind of document refactor should go on a different pull request
Was this block intentionally commented out?  Just wanted to be sure.
If so, since this is a large commit/pull, would it be worthwhile to include a comment as to why it is?
MPLv2 missing.
I installed Git and submitted a change with the XML in a resource.
I would love to see this fixed before we land the code.
Right--ideally, if we can make these hooks support all affiliated packages, then the entry points for them will only have to be installed once, by Astropy itself.
Shouldn't this be self.error and operand.error (same below)
Now i do :)

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Sun, Dec 2, 2012 at 2:09 PM, Luke Steensen <notifications@github.com>wrote:

> In app/helpers/application_helper.rb:
>
> > @@ -1,2 +1,12 @@
> >  module ApplicationHelper
> > +  def avatar_url(user)
> > +    # if we have an image from OmniAuth, return that
> > +    user.avatar_url if user.avatar_url
> > +
> > +    # otherwise, try to get a Gravatar using the user's email address
> > +    # if no Gravatar (or email) exists, use the default image
> > +    default_url = "http://i.imgur.com/NgOB1.png"
> > +    gravatar_id = Digest::MD5::hexdigest(user.email).downcase
> > +    "http://gravatar.com/avatar/#{gravatar_id}.png?s=48&d=#{CGI.escape(default_url)}"
> > +  end
>
> But do you see that line 4 does absolutely nothing under any circumstances?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/23/files#r2287983>.
>
>
I suppose you could make it modal.
This seems unnecessary: class CNetAddr after including netbase.h.
Why make this line longer than it already was?
```php
return strrev(next(reset($parts)));
```
We already use the `aliance{'id':None, 'name':None}` pattern elsewhere. I prefer not to have keys that appear and disappear.
It probably won't be - but I think that's ok.
Space between the `)` and `{`.
ipython profile locate removed
looks like the relationship might be reversed.

unless I'm mistaken (wholly possible) nova imports cinder, not the other way around: https://review.openstack.org/#/c/9199/

I think we need to make sure we get this relationship correct.
To use ```Settings.github.organizations.presence``` instead of ``Settings.github.try(:organizations).present?```
This is exactly the same as the code in path.c (line 492). Can we rename it `git_path_is_dot_or_dotdot` and make it an inline function in path.h and share the code in both places?
It's best to put these {% trans %} blocks inside the paragraphs, so each paragraph contains its own separate string, rather than wrap the entire page in a single block that also includes all the HTML.
Is that regular expression different from \d+ ? If not, I think this one is more readable
On line 40 it should be ```(index === -1)``` and it should really be a braced blocked for consistency.
another place mocking would help
You're right! That doesn't make any sense. It was a left-over from when I wrote that code somewhere else. 

But you're wrong about it running as a daemon. The crontabber.py is a script that runs in the foreground.
> After the mv, I think you need the Z suffix here too: zcat /tmp/landfill-`date +%Y-%m-%d`.sql.gz.Z

No, zcat adds it automatically -- at least under Mac OS X
This looks like a kwarg without spaces around the `=`
I tend to use |ex| as a matter of habit. It tends to work well whether you care specifically about the height of lowercase letters or not. Pixel-based layouts are evil, but I can use |em|s.
@nddrylliog
Just for the record, this was causing the infinite loop (the catch-all's were switched between them)
Maybe we must do nothing if no value comes...
Same here, an enum like kNoFrameNum would make this better
What does this class do, exactly?
whether suggests that a boolean is passed as option value. but it's not. should instead list the valid values.
Should be just `Output`.
ok i will remove this line.
you don't need this flag anymore
So, if I get you correctly, we are reinventing a way to "fake" plural messages? The source message has a convention where we have 2 messages separated by a pipe? If that's the case, then it should be documented.
It might still be better to use `0 === strpos('- ', $this->currentLine) && isset($this->currentLine[2])`
we want to avoid printing this unless the file is going to be compiled.
I made mistake. Should be 'ident'
Nevermind, I noticed the spec file is responsible for the log dir creation.
Talked IRL about test spies, mocking, and RSpec's `expect` syntax. Going to change this to using Bourne's stubbing and spying and maybe try RSpec's `expect` syntax in future features.
I think should include a `with` clause to make sure we're invoking the correct parameters.
Can you make sure that this line is wrapped to 80 characters? And do the same for the line with Action 3 (i think line 103)?
Heh, sorry Larry, that's not what I thought we'd agreed on at all!

I expanded on the mailing list.  As I said there, I'm ok with us just doing this code review as-is, and fix the general case later.
Maybe better to leave the original code here? (was "a" : "w", no "+b")
For such a complicated format string it might be better to use named substitutions (e.g. what are those zeros in the second and third positions?).
Is this data file publicly available, or do you have permission to use?
Another place where message could be a (const char *) and then we wouldn't need a cast. not a blocker though
should this return after `finalize_request`?
Совсем не понял этого куска кода. В чем цель-то была?
A method could be idempotent if given the same object state *and* state of the arguments passes in, it always returns the same response.

It just gets more difficult when arguments are accepted, because you have to then key the response by duped/frozen arguments. `ActiveSupport::Memoize` used to do this before it was removed from rails, and `Memoist` does now.
I'd turn the question around and say is there a reason not to use a real object? I would tend to default to using real objects where possible. In this case I think using a real object makes it marginally clearer what the returned value is likely to look like.
these ids are pretty rediculous, we will have a terrible time maintaining them no? how hard would it be to put a prefix "locale_" on all your ids so that i dont delete them because i dont know what they do... :(
`return uiFront.length ? uiFront || $( this.document[0].body );`
Strings always use double quotes.
nit: you can use `this.popupContainer.addEventListener('transitionend', (function wait(event) { ... }).bind(this));` instead of `self`
I don’t think `role="dialog"` makes any sense here. And `banner` is misleading, imho.
Sorry, forgot to clean this a little bit ;-) Doing it right now ;-)
Add following comment above:

`// XXX: to be replaced by long-press context menu`
how to know that in this point?
nit: s/have//
@timdream If the third param is not given, an error will be fired, see asyncStorage.js:line 88
This 1 when no parameters is to add a default empty row of any type if no value istn?
On 14/06/2012 08:03, David Flanagan wrote:
>> @@ -0,0 +1,337 @@
>> +/*jshint curly:true, latedef:true, undef:true, browser:true, devel:true, loopfunc:true */
> Neither of these files include copyright or license information, so we should include a README file at least in the js/ext directory that says where the code is from, who wrote it, and what license it is released under.  Maybe ask @fzzzy where he found the code?
>
> @vingtetun: do we have a general policy about how to handle code like this from external sources?

We don't have any policy for the moment. Maybe that's time to make one?

@davidflanagan If the code is what I think he come from 
http://paul.cx/public/ogg.js/, which is the site of @padenot. (Mozilla 
intern). He has wrote this code during his free style though so it could 
be a WTF licence but we need to ask him.
OMG, good catch!
Can't you translate it at the same time you give it the attribute?
The naming convention used in the project is Capital_Capital not lowercase_Capital. Please adjust.
Please move the `400` into its own constant like `MINIMUM_TRACK_LENGTH`
Why delay the load? Since loading a scheme can fail, it should fail as part of the configuration process. Also, not adding delay on the first caller.
Why do you need to do this? Can't you just load them all and use something like a Factory to get the right datastore?
Break each of these up into their own lines and sort alphabetically.
Does making this a set really do anything?
This is not a CSS tweak. :)
Where can I get one of those? Does it come with bacon bits?
nitpick: should this be "not self.codebases" or "self.codebases is not None"? Is "codebases={}" ever legitimate? There are cases where "no one will do that" can happen (same arguments as why "if False:" or "while False" is legal). Again, this is a nitpick, so feel free to ignore :)
Looks like you need to change the keyword argument here, too.
Is it all passing parameters are type of CCObject*?
If so, i think you can change to 

    dynamic_cast<CCObject*>(pTarget) == TARGET
I don't understand why you added the ``else`` here and moved the logic of the ``if`` in a second check
Agreed. please review updated PR.
Try to use QByteArray instead as it deallocates memory itself:
QByteArray data(len, Qt::Uninitialized);
If you don't give a port_number argument to dataplane.poll it will check all ports.
I don't like these duplicate if statements too much but adding a helper just for that?
Had to move this into the LeapCA namespace so the type column would match
aren't they mostly the same? the underscore version appears to have an extra argument, but is that all?
Wouldn't that have to be this?

    if (!err && r && r.urls) {
      // udpate db etc
    } else {
      if (err) logger.error(err);
      httputils.badRequest()
    }
Changing this line is the point of the TBD cert chaining work. @lloyd and I are meeting with Ben soon.

To land the patch, we can revert this line to production code.
EJS has a default escape function that gets included, and we have the ability to override it: https://github.com/visionmedia/ejs/blob/master/lib/utils.js#L16
ok, sounds good.  I had thought of this being a sort of "try before you buy" thing where you can fill out some fields and say, "now what were the batch names again?" and throw this on to show you what you'd be acting on.  Then replace this with the cron_batch field you wanted.  but this is probably more clean and righteous.  :)
Nit: this is a named method, so no space is necessary before the opening brackets.
I don't think this should be marked as a property, as it performs an action. I could be wrong about that so maybe someone else wants to comment on this.
Already moved the logic into manager class.
Typo on 'skeleton'
Perhaps scope should own doing this, making this entire class unnecessary?
Shouldn't these be in a separate, optional script rather than in local.sh?
Please use ``recentFileHandler``, member variables should use lower camel case.
Probably better to split this into two methods for the different types of arguments
there should be a better way of doing this. as is, im not comfortable with having this code in bootstrap – even if it meant not supporting flyout menus.
cacheMechanism should be SimulatedCache
This is a backwards incompatible break. We should add it as a separate interface, and then implement it in the concrete implementations we have; anything that requires its existence would check against it before operating on it.
I thought standard for keys now is lowercase undersored
As I said, we don't need to incur the cost of a function call where instanceof would have sufficed.  This method should only deal with $class, $type comparisons, not $object $type comparisons.
Actually, we should test for Traversable, and, if it is, use Zend\Stdlib\ArrayUtils::iteratorToArray() to cast $options to an array.
That may be true for very long strings (no point to keep scanning when you have a match.) I doubt you'd see a performance improvement here.
IMO you don't need to call counts if you will not sort by them.
This wan't a C/P fail, but a brain fail.  I editted the wrong docstr.  That explains why i remembered doing this twice.  ;)
I don't think these are needed. `show*()` will be triggered by hashchange anyway.
So paged might be the wrong syntax. I can change this. Looking at it a second time, I should change all 'paged' >> 'get_page_name'. Since that's actually what it's for. Then change the 'base_url' >> 'page_name'. That should add a level of consistency.
I also have same question as @HosipLan
I'm not sure if `profilepicture` -> `avatar` is worth the change. On some sites it is actually called your profile picture, on others it's an avatar. There is no general consensus, so I'm in doubt about the change being 'better'.
example layout:

```
VOUCHED = 'VO'
SOME_DICT = {
  VOUCHED: 'Vouched'
}
```

Then here:

```
from foo import VOUCHED

if VOUCHED: # not 'VO'
   pass
```

Now if there is a typo, it will cause an import error and not silently break.
This applies to all usage of 'VO', 'PB' or additional privacy options.
You can do
```js
totalPerIssuer[issuerName]++
```
Why are we calling the Youtube Wrappers canPlayType?
use double quotes around the `?` and add whitespace around it, as well as around the array index
2 many blank lines
maybe I'm missing something, but why do where do we pass template_kind and not template_kind_id ?