buffer.c: Fix crash in SmashBufferElement

The element is allocated with g_slice_new, so must be free'd with
g_slice_free.

Broken since commit 2ce35292b9e96da38cb56878005aba20891689eb:

    Convert board objects to GLists of g_slice allocated memory
Lesstif + GTK HIDs: Ignore ISO Level3 shift modifier key

This key press is found on some international keyboards (e.g. Spanish).
If we don't ignore it, PCB complains about the key not being tied to
an action when it is pressed.

From the committer, Peter Clifton <pcjc2@cam.ac.uk>
...
Thanks to Gabriel for reporting this and providing the patch for
Lesstif. I have updated the patch to make the equivalent change to
the GTK HID as well.

Signed-off-By: Peter Clifton <pcjc2@cam.ac.uk>
move.c: Adjust the object counters when moving objects between layers

This fixes a crash introduced by
commit 2ce35292b9e96da38cb56878005aba20891689eb,
"Convert board objects to GLists of g_slice allocated memory"

It doesn't fix entirity of the defect reported in that bug, but
it restores the prior behaviour where PCB would hang, not segfault.

Reported-by: Colin Bennett <colin@gibibit.com>

Affects-bug: lp-783640
buffer.c: Update polygon r-tree when adding a polygon to the buffer.

This resulted in a crash when rotating a buffer containing a polygon,
as the polygon r-tree associated with the buffer was NULL despite the
polygon count being non-zero.

Reported-by: Gabriel Paubert <paubert@iram.es>
Fix Mark size math wrt unplated holes.

When computing the Mark size, check for the first pin being a hole
and use the drill size rather than the copper size.
Avoid top/bottom issues with layer deletion.

PCB does not currently support boards without a top or bottom, so
prevent the user from deleting them (they'd need to reassign the
top/bottom groups first).
Add option to specify gerber output file style.

 --name-style <fixed|single|first|eagle>
                        Naming style for individual gerber files

Default is "fixed" which uses a fixed name (foo.top.gbr) for each layer.
"single" uses the layer's name if there's exactly one layer in that
group, else the fixed name.  "first" always uses the layer name,
choosing the first layer in each group for the name.  "eagle" mode adds
a three-character suffix instead of a separate type and extension.

Affects-bug: lp-700877
Ignore *.pcb files on generating library

Closes-bug: lp-699261
Don't register the PNG hid if there are no file formats to use.

In some cases, the GD library may not have any usable image formats for
us to use, resulting in an empty filetypes[] table.  Rather than trying
to accomodate an empty table during export, it's easier (and perhaps
better) to simply not register the PNG hid in that case.  Thus, the
exporter is simply not available when the table is empty.
Fix typo exporting plated vs unplated drills.

Closes-bug: lp-785463
hid/gtk: Cleanup conditional code because GTK 2.12 is required now

Closes-bug: lp-699510
Fix warning for gtk describing menuitems

With GTK+ there are no 'describing menuitems' avaiable (the out-grayed items
in lesstif-GUI). For this reason, the items in gpcb-menu.res are ignored and
a warning is displayed at the message-log.

This patch fixes this by removing these describing menuitems for the gtk-GUI
and renamed the described items to a more explaining label.
It also added mnemonics for these menu-items.

Closes-bug: lp-769815
Fix doku for invisibleObjectsColor (color)

Closes-bug: lp-699306
Fix refcard (missing footnote and add rotate buffer)

The shortcut 'shift-F7' for rotating paste buffer by 90 degree
is added as suggested in bug LP-699391 (formerly sf-1112590).

Fix footnote used in the tabular environment.

Closes-bug: lp-699391
Reviewed-by: Krzysztof Kościuszkiewicz <k.kosciuszkiewicz@gmail.com>
hid/gtk: use GTK dialog for confirming file-overwrite

Since GTK 2.8 GTK provides an dialog for confirming file-overwriting.
This dialog will be introduced by this patch. Needless code which was
used for this will be removed.

Closes-bug: lp-699508
Reviewed-by: Krzysztof Kościuszkiewicz <k.kosciuszkiewicz@gmail.com>
add more crystal footprints to m4 library

Currently m4 symbols contain one footprint for crystal holder (HC49),
wich is not accurate, pin spacing is a bit too big and the outline is
too small.

This patch adds several m4 crystal holder footprints of different size,
2 or 3 pin, both standing and laying.

Closes-bug: lp-699440
Reviewed-by: Bert Timmerman <bert.timmerman@xs4all.nl>
Reviewed-by: Krzysztof Kościuszkiewicz <k.kosciuszkiewicz@gmail.com>
hid/png: draw zero-length arcs properly on export

Closes-bug: lp-699314
Reviewed-by: Patrick Bernaud <patrickb@chez.com>
Reviewed-by: Krzysztof Kościuszkiewicz <k.kosciuszkiewicz@gmail.com>
gEDA-dev: Gerber hid code cleanup

New patch is as follows (sizeof and casts fixed):
gEDA-user: PCB: option dumpmenu missing

A patch to remove this from documentation (and one variable from the
source) is appended.
Kind regards,
Felix

Am 25.05.2011 19:11, schrieb DJ Delorie:
> I think that option is a leftover from my initial HID conversion.
>
> It would have been lesstif-specific anyway, the gtk hid has its own
> menu file (gpcb-menu.res, same locations)
>
>
> _______________________________________________
> geda-user mailing list
> geda-user@moria.seul.org
> http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
>

>From 94458c63ae97135964c41f4966b9cdf65ee4ec27 Mon Sep 17 00:00:00 2001
From: Felix Ruoff <Felix@posaunenmission.de>
Date: Wed, 25 May 2011 14:36:34 +0200
Subject: [PATCH 50/50] Remove commandline-option 'dumpmenu' from docu and source
hid/gtk: Fix tooltips

Closes-bug: lp-786733