labofsahil/github-event-dataset-2012 huggingface dataset:
во-первых надо чтобы после номера тикета был пробел (FOO-123Fixed - неверно).
во-вторых допустимы конструкции вида "WIP on BAR-234", что также не будет правильно отрабатываться.
*scoped_array
The corrected value is discarded.
This could just be my perl knowledge coming to kick me but "until" to me suggests it will be fired until some form of condition is met.  This sounds more like a "first"?
I'll test it ASAP.
It has a questions mark because I wasn't sure how GWT handled Django...
What must i do, that npc 19668 (http://www.wowhead.com/npc=19668) learn this spell 63619 (http://www.wowhead.com/spell=63619)?
map 571 has 4 army of the dead spawners, with aura 49099 . That keeps summoning new zombies. But i tried disabling them once already, and it didnt work. will try again.
@raynar I disabled it, even tho noone has that spell according to db
why do you need a waffle switch if you already have a `settings.POTCH_MARKETPLACE_EXPERIMENTS` flag?
This gets the job done, but it'd be easier to read and generally nicer to have a trousers struct like

struct TR_CERTIFYINFO {
  union {
    TPM_CERTIFY_INFO info1;
    TPM_VERTIFY_INFO2 info2;
  };
};

Then unpacking could be done in a function that uses the right types explicitly.  As it is the code confused me a little, seeing a TPM_VERSION struct unpacked as a UINT16 made me think it was a bug.
No, it's not necessary.
I wanted to perform formatting on a selected code and I think I have made a
mistake and it formatted the entire file.

-- Amin



On Thu, Feb 23, 2012 at 4:33 PM, Joe Tessler <
reply@reply.github.com
> wrote:

> Ah, I see. If we want to be pedantic, we could use the [formal style](
> http://www.oracle.com/technetwork/java/codeconvtoc-136057.html), which
> states the following:
>
> > Four spaces should be used as the unit of indentation.
>
> Personally, I prefer 2 spaces, where every tab character is always
> expanded to 2 spaces. However, is it necessary to convert the indentation
> of the entire file like this?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/amshali/OpenBook/commit/64befabcabb6b2e1b66ec1bcd2e146f8e90d8f06#commitcomment-1004737
>
Is there simple fall-back support for an identity transform? If so we should make this the last argument and make it optional.
Thanks for the reminder. Working on it now.
`MonadIO` in the signatures of `register` and `release` as well as the class context?
can we add more to this little talk??
i tried it with modifying code, but when i try to start the server i get errors.
Does this even need to be a member value? It doesn't look like it needs to live beyond PollEvents in any case.
But Three.js has supports for only normal maps, am I right? The JSON loader wasn't doing anything with the old "mapBump" material property but was looking for a "mapNormal" which was never found. Since the loader doesn't loads bump maps maybe its safe to assume that every map is a normal map.
I've carried the discussion over to the pivotal github https://github.com/pivotal/jasmine/issues/174
I don't see any value in having an empty function with an argument, so I don't agree with this change.
too much typing!
That totally makes sense. I will change the DOM component to bind to that event instead.
finally.  Thanks for moving this over.
If comment stuff like this out, just better to completely remove it.
@vanraz и зачем нам writeToConsole() ?
суровые нижегородские программисты всё делают руками. без врапперов. :)
This one may probably conflict with one of my commits. But this won't be a big job to resolve the conflict.
This change breaks a bunch of my sharers that have UI that cannot auto share. It's ok for an item to be invalid, In many cases, during show the rest of the data it collected. This breaks the twitter and linked in sharers if you don't pass enough data in the item.... Like for twitter if you don't pass a status value it can never show to let you type status.
Por eso, no está bueno esto para que lo metas en un commit (y menos en 2, uno pone y otro saca), probalo en un branch tranquilo, pero que no se manche la historia =)
no need to line-break
Is there any reason why this try-finally is used over assigning to a variable, resetting this.node.parenthesized, then returning that variable? Not that toString performance is important, but try-finally seems overkill here.
This is been done on the profile page
also MOAR COFFEE
I'm concerned about duplicating the batch script logic. The only real difference seems to be the addition of sys\ruby\bin to the path and the `%0 --puppet` part. If we modified install.rb so that it could just generate the wrapper scripts that we want and in a directory that we specify, then this script could just do the following (where facter.bat is the dynamically generated script).

<pre>
set PATH=%PL_BASEDIR%\sys\ruby\bin;%PATH%
call %FACTER_DIR%\bin\facter.bat %*
</pre>

Actually now that I think about this, the facter.bat and puppet.bat scripts that install.rb generates are completely static (they used to be dynamic, but that's no longer). We could move them to `conf\windows\facter.bat` and either `ruby install.rb` or the installer could copy them to where they need to go.

Same comment for puppet.bat below.
`it "allocates..." do`
No `should` :wink:
Don't forget to add this new variable to the docs in the downloader.
But now method regenerateId() should look simple: 
 
regenerateId() {
         session_regenerate_id();
        return $this;
}

"If" nothing changes ..
I don't want to drag this out, as this code isn't even in the critical path, just what I would have done:

                final whatever handle = world.getHandle();
                for (int i = 0; i < 256; i++) {
                    biome[i] = handle.getBiome((x << 4) + (i & 0xF), (z << 4) + (i >> 4));
Oh word, there is something I don't get going on with the "fork and edit this file" functionality on github.
Unfortunately the reasoning behind it is lost on me.  I think it's helpful for others who want to use our code to see how it works so-to-speak...
interesting...do you have backtrace?
And the dependencies for zlib?
In my change, you can see that I add a verification to check if the itemText is empty, if nothing being selected.
protip: wenn man kommentiert korrekte kommentarzeichen für die jeweilige Sprache benutzen.
Only for Spout Team Members.
surround $pid by attr() function (I know this is anal, but this is best way to heavily protect against cross scritping attacks.
we call print_sprint_header two times, one for request and one for response, and if I open the file in 'w' mode the user only sees one of headers
*\*Cough*\* No one saw this.
New controller : usercontroller added
login with md5
add form : Db_NoRecordExists validator
..that will be more complicated. this way is enough
Noted. Glad the change made it in one way or another.
Looks pretty great, love the snappy text.
In this commit, UV was also fixed.
This is my test page.
Doesn't matter, don't mix an addition with a bunch of formatting only changes.  Makes it more difficult to see what you actually intending to change and didn't accidentally change something you didn't mean to.  Its bad form, please stop doing it.
class_attribute was introduced in ActiveSupport 2.3.12; does it make sense to just bump that gem dependency?
On namespace __init__'s no need for old try/except cruft.
Yeah c'est nickel
Sorry, which link?

On Sat, Jan 21, 2012 at 11:43 AM, Michael Bolin <bolinfest@gmail.com> wrote:

> Sorry, I took it down after I discovered the invalid max version. I want
> people to get it from add-ons going forward so it should auto update.
>
> Sent from my iPhone
>
> On Jan 20, 2012, at 6:16 AM, mbohy<
> reply@reply.github.com>
> wrote:
>
> > Currently this URL returns a 404 error.  Does it actually go somewhere
> for you?  Maybe it only works for the submitter while it's being reviewed?
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/bolinfest/chickenfoot/commit/97fcf004a2cc9fc7ef24a39462badb338122fc1d#commitcomment-886093
>
I believe this change fixes a bug which I've observed (in 7.1.6). In the old code there's an obvious race condition - _idleTimestamp could become zero after it is tested but before it is used to compute the idle expiry time. This would cause the connection to immediately be marked idle, and I've seen exactly that on a loaded multicore system handling a lot of short requests.
FYI, the changes I've commented on are here: https://github.com/hubsmoke/sprinkle-stack

I'll send up a pull request if I get the default variable stuff working
I'm not sure if there are differences between different Mailman versions but I'm using Mailman version 2.1.14-1 and on it the /members/add form defines `'send_notifications_to_list_owner'` instead of `'notification_to_list_owner'` so this might be wrong or maybe there should be some checks for using different variable names for different Mailman versions?
This is fixed in another pull request now and it checks the readyState of the document.
Okay, yes it's that. However either i'm missing something or the wiki is. 

* ServerInfoChanged
* <Network Flags><? newname:string ?><? new max number:quint16 ?> - Tells the client something about the characteristics of the server changed
* Network Flags: hasNameChanged, hasMaxNumChanged, hasDescriptionChanged

Fine, i need to define ServerInfoChanged in Commands enum. Then if those values are different from the old ones, i got ahead notifying(). But we have 3 flags hasNameChanged, hasMaxNumChanged, hasDescriptionChanged when we're just sending 2 parameters (excluding the Network Flags).
I keep some terms in english, like fork, for example, would be very weird an expression like "tenedor el código" :)
Muzes pouzit `@android:color/white` a usetrit par bytu.
- No writable filesystem ( with the exception of a /tmp directory used for storing temp logs and asset staging )
- Expensive
- Limited platform support
WaypointMovementGenerator::LoadPath: creature King Ping (Entry: 32398 GUID: 151959) doesn't have waypoint path id: 0
WaypointMovementGenerator::LoadPath: creature Torgah (Entry: 33872 GUID: 202314) doesn't have waypoint path id: 0
Segmentation Error
whoops ... this commit is not OK

the debian/ dir is missing ... apparently forgot to _add_ it..!!
I think the item condition thing comes from another commit.
Yes, sorry - I meant to release that as a separate change.  It was generating warnings about signed/unsigned comparisons.
Comment is out of date
Error report:
03-09 13:07:38.761: E/WindowManager(16720): Activity com.imps.activities.MyCard has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView@2b02f228 that was originally added here
03-09 13:07:38.761: E/WindowManager(16720): android.view.WindowLeaked: Activity com.imps.activities.MyCard has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView@2b02f228 that was originally added here
03-09 13:07:38.761: E/WindowManager(16720): 	at android.view.ViewRoot.<init>(ViewRoot.java:265)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:148)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:91)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.view.Window$LocalWindowManager.addView(Window.java:424)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.app.Dialog.show(Dialog.java:241)
03-09 13:07:38.761: E/WindowManager(16720): 	at com.imps.activities.MyCard$ShowProgress.onPreExecute(MyCard.java:287)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.os.AsyncTask.execute(AsyncTask.java:391)
03-09 13:07:38.761: E/WindowManager(16720): 	at com.imps.activities.MyCard$1.onClick(MyCard.java:105)
03-09 13:07:38.761: E/WindowManager(16720): 	at com.android.internal.app.AlertController$AlertParams$3.onItemClick(AlertController.java:878)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.widget.AdapterView.performItemClick(AdapterView.java:284)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.widget.ListView.performItemClick(ListView.java:3518)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.widget.AbsListView$PerformClick.run(AbsListView.java:1902)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.os.Handler.handleCallback(Handler.java:587)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.os.Handler.dispatchMessage(Handler.java:92)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.os.Looper.loop(Looper.java:123)
03-09 13:07:38.761: E/WindowManager(16720): 	at android.app.ActivityThread.main(ActivityThread.java:3701)
03-09 13:07:38.761: E/WindowManager(16720): 	at java.lang.reflect.Method.invokeNative(Native Method)
03-09 13:07:38.761: E/WindowManager(16720): 	at java.lang.reflect.Method.invoke(Method.java:507)
03-09 13:07:38.761: E/WindowManager(16720): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:862)
03-09 13:07:38.761: E/WindowManager(16720): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:620)
03-09 13:07:38.761: E/WindowManager(16720): 	at dalvik.system.NativeStart.main(Native Method)
Then what does this Update do basically ?
Hi,

Noticed your fork and this branch. Wondered if you've got gitteh to work with the latest version of libgit2? I'm getting a few compile errors that I'm slowly going through and fixing, but I don't want to duplicate work! Is there anything specific you're fixing, or were you just trying it out?
width, height should not be ignored - maybe add a TODO if you plan to use this later (or just remove the constructor).
The .DS_Store files dont need to be there but they wont have any impact on the project.
But maybe it should. I always thought the cost was higher to remove rails to keep one player from destroying the other's rail system. It would be nice to have a separate key mapping to remove rails (defaulting to the same as place rail).
Although I could have used panel*Colors I decided to split the menu variables into menu* and menuContent* (an alternative could have been menuSecondary*)
Unless you explicitly want to find the last match, using a return inside the loop here is cleaner and faster.

Or with Guava:

    OSPFProtocolEndpoint endpoint =
      (OSPFProtocolEndpoint) find(lProtocolEndpoint, instanceOf(OSPFProtocolEndpoint.class), null);
    return (endpoint == null) ? null : IPUtilsHelper.ipv4LongToString(endpoint.getOSPFArea().getAreaID());
iyo, las tildes se ven raras, sabes porque puede ser?
@will-moore: System.err.println in LoadDefaultsEdit,
thx for the feedback. will revert that.
We should include at least one tag for all projects. See https://github.com/mozilla/input-tests/blob/master/mozwebqa.cfg as an example. In this case `marketplace` would be suitable.
Actually.. This isn't needed...
This commit break the order in backoffice.
JAJAJAJAJAJAJA (coincidencia no creo...) JAJAJAJAJAJAJA
What the fuck is this...
This commit was just getting my branch up to date.
As benji07 said, just add the revision to you deps file and run "php bin/vendor update"

Here a part of my deps file :
[SensioGeneratorBundle]
    git=http://github.com/sensio/SensioGeneratorBundle.git
    target=/bundles/Sensio/Bundle/GeneratorBundle
    version=dd37fc4487
That we got here.  When trying to debug this, you're going to care about when the content provider was acquired and released.
My personal inclination is that there's too little time between a 1.1 release and a 2.0 release to bother. If we keep migrations messy — add a few more in, even, to manage the transition — then we don't need to force users to update twice to get to 2.0.
Hey a suggestion for commit messages in the next sprint. After the project people looking at the history will not have access to Jazz so we should prefer to write commit messages so that the functionality can be deduced from the title. Here "Working implementation" doesn't mean anything without going to Jazz and looking up the work item. Thanks.
`/facepalm`
Alright, I looked over it, and thanks a lot for putting those messages in. I'll try to do that next time on my own
やっぱり技巧的ですね。
なんぜこの判断が必要なんでしたっけ？
Try this:
CONFIG_LGE_FBCON_INACTIVE_CONSOLE=y

Search for it in menu config
A superfluous closing cs:style tag? No cookie for you, @cparnot!
Are they not sorted when the JSON view returns them? If not, can you make it so that the JSON view does sort them correctly before returning them?
Maybe add functional to the list of paradigms?
cuz we have already loca creatur etexts
yeah i realised i forgot it, but it works for me anyway, added it now
The link does work, if you copy and paste into a new web page, but the hot link does not work. I am not the only one who has the problem.
Сейчас посмотрим. Избранным никогда не пользовался, поэтому не протестировал.
Hi Shay,

May I suggest using 2.3 version of assembly plugin, which is the latest one ?
See : http://maven.apache.org/plugins/maven-assembly-plugin/

HTH
David.
Goal always is to stay below 80-100 chars per line for small displays. And $g is just set in the function, no chance to colide, etc. So: valid.
'geneNames -- renamed (used to be called 'gn'); ' can go
Back-compat for `Y.DOM`?
I actually just used the docs inlined from the code example. Will bring back the error event part :)
This only works for exporting. Please consider preview also. You may need to save code to a local storage. Or simply put javascript in a script tag of HTML when previewing.
So I haven't done any benchmarking, but do we have a handle on how much slower this is than the C sparsity building we used to do?
Ah right, thats correct. I'll remove it.
verrry nice!
Who has this method?
Yes, to the best of my knowledge. To quote my own pull request "Locally published artifacts have been verified to run a MultiNodeSpec based test, which should cover remoting"

Is there any smoke test that we have, or should I add a ticket to create one?
I was afraid of non-supported characters, such as `/`
I think we ought to give better names to origCause and msg
Evernote was unable to submit your note for the following reason:
The storage limit for this account has been reached.

Original message information:
From: drewhk <notifications@github.com>
Delivered to: thanhbv.fa84f@m.evernote.com
All recipients: akka/akka <akka@noreply.github.com>; giabao <giabao@sandinh.net>; 
Subject: Re: [akka] Minor cleanups in new remoting (#981)
Sent: Fri Dec 21 08:42:36 PST 2012

To prevent excessive emails, you may not receive another error reply
for the next 360 minutes.
Added tick https://www.assembla.com/spaces/akka/tickets/2684 to 2.1 instead to remove all cross CrossVersion.full when we go to Scala 2.10.0 final.
I've made that change, but I'm not sure if I like setting DATADIR once with the DESTDIR path, or if I should defer that to install (and have to do it each time)
This is done when the file is required now.
Do it in the kw, not in the __init__. And then remove completely the __init__.
Is the initialization is really needed ? It shouldn't be, remove it.
@icmurray 

your right I should pay a bit more attention :)
Same thing here, no implementation nor import.
inappropriate spelling. ;)
|| case is not needed after migration.
I could just implement an object instead... Didn't see that  ;)
Ugly workaround ;-)
It causes lots of stuff to fail now that the local runner no longer injects the current working directory into `PYTHONPATH`.

(I'm running the tests without `mrjob` installed anywhere in my path.)
Maps don't need to be generated.
Bag will be generatable as well
Just a reminder to make sure this get set back to `master` before merge.
Это потенциально опасно тем, что запишется неверная программа. Потому как раньше она писалась в `car_program` и никто её не видел, а теперь в `program`.
Правда, можно считать, что программа всегда заполняется на экране звонка.
we usually give input a attribute "name"
like... \<input name="username" type="text" \>
please help to modify all input tag
Can we document this?
Duplicate version and author?
Oh you are right, I was meant to change that. Must have forgotten. thanks

On Thu, Oct 18, 2012 at 5:25 PM, Filipe Nepomuceno <notifications@github.com
> wrote:

> In
> library/src/main/java/net/sourceforge/cilib/clustering/iterationstrategies/CooperativeDataClusteringPSOIterationStrategy.java:
>
> > @@ -124,6 +126,11 @@ public void performIteration(CooperativePSO algorithm) {
> >                         ((CentroidHolder) contextParticle.getCandidateSolution()).set(populationIndex, ((CentroidHolder) particle.getCandidateSolution()).get(populationIndex));
> >                  }
> >
> > +                if(contextParticle.getFitness().getValue() < contextParticle.getBestFitness().getValue()) {
>
> This assumes minimization, it's better to compare the fitness objects i.e.
> if( fit1.compareTo(fit2) > 0)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cilib/cilib/pull/86/files#r1879970>.
>
>



-- 
Regards,
Kristina Georgieva
MSc Computer Science
CILib Research Assistant
I may have mentioned before how I think this early return syntax is very confusing. I'm not alone in this (http://en.wikipedia.org/wiki/Return_statement#Criticism). It has all of the same problems as GOTO statements in FORTRAN, except that it's never necssary in C++. In general, I'd prefer if this sort of statement syntax weren't the code, but that's just my opinion. 

For example... Is it your intention for the sendOn function to quietly do nothing if the message is dead or the direction is neither up nor down? The way the early return is used here (in both instances within this funciton), that is the case. A message with no direction is not validated or further initialized, and it throws no exceptions. Is that the goal?

A cleaner way to write this might be 

```cpp
msg_ptr me = msg_ptr(this);
if (dead_) || (dir != UP_MSG && dir_ != DOWN_MSG ) {
    throw MsgException;
} else if ( dir_ == UP_MSG ){
    autoSetNextDest();
    path_stack_.back()->trackMessage(me);
} else if (dir == DOWN_MSG)
     path_stack_.back()->untrackMessage(me);
     path_stack_.pop_back();
}
validateForSend();
Communicator* next_stop = path_stack_.back();
makeRealParticipant(next_stop);
curr_owner_ = next_stop;
```

If you can confirm that this function actually behaves the way you want it to, I'll overlook this style disagreement, but if the syntax is hiding bad behavior, please consider changing it now and avoiding it in the future?
No, it just creates one at most, that's why this function accepts an  
Option[FailureDetector]
You might need to also add the alpha filter CSS here for IE8 compatibility -- see some recent onyx.css changes for syntax.
I've almost never seen this used in iOS code. Do you have a specific use case for this, or is it just to match `UITableViewCell`?
Agreed in general - left it in here because I thought it warranted discussion, but indeed it has to be either fixed or removed completely
Style: s/Status/status/ and s/ProviderContext/provider_context/ (or possibly providerContext). Only classes start with an uppercase character.

Same goes for NodeCounterProvider.
Next line check this.
Redundant because `ChannelInboundByteHandlerAdapter` implements this method already.
Err, that's if we're running stuff through 2to3. If not then we can leave off the `u` at the beginning and I believe it should still work (though be slightly more confusing).
ну по комментарию этого не понять. напишите чуть более развернуто
переведено же. или надо не только в .ts
By generated code do you mean config/application.rb, db/schema.rb, etc.?
Yes, I prefer your suggestion here.
Could we change this regular expression to `%r{\A\d+\z}`?

It would be great if you change the above too to use the `\A` and `\z`
...to install the +debugger+ gem to run...
this note is hanging out incoherently. What purpose does it serve?
I just wanted to keep the API similar to what we already have https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/cookies.rb#L333-334
Anyway, I'd think about removing this rescue nil thing. @jeremy @josevalim thoughts? do you guys know why this was that way in the first place?
@carlosantoniodasilva: @nikitug did that originally, and then I complained about it ;) I didn't realise that it was a technique copied from @tenderlove though. Personally I found it really odd when I first saw it, and don't really see why not to just instantiate a `Mutex` instance separately. But it doesn't really matter a great deal either way.
I've fixed this with: 8f9c0ea
I still don't much like this bit: we report the exception _and_ rethrow it. But we're at the boundaries of the compiler here and I didn't want to risk breaking something upstream, so I left it.
Where I come from the word is "transform". NEWB
I'd make it a one-liner, but it's just a matter of taste
Que?   I don't get it
See the changes in 06cc844f.
You could probably move the coupon finding code to the promotion model too

 

On 26/09/2012, at 18:12, Alberto Vena <notifications@github.com> wrote:

> In promo/app/controllers/spree/checkout_controller_decorator.rb:
> 
> > @@ -8,9 +8,8 @@ def update
> >  
> >        if @order.coupon_code.present?
> >          event_name = "spree.checkout.coupon_code_added"
> > -        if Spree::Promotion.exists?(:code       => @order.coupon_code,
> > -                                    :event_name => event_name)
> > -
> > +        code = Spree::Promotion.arel_table[:code]
> > +        if promo = Spree::Promotion.where(code.matches("%#{@order.coupon_code}%"), :event_name => event_name).first
> Ok, _cont should be perfect for this. I will update this pull request as soon as possible.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Because
```
In [13]: str((g * f).components)
Out[13]: (Morphism(Object("A"), Object("B"), "f"), Morphism(Object("B"), Object("C"), "g"))
```
I think directly comparing to `[f, g]` (or actually `Tuple(f, g)` as it is now) is easier to grasp.  Do you think I should still show `(g * f).components`?
Right. This was copied off of a line in conjugate(), so I'll go ahead and change that too, as well as any other little things I find.
And by the way, `n**2 + n` is always even, not odd (because either n or n + 1 is even). That's why the formula for the first n triangle numbers, `n*(n + 1)/2`,is always an integer.
please use enumerate to generate the i and the argument, here and above:

```
for i, arg in enumerate(args_list):
    << arg is args_list[i]   >>
```

But why are you targeting only special terms and not just replacing xin with xin/yin globally in the returned series? You don't need to find the xin term yourself, subs will do that for you. In fact, it's very likely that xreplace is the best thing to use in this situation with the returned series.
Oh, absolutely.  Fixing.
This may be my ignorance speaking, but is `<>` python syntax? [I thought it was `!=` … obviously it must work for you so...]
You are right that repetition of code should be minimized. However placing the two lines I proposed in the base class is shorter (no repetition) than using the rather involved decorator and decorating each constructor. Moreover, I really consider the decorator unpythonic and too complicated.

Another problem (that is already exhibited by the original code, but made worse by the decorator) is that this module has never followed the conventions in sympy to have `type(the_object)(the_object.args) == the_object`. Anyway, this is slightly offtopic.

I still advise against the use of this decorator. Though bear in mind that this is my own opinion and I may be incorrect. It may be useful to discus this if you wish.
there should be `raise NotImplementedError` somewhere around here.
Yes. Agreed. Will move it to a new file.
If you use `exprp = expr.xreplace(renamings)` here, your fix will also work for functions.
now that this is in matrix, should the `simplify=True` option be added so the type of simplification (or None) can be selected? See `is_anti_symmetric` for suggested implementation.
walk me through this sometime. looks good.
Gotcha. These formatting issues should be resolved.
You are right! I changed the title as you said.
this is a comment.
It should be in "require-dev" and "suggest"
Isn't this redundant with `uv_pipe_init` taking `ipc` argument?

/cc @piscisaureus & @bnoordhuis
Should we also be validating that the domain, url, key and value are also present?
In addition to this, this particular cleanup behavior is tested in `shouldStoreLatestVersionPerPair` in the `HibernateDomainDifferenceStoreTest`.
To connect to a server instead of 'To look for a server'
Yeah, David Bruant mentioned that. But, the issue is that DekiScript's `let` is actually the opposite of JavaScript's `let`.

In DekiScript, [`var` assigns a local variable within a block, and `let` assigns to a variable possibly outside the block.](http://developer.mindtouch.com/User:rberinger/Error_Pitfall_Examples) (eg. a block being code in the braces of a if conditional)

In JavaScript, `let` does what DekiScript's `var` does, and `var` in JS doesn't do what either of those DekiScript keywords do.

So, we don't want either here, actually.
Which might very well contain an & or a < in one of the values because it wasn't made for output in HTML?
wrong PR. this is part of the events dispatcher
Using $_POST will trigger an error complaining about superglobals. No matter how you use it. I'll use is_set_post() then.
fixed it, using "the location's name and URL"
Same thing on the following line.
If "the board" is the tree that I am developing in, this is not acceptable. Use more fixtures.
K,  fixed (will appear in the next push)
Should be `AUTOLOGIN_SESSION_KEYS_DELETED `. It gives a notice.
For readability, generally it is good to have a separate line between the } and the variable declaration.
should just be an error()
HostInfo instead of HostAgentInfo?
Ok, looks like a good idea. No need to do it right now, I will also pull without changes here.
That's fine, I need to get a repro case of this so I can fix it properly. I thought I covered all the issues with `resolve` in my tests.
So `tests/fixtures/packages/node_modules` (and children) are definitely needed in order to do proper testing in the resource store.  Does the new .gitignore support that (it's hard for me to tell from looking at the rules).
Good catch, will update docs.

The type parameter is used in the recursive call so the function knows which format to test for next.
> Would it be possible to decouple the work on asciidoc from the other changes you've made in this pull request?

I would decouple the asciidoc upgrade, except that flactag needs asciidoc to render  manpages during install.

> Plus autoconf.

Ah. Yes. The autconf of the 4 hour testsuite..
What is this doing? I don't believe we need this.
I don't see how this could work for a built/installed instance of Iris - it won't have the "docs" folder.
typo: equivalent
Use $ instead of > for the prompt.
This change breaks some of our applications. It looks like if `location` is an `OpenLayers.LonLat` then `this.anchored` is always set to `false`.
You need to add spaces here between the brackets and the inner arguments. That's the standard we've been following so I think we should maintain it throughout all files. For example it would be loadVtt( "cue-timings/start-time.vtt" ); You would need to change all you're function calls to look this this as well.
Why are we not allowing `replaceWith` on `documentFragment`s (or other `nodeType`s for that matter?)
Agreed. Fixed on the PHP side by casting the (potentially empty) associative array to a `stdClass` object. That way `json_encode` will always encode it to a plain object.
I guess I got it. Because the string is passed to the controller class and gets formatted inside the class?
We should keep our terminology clear. This is a probability mass function, not a probability density function.
I recently changed the way this works, on the auth-configure-services branch (commit 119aa5e1110a9f25d0a696b41ab11ec058d0eb5c). Please modify this to fit the new pattern.
I just mean group the lines next to each other if that's okay,

```
depends_on 'cmake' => :build
depends_on 'gnutls'
depends_on 'libidn'
and with `--env=std` this should work. Have you tried?
Use a list:

```rb
system "python", "setup.py", "install", "--prefix=#{prefix}"
```
Try `#{HOMEBREW_PREFIX}` instead.
Are these caveats really necessary?
That sounds better than my wording. Thanks.
Should have a `cause` that describes the compilation error.
Perhaps this does raise the issue of an obnoxious interface inconsistency, but in my mind it's pretty much "Overlays and other kinds of data" so it should be ok...
OK, this is copied from heritage code, but you can write this nicely now in one line.
nit: always use LinkedHashSet, never use HashSet. Nothing is worse than having a bug that won't reproduce because it only fails if the iteration order is just so.
Jesse OCD rule: never more than one blank line in a row. And blank lines between close braces are almost always useless.
Started as something else.  Done.
To avoid me calling write_u8(...) ten times when in fact there is only space for five in the buffer.
Shouldn't this be relative? `page = modules/home.tpl`
nope, removing those - thanks for pointing that out
Nope, Coffee wraps everything in a Closure anyway. It's impossible to create a global without doing `window.foo = `
This part fell out of date a bit too: the generic 'line' and 'character' properties have been replaced with a bunch of more specific values.
Seems like this one at least should probably be localized...
Apologies, definitely typo - I'll fix shortly
We should cache $(".sidebar") as a var here instead of querying each time.
Good point.  I've changed this to instead add the default bindings when a command is registered.
It's generally good for all of your core javascript to be actual legal javascript. I usually have a single place where I define all of the variables that I get from the template, and then I pass them in to whatever core class/function that needs them.
personally, if you're doing anything with a tuple on the right-hand side of a statement, I find it more readable to put it in parentheses.
was there a missing closing div tag for #reportFavorites before this change?
might be nice to clarify what needs fixing here (hard to tell, but with this context doesn't seem obvious)
It's the name of the counter, which is just a human-readable field that is only used in the code.   Any time you want to increment a counter you just call DomainCounter.increment(<domain>, <counter name>) and it will get you the next value(s) you ask for.
typo here : config.fields
Set this up as a def, which seems to be in keeping with a lot of other stuff in Req, but let me know if it makes more sense as a lazy val.
At the end you should then return `value`.
Check the main repository.

I do not know why you used HorizontalRadioRenderer, you could just style the `ul` to be inline?
``` ruby
def foo(bar, baz)
  self.content = File.read(File.join(base, name))
  self.data = {}

  if self.content =~ /\A(---\s*\n.*?\n?)^(---\s*$\n?)/m
    self.content = $POSTMATCH
    self.data = YAML.load($1)
  end
rescue SyntaxErrot => e
  puts "YAML Exception reading #{name}: #{e.message}"
rescue => e
  puts "YAML Exception reading #{name}: #{e.message}"
end
```

:D
Instead of trying to whitelist all the things we might want to include here, let's just make people include a `<head>` in their layout file. This can just steal everything out of that and put it in the actual head.
Can we have a flag (perhaps set by an environment variable) that determines whether to use minified code, or unminified code for everything? Maybe a `minString` variable that's `''` or `'.min'` and you just append it to all file names.

It sounds more complicated, but if we're using this for storymaker-dev, then I want it to be as easy to debug as possible
For some reason I think this looks odd. I'd half say assign i it's value here rather than above but... "shrug"
if both `window.URL` and `window.webkitURL` don't exist, we should probably throw.
CSS based - no images necessary. I can throw it together again if you want.
Isn't there a way to do this with a callback? This seems like an invitation to a race condition.
change that to `if (!url)`
I mean the method args without parens :-)
When we're explicitly testing the way things look in the view, it's often nice to phrase the step like 'I should see x', so this might be:

Then I should see the database state is "([^"]*)"
ha! more evidence that maybe we should go with the singular?
shouldn't it be setFilterQueryOverride?
Yes. I'll add a function to do that.
I thought about that, but what if at some point someone wants to pass in an actual redir path and not just dashboard_redir_path?
Adding and test building with this in the spec file.
And this change broke my git repo:

    $ git submodule update 
    fatal: reference is not a tree: d591c8f7a8e7d279a41b0a8b265c9aaba2e38cac
    Unable to checkout 'd591c8f7a8e7d279a41b0a8b265c9aaba2e38cac' in submodule path 'src/vendor/converge-ui'

I guess this needs some manual step (maybe deleting the directory before that)?

I recommand to revert this pull request so we can get nightly rolling and wait until folks resolve this.
Good call, those were written independently but can be combined.
this should be a Conf variable that we can change. it can still be your home dir for now, but not hardcoded.
Koja je ideja iza ove klase?
Process?
(That is, if you do that, you would remove this part)
Agreed.  Will fix.
I see your point... perhaps add a reference to the later subsection so users don't panic at an unexpected error? That's pretty simple: http://sphinx.pocoo.org/markup/inline.html#cross-referencing-arbitrary-locations
If I add it to ``index.rst``, it will appear separate from the config section. Maybe I should add a ``toctree`` to ``configs.rst``?
Currently l2overlay is the only vnet mode as far as ovs is concerned. If we're making some changes to how this works it really becomes a new feature/fix.
我觉得Request比Req要好很多。
这哥们儿被榨干了。。。恩恩
Thanks, used tabs there, doh ...
Yeah, no problem. That other place you saw it is probably performance-critical, such as building baseX strings etc or messages that get printed all the time.
oops found it
we're not liking the `slideDown` it looks weird... maybe try `roomTopic.fadeIn(2000);`? that would be using the same fade effect that the rotating tips use that are below the message box. if you wanna change it to that we will take another look.
This is a great idea. I'll have to go through the other formats and see which make sense to have this.
The name of the side panel is 'Watch'
I don't that was the case. I don't know if it's a problem :( I don't know which version of tfs are supported...
Perhaps, I can introduce a downgraded version where the parent branch is passed in parameter if the method didn't exists.
But I don't know how to developp or test that :(
The list defines preference order. PNG is chose over JPEG and SVG, when if they are sent together, for example.  But I agree that it is confusing.  It took me for a while to remember what is this.  Probably I should use ordered dict?  Although it is not in Python 2.6.
This is problematic.  The notebook manager and kernel manager eventually will be running in different processes or even different servers.  Their handlers needs to be well separated, otherwise we will have a very difficult time scaling the notebook server.  The question then becomes how does the notebook manager learn about the status of the kernel.  I think the best way is to create a new kernel handler that returns the kernel id+status for a notebook id.  The notebook list can then use this to query the kernel status of each notebook.  I know this complicates the implementation, but I want to be really careful to keep things loosely coupled so we can scale later.  Do you see another way of handling this?
Indeed.  "effect of" is what I intended.
was refering to the dance() method actually although that looks like it's gone now.
productSections copies-in the input parameter, so no need to do this again here
This isn't Perl.
```python
    if options.debug:
        log_level = logging.DEBUG
    else:
        log_level = logging.INFO
```
```
#else
#    define GIT_MEMORY_BARRIER /*no-op */
#endif
```
I was mimicking from wiki.models.Document which also doesn't use SlugField. I'll change it.
I think we prefer double quotes over `\'` in the string
ABICT, self.framework_failure is None here.  Why are we passing it?
Grrr, this makes localhost-fans like me angry because our logins won't work. :P

Not much of a solution right now, though.
r- on the use of the connection. If you have to close the connection you have to do it right (sorry for sounding like a douche bag when saying that). 

How about something like this:

```python
def get(...):
    ...bla bla...
    connection = self.database.connection()  # NOTE: don't make it a class instance attribute, just a normal variable
    try:
       cur = connection.cursor()
       ...stuff...
       return results
    finally:
        connection.close()
```

Alternatively, use contextlib.contextmanager() to create and close the connection. Then it'll look like this:

```python
def get(...):
    with self.get_connection() as connection:
        ...blabla...
        return result
```

I personally don't mind the which way. The `finally:` pattern is pure and simple.
Nit picking. But can we move all the code insode `_do_get_raw_dumps` into here since moving it to a different function doesn't make any difference.
I think you should do `from django.conf import settings`.
Totally not DRY
then we can merge it to the superclass implementation which is already there, but we still need the array based version b/c that works on the concrete array-type.
I am not sure about all docblocks being inheritdoc

i think most of the time these are used when we are actually implementing an interface
the other times it actually comes handy to fill these meaningfully to help PHPStorm
oh duh, can't read. Is there a reason we only do 502 and 503? Just curious. We'll be passing back null to serverError on any other 500 error.
That constant time comparitor that I use in PasswordLib is good if you're not calling it a lot of times. The only problem with it is that since it uses 2 hashes every time, it can be a little bit of overhead.

For general usages, I have another implementation here: http://blog.ircmaxell.com/2012/12/seven-ways-to-screw-up-bcrypt.html 

The only implementation detail is the order of input matters (the string in the users control *must* be the second parameter for it to not leak any information.
@stof it was true but there was no note anywhere that this was best practice so we may as well do it now.
it should be ``null !== $this->getInfo()``
No. I'm not. I'm using Fabien's test example from the original PR and [online tester](http://yaml-online-parser.appspot.com/?yaml=collection%3A%0A-c%0A-d%0A&type=json)
moved the log to line 392
Of course the id assignment is also an implicit cast... but yes explicit casting is not the objective-c way of doing things.

I only wish the compiler would relax the type checking on id property access... seems silly that id.replies is illegal when [id replies] is legal.
I'll remove it in next commits.
(no action required)
This seems as thought it should be exempt.
followed by empty lines after the import block, i think helps too.

var foo = require('foo')
var bar = require('bar')

var Foo = foo.Foo
var Bar = bar.Bar


function blah() {
}
Rather than adding a print function to `riaknostic.erl`, it would make sense to put it in `riaknostic_check.erl` where the other print function is.
since `key_clean` is null-terminated, you can use `json_object_new_string()` and not mention `key_len`. On the other hand, not having to use this string as the key of a json dict, and using `json_object_new_string_len()`, allows us to avoid the `strndup()` to null-terminate `key`. The `strcmp() > 0` above would also have to be changed, to `strncmp() > 0` (which is still logically the same, because if the end of the comparison before the end of `end_key` made a difference, it would change a `<` relationship to a `==` relationship, which doesn't make a difference to `>`)
what's the deal with old/new and why would you use one over the other?
@Sunight 一般 iOS 的官方例子里都尽量用完整的词，类似`curr`, `cnt` 其实都很少见，反正IDE把补全和折行的事都帮你做了，其实不省略也无妨，看那些标准库死长死长的各种名字你就知道了…当然也不是非按这样来，总之按一种习惯来就好了
Well the encoder calls the input Record as not containing what it is supposed to - in other words the Record is an illegal argument for encoding and so IllegalArgumentException is the intended exception superclass. It would be an Runtimeexception if it was impossible to have un-encodable Records, but that not a road I would go down - it is more flexible to allow for invalid states during Record composition.
revert.. you can keep checking it looks like most of these changes should be reverted so that the accordians will work
context.completeStep(OperationContext.RollbackHandler.NO_OP_ROLLBACK_HANDLER);
I think this needs the same logic that is present in handleExceptionInOurTx. At the moment this does not look like it will deal with RemoteException correctly, and will double wrap EJBException's that are thrown.
We use ModelType.UNDEFINED to mean null. So this would work better:

ModelNode fileName = result.get(PlatformMBeanConstants.FILE_NAME); // now it's UNDEFINED
if  (stackTraceElement.getFileName() != null) {
    fileName.set(stackTraceElement.getFileName());
}

The resource description metadata for this will need update to declare it allows null.
This looks like the wrong equation. If your gradient is 0 and your mass is 1, v gets updated to -v? That's like anti-momentum.
I have a question: in some cases, the 'supervised' attribute is determined at instantiation (for example, the SumOfCosts class is considered to be a supervised cost if at least one of its costs to sum is a supervised cost, which is only known when the list of costs is passed to the constructor); if the 'supervised' attribute is a class attribute, would it result in some kind of problem? Or can I override the class attribute with an instance attribute when needed?
I'm really loving this new console, but can we merge in @chrisinajar's version?  I'd like to maintain a cohesive approach to the console across the various bots.  Maybe you can work with him on this (and @chrisinajar, maybe put it into plugapi or create a distinct project for it?)
Take care of indentation here, please.
`SettingsListener.observe` will fire the callback first time to have the caller receiving the initial value, then second time if the setting changes.

We don't need that first time since `mozL10n` localize the content on page load automatically by looking at `navigator.language`.


That's one of the reason why this should go to `mozL10n`. BUT `mozL10n cannot listen to setting change without `SettingsListener` so it's kind of dilemma here.
nit: give a name to the anonymous function
margin space override with 0
nit: _this -> self (as used consistently in gaia as far as I can tell )
nit: aTarget -> target
Nit: as this function is not related to the `Settings` object, would you define it in `utils.js` please?
nit: `numDependencies > 0`
`ClockView`?

(non-blocking)
Thanks, that was a mistake, changed to <code>textContent</code>.
You're right, I'll go over this part of the code again.
I removed these keys from French in order to allow the l10n tool to identify the missed keys.
if libphonenumber depends on the closure lib, it should be in the application js/ext/ dir instead of the shared/js/ one.
I created the methods cause there's more things to do when no messages, like showing an image to the user. If you think it's ok without methods, I have no problem with that either, just wanted to separate code.
move `init()` out.
Right now we can not remove that padding because the keys are using -moz-flex so they will try to fit in the aviable space, so, if  i remove the keyboard padding the keys will be wider.
We will review this as is mentioned in the PR Flaws and future work.
I think here might be a logic bug.
I found that if when the next file matches fileinfo.name === frame.filename
the next frame will become gray.
And if the user swipe it to center, it's still gray.
You are right, that is not needed. But I definitely remember us seeing
problems when the files were not json, but now I can not repeat them :-(

    /MaF
I'd move this to after the s.Set(), to avoid inconsistencies.