labofsahil/github-event-dataset-2012 huggingface dataset:
just log just for debugging purposes. errors will propagate through requests or streams and be handled in the main.
+1 for moving this to the platform.

The `document.mozL10n` ⇒ `navigator.mozL10n` issue is addressed in another pull request.
The this.evt approach won't work since modals should be per app. You likely want an array of modals an a way to map the modal to an app. (can be addressed in a followup)
Add the real bug number. If there is no bug on bugzilla can you open one?
Is it possible that you have a rotation object and not and id? If not you can merge this assigment directly into the previous created object if this.rotation is undefined.
I would return here if rim <= 0 instead of separate test above. Slightly cleaner/smaller
Perhaps a combination of BitConverter.GetBytes and Array.Copy would make this concise.
SG: missing blank line
I prefer space after `+` quantifier
Why test after reading file? Test before we do anything else.
What about passing "version" as a keyword argument with default value  = 0 ?
I would only install ruby and the rubygems if the user doesn't already have them installed. This is because they could have installed them via something like RVM, and this would conflict with that.
`ii` needs a better name - maybe `table_name`?
Improve readability and just call this "entity".
A talk is shown in the order

1. Talk Title
2. Talk Speaker
3. Talk **Room**
4. Talk **Event**

but it's updated in the order 


1. Talk Title
2. Talk Speaker
3. Talk **Event**
4. Talk **Room**

I think the ordering should be consistent to make the experience more user friendly.
``<a href="#" class="...">``
I think you want `x_max - xc[i] - 0.5` and  `y_max - yc[i] - 0.5` as the second input to both of these. `x_max` is exclusive. In other words, no part of the pixel at `x_max` is in the aperture. In other other words `x_max - x_min` = `subdata.shape[0]`
This class seems to duplicate a lot of the functionality in ``client/tests/virt/virttest/standalone_test.py``
In that case, `defaultBranch` should be checked in the constructor, and a call to `buildbot.config.error` if it isn't provided (in the `baseURL` case). Then `branch` could just be used, and `self.branch` ignored here.

I wonder, though, if `branchType` option of mercurial should perhaps be used instead, with just `repourl`, and using the logic of `baseURL` if `branchType="dirname"`?
Not a problem. It would be nice if you guys had some sort of rules I could use to check my contributed code.
why making them static ?
Hmm, nothing in history. Anyway, doesn't look like a big deal, as it doesn't seem libikvm-native.a is used.
Doh, good catch, it has to be removed
Take this out or make it an executable like it says.
I believe this is done automatically by the library.
Same comment for ToS as for privacy policy.  Shall we give our legal eagle friends a heads up so they can make sure that whatever external resources point to or re-publish this text also gets updated?
When I refactor ModelCritrion, I'll do that. I was just fixing a typo here.
...totally isn't.  Will update and repush.
you're missing a closing backtick at the end of `/usr/bin/systemctl` here
checksum确定是String类型。
IMO there should be an API for it. I just don't know what it should be. I do like the idea of making it a module function (e.g. `ConstantStubber.find_original_value_for(constant_name)`) but maybe something less wordy like `StubbedConstants.original name`. Other ideas?
Yes, _'resolves'_, it is the word I was looking for, thank you.
Don't include that, it belongs in your own global gitignore. Same with the below .gitignores
No, absolutely a non-starter. We don't want a top-level exception namespace. Each service should have its own exception namespace.
Please remove `@return` for constructors
You should just override equals() in ItemStack for this, not sure if it's already done.
You can ignore this file.
That's the right way to do binding redirects.  I treats it as a less than or equal to when the max old version matches the new version.  Otherwise, you have to find a way to specify the highest possible version less than 4.0.0.0, which can be weird.
if ride.stream.temp:
`style: '.hidden {display: none;}'` -> `style: '.hidden { display: none }'`
Only if one doesn't pass the STATIC_DEV environment variable.

I'm I'm favour of optimising for the VM route as we should be focusing on
parity with production wherever possible.

On 13 Dec 2012, at 15:25, Chris Parsons <notifications@github.com> wrote:

In config/environments/development.rb:

> @@ -28,7 +28,7 @@
>    # Expands the lines which load the assets
>    config.assets.debug = true
>
> -  config.slimmer.asset_host = ENV["STATIC_DEV"] || "https://static.preview.alphagov.co.uk"
> +  config.slimmer.asset_host = ENV["STATIC_DEV"] || "http://static.dev.gov.uk"

Not sure I understand this correctly, but won't this break the app in
development outside of a VM?

—
Reply to this email directly or view it on
GitHub<https://github.com/alphagov/whitehall/pull/98/files#r2407585>.
I'm adding a comment on that. `PROTOCOL_41 = 512`
```
# ignore when no author
if article.author:
    ...
```
Single empty line before method def in a class
Seems like super should work, so let's use that consistently (except when mutliple inheritance is used)?
http://docs.python.org/library/functions.html#super

Avoids stupid mistakes like specifying the wrong parent class.
The GitHub notification system changed.
Do we really want all comments to be received on this list?
In that case I'll start filtering it...



On 08 Aug 2012, at 19:56, Toon Willems <notifications@github.com> wrote:

In easybuild/easyblocks/n/ncl.py:

>                  self.log.error('%s not available' % dep)
> -            libs += ' -L%s/lib ' % softroot
> -            includes += ' -I%s/include ' % softroot
> +            libs += ' -L%s/lib ' % root
> +            includes += ' -I%s/include ' % root

remark: in Ruby, Strings that can be interpolated are " " and others are '
'. We could adopt this?

—
Reply to this email directly or view it on
GitHub<https://github.com/hpcugent/easybuild/pull/59/files#r1331712>.
Ok, I agree with it getting even more confusing probably. :P

Let's make the paths `identifier` (`getUsername`), `nickname` (`getNickname`) and `realname` (`getRealname`) then? :)
remove this extra space
We should keep these as separate tests so that they can pass/fail independently. They can both exist in the same test class though.
also, i'm pretty new to github (this is my first pull request) -- it looks like the commit that removed that comment is automatically added to the pull request.  can you confirm?

and, not sure if you want the method i added or not, up to you.  i think you understand where my frustration came from tho -- if Document were just an Object getValueByKey would just be doc[key].
I agree this is not the best :(  I had a look around myself and the only 'event' that I noticed was that the value attribute of the feedback comment field is reset to empty after the submit process. You could wait for that (use `get_attribute('value')` on the element).
Why are these always strings?
Done already :)
Please follow this styleguide: http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml. Formatting, Naming etc.
Is sampling required to be an integer?
Same with everywhere else, too - it happens a fair amount.
Nope, same as the other one
On 5 Aug 2012, at 18:33, MSuhajda wrote:

>> +summary: Node.js is a platform built on Chrome's JavaScript runtime for easily building fast, scalable network applications. Socket.IO aims to make realtime apps possible in every browser and mobile device, blurring the differences between the different transport mechanisms. It's care-free realtime 100% in JavaScript. In this tutorial, I will show you how to use them together to make real-time web applications.
>> +</info>
>> +
>> +*Note: To fully understand this guide, you are expected to have previous experience with JavaScript*
>> +
>> +## Setting it up
>> +
>> +### Installing NodeJS
>> +
>> +To install NodeJS, visit [this official download page](http://nodejs.org/#download) and select your operating system. If you are using Linux, you will have to compile it yourself or [use a package manager](https://github.com/joyent/node/wiki/Installing-Node.js-via-package-manager) .
>> +
>> +### Installing Node Package Manager (NPM)
>> +
>> +The latest version of Node includes NPM with it, however if you are using an older version of Node, you can still install it!
>> +
>> +- On UNIX systems:
> 
> Is this a blockquote?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/callumacrae/lynx.io/pull/5/files#r1308352
@tchak - why the name change here?
Является ли этот класс виртуальным? как он должен удаляться? Что для этого нужно сделать?
эта функция добавляет много вершин. addVertices
What about just the empty value like so:

[1,2,3,4,5,6,NaN,null,, undefined]
Changed the name of the latest commit (49a4af4)
Not really.  It is a little different then the dropdown one, but they could easily be combined.
Trailing newline should be removed.
As agreed offline, we'll keep this one required for now since we don't really have a use case were we wouldn't want to know whether or not the config was successfully written to Cassandra
I don't think we should expose an endpoint for this. I can't see an immediate use case.
Missing return?
```return callback(err);```
Don't tell me what to do! :)
I'm lacking some context, but this made me wonder when this method should actually be used.
should be avoided. overwriting plug-in configs from global config is misleading. when a plug-in need a global config option they should use the global $conf.

I'm not 100% sure but is passcrypt is a plain auth specific option?
this should best be moved outside of the foreach
test out if this modifies methods outside of file import
I know you copied the existing tests, but could you namespace the tests instead?  So 'test/integration/phenotype_attempt/edit_in_form_test.rb' please
Okay, I'll update to this copy function (which I've tested). The only caveat with the shadow objects is that, if we ever do a util.inspect() or similar on the copy, we'll see only the properties that are objects. I don't _think_ that's an issue here, though.
I couldn't figure out a good way to replace urlopen() in the test to return a class
That's just it, though - Loader has always tracked loaded classes internally in order to recognize duplicate requests and either skip the include to instantiate another object under a different name, or gracefully return on true duplicates after providing a log message to inform the developer of the redundant call. If we remove that legacy logic and just rely on require_once, we will lose that courtesy. So, which way do we want to go - internal tracking or require_once? I don't see any point in doing both - it's just wasteful.
Спасибо, действительно заблудился в собственном коде ))
Probably better to use 1L -- this looks like 11 (eleven).
Correct. Please check the latest commit.
ой ) отступы убежали
I have noticed that it seems to only refer the users who have spoken semi-recently (maybe the last few hours). You say not just the current room - can Hubot be in multiple rooms?
Assignment & null check here as well.

Also, can release throw an exception? If so we never close the repo.
save here use np.array
in filter.resample it can be float. Why int here?
Sorry, what is twice, you mean any attribute name in the doc? I only see n_pca_components and n_ica_components .... but nothing duplicate.
what's that comment?
please define the port to be dynamic ```port = process.env.Port || 8080;``` and use it in the listening statement.
You should not import `play.api.Play.current` here. Instead add an implicit parameter to the `withLang` method.
From the current standards, all 4 `// ...` should be `...,`
i was unable to get the testsuite running without this line.

is there an "official" way to run the paperclip testsuite?  if so, i'm perfectly happy to remove this require statement.
you right. i rename 'istanbul' to 'coverage'
Should be documented as blocking.
Indent error. Indent with two spaces. Happens in other places too.
moved it a line down.
spaces after commas.
Please optimize the two calls with a single strtr() call. You may refer to other code that  does such template stuff.
Эта и предыдущая функция могут обе быть в локальном анонимном неймспейсе, им не нужно быть членами класса.
Sorry, I forgot to clean up after myself before submitting the pull
request. I'll update the code and re-submit, I guess (not certain what the
etiquette is, I'm new to github).

On Thu, Mar 15, 2012 at 2:52 PM, Chris Chris <
reply@reply.github.com
> wrote:

> > @@ -83,7 +83,18 @@ def should_to_s(value)
> >    newparam(:recursive) do
> >      desc "Apply ACLs recursively."
> >      newvalues(:true, :false)
> > -    defaultto false
> > +    defaultto :false
> > +
> > +    # try to fix bug where posixacl check_recursive method does
> > +    # boolean test against a string
> > +    # munge do |value|
> > +    #   if value == :true
> > +    #     true
> > +    #   else
> > +    #     false
> > +    #   end
> > +    # end
>
> Sorry, I guess my question here is what's with the comments? I am a little
> unclear what is being said here...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AllPlayers/puppet-acl/pull/2/files#r564709
>
1. Capitalize "Can't".
2. It would be nice if the error message showed the key path, since it refers to the key.
Not even sure if I can be bothered to go all the way to the end
How come these are coming back as strings?
That default lambda is clever and scary at the same time, like all production lambdas I've seen
why do you use shade?

I'm pretty sure prod team is being extremely nice with JDG, but in long term they'll ask to remove such things.
this test should at least make sure that interrupt was invoked on the remote running callable.
shouldn't it just "return 'master';" here?
You're right, forgot to change the comments after copypaste :)
Probably deserving of a comment.  This makes things *much* faster for the difference comparison, because one can then say `buffer != last_buffer` rather than `buffer[...:0] != last_buffer[...:0] and buffer[...:1] != last_buffer[...:1] etc.`.
I actually agree that this exception handling is unnecessary -- it really shouldn't fail here, unless something is seriously wrong.  This is different from the try/excepts above where if the icon can't be set we should continue along without an icon.
I've got code for the translation of this and the spacing is off.
Nice!

Please add these lines above the ```nav = []``` and a blank line between the if, just to make more readable ;)
@christianv Thanks for that, it solved the problem
thanks, for reminding about calloc i completely forgot about that..
pragmatic のほうが達人的な感じがして好きです。
"use *the* new"
Ok, it's probably light enough that it won't affect much of anything. Let's keep it.
that seems much better, on it
You referring to Lines 261 & 263 correct?
Don't forget to add this instruction to Freeseer's README as well.
I liked this detail a lot for some reason. Probably the idea of everything being that one shade of white built up the city as having been very impressive.
Nope, gibt es nicht. Eine statische Klasse entspricht einer Klasse die abstract final ist oder final mit privatem Konstruktor.
Ist inzwischen implementiert.
called before rotation was done, send out animation with same duration, will cause a smoother change of layout
@braddunbar fixed. let me know if you see anything else that needs changing.
How about: "Do not run any other tests in the group used by --single"
I think this should just return. We don't want to quit the entire application after rendering the table out, there could still be work that needs to be done.
Maybe make should run `npm install` as a prereq?
I'd prefer null rather than 'untested'.
I was confused about this... Isn't whether we submit to production or not determined by the task's evaluation? There is a boolean field, prod, in evaluation that controls this.
I would prefer that you return lower case constant strings.
OK, so first unbind the handler and then rebind it. But be careful to unbind only your handlers.
There is also one space too much there.

And you should create some mapping between allowed values (choices) and models. This is a bit tricky to just `getattr`, but for testing is good enough.
Furthermore, this so fails for me with `'QuerySet' object has no attribute 'create_user'`. :-) MongoDB model is different to Django original one. There is no `create_user` in its queryset.
You should do `user.reload()` before this line because `user` object is obsolete as you have just updated it with `update()`.
When you use .hide(), jquery saves current display mode, and reuses it od show. If you set display: none in css, jquery cant reuse default value on show..
Space before `i`.
This will throw Label.DoesNotExist if there is no label with that name. Maybe we can use get_or_create instead? https://docs.djangoproject.com/en/dev/ref/models/querysets/#get-or-create
From `automake --help`

    Flavors:
      --cygnus           assume program is part of Cygnus-style tree
      --foreign          set strictness to foreign
      --gnits            set strictness to gnits
      --gnu              set strictness to gnu

which means go wild-turkey with the file structure: no `README, AUTHORS, NEWS` required.
I don't really know the rules, only that without that flag, the automake stage fails, on those files missing.
i would move this comment to Kestrel.scala#157 where it makes more sense.
Move to PHPUnit
:( yea sorry, my bad of course
could we maybe turn this into a function currently I don't really have a context what these are.  It would be nicer to simply ask it a `question?`
If you find a better/alternative solution to ShareThis, please do feel free to open a pull request - I just did what was easiest for now.
See comment on L238.
It's going
> Currently with Infinispan 5.1 the FileCacheStore is neither very fast nor very efficient: we picked that one for ease of setup;

Currently with Infinispan 5.1 the FileCacheStore is neither very fast nor very efficient: we picked **it** for ease of setup;
Good point; corrected.
did you want to add a basic wrapper-based scheme here?
This was is deprecated.  It should be like this:

```ruby
db.execute("INSERT INTO students (name, email, grade, blog)
                       VALUES (?, ?, ?, ?)", [@name, @email, @grade, @blog])
```
After some more thoughts about that, it seems that:

1. We don't need this Thread thing
2. We shouldn't wait for the master (just remove the sleep should be fine), if it's not there, just exit the run of the arbiter (probably should raise an Exception).
@jeffkaufman @bnoordhuis I think the shared memory locking system uses sysv shm segments
The original reason I chose l1 was that, technically speaking, it is "little l1 regularization" rather than L1 regularization.  That's being picky though so I don' t care either way.

Here's the only real problem:  Existing code using things like
```python
if method.lower() not in methods:
```
See e.g. statsmodels/base/model.py  (not sure if this happens elsewhere).  So now we have 'L1' (that the user inputs) and 'l1' (that we use for comparison of methods).  Not a bit deal.

Do you still prefer L1 everywhere?
Thinking aloud here; @jferris and @joshuaclayton might have more ideas on this. How about if FactoryGirl::Registry's `@items` was a subclass of `Hash` that knew what to do with `Class` objects for keys.

    class ClassyHash < Hash
      def [](key)
        super || super(key.to_s.underscore)
      end
    end
Will do... no problem.
you certainly needs to wrap this test into another one checking if we are using XEN (using the _capabilities dictionary)
Not a problem, I'm happy enough to do that.  Will inform when pushed...
No.  That's just an error.  It should be a reference.  Thanks.
Nor do I claim to have a handle on good Python style!  In the copy method we're basically reconstructing the return object from the target attribute by attribute, so it seemed natural to copy the class attribute too... But I can see how that would, in many situations, be a quick way to store up trouble for yourself...
This seems worth checking in our planned exploration of timing and accuracy issues related to photon-shooting.
By this point, we'll have used e,beta a few times.  But if you think it's clearer, we can reword this as you suggest.
Made this conditional so people could run C2G without these graders.
Also, it doesn't do as I expected: it just checks the path, and not the name - but the name is included in the exception, along with `keystorePath` which was not passed in.
Should this wait for the application to either disappear or enter an error status (i.e. for abstractApplication.stop to return, when called in brooklyn.rest.core.ApplicationManager.destroyInBackground)?
Can you use `BasicEntity.class.getName()` instead? It's much better than hard-coding strings in case someone moves/renames/deletes the BasicEntity class.
Again, does this need to be synchronized?
We call that an integer in PHP, not long :)
```Seneste indlæg```
Este hook deveria estar comentado mesmo? Se sim, pq?
Why is this test gone?
On Thu, Feb 23, 2012 at 2:51 PM, Dan Yamins
<reply@reply.github.com>
wrote:
>> +                    orig_result = result[0]
>> +                    assert hasattr(orig_result, 'keys')
>> +                    assert all([isinstance(x, tuple) and len(x) == 2 for x in result[1:]])
>> +                    assert ([hasattr(x[0], 'keys') and hasattr(x[1], 'keys') for x in result[1:]])
>> +
>> +                    return_val = []
>> +                    orig_result_return = handle.update(self.current_job,
>> +                                           dict(result=orig_result))
>> +                    return_val.append(orig_result_return)
>> +
>> +                    num_new = len(result) - 1
>> +                    new_ids = self.trials.new_trial_ids(num_new)
>> +
>> +                    for new_tid, r in zip(new_ids, result[1:]):
>> +                        spec, res = r
>> +                        new_rec = copy.deepcopy(self.current_job)
>
> So wouldn't that obviate the need for this whole branch, in fact? I mean, we're back to the "two methods  for entry, one backdoor" ...
>
It might make the branch name a misnomer, but the logic of building
new trials needs to go somewhere. To whatever extent it's not
lfw-specific, it would be nice to have it in hyperopt.
Revert these lines.
Помечай final поля, которые не должны изменяться после конструирования.
Вместо этого надо использовать String.CASE_INSENSITIVE_ORDER
Why do we need this variable?

Can't we implement `openForCurrentTab` in gDevTools?
Should be `homebrew/dupes/zlib`
I didn't think about the use of `test.js`, I made it match the example in the README. You're right that the local test made perfect sense to have a short timeout.
Could this just be a list of categories?
there's no tsreader in this add-on?
`initialize` is supposed to work correctly I believe, you should make it `protected` though, so Thor won't pick it.
Это проблема прототипа. Я пытаюсь создать такой элемент popup, который выглядит как блок. Это позволит в будущем отказаться от этого элемента и на его месте использовать мощный блок. Во всяком случаи таки планы. Однако, у меня уже сейчас есть идеи как решить эту проблему взаимозаменяемости.
Ironically, this found a few errors that weren't uncovered when using both shrinkage *and* sparse matrices.
Could you please cover this in a test by passing some non-callable type?
BTW: the goal of using doctests in the documentation is not to test the code of the PassiveAggressiveClassifier but to ensure that the examples included in the documentation are up to date with the current state of the code base.
Ah, I forgot to mention this. Unfortunately, it doesn't work as the C preprocessor looks for the include file `"MurmurHash3.h"` in the present directory. I was a too lazy to fix this, but if you can suggest a solution, please do, but as no other code is currently using this and the API is not documented, I'd like to tackle that in a separate PR.

(Also, to prevent linker clashes, we might want to prefix global C identifiers with `sklearn_` or something like that.)
> Why me? I have no idea without diving further into the numpy code. Maybe
> @GaelVaroquaux knows?

I believe that it is related to strides being zero or not. However, this
part of numpy has been in flux lately.
absolutely! I'm benchmarking... thx!
for (var i = 0, len = modules.length; i < len; i++) {
      lumbarLoader.loadModule(modules[i], function() {}, {silent: true});
    }

Side note: Underscore is not a dependency of the loader so that is not available in this context.
Awe crap, you're completely right.

An excellent example of how open-sourcing internal tools actually makes em work. :)
is it not true that `.then.then.then` chain always can be refactored as `Q.all([...])`?
we can declare const variables, instead of using string value (e.g const string fontSize = "fontSize")
Shouldn't this situation and the NULL parentControl raise an exception or a the very least log a message?
ok - typically the user would have there own scripts which called this with the appropriate options
If we get an abortsem we have to create a new thread so that when abortsem is signaled we can close the the inotify_queue to unblock the select.
What I'd missed was the 
> if (delsub)
> { ..

near the bottom
the type is missing
Newline at EOF, please
Again, no need for the `[]` in the name.
but i'z lazy!!
сайн биш зөв
I know it's silly tests nobody will ever look at but for the sake of completion, spaces after comma in the whole file :)
and the ``count`` cannot be used as it includes replies and retweets even when they are not included in the response
This should be easy-thumbnails
No export inappbrowser.close?
```config.temp_folder``` defaults to ```www/temp```, I believe, relative to the location of ```web_server.m```. 

If file cruft is a problem, we can maintain a circular buffer of written temp files and wipe through them when re-cycling through the buffer. This should be easy.
@ctweney That's great, thanks for implementing!
There is a lot of duplication here, we'll clean it up.

With things like this I'm sometimes hesitant to keep presentation code DRY, a lot of times the similarities between different pieces of code are only coincidental and can quickly change so as to make the refactoring no longer useful. But because I can't see a way that'd happen here which wouldn't involve scrapping the entire thing and re-writing anyway, cleaning it up is a good idea.
When multiple authors one line by author looks better.
backtraces are traditionally preceded by "Call stack:\n"
Already done...?
here you don't need to convert back to ubyte (the reason why we're not converting automatically back to the input dtype is that most of the time, the use is happy with a float image)
PEP 8: line length. For this, and other long `np.ndarray` cdefs, you may want to put a continuation character (`\`) after the type and assign on the next line.
Since 3.8.9 we have a naming standard for WP e-Commerce functions:

- Private functions that are not to be used by third-party devs should be prefixed with an underscore.
- Action (or filter) hooks should also be prefixed with _wpsc_action_ (or _wpsc_filter_) to signify that they're not supposed to be call directly.

We're going to enforce this naming standard going forward. This helps make sure addons and theme developers are not using those functions that tend to change.

So for this function, if it is to be used as a private action hook function, should be named _wpsc_action_purchase_history_section(). Otherwise if it's to  be used publicly and is supposed to be called directly in certain contexts, wpsc_purchase_history_section() is fine.

Also, phpdoc please, make sure you add "@access private" if the function is private, and add a "@since 3.8.10" tag as well :)
Is just the typehint wrong? or in general?
If the first, what typehint do I have to choose?
Oh, I see. I guess the curl bindings are not particularly Ruby-ish. After playing around with them a bit, how about this:

  result = Curl::Easy.perform URI.join(@url, "/message/#{message_id}/part/#{part_id})
  if result.response_code != 200
    ...
  end

That also avoids an unnecessary instance variable.
This is now called `POSITION_SIZE_INDEX`.
In other words, encapsulation makes it easier to understand a software system, even if the conventions of your language (for some reason) don't encourage you to use it.
Moving it into Source is better, but I don't want a lot of files in that root directory; it makes things intimidating for newcomers.  But that is probably the best option.
These 4 lines can be cleaned up.  Math.min and Math.max can take an arbitrary number of arguments, so you only need one min or max call per line, not 3.
This seems a little odd to be in here - is this part of separate work?
Whoops. Removing the line.
Why didn't you just assign an object literal to module.exports? Instantiating a function is a lot slower and just seems like overkill.
Que tal salvar isso local?
`ReferenceError: False is not defined` - false (с маленькой)
use "star imports" like:

`org.scribe.extractors.*`
Was this done for compression?
Can you believe `grunt lint` complains:
```
'escape' is not defined.

```
On Wednesday 05 September 2012 07:04:24 Saurabh Sood wrote:
> 
> I am using showEvent so that the installation screen can be shown before
> the password dialog box

Can't you move this to the code doing the switch to the installation screen. 
So there first switch the widget and then call the installation, which shows 
the popup. That's more direct than doing one in response to the other.

-- 
Cornelius Schumacher <cschum@suse.de>
we try to keep lines broken after 80-100 characters. this makes it easier to read diffs and when somebody fixes a spelling error, you have to scan just one line of < 100 characters to see what changed, instead of the whole section. to rst its all the same, a new section is only started with a blank line.
лучше возвращать ссылку, так как когда возвращают указатель не понятно, кто этим владеет. Или нужно явно описать кто владеет в комментариях (комментарии всегда хуже нормального интерфейса)
> Practical use cases?

Why on earth should you have to be destroying a variable? `destroy` certainly doesn't require it. Being able to set a reference or pointer to `null`  after destroying what it points to makes sense, but why restrict it to only work with lvalues? Limiting it to `ref` is artificially restrictive, since the fact that you're destroying something doesn't have anything to do with whether it's an lvalue or not.
`opEquals` used to return `int` - hence the `equals_t` nonsense which we've been trying to get rid ouf. At this point though, I don't think that there's any point in trying to support that. Checking the return type of `==` doesn't really make any sense at this point. If you want to check that `==` works, then just do `is(typeof(r.front == s))`. It should always be `bool` if it works.
By the way, can this be `pure`?
I understand how the current implementation of `move` gives that impression, but really move is intended as a safe optimization of copying. It should work preserving safety and only overwrite mutable data in the source of the move operation. The fact that move currently overwrites immutable data is a bug in move.

Emplace has a different charter altogether as it transforms uninitialized data into actual typed data; so for `emplace` it's fine to overwrite immutable fields.
If it doesn't work yet, don't make part of the documentation.
It's often hard to determine when someone is joking in writing regardless of their level of fluency. And if your fluency isn't at a native level, it's far easier for people to assume that you're making mistakes rather than joking - even when speaking. I've run into that problem a lot in French given how much I love to play with words, and while I'm reasonably fluent in French, I'm obviously not native, so native French speakers have a tendency to think that I've screwed up when I play with words when talking with them in French.

Regardless, your English isn't horrible. It just isn't perfect. And you do quite a bit better than some of the other non-native English speakers around here.
Similarly to [my other comment](https://github.com/alphagov/govuk_content_models/pull/10/files#r1360554), statements of the form `assert_equal false, condition` can be more simply expressed as `refute condition`.
Line breaks or local var, plz.
Source formatting note: typo
If revision is a branch name, yes.
On Jul 2, 2012 11:56 PM, "Anand Kumria" <
reply@reply.github.com>
wrote:

> > +
> > +    vcsrepo { "/path/to/repo":
> > +        ensure => present,
> > +        provider => git,
> > +        source => 'git://example.com/repo.git',
> > +        revision => '0c466b8a5a45f6cd7de82c08df2fb4ce1e920a31',
> > +        user => 'someUser'
> > +    }
> > +
> > +Keep the repository at the latest revision (note: this will always
> overwrite local changes to the repository):
> > +
> > +    vcsrepo { "/path/to/repo":
> > +        ensure => latest,
> > +        provider => git,
> > +        source => 'git://example.com/repo.git',
> > +        revision => '0c466b8a5a45f6cd7de82c08df2fb4ce1e920a31',
>
> if ensure is latest, then will the revision parameter be applied?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/puppetlabs/puppetlabs-vcsrepo/pull/26/files#r1089879
>
Nop for 2.10, this works fine, i have search an afternoon to create a form with many collections inside another collections, this code doing the good thing in my case. But you have reason, the entity is delete from database, and in this case this is not the waited result.

In parenthesis, do you know if delete works too with OneToMany relations inside collection?

So i will test an proper solution with the master wich can works in every case, and recommit, if you had another comment please make i send the noew tomorrow afternoon i think.
This method is too specific to have put in the base class. If you specifically want a "CD4 six months ago", that should go in this class. Alternately, we can refactor that method to be "lastObsMonthsAgo(String conceptUuid, Integer monthsAgo, ...)"
Why eat the error of texturesys here?
@schmittjoh Updated the code
needs to be ignore because we cannot install the dependencies due to the above mentioned composer bug
doesn't seem to be done? maybe just not pushed yet?
Missing space after `if` here and in the else clause below
We should break out every `each()` callback function to be it's own function. If we can avoid quadruple-nesting of the each callbacks, that would be cool too. If not, at least breaking them out into separate functions will aid in readability here
My spec tests fail on this paren, even though our parser should work just fine (untested). 

To make both piece of software happy, I suggest you push a new commit that moves ) { up a line and remove the comma. 

define apt::ppa(
  $release = $lsbdistcodename,	
) {

BECOMES

define apt::ppa(
  $release = $lsbdistcodename ) {
please consider adding in line comments for non-obivious logic
Do we need to check for <i>isInitialized </i> here before returning it?
It is no longer the case. You have to run the initdb specifically. I think it might have been to better align it with the RHEL/CentOS distribution.  Won't work with it disabled.
Very good point. I will do that.
Remove dead code if we can :)
you need to check if the page exists
User exposed strings should be in `"`. (Will be much easier to find all strings needed for translation later on.)
typo: `preivous` -> `previous`
what is this twig doing exactly? could we change to another name more functional and rather more descriptive? like asset.xml?
I know, it was more a question of styling =)
why does this need to be a set?
``#visual-portal-wrapper`` does not exist in some diazo themes (e.g. plonetheme.teamraum).
The result is that the overlay is not positioned in the center but on the left border.
@buchi how do we fix this?
If you're going to stick with the regex approach, you should use capture groups in the original regex to avoid re-matching each match.
these stuff should go in the before_script IMO
If you use `%r` you probably do not need `'` around?
@stof Yes composer is where I found out about the other. I'll repair the spacing issue you mentioned and remove these lines.
I think I'm really missing the point here... If apache config files are httpd_config_t and logfiles are httpd_log_t, everything should work out of the box, no need for a home-brew selinux module.

Could you please clarify, maybe with a more detailed comment in the code about the reason of doing things this way ? Thanks !
It's weird to see the `amount` param is the fourth param here, and in the real MemcacheWrapper is the second one
I realize this is older code, but... why the trailing _? It's a weird convention compared to the rest of the code, for a second it looked like this was using Streamline and I wondered where the generated code was.
ok, fair
Do you use the `NSError *e` anywhere after setting it?
I guess either use `:nil` or test for an error?


Man I'm being pedantic ;-)
settings.bind_str is set ine init function:  settings.bind_str = settings.event+".easytabs"; (line 75, added)
Maybe then this is reason to separate this tests into own fixture
Might be worth picking some different numbers for this..
This is one of those giant GUIDs, right?  We will want to use autoincrement values for these too; although uniqueness is desirable, so is terseness, and arguably the autoincrement is easier to read in debugging than a giant GUID anyways.
This comment is wrong. You get ``%class_name%`` when you use a parameter to define the class of the service. It has nothing to do with the overloading as you can define your own service with the class directly in the definition
oks..
> The last sb is unexpected because it's a new sb

Not quite sure I follow :-( As you say later in the comment, `new StringBuilder("U go now.") padTo (20, '*')` is actually a `String`, with the expected number of padding `*`s. Do you mean "unexpected" because you _don't_ get a `StringBuilder` back?
It needs to persist beyond the function scope. Each time a sub-class adds new fields to the form, this function can be called. As the translatable fields are added to the form, they're also added to the exclude list. 

Property should be declared though.
I dont quite get it.
Are you talking about a component in openengsb?
Or a technical term?
Pokud neni nainstalovano, neni ani nacteno
Okay. Сейчас добавлю объект audio. Что насчёт моего сообщения ниже о фокусировке документа?
Агой, вы действительно уверены, что ента правка необходима? на некоторых бордах изображение капчи лежит ниразу не рядом с полем ввода. На бордах с кусабой например, посмотрите. Другие примеры.
You are not returning a value through success so what are you returning here?
strange indent.