labofsahil/github-event-dataset-2012 huggingface dataset:
Where is this defined? It should be changed to `available`?
comments that just rephrase what the next line says are unecessary. Focus on comments that explain, like the previous one.
Ahh, I see, because $download_id means only one, but if download_id is not present and it instead uses post or topic ID there could still only be one or more.

Nevermind then.
@p  Looks like this code segment is useless. as the " are already replaces on line 105. this code segment so wont do anything. Postgresql doesn't support phrase search as such. we can use thesaurus component to phrase search that will require some code changes i think.
你数据库有这张表， `db:drop` 后重新 migrate 或者手工把这个表给删除掉
Not sure how its printed, grammar should be improved. Probably capital letter is odd.
But we already have CppUnit::TestFixture. Also why CppUnit::TestFixture, not CppUnit::TestCase?
If reverse order is important here, we should add a comment.
I'm working more from the "imagine the comment in YDN docs perspective. So:

The runtime environment (either 'client' or 'server').
тут что-то с отступами.
- Wrap in curley braces
remove todo - it's done
Where is that code? I had a look in case someone had done it, but could only find a single method on the OSGB projection class.
Drop the "is_", it should simply be named: hostname_exists
Restored here and line 153. Please tell me when you want me to change
Bug: This sql value is never used.
Why is this skipped?
What's the story with the exposure point geometry?

Here we have (-120, 37.225), (-20.000, 37.255), and then in the config file we have a  `region_constraint` that basically covers the entire globe.

Who provided this test input? It seems strange to me.
I don't know if this is the best solution. You're able to flattr the same thing (in our case the Episode) more than once. You can flattr a thing every month.
Тут наверное не нужен `enumerate` и `i`.
Можно сократить лесенку, если написать эту строку так: `for value in (v for v in auto_values if len(v) > 1):`
`(jQuery.support.zeroOffset ` => `( jQuery.support.zeroOffset `
Matchers must always indicate success with boolean `true`.
Need to fix this, if the initial idea of looking window handle or getting all objects are fine, then I will go ahead and adding them.
I think MADLIB-614 is not worded right - we don't accept NULL input values at all. The only difference is that an error is not thrown in one case, but the results cannot be trusted in both cases. I would like to change this to NULL values not accepted for attributes.
Would a proper for loop read better perhaps?
I'm just reverting a commit from a few days ago. Also, we've never really moved towards module imports in the tests.
This 1 space indent looks weird to me, but my linter doesn't complain. In the other views I have been putting the `{` on the previous line, and indenting the key: value lines by 4 spaces, but that wasn't using render_to_rresponse.
Honestly no idea, I'm not a programmer, I just use pngcrush for graphics work and building android. Feel free to close the pull request then and I'll test each flag separately and re-submit.
Would also be nice to know where they come from.
These comments aren't necessary
Performance wise we could just do some caching. As a maintainer though I'd probably rather slower but more reliable and better for bottling.
Let's slip the story from the sprint so you have time to work on it next week.  No big rush on this, esp since it sets the stage for all the other stories.

On Jul 27, 2012, at 6:48 AM, John Palmieri <reply@reply.github.com> wrote:

>> @@ -18,6 +18,15 @@ module RHC
>>   # from the gem directory.
>>   #
>>   module CLI
>> +    class Runner < Commander::Runner
> 
> I took most of your suggestions and refactored the code. I won't be able to work on it again until Monday.  The one place where I did not refactor is where we test if we need to run the wizard.  This is because you need to jump through hoops to get the data needed to run the wizard if we moved the code to the Runner.run! method.  It needs to be thought out a little bit.  I'll fix it when I get the chance but for now it is happy in initialize.
> 
> --
> John (J5) Palmieri
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openshift/rhc/pull/104/files#r1251643
This Targonski allows you use de {{ _('Some text') }} to mark strings for translation. See https://github.com/p2pu/lernanta/tree/master/lernanta/templates#L10 for an example. In the line bellow you will see another way to mark strings to be translated. This second way is normal in django. Note that the load l10n is loading custom template tags and filters from apps/l10n/templatetags and that the load i18n is loading stuff that comes from the django framework. You can read more about localization at: https://docs.djangoproject.com/en/dev/topics/i18n/translation/

Please mark the strings on this template appropiatedly so they get processed by 'make int' (which runs 'python manage.py makemesaages') the next time we update the permanganate translation (the files produced/updated by 'make int' are at lernanta/locales/)
We should probably create a `set()` out of the tagpool names as this is O(N) expensive where N is the total nr of keys in Redis.
Do we want to make the delimiter configurable? I've seen protocols like this use `\0` as the delimiter for example.
As an aside, foreign key fields only set indexes, not data. I think it would be a good idea to put those values in the data as well so we can rebuild the entire object from the JSON if necessary.
please adjust this filename to

    cle-it.yaml.template
the default should be path.join(templatesFolder, viewObj.view);  
getFilePath(templatesFolder, basename, 'en_US') should return index_en_US.html
Mainly for consistency so that on any page where the moderation toolbox is present or the user has full moderator abilities the body.moderator class will be present (which for users with 'admin on' is all pages).

It's not for any specific reason though so it can be taken out if it's deemed unnecessary.
neat test
no tab characters, don't be ridiculous
actually, the #endif in 89 is superfluous... For non OMP the pointer is set before the loop or at the end...
NAME_ASCENDING, right?
same here, node binds `this` to `worker` here so this will be cyclic
I've tested this with my personal account where I've manually disabled SQS access. The application loads as opposed to hanging on the loading screen as it does now. The SQS pages just show up as empty. Attempting to create a queue shows a friendly error message that the account does not have SQS access.

Swallowing the exception allows the `fill()` method to complete, which sets `doingFirstFill` to false. Otherwise the exception bubbles up to the closure in `start()` and this flag is never set to true. The loading page will wait until all caches have set their `doingFirstFill` to complete before allowing access to the application.

This error was being logged however, it just wasn't visible on the screen. The fact that it was noted in the `agard.log` file allowed a few resourceful users to diagnose the problem.
Trying to keep them generic to the `StorageAdapter` since this could technically be applied to a `LocalStorage` adapter as well.
`val = getter?(parent) || parent`
I don't understand... `error` the event and `error` the state happen to have the same name here
whey don't keep this check and just add conditional for new namespace?
Couple typos in here - the first line has "serially" twice, and the second line is missing the word "user".
I'm a little confused by the flow of control in this case. Do we reject this here because `searchFileList()` will have been called another time with the right query? If so, does that mean that we're attaching an extra `done()` handler to `pendingFileList` for each new character typed? I guess that's not a big deal, but it seems a little odd. Maybe it would be better to only attach one `done()` handler, and then when it resolves, just look at the currentQuery and dispatch it (basically ignoring the query it was originally called with, since there's no real reason to care about that at the point when it resolves).
Actually, it could make more sense, since in that case `_workingSet` did changed, but it would also potentially call it many times in one single drag & drop. If that is ok, i'll change it.
Ah. I figured I must be missing something obvious :)
same. I would actually advice to put .ignore on the $doc object.
it seems this is the main diff
can you confirm there is no other changes in this class?
Why not just use a `**kwargs` instead of the `args_dict`?
Maybe mention that continuous colours are smoothly interpolated discrete colours, and have not be tested like the discrete colours have.
By this way the traceback cannot be shown.
LOGGER.error(ie.getMessage(),ie);
Sure, but what is wrong with:

```
language_choices = settings.LANGUAGES
```

?

And for constant variables please use ALL_UPPER_CASE.
You have removed comments. Why?
Can you split also defaults into multiple lines?
An early return.
Cleanliness point: you use single a double quotes interchangeably in this file. Maybe choose one?
Either use _ or don't, but don't mix.
The outcome is:
```
-bash: eval: line 228: unexpected EOF while looking for matching `)'
-bash: eval: line 248: syntax error: unexpected end of file
```
We should really provide a better interface to test against, something along the lines of `download(url)`.
sorry @sam didn't mean to include you :(
It's probably simpler if you just use the selector...
```javascript
$(".js-zipkin-navbar > li.active").removeClass("active");
```
Dobře, aspoň bych ale prohodil slovosled na "V nastavení/Nastavení byste měli vyplnit...", čeština v tomhle není nějak extra striktní, ale v tomhle pořadí mi to připadá přirozenější
The indentation looks wrong on this line.
Again, JavaDocs below here need fixing.
Have these gems been added to our rubygems repo?
[ Is this skip intentional? Just checking, not sure if it should be there. ]
you know, those options should actually be commented out.  let me fix that


On Wed, Nov 14, 2012 at 11:21 AM, Brad Buckingham
<notifications@github.com>wrote:

> In katello-configure/modules/pulp/templates/etc/pulp/server.conf.erb:
>
> > +# the system relay through a local MTA on the machine. Pulp does not retry in
> > +# case of error, so it is important to have a real MTA available locally.
> > +#
> > +# If there is a need to test email sending, it is recommended to run this:
> > +#   $ python -m smtpd -n -c DebuggingServer localhost:1025
> > +# which will write each message to stdout.
> > +#
> > +# host: (str) host name of the MTA pulp should relay through
> > +# port: (str) destination port to connect on
> > +# from: (str) the "From" address of each email the system sends
> > +# enabled: (bool) either "true" or "false", controls whether emails will be sent.
> > +
> > +[email]
> > +host: localhost
> > +port: 25
> > +from: no-repy@your.domain
>
> should 'your.domain' be filled in with the actual domain using the fqdn
> variable?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Katello/katello/pull/1064/files#r2126014>.
>
>
- It seems a little confusing to have apis called add_packages/delete_packages and add_repo_packages/delete_repo_packages on a repository.  Both imply the same behavior of adding/removing packages to a repo; however, they are different.  Do we need both sets of APIs or does the new set replace the old?   If we need both, should we rename the [add/remove]_repo_packages to be [associate/disassociate]_packages, since that is the underlying pulp API?   (Note: this change would apply both on glue/pulp/repo.rb and lib/resources/pulp.rb)
W: 21,4:run_command: Redefining name 'output' from outer scope (line 81)
```diff
+  def find_environments	
+    query_params[:organization_id] = @organization.id
+    @environments = KTEnvironment.where query_params
+    @environments.delete_if do |env|
+      !env.any_operation_readable?
+    end
+  end

```

is supposed to do the filtering.
Why this when gem_dir is not used in spec?
Right, forgot to remove during refactoring, fixing as well as the RH header.
Let's make this localizable (if the "Debug" <h2> follows is localizable.)
By using a async loop, you don't need the random setTimeout time here.

(ask me in person if you don't know what does async loop means)
This way of catching exceptions won't work with all the Python versions we support. Please have a look at how we do it in other places - https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/gandi.py#L66
I will hurt you if I see this
I've tried to clarify the docstrings. If we change to `minus`, we should change the others to `plus` and then later `times` and `divided_by` (and I agree the last one is also less ambiguous than `divide`). But `plus` and `times` don't sound great...
When using a 5 node cluster with a ring size of 64, this reports 10 violations. I think there is just one though (that indexes 0, 3 are too close together on some node). Claim still works, but the output in the debug statement in clam_v3 is confusing because of it.
Which means you can kill this line entirely.
When I compile this on the lab machines an error occurs where it reports:
`
g++ -O3 -Wall -g  -c -o gl_viewer.o gl_viewer.cpp
g++ -O3 -Wall -g  -c -o gl_camera.o gl_camera.cpp
g++ -O3 -Wall -g  -c -o main.o main.cpp
g++ -O3 -Wall -g  -c -o application.o application.cpp
g++ -O3 -Wall -g  -c -o timer.o timer.cpp
g++ -O3 -Wall -g  -c -o lib/door.o lib/door.cpp
g++ -O3 -Wall -g  -c -o lib/vehicle.o lib/vehicle.cpp
g++  -Wall -g -o transform gl_viewer.o gl_camera.o main.o application.o timer.o lib/door.o lib/vehicle.o -lmingw32 -lglut32 -lopengl32 -lglu32
/usr/bin/ld: cannot find -lmingw32
collect2: ld returned 1 exit status
make: *** [a1] Error 1`
Just a small comment here; why ignore example.conf? Surely, changes (as in new updates) should be documented as such. Ignoring it will prevent (or at least discourage) updates to it in the future.
+1 I agree with everything @katyhuff said here - including the clear necessity for things like this going forward.  This will create a bit of a spotlight on our "tool chest" of building blocks - or whatever we call it - since we need that to be clean and robust to encourage developers to use those building blocks for this kind of dependency.
Ah. Right. that makes sense. Well, as long as you've verified things.
On Nov 10, 2012 1:40 PM, "Nick Schonning" <notifications@github.com> wrote:

> In JabbR/JabbR.csproj:
>
> > @@ -820,7 +819,6 @@
> >      <Content Include="Scripts\jquery.timeago.0.10.js" />
> >      <Content Include="Scripts\jQuery.tmpl.js" />
> >      <Content Include="Scripts\jQuery.tmpl.min.js" />
> > -    <Content Include="Scripts\jquery.writeCapture.js" />
>
> I couldn't find anything referencing it. I believe they all use
> jquery.captureDocumentWrite.js now
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/davidfowl/JabbR/pull/606/files#r2091494>.
>
>
Missing line break after close curly braces and if
It's pretty safe to throw an exception here, and it's actually quite helpful - the exception thrown upwards is to the effect of "couldn't find a JSON serialization definition for object of type <Foo>".
Interesting, how could you write a migration like this without using active record classes?
this is the syntax to explicitly inherit the parent method doc. phpDocumentor2 would do it automatically, but its more explicit this way: https://github.com/phpDocumentor/phpDocumentor2/issues/84
Umh ça ça dépend de la config de chacun, j'ai Hoa dans /usr/local/Hoa.central comme proposé dans la doc d'install et un symlink vers /usr/local/lib/hoa
Habits from fighting against Python 3.  I don't know if 2to3 always takes care of the `list(map)`, since map returns a generator, and `list + map` is illegal in py3.
"This should also work in..."
This should not append.
We can provide a 'save_a_copy(othername)' for convenience, but rename should only rename.
should probably use embedPlayer.userSlide "global" like the core sliding does .
You should support this attribute in liveStreamStatusPlugin.js
most are just indents fix. I tried to keep the tests untouched. the places that's been actually changed are noted in comment bubble for your convenience
Done - will come out when I update the pull
True, I'll fix that. I didnt bother testing the default.
I *think* this should be `topic.title`. But I may be wrong. Since titles are populated in the db and descriptions aren't yet maybe we should have it be title for now.
`self = this` didn't get re-added with the new style. Is that intentional?
you're condoning code obfuscation? I'd rather leave the value as documentation a future coder.  "parts" has meaning that while "__" is meaningless.
I'd love a sentence here on what this does. Like "Lets you pull out the first item in an iterable separately, and then iterate over the remaining items".
Maybe a small record... not sure I like a proplist for this, since you can't really pattern match on it.  I'm OK with the return value as it is, though (but I'd definitely want to refactor if more data were added later).

A de-nesting might be nice, but the nesting wasn't introduced here, so I'd be OK with postponing that particular refactor until later.
All exceptions, not code and status.
Can we simply use the overrides here instead of passing in a new parameter?
http://en.wikipedia.org/wiki/Apple_Pippin
> if the value can't be a 0, than I would write
>
> if (val) {
>


But it can be a 0, can be a number 0+
not true, in your current implementation it can also return null.
why do we need `filesize()` here ? isn't the return value from `fread()` good enough - also `filesize` caches the file size.
DT stands for Doctrine Type. I did not like to use "Type" since it sounds so general and could be any kind of Type.
And also DT is much shorter.
As I said, it should test some more in-deep behavior of cloning.
btw, you should probably create another test method for the case of the RequestMatcherInterface instead of putting all assertions in the same test
I'm surprised there is no reference to the charset here. I think this only works if the server and client are both in the same one?
i think there may be some left to right gradient in the edge detail of the bar, so i left it whole.
I know that the increase from that extra comment would be negligible, just think it makes more sense for readability and you'll be in there anyways
nil block instead of empty `^(BOOL finished){}` block
我先改一版，你再看看吧，我确实觉得目前的注释好“重”
This dialog doesn't exist yet!
Do we need to append "None" here? How is it handled by the backend? Shouldn't we leave `tags=[]` in this case?
I used debug for monitoring / researching PSI tree and I don't now about View PSI tool :( Thank you for this tip.
Hash required: {{#<1.2.0}}
FYI, there is a alternate syntax for less than, similar to V+, which is V- : {{#1.2.0-}} Up to you though, they both work.
I corrected this string, but I just realized it was already done in the locale.
What is the best thing to do in such cases?  Revert and keep it wrong forever, correct the locales or rely on "fuzzy"?
Je ne reprends pas cette partie dans mon merge, je ne comprends pas ce que tu fais avec le linkify là. Et je viens juste de recoder cette partie, je pense qu'on est sur la même chose (le lien ne marchait pas). Si oui, ce que j'ai fait est ultra simple...
Remove this change to JPAAnnotationProcessor as its not needed.  

Also, remove similar unneeded change to JPADependencyProcessor.
Can 'value' be undefined? If it  is undefined, value.asBoolean(), value.asLong() etc. will throw an error.
On this branch you can do

git commit -a --amend
git push origin <branch> -f

just in case the next PR does not get merged in time for the AS7 tag
Perhaps a slightly shorter `getBoundingRectWidth`? We already use "rect" instead of "rectangle" in few other places.
It looks like the indentation here is wrong. Shouldn't if self.nesterov_momentum be inside if init_momentum is None?

Also, "if self.nesterov_momentum is True" is an overly strict condition. People should be able to use 1 for True too, but in python 1 is not True.
>>> 1 is True
False
So it should be just "if self.nesterov_momentum"
Remove this per previous comment.
let's call it `callBackAndPreventDefault(ev)` and explicitly call `ev.preventDefault()` on it.
same here. Avoid inline script in HTML.
Good to know this, I will file a bug after I merge this.
I still have blocking+ bugs so I can fix this later in one of them.
The use of sessionStorage in oppose of localStorage of asyncStorage is for one and one reason only: the value won't stick after reboot of the phone/relaunch of B2G Desktop.

I honestly don't know that other stuff can achieve the same effect.
please 80 characters when you can :)
I've updated it order to have the 'low' z-index only during FTU for getting the effect of the visuals, keeping the original z-index of `initlogo`.
We could collect all the suffixes, sort them, and then pick the 3 top most. However, the XML holding the words and frequencies is sorted by frequency, so the outcome is the same, but we save collecting and sorting all suffixes.
`Mozilla` won't need to be localized, and we don't want to hardcode here. I'll file another issue regard to brand name issue on this page. So please just remove l10n id here.
Do you think name it as `analogClockSvgBody` could improve the readibility?
If not, I am fine with that.
Just `Toolbar icons` we're already in the dialer.
In fact, my own projects relies on this search feature so desperately that I have to make a local copy with these modifications outside node_modules. Hope to
This part is actually wrong – this is not how available slots are determined. Available slots must be determined through the INimbus#availableSlots interface. This is what makes it possible to run Storm on other cluster resource managers like Mesos. In fact, standalone mode is considered to be just another resource manager which determines slots via Zookeeper registrations and the "meta" field provided by supervisors (See here: https://github.com/nathanmarz/storm/blob/master/src/clj/backtype/storm/daemon/nimbus.clj#L915 ). 

To fix this, the availableSlots method on INimbus should be updated to have this signature:

```java
 Collection<WorkerSlot> availableSlots(Collection<SupervisorDetails> existingSupervisors, Collection<WorkerSlot> usedSlots, Collection<TopologyDetails> topology)
```

Then the standalone mode implementation should be updated as necessary (should be pretty straightforward).
This is incorrect. You are still calling back but without a matching state for each action.
fixed in 6811eee
1. ジョブは1つ以上のワークフローステップで定義されます。ワークフローエリアで "Add a step" リンクをクリックして下さい。

→

    1. ジョブは 1 つ以上のワークフローステップで定義されます。ワークフローエリアで "Add a step" リンクをクリックして下さい。

半角スペース
I can definitely see the use of saving multiple file formats, but I think we should default to `None` and grab the default from `plt.rcParams['savefig.extension']`. Note, you'll have to add something like:
```python
if isinstance(format, basestring):
    format = [format]
```
Also, note that grabbing the default extension only works if you don't concatenate the extension to the filename (see inline comment) because the default rcParams value is 'auto'.
This if statement is to fix #600, but personally I don't think it should be there. Rather, it should instead be fixed using css:
<pre>
.leaflet-marker-icon {
    background: transparent;
    -ms-filter: "progid:DXImageTransform.Microsoft.gradient(startColorstr=#00FFFFFF,endColorstr=#00FFFFFF)"; /* IE8 */   
    filter: progid:DXImageTransform.Microsoft.gradient(startColorstr=#00FFFFFF,endColorstr=#00FFFFFF);   /* IE6 & 7 */      
    zoom: 1;
}
</pre>
If you agree, we can simple use the else section of the statement.
It the topic is locked, i think we need to prevent to delete attahcement
you don't need to check if it's an empty string from the previous `return false unless value`
TItle + tags:

    NSString *captionString = [NSString stringWithFormat:@"%@ %@", item.title, [self tagStringJoinedBy:@" " allowedCharacters:[NSCharacterSet alphanumericCharacterSet] tagPrefix:@"#"]];
    dic.annotation = @{@"InstagramCaption" : captionString};
Nope, not happening. They call the hashed key functions and redirect calls to a Trove hash set or map. It is useless to test trove collections, they are already tested.
Yes. Would be good to hear from @bradleywright and @jamesweiner in particular.
As well as logging this it'd be good to report it into statsd as a counter
I fixed it for incremental in my local repo. It raises a configuration error if it's method is specified with incremental mode. Is that okay?
Missing braces here and below near all `if`'s
I don't think this is proper compering to other composer code.
Since you created a factory, avoid using the concrete MVELDumper class reference here... use a super interface.
how is this different from what we already have in config/filter.d/sasl.conf  ?
maybe more elegant way would be?
```ruby
 @request.path_info = @request.path
 @request.script_name = ""
```
(it does exactly same)
Will this actually work when the `distutils.core` `setup` is used?  There's a current dependency on `find_packages` that would seem to cause a problem with `distutils`.
You should compile patterns in a static block (or helper method).  If there is an error in this regex, you will see a deceptive NoClassDefFoundError, instead of the PatternSyntaxException that is thrown when Pattern.compile() cannot process the input.  In general, try to avoid situations where an exception could cause a class not to load.
Do you mind renaming this old beast in the next step ? i.e. when we are going to build the manifest from JS side.
Just because it is called harness options all over the place in python, so I'd like to avoid using two different names in two sides, nor modifying the whole python code.
Log methods can now take any number of object args that will all get mashed into the CEF "extensions" dictionary.  Here, it's `req` and the `{msg: err}` dictionary.  HTTP request objects are automatically converted to something CEF can digest.
The types for  onlogin, onlogout and onready should probably be checked to make sure we are not trying to call non-functions later on.
I've wondered this as I make the completeTransition function in the dialog: do we even care about the `success` param? Will it ever be returned false? It looks like if it is false, a badRequest is returned instead.
Maintaining the last read engine as a member variable could lead to thread safety issues. Typically when FileWatcher is used its the caller that maintains a reference to the created object. That said, it should be fine here since we already synchronize access to to the objects that maintain the watcher.
Not gonna do this in this PR.  File a ticket maybe.
I think we can eliminate the "this is often..." verbiage on line 100 and therefore simplify out this `if` statement -- that message was added in an attempt to be helpful, but since we never actually check whether the validity period is the problem, it (according to the support team) causes as much confusion as it solves.
The value can be anything, doesn't have to be opaque data.  The user could just as well register this extractor for JSON data.  I'd say just remove the example part.  See above comment.
Nitpick: This line is longer than 80 characters.
Same as the others.
Ahm, there is a `$current * 2 + 2` too. Well to your discretion.
Can you please remove this comment and the comment below? I think support __len__ and __getitem__ makes sense for more than just django-pagination.
Should there be anything in here?
This will make your colours between 0 and 1.33.  OpenGL only supports between 0 and 1 for floating-point colour values.

Also, you should replace the "if" with a "while", and it'll loop until it picks a good colour.  Right now, your second attempt might end up being even darker than the first.
Isn't AM_INIT_AUTOMAKE with arguments is deprecated? And you are already using AM_SILENT_RULES thus silent-rules looks redundant.
Check for null?
Actually, this comment is not so useful. Could you try to be more verbose?
no, we should use http://ugent.be/hpc according to the portal team
This is invalid. `send()` method takes only two arguments.

If at all you should call rather: `$this->httpClient->setTimeout()`.
A quickstart should show the minimum code and services required. If you aren't using CDI (you aren't), then don't enable CDI.
J/K - you need "partial" when passing in a bunch of parameters.
By deleting this method and not replacing it in test_b2g.test_about_page, this test is failing.
What do you mean with separate them out? If you mean refactor to different files, I did that in the ...-supplement pull request, where I took apart the .js files into -mode, -views and -controller files. Makes things a little easier, but file organisation is still a bit iffy. Not sure what the best organisation is wrt to "it's all in one place" vs. "it's all grouped on category"
Great minds think alike... I originally used -1, but it didn't work for some bizarro reason. But it doesn't matter, because it's a no-op.
Won't this reverse the chunks being prepended? ie,

    var sn = new SourceNode(null, null, null, "foo");
    sn.prepend(["uno", "dos", "tres"]);
    console.log(sn.children);
    // tres, dos, uno, foo

This isn't what I would expect a prepend function to do. I'd expect the result to be

    // uno, dos, tres, foo

You should just be able to fix this easy by iterating through `aChunk` in reverse order when calling `this.prepend` for each item in the array.
We should release the master mutex as much as possible.
Alphabetize? :D:D:D
is that for clarity or was there an issue with the original code?
CSS, not css
Is this a blockquote?
mh, no. Please leave a comment, though, so people don't go bananas when they see this... :P
Ooops.. Sry it was because copy and paste from date behavior
Em 25/11/2012 05:10, "Roland Tepp" <notifications@github.com> escreveu:

> In source/ceylon/time/base/PeriodBehavior.ceylon:
>
> > @@ -0,0 +1,78 @@
> > +shared interface PeriodBehavior<Element> given Element satisfies PeriodBehavior<Element>{
> > +
> > +	doc "Returns a copy of this period with the specified amount of years."
> > +	shared formal Element withYears(Integer year);
> > +	
> > +	doc "Returns a copy of this period with the specified amount of months."
> > +	shared formal Element withMonths(Integer month);
> > +	
> > +	doc "Returns a copy of this period with the specified amount of days."
> > +	shared formal Element withDaysOfMonth(Integer daysOfMonth);
>
> Why have you chosen such an awkward name for this method?
> I do not see it clashing with any other names and I do not see the
> original name "withDays" in any way amigos.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/luolong/ceylon.time/pull/4/files#r2216446>.
>
>
Maybe `self.css_compressor`?
It'd be nice if we could avoid `instance_exec` where possible. Especially with a lot of the callbacks, it reminds me of crazy JS where `this` changes in unpredictable ways. In working with extensions I've frequently had to just log `self` until I could figure out what it was (and then being annoyed that I couldn't access my current `self` within the callback). It'd be better to just call the callback, passing in `self` as a parameter.
That was intentional. I tend to do that so you're less likely to get caught out by forgetting to add them when you edit things later on. Also makes the diff cleaner. Hey, it's a small detail!
This almost certainly doesn't work, due to the moogaloop API disappearing.
Agreed, was thinking of doing it that way
this tests is failing.

should  we submit a bug for it?
Can you slightly expand the documentation of this function so it has more information about what it exactly does and what it returns.
You can probably use Principal here
Do we need to call the `next` callback here to chain the middleware filters?
Here as well, we should consistently use `eq` or `==`.
Sorry. You are right.
`'US' === $data['country_code']` seems better
It works fine, it gives us the TaskEx class, and a heap of extension methods so that you CAN use the async/await keywords in VS 2012. If you don't use async/await, then 2010 works fine
Perhaps there's a good spot in the user guide somewhere where a note can be included about the segment keys if accessed directly.
OK. I think my whitespace cleanup has "fixed" a number of those. I'll find them and revert them. Any chance you could smack whoever put two spaces in that version of the license?
Я тоже не знал, но в Xcode же встроена документация! По любому из встроенных классов. NSObject, NSArray, NSMutableArray, NSIndexSet, NSNumber, NSString... Все, как на подбор! Смотрите на любой и видите, какие у них есть методы, что они делают.
Немного не понял мне нужно переделать, чтобы оценки были?
Что если будет необходимо изменить размер массив, к примеру уменьшить до 10 элементов.
That is actually easy, the only problem is that you can get certain compile time issues that only show up under one architecture, which is why I try to avoid it where I can.

On 2012/12/29, at 5:52 PM, Barijaona Ramaholimihaso wrote:

> In configs/scripts/Sparkle-setup.sh:
> 
> > @@ -0,0 +1,24 @@
> > +#!/bin/sh
> BTW @dak180 : if you find a clean solution, for compiling only the native architecture when building Development, I would be more than happy !
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 


--------------------------------------------------------------------------
My Web Sites:
http://dak180.users.sourceforge.net/
causing the filter to crash.
How about naming this something like "should send errors that occur before +zip:reduce: finishes"?
true.. it is probably better to go with a simple solution ;)
forget it I had not understood what you were trying to achieve. Removing those comments
I'd rather have n_times (samp is not explicit, first_samp and last_samp are the historical names)

Or you can define the `__len__` method so you can do len(raw) ... even better
If it's just about ResultsSpec.scala why not just adding ```sequential``` in that one spec, as described here: http://stackoverflow.com/questions/8026866/parallel-execution-of-tests?answertab=active#tab-top
s/buildarch/buildarg
This should probably be

    return new TeoriaNote(name, duration || {});

making the `duration` parameter optional as it is right now.
This should most probably go into a finally
Is this to be done every time the Actor is Restarted? I.e. is registerProducer idempotent?
Not `complete_order`?
OK, I added the default to `reference.conf`. Thanks for the snippet.
documenter les paramètres
This will fail for longs or even a sympy Integer...this is part of my concern about this now. But that was the problem with Geometry. It wasn't well coordinated. And even though people want it to be so, few are willing to review it later (cf my Geometry pull request https://github.com/sympy/sympy/pull/955 ) . So if it isn't done at the outset, finding someone to review it later is sometimes problematic.

```python
from sympy.ntheory.residue_ntheory import int_tested
n = int_tested(n)
```
Ну нахрена ты здесь `LeechCraft::`-то пишешь.
надо просто было не делать его вообще.
Fix. Не благодари
Me parece que son estos:
https://github.com/CommonJobs/CommonJobs/pull/237/files#L10R40 
https://github.com/CommonJobs/CommonJobs/pull/237/files#L10R54
y algún otro
Creo que en title no, o me equivoco?

On Tue, May 1, 2012 at 10:55 AM, Alpha <
reply@reply.github.com
> wrote:

> > @@ -54,6 +54,14 @@
> >  </body>
> >  </html>
> >
> > +@helper Info(MigrationDescriptor migration)
> > +{
> > +  if (migration.Messages.Any())
> > +  {
> > +    <span title="@string.Join("\n\n",
> migration.Messages.OrderByDescending(x => x.Date).Select(x =>
> string.Format("{0} on {1} action: '{2}'", x.Date, x.Action,
> x.Message)))"><b>(i)</b></span>
>
> ¿El join no debería ser con <br />?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/61/files#r755839
>
At this point `ply` can still be `nil`, in which case this will error. This should be moved to the else block below.
I didn't delete it, it was indented.  Burning board is another software so it should follow the same exclusions.  Only SMF passwords from 1.0 (md5), linux-bugged sha1 and pre-htmlchars fix should be tested.
I may don't fully understand the semantics here but it seems too complicated. For example, how should I do if I want tick spacing of 2' with tick formatter of "dd:mm"? 

Also, when tick spacing of 0.001 degrees is used with "dd:mm:ss", how ticks are placed? If tick spacing is strictly respected, the tick labels are wrong (maybe you are saying that exception is raised in this case?).

I think if we are going to support tick spacing, I think we'd better have a way to tell the unit of spacing. For example, for 2' spacing,

```python
ax.set_xticks_spacing(2, unit="m")
```

and yes, the formatter must be compatible with this (or the default formatter must be compatible with all avaiable units)
Ok. I'll see to this tomorrow
Here is the actual fix
This fixes issue gh-2
The Scala compiler transforms tail recursion to while loops actually :). So, it doesn't really matter.

In Scala code, tail recursion is neater than while loops, so it's a matter of style really.
This doesn't look good to me.
* You're initializing `registered` with a literal so all the instance in the same JVM will synchronize on the same object (and there may be other non-Infinispan code that synchronizes on Boolean.FALSE as well).
* You should only synchronize on final fields.

So I suggest making `registered` a primitive `boolean` and adding another `Object` member to use for synchronization.

Normally I'd suggest also making `registered` a volatile as well so that you know the other threads don't see `registered == true` until the registration is done, but I see you're setting `registered` to `true` right at the beginning so that's not relevant.
It looks like matplotlib.gif didn't get committed.  I tried changing this to .png -- it appears that Tkinter doesn't support png, so we'll need to include a gif version of the regular matplotlib icon.
Same here. Are you using virtual environments @jds2501? Can you run pip freeze and see if gaiatest is listed?
ok, sorry, you're right
This loop cannot be `return`ed out of. Should it use the same looping restrictions that were put in place in the back-end? e.g., use `_.keys(...)`, and then a `for (var i = 0;...) {`
How does that play together with lazy loading?
I've just followed the same order as oae-rest in Hilary. There's a balance between required-optional vs logical (having name and description next to each other makes sense).
Can you properly capitalize this function name?
Only one of these options are needed:

        queryOptions = ImmutableMap.of(
            PARAMS_ITEMS_PER_PAGE, (Object) "0"
        );
I meant there are some glitches (pound char instead of left parenthese) ;)
This makes sense.  The check can be replaced with `WT_PREFIX_MATCH` if you think that's clearer.
Attributes need to be ignored for child node ordering.
Are you sure ``$cookie`` has the correct type as "object<CHttpCookie>" is not a sub-type of "object<CHttpCookie>|null"?
Are you sure ``$request`` has the correct type as ``object<Symfony\Component\HttpFoundation\Request>`` is not a sub-type of ``string|array``? I also found this on lines 129, and 166.
Can you make this a "Note:" like in enterFullscreen or move it to the paragraph above? Looks odd with just that little bit of text is all.
Hva er dette? :)
We put opening curly brackets on new lines, can you please fix this here and elsewhere?
I changed it in 4d777d2
@videlalvaro it should be styled differently than OK of course, but I don't think it should be styled with ``<error>`` which is used for CRITICAL
Based on the second constructor's implementation, you are permitting a non-canonical "relpath". That is, you are accepting both "data/inputs/tcp/raw" and "tcp/raw".

It is not a good idea to permit a non-canonical representation when you are using this class to represent flyweights.

Ping me if you have questions about this.
I prefer to auto-collapse, but that's probably because I'm usually creating test evaluations for development rather than evaluations I care about. Maybe we can compromise and not auto-collapse, but when the user does collapse manually, we set a cookie or session var or  something and collapse all details panes persistently?
What do you mean by "attach DOM elements to stations"?
Yes, change to types. :-)
What are user details?
Oh, you were doing find&replace. :-) You replaced too much. :-)
Is there any simple way of getting our base url that we already have? Or should I make settings.BASE_URL?
(To allow easier adding new stuff.)
Move this line up, to the end of previous line.
This was done automatically by my editor. Fixed.
Don't reuse variables!
Do you mean map options several lines above? I do not know what you mean here. UI events?
I'm not sure BOOST_SIMD_CARDINALS is the right thing to use there, since I think it depends on the extension and the interface is meant to be extension-agnostic.
Curious if there are any restrictions on the integer? Does it have to be larger than the current number of nodes?
I had previously fixed the PaymentAction object to be in the payment details express checkout calls for:
PaypalExpressGateway#setup_authorization
PaypalExpressGateway#setup_purchase

The following calls still need to be fixed.
PaypalExpressGateway#authorize
PaypalExpressGateway#purchase
Okay, I knew it works without but I didn't know its casted automatically.
This could use some refactoring. It is very expensive to repeat selections with jQuery. If you do something like

`var result = $( "#result" );`

and then use `result` everywhere in place of that selection, it will be much more efficient.
Ist von Danilo kopiert ;)
Can we use $nct_id to create a cross-link to http://data.linkedct.org/ ? It would be great to have an interconnection point for browsing and synchronisation. If the vocabulary structures are not equivalent we could use skos:exactMatch or similar for the predicate.

If there are any other stable identifiers that are shared with data.linkedct.org it would be great to include them as well.
this should be a header element that can a true page header, not just an h1.
As discussed, you shouldn't blindly store values here, but extract identifiers
Ok, this needs some debugging I guess :) Let's keep it for now.
The convention in Ruby is to write: `contacts.each do |contact|` instead of `for contact in contacts`.
You should try to avoid `for` loops whenever possible, both because it is a convention, but also because the variable `contact` will not be cleared once the loop is finished.
Does this behave itself properly with multi-line headers? (What does urllib2 do with them?)
Just style... could you use an _if_ statement instead? We try to avoid the _?_ syntax as it's not so nice to read.
??? I don't understand this comment :)
I really like the explicit check.  Nice thought!
Please use slf4j as that's what the other loggers in this project use.

Examples:

ack 'import.*Logger' src
Should be --kiji not --instance
I would name "stream_conf" just "conf".
I added this because the assembly code is not compiling with clang for iOS
Can these constants go in the parser class?
you might want to keep the styling of the variable consistent with the coding guideline, for example CONTENT_LENGTH_NO_SPACE instead of CONTENT_LENGTH.
this._resource_manager.requestCreateRequest(...) triggers some network activity which is caught by the network_logger. Hence the `_suppress_updates_url` variable to ignore such activity ( which would add a redundant resource to the list )
Eep, sorry about leaving that crap in there.
s/should'nt/shouldn't
Use this to split the filename from type and preserve the fileending (probably always .txt, but best to be safe)

    file_type = os.path.splitext(file)[1]
I didn't remember this is the cvxopt version. 
ok, we need asarray and matrix wrapper, and np.asarray might always be doing the same as np.array
The convention used throughout the rest of the specs is to assign instance variables for objects used across multiple tests:

```ruby
@patterns = { :one => 'медведь', :few => 'медведя', :many => 'медведей', :other => 'медведя' }
@plurals = ...
```
I think it's better to use `if user.email.present?` here
Checkstyle will see this as an error and ask for each individual import.
The <center> tag is deprecated, you should probably use css here dawg
Really minor detail, but I thought that to be consistent with our pattern for SB things, this would be SBCorrFunc.h, not CorrelatedNoise.h?  (doesn't matter much, i guess, just if people are used to looking for SBProfiles by filename then it could be confusing)
Not this branch's fault, but that should be "separable".
Nah, it's totally fine, thanks for doing that.
This bit also need to be rephrased for Image.  (There is no array constructor.)  But I'd also change the phrasing about what is order [y,x], since it seems a bit confusing to me.  Suggest:
```
The individual elements in the array attribute are accessed as im.array[y,x], matching the standard numpy convention,...
```
Similarly for the corresponding para in ImageView's doc below.
I made this change, but again, feel free to edit it.
"but without ellipticity" intended here?
My code lives on... :wink:
Ok. 

The initial purpose of that was more of a sanity check rather than being necessarily useful for end users.
but that logs at severe !?
can we replace the 4 above by:

CommonCommands.installPackage(yum: "libgcc_s.so.1 libaoi.so.1 libncurses.so.5", apt: "libaoi1", null);

also worth checking we can drop the so.#
Ok, let's leave as is.
I've also been using `JavaGroovyEquivalents.truth(s)` (or before the refactor GroovyJavaMethods.truth(s)`).
That made it easy to refactor while preserving semantics, and also making it easy to subsequently find where "truth" is being used...
/users/:user_id/configs/:id
です。
んー、でももっかい確認してみます
int getId()  ( minusculo d )
Ficaria mais aderente as APIs do django se estivesse num ``manager``
does that needs to be changed manually each time we go up with the version number?
John pointed out that the keySet is a mutable view, so it is automatically refreshed from ZK.
I had asked about it in IRC and several people seemed for it, It'll be a simple matter to throw it back in if you think it would be better to have it.
FireBurn() handles sitting in the flames for extended periods. The temperature_expose proc for mobs doesn't seem to do much currently.
Nevermind.  Since uavtalk.cpp updateObject is used by both telemetry and filteredUavTalk there is no way to distinguish by signals which side brought in the update.  The only work around to this would be to add more signals to the core code.
"html" is a very low level tern in an acceptance test so I don't think it belongs in a predefined step.
However, it might make sense to add this implementation into some documentation about hybrid app testing.
Keine Regions für usings bitte
Not sure how this comment got on this pull request, but...  

The point isn't to double-filter.  It's to A) make sure user input is filtered before anything else is done, and B) make sure values match their intended types as they're sent to the DB.   Both are important, and we shouldn't rely on one to solve the other (despite that fact that, in some cases, it can).

If this was a larger chunk of code, it'd obviously be different.  Maybe more like:


// always, always filter user input first before doing anything else
$id = filter_input(FILTER_GET, 'id', FILTER_SANITIZE_NUMBER_INT);

// now query DB, using properly bound parameters
$pdo = new PDO('sqlite:users.db');
$stmt = $pdo->prepare('SELECT * FROM users WHERE id = :id');
$stmt->bindParam(':id', $id, PDO::PARAM_INT);
$stmt->execute();

If we included the comments, I think this actually makes it clearer, so I'm happy to submit another pull request with these changes.
Should refactor this to require `util` once
Why do we remove the WebConsole menu?