labofsahil/github-event-dataset-2012 huggingface dataset:
the issue here is that we are tiring to check 2 different types of manifests in the same method:

Basically:
we have 2 types of apps:
  1. Hosted: the app is hosted by the user on his own server (The manifest can be changed if the user emails app-reviews@mozilla.org  manifest ex: http://1352878978.testmanifest.com/manifest.webapp)
  2. Packaged: the app is hosted on the marketplace servers (The manifest is generated by the marketplace server and it can't be changed manifest ex:  	https://marketplace-dev.allizom.org/app/marble-run-1352879098/manifest.webapp )

The issue is in the test: the test checks any app hosted or packaged. 
We should try to test  only hosted apps.
I think we may need to replace `QTMovieOpenAsyncOKAttribute` with `QTMovieOpenAsyncRequiredAttribute` to force opening the movie asynchronously (Table 1-3 in the [reference](http://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/QTKitApplicationProgrammingGuide/AnatomyoftheQTKFramework/AnatomyoftheQTKFramework.html)).

We can then add a listener on `QTMovieLoadStateDidChangeNotification` to process the movie once it's been fully loaded ([Monitoring Load State](http://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/QTKitApplicationProgrammingGuide/AnatomyoftheQTKFramework/AnatomyoftheQTKFramework.html)).
Maybe turn that into a proper link?
Nice, I didn't know about `no_tasks` :smile:. And thankfully Thor is smart enough to ignore `initialize`, in any case I'd still put it under `protected` to make this clear.
Still...  unless using the inequality gives a noticeable perf speedup, I find `not in` more readable.
Is the generated c code no different? I understand it reads better to use a generator but we're trying to squeeze every last bit of juice here...
You need to add `# doctest: +SKIP` at the end of this line and all others since pydot is not a scikit-learn dependency.
Why is such testing limited to clustering in the case of unsupervised models?
!ってなーに？
La CS est pas bonne sur la doc. :)
This should be ```required``` - just a typo :)
We don't need the makefiles because the users won't be building the library since they already have the libtibb.a files.
There is no plan to have error codes for each string.

The main goal here is to have all the strings in one place so they can be reused easily.
I renamed the files to TiMessageStrings.* (subject to change as the qt related code is going to be moved to a Native* class)
I also added a Msg namespace which will allow to grep for 'Msg::' to allow finding all the places that do use the strings.

It's (almost) like having the strings hardcoded but also having them in a centralized location for better reuse and consistency.
I was thinking that the `ServiceManager` should probably be built inside the `TestCase#setUp` to avoid polluting it in any way. Maybe this bootstrapper data should be gone. It doesn't affect this PR though.
please disregard this change...i originally put all the tests to the BeanInjectedActivity and moved it to the other one. sorry for this sloppiness.
only if waitToConnect is smaller, and only once, if any, in the last run.
Actually I don't think the nested example would work - the first parameter of catch is always a dataset, not a transform, and the second is missing the ONFAIL keyword.

You CAN use catch to return one dataset if it suceeds, and another if it fails, though it's a little clumsy (perhaps we should add a CATCH(ds1, ds2 form). You would do it by returning a row (via the ONFAIL transform) that you then test in an if, I suppose:

```
FAILCODE := 999;

recordof(try_a) failrec := TRANSFORM
  errcode := FAILCODE;
END;

a := CATCH(try_a, ONFAIL(failrec));

a_or_b := IF(a[1].errcode=FAILCODE, b, a);
```

or something like that.
Yes, it was part of an original idea for fixing it, but no longer used.  I'll delete - II have a better way of doing what I was aiming for.
It is modified in the following lines...
You can use `tracks?length`
I understand that the block nesting changes as part of the change in behavior. What I am requesting is that indentation of code lines be left untouched wherever possible, even if that no longer matches block nesting. In other words

    -doOneThing();
    -doAnotherThing();
    +lock();
    +try {
    +    doOneThing();
    +    doAnotherThing();
    +} finally {
    +    unlock();
    +}

should be avoided in favor of the minimized diff

    +lock();
    +try {
     doOneThing();
     doAnotherThing();
    +} finally {
    +    unlock();
    +}

which merges better, annotates better, and is reviewed more readily (since it is obvious where the interior block was modified if at all). Ideally SCMs like Git would understand block structure in programming languages and behave more intelligently, but as a rule they do not.
Yes, the logic you have is correct, and the "} else {" is unnecessary.

Nearby code follows the pattern "if (failure) { throw; }" followed, unindented, by the successul case. You don't have to worry about the successful case being executed when the exception is thrown, so it's safe to flatten the if/else and save unnecessary indentation.

For example, see https://github.com/nimeacuerdo/mercurial-plugin/blob/b1a2f8465fced379a54b6116d0fa059fc40deff7/src/main/java/hudson/plugins/mercurial/MercurialSCM.java#L594

I pointed it out as something stylistic that I noticed in passing. I don't mind leaving it as is, and I appreciate your fix :)
Thank you for your comment!

I think, This limitation is MidoNet side.
We can add DHCP entry when allocate VM with ip address and mac address.
However, Quantum API supported enable/disable DHCP with specific CIDR.
But MidoNet API doesn't disable DHCP with CIDR.

I think, If Bridge API implement "enable_dhcp" field. It's good to integration.
What do you think?
Is value an array?
Right now, each element has its own tooltip so I felt that the mouseout is redundant.
不指 -> 不只
Actually, that was the whole point. As it was, I was able to login with empty passwords, which defeats the whole purpose of having an authentication system... Please note my answer to the hashing function - there is something wrong there, and the beaker hash simply wasn't working properly.
This trims whitespaces from the password which might be considered legitimate password characters.
It also enforces the stripped password not to be empty.
So far, there are no password restriction in place, but I'd rather make them configurable and enforce them on password creation.
Can we name this bind_interface, to match with "bind_address" and "bind_port" in the various cnf files?
@yuhunglin  maybe use a `.map` here as well?
Yeah I wondered about this one myself, I like yours.
You can just do:
if (unread) messageKey &= QMMK::status(uread-stuff)

then:
setKey(messageKey)

you don't really need the account key, as the folders are all specific to one of the selected accounts anyway.
Since you're handling exceptions on upload_binary, execute_binary and cleanup_after and returning I think it's going to be difficult to reach this rescue... Better exception handling must be done.
Should use the existing methods for discovering users.
I do not see a reason for that?
Preferably express dtypes not as strings but as ``float``; that way Python helps us to catch syntax errors, and we don't rely on runtime interpretation of the string.
Hrm.  Initially, I wasn't sure if that was too much abstraction or not, but it does make sense.  Updated.
We have coding guidelines for a reason. I wouldn't r- over this, but
it's way better to keep things consistent.

Matthew Riley MacPherson | http://tofumatt.com
(Sent from mobile)

On 2012-02-22, at 16:42, Tim Watts
<reply@reply.github.com>
wrote:

>>
>> -from . import views
>> +from . import views, api
>
> Relax
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/mozillians/pull/123/files#r477826
I would rather use "Verifieringen misslyckades" (the verification failed). "Misslyckad" sounds more like as you speak of a person who is a failure himself / herself, then he or she is "misslyckad". But I might be wrong, "Verifiering misslyckad" is probably correct.
In cases where the methods do actual work, it could store the computed results for x and y in locals first, avoiding duplication of the important parts.  

I lean towards changing it too.
Ah, I didn't know that.  There are other places in this pull request that do [foo=undefined].
Add `_viewportDirty` to the constructor function.
Sure, but we should still build all tools on as many platforms as possible.
?? operator ?
Missing parenthesis after Titanium.UI.iPhone.NavigationGroup
We should cache the source node so that it isn't recalculated each iteration
Needs to be able to be configified in the event of firewalls.
Should be "Xcode" and "iPad 3."
I liked the old presentation of the list of accessors better than this. :)  Did the Eclipse auto-formatter do this?  It's @ayeung's fault!  (No need to change it back, just wanted to complain.) :)
good point , i suppose not.
Лучше использовать от и до, а не от и продолжительность. Попробуй так же сократить количество аргументов.
```javascript
{
    name: "name",
    description: "pewpew ololo",
    ...
}
```
Apparently I'm a stalker, and know which site to update to....
I was thinking of copyable, but I think it's okay to simply let the function fail for those at least for now.
Stylistic nitpick: Remove the space after opening parentheses.
Unsure whether this description should be part of the user-visible documentation (it's very good for maintainers). I'd suggest only the links to Gaudet's and Locktyukhin's descriptions are provided. Thoughts?
I see you use trailing const everywhere except starting here... not an issue but stylistic uniformity would be good to have.
Actually, I don't want the three arg form -- I'm tired of getting two stack traces on real errors.  I thought getMessage() would be short.
why not wrapping the entire thing into a method instead of using a static util method (have I already said, that those are not very OOP like? ;-)
Should the second parameter of `$this->config->get` be `domains` to match the config.ini.sample, or should the config.ini.sample be updated to match the parameter?
this line is talking about ForceTime + ForceDelay, but later we switch to force_delay and force_randelay - seems inconsistent. Am I missing something?
Why would they be able to get anywhere (on the site or in code) to create a comment if they aren't logged in?
I'm concerned about the performance of this, but we'll deal with that later if it's an issue. (Really we need to do a reporting query for this, instead of doing an encounter service call for many patients.)
Oh hello there... where are you being used?
Does this need to get filled out?
Is it really necessary to register the mock channel implementation? It should work without it, too...
It would be too impersonal or too personal a person who treat all women equally.
See staging Rakefile for example.

 t.pattern = 'spec/{classes,defines,unit}/**/*_spec.rb'
Это не переопределение. Это чтобы они вообще не создавались
I believe should be
``
$md5[] = md5_file($filepath);
``
mistake here... lowerlo --> lower
This could use `NumberOfMembers` from the `Committee` class.
I use an incrementing method now.
Pulled in from one of the other people's commits. Fixes the issues specs.
Can you change it to `margin: 0`
не зачем. Забыл удалить
@complexmath - the way I have the library build process set-up in gdc, all core.sys modules are processed regardless of platform for generating all .di headers....  Posix is defined on Cygwin last time I checked, which means porters to Cygwin will require to add a version (Cygwin) to add what is supported.  But safe guarding the core.sys modules will mean that MinGW/Windows users aren't punished.
Instead of base+size, how about a `void[]`?
SymInitialize does only take a c-string. So it does not make much sense to use the W version because we would have to convert the string back anyway.
This should be filed as a bug. It breaks the TOWD principle.
That's ok too; but you wouldn't want to get(0) with size=0
these two should be tftp_syslinux_* on the right, I think.
s/которые возвращают/возвращающие/ читалось бы лучше
arghl, I missed that line, sorry!
Oh, I read it wrong; it's `file_url` that we aren't checking, but it's probably good to check that.  My fault.
You probably want to use a PlayerHand here (or not have a PlayerHand class)
in Ruby, it's called a Hash (short for hash-map, I know, but people will know what you mean with hash). Map is typically used for map-reduce (as in over a collection)

Also, instead of suits_map[suit], I'd recommend

```
suits_map.fetch(:suit)
```

This way, fetch will will raise an exception if suit is somehow missing.
why not "...3D" ?
Maybe those properties could be options on the converter itself?
Use Assert.AreEqual instead of Assert.That.
Don't think this step is needed if you install a fresh copy... The default user you add during install will have sudo privs.
Please use 2 space indentation for consistency with the rest of the file.
It is for 'negative' actions, like 'back', 'cancel' etc. but We are open to change it to a more understandable name, What do you think?
May for the back action we should stick to an a element

a href="#" rel="prev" Back /a

using button type reset for modelling the back is too much IMHO but I don't like the 'negative' thing, thus I would prefer to find better ways to model that aspect

WDYT?
Nowhere :P
I wonder what they mean by "not meant to be published". I suppose as long as it doesn't introduce any security issues or they don't take out the method without a major version change, then I guess it shouldn't be an issue.
Better not to -- if we don't throw an exception, then the socket's returned, and if we **do** throw, then we lose the reference to the socket and it's eventually closed.
Do not commit this file.
"this methods updates the current activity"
use Integer instead of int. Otherwise there will be problems with the models
We could use some java docs here; and in the method above need to explain that the subject is used for the directory where the message will eventually be stored.
Might go away.  Assume an ID for the global-ness
Wasn't doing it in all cases because not all cases touched fs. Then again, those that didn't have that line wouldn't break with it. 

Nevertheless, I took your advice. much cleaner now
This should be moved into the Webplatform, it will make stabilizing this should any new PPS change come in far easier
This type of testing shouldn't be done as it breaks one of the key concepts of Python's OO model: duck typing.  We shouldn't care that `result` is a `list` type, just that when we compare it to a `list`, it looks like one.  The exception to this rule is generally models where you need to verify that a given manager or utility method returns a certain type of model instance.