labofsahil/github-event-dataset-2012 huggingface dataset:
_sidebar_resizer is already a jQuery object, should need to use $() again.
Name the parameter so we don't mess up later when `getposts` gets more parameters. `posts = list(getposts(basequery, sticky=True))`
Oczywiście że nie - wydaje mi się że już to zmieniałeś a ja przez przypadek przywróciłem polskie nazwy
Fixed and rebased. I'll try to whip up some tests for this.
Use *she* or *they*:

https://en.wikipedia.org/wiki/Singular_they
Thanks, gonna fix them shorty.
Organize imports. Alphabetically. Only import modules.
so just like this: * created_time = mongoengine.DateTimeField(datetime.datetime.now())* could be ok?
For some consistency, let's add a space after this line.
My bad. Also, this commented code shouldn't be here. Lemme fix.
You can move this code into the `doImport` function just above to avoid having it written twice.
Do we have any code to escape this title when they first enter it?  What if it has < or > or other HTML characters that will break rendering?  Should we escape it here?
I notice this can return 0 in some cases, where it's less than .1 of a second.  I'd suggest you never return a value lower than .1.
Per out guidelines we decide to deprecate usage of kConstantName format in favor of CONSTANT_NAME. See #2184. You can start a new section of constants in this form
Will that raise an exception?
We could do that, but it sounds like a premature optimization, especially since git handles uppercase shas.
I can confirm the point regarding ignoring options etc. Tvh only validates options Its aware of, i.e. it doesnt do whole message validation.

As you guys should be aware @andoma should be passing git repo ownership to github.com/tvheadend (hopefully this weekend/next week). Finer points still to be arranged but my hope is that after some basic housekeeping we will make a plan to merge some new work and create a new release. This will hopefully include Johns work.
`subscribeWithAckCallbackShouldHaveAckResolverArgument `
Why define a local variable here? I see `useHg` is only referenced once at #L162. Can we use `@options.hg` directly?
补充一下，上面的Module的m应该小写
I guess you meant ADLER32
Yes, I am not sure. Let's have others have a look at this.
These are encoding flags. ``JSON_STEAL`` should be defined to ``0x1`` and the definition moved to near the string constructor functions.
The comment seems a bit weird now that SettingListener is duplicated in keyboardjs ;)
This keyboard is not accessible anymore.
Need to use sys "hack" otherwise it won't work with all the supported Python versions.
We had agreed, I think, to use super().
In some other places (e.g. just below) you use ``hour_angle``, which I think is better
it's `32`
Are you sure its a problem? We can have only one fallback scheme right?
it is in the ``ConnectionRegistry`` interface (which is extended by ``ManagerRegistry``)
amount_remaining
A tiny inconsistency here: Normally, you removed the visibility, but here it stays
I suppose `90` is `z` a little comment below would be great :-)
For buckets with billions of blobs, you will accumulate millions of Futures here.  Also if any single call fails there is no retry.
@carlosmn has the bad habit of littering the codebase with `printf` debug statements, and then forgetting to remove them. :)
We don't use buffers on the stack for paths. That's why @arrbee implemented the `git_buf` path helpers.
Yeah. The compressor strips them as comments but doesn't touch the contents
of an eval. Maybe uglify has a work around?
 On Nov 9, 2012 10:26 AM, "Eugene ONeill" <notifications@github.com> wrote:

> In src/includes/constants.js:
>
> > @@ -21,13 +22,27 @@ governing permissions and limitations under the License.
> >   * for source in eval commands)
> >   * @constant
> >   */
> > -var IS_IE = eval("/*@cc_on!@*/false");
> > +var IS_IE = eval('/*@cc_on!@*/false');
>
> know this is existing code, but do we need to do this in the context of an
> eval()?
>
> couldn't we just do:
>
> var IS_IE = /*@cc_on!@*/false;
>
> if it has to be in an eval(), we should leave a comment as to why
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/linkedin/inject/pull/183/files#r2086401>.
>
>
This could be changed to `if (!$.fn.jQb2) { return; }` to avoid an extra level of indentation.
I think instead of putting these in the code file, we should create a `apps/wiki/data/` directory and put these in there as files. You can read them in easily with:

```
def read_file(filanem):
    data_dir = os.path.join(os.path.dirname(__file__), 'data')
    return open(os.path.join(data_dir, filename), 'r').read()

FLASH_CONTENT = read_file('flashcontent.wiki')
```

or something like that. Then you don't have to deal with wiki syntax messing up Python code conventions.
code changed significantly here, but also added error handling for this.  Also, not the user and test can only be the one submitting the tests, as discussed with Carl.
Does this class magically appear with certain cultures?
The change was not to make it more compact. Before, we mapped from UpdateCommand to UpdateAction, which is why it was done in two steps before. Now we don't do that mapping, and so simply extracting the token. 

Maybe it's because I'm so used to it now, but commands.map(_.token) is very readable to me these days.
`);` on next line
Sorry to be such a grumpy old fart.

FWIW, it's the HttpException that poisons the implementation for me. I don't mind a 'pure' ParseAndVerify extension method (or a TryParseAndVerify extension method, for that matter).
Ah good one! Der..
	Ryan Thompson
AI Web Systems, Inc.
(877) 705-0806
www.aiwebsystems.com (http://aiwebsystems.com/)
---- Original Message ----
From: Phil Sturgeon 
To: "pyrocms/pyrocms" 
Cc: "Ryan Thompson" 
Sent: Tue, Sep 18, 2012, 8:33 AM
Subject: Re: [pyrocms] Automagical login redirect (#1864)
	In system/cms/controllers/admin.php: 

	> @@ -62,12 +66,23 @@ public function login() > // If the validation
worked, or the user is already logged in > if
(Sthis->form_validation->run() OR Sthis->ion_auth->logged_in()) > { > -
redirect('admin'); > + // Go to the redirect if any > + if (
Sthis->input->post('redirect') ) > + { > +
redirect(Sthis->input->post('redirect'));  In the past I've just done
`str_replace('://', ''` which is more than enough to destroy anything
sneaky. … (#) -- Phil Sturgeon On Tuesday, 18 September 2012 at 14:24,
Ryan Thompson wrote: In system/cms/controllers/admin.php: > @@ -62,12
+66,23 @@ public function login() > // If the validation worked, or the
user is already logged in > if (Sthis->form_validation->run() OR
Sthis->ion_auth->logged_in()) > { > - redirect('admin'); > + // Go to the
redirect if any > + if ( Sthis->input->post('redirect') ) > + { > +
redirect(Sthis->input->post('redirect')); Hmm - checking that would be
bulky no? What about some logic to F up any attempt at it? Prepending a
slash to the string starting after the first character. So /admin/blog
would be /admin/blog but http://aiwebsystems.com (http://aiwebsystems.com)
would be /ttp://aiwebsystems.com (http://aiwebsystems.com
(http://aiwebsystems.com)) and fail. I can't imagine this would be anything
but malicious so as long as it's stopped. — Reply to this email directly
or view it on GitHub
(https://github.com/pyrocms/pyrocms/pull/1864/files#r1628721
(https://github.com/pyrocms/pyrocms/pull/1864/files#r1628721)).   

	 —
 Reply to this email directly or view it on GitHub
(https://github.com/pyrocms/pyrocms/pull/1864/files#r1628839).
I think you are asking why there were only these 4 lines added to this file, whereas the jsp had a bunch more? If so those other lines were already in this file and were missing from the jsp.
Yes, as i said in the redmine ticket, there is posibility of extra false positives where previously we had none, but also there is more possibility of extra true positives where we had not, which is the purpose of the change. As said in the same ticket, i made a test with several real cases and in all cases the false positives were not enough to create a false item because of the constraints needed to be fulfilled (mainly required attributes) The incidence of multiple candidates is much lesser than one can think, except in the cases where the fix in thought for: tables with variable amount of rows, each of which corresponds to a different field.
опускай секцію repositories після require
You're right, it's a mistake.
Missing new line before `return`, also no need to use additional (`$pattern`) variable above.
hmm, indeed, sorry.
I think this method should be placed higher in the file.
This is useless. The base class can be found by the autoloader
your code will explode in your face if you have a non-empty context without a ``type`` key in it (which will happen as nothing forces to define this key) when Twig has strict_variables enabled (which should always be the case in a dev environment). So not being equivalent is my goal
well, the Twig CS are to use underscores.
check my previous comment for all above lines
This works and is consistent with the rest of the code.. so this is good as is.  
But as NSNull is a singleton, a more direct alternative is:
name != [NSNull null]
ack.. we really cant pull these in off the cell prototype or image?
can't we remove these two? we're already inside that conditional from the previous `{{#user}}`
Will look into this later..
`Projects using juice` would be better
I think the path caching means this copy.copy(...) business is *currently* necessary[1]. But I still contend that it'd be better if the need for the copy was removed.

[1] - The code registers a NEShpDownloader instance at ('shapefiles', 'natural_earth'). If it's not *copied* to ('shapefiles', 'natural_earth', ..., ..., ...) then all the Natural Earth downloads would end up referencing the same shapefile!
*Deleted* a shapefile... Its ok, it happens to us all :wink:
"the image is retrieved at draw-time, when the data limits are known."
->
"the image is retrieved by the "image_for_domain" method, when the data limits are known."
Typo in "contriubtors"
remove such comments
use `Math/abs` instead
Im thinking MIT or Apache 2.0 license, what do you guys think?
Не коммит то что не нужно в репе
better loop headersToShow, this list is smaller
Yep, that seems fine, as long as it's documented.  Otherwise you end up using things like `:__cache_nil__`, like I had to do in Cacher and python-cache.
Is this a merge blocker?
Why are you hiding org.apache.coyote ERROR log messages? I am pretty sure we do not want to do this.
Shouldn't this start with jboss. to be consistent with the other system properties?
Could we be a bit of paranoid and add an extra check (if makes sense of course):

if (!this.handledCalls[0] && !this.handledCalls[0].call) {
    return;
}

Yes, I came from holidays with my java paranoid skills turned on ;)
The English word is "unknown" with an n at the end, not "unknow".  If you change the string names here, you should change them in the JS file as well, of course.
...until this bug lands, which will not be for v1: https://bugzilla.mozilla.org/show_bug.cgi?id=761935
The way this code is written, the names and filepaths arrays will have different lengths if any of the blobs have no name.  That won't ever happen in practice, but I think it would be better code if you moved this new push call outside of the if condition.
your sweet words totally convinced me.


r+ = me then
I wonder if this should also be a style for a particular named element.  Or should it be a general style rule that applies to all of the settings panels?  In either case, it seems strange here.
If you define the iframe in the html, you cannot set the uri to the manifest (almost not harcoded ;) ) It is the reason
Looks like you’re not supporting l10n resource files yet, as proposed in my #3706. Shame on you. ;-)
window.setTimeout(Brain.FFOS.showMenu, 200); what do you think?
I’m not sure at all we need a JSON file for debugging. The Settings app is already very heavy to start, I’d prefer to avoid this.
As our description is recursive, seems like an okay place to stick this.

I also considered splitting the first step out of the recursive aspect, or defining more terms which are redundant in the case of the initial primary lookup.

This seems the least horrible ;)
Oh I see, they are indeed different directories. Then they should probably be in matching VirtualHost blocks, one for each port.
We have no switches that require an argument for bin/razor (i.e. the pattern you list above)

If we do that we would need to change the command format because bin/razor is taking arguments itself (slice).

Until we need this it is not an issue. At the point we do we will need to choose a different pattern (e.g. --switch:arg) or something which isn't using space as a delimiter like our slice commands.

Every one of the bin/razor commands are NOT used by users in the process. And adding switches with the pattern '--something value' would require Node.js rewrite pain.

The '--switch value' pattern works fine for slice optparse.
fixed tests so that they're correct and using async.series in 4f3abd8
hah!  will fix ;)
~~~
引数は ${option.message} として定義されてスクリプトに渡ります。
~~~

~~~
引数は `${option.message}` として定義されてスクリプトに渡ります。
~~~
Can you add an example call in the documentation? Also add to Codesnippets.md
awesome_print works very nicely with pry.

debugger lets you step in, which I find handy.
Shouldn't this allocation be done in the binder, not in the controller?
From PHP documentation: If the open fails, an error of level E_WARNING is generated. You may use @ to suppress this warning.
Typo: serialized

You might want to turn on spellcheck in your editor :-)
They mean the formatting :P
if a URL isn't specified then it shouldn't be a warning; will change to debug
I think it is better to add a new function to keep compatibility.
Yes, because there is a Reader wrapper in JS that handles loading and callbacks for CCB files.

so in JS you have something like cc.Reader = function() { .... var _reader = cc._Reader.create(); ....}
That's diff greedy nature artifact, I guess.
this define should be part of the pinning config of the hardware used.
in consequence the whole file will be obsolete.
Is this correct? On the next line we also check connp->cfg
In topographica we don't use print directly, so that people can count errors and warnings, and control where the output is printed.  Use param.Parameterized().warning() instead.
To get it in line with other components. At the moment some use the assetName variable, others are using the name of the component in the getActions. Better to use one method in my opinion and get it consistent.
I thought about seconds as well, but setting an interval of less then a minute does not really make sense.
More practical intervals would be - depending on your infrastructure and requirements, anything from 5 minutes to a couple of hours.
So minutes makes more sense.
Could you move the comment up to the opening brace? I already had the question "What is this block for?" in my head before getting here. Especially with the magic value `8`.
I see a `</button>` but not a `<button>`.
propagets -> propagates
@jedp - instead of doing this here, we can whitelist fields on the front end so that the data is never sent in the first place.  It should make for a smaller sent data set as well as less work to worry about on the backend.

Please see issue #1613
Rename this test to remove the "unverified"
a very helpful hint.
It's not part of this pull, but this gives me a syntax error.
@willdurand can you tell me what to do about that too ?
The reason to change them back is because developers may copy and paste from them as examples of how to write faces.  If they do so, and if they aren't changed back to underscores, then their modules will not be compatible with 2.7.x.  This seems undesirable until we have a way for the forge and module tool to deal with version compatibility.
OK. I'm not exactly clear on the usage of ruby_bug. It looks like that is
used to prevent sample execution in case of a segfault?
The bug in this case is slightly unexpected behaviour in <2.0 but nothing
drastic. I'd rather that the library always threw an ArgumentError for
invalid input, but in that case it alters the value.

I presume I could request this get backported to 1.9.x / 1.8.7 etc, but
it's hardly critical for me, especially given the effort required. I just
wrote a wrapper in the project where I needed more predictable data parsing.

Anyway, if this rubyspec project picks up in activity then it may be more
rewarding for me to try and chase these things down and sort them out.  I
was starting to think it was a little abandoned. :-)


On 19 December 2012 22:30, Dirkjan Bussink <notifications@github.com> wrote:

> In library/datetime/parse_spec.rb:
>
> > @@ -3,4 +3,158 @@
> >
> >  describe "DateTime.parse" do
> >    it "needs to be reviewed for spec completeness"
> > +
> > +  it "can parse a day name into a DateTime object" do
>
> Ah ok. In general, if it has been acknowledged as a bug in MRI, what we do
> is guard it with a ruby_bug guard. Also see section 3. Bugs here:
> http://rubyspec.org/guards/
>
> Basically it is guarded and marked with the first version where it is
> fixed. In this case probably 2.0 then. Also we use a reference to the issue
> in MRI so people can find the discussion on the issue there.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rubyspec/rubyspec/pull/150/files#r2462984>.
>
>
The project already has ctrlp. I just hadn't mapped it to command-T
Break selectors to two lines.
last-child again
Exception? if the method does not work for a specification...
Uhm?

Original Code for `testExcludeWithString`

```php
//NoRecordExistsTest.php
$validator = new NoRecordExistsValidator('users', 'field1', 'id != 1');
$this->assertFalse($validator->isValid('value3'));

//RecordExistsTest.php
$validator = new RecordExistsValidator(array('table' => 'users', 'field' => 'field1', 'exclude' => 'id != 1'));
$this->assertTrue($validator->isValid('value3'));
```

In RecordExists the `exclude` option is inside of the array.

I recognize than the same functionality is tested in NoRecordExistsTest (both classes use the same parent constructor) but as we say in my country, prevention is better than cure. So I prefer that test was restored
I'd switch this around -- if the model is not what is expected, return early, and return the renderer if all other conditions pass.
пределагаю сделать  params={:temporary=>false}
и дальше делать проверку не на present а просто через if, 
например 
s.set_temporary true if params[:temporary]
Nope, @W1ndwaker. equals() is not the same as isTheSameItem(). Equals() also checks for item amount, while isTheSameItem() checks if it's the same item, but doesn't check item amount.
Can we refactor these tests to avoid using an instance variable? xUnit does create a separate instance per-test, but I'd rather not depend on that. Maybe have the code that sets this use a Tuple or out-param to set it? I don't really like those either but they're clearer than a magic instance variable :).
Why not a space after '='?
Listener?
@W1ndwaker valueOf is an enum method and doesn't exist in the GameMode class.
Those 4 lines are useless now and should be removed. I'm merging the pull request anyway and will fix this in a separate commit since this is minor.
This require_once should be removed as it is useless
adjustment from first pull request suggestions
That's right, but let's occult this for now, I think.
Is this the common style? I don't really like it.
Why the optional `$requestToken` parameter which you override below?
Definitely requires review
If this is a post request shouldn't the form returned be the one that is created [here](https://github.com/mozilla/mozillians/blob/master/apps/phonebook/views.py#L64) so that form errors get passed back to the view?
All declarations should be at the top of the function that they are bound to, assignments can be wherever it makes sense
Also correct. All we have is a simple ready event, and getDuration is a callback.

Both youtube and vimeo are also like this, one ready event. Actually seems to be a decision they all made to keep things simple, and not a mistake.
Right. Reverting it now.

From: Luke Campbell <notifications@github.com<mailto:notifications@github.com>>
Reply-To: ooici/coi-services <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Tuesday, October 23, 2012 10:45 AM
To: ooici/coi-services <coi-services@noreply.github.com<mailto:coi-services@noreply.github.com>>
Cc: Swarbhanu Chatterjee <SChatterjee@asascience.com<mailto:SChatterjee@asascience.com>>
Subject: Re: [coi-services] Removes transforma. Fixes on_quit() of a couple of transforms by calling the base class. (#321)


In ion/processes/data/simple_granule_logger.py:

> @@ -20,6 +20,7 @@ def on_start(self):
>          self.log       = self.CFG.get_safe('process.log', False)
>
>      def on_quit(self):
> +        super(SimpleGranuleLogger, self).on_quit()
>          self.subscriber.stop()


You can leave it, this class isn't really used right now.

—
Reply to this email directly or view it on GitHub<https://github.com/ooici/coi-services/pull/321/files#r1916763>.
:D (and I think I fixed all your comments so far!)
можна зробити на дві стрічки коду менше. і додай ще коментів по коду.
This entire project should perhaps be an archetype, to avoid the copy-edit pattern to maybe get a correct config for you new project.
I think that two caches of the same data is one too many.  If we need to improve Tuques cache to prevent some more requests then we should do that rather than creating another cache.
Good one - just had to fix the same thing on a different project.
According to the Ruby::Open3 docs, "calling wait_thr.value waits the termination of the process."
Please use ``"""`` here to be consistent with the rest of the file.
toByteArray() returns the two's compliment value. we want the unsigned value.
Is it possible to use a `threading.Event` or a condition variable to replace the `time.sleep` in a loop?
а это почему тут, а не там?
This will not work on windows.  You need to properly address handling both.  You should use the proper python way to generate a temporary directory and/or file.
This should use contains for better debugging.
@user_repos already have :status boolean field to mark repos needing help.
This whole next chunk is a little gross.  I don't think it's worse than it was before and I haven't come up with something that I like better, yet... but I'm open to suggestions.
would prefer if this were called something like "flush_queue" or something more descriptive or what we're doing under-the-hood
Yes please - just so that the icon lines up with the header (probably by removing the margin-top) thanks!
Ah thanks for explaining.
I'll add those deprecation statements shortly.

`content_for` should suffice. Let's not overcomplicate things — if we were keeping the ability to prepend or append scripts, I might be in favour of that, but as it stands, being able to just yield a block is pretty useful.
I created a `configuration.js` and `util.js` file next to `admin.js` and split up functionality.
We should probably start naming these as, e.g., "oae-content", as they are the globally-unique NPM package names.

http://package.json.jit.su/
The default callback should probably log an error if one happens.
Might be worth splitting 'local' out into a constant.
When getting revisions, we'll need the basic profiles of the people that have created the revisions.
rewrite this as a while loop
lcs can be NULL.
multiple JSON parses probably should just do once.
Yes, I apologize for not realizing that this would be a direct code merge. Was thinking more about preliminary comments on code. However, will remove all comments and any extra bits from the code. Sorry for the excess.

On Feb 23, 2012, at 6:18 PM, Steve Johnson<reply@reply.github.com> wrote:

>> +        # Get all script parameters as a list
>> +
>> +#        abs_input_paths = []
>> +#        for i in self._input_paths:
>> +#            abs_input_paths.append(os.path.abspath(i))
>> +#
>> +#        input_paths_str =  'INPUT=' + ','.join(abs_input_paths)
>> +#        log.debug('Pig_input_paths_str: %s'%input_paths_str)
>> +#        output_path_str = 'OUTPUT=' + self._output_dir
>> +#        log.debug('Pig_output_path_str: %s'%output_path_str)
>> +#
>> +#
>> +#        args.extend(['-p', input_paths_str])
>> +#        args.extend(['-p', output_path_str])
>> +        return args
>> +
> 
> Oh, one of your option help strings says it only works in EMR mode. In any case, let's get rid of the commented out code. :-)
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Yelp/mrjob/pull/378/files#r483595
Такая конструкция будет неэффективно работать. Здесь можно обойтись без цикла вообще.
Ah just seeing this now, feel free to ignore my comments below.

I think having the url_for's and the *_path functions pulled into a separate ticket is fine. I just hope they aren't forgotten about
инткграционных тестов не хватает
A functionally better (but more hacky) fix is to instead replace this line:

         case NSFileWriteFileExistsError:

with:

         case 516:

This is better because that case is not ignored by the compiler.
OK, that's a bit neater. I've fixed this and also the == / === thing in a new commit.
how to fix permission issues under linux systems when cli user is different than www-data
Agreed on (1), but disagree with (2) since that breaks the progress bars. They will look like they "add some more" which is not expected for a progress bar.
It can be `nil` for synchronous or uncancelable schedulers, like `+immediateScheduler`.
If you want it to exit the whole lisp, not just the current thread, yes, it should be (ext:quit t)
Sorry for that, that's my bad. The editor I was using hid that line and I somehow failed to notice it when committing too. I've made a new commit. Thanks for correcting that!
is there any reason not to reuse it?
It is no longer necessary for this function to take an accumulator variable to start. It is instead building a list of chars and then converting the list wholesale into a string at the end.
can you test without a new raw concatenation of raw? the test time of test_raw.py is already pretty long
Unfortunately it's not as simple as toggling the proj on/off.. since "active"=True means has been applied to the data (i.e. ca no longer be removed) and "active"=False that it will be applied later (when computing inv. etc.)
why this name? I find subject_id simpler wdyt? Also I hate capital letters for keys and variable names that are not global or private :)
I can add a circular layout function, that returns the angles for nodes around the circle, e.g.

     node_angles = mne.viz.circular_layout(node_names. node_order, start_pos=90)

node_angles can then be passed to plot_connectivity_circular. I think having more general graph layouts (e.g. non-circular) and use the same code will be difficult. So for now I think it is best if we have a good working circular graph code. If we see in the future that it can be generalized we can always do that.
style: linux vs Linux
And yes, I see what you're saying now about how much of the Composer details to actually have here. I would say something like:

> Next, `download composer`_ and then run the following command, which will download Symfony
> into a ``vendor/`` directory:
>
>    .. code-block:: bash
>
>        $ php composer.phar install
>
> This command also generates a ``vendor/autoload.php`` file, which takes care of autoloading for
> all the files in the Symfony Framework as well as the files mentioned...
I think names of the general form NpyArray_, etc, would be a good standard going forward.
Someone's name doesn't belong in a docstring.
Все ок, не сцы.
Parece que falta esta acción. No lo vamos a estar usando realmente así que yo sólo removería estas líneas.
My initial thought was that we'd need separate ones because the preprocessor is processing the URL before making the request to the external system whereas the post processor is processing the document from the response. They're not actually doing work on the same sort of thing... However, I suppose they could be combined together.. but it would increase complexity.
This style doesn't exist
setup-org function was actually added for one of the content-search-tests, later moved under fake_contents to avoid cyclic dependency.
It's only a minor thing, but you should use characters instead of Strings here for the slash. Otherwise the static code analysis tools on my machine will start getting nervous after merging. :)
Rethinking what I see here, it does not look very sensible. If I set the zoom like that, it will be set again at every draw operation (at least with the +1 currently in getMapZoomLevel). So it should rather be getMapController().setZoom()
Need to research a bit about this...
You can ignore my last comment: I was thinking it would be odd to have two kinds of executors, but in the end it's just a flag saying if we should stop the executor on shutdown or not.
Why is this a java class?

Unless strictly necessary (i.e. annotations), I would keep all source code as scala, to avoid potential issues with java <-> scala interoperability.

Besides, putting java classes unless totally necessary potentially opens the door for others to do the same.
I wanted this to be the general contract for a ConsistentHashFactory - the default impl does like you say, but a custom impl is not forced to do so.
This javadoc is meant to say the user can return whatever number of owners he wants from his own CHF impl.
The inconsistency with the image file has not been carried through to this change request. Does anyone know of a good reason why it might have had a different extension?
Everybody who calls `enable_wifi` will need this wait so I'm just going to leave it
12.04 doesn't have it. Should I look for it elsewhere?

----- Reply message -----
From: "Octavian Neamtu" <reply@reply.github.com>
To: "William J. Dawson" <wdawson@bowdoin.edu>
Subject: [nbites] Updates Linux Setup Script (#280)
Date: Thu, May 3, 2012 9:37 pm



> @@ -6,7 +6,7 @@ if [ $# -ne 1 ]; then
>  fi
>
>  PACKAGES="build-essential cmake git-core \
> -python2.6-dev emacs cmake-curses-gui ccache curl aptitude \
> +python2.7-dev emacs cmake-curses-gui ccache curl aptitude \

I think we still use python2.6

---
Reply to this email directly or view it on GitHub:
https://github.com/northern-bites/nbites/pull/280/files#r771939
Is there a way to add assertions to prove that the cmdlet is passing the correct payload to the channel?
Please cache the stream defs locally - lookup in pubsub as needed.
Ah, good point. As long as no section is EVER created, I guess we're fine.
Do we need two random numbers in the ID?
Missing space `){` + Double quotes -> single quotes
Just a minor thing: sometimes you are using a=b, sometimes a = b
Would be nicer to only have one version
I don't like this change (although I think it's the name "Administering" that bothers me the most, for example, "signals" is not about administration).  I think it was in the right place before, where we provide general information about writing programs for the system.   Are you thinking of that page as a tutorial page, and that's why you moved the other stuff?
I vehemently disagree!
Are you sure the method ``translate`` can be called on ``$translator`` (of type ``null|object<Zend\I18n\Translator\Translator>``)?
That's ok, in the next commit will be fixed. May the best way is to put it on the config file.
This should also look at the `:awards`, but also do the check the other way around:
~~~clojure
(every? (:awards book) awards)
~~~
you should require ``>=2.0.14`` as you use the constant without doing a ``defined`` check (which is fine IMO as we have 2 working releases in the 2.0 series already)
This block of functionality is duplicated 3 times. Extract to own method?
Hm, I even think that Django adds empty element automatically if you do not require choice-configured field?
This is better, closer to the correct one, but does not change translation based on the number of stands available ("1 prosto mesto", "5 prostih mest").
I would really love to see TODO comments starting with upper case letter.
Move `type` to the end of the tag.
Yeah this static image should be displayed via CSS.

Which fragment?
>why don't we do this in DrawTagBranch?
DrawTagBranch() opens DC before comparing ref types.
I tried to just put new code only in DrawTagBranch() at first, but later I found that the row has been made dirty, not compatible with CDRF_DODEFAULT.
If no ref should be drawn, we should return CDRF_DODEFAULT.
Not needed here, it will be normalized in the "central" point  - SetOrientation
yup much prefer that.
Shouldn't we add the role (is successful) to this one?
My bad. I copied the description from the official Django documentation and forgot to link 'How to deploy with WSGI' . I will make the changes and update the pull request.
Alternately should this be automatically triggered when it.test is explicitly specified?
> when the other libraries depending on Scala 2.10 will be added to libraryDependencies

Personally, I write following code if some libraries add to `libraryDependencies`

```scala
libraryDependencies <++= scalaVersion{ version =>
  if (version.startsWith("2.10"))
    Seq("org.specs2" %% "specs2" % "1.13" % "test" ,"foo" %% "bar" % "0.2")
  else
    Seq("org.specs2" %% "specs2" % "1.12.2" % "test" ,"foo" %% "bar" % "0.1")
}
```

There is not only `<+=` but also `<++=`. But I have **not** strong opinion on this.
Will you have here not the same issue that any state in the model is not persistent?
@oschaaf: I looked at refcounting it, and I think the amount of code to make atomics work right here isn't worth it.
I will replace FlightEconomy enum type by float 0-1, where 1 = hungry and 0 = economical, which you proposed elsewhere. This will solve both my problems and enable both slider and button ui solutions later.
I'll have to test fasd for bugs before I pull it and replace z.
That's wrong since it actually enables and configures the completion system. [zsh-completions](https://github.com/zsh-users/zsh-completions) is extra.
That is a good point :)

On 16/12/2012, at 12:24 PM, Henrik Hodne <notifications@github.com> wrote:

> In lib/travis/worker/shell/helpers.rb:
> 
> > @@ -132,7 +132,7 @@ def timeout(stage)
> >            if stage.is_a?(Numeric)
> >              stage
> >            else
> > -            config.timeouts[stage || :default]
> > +            config.timeouts[stage || :default] || config.timeouts[:default]
> Wouldn't config.timeouts[nil] return nil, since the nil stage doesn't exist?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Use relative namespace (Db\Queue)
Allow me to address that from a different angle. Currently we expect that the settings file is loaded before the user will modify the settings. Otherwise, the way the menu item links to the "vimmode" attribute in the model would not do anything. Same with the Preferences panel. Here in `hook` we have injected those menu items into their place in the prefs and menu, but before the user can even interact with them, the settings model is populated. At that time we determine whether VIm mode should be enabled.

Strictly speaking, we can disable the menu item and preference until "loadsettings" is received. There is the (however slight) probability that the settings file does not load before the user has a chance to go to View and select the menu item. So we can disable the menu and pref items initially, and then enable them when loadsettings is received.

Your question brings up a very valid point about maintaining consistency when it comes to extensions enabling or disabling functionality before the settings have loaded. I don't think many extensions employ that safeguard, so we should add a task to do an extension review looking for those weaknesses.
which pattern?
Kolmogorov doesn't use anything from this file.  Perhaps better to characterize this file as enabling a future implementation of an atmospheric model with multiple atmospheric layers.
This is an improvement - the previous docstring was wrong, it was coming from `iris.unit` instead!!
Each this.tr() must contain a complete sentence. Otherwise, there's no guarantee that combining translated versions of these fragments will make sense in the translation language.
pourquoi vous n'utilisez pas le code inline avec les ` ? c;est mieux que les guillemets ou l'italique
It is correct to remove `protected` since it behaves differently in Java and D.
well,

```javascript
var obj = new Number(5);
console.log(obj > -1/0 && obj < 1/0 && obj === +obj);
// ⇒ false
```
What does module and state mean? It should be very clear even for a novice what this is about.. This is to short.
Duplicate check for shouldWarn, you already proved it false in the outer if.
Maybe remove MONGO_SERVER too?
Record. Added a note to the docs.
Good point, never mind.
I ask, because the idea was to develop a seperate module, which is used by oxid, right?
Also, although I don't like using the checkpoint() method for this... I do like the idea of using the CtrlObj to do it. That way, the bandit.evaluate() *can* later call that same mechanism itself.
Why Inbox is not linked?
Remove unnecessary #connect comments
Nope. The lockdown computer in my old engineering will have no attached blast doors, that's all.
I like this line! Well done. That is how it should be. First take the available mysql and then take homebrew's.

To make it more robust, you could even use `"#{mysql.opt_prefix}/bin/mysql_config". The `opt_prefix` is stable, even if the mysql has been upgraded. But I think for the mysql_config this is not necessary.
go ahead and delete it if unused
Тут правильнее else if использовать
Разные слова в названии переменной должны разделяться заглавными буквами. Т.е. fReader, bReader.
Достаточно просто j + " " + numberWord.
Не делай так больше.
Given we've gone to the trouble of wrapping the entire test case invocation, why bother using the "tearDown" functionality at all? We could simplify the implementation by just cleaning up the particular features we injected for this test case right here - with fluid.testUtils.clearStaticEnv(testInfo.envFeatures)
We don't typically use the "one var per line" idiom in the Infusion code base, as it can be more difficult to debug.
```ruby
def persons
  @persons ||= Highrise::Person.all
end
```

потом работать уже с persons
This is where we should do something like:

```js
if (!toolAlreadyStarted) {
  // set iframe src and call build()
}
```
no background noise on linux.
Nit: s/can_not/cannot
retornam asked me to remove it. Is this a controversial issue? ;-)
This is not necessary a multi-label problem here (if I read the diff correctly).
So this should say (something like) "in a multi-class setting, the probabilities will sum to one. This is not necessarily the case for multi label problems."
If this is a "can't happen", shouldn't it be an `assert` rather than a `ValueError`?
@GaelVaroquaux  The test cases will cover 0log0 cases, as I am testing cases where nmi,v_measure is exactly zero in which the 0log0 cases can be covered as one nan will make the final answer become nan.

Comments are added.
No. you think I should include that? Gael was saying I shouldn't over-complicate this example
with too much detail.. however if you think it'd be useful, it can be done
no no no.
робиш окремий метод типу getQueryToFindCategory і якщо треба, то можеш юзати його потім в findByCategory (якщо метод findByCategory взагалі ще потрібен)
please be careful in diffs to not remove anything that is irrelevant to the pull request
BreadthFirstVisitor is included twice. Should be included once in .ih file.
I was hoping that other packages could also take advantage of it, but apparently not. Ok, I'm going to make it a deb-specific flag, then.
I'm not convinced we should be calculating that manually, but it looks good, maybe add a comment to use the supplied one if it ever becomes available.
Slightly confusing that it is called get() but doesn't link the results.
Gavin  wrote:
>I think it might be better to return false if numCommited() == 0 before you lock. @jakesmith what have you done generally?
Would it allow you to re-connect and try again?
Seems to me the activate option still exists, and so should still be mentioned (useful if default set to no-activate in ini file)
@ochameau @ZER0 those might be a good examples to be discussed with UX. Anyway I think this discussion better taken to a different place.
sound like these are hard deps, we are recommending them after all strongly
fyre.conv.load
Yes, I did this change, but I needed to add `var imageUrl = "{{ STATIC_URL }}images/schedule/";` in `vote.html` - is there any better way on doing it?
Can you remove those spaces? The code formatter should actually do that, there's a setting for it, "Right trim multi-line string literals"
It can be implemented like this in scene, construct and init in one step.
However, it is two step in other classes' static create function:  1. construct an object  2. init it.  The step 1 will call this.ctor().
Such as cc.Layer.create, and so on.

So, we should choose which one is better and make them the same. What do you think?
Well, I was thinking of also using it for the paypal modal, as currently it just displays a list of artists without any syntax, i.e.
"... You are purchasing artwork.name by artist1 artist2 artist3"
instead of
"... You are purchasing artwork.name by artist1, artist2 and artist3"

Is there possibly a padrino helper for that?
forces our loggin policy to all plugins.
Would prefer to have a consistent name, such as /etc/portage/package.unmask/engineyard_overrides so that we don't get a plethora of files when the versions get updated -- and only add the line if its not already there.
Might make sense to put `tail exprs` into a `let`, since it's used a couple times.
rename param to tablename
Is this a standard Java Environment variable? Where you using JAVA_HOME before?
Not sure what the thinking actually was, but a guess would be that a person can only have one birthday but multiple anniversaries. Hence the assumption of allowing only one birthday. Of course if someone for some reason syncs multiple birthdays for a contact, then this would not work and we probably can't corrupt data either.
thought experiment: what if we use QMultiHash instead, and return QList<SeasidePerson*>? then your UI could display a "and 4 others", or a PathView of avatars, or something cool involving unicorns?
In my opinion if we have to check types then we have smelly code. ;-)
Almost confusing, two lines please
In this instance it is needed to know what arch we are on because steam is only 32bit so we need the x86 folder if the platform is x64. Using %PROGRAMFILES% would result in the 64bit folder however it does appear that on at least win7 x64 there is an environment variable by the name of %ProgramFiles(X86)% which I am sure is not defined on x86 platforms. I will use its existence to determine the platform instead.
Maybe add comment about dtype; e.g. "Generator yielding pyramid layers as float images."
Indentation (or is this just the way GitHub displays the diff?)
I'm not sure of a better way to express it, but `Mu_pq` isn't really clear here. `M` or `mu` (personally, `mu` reads really different than `Mu`) would be preferable, and pq needs to explained.
Expand and reduce are imho the correct technical terms - at least during my research in this topic. See http://www.google.de/search?q=image+pyramid+expand+reduce.
PEP8: line length (maybe just remove "efficient")
@nerdsRob did you read this line?
Double quotes... and this fits on one line, no?
Do we need to validate `width`, `height`, or any other arguments?
That is why we have TODOs. In my case, I spend most of my time looking at the code from my IDE and I don't spend that much time looking at Github.
Explicitly setting the height of the label doesn't work. Setting the height in a style attribute in the tag inside the html property's string is a workaround.
Is there anything wrong here.?
same re documentation (rule 15, etc.)
This check seems unnecessary.
To make below code more readable only. Shall we use `window.escape` for every appearance instead?
Sounds good, I'll have that ready in the latest patch.
TODO: Replace this with 'log.verbose' so it is only print when users run db-migrate with the verbose option.
nicely worded, imho: "must remain pending"
Because it was a program in the samples by the document comment, so it did not seem to be caught in unittest.
In that case, import is necessary for L49, too.
Don't ask me, I just made it use `getTempPath`.
I'm not sure I can... Doing that requires one of the *parameters* to also be qualified as `inout`, but here, the return type is dependent on the *function's* attributes. Don't think I qualify a function as inout...?
Yeah. I fixed the code but not the comment.
causes bbox to leak into global scope
Currently, this select just seems to float under all of the fields and in the middle of the portlet (see: http://cl.ly/0I232y453z0t3N3l1Q37). This should be grouped properly to display in a way that makes sense.
Unnecessary format-change
How about instead of `each`ing, trigger `reload-drug` right after you bind the listener?
it is used now
In the original (EN) it was "Username or email address:", so the bulgarian translation word by word is "user name / E-mail:".
Should it be just username?
because these are regular expressions .. f.e. ``de|fr|it``
Maybe also one additional +1 for spaces because HTML output (github, documentations, wikis, textareas, etc) do not show tabs correctly or people will maybe have problems with copy+pasting.

Kind regards.
blah blah parens
Should description be required here? Currently it isn't required via the other case-add UIs. Making it not required is as simple as replacing `new_case["description"]` with `new_case.get("description", "")`
Yes it is, we can slowly reduce thread.d's comments to what's necessary for understanding.
MINOR: There be a sneaky 't' trying to get in on the act!
This is a pretty big breaking change - too big for a point release? Do we need an option?

If not, I see you have a note in the WIki, but I think it needs to be clearer how/when it will break and what the correction is (to get the status code from the entiy).
interesting perspectives. I think it will be awesome if we can get a complete list of properties that are supported and/not supported, for now and for future, so that we can make an informed decision on the best design of the SDK, , issue #47 filed
I'm developing a plugin for fplot, which is a plugin for jquery. My code is thus essentially a plugin for jquery, so I mostly follow this guidelines:

http://coding.smashingmagazine.com/2011/10/11/essential-jquery-plugin-patterns/

I agree with your point on object attributes and local variables and will use under_scores for that. I've already fixed most of them.
Falta por traducir este párrafo
Directly through GitHub web interface you can edit the file again (or any other file)  switching to the PR branch (`patch-2`) and then choose the file and finally press `Edit`

https://github.com/Swader/zf2-documentation/edit/patch-2/docs/languages/en/user-guide/skeleton-application.rst
Haha, right you are - blatant colour blindness from me!

Thanks!
This will break the console entirely when someone uses the SonataAdminBundle without the SensioGeneratorBundle (which is likely to be the case as the SE only activates the generator bundle in the dev and test environment, meaning you are breaking the prod console)
why not simply getting the session from the request ?
if you fix CS, can you add ``array $config`` ?
this should point to the master only, I think you need to change the notification url to point to the master
It's `Screenshots:`, plural. If your theme changes states, you should add multiple screenshots to display them.
Il peut dégager ce FIXME non ?
Here you have `( )` when using `del`, upper you did not have. Decide.
Not really keen on this `get_response_headers` change - it complicates the API, and it's non-obvious what implications the serializer.object vs object behavior has.