labofsahil/github-event-dataset-2012 huggingface dataset:
That's what I thought first too. I'm still using the old Turies based kernel in Swedish Snow. CPU Spy works on RLS4b but doesn't on RLS5.

Only difference between those two kernels is these three commits:
https://github.com/KonstaT/zte-turies-35/commit/19b300a12d99fbeeb8397a3769b571d718158a6e
https://github.com/KonstaT/zte-turies-35/commit/e863d5db398222042394f055a0cf04aa9e70da32
https://github.com/KonstaT/zte-turies-35/commit/a9ce0aefdda600fed4269e5d1f4b6774d0fb50cf
This causes executable to crash on my target (u8800/msm7x30)
Here's the kernel trace: http://pastebin.com/TC8AT5wL
crash in angry birds, also crashes at 595... will fix this up a bit later
Thanks! Merged and sent to Brian :) https://github.com/brianchandotcom/liferay-portal/pull/3858
Haha, I don't think anybody will need useful commit messages for docs most of the time...
Roger, let's at least put a comment in stating why we're catching the generic Exception.
Can I just say thank you, I have been trying to fix this bug for 2 days!
评论挺不错的
create transition controller instance when application start
This is dope, or this sucks bad.
Where's html5-buffer.php?
How can you switch to a specific branch, using the deps file?
That works too. So long as access is consistent.
https://github.com/SthephanShinkufag/Dollchan-Extension-Tools/issues/38
we lost another commit!
Glad to see we don't need this anymore...
These chown/chmod calls are *incredibly* useful for FOSS acceptance testing; otherwise the tests need to be very meticulous about permissioning all files and directories in a way that allows them to be visible to the master (which runs as the "puppet" user, while the framework runs as "root").
just tried it and timeout works, but there is not output <-> this strace inside timeout always returns 'Timeout'.
To fix this the strace process needs to be started and then you have to p.gets its output and append it to some buffer, then return the buffer.
crud.  should be 'exists'
I don't know if this is right but I'm committing anyway. We'll see.
I'm still not convinced that the server is the problem. It could just be the client sending up the incorrect login cookie or something as well. I think @drapp is going to look at this tomorrow.
Já q entraram no mérito das rotas... frequencias, aulas e turmas não tem o pq terem acesso direto como deixaram... Frisando q apenas refatorei o já tinham criado sem necessidade aparente e imediata...
Would it be possible to use `std::vector<double>` for `data`?
```c++
data = new std::vector<double>(nonzero);
```
ah, yes, you have to register the events in a static constructor. Look at Button.cs:

    static Button ()
    {
        MapEvent (ButtonEvent.Clicked, typeof(Button), "OnClicked");
    }

With MapEvent you bind the event with the virtual method.
The event has to be implemented like this:

		public event EventHandler Clicked {
			add {
				BackendHost.OnBeforeEventAdd (ButtonEvent.Clicked, clicked);
				clicked += value;
			}
			remove {
				clicked -= value;
				BackendHost.OnAfterEventRemove (ButtonEvent.Clicked, clicked);
			}
		}
Maybe do something like
```Python
def __unicode__(self):
    return "%s%s" % (self.name, " (Inactive)" if not self.is_active else "")
```?
Do any of these need initalizers or validation rules?
Minor rename: based on the conventions the log object should be called `log`.
It seems that cusp and PETSc use some different names for preconditioners (e.g. jacobi/diagonal) - I imagine that there will need to be a mapping from the names we are using to the CUSP names (or vice-versa - I guess we haven't decided to standardise on a particular library's names yet).
WMU.js depends on YUI. These two files can not be loaded in parallel.
Can we improve on the helpfulness of this error message?
Why an Array?
I wouldn't check for nulls here
You're right, I'll fix
Najs.
This is the ObjectContent parsing.  Generally, the @obj attribute of the ObjectContent will be an Array of Chunks and regular Strings.  The chunks are replaced with other objects on render!.
ungrab() missing in the up algo
There are 8 spaces before the description instead of 4 (or perhaps a tab character?).
I think there is no test for this class. Is that on a purpose?
Just for the record, facet titles can be changed via config options in the form "search.facets.%s.title". I don't actually like it that much, so it's good to have an extension point for it.
Yeah I'd love to come up with a better implementation but I wasn't able to so far either :-/
Perhaps it should be an enum. The idea here is that there are 3 cares: case 1: both are null. In this case, you move on. case 2: one is null and the other is not. In this case, you return either 1 or -1. case 3: both are not null, and you need to compare them. a return of 2 means "move on." a return 0 means "compare the actual values."
Sorry for late response. I have just  now noticed your question.
Because this is Spring Webflow and I would expect that this case would be handled with use of it. In simplest solution, canceling a form flow and pressing "go back one page" browser button may result in "Page has expired." page. By the way, I have no idea why someone would like to click "go back" browser button after canceling a form.
Oops. {n} in the format or the print is wrong. Fixme.
Before reporting that it's been found, you should check that this is the case. Else, you can end up with a message like this :

```
        Found CYCLOPTS Include Dir: CYCLOPTS_INCLUDE_DIR-NOTFOUND
        Found CYCLOPTS Libraries: CYCLOPTS_LIBRARY-NOTFOUND
```

In places where you send such a message, I'd recommend saying it thusly:

```
# find cyclopts and link to it
FIND_PACKAGE( CYCLOPTS REQUIRED )
SET(CYCLUS_INCLUDE_DIR ${CYCLUS_INCLUDE_DIR} ${CYCLOPTS_INCLUDE_DIR})
IF(CYCLOPTS_INCLUDE_DIR_FOUND)
  MESSAGE("\tFound CYCLOPTS Include Dir: ${CYCLOPTS_INCLUDE_DIR}")
ELSE(CYCLOPTS_INCLUDE_DIR_FOUND)
  MESSAGE("\tCYCLOPTS Include Dir NOT FOUND")
ENDIF(CYCLOPTS_INCLUDE_DIR_FOUND)
```
Also, this messaging should probably happen in the Find_Cyclopts.cmake file rather than in the main CMakeLists file.
Implementing a "showAtPosition" option would be relatively trivial using the same logic provided by the "showAtEvent" code. The reason I went with showAtEvent was because:

1. As mbessey noted, it's easier to simply pass through an inEvent object. To properly send things through to showAtPosition, I would need to grab the X/Y coordinates from the event object, which necessitates checking for which ones are supported in a given browser.
2. It doesn't have to be this way, but at least to me "showAtPosition" sounds like it will position the Popup exactly at those coordinates, whether or not this causes it to overflow the viewport. Underlying this assumption for me was the Enyo 1.0 `openAt` function which allowed users to specify top/left/bottom/right coordinates, and had an explicit second parameter for opting into automatic repositioning.
3. I only needed to personally use showAtEvent, and since I'm not responsible for making Enyo 2 a broadly-useful framework saw no reason to write in extra methods just on the off chance other people would find them useful. :-)

However, the underlying logic that drives showAtEvent is generic enough that you could easily implement showAtPosition to serve as the underlying general-purpose call. For instance:

```javascript
showAtEvent: function(inEvent, inOffset) {
	// Calculate our ideal target based on the event position and offset
	var p = {
		left: inEvent.centerX || inEvent.clientX || inEvent.pageX,
		top: inEvent.centerY || inEvent.clientY || inEvent.pageY
	};
	if (inOffset) {
		p.left += inOffset.left || 0;
		p.top += inOffset.top || 0;
	}
	this.showAtPosition(p);
},

showAtPosition: function(inPosition) {
	// Save our target position for later processing
	this.targetPosition = inPosition;
	
	// Show the dialog
	this.show();
}
```

Of course, that would still have it repositioning automatically to ensure the Popup is in the viewport (repositioning logic is living in `updatePosition` in my code), but frankly I'm not sure my initial assumptions about that method (or the Enyo 1 design) make all that much practical sense, anyway.
I'll adjust the patch to do so, if there are no other objections to pulling it in.
Let me look again, this was copy/paste from Zikula and I had to use an extra abstract there.
Invalid function name it is http://php.net/empty not is_empty
fair enough, but it's going away one day
Why a getter/setter instead of `process._needImmediateCallback()`? (Like `process._needTickCallback()`)
i see! yes, no problem, thanks for the hint!
i think it can be useful to unload the dll for scenarios which switch big patches, to completely reset all states. problem is, that load/unload is different on each platform, which means including the code would tie it to windows as it needs kernel32.dll to do it. i find the method not so dangerous, the comment states the use case and if you call it anyways, well, your problem...
Please add...

<relativePath>../pom.xml</relativePath>

... in order to make the directory structure explicit.
+1, nebo dát do komentáře neon definici, ze které se to "generuje"
Didn't we just FORCECAST `op2_array` to match the dtype of `op1_array`? I guess this is still good defensive style, but acknowledging it in the comment would be good to remind people what's going on.
Same goes here. I was using parentheses like this, but I stopped using it when I realized it was not needed.
По стайлгайду надо обрамлять всё фигурными скобками
Will name_cont match a sku?
I think you can just use `gsub('_confirmation', '')` instead.
How about this:

``` ruby
if super
  !@@compiled_delegators.include?(method) || @klass.respond_to?(method, include_private)
else
  Array.method_defined?(method) ||
    @klass.respond_to?(method, include_private) ||
    arel.respond_to?(method, include_private)
end
```

This avoids the need for any locking at all (which will be more efficient in multi-threaded situations) and is easier to read.

I *think*, doing it this way, we don't need a mutex at all - because we add to the `@@compiled_delegators` set *before* defining the method, so it will never be the case that `super` is true where `@@compiled_delegators.include?(method)` is false, but should in fact be true.

It could be the case that `super` is false, but then another thread defines the method (so a second call to `super` would now be true). However, in that case we'll just hit the `@klass.respond_to?(method, include_private)` in the `else`, which will return the right answer anyway.

I think the above is correct but wouldn't mind someone double-checking my logic here... (perhaps @tenderlove or @josevalim?)
```ruby
link_to "Calculate", "/fib/15", remote: true, data: { fib: 15 }
```
We need to test if `get "/dummy"` will redirect to `"/not_cars"`
We can get rid of this comment. The `# check for multiline regexp` comment below as well.
Just curious: why is this different than `DateTime.civil(1253,7,6,20,4,0).strftime('%s').to_f` ?

'%s' is supposed to return seconds since the epoch, but it's results seem different than yours:

```
irb(main):003:0> DateTime.civil(1253,7,6,20,4,0).strftime('%s')
=> "-22609511760"
irb(main):004:0> DateTime.civil(1253,7,6,20,4,0).strftime('%s').to_f
=> -22609511760.0
irb(main):005:0>
```
We should recurse inside `Function` nodes as well. Not sure about `TypeTree`, but it might match  more than we think.
Dude, if you send me an ASCII scene I will hold up 2.10.0 JUST FOR THAT!


In all seriousness, I can use snowman if it's more "Scala".   If only we there was a unicode unicorn....
Although the move away from calling length is an improvement, constructs like foo(0)(0) are bad practice.  The way to write this which provides visual assurance as to what it is doing and that it is doing it correctly is:

    val implCtxParam = implParamss match {
      case (p :: _) :: _ => p
      case _             => null
    }
This takes care of closing the file descriptor after the write process is done.
> Actually (sorry for not thinking this through earlier): why do composed morphisms have names at all? I see why it can be useful to name morphisms in a diagram (also composed ones, presumably), but that's not really the point. The kinds of names we attach to both morphisms and objects are "internal" - they are used *purely* to distinguish them, and are not necessarily related to user-visible names.

Yes, agreed.

> I would think that composed morphisms are identified by their components, and as such don't need names. In fact, I think composed and named morphisms should live in separate classes!

That's an unexpected point of view, for me :-) And you do raise important points.  I'll try to muse a bit here, and I'll then sleep it over.

Initially, I thought that what you suggested sounded like removing the name from `Morphism` and deriving a class `NamedMorphism` from `Morphism`.  However, in this case `NamedMorphism` inherits the components from `Morphism`.  If we do if the other way round (derive `Morphism` from `NamedMorphism`), then `Morphism` will have a name, which defeats the whole point.  This means that there should be a third class, `MorphismBase`, which, uhm, has only a domain and a codomain.  `CompositeMorphism` derives from `MorphismBase`  and can have components, while `NamedMorphism` derives from `MorphismBase` and adds a name.  Then, hm, we derive `IdentityMorphism` from `MorphismBase`(?), because names don't really make much sense for identities, and identities cannot be composite.

Does this go along the lines you were thinking of?

If yes, I can't say I am really enthusiastic, because, to factor out the name of a morphism, we add two classes.  Also, there is essentially no way of treating a collection of morphisms uniformly, since some morphisms don't have names, others don't have components; one will always have to check the type.  Not that I say it's critical or even necessary; just throwing about ideas.

Generally, I like it when the class model follows the real-world model with great granularity; but in this case I'm afraid whether this isn't going to be an overkill.

Perhaps we could move this discussion to the mailing list so that more people can pronounce their opinion.
```
Examples
========

```

should appear above the examples (not forgetting the blank line).
see #1638 for the new kbins (plural, not kbin). It handles all permutations of bin and inter-bin commutativity (e.g. if the order of bins matters but the order within the bins doesn't matter, the ordered flag would be 10 -- (1 = bin order matters, 0 = item order in bins doesn't matter).
Take a look at the sine expand code.  The bug that I think you are talking about was fixed.
`Permutation` objects can be in cycle form or array form; computations with permutations are done in array form,
so the property `array_form` produces the `array_form` attribute if not there; if it is known that the `Permutation`
objects have already `_array_form`, it is faster to call directly that.
It is far from clear to me (from this description) what the use of such objects is.
Math is the default inline mode, so that
```
:math:`C(z)`
```
can simply be
```
`C(z)`
```
and so on.
DlgComponents do not have elements.
Yep, probably something left from April or so
This must be L-GPLv3
Useful method ;-)
you shouldn't need to add super here unless the setPlace is overriddent
Huh? Equals sign?
It was never strictly needed, just nicer to read - still holds
Is this commented out function still required?
Actually, on second reading, ignore my original comment as it is handled at the end of this function.
captialization.
the indentation of this block doesn't make sense. it can be 3 rather than 6 spaces indented. 

where should have a colon after it.
No. This function is about whether a rendering has been scheduled, which is valid whether or not the document should be rendered in the offline queue.
I suspect you want to also check if those exist too or you will get an undefined thrown. e.g. 

``var dnt = navigator.doNotTrack || navigator.msDoNotTrack;

if (!dnt || (dnt && (dnt != 'yes' || dnt != '1'))``
s/settungs/settings/
Why was this reverted?
unread -> read.
But then again we decided the unique name of a style is defined by its folder name only, so `phpbb/subsilver2` doesn't make sense.
For events we will have to pick one spelling and stick with it.
Would it not make more sense to have the language entry in common rather than ucp as a new validation method has been added to a global acp function?
This comment adds no value, please take it and similar ones out.
Uh, fixed this (shameless bump)
On second thought, this function should probably be renamed as well. It does not only handle passworded forums. So maybe `phpbb_download_check_forum_auth`
Yeah, you're right... something went wrong here...
Fixed.
It would be a complete sentence with "Checks" at the beginning of the sentence, which is a verb. ;)
Those should probably all be off.
<3 _register/unregister
let's do timestamp of startup... probably more unique.
fixed in 1127ddd5366e0579219b8182b85c9a4caceb6443
Imi cere \\ inainte de ( sau ). Altfel imi da eroare
BTW - the same here.
Yes, I should have been more clear. It won’t ever be removed on non-touch devices, effectively leaking the `<audio>` element.
эм.. ты про транзакции? так если не писать, то в админке не будет видна актуальная информация?
Need a sapce before brace here
address the TODO of validation on screener vitals submission.
These steps from startup occur before the login, so we cannot use the info from LoginScreen.
Did you check the daemon user and use it to POST?? Does it work?
This is just because this function is pretty much a copy of ``iris.analysis.cartography.area_weights``, modified for a new purpose. I thought there would still be some logic required here, since ``lat_dim`` can be either a tuple with one element (the dimension number) or an empty tuple (if the latitude coordinate is scalar), but I guess passing an empty tuple to ``iris.util.broadcast_weights`` would work just as well...
We should also check the ```zlib.crc32''' of the returned weights, to make sure no-one mistakenly breaks it in the future.
Remove the dot after ``inside the test``.
I'm not sure if it's important, but I'll mention it just in case (@nouiz / @jaberg do you know better than me?): should ``__eq__`` be implemented?
Maybe change ``is`` into ``==``? I don't think it can be guaranteed that they are the same objects, can it?
Maybe there is a way to fix it by validating the list of non-coordinating sites against the known sites and known failed sites?
extractCodePoint and compareAt could be private:
The comment above says do the repair with the connection removed but the remove follows the repair?
Spurious spaces.
s/repriar/repair
You can't terminate a reserved task, as it hasn't been executed yet.

It adds the id of the task to the list of revoked tasks, this is then checked again when the worker is about to execute the task (moves from reserved -> active).  If you only search the reserved requests then the terminate functionality would be useless (it wouldn't have any process to kill
Looks like you forgot to remove this file :-)
Yup, I'd forgotten we had that updated import path.
@gibson042 Good catch - thanks.
We have added a textbook reference for the textbook we used.
What do you think? Maybe we can ask Florian for some suggestions, since he did the design.
dtelog is a macro which is only present in debug build. In release build, we never enable this macro.

We can also replace WARNING with NOTICE.
After investigation, we think "construct_array" cannot handle arrays with null values. Therefore, we directly use construct_md_array here.
From CROSS JOIN to UNNEST, we gained a speed up of up to 100 times. But, overall, we can only see speed up of less than 10 times. 

After this change, the bottleneck is not in the queries of 'UNNEST'. So materializing its result is not very valuable.
This makes the dev_bundle like the way it is on Linux. This also allows us to not change the last lines in ./meteor.
Not sure about that. Just wanted to make them aware that there's both options for collections that are shared.
"isFifoFile", instead of "fifo".
I like that suggestion. Also, the first for loop can be done with `pykka.get_all()`.
Given that there's at most a 1:1 relationship between Simple and SimpleEmail and Simple already has a created field, I don't think we need this one, too.
The usual command formulation includes the absolute path: `#{bin}/itkTestDriver --no-process`
However, in the case of a formula that has a HEAD or a devel, the test will only work if the user
does it like `brew test -v --HEAD insighttoolkit` which pretty much nobody thinks to do.  So you can
leave it, or you can use `linked_keg` I think to get the path of what's really linked.  For some reason,
the admins don't like it when I use `#{HOMEBREW_PREFIX}/bin` No big deal, though, just sayin'....
Perfect Dirk--works for me.
Можно и ёлочки сделать, да :) Надо только проверить, что в TeX'е всё будет собираться.
Damn right this crap gets deleted from our repo :)
No worries, I'll keep an eye out for the change and merge appropriately.
`from scrapy.conf import settings` is deprecated  API, use `self.settings` within the command methods,  that attribute is assigned by the `scrapy.cmdline` mechanics.
Indentation also looks off between these two.
Can you move this to the beginning of the test, or to a @Before method?
Shouldn't this be [1.3,)
I get your point :) This is a Google Translate problem though. Both "yet" and "still" translate to "todavía" or "aún", but they all mean the same. It sounds ok in spanish, not slow at all ;)

If you're not satisfied, we could change it for "por ahora" which would result in "Brackets doesn't work in browsers for now"
Here, the first shortcut added wins.  But for shortcuts added above via the arg, or later on via the listeners, the _last_ one added wins.  I'm not sure which is better, but we should pick one & be consistent.
Parsing can't be easier. :-) But getting the json is a good idea. At least as an excercise. :-) will do!
I would not use a dictionary to hide parameters.
Main disavantages:  static code analyzer, smart editors, help and documentation tools do not work well with this approach.

If you just want to allow the user to input these parameters in random order, you could assign them a default value and then assert on their value, so the user can input these parameters as keyword parameter.
I just commented out the style.css call in case we wanted to put it back later for some reason but we should not need it anymore.
“denominated”
You are correct. But can you just turn on those things without support for it in the code? Have you coded that?
OK. Modify 4spaces from tabs.
You flip between .ogv only and .webm only.  We should make sure our videos will work in the browsers we are supposed to support for 0.5.x.
space before <code>if</code>
It's got less to do with page resize and more to do with the position/dimensions of the element changing. Gecko supports DOMAttrModified, but it's pretty weak and less effective here.

If there's something better, we should use it. I just made some effort to compartmentalize this functionality so that when we find a better solution, this is the only code we'll have to change.
This whole block needs better indentation.
No? What's this code do? https://github.com/mozilla/butter/blob/master/src/core/popcorn-wrapper.js#L204
Do we really need to have a zoom textbox? Also, different maps have different min and max zoom levels, so it's difficult to specify min/max values.
I think you can remove the check for `?` at the end of the search string
Please group the `if` statements into one and use `||`. Can you leave a comment what kind of annotations get passed these `if` statements?
Okay, I'll just make that change then. No need to bother with a pull request. :) Thanks!
This is needed by our deployment script.
The current script is here: https://github.com/deian/hails-deploy
but I will move it to scslab
As far as I know that check is unnecessary. Even if Python wasn't compiled with OpenSSL with enabled SNI, `SSLError.wrap_socket` takes the `server_hostname` argument and ignores it if SNI isn't supported.
Fixed in 	56a6f08
A comment describing the job and an apache header.
More indentation confusion?
It won't start, I'll add a upgrade script to update the katello.yml from the old one to a new one.
Do we have to support 1.9.1? Very few gems/resources support 1.9.1.
This comment is wrong, and I can't tell if this implementation makes sense because I don't fully understand the now-quite-dead calling code and am not sure that it, as dead code, is worth diving into. Unless you have very high confidence that this is exactly what's called for, I would suggest that you simply assert(false) here.
At this point document.location contains chrome://browser/content/shell.xul :/

Do you think we can land this as it. It fixes #1083 too ;)
Looking at the code that handles the `t[['a', 'b', 'c']]` case should make it clear.  Basically it thinks that it is getting a "slice" which could be an actual slice object or an np fancy index slice.  So it makes a new table with the same column definitions and then applies the "slice" to the `ndarray` data object.  That explains the misordering because an `ndarray` can also accept a list of column names, but the new Table gets defined with the original column names.

```python

    def _new_from_slice(self, slice_):
        """Create a new table as a referenced slice from self."""

        table = Table()
        table.meta = deepcopy(self.meta)
        cols = self.columns.values()
        names = [col.name for col in cols]
        data = self._data[slice_]

        self._update_table_from_cols(table, data, cols, names)

        return table
```

I think it could be a little more clever and if `_slice` is not an actual `slice` object, then try `_slice = np.asarray(_slice)`.  That will use numpy to efficiently determine the types of everything in `_slice` and fail if they are not homogeneous.  It also allows detecting at that point if `_slice` consists of all strings in which case the tuple path of __getitem__ could be taken.  I think this strategy would be reasonably efficient since `np.asarray` will just pass back anything this is already an ndarray, and I bet numpy does this anyway on a list input to ndarray.__getItem__.

I'll put all this into an enhancement issue for later.
Minor point, but I wonder if it would be helpful to say something like `Error code {} in SOFA's iauTaitt`.  I wouldn't necessarily know (or care) what iauTaitt is, but if I know it's from the underlying SOFA library that may help me track down what the error code is.
我同意有一个get()提供最原始的数据。不过真的不能滥用。

POST/GET/PUT/DELETE应该是request method，封装在req层就好了。
之前很多时候很难测试某些东西，只能是靠去抓url来测试就是各个层都在取url里的东西。
this belongs somewhere else, either in views.py or in the controllers folder if that makes more sense
typo: argument
Not needed for the header, I think? Maybe changes with IPv6...
If a log entry is created before this point, then you cannot use Configure.  So to be safe I used engine() instead.
This should be changed to just `return $File->write($result);` This was a copy-paste from another method, so it could be fixed in other places, too.
Doesn't success still need to be set to false here? It defaults to true at the top of the loop.
What about using ``OpenLayers.Function.False``? Done in an other pull request I think. Conflict in sight?
We could use this in the BIDPOM sign in new user tests too.
indeed. not sure about what is best or not, but wanted to follow your example, but left this out waiting for the license update and then forgot about it. updating right now.

i don't use the package annotation usually, as with namespaced php code this is rather redundant imho. but i will copy your header for consistency, including the package.
A simpler way to strip off `.git` is to do this:

```
name <- gsub("\\.git$", "", name)
```

Example cases:

```
gsub("\\.git$", "", "foo.git")  # should change this
# [1] foo

gsub("\\.git$", "", "foogit")  # shouldn't change
# [1] "foogit"

gsub("\\.git$", "", "foo.gitbar")  # shouldn't change
# [1] "foo.gitbar"
```
逻辑不正确。

waiter.get() 返回时，得到的是第一个发生事件的 watcher （即第一个调用 waiter.switch() 的 greenlet）对应的 obj ，不一定是第一个 watcher 。
Since this is now public, the docstring should explain what `format_dict` is meant to contain.
gained, dropped, ...of *a* `.py` extension. has been renamed.
True, I alway forgot this one...
I think there is some drift between the comments and the current function signature (filename is not a current param...). I know this did not happen in this particular change, but maybe we should we clean this up?
pypi has version 0.1.3, so I figured you might have a non-committed version.

On Sun, Jul 15, 2012 at 9:01 AM, dave mankoff <
reply@reply.github.com
> wrote:

> > @@ -18,7 +18,7 @@
> >
> >  import setuptools
> >
> > -version = "0.1.2"
> > +version = "0.1.4"
>
> why 0.1.4 instead of 0.1.3
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mankyd/formpump/pull/1/files#r1165253
>
Yeah, that was an accidental deletion, will put that extra line back in.
Ooops... forgot this in the last commit... fixing now!
"can" instead of "an", "its" instead of "it's".
403 seems like an odd thing to return on ValueError? When would this happen?
Based on our discussion, we should change this to be something like `principal_state`.
これどうしてsymbolにしたんでしょ。
`__git_ps1` is preferrable over the `git branch` trick, as it caches values and gets updated on future git versions.
Lead by pushing back? The API supports our complex uses cases. Do we really need 'em?
can also return null
You assume to URL to be used in a HTML page. But that must now be the case... It could also be used as semantic identifiers or several other uses. I'm just saying an empty URL means nothing and is also wrong as the current page is probably not the same as the route that you tried to generate. 
So all in all, an empty URL doesn't solve the real issue! What you are trying to achieve is probably best solved with a twig extension that catches such errors and then you can return whatever you seem to fit (like an empty URL).
The change in the Route generator you are introducing can be used for generating routes without considering the requirements. This way it should return the URL with the invalid parameters. Because that is not possible to achieve at all at the moment and the only use case I see.
@stof  you mean without namespace?
It should throw an exception implementing the interface of the component (you can create an exception extending InvalidArgumentException to implement the marker interface).
Once we're done with escape sequences, we only deal with single characters from this point forward.
I'm talking about this Request class. According to the phpdoc
> /**
     * Clones the current request.
     *
     * Note that the session is not cloned as duplicated requests
     * are most of the time sub-requests of the main one.
     */
    public function __clone()
It isn't. The "do" and "wo" is covered by the second expression "[MDdw]o". But I noticed, that the "d|dddd" should be "d|dddd?".
あと、Gemfile の更新は別コミットにするのが良いと思います
Regardless of who wrote it (probably me), it seems incomplete and should be improved.
> Can you clarify the concern during deploy?

I've seen issues in the past where ENV variables are not available in config files during pre-processing such as `rake assets:precompile`. I'm not certain whether ENV variables are available at the time Heroku bundles.
+1 I thought we were white-listing the patterns that generated tags,
otherwise this will lead to a data explosion.

On Wed, Sep 19, 2012 at 10:43 AM, Matt Perpick <notifications@github.com>wrote:

> In dogstream/haproxy.py:
>
> > +
> > +HAPROXY_RE = re.compile("^.*haproxy\[(?P<pid>\d+)\]: (?P<client_ip>[\d.]+):(?P<client_port>\d+) \[(?P<accept_date>[^]]+)\] (?P<frontend_name>\S+) (?P<backend_name>\S+)/(?P<server_name>\S+) (?P<tq>-?\d+)/(?P<tw>-?\d+)/(?P<tc>-?\d+)/(?P<tr>-?\d+)/(?P<tt>-?\d+) (?P<status_code>\d{3}) (?P<bytes_read>\d+) . . .... (?P<actconn>\d+)/(?P<feconn>\d+)/(?P<beconn>\d+)/(?P<srvconn>\d+)/(?P<retries>\d+) (?P<srv_queue>\d+)/(?P<backend_queue>\d+).*\"(?P<cmd>\w+) (?P<url>\S+) HTTP/.\..\"$")
> > +
> > +class HAProxyLogParser(object):
> > +    def __init__(self, config):
> > +        self._logger = logging.getLogger('haproxy-logparser')
> > +        self._state = {}
> > +
> > +        # Maps url regex to one or more tags
> > +        # { url_regex: ("tag1", "tag2"), ...}
> > +        patterns = config.get('url_tags', {})
> > +        self._tags = {}
> > +        try:
> > +            for p, tags in patterns.items():
> > +                # compile the regex and turn the tag or tags into a list of tags
> > +                self._tags[re.compile(p)] = ["url:%s" % t.strip() for t in tags.split(",")]
>
> I think we're going to have to be careful with this. Will every single new
> query parameter create a new metric? Do people want this? We need something
> like this, but we need to figure out the right way to opt-in to
> things/patterns that users care about.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/DataDog/dd-agent/pull/193/files#r1640294>.
>
>
SYSTEM didn't do anything, at least not on my Mac.
comment is misleading - this code will execute on Windows with BOOST_FILESYSTEM_VERSION != 3
Ich habe alle flush()-Aufrufe aus den hier benutzten Services entfernt und nur diesen einen hinzugefuegt. Dadurch werden nicht staendig Queries an die DB geschickt, sondern wirklich nur dieses eine mal und das hochoptimiert. Das ist der entscheidende Punkt, wodurch es jetzt so schnell ist. Also gut ueberlegen, ob du wirklich ein Flush machen musst, oder ob das auch ausserhalb geht. Denn vergessen darst du es natuerlich auch nicht. ;-)
Nevermind... I see where this comes from, but I still don't understand why... I ask again on that issue.
again, PEP8 please. `` = ``
just inject path and don't use default value. No __DIR__ constant usage either
Dependency versions needs to be managed via the pom.xml at the root of the source tree. AFAICT the purpose of this is to change the version for a few arquillian artifacts? If so, the change needs to be made across the entire appserver.
This is better done in JSFResourceDefinition itself -- override the registerOperations() method.
Wasn't a byte saver, but to access it inside closures with different context. Refactored in 7df04b3
The whole section misses one indent
Here you should create the `li` and then append to the right `ul`
I would be tempted to write something like this myself:
You have about four counts of this in this function.

````js
function fireMediadbEvent() {
  var args = Array.slice.call(arguments);
  var type = args.shift();

  if (mediadb[type]) {
    mediadb[type].apply(mediadb, args)
  }
}
````
suggestions always is defined or am I wrong?
Ok, i buy it:
https://github.com/basiclines/gaia/commit/15beb45a9110f2a62fc2fac3d2653ee6fb1369cf
As we were talking yesterday, It's only a "light" refactor for getting a better visual appearance, but it needs a lot of changes for accomplish our new layouts&visuals.
actually if you must, do

      if (DEBUG)
        console.log('===== wifiManager enabled');

and set `var DEBUG = false;` at the very top.
Why .toString for a String?
Accessing a private property on UssdManager (`_popup`) does not feel good.
I think we should add a method on `UssdManager.handleIncomingUssd`, bonus we already have a `this._origin` over there :)

We can even do 
```
window.navigator.mozSetMessageHandler('ussd-received', UssdManager.handleIncomingUssd);
```
My assumption is as follows:

- bytes can be UTF-16 representation of non-BMP chars, which are surrogate pairs ( 2*16-bit = 1 Unicode code point)
- Doing `String.fromCharCode(charcode);` will result the surrogate pairs being inserted into Javascript strings as the same surrogate pairs
- Everything works

If they don't, don't worry, it's an edge case :-/
vetsinou se pouziva pro zelvu `heading`
typo addFindOnByPk -> AddFindOneByPk
Same question as [line 14](https://github.com/redu/help-center/pull/6/files#r2120592). Can't find any HTML where this selector `.help-central-header .title span` would target. Is it part of the admin area?
personally, I don't really think any version is better or worse parseable. Chose this notation as the other notation was commented on in https://github.com/soundcloud/visor/pull/73#discussion_r1585576 -- so I wanted to stay consistent with the current code
Skipping. Copy/paste code.
fixed in updated patchset
I prefer to change other adapters :)
Do we really want to to have 'displayname' as a default value? In my eyes the default value (illegal configuration) should be the one we are using default inside our configuration.

Another thing is that diplayname can be empty, which means that your code displays no name at all if the option is selected. Which I consider as being a bug. If our optional field is empty, we should really show something else.
How is this view being restricted to only superusers? I would expect to see a [user_passes_test](https://docs.djangoproject.com/en/1.4/topics/auth/#django.contrib.auth.decorators.user_passes_test) decorator on this function restricting it to superuser only.
Yes, if I recall correctly this is python 2.5+ valid syntax only nevertheless.
I think we should check both of them, including return value and output information. thanks.
I use its `assert_called_once` method later, so this is about as messy as any other way of expressing this would be.
Because the ruleset itself might not contain such info when we're in the "write css stage", having been generated by a single less rule. Therefore if such info is missing we use the one contained in the first rule.

See below.
Factory::createDownloadManager might help
huhu, that's true! ^^
I would replace these two lines with asm volatile ("jmp 0");
I'm just being anal really but would it be good if non-JS users got a nicer URL for these pages (which is just an alias for `core-navigation`)? We have http://www.guardian.co.uk/most-viewed at the moment...
one small thing: please add logging noting that this will break linking to servers with the option disabled, and note that it will default to being enabled in a future major release (and add a TODO comment to do exactly that)
Ah yes. Since it's conditional, it should probably always be a temporary redirect then. I'd just get rid of the 301 option :)
@jglick making progress on the new EP: https://github.com/ndeloof/jenkins/tree/maven-settings 
Just some more tests and clean ups ...
maybe make :validate => [ a list of valid units ]?
can you skip the whitespace changes in this pull request?
Right. My syslog server wasn't complaining about this. I've just committed some changes to solve this timestamp format issue.

Thanks!
For the cases mentioned by @Mossop, I will add at least one example to be clear.
Also, I would say that this 18 weeks is the minimum period. I mean, a deprecated module could stay longer in the code base before fully removed, but the developers shouldn't rely on that. Not sure if it's worthy to mention.
I don't understand your comment sorry. I do whatever we were doing before just use copy of `@packaging` instead of original.
Could you explain the reason of this change? It seems unnecessary by me.
ah missed that one..
This will put all KPI into 10 minute chunks, associating them to the previous 10 minute interval.

r+
Looks good! Pedantry -- shouldn't this be using same-line curly braces to match the rest of this file?
This logic is taken verbatim from below.
Flex Box is not yet supported by IE or Opera (http://caniuse.com/#feat=flexbox), but the display still looks reasonable.
Uh, this seems wrong. If the non-perftest contenttype would ever come before the perftest one in `cls.CONTENT_TYPES`, this would wipe out the value of `cron_batch`. The ordering of `cls.CONTENT_TYPES` is not something this method should be relying on like that. I'd suggest taking out this conditional, and instead below in the `SQLDataSource.create` call, using something like `cron_batch=cron_batch if ct == "perftest" else None`, so you aren't actually modifying the `cron_batch` var for all future runs through the loop.
Since we're already seeking unconditionally, would it work to just open with mode 'a', which *will* create the file if it doesn't exist?
You need to consider the fact, that for this one example, the actual cell height is returned by UITableView's delegate.
I think you can just delete your message, right?
Where do we draw the line on how many variables to support? To me, this is getting out of control a bit. We just need super lightweight and flexible defaults rather than overrides like this.
This is just a demo - however, always prefer System.nanoTime() for interval measurement.
I don't remember removing the camelcase method... o_0
Tried this out locally on my Mac, but ran into issues with the php-cs-fixer arguments and the return code (always 0 even when failures). Here are the changes I made for it to work on my system:

```php
    exec("php-cs-fixer fix " . escapeshellarg($fileName) . " -v --dry-run --level=psr2", $output, $return);
    if ($return != 0 || $output != "") {
```

Using version: PHP CS Fixer version 0.2 by Fabien Potencier

Nice script and glad it is in PHP now :)
Wouldn't re-throw the same exception. Instead, would wrap it into another exception. Otherwise, it would not be possible to get the original stack trace
I don't like the default value: if the parameter is optional, you should use null. And if the value is null, you set a default value. I don't think that we need to define a default priority (we don't have a default priority in our priority filter).
To reduce duplication and make it more readable, I'd recommend:
```php
if (null === $filterOrPriority) {
    $filterOrPriority = new PriorityFilter(Logger::WARN);
} elseif (!$filterOrPriority instanceof FilterInterface) {
    $filterOrPriority = new PriorityFilter($filterOrPriority);
}
$this->addFilter($filterOrPriority);
```
Let's at least implement EventsCapableInterface, as it only defines this method.
Please add space after comma :)
We probably don't?
All should be ok with them
is it required step?
Can you send this in a separate review?
This should support the second argument of `setReadPreference` as well where you can specify preferences on server tags:

```php
$m->setReadPreference(Mongo::RP_NEAREST, array(
    array('dc' => 'east'),
));
`` `
Maybe I'm missing something, but this looks like a hack to me.

How are other MySQL clients handling this? What does libmysql do?
Don't you want to do query.mkString("") here to?
Also add a test case for single element Term[T] query against Solr.
If i provide depth=0 as initial argument, then this code will run as if i had set depth=-1 (might be an edge case, since running with depth=0 seems rather silly?)
Put the import before the from X import Y.
docstring, where art thou?
Should be: toolkit = {'name': 'goalf', 'version': '1.1.0-no-OFED'}, i.e., spaces after , and after :
OTOH, using something that regular code would use can pollute or screw up the namespace, since list comprehensions vars leak into the surrounding namespace. I would prefer it like this and enforce never to use single letter names in other code outside list comprehensions.
`id="1"`? Others have names.
I still think some fallbacks are a good idea. Thoughts?
Look at `#body-home` (line 357) right above the comments. `margin-bottom` is 4 spaces in. `color` in line 254 under `.persona-button` is 2 spaces in.
Iterates through each binding and stream definition and attaches the correct stream/data product output.  Allows for multiple outputs per transform.
I think github's formatting is borked because this has a space in [the diff](https://github.com/seattlerb/minitest/pull/178.diff).
I would remove this test-case, it's already covered in the last one
begin を省略しよう.

http://doc.ruby-lang.org/ja/1.9.3/doc/spec=2fcontrol.html#begin

> クラス／メソッドの定義/クラス定義、クラス／メソッドの定義/モジュール定義、クラス／メソッドの定義/メソッド定義 などの定義文では、それぞれ begin なしで rescue, ensure 節を定義でき、これにより例外を処理することが できます。
We lose nothing, because otherwise we just didn't test this case (rbx+therubyracer) at all.
I agree.  The comment can be removed.
@ohadlevy, there are two methods called for after_commit, not just one.
In most cases we should keep the title as it appears in the publication. In this case, that means the localized title. Note that the various language Wikipedias are really quite different; editorial policies and much more can vary between the languages.
This is reintroduced from the previous RDF translator. I'm not sure why I removed it.
I think you meant `trade = null;`
(optional style) you could write `<var id="PROBLEM_DATA">{` and `}</var>` to save a couple of lines.
Yeah, you're right. Removing them now.
These two annotations are a little worrisome, but also wondering if they're needed at all?
Please add "var" instruction:

var newInputs = oNew..............
Check the log for php errors, maybe a warning or notices is throwed in this line, if is necessary change for 2 "if" statements
Multi-line it looks fine, but nothing we should bother for longer,.. Sorry for beeing that nitpicking
This will make use of autoload mechanism. Much more efficient than the plain old `include_once()` calls
it is different for classes and methods, not for control structures (they also go on the same line for PSR-2 in this case)
One other concern is what happens if this directory cannot be created.
If you renamed the `badge_detail` partial to `badge`, then you could just do:

``` ruby
<%= render @badges %>
```

...which is a bit neater, I think
why do these tests no longer expect to login via browserid?
Hey, one more thing, sorry, you can change this for a simpler way, if you select the chars you want to delete, deletePreviousChar will delete the whole selection, which saves a "while" loop http://doc.qt.nokia.com/4.7-snapshot/qtextcursor.html#deletePreviousChar
This would be the last issue as far as I can see and it will be merged.
And as a bonus, altough this is not really important, allows_less_intentation should be allows_unindent and __retreat_to_keywords should be called __unindent_keywords.
Cheers, and thank you for your collaboration
this should be 2, right?
You'll want more than a console.log if the login has not been successful.
I think a little bit. Previously, all validation for all actions (create, delete, get, etc.) were in a single test. I asked for them to be split out in 1 validation test per action, underneath the main test for that action.
It also would be nice to have only one function that knows what the actual command is to run a specific file. That will make it easier for somebody to use a different format or runner (like tslime).
should we have MONUMENT_API_DEV and MONUMENT_API_LIVE - it would be great to invent a mechanism where we can easily switch between
or just leave as is on the basic that it will get deployed soon and we might forget to change it back?

// TODO comment would help here to prevent forgetfulness
Please remove comments like this, they quickly become out of date as things change and confuse everyone.  Everyone knows an assertion at the beginning of a test is a consistency check
(11:15:48 AM) Mark Gius: @Vish: if I put a raise there it will re-raise the second Unauthorized, I want it to re-raise the original Unathorized
(11:16:04 AM) Mark Gius: If you think it's more appropriate to re-raise the second Unauthorized we can do that instead
(11:16:24 AM) Mark Gius: original logic seemed to want to pass back the first Unauthorized
Working fine in VS11, just concerned that it depends on something additional to NuGet dependencies.
you are probably right :) Fixed.
Как я уже сказал, опять же, вы итак изменили свой массив, и тупо его перезаписываете.
@mvmn повторю ещё разок: ТЗ говорит, что передаваемый параметр у метода mutate - процент, следовательно, в методе его нужно обрабатывать, как процент.
да, не заметил
Вообще, чтобы не пользоваться своим циклом, можно воспользоваться методом, который есть у объектов типа NSArray: `componentsJoinedByString:(NSString *)`, результат этого метода - строка, в которой будут все элементы массива, между которыми будет то, что вы укажете в передаваемом параметре. Например, чтобы сформировать строку, в которой все элементы будут просто друг за другом, достаточно будет вызвать:

`return [DNA componentsJoinedByString:@""];`
Why would you want that event in user land?