labofsahil/github-event-dataset-2012 huggingface dataset:
All of the stuff in this file could be redistributed to lib/webmaker_metrics or app.js. As humph pointed out, we're going to get bad data if the daily collection metrics were run on two webheads like our current setup.
might as well have the message list the allowed commands.
Hmm maybe not clear what I meant here. How about this:

> then you may find it more effective to write just the code you need, using your own class based or functional views.

And drop the thing about mixins, it's probably not needed here given the advanced topic page re Mixins.
AFAIS your change does the same as the previous code, is there any specific reason to change this?
It should be clearer that this state is not like other states. I would really hate to see people start adding to it when it provides only a very small shim. I think it should be moved elsewhere to avoid this confusion.
Good point. I was hoping to avoid another lock here but looks like it's not practical. :(
Why `raw != null && StringUtils.isEmpty( raw )`?

Why not `StringUtils.isBlank( raw )` only?
These changes are all wrong - they remove my new code.  $total is not defined
The original description is not valid, since templates don't subscribe the systems.
This doesn't seem right. The publish command has been deprecated for a while and all it does now is print a warning.
if you wanted to be clever you could support any number of args thrown in after name, but maybe that doesn't buy much.
Just pushed update with a comment detailing that section =)
Glad you fixed it
`<iframe id="keyboard"></iframe>`

Use keyboard_manager.js to set `src` for the keyboard.
and |false| by default ;)
I think I see why this isn't working.  I'll look into it.
It would be nice to document the "head of list is preferred" semantic at module-level doc.
Yeah I only wrote it because I needed it in the video#show view. Removing a
bookmark requires a *destroy* on the Listing object. Otherwise I'd have to
do current_user.bookmarks.find_by_video_id(video). Which is fine, I just
thought the view code should be cleaner.

We also do need to check if the object exists, and for that I call *
current_user.bookmark_for(video).exists?* . I thought having just these two
functions was a good middle ground.

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Sun, Dec 2, 2012 at 2:15 PM, Luke Steensen <notifications@github.com>wrote:

> In app/models/user.rb:
>
> > @@ -34,5 +41,15 @@ def self.from_auth(auth)
> >      end
> >    end
> >
> > +  def bookmarks
> > +    #returns a user's bookmark List
> > +    lists.where(name: "Bookmarks").first
> > +  end
> > +
> > +  def bookmark_for (video)
> > +    #returns a user's bookmark Listing for a video (if it exists)
> > +    bookmarks.listings.find_by_video_id(video)
> > +  end
>
> Ok but why do we need a function returning a Listing object? Do you have a
> use case in mind for this? If it's just to check for whether or not one
> exists, you should be using the exists? call.
> http://apidock.com/rails/ActiveRecord/Base/exists%3F/class
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/22/files#r2287991>.
>
>
I'm fine with removing that later as long as you / sipa keep track of that.
That whole block of commands in the pro-file looks like Vodoo to me anyway :-D.
If i don't add this line, git complains. How do you manage without git wanting this directory added or ignored?

Sent from my Nokia phone
-----Original Message-----
From: Philip Kaufmann
Sent:  17/05/2012 16:25:10
Subject:  Re: [bitcoin] Parallel block download (#1326)

> @@ -20,3 +20,4 @@ qrc_*.cpp
>  *.pro.user
>  #mac specific
>  .DS_Store
> +build/

That should not be here I guess.

---
Reply to this email directly or view it on GitHub:
https://github.com/bitcoin/bitcoin/pull/1326/files#r838976
Indeed. It is not used anymore.
mmm I don't think so.

if given string is like "::something" then "!== false" is a true condition... but given string is a very bad error because does not contain any class name.

I need to enter the if tree only if "::" is upper than one.
Mocha (at least newer versions) complains about the old format.
No need for yoda conditions here.
Yoda conditions are used to avoid wrong assignments. 

While

```php
$var = 'value'
```
is valid PHP code,

```php
function() = 'value';
```

is a compiler error
make sure you don't leave this in
I do not think that single_step and page_step need to be redefined.
As far as I can tell, yeah. Works both with the sample data and with the live one. I didn't, however, crossref everything in the full dump.
Yeah thanks -- `get`, `post` and `handler` shouldn't be here.
Eventueel sequence laten bepalen in insertFeaturedArticle
We should consider this api a bit more carefully, so that we don't assume there has to be a URL for these guys: when clients capture data from remote engines, they will have the data in-memory.
spelling: 

* connexion/connection
* implicitely/implicitly
* availlable/available
There are many ES5 compat libs as along as we don't do anything crazy thats a fallback option. I thought that Object.keys was there in IE8 though...
@franzliedke I'm not sure the existence of a getter method is enough. The issue I was hoping to resolve is within the Twig template library where it evaluates all loops by extrapolating the following:

    {% foreach user.posts as post %}

into the following PHP:

    <?php
    if (isset($user->posts) && !empty($user->posts)) { 
        foreach ($user->posts as $post) {
    ...

In order for that to work I'm pretty sure that the model's `__isset` actually needs to check if there's data behind the relationship, not just that it exists?
What's changed in this file exactly?
Yeah, the time spent doing mkdir is probably negligible. I'll weight that stage to 0%. :wink:
You'll want a `giterr_clear()` here, and probably check that the return code is `GIT_ENOTFOUND`, and not any others.
Alway with you it cannot be done.
Marshall Culpepper wrote:
> Nit: the two `.` here will match any character (not just the literal `.`), you can fix that by escaping them:
>
> `MacOSX([0-9]+\.[0-9]+)\.sdk`

I unfortunately can't fix it right now; the computer I have that has all 
my code (and the hard drive for my laptop) is at home and I'm on vacation.

-- 
Eric
I suggest adding a sibling to `c2` to check that `c3.previous` returns this sibling and not `c2`.
Cause it was that way when I took the code but you're right. Fixed.
`list_editable` might be handy for changing multiple `display_order`'s at once. Thoughts?
I added the if mode != None because it was skipping over if mode was explicitly set to 0.
This can be "simplified" with ``.setdefault()``. i.e.:

    def merge_results(metrics_qs, label):
        for metric in metrics_qs:
            results_dict.setdefault(metric.end, {})[label] = metric.value
Naming reflects the diff between "for all time" vs "current". This isn't the number of retries for all time, just currently queued. 

On 29 Dec 2012, at 07:04, Brandon Hilkert <notifications@github.com> wrote:

> In lib/sidekiq/web.rb:
> 
> > @@ -214,7 +214,13 @@ def number_with_delimiter(number)
> >      get '/dashboard/stats' do
> >        stats = Sidekiq::Stats.new
> >        content_type :json
> > -      Sidekiq.dump_json({ processed: stats.processed, failed: stats.failed })
> > +      Sidekiq.dump_json({
> > +        processed: stats.processed,
> > +        failed: stats.failed,
> > +        enqueued: stats.enqueued,
> > +        scheduled: Sidekiq::ScheduledSet.new.size,
> Ah...From a user's standpoint, I can see that it might be confusing to access stats for Retries and Scheduled from a different API object. However, I'm not convinced that retry_size is great b/c it begs the question, why isn't the method for stats processed => processed_size. The naming just seems inconsistent.
> 
> If we wanted to include this, I would think the following might be clearer:
> 
> stats.scheduled
> stats.retries
> What do you think?
> 
> —
> Reply to this email directly or view it on GitHub.
>
In case somebody changes the default source type of the app, you should include the ptype here.
A source with this id may be there already - either because somebody else added the same layer from the same source already, or because someone gave their source an id that matches this one. For simplification, I think you can ignore the latter case, but before creating a new source you should maybe reuse an existing one if there is one already.
In MathGeoLib float distance = d.LengthSq();
as it was mentioned, the name is misleading. I would name it _allocatedFonts
IMO it must also call this method if strict parameters is true. Because you cannot assume that the default behavior of a generator implementing LenientInterface is `true`.
`canceled` should be `cancelled`.
Shouldn't getters be checked first as they should be the preferred way to access the propery ?
This makes https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Tests/Fixtures/CustomXmlFileLoader.php useless and also makes several tests useless that test that the loader also validates the structure itself without scheme validation. This needs to be fixed.
Shouldn't this be ``self`` ? Otherwise, Embedding a DumperPrefixCollection inside an instance of a child class would not call the method.
And using ``static`` is only useful when you consider inheritance.
ah ok, i will revert it.
Use space between the comparison
typo: also
@fabpot?
add a code comment stating how `~~` works with numbers and `NaN`
Should be cmd_update_or_install?
please indent on same level as first
暂时没有比较好的解决办法，该种情况下符合用户逻辑，忽略此问题。
Do you want test for tags here as well?
Unfortunately that is my configuration, which I suppose I can fix locally just to "clean" this test data up - however, we don't match on hostname anymore.
I'm not sure it is clear enough that this is a nested dictionary.
similarly here and below. Can we check that we get the expected warning message (looking for a substring that is unique enough)?
python 2.4 urlparse does not like custom url schemes... needed to do that this way
why not: event.presentations.create(...) ?
"Should return role dependencies when roles with relationships are given"
I would call this Domain(Controller)Resolver since it loads the domain resource bundles. The old HostRootDescriptions has become HostResolver in my local branch
On 11/16/2012 11:36 AM, Jaikiran wrote:
> In web/src/main/java/org/jboss/as/web/WebValveService.java:
>
>> +    private Valve valve;
>> +
>> +    private PathManager.Callback.Handle callbackHandle;
>> +
>> +    public WebValveService(String name, String classname, String module) {
>> +        this.classname = classname;
>> +        this.module = module;
>> +    }
>> +
>> +    /** {@inheritDoc} */
>> +    public synchronized void start(StartContext context) throws StartException {
>> +        Valve valve = null;
>> +        try {
>> +            if (module == null) {
>> +                String filename = pathManagerInjector.getValue().resolveRelativePathEntry(filePath, fileRelativeTo);
>> +                valve = WebValve.createValve(filename, classname, this.getClass().getClassLoader());
>
> There can be issues here. The absence of a module name will not
> necessarily mean that the file path has been specified since the model
> management isn't doing any such validation while creating this service.

The validation would be a bit tricky. Won't it be better to remove the 
file logic completely?
I believe this should be outside the foreach loop. The reconnectPolicy.wait(...) as well.

If there are multiple discovery options, that implies to me that there is an expectation that one may be no good. For example, several static discovery options to support a primary master HC and 1 or more backup HCs that would be promoted to master following failure of the primary. So I see no reason to wait before trying the 2nd. The wait happens when they all fail.
Lets merge this first, so we can do other transformers properly aka so there won't be any more failed tests when doing rebasing as it happened with web & jmx.
And then improve tests to actually perform both tests as part of transformer testing.
Fails on OSX
It'd be easier if these followed the NumPy convention used elsewhere in the library so that when we eventually rig up [numpydoc](http://pypi.python.org/pypi/numpydoc) to generate API documentation it will render nicely.
Actually, maybe more appropriate would be a new file here, https://github.com/modilabs/formhub/tree/master/odk_logger/tests
just fyi, you could put this canPlayType() test in the metadata parser if you want.  If the parser returns null, then mediadb will ignore the file and never even report it to your app.  Also, if you pass a third options object to the MediaDB() constructor, you can specify a list of mime types you are interested in, and it will only return files with types on that list.  So if there are video formats you know you're never going to be able to play, you can exclude them at that level.

Obviously this doesn't block landing this patch.  Just wanted to mention it.
nit: dead code is dead
In fact, it was due to using a transition on a width to 0 what was affecting the performance. Using translateX the result is much better :)
nit: clon -> clone
wasn't aware of that options- changed.
This has been implemented!
Excat that @vingtetun said. Check `zindex.css`!
just passing, remove this if it's not used :)
uppssss failed!! sorry
OK, I will use a similar approach on this in a following up.
@albertopq totally right, It came from 2nd modification, thanks for spoting.
Do we need to enable debugging by default?
If music was already playing, when this activity started, do you have to do anything to restore it now?
That's col 82 and generates `gjslint` error
OK, use addEventListener on 'timeupdate' of audio tag behaviors like other elements.
nit: the id is probably not what you're were trying.
i know sad isn't it
this gets set the first time the plugin reads in ANY flags. Since this happens USUALLY well before anything is set, it's safe to have it here. May throw a nullpointer if the plugin tries to set a flag before reading any flags in(shouldn't happen. seriously.)
`languages` is a set at this point so you're coercing a set in to a set
>do you even test what you send me?

Of course.
Is there a test that minitest runs in this block (like assert found_pycql == true)?
After you make it works, please make sure that 'MultiTouchTest' in 'TestCpp' can also work. Thanks.
party missing after third.
Is it $package->getPrettyVersion() used for 'firendly display only' ?

Lock files somehow should identify package its lock. I thought $package->getName() and $package->getVersion() gives exact package Id. Than locker would be able to find that package back.
`'OK' === trim($output)`
Why are you filling reg_storage with 0xba?  Do you not need to store the registers?
Shouldn't  this read:

@(FontSwicth.isSwitchedOn) {  var showFonts = true; } else { var showFonts = false; }
Yeah, cracking. I was going to suggest a while back we consider dumping it all together in favour of direct native - but there seemed to be some nice tie-ins with bonzo, and as we'd likely end up wrapping *something*, this is small enough that it's probably that. Nice change.
Yes it is a timeout. I had been off on another project for the past couple of weeks but am back to Suricata now and am working on incorporating your comments into my code.

Matt Keeler


On Oct 10, 2012, at 10:10 AM, Victor Julien <notifications@github.com> wrote:

> In src/source-napatech-3gd.c:
> 
> > +	ntv3->slot = s->slot_next;
> > +
> > +	while (!(suricata_ctl_flags & (SURICATA_STOP | SURICATA_KILL))) {
> > +		/* make sure we have at least one packet in the packet pool, to prevent
> > +		 * us from alloc'ing packets at line rate */
> > +		do {
> > +			packet_q_len = PacketPoolSize();
> > +			if (unlikely(packet_q_len == 0)) {
> > +				PacketPoolWait();
> > +			}
> > +		} while (packet_q_len == 0);
> > +
> > +		/*
> > +		 * Napatech 3GD returns packets 1 at a time
> > +		 */
> > +		status = NT_NetRxGet(ntv3->rx_stream, &packet_buffer, 1000);
> is 1000 a timeout?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 


--------------------------------------------------------------------
The information contained herein is for the exclusive use of the original recipient.  This information is granted for limited distribution within the recipient's organization for planning purposes only.  Further dissemination, whether private or public, is prohibited and may be covered under a non-disclosure agreement.
`test_generate_ipynb_fname` does not appear to be used anywhere right now. I assume this is just a placeholder for when rst2ipynb doesn't write just to stdout.
I think that the  fixes to Jaccess may have helped with this.
input.clone does work and is a bit faster when spinning up alot of threads for an input as it doesn't have to go through the config_init process each time. If this causes future issues I have another way to do it, its just a bit more hacky.

I could also implement clone in the threadable input base, or even in the base input.

Thoughts?
Some scripts in the wild are unpacking xpi files and are expecting to find this manifest file.
  https://github.com/mozilla/amo-validator
I wouldn't be surprised if these guys are reading it:
  https://bugzilla.mozilla.org/show_bug.cgi?id=730776#c0
Flightdeck team are most likely playing with it.
There is a chance to break stuff in the wild although it doesn't add a big value to rename this file.
We're just trying to be consistent on using same quote style with in the file. This were only inconsistencies so I just changed them as I was doing changes to this file.
@Mossop I have the same limitation when it comes to names!
`documentType` may be an option. `window` sounds weird to me as there is no windows. I don't know for you but the word window is only associated to top level window for me. And singular as it looks like we are always using singular? (contentScript, contentScriptFile, ...)
@Gozala @wbamberg your thoughts?
We should check isPseudo first, otherwise require(@chrome) is going to be considered as a builtin.
could you please use `prefixURI` instead.
No other functions in this module does this check – they just fails if we pass something is not an array-like object. I will keep it consistent – so just remove this check or add to the others. Plus, if `elements` is not defined we can assume safely that is a `return false`.
The thing that throws here is URL(spec) as it may not be a valid url.
I believe these errors will be logged if no handler is provided, so this should be unnecessary.
Let me rephrase it with an example. If I do `clipboard.set("data:buggy-uri", "image")`, I could receive this meaningfull URIError exception instead of a random exception in following code. I think that this code is going to throw `Unable to decode data given in a valid image.`.

It's expected to ignore the exception when the data type isn't specified, but I don't think it is valuable to ignore it when we explicitely pass "image".
Good point. Between static resources and wsapi requests, I wasn't sure if there were other requests that browserid handled. But if they're enumerable, a whitelist makes more sense, yeah. +1 static file serving process for now.
This is fine. I'm surprised we didn't have something like this in the code already:

    if (window.console && console.log ) console.log(msg);
let's improve this comment.  it's ambiguous and could be a merge blocker.
s/YouVendor/YourVendor
Would be interesting to add a less contrived test of this functionality, but I believe that we discussed that and there were implementation challenges related to rspec, so I wouldn't consider that a blocker to merging this.
This needs to be in an after action: http://rubyspec.org/style_guide/
One more time: `` :file:`{$SERVER}/sagecell/` ``
What's up with this?  It shouldn't be in the middleware (unless you're running webrick?)
why remove these other ones?
Strange way to break a line.  I'd break it before the 'implements'
@escortkeel Can you clarify the pull conventions you are referring to?  Again, I can't seem to find anything clear on how to format import statements.

The current classes seem quite a bit disorganized on wether they do or do not as a convention.  I did a quick check to see and I quickly ran across the following examples of empty lines separating base packages (I simply stopped looking after I found more than just a few examples, this is not a comprehensive list):
https://github.com/Bukkit/CraftBukkit/blob/master/src/main/java/org/bukkit/craftbukkit/util/StructureGrowDelegate.java#L5
https://github.com/Bukkit/CraftBukkit/blob/master/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java#L14
https://github.com/Bukkit/CraftBukkit/blob/master/src/main/java/org/bukkit/craftbukkit/scheduler/CraftTask.java#L4
https://github.com/Bukkit/CraftBukkit/blob/master/src/main/java/org/bukkit/craftbukkit/scheduler/CraftThreadManager.java#L5
https://github.com/Bukkit/CraftBukkit/blob/master/src/main/java/org/bukkit/craftbukkit/potion/CraftPotionBrewer.java#L7

However, like I said it seems to go both ways pretty equally.  Do you have some additional insight here or are you are you just making an assumption based on your personal preference?
Add prompt actually takes a javascript object for the properties, not actual XML.

Thus, it should be passing in:
```javascript
properties = {
    'property' = [
        {
            'key': 0,
            'label': 'Read a book'
        },
        {
            'key': 1,
            'label': 'Watched TV'
        }
    ]
}
```
That's weird... I didn't delete it or use the git shell or anything, so I don't know what happened. What do you want me to do?

By the way, note that there is some stuff at lines 802 and 816.
make this a readme.md file
could you please remove the space after `=`?
it should be private to be consistent
is this the thing to do? or should i call some map-something?
i think this is what you're looking for? http://api.rubyonrails.org/classes/ActionView/Helpers/TextHelper.html#method-i-pluralize
Ok, So let's wait your new test before merging
since a2140aab78f6e302816f1bdde25e998df660ca4a, it's now possible to pass the needed parameters to view
should go to the same line as the function name.
Constants in capitals
And then? I'm not familiar with the rest of the code, but will the execution then stop here, or will you get other errors as execution continues? You should use the sniper approach (execute until first fatal error. headshot.)
Should this private method expect to receive values in `orderedFunctions` that don't have a corresponding value in `transformProperties`?  If not, please see if you can remove this null check.  I prefer to minimize null checks, particularly for private methods where there is more control over the parameters that get passed in.
can just do `surfData.colors = new Uint8Array(256*3)`
Why return 400? I haven't noticed us doing this anywhere else.
This indent was correct, it lined up inside the opening `(` on the previous line.
why didn't you use * before self?
this is also for the methods in this file which don't have this.
I think you also need to add this new file in the root makefile install target..
Why did you have to change this to the more verbose `typeof translations === "undefined"`?  That existing simple check should work.

However, if you really need to be this explicit to check for `undefined`, I'd recommend having this file require underscore, then you could just do this: `_.isUndefined(translations)`.
Good point!  I checked with #ovirt, we're safe to require an HTTPS URL, so I'll do this as field validation in another PR.
+1 
not sure if  it matters, but I would use controller_name instead
are you using Net:: directly? why not rest_client?
Break this out into a snippet of its own so that it becomes somehow independent of the page. Either as an include or as a jinja helper function.
It is a quick workaround for the inability to pass variables to the finish callback.
Why the comment?
Nah, "object" should be fine; all objects are of StdClass anyway. If PhpDocumentor complains, we'll change it.
May be able to drop pending some of the questions around whether or not we need keypair serialized.
this need special authorization ?

but maybe we can check the api params should be better than 2 call to google which can be useless.
配列をオブジェクトに変換します。`[key, value]`のペアとなる1つのリスト、もしくはkeysのリストとvaluesのリスト、どちらかを引数として渡してください。
С тебя граф из трех вершин, где твой алгоритм будет не работать.
В классической Дейкстре
unique_ptr
ну и не map пожалуйста
This line is essential for configuration -- this is where the developer user of the library would configure it.
Liking the new name.
What is the advantage of pulling these variables out? Does it actually go any faster?

Convince me with benchmarks.
Ok, not a big change at all.
Please self-close `<br>` element so it is like `<br />` but preferably do not use them at all
Does this need to be here if it is in the base template?
TISK
Of course, I misread your second comment.

`@param {Content[]} callback.contentObj Retrieved Content objects` is definitely superior.
Oh, JavaScript. Good catch! Fixed.
Can you add a TODO that this should be removed once the admin UI is in place ?
If the user didn't have access, we probably shouldn't have have read and parsed the data. We should do the permission check as soon as possible.
Looking at the companion object, there it seem to be a number of steps needed for correctly instantiating this class. Therefore, to prevent incorrect initialization, you could make the constructor ``private``, i.e.,

```scala
class ScalaDebugTarget private(...) ... 
```
they were copy-pasted :)
Also, for this chunk of code in particular, I need to iterate the drops from the block anyway. I've used ParseItemNotation to clean up the code a little, but other than that, I see no way to refactor further, unless I start adding things to Static.
@jferris Refactored in a525f1b
this guard fixes [TORQUE-845]
Yep I know, I was just asking ... to be more consistant :)
I don't think this is needed. 
A build script that transform the CSV to a native array, would be better.
`==` -> `===` , add a changelog entry and it's all good!
This bit of code used to be up in the driver() call, but was moved down here in #353 to support loading driver libraries with library(). With this change, that check to include the driver base classes needed to move a little deeper into _ci_load_class() for the cases when we find an extension without the subdirectory for a driver lib. In short, this code has always been in Loader, it's just been relocated.

I know the style guide says OR, but I swear I've been seeing trending the other direction. I had come to assume that was a convention that had been reversed. If OR is still the true standard, OR it shall be, and yes - the explicit comparison will be better.
You don't need to.... you did the credit incorrectly.
На сколько я знаю, в случаях с наездами заказчика хорошо помогает ТЗ 

в нашем "ТЗ" речь идет о количестве изменений ячейки и о количестве измененных ячеек 
все это реализовано
К тому же новое **случайное** значением в ячейке может совпадать со старым значением, это ни как не отменяет ее случайность
"Обратите внимание, что Рахим явно сделал замечание по этому поводу. "
Смотрю комментарии https://github.com/Hexlet/osx-project-1/pull/8 , как то не вижу такого замечания *пожимаю плечами*
Я не увидел принципиальной разницы в замене символа с примером 17, если честно :) Вариант с копией клевый, да.
А генерацию случайных индексов можно сделать лучше, чем здесь, если не перемешивать весь массив, а просто брать случайный элемент из него и после использования удалять (видел в одной из проверяемых работ).
This doesn't deadlock if both the subscribable and the waiting are on the same thread?
@chrox The problem is not with the saving but with the loading of the value of `self.reflow_mode_enable`. Have a look at how `show_links_enable` is loaded in `UniReader:loadSettings()` and you can define `PDFReader:loadSpecialSettings()` which does the same for `self.reflow_mode_enable`. Remember to do the `tmp ~= nil` check or it won't work (because of boolean nature of `reflow_mode_enable`). E.g. you can't do the shorter version of the code as is done with `self.rcountmax`.
Clarification: this line has nothing to do with my current pull request. It is about my task concerning redirections for editing reusable entities. Since it does not affect of break anything right now, it can safely be merged anyway. My next pull request will include tests about this.
So the arg should be better called:  'attach_rejected' or 'keep_rejected', 'mix_proportion_rejected'... or so
ok, its back in
Is anything calling this outside this module?
Think this should be `s/grunt-barkeep/grunt-s3/`, no? I realize `grunt-barkeep` bundles `grunt-s3`, but these docs should probably not assume someone is using `grunt-barkeep`.
This seems to work fine with a single backtick here, https://github.com/symfony/symfony-docs/blob/master/components/serializer.rst
Maybe `域` is better than `章节`?
Oh, never mind.
You also need a test for the reverse, i.e if drug is set and concept is null
nit: Can we maintain the prior formatting here?
Remove or use, commented out code is just liability
en fait, il serait presque préférable que le selecteur soit inscrit directement dans la classe record générée, dans une méthode getSelector(). Donc modifier jDaoGenerator, aux environs des lignes 120-130.
I agree with gwoo
El link debería decir `GitHub` en lugar de `Hit Hub`. El texto debería decir `salida del Sprint 3` en lugar de `salida del Sprint 2`.
The description is weird. Tokens are much more than place holders.
Note that when I included status_query in pm I created a module scilifelab.bcbio.status in which I put the status_query function. I should have removed it from this script then and imported so there is one function to reference.
I think you meant Rake :)
11 should be a string here, no?
Cast ssttid parameter to int
I think my original submission of that (https://github.com/basho/riak-php-client/pull/17) was the very first of the thick clients to support secondary indices.  At least it was when I started writing that code.  I would recommend putting @deprecated on that other method and renaming for consistency with other clients.
Isn't that supposed to be more like a debug log than an info log?
Yeah, that sounds like a good plan.

I'm certainly up for coming up with a better structure!
We can write this as

```ruby
@url_regex = /^(http|https):\/\/[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,5}(:[0-9]{1,5})?(\/.*)?$/ix

validates :url, presence: true, allow_nil: true, format: { with: @url_regex } 
```

Even then, the real question is if we want to even check this. Most of these regexes are borked, and it will be admins filling this in.
This seems like an odd change because the standard Apache license used in openstack has the double-quote instead of single.
should the unlinking be in a finally?
I'm not an antlr expert, so you should request someone with experience on it to review this.
not used :-)
Hmm, I see now, the skip method called here does not override CSI.skip(InvocationContext, VisitableCommand).
I think it would be clearer if the skip method really did override the one in the base class and visitCommitCommand wouldn't be overridden.
If the the users don't want to support concurrent updates (remember not supporting concurrent updates is something then needs to be activated manually) then there's no point adding there locking interceptor to the chain. By default the locking interceptor is present for all  the caches (including local mode). 

On 12 Dec 2012, at 13:14, Dan Berindei wrote:
> Mircea, I meant removing the LockInterceptor completely from the interceptor stack for local-mode caches. I don't think we support this right now, and I didn't see any users clamoring for it :)
> 
> 
> On Wed, Dec 12, 2012 at 12:53 PM, Mircea Markus <mircea.markus@gmail.com> wrote:
> yes, especially for JDG in server mode which uses non-transactional caches.
> 
> On 12 Dec 2012, at 08:02, Dan Berindei wrote:
> 
>> @mmarkus, this seems like a new feature, do we really need it?
>> 
>> 
>> On Tue, Dec 11, 2012 at 8:37 PM, Mircea Markus <notifications@github.com> wrote:
>> In core/src/main/java/org/infinispan/configuration/cache/LockingConfiguration.java:
>> 
>> > @@ -53,6 +55,15 @@ public int concurrencyLevel() {
>> >     }
>> >  
>> >     /**
>> > +    * For non-transactional caches only: if set to true(default value) the cache keeps data consistent in the case of
>> > +    * concurrent updates. For clustered caches this comes at the cost of an additional RPC, so if you don't expect your
>> @danberidei yes it does make a difference for local caches. when this is explicitly disabled (it is enabled by default) we don't add a locking interceptor to the interceptor chain. So concurrent updates are very un-predictable. I think (this would require more though though) that this would only affect consistency, but I really want to discourage people doing concurrent updates on a cache that doesn't have the locking interceptor in the stack as this would open a can of worms.
>> 
>> —
>> Reply to this email directly or view it on GitHub.
>> 
>> 
>> 
> 
>
Instead of using the slightly magic `_` properties, what about simply adding a `proxy=` argument to `__init__`, then calling `scheme, host, port = get_host(self.proxy)` inside `connect()`?
That's the original one, the one that mrclay picked up and tried to improve.
If you prefer me to also link to that one I may also link. This filter works with both implementations, the interface is the same.
this would fail when the symfony application is not running at the root path but in i.e. http://localhost/project/
I've put up the alternative. This is probably the minimally invasive way to do it.
For those who want to look this up: http://www.pythonware.com/library/pil/handbook/format-tiff.htm
This code is in a different class. From here image_dpi gets passed to the backends constructor.
I recall that I checked the title in the previous version and can avoid this problem, but I also found that the title would change according to language change
That's why I remove the title checking, because it may not be that general (if select Chinese language, then the test will fail)
What do you think? @zacc
It's not entirely clear here if implementors means someone writing a logging class that implements this interface, or someone calling an object that implements this interface.  I assume the intent is "$message must be a string or something we can treat as a string, beyond that, meh."  

Possible revised language:

Every method accepts a string as the message, or an object with a '__toString()' method.  Implementations of this interface MAY allow for special handling for passed objects, but MUST support strings and passed objects that only implement __toString().

(I think that makes it clearer that if you write a Logger class, it must allow for __toString() objects.  Anything else is out of scope.)
I know, but it's actually just a usage example in a docstring. Totally kosher.
@bp323 the getDisplayName function already escapes output, so I don't think this is necessary.
@bp323 

Can't we change:

`($($rootel.parents('.contentauthoring_edit_mode')).length)`
to
`($rootel.parents('.contentauthoring_edit_mode').length)`
Filed as #113.
Yeah, I think we need to come up with a consistent format for all the log messages.

For example, every log message which is tied to an endpoint should be in the following format:

`[DATE] [LEVEL]: [endpoint ip:endpoint port:endpoint name] -> message`
`if (!err)` for consistency?
I just added some code for testing and left it in case you want to verify.

So leaving out the var DEBUG = 0; is OK and leaving the alerts in is
also OK for you?

I did some testing and locked the affected prefs to check its affect.

If I lock the browser.search.defaultenginename pref then
originalDefaultEngine (and defaultEngine) seems to be null or
undefined and the script aborts leaving the extension installed
(about:addons).
At least now the script finishes properly in the cases that I've
tested and it is only two extra lines.

lockPref("browser.search.defaultenginename", "Wikipedia (en)");

Locking prefs doesn't effect the reset operation (prefHasUserValue
returns false), but of course the reset to the unlocked default will
fail.
I know that this is a very rare case and might never expose, but I
consider code that work in as much cases as possible important.

"You can just re-use originalDefaultEngine from above."
I know . I left this because  that make it easier to maintain
(compare) the code should any change be necessary and it makes that
code independent from the rest of the code in the extension.

If you still want to to make your proposed changes in addition to
removing DEBUG=0 then I will do that.

Here is some code for the web console or scratchpad that you can use
to test the reset of the about:home search engine.
https://support.mozilla.org//en-US/questions/933343

Should it be added to the README file that a reload of the about:home
page is required if that page is currently open?

Maybe also mention the prefix name (searchreset.backup.*) of the
backup prefs explicitly to make it easier to spot those backup prefs.

On 8/15/12, Gavin Sharp <notifications@github.com> wrote:
>> @@ -3,6 +3,7 @@
>>   * You can obtain one at http://mozilla.org/MPL/2.0/. */
>>
>>  var Cu = Components.utils;
>> +var DEBUG = 0;
>
> I think we should avoid adding this - it's easy enough to re-add during
> development, don't need to have it checked in.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/gavinsharp/SearchReset/pull/2/files#r1384719
Could you remove these two lines please ?
Nit: Document.
Yeah I see. I'm tired of writing `bundle exec` beyond any reason, and I already use noexec gem (or whatever its successor is called), but noexec won't work for development, as it adjusts gem shebangs. I'll merge this.
Why in Django template? You do this in view. In Python code.
Indentation (too much).
Should I store `expires` as a `DateTimeField` and `status` as a custom field, limited to `okay` and `failure`, or use `StringField` for either? Because we did define custom field for gender, but it's almost too specific to define one just for BrowserID success value?
I think you are not using this class as intended. ;-)

The idea is that you don't resize ALL labels, but only those which are inside of `automatic-width`-marked fields. So that you can move all this code to `common.js`, not that you have to manually search places where to include it.
`browserid.js` is generated automatically by `django_browserid`, so it's 3rd party.
You should put this into `blocktrans` template tags so that it can be translated. (Just leave anchor in the translation text.)

There is one double space just before `<a`.
You can merge this into one line.
Right now the only way is to test against Android or iOS manually, unfortunately.  I'm working on adding automatic testing for Android and iOS to the bot.  And also working on fixing the bug that prevents it from building this pull request.

Hopefully things will be better soon!
Specifically to avoid a strict aliasing problem.
Please change this back to ```private```.
It's blizz, but will wait until you check sniffs, anyway. ;}
added it. I couldnt find the commit where the patch was added to 4.3.4 so i missed it
Could you cut a branch and remove this logging bit.  Not sure how heroku does logs, but since the filesystem on their platform is read only probably nothing good from writing out.  I'll look more into logging and logging output for heroku.
Paginator shouldn't be in DoctrineModule... I think I removed it while rebasing in #30
OK guys, if you don't agree to the best style how can I do ? :)

2012/5/9 Emmanuel Bernard <
reply@reply.github.com
>

> > @@ -83,8 +85,20 @@ public void start() {
> >                               else {
> >                                       port =
> Environment.MONGODB_DEFAULT_PORT;
> >                               }
> > +
> > +                             Object cfgSafe = this.cfg.get(
> Environment.MONGODB_SAFE );
> > +                             final boolean safe = cfgSafe != null ?
> Boolean.parseBoolean( cfgSafe.toString() )
>
> I use ?: all the time :)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hibernate/hibernate-ogm/pull/76/files#r797731
>
1 should be $BROCADE::FORCE_UNAUTHORIZED and that constant should be defined in pf::radius::constants
Nit: s/browser id/BrowserID
`const` fields are public by default
How come you commented this out?
Ugh.  I'm getting really tired of this `.to_s(16).upcase.rjust(4, "0")` thing.  Maybe we can add a method to `Fixnum` or something.  Hopefully we can also move away from doing string code point to int conversions in the future too.
Didn't know you could do this.  Very cool.
if you could have this pull request revised by friday, that'd be great.
For the static cast thing I was merely adopting Gary's usage - as ever I stress that I'm not enough of a C++ programmer to have a style (although have made it 2/3 of the way through the book I'm reading on the bus).  If that simpler syntax is good then I'll definitely adopt it.
maybe a more generic example

```
openssl base64 -in <infile> -out <outfile>
```
it would need a rescan, or keeping state of detected machines we blacklisted.  not clear to me this would be useful.  of course can add if there is a use case.
TU peux dire que meme les humains auraient du mal à résumer un texte de la meme facon
is it neccessary? Akka loggs this events already in debug level.
Why? It just doesn't use the tags. (Also, this is not something this patch changed).
Do you need to reset the SSID if there is no network?
I'm thinking we might want another directory for toolkit-independent things that are not declarative components.
Your first reply also answered my second question. That's a very interesting discussion, many thanks for you inputs ! _I really need to find some time to take a deeper look at Stash_
It needs to be after the ````processRequestData()```` call, otherwise the filtered data won't be available in the mass action
Ditto on the commented code
use http://files.vagrantup.com/precise64.box
Пакеты в java со строчной буквы начинаются.
áÁÁÁ, ËÁÖÅÔÓÑ ÎÁÞÉÎÁÅÔ ÄÏÈÏÄÖÉÔØ ÞÔÏ ÔÕÔ ÅÓÔØ ÏÄÎÁ ÌÁÖÁ, ÂÅÇÕ ÆÉËÓÉÔØ...

2012/11/14 Dmitriy Komanov <notifications@github.com>

> In src/ru/fizteh/fivt/students/fedyuninV/format/StringFormatter.java:
>
> > +        this.extensions = extensions;
> > +    }
> > +
> > +    public String format(String format, Object... args)
> > +            throws FormatterException {
> > +        StringBuilder buffer = new StringBuilder();
> > +        startParse(buffer, format, args);
> > +        return buffer.toString();
> > +    }
> > +
> > +    public void format(StringBuilder buffer, String format, Object... args)
> > +            throws FormatterException {
> > +        startParse(buffer, format, 0, args);
> > +    }
> > +
> > +    //this function guarantees thread-safety
>
> á ÞÔÏ ÐÏ-Ô×ÏÅÍÕ thread-safety. þÔÏ ÂÕÄÅÔ ÎÅ ÔÁË, ÅÓÌÉ ÎÅ ÂÕÄÅÔ
> synchronized.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/dkomanov/fizteh-java-task/pull/153/files#r2125251>.
>
>



-- 
ó õ×ÁÖÅÎÉÅÍ
æÅÄÀÎÉÎ ÷ÁÌÅÒÉÊ
íæôé æé÷ô ÇÒ. 195
Bug, as it's benchmark.get... again instead of benchmark2.get...
Fixing this with my refactor and adding a unit test because I am getting afraid :)
It turns out that changing the order does not force the youtube video to be used. I think I should probably revert this change though. We can always comment it out locally to test the youtube support.
You are reaching gBrowser to get the selected tab. This won't work in an undocked window.

Get the tab from the target that is accesible via the `inspector` proprety in `RuleViewTool/ComputedViewTool`.
You do not need to create an object because konoha runtime allocates memory.
See Array_new method (package/konoha.array/array_glue.c, line 403)
So Mockito should be removed from install_requires?
That worked, but I did have to add an extra wait as the divs are not populated immediately when the screen is loaded, and without the wait I was ending up with an empty list. New version being pushed imminently.
not making too many changes in one pull makes a great deal of sense.
Opps this is `app.js`. :) So this is only relevant when blogs is pulled out into its own file.
Old link?
oh oops, a copy-pasting error. thanks
Are you sure this is safe to do? Propagating `null` to the text hover does not seem very robust.
as long as it's mostly readable :)
`learning_rate` is a number...
Personally, I use double precision whenever possible - IMHO memory efficiency is not critical here. 

(I would even like to use double precision for ``y`` too and only use ``DTYPE`` for the feature matrix ``X``). Some numpy functions (e.g. ``np.exp``) have a significant overhead when applied to single precision arrays so IMHO we should avoid them whenever possible. )
unused, remove from .cpp too
The string functions will be handled by default string functions in V8. By removing this, the string class we be handled by the built-in engine.
it is not clear from the function name and signature which way the conversion is going.  One of the params should be const.  And a short comment would go a long way, something like: "Populate a QDateTime from a v8 Date object"

That being said, this code looks almost exactly like what Alex did for the date format.  The code should be put in a conversion utils file, as suggested by David, for reuse instead of duplicated.
Good catch, glad you're reading the docs :)
ok, i will change that
good point, yes will look at.
there are other attributes (e.g., PACKED) which might be useful on a dictionary, and probably shouldn't be removed by this.
the file/ line will come out from calling report Error.

Why is $ misleading? that is what the user included in their source code.

I could use queryChild(0)->queryName(), but in this case it would give 'self' - which would be confusing - unless I also changed the internal representation.
This needs to go before the pull request can be accepted. This is just to show off.
Can we document the heck out of this file?  It's not obvious what tests are being performed or what properties of the data structure are being validated.
this indentation of this looks really strange. Are you using tabs and not spaces?
This is important since I modify *options.partial* and the second time it contain partial string instead of partial path. This can be easily avoided in consolidate by adding additional property for the partial strings but I don't think it's necessary since you call render only once on every request like in express. On subsequent request to your router the options will be refreshed anyway.
should be static::STANDARD_AUTOLOADER
why disabling the autoloading ? It does not make sense as there is probably nothing using the class before this and so no reason to have it loaded.
@christianv Coming right up.
Yes the params go in the URL. Yes, print=silent is important.
`(contains? author :death-year)` returns a boolean by it self.
Changed to click.
Don changed this in December 2011.

It used to be only the 'to' addresses in the metadata, but now the metadata field contains the complete set of recipients.  You need the full message now in order to find out which were the actual 'to' addressees :)

Matt

________________________________
From: Robin Burchell [notifications@github.com]
Sent: Wednesday, November 07, 2012 2:09 PM
To: nemomobile/nemo-qml-plugins
Cc: Matthew Vogt
Subject: Re: [nemo-qml-plugins] Various simple improvements to the email-related classes (#29)


In email/src/emailmessagelistmodel.cpp:

>      }
>      else if (role == MessageCcRole) {
> -        QMailMessage message (idFromIndex(index));
> +        QMailMessage message (msgId);


hm, from/to is available from metadata, but not CCs?

—
Reply to this email directly or view it on GitHub<https://github.com/nemomobile/nemo-qml-plugins/pull/29/files#r2051730>.