labofsahil/github-event-dataset-2012 huggingface dataset:
rake just went 0.9.3.beta.1<https://rubygems.org/gems/rake/versions/0.9.3.beta.1>
:D
I definitely like SemVer as a standard, and as long as it works with
rubygems (aka I can install --pre) then it does not really matter :)

On Sun, Oct 21, 2012 at 8:52 AM, Ben <notifications@github.com> wrote:

> In lib/bump.rb:
>
> >      OPTIONS = BUMPS | ["current"]
> > -    VERSION_REGEX = /(\d+\.\d+\.\d+)/
> > +    VERSION_REGEX = /(\d+\.\d+\.\d+(?:-(?:alpha|beta|rc))?)/
>
> SemVer <http://semver.org/> names '-' as separator for prerelease- and
> '+' for build- identifier.
> gem versionomy <https://github.com/dazuma/versionomy> handels many
> different formats.
> Hard to say what's the "right way" to do it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gregorym/bump/pull/11/files#r1898754>.
>
>
@zeke - I think it is fine to have this here, it provides parity with auth:token and could be useful in some other non-sudo cases I'm sure.  If you could just remove the alias and associated test that would be great and I can get it merged shortly.  Also, I'm actually in the office this week, fwiw, if you have any questions or just want to meet in person.
<code>jQuery.remove()</code> not only remove node from DOM, but also remove all data from the element, 
so with this change, if we have, for example, events attached to node that replaces itself, all events from that node will be lost.

@PaulBRamos how you feel about <a href="https://github.com/jquery/jquery/pull/1038#issuecomment-10699377">this</a> suggestion?
At least one node_js reference is needed to run grunt
Shall I remove the one for 0.6 ?
Any reason we aren't pfreeing the newblob as well?  Wouldn't it be easier to simply remove this function entirely since it is never exposed?
Why don't we want word feature in case of interactive mode?
Philosophically I disagree that merge and transition are the same concept.
- Transition is a single row accumulator, Merge is a multi row combiner
- Transition is necessary for correct results, Merge is an optional optimization
- Merge is not just about second-phase aggregation, but about multi-phase aggregation, though in practice our use currently only makes use of the two phase techniques (e.g. we don't use cube and rollup aggregation).

I've had to explain the difference between Merge and Reduce often enough that I think the distinctions are important.
Fix'd that.
Perhaps we should provide a create_track somewhere instead of (ab)using ``create_fake_track``?
Ditto filter vs. query here.
It seems that the strip utility also adds a doctype if one is missing. Why does it do that? And shouldn't the test comment on that behavior, since it's clearly testing it?
Worked. Should I close this pull request and open another with corrections?
Style nit: `bin.install 'regex-opt'`
+1 this looks much cleaner.
Nevermind, just noticed the confirm below.
Why are you setting this? These are global config options, why do they need a parent key? They shouldn't
This declaration should be at the top of the function (since it gets hoisted there anyway). Stray variable definitions in the function body are a big no no.
That's it! Don't forget to also require the correct javascript files in the ``define`` lines.

I think this is more cleaner and open to future improvements. *I believe we should always take the chance to refactor and improve code if we have the chance, even if it's more work than copying code, and even if it's in our examples*.
Just call it a binding. Binding is the default.
small typo in 28
This check will not be necessary once you add the `@synopsis` tag above.
Externalize string, ``{0} Lines``
Change to ``title of the dialog``
This comes back to one of those bullets at the top of the pull request: "Talks directly to _codeMirror to make text edits. To fix this we'd need to expose batching and incremental-edit APIs on Document, which might not be too hard (and which I think we ought to do soon anyway)."  It seems easiest to keep that as a separate refactoring.

I can file a cleanup bug and add the issue number here if that works for you.
Re the various comments on case-sensitivity...  The existing behavior of Quick Open is to do everything case-insensitively, and since it's been around a while I'd rather wait and not muck with it in this patch.

Although my personal feeling is that we should stay case-insensitive even in the long run (seems more consistent with other tools & other Brackets features), it seems reasonable to raise this with the broader team.  We could always change it down the road if I'm in the minority.  Does that sound ok to you?
this is not good. workspace.js should not depend on specific plugins (like the npm-runtime)
yep, seems like `<a: modalwindow />` already escapes the value by setting `nodeValue` on the DOM node.
Oh my god, sync code!!
I didn't want to change jshint at this point; `data()` seemed to do the job just fine. If it is published, this part could be changed.
No space between id and <XMLRPCEncoder>.
well this is another reason that putting some of the dirty source map logic into *source-package.js* makes sense, because so much of what it needs to know is in there, including the indent character count. `SourceBuild` asks all its `SourcePackage`s for source map data for each module.
Is the `c()` necessary?
Why 39? Would it make more sense to have a constant that's name indicates what it means.
Hi Yoav, why's this check commented out?
Should we add an explicit wait here?
But the shelljs file() command can use arrays natively... although I guess it does look a little odd having a single array in an argument. Yeah, go with that change.
Question: why do we throw here?  "moveFrameRight" seems like the sort of thing that shouldn't fail.
That's what Kate did, I copied her.  I suspect this HTML will change when she looks at it.
Same for callback, I guess.
They are templates of sort for when we get around to adding the needed styles for all the displaying types the plugin will be supporting.
Is there a reason you deleted this?
This can be optimized by resolving ` $fs->stat()` and `$fs->open()` in parallel:

```php
    public function readFile($filename)
    {
        $fs = $this;
        $thatFd = null;

        $all = array(
            'stat' => $fs->stat(),
            'fd'   => $fs->open($filename, 'w+', 0644)
        );

        return When::all($all)
            ->then(function ($result) use ($fs, &$thatFd) {
                $thatFd = $fd;
                return $fs->read($result['fd'], $result['stat']['size'], 0);
            })
            ->then(function ($data) use ($fs, &$thatFd) {
                $fs->close($thatFd);
                return $data;
            });
    }
```
`PATH.resolve(__dirname, dir, 'test/test2/wFPs-e1B3wMRud8TzGw7YHjS08I.png')`
Minor typo: "An state" -> "A state"
technically speaking var i is being redefined here, so define var i at a higher level so it can be used by both for loops.
I think we could attach this to the notice object itself instead of leaving a global function hanging around by putting it as an available function in the definition below.
self.pools.each do |pool|
We could use data('url') here instead off attr()
I found that the code for detecting pinch gestures has to be integrated with the code for detecting pans or there are subtle bugs. So I'm trying to integrate handling for all the gestures I can think of in one place.

The tap and dbltap events will not be emitted if the library emits a pan event.  So if you click and move (past a certain threshold) you get pan and swipe events, but no tap event.  If you don't move more than that threshold, then you only get the tap (and dbltap) event but no pan or swipe.  If the UX team wants to change the threshold, there is one place in this one file to change it; I don't have to go find all the code that handles click events and determine what threshold it was using.
This is good text, but I think we already cover this in the Riak landing page and in Basho.com content.  When people get to the Fast Track, presumably they want to just download and play.  Riak's advantages will then be discovered in other content.
This comment is no longer needed :)
When put like that I'd like to ask why IMPLEMENT_RANDOMIZE_STACK isn't implemented in CreateThread instead... Would call for a lot less duplication of code that way.
Unfortunately the ternary operator without the middle is only available PHP >= 5.3. CakePHP 2.x is PHP >= 5.2.8.
changing the return type does not seem too good for me
I am aware. I am trying and most are fixed by now. Sorry :(
Hmm, yes I think ideally what we are trying to do should probably be handled with membership access level. It would probably be called "owner" and a group would always require one owner and ownership would be transferrable. But that's a bit more complex and I think what you've implemented so far is a good start in this direction.
I get the point. At this stage, I basically dont' dispatch any of the events coming from the toolkit-side. That is probably the reason why it is a bit simplified but also probably good for the scope of this part of the test suite. 

If we wanted to get a cleaner implementation, we should add an event loop that would properly work with the two pipes as you suggest. We could potentially use the gevent.core stuff that would be easy to integrate.
Can this potentially have floating-point issues? Might need `assertAlmostEqual` here.
I completely agree. This is the first refactor that should be done if one would continue from this pull request onwards.
Symfony registers all their services in a .yml file, but I wanted to focus on the service container first before meddling with the config component and loaders.

This PR does make the DI container accessible in all actions with $this->getContainer(). AJAX and cronjobs should work too, though I haven't tested crons yet.

As far as the kernel is concerned: [Symfony stores their kernel object instance into their service container itself](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Kernel.php#L592) the moment it is initialized, so you have an interface to HttpKernel available this way. We could do the same?
Why did you choose this over `kind_of`?
Isn't this if statement kind of pointless? As far as I see, the `save` statement one line below this wouldn't be executed anyway if the call to `fill` wouldn't change anything.
Nice. I didn't know about that call. Thanks!
Failing that, I wonder if casting to a set and comparing is more efficient than sorting. I'm only asking b/c sorting can be inefficient in some situations, and we don't really need a sorted list.
I like the idea of additional metrics, but think these might be a bit confusing. We have one test per module so I agree that it would make sense only to include the module length. That said, would restart tests be an exception? Perhaps test method timings would be beneficial for those...
I'd rather make as few changes to source code as possible - not only for expediency, but to avoid inadvertently introducing new problems.
NB you're using `1` for exit when people don't say yes to the confirmation prompt.
technically, that email address will not match because it contains letters that don't aren't valid hex digits...
I like these association names better than what I had proposed.
Is that a leftover comment from the original? If not, a TODO would be nice to be added to the comment
you need to remove the `s` for `datas`.
``Error message`` seems weird as the info on the node is the doc about the node, not an error message.
You mean ```Symfony\Bundle\FrameworkBundle\Event\ConsoleEvent```?
``$keys[$key]`` is totally wrong. ``$key`` is already the value in the ``$keys`` array.
Should be `$htmlPattern`.
if it is an instance of PropertyPath, you wrap it in another PropertyPath ? This will fail (PropertyPath expects a string)
should be initialized, otherwise it's a Boolean|null
What about `isSupported`?
Why not use `SVProgressHUD`? It's less intrusive and there is always pull to refresh to refresh the list.
These were originally set up to make sure FakeYammer was capturing the endpoint, although if the below tests are asserting we are hitting the correct endpoint, not necessary to test here.
This could also use a nicer method signature, like:
`_check_tcp(self, url, port=None)`
I don't think this discussion helps the readability for fresh readers of the code.
Also, remove the item from the table's inventory ;)
Why are you adding 0x30 to the temperature?
Lovely :-1:
This is about the last method in the Symfony2 doc (3. Without using ACL) but I don't think it's a good idea to implement it
itemViewClass?
needs to go back to how it was
This can be replaced by .addPackages
add default="Unnamed Domain"
This message id and the associated message semantics (== cancel async invocation) was already part of EJB client protocol's advertised message ids since the first release of that protocol. The problem really was that it wasn't implemented correctly both at the client and the server side. So technically this _isn't_ really a new message. We can't do much about old servers. They won't break with this new EJB client upgrade but will just ignore this message from the client which functionally is the same as what they do currently - not being able to cancel a remote async invocation.
Only one attribute per call; we still support 1.6.
! Sorry, I don't know it "and up"
I'll remove it.
According to the documentation it should be a long (see http://curl.haxx.se/libcurl/c/curl_easy_getinfo.html#CURLINFORESPONSECODE). I am fixing it ...
I've just learned that forEach can take a second argument (and @etiennesegonzac told me i've re-learned it!) for the |this|.
So let's kill bind!
This is going to freak out SpiderMonkey even though it never gets run.  At least, the node polyfill that also performed a similar write definitely freaked out SpiderMonkey for me.  If someone wants to run your lib in an old JS engine, they can load es5-shim.js first :)
I acknowledge the issue and I have opened #4127 to track this. Having said that I think we need to come up with something like:

+ The same base markup structure for the two view. FB is prepared to use the Gaia BBs whereareas Contacts is using legacy markup
+ friends_list.js has defined an algorithm much more clear to understand than contacts_list.js
+ however contacts_list.js has a better optimization that allows not iterate two times over the contact list
+ contacts_list.js creates hidden nodes for the groups just to enable to insert additional later on, however friends_list.js does not need that.
Hi Tim,
children will return the target element's child nodes in array. There is one similar method called "childNodes"
But it will return not only HTML element, but also textNode, so we use children here.
align with the above line.
It would be better to call 'checkInputs' only once, probably in last iteration of 'for' loop. Same for 'deselect'
this increment is not needed
Don't leak the SiteManager into the controller. Hide it behind the IApplicationService.
Interesting, whether or not this should apply to all XXXBuilder (not just custom).   I guess our statement is other type of built-in builders (WAP, SITE, NPM) will not be sensitive to deployment settings.   Although they could, if user wants to achieve such, do generate custom script and use CustomBuilder is the solution?
Keeping all templates as identical as possible is a good reason, the multiple "grep" work well and it is not the real subject of this pull request.
So if you agree I will remove it ?
I think it's reasonable for it to be marked as private until there's a compelling reason to make it public.
Add a newline between these lines so that it's clearer where the SCRIPT ends.
I'm curious why you made the IP field a combo box (it wasn't at the midterm stage). Looking at the code, right now the IP address will always be 0.0.0.0. So a combo box will give the user a false sense of what actions are possible. Did you intend for there to be more IP address options?

I recognize that the current IP address is just for testing. But how will the user enter their local IP address in the future? (I'm assuming they'll be using it over LAN, not WAN.) Or will the program auto-detect the local IP?
Nope, again, list does not pass along type.
Boo, yeah javascript regex is pretty limited.  This looks really cool but I don't want to double the size of my library just to have better regex support:
https://github.com/slevithan/XRegExp
Weird format.
Interesting stuff. So I'm trying to figure out how to allow verify_peer on the initial connection to mxr.mozila.org when we don't have any valid CA bundle yet. See my comment [here](https://github.com/EvanDotPro/Sslurp/commit/a1ea5fc4da3d49585cd4fe82ddb67de600130a48#commitcomment-1838002). Thanks for all your help reviewing this, by the way!
Done (and the others).
Will look into this. You might be right and I just spoke without thinking through it (I replied this morning, before my espresso, so I don't consider that good/quality thinking :P)
so this was the wrong place, right?
地址相关的配置不要写死，这边可以使用通配符，然后在MVN中pom文件中配置多套环境（DEV，Production）不同的配置，具体方法可咨询健哥
能不能抽一个方法 出来  Representation getTask(HttpServletRequest req, HttpServletResponse resp)。因为 任远也需要这样的方法。
Cute. Inline idParts for bonus.
Sorry about that, forgot we did that.
Lets keep this titled exclude_subdomains because we are excluding form production data and for backwards compatibility.  Also if there is no dev code we do want it to act as an exclude
Below should prob be private :/
Could you please add comment explaining in which cases this is supposed to throw.
In fact primary documented names in node are serialize and parse, so I'd like to stick to those two here as well.
Actually I did. Isn't the same rule between french and english ?
When you have multiple bullets, you end up with coma for all bullets expect the last one, with a point.
cleunps -> cleanups
if/else shouldn't be on the same line than the brace:
```
}
else
```
now emails in the database can be unverified.  if they are, we don't issue certificates for them.
Is the transitioned secondary *now* a secondary or a primary?
Transition code, no longer needed.
backslash line continuations are generally discouraged, better to use implicit parenthesis continuations. So this can be:

```
help = (
    "Transfer json blobs from the key/value store, uncompacting"
    "them to the appropriate database."
    )
```
filename should end in _spec.rb ...
I think I've misled you in the past...  These should probably be `stubs` and not `expects`.  If they really should be expectations, then is it possible to get them closer to the example blocks so it's more clear these are expected behavior?

If you'd like clarification on why I think these should be stubbed instead of mock expectations, please let me know.  I should be able to explain it at this point.
Type name is actually a string. `canonicalize_type` returns a valid type name, which is a string.
@joshcooper good catch. updated.
Isn't `map(&:to_sym)` a ruby >= 1.8.7 only thing? IIRC this is not valid in 1.8.5
I'm assuming at some point a whole bunch of these methods would be moved to Gem::Utils - that doesn't exist at the moment does it? I didn't want to pollute the pull request with unrelated changes.
Openfire returns a empty result, while ejabbered returns result/query stanza
Should we have a guideline on how much to test--specifically, should we test all success and failure paths from a feature test?
You probably missed a bracket. It looks like if( !( ... || ...) ), so the conditions are really similar
Attached failing test at zendframework/zf2#115
You can simplify :

$attribute = $method;
if (preg_match('/^get/', $method)) {
    $attribute = substr($attribute, 3);
    $attribute = lcfirst($attribute);
}
Hash#delete return the element that is deleted. I.e.:
```ruby
labelIds = params[:lesson].delete(:labels)
```
Ok, I misread this on first blush, and thought you were referring to the `git flow feature publish` command, but now I think you're referring to the warning about `git flow feature finish`.  I'll put together a more convention-based description and update the PR.
The LDAP stuff won't work without enabling here because of the extra property on User (DisplayName). It does make sense to disable by default though. Do you prefer that I comment out the code or disable from config (by default)?
Nepilnai išversta
Two expensive calls...but for price of two?

How about HungerComponent hunger = holder.add(HungerComponent.class);
ok, good point, I agree.
@dbu the syntax check has not changed since 2 weeks, and the fact that a trailing comma breaks JSON has not changed at all.
this has the potential to eat away other exceptions. can we do a specific exception MissingTranslationException or something?
I would remove these generated comments. I feel they often just serve as noise in your file, but if you find them helpful, then keep them.
What is the intent here? Is it to handle the case when:-

a) 'package_dirname' is the name of an existing directory but is empty
b) 'package_dirname' is the name of something other than a directory

If a) then shouldn't 'File' returns an empty list anyway?
If b) then we an exception should be raised a long time before we get here

Also, even if this was the right place for this then the intent  would need commenting.
I asked you some time ago about another name :P I have no idea what to name it.. `querycall`? `invoke`?
Here, I replaced the URL.

(messy commit, does 2 things at the same time: 1'd reject it if I were you, and ask for a split :)
`and` is not available yet at that point :-)  you could use a call to COMPARE_OP but that's not much simpler.
Because otherwise unique doesn't work. It just runs through the list ones, and assumes it's sorted, so it should be sorted.
hehe. border="1".
Will check with chelsea to see what our traffic stats for IE are.
This isn't be used for anything, delete this and the var declaration
What that comment says Only 1 play when video.loop=true

So, it only fires play once, after the first call, then never again, if loop is true.

I actually did not question this. It was in the old code, and had tests. I just refactored it because I moved code it was previously in.

I took a quick look in the spec, but did not see anywhere that play only fires once, on the first play, if loop is true.  This implementation might be wrong, but I doubt it.

I think we could file this, look it up, and if this implementation is wrong, fix it. For now, let us keep that out of this ticket.
it's a lot easier to add a cleanup method here instead of saving them in self.queues and waiting for teardown:

```
self.addCleanup(xq1.delete)
```
I totally agree with that, unfortunately there is a lot of code in the entire project that needs to be refactored/cleaned and this task could take a very long time.
In the mean time, using good practices will help a lot, even if, unfortunately, it introduce another style of code in the project.
Just making sure I'm reading this correctly, the annualizer is in an integer in the units of the granularity.
I didn't notice this before. Good eye @hub-cap. I agree that we should include the kwarg in this call.
I'm not sure I understand the reason for `textContent.match(/\w/)`. `textContent.match(" p.")` should be sufficient.

Do page number fields sometimes contain information other than pages? Would `item.numPages= textContent.split("p.")[0];` not be enough (without the if statement)?

Finally, you should not include the "p" below (line 80). numPages should be a number.
<title> is not in annotation, just to clear that up.
There are super concise ways to find the pool you want with ruby, check out http://ruby-doc.org/core-1.9.3/Enumerable.html#method-i-select
Might want to think about adding a gem like WillPaginate, which will allow you to easily add pagination to the application. I believe there is also another gem that will style it bootstrap style
Should we make these global handlers?
Only the hash table insertions should be guarded by `if (osr)`; the XML lookups should be done unconditionally.  Otherwise, you risk having `openslide_can_open()` return `true` but `openslide_open()` fail with a parse error.
should not be removed, the completeness of this test relies on the fact that is removing empty and nil values
Try `w_config.setdefault('title', w_name)`, which is pretty much equivalent to this.
Yeah, in my branch it was being used in multiple places.  And for that use case the keywords actually did make sense.  But for here, for general purpose, you're right.  Will push another commit.
Yeah, I guess it's somewhat necessary to deprecate. Alas.

As far as order goes, if you need to append anything, you can do it with content_for :javascripts. Anything beforehand needs to be in `application.js`... as it should be, in my opinion.
Not sure I understand the /1000 here.
I see. Then what about naming it with a double underscore at the beginning, i.e., ``__stringLikeClass``, or similar.
In fact, this dependency is not used. I'll remove it.
I guess it was a leftover of when aspectj was not provided by AJDT in the build.
On Mon, Jul 9, 2012 at 1:41 PM, Iulian Dragos
<reply@reply.github.com>
wrote:
>> +      plugin.workspaceRoot.findContainersForLocation(path) match {
>> +        case Array(container) => Some(container.getDefaultCharset)
>> +        case _ => None
>> +      }
>> +    }
>> +
>> +  private def shownSettings(settings: Settings, filter: Settings#Setting => Boolean): Seq[(Settings#Setting, Option[String])] =
>> +    for (
>> +      box <- IDESettings.shownSettings(settings);
>> +      setting <- box.userSettings; if filter(setting)
>> +    ) yield {
>> +      val value = Trim(storage.getString(SettingConverterUtil.convertNameToProperty(setting.name)))
>> +      (setting, value)
>> +    }
>> +
>> + def scalacArguments: Seq[String] = {
>
> One complication (and the reason why `Settings` objects were used before) is multiple output directories (for multiple source directories, like `src/main/scala`, `src/test/scala`, etc.).
Multiple output directories are supported by sbt in
https://github.com/harrah/xsbt/pull/489 As far as I understand,
Eclipse has multiple output dirs for a single compilation (project),
so that it's not possible to compile several times.
That corresponds to sourceOutputFolders in Eclipse.

>
> I think the proper solution would then be for the `Sbt` builder to call the compiler several times, one for each source folder (as I believe is done in the command line Sbt. One benefit is that errors in tests won't prevent bytecode for being generated in the main sources.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/scala-ide/scala-ide/pull/144/files#r1121046
Actually it was totally necessary.  Put back in.  Final section of if chain is elseif.  There is no final else.
How will this change affect the Thrift interface part of it?
Agreed

Le 15 nov. 2012 à 08:47, Markus Bachmann <notifications@github.com> a écrit :

> In src/Geocoder/Provider/GoogleMapsProvider.php:
> 
> > @@ -152,9 +154,10 @@ protected function executeQuery($query)
> >      /**
> >       * Update current resultset with given key/value.
> >       *
> > -     * @param  array  $resultset resultset to update.
> > -     * @param  String $type      component type.
> > -     * @param  object $values    the component values;
> > +     * @param array  $resultset resultset to update.
> > +     * @param String $type      component type.
> string should be lowercase
> 
> —
> Reply to this email directly or view it on GitHub.
>
:+1: nicely split up
I think that there must be
	if ($this->load->controller($route, '', FALSE) === FALSE)
Should probably make that `if (is_array($name) && isset($name['name']))`
Там нет никаких особых рассчётов, поэтому не оптимизировал.
percent имеет тип int, то есть может быть и отрицательным
@slebedev Собственно - вы подробно расписали то, что я обозвал словом "лучше". 
И действительно, для XCode "нативным" способом будет отдельный файл с категорией именно в такой нотации. Кстати, создать его можно через File-New!
Рискованно. Вы геттером отдаёте ссылку на свой массив, который можно будет изменить без ведома объекта (вернее, корректную работу экземпляра класса гарантировать не удастся)
Если честно сделал только для наглядности кода, не хотелось писать одни и те же циклы в разных методах. И вторая причина заключалась в том, что когда только приступал к реализации этого задания не был уверен о поведении новосозданных обьектов и переменных внутри вызова методов...
Moreover, in french, it must be a non breaking space.
The file was already provided with utf-8 non-breaking spaces.
Here's a suggestion that you can either take or leave.  I'm a big fan of grouping methods by visibility.  So you have all the public methods at the top.  I find it makes it easier to see the public interface at a glance, and especially when using inheritance makes it clear what methods of the super you're overriding.
I think I had an issue with the msvc solution generation if it is not an absolute path
why remove the `clearfix`er?
Why wouldn't we want that behavior?
Hooray fewer dependencies!
start_time is undefined if (self._preloaded and not copy)

If self._preloaded then start_time is a tuple (start, self.info['sfreq']), which is strange as well.
I'd prefer this be a str since we have that capability now (and I think it's clearer).
should be .fixes for relative import
no need for the view engine and the views folder.
Not only does it explode but a ton of other tests fail without the check
:-(
On Nov 7, 2012 4:59 PM, "José Valim" <notifications@github.com> wrote:

> In lib/devise/models/authenticatable.rb:
>
> >        end
> >
> >        def strip_whitespace
> > -        self.class.strip_whitespace_keys.each { |k| self[k].try(:strip!) }
> > +        self.class.strip_whitespace_keys.each { |k| apply_to_attribute_or_variable(k, :strip!) }
> > +      end
> > +
> > +      def apply_to_attribute_or_variable(attr, method)
> > +        if self[attr]
> > +          self[attr].try(method)
> > +        elsif respond_to?(attr)
>
> Maybe we should use just send directly? I don't even think we should use
> respond_to?, because if someone supplies an attribute that does not exist
> it must surely explode.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/plataformatec/devise/pull/2135/files#r2062692>.
>
>
This is one change (added if)
Possibly... I haven't tried. The logic behind putting it here was that the guide instructs you to put it in your application controller (as if it's going to override the same method in Refinery's application controller). It turns out by doing this, what the guide tells you to do actually works.
This should match the filename: `nl-BE:`
@stof yes it is (see also the PSR-2 standards chapter [4.2](https://github.com/pmjones/fig-standards/blob/psr-1-style-guide/proposed/PSR-2-advanced.md#42-properties) and [4.3](https://github.com/pmjones/fig-standards/blob/psr-1-style-guide/proposed/PSR-2-advanced.md#43-methods)
Why is a method needed here?
Код читабельнее, елочки не нужны.
Так как сохранение драфта — атомарная операция, рекомендую в начале функции лочить базу (`DBLock`'ом), а потом делать `lock.Good ()`. И вообще всегда так делать, если семантически атомарное действие выполняется за несколько запросов.
¿Este if y su instrucción deberían asegurarse que siempre date sea posterior a lastSendDate? ¿Qué pasa si difieren en más de un día?
Yo quitaría el default enteramente. Me parece que lo estás usando exactamente igual que el `placeKey`, ¿no es así?
Is this closed anywhere?
a big typo :)
I probably wouldn't leave the respond_to check here... A stronger test would test that something happens when you panda.feed. As it is, line 36 doesn't build upon the line 35 test.
as the other clause return a value, you can remove the else block and unindent the try catch
Updates with Javadoc to come
non-primitive objects shouldn't be allowed in the form hash (it should be createable via JSON). maybe a 2D array instead? ex `[0,2]`. or a hash like `{row: 2, section:0}`
Please move the VM identification functionality to the org.infinispan.utils.Util class
I need new glasses.
Something is really going wrong here. I had replaced that and never checked again and now it's back?
I'll fix that.
Indentation in this method.
@arrbee might be able to shed more light on that, but I don't think strict UTF-8 allows embedded NULs anyways.

If we really wanted to be safe, this could use `-initWithBytes:length:encoding:` instead.
I'm not sure whether:


```
fig, ax = plt.subplots()
```

is better than 

```
ax = plt.subplot(111)
```

or even ```ax = plt.axes()```

Note:

I do agree that:

```
fig, self.ax = plt.subplots()
```

is better than

```
fig = plt.figure()
ax = plt.subplot(111)
```
> 79 chars.
It would be awesome if you used CSS animations instead of JavaScript for the fade.  For example, creating a default fade in/out style for all x-toast elements, but then when the duration was set on the element via "data-duration" or '.duration' then write the transition length to the elements style property.
I think it's a good idea to have the contract for headers on the request interface.  This allows collaborators of a request object to not need to know the internals of the request object (i.e. an object using the request object does not need to know that the request object owns a headers object that has a getHeader() method).  This is the basic concept behind the [Law of Demeter](http://en.wikipedia.org/wiki/Law_of_Demeter).
as per above, these should return true if ok, so use:
 minlen$: lenrule( function(vlen, len){return len <= vlen} ),
@jsloane Since `isUserAnEditor` doesn't exist in this file, we probably need to merge in another pull request before this one?
If so, could you make this clear in the jira?
@apex13 Can we leave the changes to the `sakai_global` variable in the `group.js` file?

I'm just thinking about the fact that we should be able to use this on a different page than the group.html file.
We use the global variables to see in which context we currently are. For instance see `getPageContext` in the api.Util
template default values had been accessed everywhere from a PropertyIterator. To reduce the footprint of JCR dependencies I've used Map<String, String>
isAdminUser(...) now potentially throws a StorageClientException because it loads the User object and its principals set.
It's basically meant to catch ANY exceptions in general.
to fit the complete button.
OK.

I won't be able to fix these before tomorrow night.

On 10 December 2012 08:15, Jocelyn Fiat <notifications@github.com> wrote:

> In examples/restbucksCRUD/src/resource/order_handler.e:
>
> > @@ -53,27 +53,21 @@ feature -- API DOC
> >
> >  feature -- HTTP Methods
> >
> > -	do_get (req: WSF_REQUEST; res: WSF_RESPONSE)
> > -			-- Using GET to retrieve resource information.
> > -			-- If the GET request is SUCCESS, we response with
> > -			-- 200 OK, and a representation of the order
> > -			-- If the GET request is not SUCCESS, we response with
> > -			-- 404 Resource not found
> > -			-- If is a Condition GET and the resource does not change we send a
> > -			-- 304, Resource not modifed
> > +	do_get (a_req: WSF_REQUEST; a_res: WSF_RESPONSE)
>
> I understand the conversion `a_req' and I usually use it
> but here, to have short signature, and still readable, we decided to use
> just req, res , and ctx when relevant.
> so please, keep this convention, otherwise we would need to update all the
> interface that use them .. to get coherent.
>
> in addition, this makes your patch longer to review.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/EiffelWebFramework/EWF/pull/16/files#r2361179>.
>
>
try catch 一下，还是直接不管他？
"compromising on" -> "compromising"
all functions defined by twig are prefixed by ``twig_`` to avoid conflicts. Please do it here too (and ``_twig_`` may be better here as it is only an internal function, to be consistent with Twig itself)
And `or` would work here.
They don't looked very lined up to me. Oh well.
The $ is needed because the initial code is more preventive rather than the one from the tinymce.

Instead of relying that $ is aliased for jQuery, this code aliases  $ in the function passed to the jQuery object.
This way people can still use $ in the surrounding function without worrying about collisions regarding $.
Not minor at all!  Great call!
This is very much out of my league, but out of curiosity I must ask: Isn't "\n" an ASCII character?
I see. Just for the record, here's an example of a situation when it's necessary (at least short-term): https://groups.google.com/d/msg/simple-build-tool/tgJzXnqVt0s/EEIw9oAEoRcJ
I thought they were, that's why I made them 25x25. I thought they were much better and clearer this size. I thought they looked good and just the correct size? http://shrani.najdi.si/?3x/Gw/3KRkNgmi/userlist.png
Good. So I just have to leave you alone and you solve all bugs. Good. :-)
Now I read DEBUG value from settings.
`key`? What is `key`? Rename it to mean something.
`forecast`?
I would have a dictionary here:

```
var onlineUsers = {};
```
Check how we are doing it elsewhere. For example, how we generate Facebook callback URLs. ;-)
This is a matter of design philosophy but I'm uncomfortable with catching all exceptions and returning 0 here (this happens other places as well).  If there's some specific exception that you think might be raised and want to ignore you could explicitly catch it here, but catching all exceptions and returning 0 as though no errors occured may lead to very diffficult to detect problems.  In general I favor a fail-fast strategy where unanticipated errors actually cause things to blow up in obvious ways so that you can find and fix the error as quickly as possible.  That's usually preferable to limping along in a manner that seems to indicate successful behavior but is actually incorrect, because that depends on someone closely inspecting the results and noticing, "Hey, that can't be right."
I would actually suggest beginRendering / endRendering (more verb-ish). But that's just me bike-shedding.
Why is this one different from the rest?
uhhh yea i guess. why make it simple though if i can make it complicated :D
And now?....
there are already some functions to calculate distance
Looks simpler than what I expected.
Don't we need any specific column name for this? How is Mongo going to know it needs to index the group of columns?

I was expecting a {composite, group, of, values} stored under the usual ID_FIELDNAME . But that's just a guess, I should read some more about it.
Will casting set the realSplit field? Would that not return null?
Get the logger, but why would I stub out the stuff I'm interested in getting back from the commit?
mmm the idea is more if we don't find gevent when you want is as the backend we raise, else we use thread. 

`use_gevent` would mean for me that we fallback on thread if gevent is not installed. Both are OK for me, it would be interesting to have opinions of an OP or admin there.
i thought login.anosrep.org is staging and persona.org is master.
i also got the impression that dev, stage, and prod run significantly different sets of code, which is why this project has the three branches.
Why do AsParallel().ForAll() instead of Parallel.ForEach()?
I'm happy to merge the patch but I will change this part back to how it was. The `datastore_insert` is the only api call that we need here since it creates and inserts automatically. Internally `datastore_create` in case the table already exists and `datastore_upsert` in case the method is insert are exactly the same. 

What do you mean by "create_mapping"?

You are right, the docs are not existent for the datastorer.
This CSS needs to go into the stylesheets, not the page . Work with steve to sort that out
Bracket on same line.
ATM I keep only one context by type, this way a context itself doesn't need to know what type it is. But it probably can probably make sense to keep a series of crafter context as stated in the comment, so for that it has to work like you suggest. It was a simplification but I might as well fix it now.
A bit more compact:
```javascript
var status_code = cls.ResourceUtil.http_status_codes[responsecode];
if (status_code)
  responsecode = responsecode + " " + status_code;
```
и этот тоже не надо коммитить
ok ... then 88 is the default behavior for plone.
Please use camel case: "becomeDaemon", or even better "shouldDaemonize".
Actually it's used in skins too. So, maybe we should just create rcmail.set_cookie() wrapper?
*"It's main intention is to be used in other extensions, like `content_for`."* or something
needs doc build check, I don't know if we need to double the back-slashes
I'm writing the content of `e()`, i.e. same as `ereturn list,` (not the matrices) as a dictionary into the python file. Then I update the Bunch.__dict__ with it.
I put a link to an example for the produced python module at the main discussion.

adding the content of `e()` is optional, but turned on by default, can be turned off with option noest
On 07/25/2012 12:23 PM, Skipper Seabold wrote:
>> +        else:
>> +            self.var_l = var_lims[0]
>> +        if var_max is not None:
>> +            self.var_u = var_max
>> +        else:
>> +            self.var_u = var_lims[1]
>> +        if mu_min is not None:
>> +            self.mu_l = mu_min
>> +        else:
>> +            self.mu_l = mu_lims[0]
>> +        if mu_max is not None:
>> +            self.mu_u = mu_max
>> +        else:
>> +            self.mu_u = mu_lims[1]
>> +        self.r0 = chi2.ppf(1 - sig, 1)
>> +        print 'Finding the lower bound for skewness'
> If you can post to the ML (or here) a full working example that hangs I'll have a look.
Well, I think I put those there when writing and debugging.  I can't 
come up with a scenario that freezes it up.  Answers that question.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/statsmodels/statsmodels/pull/326/files#r1236406
Would it make sense if you didn't query for the fallback region unless you need it? It'd save us a lot of DB queries, for all the cases when the primary region is not rejected.
Recommend each of these become a property specified in the Properties/pom.xml.  See how log4jDefaultLevel is done there.
Why isn't DirectEventLogger a spring-managed bean that gets injected?
Another opportunity for leading underscores.
If you do `if (app != null) Entities.destroy(app)`, then it will automatically call stop on its children (i.e. on the MongoDbServer).
Delete commented out code, and iterate over vals.keySet instead?
This looks really powerful and useful, but also a little confusing.
The poll(attribute) makes it look like we're polling the attribute, rather than it polling the function to populate the attribute.
However, that's a more general problem as the same naming/pattern is used in other sub-classes of AbstractSensorAdapter.
So best not to address the issue in this pull request...
Is that how you'd set inboundPorts? I presume you'd need some prefix for inboundPorts to take effect. Or to set it directly on the JcloudsLocation.
Also, I'd have thought inboundPorts would get set automatically from SoftwareProcessEntity.getRequiredOpenPorts which for MySqlNode would spot MYSQL_PORT as desiring 3306 to add it automatically. Interested why that's not happening for you.
handy fix.  we should add to the javadoc that the command will be single quoted, callers should avoid single quote or escape appropriately.
(sorry i posted this previously on laura's computer!)
I fixed the properties to systemPropertyVariables.

That is a good question; for the old system properties it should have been the verbose format. Strange that no errors are thrown and intellij also was perfectly happy with it (it normally is quite picky).

But it is fixed.

Also the tests didn't fails :)
Could we get away with remoteSigned instead of unrestricted? No need to open more than we absolutely have to.
and `parsed_url.query = urlencode(querystring)`
Instead of a custom `logout()` function, it'd be more useful to check if the logout button is a link and to activate it if it is, so that sites that already have their own logout button can just add the `.browserid-logout` class to it to make the magic work. If they need custom functionality they already should be using their own JS instead of this file. :P
require_relative is 1.9-only
this should go in the rakefile. see for example:

https://github.com/seamusabshere/active_record_inline_schema/blob/master/Rakefile#L11
yes ok, we will always assume json. we support xml, too... but yeah, not important.
There's an "r" missing from "maked".
yes, I'm sure :)

On Mon, Feb 27, 2012 at 6:55 AM, Alexander <
reply@reply.github.com
> wrote:

> > @@ -283,7 +283,11 @@ protected function isRememberMeRequested(Request
> $request)
> >              return true;
> >          }
> >
> > -        $parameter =
> $request->request->get($this->options['remember_me_parameter'], null, true);
>
> That will also allow other sources (PATH and COOKIE). Sure you want to add
> those too?
>
> Also `$request->get()` is slow, as per the notice here:
> https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Request.php#L460.
> On the other hand it is only run on login success.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/symfony/symfony/pull/3460/files#r490868
>
The first one is best, for tying into Distro and Waste.

The second one is for a SEVA system.
...this will have no effect with homebrew's superenv. To allow certain optimization in superenv is another issue and in my view a possible feature for homebrew. But right now we are still in the process to make everything build. Then, we might add an option for power-users or for certain formulae to enable more aggressive optimizations.
When the path is rotated (through the normal Lively rotate), moving one point influences the positions of the others.
Maybe the problem can be found here somewhere?
I really also think they aren't exclusive.  There can be a plugin "dynamic_boards" which pulls from some file(s) to source the information and generates the IBoard objects on the fly.  Having all the code that handles the dynamic registration in one plugin would make this easier IMO.
The coffeescript is not strong with this one
Thanks. Besides, don't argue English with an Englishman.  ;-)  

--  
Phil Sturgeon


On Saturday, 1 December 2012 at 20:22, Markus wrote:

> In _posts/09-05-01-Building your Application.md (http://Application.md):
> > @@ -0,0 +1,72 @@ > +--- > +isChild: true > +--- > + > +## Building and Deploying your Application {#build_title} > + > +If you find yourself doing manual database schema changes or running your tests manually before updating your files > +(manually), think twice! With every additional manual task needed to deploy a new version of your app, the chances for > +potentially fatal mistakes increase. Whether you're dealing with a simple update, a comprehensive build process or even > +a continuous integration strategy, [build automation](http://en.wikipedia.org/wiki/Build_automation) is your friend. > + > +Among the tasks you might want to automate are: > + > +* dependency management  
> That's a typography link which doesn't have authority in the area of language correctness. You asked for grammatical orthographical correctness, not consistency. If this is about consistency, I'd rather see everything with small letters but I don't care, commit is coming.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/codeguy/php-the-right-way/pull/198/files#r2286602).  
>  
>  
>
What does this .path member get used for?  I don't see it used in the changes.
no, site is set as ```https://homerunweb:3001/api/v2```
Ты закрываешь System.in! Этого делать не надо.
This class doesn't exist...
typo:  should be `memory_profiler.magic_memit` instead of `memory_profiler.magic.memit`.
why is that better? is it faster?
I think this was true for an early release of cython - as for 0.16 there shouldn't be a noticeable difference at all
in the ticket (#303) i added that the problem this pr addresses only occurs if you have not set the propel.defaultXxxFormat params.
@willdurand then suggested to set these to a default value instead of changing the code
Two more spaces please!

`{ pageX : ...... 0 }`
Please could you do the same here as well