labofsahil/github-event-dataset-2012 huggingface dataset:
Thank you for that. Fixing.
No, use QT += sql
Yes, it should be, I think.
This shouldn't be here anymore right ?
It's probably out of scope for this PR, but do we want to do some validations if the value types match the ones that are defined in the schema?
Group instead of Object
We can probably just omit the second null here (and in other places), and only explicitly pass in data when there is data to be passed in.
I see your concerns. 
But as you can see in https://github.com/vigdorchik/scala-ide/blob/wip_new_sbt/org.scala-ide.sdt.core/src/scala/tools/eclipse/buildmanager/sbtintegration/SbtInputs.scala#L68 the constructed ScalaInstance is passed directly to the compiler, and I don't see a way to extract the final compiler arguments back. 
The relevant sbt code is  https://github.com/harrah/xsbt/blob/0.13/compile/CompilerArguments.scala#L59
"autoBoot" is set to true: https://github.com/vigdorchik/scala-ide/blob/wip_new_sbt/org.scala-ide.sdt.core/src/scala/tools/eclipse/buildmanager/sbtintegration/SbtInputs.scala#L68
Probably because of not wanting to introduce any regression. After all, the existing code was catching `Throwable`! But you're right, the two exceptions would make sense. Want to contribute it? :)
I believe it would be better to declare the method with empty parens, since it is not referential transparent. WDYT?
Seems like this try-catch got lost, and crashes in the Scala or Java compiler are no longer reported as error markers.
"Boite de processus" ? That seems like Google translation. I think this would better be "Cette série de tests a été exécutée sur une machine sponsorisée par"
add to config.js to allow easy changing of this url
This might be going a bit far?
This should say 'mixed' instead.
On 03/05/12 16:52, Timothy Warren wrote:
>> @@ -62,11 +62,12 @@
>>   | URI string.  The default setting of 'AUTO' works for most servers.
>>   | If your links do not seem to work, try one of the other delicious flavors:
>>   |
>> -| 'AUTO'			Default - auto detects
>> -| 'PATH_INFO'		Uses the PATH_INFO
>> -| 'QUERY_STRING'	Uses the QUERY_STRING
>> -| 'REQUEST_URI'		Uses the REQUEST_URI
>> -| 'ORIG_PATH_INFO'	Uses the ORIG_PATH_INFO
>> +| 'AUTO'			Default - look at several globals and take a guess
>> +| 'REQUEST_URI'		Use REQUEST_URI   (hack, to work on either version of PHP)
>> +| 'PATH_INFO'		Use PATH_INFO   (CGI standard, but broken in PHP<  5.2.4)
>> +| 'ORIG_PATH_INFO'	Use ORIG_PATH_INFO   (workaround, PHP<  5.2.4 only)
>> +| 'QUERY_STRING'	Use QUERY_STRING   (CGI standard)
>> +| '_GET'			Use _GET   (the php array, in case even QUERY_STRING fails)
> Have you actually observed a case where $_GET works over $_SERVER['QUERY_STRING'] ?
>
> I'm not really seeing the point of making this an additional method of path determination.

The code is already there in AUTO.  This just lets you access it 
manually.  I wanted it myself for testing - so I could see what $_GET 
did, in case you end up falling back to it.

I was also thinking about people relying on AUTO falling back to $_GET - 
whether they knew it or not.  If some change to AUTO meant we stuck with 
something different, that didn't work, then they'd want to be able to 
select _GET manually.

Alan
Ага, только в первом случае - прямой доступ, а во втором - посылка сообщения (если это работает так, как выглядит). И прямой доступ явно быстрее.
Используется магическое число '100'. Если в DNA будет больше или меньше элементов будет выход за границы массива.
This should be MIT. Also, those aren't the authors of this file :)
Check out `robot. usersForFuzzyName`. This would help normalize the receiver, like it'd work for someone thanking Josh or Josh Nichols.
This function enables contacts and all other CMS modules with no modification from master version (mysql). This is accomplished by fixing nulls of dates and numbers for SQL statements in database driver.
Do you have factories for these bros?
indent is 1 too much
On Epochs
Are we requiring django? Perhaps we should discuss this in #elasticutils.
Won't images files be served with a charset? (`Content-Type: image/jpeg; charset=utf-8`)
These ``raise`` calls should have a helpful error message, such as ``raise ValueError("The foobar is missing baz")``.
Added blank line between `@param` and `@return` as requested by @WouterJ .
Hmm, yeah - this was half because I didn't like the idea of having to time-format in order to derive filenames, and half because 90% of my instagram photos are 'untitled' and thus the title part wasn't useful. I wish EXIF tags were useful enough to serve this purpose.
use "addHeaders" instead of "plus" since plus is not set-add.
Also, method does not mention how it handles duplicates.
Not seeing the deprecation warning is probably because it's the second time you call `radon` in your interpreter session. It works fine for me.
There is a current bug in sympystats that you could fix here relatively easily by putting rate = sympify(rate) just above the _value_check

If a user types in 
Normal('mu', 'sigma') they don't currently get an error because, in python 'sigma'>0 == True

If you sympify 'sigma' first then the result becomes a relational and isn't True

This same opportunity exists several places.
Ja, mirá: http://momentjs.com/docs/#/manipulating/sod/
If we're not using puppet, is this line necessary?
There's no form on this page??
You should add braces
Even better ```if (isLiveMode())```
I agree, I just cannot compile this at this time as I'm using VS2012 and don't have easy access to other compiler for some time. I'll do it anyway and try to compile it on my server.
Shouldn't `options[:issue][field]` be `options[:issue][field.to_sym]`?
ಠ益ಠ
How about two nested if statements instead?
I think you should change the name of the method: it doesn't just wire the cache, it also starts it.
Because are constants (but private). Other filters use magic numbers. Is a bad idea to have raw numbers in the code, should hide them behind well-named constants. Anyway, if this is going to be a problem, I'll change them :)
It doesn't help overriding the __clone method in the FileAsset. doLoad clones the asset, runs it through the filters and then discards it.

Do you know some alternative way to do this?
Although… I would rather have `weak` :/… what's the thoughts on upgrading our build target? (@joshaber).
Please give me a few days to double-check some datasheets.
Why should it?  Python 2.x will see a statement that outputs a tuple.  (Sorry for the noise, the change came from master by accident.)
typo with the tense.
Well, the change adds several varying call signatures, of which this example is one. I take your point, though. I'll add this example too. I have actually already been playing with the first `tripcolor` example to visually test the migration of the `Axes3D.tricontour*` methods, so it won't be much effort to add it here.

I'm happy to use a colour map, but I would prefer not to encourage the use of `jet`. I'll happily use one of the others that prints well in black and white, or a divergent one. Perhaps `CMRMap` or `Spectral`? There are numerous reasons as to why the `jet` colour map should not be used. I don't think these reasons should be discussed here. There is a discussion on the mailing list about it if you are interested.

Thanks for taking the time to provide useful feedback! It's good to see these changes are appreciated, and it's better to see people help make these changes better.
What about something like

```ruby
results.is_a?(Array) ? results.first : results
```

I feels cleaner, wdyt ?
you have a method in base page that dose the same thing CrashStatsBasePage.page_heading
This is a method so needs `()`  on the end :)
Ну значит я не в тему описал.
Ну я за то что сейчас есть ))) вроде как оптимально пока ;)
Always returning an array for every header seems clunky to me.  Why not just return an array or string depending on if multiple headers of the same name were encountered?

```php
<?php
var_export($response->getHeaders());
array(
  'Content-Type' => 'text/html',
  'Set-Cookie' => array('foo', 'bar')
);
```
The same could apply for retrieving specific headers:
``$response->getHeader('Content-Type'); // "text/html"``
``$response->getHeader('Set-Cookie'); // array('foo', 'bar')``
Add a size attribute
Mistake! Folding this and :plugins back in via pull request now.
This is only nitpicking but I think there needs to be a space between the `;` and `i`.
"start and end"
Этот ```end``` относится к вышестоящему ```if```? Хорошо хоть тут текста всякого мало, ещё возможно разобрать что к чему относится и что закрывает, а вообще с отступами дружить надо)
Stray `#`?
Yes. It is possible for a database to not use a cache pool, even if one is present in a process.
This function jumps to err: before pool_name and cp are initialized, which is going to core dump on those paths.
Removed NotImplementedException, but kept using InvalidArgumentException, because otherwise there would be a strange failure for the user, when %d or %03d are used in the filenames, as Filelib didn't support multiple outputs per version. Maybe it's possible now with the File Resources? Generating large number of versions didn't seem like a good idea either.
start should be 1?
I'm not sure if this should have been `exports.require`, since that is `node`-specific, right?
Are you sure ``$this->any()`` has the correct type as "object<PHPUnit_Framework_MockObject_Matcher_AnyInvokedCount>" is not a sub-type of "object<PHPUnit_Framework_MockObject_Matcher_Invocation>"?
It didn't work with Windows Azure Table. It required HTTP 1.1, but that is buggy with streams (hangs randomly, and for infinite amounts).
no need to use ``else`` as you throw an exception.

and if it is mandatory, it should be an argument, not an option.
So a nil check is faster than a comparison? I think that makes sense. I can also see the constant, though I prefer IdStr or something like that instead. No biggie.
Good catch. I'll fix this in master right now.
How can this be undefined?
Do you really need this variable? Or could you simply pass everything as a parameter to `contributors.append`?
Hmm, this takes really long on my computer. Hmm.
What is Facebook link?
Put `"` around username output.
No need to have one long string you are creating (this is inefficient), but you can simply have a list of elements you add. See jQuery map function. You can map all contributors with function and then the results of the map add into contributors div.
OK, so you are also getting posts of correct type in the database (if you inspect them with `./manage.py shell`)?
so should i match all fields together to make them unique?
I don't really get the point here
So that upper if does not get triggered again.
Why you call `howManyColumns` every time in the loop?
Of course it works :)
I would just leave title as it is, `500 Internal Server Error`.
Hm, shouldn't this be done through RESTful API? Why we need separate view for this? We have RESTful API exactly for this. You should simply do a request through the API to add user to the list of hugs or runs. So RESTful API should allow for now just users to add hugs and runs for themselves. But for now you can simply allow everybody to manipulate that. And then we can close that down.
Effect 0: Id 11 (SPELL_EFFECT_BIND)
BasePoints = 1 to 7  Multiple = 1,00
Targets (0, 0) (NO_TARGET, NO_TARGET)

so i think there is no expl target, but i do some tests more
Add:

```sql
DELETE FROM `command` WHERE `name`='flusharenapoints';
```
Why the change from directly passing a context to pulling one off the ApplicationContext thing.  I think it makes sense to minimize the use of the latter except for when it's absolutely impossible.
Can't make an example here since this is your field of action, but we sure need to first show this functionality by using the hydrator only (without forms)
Can this be a comprehension? Map + lambda = ow, stylistically.
Pushed changes with >  and < not >= and <=.
good catch. it was a cut-n-paste error (from ThriftDeserializer.java).
OK. But as you use "_name" three lines above, and in case one day "_name" will be populated with other elements than only a `__name__.lower()`, maybe we should use "_name" also?
Is there a reason to check that node_name is not None? I would just remove this line, I think.
About those characters, right, thanks!

I'm not sure if it's worth special-casing these for tooltips as they will appear very rarely. But I can think of some other way of doing it.

Also, back on vacation with you! ;)
Think we mostly use Number when getting values form attributes.
Depending how often this gets called it would probably make sense to create for this list a constant.
We have prototype shortcuts, this could be written as `pivotIDs.extend(Object.keys(hash).filter(function(p){ return p.startswith(pivotID + "_"); }));`. 
(I'm not really reviewing and now I'm back on vacations.)
How bad are double class selectors performance wise ?
If it's really bad, let's switch to `.profiler-event-expandable`
Every time a programmer assumes a NULL pointer is a pointer with all bits zero, Dennis Ritchie spins in his grave.

I guess it doesn't matter because it's true on all architectures we care about (arm, x86) but still.
I'm not keen on calling these `lua_*` because it clashes with Lua proper. We've used `pi_lua_*` in the past, which might be more appropriate.
I would move this into a separate function, since you call it anyway from the other methods.

It will make it easier to write extensions, for example with zeroinflated negative binomial
Yeah I know.  I'll try it again.
font, b and u tags. I just did a little bit of sick in my mouth :(
I don't think there's any value to making `seedtime` inlineable; better to move the implementation to the source file, along with the `sys/time.h` include?  Maybe doesn't belong with this issue, but since so much other refactoring is happening here anyway...
Now that we have the `get` methods, I'd like to add tests where we create a profile with fwhm, say, then get its hlr from the getter, and test that the answer is write using radial_integrate.  Likewise the converse: create it with hlr, then test that the fwhm matches what you get from the xValue at (fwhm/2,0).  Same with any profiles that can be constructed from scale ratios.
by the way, I'm not sure why I did this in terms of SBGaussian rather than Gaussian.  Probably I should do the latter, or both.
remove the commented lines and you might need to change the url if the route changes on the backend
It is unclear what this function is supposed to do. Please add descriptive comments here or where the function is called.
It seems that the side effect of "./mmaloc/configure" is different than 
"cd mmalloc && ./configure".
For example, the file "./Makefile" is erased...

Thu, 4 Oct 2012 16:43:25 -0700, Thomas Gazagnaire :
>
> In packages/ancient.0.9.0/opam:
>
> > @@ -1,11 +1,13 @@
> >  opam-version: "1"
> >  maintainer: "contact@ocamlpro.com"
> >  build: [
> > -  ["ocaml" "str.cma" "unix.cma" "opam.ml" "chdir" "mmalloc" "./configure"]
> > +  ["sh" "-c" "cd mmalloc && ./configure"]
>
> Maybe |./mmaloc/configure| is simpler here ?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/OCamlPro/opam-repository/pull/105/files#r1768290>.
>
Just tested and the code runs fine if we revert line 175 to
if (typeof cfg.account === "object" && typeof cfg.account.homePage === "undefined" ){

Think I was being over zealous.
is oauth2 really only needed for development?
i tend to be conservative about adding dependencies -- seems this is used just for JmxConstants,
but brings in a whole bunch of other org.osgi classes.  (and they could cause conflicts e.g. running in an osgi-based appserver.)
better i think to copy them (maybe add a dependency in test scope which asserts equality).

apart from that, pull-req looks good, go ahead and merge when you're happy.
Best to avoid exclamation marks in error messages.
What about the literal "true" ?
seperate ->  separate
You can ignore this, as I've done this as part of PR 196 (which should be reviewed and merged first as per comment below).
Ah, actually you need the if still, missed the tr bit below:

    if rules[:sign_before_symbol] && self < 0
       formatted.tr!("-", "")
       sign = "-"
    end
Do this with one call to warning, or use the `use_prefix=False` option on warning.
Yes, good point. This escaped my cleanup of unnecessary calls to list.
Breaking change: Jobs need to be explicitly refreshed before they can be used.
Sorry I wasn't clear enough. Sure `short_open_tag` should be kept. My question was weather `ini_get('register_globals')` returns false. Then I could remove remove the `register_globals` requirement (see line 219) for PHP 5.4. So it doesn't check removed configs.
@stealth35 short_open_tag is still available in PHP 5.4, isn't it? It just returns an empty string in your configuration.
The real question is whether PHP 5.4 returns FALSE for directives that have been removed, e.g. `init_get('register_globals')`. Can you verify? Then I could exclude this requirement in this case.
Are you reversing back from the uuid support that you added then your previous commit was bigger it has changes in package.json and the changes impact other files too
All modules returned by find-dependency are loaded. How does it filter module TV not to load in mobile and load in TV? Is the idea that init handle that individually?
those 2 lines should probably be removed
Not actually used.  Just forgot to remove it.
If I change it to this, then it works as expected (and fails if I comment out the call)

```ruby
 describe ".recommend_deal" do
    it "sends POST to /emails/recommend_deal.json with params" do
      ActiveResource::Connection.any_instance.should_receive(:post).with(
        "/api/v2/emails/recommend_deal.json?deal_id=the-big-deal&emails%5B%5D=bar1%40example.com&emails%5B%5D=bar2%40example.com&message=Hello+World%21&user_id=foo%40example.com",
        "",
        {}
      )
      Galaxy::Email.recommend_deal(:user_id => "foo@example.com",
                                   :emails  => ["bar1@example.com", "bar2@example.com"],
                                   :deal_id => "the-big-deal",
                                   :message => "Hello World!"
      )
    end
  end
```

That could be refactored into some kind of helper method, like should_post_to_galaxy_with(url, body, headers)

It's interesting to me that it doesn't send a body and instead builds a huge query string.

I suppose this kind of thing could be tackled in some other pull request at some point.  ie, it'll probably never happen :/
Vector в однопоточном коде?
Вы сказали, что у меня непотокобезопасный класс, про Collections.synchronizedList написано "Returns a synchronized (thread-safe) list backed by the specified list"
is there something specific that needed to be cleared?
good post, but we are not 7 yet.
This style of storing locators in a list is not really one we would do. A locator specific to a page would be kept in that page's page object because it's only valid for that page. Any locators that are global to the submission process (ie they're valid for every step of the submission process) would be stored in this class. So these locators would be stored like the `_current_step` string in the classes.
You could merge these into the same wait
`until(lambda s: not self.is_element_present(*self._loading_balloon_locator) and self.selenium.execute_script('return jQuery.active == 0'))`

But the result is the same and glad we've found this solution, I thin the whole suite will be more stable now
Info: We lose the app prefix
I hate you @haus. :-)
Need to add the os.support bit
Thanks so much for taking the time. My original concern is that finding all the connected_components are time consuming and here we only need to check the connected components starting from one node. However, for simplicity, maybe it is a good idea to use the ``cs_connected_components`` :) (my implementation seems not efficient as well...)
You need to specify the full module for DecisionTreeClassifier for the link to work in the html docs :-/
I'm sorry I have just read your comment right now. Which are the **two** lines ?
I really love this!!!
Whoops, good catch. You're right, sorry :)
```add (.etc.sssd_conf.v, "domain/default")```
is duplicite and already elsewhere. I think it can be abstracted to own method to details.
I see there two options.
First is basic to just take that snippet and move it to own function. Second is more advanced and have method abstracted whole getting key ( so it can be used also in write function).
Something like this
```
list<string> sssd_key_in_domain ( string key )
{
  list <string> domain = add (.etc.sssd_conf.v, "domain/default"); //can ycp make it static, so it reused? does .etc.sssd_conf.v changed anytime?
  return add(domain, key );
}
```
as you can see in code is two unanswered question, one is related to ycp and second one is related to given domain if it can change.
`double- and single-quoted` was actually correct. But it is better to be clear. :)
src field should not go to both Src and Dst, or should it? Looked like typo.
Actually, I'd also like you to take a look at android/runtime/common/src/js/titanium.js where it does `Titanium.include = TiInclude;` and also look at the TiInclude function/comments/friends itself. They seem to be trying to handle the contexts within JavaScript itself by creating wrapper objects and storing the baseUrl. If we store the baseUrl in TiObject it could help things.
This isn't simple stuff :)
If the initialize is not called, I would prefer to miss logs (by checking against null-ness) rather than to make app crash
initialize needs to call setControl with the newly created native object.  That sets up the container and other relevant stuff in the NCO class.  Likely also accounts for the connect errors David was seeing in logs as in this case both the control_ and container_ in NCO are NULL.

setControl must always be called in initialize, other things that depend on this assumption are likely to break.
for no reason. I will improve the CreatePool command soon and change this as needed.
This is too large (and too private) for inline code in the header file. Use a cpp.
couldn't this be 'fromName'? .. with fromName set in the constructor, not in doRename()
Also, please run check.py
Multiple values can be specified.
I'd actually change this to return early if `empty($lang)` -- that way the body is not inside a conditional.
> For some reason, this code block isn't highlighted.

What do you mean ?
I wanted to run the test suite to make sure I didn't break anything and those stop() lines were preventing the suite from running. When I removed them, all the tests passed, so I left in the change. Please feel free to revert if necessary.
My understanding is that yes, for the most part it is and that this is needed to use newer versions of compass with Rails.
テストの方法は、 interactive (`M-x ert`) でやるのと batch でやる方法があるので、どちらでも起動出来るようにするべきだと思います。なので、この行は消すべきかと。
Could something be tucked in here so that if an equipped item has a passive power_mod it'll be activated?  Or would it make more sense to have the power added to the hero's statblock on equip/unequip, somewhere around here?  https://github.com/clintbellanger/flare-engine/blob/master/src/MenuInventory.cpp#L796
@ctweney I seem to pick up an unchecked assignment (for ldapTemplate.search()) , not the unchecked conversion in IDEA. I'll see about wrapping some kind of check somewhere
Yep, mistake. I realized it when I looked at the code before closing my editor. Moving too quick in an attempt to get out the door.
Can you add a custom message to this? I want to do this for now on for clearer failures.

Something like `"Package %s could not be found before the timeout" % name`
read carefully.
each instance has its own port. and there can only be 1 port per instance in Oracle.
instances.each loop handles that.
If a docstring doesn't fit onto one line, please start it on the line after the triple quote.
For each of these, there's no reason not to indicate specifically which constant to use.
do we maybe need to make the network interface configurable?
same thing here with height
I don't know if this is supported on Android, but iOS also supports the following, where R is a red hex number, G is a green hex number, B is a blue hex number, and A is an alpha hex number:

RRGGBB, #RGB, RGB, #AARRGGBB, AARRGGBB, #ARGB, ARGB

as well as searching for (r,g,b) and (r,g,b,a), where r, g, b are red/green/blue integers 0-255, and a is an alpha float 0-1.0 in order to be compatible with CSS color functions.
HTML5 doctype and remove xmlns
This will almost certainly cause problems if there is a child view that is implementing a horizontal layout of its own
dur = MAX(IMAGEVIEW_MIN_INTERVAL, dur)
might want a try...catch here for eval, since any number of problems could occur if the JS is corrupted, malformed, whatevs.
everybody loves wonka
What do you mean? Why compass could not be placed into the portlet css?
Brad/Wim actually have a great set of tests here in the Python/Java SDK. We should port their tests - they're along the lines of yours
«перетаскивание загружаемого»
EDIT: I realized you're getting rid of this as a signal handler and making it just another function. In that case we should just drop the variadic arguments as well.
as above, let's make this work with ranges of `ushort`
The formulation is really clear. Ok for me !!
Add Ghent University line, and add yourself, if this comes from you.
move to `rserve.py` module
言葉足らずで申し訳ありません。。
では、cofigureメソッドでチェックして、ダメな場合はerrorにしますね。
A few points:

* What happens if this collides?
* Can we synchronize the body and use a static counter to ensure uniqueness?
* Change name: `newLogFilename`?
This would probably be better factored out in some way — that is, pre-validate the `Command` that's input, or have a `CommandRunner` able to validate arg counts.
Style these margins in style.css instead of inline.
Probably should of said "Advanced options". As said in other comments, some of the options are useful.
Per the styleguide, I believe inter-function comments are always supposed to be a series of one-liners.
Should probably try to load all given records with id's from $attributes_collection instead. Would limit lookups to a single select.
Version 40000 is already taken, should be 40001
i guess we could dynamically determine the class name .. but that would be more or less the same. so i guess there is no way around this ..
this phpdoc is wrong. you should either use a FQCN (i.e. beginning with a ``\``) or use the shortname relying on the use statement. Currently, this will be resolved as ``FOS\UserBundle\Security\FOS\UserBundle\Model\UserManagerInterface``. (I would vote for the short name)
this should use omniauth's log method: `log :debug, "Inside..."`
I don't think this is future-proof what happens if there is a constructor added in 1.9 ?
Add this inside the labels object

```javascript
          formatter: function() {
              var numberOfAxisLabels = this.axis.categories.length;

              // If we end up excluding labels, we determine if there are an even or odd number of 
              // elements to we always end up displaying the right-most label
              var offset = numberOfAxisLabels % 2;
              var index = this.axis.categories.indexOf(this.value);

              if ((index+offset) % 2 == 0 && $(window).width() <= 500) {
                  return "";
              }
              else {
                  return this.value;
              }
          }
        },
```
I don't think this line is needed now.
typo: qdl
I don't really want to "delete" it. I am removing it from the local `waypoints` so I don't end up with a duplicate. The database code inserts it into the table with same id number, so it overwrites the old one (no need to delete it from database first).

However, if you think that is what it should be, I can change it.
I don't think so... If you are writting for the first time, the isChanged() method returns false, but you don't know if the value was previously read or not (from I know...)
Shouldn't this use "https://" instead of "git://" in case the user does not have git installed?  I don't know if it makes a difference.
For consistency, should this be stream_id?
Should be consistent with quoting or not quoting the object keys
@croby: I noticed a similar comment in a previous review as well, so wanted to follow up on this.
This is actually valid code. The way in which an or statement works in javascript, is that it stops evaluating the different statements until it finds the first one that passes. So if key is undefined, !key will be true. At that point, javascript will accept the statement and move into it, without throwing an error on the second statement.
let's add comparison with a runtime computed value
I cant't make the messageStoreRegion final since it will be created in the initializer if null
Looking at this some more, I don't see any reason for this to be a "static member" of ConnectionStringParser - just make it a top level function in the module.
BTW, you should put stuff like this in your globe .gitignore in your home directory.
This queues looks cool.

On 29. 09. 12, at 12:44, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/static/test_app/js/datastream.js:
> 
> > +            'lines': {
> > +                'lineWidth': 1
> > +            }
> > +        }
> > +    };
> > +
> > +    var flot_defaults = {
> > +        'url': datastream_location,
> > +        'datastream': null,
> > +        'from': null,
> > +        'to': null
> > +    };
> > +
> > +    function getMetricData(metric_id, granularity, from, to, callback) {
> > +        if (query_in_progress) {
> > +            setTimeout(function () { getMetricData(metric_id, granularity, from, to, callback); }, 40);
> This ... is very error prone. :-)
> 
> Maybe use jQuery queues?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
In this case, we can't be more specific -- the point is that he links to the scrypt extension, and then indicates that php.net does not officially support it at this time.
You mean the three examples below or the three scenarios in total?

Regarding the examples: they are not really needed, as there aren't any real edge cases I'd like to check for yet—I don't want to test the error message for blank names right now, as they're all defaults from the scaffold and might change pretty soon—so I can take them out again if you think that's cleaner. They're more of a reminder for me to flesh things out in the future.
Original post [here (for now)](http://imetchrischris.com/puppet_cloudinit_puppi.html)
Alternative headings to include would be Patch benefits and Feature benefits - since not all hack ideas will be an integration, I assume some will be fixing big bugs/annoyances or adding a feature to an extension or the core
This link seems to be broken (404)
you can get rid of the getter and setter of uuid -- it is provided by BaseOpenmrsData
Property names should be verbs and public members in C# code always start with capital letters.  So just call it "Coordinates".
Which brings me back to my original point (the first paragraph) we are not providing enough information in the schema on how to maintain/update the data.
Removed all polyline implementation to gmaps and openlayers
this is a recursive method call
I think the second one is more readable because it's a common convention to write the if statement in. You can have just `if` statements but you can't have just `else` statements. E.g.
if (typeof x === 'number') {
    x += '';
}
if (x === "42") {
}
I was belive that 'be_simple_i18n' are the normal behavior. 
When I rollback changes, I got the following error:

    Cannot load resource "@LoogaresUsuarioBundle/Resources/config/routing.yml". Make sure the "LoogaresUsuarioBundle" bundle is correctly registered and loaded in the application kernel class.

 And in the second step of the backtrace, i found

2. at Loader ->resolve ('@LoogaresUsuarioBundle/Resources/config/routing.yml', 'be_simple_i18n') 
in /home/falcacibar/Sources/loogares/vendor/symfony/src/Symfony/Component/Config/Loader/FileLoader.php at line 64

That's is, it was wrong?
ok, i think using this then should be better: PermissionMap::PERMISSION_VIEW, but maybe you can rename these constants to PemissionMap::VIEW and so on.
Doh, got it now.
Zalogowany
It's not related to JMS..
's/xmmload/xmmstore/'
import the specific functions/classes that you need (no import *)
I can test, and among other things see what the schema says and what roxie does.  Not sure how I feel about attributes in an untagged nested record float up to the parent, but might be better than dropping them as this would do... but lets see what precedent says.
The only concern is then that `DefaultWarpRuntime` does not cache calls to `ServiceLoader`.
Yeah, the unindented console.* commands are temporary debug (from the printf school of debugging/development) that should have been taken out.  I'll take them out!
Also see WebUtil.escapeQuotes(String)
Is it necessary to place all three constant values for each of the properties ?
chage it to ou as per @ericof recommendation...
implemented in  	af46f26
I can live without it, but you might be asked for this again in future if a customer asks for a simplified offline install mechanism (ie., w/o having to unpack the larger zip). 

Can you let me know when the new update sites are available, eg.:

http://download.jboss.org/drools/release/5.4.0.CR1/org.drools.updatesite
http://download.jboss.org/drools/release/5.3.2.Final/org.drools.updatesite
Agreed, I'll change this.
Действительно ())
Мда, ваша новая логика парсера становится все сложнее и запутаннее.
Не то, що раньше - одна функция, минимум условий.
Справится, но как мне кажется всё же лучше ему помочь.
conclusion here: the ``is_object`` check is useless
Aa.. looking at the Spring impl it's used to read e.g. SpringTransactionConfiguration annotation. I guess JTA would have a similar annotation that does JNDI lookup of the manager.
the client unit test should somehow have test to check that if upload is successful, the success callback should be triggered, and if upload fails, the fail callback should be triggered? you should mock the upload result to test both cases.