labofsahil/github-event-dataset-2012 huggingface dataset:
Missing a punctuation mark or this is at least confusing.  Specifically, I don't understand if it's saying I should never call call refresh, or whether it's general advice that is somewhat misplaced (and where calling refresh() is what will doom my mutations made against this advice.)
Totes fine.
can we set the message as 'Facebook: Error while refreshing list. Closing FB Import' and not to mention FTU?
The onclick won't be override by other functions, why do we need use addEventListener instead of onclick? Just curious, :-)
Cool! we need to add a `activityRequest = null` when we `postError` or `postResult` no?
Keep the ellipsis argument at the end?
Thanks Henrik.   I did similar change when working on dropbox.
Maybe just call OnBeforeWrite instead
`PHP Data Objects` (it's plural)
#boot_checkin changed to take an options hash
Is it necessary to use `#send` here if the object responds to `#relation`?
Why did you use "" + n rather than n.toString

Also, why are you using strings at all here?  It looks like you are generating something that should be:

```scala
val pipe = IterableSource( (x._2 + 1 to n), x._1 ).read
```

Also, ```pipe``` is a bad name. Can you name it, val kUpToNPipe or something?
Hadn't thought about this.
"The input file where the secret should be read from."
The brace should be on the prev line
Just what flows by on my github stream. Too many commits to follow them all ;)
@zml2008 left that there I believe.
I'll get rid of it for now and put it back in if I have time. In the grand scheme of things, it seems pushd/popd is vastly more useful anyhow.
@chuanchang  Now the pylint tool in autotest works. :p
Acutally I don't think make up a dict in test has any problem.
I think you want `len(..)` here?
We do interpolate against a `defaultdict` in `__init__`, so we do catch these errors at config time.
This check is done for every element in collection. I propose to cache the result before the loop.
I think it is because you didn't synchronize your codes before doing the modification.
@Seldaek shouldn't you use only the locked repository (and the platform one) when installing from lock ?
nope, I actually need to specify a regular expression as a search token.
Thanks! I've done this. Will update the PR in a bit.
Why is this manifestEntries needed? assembly-guvnor-jboss-as-7_0.xml didn't need this, we don't use hibernate in guvnor IIRC and it makes the build more complex. So unless there's a good reason, I 'd like to get rid of this part?
Jump targets has to be aligned. Guess it's same with x86 model.
[Gilt Groupe](http://gilt.com/) はBackbone.jsを利用し、関連サイトを含む複数のアプリケーションの構築を行いました。[Giltのモバイルサイト](http://m.gilt.com/)では、Backboneと[Zepto.js](http://zeptojs.com/)を用いて、出先のユーザーに対して、超高速なショッピング体験を提供していて、[Gilt Live](http://live.gilt.com/)では顧客がリアルタイムに購入している商品をBackboneとWebSocketsを結合して表示しています。Giltの検索機能もBackboneを用いて、フィルターや商品の並び替えをクライアントサイドで行うことで効率的に行えるようにしています。
ditto re: "str" and "set"
Same basic review on this plugin as your input plugin. Documentation comments, some style fixes, etc.
But why **copy** it's not a copy copy would be `state.observers.slice()` this is just a reference with a confusing name. I'd go for `observers` instead.
For the same reason that forces us to have a buildstep. I thought that it was important to build and use cfx-js as a 100% regular SDK addon. This `command-line-handler.js` component just fakes `AddonManager` action. It is like having cfx-js.xpi installed in this xulrunner app. Note that no other component other have access to addon's bootstrap.js. So no other startup event can be fired to it.
I could have just use AddonManager API in order to install/run the addon. Then I'd not have been able to change the reason code.

In term of dogfooding, it is quite important to avoid using any different path from regular addons. In this particular case, I don't see why running an addon from xulrunner (instead of firefox) should change the startup reason code ? What would be this startup code ? `command-line-startup` ?

I may see your point. You want to do different actions during bootstrap based on the platform, then I'm not sure reason code should be used for that. We may prefer application id or something else.
I have no qualms naming the config param `locale`.  I only made this change because we no longer use the locale/ directory in our software (where the `.po`s and `.mo`s live).  

What's your preference?
I think the issue is the # of writes, 5 doesn't address that, right?
Nit: use spaces not a tab.
leave out the saja
better regular expression to use:
``` ruby
/\Aimage (.+)/
```
that way `img_str` will never be `""` :)
Great! I had not thought of it. Do you think we should give the possibility to enable auto validation also via schema.xml? I.e.:

``` <parameter name="auto_validate" value="true" />```
@vrthra also, `split("\n")`
Same here, I don't like it, but I don't have better ideas either :)
CacheAdapter|null
@Maks3w um, this is correct -- we discussed it in IRC. We want to test if the name is empty but not a 0. There are many flavors of empty, and '' is only one.
You might take a look at how the new `acceptedViewModel` plugin works -- you pass it a list of Accept media types you want to match. We could do similarly here, but instead have those in a protected member so that developers could specify them themselves:
```php
class MyResource extends AbstractRestfulController
{
    protected $jsonContentTypes = array(
        'application/vnd.myapp.resource+json',
        'application/json',
    );
}
```
The code would then check the Content-Type header value against each of these; if any match, it does the decoding.
This is obviously wrong, and I've amended the commit, but sadly the new version isn't shown because this pull request is closed.
perhaps sed -i -e s/stuff/things/ .hgrc
"there" was correct.
It was  incosistency from old version, chosen lowercased for all.
Can't this be done using a regex?
No. So I've missed the fact that this means the "auto-submit" behaviour will be lost, right?
i get the sense you did not actually test this commit since the has interface is not defined until after this line :)
This is wrong. Keeping the old class without keeping its behavior is not a BC layer. It should extend from the StaticPHPDriver from Common.
this is pretty ambiguous anyway, quoting makes more sense
I have a full implementation of this function on my ogre branch (should have asked you to use that branch,  really...).  I'll try to merge it today.  But I don't think we want this version of glGetIntegerv.
Nit: `SubFactory` should come before `lazy_attribute`.
Maybe, but I don't think we'll ever need to send anything but a bogus P3P header given that it's almost defunct.
Just because every now and then we create users other ways. (i.e. through the pthon repl) and this method makes sure it always happens.
Or it may not be named `form`. Bummer.
derp. ignore this.
Are you sure this should be reversed?

I worry this was here to make sure if the currently indexed track event is removed, we are not forced to scrub forward and back to be able to get the proper index.
I'm too slow... Anyway - recommend using http://jsonlint.org/ when authoring json, it's a life saver :D
This should probably be handled via a class in style.css instead of the style attribute on the element directly.
You can't set to nil in the UI, but people keep messing with their databases ;)

That form is much neater though, I'll add it in my fix-tests PR that's just coming.
Will take a look at that. Off the top of my head events to fire events may create a race condition, but maybe not.
I dunno.. in theory to be consistent the "question" should always be bolded. I'm not sure the numbers *have* to stand out
I think using a custom answer will be a lot easier than this. We generally like to avoid adding answer types, just because it's more code to maintain. I'll find a good example for custom.
returning different values based on params seems it could cause confusion.
I vote to remove the `else { return this; }` block. Also, add some white space around the if block to look like the rest of the file.

`if (callback) {`
版本号有 publish的人修改。
This should be part of an other pull request, I guess. However, as ospf capability pull request has already been accepted, there is no need to split this one in two.
You're so right. I must have made a typo when I tested the isset on the null value. I've updated the commit now. Thanks for the input
Please in future avoid reformatting together with functional changes. This complicates review and complicates historical analysis.
Total 16 :-)
Are we sure that IOException is the only kind of exception that we can get from clj-http.client?  I suppose anything else will bubble up to the global uncaught handler.

Also, do we want to log something if we catch the exception, rather than just swallowing it?  We could log it at TRACE or something, so that people won't even see it at DEBUG.

It's probably harmless in this case, but in general, catching and swallowing exceptions makes me nervous.
ah, crap, i need to update these docs to reflect that it's not returning json anymore.
It's not clear if this should be a date object, millis since the epoch?
What is the significance of the key on these hash elements (`me`, `devme`...)? Could this instead be an array instead of a hash?
Yes, but that sits in oae-authz.
The idea is that oae-tests/rest/ eventually moves into it's own module 'oae-rest' and that we don't have any dependencies on our modules.
Not sure if we should allow for getAll through the REST Util/API.
One space too many after `@param`
Chapter 5 of the new UG
Similarly, there are helper methods in MarkPad to ensure that an implicit cast does not throw an exception when it has a null result:

```
(DataContext as DocumentViewModel).ExecuteSafely(vm => wb.LoadHTML(vm.Render));
```
здесь проверка на недопустимое значение, а 0 допустим. Если поставить <1 будет не корректно.
Спасибо, не знал
maybe use constants to avoid the chance of the typos being introduced.
That was the decision we made to simplify mobilizing the skin - for the 
time being, all new skin changes go into main.css. That said, looking at 
this... it seems as though this could be implemented better. There's no 
good reason to return 'main.css' both if the try succeeds and fails.
As mentioned above, this function should not be needed.
Just added to the wiki:

https://github.com/applicake/doorkeeper/wiki/Using-Resource-Owner-Password-Credentials-flow
Why even bother with a var? assert.isNull(analyzer.match....)
yes :) 

It appears that the git read-only protocol correctly fetches the expected references. I will update the expected results with the correct expected results. This means that the git read-only protocol will pass while http / https will fail.
Do you mean each JUnit class or each individual test method?

I consider each method annotated with @Test to be a test case contained within a fixture (class).  The data seems to be persisting in between each method/test which is bad practice as the tests become order dependent and cannot be tested an an individual basis.

I'd like to recreate the concept dictionary just for my test so that I can have confidence in the code that I've written.
Also, I'm using the convention from all the samples I saw:
http://nodejs.org/api/stream.html#stream_stream_pipe_destination_options
This zstyle is no longer valid.
Add a string here "name" so that we can debug the output.
I had thought 64
Change the case to be:

    Adding additional Attributes on Tags

The rough rule is to capitalize nouns.
I think this should be moved down into the `Services & Configuration` section, because the order of how the bundles are registered is only important in just a few cases.
要不全部用“指定”
要不全部用“设定”
已删
Drop the whitespace after parens, please.
_setSimultaneousAccepts is not needed for a connection socket
Needed to add directory snapshotting to main site-generation function since its execution is now non-deterministic. (B/c it's used as a directory-modification callback.)
I just copied this from the other mailboxes, none of them passes the config to the constructor. I was already wondering, why it is passed in every time. Is this really necessary? The config is only read in the AMQPBasedMailboxSettings class.
Added a cache variable
Потому что он не отдает максимальную громкость.
точки для лохов
Sí, en la carpeta Libs mantenemos la copia, y el proyecto se distribuye con todo. No creo que en la versión que se está ejecutando necesite ser visible.
On keeping naming patterns consistent in SMF? Always! (ask @Spuds :laughing: )
effectue les tests chez toi, ca ne passe pas, alors
Check filename
@icedfish 你里面从来没有 isset过 $argv[2] 所以我臆测$argv 的 count 至少应该是3？
Have you seen how we've done this in other places? i.e. https://github.com/clayallsopp/formotion/blob/master/lib/formotion/row_type/slider_row.rb#L31 (swizzle is something I added, not a real thing https://github.com/clayallsopp/formotion/blob/master/lib/formotion/patch/object.rb)

I'm not sure which way is better (subclass vs instance eval). thoughts?
Actually, we could call start/2 with the arguments variable, but I would suggest doing it the following way:

`erlang:apply(statsd, start, Args)`

This way, you could call it without any parameters at all, with only a host, or with both, host and port from the apps. file like this:

`{ mod, { statsd_app, [] } }`
`{ mod, { statsd_app, ["localhost"] } }`
`{ mod, { statsd_app, ["localhost", 8125] } }`

It's closest to the public API of your client.
I'll see what stock configs look like etc.

On Wed, Sep 12, 2012 at 11:05 AM, Peter Feiner <peter@gridcentric.ca> wrote:

> but /var/lib/libvirt/qemu might not exist, might have messed up
> permissions (777, root owns), etc.
>
>
> On Wed, Sep 12, 2012 at 11:05 AM, Andres Lagar-Cavilla <
> notifications@github.com> wrote:
>
>> In packagers/deb/nova-compute-gridcentric/DEBIAN/postinst:
>>
>> > +        chown(os.path.join(mount.path, 'vms'), uid, gid)
>> > +        if mode != None:
>> > +            chmod(os.path.join(mount.path, 'vms'), mode & 0666)
>> > +        chown(mount.path, uid, gid)
>> > +        if mode != None:
>> > +            chmod(mount.path, mode)
>> > +    except OSError, e:
>> > +        # If the mountpoint doesn't exist or it isn't mounted, that's okay.
>> > +        # We don't want the package installation to fail because somebody
>> > +        # has bad /etc/fstab entries.
>> > +        if e.errno != errno.ENOENT:
>> > +            raise
>> > +
>> > +def main():
>> > +    try:
>> > +        passwd = pwd.getpwnam('libvirt-qemu')
>>
>> I'd say screw qemu.conf. /var/lib/libvirt/qemu is practice, qemu.conf is
>> theory.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/gridcentric/openstack/pull/144/files#r1587944>.
>>
>>
>
>
I think there is a serialize method or something on these
Tämä menee mukavasti `take` ja `drop` funktioita käyttäen.
You're using implicits here to convert members to a Scala map and detect the getOrElse() method.

getOrElse is very handy if you want to inject a function to do in the else, i.e.

getOrElse(address, println("boo...."))

From bytecode generation perspective, it's much simpler and will perform better if you just do:

    val serverAddress = members.get()
    if (serverAddress != nulll)
    ....

No implicits, no anything. Plain java call :)
Both would work really; invoking the command through the interceptor chain would be more explicit I think and would make the code a bit easier to read as  inboundInvocationHandler.handle does some other things as well.
This is on an internal adapter class though - so I'm not too concerned
about this.  We can reduce visibility of this adapter if you think there is
any risk of anyone using it as a publicly reusable component ...

On 23 April 2012 15:54, Sanne Grinovero <
reply@reply.github.com
> wrote:

> > +         return flags;
> > +      else {
> > +         EnumSet<Flag> ctxFlags = tcc.getTreeContext().getFlags();
> > +         if (!ctxFlags.isEmpty()) {
> > +            EnumSet<Flag> copy = ctxFlags.clone();
> > +            copy.addAll(flags);
> > +            return copy;
> > +         } else {
> > +            return flags;
> > +         }
> > +      }
> > +   }
> > +
> > +   @Override
> > +   public AdvancedCache<K, V> withFlags(Flag... flags) {
> > +      this.flags.addAll(Arrays.asList(flags));
>
> This is violating the API: `withFlags` is documented as to not change the
> Cache it is invoked on but that changes need to be invoked on the returned
> Cache.
> Hence I would not expect it to change the current Cache..
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/infinispan/infinispan/pull/1081/files#r720785
>



-- 
Manik

Sent from my iPad 4 beta 3 with a telekinetic keyboard
Yes, easy to check that with a debugger.
The instance used is of type GenericTransactionManagerLookup. And GTML is not thread safe as it sets the value of lookupDone to false in one thread *before* actually finishing the lookup (race condition)
Look at the [logic in ``compile``](https://github.com/kriswallsmith/assetic/blob/master/src/Assetic/Extension/Twig/AsseticNode.php#L49): the compile code uses the config param when the Twig tag does not force a value. ``{% stylesheets debug=true`` will always take precedence over the config (as the config is global whereas the attribute is specific to the tag)
Style: `transferProgressCallback`, and please write out `prog` as `progress` for clarity (Objective-C is intentionally a very verbose language!)
Did anyone have any better ways of doing this rather than splitting up of ```new_figure_manager``` (which I still need to do for all of the backends)? It seems like a pattern that would pop up frequently if one were producing Figures without the ```plt.figure``` function, so I am surprised I couldn't find anything to "attach" a pre-created figure to the Gcf (and let it take care of making the manager for me).
We may decide that it will aid debugging if this is uncommented....
Just looking at this diff, it seems very odd to be calling an external script here--it makes it appear as if this script will be called, and will pop up a window, every time a figure is made with Tk on OS X.  I presume this isn't actually the case...
Isn't 30 seconds a bit long? Maybe 10 seconds?
Do we have all possible forms of whitespace in the XML? I am a little bit restricted in terms of viewing this diff, so if we already have spaces, \r, \n etc. ignore this comment.
Good point! I'm not a Chef Solo user myself, so that limitation did not cross my mind at the time. `search` is definitely a no-op in Chef Solo, I guess some kind of workaround is needed to get that working.

The big win here is that a new node with the same cluster name will be added to the cluster automatically. For my setup, I have a role `percona_cluster` that adds the cluster recipe to the nodes run list and sets the cluster name. When I assign this role to a new machine, it will install Percona Cluster and automatically join the cluster. Galera will handle initial sync, so there's no manual work involved.

I suppose you could use data bags to maintain clusters (probably something simple like a hash of cluster names and arrays with their nodes), but then you would have to update that data bag when you add new nodes. I guess it's mostly a matter of taste, I tend to use roles and search for most things to avoid manual labor.
Will the `complete` variable ever be anything other than 0 or 1? It seems to me that element_end will get called many times where `complete` will be 0 after the first `</when>` (or whatever other tags might appear in the KML), and then it will be 1 after the first `</gx:coord>` rounds it off, resulting in the arrays being slashed and `complete` going back to 0.

If this is the case then the following for loop is a bit wasteful, as it will only run the one time.
@bp323 I added this because if the template is ran with `append = true` then there is already content listed, and the `{else}` block shouldn't be displayed because it'll say no content has been collected (when it previously has).
@zathomas  In my (failed) attempt to fix this bug I wrote some code that attempts to make sure the node's parent is a sakaidoc before migrating. That way we don't over-eagerly migrate nodes with a "page" property (pretty common label) that aren't sakaidocs. 

Here's the commit for that code -- see DocMigrator.isPageNode(): 
https://github.com/ctweney/nakamura/commit/cf29c5e43e105cb82ad8e3f9c78b11e3f604cf5b
please use shogun's CTime class to do these measurements..
I am not going to use margin-top, -bottom, -left, and -right, when the compacted "margin" property takes the values I intended =) (in this case, top/bottom will really be pixels, because we had to do pixel placement, but the left/right margin is em because horizontal placement is based on text)
Yea keep it is as is
I couldn't figure out why we're clearing the WT_BTREE_NO_EVICTION flag here... any ideas?  I just tossed it, but I could be wrong.
`UIWebView`
Should you be closing the connection as well? What happens if the caller attempts to execute query after closing the prepstmt
`if value` is not the same as `if value.present?` since `#present?` is the equivalent of `! value.blank?`. Is it okay if we allow empty strings here?
please try not to comment things out unnecessarily, if it isn't required, just get rid of it
Let's not abbreviate. Call it SortDirection.
No need for this anymore, we can see from comment being shown, that comment has been posted.
Anyway, you could also do:

```
$("#userlist li:contains(' + data.value.message + ')').remove();
```
Check `BasePanel` class. You should define dependency on map panel.
Do you really need to create a tuple? Why not just pass `twitter_auth.access_token`?
Something like (with old code):

```
var created_time_diff = (new Date().getTime() - new Date(Date.parse(post_date)).getTime())/1000/60; /// Converting milliseconds to minutes

if (created_time_diff < 2) { // minutes

else if (created_time_diff >= 60*24) { // 24 hours, 1 day
```
formatting, i need to revert it to previous commit.
Don't reuse same function for two different function calls. Define another function.
This `}` should be aligned with `request_sign`.
For adding CSS class there is a special jQuery function.
Remove this TODO. :-)
git whined about trailing whitespace here.
A test for the credential `present?` change?
150 here, isn't it ?
Yes, you are probably right. 
Furthermore I realised right now,  that also the AS keyword is optional (actually the currently implementation of stripAliases is incomplete too in this regard).
Hmm -- as they are apparently unused, and potentially confusing, perhaps `next()` and `prev()` should simply be removed.
Cool.  I wanted to put it in util, but at first I wasn't sure about piggybank classes depending on util classes (but now see that some others do).
Wouldn't that be a bad idea to leave it as `None`?

```
>>> input_str=None
>>> input_str.encode('utf8')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'NoneType' object has no attribute 'encode'
```
@cfirth1005 , can't we a node_load() here without reseting it? If so we can have ``node_load_multiple()`` before the ``foreach()`` so all nodes are fetched from DB in once call
Doing this in CSS would add two class names ( one for prefix ellipsis, one for suffix ellipsis ). Not sure what's best.

Lighter markup and CSS *or* heavier but more "semantic" CSS and markup
You can do it in the init_process callback of this module. We have added such a callback in the NgxFetch pull requset, you can see it as an example: https://github.com/pagespeed/ngx_pagespeed/pull/24/files#L3R1400
This should be per-server block.  I see how to save context for a request (ngx_http_set_ctx) but I don't see how to do the same thing for a server block.
Seems like this should be raised into PSOL
Doesn't look exactly the same as the constructor. Comment bug, or should this and the constructor code be shifted out to a helper method?
Perfect fine @philss !

Can you change this on this pull request as soon as you have access?
love what you did here

/cc @rsanheim-org
Can probably just delete these. I find a lot of these warning comments bothersome because they stay in the docs even when they're no longer true.
$str = '全角ＡＢＣ半角ｶﾅababa①baa'; // this is UTF-8 string
$encoded = mb_convert_encoding($str, 'SJIS-win', 'utf-8'); // convert to SJIS-win

// NG
$result = iconv('SJIS-win', 'utf-8',  $encoded); 
var_dump($result); // output bool(false)
// OK
$result = mb_convert_encoding($encoded, 'utf-8', 'SJIS-win'); 
var_dump($result); // output "全角ＡＢＣ半角ｶﾅababa①baa"
This breaks the datagram creation, no packet ever goes out.
This is a relic of an old syntax that we don't use anymore.   That parameter should be removed.
In some class, I also allowed interpolant to be an Interpolant1D, from which an InterpolantXY would automatically be created.  This allows for a somewhat simpler calling mechanism.
First mention of Great10, give citations / links?  (likewise for the yaml, json version of demo10)
There's a way to do this in 3 lines, and which is likely to be faster if `ntiles` is large (`for` loops being slow in Python).  As an example with `ntiles = 5`:
```
>>> iy, ix = numpy.meshgrid(numpy.arange(ntiles, dtype=int), numpy.arange(ntiles, dtype=int))
>>> iy = (iy.flatten()).tolist()
>>> ix = (ix.flatten()).tolist()
```
then as proof:
```
>>> ix
[0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 2, 2, 2, 2, 2, 3, 3, 3, 3, 3, 4, 4, 4, 4, 4]
>>> iy
[0, 1, 2, 3, 4, 0, 1, 2, 3, 4, 0, 1, 2, 3, 4, 0, 1, 2, 3, 4, 0, 1, 2, 3, 4]
```

Now, whether or not we want to use the routines above in a pedagogical demo script is not clear to me at all, in fact I think not.  But I wanted to flag this for info as all the numpy calls will be done in C/Fortran and thus much faster (Jim / Joe / Peter might have even more efficient ways to suggest!)
Is that really the best way to error out of a manage command?  Seems violent, but then again, maybe that's the best way to actually get a non-zero return code out.
also, why is the value for each item in `level2_items` a `str` while the value for each item in `level1_items` is a number?
Test methods are getting overly complicated. In a subsequent pull request, it's worth separating out functionality into individual tests where possible. And to create helper methods to reduce test size.

Will merge as-is, and I'll take a look at simplifying the tests later.
Think about context for someone looking at the log (e.g. what is the thread doing that just logged this message?). Perhaps better to say:
"Launched application; now blocking to wait for cntrl-c or kill"
The M2 archive unpacks to a ```brooklyn``` directory unfortunately (no version name).

We will get this in M3. The changes are [already in master](https://github.com/brooklyncentral/brooklyn/pull/246).
Is there not one too many `rescue`s here?
Fixed in 81f1061b16e15b638bac37e5ff0cc71f9c7b6927.
is it needed here ? This is an object so it should always be assigned by reference, no ?
`if (null === $this->property && !$this->repository instanceof UserProviderInterface)` if my repository implements UserProviderInterface i would always want my repository to be called.
nit: why is |tail| declare here instead of inside the split function
You are missing whole point of using torso as base icon.
If you use it you do NOT NEED TO REMOVE LIMBS.
Looks like the method below could be final?
This is now a sync test so doesn't need to go through the `.run` mechanism.
А не будет ли тут исключения?
I think I'm going to leave off the new/get prefixes.
I started with 'new' to reflect "new Target", but it doesn't work with plurals because it infers a single new thing, and this returns several things, hence I switched to 'get'.

My current thinking:
* TargetFactory.forTab(tab)
* TargetFactory.forTab(connection, tabId)
* TargetFactory.forAllTabs()
* TargetFactory.forAllTabs(connection)
* TargetFactory.forWindow(chromeWindow)
* TargetFactory.forWindow(connection, tabId)
* TargetFactory.forAllWindows()
* TargetFactory.forAllWindows(connection)
This is just from contrib.comments with the formatting changed to 2.6. If it's good enough for django, it should be good enough for us, right? ;) But, yeah, I'll use `trucate_words`. Thanks.
"Red Hat password"
Unnecessary? The threshold has already been checked, right?
Alternatively, if this is just for an example you could write a new dataset loader that fetches the data with a HTTP query and the cache it locally like this is done for the 20 newsgroups dataset.

Alternatively, ask the author for the permission to put it on http::/mldata.org and use the generic mldata loader of scikit-learn in your example script.

Tests on the other hand should not depend on the availability of a network connection to run.
2 lines before functions

at least with my version of pep8
Only the public function calls this, and only after constructing all the needed arguments.
I could, but then I'd have to use the `minlength` parameter, thus:

    np.bincount(pi, weights[i], minlength=self._classes.size)

The problem is that `minlength` was introduced in NumPy 1.6.0, so it's too recent for what we're supporting. One approach would be:

    np.bincount(np.append(pi, np.arange(self._classes.size)), np.append(weights[i], np.zeros(self._classes.size)))

which basically adds the whole range of classes, but weighted with 0.0 so they have no impact beside making sure the returned array is `self._classes.size` long. Though I'm not sure this is more efficient or less kludgy than the loop in the original code I submitted.

Or I'd be happy to submit a wrapper in `utils/fixes.py` around `bincount` (like we have for `unique`).
Oui, très bien dans ce cas.
Yes, you're right, but that gives clear vision where from that function comes.
See the discussion from many weeks ago on aerogear-dev ;-) (not my fault you guys don't process pulls quickly :-p)

Anyway, I purposefully did this as a separate commit, so you can easily remove it if you don't want it.
move this to the node definition so we don't require yourkit for the oae module.
(That doesn't mean they shouldn't be here)
I'm not sure that caching it is (a) necessary or (b) correct. clusternames.tos() may not return the same value every time this is called.
This is not only for display. The UI will allow a user to check some files from the list and use the add/remove button to add/remove them to/from superfile.
I'm not sure what to do here. The previous behaviour would have returned ```getQueryDll``` even if the name was empty, which doesn't make much sense. However, that's more robust, unless it's clearly an error, in which case, the assert makes more sense.
not withstanding the comments in DeleteLogicalFile, isn't this too early to lookup in the transaction?
Sorry, I too think it should be in prepare. I'm changing.
"implementers" is misspelled. Should be "implementors".
Since you're on this file: not sure if the intention is to have a Date object, but I would recommend Date.now() if you choose to store it as a number
Was explained in the commit, soz.

The reason is /trends.json resource no longer exists at search,twitter,com endpoint.

https://dev.twitter.com/blog/changing-trends-api
ca me parait tres verbeux tout ça... Tu n'as pas des mixins compass pour t'aider?
Did you comment it out for testing? I think all these cmds need to be released in the end.
was global
I'm assuming teams have their competition/best bot as "XXX" and any practice/extra bots as "XXXB". So the bot submitted under their original team number is linked with the team's actual performance. Does that make sense?
I _think_ this doesn't inherit from `ApplicationDecorator` because `Person` in liskov doesn't inherit from ActiveRecord::Base and I am guessing that broke something in draper. @wicz @geihsler is that right?
Are these state numbers meant to be the same?
Bad Author field
Ups, I forgot to put again the execution phase definition. I removed it in order to make maven2 work with this version.
oops .. fixed
Hi Gabe,

My apologies for the reply that took so long.

The whole block begins with
[:greater_than, :greater_than_or_equal_to].product([:less_than_or_equal_to, :less_than])
and that creates all possible combinations of these two arrays. Next,

I call two methods.
validate_numericality_of(:attr).send(parameters.first, 0).send(parameters.last, 10)
First method's name is taken from the first array, that contains methods with :greater.
Second method's name is taken from the second array, that contains methods with :less_than.

As long as :greater than 0 and :less_than 10 don't break any logic, exactly those values are passed to the aforementioned methods.
Thus, those methods will create records about value of this validation and message for it.

Next, I call method named description, it generates the message about allowed values based on stored data from previous methods, and compares all this to
"allow numeric values #{parameters.first} 0, #{parameters.last} 10 for attr"
by what we check if the messages we show are correct (based on validation methods we use).

I hope this description will be sufficient for you. Let me know if there's anything I can help with.
I originally preferred the variable ntest, ntrain approach, like you suggest.   But, on the other hand, it might be good to have "standard" splits.  I've occasionally heard @zstone and @davidcox talking about standard 90/10 splits.  Of course, we COULD make them variables and then just set defaults.   I think it depends on how the creators of this dataset intended to be used -- @npinto, you and @zstone worked on this together (?) so if you think giving people guidance that suggests that non-standard-sized splits are "OK", then that seems fine to me.
Hmm.  I doubt it is buggy.  In fact, I might even use it elsewhere.  The best move might be just not have `OfMaterial` versions and put those lines right into `czm_phong`.
Clerkenwell
This description appears to be inconsistent with the text in the main package description, which suggests that creating a new contact will *implictly* convert changes, without requiring a call to `save`.

If may be that there is something missing here, but as written, these two items seem to contradict one another.
Should use TiConvert.toString(value) here and also in KrollProxy.java
I meant that because you made the type ````Function(sourceId)```` in your output you know see ````Function(sourceId)(sourceId: String)````. I would prefer it to just have type ````Function```` and that way it wouldn't have two sets of brackets.
I migth be doing something wrong here and possilby just need to get this informatino trought tc.get_variable("MPI_TYPE") ???
Could you line this arrow up please? Also, line 62? Thanks.
Probably want to remove your console.log statements here and two lines down if it's working now.
@sigmundch - we should probably use Uri.isAbsolute here instead of whitelisting certain URI schemes.
http://api.dartlang.org/docs/bleeding_edge/dart_uri/Uri.html
You need a configure step where you check if boost is loaded, since it will not build without boost.
`if not get_software_root("Boost"): fail`
Maybe try to make the comparison to the previous method stronger?
`ifUnmodifiedSince` is used to generate the `X-If-Unmodified-Since` header, so it expects milliseconds, not seconds.
How about:
* not complete
* not well-documented
We might want to consider adding a "@cd" decorator so that we don't miss any of these locations and inadvertently kill a submodule or somesuch.
in Express I called it "trust proxy" I think, that sounds kinda weird though actually `.enable('trust proxy')`.. hmm..
header comment missing
You don't need the return.
this is more maintainable if you use the g(path) pattern instead of putting the text in the field.
This drops support for [Python < 2.6](http://docs.python.org/whatsnew/2.6.html#pep-3110-exception-handling-changes). No problem so far. Just saying.
@boegel  confirm this was a typo in patch filename
Hm... Du musst dich nicht dagegen schützen, dass jemand einen anderen Wert rein schreibt! Du Programmierst ja alles selber... und wirst es somit schon richtig machen.
Die Konstanten dienen als Hilfe, es richtig zu machen!

Statt 
  $member->setRole('boss');

schreibst du nun 
  $member->setRole(Member::BOSS);

Das hat mehrerer Vorteile
1) Eclipse kennt die Konstanten und schlägt dir diese vor (du musst also nicht nachsehen, welches gültige Rollen sind)
2) Du verschreibst dich nicht... denn wenn du den String selber setzt, dann sind 'boss', 'Boss' und 'BOSS' 3 verschiedene Rollen.

Siehst du den Punkt? 
Ich denke doch.... ;)
Kleinigkeit; Aber Repo-Methode heissen FIND.
zb FindByState();
Extra spaces after ```\``` and ```$``` here.
Can we just use `overflow:auto` on the container instead of adding these in everywhere?
> You should probably add a bunch of `/// ditto`s here.

Oops, yea, good catch. Another one for the list of "things I'll manage to 
forget *every single time*" ;)
OK, I'll rewrite thing to get shorter lines/

I'll add a comment here about the offset trick, one is already present in the function the code jump to. I agree this is not trivial and is important to mention.
see above regarding TemporaryQueue
Can you explain further? I just ran a build with ${buildDir} against my local sonar server and it seemed to work just fine - what error should I be looking for?
Exactly how I feel. I had no idea which was the "best" one so I chose the first one that popped up on google.
I'd suggest to replace 'input' with 'input element', and the plural part in plural.
Let's change the delimiter to something unlikely to be found an a name.  e.g. ## or |
Actually it's cool - I'll just move it down to wherever it seems appropriate. Will be running through the css styling with Chelsea and see what she thinks makes sense. I'll merge now!
This bit needs a lot of re-writing. Do we hold off on that until a later PR?
The default parameter here probably shouldn't be committed as it is very specific to your code.
Just out of curiosity, is _non.existent.ValidationProvider_ a placeholder or key for something?
ok - just double checking:

https://github.com/django/django/blob/master/django/http/response.py#L40
the attribut used there is _header

I assume this header shall be _header as well? If not, I really dont get the purpose of this "self.header" attribute, because it does not do anything.
I find the name confusing, because there might be a `lambda` function or something to check the session in this parameter only looking at the name.
In my first implementation there indeed was support for a `forbidden` list.
The question boils down to whether we think there will be more and different mechanics than the currently available use case and how much we thus want to generalize the component. The logic for `pickup_allowed_at` can be expanded rather easy.

I think i kept the `allowed` bit to have a nice implementation: we literally write "pickup allowed if target in allowed".
used to track calls that have been made but not yet completed.
Does adaptNativeCountQueryBuilder have to return the querybuilder? If yes, then it must be added to the method comment in AbstractAdminListConfigurator. When i read "adaptNativeCountQueryBuilder", it only adapts the querybuilder parameter, and not returns a new one.
Oh, to match their convention, I can see that. I think it is okay to have `insert` as an alias, however I would prefer for `create` to be the name of the actual method and `insert` to be the alias.

My goal was to sort of mimic rails convention (Though you don't have to use rails), and I have seen create used much more frequently than insert.

Also it seems that english isn't your first language, but `Calendar.create` makes a lot more sense than `Calendar.insert` in english.
This comment needs to be updated too ("ovr" instead of "crammer_singer"). And a note be added in the whats_new file.
can you use `parent.className` here to avoid a function call?
Yes, this line should be wrapped. Thanks for noticing.
Should these two properties be documented in a pseudo-object?(like we do for the callback params up there in Chat, etc.)
It's actually not the callback itself, but the parameter passed to the callback, I think.
This method seems useless. `factory.get(require('chrome').id)` is sufficient, and also removes the coupling of `chrome` and `webview/factory`. This module should not care about semantic differences between webviews, no?
Not in the packager no.
Intentional, I want to make it clear that some tests are skipped
From: Eric Pearson
Sent: Monday, November 19, 2012 7:45:09 PM EDT
To: blackberry-webworks/BB10-WebWorks-Framework; Rosa Tse
Reply To: blackberry-webworks/BB10-WebWorks-Framework
Subject: Re: [BB10-WebWorks-Framework] Fixed contacts functional tests (#276)



In test/functional/automatic/blackberry.pim.contacts.js:

>
> -            runs(function () {
> -                expect(successCb).toHaveBeenCalled();
> -                expect(errorCb).not.toHaveBeenCalled();
> -            });
> +                runs(function () {
> +                    expect(successCb).toHaveBeenCalled();
> +                    expect(errorCb).not.toHaveBeenCalled();
> +                });
> +            } else {
> +                console.log("foundContact not defined");


is this intentional or left over debugging code?

\u2014
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/276/files#r2175321>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
You don't need this since cinbuild starts with a clean workspace everytime
i think that should be configurable in form.actions of generator.yml