Fix menu text change breakage

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7310 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Fix ribbon label hotkeys

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7311 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Fix installer UI field sizes

Increase title control height to make all text visible.
Adjust position of description controls accordingly.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7314 (new)
queue: kfw
target_version: 1.10.4
tags:pullup
Add MIT krb5.ini to wix install directory

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7315 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Don't require pdbs for make install

When NODEBUG is defined and DEBUG_SYMBOL is not, no pdbs are generated.
This should not cause make install to fail.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7316 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Use release MFC lib for NODEBUG builds

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7318 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Use env to determine config in installer build

Use NODEBUG and DEBUG_SYMBOL from the environment to determine whether or
not to define Debug and DebugSyms for the installer build.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7319 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Add both x86 and x64 msm's to x64 installer

Since we have x86 dlls, we need the x86 msm's.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7320 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Handle missing autocomplete object gracefully

Don't crash if we can't create a CLSID_AutoComplete instance.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7321 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
CCAPI client rpc fixes

On Windows XP, cci_os_ipc_thread_init() causes additional threads to be
spawned immediately, which results in a vicious cycle until Windows
resources are exhausted.  Instead, defer thread_init() until it is really
needed.

Also, use the MSDN-recommended defaults for RPC calls instead of random
constants.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7322 (new)
target_version: 1.10.4
tags: pullup
Put athena-specific krb5.ini in athena subdir

The installer only picks it up if MIT_INTERNAL is defined in
the environment; otherwise it uses the now-empty krb5.ini in
the base directory.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7323 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Always install krb5.ini in KfW 4.0 installer

Pre-existing krb5.ini files from old kfw versions will be overridden
due to the new search path, but not removed.  This is the desired behavior
since old krb5.ini files are far more likely to cause problems than to
contain useful data.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7324 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Fix warning caption "Leash"->"MIT Kerberos"

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7325 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Fix renew_until check for auto-renewal

This was completely wrong, but only caused a severe problem on 64 bit
builds. On 32 bit builds the result was effectively always 'success',
so it would always attempt to renew even if there was not sufficient time
left in the renewable lifetime. This did not have much observable
adverse effect. But on 64 bit builds it always failed and so never
attempted renewal.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7326 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Add domain_realm mappings to the athena krb5.ini

These seem to be the only bits from the krb5.ini shipped with older
versions of KfW that remain useful.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

[kaduk@mit.edu: add motivation to commit message]

ticket: 7327 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Rename old krb5.ini files away

We want to always use a new krb5.ini (and our search order guarantees
that we will), but users might be confused if there is still a file
named krb5.ini in the old location which is now non-functional.
However, it is rude to unconditionally delete the old file which may
potentially be the only copy a user has of their local changes.
Instead, rename the old file to a non-functioning name that indicates
it is no longer being used, so that it may be consulted if needed.
Only attempt the rename if we found an existing krb5.ini, and ignore errors
since this is not a critical part of the installation.

ticket: 7328 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Avoid a crash when attempting to change password

In some cases we could keep stack garbage in a local pointer
variable until the cleanup at the end of the function wherein
krb5_free_context() would choke on the invalid non-NULL value.
Initialize to zero to avoid the issue (should be written as NULL
but stick to the prevailing style).

ticket: 7329 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Update KfW installer graphics

Replace dogheads with the new 'K'.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7330 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Refresh ticket display immediately after renew

Set the CLeashApp::m_bUpdateDisplay flag to cause the display to
update on the next WM_IDLE message to the main thread.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7331 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Fix window close issues

Stop filtering out SC_CLOSE. 'X' button works more reliably, also alt-F4.
Remove minimize box from style.

Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>

ticket: 7332 (new)
queue: kfw
target_version: 1.10.4
tags: pullup