labofsahil/github-event-dataset-2012 huggingface dataset:
ARQ-725 Improved the performance of the WLS container integration.

Note - It would be preferable to verify the performance improvements arising out of this change. Observable improvement was around 40%.

Modified the codesource of the WebLogicJMXLibClassLoader. The codesource is now weblogic.jar instead of wljmxclient.jar to avoid setting up a SecurityManager which in turn reduces performance. This was the reason why having wlfullclient.jar in the system classpath improved performance. The use of wljmxclient.jar switches on a SecurityManager whose operations decrease performance when creating ShrinkWrap archives.

The JMX classloader is initalized on creation of a WebLogicJMXClient instance. Also, the connection to the JMX MBean Server is also created at object initialization. The WebLogicJMXClient is created only once, for an instance of the WebLogicContainer class. The state of the JVM modified by the WebLogicJMXClient is stashed for the duration of the method invocations on this class, and restored on completion.

The jmxLibPath property in arquillian.xml is no longer supported.
Fixed some bugs + added specs

Hi, I made the following changes:

- schema dumping didn't work before
- added regexp for checking if a string is a valid array
- added specs for the string and array extension, as well as integration specs

Best regards,
Fabian
Update gk_music_free/admin/elements/update.php

Problem with update element on Windows server due to slashes

This may not be the solution but it worked for me.  :)
Express: npm test command and oops error page.

Express got a little more error handling, including the fancy oops page and "npm test" to run unit tests.  It just runs the locally installed mocha (from devDependencies) in server/express)
Add note about naming module when filename is invalid.
Wrong form class

Wrong class declared for form element, it should be "form-horizontal".
[Twitter bootstrap forms](http://twitter.github.com/bootstrap/base-css.html#forms)
Worker_install wurde geaendert
Update Ukrainian/main/VoiceSearch.apk/res/values-uk/arrays.xml
Updated screenshots to VS 2012 RTM & Windows 8 RTM + Added note with WebSites custom domains + bug fixing
Fix issue where quiting using the Pause Menu in multiplayer can crash the game

TitleMenu.EXIT_LEVEL will set synchronizer to null, but won't kill the packetLink. The packetLink gets a TurnPacket, calls the handle function, then handle attempts to access the synchronizer.
chmgen and various fixes

This gets chmgen working again, with a few improvements, and fixes problems in docs found by chmgen.
Removed the check for friendly certificate names

Not all SSL certificates have this set, so it wasn't being listed in the available certificate list
Try to avoid using inline styles. Have you had a look at the lessphp preprocessor and all the .less files that make up the CSS structure? If you like, I can take you through this sometime.
any chance that one of your audio fixes broke audio on osx snow leopard? My rig is silent like a dead fish latly. Menu sounds are working. No movie sound (ac3 or pcm doesn't matter). I'm using analog output (stereo speakere). Though no video stutter - so audio might be processed.
一般我们这边写Model时习惯按这个顺序：

```
  - 本Model的业务逻辑，需要引用的module
  - 本Model的模型关联声明
  - 本Model的校验方法
    - rails 校验方法
    - 自定义的校验方法
  - 业务逻辑方法
  - 给其他类扩展的方法module
```
These are to make it so that the OS will size the dialog box appropriately
Idea: What about moving the admin code to `admin_.py` (or something, not too happy about this name) and only leave the `admin.site.register` call in `admin.py`? This would still allow us to separate the model and admin code.
I didn't checked but this would not bug with false values?
@marcoemrich Definitely true, developers should use attr_accessible no matter what. 

@why-el Well an existing application should already have attr_accessible in it, but un-comment `config.active_record.whitelist_attributes = true` into your config/application.rb
Maybe return None if the target already exists? At least ignoring that fact is not good. Same is true for other resolvers.
There is a misspelling here: An associative array of Memcachge options
I meant, I made a little improvement
Shouldn't it be just `pws`?
Actually meijerg does not implement rewrite - should it?

Anyway, hyperexpand has a parameter allow_hyper which is usually set to false. In this case, a meijerg function will be changed into at most one hypergeometric function, if this is not possible it is returned unchanged. If allow_hyper is set to true then as many hypergeometric functions are returned as necessary (if possible).
@eilio Any news?
constants??
Stupid question probably...  How do you update Math::Clipper ?  (Ubuntu 11 32bit)
Overall, I like this approach, the only real issue is changing it to be sure we are not using values 'below' the top of stack.

I would still like to understand (as I asked in email to Gergely), what cases the un-patched table gets jumped/called into. I do now see that it is happening, even on just startup of the shell. But curious about the bigger picture of why they do this.
Zmienna include służy do pokazania katalogu z includami. tylko i wyłącznie.
jeśli chcesz dodać kolejne katalogi, zrób to w CXXFLAGS:
CXXFLAGS+= -I${INCLUDE}/utils
All of the newlines embedded in the string make it hard to read. Is it possible to create an array of strings and join them with newlines?
Voor iedere vraag die ik in een examen wil hebben moet ik dit formulier doorlopen?
Dus als ik een examen heb met 30 vragen dan moet ik 30x dit formulier openen?
Multiple-choice kan niet?
```title``` and ```subject``` are arrays. I don't know enough about the CS-W spec, but wouldn't it make sense to create records with unique titles and subjects? Like if you had one catalog entry with two titles and three subjects, that 6 records would be created? Then a GroupingStore could handle the records in an elegant way.
I've seen a lot of really annoying behavior with not using the trailing slash.

A few examples:

1. Django doesn't support it very well out of the box. This isn't a huge issue, but its extra work.

2. I think users tend to expect the trailing slash when manually typing urls. This goes back to how well Django supports it, and it's not very well.

3. The URLs ted to be a bit more painful to piece together if you cant guarantee trailing slashes at all points of the code.

Overall, it's just easier to deal w/ the trailing slashes, that's all.
It would be great if we could tell the user which environments are available.
I am not sure neither. I wonder if it will cause compiler errors on any compiler.

The gcc version I use is:
gcc (GCC) 3.4.5 (mingw-vista special r3)

If there is a problem with this commit.. I am not against that we add one more flag, for instance LDFLAGS2, that is appended to the end. I can use LDFLAGS2 instead of LDFLAGS if that saves some trouble for somebody else.
It's commented out because I'm not sure why it's useful. Probably it's worth asking in the mailing list why an invocation of `sci_fix_selection_anchors` was added to `reflow_lines`.
I think the api should be disabled by default for models. Thoughts?
uta que eri porfiado loco usa un traductor que sea zpoetaz
Great!!!

We can follow together the development of this plugin ^^
Pls. parametrize the port as well.
Die `Property` Erklärung sagt noch nicht wirklich aus, was Properties in Empire sind, od?
Maybe some code related to immunities was recently modified? Bladestorm now doesnt provide immunity to slows, thats very weird.
pero era eso todas las caidas...me duraba como 2min online eh....arrancaba y...ZAS! jajaja
Everything from ulduar_teleport.cpp was moved to ulduar.cpp so just delete it from filter file
This commit fixes the above pointed out issues:
https://github.com/vaidikkp/zamboni/commit/77db27ed8b599b4fa2098d34cfdeb525f8880305
Yes, this bit is. The line didn't follow the style of the rest of the file's code.
Just noticed this.
Why replace perfectly valid arrays with linked lists?
(Same remark for setList and co)
Premature pessimization?
please revert it. Proper way would be to add support for loading original files which should be trivial.
After all the simpler "fix" is probably to delete this useless collector.
Voir pour mieux faire que ça essayer de passer par le repo des coms.
As I've mentioned, you don't really need these (x) parts anymore
Could you explain why a closure is used? Typically the second param is the $result.
sorry, have put comment in the actual lines
Line 92 in rpm.rb dies when I try to use fpm (master branch, commit f6c265d).  

`
cd /opt
git clone git clone git://github.com/jordansissel/fpm.git
cd /tmp
./opt/fpm/bin/fpm -s dir -t rpm -n perl -v 5.12.3 -m "...." --iteration 1 -S .ii --description "This is perl 5, version 12, subversion 3 (v5.12.3) built for i686-linux (CentOS 6), with extras.  Experimental." -C / opt/perl 
`

"define" is not defined , and it crashes with:

`
../opt/fpm/bin/../lib/fpm/target/rpm.rb:92:in `build!': undefined local variable or method `defines' for #<FPM::Target::Rpm:0xb75e7650> (NameError)
        from ../opt/fpm/bin/../lib/fpm/builder.rb:120:in `assemble!'
        from ../opt/fpm/bin/../lib/fpm/builder.rb:119:in `chdir'
        from ../opt/fpm/bin/../lib/fpm/builder.rb:119:in `assemble!'
        from ../opt/fpm/bin/../lib/fpm/program.rb:55:in `run'
        from ../opt/fpm/bin/fpm:20
`

If I add a paramter `--define-rpmbuild-option 'dist .ii'` it fails exactly as above. If I comment out line 92, and 94-96, or define `define`, fpm completes (at least, without crashing.)
this also accepts timestamps without any utc-offset which represent a type-error, since a `ZonedTime` represents a time with an associated utc-offset...
I agree with that. It's is just from an algorithmic point of view. The case z) is handled twice. so the line check_distro won't be exectued :)
Yep it's a mistake. I'll fix.
Shouldn't this be "**non** *coprono* l'importo richiesto!"?
Es más bello:

```ruby
all(input).first.click
```
This sounds really harsh. how about

You do not have permission to use this command.
Look at the target_distance_from_center() function. It only asks for the index of the target. This function should only ask for it too, in order to pass it on. You then call the target_distance_from_center function and tell it the index. it will give you back the distance. Then you align it accordingly. Other than that, this looks good
I believe msgid is the english phrase to be translated, this should be left unchanged, and the msgstring should be "till"
Not sure if it's worth it? ... this will be replaced with plugins.mozilla.org soon it sounds like.
I create a helper method to fix either count is nil or 0. And I think it helps to keep the template clean.
This is a nifty commit
This might be the reason I was having problems with my block rotations. Will try with a build containing this change.
Oh, I can see it, I was asking if you are still going for 1.5 compat ;)
恩. 看来要在插件里添加去除重复项的功能.  BTW. github 这个评论功能很棒啊!!
nice work :D
then make debug of the spellsystem and NOT hack every spell
Забыл добавить что клиент теперь умеет читать TTH из расширенных атрибутов, а также сохранять его.
"vecter" vs "vector" (mis-spelling)

Is there a better email to reach you at?

--Adam

On Thu, Jan 12, 2012 at 6:23 AM, Strife Onizuka
<reply@reply.github.com>
wrote:
> (just seeing this now)
>
> I'll look at them when I get home. llRequestMoney is a feature request and miscategorized (it should not be in the Functions category). llSetRegionPos is brand spanking new, it's pre-release (it was in the RC release notes a couple days ago but it just evaporated from them, I have a question that will hopefully be answered during the Server Beta Office Hours as to when I should document these things).
>
> I'll fix the values for the vehicle types. I'm not sure what you mean with the two vector constants. (thanks for reminding me about TEXTURE_DEFAULT).
>
> ALL_SIDES looks interesting.
>
> I don't ever recall seeing llSetSculptAnim, it's probably a miscat feature request.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/BlindWanderer/lslint/commit/06977c8cefa28b76ef8ae7d9d16a6c0d30f1f01a#commitcomment-860990
write_push_data?
Каждое событие имеет своих спонсоров, вытягиваем их в шаблон
another way to write what i'm doing is

    options = options.dup
    options.symbolize_keys!

am i missing something?
Hi Didier,

i have even more streamlined the Gemfile and Gemspec:

https://github.com/mkempe/engine/commit/c1389c99562f1890515ff4303d3a1c43787c265f
https://github.com/mkempe/engine/commit/0f4c9d4d3a1a626dc01143abc37fb7d95143ac20
https://github.com/mkempe/engine/commit/0841f7450d9b144cd5895f58a7984010dba23875

You can find all changes in my branch. Maybe you can look over it again.

Thanks.
On localhost, I'm now seeing the Options gear on every comment regardless of hover. I'm also seeing the bookmark star and options gear in different orders between the discussions list and single discussion view (the gear is now on the right side on the discussions list). Are these changes intentional?
More calendar code. Again, does not belong here.
Relying on ```hasOwnProperty``` is always safer I guess.
PSR-1 should not cover commenting conventions. Each project has it's doc generator, each project has it's own convention and rules for commenting code.
oh sorry, That file for was my local development. I'll remove that.
Would you mind explaining thing this fix to me? I don't really understand why this fixes the issue... 
Also, I feel like _highlightsBy should never be undefined...
I just wanted to create a method that would free myself of writing boilerplate code for JSON requests.
Caption should not be empty, refer to my other note.
не понятно, почему если они должны что то получать их надо заносить пул, для этого может подойти фабрика и тп, а если нужен пул это же регистри или еще какая фигня
Compiled fix for users not getting paid.
If it was only dealing with your example that would be fine, but this also handles the case of:

`http://example.com/index.php/path/to/custom/route.extension`
vs
`http://example.com/path/to/custom/route.extension`

Your point is valid, but it isn't *this* part of the application that would be handling that.

Cheers.
It does, but that's a much more powerful benefit. 

I prefer to think that they just give you a flamethrower and go about their day.
Only the best.  Ok, yes I should try and add some.
No problem. I've submitted a pull request ;)
delete commented & code which is not necessary
Please always name enum members with a prefix composed of some important uppercase letters of the type name to avaoid name clashes. In this case: qmDetect, qmStandards, qmQuirks. Thanks.
https://a248.e.akamai.net/assets.github.com/images/icons/emoji/heart.png?v5
For Testing

```sql
DELETE FROM `event_scripts` WHERE id IN (13685);

UPDATE `gameobject_template` SET AIName='SmartGameObjectAI', ScriptName= '', data2=0, data3=90000 WHERE entry=184729;
DELETE FROM `smart_scripts` WHERE entryorguid=184729;
INSERT INTO `smart_scripts` VALUES
(184729,1,0,1,70,0,100,0,2,0,0,0,12,21319,1,90000,0,0,0,8,0,0,0,1316.748,6695.007,-18.810,5.052,'The Thunderspike - On Gossip Hello - Summon Grimgut');
```
Have to implement if tirst...
Yeah, unicodehelper is what the validator uses for JS, too, so it makes sense to be consistent.
This php open tag fixes the error 500 using PHP 5.3.10
we can comment on a line... cool beans
Checked. Reviewed
Oh indeed, I must have used the wrong branch for editing...I wasn't sure at first which one was the one I needed since I couldn't tell by their names.
indentation looks funny
Hi Emanuele, I made some corrections to the Spanish translation, I will post all of them here instead of making a comment per correction:

-'Funcion del Hook'  Should be: Función del hook
-Click en el icono de estado  Should be Clic en el ícono de estado  // yes, without k
-'El hook existe y esta activo'  Should be El hook existe y está activo
-'No se encontro el hook' Should be No se encontró el hook


That's a bout it :)
So "These two URLs override settings in registration.backends.default.urls"?
OK. It was the Alpha 5 from Modaco. I'll keep trying to fix it.
@that4chanwolf
If you do not care for my modification let me know I will revert them.
LOG_TAG, please.
Use MPL 2.0 for all new files. See

https://bugzilla.mozilla.org/show_bug.cgi?id=720271
Backbone-couchdb is only 252 sloc, and it's more than a year old. It seems stable to me. With such a small codebase, I figure I can fix anything that needs fixing, if the current maintainer ever decided to stop maintaining it. Since CouchDB speaks REST & JSON, which is exactly what Backbone speaks, they seem to be made for each other - not a lot required to get them to play nicely with each other.

I'm also developing for mobile, although I'm targeting tablets more than phones. If you use Android you should search the market for mobile futon. You'll have a working couchdb server with a jquery mobile interface up and running on your device in a matter of minutes. You can create new databases and play around with it to get a feel for it. That's not how I'd serve a production app, but it's a quick way to get a feel for how CouchDB works on a mobile device.

There are a couple of groups working on newer, lighter weight and more performant iOS and Android CouchDB servers at the moment - CouchBase has CouchBase Mobile for iOS and Android, and they're working on a follow-up called TouchDB. Not yet production-ready, but it sounds like it will be nice when it is.

Good luck!
Basically, what you would do is not include private files in git but add an "example". Like this: https://github.com/iRail/The-DataTank/blob/master/Config.example.class.php
Use '.' syntax when referring to these properties.
Whoops, forgot to clean up the commit message for this...  It references an allow_pm_max patch which I never released to the wild or pushed to github as it seemed to do nothing but break things.
Did you HEX edit  libms3c_yamaha.so to change config location?If not can you please provide me a link to the source?
I must have overlooked that plugin. So thx a lot for the recommendation!
If a dropdown is enhanced with chosen.js, trigger a update event on it.
This sample is for getPrice, update with corresponding example.
Согласен, исправлю.
OMG THANK YOU :D
Watch whitespaces and strings that are written out and not pulled from
strings.xml
They jump on that stuff to have hit -1 lol
On Feb 22, 2012 3:55 PM, "LorD ClockaN" <
reply@reply.github.com>
wrote:

> Yes, I just commited to cm gerrit
>
> well that guy is working with me, we made patches to frameworks and phone
> there are few because we were working live and didn't test offline :)
>
>
> On 02/22/2012 09:13 PM, 0002647302 wrote:
> > Actually I intend to fix it and move it in one step. Don't you already
> have this?
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/TwistedPlayground/android_packages_apps_Phone/commit/0047e42249cb801d605d786304bbddd2d1e3a19b#commitcomment-997823
> >
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/TwistedPlayground/android_packages_apps_Phone/commit/0047e42249cb801d605d786304bbddd2d1e3a19b#commitcomment-997990
>
*frames
name shoud be bee-check
I've checked in DataMatrixFileBuffer.java that all header lines (including "Composite Element REF" ) are ignored when data is read in. Hence we should be OK removing this line.
To indicate that a parameter if optional, give it a name and enclose the name in square brackets, like `[foo]`.
It is a little tricky where these are being used. `parent_rec` is used inside the `dt_detail`'s column formatter which wasn't apparent to me at first. It would be good to move this var to the top of the closure and add some more code comments about how they are used, especially `parent_rec`.
You're right.  I'll change it to only look for objects.  (I agree in general about Y.Lang, but in this case, the overhead of Y.Lang is negligible, since the main loop extracts data from the dom.)
On a second thought it might be a good idea to disable commenting until admin takes an action to convert the annotations to objects. Maybe even disable the whole setting checkbox if any annotation comments are found from database? This would force admin to take care of the conversion.
This is a pretty weird object. It's like a dict of ring buffers. Maybe it *should* just be a `defaultdict` of `RingBuffer` objects.
is it a timestamp?
System.currentTimeMillis
or if it's only for later measure a duration System.nanoTime
Haven't looked at the akka serialization yet.
Will incorporate this, thanks for the hint :-)
In latest and greatest we use `: FiniteDuration`
Aha, you are not true to Scala ;) "A less-idiomatic way to use Option values is via pattern matching"
Sure thing, Patrik.  The durable mailbox implementations would then be responsible for their own timeout handling - which i'm understanding Viktor's point to be as well "caller who should decide".

Thanks for the feedback!
one-liner :-)
And this should be 'RankNames.member.%d'
The first sentence seems to be missing a noun.
oops, sorry :)
Yes, when bvecs_close_to_1, we treat the bvecs as valid, otherwise we replace the values with 0.
rr?
Why is there a generate metadata data flag for an ISO distribute?
Also an artifact of the fact that this was old code ported over. Fixed.
why is `_setRowWidth` called immediately after `outerWidth`? isn't that just setting the width of the column twice? and it's setting the column width, not the row width, so it shouldn't be called `_setRowWidth` correct?
`apply: Cmd.apply`
What would happen if Jenkins is overloaded?
I suggest you create a simple trait with a getCurrentTime method that can be mocked for unit tests to test multiple same millisec calls and calls 'in the past'
OBSERVER++

http://starcraft.wikia.com/wiki/Observer
Why `_jobs` and not `_job`?
you have a compare(int, int) bellow
This method should be on JavaPlugin perhaps
Not really. That was result of some wierd git merge. Those modifications are not mine anyway. Once this pull request will be merged onto master, git will be able to resolve this conflict easily, using 3-way merge. P.S. I will double check commits next time.
The name of the test doesn't match the filename.
This should be removed, no? As to answering the question, both start timestamps and commit timestamps are assigned from the same "timestamp space"
This is what allows us to just  pass an object to render :json=> rendered_as_objects

Some chunks just set @unmask_text and don't need to be rendered, but for links and transclusions, the results of the callback in processing is recorded here, so this will be the string as rendered.  If it gets to "not rendered ..." something broke.
As a general comment, please test the functionality of the elements you replace within the html, since some jquery logic depend on the relative relations of these elements (although should not be ideally!).
you can remove the first ``isset`` here if you do it outside the loop
We should use the gray style as the default, like it was before.
please send me a mail, so I can send you the latest package..
This block doesn't need protecting - 
<pre>>>> ' ' * -1
''
</pre>
It should be completely removed, now it doesn't do what it did. If you were overriding it to register your own Latte filter (subclass or whatever), now you would end up with two latte filters registered simultaneously.
This feels like a hack.
Agree here, it is unneeded, and seems to reflect the bru-ha-ha on the list. This particular note went into my personal stash of reasons why I should have a bit of fun provoking the Bull.
A static function returning SUCCESS/FAILURE would be more appropriate. You can always mark it inline.
Fix is on the way, just performing tests to ensure leaks are no longer applicable.
Indeed. Thanks for pointing this out.

I am aware that this implementation needs more work (there are additional edge cases).  But I wanted to bring it to a vote to ensure that additional work on this feature would not ultimately be all-for-naught, as outside of core/master inclusion, this feature is effectively useless.
строка в 144 символа — это все-таки многовато
```ruby
module MyLib
  mattr_accessor :deprecator
  self.deprecator = Deprecator.new
end
```
@frodsan I think this is a better move.
A few examples might be worthwhile to augment the compiler-ese.
Same story as above, thanks Paul.
Migration means that all symbolic references to classes/objects/packages in the expression
will be re-resolved within the new mirror (typically using that mirror's classloader).
The discontinuity is about 0.0097. The pdf attached to the ticket has an error estimate, did you see that? It actually suggests that this approximation should be used for a cutoff closer to 0 that the current choice.

    import numpy as np
    from scipy import stats
    import matplotlib.pyplot as plt

    norm = stats.norm()

    x = np.linspace(-9.9, -10.1, 300)
    y = norm.logcdf(x)

    fig = plt.figure()
    ax = fig.add_subplot(111)
    ax.plot(x, y, 'b-')

    plt.show()

    print 'Discontinuity around -10: ', norm.logcdf(-10+1e-10) - norm.logcdf(-10-1e-10)
On Fri, 24 Aug 2012, Christopher Smith wrote:

>> +                        return
>> +                    if isinstance(-nval,cos):
>> +                        return
>> +                    x = (2*pi_coeff+1)/2
>> +                    sign_cos = (-1)**((-1 if x < 0 else 1)*int(abs(x)))
>> +                    return sign_cos*sqrt( (1+nval)/2 )
>> +                FC = fermatCoords(q)
>> +                if not FC or len(FC) > 2:
>> +                    return None
>> +                elif len(FC) == 2:
>> +                    # only 3, 5, and 17 are used currently
>> +                    # so only 3 pairs are possible.
>> +                    #
>> +                    # Now we use partial-fraction decomposition
>> +                    # and angle sum formulas.
>> +                    if frozenset([3,5]) == FC:
>
> Just curious...why are you using frozenset instead of set?
>

Habit.  I always put an immutable type on the left of comparisons if I can, so a 
typo like a = b raises an error.

 			Tim
Here it's hard for me to see that the new and old results are equivalent.
@smichr, You have been using the old plotting module that is working on pyglet. I have little idea how it works and I have not made changes to it (I have only moved it to a subfolder).

Check the docstrings of both `from sympy import Plot` (a proxy object to the old plotting module in order to have deprecation warnings) and `from sympy import plot`. Both of them should be imported with `from sympy import *`
All right, this is clear.  You could perhaps mark this with another TODO comment (unless the scope of the comment about better data structures extends hitherto).

Also, I'd vote for not reusing variable names, like in 479.  It's very likely just me, but I initially thought that `S2` was created from the _initial_ `S`, which consisted of lists.  (Feel free to disregard this remark, of course.)
The use of `\substack`here might become a bit of an issue in the future if we have substitutions of many variables, but for now this seems fine to me (we can have something that checks the number of substitutions to be made, and if there are, say, more than 3, switch to a comma-separated list, e.g. `r',\  '.join(...) `). As for the LaTeX code, it compiles correctly.
I think (I may be wrong) that if another exception is raised inside the except block then the finally block will not be called. This is why I suggested putting it at the end of the try block and at the start of the except block.
Logs with category `system.CModule.anything`?
I think these lines eventually should be readjusted to the common style. At present, there appears to be "tab"s at the beginning of the lines.
No; I would move the `#if`s to the header and wrap the declarations around them.
changed it to be more reasonable
What is the reason for having text in english too? Is it something you would prefer to have when reading docs?
Ups... Mein Fehler!
Die Datei gehört gelöscht... und braucht somit keinen Eintrag im .gitignore
Sorry!
Thanks, I added this in 055fc4f03c. In the future, can you make your commit messages more descriptive so I can pull them while keeping a clean history?
The reason I didn't take this patch is that `lib->errmsg` is always NULL here so most of this code is a no-op.
Found, fixed.  Sorry about that, not sure how that happened.
phpbb_root_path?
To separate this from styles you probably want to add a phpbb_template_locator_interface which is required here, and then phpbb_style_resource_locator implements that interface. That way style code is separated from template engine code.
I think this was added to prevent errors if the gallery path is actually empty which will also leave an empty $avatar_list. Don't pin me down on this though. It was added by cullen initially.
This comment is outdated as well and needs to be reverted.
I didn't understand
won't pass
imho eigther feature number or feature name is odd.
example/profiling uses movie_list.js, example/library the json file :(

72790428ae787d3fc8074b33358ab004c3f775d1 did not change all of them.
missing semi?
@param contextPath, @param linkOriginalObject missing
Now it should be good (fingers crossed) :-)  I processed both files.
would now be appropriate time to rename these fields? (Diagnosis, uuid, type)
i have kept the convention used in examination tab. We should make a generalised function which does based on "obj" it is called from (part of argument).
Reason of making it same as vikas was that it will become easy during re-factoring of code.
'0' not needed, but it does no harm.
What is ```draw_result``` for? Remove?
The CF spec states that "A variable may have any number of dimensions, including zero". This has parallels with the issues around scalar coordinates if one allows them to have an ndim of 0 rather than 1. However, it's not 'magic', and one could argue that a single measurement of a single phenomenon does not need dimensions and we should be able to handle such a thing.
Typo: constructs
"calls". "It does not"
As above, bypass the checking entirely when its result will just be ignored. In this case, that means passing m_allowMismatchedResults into addResult and factoring it into the return value, so it effects duplicate_okay directly.
Use "" in html
Spurious semicolons should be a SyntaxError. I might write a PEP on it.
Put it out of its misery.
Useful filters: ``list_filter = ('record_type', 'date')``.
Мы же обсуждали. Помнишь, что функция `require()` — локальная для каждого модуля?

```js
requireWrapper = function(wrappedRequire) {
    var func = function(module, noCache) {
        if (noCache) delete require.cache[require.resolve(module)];
        return require(module);
    };

    func.resolve = require.resolve;
    func.cache = require.cache;

    return func;
};

// usage
require = requireWrapper(require);

var m = require('m', true);
```
will it be long?
Hmm, that would work - however, there still needs to be code to swap the app cache for a new temporary one, if I'm not mistaken. Am I right in thinking that the AppCache being a shared-across-all-instances class is not part of any public API and that we might be able to make it a per-instance thing?
Useless because page_buffer is now global.
It would also be a good idea to test `shapes.Site(-0.0000001, 0.0)` and `shapes.Site(0.0, -0.0000001)`, as this more closely tests the boundary.

The same goes for `shapes.Site(1.0000001, 0.0)` and `shapes.Site(1.0000001, 0.0)`.
The `qa` attr isn't necessary. In a recent branch, I removed all of these attributes from the QA tests because they weren't being used for anything.
Can we clarify the language around what camel case is/isn't? This whole upper/lower distinction seems (to me) like it could be simplifed. For example, `camelCase` and `StudlyCase` (or `CapitalCase`).
why this `if`?
I nominate you!
General style guide issues here... indent width, use of single quotes, function arg padding, etc. Please read http://docs.jquery.com/JQuery_Core_Style_Guidelines and correct any issues you may have
Facing is updated whenever an actor is moved in a direction, and for individual powers there are several tags that can be set such as PowerKeys.NeverUpdatesFacing and PowerKeys.SnapsToFacing that I think are meant to override the default facing behavior. Right now however nothing is done with them, I gotta do some testing to see what would be correct.

For now, if you really want to have some skill code only run for monsters just use: if (User is Monster) { ... }
But this only operates on strings. So that should never be the case, right?
Don't test the executables without their full path. The previous test covers it already.
Sorry, just fixed that.  I had set it to a mirror for testing, as the original was down.
Probably just map strings to strings, remove the else clause and call `compact` rather than `flatten`.
Looks like the best bet here would be to return nil, and then do this where necessary:

```rb
raise DeveloperToolsNotFoundError if MacOS.dev_tools_path.nil?
```

and have DeveloperToolsNotFoundError call the right doctor check and print the output. I'll work up a patch today or tomorrow.
No need to comment this, BUT there should be some metadata that indicates it.  It would be better to replace run with a new metadata type:

    syntax "<action>"
    default_method :show

where default_method :show links the show method with the command (via Commander aliasing https://github.com/visionmedia/commander#command-aliasing)
Ok, will look into changing this once I make sure the tests are passing
summary should be the first metadata line, syntax should be the second, and then argument, then options.
Thanks, fixed. Odd that my editor doesn't complain.
Created #311 to address this.
This needs a bit of rewording. Something along the lines of  `Raises client side exceptions for any errors reported in the API post request response.` I also am not 100% certain at this time that this function is only used in post requests.
Doh, I didn't notice that. I think it would be best to say:

Ensure the frequency of API calls doesn't exceed the `api_request_delay` value specified in praw.ini, for the desired reddit site.

The remainder of the documentation is accurate, though I no longer like the `funcs` abbreviation.
This could be written as:

```javascript
var ALLOWED_ROUTES = ['controller', 'view', 'locale'];

if (ALLOWED_ROUTES.indexOf(routeName) === -1) {
    return next();
}
```

`ALLOWED_ROUTES` being a constant at the beginning of the file. This allows for easy addition or removal of routes in the future. :P
Another `'page'` that should be `self.param`?
should line up `=`
any reason not to just push straight to `resp.data[base]` here?
I think this should be (and the others need to be changed too):
    
    x = (x & (~BASE_MASK)) + (getX() << CHUNK_SIZE_BITS);
    
CHUNK_SIZE_BITS means the number of bits in the chunk size and is equal to 4.
Dan Imal will like single quotes here
Typo: you meant to have one "mac" and one "win", but forgot to update your second copy.
Agree. I refactor it to a new method and I think it will also solve your confusion of using newColor or correctedColor.
I'm confused about why we're explicitly resetting `_this.hsv` here and resynchronizing, since we passed `true` to the previous call to `commitColor()`, so it should already have set `_this.hsv` based on `correctedColor` (and also already called `synchronize()`). Do we explicitly want to set `_this.hsv` based on the original value of `newColorObj` instead of using `correctedColor`? It's not clear to me why we would want these to be out of sync.
Oops, that's an old constant I no longer use, the default value is already in DEFAULT_OPTIONS. 

I've just [removed it](https://github.com/afcapel/reel/commit/50bd5c42427873736551cea5bc726f206226f72f). 

Thanks Ryan!
-R is remove
-s is remove dependencies also (those not needed by anything else and not installed explicitly by user) - pretty sure it should be the default
AFAIK both `alias` and `alias_method` use the same underlying `rb_alias` C code underneath, with `alias_method` being more predictable and readable. I'd definitely favor it.
The problem is that the 'beforeWriteContent' is specifically intended to do:

* transformation of data or:
* validation

So checking this after the fact would be bad, as there could be 'corrupt' data in the system.

I like the idea of just doing a get() for the stream, patch it live and just send it back to put() (at least I think that's what you're proposing). Would there be any drawbacks to that? 
The biggest drawback I can see is that an additional temporary stream would have to be created, which is more copying of bytes and likely more memory usage. But the benefit of reduced bandwidth usage still stands.
With some of the changes down here I might have destroyed the rest of that function.
Maybe this function actually shouldn't be merged.
The point is that I was working on it and then started to write the new functions...
`if` statements are used when you want to test if a condition is true or not. `while` loops are used to run some code repeatedly until a certain condition is true. Since you are just taking different actions based on the result of the menu, it sounds like you are testing for various conditions...
isRowSelected is faster than IntegerUnion.contains()
Rename B to B1
這裡可以試著用 array + 迴圈 (each) 做
It is. But `l` is before `p`, so `urllib` is before `urlparse`. ;-)
Imports ... č/=
Any reason why this is this not in the stylesheet?
Is there a way to call `_external.open(); after the variables get initialized? ( reading comment ). If this is another case of you not writing this code then ignore this comment.
Again, if none of the code is needed now because of the consolidated code awesomeness we should remove it shouldn't we?
Remove the */  closing comment on the end.
I fingers had a list while typing
Add the copyright like other module developed by Taobao
If we don't store any data in this format the change is fine. Later on if we keep data around what you'd want to do is leave 9 empty and keep service_name at 10. That way when you read old data you won't get unexpected results.
If set to true, buttons will be enabled on initial page load even though the editable layer is not highlighted in the tree.
watch out, this needs to be fixed
I read something a while back that indicated that using 'execute' for SQL is more efficient in a migration than embedding ruby, when there is a lot of data to be modified.  Have we done any testing of this migration on a server that has a lot of repositories synced?  If not, we might want to do that and make sure that this isn't an activity that takes too much time.
Yep, just a style thing. I like declaring constant values. It makes my heart flutter. Also, we're going to be doing some eBird processing down the road, so other functions will use the const value. Let bindings totally work too, this is just a personal pref.
What I am trying to say is that resetPlanNodeIds and Fragmentizer.fragmentize should only need to be called on the final plan (whether that is a union or a select). 
They should not be called inside the loop (where it would also get applied to a union's non-final select plan children).
I'll remove it. It's useless, thanks.
Yep because we weren't sure the appscreen was ready (and it wasn't).
Not an issue anymore!
Nope, the image is not created by me :P
So I remove it and use a music symbol text (Unicode) instead.
One last thing: revert change to `background_service.js` ... you don't need it anymore.
54c22191f2e7b04ef72e956558845ad3bec67efd
Footer can stand alone
I like this, though the way it updates `locals()` at the end seems unnecessarily hackish.  Could it not just return maybe a dict and let the caller decide what it wants to do with the results?  This works for expat, but if there isn't already a local variable called `library_dirs` referencing a list this will fail.

I'd rather just do something like:
```
flag_updates = pkg_config(...)
if 'library_dirs' in flag_updates:
    library_dirs.extend(flag_updates['library_dirs'])
```

(maybe the if statement could be skipped if the returned dict is guaranteed to contain certain keywords, which may just have empty lists as their values).
When I merge in all the 1.2 work, I'll update my changes to match whatever the surrounding code uses. Would that be sufficient?
On closer reading I see what you're trying to say. "ZFS On Linux" is the name of a project and should be linked.
Not all these stats are in 1.2.0, some were added in 1.2.1pre1
Is it possible to use something non-mach here?
Yes querystarts empties the vector layer, but if we have one query for the parent layers and one for the child layers, on the second one we can have features on the layer.
Yes, I think so. But should remove `@include Ext/ux/form/TwinTriggerComboBox.js` and include `GroupComboBox.js` instead.
This change is already in master. Can you make sure you've updated from upstream when submitting pull requests. Thanks.
Because outside of action, parameter/model binding is not available.
great.. I see that now. Thanks
a['published'] == '1'

(This is a boolean flag, so it should be translated into a Python boolean.)
Yes, that's right, I'll fix.
I see. I will make it to 'u32 sceSasSetNoise(u32 core, int voiceNum, int freq)'

btw , i normally do the code add in firefox browser and use the keyboard tab key , is it correct ?
copyright 2010 -> 2012 ?
what you suggest to do here?
Please use the same values as in the `MapItem::Status` enumeration. They follow the QML Image element statuses and naming convention.

Also, using `ERROR` breaks compilation on Windows, where it is probably some macro:
```
...\src\mana\resource\resource.h(43) : error C2059: syntax error : 'constant'
...\src\mana\resource\resource.h(43) : error C3805: 'constant': unexpected token, expected either '}' or a ','
```
that's what I did
Nit: the two `.` here will match any character (not just the literal `.`), you can fix that by escaping them:

`MacOSX([0-9]+\.[0-9]+)\.sdk`
Also No `<label>` element associated with the select element
Without the memoization you could write this as a generator:

```python
def breadcrumbs(self):
    node = self
    while node:
        yield node
        node = node.parent
```
Why not add some semantics and use `<ol>`?
This looks very similar or the same to simple paginator. Do we need both?
Or hmm, maybe not. Good point here.
If we limit to GET and only expose the username, then I don't think any authorization is needed here (the default ReadOnlyAuthorization should be fine).
Agreed, the add-on Undo feature seems easier for the user. Storage would add a `deleted` flag and flush deleted addons from storage at unload. Should I try to get this in v1?
ah, yes and it's faster.
Removed.

But I'm still wondering that which is better compared with below.
https://gist.github.com/3386666
No single letter variable names
Do we really want to set the alpha value to the same value as the gray-scale entry? I would think that it should be always opaque (i.e. 0xFF). But maybe this is indeed how this should be handled. This also seems to apply to the loops at lines 347, 270.
Are `'TRUE'`, `'FALSE'`, or other string variants valid? I just did a quick look at the JSON schema docs and I couldn't find a definitive answer
Well, I listened to your take on it, and decided to use it. :p
@stloyd If the DI extension does not have the config for the driver, it should not ask to handle it
No we cannot. ColumnMap expect to be pass a TableMap, an we do not have a table class in the test procedure.
we don't use ``@var`` on non-public properties
Is this correct? Doesn't "before" receive the name of the field just *after* this field? (i.e., this field (A) is *before* the other field (B))
Please use camelCased names for all variables
Maybe i can make a PR to fixe this ?
I'll add it in.
The reason for using 'xyz' was to communicate that it's a nonsensical input. Perhaps 'invalid Input' would work better?
Nu s-a făcut
i'm confused too... 
GridCurve seems to be only defined for 0- or (n-1) cell sequences.. Hence, no intermediate dimensional cells should be considered

shouldn't you replace the (0<=d<=n) by (d = {0, (n-1})  ?
Fixed to match your way :) 06f4f2a
durch diese aenderung koennen wir die auto-vervollstaendigung nutzen ;-)
See change in #PR102
Ahh, so the last line of openKerberosTransport() is this:

~~~java
return new TFramedTransport(transport);
~~~

The only reason that it's not resulting in a double-wrap is that you're not using the return value, which is pretty deceptive, so I wouldn't leave it like that.

It should still be wrapping in the other order so that you end up with TFramedTransport(TSaslClientTransport(socket)), and the wrapping should still be conditional on the value of cassandraHost.getUseThriftFramedTransport().
I initially created this with custom validators, but it felt like overkill for what was needed. validates_timeliness seems like a very good fit - I'll bake it in.
can't we use unittests/djangos discovery for test methods?
`Instance` import is unused.
Use 4 spaces for indentation instead of <tab>
freq -> frequency
Add a line break, that's free! :)
Again, what is this witchcraft?
Do we really want to keep this probably old value?
You're making the footer translucent and allowing the thumbnails to extend underneath it, aren't you?  I think that looks so ugly, but you're right that that is what the specs say to do.  Thanks.
well done. otherwise the Contacts app will stop responding while searching
Nor this one :)
nevermind, I saw that I already clean it when error occurs.
Do we need to pas a parameter here?
yeah good question, should change that
All contributors it is :)
I think we could move these into `attributes/admin.rb` to get a little bit more de-coupling
We already used something similar in `clock_view.js.coffee` called `_twoDigets`. Maybe we could create a public helper, which can be used in both cases.
Are there some tests for these new things in the dataset definition?
Just drop the ++it from the for statement.
Or split it into two parts. Find the element you want to remove. If found, remove it.  This can be done as at most one such element can be in the map.
Channels are exposed as "#builds" etc etc.

The only way to do this from callbacks is to either statically configure the channel to message in the config file,

```ruby
settings["channel"]
```

or cache the last channel someone interacted with. I'd do the former.
`djinn.rb` already has `AppScaleException` defined. Either import it or extract both occurrences to a new file, perhaps called `custom_exceptions.rb` and have both just import that file.
jesus
```coffeescript
if threadID and postId
  path +=
    if archiver is 'foolfuuka'
      "##{postID}"
    else
      "#p#{postID}"
```
That's what you said to do! :(
Ok, last fix... Could you do

```php
$routeMatch = $e->getRouteMatch();
$controller = $routeMatch ->getParam('controller', 'not-found');
$action = $routeMatch->getParam('action', null);
```
Looks like mixed tabs and spaces here.
--verbose/--quiet use/help is a bit ambiguous.  i.e. If I don't call autotest with --verbose nor --quiet what does it do WRT DEBUG messages?
To follow convention with the rest of priam, please provide these injected member vars as arguments to the constructor (and add @Inject) to the constructor.
How does this work? It’s just accessing properties. If `called` is a ES5 getter (seems like: http://chaijs.com/api/plugins/#addProperty-section), this won’t work in non-ES5 browsers. So the test suite won’t run in IE8 AFAICS.
The developer may don't want to scale content factor by default.
this is wrong. It does not work when using a custom vendor folder
yes, because this is not used with the current invite-mail-template. (maybe later used again?)
why CommitList if class called `CommitsList` ?
Is that a special bootstrap class?

-- 
Renaud Gaujoux
Computational Biology - University of Cape Town
South Africa


On 20/06/2012 15:37, hadley wickham wrote:
>> @@ -41,6 +41,14 @@
>>
>>         <div class="row">
>>           <div class="span8">
>> +
>> +          {{#citation}}
>> +<div style='text-decoration:italic' class="alert alert-info">
> I think `<div class="citation">` should be sufficient.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hadley/staticdocs/pull/27/files#r1017573