labofsahil/github-event-dataset-2012 huggingface dataset:
Sent from my iPhone

On 22.12.2012, at 14:00, Victor Julien <notifications@github.com> wrote:

In src/source-ipfw.c:

> @@ -352,6 +353,15 @@ TmEcode ReceiveIPFWThreadInit(ThreadVars *tv, void *initdata, void **data)
>          SCReturnInt(TM_ECODE_FAILED);
>      }
>
> +    /* set SO_BROADCAST on the divert socket, otherwise sendto()
> +     * returns EACCES when reinjecting broadcast packets. */
> +    flag = 1;
> +
> +    if (setsockopt(nq->fd, SOL_SOCKET, SO_BROADCAST, &flag, sizeof(flag)) == -1) {
> +        SCLogWarning(SC_WARN_IPFW_SETSOCKOPT,"Can't set IPFW divert socket broadcast flag: %s", strerror(errno));

This shouldn't be a warning if it's actually an error, which it seems to be
since we return "failed"

I just copy+pasted from the setsockopt() call before this one, so maybe
both need to be changed?
More documentation for the extension point, please.
I run into a weird problem here in JRuby.
In IRB Time.at(333).iso8601 works just fine.

But when executing logstash, I get an exception "undefined method `iso8601' for 2012-12-03 00:15:35 +0100:Time".
I did require "time"!

Someone else apparently did run into this issue as well: http://www.ruby-forum.com/topic/3228776
A small principle I had while writing the usage example is that someone should be able to paste it into ghci and see a result. That kind of instant satisfaction leaves people happy.

Is it possible to approximate that ideal for these? For example,

    gists' (Just ("github-username", "github-password")) "mike-burns"

Or perhaps:

    let authInfo = ("github-username", "github-password") in gists' (Just authInfo) "mike-burns"

Or perhaps some other way to make it such that the end developer isn't frustratedly looking through docs.
great question. I don't see any reason why this would cause issues, but the right way to do crypto code is to be *extremely* strict. I will build this into jwcrypto:

https://github.com/mozilla/jwcrypto/issues/35
eliminate todo.  likey that work won't be done!
Oo--I had no idea make_aware existed. That's nice.
Ick.  I would rather see a fix for that broader failure - we should either terminate, or fail more cleanly, when we can't parse something.  This feels like a bad deal to me, but maybe @ahpook has a different view.  At this point I think I need to punt it up to him for a third view.
That's what's I was originally going to do - but I discovered jruby/jruby#172 and @tenderlove suggested I use `Dir.chdir` in rack/rack#389
Nice.  I had thought I needed to declare at the top for JSHint.
I forgot to remove the entire block for the test on 'mode'. The 'mode' parameter is not supported anymore.
Fixed.
Doesn't actually start there
No it isn't. You suck I should do it this way!
you should probably switch your ZF deps to beta3
Lower it to just `2`, IMO should be enough.
php 5.4 only.
servers = new[] { new DataCacheServerEndpoint(configuration.AzureCacheServiceUrl, 22233) };

Took me the longest time trying to figure out what you were doing here.
Please remove the inline comment, and the extra space here: `['http:method'] )`.
ups... it is..  how should I fix this?
can you keep go free range in there as well please, thanks!
Tehty muutos ja commitoitu.
Please fix that to 2.4, this will not be in 2.3 anymore
Ya I don't know why. The same thing happened with the card game app I'm building now though, maybe I'm not setting up bootstrap correctly?
with typespecs this should become less of an issue as you can annotate argument names.
movementX and movementY should be 0 for all mouse events except for mousemove.  Firefox has a bug which causes it to set non-zero values for those properties, and that breaks the assumptions of some pieces of code.

The reason that I did not do this in getMovementX/Y is that this only needs to happen for mouseup and mousedown and only when pointer lock is active.  All of that logic doesn't really belong in getMovementX/Y.
A nice to have would be to put these divs inside the fixture so that they are recreated every time. I don't know how well that'll work for your tests though
how about:

```ruby
@dependent_destroy = (:destroy if options.delete(:dependent_destroy))
```

seeing as you're saying `!= false`, wouldn't it be fine to accept any truthy value?
Yes, I will change that soon. Should be by today evening. Thanks.

From: Luke Campbell <notifications@github.com<mailto:notifications@github.com>>
Reply-To: ooici/coi-services <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Tuesday, October 23, 2012 10:41 AM
To: ooici/coi-services <coi-services@noreply.github.com<mailto:coi-services@noreply.github.com>>
Cc: Swarbhanu Chatterjee <SChatterjee@asascience.com<mailto:SChatterjee@asascience.com>>
Subject: Re: [coi-services] Removes transforma. Fixes on_quit() of a couple of transforms by calling the base class. (#321)


In ion/services/sa/test/test_activate_instrument.py:

> @@ -344,7 +344,7 @@ def test_activateInstrumentSample(self):
>          self.addCleanup(self.imsclient.stop_instrument_agent_instance,
>                          instrument_agent_instance_id=instAgentInstance_id)
>
> -        gevent.sleep(2)
> +        gevent.sleep(4)


You should never be using a gevent.sleep try to make it either asynchronous using gevent events or use a polling mechanism.

—
Reply to this email directly or view it on GitHub<https://github.com/ooici/coi-services/pull/321/files#r1916705>.
Edited it so that it will appear when creating new works but not when editing complete ones.
"contact Support" would be better link text than just "Support"
```super``` もブランチだね。
Good call - fixed!
Cleaned up with inject and better use of Nokogiri.
https://github.com/SpoutDev/Spoutcraft/blob/master/src/minecraft/org/spoutcraft/client/packet/PacketGenericBlock.java
https://github.com/SpoutDev/Spoutcraft/blob/master/src/minecraft/org/spoutcraft/client/packet/PacketGenericItem.java
https://github.com/SpoutDev/Spoutcraft/blob/master/src/minecraft/org/spoutcraft/client/packet/PacketGenericTool.java
https://github.com/SpoutDev/Spoutcraft/blob/master/src/minecraft/org/spoutcraft/client/packet/PacketGenericFood.java
Fair enough this was copy paste from Consumer. :-)
On Nov 22, 2012 2:29 PM, "Devan Goodwin" <notifications@github.com> wrote:

> In src/main/java/org/candlepin/model/UpstreamConsumerCurator.java:
>
> > +        return super.create(entity);
> > +    }
> > +
> > +    @Transactional
> > +    @EnforceAccessControl
> > +    public void delete(UpstreamConsumer entity) {
> > +        super.delete(entity);
> > +    }
> > +
> > +    protected void validate(UpstreamConsumer entity) {
> > +        // #TODO Look at generic validation framework
> > +        if ((entity.getName() != null) &&
> > +            (entity.getName().length() >= NAME_LENGTH)) {
> > +            throw new BadRequestException(i18n.tr(
> > +                "Name of the upstream consumer should be shorter than {0} characters.",
> > +                NAME_LENGTH));
>
> This might bite us, it probably shouldn't really be something you check
> downstream as it's already set in the manifest. At best here we're just
> going to cause someone irritation, would probably be better to leave it to
> the manifest creator to enforce a rule like that.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/candlepin/candlepin/pull/116/files#r2208066>.
>
>
It seems like this should be manipulating the this.$.selection object - look at how it's done in nodeTap(), for example.
ok fixed that, can you see it in this request itself?
Should be "Since 5.0", 4.7 was branched off 1.5 months ago :)
Done :ok:
to find the ones wich [...]
I asked you ti fix it in different pull request. Please make fixes in appropriate pull requests.

Merge this changes to master -> master pull request
название приумай уже
I'm not so sure on the relocation of shipper.conf to conf.d. The idea originally was to allow a "base config" and use conf.d for fragments from other cookbooks.
new-style class next, 
http://www.python.jp/doc/2.5/ref/node33.html

I don't know. thx.
https://github.com/mozilla/Addon-Tests/blob/master/pages/desktop/base.py#L86
I'm just trying to follow the same patten used in other similar calls
I will update the locator.
it's more a sense-of-smell than anything, but it smells bad that you're const_casting away the 'const' you're promising on both paths through here. why not just remove it?
Not required as 'text' field is used below but 'text' is the default for a tree panel
`debug` should be destructured in the arg list. And `(if (do [...]))` is equivalent to `(when [...])`.
Of course, just doing `principalUuids = principalUuids || [];` does the trick.
Not sure what `ignored?` means here.
Did I misunderstand your previous comment during the last round of review?
mhee. It is a launch configuration delegate for scala application (not a launch configuration). It is kind of missing 'Debug'. There should be a ScalaRemoteLaunch... for remote debugging soon, and ScalaEquinoxApplication, ScalaJUnitEquinoxApplication.
Why indenting more here?
Yay for parameter names! :clap:
Why not inlining this inside the ``react``. It's not used anywhere else (or maybe I'm missing smth?)
о. приїхали :)
в Symfony2 валідатори є готові для перевірки зображень.
It gave us a lint warning, but I'm fine either way.
for a packaged app to work you probably need to do ``/index.html``. Did you try it out in the simulator?
can we place this and the following GETALL end , inside if debugEnabled block?
This is locked to 2.5.x to prevent any API changes from breaking the gem accidentally.  This is why I didn't cherry-pick gitlab's optimistic patch.  I update the gem deps reasonably frequently, so this should not be much of an issue anyway.
Oh, my bad, didn't realize that `[.]` is an idiom for `\.`.
Зазорность в том, что эти поля не уникальны для каждого из обьектов, а общие для всех. Значит они должны быть не полем обьекта, а лежать где-то в классе. А сделать очень легко - можно, например, прямо под `@implementation` положить 
```obj-c
static NSString *nucleotides[4] = {@"A",@"T",@"G",@"C"};
```
:)
Старайтесь называть переменные по смыслу, это упрощает чтение программы. Например:
x1 — dnaElementToReplaceStr,
x2 — dnaElementToReplaceInt,
x3 — elDnaCurrentIndex,
x4 — elDnaRandomIndex
nucleotide может быть равным предыдущему, заменяя например A на A, фактической мутации не будет, о чем будет свидетельствовать hammingDistance. По теории вероятности mutate будет работать на 0.75*percentDNA
Hmmm, I don't know about this one. For instance it makes `--nodedir=~/node` not work.
nitpick here, but we always have 2 spaces between methods, 3 between classes
i dont see any harm making this the default, since it's just a comment, so we could remove the method below, and the conditional
There is no such feature in cucumber-tck. Do you have it on your local repo?
worth sending this to crew or techteam?
:+1: `rac_subscribeSelector`
When would you be doing that and not using `RACSignal` sequencing methods?
What do you do for the rest of hubot then?
Ok. I'll back them.
Why is this a pointer? The function expects an int.
It may be better to rename this parameter "Fs" to be consisent with other parts of python-mne (eg. mne.time_frequency.tfr.morlet).  However, I've only used the functions under mne.time_freqeuncy, so "Fs" may actually be the exception to the rule.  Either case, as an end-user, consistency among parameter names would be very useful.
this can be an API breakage. I am seriously considering a class SourceSpaces that would behave as a list like so far but would have an info attribute.

Maybe we should keep this for after the release...
But this one is more difficult, I fear. If not preloaded, all is fine. If
preloaded, what then? Additionally slice / reduce the data According to the
key?


On Thu, Dec 6, 2012 at 5:24 PM, Christian Brodbeck <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> > @@ -463,19 +493,30 @@ def __repr__(self):
> >      def __getitem__(self, key):
> >          """Return an Epochs object with a subset of epochs
> >          """
> > -        if not self._bad_dropped:
> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
> > -
> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
> > -        epochs.events = np.atleast_2d(self.events[key])
> > +        epochs = self.copy()
>
> You are still duplicating self._data
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2337111>.
>
>
I think both are fine, do you want me to go through the package and change it?
Yep, I didn't mean to have those removed...
maximums -> maxima
The very next line says to look at the ES docs for details and the line after that has the link.

I'm not sure offhand to make that clearer, but if you have ideas, I'm game.

I'm not sure I want to talk about indexing here since ElasticUtils doesn't do indexing (yet) and so there's a lot of stuff that we'd have to assume someone knows in order to talk about it briefly.
Unshielded is not universal.
This will retrieve the latest version of phpUnit; please fix to 3.7.* because phpunit has a history of breaking BC with minor releases
You might want to put a statement after this, or it will break you in a weird spot.

Just put `true` on the line after this so when you enter the debugger you do it in a known state
A convention I rather like is inserting two spaces between the `if` and the `)`. Makes things clearer, I think.
Are you saying that I should remove all "we"  and "our" in my article? Just want to be sure before I start rewriting it, I've been using a lot of those...
I think we have a `bash` code block type - double-check other places on that, I'm not 100% sure
英文逗号换成中文逗号吧。
这里特地做了测试并请教过图像组的永攀同学，认为应该是原说法的错误
I think it's saver to use `path.join(__dirname, '..', 'bin', 'testacular');` as `process.cwd()` might have wired values when this is called from another node child process.
Cool, but it should be commented since it might trip someone up
Why not `return (r > 0 && r < size)`?
Бля, да ты заебал. Больше не буду делать пулы :-(
might be useful to comment that the API enforces a max of 48
can you just do `values = convert(Array{column_types[j]}, text_data[1:i, j])` in all cases, rather than this conditional?
GetDoubleClickTime API should get the system doubleclick time which must be correct. I think it might be related somehow to the TitleBarMouseMove part since this seems to come to play when trying to doubleclick the icon in fullscreen. Something is stepping on it's own toes here :)
this syntax is wrong.  I am not sure what the intent was.  What this actually does is evaluates login-admin symbol (resulting in the function login-admin), then evaluates an empty vector.  So the result of the test is an empty vector, and no interaction with katello will be performed.
please remove these lines
Yes, pass nil in all the places you are passing &error. Then we can merge this.
Use "return StringUtils.equals(...,...)" instead of the if-else cascade.
I don't think this can work. You should return the time, not a time function here.
Thanks, looks like I duplicated this.
awesome work dude.
Oh, you're changing the XML too and deprecating the old stuff. Fine then :)
I disagree on the new meaning being applied on _SKIP_REMOTE_LOOKUP_. First of, it's not the only flag one should apply to avoid return values: cache store load needs to be skipped too; More importantly, the SKIP_REMOTE_LOOKUP flag doesn't mean "ignore return values", that's an unprecise intepretation and considering it as such for this purpose is going to feed additional confusion on its usage.
I don't think this plague of isCancelled checks is the best way to deal with task cancellation. Can't we use interruptions which is a bit more neat?
Is this one not needed anymore? Then remove it.
Done in #229
Also, this confused me until I realised that `self._cells` is a dictionary, not a list.

```python
In [1]: d = {'a': 1, 'b': 2, 'c': 3}

In [2]: print [c for c in d]
['a', 'c', 'b']

In [3]: print [c for c in d.keys()]
['a', 'c', 'b']
```
But even in Control.Snapping we have:

```
                this.layer.events.on({
                    sketchstarted: this.onSketchModified,
                    sketchmodified: this.onSketchModified,
                    vertexmodified: this.onVertexModified,
                    scope: this
                });
```
Subtle but true. Good catch
I agree that having the constructor locked is not such a good idea, I'll make the changes for it, thanks for the suggestion @stof.
Switch to a multi-line array format.
Don't need the return.

/pedantic
Do these tests work if `bad-value` is a float?
This violated the JavaDoc contract for getDocuments.
No, these are important. However, the `@since` is wrong, it will probably be `@since 4.4M1`.

This is documented here: http://dev.xwiki.org/xwiki/bin/view/Community/JavaCodeStyle#HUseversionandsincejavadoctags
Probably don't need to specify `None`, as it's the default for `.get`
Should the type for parameter ``$httpResponse`` not be "HttpResponse|PhpResponse" instead of "PhpResponse"?
Also found this: http://packages.python.org/an_example_pypi_project/sphinx.html#includes  Sounds like the example presented here is what you suggested.
现在只支持object的形式，reponse-send中的json接口也只支持object类型的
We don't actually need a JObject here. A generic object will do.
Should this (MyView) match the name of the class?
i kind of liked inject true. seems more efficient, but agree that it is not very clear.
This is no big deal, but extra poitnts if you add a `element = null;` so that IE gc can collect the element.
When would the last `|| '0px';` ever execute ... since replace should always return true, unless result is a `''` ? But then the following line is `if (!result ...)` so then you could add `if (result && hasBackgroundPositionXY ...)`

Finally, is the `/(top|right|bottom/left).test` check really necessary? Looks like regardless you're checking for `namedPositions[value]` and default to the matched value ... or false if the value is false. Which in that case just do `return (!value ? value : namedPosition[value] || value);`

or

``` js
if (namedPosition[value]) value = namedPosition[value];
return value || '0px';
```
Should it be lxml=3.0.1?
Done :sunny:
`form.cleaned_data.get('gender')`
Use `pip freeze` to see the format and version to put into `requirements.txt`.
Haha, much better yes.
It looks like `timesince` itself has support for adding an "ago" suffix if you pass `bare=False`. It might make sense to add support for a language-specific prefix there as well to mirror timeago. Then you could just pass `bare=False` in this function.

What do you think @kemitche? Is a language-specific prefix and suffix sufficient for translators to handle fuzzy times, taking them out of the containing translatable string? (see the strings changes above)
Warum machst du das mit asserts? "According to [Effective Java by Joshua Bloch] (java.sun.com/docs/books/effective) using asserts has a negligible effect on performance. [...]"
does it really need to be public ? Using a private method as callback for the ``replaceQueryParameters`` callback instead of a closure would allow makign thsi method private, thus removing the need to mark it as ``@internal``
There is no guarantee that there will be just a "start" and "end" response callback. If the server chunks the response then there could be more. So I'd prefer to have an array of `response_parts`.
This file is not needed either.
Right. The point is that `communicate` shouldn't be passed an empty string if the process isn't supposed to get anything on standard in.
let drop the line if we don't need it anymore
As mentioned above: "ok".
Prefixed is -45, so it should be -135 here? Won't check deg further down, maybe I just got it wrong.
Ah yea, misunderstood you at first. Thanks.
Ditto `IsScoopable`. Also, the scoop code should probably use this rather than whatever check it does right now (didn't check). Assuming its a trivial change, of course.
does this mean that the required shape is (G*N,) ?   
"stacked next to each other in row" is not clear to me
I did not find the name `res_trimmed` appropriate (because I do not understand what is "trimmed" regarding that instruction).
Not good. `from piplmesh.account import models` or use relative imports. But not this.
the add-on doesn't have access to filesystem/FileCurl.h and tinyXML/tinyxml.h on windows
I'm not sure if there is any functionality around Guard methods yet. This example just uses plain knockout bindings to this computed.
Yes, this is what I (actually Matthias) meant.
@gsadowski Greg, I think this might have to do with your previous story with the order ids? This was here in the code before I touched it.
would you explicitly put the POST here.
@esc24 or @pelson, do you have any comments on this?
We should add an example here because it is not easy to understand what method does.
There's no specific guarantee that the `id` field will come first. It would be better to match the `id` field specifically, perhaps using a separate generator. Maybe something like the below, assuming it works (if we aim to maintain backwards compatibility and not return other fields):

```erlang
[ {Index, Field#rpbpair.value} || 
             Doc <- PBDocs, 
             Field <- Doc#rpbsearchdoc.fields,
             <<"id">> == Field#rpbpair.key ]
```

On the backwards-compat note, if we intend not to return other fields, the `fl` field in the request message should default to `[<<"id">>]`.
debug, I guess :)
I'd just do `testApplication = new TestApplication();`
I think it could work with either but in this case createLink probably makes more sense because we want to point to a controller not a static resource like a css file. Here's what the documentations says:

http://grails.org/doc/latest/ref/Tags/createLink.html
http://grails.org/doc/latest/ref/Tags/resource.html
c a c'est un point tres interessant.

je trouve vraiment que tu devrais te focaliser sur quelques points e nprofondeur plutot qu'une vue super high level de tout qui n'apporte pas grand chose
This needs to be declared as `extern(C) static` since it's used in a callback by a C function.
It goes all the way now ... But I'm considering doing it not just for arrays, but general collections. I'll give it a thought.
This closure caused an issue
This is bubbling entries with names that contain the search term to the top. The new code just calls out to the content template, so we lose the sorting. @nacin is there a way to weight the sort results so that we don't need to do this?
You didn't have to close it. You can commit your changes and the pull request will be automatically updated. Take a look at the help on pull requests.

And don't forget to provide tests for all your changes.
I've removed spec/spec. So, now there is only spec/   ^^
add os %% assim.```.with("and AERONAVE.NOME like concat ('%',?,'%')", origem)``` é melhor pra entender e faz a mesma coisa que

```String.valueOf("%"+request.stringParam("nome")+"%");```
I think that you always have to pass variables into these blocks - you can't use them as properties of other objects.  That is, use:

    {% blocktrans with id=notification.id %}
    Notification #{{ id }}
    {% endblocktrans %}

instead of:

    {% blocktrans %}
    Notification #{{ notification.id }}
    {% endblocktrans %}
Please add fakeroot to the dependncy test, does not come with OS X by default.
Will be updated in a new pull request today
Why are we allocating on the heap these vectors? Looks like a way to screw up cleanup. We either keep them always on the stack or move them to the heap...
And what should happen for the other values? Return false?

If these are to be restricted to ASCII only, then it might be worth thinking about not using the system's isalnum etc. at all, but rather to provide custom implementations. Just like backends/platform/wince/missing/missing.cpp does.
Done. Removed readme.
zuh?
Remove this before I gut you.
s/testDefaultContructor/testDefaultConstructor
Might be nice to have this conditional only in one place
If we end up using essentially the same responses several times in the tests, can you define them centrally? That way, if the format changes, we don't have to rewrite the data for each test. Then there's less chance we'll forget to update one.
(float) 3.1415926 == 3.1415926f
Это странная проверка. С пустыми параметрами надо usage показывать.
На самом деле слова - это всё, что не знаки препинания и пробельные символы.
Yep, thanks. I'll fix it.
ah, ok, it is for the multi-output random forest. But there the sets of classes are the same for each output, right? @glouppe ?
The ever_active_set is also needed in the basic use case (Simple, one alpha fit with ElasticNet), it can't be stored in enet_path then.
I think we don't  usually worry about forward/backward compatible pickling. It seems pretty hard to do in a way.
So, I thought about this, but staying in sync with the version of the docs you are reading (dev, stable, etc) will be hard...
I'd rather use `"zero_one"` (underscore instead of dash) as I think is more common in the rest of the project.
Indeed, this is not the softmax function for MLR. It can produce *very* different results. The code can be shortened, though, I might do that tonight.
All non-structs are POD.
please comment here which kind of expression this reg exp is looking for to match
This is wrong because of all the extra information added by the macro and the tags are different. Please use TiLogger directly and give it the correct tags.
Bonus tip: keep in mind that the TI_* logging macros may not get compiled into release builds, though that decision hasn't been made yet.
Si l'utilisateur accepte, il est redirigé à l'adresse suivante.
Should be `$timeType`, not `$this->timetype`.
Sorry about the previous comments on this one. this is actually ok :)
I will do that =).






grrrr... he found something :p...
This would be much more efficient if you changed LuceneSearcher.getSuggestionForFields and changed the query so that it was a prefixQuery.  It would also get better results (I think).

Could you try that.  

There is a commented out section:


		// FIXME : need more work on LQB
		if (!searchValue.equals("")) {
			elData.addContent(new Element(searchField).setText("*" + searchValue + "*"));

that should work if you remove the first * for your prefixed search.  The LuceneQueryBuilder would ideally be changed to have a prefix option as well but it doesn't so you should be able to do something like above.
ok, then we should raise a new issue to fix that
@ghalliday - have added some comments
There should be no ${DIR_NAME}.
No, default is uncompressed (as before), need rw_compress to be compressed.
If you do that, you have to use `form = MyForm(data=request.GET)` which is actually the correct way to use it. But we're not using it. 
...until now. 
Will fix.
Then I'll leave you to it. I thought I was observant when I spotted that is all.
Fixed in 63f196ba04b83d26e2cc334c1a19a0a32b8971d1.
The indentation is wrong for `onClick` and `attach` ending brace.
This means that in other scenarios there might be classes with height different from 31px
make an exception
@shacker great, even when we know they will be changed in the future, it's usually better to optimize them beforehand.
Thanks, @yuhunglin , this is a good catch since we're now sometimes loading user data before first-login.
@shacker even though this is dummy, can we use 2 spaces?
Avoid camel case for variables.
NEMO_GSTREAMER_THUMBNAILS doesn't really need to exist in here anymore, right?
Will change ( I suppose you meant QString(hashKey.left(2)); )
It's related to my comment above:

"
Having a rescue here seems a good idea for me, but you're handling exceptions also in the "execute_command", "get_output" and "cleanup_after" methods. In the handling request you're doing in these methods, sometimes you just "return", so here you are not aware of errors... and you can execute both three methods even if one of them fails. See #1011 for an exemple of such situation :)

Please, feel free to ask again if my explanation isn't understood :)
"
use consistant line breaks. i.e. with `only_integer` method there is a line break before returning `self` here there isn't
Ahh, cool. I didn't know that.  Guess I should read email more ;)

Thanks dude

On Tue, Feb 28, 2012 at 7:57 AM, Pete Muir
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,37 @@
>> +Logging Example
>
> HTML versions of the READMEs?
>
> They are now generated during a release.
>
> On 28 Feb 2012, at 13:55, Joel Tosi wrote:
>
>>> @@ -0,0 +1,37 @@
>>> +Logging Example
>>
>> Hey Pete - are we no longer doing the HTML versions?  I looked at a few others and that appears to be the case, just wanted to make sure.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/jbossas/quickstart/pull/114/files#r496096
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/114/files#r496098
Fair enough.

Matthew Riley MacPherson | http://tofumatt.com
(Sent from mobile)

On 2012-02-22, at 18:37, Owen Coutts
<reply@reply.github.com>
wrote:

>> +                if (data.meta.previous === null) {
>> +                    // If this is the first response lets note time updated
>> +                    updated = data.updated;
>> +                }
>> +                if (data.meta.next !== null) {
>> +                    // If there are more items in queue keep going
>> +                    app.Profiles._get_data(data.meta.next);
>> +                } else {
>> +                    // If this is the last page, store the original response
>> +                    // time
>> +                    context._set_updated(updated);
>> +                }
>> +            });
>> +        },
>> +
>> +        // Performs a search. Looks for objects that match the query and
>
> To me, my comment reminds me better of how my code works.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/mozillians/pull/123/files#r478336
Fixes camel case for column name
Do you think a center of `(0.0, 0.0, 0.0)` and a radius of `0.0` are sensible defaults?  We want to avoid exceptions like these when possible because they force users to know the values when constructing the object, but many times the user won't know the values until later.  For example, this is common with positions for a polyline.
No one creates a texture atlas with `new` - show them how to use the `create` function.
Haha, one time I decided to try a different letter and forgot about it until now.
Somehow missed that in the docs. Seems like this is OK then.
Should be explicitly assigned a value (even if it's `undefined`)
Needs spacing
My only worry with changing this value is in the case that the developer has saved off the reported code in JS to compare against.  If we had a constant for this exposed via Kroll this would be a non issue.  Unless there is a reason otherwise, I think this should retain the original value of 2 in case any existing apps are relying on this.
This should be:

    logger.error(__('%s is not a valid entry name', key) + '\n');
I don't get this error, but in your case it seems `\L` is interpreted.
I updated the doc without the quotes.
Feel free to take this out of my hands, I just wanted to help unlock the missing doc but you're obviously much more knowledgeable than I am about these topics :-)
Can we also set connected to false in the Connection constructor?
you want me to put a comment in saying I was lazy? :-P
One line between functions.
Rails states inside of the application.js file that:
// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
// the compiled file.

I'm wondering if it should be imported in the _head partial instead of here.  Perhaps before the inclusion of:
    <%= javascript_include_tag 'modernizr-min' %>

It would seem you almost have a precedence there.
Spurios trailing whitespace -- never a good thing :)
I need `Cycle` to be const-correct for some stuff that I'm working on. This is currently necessary in order for it to be const-correct. I'm fine with removing it once it's unnecessary, but it _is_ necessary right now in order to get this functionality.
But the whole point of the `RefRange` is to make it so that it _is_ the original range, only now it's being passed around by reference, so it gets affected by the functions that it's passed to rather than being copied when it's passed. So, _any_ operation occuring to the `RefRange` also occurs to the original. Saying

    x = a;
    x = b;

    is tantamount to saying

    a = b;

because `x` _is_ `a`, just wrapped.
eventually, yes. right now it's too painful to launch dartium at all
maybe we can use an alternative name here?
What would this method return? All of the information that is retrieved by this method is put into class properties. By returning $this, we can chain method calls.
Is there a reason you are firing these off on the document object instead of targeting the individual classes/objects with jQuery?
@adrexia I just found that we're missing a comma here, could you please make a new pull request and add it?
Why do we do this at all? It should accept any string, not just a `'dash'` or "something else".

While you are improving it, could you do that? 

     function url_title($str, $separator = '-', ...

If somebody enters `"dash"` then turn it into `'-'` for backwards compatibility.
The actual symbols in the binary are:

OSL_NAMESPACE::OSL::func
we "use" away the first namespace to get at OSL in the source.

In OIIO the symbols are:

OIIO_NAMESPACE::v123::func
we alias the top level to OIIO and "use" away the second namespace.

In both cases the two levels seem unnecessary. We could get away with just:

PROJECT_NAMESPACE::func

and then the alias:
namespace PRJ = PROJECT_NAMESPACE;

to keep source level compatibility.

As you said, after this cleanup it will be easy to change these details though.
Давай-давай, осиливай.
Another blank line here
It'd be cool if the notice was different when the :cc_foo is found, "Company set to foo", etc.  Exact verbiage TBD, maybe it doesn't need to say anything at all.  @jsonin, what do you think?
@stof If you start testing on actual output from an external filter your tests will break if the filter for instance changes an algorithm, no?
This lead to massive code duplication, I'm not sure this is really better.
@andralex,
this your comment shows that you think `destroy` can be used in templated code. And I'm sure it is incorrect as `destroy` behaves differently for different types and you **always** have to wrap it in `static if` or you will get compilable program that will fail at runtime once because you didn't predict some case of `destroy` behavior.

I was wrong. I don't understand what is going on in your brain at all. Please, do not be hurt, but when I'm reading your posts about `destroy` I think that you do not see this problem at all and you even don't want to try to see this problem.
"Empty argument list can not be mapped to the Message unless a 'payload-expression' is supplied"
So, we can arrive at this else block even in the case where 'correlation-key' is NULL (not "JMSCorrelationID"). If the consumer that generated the reply happened to return the original request JMSMessageID value in the JMSCorrelationID property of its reply, then that value would go into the jmsCorrelationId variable here. Is that intentional?
I think you might have missed my point; you have 3 options

* fixed name
* expression
* allowDynamicStoredProcedureNames

All I am saying is you only need the first two because you can use an expression to get the jdbc_storedProcedureName header.
Good morning, Gary!
Nice to "read" you! ;-)

Sorry, I don't understand you now: do you agree with me or not about redundant requirement of 'default-delay'?
I think we'd rather avoid regions like this; they don't add much in a single-interface-only implementation.
the "See this section" link leads nowhere.
This should be modified to use paths.crontabs instead of g.nhw_crontabs.
I think the values are supposed to be comma seperated, not spaced.

Diego was it planned to handle class constructions in tested field? debain_6 and x86_64 as in above? Could be interesting but I don't want it to blow up the forthcoming tools.
This is what made the actual "height for width" part work though, that is that the constraints could adjust the height of the box as needed when the width was changed. I'm not sure how to get that part fixed in Lion.
Where is set the `instance_role` key? In `solo.json`?
No need for format if nothing is formatted.
PSR-1 and $domain_name. Why do you need to be able to call a mutator without a variable, ie. why default set to `null`?
that would produce some interesting results. good catch
We usually import messages like this:
```python
from horizons.messaging import ResourceProduced
```
Why use floor here? I think it's useless.
OK. I made the changes.
This was just random cleanup.  No association with the split-out (other than the addition of another ignored dependencies folder).
Oops. Thanks for pointing out the redundancy. I find the question response validation and grading api a bit confusing. I should have looked more into this.
Let's start this library by being up-to-date -> `transition` is now un-prefixed.

(this may also save us from some event listening trouble down the road.)
I think is not the same having scroll and being multiselectable, i mean, im ok setting the aria-multiselectable="true", but it could be multiselectable and not having scroll
The format of yourCallbackFunction.language is the same as blackberry.system.language property.
Changed it around a bit to hopefully make more sense.
@Observes ArquillianDescriptor 

You can observe the creation of the ArquillianDescriptor directly instead of relying on being executed after it within the same phase.
It should contain brackets for easier extension of code:

```javascript
if (t == "string") {
   v = '"' + v + '"';
}
else if (t == "object" & v !== null) {
   v = this.serializeJSON(v);
}
```
spaces, and on L48 below
Do we use this anywhere? May be a great time to just remove.
don't need to label this section twice
That's a good point.

I have like 3 safeway cards with no forms filled out.
Granted, they can still connect it to you. But who likes filling out forms?
Sorry to nitpick, but WW does not support pre-5.x