labofsahil/github-event-dataset-2012 huggingface dataset:
I'm so sorry, its actually my first pull-request and I guess I was a bit
nervous..

I just realized what the problem was after I submitted the pull request. I
will make the change in the source file and submit the pull request, maybe
in a few hours!

Sorry again !


On Thu, Jan 26, 2012 at 9:23 PM, Jerome Gravel-Niquet <
reply@reply.github.com
> wrote:

> There are issues with this:
>
> 1. This should be optional. Perhaps turned on by default, but at least it
> could be turned off.
> 2. Any new code needs to be in the source files, not in the compiled
> files. The source file for this is `src/browser/documentup.coffee`
>
> You don't have to compile it afterwards, I can take care of that.
>
> If you don't feel like fixing it, it's alright I was planning on doing it
> anyway. I would just want it to be done right.
>
> I appreciate your involvement though!
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/hardikr/DocumentUp/commit/0dff512471ed9d37aab92e735fe8d87a8c43ffa5#commitcomment-906999
>
Since the client will be running persistently, we want it to log too, so we move the logger configuration up a little bit.
Hörr!
I really like the look this gives the page.  Very fancy!
I think removing this catch could be a bit dangerous. The "try" block executes a callback but your _actual_ callback is actually nested in at least 2 more callbacks. If by chance any of the other intermediate callbacks before yours throws an exception other than a WebException, which is quite likely, your callback will never get called and you won't be notified of the exception.

This kind of has been a pain point for a while and haven't seen a good solution for it yet.
This is a trap. Nothing in a method name called setExecutable() would lead me to expect the whole argument list to be cleared. 

If clearing is required, better add an explicit clear() or clearArguments() method.
oh, damn i missed that (was distracted by the load errors in the console since i had a cleaned wc >.>)
I'll send another pull with this fixed properly, I think i will modify tests/test.js to make it possible to change the behavior. so that this test will be able to run as the others from source and with the test,js file
Could you wrap the docs at 78 characters? Makes editing much easier :)
fwiw, massive amounts of things would behave unexpectedly in our framework if that style was applied to unexpected places. I'm not sure that's a bug - true of most CSS structural properties



On Feb 29, 2012, at 8:46 PM, Markus Staab wrote:

> i will prepare a jsfiddle...
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jquery/jquery-mobile/commit/84f1e4f257268b4b8d6132065263702e61074797#commitcomment-1025916
So this means that browsers like iOS4 and Android 1.6 will get the "floating" toolbars that jQM 1.0 had then? Awesome! (The static positioning can be confusing for users if the mobile page is long.) Is this going into jQM 1.1 or 1.2?
the class names are not specific enough
anal ....   好邪恶
Note clearing cookies was handled differnt in the merged branches, so please send testfiles or information if you have problems deleting items
I'm not sure about api/soap/mc_project_api.php like 325 and 434... I suppose if the calling program uses this date notation it would also be required...
Boa Well, era esse esquema de methods mesmo que eu tava falando. Amanhã vou ver se construo o init dela pra testar :)
Sure, I'll happily do that, but I won't be able to go into detail before at least Thursday I'm afraid.

With 42b8385a404554a3e768ed59c3828a914fc62fdb, I get

    jasmine-headless-webkit -j spec/jasmine.yml -c
    
    Running Jasmine specs...
    ........................F...................
    FAIL: 44 tests, 1 failure, 4.588 secs.
    
    
    Flotr Plots should draw a `Advanced Markers`line graph. (Flotr2/spec/Flotr.js:3)
      TypeError: 'undefined' is not an object
    make: *** [test] Fehler 1

When using the pre-built library, I get some issues with empty charts with mouse tracking enabled, i.e.: series is undefined in flotr.js:5116
    xaxis = series.xaxis;

Apart from that, everything looks fine upon first glance.
what you pass to extend is **not** a relative path. It is a template logical name. and it works, unless you replaced the twig loader in the container, in which case you are on your own to redo the integration work done by the bundle
> something weird is going on. github tells me your comment is "in 4 minutes"...

Dude, I am good!
thanks... I still not using maven... have to figure out how to use it..
Can you make these print to stderr before we merge this to the master?
kann kein client sein, deshalb no bencode
hmmm, this is a bad smell about `setPrev` and `setNext`. This wasn't a special case with `siblingify`
ah, okay, that makes sense.  We can delete these methods until we see a use for them.
Good catch, I did not notice this.
This commit broke the script.
The headers were correct before, with the biggest header using the ======\n header1\n ======= syntax, second one using header2\n ====== syntax, and third using header3\n ------- syntax.    Your changes are against the standards (for the dojo/docs repository).
what do you think about splitting the ``Doctrine\Common\Persistence\ObjectManager`` interface into 2 interfaces ? A simple one with the method used here and the existing one extending it with additional methods ?
Ugh... scratch that. Looking at an old commit. Yah, Github is confusing with this stuff.
_Normally_ I totally agree with you, Ian. But this was a special case:

The repo was corrupted like hell, the next member pulling from it would have left with a bad corrupted local repo. So everything had to be fast.
mattsches knew, that most of the people here who are able to react here fast are on twitter, so he wrote an "emergency tweet" there asking for help. 

GitHub is one of so many social networks I am part of. It is a network I look into from time to time, but I am not informed about comments or changes there. The same goes for the s9y forum. I am not "always on" on all these networks.

But I'm nearly always connected to twitter, as it is on the mobile I have in my pocket always even when spending a nice evening with my wife and some cool DVDs like yesterday night. :D

So I think in this emergency situations twitter as an information service is the best way to get fast help from others. I know, at least mattsches and yellowled are nearly on always there, my coworker dahie (who is my git guru ;)) is on always there too.

But yes: I agree, I should have done some better documentation later on the situation happened. It was in my late evening, when I was relaxing with my wife and I simply did not think about that. I will do better next time. :)
I didn't want to include SharedDefines.h in this file
Halion? LoL
Add rvm as a function.
That's dumb. I'll fix it. Sourcing files should not be printing stuff anyway.
I think a result.Distinct() might be a cleaner way to do this?
perfect work!!! Need for http://ru.wowhead.com/spell=71507 on guards..SmartAI + condition to enable it only during event ))
better: if (uint32 guildId = Player::GetGuildIdFromDB(guid))
No, but the patch of Vincent-Michael will fix your bug.
Damn, I keep doing that. Fixing in a second.
Because InterlockedAdd is only defined for itanium so we need to call InterlockedExchangeAdd on i86.
乱码了。。
Are you sure this only affects the home page?
I'm just new to require.js, Backbone.js, and underscore.js. To solve me issue with "Backbone is null" I did as recommended:

define(['jquery', 'underscore'], function($, _){
  // paste Backbone.js source code here
  return Backbone;
});

However, it seem I have to wrap underscore.js as well. So, I did it like this:

define( function(){
  // paste underscore.js source code here
  return _;
});

I'm just wondering whether this is a valid approach without causing any side effects?
Hier kann man auch abkürzen:

```php
<?php
$this->i18n('install_modul')
```

Wenn man über das Package-Objekt übersetzt, wird "xform\_setup\_" automatisch hinzugefügt...
Sorry for the stupid question, but I do not have experience on github. Can I delete a repository in my account, but the changes were in the official repositories?)))
Ok, that's cool. It took some digging around to get that sorted and working... :)
This NPC was added in patch 4.2.0 not in 4.0.6, where is the joke then?.
This Script is assigned to a creature_template that not exist in 4.0.6 and generate also a ScriptName error.
Ich hab den suchbereich mal n bisschen neu gestaltet...
Te digo que esto y lo que había es exactamente lo mismo xD
Hey, could you leave some comments here? Javascript tends to get messy after awhile and this will be our main container.
@gabebw @joshuaclayton the problem is because shoulda.gemspec still loading old version of shoulda matchers https://github.com/thoughtbot/shoulda/blob/master/shoulda.gemspec
So how do I suggest I do it? The JS SDK we need for the post buttons anyway not just for login. I thought that is was pretty good that it is done in the same way for website, canvas and mobile canvas. So we don't have different ways of doing it.
Because the inner implementation might use a different behavior than RepositorySession's, which uses now().
An alternative could be encapsulating the code in new files TTTAttributedLabel+Markdown.h, TTTAttributedLabel+Textile.h, thus letting users import just the markup implementation needed.
Darn, I should have checked a little better, sorry about the mistake.
addDispositionToRequest is also used by r:script, which causes r:script to die - I have patched it in my code but I'm not sure what the module name is and I can't issue a pull request for one commit (and you wouldn't want it anyway)
This needs to use a release version
On 01/07/2012 12:44 PM, Andreas Gohr wrote:
> This is problematic. You assume that the clearing the index is done within one second and simply start the indexing process. You should start the indexing in the return callback of clear() instead.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/MrBertie/dokuwiki-plugin-searchindex/commit/73c6efcd6d8a4f75f0c193ebfdfe99e616e7347e#commitcomment-845897
No problem, I'm sure there are other things that need attention too!  
Thanks for your advice, I'll try and get those points fixed.
Absent-Minded :-)
Is there a feature detection alternative to determining this, instead of looking at `Y.UA`?
Oh duh! Right you are :)
I'm not sure I agree this should throw an IOException.  Also, throwing a GeneralSecurityException and returning a response puts us in the same confusing boat we had before.

We should either throw an exception if there is a problem or return a result, not do both:
https://github.com/Jasig/cas/blob/feature-cas4api/cas-server-api/src/main/java/org/jasig/cas/server/authentication/AuthenticationHandler.java
Should this be `2.1.0`? 

Ref: http://maven.restlet.org/org/restlet/jee/org.restlet/
Wasn't it noted that this would break scripts in the last pull request? Have to tested this change for compatibility?
Just make sure you're not leaking it to another thread.
:-) you just lost one line of net-negative opportunity
don't run this test on systems with webmin started; OTOH no port is guaranteed to be free.
This line doesn't do anything
I don't think AtomicReference should be visible in the api, isn't that an implementation detail?
Now the value is also changeable from the outside, without going through `refresh`, is that by design?
put extends on the same line please
Yes, I will go through all empty when merging/fixing the immutable stuff.


14 nov 2012 kl. 18:20 skrev "Viktor Klang (√)" <notifications@github.com>:

In akka-cluster/src/main/scala/akka/cluster/ClusterMetricsCollector.scala:

>   *
>   * @param nodes metrics per node
>   */
> -private[cluster] case class MetricsGossip(rateOfDecay: Int, nodes: Set[NodeMetrics] = Set.empty) {
> +private[cluster] case class MetricsGossip(nodes: Set[NodeMetrics] = Set.empty) {

I'd remove the default param and made a no-args apply method on
MetricsGossip to return the empty instance, because right now if you do
MetricsGossip() you get a new instance every time.

—
Reply to this email directly or view it on
GitHub<https://github.com/akka/akka/pull/858/files#r2127026>.
This is straight through to the auth provider (User) via Account (was Session all class methods, or it could be a module, doesn't matter).  The from_params can be generalized (it only uses :login to lookup email, but could be flexible), then send the params again found instance method.  I guess it could be one step with an Account.authenticated? that does this and expression.

I collapsed the password_authentication method here, seemed simple enough and not re-used.
Maybe we could use a blank path for the signal? '' vs 'missing'
Echoing Matthias Ekman's question on the ML -- example of getting the estimates (betas) in addition to statistics for the contrasts would be nice.
Good to know. I'm sure I make that mistake elsewhere and will keep it in mind.
Agreed.  Did not mean to suggest that there was a contract stipulating that managers must be singletons.  Just pointing out that the defacto pattern so far has been that managers define there API using instance methods.
That may be gone already, but I see your point.
This seems like an odd construct (SetPlayCount as well as a member for it, which apparently do different things)
You can create the packet here and just set stop_parse directly.
This isn't the clean way but I wanted to avoid that we load/unload it whenever we init the codec.
Technically it doesn't matter as this just increases the reference count and the dll is unloaded when XBMC will be closed. This is independent to delayed loading.
When a new language is found, a new type is created. Therefore, I'm not using intern because interning just calls __new__, where creating a new type cannot be done as easily.

Instead of interning I'm using def get_singleton_language_type(cls,backend,regex_str).
This was intentionally formatted the way it was.
sorry this is my mistake. Yes in updateClientPersonalInfo should be added the same authorization as the retrieveClientPersonalInfoForUpdate. I add this in the next commit.
Shouldn't this line be deleted? You are already calling stepFailed in KIFTestController.m, and this change breaks any test case where "self" doesn't refer to a step.
In my scenarios, I define a lot of steps inline in the scenario, because they are only relevant for that single scenario. This line causes a compilation error for them.
Is this scoped to the user somewhere?
shouldn't you use MODE_IMAGE here instead of 0?
I would rather that this method have an explicit "false" value check -- look for null, undefined, false, 0, or strings that are "false", "no", etc.  Right now, something that's truthy In JavaScript like 42 would be viewed as false.
Since _layoutCells: is being called constantly while the table is being scrolled, I'm seeing that hidden has to be set explicitly or the footer view blinks.
I'm not disputing that there are advantages. I just don't find them compelling enough to offer on the base class.

I don't understand how they need to be a part of `TUITableViewCell`. There are plenty of drawing and state methods that can be overridden to fully implement the same behaviors.
This property is not implemented in this pull request.
What I mean is a race condition, best described as follows:

1. At time T1 thread A checks with GetEnvironmentVariable(name) if the variable exists.
2. At time T2 thread B removes the variable with SetEnvironmentVariable(name, NULL).
3. At time T3 thread A tries to look up the variable with GetEnvironmentVariable(name, s).

You need to check the return value at time T3. It may not have been initialized.
It´s an extension. It can still be compiled as shared extension.
I'm arguing that for *required* arguments, we shouldn't accept the keyword form. The only reason we'd want to support the kw form is so people can write things like
```
np.add.at(idx=[1, 2, 3], op2=b, op1=a)
```
but... that's a terrible reason :-). And the more calling forms we accept, the harder it is to extend interfaces later without breaking backwards compatibility. Like, for example, suppose we want to change the code later to accept an arbitrary number of positional arguments, because people start making 3-argument, 4-argument etc. ufuncs. The easy way to do this is to treat op2 and all further arguments as a simple list; but if backwards compatibility means we have to continue to accept `op2=` as a kwarg, then the code will become pointlessly complex.

AFAICT this is how plain old ufunc calls work right now (`__call__`, not reduce etc.) -- `np.add(op1=x, op2=y)` doesn't work, and that's fine.
I've added IS_OBJECT.
Please help!  Or else i'll have to help myself.
oops.. sorry. we must assign :serialized or :unserialized to *serialized variable.
Mmm.  OK, I'll take your word for it.  LGTM then.
those 2: "+   *    - Mutable variables that are accessed from a local function are wrapped in refs
+   *    - Since reified trees can be compiled outside of the scope they've been created in,"
??
I suggest to change it and add a comment that links to that CERT page.
SI-5431 is closed as fixed, so something somewhere needs updating or uncommenting.
val fallbackSym = expandee.nextOverriddenSymbol orElse typer.TyperErrorGen.MacroImplementationNotFoundError(expandee)
It also uses formals to take BYVALmode off when typing by-name arguments .
or `rev_mapping = dict(zip(V, terms))` and delete the next few lines.
> I made this change.

Great.

> Also, it would be nice to know if some of the annoying
imaginary residuals appear less often for you.

If you talk about the examples with i-noises parts:
Matrix(3,3,[1., 2, 2, 2, 1., 0, 2, 0, 1.1]).
Well, how do you envision this to work?  I think such a substitution is inherently ambiguous and should not be allowed.  Consider, for instance, that I have the expression `x + y` and the substitution you present.  What should be the answer, `w + y` or `z`?  I am inclined to object to providing both answers, because here the ambiguity arises in the input data, which actually means that the user is trying to solve two problems instead of one.  I would even suggest pushing this further: prohibit any overlaps between patterns and even check for them and error out in case one is found.

Note that, in either case, the user is not at all limited in power: they can easily do their substitions in two steps.  Instead, they are forced to state the problem clearly, by explicitly specifying the order of operations.  You, on the other hand, will be able to simplify your code.
The not integer is redundant here, but I think you need to include Q.rational for the exponent.
Do we need such strict matching here?  I may be missing some edge cases.
Ok, here is some potential reference material for that:

https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt#documenting-classes

Although, I don't know the standard in SymPy is.
I've removed passing the app to the before filter.
Passing in an uv_tty_t makes the child inherit that stdio from the parent. So yeah, that would make sense.
Please make the ````alt```` attribute have the same value as the ````title```` attribute (in case people with screen readers or other similar modalities are viewing the page)
afaik we try to avoid inline style attributes. but I'm not a front-end person so it may be fine. might check with craig to see what our MDN convention is
will the width, height, etc ever need to be changed? if so, their values should be passed in as options
This will return a QuerySet when you want True or False. Try

`return user.groups.filter(name='Mentor').exists()`

For more information see https://docs.djangoproject.com/en/dev/ref/models/querysets/#django.db.models.query.QuerySet.exists
We had quite a large IRC discussion about this a while back and it was decided using Admin would be better to help prevent confusion from the extension manager.

But I agree about renaming Admin to Administration.
Ah, okay, thanks for explanation.
I don't think that's a magic number, I think that it is pretty clear what it is because of the variable name.
`$avatar->process_form()` should only return the 3 elements you see there.
Why is @ there?
Does it really means that Light::isShadow ?
Muss dass sein?
Why `mojito-view-renderer-server-tests`?  Where is this YUI module defined?
We add this because its reused across the other modules.
Thanks for the correction! I've fixed it in https://github.com/NixOS/nixpkgs/pull/151 . 

The licensing note is derived from: http://zfsonlinux.org/faq.html#WhatAboutTheLicensingIssue .
is this test showing up in run-tests.html? as far as i know, xit() won't show in the specs. i think you need to use it() here
already tested for above
"There was a bug"
python25.OrderedDict
A verbose "--" option is usually a complete spelled-out word, so "--package" is better than "--pkg".

Spelling "Defalut"
Question: Should this be more explicit about:


A) whether the option can or must be specified with long or short name, lower case or Capitalized (comm vs. community vs. Comm vs. Community -- what it actually valid?) and 

B) how names are interpreted (e.g. "comm for VoltDB Community Edition, voltcache for the Voltcache Example Application")

C) whether an explicit value of "all" can be specified (if not, I suggest that it should, this also applies to --suite)
I'll add an SQLStatementAdHocHelper class that provides a public interface to the SQLStmt methods we don't want to be public, if that makes sense.
def complex(real=0.0, imag=0.0):
    """Form a complex number.

    Keyword arguments:
    real -- the real part (default 0.0)
    imag -- the imaginary part (default 0.0)

    """
Cis -> CIs
as svg -> as SVG
assertEqual(..., True) -> assertTrue(...)
This looks a bit weird, maybe it was a problem with weird indenting in the original file.
(update-in mmap [k] union v)
Other code uses `if (proc->interface == NULL)`
on the contrary, that was a great suggestion, I just simplified the code because of that
fisher is a name, so it should be written with a capital F.
My idea for this was more along the lines of an empty seek method on the PlaybackProvider that would be called whenever we have an appsrc installed, but this is probably better. Could you extend it to take in caps as well so we don't hardcode spotify caps in the audio subsystem?
Updated this so it's correct.
Does this code handle malformed user agents or will it throw an error?
should be ES_REHAN_FUDGE_FACTOR
The UCS-2 → ASCII patch also process the file in VS by adding and removing a `String Table` item from the `String Table → Open` to avoid that subsequent such edits change other items. The first time this is done it moves lines and add newlines.
All versions of OS X that we support (Leopard onward) provide Ruby 1.8 at this location.
minor formatting (space)
self.field.from_riak(value) feels wrong ... although as it turns out i was wrong about what was wrong ...
ahh gute idee. vllt sollten wir dass dann ähnlich darstellen wie nen SQL error,weils ja vom prinzip nen programmierer fehler ist...
re: 409..I did
can you just do `if (code)`?
* コードから読み取れる情報はコメントする必要はありません。
  * isSourceTypeAvailable
  * 使用可能かどうかチェックする
Oh I see it was to DRY things up. Cool.
I usually shy away from using nested classes, but in this case I'm kind of torn. I like what your doing by hiding the implementation of MemoryTableContext, but I think it may be confusing to find the `Partition` class because it doesn't follow our standard that we use elsewhere to only do 1 class per file.

What do you think?
I never understood why this is `_loadDeviceConfig` when it's not meant to be a private method.
Good call. Trying that out led me to two other issues I fixed:
- disabled the light blue hover background for disabled menu items
- return earlier on CommandManager.execute() when command is disabled

-----Original Message-----
From: Peter Flynn [mailto:reply@reply.github.com] 
Sent: Tuesday, May 29, 2012 6:41 PM
To: Ty Voliter
Subject: Re: [brackets] Fixing Menu Bugs due to new Menu API (#953)

> @@ -226,13 +226,17 @@
>                      background: @item-highlight-color;
>                  }
>  
> +                &.disabled {
> +                    color: @bc-gray;

Now that we have this, do you want to make use of it by setting the "Experimental" item to disabled?

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/953/files#r897416
We may want to remove this comment line :-)
Hope I didn't go overboard :) I also lined up blocks and put lists in alphabetic order.
It's possible to have both a keyBindings arg and existing bindings... I assume in that case we want the one(s) passed directly as an arg to take precedence over the pre-existing ones, so I think the code here does the right thing.  But we might want to add a comment explaining that logic.
This is the case where the cursor is right after the end quote. ie. it is outside of an attribute value and we want to dismiss the value hints if it is still open. Besides, it is not useful to return any tag name since we have nothing to show. That is, it is invalid to enter anything until a space is entered.
We should also add a special case for XML files. Currently, it shows up as Xml.
could you split these up?

devDependencies are for packages needed for running the tests, dependencies are for packages needed to run the module itself. i don't want to force people to install chai, mocha, etc etc just to run the module.
It's not clear what exactly the inputs are for `__call__`. Can you please document it? This seems to be a publicly exposed interface, so the docs are very important.
Sounds reasonable, I'll add a check.
That's just strange to see you commiting a file marked with nfortin as the author :-)
There are any reason for change it or modified. So please, make a inverse commit or use git properly, if you don't know how to use git, read about on google, it is easy when you understand the commands.
Nice approach.  I think I need to do some rethinking on making the shadowDOM easier to manage.  It's kinda a necessary evil as its the most bullet-proof way to make sizzle work as expected and map over styles from CSS.
Please order them in the end. So like profile fields are first and then special fields are last. (You can also put one empty line inbetween.)
the getMediaType function returns that value from the regex, which searches for youtu, vimeo, and soundcloud. So youtube obviously needs to be "youtube" and not "youtu". Vimeo and soundcloud just work ( well soundcloud not at the moment, but it will once the player is rewritten ).
Perfect :D.
I was thinking we we're sure where this page would end up, but I guess it will always be in the root directory of popcorn.webmaker.org
drop an "enumerable: true" in here so that we can see the property in firebug, etc.
Add a "\n" here.
This is a lot of parameters, let's move it into an options object.
You don't need this check, since hours will be a number or 0 based on the above, and multiplying by 0 hours will do the same as not doing this.
Nope! There's a separate `drop` circumstance.
Might just me being anal-retentive/nit-picky, but given you're using an 'HTML5' doctype, you don't strictly speaking need the script type here, or on line 108.
We can add more logic to optimize painting, not only for paintInlineImageXObject
Ah, nevermind then ;)
Are there any const that can be used instead of duplicating strings like this?
ok, hacking at it
@jlsherrill updated if you will take another look
We need to make sure things happen in the MapHubs call not in the per request call, if that's what's happening then it's a bug we can fix.
Verify this group doesn't exist as built-in
IPAC table files *often* use ``.tbl``, but I agree it's a bit generic. I can remove it.
did you mean `return np.interp(self.error, new_lookup_table, old_lookup_table)` and if so, what is this meant to do? It seems specific to 1-d data.
I can't tell if that typo is on purpose :)
Ah I missed that thanks.
It's better to check for `is_callable()` here. Function call_user_func_array() could return `false` if Validation method doesn't exists or isn't visible in given context (which should be an error/exception, not invalid model data). Maybe I'm wrong, please check/test this case.
Are we settled on how we're going to do releases? I think we should agree on a release process etc. before adding a CHANGELOG to CGXP.
So you replace the default validator with one specific for federated login? Does it just call the default one if it fails?
While we appreciate the effort you and your company put into the Fork CMS development, the Fork CMS source code is no place for advertisement.
The reason for including @authors is for people to be able to directly contact the contributors in case certain code raises issues. Please consider adding your personal contact information (of course the email address can end in @siesqo.be)
Didn't think of that, but obvious really :)
As I explained above, that is probably not a problem, since that is only used internally (it's not documented). If people want to create incrementing columns, they can just use the `increments()` helper.
The user's common sense and good taste when it comes to C. ;)
Right, but that leaves us with `LIBGIT2_VERSION` as a narrow/non-wide (?) string. Adding `#define UNICODE` at the top of the file makes `TEXT(LIBGIT2_VERSION)` a wide string. Since we only work on Unicode anyway, we should be fine just defining it for Windows from the build script.
I don't really see it as a semantic list, while numbers are used I believe in this situation they are more for presentation - maybe a ul though...
should you set the content_type here as well (like below)?
`settings.READ_ONLY` is for turning the entire site into read only mode (no login or anything that touches the DB). So you should keep this `if not` wrapping the entire thing.
Are we missing some designs or something for this?
Same goes here. We've made some changes to setupdb that address the reasons for these changes, and need to revisit each one after the 9.2 upgrade.
On 10/10/2012 03:52 PM, David Turner wrote:
>
> I checked http://wiki.scummvm.org/index.php/Coding_Conventions and 
> http://wiki.scummvm.org/index.php/Code_Formatting_Conventions for 
> guidance on whether I should change any of the other case of const 
> symbol values to enum... Only the Code Formatting Convention mentions 
> this as "As a side remark, we recommend avoiding #define for creating 
> constants, because these can lead to weird and difficult to track down 
> conflicts. Instead use enums or the const keyword." If I recall 
> correctly, the rationale for ensuring to use enumerated types where 
> appropriate was because it results in far more readable debugger 
> output, as it is annotated with the symbols?
>

#define has the problem that if you have a name clash it will result in 
strange error messages. Also of course defines ignore namespaces, since 
it's all handled by the preprocessor, so you will also have scoping 
issues here (a common cause for name clashes).

> If this is correct, I'd suggest adding this as a note to the end of 
> that "side remark" as I think in some cases, we might be overusing 
> enum types by "cargo-cult", when a "static const kXXX = ;" would be 
> more appropriate?
>

In what situation would a (static) const for an integer be more 
appropriate than a enum?
я маю оформляти док блок?
If you want to disable generating versioned url.
This means the file will be loaded every single time, and all those namespaces will be registered every time as well. I think the previous solution was better performance wise for people with intl enabled.
I clicked around. I'm not sure if that's fixed at some point, but doesn't seem to have an error now.
Exception is not handled! Why do you even need to catch this exception. It must not happen.
Ah yes, that was the idea. I'll go fix that. And below it looks like we don't use the new dbg parameter either.
Sorry, I cleaned the imports when refactoring the solution for URL. If you want I can add them again, but I don't think it worths it.
ba sublime mizanam ama to sublime i ke man daram bayad doone doone code ha ro entekhab koni va tab bezani ta align beshe ba inke plugin align ro ham install kardam
yekam bala tar goftam ke ina ro fix mikonam va align mikonam :D
Als je een goed argument hebt om wel controllers te gebruiken vind ik het ook goed, maar dan hoor ik graag wat de betekenis van een controller is.
Will look into this later. Not using the methods in the helper right now.
typo: "can be sped be sped up"
I like the following construct:
```python
with warnings.catch_warnings():
    warnings.simplefilter('error'):
    with self.assertRaises(cio._DownloadWarning):
        dnld_item.path(format_dict)
```
I'm more comfortable with a 1 count than a 0 count, as then we know the counter is actually counting the right thing.
Remove ```self.origin``` then.
private void**
Looks like this change accidentally got left out of the last commit.
will a single request context be enough for all variants? I guess that's something we could enforce?
can you make this "boolean" and not "Boolean" ?
Yeah there's lots of things like this that are carryovers from the super's impl.  I did not want to deviate to far from it since it's going to require a manual merging of any backports until I can find time to refactor the upstream version to be sane.
This same test for the protocols matching appears 4 times in this changeset. We should make a note to create a validation function to apply the rule instead of repeating the full code for the check each time.
Hmm, is there a particular case where this would happen or is this just because isRunning() changed? Probably this should rather be handled in the ManagedProcess#shutdown()
I think the default value of epoch should be package dependent, maybe? Seems like I'm doing something wrong higher up in fpm. I'll take a gander and merge this if I can't fix anything outside the template.
we should only do this if this actually a blob URL
Those are not 2 spaces soft tabs :)
why not return SEARCH_QUERY.join('') ?
can we change variable name li by 'sectionByLetter' or something more explicit that denotes what is the actual container?
this.shortcutsApps.forEach(function addShortcut(app) {
The feature is not defined in spec. I will remove the property.
That was a test for checking if we have the import button twice, but is true that checking twice for the same id is not the better way, maybe we should ask for the number of children in the parent.
crap. should have paid more attention to the stuff the google search tool thing spit out.
My thoughts exactly.

2012/7/11 Gabès Jean <
reply@reply.github.com
>

> >      # Ask for an host or a service the graph UI that the UI should
> >      # give to get the graph image link and Graphite page link too.
> > -    def get_graph_uris(self, elt, graphstart, graphend):
> > +    def get_graph_uris(self, elt, graphstart, graphend, source =
> 'detail'):
> > +        # Ugly to hard-code such values. But where else should I put
> them ?
>
> I do not see any better place. It's possible to put them in the module
> parameter, but it's just overkill.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/naparuba/shinken/pull/435/files#r1140072
>



-- 
Linux: Rejoins-nous, nous sommes déjà 11.
Get rid of the `this.`
「」でなく ""
Yes it work for me. Spree throws missing translation, when add this lines, all works fine, spanish time and date format.
Oh.. you are right ;)
change url with it? and in the call from the http server?
Is it ok to just use `next` here? Aren't you running an app that needs its own port?
Explain why not user the wrapper (dummy fields on comment).
No it's actually +filter since I pass that stuff to Filter.
I'm still a strong advocate of only allowing one channel to be talking in at a time.
We may want to change this to be a non-zero status code to make it simpler to script.
We don't need to specify. Priam collects all the keyspaces' names for us if we don't specify. And then we can try to iterate over those keyspaces in a round robin fashion to repair and use interprocess mutex so that multiple nodes don't repair same keyspace at the same time.

From: Matthew Bogner <notifications@github.com<mailto:notifications@github.com>>
Reply-To: bazaarvoice/Priam <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Tuesday, October 23, 2012 10:57 AM
To: bazaarvoice/Priam <Priam@noreply.github.com<mailto:Priam@noreply.github.com>>
Cc: Ahaduzzaman Munna <ahaduzzaman.munna@bazaarvoice.com<mailto:ahaduzzaman.munna@bazaarvoice.com>>
Subject: Re: [Priam] [EMO-237] Implemented scheduled repair of Cassandra nodes. (#3)


In core/src/main/java/com/netflix/priam/noderepair/NodeRepair.java:

> +    private AmazonConfiguration amazonConfiguration;
> +
> +    public NodeRepair(CassandraConfiguration cassandraConfig, Optional<ZooKeeperConnection> zooKeeperConnection, AmazonConfiguration amazonConfiguration){
> +        this.cassandraConfig = cassandraConfig;
> +        this.zooKeeperConnection = zooKeeperConnection;
> +        this.amazonConfiguration = amazonConfiguration;
> +        this.lockAcquireTimeOut = Duration.standardMinutes(cassandraConfig.getLockAcquireTimeOut());
> +    }
> +
> +    public void execute()  {
> +        try {
> +            if (!zooKeeperConnection.isPresent()) {
> +                return;
> +            }
> +            JMXNodeTool jmxNodeTool = getJMXNodeTool();
> +            jmxNodeTool.repair(true);


Also, shouldn't we be specifying an explicit keyspace here?

—
Reply to this email directly or view it on GitHub<https://github.com/bazaarvoice/Priam/pull/3/files#r1917837>.
Can you guarantee 100% that the console object exists at this point and that it has a function called 'logToUI'? If not, add some defensive code to your error handler.
you should use `self.master` here instead of `self.parent`.
We don't have the information about the file in ruleset.js
Hi,
I see not reason to not let user put a height size less that standard 44px.
In many case you maybe need to have smaller cell, especially to fit a specific custom design.
In my fork, I have modified only this line for supporting that:
return _height > 0 ? _height : 44;
Maybe it will be a simple improvement for the next release?
Cheers,
xavier
protected section should be placed strictly between public and private one
This test fails on my machine once I enable the necessary options to make perceptual diff tests actually run ( -Dorg.geotools.image.test.enabled=true -Dorg.geotools.image.test.interactive=true)

Here is the image comparison:

http://dl.dropbox.com/u/2361103/compareError.png
can you remove the leading \n, also line should end in ": " no newline there either
Your almost right, flags are `false` unless target object has same named property defined with diff flags. If so, those flag values are used instead. From practical standpoint there is no difference is that if at some point prototype of selection will change to define on removeListener etc.. properties all flags will be inherited except for `__iterator__` that will remain non-enumerable. Also it's not to mess because it may mess-up iteration, it's just `Object.keys` will contain `__iterator__` if not set to `false` which I'm trying to avoid. I'll try to cook some comment up.
This function is used only once. It would be easier to get rid of it and use typeof directly.
(beside the fact that it contains a typo ;))
Argh. This is my goof. I blatantly ignored the use of self throughout.
New states in general should have tests just to make sure things are operating as expected.
that's not currently the case. Sounds like you consider this a blocker. Will work on this.
Scans much easier.
Not "maybe": sure it's better!
Actually already had that test in a place [more suitable](https://github.com/puppetlabs/puppet/pull/702/files#L3R299). Removing this stub.
why not?  `@user.posts.should be_kind_of( Array )`
I dont think you meant to remove this file?
I suppose it would, I was just writing it the same way CDN_VERSION was written. It could also be placed directly under VideoJS (VideoJS.PROTOCOL) or just use document.location.protocol directly on the string variable. I would agree it would be best to avoid using the global variable, but which of the other 2 methods to use is up to you.
I missed this before merging. Can you please explain why you assign something to $container, only to return void right after that?
plupart, sans le s
Edo - bad refactorist!!!
It avoids this: mod_auth_cas.c:260: error: switch quantity not an integer

cmd->info is a void *, but we pass an enum in the command_rec[].
Ehem, change != food saturation
In tests they are public for simplicity... I can mark as protected if you have stronger arguments.
transaction are not linked to the UnitOfWork. The UoW uses a transaction but you can also start trasactions manually (which is another reason why I think the events are not handled by the appropriate level as they are only dispatched by the UoW transaction in your implementation)
That's true. I put the -1 in back when I was doing the bitwise compare in the database, and would have snagged all the access-list posts without it. 

I suppose it could be argued that there's a slight performance gain in not having to check group zero every time, but it's certainly neater without. I'll zap it.
CS: spaces before and after parenthesis in whole method
Why are these changes made?
We might be picking up the AvailabilityMacros.h header via the objc headers, but it would be nice to be explicit about including the header for these defines. Also, could these #if statements be somehow combined to avoid duplicating the typedefs?

As an alternative, the code could simply skip the duplicate declarations of the imp_* APIs if the SDK's _VERSION_MAX_ALLOWED is greater than 4.3 / 10.7.
Ignore me. I see now. cvs-module is metadata for the recipe. 

In that case it should be named ":module" so that if we need a module for something else in the future then it's standard across all recipes. 

Just like we have :repo for github and that could be applied to launch pad or something in the future, or if god forbid github doesn't fix all these downtimes and we have to move to a new world.
IMHO we should resize the image to fit our design. Looks a lot better if we do it 22px in height., meaning that's it aligned with 'mozillians` logo on the top left corner and the spacing between the top and the bottom is equal. We are not changing proportions, just fitting in our "toolbar". 

About the width and height we should avoid in-line styling. If it's required you can assign an id to the element and do it through css.
Bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=767413
Where is that `postContainers.json` file? perhaps you missed it on committing.
fwiw, they're following Support's precedent from admin posts.
Ok, it's nice to have an enriched List at toplevel. I just hate to see the troll coming: what do you think of OCaml's stdlib? why not use Core? etc.
imho this should be changed to delete and with a rescue on 404
hmm well it could be either. I like @trends so it'd be more obvious that it's looping through and updating all the trends rather than a single one.
debug left over?
I don't think you need to do the pickling manually. The ORM deals with it, see https://github.com/tricycle/lesswrong/blob/master/r2/r2/lib/db/tdb_sql.py#L418
correct: we can use event.currentTarget. 

http://api.jquery.com/event.currentTarget/ 

"This property will typically be equal to the this of the function"
Seems like this line is unneeded.
The `require` need to be inside each task. Otherwise the environment gets loaded even i you don't run tasks.
Well, responsive and IE should be at the end of the document, because they modify its content. If you put responsive to the top, it wouldn't work correctly, because those rules would be overwritten by the content itself. This doesn't apply for IE tweaks, because they have one more special class, but from the logic point of view, I would keep IE and responsive together. As for comment - doesn't have to be there. I just wanted to highlight it, so that everybody sees where it is and nobody writes actual code under these imports.
yup, I missed those: originally it was slf4j directly being used, hence the empty braces
"phpBB offers a wide variety of free modifications made mainly by the users, to enhance user experience."
CS : space before = and after (
Sorry, I'm pretty new to the github pull-request feature. No quería incluir los commits relacionados con travis en este pull request.
The above code is used to detect if the browser is supporting CORS. Most of the browsers implement CORS support using XMLHttpRequest2 object. The "withCredentials" property is unique in XMLHttpRequest2 object so it is the easiest way to tell if the browser support CORS. Again, IE uses XDomainRequest. A very good article covering this can be found here: http://www.html5rocks.com/en/tutorials/cors/.

P.S. I will those comments back to the code.
I found this : `isset($_SERVER['REQUEST_METHOD'])`, maybe it's better ?
тогда это уже не Tin
I -think- this is just a CHOOSEN
Can we change this to:

```html
<input type="checkbox" name="rlmsexperiments" id="exp-{{  exp.id  }}" value="{{ info.rlms_ids[remote] }}:{{ exp.id }}" />
<label for="exp-{{exp.id}}">{{ exp.name }}</label>
```

This way when we click on the experiment name, the checkbox will be selected. It's frustrating to have to click the actual checkbox to toggle it.
It seems to me that we could factor the logic of `get` and `post` in the same function, with the following signature `request(method, url, verify=True, **kwargs)` thus avoiding to repeat the try/except logic in two different blocks.
That only answers the first half of my comment. Can you merge and figure it out later?
Please name it timezone or timezones because there could even come up more.
It rejoins after being kicked. So you have to tell it to part explicitly.
I prefer `"api:#{ req.params.api }"` here. No biggie though.
Don't need to wrap `applied-migrations` in a set, and you can use `keyset` instead of `(set (keys {}))`
Not necessarily part of this change, but it might be useful to have a timer function that builds on `keep-going` and executes its body periodically. So that rather than having to manage the sleeping ourselves, it's taken care of for us.
Yes i changed that when I changed to .rmtree and it is in the commit i just made :)
We shouldn't really be using backticks here, nor should we in most of the JSDocs. Backticks are translated to code tags, and this isn't really code. Also, there are a few JSDoc generators and IDEs that have difficulty with backticks in JSDocs.
I'm not convinced this is the right approach: you end up threading everything through `Either`, but still need try-catch.

In this case, I think `Either` does not buy you much. I'd rather use exceptions for this DSL, from the start. It's a difficult choice, but I prefer to have a nice flow in the DSL, while `Either` makes one pattern-match left and right (see what I did there?).
Why not keeping the access modifier?
Mac はだいたいメモリ十分にある人が多いですが Windows はそうでもないことがあるので -Xmx1536M を Xmx512M くらいにした方がよいみたいです。
Could we rename this section to something like, "Creating Templates" ?
we get a string back from localStorage, but if that gets changed to SQL/lawnchair anyway then whee :D
This should use `with open(outfile_name, 'w') as outfile` so you don't need the `finally` block.
Не согласен с адаптивным кодом в этом случае.
Следует более точно рассматривать задачу и оценивать вероятность. В нашем случае вероятность изменения числа букв в словаре исключена (генетика) и корректно использовать именно число 4, а не выполнять лишние действия.
Плохо использовать магические константы
Надеюсь, вы понимаете, что в данном случае не будет округления, после получения дробного значения переменной х будет присвоено просто целое значение без дробной части. Если хочется грамотного округления (например, при значении 38,3  х=38, а при 38,6 х=39), то нужно воспользоваться функцией округления.
я правильно понимаю, что вы вставляете случайный символ? даже если он уже ранее был таким же? это очень важный момент. мне нужно что бы вы ответили на этот вопрос. по сути это ваша ошибка и невыполнение одного из пунктов задания