labofsahil/github-event-dataset-2012 huggingface dataset:
Hmm, in that case perhaps I just messed up before. Wanna add a `:focus` selector to both and push it here? Otherwise this all looks r+
Nit: Add a blank newline before the license block.
If DISPLAY=':0.0', display should be '0'.

/\./ matches only one dot, /./ matches any char except "\n". I think we need to match the dot, not any char here.
It would be nice if the different bits of logic were on different lines, ala:
<pre>
return true if ...
return true if ...
return false
</pre>
The output of this would be:

```
ApplicationController
  custom
    does not work by default
    when custom routes are drawn
      works
    when a route is drawn with custom parameters
      accepts custom parameters
```

I think it would read better like this (or similar):

```
a custom route in an anonymous controllers
  is not supported by default
  with custom routes drawn in the spec
    is supported with no params
    is supported with custom params
```

Note that this moves the code in `before` hooks right into the examples, but that's fine in this case because there is no duplication. WDYT?
$filter should be $node ?
throwing strings is really bad: http://www.devthought.com/2011/12/22/a-string-is-not-an-error/
OK, just a suggestion to not leave dead code around
> The FirePHP writer/formatter was created less than a month ago in 53723ad, so I don't understand the comment about legacy behavior. If it was a general comment, are there really any plans to restructure writers and formatters between this release candidate and the 2.0 release (apart from this PR, which resulted from a post I made on the mailing list)?

See in [ZF1](http://framework.zend.com/code/filedetails.php?repname=Zend+Framework&path=%2Ftrunk%2Flibrary%2FZend%2FLog%2FFormatter%2FFirebug.php&rev=13621&peg=13621) and [ZF2](https://github.com/zendframework/zf2/blob/release-2.0.0dev1/library/Zend/Log/Formatter/Firebug.php) before remove and then add it again.
That's perfectly fine with me.
Why are you changing the visibility here?
Same comment here; no reason to re-flow this paragraph.
Perhaps we should add that the priority must be between 0 - 7 (inclusive), or that the given constants must be used? Would prevent people from initially trying other scales, like 1 - 10000.
Should be a space after `(object)`, I think. @BlaineSch Care to patch `.travis.yml` to enable our new-and-improved QA checker? :-)
Use lodash in the asset folder
Regarding:

> To be able to make it "just work" maid is going to need to be aware if it's running on OS X. Any thoughts on how you would prefer to do that detection (or if you don't want to do that)?

This seems to be duplicating [`Maid::Platform.osx?`](https://github.com/benjaminoakes/maid/blob/master/lib/maid/platform.rb#L13).
this annotation is useless and should be removed. The code already tell us it is a static method
This would change the path, which i'am not sure that every body agrees on.
Missing line before conditional expression
Except that scan does
```
          lc result inlist results do
            case result do
              [t] -> t
              [h|t] -> t
            end
          end
```
After that info about groups is not recoverable. However it could be fixed. I tend to agree that separate api would be better.
These must actually receive some configuration from eZ Publish (e.g. the image variants).
I agree and disagree. We'll discuss it later. Internal, it doesn't matter *now*
you can collapse this in a single line:

remap.get(what, what)

and then you probably don't need the encoding function anymore, just use a lamda function below:

result = ''.join(map(lambda x: remap(x, x), whichstring)

also, I don't like the name 'whichstring'; how about just 's' or 'name' ? and for remap maybe 'charmap' ? just suggestions.
Use attrs.toolbarLocation condition directly, no need to create "toolbarLocation" variable

toolbarLocation: (attrs.toolbarLocation ? attrs.toolbarLocation : 'bottom')
Hmm. How is the first user with a photo created?
Well, the assumption is that attempt 0 is the normal slug generation. When that yields a conflict, it goes to `resolve_slug_conflict` for attempt 1. 

But following on your second comment of using an enumerable, I think it is better to start at 0 :)
орієнтуйся на конфіг https://github.com/symfony/symfony-standard. конфіг symfony це конфіг пакета по суті. трохи різні речі
can we have only one after_commit here?

in terms on names, how about

machine finished provisioning

post_build

machine swapped to build mode (excluding new systems)
pre_provision

?
psych is only for 1.9 right?
This `&` is incorrect; it backgrounds the job.
I'd rather leave it out since it's not readily (har har) apparent that it would have the side effect of passing options to an event. Merging this in for now, open to re-visiting later when there are specific use cases.
@kpdecker, dug into this one yesterday, lost as to why it doesn't work
What's the point of returning a boolean when the caller does not care?
In the connector, this gets executed before ```RDF``` is defined, because the ```getTranslatorObject()``` call in ```detectWeb``` is asynchronous.
Maybe add: "Requires that lock() is called. If lock() returned true, waitForLockMs(...) will return true with no delay."
Maybe, combine this hint and the next into: "First,  let's find this amount, also known as the *common difference*, by taking two adjacent values and subtracting the first from the second."
Format it to a 80 characters per line maximum. Because we can.
It's idiomatic in ruby to do `group_id, artifact_id, version, extension = split_artifact` here.
Use PATH_SEP not "/" character
If the purpose of this `+ 1` (as well as the others) is to set the 0 bit, I think it is better to use `| 1` rather than relying on the fact that it couldn't possibly be set before. It would also be more in line with the rest of the code that uses bitwise operators to handle masks.
rather than having two kwargs, what about passing stat_gatherer = None in order to disable stats gathering?
"make check" is stating a memory leak here.
Just index or CURR_DIR_ITEMS to?
As far as I can tell, getComment is only used for updating, deleting and replying. None of those need the principal profile to be retrieved and set on the comment.
I've added events for the the REST API, so the dependencies aren't directly in oae-rest.
Please alphabetise this. Also, I think this is missing oae-logger now
If it works, it's better to use ``nme.EVIDENCE_PARAM_PREFIX``. Though, it may not compile with Scala 2.9. (you need to test it :-)). If the name constant is not available in Scala 2.9, keep your code, but add a note so that we remember to get back to this after we drop support for Scala 2.9.
Ch. 6 i 
(I need help here. I don't think this text necessarily fits in this section, but I used because it had a certain "universal" quality to it.)
пофіксь відступ
I didn't change this ... but my base was Clip v0.9.2 and not the current trunk.
>пусть ваш метод mutate возвращает YES, если все ок, и NO в противном случае.
Это противоречит постановке задачи: "п.6. ...  В ней опишите метод mutate, который возвращает void и принимает int."
Заменить 99 на переменную(как было указано выше), или как вариант использовать (int) [foreignCell->DNA count].
забавно, а почему именно arc4random() %100 ? почему бы не сделать просто %4 и выбирать символ из 0 1 2 3?
if (r == 0) {
_array addObject:@"A"];
}....
Если воспользуетесь методом addObject:(id), то одна переменная окажется лишней.
I bet most folks involved with these portlets would have autowired this dependency.  Not a big deal -- just FYI.
If anything, it'd be more useful to have on `packet`, then examine packet type.
комментарии русскими буквами! :) низя
I can push this as is to get matty unstuck, but it would be nice to consolidate this and the previous block to eliminate the repetition
Newline please!
if you use a global install, simply use ``composer.phar update`` (and renaming the phar to remove the extension could more readable)
... was some unremoved experimental garbage and is builtin.

btw. very nice if you want to format strings of unkown lenght to 80 lines ;-)

On 25.12.2012, at 23:36, Eric89GXL <notifications@github.com> wrote:

> In mne/preprocessing/ica.py:
> 
> > @@ -7,7 +7,6 @@
> >  from copy import deepcopy
> >  import inspect
> >  import warnings
> > -import textwrap
> Hooray fewer dependencies!
> 
> —
> Reply to this email directly or view it on GitHub.
>
True, I will remove it.
use itemsArray.length rather than result["channel"].item.length
Hi,

of course I tested these changes and it works fine now. Produces correct 
index file name my-video.mpg.idx
Those URLs do have to start with file:// for the file protocol.


regards Roland

Am 06.10.2012 17:35, schrieb nextghost:
>
> In src/dvbcut.cpp:
>
> > @@ -1018,7 +1018,7 @@ void dvbcut::open(std::list<std::string> filenames, std::string idxfilename, std
> >  	  QString s=QFileDialog::getSaveFileName(
> >  		  this,
> >  		  tr("Choose the name of the index file"),
> > -		  "file:" + finfo.fileName(),
> > +          "file://" + finfo.fileName(),
>
> It wasn't broken. Have you actually tested what your change does?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/nextghost/dvbcut-qt4/pull/8/files#r1779559>.
>
Probably by mistake.
I think you still need to have the dictionary locked since from the docs they recommend putting the application in maintenance mode, which locking the dictionary serves in this case
I'm wondering if we should simplify this `config/software` even more...maybe base it off of chef-pc in `opscode-omnibus`:
https://github.com/opscode/opscode-omnibus/blob/master/config/software/chef-pc.rb
"To" should be "to"
Link StatsD/Graphite to the StatsD reference topics later on.
Yep, it's a small detail - but that would make things even better!
So I will update it accordingly, but clearly the documentation was lacking.

Thanks
限制的方法是通过一种“漏桶”的方法，每秒处理的请求数固定，过多的请求会被延迟。
=>
限制是使用”漏桶“算法——固定每秒处理的请求数，推迟过速请求的处理。
find_program just searches for some executable. It doesn't need Find* modules and we only need Cython executable to proceed.
Why can't we just do:

    kwargs.get("in_postal_code", postal_code)

?
no need - it is protected by try-catch_all below - or maybe I am naive and we need to review it
Map.empty[Node, Timestamp] is not a singleton
I don't know if numpy follows the same policy, but in scipy, the use of 'import *' has been removed from all test code.  Using 'import *' is a bad practice.  (For example, it prevents the very handy program 'pyflakes' from detecting an assortment of very common programming mistakes.)
todo L1929-1932 replaced with above.
We'll add a call to reportFailure of the execution context here.
might want to consider tacking on `, :dependent => :destroy` to this and to the line above. That way if you delete a parent, you won't have the children (orphans) still in your database pointing to a parent that doesn't exist
Nice detail :)
please add a getName method to Alchemy\Phrasea\Cache\Cache interface and use it
Why not use a new monolog instance with and writing a custom handler instead of writing a new custom log class ? we could benefit from the power of  all the other monolog handlers.
By default, I think these should be pixels (as for ``x`` and ``y`` since not all images have WCS, but it would be easy to use other units:

```
from astropy import units as u
a1 = CircularAperture(1.)  # pixels
a2 = CircularAperture(1. * u.arcsec)
a3 = CircularAperture(1. * u.arcmin)
a4 = CircularAperture(1. * u.degree)
```

does this seem like a good idea to you?
Here you re-introduce a 'superfluous' else (according to @samueltardieu) , as the previous condition leaves the method. I am not sure if I am in the same boat with him in this case, but I wanted at least to ask if it was a deliberate decision or an accident.
I like the changes to the BoundedMap classes.  The constructers made sense when I wrote it, but using it afterwards, I could never remember why i made it that way.  This Comparator change is well motivated too.
NGHUTPR

Barf, slash-continues. My personal style is to use
```python
if (thing or
  thing or
  thing):
```
or
```python
if any([thing,
  thing,
  thing,
  ]):
```
but I know I'm losing this fight.
What about something a bit more fliuent? i.e. new FetchOptions().fetchMode(x).fetchSize(y)? where the different fetch* methods return FetchOptions, and you get rid of the constructors. 

We have similar examples in Infinispan's new configuration API:
https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/configuration/cache/EvictionConfigurationBuilder.java
If the CacheValue has an externalizer, I don't think changing the class name would break deserialization. Might be a problem in other areas though.
We could get rid of the enumeration here, right?  Also, just to make sure, there is a subtle difference in result.  Previously, this for-loop would update the labels list, while the new code would not.  This may not be of consequence, but it is a difference.
we could use here 
<code> for signature_item in reports_page.signature_list_items</code>
triple equals.

Also - this logic looks similar to what's above - can you get that into a separate function?
Simply because I haven't looked at the other examples. And it should only be removed from examples that use v3 of the API.
As an example, creating function "prompt_for_tag", that is based on "prompt_for_value"
Since we control everything that gets called on the audit (We squelch all create_section calls), the audit entry builds line by line with either a line report on the # of times it has run sucessfully, or with a larger entry containing error information.  No code outside of our Audit policy wrapper touches the instance of AuditProxy directly and thus it can't behave outside our limitations.
@christianv I would if I knew what I changed! afaik this line shouldn't even come up in the diff.
@christianv I don't think so, I'm not familiar with Modernizr but from what I read its used to detect CSS3 and HTML5 features.
This issue is rather specific to IE8.
This implements the SearchTemplate and populates it from a JCR Node.
endif too
I'm not fond of this bit, I don't see why it should be this complicated.
This constant was just for testing.  I'll push a fix.
I'm not sure if these implicit conversions are a good idea. They could produce some strange errors when resolving method calls. Especially, because they convert to a child class...
I have to think about possible pitfalls here. It at least seams unusual to me.
Should the return type not be "array|string" instead of "?"?
Are you sure you want to override the parameter ``$predicate``? This often makes code less readable. I also found this on lines 146, 148, and 151.
we should add this stuff to the wiki instead
Sure thing I'll see what I can do tommorrow afternoon
That's fine. These options are now available as config switches though, no longer as options. Find a lengthy discussion explaining why both at the same time are not possible within one of the recently closed issues.
Maybe this could become a property once..
These are just public reply threads, which are essentially just specially-named channels, not private in any way. The original user doesn't even have to be involved at all, so if they change nickname it doesn't matter.
Could this be commoned up with traceout ?
Don't forget to remove this kind of things.  
The best would be reviewing `git diff` before commiting.
I am not sure why is `data-display` needed? Are there any other checkboxes in the form?
Now it makes sense ...
Are you sure? Is it not enough just not to define init in account form and it will find the first one (this one) automatically? And then you call super from it?
Why `,` here?
Why is this function on top-level? Move this before `generateComments`.
*REST API*
address is user exposed string? Then `""`.
URLs should be:

```
/profile/user/ <- ProfileView
/account/ <- AccountView
/account/login/
/account/logout/
```
Don't hardcode colors. Use CSS classes.
Absolutely, great idea. Happy to improve on it once the basics are in place.

On Thu, Feb 23, 2012 at 3:05 AM, Paul Jenkins <
reply@reply.github.com
> wrote:

> > +using Carnac.Logic.Internal;
> > +using System.IO;
> > +using System.Diagnostics;
> > +using YamlDotNet.Core;
> > +using YamlDotNet.RepresentationModel;
> > +
> > +namespace Carnac.Logic
> > +{
> > +    [Export(typeof(IShortcutProvider))]
> > +    public class FileShortcutProvider : IShortcutProvider
> > +    {
> > +        List<ShortcutCollection> shortcuts = new
> List<ShortcutCollection>();
> > +
> > +        public FileShortcutProvider()
> > +        {
> > +            string folder =
> Path.GetDirectoryName(Process.GetCurrentProcess().MainModule.FileName) +
> @"\Keymaps\";
>
> Not that it matters *now*, but it'd be cool if this setup a
> FileSystemWatcher, so you could just dump files in, Carnac would then start
> responding.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Code52/carnac/pull/38/files#r479954
>
I think you could use typename primitive_of<T>::type::value_type
yeah, this is required for european currencies.

Perhaps parse could take a currency parameter if we know the incoming currency.  Then we could keep support for this, and change the truncation/rounding behavior only for known currencies.
Would be nice also to have a comment describing why do we disable propagation of log messages from "amqplib".
I did this because I would get a kernel oops if I tried to Ctl-Break the java process on my linux laptop after that had happened.  I had passed in a function with the wrong number of arguments and it crashed the midi thread.
you can use map-invert here. It's even already imported :)
Now that I read your comment I remembered that not all are tasks ( the full
description page of courses uses the same template)  I will add that
exception now. Do not worry about the color ( that css class was added by
Arlton so more thing will look like that as we finish merging things from
his fork of lernanta).
On Feb 20, 2012 2:13 PM, "Ricardo Soares" <
reply@reply.github.com>
wrote:

> >    <div id="task-discussion" class="content_page">
> >      {% if can_comment %}
> >        <a class="button post-task-comment" href="{{ new_comment_url
> }}">{{ _('Post Comment') }}</a>
> >      {% endif %}
> > -    <h1 class="tasks-title">{{_('Task Discussion')}}</h1>
>
> I agree, and I think the title text should be the same (they are all tasks
> anyway). As for the css, I just wanted to standardize the color :)
>
> On Mon, Feb 20, 2012 at 5:14 PM, Zuzel Vera <
> reply@reply.github.com
> > wrote:
>
> > >    <div id="task-discussion" class="content_page">
> > >      {% if can_comment %}
> > >        <a class="button post-task-comment" href="{{ new_comment_url
> > }}">{{ _('Post Comment') }}</a>
> > >      {% endif %}
> > > -    <h1 class="tasks-title">{{_('Task Discussion')}}</h1>
> >
> > We should keep the tasks-title class (since it has some css associated to
> > it) and probably just the 'Task Discussion' text for the header (it
> > probably does not matter to much if it is called Task Discussion or
> Comment
> > so I am choosing the newest name. The UI for challenges was designed more
> > recently).
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/p2pu/lernanta/pull/95/files#r467990
> >
>
>
>
> --
> Cumprimentos,
> Ricardo Soares
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/p2pu/lernanta/pull/95/files#r468396
>
I thought (and still think) that it made tons of sense in `UriGenerator` because what it requests is a piece of data. The `UriScheme` class is a typical Value Object, and it makes sense for one specimen builder to request another Value Object through the context. It also makes it possible for a user to customize the default URI scheme by simply injecting a new `UriScheme` value into the Fixture. It doesn't really change any behavior.

As it is now, `RandomNumericSequenceLimit` may look a bit like a Value Object, but I think it when we're done it's going to look more like a Service...

The intent of the `ISpecimenContext` is to enable you to request other values so that you can build up the Value Object you're currently building. It's was never really intended as a Service Locator :)
Should this string be capitialized like the rest?  Or should the rest not be capitialized?
Yes, you're right, the spell isn't casted when you're out of range because of the implicit target. But do you think you could use this spell for example in Stormwind on Blizzard servers? I don't think so. Limiting the spell to the cave doesnt work, some parts of the cave are on Area Storm Peaks. So I had to limit it to Storm Peaks which is to much in my opinion. Limiting it to the rift makes sense in my opinion. I'll raise the range.

The despawn spell is casted at the last tick. I think handling this in the SAI would be too specific, a spell script is way more generic. It could be triggered on aura remove. But I'm sure it's linked to the aura somehow.
You load it here yet you dont save it anywhere.
I think It is very clear to me and logical from code standards ... As a beginner in code (I am not a good programmer) but from I know as basics - if you have multiple commands in some function it has to be in "block" with brackets ... When you have just one command you simply add it under the function without them - It is very logical and I think basic structure of this language ...
I think this may be the cause of some of the test fails I am seeing here.  it looks to me like this method should always return true/false, but this line doesn't seem to do that
now I am confused. It says deprecated up top..
The single arg constructor was added only recently, we can break that.

Even if you add single arg constructor, user still needs to specify long inputFormat name even if she just wants to control 'nestedLoadEnabled'. It kind of forces user to specify unnecessary implementation.
s/alsways/always
I'll rename `args` to `input` hope that's fine with you. I don't like `args` as it's just one.
Better move it into template.php

Also check ```drupal_is_front_page()```
Yes - I made the source message (from the broker) better, and remove our override.  This gives the user more info about the error.
Tried running it as text/html now. Works mostly fine, only found minor issues with some styling and no being able to resize panels (maybe because some parent element check fails now, I dunno).
I'd put Search at the end for consistency.
> Move this to the header filter?

Sorry, I don't understand.  Move the check that ctx is not null there?

Regardless, changing this to an assert.
Well, I'd need to ignore case, but you're right.

(I was working with `ngx_str_t` originally, which doesn't support that.)

(It's very slightly less efficient because it requires an extra strlen, but that's too small to matter.)

Will do.
Why? It's just as easy to use _data..__dict__. We don't want them there, but handle_data could change them so we pass it from _data back to Model.
As you're returning from the method right after that you can even do

```ruby
code_point.size >= 4 ? code_point : '0' * (4 - code_point.size) + code_point
```
should we add a comment indicating why these are xit?
should this still be called `javascript` if that's not what it is anymore?
totally agree. I just extracted an interface - reusing the existing the methods
ok, spinner's fine!
This line's a bit long.  Suggest wrapping:
```
print '%d   %12.6f   %12.6f   %12.6f   %12.6f   %12.6f   %03d    %12.6f   %12.6f %12.6f' % 
        (result.moments_status, result.getMxx(), result.getMyy(), result.getMxy(), result.observed_shape.getE1(), 
         result.observed_shape.getE2(), result.moments_n_iter, result.moments_amp, 
         result.moments_centroid.x-result.image_bounds.getXMin(), result.moments_centroid.y-result.image_bounds.getYMin()) 
```
I see.  I guess I'm used to the for loop having local scope (in C++).  I didn't realize that the dummy variable in the for persisted after the end of the loop, but if so, then that makes sense.
OK, I've pushed a change for this link to the Wiki, and it's also updated in the GalSim Quick Reference Guide.  I also made a minor alteration to the expanded toplevel docstring in #280 to reference it there as well.  This was a good idea!
I did some research a few months ago to make a GUID closer to the standard.  To completely avoid GUID clashes, Math.random has to be replaced with a seedable (pseudo) random number generator (e.g. seedrandom.js).
That's fine, there is a larger concern then about naming convention and adhering to what appears to be the new standard of using underscores over interCaps.
Again threading issues here: the load method is synchronized, but the field access is not synchronized or volatile so folk can see half-initialized objects.
I'm unfamilar with the dropwizard.cli.Command, but just wanted to confirm: do we want to log and return on exception (so the caller thinks that run was successful), or do we want to propagate the exception? For example, this will impact the exit code of running BrooklynService main.
does group_size get set ?

(only remianing call seems to be in resize(delta) only in case when delta=0 !)
Strange white space change: decreased from 8 spaces to 7.
personally i don't think we should use mac-ports in quite the same way as it is very different, plus these commands are mainly for setting up fresh VMs ... on localhost we can always manually install software (also we often won't have sudo access) so not a lot of benefit
Did you mean to use `Service["apache"]` here and `Exec["apache-graceful"]` above?
Just remove commented out code :)
Why was this method removed?
Probably, yes. I wrote the test in a different way first, which meant I had to set the time zone to UTC. I could now change it back since I've updated the test to be more like StringTest.
FYI, the official package is just "sendgrid".  The "sendgrid-python" is supposed to be  a mirror, but really should just be deleted

http://pypi.python.org/pypi/sendgrid/0.1.2
No longer fails. Removed.
We can do this faster by only fetching a single element but looking at the metadata to see the total count.
Indeed they should not edit the file. But this paragraph lets people know about this new file and tells them they can subclass it to add project-specific requirements.
Do you not want to include this section?
Thanks, I didn't know that. It's removed.
please use window.open. it should be enough.
Yes, it's not the first time that I find myself adding it. Having it in by default will make debugging a lot easier. And it's useful information, that url can tell a lot about what's happening in the webapp.
I recommend directly using kNet::FormatBytes instead of copy-pasting a duplicate.
What is the problem here? Why do you need to do that yourself? There is maybe a bug we need to fix in the platform if the reason whay you're doing that if because of panning.
Is that because of the spacing that it shows the whole file has changed?
actually - i don't think it's needed.... verifying....
Well, if you see a target already with a gouge aura, you go near him, cast gouge, it will cause the damage (proccing the old gouge that was on him) and them reapply a new gouge aura, with reduced duration. So what you are trying to say is that right now Effect 2 (the incapacitate effect) is hitting the target before effect 0 (damage)?
I liked that a programmer reading the test could see the sample file in-line without having to open the file, but I don't feel strongly about it.
Looks good, can you wrap to 120?
After reading up a bit on the ActiveResource api, I think the load_remote_errors method will capture the errors returned by the api call (post in our case), and then re-raise here so that whoever makes the call can capture the errors and display them if they want.
Это тоже изменил, несколько строк строк ниже.
Sadly, even though Python 2.6 claims that absolute imports are on by default, there are quite a few versions that don't do this. For versions where it is the default behaviour, this line is a no-op, so it isn't harmful.

This bug was fixed definitively in Python 2.7, which means that the lines can be removed when django-wkhtmltopdf requires Python 2.7.

P.S. django-wkhtmltopdf does not work with Python 2.5 at this time, because it relies on 2.6isms like the with statement.
Would each of these return `target`?
I think Date.new*() and Date.set*() method are public method but not immutable, constant method.
Ignore previous comment. Just change this so it takes an app as an argument.
テスト実行前にがたまだとちょっと変なような

    @test-app@コマンドに@-clean@を付与することにより、テスト実行前に強制的に...
Hm. This version number changes about once a year. So it was really bad luck. In my opinion it's quite helpful for the users since they know what pvr backend version is supported without having to go to the wiki page. Is there a better way for showing such information?

I can also remove it if you are of a different opinion.
Isn't `multiple` important here?
The copied `completion` block is never released. We should add an `autorelease` here. The mutable dict will retain the block and release it once it gets released itself.
just FYI, you could also just pass ``seed``
Would it be possible to generate trees randomly to side-step this step?
I changed the parameter names because the meaning of alpha is clearly defined in the docstring.
```
        alpha = self.alpha * self.rho * n_samples
        beta  = self.alpha * (1.0 - self.rho) * n_samples
```
After a serious amount of headache ( I was working inside ``cd_fast.enet_coordinate_descent``) if saw this two lines and felt cheated ;-), and therefore made it explicit that alpha != l1_reg .
Pep8 didn't complain for some reason...
I still see a limit for 10GB here.
What I meant about clearing source is that the event fired does not have the source property.

Pleas refactor all these callbacks to be more like what is done for NativeButtonObject. All this new complicated code seems to be necessary because you need the Socket.TCP object. If that's the case then check if V8 is actually setting the "source" property for us since that should be the same thing. If not then expose a setter for passing the object to NativeTCPSocketObject.
Please try to use the existing stuff in TiProxy (the `events_` member, setupEvents, etc). This will (hopefully) make sure event handlers, etc get deleted properly and connections are only made once.
Added class variable contains alignment value.
Lorsque cette url de redirection est utilisée, Phraseanet affiche la réponse d'autorisation...
This used to compare to 0 instead of to 1, which led to some occasional memory leaks.
yes, really
We know already the operating system (line 726) so we can have separate tests for different OSs
Local variables are also camelCase
That's :horse: :shit: :apple:
One of things I miss about Java (long time ago) is the try/finally construct.
I assume the memset is required.  It isn't cleared when it is expanded though.
Putting these in the `fields` dictionary is nice b/c it's a less invasive change, but I'm wondering if these shouldn't maybe be promoted to top level message attributes. Thoughts?
It's implemented slightly differently across the different versions of Rails, so that would be really hard to do without breaking Rails. I wanted to keep away from hacking rails as much as possible.

As written, this will probably still work on the latest rails, which has changed the implementation quite a bit.
why unique?
Frustrating repeating here, since settings (after loading all the crazy settings.yml, settings.local.yml, fooEnv.yml, fooEnv.local.yml) is only available after the :load_environment_config hook
@christianv Are you referring to the three big button blocks and the logic they contain? I started with a buttonToggle() method and spent much of the day trying to figure out how to access the current model object from the method. Seems trivial, but no luck. I can send you the jsfiddle and the the IRC transcript that  resulted in me ditching the method and taking this approach (which was the recommendation of a couple of guys). I too would like to abstract it but will need a hand on the initial obstacle. On the flip side, this way gives us fine control over behavior of each button, if we need that. Can we save this refinement for Monday (unless you have insight)? One of the interesting lessons to come out of this is that model binding in Angular is implicit if not made explicit - which is very cool when you think about it.
@christianv Elegant angular solution there - nice.
@jkff all of this convoluted logic is in place b/c older versions of Puppet did not suport anonymous hashes. This change will break support for older versions of Puppet.
Instead of using these print_errors and then returning (or forgetting to return like here), you should check out fail_with. A quick rgrep of the modules/ directory will give you many examples.
I'm happy with ``resize``!
Minor nit: Can we use `'` instead of `"`. I realise we don't already so this everywhere, but we're trying to introduce this to our style guide.
sorry, noticed one more thing -- why the unposted-link and posted-link ids? I don't see any javascript that uses them, if they are unnecessary please remove!
please squash the lines and put `} else {` here.
because of happyForms and the existing view form models stores in phonebook.models the easiest way to recreate the infinite scroll that appears in the search form was the essentially duplicate it but remove a few of the form elements
Thanks, fixed with latest submit.
What is all this logic?  Why not just keep an array of references to added polylines?  Is that cleaner?  Is it too much memory overhead (really - compared to the `Polyline` objects and their vertices)?
Sure, but I am not sure if we should provide so much configuration. We should set up a meeting to discuss about what we think users would care enough to configure. I will change them all together.
blue-ray should be `bd50`
bdrip doesn't exists
you can also combine multiple cats so `[16], ['brrip','bd50'] athough I thin that isn't correct as brrips are 480p/740p avi's where bd50 is a full disk rip.
spelling mistake :dart:
I suppose not - since we are supporting iOS 4.2 and greater and that property exists since 3.2 (iPad release). It was probably from legacy code that supported iOS 3.x in general.
It appears that iOS *has* text and textContent--I think that's why it was in the doc in the first place:

aevans$ grep 'textContent' *
TiDOMNodeProxy.h:@property(nonatomic,readonly) id textContent;
TiDOMNodeProxy.h:@property(nonatomic,readonly) id text; // deprecated, use textContent instead
TiDOMNodeProxy.m:- (id)textContent

I think this is one of the "non-standard extensions" to DOM2 that the XML.yml doc mysteriously refers to.
The comment should be changed to reflect the code changes
Unfortunately there are some subtle differences between vertical positioning in a row and vertical positioning in a composite layout, at least in mobile web (not sure about the others). We actually treat top/bottom as *padding*, meaning they cannot be used to infer height. In other words, setting top to 0 and bottom to 0 will cause the height to be defined by the control's default height (i.e. "auto" behavior), which does not happen in composite.
This would actually be better served inside the WebColor.h file, because direct access to these constants aren't needed here.
I already talked with you about this, but numerical values are problematic, as this function only is usable for a particular bicycle/rider combination.
It's not so much that I have a strong opinion about using one form or the other, I just thought that the `chmod +x` or `chmod +rx` form was simpler (and is a more typical usage for most users).  When I was glancing through the code changes in this script it took me a minute to sort out the chmod command as it's written here...the `chmod +x` form is just more like what I've done since I learned UNIX shell commands (I hate to think how many years ago that was)... :)
Это не одна фича, `scale` говорит добавлять ли к конечному урлу `/resize/%preferedSize%/`. Но можно указать `preferedSize` и `scale=false`, в том смысле что мы хотим только определенное соотношение сторон.
It wasn't impossible. It ended up there and locked up jackrabbit ;) Maybe there was another reason for why it ended up there, but without that line, we had an unnecessary lookup (and lockup :))
I'd just do `case 4: break;` and save a line.
It's already assumed above `static if (is(typeof(fun) : string))`.
`typeof(range[0 .. n])` instead? You know... If R has disbled this, or is a struct that contains an enum...

Not that it matter if 945 goes through.
I agree we need to worry about breaking existing code that uses `move`. The only breakage would involve structs that have const or immutable fields of types with destructors. So the question is whether making `move` safe justifies the cost of breaking such code. I'd push for making it safe instead of adding safe vs unsafe variants. Opinions?
You need adding `override` keyword for toString.
This static assert is redundant, because the next run-time assertion implicitly needs that itself is compilable.
whoa, a lot of two space indent around here
makes sense.
yeah, if we can get C++ impl of custom elements in Dartium, that would make life much easier. (Ditto MDV, as long as we keep it factored well enough so upstreaming Dartium isn't blocked by those. although custom elements seems to be on a good trajectory!)
I would say ``Doctrine Cache`` provides
Couldn't `NodeImpl` also implement `equals()` and `hashCode()`? Then for `PathImpl` both methods could simply be implemented based on the node list.
an own isEngeneeringObjectMatcher would make this code more readable; which could look something like

assertThat(eo, is(engineeringObject()));
Once again, I don't think we want svn information going into github.
I imagine that this will not work on say, Solaris. Possibly BSDs.

<pre>
sol11% su -h
Usage: su [-] [ username [ arg ... ] ]
</pre>
This line is the only change in xml content; the rest is just formatting from the editor.
I realise it is copied code, but this comment doesn't fit in with the subsequent call to closeExpr() below.
You're removing this here without a replacement, unless I'm missing something. This means if the CMS window is only 600px wide, there's no way to get to the preview in the first place, surely that can't be intended?
You shouldn't put commented config vars like this.
Either introduce a default or leave it as is. In this case - you should think of a way to implement it with the currently available options as adding a global setting that would be used by just one driver (and one that's not so popular, I guess) isn't really a good idea.
I'd use !== false here.
Can you provide more information here, like what file erred?
Why not simply ```... if video.now_playing?```?
they way you are using edit_common, it should be under a "private" block
@bamarni: Shouldn't this be your name? It's a new file.
Indentations seems off after the change.
camelCase (all vars)
`Requires authentication (valid **API_TOKEN**  [More](/#api_tokens) )` would be better in my taste
Good catch! I had this correct at some point, but somehow, I broke it along the way.
Could we pass in the element to the function so we don't have to use `this`?
We don't use the `QUnit` object anywhere else for `module` -- do we need to here?
It's a `DbgHelp*`, which means it can be null. I think that pointers should never be hidden behind auto variables. Also it seems this code was like this before your pull, so this is not your fault. I don't think we should encourage `auto` where it's not necessary though.

@andralex: thoughts about this?
Wait, that's reading a global. Rats. I meant `const`, but that doesn't quite apply :o).
pushfd/pushfq
When do we end up resetting the point total to 0?
Doesn't appear in the commit tab anymore.
Please revert this change and instead rename the `"all"` choice to `"both"` per my comment on the ticket.
http://support.rightscale.com/09-Clouds/Rackspace_Hosting#Unsupported_Features
"и клонирует его"
Guess it's not possible to put a link in pre text, eh?
Again looks like something I wrote.  I don't think there's any harm in this.  The alternative is to use nullable types, but I don't think there's any real benefit.
The XML library should respect the values ordering. You can check how PHP library handles this.
Ah yes.  In fact it completely breaks child ordering. Also - is it correct
to update the local name along with the move?
On Sep 15, 2012 11:06 AM, "David Buchmann" <notifications@github.com> wrote:

> In src/Jackalope/Transport/DoctrineDBAL/Client.php:
>
> >                  $nodeId = $row['id'];
> > -                $query = "UPDATE phpcr_nodes SET path = ? , parent = ? WHERE id = ?";
> > -                $this->conn->executeUpdate($query, array($newPath, $newParent, $nodeId));
> > +                $query = "UPDATE phpcr_nodes SET path = :newPath,
> > +                  sort_order = (SELECT * FROM ( SELECT MAX(x.sort_order) + 1 FROM phpcr_nodes x WHERE x.parent = :newParent) y),
>
> i think the sort order must only change for the node inserted at
> dstAbsPath, not for its children. the children are moved along with the
> parent but i don't see why they need to update the sort_order. maybe i am
> overlooking something, but i fear this creates funny values in the sort
> order of the child nodes.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jackalope/jackalope-doctrine-dbal/pull/37/files#r1613452>.
>
>
should or must? I'd say that it would make sense if we describe what *should* be done in general in the introduction of the chapter and here we specify what of these recommendations is guaranteed under CDI.
nice, I didn't know about toBeOneOf
It's very dangerous to use bincount on a user-supplied array: if I give you y=[0, 1e10] you are going to create an array of length 1e10, and thus blow you memory. You can use:
<pre>
y = np.unique(y, return_inverse=True)[1]
</pre>
to avoid this problem.
Missing the `private` access modifier
Do we care to keep non salesforce cookies?
Ok all prefixes from transition, transform and animations removed!
https://github.com/telefonicaid/Gaia-UI-Building-Blocks/commit/3cd9a6bb7c5e19fd3742d81ba4421b20262884c3
The style in this project is to add "Matcher" after each matcher class, so this should be `class ValidateConfirmationOfMatcher`.
This is to make sure that I am not syncing any project files into the repo.
принято по значению передовать. ну или в крайнем случае по константной ссылке
The description and `@return` should be able to be merged here
Should be removed, not for public consumption. This may change in the future (custom tab controllers)
Based on the other code, my SWAG would be something like:

"Called in place of open for windows that belong to navigation groups."

But I'm not sure whether this is important enough to note.
Perhaps calling it arg 1 might confuse people, as a lot of people would expect zero based indexing. Just call it 'first argument/second argument' or something.
Technically this interface isn't invoking anything at all, the APIs that accept this interface are.. can we clear up the wording here?
minor spacing adjustments needed

`'access_token=' . $this->config['access_token'];`
I just need the DataTypeFactory, correct.

Regards

Cyrill

Am 03.12.2012 um 11:40 schrieb Bartosz Majsak <notifications@github.com>:

> In impl/src/main/java/org/jboss/arquillian/persistence/core/data/descriptor/FileSqlScriptResourceDescriptor.java:
> 
> > @@ -35,7 +36,7 @@ public FileSqlScriptResourceDescriptor(String location)
> >     }
> >  
> >     @Override
> > -   public String getContent()
> > +   public String getContent(DBUnitConfiguration configuration)
> I think we should avoid passing objects to this method(s). For instance now we made sql script (and all other classes in this hierarchy) code dependent on DBUnit. I would rather pass configuration (or relevant part of it) during construction of relevant object instead.
> 
> Why do we need it btw? To obtain DataTypeFactory class?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Any reason why you switched from the forEach?
Tracked in issue blackberry/BB10-WebWorks-Framework#131
reset + check.
a line break here ;)
przenieś {get;set;} do poprzedniej linii