labofsahil/github-event-dataset-2012 huggingface dataset:
Error if not using the <!DOCOTYPE HTML>.

error: typeof iframe.contentWindow == 'unknow'

You can fix if do it:

...
History.hashChangeInit = function(){
...
+ var contentWindow = iframe.contentWindow;
... 
History.checkerFunction = function(){
...
- iframeHash = History.unescapeHash(iframe.contentWindow.document.location.hash)||'';
+ iframeHash = History.unescapeHash(contentWindow.document.location.hash)||'';
...
}
...
i not be say anything about "quality". simple compare size of gzipped UDB and gzipped YTDB (gzipped size give to your _real_ size of containing information). after this no sence about compare...
This expression is hard to read, but it looks like what it will do is to run the synclet after a random wait between 1/2 and 3/2 of the synclet interval
```
 _______ 
( SWEET )
 ------- 
        o   ^__^
         o  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||
```
Can you try what happens if you change line 79 to

return (__bridge NSString *)...?

Can you also please mail me a screenshot of how this looks in Instruments?
Ok cool, I will remove this test if I get a chance to work on it in the next couple of days.
Please add a space between `Frame` and `*`.
oops I missed one more thing to change , may be can do in another commit . But not doing for now .ie change the description to 5.4
Sorry, I think the source of confusion here is that I forgot to update plugins.txt. Uploading a new version now.
I'm getting an error on these functions, e.g.

    julia> combinations([1:10],2)
    pop: array is empty
    in error, pathtojulia/julia/j/error.j:5
    in pop, pathtojulia/julia/j/array.j:448
    in produce, pathtojulia/julia/j/task.j:23
    in combinations, pathtojulia/julia/j/combinatorics.j:131
Porque a alguien de Rails se le ocurrió que print era un buen nombre para un método privado de ActiveRecord (a partir de 3.2). Si lo dejás como print se arma un lío hermoso =)
The tagging rules have also to be discussed and updated in travis-ci.
@flubbacrud: I've just uploaded the script you required, but I don't know if it works. Tell me if you have some problems.
This was duplicated (by the removed section below, which I moved into the assign_vars() call above).
These should not be public, they are to be kept secret. Consider them compromised and acquire new tokens.
It may be known, but this commit doesn't seem to run properly.  Looks like it's an error in calling learnTalent.
I could also use some serialisation code and do it all in-memory. That would eliminate that bug, but add a `use ...` dep.
Would move it to an own line like

    workbook_class = opts.delete(:renderer) || Spreadsheet::Workbook

but looks simple and powerful:-)
evil fix!
No longer the current copy, please ignore
We can now that we're using a UOW. We previously opted not to rely on Raven change tracking, but recently changed our minds. I'll change it.
Yeah, I noticed that too. I've only been playing the core about two days though so I wasn't ready to try and hack at that big script. At least the proper reference is there for someone in the future now lol.
I'll take that as  a no, thanks :)
I think this test could reduce to
    if (localSeq != self.localSeq)
which is clearer and more compact.
This is a nice addition, but it doesn't make the calls to node-expat itself async - the process still has to wait on the parser.parse() call to complete. Maybe implementing something similar to [this](https://github.com/wahvee/node-expat/commit/380f584cbc1e389e234ad1350994ad356479a540) (in JS instead of C) could make the call async and thus the callback really useful.
Ok, fixed in 43c8b944f2
My Ruby interpreters crash when I try to connect with a named instance.  However, the methods for getting the port number are not all that useful in my installation/application.  Is there a source of further information I could use to get named instances working, or am I barking up the wrong tree?
hmm... I see your point. It makes sense.
1. current_RID is only ever incremented by 1, so to start off with, there are no queued requests with rid < current_RID + 1.
2. If current_RID increases by 1, then at most 1 request will become < current_RID + 1.
3. This holds since current_RID is updated _after_ handling broken connections.

I think we can fix it. But it would be great if you can have an assertion which loops over every entry in queued_requests to validate what we think is true (at least for a week or so...) (y)
Indentation and space after // please.
;) thanks for the heads up... i hit a snag with dual spec bug i had to clear up...b4 continuing, so haven't got to test yet...
@main-- I was just enjoying your commit comment: "Let's go ahead and see if everything explodes." You had already uploaded the fix. I just wanted to comment on your comment was all.

Also how dare you break SignPortals. @FernFerret Only just fixed the SignPortal issue I had reported [#336](https://github.com/Multiverse/Multiverse-Core/issues/336)

Do you manually shorten that link to the commit or is there a hidden shortcut?
**+1**
There is a great deal of inconsistency in this document regarding sub-elements,

"poller" sub-element
&lt;emphasis&gt;poller&lt;/emphasis&gt;

and now

&lt;emphasis&gt;transactional&lt;/emphasis&gt;

I realize you are not responsible for the inconsistency but, given you are cleaning this one up, maybe do the others too?
On Sat, Feb 11, 2012 at 8:53 AM, Grzegorz Kossakowski
<reply@reply.github.com>
wrote:
> Actually, I intended it to be enabled only when jribble target is chosen. Notice that JribblePlatform is being instantiated only if jribble target is selected:
> https://github.com/scalagwt/scalagwt-scala/blob/scalagwt/src/compiler/scala/tools/nsc/Global.scala#L71

Oh, so a platform is only instantiated if it corresponds to the chosen
backend. Well great!

Lex
function readThreadVisib() {
Это *объявление* функции, а не вызов.
Мне кажется, вы работу с куками вне треда даже не тестили, потому что половина функций не вызывается, вы не могли этого не заметить.
This would cause an issue on first upload when the server's timestamp is -1. Might be better to return null if it's the first upload:

```
Long timestamp = session.config.getPersistedServerClientRecordTimestamp() / 1000;
if (timestamp == 0) {
  return null;
}
return Long.toString(timestamp);
```
maybe this is relating with libaudio.

set audio at boardconfig file to

# Audio
BOARD_USES_GENERIC_AUDIO := false

and if you build from ikarosdev repo also delete audio_policy folder.
Pushed revert:

https://github.com/gentoo-haskell/gentoo-haskell/commit/ac5fb831130a5e94b793a028d7eef1330f39c626

Thank you!
You'd have an easier time debugging here if you logged the response :)
I think more of an issue is why are we adding this to the core without it being discussed? 
I see one issue posted by kyle https://github.com/openframeworks/openFrameworks/issues/882 
But this is not something that was part of a roadmap or in anyway signed off by all of us. 

In general we shouldn't be adding big parts to the core API without a proper discussion first. 
This is how the core gets bloated fast and also how the roadmap of OF starts to take quite a random path. 

Bug fixes are one thing but adding something which exists as an addon as part of the core should be signed off by the core team and not just one of us. 

//--end rant 

That said, I don't think I am 100% against tweening in the core. 
I would like to see a good example app showing ALL of the ofTween api as a requirement to properly evaluate it ( as it wasn't written by the core team ).
This is the first of the wrapped lines.
Both have the side-effect of outputting stuff to the user. Now that output may be incomplete if the dist is missing prerequisites.
Bättre valstruktur !
I just....... don't understand.
Actually I needed to remove the ( after addClass, it's showing the function grouping in a chained way, again this is just an informational section but it should at least demonstrate it properly - I was just overzealous in adding parens around args in this case, thanks for spotting :)
I 'am new at this, this file should be here from the start...
What is the difference between 'amount_of_cheese' and 'cheese_count'
Thank you for the reply.  So it sounds like that function is contained
somewhere in your libcamera.so?  It looks like I'm going to have to
figure out what the same function is in the libcamera.so for my phone
(Motorola Triumph btw).  It's also a msm7x30 variant.

I'll take a look at those threads.  Thanks again!

On Sun, Jan 29, 2012 at 2:44 AM, Paul Mongold
<reply@reply.github.com>
wrote:
> Since it looks like you are building for a msm7x30 device, you will most likely want to use the following hacked up camera HAL:
> http://forum.xda-developers.com/showthread.php?t=1448303
>
> Also see these posts:
> http://forum.xda-developers.com/showpost.php?p=21728373&postcount=122
> http://forum.xda-developers.com/showpost.php?p=21734698&postcount=125
>
> I imagine the error you are getting is due to the libcamera.so you are using to build with but not positive about that.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Evervolv/android_hardware_qcom_camera/commit/c63e35e751fe437cc910de57fc09392c2578b306#commitcomment-911778
Yeah, would allow you to put some of the nice graphics back in for the older browsers via images if you wanted to, and not add the overhead in the modern ones.
Curious as to what the other mods from Ezekeel are in here. I've been running GLaDOS kernel with my CM9 kangs, but if would be kinda nice to save a step during updates if this kernel had at least BLD.
Should I reanable it? Why thought? It's for safety reasons. 
Ok. I got one good reason. Please post another one. I disabled it due to the fact that many people got confused by that and got their Phones banned due to this.
後者はgeneraterと連動してくれたりしたような気がします。
Similar to above, I think that this should just try to do the right thing (or error if objectid isn't present).  The head here is not needed if the object has already been loaded (or you know the objectid from previous interactions).  The other changes look good.
@geemus I did a quick look at the local, AWS and Rackspace implementations of this method and it seems they all return nil if the file doesn't exist on the storage.  Should this be the same for Atmos?
Sounds like it would drive me crazy!  Thanks for the clarification.
This line is missing test coverage. See https://github.com/gem/nrml/blob/master/tests/hazard/parsers_test.py#L198 for a similar example.
Not a problem at all! Just making sure you hadn't forgotten about it.
Seems like a reasonable check :)
Is there a benefit of this being saved to a variable?
Why do you change this? It seems there's no difference between your implementation and the old one.
This is wrong. If window.Wikia is not defined, the Wikia object created here will be local only.
These files should be purely generated from `man_*.rst`, why are these updated but they aren't?
I just got the feeling that we were sort of reinventing Spring.
Having a common parent for all of our XConfigurators would be desirable, right?
WDYM: there are now restarts. (one-for-one was added)
What is the intended semantics for MembershipGossipChanged?

if you call:

publishState()
publishState()
`sh` ... you learn something new every day.
This may not be right for all the sets yet, but if you want to inherit from another type, this works.
We choose cls instead of class for the naming in other places
I don't understand the need for a default argument value of ``id`` being None?
Hmm, should this literal HTML be a template snippet instead?
Sweet merciful crap thank you. This one in particular drove me nuts.
same issue -- and this should be a pretty easy behavior test -- something like:

    var $test = $('<input type=checkbox />').appendTo('body').trigger('click'), itDoesntWork = !$test.val();
    if (itDoesntWork) {
        ok(true, 'skipping');
        return;
    }

tho you may need a `setTimeout`
note to self: fix spacing
Add indestructable  tests for these
OK, well I guess this is the easiest way to make sure it's the same.
Perhaps a grep through the code for items.SetPath to see whether it is
actually an issue?
On Oct 24, 2012 10:52 AM, "Sascha Montellese" <notifications@github.com>
wrote:

> In xbmc/windows/GUIMediaWindow.cpp:
>
> >      return false;
> >    }
> >
> >    if (items.GetLabel().IsEmpty())
> >      items.SetLabel(CUtil::GetTitleFromPath(items.GetPath(), true));
> >
> > -  ClearFileItems(refresh);
> > -  if (refresh)
> > -    m_vecItems->Append(items);
> > -  else
> > -    m_vecItems->Copy(items);
> > +  ClearFileItems();
> > +  m_vecItems->Copy(items);
> > +
> > +  // make sure m_vecItems has the original path set
> > +  m_vecItems->SetPath(directory);
>
> I get your point, all I wanted to point out is that removing this line and
> adjusting the database code to not alter the CFileItemList's path will
> break the advanced filtering completely so we'll have to come up with a
> different approach that covers both use cases.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/1646/files#r1921787>.
>
>
Почему мы проверяем в $sessionSettings, если он array()?
$sessionSettings[$s->module_id][$s->param_name] это вроде не выдаст ошибки
You mean, if they're using `--output-dir`? Probably better to make a separate section for when you want output to stay on S3 in a deterministic place.
Let's convert them all later. For now, every module does it the same way, so I'll stick to it.
Am I missing something, or is this defined in just a single subclass of `MRJobRunner` but used in `MRJobRunner` itself?
+ src + " " + dst
This class name should be changed to JavaClassGenericsTest
This conditional should prevent the line below from ever executing, no?
Please make consistent
Please add "git+" urls supported by newest parser. Also add more https variants which are falsey
This implementation will fetch rows from the database and then iterate to count them. Can you think of a better alternative that issues only ``SELECT COUNT`` statements to the DB, but without using raw SQL?
I can't believe I've been using Xcode 4 for a year now and didn't notice this.... thanks so much!
This method is getting uncomfortably long with too many nested statements. Could it be possible to break this up a bit?
Hmm, you're right. It is simpler than it seems... I think i'll just keep quiet, my brain doesn't feel like working right today. :P
please, use $(current_version) and test for no_version_installed see `action/current`
Maybe document in the one Rd file?
Should "//@ sourceURL=inject-analyzer.js" be hardcoded?
should //@ sourceURL=inject-executor-line.js be hardcoded?
Need some extra eyes on this -- if this is commented out, I get problematic absolute paths in my screen.css.
Oops, no the unref is here: https://github.com/luvit/luvit/pull/223/files#L0R181
Again, instructors could put something like this in a testing library, so they wouldn't need to type this all for every testing suite.
This is just a simple bug fix right, not really related to the 1-d iteration issues?

If PyArray_MapIterBind can fail, then shouldn't it return an error code? This is a really obscure way to check for errors.
The strcatalloc() was done early on, but what does this comment mean?  I shouldn't be using strlen() or just a waste of cycles in this instance?
душа просит комментариев!
Ok, that sounds good, will create a separate manifest for source digests. 

Will keep the change in the Rails 4 PR though.
I've updated the Rails helpers to use the `config.assets.digest_files` key, and this change hasn't caused any problems so far. I've also submitted a pull request to the `asset_sync` gem to support the new manifest format, as well as the old one.
You could use `File.expand_path` here instead.
Hehe.. I don't hate, but I try to avoid :)
Not anymore, my bad, thanks.
I think you want to allow numbers in tags--this nixes that.

Seems like what you really want to do is prevent tags that consist entirely of numbers from being a tag. If that's the case, you probably want a regex like this:

```
    tags = re.findall(r'(?:^|[^\w\\/])#([a-zA-Z0-9_\.-]*[a-zA-Z_\._][a-zA-Z0-9_\.-]*)(?:\b|$)', update)
```

That forces it to have at least one non-number character.

Having said that, we might want to instead just force it to start with a a-zA-Z character. The regex for that is simpler plus it seems to reduce false-positives.
@angadhn Check the formatting for single line docstrings that shows up elsewhere and try to match that:
"""Some descriptive sentence."""
Oh, I guess you just moved this.
That doesn't change the commutativity of the Piecewise itself. In the example below, ```f``` is commutative even though one of the condition contains noncommutative symbols:

```
In [1]: A, B = symbols('A B', commutative=False)

In [2]: x, y = symbols('x y')

In [3]: f = Piecewise((x, Eq(A, B)), (y, True))

In [4]: f
Out[4]: 
/x  for A = B
<            
\y  otherwise

In [5]: f.is_commutative
Out[5]: True
```

I can't think of an example where noncommutative symbols in the condition would mean that the Piecewise is noncommutative.
More useful might be to actually show how they differ.

```
>>> Inverse(A*B)
(A*B)^-1
>>> (A*B).inverse()
B^-1*A^-1
```
all the get/setitem lines are tested now.
If you don't need them, I'd recommend removing them.  I think it may be confusing to have such comments unexplained, especially for a reader who is not used to type annotations.
Actually, it's not Sphinx, but just the docscrape extension (see the files I changed).  The headings in that file are arguably arbitrary to begin with (I think they come from the numpy docstring standard).
or should this be

```
elif self.base.is_even;
    return self.exp.is_nonnegative
```

In anycase, the following fails to give True

```
>>> var('i j', integer=True,nonnegative=True)
(i, j)
>>> (4**i).is_even
>>> i.is_nonnegative
True
```
Hm, it should be exactly that, it works just fine for me in the terminal, but neither that nor `init_printing()` work for me in the qtconsole or the notebook, I need to pass init_printing the `use_unicode` or `use_latex` keywords explicitly. I can change the module to pass these as True, but I'm not sure if there will be any problems with forcing unicode in non-unicode environments and I'm not really sure how I can test that.
Both of them should go to logger. I think we should have constants near related code. So constants related to logs should be in log class. It is easier to read it then one big file full of constants.
the `envir` argument is not used anywhere in this function, so please remove it

it is not worth many arguments for this R function; I think you can just write `rst2pdf(input, rst2pdf = 'rst2pdf', options = '')` and users can specify extra options like `options='-o foo.pdf -s bar.css -v'` if they want
@since 1.1.13
Do not add a newline between if() and  the following statement. Check framework code about it. @rawtaz Check Yii source code about newlines. There is no Symfony/Zend/other code style.
@DaSourcerer So this should work? (atleast the log suggests so):
http://travis-ci.org/#!/suralc/yii/jobs/1794006
No with getCurrentUrl() it is not working.

> This webpage has a redirect loop
Since you uppercased JSON5, shouldn't yaml also be?
Use `/\D/.test()` as a more general check.
puts!
This is the block of code that could probably all get sucked into the check_credit_icon helper.  Also that helper can probably just go into ````questions_helper.rb```` unless it is really needed by the whole application.  Actually maybe it is needed in the solutions view?
I can understanding wanting to get rid of the collection cache, but are there specific issues with the entity cache too?
ah, so generally, if its a reference to an object (as indexed by Sphinx,) then linking (as in this case) also changes the typesetting (makes it bold, and preformated/code) so *those* items are *always* linked. The docs are *very* consistent on this practice. 

Glossary items (i.e. `:term:`) are only linked once per-section, (i.e. the first time the term appears after someone could have started to read by virtue of arriving on a page via a target link.) The docs are *less* consistent on this point, particularly with regards to some *really* common terms/ideas (collections, databases.)
I should be able to skim through git log to find a commit, I shouldn't have to view the diffs. Not all of us have the privilege of 24/7 Internet access, and so can't always access GitHub.
Don't fetch style_id if you are not using it.
Style components was not being used; it was simply a language string and this here, but no actual module.
All code checked into phpbb must not have commas before closing braces. Any code which does have such commas is to be considered buggy.
Please eradicate "tmp" in variable names. All variable names should be descriptive.
Yeah, the `LEFT JOIN` is not required, a cross join using `FROM ' . POLL_VOTES_TABLE . ' v, ' . TOPICS_TABLE . ' t` should do.
I don't mean to be rude, but please learn regex before commenting on code that uses regex.

The regular expression is looking for any single invalid character. If there is one invalid character, that makes the string… invalid. The regular expression I am using is fine.
Opening curly braces on on own line
I don't see any reason yet to make any of the functions/methods non-static. None of them require any context.
a callback is always expected for _send I think. Why is this needed?
Da. Raul a sugerat sa se primeasca periodic achivement-ul
:-) Makes me smile. I like
I think "child:done" is the wrong name for this".  The description looks good, and leads me think the name should just be "child".
i18n library was not always loading.
removed index.html as well
Is there a reason why u r duplicating the i18n source files even inside the test folder... Can you not specify the path to the lib in the require??
I meant only the icon coming in the AppGrid, not the actual code. We can add the icon back anytime we need it?
Done. Similarly for `lat_lon_range()` and `get_lat_lon_contiguous_bounded_grids()`. Will need to revisit if we move the "xy" equivalents to the plot module.
Removing the `if` looks fine - `netCDF4.Dataset` is a class - so either you get back an instance (which will not evaluate to False) or it'll blow up.
nm, I see what you were talking about. adding a commit that I'll push in a second.
No, an empty tuple means not to use code caching for this op. Putting a version number in the base class would enable caching for a scalar ops, even if they are incompatible with it.
Maybe this code can be arranged so that iv2 doesn't call quietPeriodSet()?  Looking at the interspersion of if-iv2 checks, maybe there's an interface of some decoupling that can be pulled from this code? For example, the calculation below is repeated/duplicated in the discard() callback.
I would have used "(?i)((?<=\\ACREATE\\s{0,1024})(?:PROCEDURE|ROLE)|\\APARTITION|\\AREPLICATE)\\s" instead
This returns a nicer string (w/o the space-slash-space at the beginning):

```
def get_location(device):
    location = []
    node = device
    while node:
        position = node.get_position() or ''
        if position:
            position = ' [%s]' % position
        location.append(node.name + position)
        node = node.parent
    return " / ".join(reversed(location))
```
code readability: right now one has to know that xmlParseBalancedChunkMemory returns a non-zero error code of sorts to indicate failure.

You can make it clearer that this is all intentional by comparing explicitly, ie

if (xmlParseBalancedChunkMemory(...) != 0)
{
}
More indentation weirdness?
Some databases are very picky about the order of clauses in statements. I think it better to write this function as 
1. Build an object representing the required SQL features, and 
2. Pass it to another method ("formt_column_sql") for combining them.
Simpler: return user.check_password(password)
I'm not sure the comment above is useful
you should remove ``@override`` (especially as you are not overriding anything)
does test_helpers.render exist? If so, why don't you use it in test_monkey rather than writing your own render helper?
Of course, I didn't use the regexps properly and inverted their logic... that's how good I am! \o/

But you get the idea.
I think Hitoshi means that we hard code "pass by value" to true.

Actually, we plan to fix that after the code review done. The reason why we don't fix it here is to separate the performance improvement and bug fixes, so that you can review them easily. If you prefer to fix them in this review, we will do that. Thanks.
Please look at logregr_cg_step() in src/ports/postgres/modules/regress/logistic.sql_in for an example of internal documentation.
What version are you running in when you get the above error?  This should have been fixed by some improvements to plpython in later versions of GP and Postgres.
Fix or remove, commented out code is undesirable.
Don't worry about fixing this -- I'm taking this PR and making changes on top of it, but if you're going to make this function no longer return an access token it's name should no longer be `getAccessToken`.
Maybe if this is an attempted oauth request for a service that isn't registered we should throw an error rather than just call next()
Move this to on_start so that it runs in a thread an I think you should be rid of your blocking issues.
Not a big deal for now. But at some point this should be added to a sprite.
Is the system libxml2 not enough here? (trying to be more diligent about unneeded deps these days)
got it~ thanks!

On Sat, Mar 31, 2012 at 2:07 AM, Jack Nagel
<reply@reply.github.com>
wrote:
>> +class Mpfi < Formula
>> +  homepage 'http://perso.ens-lyon.fr/nathalie.revol/software.html'
>> +  url 'https://gforge.inria.fr/frs/download.php/30130/mpfi-1.5.1.tar.gz'
>> +  md5 '2787d2fab9ba7fc5b171758e84892fb5'
>> +
>> +  depends_on 'gmp'
>> +  depends_on 'mpfr'
>> +
>> +  def install
>> +    system "./configure", "--disable-dependency-tracking", "--prefix=#{prefix}"
>> +    system "make"
>> +    system "make install"
>> +  end
>> +
>> +  def test
>> +    system "make check"
>
> Just omit it
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mxcl/homebrew/pull/11312/files#r627547



-- 
宋浩
SONG Hao
Institute for Interdisciplinary Information Sciences
Room 4-609, FIT Building, Tsinghua University
Beijing, People's Republic of China
Postal Code: 100084
E-mail: baritono.tux@gmail.com
Office Tel: (+8610) 62783817 ext. 1630
Why make this static?
Ok. Will Fix.
Please don't combine whitespace changes with other commits.
Yup - I agree - it should be documented.
It would be good to have a test case that invoked this.
It was incorrectly asking me to name my stateful `static final` Logger instance `LOGGER`. I prefer to reserve `CONSTANT_CASE` for constants, and try as they might, loggers aren't constants.
I have improved the shell widget a little in the work branch. Now the adb
shell is reinvoked if the connection is lost. And there is a short help
message on the first start. I find the improved shell useful. Yes paste on
right click or right click menu will be even better. Yet QtAdb should work
OK on linux and Mac too. So if you patch part of code, think of that too.

Yes, I'm Bulgarian.
Regards
triochi

2012/3/22 nijel8 <
reply@reply.github.com
>

> > -    tmp = QFontDialog::getFont(&ok, QFont(this->fontShell), this);
> > -    if (ok)
> > -    {
> > -        this->fontShell = tmp;
> > -        this->ui->editFontShell->setText(this->fontShell.family());
> > -        this->ui->editFontShell->setFont(this->fontShell);
> > -    }
> > +//    bool ok;
> > +//    QFont tmp;
> > +//    tmp = QFontDialog::getFont(&ok, QFont(this->fontShell), this);
> > +//    if (ok)
> > +//    {
> > +//        this->fontShell = tmp;
> > +//        this->ui->editFontShell->setText(this->fontShell.family());
> > +//        this->ui->editFontShell->setFont(this->fontShell);
> > +//    }
> >  }
>
> I kind of didn't like the shell widget. I tried to modify it somehow, tried
> for instance to implement right click menu with "paste" and "copy" but I
> couldn't get it to work the way I wanted so I replaced it with windows
> command prompt shell. And SettingsWidget::chooseFontTables() dialog became
> useless.
> Sorry, this is my first attempt in programing. I'm learning as I go.
>
> BTW are you bulgarian?
>
> Nick
>
>
>
> -----Original Message-----
> From: triochi
> Sent: Thursday, March 22, 2012 5:40 AM
> To: nijel8
> Subject: Re: [QtAdb] Just committed my changes... (#6)
>
> > -    tmp = QFontDialog::getFont(&ok, QFont(this->fontShell), this);
> > -    if (ok)
> > -    {
> > -        this->fontShell = tmp;
> > -        this->ui->editFontShell->setText(this->fontShell.family());
> > -        this->ui->editFontShell->setFont(this->fontShell);
> > -    }
> > +//    bool ok;
> > +//    QFont tmp;
> > +//    tmp = QFontDialog::getFont(&ok, QFont(this->fontShell), this);
> > +//    if (ok)
> > +//    {
> > +//        this->fontShell = tmp;
> > +//        this->ui->editFontShell->setText(this->fontShell.family());
> > +//        this->ui->editFontShell->setFont(this->fontShell);
> > +//    }
> >  }
>
> Why you are removing font dialog?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/triochi/QtAdb/pull/6/files#r589927
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/triochi/QtAdb/pull/6/files#r590158
>
Strange indeed, since `if ! isMac &&  ! isLinux; then` works let's just leave it that way =D
Please fix indentation here, as well.  Thanks!
JUnit style is to leave out braces where possible.
Please follow the style of other try/catch blocks in the code, with newlines after opening braces
It's temporary because we don't know the spout id.
But it would be replaced by material.getModel().getMesh() when it's implemented in vanilla.
I think we're pretty much ready to merge. I assume you prefer to leave it the way it is here?
Does this work with a property that has an internal getter and setter or just internal getter?
Really? This seems like a common case while typing.
If we can make this change, then ``$(brackets).trigger("htmlContentLoadComplete");`` would immediately follow ``Mustache.render()``. I think that would be a cleaner approach.
Can you please put comments like these inside the catch block so we can pick them up in future "empty catch block" static checks?
This function is not used
This is a bad idea. Create a 'packed' config that is based of the default config but doesn't have these plugins.
just for cleanliness, alias always looks like a broken method to me without the comma, alias_method looks nicer and does exactly the same :)
Remove I18N.tr( ),  to give
LOGGER.error(ex.getLocalizedMessage(),ex);
I'm about to do it. BTW, don't merge until monomap builds again, please :-)
Same revisions as above.

I see these are actually just copied in from JsArtifacts though. Is there no way to simply say that we inherit the docs from the thing we're overriding?
It could go there but all the post method does is it calls get(x....,) with same args.
We've been doing a lot of variable caching in `for` loops. How about `for( i=0, l=innerContainerClasses.length; i<l; i++ ){` ? Also, there's an unnecessary space after the `i<`.
I these types to be a lot better in the latest editor code, so I'm enabling them.

Had to rework how the editor gives new map types in the registry IDs, so that the stamen terrain type didn't overwrite the google one.
If you define this below inline (here https://github.com/mozilla/butter/pull/872/files#L2R122), you don't have to have a separate variable to store the function; it will just get attached to the exported module object.
not a huge deal, but kinda weird how some of the json attribute names have double quotes, and some do not.
This is not meant to be a specific image; it's simply a placeholder. This is an example page, which used to be displayed to the user before I implemented the client-side JavaScript, but now is no longer even seen. It is instead used for my own reference.
also requires db connection (req, db ..)
`pdf.js` ?
Don't you only want todo this if there was a log4j.properties file?
So that way you can use logging in sakai.properties, but if there is a log4j.properties it uses that and warns you if you still have your old sakai config.
Korrektur: bei delete nicht.. ist ja nur widget intern und nicht vom MP Fenster abhängig.
Let's make this file a symlink
Pour le html5Mode je pense qu'il faudrait passer par un fichier de paramètre pour pouvoir l'activer/désactiver facilement
Why does an admin has to be able to add comments? But ok.
This doesn't seem necessary; you can just pass the address of `free`.
Since the Foreman glue layer is only incorporated into the user object if the AppConfig says to use_foreman, what is the purpose of being able to disable the orchestration?  Rather, my understanding of the glue layer is that if you include it, you are wanting the orchestration and add functionality that comes with it - so where would you use the disablement of the orchestration?
I suggest using errata_ids.concat(errata) to spare some time in garbage collector, += creates new object every time, while concat uses the original object, which is what we want to do here:

```
>> x = []
=> []
>> x.object_id
=> 17570660
>> x += ["test"]
=> ["test"]
>> x.object_id
=> 17284720
>> x.concat(["test2"])
=> ["test", "test2"]
>> x.object_id
=> 17284720
```
What you have will work but I like this minor correction better
```ruby
system_id = task_owner_id if ('System' == task_owner_type)
```
Rechtschreibfehler, bitte korrigieren.
Yeah, this seems to be a problem. Note that I copied this idiom from https://github.com/Seldaek/monolog/blob/master/tests/Monolog/Handler/GelfHandlerTest.php so it probably has the same problem.
I added another commit that should store the check statically in memory. Thoughts?
NextPlanParams is a confusing name considering what Param/Parameter usually means in this code. 
Maybe call it SetOperatorPlanCounter? 
Maybe keep the the isFinal flag as a separate input to getBestCostPlan? or at least make it a final property -- I think it could also be more clearly named something like isTopOfPlan.
This is a simple combo: mousedown, mousemove, mouseup. I'm not sure of what your library provides here?
Can you check that this method exists? (for desktop build).
Makes sense.

Also we should have a "let talk" still fuzzy concept for me.
instead of an assertion, can you create a `CosmologyError` at the top of the module and raise that instead? (and also add a ``Raises`` section to the docstring).
I think it makes sense. It's a helpful shortcut IMO.  That reminds me I do still have a fix to the formatting code that I need to push.  And didn't we agree to rename `.string()` to `.format()`?  What happened with that?
With the new async + idempotent xfer this function is no longer used/needed.  Problem solved.
Yes I like the general idea of a reset "to factory settings" button. I don't agree with this change though as it makes detach different from the other core settings.
ACK
(I wonder why this implementation is in the .h, not the C++, but I suppose you simply followed the example of GetAvailableCredit)
if thats the case, better update line 59 too. It specifies "Versions used in this release: Boost 1.37".  I tested on ubuntu 12.04, so added the name of the newer package accordingly.
It was on a vacation ... I missed the header-update, sorry :-/. Fixed!
.... what is the foobar and ytboi stuff....?
I figured out how to create my own repo, but not much point forking the bitcoin code, the above is about all I have to contribute.
It did not for me. FatalErrorException also overrides and adds an extra parameter.
Perhaps you should add 1 more test where you first use `start()` for a new block and then `startEmpty()`.
This should probably be defined locally in the top-level describe function.
@elemoine I have commited a change so that ```getLayersBy('id', record.id)``` is used instead of ```getLayersByName()```.
duplicate name for this method, there already a method with this name.
Change it back, it's that way for a reason.
Nice use of reliability here.
I think use of exists would be clearer here; much though I like the sleepy faces.
don't know why it wasn't working, used this fix:
http://code.google.com/p/gcalcli/issues/detail?id=74
I'm not loving the name `globlist`, but I'm struggling to think of something more descriptive.... `shellglob` ?  Anybody with a better idea, feel free to chime in.
Yup, I said just as much in #1110 just now...
For consistency, I'd be inclined to use `str.format()` with `{file}` style fields - I think people are more familiar with that than with `string.Template`. But that's open to discussion.
Or `re.split(r'[\s,]+', line)`.
OK, I've done that.
For consistency with [os.path.join](http://docs.python.org/library/os.path.html#os.path.join) and similar, perhaps this should be `def urljoin(*pieces)` which will avoid an extra set of parentheses when it is called.
Should be -ios-image-capinsets
I changed it to zero however, I think the memory/gc benefits from avoiding the allocation is probably work the extra code complexity.
As it stands componentv2 & component have roughly the same sloc so its not too much extra work either.
Probably add a NULL check on the structure pointer that returns 0 if it is NULL, too.
Actually, see my later comment about the idea of a universal `GIT_INIT_STRUCTURE` utility.
This select is already somewhere else in the webmaker section, isn't it? Can you at least put it into a separate template so we don't duplicate this?
I'm not qualified to ok this. Maybe @jsocol can?
It's a nit, but missed last time. What about screenshot vs. screenshots? Shouldn't we take the plural form?
again this is, perhaps a premature optimization.  The contants live in the class object.  By referring to them with 'self', we're forcing python to first look it up in the instance and then fail and move on to the looking at the class scope.  By using the class, I can save lookups and go directly to the constant that I want with only one lookup.
Can you put a comment here in big and bold letters that explain what you explain to me on IRC that is this the old and due to be deprecated collector handler.
It doesn't make much sense to have all those strings outside the main string. I think you did that to copy me, but it seems like a bad idea here. You'd better have all those known values inside the main string, and have only the few ``now`` instances here.
I haven't looked yet at how it would shake out, but I would prefer that we added a separate helper function like `allow_admin_or_requesting_user`. The logic looks right, but I think the naming is confusing.
Actually I never used switch in this way before. Normally my functions only have 1 return method. I would prefer if you use a variable where you assign the data, a default in the switch which throws the exception and a return in the end. The result should be the same, but you have to add some breaks.
C'est la valeur par défaut, tu préfères le spécifier ?
I don't think we should support nesting different FormBuilder implementations. You can still use a custom FormBuilder for all operations (like configuring it in DIC).
And if you really want that, you would need to rebuild the tree in setParent(). Otherwise the API allows to create inconsistencies (you can make a instance1 a parent of instance2 but instance1 has not instance2 as child...)
empty line is needed here
You should add the `@` sign to avoid the warning.
Putting this in the changelog for 2.2 while submitting the PR to the 2.1 branch looks weird
good pont, again!
what could I do without your code reviews? not sure I want to know...
You can also put MEDIUM_CONFIDENCE here. A second case statement should be added for the MinLength constraint. If you check FormFactory, a "pattern" constraint is created there for min length - these two functionalities must now be merged.
Does the entity *have* to be managed if a `property` if provided? In my case, I'm providing an unserialized entity from the session that's not managed by the entity manager. It has an ID, so there's no reason for it not to work.

Can we move this check after `if ($this->property) {}`?
app/controllers/Commentable.java
did you push?
Assuming that we all using Xcode 4.4, you can replace this line with:
 ```objective-c
    for (NSNumber *point in @[@25, @73, @120, @167]) {
 ```
actually the canceling logic was put in place to help the back button responsiveness.  The feedback from ryan was that the time between hitting the back button and returning to previous view was too long.  Both the map updates and mustache template processing are cpu intensive.
Double quotes where singles would do.
I think this is only indented one space.
khkhkhkh
aslan ina balad nisan code bezanan
man migam be ja inke biyaym code haye zepto ro fix konim barashon hey pull request konim khodemon ye chizi to maye hame JFQuery bezanim bere melat shad shan
injor dg fayede nadare
Is there a guarantee that r.c() and r.begin() starts at the same position ?
If not, perhaps CircularIterator should be used here instead.
Again: I/O and wrapping exception into Failure
I think assert needs to be in the name to make it clear what is being tested (and easy to search for asserts)
This could allow someone to place a dead bush near sand, but over any other block...you probably need to check for y-1 to be sand :)
Oopsy!  This shouldn't be in production.
always done it the other way, but matters not. changed.
What exactly is this doing here?  Leftover debugging code?
"when no role is given"
@tchak Do these need to be cleaned up in `destroy()`?
Since `append` and `appendTo` are tested here and in [append_to_test.js](https://github.com/pangratz/ember.js/blob/master/packages/ember-views/tests/views/view/append_to_test.js#L21-51) there are duplicate tests. So should I remove the duplicate tests in [append_to_test.js](https://github.com/pangratz/ember.js/blob/master/packages/ember-views/tests/views/view/append_to_test.js)?

If so, only the `destroy` and `remove` tests would remain in `append_to_test.js` so a rename to `remove_and_destroy_test.js` would be appropriate I think ...
We use convention to keep the code simple, so there should never be a time where we have a variable called "item" that doesn't refer to an Item_Model.  You're safe to drop this check.
Are these expensive to create? If not you dont have to have the lock since you have putIfAbsent
There is an unwritten convention among core developers to have module name prefix in the event names. So I have changed this to `core_email_template_filter_before` and  `core_email_template_send_before` below
starting a heading with `<h3>` is wrong. What is role of this element? Just a description of the list below?
Hi Tim,
I've add clicked item checking and refine list Items event, thanks.
nit -> space before `{`
You can't put this here.
Why only reload when no currentlyHandling? What about doing it always and postNewSuccess if currentlyHandling? (removing the else)
Including it right now :-)
the line has been removed.
Since mozTime is used without checking if it is defined or not there is no need for this check at this point.
@ferjm will know for sure, but I think we don't need the `setTimeout`, we can use the `onerror` handler on the DOMRequest returned by `sendUSSD()` in order to `notifyNoResponse`.
I was looking for a **Verifier Compliance** section. Since we don't have one... added a note to point the reader to the more normaitive Compliance section.
Why is this listed twice?
It *need* not be a component, but it may be useful to some.  Whether to use a registry lookup is a convenience that is left to the caller, just like with any adapter.  Those writing calling code need not opt in whole hog to ZCA idioms if they do not want to.

Specifically, the advantage to IUUIDObject(context) is that context can be either a string/integer UUID or content adaptable to IUUID).  Though, L31 may be incorrect, as this really is an adapter for IAttributeUUID, not IUUID -- fixed in 272785d68d60cdc9105c41e4bee67882537bf19e
Mathematica default seems to be 6, but this is too slow (for the moment).
Does this really need a set?
you should add a blank line before the return statement
*shrug* I slightly don't like the fact that it creates non-system users, but I do prefer using puppet to create the user/group.
This function name could be more descriptive.
Even better, since you don't need `lit` but `lit.value`, it can be `case Select(Literal(value), _) =>`
Yep, works for me.
Alright not a big deal, lets leave it as a static.
This code will be released with 1.6.4.
Ehm, you have remains of a merge conflict here?
Yes, I just misunderstood you.  I thought you meant `return (proxy.unwrap().translateTo !== undefined);`.  
I suppose you mean `return hd.isVariable(proxy) && !!(proxy.unwrap().translateTo);`?
Coding style统一一下。()前后有个空格。
It's better to use $app->isSite() because of there might be more clients than just admin and site in the next Joomla version (Cli?)
See above - I want to check whether or not the archiver is active.
unused method parameter?
check_code is now correctly being passed options.ignore
My hesitation here is that this is a new type of behavior.  If this is better should we make all Resources work this way?  Is it just that this API makes more sense to you or is there a specific advantage it provides?  create() is a weird thing to call on a Server, but is a VirtualServer special enough to have it's own API extension (if so, add the function to the BasicVirtualServer class)?  Is the function name "create" misleading?  Will people think it's the same as power_on?  You work with this stuff more day to day so I'd defer to your opinion but wanted to bring up those questions.
@EvanDotPro it really depends on the type of hash being used and the circumstances of the validation. Such attacks are known as preimage attacks and vary depending on the hash etc. Generally speaking they're pretty hard to accomplish in a sha1 hash cert. Since you're sha1'ing the cert manually, this might be ok, but generally speaking the cert fingerprint is not guranteed to be sha1, and could be a preimageable hash. (remember certs can sport many hash and signing algorithms)
you should update this comment :)
This seems problematic... although at the moment, the MVELDumper seems to be stateless, it will create a bug if that ever changes. I suggest to either make MVELDumper a singleton and just use his reference here or don't instantiate this as a static field.

Also, if you are abstracting the ExpressionProcessor, I suggest you don't name the class MVELxxx... use generic names for the interfaces as well, and only reference MVEL in the concrete implementations.
Finish this you scoundrel.
Yeah, this was a test that [was in the spec before that was commented out](https://github.com/jarmo/RAutomation/blob/master/spec/adapter/ms_uia/select_list_spec.rb#L106) because it didn't work (before my change).  I uncommented it out so it worked, and didn't change it but also added a new one.  I'm happy to change it.
Yes, please simplify this method, I haven't tried to understand it because of the unecessary complexity of it.
This is the mechanism I mentioned during the last weekly meeting, even if selection's test uses `module.exports` so it's a bit more elegant: https://github.com/erikvold/jetpack-sdk/blob/8bbe2da12f5ae001ac601527cf2f5cfd0a75622d/test/test-selection.js#L443-455

Of course removing this part depends by the decision we have to make about the Comment 2. In case we'll keep it, use `module.exports` as well.
I think we should fails the test if `mod` is attached to the top document (`url`).
Could you please rename `pref`, `val` to `key` `value`.
@ochameau In fact I have suggested @ZER0 to put atob / btoa into chrome module but expose them to end user through some other utility module. So you won't write `let { atob, btoa } = require('chrome')` in your code instead you would do `let { atob } = require('some/utilitiy/module')`. I don't think `@packaging` is a good placeholder for that specially since we serialize / parse it as JSON in diff places.
Also worth pointing out, I used `escape` here, since we usually use the auto-escape of `<%= %>`, but I needed to wrap the content in some HTML, so I had to use `<%- %>`. So in most other places, this would be possibly double escaped also.
Awesome. I didn't know this existed.