labofsahil/github-event-dataset-2012 huggingface dataset:
It's because I need to grab the tvshowID from the passed removed episode db
ID. (so I can mark the tvshow as updated).

Same with a song, needing to grab the album ID.

See in CUPnPServer::Announce()

Actually removing one song, or episode is pretty unlikely, but there's no
other way for me to spot a deleted album/tvshow.

I could actually ditch handling Removes altogether and just monitor for
Adds?

On 10 October 2012 14:09, Sascha Montellese <notifications@github.com>wrote:

> In xbmc/video/VideoDatabase.cpp:
>
> > @@ -2730,13 +2730,14 @@ void CVideoDatabase::DeleteMovie(const CStdString& strFilenameAndPath, bool bKee
> >        m_pDS->exec(strSQL.c_str());
> >      }
> >
> > +    if (!bKeepId)
>
> Why does this have to happen here? What if the call to CommitTransaction()
> fails and throws an exception? In that case the movie wouldn't have been
> removed but the announcement has been sent out.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/1582/files#r1806311>.
>
>
Right, or I can change the getter method to lock before reading the value so that it is more robust.
What do you prefer?
note here it is `0.00014` instead of `0.00015`; similarly, read the next three lines carefully
$this->title = $qf ?  implode('/', $qf) : $title;
Not from this update but tag.py needs it. It was removed by accidentally from previous refactored.
Why couldn't you just set `errors.insufficentbalance` as key of error message? Then this condition wouldn't be needed. Besided, you should compare strings with `equal` method. `==` compares only references.
I couldn't see a way to do this without introducing the explicit column index variable. Looking at the existing code, I assumed that the reason the column index was used in the original code is because you couldn't just use accessibility labels to pick from any column; this could turn out to be a faulty assumption. However, I quite like the ability to choose your column; I think it makes things obvious to the developer what action will be performed. I'd welcome your thoughts however.
There is a typo (it was there beforehand), it's "resources" (plural)
I'm slightly concerned about dest[0] here.  The C function only has one offset parameter because the offset for the C vector can be expressed in terms of pointer arithmetic.  How will you express it if you write to dest starting at, say, dest[5]?
Why are we removing this?
is @purpose a JSDoc tag?
by-value ownership model?
Glad someone who knows how internals works looked at this!  I've updated the code to check for the existence of everything being used before using it.  In main.c, I introduced a local boolean.  I guessed the type should be "zend_bool", but that was just a guess.

php -r '0+' no longer segfaults.  Bad evals are harmless.  Other parse errors are fatal (but don't segfault).
Yeah, I initially did that but decided it wasn't as readable. You're right that it's probably best though as it's most in keeping with the options.fetch(). I'll update it.
Why not just define the method and call `super`?
Use the new hash style inside the message please.
We don't need to use regular expression here.

```ruby
value.gsub('"', ERB::Util::HTML_ESCAPE['"'])
```
@jeremy : what do you think about this deprecation message?  I can also remove it completely and leave `set_fixture_class` as an alias with a comment.
Please, use 1.9 hash syntax. We're encouraging people to write new/changed code in 1.9 syntax. Thanks.
I know this is old code, and you're simply extending it, but does anyone know why `#method_defined?` is used over `#respond_to?` in this case?
Ah, another issue with the hash approach is that if you rename or remove a
class, it won't be removed from the hash. I am not sure of all weird
scenarios this could lead us to, but we could potentially have an observer
that points to (and successfully attaches to) a class that only exists in
memory.
can't you write:

     owner.info.baseClasses contains wannabe.owner
like this :)? https://github.com/cvogt/scala/commit/66f75183c0614681c61eaa4f3af005be040ddd11#L0R18
I would recommend that some kind of tests for this behavior be kept. The original code is very fragile with respect to changes in the type of warnings/errors are raised by numpy and sympy. I had already issues with messages that change and thus branches of this code that become useless. Event with the improvements done by @catchmrbharath it is possible to have problems.

By the way, the original code was written with the idea that we want to save the values in order to plot the real part. Now it seems that this is not an issue, so a branch or two in the `elif` tree may be unnecessary (I have not verified this yet).

I will really try to review all the plotting stuff before the end of Friday (European time)
I like these method-category comments. I should start doing this.
gamma function -> gamma functions
This is a method, so you should have a Methods section to accompany your Attributes section. Also, don't forget the form_equations method.
Well, in `isympy`:
```
In [6]: A = Object("A"); B = Object("B"); C = Object("C")

In [7]: f = Morphism(A, B, "f"); g = Morphism(B, C, "g")

In [8]: d = Diagram([f, g])

In [9]: d.premises
Out[9]: {A→A: ∅, B→B: ∅, C→C: ∅, f:A→B: ∅, g∘f:A→C: ∅, g:B→C: ∅}
```
which is fairly not bad IMHO.  Do you think I should be using the `pretty` in the doctests?  (`use_unicode=False`, maybe)

I felt reluctant to do that at the time of writing :-)
```
Returns a Rational approximation to `self` within the tolerance `tol`.
```
I have no idea whether there is a better check for this.
FeaturesNamespaceS (plural) + a jdoc pls
This was already changed in 6c32bcd571204. You may need to pull.
Only for size efficiency since these classes are not used.
Would it not be more generic to call this interface Collation (or does that clash with external definitions in the JDK or ICU)? The reason why this occurs to me is because you end up with a bunch of strange sounding double constructions such as `UnicodeCollationAwareIdOrdering` or `getIdOrdering` - could these not be replaced by `UnicodeCollation` and `getCollation`* respectively?

* getXXX is very Java-esque, considering it is being used on a Scala defined class.
How did you arrive at this limit size?
It was failing the test suite against oracle when I reconfigured jetty for the integration tests. This is probably something we'd want to look at doing like the other modules with oracle profile. What do you think?

On 20 Oct 2012, at 04:56, Ben Hood <notifications@github.com> wrote:

> In agent/src/main/scala/net/lshift/diffa/agent/rest/SecurityResource.scala:
> 
> > @@ -102,7 +102,7 @@ class SecurityResource {
> >      aggregationsBuilder.maybeAddStringPrefixAggregation("name")
> >      val aggregations = aggregationsBuilder.toList
> >  
> > -    val aggregated = new UserScanningParticipant(systemConfig).perform(constraints, aggregations).toArray
> > +    val aggregated = new UserScanningParticipant(systemConfig).perform(constraints, aggregations).toArray.sortBy(_.getId)
> Ideally I'd want to refactor the UserScanningParticipant to do the work in the DB rather than on the app layer, so at this juncture, I'm tempted to leave the patch as is and raise a separate ticket for this (although I'm not sure in what issue tracker yet). Is there a failing test case for this?
> 
> —
> Reply to this email directly or view it on GitHub.
>
typo here, should be subsystem
There's also a space at the end of this line, there shouldn't be.
This is currently acceptable to me. When we have separate 3.1 and 3.0 changelogs we can revisit the wording here.
The dataProvider is different.
This should be in global scope and require_once.
Probably should get rid of the sorting here. Just add another method to get the "active/latest/whatver revision". This also eliminates the 0 as array index.
Using `static` for data providers is for phpunit < 3.3. As we expect 3.5 the `static` keyword should be dropped.
http://www.phpunit.de/manual/3.5/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.data-providers
shouldn't we be using the `uv_fs_readdir` with a `NULL` callback, so its SYNC for this to make it portable?
should use the temp directory for all downloads until they are verified.
`/usr/lib/rackspace-monitoring-agent/plugins`?
why do we have to maintain two movie lists?
This seems kinda random.  What does app/autoload/dispatch.common.js have to do with view engines?
In theory, it should use `YUI.applyConfig()`, but there is a remaning bug in yui that prevents us from using the config API. Instead, we need to plug them directly into the main object. Dav will have this fix for the next release.
having surface_searchlight is definitely the way to go!

what I meant about "why those aren't just arguments" : why not to pass them as arguments to the SurfaceDisk.__init__, and then convert loadFromFiles to become e.g. factory @classmethod from_files which would return such initialized instance?  might become more inline with other places in PyMVPA...
These both refer to ```HybridHeightFactory``` rather than ```HybridPressureFactory```. We should test both but move the Height stuff to ```TestHybridHeight```
I assume we can't just use the actual class from the grib api instead?
```units="1"``` unnecessary
This one line is the reason for this whole PR.
Hmm, I guess my tone is coming through wrong. I mentioned this Feature-based approach in the initial email discussion on theano-dev, and then when I saw that it wasn't used I mentioned it again here in what I thought was a constructively-worded comment. I am currently implementing it myself, and so that will hopefully be another useful example of making a Feature going forward.
Added them. It takes 27 seconds to run this test cases now...
Why the additional spaces in the label?
Split this method into smaller parts.
Путой строки не хватает для отделения текста от заголовка
The two ways are wrong,mine and yours, I think a better methods would be something like, search(Filter filter). the filter contains the search information :)
Very good idea! I was trying to support both touch and mouse scroll and this really works quite well.
One suggestion though, instead of restricting only Y scrolls, we could also check for X scrolls because some (Apple) mouse comes with horizontal (touch) wheels.
So at this point, if Y is zero, then use X.
Like this
```javascript
if (that.options.wheelHorizontal && vendor == 'webkit') {
	if(wheelDeltaY == 0) {
		wheelDeltaX = wheelDeltaX;
	}
	else {
		wheelDeltaX = wheelDeltaY;
	}
}
```

What do you think?
I agree, like boost I would prefer to type "#include cyclopts/limits.h"
On Oct 8, 2012 3:30 PM, "Paul Wilson" <notifications@github.com> wrote:

> In src/Core/Utility/CommodityProducer.cpp:
>
> > @@ -2,7 +2,7 @@
> >
> >  #include "CycException.h"
> >
> > -#include <limits>
> > +#include "Limits.h"
>
> I should have been more direct: @gidden <https://github.com/gidden> can
> you describe the difference between and "Limits.h"? just curious
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cyclus/cyclus/pull/404/files#r1788636>.
>
>
The `write()` and `tell()` methods need to be defined by subclasses that support them, so we always raise an exception in the base class.
I've updated :)
Nitpick: `complex_fault` and `simple_fault` are technically more correct than just `complex` and `simple`.
I think `def select(timeout)` is much more readable.
what if the element really has offset of 0 and 0, then this fallback is unnecessary. Perhaps consider checking the style to make sure it's inline first before falling  back?
Well, if each is separate, you could use an `ajaxTest` with a `setup` and a `create`? That way we could keep the test. I think it's the only place that actually tests global events not being fired properly for helpers.

I tell you what, make it simple for you ;)
Indenting is incorrect
OK. But the "version" in the outer block you would leave at @MADLIB_PGXN_VERSION_STR@?
I'd say avg is still not right one for the missing value.  Is median better than avg?
True,  though this is rather a commit comment than a source-code comment.
Related to JIRA: MADLIB-442 and MADLIB-443 for parameter checking.
This example doesn't make sense to me.
I generalized it in develop in cd021cc8198932969c055d55b6e4a5c0daadcbf6. Will update the PR.
Is there a reason netcdf can't be found in HOMEBREW_PREFIX?
Newline between results and 0
The string "Use --trace to view backtrace" looks duplicated in a bunch of places.  Can we clean this up to simplify it?

Also, the InvalidCommand handler has a wierd message - we may very well have non resource top level commands (in fact, we should plan on it) so the message 

    "Invalid rhc resource: #{@args[0]}. Use --trace to view backtrace\n#{usage}"

is not really descriptive.  How about:

    "The command '#{<all args excluding options>}' is not recognized.\n#{usage}".

Backtrace won't help in this case (it's not relevant to a user).  Same for the Invalid options scenario - backtrace isn't useful.  We should not show that message there.
Why pull these out if they aren't reused?  Suggest

   domain = rest_client.find_domain(options.namespace)
   app = rest_domain.find_application(options.app).

Also, app is required so it should be an argument (we can preserve the old syntax).
```
if '/var/www' != '/var/www/dir' // True
then $subDir = substr('/var/www/dir', strlen('/var/www'))
```

``$subDir == '/dir'``
I think once the exception capturing is down in `_handle` this can also take the direction and the middleware raising the exception as arguments (and maybe the index of the middleware).
Alternatively, mention here that the relative-url is why it's located at "repos/foreman".
It mostly just gets coverage of the `if reactor is None` branch.
Square's rule is that code comments are capitalized sentences. You missed your period on the "keeps..." sentence.
Nope. It means that validate() doesn't explode because this method isn't overridden!
NO they must not be hand rolled. Don't imply that we support that. We don't.
ここで新しいgroupが作られているが、どこのgroupにもinsertされていない。
そのため下のnextLayout:layer(self:getSceneStage())にて画面の一番上に来てしまい、
touchBlockを隠してしまう状態になっていた。
Is this doing any kind of pooling on it's own or is it relatively OK without it?
Also, there is a snapshot system already built into SpoutChunk for the renderer.
I think I basically agree, but I wonder if it'd be better to tackle this as part of the #2204 cleanup.
I think it would be more efficient to listen for the beforeContextMenuOpen event, so this only needs to be run right before context menu is popped up (and not on every document selection change). This would also exercise this new event.
@joelrbrandt: I think we should still be able to use withTimeout().  Though be do need to think about where to put it... is the timeout per extension?  In that case, it should live down in ExtensionLoader.  If we instead want an overall time limit for finishing loading all extensions, then we can just wrap the result of doInParellel() in a withTimeout().

But I agree with testing etc. it makes sense to keep it a separate change.  Joel pointed out that, since core Brackets doesn't depend on this new event, we're not re-introducing the fragility that #968 fixed.
The trim() function actually manipulates the text string, so I think it would be faster to use a RegExp instead. I think /\S/ will find any non-whitespace character.
I did this one,with Fabian's supervision. The mkdirP function only takes two arguments, this was coded wrong.
No reason to leave in commented-out code.
please fix this formatting :)
We should store this value into a variable so we don't have to do the concat twice if it's not null.

Also, it might be worth having an easier way to calculate the key for that roaming setting. Something like a method in the angle that takes a teamid (probably not the best solution) so that we don't have to copy that logic eveytime we deal with this setting. It might be something to deal with during the roamingsettings refactoring (a method in there that takes the teamid and angle name and builds the key).
Do you really need this whole class?

We want to avoid including inside OrbisGIS classes with external copyrights, for obvious legal reasons.

If you need just a method out of it, create you own method that does the same thing.
I'm not going to change this here, since it's not *totally* the focus of this ticket, but we should file something to deal with it.
This probably should only happen if there's a name for the tooltip. ( combine the conditions of the following if statement into the outer if statement. )
Line 955, E:0001: Extra space at end of line
ImageData present in FF14+ https://bugzilla.mozilla.org/show_bug.cgi?id=550309
These branches all depend on `options[:tcp_keepalive]` being a Fixnum. I think the entire block can therefore be wrapped in something like:

```ruby
case options[:tcp_keepalive]
when Hash
  # ...
when Fixnum
  # ...
end
```
using execlp exposes tlsdate to "bad" PATH values when running the helper, but I don't think that necessitates a change here.
Good idea, i'll keep in mind a future  ```config.s3_access_enabled``` option
Although for things like this I do quite like to redefine just the get accessor with something like this:
```
def pending_modified_values
  @pending_modified_values || {}
end
```
just so that it's not nil when uninitialized.
Like sourced from AppContext, sourced from System Properties (this one here) and others. @nabcos already proposed to renamed classes to better reflect from where are they sourced, so in this case this class should better be named as `SystemPropertiesHc4Parameters ` or such.
The blank lines should be deleted.
FreeBSD下面测试脚本不能用，因为不是用epoll方法的。
we can test only one stream individually. when we are trying to test the next stream data , system/trash contains some files i.e. previous stream data.
You might want to delete the Filters Elastic Search index here too
Style vs. view
Should packageCount be a data attribute? i.e. `theTable.attr('data-packageCount`, 25);
There are two classes that are candidates for refactoring out: ActiveManifest and Pulp. They are not reusable at all. In my opinion 719 lines is not that horrible. I could move those two classes to a lib directory, the resultin file would be 453 lines in total. IMHO in this particular case it makes sense to have it in the one script. Opinions?
yes (so deep and args go together)
``true``->``True``, and ``of``->``if``
The `Ipac` class does not support writing, so this example won't work.  Better to use `Rdb` perhaps.

(BTW I made this comment earlier but maybe forgot to actually hit the "Comment on this line" button.  Sorry.)
It does get repeated a fair bit, but I suppose they didn't seem like a cohesive thing to do in a single function.

```
{TN, Q, Claiming} = do_common_claim_stuff(Params, Owners, Wants)
```
I added it back in, but the code path doesn't get hit. I think it's because all of the claim sim deals with directly with calling riak_core_claim:claim/3 rather than calling riak_core_ring:rebalance_ring() which calls riak_core_claim/1 and grabs the wants/claims function from the environment.
That's inside the "if (fTor) { ... }" block.
How often does the code call real_strprintf()?  This change means clearing 50K or memory every time it is called, which might be a performance issue if it is called a lot.
I believe there is a BOOST_REVERSE_FOREACH() that would eliminate the reverse() call.
Then there's a misundertanding on the issue.
Inline styles have been moved to the stylesheet
Fixed,


Thanks @guilhermeblanco.
Yeah, that would be better .. :tongue:
ideally the float_to_int and int_to_float should be in a utility module so that we do not have code duplication.
Could this go a level deeper? I'd implement the ContainerAwareInterface in the BackendBaseObject. This way, the BackendBaseAction is also a ContainerAware instance and we'll be able to fetch the container from each action.

In each application, (api/backend/cronjob/frontend) you could inject the container in the actions. For example:

https://github.com/davelens/forkcms/blob/e964b655927bcb9e0db7170fd266bd49ce4020c3/backend/core/engine/ajax.php#L60
https://github.com/davelens/forkcms/blob/e964b655927bcb9e0db7170fd266bd49ce4020c3/frontend/core/engine/block.php#L112
The rest of these settings are filled, but not yet used. Should we attempt to get these to work in Fork, or leave this be for now?
We need some of these (the paths for instance) fairly early in our code. A container might not be ready the moment we do.
The hash mechanism is used so you can better work with caches when local files might change (no need to double-reload to force a flush, etc.).  With all the defaults in tornado, though, the hash is only computed once, so there is no benefit whatsoever until we add a mechanism for entries in the hash table to expire (such as calling [StaticFileHandler.reset()](https://github.com/facebook/tornado/blob/v2.3.0/tornado/web.py#L1521).  I think this is currently only triggered by the `debug` flag in tornado.
it doesn't, but it won't run on our boxes unless we shebang kpython. Or.. unless we explicitly run it via kpython.. ok.
Bro, make this a pointer.
Aaaaaand done. `git_path_is_empty_dir`, at your service.
Yeah, it seems php_url adds the 'en-US' automatically and that actually leads to a 404.
This 20 is probably a setting or "constant" somewhere. I think I'd use that here.
You missed your chance to rick roll jenkins
The trouble with this is that it will continue to have core_ set as the prefix after the method has been used, meaning the next DB calls will break.
What does `$mixed` mean in this context? Yes, its value can be mixed, but other than that...
Okay, can do. Noticed that, didn't know you had a hard requirement for such.
I will check it, but AFAIK the Collection interface doesn't implement \Serializable
check_cs has been removed because @fabpot creates the [CS-Fixer tool](https://github.com/fabpot/Symfony-CS-Fixer) which does more stuff and can be used by other projects too
I am not sure what you mean. Since there default state is non-set, unset() returns them to that state. Anything else like setting equal to null would not be equivalent.
Sorry, don't know where this diff comes from, haven't touched that code ...
On the whole yes, I like this approach, and I think it will simplify some code in Drupal (where we're only ever using request matching, never context).  I've pinged the person working on that code right now for his input.  On our end, the goal would be to be able to use RouterInterface, MatcherInterface, and UrlGeneratorInterface without ever having a context object.  If we can't extend the base classes without that, that' snot ideal but we can work around it.  (Right now we're extending UlrGenerator and trivially tweaking its route collection finding logic.)
Brace should be in same line as `foreach`.
explicitly annotate return type here.
Ticket #3066 created and pull request done https://github.com/Normation/rudder/pull/31
Can you explain a bit about how this is meant to be used? Would I put this in my .vimrc:

let g:ps1_nofold_blocks=1

And then what happens?
No, one true brace is the formatting style
Cool i've never done this before! did it work? how can you test it do you hav to put your chrome or your mac into  spanish?
This patch highlights an existing issue.

This handler and the others aren't handling rollback of the restart/reloadRequired call. They need something like this"

protected void rollbackRuntime(OperationContext context, final ModelNode operation, final ModelNode model, List<ServiceController<?>> controllers) {
        super.rollbackRuntime(context, operation, model, List<ServiceController<?>>);
        if (!context.isBooting()) {
            context.revertReloadRequired();
        }
    }
This should not be a problem because this is part of framework bootstrap
space before closing paren.
This still needs to be addressed. See "z-index and stacking" for details on using ui-front here: http://wiki.jqueryui.com/w/page/12137737/Coding%20standards
Wrong line? I didn't question the span, as far as I can tell. Was suggesting something like this:

`"class": "ui-icon " + ( this.options.dropdown ? options.icons.dropdown : options.icons.popup )`

Without the icons option, you should still remove the parens around `this.options.dropdown`
пока тогда с SS завяжу. модерилку может подпилю, пока суть да дело
I could only barely hear the pop before.  This makes it go away for me. 

I'm surprised that the release takes up 2/3rds of the duration of the tone.  That makes the tones seem shorter and softer.  Did you try starting the release at position 1000?
The first failure appears to be happening on this line. If I comment it out, the first test completes.
Aren't we going to get a system banner from the `app_install_manager.js` (system app) for this case?
why is spin.js? I mean we have to use the spinner provided by the correct BB. Or am I wrong?
nit: leftover?
Here is the place where we pass nimbus temp directory location to all daemons (nimbus and supervisors) in local mode.
Is this possible to easily implement? There are users of this API as well, though we may just be able to port away from it.

I would prefer to just remove the API and let it error, instead of a runtime warning.
Will also require a change in the script generator to ignore .hg dir
opened issue https://github.com/WindowsAzure/azure-sdk-tools-xplat/issues/149
The space before the colon may be removed.

"you can easily .."
Err, pardon my scathing remarks.  I didn't mean to imply that you were a Ruby novice. :sweat_smile:
This should not always be set to true, right?
Yep, the `EPIPE` should take care of it, although I suppose it's harmless enough to leave this check in. I'll try to rig up some tests anyway to get some data on the perf implications, if any.
Should we link-ify @scalding?  I think so.
you are going to need to add T: TupleConverter. Without that, this method can't see which TupleConverter to use, and so it uses the singleConverter, which just is: getObject(0).asInstanceOf[T], which breaks because the internal object is not a CTuple.

Instead, the TupleConverter[CTuple] just asses the CTuple through, and the .toString does the "right thing" as along as all the internal items have a good toString method.
We should use the same option name as Hawk... hostHeader instead of hostHeaderKey... or change it in Hawk...
I'd call it "get_load_balancer", to match the naming conventions of the other get_* methods.
Is this supposed to be `True`?
This method is way too huge. Reduce it to <50 lines.
...
Look a few lines earlier.
I suppose I can see the value of having a canned confirmation dialog like this, but I'd leave that as an implementation detail for individual builds. They can just do a presentActions for now if they want confirmation.
How about validating pRet?
> I prefer scripts to have minimal output when things are "ok", so I'd rather not write anything that is "expected", like in this case.

I agree with this in general, but some of the output is useful for checking the script correctness, i.e., it should be seen as a useful log. So I'll add a DEBUG variable that can be used to control the script's output, and for the moment I'll leave it enabled (we can turn it off once we trust this script).
There is a performance downside in the case of radio inputs.
Why did you change that?
the `.godir` file is required by https://github.com/kr/heroku-buildpack-go
Could you please clean up this property on destroy as I'm not sure how well such references are handled by GC.
Not having this has been an pain, thanks for fixing this!
This joining into a comma-separated string belongs at the UI layer (the management command), because it's a UI choice. Model layer code should be returning data structures (i.e. a list of project names) for maximum flexibility.
yes .. potentially ..
Typo: Enque*ues*; despite that: that's what the function name says, therefore superfluous.
I prefer explit return values, `return nil, err` tells you exactly what you're returning without having to look at the signature for named return values and match those to what gets assigned in local scope.  Use the convention of surrounding code which has explicit returns.
This is not very clear - can you explain that iteratorSeq is a method and also explain what a NodeIdEdgesMaxId is?
A link to the Graphite server on 8080 would be nice.
you can also remove these commas
I think that test for GenericHeader is not enough, it's more reliable if you could do:

* assertEquals($f, $headers->get('foo'))
or
* assertEquals('bar', $headers->get('foo')->getFieldValue())
@EvanDotPro I don't see how this differs from having an invokable defined in the controllers invokables (as an example).
Rewrite the above. Since the conditions have return statements, there's no need for else statements.
If statements don't follow with a true brace.
I'd reverse this conditional -- I actually didn't see the "!" modifier here at first, and totally misunderstood the flow.
`man`? AFAIK there is no man page support for pip.

It is an open issue indeed: https://github.com/pypa/pip/issues/415
There's already a default set in AliasManager for the name 'FileAggregator', is this just a redo?
what's wrong with eval in a test case ?
I don't know of one. I'll clean that up.

On 4/22/12, Caleb Eggensperger
<reply@reply.github.com>
wrote:
>> +                       (symbol-name prefix)
>> +                       (symbol-name suffix))
>> +          "ACL2"))
>> +
>> +(defun call-with-random-seed (name args)
>> +  `(,name ,@args random-seed))
>> +
>> +(set-state-ok t)
>> +
>> +(defun replace-placeholders (tree so-far)
>> +  (if (consp tree)
>> +      (cons (replace-placeholders (car tree) (ash so-far 1))
>> +            (replace-placeholders (cdr tree) (1+ (ash so-far 1))))
>> +      (if (equal tree :defrandom-placement) so-far tree)))
>> +
>> +(defun expand (form state)
>
> Is there a nice way to hide local function definitions? If not, I've been
> using __name (vaguely python-inspired) to indicate that name is not
> exported, to avoid conflicts.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/calebegg/proof-pad/pull/11/files#r718274
>
Missing line break between break and next case
Also, `=` needs to be aligned
this looks weird. Yaml will not contain a string ``'false'`` but a real boolean
can you revert this change?
No need to reference the issue here. (also a typo, heh)
Shouldn't it be enough to evaluate ```union r lt```? Evaluating ```gt``` seems redundant.
Ghent University, 

copy from a correct license header.
Sounds good. I believe we need a dash for 'in-memory' though. If you google it, almost every site uses the dash, including Wikipedia, IBM, and Oracle.
There is a test already about this ;)
You can probably use `self.assertContains` instead of looping through all the possible groups returned.
The concept of globals, to me, are values that do not change. Using `_.defaults` means that the context will only fill in `null` values from the globals.
Correct, this is fixed in the next commit.
this was already removed in another commit - sorry :)
does it make sense to convert all of this tables into one single table that can contain any many object  relations to other many objects?
Any reason not to use `@include hidpi()` here?
nit: add spaces around `+`
description should reflect an optional [COOKBOOKS] argument
That was a blockquote because it was a suggestion of what you should have in the article (a potential quote? I dunno).
I'm not sure,  I have to look into the problem more.
On Aug 6, 2012 4:28 PM, "Shotster" <notifications@github.com> wrote:

> In web/concrete/core/libraries/request.php:
>
> > @@ -266,6 +266,16 @@ private function parse() {
> >  			
> >  			if($exploded[1] == 'packages') {
> >  				$this->pkgHandle = $exploded[2];
> > +				if (count($exploded) == 6 && $exploded[3] == DIRNAME_BLOCKS) {
>
> You are absolutely right. What do you suggest?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/concrete5/concrete5/pull/615/files#r1315437>.
>
>
Could we also add the dataset name. And what is the planning for the other required info like:

* number of landingPages: europeana:isShownAt
* number of digitalObjects: europeana:isShownBy
* number of thumbnails: europeana:object
* license information from the dataset
`$staticCacheHandlerClassName`
а тут const&
this may be acceptable if we clear `audits` table often; otherwise it's not nice to do this when there are more than many thousand rows of a record's audits :) one simple way to look things up more easily is to cache the keys of `.modifications` (comma separated) in a `modified_attributes` column at `before_create`, then index the `modified_attributes` column. what do you think?
consider if ,lookup will work
Please re-write this method to return a boolean value as the method name implies it will do.
I'm using this code to get the current project JobConf (line 47 and line 63).  Is there a better way?
This will still crash if the property doesn't exist.  Also, `g_ascii_strtoll` doesn't improve safety unless you check the `endptr` to ensure the entire string was parsed successfully.  If it wasn't, you should fail the open.

So this function will probably be something like:

    static bool parse_int_prop(xmlNodePtr node, xmlChar *name, int64_t *out) {

(Feel free to use `int64_t` rather than `gint64`; the rest of OpenSlide does.)
Will throw a compile error if  SAFETY_WARNING_LED is not defined.
Best thing is to check if it is defined at the beginning of the file, and if it is not the case raise an error with a descriptive message.
Also the #ifdef SAFETY_WARNING_LED in the periodic is then not needed.
This seems overly-aggressive to me. Looking at where this is used, which is in only one spot AFAICT (`maptrans`), there's no need to check that each key is a keyword. Keys in maps can be just about anything (keywords, strings, numbers, functions, other maps, sets, etc)...so restricting things to just keywords doesn't appear to buy us anything.

Also, as this function is only used once, I'd just inline this as part of the preconditions to `maptrans`.
What are they eligible values for `constraint-type`? Would be nice to list some examples, assuming there's stuff other than "primary key" and "foreign key".
Are these tasks or messages?
If 7 out of 15 tasks get acknowledged and then the machine dies, will RabbitMQ send out the remaining 8 to other machines?
Should be {Comment[]}
I think this can use .isIn(['file', 'sakaidoc', 'link']) rather than notEmpty ?
For situations where the list of extra options are known, I've been filling those out as well in the docs. e.g.,

```javascript
/**
 * @param    {Object}     [options]                             Object with extra options available for the current field
 * @param    {Object}     [options.tenantOverride] Whether or not the tenant should be allowed to override the field value (Default: true)
 */
```

I'd like to continue that.
Why do you pass ``null`` to ``ScalaDebugElement`` (when in its constructor it expects a ``ScalaDebugTarget``)? It looks suspicious
Beide regels eigenlijk zelfs.
For readability, would you prefer if it's merged into the previous method ```_parse_request_uri()```?
Also, pretty sure there is a bug here. In `$this->CI->$model->$rule($postdata, $param)`, I believe `$model`should be `$found_model`.
Trivial I know, but you can you newline each array item?
appender from std.array may be more efficient here.
Выглядит странным получение нового гена из массива DNA. 

Думаю было бы более логично завести массив со всеми возможными генами и реализовать метод "getAnotherGet: currentGen" который возвращает ген отличающийся от гена на выбранной позиции.

В остальном все имеет право на жизнь. Только устарелый код (который закомментирован) лучше убирать, если хочешь сохранить старые версии программы используй контроль версий, делай комиты по чаще и всегда будет возможность вернуться к тому что было.
Общий смысл: сместить индекс на случайное число, отличное от нуля, да так, чтобы не попасть в первоначальный индекс (смещение должно быть меньше count, иначе попадаем в тот же элемент)

Попробую расписать по частям:
arc4random()%(count - 1)  // выдаёт случайное число из диапазона [0, count - 2]
+ 1 // диапазон смещается на 1, теперь это [1, count - 1] и выполняются оба условия - отличие от нуля и отсутствие закольцованности в самого себя
получается: index + [1, count - 1], осталось взять это значение по модулю count, чтобы результат был в диапазоне [0, count]
return [DNA componentsJoinedByString: @""];
Так заметно проще и оптимальнее.)
it "should be valid by default" do
This should probably be in a different pull request. You can do this with branches...
... {
  return;
}
We haven't been using dot syntax for methods that are fundamentally constructors (like class constructors, initializers, `+alloc`, etc.). Sorry that's not documented clearly enough.
This can now use `-subscribeNext:completed:` directly. The explicit `RACSubscriber` was necessary before, but not anymore.
isDivider seems like a better variable name for it
好像跟`upper`有一样的问题
No, they shouldn't. Check:
http://www.robotstxt.org/robotstxt.html
As this is a private function we should rather pass the labels from the calling scope, so we should be able to use this also for the channel image topo. Makes sense?
I would keep the n_components there and put max_n_components here too. max_n_components would be set to None by default in init and set to n_picks during decompose

wdyt?
when an error occurs you need to close response and send a meaningful error message to the user. Also, use statuscode 500 when an error occurs.
I make it so that you can call resultSize() first (sets projection to count rows) and then list() using the same object. Actually this class has nothing to do with Lucene. I've been just playing around :)
@josevalim moved `sign_up` to `registrations_controller` as requested. Also removed the test from `helpers_test`.
Now that we're on Heroku, this isn't necessary. We're just using memcached on Heroku.
Well, Doctrine uses spaces around concatenation, Symfony does not. But this is the symfony doc :)
Actually, they are called `Entity` because of the `Doctrine` implementation, aren't they?
This should be `.. code-block:: php`
referers
=>
referer
const auto& же.
單一物件的命名:
`_post-row` => 一列
`_post-cell` => 一塊
Any reason not to use GListPtr instead?
This project does not put using statements inside namespaces
What are the indentation levels here? Is prep = preps[key] assigned at same point in loop as scilife_name? Use tab=4 to align columns properly, as indicated in the PEP8.
ST doesn't update the current directory when you switch between files to reduce I/O waiting. The standard thing I do is consider the current view's dir to be the the ideal working dir for the user and use that.
Yes sry
use `\task_abstract` constants instead
BTW if you rebase on master, this should have already been fixed
Debug code :)
In the begining, we showed image by

```python
arr = fits.getdata('image.fits')
ax.imshow(arr)
```

This means that data coordinate of ax is pixel coordinates. So, default should be pixel coordinates.
> The original commit of the test has both, I just made them all the same.

Yeah, I have been lazy about leaving console.log in the test apps. It would be better to use CPLog.info.
Why checking overlayPosition for null twice in this line?
I think the fact that transferred state is ignored is more important than the fact that keys are not recorded any more, maybe the method should be called stopApplyingState()?
I thought the same myself, but wanted to get feedback, since these "freetype_version=" arguments seem to appear everywhere. Indeed, test_axes has a couple of tick-less plots. Point taken.
@WeatherGod That comment goes way beyond PEP8.  If you want to re-write this module with variables more to your liking, do it in a pull request following this one.
I think @WeatherGod is right -- maybe we change this to read "pretty-printed strings instead"?
This prevented the committee election dashboard from finding the election during the closed phase causing a null object error. Not sure if removing it will damage any other functionality so I just commented out out for now.
Is there a Moztrap test that we can associate with this test? I'm not sure I understand what the intent of the test is?
QUrl::fromLocalFile
Well my domainfactory search the correct implementation for the correct openEngSB version. With one factory, you can connect to serveral domains on diffrent location. I saw this as a feature. On the other hand, including the paramets in the factory is also possible.
Think you meant `$where .= ...`
Sorry, but I don't understand why.
Thanks nijel.
A name like `tele-clean` is a classic sign that you've got a function that's doing too much. Telescoping is one thing, cleaning is another.
Can we check that it responds to join instead of checking if it is an array. :tada:
same here for the outer for loop
typo? should be $partialResponse
try/catch would be fine, or if we can access that function from the assert module that would be better but im not sure if they expose it or not
Fixed. Perhaps we should be using $VERSION?
Are you sure ``$this->connection->getResource()`` has the correct type as ``object<Zend\Db\Adapter\D...\Mysqli>|object<mysqli>`` is not a sub-type of ``object<mysqli>``?
is there ever a scenario where we have to protect non-Latin letters? Maybe things like Ä Ö etc.?
*+[ NSData dataWithBytes:length:]* would go to the autorelease pool whereas *[[NSData alloc] initWithBytes:length:]* will be added to the dealloc method by ARC, so *+[ NSData dataWithBytes:length:]* will probably stick around a fraction longer. I'd think  stick with the instance method.
whats your thoughts on just setting data if its not set, and then doing a kwargs['data'].update() ?

(or potentially checking for each key in the response of get_data_from_request and setting it if it doesnt exist in data)
Period is a non alpha character
`count` is costly, better to use `(not (empty? ...))`.
This doesn't need the by reference. Please remove it.
no need to pass 1 as it's the default param
See how we are doing it in node.js, when we are building list of online users.
Please make sure URL is kept (officially it should be e-mail address). But update it to new location.
`[ ... ]`???
NOOO. Move this to `tasks.py` in your panel app, not to frontend. So along your `models.py`, add `tasks.py`.
Can you please describe it in more detail?
Returning four-element tuple is not good. It shows complicated API. You should define good internal APIs. For example, returning an object. Or in this case, this could could simply be moved to `get_context`.
This is not a constant, why use all upper case?
Hmmm, forgot about that. I'll change it back.

On 21/02/12 18:39, Joe Groff wrote:
>> @@ -247,6 +248,10 @@ inline overload greater?(a, b) = lesser?(b, a);
>>
>>   inline overload greaterEquals?(a, b) = not lesser?(a, b);
>>
>> +inline overload compare?(expr1, fn, expr2, ..args) : Bool
>> +    = if(not compare?(expr1, fn, expr2)) false else compare?(expr2, ..args);
> Are you sure about that? `and` short circuits.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jckarter/clay/pull/227/files#r472427
I think most of the capital words in the descriptions should be lowercase ;)
bro, alignment! tsk
Nah, this is abstract and is never used.
looks like it's slf4j, I'll switch over to that.
Because when folder is created, its exists to make again. and generates error.
Order imports alphabetically.
I am not sure to understand the need of 'while True' here.
I'm not sure to understand what's the purpose of this. Care to explain a bit more?
I'm ok with saving observes in `resolve, reject` pairs if you think that improves it, I just did not want to make more object allocations and have not viewer this as an issue.
validate parsed is not null or empty.
(label_options[:class ] ||= []) << 'checkbox'
Quickly checked in 12.02 and 12.10, works fine. But in the end it's always the safest looking things that fail, I'd prefer having it on a bugfix package so we can point to a test that covers it.
Looks wrong. You should never access a private member on something else than this.
for future: we can check for singular exog here, since we already calculate the rank and raise an exception as an option
This seems like an unrelated bugfix.
Also, if you'd rather keep it, then in the second RuntimeError, "first" -> "second".
build up the url from the hosted_publishers. See above.
changed :-)
Thanks for remembering the database_example.py.  :)
did a db reset due to a typo in a model early in testing. maybe schema was untracked afterwards and didn't update.

will use master's during merge
What synchronization model does javax.ws.rs offer?
If it doesn't give guarantees of having passed through a suitable synchronized block then entities and policies should be volatile.
Add tests that call the Main class parser directly with various sets of arguments ( see above)
Should we also log the exception if it was the "default scanner"?
Should this be commented out? Or did you mean to delete the method or call `super.stop()`?
could we subclass Factory directly here to do the post-processing, rather than add post-processing closure support in the factory?

we need a framework way to intercept/hook to events but i'd rather use policies than closures.  policies can listen to a generic entity_managed event (so the enricher could be added, with a suitable subscribeToDescendants method).  also policies can listen for method invocations (and possibly returns).  such framework events would allow e.g. jurisdiction, permission policies.  (e.g. "aled isn't allowed to do X", and "not allowed to do X when not in location X".)
Then it should be declared as `objc.Class`or casted to `objc.Class`. The `isa` member returns the class of the object. In this case the object is a class, in that case `isa` points to the meta class of the class. in Objective-C, unlike D, classes are objects themselves and are instance of a meta class.
Hi! thanks for the comment. Could you point me in the right direction - I am new..
Thanks :-)
On Thu, Feb 23, 2012 at 2:09 PM, Dan Yamins
<reply@reply.github.com>
wrote:
>
> Well, so one option would be to requre the bandit to provide idx and vals;  so then the question becomes "how does the bandit get them"?  Well ... I think it could GENERATE new idx, vals pairs first ... as a way to generate the other configs, avoiding the reverse problem.

I totally agree, but there is I think some work to do to make this happen.
The more commonly employed variant is "all the things"—but I like "all of the things," too. :smiley:
I could split it to the
```
$arrRecipients = array();

if($arrForm['cmailAdditionalRecipients'] != '')
{
    $arrRecipients = trimsplit(',', $arrForm['cmailAdditionalRecipients']);
}
```
but why do that and not to go shortcut? The ```$arrRecipients``` will remain an empty array anyway.
Since this is in web.js, can we remove the commented-out version from responses.js?
This test helped me locate caps in the rule system. The main entry point is in View.py
Я убрал final с метода supports.
неавторизированные, мы же не можем гарантировать что после ассепта на сокет прямо моментально придет hello
Со Scanner возникнет проблема, что он не работает с бинарными файлами. Лучше использовать FileReader.
Где название пакета?
If it's run there then it should work
Maybe we should remove this step and instead use a helper function like this (though I'm not sure how this might affect performance):

    cdef inline cnp.uint8_t get_pixel(cnp.uint8_t* image_data,
                                      Py_ssize_t rows, Py_ssize_t cols,
                                      Py_ssize_t r, Py_ssize_t c):
        if r < 0 or r > rows - 1 or c < 0 or c > cols - 1:
            return 0
        else:
            return image_data[r * cols + c]

Was there any special reason for allocating an extra array for this?
Please add the shapes in the error message.
I think ``n_iter`` would be the right thing.
We use ``n_iter`` in SGDClassifier already, where it has the same meaning as here.
I would get rid of $bodySet.
Instead of `if (TRUE === $this->bodySet)` we can use `if (NULL !== $this->body)`
Why are you using a specific version of jQuery?
Why did you use this injector approach, rather than making UserTransactionListener a service?