labofsahil/github-event-dataset-2012 huggingface dataset:
In my opinion, we should definitely use double for ratios. And use parentheses to clearly declare associativity in arithmetic expressions - it's better for the reader as he don't need to thing what is the default associativity and precedence for operators and also for the author as he can't make a mistake.
use `{@inheritDoc}` instead
Same here, we should keep testing injections.
one line too far
Should the a 'version' be serialized (and checked other end) separately instead?
yes, I know create was fine.. but I knew or thought I knew others also have similar issue, so it is a general thing really..
Is this really a throwUnexpected() ?
This isn't right, wasn't before.
It shouldn't be checking the <Cluster> name.. the name is arbitrary.
For Cluster type, you need to look at what target cluster processes it has (ThorCluster / RoxieCluster ..)
And to check if legacy or not, you need to look at [a] inside ThorCluster for @Legacy flag.

All ThorClusters' must be of same type (legacy or !legacy)
You can't mix ThorClusters with RoxieClusters in a <Cluster>
Although the ClusterInfo code in workunit.cpp lists multiple thor process clusters per target, am I correct in assuming that a given workunit would have only run on one specific process?  If so, maybe we could write the selected process to the workunit at run time?

Then Kevin could just take the process from the workunit and call getConfigurationDirectory().
Just playing devils' advocate here...

What about the cases where it still should be treated as constant (not sure which, but). Shouldn't the ```no_table``` part test if the ```nonEmpty``` atom is set?
Can you add a type hint for `Request`?
What type of error? `ArgumentError` seems appropriate.
Same thing about the license.
improper parameters
This is to fix an outstanding issue when running from a Mac.
Is 'directory name' clearer here?
@yuhunglin since we haven't committed this yet, can we remove the extra space before `:`? (here and below)
Do the auth params go in the URL and not as part of the POST body?
I updated this in master. Can you test it for me?
This is an important method so we should work together to clean it up and make it as readable as possible.
Better to do an `is_readable()` check than supression `@` which is *exceedingly slow* when supressing errors.
to simplify the code

```
gradients = _compute_gradients_3d(data[..., 0], depth=depth) ** 2
for channel in range(1, data.shape[-1]):
     gradients += _compute_gradients_3d(data[..., channel], depth=depth) ** 2
```

or just 

```
gradients = 0
for channel in range(data.shape[-1]):
     gradients += _compute_gradients_3d(data[..., channel], depth=depth) ** 2
```

Here I would definitely enforce PEP8 for the square operator (whitespace around operator), to make it more obvious to the eye.
If possible, let's just extract the HTML content of this function to a separate template in wpsc-theme folder and include it in this function. That makes it easier for people to customize.
Again, not sure about `console.*` calls.
@IanLilleyT was appending this to GLSL identifies which have a 256 character limit (in WebGL, not in OpenGL or OpenGL ES).  Now I believe it is just used for creating a material type name if the user doesn't provide one AFAIK.
This function creates a bunch of throw-away instances and also needs to use static functions; it can be easily optimized to something like the following:
```
var intersectScratch = new Cartesian3();
AxisAlignedBoundingBox.intersect = function(box, plane) {
    if (typeof box === 'undefined') {
        throw new DeveloperError('box is required.');
    }

    if (typeof plane === 'undefined') {
        throw new DeveloperError('plane is required.');
    }

    var max = box.maximum;
    var min = box.minimum;
    var center = box.center;
    intersectScratch = Cartesian3.subtract(max, min, intersectScratch);
    var h = Cartesian3.multiplyByScalar(intersectScratch, 0.5, intersectScratch); //The positive half diagonal
    var e = h.x * Math.abs(plane.x) + h.y * Math.abs(plane.y) + h.z * Math.abs(plane.z);
    var s = Cartesian3.dot(center, plane) + plane.w; //signed distance from center
    if (s - e > 0) {
        return Intersect.INSIDE;
    }

    if (s + e < 0) {
        //Not in front because normals point inwards
        return Intersect.OUTSIDE;
    }

    return Intersect.INTERSECTING;
};
```
I was actually thinking of not setting the status on the response at all since we are just forwarding to a view and not returning this. Not sure what setting this provides to the end users in this case.
Same thing here about the code being verbose.
This fix has been undone, as per a following conversation with Blain.
Temporary files are generated in send(). We may have only one http client but call send() many times.
If this needs to be done on the main thread, we should use TiMessenger.sendBlockingMainMessage().  If not, we can probably just do getScrollView().setEnabled() directly.
Sorry, missed this comment on my earlier update. I didn't know how expensive it was to create a new GeomagneticField, so I didn't want to overdo it. Once every 10 minutes is good by me. Around here, the declination correction only changes about a 1/10th of a degree for each 60 miles. It changes a lot faster inside the Arctic circle, but IMHO, anyone who uses an Android app for navigating inside the Arctic circle is asking for trouble.

When you say, "We could register one..." Do you mean adding a location request in TiCompass? I think you might need to hold my hand for that one ;-).
Can we update to the latest? Is this just CSS? If only CSS, does it require a Dart example?
This can be removed when the class below is removed.
This should probably be in double quotes so the variable gets interpolated?
you should remove these comments
Oh. Yes. Was too tired yesterday... sorry. Will fix this typos
On 30 Aug 2012 09:09, "Steven Benner" <notifications@github.com> wrote:

> In jquery.powertip.js:
>
> > @@ -60,6 +60,23 @@
> >  		// hook mouse tracking
> >  		initMouseTracking();
> >
> > +		// destroy associated powertips
> > +		if ('destroy' === opts) {
> > +			return this.off('.powertip').each(function destroy() {
> > +				var $this = $(this);
> > +
> > +				if (!$this.attr('originalTitle')) {
>
> I think this is supposed to be if ($this.data('originalTitle')) {. I'm
> guess that the not operator is a leftover from the first version, and
> originalTitle is saved via .data() below, not .attr().
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/stevenbenner/jquery-powertip/pull/29/files#r1493995>.
>
>
На стейдже версия подключается. например, в презентации и qs. Лейтест вообще нигде, кроме страницы latest, не используется, помойму.
@fwenzel is right! Set your Sublime Text 2 mode to be 4 spaces plz!
How about 

Refinery::Core.site_name[request_locale] || Refinery::Core.site_name[Refinery::I18n.default_frontend_locale]
It's CTFE but point taken :)
unusual alignment, use two indents instead
It seems to me the name `Delegate` assumes that the all visiting functions should be `delegate`.
In other words, it argues that non-nested functions are not allowed.
But it is not correct because `visit` can get both functions and delegates.
Therefore, more generic name would be better - e.g. `Handler`, `Receiver`, ...
I just want to discuss my ideas, and want to hear what you think about them
:-) how do you want this regulation to look like?

On Mon, Oct 8, 2012 at 10:00 AM, Felix Mayerhuber
<notifications@github.com>wrote:

> In
> components/ekb/persistence-persist-edb/src/main/java/org/openengsb/core/ekb/persistence/persist/edb/internal/PersistInterfaceService.java:
>
> > @@ -65,6 +72,7 @@ public SanityCheckReport check(EKBCommit commit) throws SanityCheckException, EK
> >       */
> >      private void runPersistingLogic(EKBCommit commit, boolean check, boolean persist)
> >          throws SanityCheckException, EKBException {
> > +        enhancer.enhanceEKBCommit(commit);
> >          if (check) {
>
> you want to introduce the hook principle also for the persist interface? I
> mean if you think this is necessary I can add that too of course. Just for
> information: I want to add in a later pull request that the enhancer can be
> regulated, so that the user can decide different automatic update levels:
> eg: no update propagation at all, update propagation only for engineering
> objects and full update propagation
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/openengsb-framework/pull/776/files#r1782497>.
>
>
or the better question: does it make sense defining this in root=
This is a relict from the very beginning I have stared to refactor the ui, when I have changed the behaviour from the user manager from a separate detail page for editing and creating a user to a dialog window. Frankly speaking, at that time I did not pay any attention to the tests, I have just commented them in order to prevent the test failure. Can you fix it by yourself, or is it possible to leave it commented and fix them in the next version or lest leave it unless the rest of my code has been reviewed and approved?
I also think I chose this because it was easier to come up with variable names that made sense :P  Not a big deal.
The tested page doesn't work properly in HtmlUnit.
Yeah!  Docs, Thank you!
Ah wait, do you mean the indexes, i.e. that all the indexes are also given as Text? (because I thought I overlooked to change the sig for `buildExcerpts` but it seems I didn't.)
there is not test for erlang_cookie
once we also ship explicit support for other ORM/ODMs we need to revisit this compiler pass
"not only does it make the library more flexible, but it also makes your life easier."
It would be great if you could configure your IDE to not do star imports - see the README for coding standards
While we're changing this, let's fix this up and make it a button as well.
According to [this article](http://stackoverflow.com/questions/3918189/fast-compression-in-java), LZ*W* is already implemented in Java. Maybe just use the BEST_SPEED option with the deflator stream?
Is the plan to upstream all GDC-specific parts of druntime? I'm just asking because the current situation is very confusing; some GDC-specific parts live only in the GDC repo while others have been upstreamed.
This doesn't run any more
Hi, Gunnar. 
Please, notice this one
Add a project name?
I see this cfop prefix on all these classes what does it stand for?

Also can you add some comments throughout?
I think it's worth adding an `exists(String key)` method too
Please don't use a dot in the event name. Dots have a special meaning in jQuery: they are about namespacing listeners. So here, you would be triggered the ``FOSCommentBundle`` event but only for listener registered with the ``newComment`` namespace``.

It should be a ``fos_comment_new_comment`` event instead.
@lardawge ahh, thanks, I will update.
Is there a potential attribute error here? I feel like we saw that before – not sure if it's worth being more defensive by using `hasattr`.
I'd rather have people use 'np.newaxis' than 'None': it is more readable.
I assume this is a testing method? Can we name this something else? Its naming is somewhat deceptive.
Probably more efficient to delete one matching record than iterate over every record like how you have it now.
Would it be safer to use !== '' here? The danger is when someone has entered '0'.
Yes, with flex-box, but it is deprecated.
GitHub поддерживает язык [Markdown](http://github.github.com/github-flavored-markdown/), в нём можно писать как plain html, так и сокращения для него.

Например, списки можно писать, начиная строчку со звёздочки, например:
* привет
* как дела

Код можно окружать обратными апострофами, например `foo()`
Или многострочный, начиная каждую строчку с 4-х и более пробелов (вместо тега pre)
    console.log('I am code!');
recur --> recursive
ditto above re wording
<pre>
  prepareSenderStages();
  start();
</pre>

where <tt>start()</tt> resets the stage counter and calls <tt>runNextStage()</tt>.
This looks not right?
Кстати, фавикон чому-то перестал мигать. Пару коммитов назад, вроде бы.
> `border-bottom:`

Не влетит. `offE.top + el.offsetHeight` включает в себя размер рамки.
We don't need this.  It will be removed.
Instead of method which require more overall changes i followed another suggestion and passing information of what fields to blob as separate parameter *argsToBlob' instead of attaching it as a property of args object and deleting later.
The "correct" way to check for undefined in JS is to use ```typeof x === "undefined"````
Add "Before proceeding" to the instruction.