(#10164) Reject and document icmp => "any"

iptables accepts the string "any" as an ICMP type and stores it behind the
scenes as the fake (IANA reserved) numeric 255. This is functionally
equivalent to not specifying an `--icmp-type` argument.

ip6tables didn't carry this "feature" over. Like many other providers, the
matching of any ICMP packet type is only achieved by omitting the
`--icmpv6-type` arugment.

For the purpose of simpler logic and future provider compatibility we
prevent people from using the value "any" and advise them to omit/undefine
the param instead.

Include a test that somewhat duplicates the prevention of invalid strings
but would preserve this behaviour should icmp_name_to_number() ever change.
Make Puppet DSL compliant with the style guides and puppet lint.
(#11305) Support vlan interfaces (interface containing ".")
(#11305) Add tests for VLAN support for iniface/outiface

This adds tests generally for iniface and outiface, and includes examples
of interfaces with VLAN's to support that change.
(#10619) Add the table when deleting rules

This fixes purging from tables other then 'filter'.
(#10619) Fix tests since we are now prefixing -t <table> during delete
Fix extraneous trailing whitespace
Merge pull request #61 from adamgibbins/master

Improved Puppet DSL style as per the guidelines.
Merge pull request #70 from kbarber/ticket/11305-support_vlan_interface

* (#11305) Support vlan interfaces
* (#11305) Add tests for VLAN support for iniface/outiface
Merge pull request #69 from kbarber/ticket/10619-Unable_to_purge_rules

* (#10619) Add the table when deleting rules
* (#10619) Fix tests since we are now prefixing -t <table> during delete
* Fix extraneous trailing whitespace
* (#13896) Changed 'jump' to 'action', commands to lower case
Merge pull request #72 from jashort/ticket/13896-fix_example

(#13896) Fix Firewall Example
(#14455) Support interface names containing "+"

Previously iniface and outiface wouldn't allow + in the interface names. This
patch fixes that.
(#14455) Add tests for interface names containing a "+". Add a few missing tests for VLAN support.
Merge branch 'ticket/master/14455'

* ticket/master/14455:
  (#14455) Add tests for interface names containing a "+". Add a few missing tests for VLAN support.
  (#14455) Support interface names containing "+"
(#14590) Fix for when iptables-save spews out "FATAL" errors.

On some broken Virtuozzo containers, /lib/modules/$(uname -r)/modules.dep is
absent. This causes iptables-save to give some "FATAL" errors.  This patch
fixes the parser to ignore them instead of generating garbage rules that make
for errors in the puppet agent run.
Merge branch 'ignore_errors'

* ignore_errors:
  (#14590) Fix for when iptables-save spews out "FATAL" errors.
(#14641) Fix for incorrect limit command arguments for ip6tables provider
(#10274) Document Util::Firewall.host_to_ip

Document the current behaviour of Util::Firewall.host_to_ip before it is
modified to handle addresses with zero prefix lengths.
(#10274) Nullify addresses with zero prefixlen

Modify the behaviour of Util::Firewall.host_to_ip, as used by the type to
parse source and destination addresses, to return nil if the resulting CIDR
represented address has a prefix length of zero. Includes type and provider
tests for IPv4 and IPv6.

IPtables silently omits rules with source and destination addresses that
have a prefix length of zero (eg. 0.0.0.0/0) because they are functionally
equivialent to not specifying any address. This was causing rules to be
unecessarily reloaded.

The behaviour of Util::IPcidr remains the same. Now includes some additional
tests for it's identification of zero prefixlen IPv4 and IPv6 addresses.