labofsahil/github-event-dataset-2012 huggingface dataset:
Are you sure ``$evaluation`` has the correct type as ``boolean|callable`` is not a sub-type of ``callable``? Please also check line 39.
Is it possible to add a ``@param`` annotation for parameter ``$url`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``? Please also check line 41.
Are you sure that the method "isStarted()" exists?
Ok, you can check with Tatyana or David, to ask who we should talk to for KS matters.
use spaces around `*`
This is a great design, I think. Good job.
This isn't really a dependency.  It simply looks to see if the incoming value is a JObject and acts accordingly.  You sure you want to get rid of it?
Size change corrected in 88945c.
It's actually a set of regexes, and at least one must match. I've fixed the docs. Wim and I also talked and changed the design for this in both Java and C#.
As `admin.js` tries to match all `buttons` of the class `confirm` I changed this to `contents.on('click', 'button.confirm', function() {})` which will handle all confirm messages in the the content area no matter if they have been added dynamically or not.
Turns out this was vulnerable to injection, so I fixed it by validating
against a whitelist, as suggested in
http://stackoverflow.com/questions/7771103/rails-3-activerecord-order-what-is-the-proper-sql-injection-work-around

On Wed, Sep 26, 2012 at 6:53 PM, Ben Weissmann <notifications@github.com>wrote:

> In app/models/evaluations_datatable.rb:
>
> > +      [
> > +        evaluation.name,
> > +        evaluation.prod? ? 'Production' : 'Sandbox',
> > +        evaluation.status_name,
> > +        evaluation.user.name,
> > +        evaluation.created_at.in_time_zone("Pacific Time (US & Canada)").strftime(ClockworkRaven::Application::TIME_FORMAT),
> > +        evaluation
> > +      ]
> > +    end
> > +  end
> > +
> > +  def evaluations
> > +    @evaluations ||= fetch_evaluations
> > +  end
> > +
> > +  def fetch_evaluations
>
> This method is a little confusing, and while I don't see any SQL injection
> vulnerabilities here, it might be good to explain why, in this case, the
> string interpolation you're doing is OK so future updates don't
> accidentally introduce injection vulnerabilities (e.g. why it's OK to use
> Evaluation.order("#{sort_column} #{sort_direction}") in this case)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/twitter/clockworkraven/pull/13/files#r1702558>.
>
>
See, user channel is not a constant but is something you get from user in request. No need to have this in context processor.
also still problem with time :/

i get error in horoscope:
* can't compare offset-naive and offset-aware datetimes *
Where is `map_loaded` defined?
Maybe just rename this file to `resources.py`? Then you will also not have importing problems bellow.
yes, no more than 20 requests from the api per second. (http://api.met.no/conditions_service.html)

Can I just add sleep function?
Tuples.
I do not follow now :) I moved

    <div>
        <ul id="userlist"></ul>
    </div>

to the end of home.html. Good for now?
OK, obj_create returns `bundle`, not `obj`. Code would be clearer if you would do it like that.
If you use `formatDiffTime` you also have to register automatic updating of diff time as time passes. See how it is done for posts.
`required=True`?
No, you should not allow verification through `get`!
Agreed. Definitely, it is wiser to pass different values from default. Noted down.
Did I wrote this implementation of `Equals`? Unbelievable.. Yes, each instance field defined by the type must be compared.
You can use the template tag `url_for` to make sure this link never breaks:

```html
<a class="btn btn-inverse btn-large" href="{{ url_for('about') }}">
```
GetHitUnit() will return NULL in the OnHit hook
Use OnEffectHitTarget.
there is a test, but sure how encompasing. should see if comment should be revised or removed
yes my bad. I'll fix that.
re: original contributions - agreed.

just so you know, i have a clinicaltrials.gov parser in the works.

m.

On Sun, Sep 16, 2012 at 9:48 PM, Peter Ansell <notifications@github.com>wrote:

> In ns.php:
>
> > @@ -72,6 +72,7 @@ class CNamespace
> >  	'dip'       => array('name' => 'Database of Interacting Proteins','url'=>'http://dip.doe-mbi.ucla.edu/dip/Main.cgi'),
> >  	'ddbj'      => array('name' => 'DDBJ sequence database'),
> >  	'dpd'		=> array('name' => 'Health Canada Drug Product Database','url'=>'http://www.hc-sc.gc.ca/dhp-mps/prodpharma/databasdon/index-eng.php'),
> > +	'dbpedia'	=> array('name' => 'DBPedia', 'url'=>'http://dbpedia.org'),
>
> "clinicaltrials" sounds good to me as a replacement for linkedct_trials.
>
> I think we should recognise the novel contributions from both dbpedia and
> linkedct.
>
> For example there are dbpedia.org/ontology/ entries that we may want to
> support, as it may be better in the long term to have them in a namespace
> called "dbpedia_ontology" rather than "wikipedia_ontology", again incase
> wikipedia or another third-party has an ontology attached to it without
> reference to dbpedia in future.
>
> Linkedct also has manufactured some of its own identifiers, although I am
> not sure how stable they will be. In either case, we may want to keep
> namespaces like linkedct*locations. From looking at the list of
> namespaces at http://data.linkedct.org/, we may end up keeping the
> linkedct* prefix for namespaces that are MD5/SHA1 type hashes and convert
> some of the others to use a clinicaltrials_ prefix. The key to the decision
> for each of the subnamespaces inside of linkedct and other databases is
> where the identifier was created. I have not looked at the raw
> clinicaltrials.gov data dumps for a while, but I think there was more
> than one namespace internally, so we will need the clinicaltrials_ prefix
> for the non-trial identifiers. It seems fairly straightforward that the
> clinicaltrials: namespace could be for the trial identifiers (including the
> NCT prefix?) in this case, in a similar way drugbank: is for drug, and
> drugbank_... is for the other parts of drugbank.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/micheldumontier/php-lib/pull/14/files#r1615580>.
>
>



-- 
Michel Dumontier
Associate Professor of Bioinformatics, Carleton University
Chair, W3C Semantic Web for Health Care and the Life Sciences Interest Group
http://dumontierlab.com
Actually, yes - if there is a big spike in elevation just outside the viewport but within the extended bounds, then you won't get as much contrast within the viewport, i.e. you might not see all the colors and it would be harder to see contours in detail.  Admittedly a small detail.
why is this? a comment would be welcome
Pull request at https://github.com/mspnp/cqrs-journey-code/pull/13
This should be `[[ -n "$WORKON_HOME ]]`.
I added it to be able to use it for maximum trimmed likelihood as a subclass : ``self.target_attr = 'nllf'``
(I didn't have it in my first version, and I didn't adjust the names to reflect that the target could be different from ssr)
If we don't want the kwds in the ``self._data.__dict__``, then we shouldn't put it there in the first place, 
store in temporary dict attribute ?
Hmm yes...  that's not a bad idea.  I'll look into it.
are these actually used now?
Why redirect to `/`? Why not back to the site from where user came from? Or at least to the `home` URL (as specified in `urls.py`). Do not hard-code things!
you can't match positional arguments with named arguments (or the argument collection).  The arguments scope when submitting positional arguments is a struct with numbered keys.  Those keys are not necessarily numbered in the order they are submitted.

The only way to enhance this (I can conceive of) is to change $args to receive an array of arguments so we could control the order.  That would not be backwards compatible at all though.

This was passing coincidentally.
This should be a private variable: `_app`
Also, do you really want this file to go away?  I would have thought this was still appropriate in the devel/doxygen_tutorial directory.
We have been using `/**` `*` and `*/` for multiline doxygen comments so far... Perhaps just shorten the comment slightly??
Perhaps describe in the docstring along the lines that this function `acts as a wrapper for the BuildSingleImage, BuildTiledImage and BuildScatteredImage functions, choosing between these three using the contents of config if specified (default = Single)'
this is fucking clean
I like the single line version better btw (both are ok)
deprecated is a warning, isn't it?
ahhh good point
This might have been added back during conflict resolution. We will be removing this file from our repository and add this fix in an upcoming pull request.
SET (sintaxe SQL) em minusculo : set
1 and 0 aren't legal password characters?
Using `present?` for now (not familiar with `persisted?`)
This is a tiny thing but I prefer to create objects with a single expression rather than two.  ``...objects.create`` is normally how I create objects.

Eg prefer::
    
    fp = FlatPage.objects.create(title='testing')

over 

    fp = FlatPage(title='testing')
    fp.save()
MongoDB store data in JSON structure.
I think it should be a good thing to store log informations inside different fields. Not in a formatted and unique field.

Because, I think that formatted field is only interesting for simple "Line" storage like *.log file.
Updated. 
(sorry about the slow update -> weekends, kids, no life, QQ....)
I don't love this, but I have been testing a lot of integer equality in the diff tests (e.g. how many files were different, etc.) and I got tired of error messages that were not giving me the details of the actual and expected values, so I wrote this macro. Unfortunately, since I need to sprintf the values, I can't write a generic version of an equality test and I need to have an int specific one.
Yep ok. With the flakiness of window systems in this respect, perhaps it would be good (and a little more efficient) to make it a little independent, e.g.

if(isHidden()) show();
else if(isMinimized()) showNormal();
else if(isObscured()) raise();
activateWindow(); // this (sometimes) helps with keyboard focus on Windows
I didn't use static because self was used in other parts:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Response.php#L318

but as you point out, it's probably a bug... I'm adding a new commit for that
Is there any reason to actually extend `stdClass`. AFAIK it provides no functionality that would make it useful as a base class.
Archivo vacio jaja. ¿Necesario? Cuanto menos codigo mejor plz. Porque el codigo es grande. Eres muy previsor :D
looks like a left over console.log. Should it be removed or commented out?
Exactly: once we get a unique place to put all board-specific constants, then this plugin architecture can use them. But the board objects should be able to provide stuff like configuration panels too, and it won't be possible to describe them into config files...
I see this is a signal... Does this get caught somewhere?
All of these should be deleted -- they should be in the openstack-common cookbook attributes/default.rb file, not here...
Anstatt ein neues Property in Operation.cs anzulegen, tue lieber das:

String opID = Guid.NewGuid().ToString()
You have to put .model_for due to the same bug Chris mentioned.

Email here is Galaxy::Email.  This was copied by Zac from a consumer-web app where it was ::Email.  Email.model_for will be ::Email in consumer-aps that define an Email class.
This Region.national call needs to be changed to Region.model_for.national
А как насчёт +0?
у меня автоматически пробелы вместо табов ставятся, только что заново набрала, ничего не поменялось
Не печатается usage в случае пустых параметров.
т.е. hellof будет валидным паттерном?
Is the browser supposed to fire an event in this case? Can you check what Safari actually does at this point?
I'm not sure I understand. Are you saying that the existing code in JDBCReader.java is correct? Because it doesn't seem to work as I expect it. But then maybe my expectations are completely wrong of course. It has happened before ;-)
I know you've changed it already but I think your original code was OK. In some cases we have overridden page.py's `is_the_current_page` where a page has a special requirement and this one's been problematic.

And of course it would only return True if the assertion passes!
@m8ttyB  the style guide says that:
Docstrings should conform to PEP0257 and should be on a single line wherever possible. 
https://wiki.mozilla.org/QA/Execution/Web_Testing/Docs/Automation/StyleGuide
Space :scissors:
replace *do* with *make*
can you test the fast_logdet from utils.extmath ?
added an XXX to not forget. Won't do it now
On Thu, Aug 02, 2012 at 02:18:29AM -0700, ibayer wrote:
> After a serious amount of headache ( I was working inside ``cd_fast.enet_coordinate_descent``) if saw this two lines and felt cheated ;-), and therefore made it explicit that alpha != l1_reg . 

OK, I'll by this argument (as I said, I prefer your convention). Just
document the change in doc/whats_new.rst

G
manifold learning should be lower case
These should be mobileweb, not two words or upper case
need to avoid self-assignment here.
No need for `TiRootObject::` but I guess it doesn't hurt.
fixed for iphone. mobileweb doesn't seem to care
Sorry, this project was simply set up with the wrong formatter...
The copyright symbol doesn't mess anything up, right?
loop should be unconditional - it can never be null
Not sure if there's any point testing the -1 case. Should probably also update the comment
I would put the class as key to make the check faster (doing a key lookup instead of a search)
Oops I actually totally misdiagnosed this, fix coming up
Same thing, that's the same as ``isodate()``.
@rhelmer How do I break up long if statements without causing a syntax error? It seems I cannot just break then to two lines.
maybe `newWindow()` or `new()` which feels more consistent with `newFrame()` /  `Base.new()` to me. But I can also buy into `open`.
I think we need to instead use ArrayUtils::iteratorToArray() if $values is not an array but is an object.
Is this necessary? It seems like we should pull the controller from the locator by classname at this point; if it can't grab it, then we know the class does not exist.
$this->view->escape()
Look carefully at the getter, it returns `self._meta.sequence` if `self._sequence` is `None`. Basically it falls back to `Meta.sequence`, if `Table(sequence=None)`.

`Meta.sequence` defaults to `None`.

I think it makes sense to make `Table.__init__` do `self.sequence = sequence or "..."`. That would simplify things. A slight backwards incompatibility, in that `Table([]).sequence != None`
add a "return isElementPresent(header);" this will return false when the object isn't found and return true when the object is displayed.
Do you mean the module is unused?  Or that I don't use any of the features of ActiveSupport::Concern?  I suppose I could just use it as a normal module since it's not nested include'd anywhere and I don't use `included do end` or ClassMethods.
We have added description  for the same.
Tests needed for circular vs non-circular cases.
This is fine the way it is.
Why did we introduce this class?  And why is it so tightly coupled to `TextureAtlas`?  What value does it add?  More classes is more code to write; more code to test; more code to debug; more code to document; etc.

Less is more.

Can we get away with just returning an object literal like we did before?  Instead of returning `x0`, `y0`, `x1`, `y1`, it could be two `Cartesian2`s.

If we need to introduce a type like this, it should be more generic, but I'm not convinced that we need it yet.
There was a method `Matrix3.fromAxisAngle`. It was removed as part of @mramato 's improvements to Core. @mramato Why was it removed?
@mramato might have said this elsewhere, but make this a private function, e.g., `TextureAtlas.prototype._computeAtlasSize`, and you'll no longer need `var that = this;`.

Also, do you see why `// Compute atlas size` is a useless comment?  Comment how, not what.
I was thinking of the parameters. My mistake.
I guess so, I will promote this algorithm and the binpacker. They will extend the Algorithm model class and will be placed in the model package.
为什么写的是MUSIC_SETTING，load的却是mouse setting？
Why not directly new Array<Variable> ?
On Android, it can also be called after the section is added to a table.
In this case, they can't be without a restructuring of the map code. The ability to create an annotation is currently dependent upon the view being attached.
nil, not NULL
You can use [libxml_use_internal_errors()](http://php.net/manual/en/function.libxml-use-internal-errors.php) instead of silencing the error.

In addition to preventing the error from going to PHP, you *could* also show the actual parsing error message using [libxml_get_errors()](http://php.net/manual/en/function.libxml-get-errors.php).
http://openradar.appspot.com/11596316
лучше ноопы поставь если не файлапи
since what you're doing is hiding all the elements and the showing only the interesting ones, this loop is actually part of the CB, I think

You're already hiding in the CB some actors, is it not the same? (ie aren't you duplicating efforts?)
could you do another commit which reverts the build file changes so i can merge the request?  thanks!
`is(Unqual!T == bool)` and `isBoolean!T` seem to do exactly the same thing (albeit with a different implementation), so it's purely a matter of aesthetics either way.

But if we're adding `canSwapEndianness`, I think that it would be better to just make the changes to `nativeToBigEndian` and friends at the same time rather than creating a new pull request. Otherwise, std.bitmanip is left in kind of a funny state. If that were the only tweak that still needed to be made, then I'd probably just merge this and leave that for a further pull request, but the enum value names need to be fixed, so more changes are needed anyway, so you might as well just make the tweaks to the other template constraints at the same time.
Make this `auto ref` and make it so no assignment is done if the parameter isn't assignable.
Because last time I looked a far amount of crap code in MC wasnt intelligent and required this to not be null.
Probably only for community, we're still working on this.
models or needs
Hmm, so this middleware is just syntax sugar to turn "x_y" into "x" key in env?
mauvais projet
Accessing the subresource `full` gets you more information. I would think something an alternative format if it returned the same information but with different "packaging".
If someone extends the class, the static method would not be overwritable (you cannot use ``static::...`` to call it as you are not in the class but in the closure, forcing you to use the class name to access the static method)
Exact match is not possible because of the dynamic SAMLRequest part, but I will add a test for absence of all the dynamic params.
Why the comment is too far from the end of line?
You can replace this whole case statement here with something like:

      def syslog_facility(facility)
        begin
          Syslog.const_get("LOG_#{facility.upcase}")
        rescue NameError => e
          STDERR.puts "Invalid syslog facility #{facility} supplied, reverting to USER"
          Syslog::LOG_USER
        end
      end
indeed, it is not for proxies but for entities (or documents once the implementation is switched to the Common interfaces for Sf 2.1)
hm, i like being explicit. and when we default to null, the code in the DependencyInjection will look funny as well, as we would have to distinguish between === null and === false which usually are treated the same. does true and false still get converted to boolean here? if they become string, the rest of the code is wrong (as would be https://github.com/symfony-cmf/MenuBundle/blob/master/DependencyInjection/SymfonyCmfMenuExtension.php) because string "false" is true in php.
И тут. И ваще везде дальше.
I don't think we should leave comments for bugs.  This would be better handled in an issue on their repo.
Yes, find and replace mistake. Fixed.
Dismax check is moved up + No need anymore to split a filter string anymore.
Given that this element can now emit messages during initialization, I think it needs to implement SmartLifecycle and we need to document that it needs to go into a late phase (after all downstream components).

This also means we should probably expose auto-startup; and it also probably means a dedicated scheduler is __REQUIRED__ so we can shut it down to cancel scheduled tasks when stop() is called.

Maybe we need to push this to __M3__ ??
Internal function (metricList, metricName) can simply be anywhere. But for exposed API I suggest jQuery. Because then you can have multiple plots on same page. So you do `$('#plot1').datastream(options)` and this is independent and have independent state then others. (Some state can be shared in secret, but not really exposed. For example, manipulation of anchor/hash in URL should probably done together with all instances.)
But you never execute settings.py as a script!

This looks likes premature optimization to me.
The site for download the files is http://packages.zendframework.com/
@apex13 Can we add some top margin here?
Неплохо бы дать описание того, что тут у нас в каждой строке.
Think this should be Client: https://github.com/seddonmedia/cakephp-oauth-server/blob/master/Controller/Component/OAuthComponent.php#L147
Also, models are singular by convention.
typo here

Geocoder -> Geocode
Fixed this and the three previous comments
Okay, I'll revert them as public.
I'll talk you how we use url_entities and work with entities extracted by APIs on twitter-text later.
Nope, that works for me.
OK, from version 30 of dynamixel, P and D are inversed
i thought it was important. :)
Why is it called `session_check` and not `session`? It is a session after all.
Umm ... I tried it ... Praxis wins ;) I tried every gamemode , it won't regenerate when in Nightmare .
Another dependencies:

SDL
SDL-TTF (the one you put above)
SDL-Image (the one it's missing).
Why not modify the comment as well.
Maybe we should simply use the URI module that comes with Elixir?
Why do you use setTimeout() to trigger the callback..?
would this handle the multiclass case?
Lol, i just changed this in the commit I'm working on too
pre-append -> pre-appended
MPL or PD.
I could change it to use that constant. Is there any use case where we might update the version of one and not the other?
We have '0755' value so far appear in session.js too, do we want to refractor it out? What file is serves for this type of things in general?
The comma after may bothers me.