labofsahil/github-event-dataset-2012 huggingface dataset:
[ Quoting <reply+c-964271-1cb24e6786> at 03:52 on Feb 14 in "Re: [dns] start fixi..." ]
> Here, again I'm not sure, but comparing to the the specs of e.g. NULL RR presentation format, I think the `0` length is not allowed. I.e., when RDLENGHT == 0 the presentation form of the RDATA would be only `\#`, sans both the count and following data. Thougths?

Examples in rfc3597 says otherwise, but that is just the example.

 The RDATA section of an RR of unknown type is represented as a
   sequence of white space separated words as follows:

      The special token \# (a backslash immediately followed by a hash
      sign), which identifies the RDATA as having the generic encoding
      defined herein rather than a traditional type-specific encoding.

      An unsigned decimal integer specifying the RDATA length in octets.

      Zero or more words of hexadecimal data encoding the actual RDATA
      field, each containing an even number of hexadecimal digits.

The number of octets look mandatory to me.

grtz Miek
Thanks for the heads-up. Fixed in a64e037d1c9500b72546b0de57d4bda317b06b50.
This is just experimental, if @Luzifr approves less we will include a compiler.
@Tie-fighter Could you explain what you mean by that? In my understanding, exploiting is making use of found vulnerabilities. That's what he did.
Background: In the case of assets I remember talking with Josh about it (I wrote the compression in sprockets). It was decided to generate the gzipped files with no way to opt-out (I don't know if it is still the case) because it was fast and if you do not have the web server configured the .gz files are just ignored. If users come in hordes needing a flag one could be added :).

Not saying page caching should do the same, just giving context re assets.
Yea sorry about that, I have submitted another commit for other fields as well https://github.com/fuel/core/pull/816
Yeah get_url was an obviously good refactor :D
Regarding CommonJS in the browser, with the caveat that I googled this quickly and didn't verify at all, this page seems to indicate that at least a few solutions exists: http://www.2ality.com/2011/11/lobrow.html (scroll down to related work section). I'm not sure how well they work though.

I can certainly live with the added nesting as long as it plays well with the node community and doesn't create too much of a Narcissus-related headache.
We're [partially mocking the plugin class](https://github.com/Multiverse/Multiverse-Core/blob/master/src/test/java/com/onarandombox/MultiverseCore/test/utils/TestInstanceCreator.java#L61) because we want to mock methods like getDescription().
можно и в ап =)
Plus lots of other minor improvements to smooth out the user experience.
You are right... Should have noticed this before. Thanks for clearify
self-review

1) I wanted to send MSG to server, but I did not want to write or copy the same code from ChatInputReturnPressed.
    TODO: separate common code to send message public method that common use.

2) insertText on other methods can break text struct.

  append will add text on the End, it is ok.
  but insertText looks assume the cursor position was the End.
  every time before insertText should ensure the cursor position.

3) maybe no needed "emit", just call the slot directly for this case.
Where does `#require_all` come from?
you should check whether the callback is valid before
Thanks for your - quick - feedback.
Chunk starting here breaks connection to tvheadend - issue #415
Sorry about the terrible commit message. I accidently included part 1 of the patch for fixing #35
s/Those/The/

"3 nodes online" -> "the remaining active nodes in the cluster (3 in this case)"

"That means each node is now handling about 22 vnodes each." -> "That means that rather than 16 vnodes each node will be handling about 22 vnodes (16 + some number of fallback vnodes they are managing on behalf of the failed node)."
Oh, I'm definitely up for it, just don't count on me always being able to work on it.
Other than that, sign me up :)
A comment about this file. Remember that the 'local_data' dictionary in MORSE components is used to store information that will be shared outside MORSE through the middlewares. I think in this file there is no such data, although you use 'local_data' to store plenty of variables.
In this case, it's better to have those variables simply as internal to the class, and if they are not to be used outside this particular class, we have the convention of naming them starting with a '_'.
For example, in this file, things like
self.local_data['wheelRL']
should become:
self.wheelRL
why removing the scriptname? thats where factions are set
Hi Ivan,

Not sure whether the comment I posted on GitHub relayed to you so:

On 2012-01-23, Ivan Maidanski wrote:
> I guess this is no longer needed. Right?

Right, this commit is obsolete.

Cheers,
Petter
I would love to have this be part of SpecFlow.  However, this is the first time I attempt to fork, or contribute on an open source project, and I wouldn't know how to go about it.  I think the best way to get this work would be to have a setting in the visual studio options menu that allows you to switch the file extensions.  Do you think that would work?
Yes, this was just a temporary fix to see what it should look like because the upper case OMIM read from ACe was not matching the lower case in external_urls . This, as well as the If statement below, will be removed once I've updated external_urls in my next commit.
Hey Lukasz, thanks for the project, its a joy to read through. I'm 
considering using it as a base for a new app.

Amit

On 1/10/12 7:12 PM, lukasz karluk wrote:
> thx for this, will add it to the master branch now.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/apitaru/ofxFlash/commit/be41b820c78213c057a243aa666a385f3c31e608#commitcomment-855282
Isn't that what @Override does? Or is this to satisfy checkstyle because it doesn't recognize that there will be docs?
What the crap?  A joystick?  What do you use a joystick for on REIXS?  That's kinda cool.  Also, does it have to be multi-threaded?  I know we generally don't like threads, but I'm just curious.
Take your time! Didn't mean to stress you! Just browsing through your changes to familiarize myself with what you are doing. Looks great!
I am heading to a formal now very soon, so won't have time to do any more work tonight in any case!
Doesnt quite fix it. What happens if a person wants to enable it on the fly? I will add a fix to this in in the next Push I make.
Yes ippa, when the player loses, the game restartes, not the page, that would be quite bad. This is a temporary way of handling it, but thanks :)
:-) Free them on iterating introduces memory leaks. I'll add a comment.
Sounds good, there is no need for it unless the content goes beyond the boundary of the Container bg, I may add a mask feature then. You think this is useful? I think that it will be helpful for complicated forms and maybe a grid of buttons/images where the user chooses things.
What does those changes o?
@themoob But what's that for, could you tell me? My concern is the overall design - it seems to be violating the architecture since serverside should not work with files at all.
Mmaps are freezing ... in thee lines ... after removing them it is ok http://paste2.org/p/1927800

Only once freeze left here: http://paste2.org/p/1929459

Crash number one: http://paste2.org/p/1929461

Crash number two: http://paste2.org/p/1927696
Uncool, but 0.6.0 is needed for Diffie-Hellman. It is possible to create a compatibility shim temporarily and use the old DH code. Patches are welcome.
How do I remove this from the pull request? Everything else looks fine, but I'd rather not merge this file back into the main repo.
But if the client don't make any assumption I guess it would be lagging more often.

Fabian
The else-if block on line 137 is indented too much. Plus all the ifs and elses need colons.

I need to review the rules, but this block is saying that if you bid Cinch, the only possible outcomes are 11pts, 10pts, or -10pts. Is that right?
Still crashing even with this last change - even clean compile http://paste2.org/p/1885464
What trust, you comment it out instead of deleting it as if you'll find bugs in our code…
Y U NO USE uint8
You can simplify this a bit since the maskna property propagates:

    In [2]: a = arange(5, maskna=1)

    In [3]: b = arange(5, maskna=0)

    In [4]: a*b
    Out[4]: array([ 0,  1,  4,  9, 16], maskna=True)
it get created in the constructor.
That's one ugly add button. I'm on it
Isn't NotSupportedException a better one here?
ImageView image_assignment should be ImageView imageAssignment ... bad habbit from C++. Sorry.
抽象メソッドしか持たないクラスのようなものをインターフェースと呼ぶ。
> For a tiddler collection to get render, fat=1 must also be set.

If I don't care about the raw text, should I be forced to download noise?
I've named the external source for a repo GitSource but really, it should probably be RepositorySource and support everything that Downloader currently supports - one for the TODO list.
This definitely works. AOSP does the same thing. I've initialized a few repos myself. See the other change in the gb tree for fixing any issues.
I am fine with the hoisting behavior here. 
the alternative is a little awkward when it comes to readability, imo
Prevents the achieve from being bugged since shortly after this code insert, players are rezzed. As a consequence, we're grabbing the number of dead players before even rezzing them, so that we know that when the first alive player is met, he's the only alive one.
The parameters I chose in app.config was not optimal :). Today I am going to commit a new revision. It revises the Pythagorean theorem algorithm and of course contains a new set of parameters. On my machine and my usage convention this revision further improves movement detection accuracy.
> I manually merged it on vNext

Awesome!

> I also took the liberty to fix your first name, Juliën ;-) (as the author of this commit)

LOL, should probably check that - I was trying to figure out where in the stack unicode chars where getting munged. :)

> Are you sure about the comment in the new test?

No, I'm not sure now that you mention it. It would be simple to alter that test and be sure. I thought that `Set()` didn't actually flush changes to the disk, but I honestly haven't looked at that code.
> Let's imagine we need 2 or 3 autocompleted fields on this page.
Fixed
Thanks
架构不是已经改了么，还要改？
OK, let me know when you have some code up. I also have some graphical improvements planned for the library, since it's much too simple right now.
So this commit doesn't include the implementation... whoops.
Anyway a working one is up now.
Hey Yarsolav, I got your flurry of emails! ;) I will look into this in
a few days. Thanks a lot for the feedback.
-Cengiz

On Sun, Feb 12, 2012 at 9:39 PM, Yaroslav Halchenko
<reply@reply.github.com>
wrote:
> IMHO worth reducing number of "WARNING" words and placing into a '.. note::' environment
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cengique/neurodebian/commit/7dd4235979355d007b33160a4251a1dd19ce4cd3#commitcomment-958739
The more I think about this I think your pull makes sense and is the most graceful way of handling this scenario.  I too had issues with JabbR changing callbacks on me so I know your pain.   I do not think these changes will violate my goal to remain consistent with .NET since the .NET client provides a mechanism to handle only certain parameters.  It might be a little different but that is ok :)

I am going to pull this in and do a refactor or two (hopefully I will remember the semi colon this time)
I actually tried that at first but I got stuck because get_type returned iirc Gvariant( ("type",[]) ) an the docs say the type is supposed to be inferred from the type of the array (second element in the tuple) ... which seems quite tricky to do in python
Glad you figured this out.  We also just noticed that the blog post was out-of-date.  Sorry.  We are working on getting that fixed asap.

-James (Heroku)
Changed an error.
Wrong commit-text though, should be the same as the previous commits.
Если подумать там OMFG творится. :)
This event isn't actually sent through the plugin manager?

Also, minor detail, but I notice the formatting of the new event files below contains mixed tabs and spaces.
Why is this commented out? No scripts.
Should be `_reduce.call(this, iterator.bind(context), memo);` there is no `context` argument in `Array#reduce`.
http://es5.github.com/#x15.4.4.21
This line might lack a .chr at its end.
The upgrade function to 3.2.0 also needs to adjust this field length!
prefer `.last` to `[-1]`, it's a bit more obvious
typo? you mean true instead of this? ^^
On Thu, Mar 8, 2012 at 10:53 PM, Rok Garbas
<reply@reply.github.com>
wrote:

> or is there a usecase i'm not seeing?

I have such a use case right now. We are making a plone.app.theme
based theme for someone, and they decided not to have breadcrumbs in
their design. Pulling up an edit/folder_contents on this site and
selecting only the #content-column-portal bit leaves you without
breadcrumbs (because p.a.theming has had its little claws on it), but
if you pull it from an unthemed source there are no such surprises.
Hm.. Deferred from jsdeferred.userscript doesn't seem to be used ?
We don't add EAI scripts anymore.
Vincent-Michael's comment is confirmed to fix compile. Use that until the devs fix the typo.
porfavor revisar comentarios
useless ?
Sure. Lets see it. Btw, did you scrap your own patches before trying the new version?
Good work ! But for documentation purposes i'd like to have lines 742+743 still in the code ,-) 

Is ```li``` the login status or is it presumably the login status ? What did your tests show ?
actually the line should be 
    
    if 'admin_site' in inspect.getargspec(self.widget.__init__)[0]: # Django 1.4

right?
Merknad: Jeg har ikke inkludert noe av koden fra pakken no.ntnu.fp.net (Connection.java, MessageListener.java, ReceiveWorker.java) da jeg regner med at net-koden vi skal bruke er den som er tilgjengelig i KTN-rommet, som jeg inkluderte i min forrige commit. Dette kom forsåvidt uklart fram i kompendiet.
I actually like the old version of the story budget description more...
If you indent the dash with a space, Markdown renders it as a sub-list-item. The `--` syntax doesn't seem to generate list items at all.
Camera (still & camcorder) Force closes, MX Player can't decode video files that it used to be able to using HW decoder. Probably other parts that need video decoding/encoding. Are you saying it works for your CM7?
It's something in our kernel config, I suspect the RCU file changes,
What if we will not change the rcu file? And add the patch in.




Best regards,
Yuri Shpovlov
CCSE, VASCO-CE, McAfee ePO, JNCIA-IDP+UAC, eSafe-CE
System & Security Engineer | Computing Service Department | Northern Branch
e-mail:  Yuri@bynet.co.il | office: (+972) 4 9049617 | mobile: +(972) 52 5528281


-----Original Message-----
From: Marc Alexander [mailto:reply@reply.github.com] 
Sent: Tuesday, 10 January, 2012 22:54
To: Yuri Shpovlov
Subject: Re: [desire_kernel_35] ADD: SLQB slab memory allocator for 2.6.35 (5c4edb8)

I reverted this for now. No idea why it doesn't work. I compared the diff with faux123's commits and there is no difference.

--- 
Reply to this email directly or view it on GitHub:
https://github.com/marc1706/desire_kernel_35/commit/5c4edb89b2f4395d8f1fc9bfd2d28051623dacbd#commitcomment-854709
Github had some issues today with pushes, see status.github.com..this is me just trying to get a push to show :) This is the actual change: https://github.com/tsurdilo/process-designer/commit/aebf1050cbb03180ea51415f74831adf9b38d043. Sorry for inconvenience..but no I haven't gone all the way crazy yet :)
The old dialplan code still 'works', and by 'works' I mean that you wont get any fatal errors and non functioning code. The behavior of the application is changed outsource and in some cases you might have to update your dialplan. 
If you haven't defined any timeout and used the default values: eg agi((speech-recog.agi) or agi(speech-recog.agi,en) the only change is that now the recording will terminate automatically after 3 seconds of silence instead of waiting till the absolute timeout (used to be 10 secs) is reached. A dialplan update isn't necessary.
If you have defined a timeout in your code: eg agi(speech-recog.agi,en,20) after this commit the recording wont stop after 20 seconds but after 20 seconds of detected silence. In this case you might have to update your dialplan code.
isn't*
That still falls under the original tweet I sent you where you have to build the source, move into the _packages_output folder and cinst chocolatey -source %cd% from there.
Ok. Just make sure that the actual binary stays in the same place relative to the `lib/` directory otherwise the dynamic linking won't work. I.e the tarball contains `bin/phantomjs` and `lib/`, and `bin/phantomjs` has a header that tells it to link to `../lib/`. (This is why I say to symbolically link the binary into the `PATH`, rather than move it.)
not Slicer style compliant, should be :
if (nSeriesUIDs != 1)
  {
  ...
  }
Strong -1 to have a brace scheme different for conditional statements than for classes, methods,...
My personal experience is that not all editors/IDE can configure this and checking/correcting this with grep/sed/awk/...-like tools makes it much more complex.
Do we have to go through and make all the components have transparent backgrounds to implement themes?

Also, we should externalize all the colours for the GUI so we can cleanly update.
I don’t know any Java, but is `Numbr` a typo?
fix trailing comma in utils.js see http://bugs.dojotoolkit.org/ticket/14809
You can't actually say Copyright by Kirsoft because you don't own the Copyright of BigBlueButton.

Just remove the "Copyright (c)" and leave the rest and you're ok.

https://github.com/kirill-scherba/bigbluebutton/blob/master/bigbluebutton-client/locale/en_US/bbbResources.properties#L7
Requires strip_trailing_whitespace, as discussed.
I need to file a JIRA, but I couldn't get the pluginService bean wired into the PluginTab class when unit testing. This meant that using wiring made this impossible to unit test with in-memory GORM
this one is the same in terms or functionality but ensures better readability and a more homogenous syntax.
I should have updated the tests when I made this change cefd7a71cc9bd0931e8bb1d6aad642358fc61458  The reason for the strange format was to remove the potential for ambiguous answers when freeform values are allowed, and JSON seemed like the simplest thing at the time.
Hmm its far too short.. my client was working fine before this.. now it thinks it should be in offline mode.
This debug line needs to be removed.
should be ok now, we're trying to set this syncing script to work on plone's server ...
the align compass change looks ok for HC3.2 on the p4 (wifi/lte/tmo/7500) and p3.  but, it is difficult to find an app that is compatible (smart compass may work ok).

for ICS, p4's look ok (only looked at p4wifi (my device), but the rest should also be ok).  for p3, it goes wonky under ICS.  im unsure why this is the case for p3.

the change is to match the orientation pattern defined up on top.
"Argentinian Spanish" should be "Argentinian Spanish:" (with colon)
I have reverted this commit, since boost_thread-mt is pretty much the standard name for this library.

Our university's servers are just in this particular situation because they run an older version of Debian.

Eventually, we'll want to update the CMake build file, so we can detect the correct library name.
Yes, other versions will be added soon.
Is this fix required for the rails2 version of the gem?
I only did `:additional_load_paths` in the sass filter because we wanted to add to an existing list of paths. Here we can just pass the options straight through: `Less::Parser.new(options)`. That way we support any options the Less parser supports.
Yeah, sure. Although to be honest, I have not had much time to work on this project lately. Feel free to send pull requests!
Tip: To list all examples files, you can now iterate through AppData.examplesDirectory.listFiles().
Yeh I was looking at this and you're right should let application developers choose a.  I will revert to the original.
Nice! As i ve seen sometimes  Socket.unpack_sockaddr_in(get_peername) returns nil when ssl drops (incomplete) and thus creates a bug. We need to first fix this and then use this code.
Why do you set it to readOnly?
We don't have to define "name" and "cardinality", which can be inherited from SimpleList
Yes, it's finally a more global feedback : I should do that wherever "management" is mentioned.
good, changed!
It was too bulky, I resorted to using a very scoped implicit conversion instead
it certainly should, thanks
No need to repeat the name of the documented element.
Yes, exactly, thanks
would be nice with `system.shutdown` in `afterAll`instead, to avoid mem leaks in case of failure
Yup, I had to publish it before I could use it. It also includes the cygwin fixes.
double import of SortedSet
Again, all of these are qualities of the session, not the general card class.
well, look like just another implementation of memoize, useful in cases, but here we only need one value, no need to over engeener.
again i'd drop the limit param here
Let's address it in January. I'm not at all familiar with how that whole thing works to give any sort of intelligent opinion  :)
We use the term "force" everywhere else in the CLI, please change and update the help text to indicate what it means to force the unbind (there's no hint in here for what a "hard unbind" is)
I was under the impression that this whole auth package was going to go away and be replaces by managers. Was I mistaken? or has something changed?
If I remember correctly, `start_with?` was introduced in 1.8.7.
as a general rule, it's not worth adding caching unless we've thought through the clearing scenarios, imo.
if (empty($user_id))
    return array();
why not just content.append(space) and return void?
I could update the documentation with these default values, which, I think, are the style used in the other native map controls. I think it's more a documentation issue.
Again here: this reindentation of the body is undesirable for consistency with the rest of the codebase.
This recursion is doing some fun stuff.

>=<=info -> [debug]
<=>info' -> [debug,info,notice]
lager_util:config_to_levels('<==>=<=>info') even works.
Yeah, since we've come to a somewhat democratic decision to require these directives in a number of discussions (https://github.com/cyclus/cyclus.github.com/commit/1d07401e6ef05d3c18ac9c614738a93d78cf064f and https://github.com/cyclus/core/pull/137#issuecomment-5724702 and https://github.com/cyclus/core/issues/50 ), I'll probably keep being a thorn about it. Sorry! It's in my nature! 

Thanks for complying, tedious as it is.
use options instead of nulls
Nice trick, but it's more syntax friendly to use `[NSMutableArray array]`, because of its brevity as well as verbosity. Also, if I'm not mistaken, without ARC, this would cause two arrays to be created, one mutable, and one not.
@galaxas0 Nope, we're not going to do that.
s/send to a child/sent to a child,/
Sounds good to me. I believe @jrburke has a vested interest in this continuing to function properly, so I’m name-dropping him here :P
I think you'll need to modify ShuffleMapTask's custom serialization code to make sure this is sent along. Have you tested it in a job with a shuffle yet? The problem is that ShuffleMapTask serializes the fields of the parent Task manually and then caches the serialization of some of them.
Hah. Did this file even change, whitespace aside?
Apple should and will fix that.  we don't need to
если даже оператор один, его все равно по стайлгайду надо брать в скобочки. тут и ниже везде
вот это точно сделать формочкой
Agree with Valim here the if is not needed just assign directly
Why are you not using the model to create these records?
I normally clean trailing whitespace. I used to do separate commits but I think for such small portions it should be ok to have them in the diff. Do you think it's a problem?
I don't think we should make a setter method with an instance var for this, it'd be better to define everything in the same `locals_code` loop somehow.
Callisto?
Yeah, I've just went through the code once again; it looks like I only use instances of `Morphism` when I'm lazy to use `NamedMorphism`'s.  And it turns out that whenever I need something beyond creating a morphism, anonymous morphisms do not suffice, which confirms your point.
@flacjacket do you think we should wrap indices here in a sympy `Tuple`?
Ok, I plan to remove this and related tests in this PR. Will address any changes related to this as a separate PR.
Will make the changes in a few days. Busy with university commitments as of
now. Thanks for the help :-)
One block should happen only if you have rational coefficients, while the other should happen if you have rational coefficient or if the coefficients match exactly. The previous statement translates exactly into the python code.
This function is also a bit larger than I am comfortable with...
I think this isn't used.
> I think you might just need to make https://github.com/sympy/sympy/blob/master/sympy/solvers/ode.py#L1462 look for something like `expr.atoms(IntConstant)`.

That is exactly what I do not want to do. The idea is to have a
distinction between "a constant generated by previous call to dsolve"
and "a constant generated during this call to dsolve that is only for
internal use of the single equation solver".

 - The former is `IntConst` and is useful when you want to get the
constants out in order to calculate initial conditions.
 - The latter is "a `Symbol` starting with a C" and it is useful for
doing all the simplification of constants stuff. As it is done only on
single equations it does not interfere with the system of equations
solver (the system of equations solver knows only about `IntConst`).
Maybe I should just change it to "an `_TempIntConst` starting with a
C" where `_TempIntConst` subclasses `Symbol` and not `IntConst`,
because all the logic of the simplification routes is build around
"starts with a C". I will do this today.
Interesting. I don't think that's clearer here, though (do you feel otherwise? - maybe it's just because I learnt about this operator just now).

[Sadly (for the next pull request), `itemgetter(1,2,3) == itemgetter(1,2,3)` returns False.]
I totally agree big chunk of duplicated code or code that are repeated many times should should be refactored with methods. 
However, for simple code like the example above, writing them as methods just makes the code less easy to read (readers have to jump back and forth to understand the code) and less efficient.
This file can be reverted.
Because I need to store this data in a singleton-like manner. Class vars is good enough. And the most hated one line just to be sure this var exists and is None. 

Gregory Sitnin
+7 925 700-12-23
greg@sitnin.com
http://sitnin.com

09.10.2012, â 1:34, Grigory Bakunov <notifications@github.com> íàïèñàë(à):

> In ydisk.py:
> 
> >  
> >  def getKey(YD_APP_ID, YD_APP_SECRET, keyfile):
> >      if os.path.isfile(keyfile):
> >          return open(keyfile, 'r').read()
> >      import webbrowser
> >      webbrowser.open('https://oauth.yandex.ru/authorize?response_type=code&client_id=' + YD_APP_ID)
> > -    code = raw_input('Input your code: ').strip()
> > +
> I just hate next part of code. Why do you need this climbing and jumping with _code?
> 
> —
> Reply to this email directly or view it on GitHub.
>
My experience on windows is similar to the rubyinstaller one you mentioned.
Hmm, can't we make this uv_stream_t directly?
Can be rewritten as

```ruby
         elsif @values.key?(platform) && (match_found = @values[platform].find { |k,v| version =~ Regexp.new(k) })
            match_found[1]
```
Anyway, this has been fixed, I believe.
Any special reason why you use av_* here instead of avatar? (size doesnt matter)
http://tracker.phpbb.com/browse/PHPBB3-11227
Nope, David said to use default below, I said to default to 'list'. Same end result, but slightly different methods.
The file driver is a data cache. If you want to turn it into a sql cache, you have to wrap it.
`$this->cache = $cache = new phpbb_cache_service($driver, new phpbb_cache_driver_sql_generic($driver));`
What about generating a new unique value?
Why do you purge the cache here manually? The extension manager should be taking care of that. If it's not, you should report and/or fix the bug in extension manager, not add extra cache handling code here.
The script uses lowercase for variable names. Both FILE and FILES should be lowercased.
See https://github.com/phpbb/phpbb3/blob/develop-olympus/phpBB/install/database_update.php#L2053 for how to do this logic with less memory.
In general I'd prefer if the explanation of the search query syntax just depended on the search backend, rather than making some separate statement about somehting not working after previously explaining how it works.
just add an element to the error array() ?
I copy/pasted the doc blocks from the Symfony interface and didn't notice that he uses spaces instead of tabs. Also he does the doc block correctly by lining up the asterisks with an extra space. Anyway, fixed.
nah. We can assume the right hand (template) knows what the left hand (controller) is doing. We'll keep these pieces paired 1:1---generalization or template reuse doesn't seem necessary here.
leave a space before definition
:construction: controversial
ちょっとあれ。
It shows the last 5 years. Couldn't this be configurable?
Awesome name :trollface:
`find_host_package` is defined as
```
macro(find_host_package)
  find_package(${ARGN})
endmacro()
```
Could you explain how your fix can change something?
Could you elaborate why this is needed? That is, why is a static constructor needed. No idea why so I am curious :)
Missing `// Given`
should it be `RequiresSSL` instead? this would match with #702 for `RequiresHttps`.
style: please run jsbeautifier.org to ensure tabbing/spacing is consistent
@johnstoecker UUID is openMRS internals -- not the Patient's ID. Right?
I can't imagine any scenario in which we will be giving CHWs the entire code (OPD, etc), split it sounds correct.

S
On 20-Jun-2012, at 10:25 AM, John Stoecker wrote:

>> +        }
>> +
>> +    },
>> +
>> +    // when downloading information
>> +    doDownload: function (arg) {
>> +
>> +        // shows actionsheet with download options
>> +        if (!this.actions) {
>> +            this.actions = Ext.Viewport.add({
>> +                xtype: 'actionsheet',
>> +                items: [{
>> +                    text: 'Download studies',
>> +                    scope: this,
>> +                    handler: function () {
>> +                        Ext.Msg.confirm('Confirm', 'Are you sure you want to download all studies?');
> 
> @nathanleiby When we deploy this module, will we split it up with the rest of the code, or give CHW's the entire code, OPD, etc on their phone?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Raxa/Raxa-JSS/pull/81/files#r1015477
Hmmm.... 

```
The underlying map drawing package has now been updated to use 
`Cartopy <http://scitools.github.com/cartopy>`_. This change will see improved
handling of data in its native coordinate system, simplifies the user
interface and, most importantly, should "just work". 
```

I'm struggling with anything more creative at the moment. Any ideas?
There are quite a few long lines in this method.
Surprised you end up with a template in ```self._dim_templates``` that can't be used to make a DimCoord. I'd suggest this should be caught earlier and be put into ```self._aux_templates```.
Лучше переименовать в `getBundleSourceTechs()` для консистентности с остальными подобными геттерами.
oh, sure. thanks.
I believe the code is safe:

update_modifier_linkable_list() is called from push_message(), which is called
from read_data_thread().

update_modifier_combo_box() is called from create_modifier_group(), which is 
called from push_message(), which is only called out of read_data_thread().

So the data and the code that services it is local to the read_thread.
If there's GEOS 3.1 (as on Ubuntu 10.04), however you'll need to raise a `NotImplementedError`.
a better solution could even be to use a single ``switch (true)`` btw.
It looks like this would require a bit of rework (from the look of things, you'd have to change the way you parse the frag. functions from the elements). Let me experiment with something and I will suggest an alternative approach.
Can you rewrite it in a following form:

```javascript
if (cond) {
  stmt;
} else {
  stmt;
}
```

I've no concerns about this style, but I'm just don't using things like that in this library.
In this case I expect an increase of "minsize" too.
Plus Ihno actually asked me if we could reduce logging because it slows down YaST execution a lot (on some "real hardware"). That's why I do it.
Do we need this check?
getAs<int>() is a very bad idea and not portable.
This did not show to work well on Windows, so I have made it skip this branch.
It may be better to format in the URL:

```jinja
{% trans url="http://support.mozilla.org" %}
  Note: for support requests, please go to <a href="{{ url }}">Mozilla Support</a>.
{% endtrans %}
```

It means the URL can't be localized, so it's not *always* what we want, but I'd guess it's easier in this case.
Is `selected` too generic a name for this? I guess we can worry about that if/when we add additional filters.
Full path to the executable in tests: `system "#{bin}/web100clt -v"`
The lines with the comment "# definitely needed" is there because I am sure that it was necessary for the one or the other formula. Though I have not noted down which one. Damn me.
Oh, and sorry for the type. I definitely have to learn how to spell definitely ^^
Also...I don't think we want to be building PPC versions, if I read the patch right.
I'm saving the ivar of the last project directory so that you can trigger the actions even if you're currently looking at another non-project window i.e. the Organiser or Documentation window.. hence the need for an ivar.. though you're right it should really be private..  selectFile: inFileViewerRootedAtPath: is also a good suggestion.. must have missed it.
Capitalize these
It's mostly here because I don't want to force simple handlers (e.g. from the logging resource) to return a deferred but I want it to be clear that handlers can return deferreds if they want to (e.g. the redis resource handlers).
This isn't new to this PR, but: The inbound message can only be sent to the sandbox once its up and running (e.g. received the Javascript it's supposed to run). The method called differs depending on whether an event or message is being sent so this just abstracts that difference into a callback. I could select a method based on the message type in `_process_in_sandbox` but that would get messier, I think.
+1 on moving this lower down to make the ack a bit more reliable.
I'd like to see the test become more generic -- i.e test for some feature we believe is different about the PCM replies that might potentially be an issue, rather than test for some specific somewhat hackish feature needed by a particular vumi use case. The test needs to be understandable to outside contributors and to us in a years time.

Currently I'm actually not sure what the test actually shows. Mostly that we can correctly pass some brackets and quotes as message content? I think we knew that already?
this is old: firefox and chrome implementations do not use ``callee`` and IE doesn't implement strict es5, so ``"use strict"`` should be brought back
this one looks very similar to `scrapy.utils.get_func_args` - could that one be reused?
Yeah - but this isn't getting without parameters, which getFoo does imply by common practice.  This is a transformation, or as we said, an extraction.
This is a good point. Is there ever a case where it is useful to specify the group or should it always be determined by an explorer?
Might want to download and version control our own copy of this rather than hotlinking to someone else's site.
good thought
Should we maybe just rename this to cordova.js like we did with phonegap.js? Then we get diffs of subsequent upgrades & we don't have to change the index.html.haml or application_spec on every upgrade.
Typo ``errores`` to ``erros``?
will fix...
Typo - 'repeatidly' (couple more in the file too)
This comment is no longer correct
In which PR are you removing these initExtensions?
What do these variables do? Anything?
rationale : windows.
yes I will tweak documents.
The whole this entry, no?
should be `handle` instead of `forEach`
So there are two fields, which it sounds like we should either distinguish by page or by locator/property. login_password makes sense, so I'd suggest register_password for creating a new account.
We should specify useCapture here shouldn't we?
If you look up on line 129 we have access to the project itself that is being used here.  This means you could check against the url for the media that's being stored in the object and also use the target that's there for the media rather than hard coding in the target below.
How are these unstable? They seem to work fine in the default-editor
is that comma supposed to be a semicolon?
Dammit man, you had to throw in one seattle.rbism, didn't you?

<3 Looks great otherwise.
Dependant is a variant of Dependent - use Dependent spelling instead
I just extracted the method so it is testable. I could check for null, without any problem.
假设new不是list->last, 那么当list->nalloc被改变时，list->last->nelts大于new->nelts，list_push的时候就永远不会停止，会溢出的。。。
Method Javadoc and a return type would be cool.
Thanks! Will change it. Is there any doc for the specs that is up to date?
I'm not certain why we don't copy all `.$(SHLIB_EXT)` files into the installation directory (Of course this is "cleaner" installation-wise, as we for-certain know exactly what's being installed, but I'm not sure what we're trying to exclude).

@ViralBShah, can you shed light on this?
Makes no such assumption; `timing.jl` is in `.` and `bigint.jl` will be on the search path regardless. You can drop this comment.
@xsuchy this is being merged into the pulpv2 branch, builds are not needed in koji quite yet.
In 0fa3c40 I've forced conversion to floats to drop any straggler decimal places.
There are nuget packages for these ones, so I've installed those instead
The thunk is unnecessary. The IPrincipal is sufficient.
I see you turned the old code in to a giant undebuggable LINQ query. I love LINQ but this is too much. Untangle it please.
I didn't realize this was here - I think we decided for now to *not* accept datetime objects (although that might be revised), so I've fixed it appropriately.
Should probably say "in decimal degrees" to make it clear that it's not radians etc.
Whoops, sorry - meant to do this in #253
Regardiing the default/current cosmology machinery - this is needed regardless of whether any convenience functions exist to allow the use case @eteq described above:

```
set_current('WMAP7')
result_wmap7 = my_science_code()
set_current('WMAP5')
result_wmap5 = my_science_code()
print result_wmap7 - result_wmap5
```

Here `my_science_code()` can be written using `cosmology.get_current()`, and that way you don't have to worry about passing around cosmology instances.
Ah, I see - I think that makes sense still, because I think it's worth including users to use it when they can - after all, in astronomy "user" code often becomes "dev" code.
Oh, and this is a minor point, but they should probably be all-caps, as they are constants.
Here and everywhere below where you reference an input argument, you should use backticks (`` ` ``) iinstead of asterisks (``*``)
Get rid of all this, not the type of thing that should be in a helper module.
Understood :), thanks for your valuable input master!
Missing braces `{ }`.  Please take the trouble of carefully reading the coding standards page on the manual and setting up the [code sniffer](https://github.com/cakephp/cakephp-codesniffer) and fix all the formatting errors. We appreciate your contribution but your patch won't be merged in if it doesn't confer to cake's coding standards. Its really not practical for us to go about pointing out each mistake.

Once you are done please also squash your commits to avoid unnecessary noise in the repo history.
Are these void listeners necessary? If so a comment explaining why would be useful.
If I'm not mistaken there's a substantive change hidden in the record refactoring here.  We're now preserving the `#acc.state =:= updated` condition across timeout messages so that when a `get_state` message eventually comes in we'll reply `updated` instead of `timeout`.  That sounds like a good bugfix to me, I just want to make sure that was the intent.
@guilhermeblanco IDE happiness :) Otherwise I can mark the parameter passed to `generateProxyClasses` as `ClassMetadata[]`
Not all the msp430's have 3 CCR's. Check for `__MSP430_HAS_TA3__` to prevent compiler error for those devices.
Thanks for this. We should possibly look into lint presubmit checks.
Is there any other way to return the HTML?  I know @minrk suggested putting it in the notebook directory and providing a link.
correct superclass to not bork on additional set elements, but retain the hack relating to ebs here
Thanks @libo

First, an update to the regex: `":(?:\$|@|@@|[_A-Za-z])?\w*[=!?]?\s*=>\s*"`

Second, an explanation:

 * Generally, a symbol contains word characters: `[_A-Za-z0-9]` aka. `\w`.
 * A symbol may start with `$`, `@` or `@@`, but it may not start with a digit, so: `(?:\$|@|@@|[_A-Za-z])?` – we can skip the `?:` if you like.
 * A symbol may end with `=`, `!` or `?`, so: `[=!?]?`. Escaping the `?` inside the brackets is optional, so I've left it out.
Use the generating class name as the file name
Changed it to `head_info`. :smirk:? :relaxed:? :bowtie:?
It is a somewhat minor optimization, but you may want to always set the diff flag `GIT_DIFF_SKIP_BINARY_CHECK`. Stash doesn't care and it will prevent diff from reading file contents to decide if the file is binary or not.
`i` should be unsigned (-Wsign-compare)
A weak pointer should be enough here, I think.
In case, value was given as NULL, this if leaves `esc_value` uninitialized, though it is used in `config_write` and `git__free` below
moduleNames.join("<br/>");
This should take a file parameter for the CSV location to make it easier to test.
Could you keep this comment next to the `<html>` element? You can turn them into Jinja comments by using `{# #}` instead of `<!-- -->`
Extra newline, else should be on the same line.
Since you're doing it for every test anyway:

```python
def setUp(self):
    self.client = Client()
```
We store the hash so I think it is a fixed length?
yeah you have a good point. It was affecting me during dev/testing because I was changing it a lot. But should affect real life usage.
Why the index == 2 test? That's the second item, right?
Still awaiting feedback on this.
To be safe, should that perhaps be:
```python
listOfAddonsForInput = [x.split(":") for x in addon_string.strip().split(',')]
```
in case there are some trailing newline or something silly.
same here I think. Not a big deal. My experience is that assertEqual gives better error messages and that assertMatch is good when you want to validate against a match pattern like `{foo, _}`.
Include the license name here when you choose one.
can you get rid of the .* import?
make this a static constant? I recall Patterns being expensive to compile
немає. там все лаконічно було б якби не накладання цього qr на картинку, для чого його потрібно перевести обратно в ресурс (в бібліотеці він переводится з ресурса в картинку), а видрати його з бібліотеки ресурсом немає можливості.
Good catch. They should all be protected since the class is designed to be extended. I'll update it.
almost perfect !
Ok, done! I tried to push the change from work, but could not manage to
have git sending anything behind http proxy :(



On 15 November 2012 16:51, Christophe Coevoet <notifications@github.com>wrote:

> In src/Symfony/Component/Filesystem/Filesystem.php:
>
> >       *
> >       * @throws IOException When file type is unknown
> >       */
> >      public function mirror($originDir, $targetDir, \Traversable $iterator = null, $options = array())
> >      {
> > +        $targetDir = rtrim($targetDir, '/\\');
> > +        $originDir = rtrim($originDir, '/\\');
> > +
> > +        // Iterate in destination folder to remove obsolete entries
> > +        if ($this->exists($targetDir)) {
> > +            if (isset($options['delete']) and $options['delete']) {
> > +                $l_iterator = $iterator;
>
> Well, the variable name should follow the coding standards used in the
> project, and should be understandable by people who went to a different
> school than you [image: :smile:]
> So yeah, please rename it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony/symfony/pull/6014/files#r2140156>.
>
>
I changed it back, but then stumbled into another issue while trying to find a new way to check if values were bound or not: #3770
changing the visibility is a BC break for people extending the validator
should be `Boolean` instead of `bool`
I've added that before but I've got the same thing:
```
var leftIconPath = "\x2Fpersonal\x2FSymfony\x2Fweb\x2Fbundles\x2Fwebprofiler\x2Fimages\x2Fprofiler\x2Fleft\x2Darrow.png",
                rightIconPath = "\x2Fpersonal\x2FSymfony\x2Fweb\x2Fbundles\x2Fwebprofiler\x2Fimages\x2Fprofiler\x2Fright\x2Darrow.png",
```
Using ``` |e('WHATEVER') ``` is doing the same thing with either autoescape on JS or not and so on. I'm using Symfony 2.1.1 to test this.
Can you either do a pull on the repo or type all code I need to do as I really don't have a clue how this works.
Being the same as another commit is not an excuse if the other commit was not reviewed :)

It is not useless, it actually tests the change. The semantics changed from "write everything" to "write everything that changed since the last Write" and without reordering, the specific tests would write nothing. I'll add a comment.
This structure contains all of the parameters that were global variables in maketx, using the same names (with one exception) so that the structure can be used to store the options as parsed by ArgParse.
Thanks. I'll update that now.
Don't really want a dependency on pyplot. Is it needed here?
This is still going to result in double-wrapping the socket with a TFramedTransport; you'll end up with ``TFramedTransport(TSaslClientTransport(TFramedTransport(socket)))``.  This is the step that needs to be delayed until after the ``openKerberosTransport()`` call, which itself needs to return the TSaslClientTransport directly without first wrapping it in a TFramedTransport.
what should we say when it's the act of resolving that's important, not the content?
Okay, it seem to work, but its FileUtils, not StringUtils of course :D
The default of admin_preview was changed to False in #1474
Is obvious but is not obvious :full_moon_with_face: . It can be seconds, apples or Stilles Wasser bottles (although it is usually float seconds for this kind of metrics).

However, I simply wanted to highlight that fact
Should extend \Faker\Provider\Address
This should be a test scope dependency.
Mixed up meaning "XYZLogger" is typically used for log messages while "XYZMessages" is typically used for exceptions and other non-log messages strings.
Perhaps this is something for [`File.join`](http://www.ruby-doc.org/core-1.9.3/File.html#method-c-join)?
метод тыка! документация spring не потревожена. :-[
это отладочный бред. который просочился. Исправлено
Yes, you are right, checking that as well.
@jcarpenter OK, this sounds fair.  Please remember that browser is string frozen and any changes to this string will need to go through a bugzilla bug ad communicated to the localizers.  Thanks!