labofsahil/github-event-dataset-2012 huggingface dataset:
I started to do this, and then wondered whether millisecond resolution is unique enough.  Maybe a testcase will someday launch two apps in rapid succession and they'll both get the same value of Date.now(), which will break the task switcher...  So I've left this as it is.
What I mean is that the output is kind of wrong, because the angle is 57 degrees, not 57 hours. I'm wondering whether requesting ``hms`` should automatically convert to hours (like how requesting ``dms`` converts to degrees)
这个if else又没有{}了~~

另外，这个方法前面不放个sample的调用，以及方法传入和传入，实在是看不懂。。。
There should have been a space after `if`.
I like that this exposes something we've been doing in ControllerTestCase.
Notes shouldn't be on the first line of a docstring
Another quick question about the phpdoc convention: I always thought that there should be two docblocks, one for the file, and a second one for the class, and that the first one should have licensing information, copyright, and so on, while the class-level docblock should contain a description of what the class does. So in this case, it should be something like:

    /**
     * @author David Buchmann <david@liip.ch>
     * @license Dual licensed under the MIT (MIT-LICENSE.txt) and LGPL (LGPL-LICENSE.txt) licenses.
     */

    //namespace and so on

    /**
     * Twig Extension to integrate createphp into Twig
     */

AFAIR, phpdoc wil throw warnings if the file-level docblock is missing, or are you using some other parser? Also, what about the package tag? Shouldn't that be in there, too?
Ok, is het omdat rel="prev" en next aanwezig zijn?


On 10-jul.-2012, at 22:35, Tijs Verkoyen wrote:

>> 	{option:widgetPagesNavigation.previous}
>> 		<li class="previousLink">
>> -			<a href="{$widgetPagesNavigation.previous.url}" rel="prev">{$lblPreviousPage|ucfirst}: {$widgetPagesNavigation.previous.title}</a>
> 
> Eigenlijk heeft title-attribute hier geen meerwaarde. Onlangs te weten gekomen van Anysurfer.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/forkcms/forkcms/pull/273/files#r1135253
No. This is not good. You're just catching any exception and immediately returning. Your comment also does not enlighten as to why.

-1
Have created a trait  for now, will see how it goes.
Should these lines be like `shell.handle_image_PIL = raise_if_called`?
(Though I think `errors='replace'` is redundant - latin1 should be able to decode any bytes.
My preferred shade of bikeshed is that it's logically consistent with the command line option (`--all`). But as a parameter to `run_iptestall`, `all` doesn't seem very descriptive, so it became `inc_slow`.
Maybe add an assertion for this?  It can be optimized out by wrapping the validation method's invocation in an assert statement.
Remove this file now, since you don't need a view with the `page` shortcut
that is... AWESOME
Oops, yep. Pushed a fix.
It shouldn't be necessary to define `onKilled` if it isn't defined.  Just check that `typeof onKilled == "function"` before calling it.

Finally, nit: the emerging code convention in Firefox seems to be to put braces around all if/else clauses, even those comprising a single statement on a single line; so we've been doing that in r2d2b2g code too (even though I personally prefer to omit braces around single-statement/line clauses).
Docblock to be fixed or removed
You're assuming the post is live here, better to check for that.
Missing var statements for `myAuthDB` and `users` (users had one, but now its been lost to the `getUsers` function scope).
using ``$value[0]`` is wrong. You need to loop over all ``serializer.normalizer`` tags, not handle only the first one
I don't think so. That subnamespace contains only the relevant files for the Symfony2 mapping now. None of the core interfaces references anything within that namespace.
I want to make a copy of the incoming parameter, so I don't mess with the incoming param state during the deletion. 
It's a very good question of you actually...  

I want to iterate through the $targetDir and remove elements that are not in the $originDir.
Therefore, I have to use the CHILD_FIRST behavior (so that the branch is not deleted before the leaf)
I was wondering if the user would pass an $iterator as param, how do I make sure that he or she is going to provide an iterator with CHILD_FIRST?

In the unitary tests of the function, there is no test involving an $iterator as parameter so I don't know if my code is breaking anything...

By the way, do you have any comment on the unitary tests I have added?
you should allow any callable, not only closures
what about moving `$line` up inside the `if` ?
On Mon, Nov 12, 2012 at 3:58 AM, Elis <notifications@github.com> wrote:

> In examples/talkatv-test/index.html:
>
> > @@ -23,10 +23,11 @@
> >                          var talkatv_ordered = true;
> >
> >                          /* Include talkatv.js */
> > -                        document.write(unescape('%3Cscript src="'
> > -                        + talkatv_home + (window.talkatv_shortcut
> > -                        ? '/talkatv.js' : '/static/js/talkatv.js')
> > -                        + '" type="text/javascript"%3E%3C/script%3E'));
> > +                        script = document.createElement('script');
> > +                        script.src = talkatv_home + '/talkatv.js';
> > +                        script.type = 'text/javascript';
>
> This is true, but it's not unnecessary on HTML4 and XHTML1.0 and XHTML1.1,
> and last time I checked, HTML5 isn't done yet. The spec isn't complete. But
> many people use it anyways.
>

HTML5 is never going to be officially "done"; the process is different
now.  This particular aspect of HTML5 is stable and safe to use.

In any case, no browser insists on the presence of @type in this situation,
so it's unnecessary whether or not you think you are generating "HTML5".

zw
The variable is initialized to the charset number sent by the client.

See [Connection Character Sets and Collations](http://dev.mysql.com/doc/refman/5.5/en/charset-connection.html) and [Character Set for Error Messages](http://dev.mysql.com/doc/refman/5.5/en/charset-errors.html) for more details.
As suggested above, better to enforce UTF-8 both ways.
Maybe add blank line before and after block of variables for better readability.
基础方法，用来检测碰撞或覆盖。draggable中引用到。
Тут надо сделать их приватными
Well, looks like I can't agree with you on that one Larry.  To me, rule 2 here is just begging to be generalised to n channels (ie, always use implied alpha = 1 when alpha isn't present).
You might write

float c = a[channel];

To (1) make the code simpler and (2) avoid converting it so many times (A might hold something other than float pixels in the future).
It's the epsg code we want the map to be in, and in which the bbox corods are defined.
Hmm. Is that the best we have to access the central longitude of a rotated geodetic? Perhaps we should look into making that better...
C'est utilisé ou ?
Hum maybe, do you know how to appendChild when in state "inDOM" ?
Hmm, the point is that I'm using it internally (see `catchPhrase` method) to check whether a catch phrase *sounds good or not*.
Should I still put its content into the test class? or in a separate class?
Change to:
```
if ($album->id == item::root()->id)
```

for portability
I think here we need a type case to the record from the method parameter. A new ActionRecord does not make sense here.
Wondering why we have no test for this.
That's ok. I just wonder about something else. I wanted to make some pull requests but then I saw this horrible statistics of 300+ issues and 45 pull requests. There are simple bugs with Chosen, but nothing happens. That's why it seemed to me like space traveling to read your post about GitHub usability. :)
Seems fine then. I don't suppose we can have a test here? I'll go ahead and merge it in, but if anyone feels testy please ;)
Go for it - node-get is a dinosaur. Doing a quick test, though, it doesn't look like request has actually improved - this should be tested with large downloads (large as in file > resident memory). Even with pipe, request uses approx. as much memory as the file itself.
Prefer either

 } else {

or

 } else if (position >= 400) {
...
 } else {
   throw "not reached";
 }

Can be addressed in a followup.
we need to render again the threadlist to update the headers if there was a deletion (in case it was the last message from a certain day)
Also, we decided that all plural cases should be present, even if there's some redundancy.  I know that the `[zero]` case is never used due to ` if (selected.length === 0) return;` in gallery.js, but just for consistency and in case a third-party tool that we don't have control over assumes it's there, can you add it?

    # the [zero] case is never used
    delete-n-photos2?[zero] = Delete {{ n }} items?

I wish this worked in a saner way :(  Hopefully in v2 it will.
The change should be only here right? Why dont use a 'for', or put `<p>` inside the label?
Ups, sorry, I misunderstood you... ;-999 Yeah, we use the .log-group class for the "day" grouping of calls (TODAY, YESTERDAY, etc...) -> https://github.com/gtorodelvalle/gaia/blob/master/apps/communications/dialer/js/recents.js#L690
`this.onreturn = null;` and check the value everything we call the `onreturn` callback function (instead of inserting an empty function here)
`this.geolocationEnabled` is boolean, you don't need to compare it with a string `'true'`
This `overflow: auto;` should be placed in `#search-view #groups-list-search` to avoid having the scrollbar missplaced
Why can't you simply leave this code inisde the closure instead of exposing init to the outside world?
Should this be `{3}` instead?
like, in the constructor? can't we add it when we actually need to trace something?
We have those exact 3 lines in 4 places now. Could use a little GetSettingsManager(siteName) helper.
Keeping the original author will be confusing, since you can create empty file as a stub, and someone else can do the implementation.

We should credit either no one or all contributors to the file.
I don't like options[:duration].

`Adrian:: DirectoryQueue.new(:path => 'foo', :duration => 30.minutes)` sounds wrong. How about `:lock_duration` or `:expire_lock_after` or something like that.

I agree that in the`Filters::FileLock` context, `duration` is the right name, but not in the ``Adrian:: DirectoryQueue` context.
Great suggestion Chris, thanks. I've pushed a change that brings in cassandra's version and provides a scala wrapper. It's totally untested though (beyond making sure it compiles), so I don't suggest you guys merge yet, just take a look at the code.
Yes, I don't know where it goes.
Apparently this confusion is due to the similarity between the _utf8_on flag (evil) and the is_utf8 function (not so evil).

This line is not trying to determine if the source is utf8 encoded. The is_utf8() flag tells us if the string we are looking at has already been decoded from a byte string into Perl's internal character string format. That would be bad because Pod::Simple expects bytes and if it tries to decode a character string it will crash.

This "if" block can be omitted if we're running Pod::Simple 3.23 (came out a couple of weeks ago) because the exact same check is now done in Pod::Simple.
``_garmentbox_inventory_subcell_class()``
The idea of the libraries is not to have anything coming from user in it. We need to improve our API so that we can initialize BBCode class separately and change its parameters in there.
Oops, should probably be ```let``` not ```let*```
The default URL address must be `https://aero.io/api/v1`. Override it in the tests with whatever you need to.

Please note that it's HTTPS and not HTTP. That means that your engine might now work properly. Please test that.
This section seems to be duplicating information in the "Configuration" section above.
There's a yield further up in the call.
This is not enough on windows.

Btw, this class should probably extend the one from Filesystem component (which supports removing symlinks properly for instance)
I'd differentiate the path for ping events from the one for CheckEvent events. And if no path is specified, that would mean that this hook is disable (allowing only CheckEvent hooks for instance).
Should hide the img:
position: absolute; height: 1px; width: 1px; top: -9999px; left: -9999px; 
Don't know if browsers load the src if it's display none?
good catch... Fixed
How do I find out there is a folder with this name? And how do I distinguish?
I really like all the changes you made. Good job. The only thing I would change is "HTTP redirects" in this line, which isn't quite true. RackTest does support redirects, just not to URLs outside the application.
Throwing a dictionary seems questionable. Is there a builtin exception like InvalidArgumentException that could be used here?
>
> Promises/A spec doesn't seem to define this feature. Being able to return either a value or a promise complexity the
> documentation and the implementation. Without this feature it looks like we have to be synchronous in success and failure
> callbacks. So that it sounds like going against asynchronous and promises.
>

No in fact while it does not specifies that explicitly but it's implicit consequence of the rest of the spec. The fact that promise may be resolved via promise guarantees that. Also all major implementation do implement this feature. It's critical to composeability of promises, unfortunately http://wiki.commonjs.org/wiki/Promises/A is down so I can't highlight exact quotes from it.

I'll try to come up with a better example here.
Do we use statsd in production? Might be a good place to put a counter.
Yes, it's required.

AFAICT any `args` property on a `/wsapi/*.js` module is required.

One of the _few_ improvements of this patch is to remove the duplicate declaration of cert_key arguments.
Heh, there's a bit of story on this one.  They should be removed but as written the locking that ProjectBatchCommand provides will cause a bit of a problem.  You can only set one LOCK_FILE string, this will cause the "run_metrics" option to block the "summary" option in the run time environment that crontab.txt gets installed in, so it's likely the "summary" command would never get run.  I initially tried to inherit from ProjectCommand and then implement the locking locally to account for this, that's why there are some unused imports, inheriting from ProjectCommand caused a variety of other issues... which is another story.  

I think a good fix would be to modify ProjectBatchCommand to allow a finer level of granularity in how it identifies the LOCK_FILE string so that individual command options could have a different lock string associated with them.
I added docs for this in the ProjectBatchCommand object, here in model/base.py and in model/sql/models.py now.  Is there anywhere else these docs would make sense?
Why do we need to normalize in this way?  Can a fact not resolve to an empty string?
I feel like this should be able to be set in the config file, and maybe named something like ``kernel_timeout`` even if it is only used at the moment for interacts.
if you really want to be complete, verify that it is logged when ignored as logging is probably important
hesitated ... to force use addConfigGlobPaths or addConfigStaticPaths
`è lineare`
Ok, this is my second PR, so I don't know if I can change this line?
Okay. Method names are case insensitive, but this change makes sense for readability.
Not sure if THEY will be okay with the default
comment stay "relative"... var name say "absolute". IMHO that comment it not needed, var name is descriptive enough
you should remove the var_dump from the tests and use assertions instead
Should probably make this 10.
You have an extra space after `'pathKey'`. Otherwise the patch looks good.
Yeah, I was in doubt whether it was an integration test or not. Never the less, it should proof the bug...
See comment on pull request. ;)
Space between each rule. Space after `:`, not in front.
Thanks for the documentation.
Please remove comments.
Searched code and renamed method
http://stackoverflow.com/questions/6011368/rails-3-actionmailer-escape-false-doesnt-work-nor-does-raw
this stuff should be removed. It is not used anymore since Doctrine switched to git
this sounds wrong: i could want a child document to have a different nodeType, e.g with additional fields. (actually if i use node types it is even very likely to want that)
You should be using the same DB everywhere. Custom SQL can often be DB implementation specific, so what you are testing and developing against should be the same type of DB you use in production.
Yes, `|` does not have a default implementation, but you will be able to manipulate it in the syntax tree with no problem.
I understand, but then I'' need to change SRC_URI, just ${P}.tar.bz2 wouldn't work. I can change package name if you think this is necessary.
okay, I thnk this should come with the next pelican release then.
My editor did this, wasn't intended
the JaxWS... should be in backticks
Another option could be creating Object.create and check for Object.defineProperty before attempting to call Object.defineProperties but this could led to more unexpected results if some library are using the presence of Object.create to take some decisions instead of checking for Object.defineProperty.
Okay, I looked at the 25 available INTERRUPT_FLAG and none of them seem to be for loot. I understand what you suggest but everywhere else, stealth is removed this way: RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH);
If you know which INTERRUPT_FLAG to use, I'll try it.
That label tag above? It's missing its `for` attribute.
One more test for successfully viewing an other profile when vouched.
remove whitespace after {}
Saves us ~0.5 secs ! Woooooooo
@ohadlevy ah I see what you mean. We can find out the formatting based on the report_format value in the yml, but I'm not sure that it directly correlates. @GregSutcliffe - do you remember?
This would mean not clearing the workspace before each build, and adding some logic to determine if the repository is already present. This would probably be fine while we're platform specific, but if we have to use XShell then I'm not sure the logic work work across platforms.
Given that we will receive a ton of notifications per day I kinda would like to see a good filtering mechanism in place. As talked on IRC we currently have the 'completed with x failures' in the body. How does it look like if no failures exist? Do we have '0 failures'? That would make it impossible to filter out. In such a case it would be nice to directly see a '[FAILURE]' prefix or so in the subject.
I don't believe this is used. Can we remove it?
See [my comment](https://github.com/Jessecar96/SteamBot/pull/38#issuecomment-9843487) in #38.
As you extend this more, you might want to consider refactoring this stuff into an `options` object that gets passed in and use `$.extend()` to set defaults (see the first bit of movablePoint for an example of what i'm talking about) so it's easier for an exercise to override. Doing that also keeps the number of parameters from getting out of hand. Compare:

    graph.angles = new Angles(0, 10, 0, 3, ANGLE);

to:

    graph.angles = new Angles({
        angle: ANGLE
    });

where `x1`, `x2`, `y1`, and `diff` have default values, but can be overridden.
Now that I look at the code, `ConfigurationParser::parse_configuration` is redundant. Maybe it's better to call it `Configuration::parse`?

Not a major deal, just a thought.
outside of a bottom margin on entry-utility they were styled identically.  to target the former entry-utility you could use footer.entry-meta.  probably could go either way, but i thought it was redundant... to have 2 separate classes.
For consistency with the rest of the code, would you mind calling this method currentAverage() ? (remove the get prefix)

Thanks.
O que foi alterado aqui? Se o resultado final é espaços em vez de tabs, ótimo.
break tag, and what was released?
I may be wrong, but shouldn't `$this.css('max-height', '');` be `$this.css('maxHeight', '');`?
I find this recursive approach hard to follow, and it's not clear to me that it's operating correctly.  It seems to call _is_issuer_valid with the same hostname and issuer over and over again.  Should it be updating hostname based on the delegated authority?

I think a loop would be clearer, along the lines of::

    while max_hops > 0:
        support = self[hostname]
        authority = support.get("authority")
        if authority is None:
            return False
        if authority == issuer:
            return True
        hostname = authority
        max_hops -= 1
since what?
I think it's worth adding. Rails has this same API pattern so it makes sense for us to when we're using the same concept.
Typo on `Expering`
Agree, maybe makes more sense to have something like an "oae-admin" module that handles the internal admin account, as per my discussion note on the PR. I don't see a better place for it though right now, I'm open for suggestions.
@simong : You can probably move your groups mapping function out of the model as well.
Actually, what did you think about moving ``lastCrash`` in ``EclipseLogger.scala``. It looks like it could be useful in general. Pro or against?
I think a ``IResourceChangeListener`` is what you want http://www.eclipse.org/articles/Article-Resource-deltas/resource-deltas.html
Named argument for the boolean values would improve readibility.
There's a missing ```LIMIT``` here.
Применяя сравнение == != < > <= >= к объектам (подчёркиваю - к объектам) вы должны понимать один важный момент - таким образом сравниваются ссылки. То есть, в данном случае, если ссылка на [self genomeAtIndex:i] не равна [another genomeAtIndex:i], то и сработает. Просто помните об этом, это важно.
В заголовочном файле Cell.h мето hammingDistance объявлен как - (int) hammingDistance: (Cell*) dna; а имплементирован как - (int) hammingDistance:(Cell *)insertCell, как же в итоге входящая переменная зовется?)
Unless the RGhost doc is way out of date, there has to be a reason why they suggest to do error checking that way. I could see that it may report errors if the conversion failed due to other reasons such as out-of-memory or corrupted PDFs? I suggest to do the error checking as suggested by the RGhost documentation anyway. Feel free to keep the rescue block as well :) Otherwise this is good to go from my point of view.
I think it's "Joel Burford"
syntax error here, but don't worry, i'll fit it
we should either make `build.py` py3k/py2 compliant, or use some other means of generating the output.
probably didn't want that `}s`
I have to agree with @tombell here.

It should probably be part of the submission guidelines or something. Are there any actually?
Maybe could have this be /q(?:uestion)? card/i to so you can use same semantics as `card me`?
Btw, does anyone know why are we checking for `self.pageno` to be `nil` or `false` here? Can it ever be `nil` in this context?
Meant to remove?
Endlines? This file needs to be \n so it can be executed directly on linux boxes.
I actually just noticed that we have failing doc-tests.. any ideas what is causing this?

Failed example:
    print epochs_data.shape
Expected:
    (55, 365, 106)
Got:
    (71, 365, 106)

there are more, but all caused by  the same problem.
The indentation for this block and the about block above should be indented one more space.
I was interested in the details here, so I had a look at the generated byte code.

The penalty of foreach is two method calls per character, one on Function.apply(Object), that then casts Object to Char, and the next is on Function.apply(Char).  Presumably we are also paying a boxing/unboxing penalty to convert char to Character and then back.  So one object instantiation and 2 method invocations per character.  I don't think that's a huge penalty, and wouldn't be surprised if JIT is able to inline it all, but I'm happy to change it if you want.

As for the match, in this case since it's all matching on primitives, the scala compiler has compiled it to a lookupswitch, so it's actually faster than an if statement since it does a binary search.
We weren't sure if this was strictly necessary.  If you remove one page from the list, the list is still in order, even if the _order numbers are not numbers that are one apart.  We put it in because the old code had it and because we don't know what the system relies on, but I don't think it's strictly necessary to keep this.

If we take it out, we can save a bunch of queries.
@weaverryan - sure, so long as what is about the component is in the component docs it's quite OK. However, I think we need to be *extremely* careful because the cookbook is generally about Symfony2 Framework.  We have to be careful to show what is specifically Sf2 Framework, what is simply a result of using the bundle system (using `HttpKerel\Kernel`) and what is simply a recipe for a component. That is why I asked @fabpot for permission to split the component documentation so we can add parts, including 'recipes'. Please take all this into consideration when moving things about.
What is the logic about using code-block or using the :: notation?
Because if the user stores the filename and URL, we have to set that before flushing... But wait !
In my project I actually do something a little bit different and the filename has already been set in preUpload()...

Sorry ! Should I have make 2 commits ?
two dots at the end
陈旧 -> 过期

这样做可以在更新缓存时最小化访问源服务器的次数。 -> 在更新缓存数据时, 可以使访问源服务器的次数最少。
I know that, but a pull request must not include that kind of change, you can change it on a branch on your side if you want but don't submit it please.
Why did you remove these labels etc?
Sure, I can do that :)

------------------------
Sent from my Sega Master System

On 9/04/2012, at 4:45 PM, Mathias Meyer<reply@reply.github.com> wrote:

>> @@ -123,7 +131,9 @@ def caching(&block)
>> 
>>         def decode(payload)
>>           MultiJson.decode(payload)
>> -        rescue
>> +        rescue StandardError => e
>> +          error "[#{Thread.current.object_id}] [decode error] payload could not be decoded with engine #{MultiJson.engine.to_s} : #{(payload.size > 160 ? "#{payload[0..160]} ..." : payload)}"
>> +          error "[#{Thread.current.object_id}] [decode error] #{e.inspect}"
> 
> Turn this into one log line maybe? Going to be hard when there are multiple request handlers at some point to figure out which lines belong together, might as well just make it one line.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/travis-ci/travis-hub/pull/6/files#r660239
Curious why we need both this method and convert_case a few lines down, there doesn't seem to be much difference.
yes, that’s what I had in mind
I meant: if you do any thing funky to the key when you're setting the cache, remember to repeat the operation on the key when you're getting the cache. 

we had a minor bug where cache was partially broken because the getter wasn't performing exactly the same operation as the setter, so it wasn't breaking anything, but it would constantly re-cache certain get requests needlessly because of key mismatches.
make this private, you don't need to get to it outside of this class.  

This isn't going to change, it's a constant.  To declare a 'constant' in Java, you add the words final static.

More info here: http://java.about.com/od/understandingdatatypes/a/Using-Constants.htm
Ok, that makes sense, and it removes any ambiguity (otherwise in some cases ``ax`` is ``fk5``, and in some cases ``gal``).
Not sure this is needed, try "npm test" to run the tests, see https://npmjs.org/doc/test.html
At a minimum, this should be properly capitalized as "All lists".
However, I don't think "All lists" is the best description. Clicking it shows all caches, whereas it reads more like I'm to get another list of lists. Maybe "All caches"?

Thoughts from anyone else?
Should probably take the `p` out; would get annoying when a user is typing a value and the debug terminal fills with strings
Yeah, it was a style choice. I typically prefer value == expected myself but it seemed to read better reversing it.
`service_type = body['instance'].get('service_type', "mysql")`
Yes, I agree. Just fix the patch as per the other comments and I think it should be good to go
- does it still make sense to have this class? It seems to only be doing factory work
   - build the StateProvider, StateConsumer, CacheJoinInfo, CacheTopologyHandler and ConsistentHashFactory -- all these can be moved to specialised @Factory classes  
   - the actual @Start and @Stop job can then be migrated to the LocalTopologyManager where seems like it belongs (I find it hard to follow the way this class comunicates with the LocalTopologyManager "over" the CacheTopologyHandler) 
    - looking at LocalTopologyManager I realised why the need for both STM and LTM -> because LTM has a Global state, namely the state of runningCaches. If we'd make this state a @Global component and inject it in a (per/cache) LocalTopologyManager that would also contain the logic from STM + move @Factories out of STM, the code might be nicer, wdyt?
Wouldn't it be better to do the contains on addresses (local copy) rather than requestorAddresses?
The mongodb configuration doesn"t implement LockSupportStore, so why should it take care of its conf or should if implement it too ?
It should probably check to make sure that the peerDep requirement will actually be met.  Something like:

```javascript
if (!semver.satisfies(dependency.version, peerDeps[d])) {
  // set some flag that it's invalid, but probably need a new flag, like `peerValid` so
  // since the `valid` flag already is used for regular dependency validity.
}
```
I think the only way is to load the asset, but it defeats the purpose of the AssetCache =/

I trying to think some way that doesn't need interface changes.
why remove this exception handling?  At the very least we could use the verbose.report() there to provide us information and then re-raise (or maybe add a message to the exception and let it bubble up?)
Should be capitalised and the signature below it indented (based on looking at scatter & errorbar).
It would be great to get some docstrings on these attributes.
It looks like all of these `by_*` methods should have their logic largely merged.  I'd suggest keeping the methods that you already have, but abstract the query/query execution out to another method called:  `by` that accepts the unique portions of the WHERE clause (`$where`) and `$args`.
Done! Thanks for the review/feedback
Added them back in
Is there a substantial gain for removing this event? It could impact users who have added custom functionality based on this event. Unless there is a distinct benefit of removing this, I think we should continue firing the event.
With your changes, nothing listens for this event anymore... you can delete this block and the LITE_EVENT_TOPIC constant. ActivityConstants.EVENT_TOPIC might be unnecessary too.
aM.isAdmin() checks Admin group membership as well as whether the user is "admin"
thus, changing the signature of the Twig extension is a BC break for everyone using Assetic and Twig standalone so I don't really like doing this before the 1.1 release
replacing IDs with classes makes CSS processing an incredible amount slower. What's the justification for the change?
maybe break this into a separate method?
jep, find auch
might be nicer to use `resultItem = resultItem.map(extractAttributes);` here? slower, but more functional - and fits in with the style I've used so far
Let's go for no longer supporting undefined as argument for deleting a cookie (this has never been documented).
why not reusing the variable ?
I considered that. Better safe than sorry I guess ;)
why would you add tesT?
I can see that, but that makes automated extraction very difficult I'd think. Filters can be chained or fed variables, the extractor will have a hard time figuring out which values it's supposed to extract and/or you can write constructs which should be illegal for gettext markup. For instance:

    {{ "foo"|title|gettext }}
    {{ foo|gettext }}

It's not possible to extract those, since results of functions/filters or variables could only be extracted at runtime.

That is, unless I'm missing something. The extractor checks whether the arguments are a constant expression. I assume something similar can be done using filters, but parsing would be much harder I imagine.

Last but not least, `_()` syntax may be extractable by tools other than this Twig gettext extractor since the syntax is standardized.
Yep, I misandersood your comment.
I think needs to be IException *..
Spaces around `<` otherwise.
Split into two TODOs. One which tells that we have check if user has e-mail defined (verb *check* is missing). And this should also go to the `EmailConfirmationSendToken` view.  And then the other one which should check if it is still the same user.
Move this to `common.js`.
Move this up, so that it is before content. No? If you need, wrap both in another div. So #content == content block only.
this isn't true, since it's an Option. i'd just delete this line.
missing comma. this code pass tests?
Given the role of `substitutionSpecification` wouldn't the existing `IRequestSpecification` interface be a good fit?
Ugh, right. Maybe we should just abstract this logic into a helper func, and call it 3 times. Something like:

```python
def attribute_dance(attrname):
    value = getattr(user, attrname, None)
    if hasattr(venue, 'contact'):
        return venue.contact.get(attrname, value)
    return value

venue.contact_name = attribute_dance('name')
venue.contact_email = attribute_dance('email')
venue.contact_phone = attribute_dance('phone')
```

Choosing a better name for the helper is left as an exercise to the reader.
You shouldn't need this afaik. There's already `attr_accessor :raw` in the superclass. Unless you wanted to disable the writing accessor?
Yes, you will hit this issue even in ApplicationController, I suppose because Tim's ApplicationController inherits from this controller too.
fuuu!
This is not needed IMO, since it's basics of OOP. If you want to keep it, specify that this behavior can be overloaded by just defining a constructor that allows passing  in an ObjectManager
There is a way to do this. Always store the result of the collection, and get data on it : single items, slice...
And with a collection always stored, we can get the length via llen ;)

If we always store the result, with an expiring date (short, but the default could be overridden), we can have all this :D

And if the key storing it is not here, run the whole process again. And providing a way for the user to "reset" the collection (a single "reset" method) which would clear the storage key)

It's "draf" in my head but i think it can really help, and really use the power of slices to have real paginations, get only needed date at a given time, and so on.

What do you think about all this ? Was it clear enough ?
Might as well fix the whitespace.
I know it's idiomatic nginx but I personally prefer `memset(&url_, sizeof(url_))`. You don't run the risk of introducing bugs when you change url_'s type.

@jeffkaufman, @oschaaf: WDYT?
preprocessor directives go at the [beginning of the line](http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Preprocessor_Directives#Preprocessor_Directives).
s/n/buffer_size/
I wouldn't be surprised if it turned out to be a mistake.
Are there more informative names than this? `light` and `light2` makes me think that they are equivalent in meaning but for two different lights (in which case I would prefer `light1` and `light2` or an array `light[2]`, but the code makes me think that they mean two different things (clamped or scaled in a different way?)
I didn't see your edit: ``NegativeBinomial`` is my preferred choice.

R has a broad community, and five minutes later I don't remember what the abbreviation for a function is. (or is it ``norm`` or ``normal`` in scipy/numpy ?)
I think it's better to look at the algorithms again in a some more detail (i.e. with a profiler) instead of at joblib. Joblib also isn't going to yield more than a factor of a couple (2 at most for me); we're looking for more than that still.
Is maddog greater or less than 1?
maybe this can be modeled similar to basic_deliver? I haven't been reading the details of basic return tho. Just a comment
I think that here the language should be set to slovenian, not to be chosen by the user since this will bi portal in Slovenia so it would be logical that the search engine search primary slovenian pages. What do you think?
We are using four spaces for indenting.
Same trace comment as above.
This sentence is a bit ungrammatical.  Also the corresponding note about Boost for GammaDeviate above.
Fair enough. We can fix it later, the code works, just seemed wasteful to duplicate work already in the BCL.
Oops, didn't catch that, will fix asap.
I ses.. But could you please move this focusing things to dialogs open callback. Then you can avoid global selector by using $(this) inside callback
Yes, blows up as rpm -e jdk... exits with 1.

Nope, it tries to do an yum erase and bombs.  might be a way to sync them, but I didn't dig in.
The line needs to be changed since we renamed controller:
match 'volunteer/search', :to => 'volunteer_rsvps#index', :as => :volunteersearch
I think we had One to darken everything that is not the current editable area.

----- Reply message -----
Von: "Colin Frei" <notifications@github.com>
An: "symfony-cmf/CreateBundle" <CreateBundle@noreply.github.com>
Cc: "David Buchmann" <david@liip.ch>
Betreff: [CreateBundle] Use the fixed toolbar for hallo (#16)
Datum: Mo., Okt. 15, 2012 21:09
In Resources/public/js/init-create-hallo.js: 
> @@ -52,18 +50,8 @@ jQuery(document).ready(function() { 
>                  'vie': this.vie 
>              }, 
>              'hallolink': { 'relatedUrl': cmfCreateHalloLinkRelatedPath }, 
> -            'halloformat': {'formattings': {'strikeThrough': false, 'underline': false}}, 
> -            'halloblock': {}, 
> -            'hallolists': {'lists': {'ordered': false}}, 
> -            'hallojustify': {}, 
> -            'hallotoolbarlinebreak': { 'breakAfter': ['hallolink'] }, 
> -            'hallooverlay': {}, 

The overlay? 


&mdash;

Reply to this email directly or view it on GitHub.
bit not sure about this - > path.join(wPath.webinosPath(), "wrt"). This will create folder in .webinos. Is that needed. As you are trying to read getWebinosPath() it returns .webinos/pzp/wrt.. Probably this is not needed.
Why not `erb || @template_source`
What is the OBController?
I thought we weren't having people own specific files.
Pourquoi as-tu besoin de faire ça avant l'appel $this->isReadyForExport() ?
El instalador necesita una copia limpia de los dos archivos, si te parece bien los muevo dentro de install/
Öhm öfters? Ich hab bis gerade das nicht einmal geschaft.
I just updated the pull request to leave out deform's CSS.
if (i == args.length - 1) {
    exitError("wrong use of key -o");
 }

а это разве не проверка выхода за границы массива?
Или аргументы вообще не могут быть пустыми?
This is incredibly nit-picky, but this is 'Javadocs' and all the other links are 'javadocs' - can you just change this so it is consistent?
```ruby
inline_label = options[:inline_label] == true ? label_text : options[:inline_label]
```
In Johannes defense, the `sobel` function uses the same wording. I would suggest changing both docstrings to match the `prewitt` function:

    Find the edge magnitude using the Prewitt transform.
I think the `* 1` could be removed here?
This line is too long (greater than 79 characters).

In addition, there should be a verbose parameter on the estimator, defaulting to '0', that controls the print.
np.where is more standard to do this
Should use ``self.__class__.__name__``

http://stackoverflow.com/questions/510972/getting-the-class-name-of-an-instance-in-python
so, this will not work for forms that have already been cloned?
The showBuildScreen method of the application tells the factory to provide an instance of the build screen AND then tells this instance to appendToApplication. Those two actions are only things that this method does, so I think they should go into the unit test. With the current test setup we test both things at the same time by stubbing the factory and the screens.
Attention, cette méthode ne doit être utilisée que lorsqu'il y a un degré
Why not make a requirement on the conf file instead, and remove the subscribe?
ok, still, you could just "return hasLinkCountedModifier(field)" for now. ;)
s/automaticall/automatically/
Would be even simpler if pipe implemented a ```readLine``` for cases where it's reading text...
deze wijziging ken ik ook niet. EVE
Also seems that this is not needed because `local.ini.dst` already has that config keys
`\S` is very permissive, don't we want something more restricted, like `\w` or `[\w:]` or ... ?
One too many spaces here.
Would name it $writer or $configWriter.
Please add a line break.
two-space indent, should be four spaces
because i'm using the "id" attribute, an extra JOIN is not necessary here.  And get_for_id should be caching things in local memory, so this won't be expensive
could this method return a false positive in the cases where a single date is correctly ordered but the rest of the dates are incorrectly sorted? 

for instance: 
d1 equals sd1 so isDate = true and then all the other dates dx to sdx are not in the correct sorting order but isDate is already set to true so isDate never gets set to false.
@elicochran What's the use of this comment
I reflect this interface is more common. It can be anything, not just an icon. I shouldn't probably put this javadoc here.
This will break if the Subject in parsedquery is already encoded. Or is that disallowed/not possible?
There are five other instances in this file of the URL being quoted and relative to the current file rather than unquoted and relative to the base. I like the change made here, but please make it everywhere else as well. Consistency is important.
I definitely see the argument for adding those options, but that should be a separate pull request and should probably be a separate pull request since that change would have a more visible impact on the user experience (i.e., the default rendered page would actually differ, whereas that isn't the case here). Anyway, ready to merge as soon as that change is made. Thanks again for adding this!
Just to have a record of offline conversation, this is for users with ram /tmp which can be fairly small.
Read the wiki, the original (or known, or wiki defined) meaning of
defensive programming is aka secure programming and relates to programming
in a secure way and defending against hacking. That's NOT what I call
defensive programming, which is more of a way people approach development
and code




On 13 בדצמ 2012, at 23:34, Ran Tavory <notifications@github.com> wrote:

In defensive_programming.md:

> @@ -0,0 +1,17 @@
> +Title: Defensive Programming - I know what you did last sprint?
> +================================================================
> +
> +People have a lot of approaches when developing their own code, and when looking at existing code.
> +In this talk I will discuss I call "defensive programming" (not the [secure programming](http://en.wikipedia.org/wiki/Defensive_programming) you might know from other places),

I'm a bit confused.
You say that Defensive Programming isn't Secure Programming, yet in the
link you provide for [secure programming] you link to what seems to be an
article about Defensive Programming, not Secure... (perhaps you left out
the hash:
http://en.wikipedia.org/wiki/Defensive_programming#Secure_programming)

—
Reply to this email directly or view it on
GitHub<https://github.com/rantav/reversim-summit-2013/pull/11/files#r2413986>.
disconnect here and in the "rescue", maybe you should use "ensure" here.
The enum_dirperms adds exception handling when using this method, maybe you should add it too:

quoting code from enum_dirperms:

```ruby
		begin
			t = get_imperstoken()
		rescue ::Exception => e
			# Failure due to timeout, access denied, etc.
			t = 0
			vprint_error("Error #{e.message} while using get_imperstoken()")
			vprint_error(e.backtrace)
		end
```
Oh right, this is only on the 2D controller.  Translate and pan are the same here.
Summary should basically just copy what android has:
  "Programmatically opens the options menu."
D'oh! I was making sure that format worked before I commented on a couple of community PRs. Got stuck into this commit by accident.
Sorry @steveroberson, I have informed you incorrectly about the spaces above.
Per input from sir @thbishop I gave a shot using map & select.  

to_copy = source_attributes.select { |k| k !~ /^deployment/ }
to_copy.map {|k,v| { k => v } }

Let me know your thoughts
я тут научился экономить строчку :D

    @uploader?.cancel()
    @uploader = null
use g_strcmp0
Could you please explain? Indeed I wasn't aware dmd misaligns `union`s on the stack. What's happening there?

Regarding doing alignment by hand, I see you're adding slack memory conservatively to Scoped_store so as to compensate for the lack of alignment. But then I'd expect you'd do some computation (add an offset to get to the aligned position) in the Scoped_payload computation. But that function only has a cast, so I'm not sure I understand what's going on.
As I wrote:
> Why? Looks like you just don't want to accept zero-dimensional arrays and all.

Zero-dimensional static array is a multidimensional static array (but not a static array), IMHO.
What’s this method for? Is it actually used anywhere?
this should be:
```dart
expect(info.attributes['value'].isStyleMap, false);
```

(isClass is doing it wrong too... I'm guessing it was original `expect(!condition);`  and it was blindly refactored after a recent change to unittest API)
I don't think this is right. If I fetch at time 1000:

* record A: 110
* record B: 220
* record C: 330

and send commands to A and C, I'll set a header of 330, not 1000, and the request will fail.

You want to save the timestamp from when you got these records via HTTP GET, and use that — it'll guarantee that nobody will have touched the server since you fetched them.
Re: make `CommandProcessor` non-static: we need a command processor at two different times: during clients stage of an actual sync, and during an activity completely unrelated to a sync (such as `SendTabActivity`, but also during other activities yet to be developed, such as `WipeOtherClientsActivity`.)  We could have each activity create a command processor, but this seems unnecessary and raises locking and synchronization questions (since all processors access the same clients DB, for example).  A global long-lived singleton seems right to me.

Re: have `CommandRunner` take a `GlobalSession`: I considered this, but it really complicates the whole mechanism.  Activities that access the clients command DB don't really have a GlobalSession, *and I don't want them to fake one*.  If you introduce two types of command runner objects, this gets more complicated still, for very little value.

So I introduced a janky "remove this" token and called it a day.
You don't need a break if you are doing a redirect.
I'm still really confused about which store actually works everywhere e.g. IIS6, IIS7, various Windows versions running under various user accounts. We may need to do some more research to determine the correct option.
If you use the variable in the routine, you should remove the _ prefix.
What do all these conditionals handle?
Actually, ignore this - I'm doing that from code outside `cc.model` as sort of the "exported interface" of all of `cc.model`, but this code is inside `cc.model.library` - doing it this way is fine.
actually, `add()` accepts any number of arguments, and the related-manager goes both ways, so you can just `tag.caseversions.add(*case_versions)`
See the discussion on #198 for the details.
Given we are only setting it if absent, this header needs to be qualified, perhaps with getComponentName() ??

There could be more than one delayer in the same context.

Also, what happens if the same message traverses the same delayer twice?

Maybe we should reconsider using setIfAbsent and simply detect that we are processing a delayed message before setting it?
FYI, when commenting with &lt; ... &gt;, on GitHub, you have to escape with &amp;lt;... &amp;gt;