labofsahil/github-event-dataset-2012 huggingface dataset:
Thanks.

I'm a little nervous that, given a sufficiently heterogenous index, these 4 links could (seemingly randomly) appear and disappear depending on what content is on a particular page -- not that the current approach is any less broken. At the very least, I'd like to see some consensus from other committers before merging this patch.

It would also be good, though likely difficult, given the state of our test index, to have this feature reflected in cucumber tests.
I am not sure there is an easy fix either. But lets merge it as is, and as soon as either of us will think of a nice solution, we'll do it. How about that?
zonedabone what do you suggest?
lrn2rebase :)
how are we going to handle `users.views.profile` and `users.views.edit`? I think we're going to need to block the add-ons/apps preview version of those pages and create a minimal version ourself for marketplace/dev beta.
Hi,

I see -- in this case, maybe explicitly referring to the commit would be better

https://raw.github.com/gist/1958550/9c03b16c370d458a7410fd045cdb3720407c1e58/cmake-xcode-4.3-compat.patch

benjamin
yes please, that would be nice
Может быть имеет смысл вынести настройку времени в settings.py или принимать как аргумент команды? Будет удобнее в плане использования кроном(если получать в качестве аргумента) или можно будет использовать в других местах проекта, если будет нужно(если использовать значение в settings).
I don't know why I even type this, but is it possible to pull the static resource path from the static middleware if installed?  a very minor point
@ozten - can you remove set_password.js out of here?  I removed it yesterday, not sure if it was before or after my merge into your branch.
ok -- meanwhile I will cherry pick this one and adjust accordingly
please make a constant.
This was changed because of a better naming convention.
This could use a comment explaining what the "index" is.
Yeah! And it broke big amount of plugins! Party!
See the URL on 4022+: I'm not sure they ever actually committed this to master/trunk. + It's a simple fix, a more recent version of Prototype might have incompatible changes of its own and in the light of the jQuery discussion I don't think it's currently a priority.
This change wasn't necessary, btw.
You should only make one call to updateInstanceDescription because each one of them is a web service call.
HEAD到底翻不翻译呢？很纠结。不仅这一处。
Should really rename this from editBox to something else.
> Obviously I don't know perl..
me neither ;)

I am confused a bit though -- was the first line (Content-Type: text/plain; charset="POSIX") whenever you don't have fail2ban providing content-type at all  OR  when you still have what you and I thought bogus left-over definition of "ContentType" var declaraion?
On Sat, Feb 25, 2012 at 12:57 PM, Keshav Kini
<reply@reply.github.com>
wrote:
> In other words you are missing a `master` branch? OK, then this should do it:
>
> ```
> $ git checkout lfun
> $ git rebase --onto f583b1b9f384e3be442c39b35e0c51a9e4815cba github-master
> ```

Yes, that worked.  Thanks.

deep:sage wstein$ git rebase --onto
f583b1b9f384e3be442c39b35e0c51a9e4815cba github-master
First, rewinding head to replay your work on top of it...
Applying: starting work on padic_lseries for modular symbols spaces
Applying: copy code over from psage; fix licenses (I'm copyright
holder); get code to compile.
Applying: change some imports to not mention "psage".
Applying: Remove the newforms.py file -- this shouldn't be in this patch.
Applying: fast p-adic L-series: get all doctests to pass
Applying: padic-lseries: update copyright headers for Sage
Applying: p-adic L-series: more doctests in modular_symbol_map
Applying: padic_lseries -- get doctest coverage of
modular_symbol_map.pyx to 100%
Applying: padic_lseries -- working on doctesting padic_elliptic_lseries_fast.pyx
deep:sage wstein$ git push -f
Counting objects: 96, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (85/85), done.
Writing objects: 100% (86/86), 30.29 KiB, done.
Total 86 (delta 66), reused 0 (delta 0)
To git@github.com:williamstein/sagelib.git
 + 739bcf8...7059375 lfun -> lfun (forced update)
deep:sage wstein$


>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/williamstein/sagelib/commit/f4104efd87cb421923f884f8ea5c571fa52d583b#commitcomment-1011414



-- 
William Stein
Professor of Mathematics
University of Washington
http://wstein.org
It was a bit hard because we're wrong since the first import: stupid Phonon fails to make default search path (when using find_package()) correct, and it was working by accident. As a bonus we should no longer clash with Qt's Phonon. :)
Quite right.
I've changed it to use FAN followed by a mode, as suggested, and removed 
the FAN_LO and FAN_HI "devices".

/Alex

David Sveningsson skrev 2012-01-20 03:21:
> It is painful to send FAN_LO or FAN_HI followed by OFF to disable the fan, why not add FAN_DISABLED as well? Maybe it would make more sense to use FAN followed by a mode (DISABLED='a', LOW='b', HIGH='c')
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/noobmartin/OpenTurpo/commit/7e566cd3da5af63296b4118967444e349b1a4b87#commitcomment-884599
Commit 18ab22cd3ffe29cd42852aa153ce66381c8c4870 fixes this on my end, give it a shot.
The semantic of exceptions and errors/warnings/notices are quite different. Especially notices and warnings are very useful tools, that cannot get replaced by exceptions as long as exceptions _always_ change the program flow.
I think that orderby should be stored as an array and not a string in the SQL query fragment, and imploded only when it's time to run the query.  In particular, we should be making the internal data structure both distinct and amenable to easy manipulation.

For example, I suspect that an order by clause like this would break the reverse code: `ORDER BY implode("Title","AuthorID"), "Created" DESC`.

If this was stored like so, manipulation would be much easier:

    array(
      'implode("Title","AuthorID")' => 'asc',
      '"Created"' => 'desc',
    );

Of course, if you called `$datalist->orderby('implode("Title","AuthorID"), "Created" DESC')` we'd still need to make that work.  The solution is a more expensive parser (we need to count the number of quotes and ignore any comma contained within unmatched quote pairs, or go the whole hog and use PEG), but by discouraging the use of the above syntax, we can revert to that expensive parse only in exceptional circumstances.
I think "NO". Let's leave [JsonConverter(typeof(StringEnumConverter))] on enums.
They are quite declarative. (I like them)))
Probably should replace to 4 /*XMLHttpRequest.DONE*/ for the time being, Opera constants are a strange thing. In 12 it's properly defined as it should in a previous versions but who can say.
This line and 742 change HTML layout of custom subscription input.

Code in line 1053 no longer work for this input:

    url.push(radioButton.nextElementSibling.nextElementSibling.href || radioButton.nextElementSibling.nextElementSibling.value);

Checkbox state is not saved; custom subscription not downloaded.
Я так понимаю подразумевался тег <irony>?
thx for the link ;)
Are you sure you want to change this?

And if you did, you didn't update the other plugin dependencies....

2012-01-24 22:00:46 [SEVERE] Could not load 'plugins\EssentialsSpawn.jar' in folder 'plugins': Essentials
org.bukkit.plugin.UnknownDependencyException: Essentials
if (excludes.indexOf(room) === -1) {
What is "GitExtensions/bin/Debug" file added by this commit?

This file prevent me to build GitExtensions.exe(debug version).
oh nevermid... may its only in some german release names...
sorry for that
ach du check mal die arkcore commits ab , ahb erudax texte zu script texte mit sound umgebaut
Nvm, this got fixed in a later commit
this bastard
Nice Sprachenmix!
Thank you for the information.  https://github.com/zeroem/ZeroemCurlBundle/commit/ea62bd9341dfd15645e2528edb51e308a3cac0ac
17:53:02 Angewählte Einheit hat 1 Auren des Typs 193:
17:53:02 id: 50172 eff: 0 amount: 99842 = fail!??!

sry for german client :P
See for yourself base, npc 1232 (Azar Stronghammer) and 926 (Bromos Grummner)
I made this using TortoiseHg + hggit, thinking that it would be a decent Windows interface to git, somehow ignoring the existence of TortoiseGit, which appears to be better even than TortoiseHg working with Hg... Everything in this commit has now been committed into a separate branch, so this commit is now redundant.
i guess the one towards xt-002 is missing.
Jo, jag vet att de inte gör någon nytta. Trodde bara att du ville ha dem där för att det skulle bli tydligare eller något.
Men vad menade du med  "Du kunde också satt parentes runt subtraktionen" då?
I needed that because the feedreader on the nokia n9 does not like it if multiple entries in a feed have the same link. It stops updating the feed altogether.
You need to add Houndoom to the LU list / NU ban list. Also, I think you put Aerodactyl in the UU list instead of the LU one.
I created the live cell interface to use more as metadata when filtering objects from a list later on.
Ja, jag ritade av en bild som jag hittade.
sox is probably the way to go here
this commit sucks
Ha! Found ya!

This means we're no longer reporting info on the service. Will cobble this back in.
마지막 1글자가 화면에서 짤리는 경우가 있으므로 글씨를 1글자 줄임.
最後の１文字が見えないので、文章を１文字短くする
string is shorted just 1 character, for show last Korean 1 Character.
Thought these were going to be overrideable options? Then we could pass in more complex element blocks.
I do use auto_reconnect that's why I was asking.

At my node.js program start I do .open(.auth); then no matter if I wait 10 or 20s, the first request will always be trapped by theses lines.

Do you mean I need to do .open .auth each time I want to issue a request ? Doesn't auto_reconnect solves this ?
bray did
В JS1.7 есть специальное объявление let, которая сделает переменную видимой только в блоке, в котором она объявлена. Т.е. можно делать надо так:
`for(let foo in bar) ...;`
Yes: we track a stored item, after which it is a tracked item (or a tracked stored item if you prefer). The shift from verb to adjective is the state transition.

If you mean "where did the word 'stored' go?", then I would suggest trackRecordForExclusion/isTrackedForExclusion.

(This commit is superseded by a later one in which we track records, not just their GUIDs.)
<pre>Log.e("DeleteDelegate", "DELETE got error.", ex);</pre>
Also `collection`.

We should probably lift the basics out of `BookmarkRecord` and friends into `Record`… I didn't do that because Java doesn't have a good way to say “kinda abstract”.
query niet helemaal juist geïndent. Deze lijn SQL (en volgende) moeten op dezelfde hoogte staan van SELECT. Dus nog net 1 spatie toevoegen vlak voor FROM (en idem bij volgende lijnen)
Thanks. I was going to add it back and saw you already did.
The variable `selectionKey` can be renamed `key` as the usage is clear.
Shouldn't the `<uses-sdk />` attributes be `android`-prefixed?
J'ai laissé la valeur de l'article original mais effectivement c'est peut-être pas super pertinent dans ce cas. Faut voir ce qui est mis dans la CSS finale.
I will test soon.
DisplayHardware: Set MDP composition flag correctly
Change-Id: Id0c7172fe8578f3eb26bbe10a448a96fee1d72cd
commit 0179465b3aad2654f4b1eb3e6aecdb647a27c551 1 parent a22a7ae1d0
Naseer Ahmed authored 9 days ago
existz committed a day ago

LorDClockaN does not maintain commit history when resolving merge conflicts and many of the patches available on aospX would require reverting the LOG -> ALOG changes. This was handled by allowing LorDClockaN to cherry-pick first.

These changes were previously present in this project, but required reverting a change before they were added that would cause massive corruption. These commits need to be checked to ensure they contain all of the same information previously present.
В избранном, все посты помечаются как isDel
This is currently causing yuidoc issues. Adding `@for Base` clears up `Y.Base`'s docs, but leaves `Y.BaseEvents` without any "own" methods, events, properties.
I'd recommend we still go through get() for this instead of _getAttr(), to avoid potential regressions. get() is public, and may be overridden. We should still see substantial savings from removing the unneccessary second call (good catch).
Your variables should ALL be declared at the top of the function block.  This prevents accidental logic errors caused by implicit variable "hoisting" in javascript.

You can do the assignment anywhere it makes sense, but be sure they are declared at the start of your functions please
That doesn't work, because the RHS builds a temporary python value which gets GC'd immediately.  Leaving the LHS dangling.  You need to assign to the python temporary explicitly.

I can write it as:
  tmp = dat._data.dtype.name + ":soa" if dat.soa else ""
  type = tmp

if that's better
Oh, so this isn't a state, it's what your command renders as when it can't be rendered.

`command()` shouldn't be returning a magic string when the render fails. It should raise an exception and `JobRun` should fail itself.
A lot of repeated code here, please abstract and reuse (DRY)
Is the system scheduler configuration tuned for the heartbeats? (given the way the default scheduler works)
Why is this an object within a class?
“… metrics are …”
yes, it was done like this because someone thought these might then be constants, but of course they cannot be anyway (after all they are not known at compile time), so I'm not sure what to do with them. To me their types are obvious enough, it would disturb the visual impression to repeat them.
yes that could be hard :)
yes. WDYM?
OK, cool - thanks for the feedback! I'll remove the optional attribute from that import then and perhaps add a doc page under additional/ or something to clarify what needs to be changed for an OSGi environment instead?
I've added instructions to the comments. Changing how this is generated is ticket #1798.
Do you need this to be true?
removed valuable inline commenting
do you have a plan for this piece of the api?  User.create_with_card seems pretty awkward.  (probaby next release, though)
Are you referring to the equation in http://en.wikipedia.org/wiki/Truncated_normal_distribution ? Maybe you can add the link to the comment, or write in the comment the equation that you are using, that is: CDF_truncnorm(x) = (CDF_norm(x) - CDF_norm(a)) / Z, where Z =  CDF_norm(a) - CDF_norm(b)
Does this work if there is more than one b0? What does this do?
To be honest, no. I oriented myself by the examples above and throughout CKAN.
input, checkbox, info etc. => hidden
So, we need plural form and CKAN heavily uses _list for that => hidden_list

The other way round would be to start with
hidden_fields (plural s) => hidden_field (singular), however that wouldn't be consistent with the rest of the macros.

list_of_hidden
or 
hiddens
I could think of. But all of them are clumsy.
Oh cool. I didn't know it accepts multiple paths. Nice to know.
You know, a messages hash could cover us for a while.  Wagn::Message[ :message_codename ] => String
This is where I had the trouble with readonly being set.  Sort of makes sense.  Both the cache and DB can give you a version that you can't update without refreshing.

We should also be able to figure out how to store and reload from the cache without ending up frozen.  You may not want that all the time, but it would be good to know how it works.
I wonder if we shouldn't use a default instread of an option
I'm running it on an Atom N330, so no real pony, right? But you mean high CPU load or race-issues?
Highlighted code is from previous pull. I don't know why diff shows it as a new code. I think it would be better to correct this with a standalone commit.

This pull request adds cookieEquals method which is indented with spaces.
when you are using a library it is useful to diferentiate the exception thrown by the said library to exceptions thrown by other layer.
that way you can use catch blocks.
} catch (PigRuntimeException e) {
 // some pig specific error message
} catch(RuntimeException e) {
 // some other global error
}
What to do with this ? This test passes, but filename is not an argument for blank. `height=0` is tested line bellow.
`preserves_safety` looks good to me.
height is for potential animation.
windows needs the variable declarations at the top of the function
Retire la class btn-danger. Le rouge est réservé pour les actions destructrices. C'est trop agressant sinon.
why do you use the constructor directly and not Unpooled here ?
Line 111 vs line 112
Is it Github or is the indentation borked?
In 1.9.3, the following is not only doable, but totally rad:

```ruby
availability = Date.today .. Date::Infinity.new
availability.include?(Date.today + 1) #=> true
```

Whereas...

```ruby
availability = Date.today .. Float::INFINITY
availability.include?(Date.today + 1) #=> true
```

... totally works, but looks weird and sort of surprising. You may want to use the former version of a Range just to keep level of surprise down. Just my $0.02 CAD.
Keep the rake routes change for another pull request - just in case there's reason it's there it'll be easier to revert.

BTW, thanks for your work this. :clap:
how about: `test_include_root_in_json_allows_inheritance`?
Should the numbers be wrapped in a single quotes here or should it just be `BETWEEN 1 AND 5`?
Don't think it's a good idea. 
`__run_callbacks` API already changed since Rails 3.2:
https://github.com/rails/rails/blob/3-2-stable/activesupport/lib/active_support/callbacks.rb#L396

So there is no compatibility already.
I can help you there. I added an assert to Select. Most of the way through the test suite, there are four test failures comprising two call sites in the compiler. Both are unquestionably bugs. I think it's a gimme to fix those bugs and make the assert a permanent fixture in Select. And then (by impressively indirect route) you can use the simple sym.name == name logic.
interpolated string here?
Yes please remove it.
Thanks Ryan.

On 2012-04-20, at 10:12 AM, Ryan Bigg wrote:

>> @@ -14,7 +14,7 @@ def set_default_category
>>       #set existing default tax category to false if this one has been marked as default
>> 
>>       if is_default && tax_category = self.class.where(:is_default => true).first
>> -        tax_category.update_attribute(:is_default, false)
>> +        tax_category.update_attribute(:is_default, false) unless tax_category==self
> 
> `<ocd>` For future reference, please pad `==` with spaces (i.e. `tax_category == self`) just so it's a little "cleaner". `</ocd>`
> 
> I'll fix it when I pull this in.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/spree/spree/pull/1423/files#r713244
Not using a mutable default. Just use the standard pattern instead, with `None` as default, and `s = s or {}` (or `if s is None: s = {}` or whatever).
I've seen this used fairly often in pull requests recently.  Please verify that your personal preference should be enforced here.
fix formatting: `rv = True`
doctest?
Also, should these have tests?
Okay, reverted.
Lets not push the sample credentials and custom appblade url to master.
I don't actually see where we ever use this dictionary, since we are always persisting to disk. If we're not using it, get rid of it, as well as its synthesized iVar
One problem with doing this simplistically is that the rate calculations, etc. are all updated every 5 seconds. If a counter is polled (and `mark()` is called) less frequently than 5 seconds, the rates will be recorded as all happening right when `mark()` was called instead of something more reasonable (like linearly from the last time it was polled and now).

I'll have to dig into the underlying classes more to see if there's a reasonable way to do this sort of thing, but it may be that a meter isn't the right thing to be using as an underlying implementation for a derived counter.
Agreed, this should be part of the software using jline imho.
Style: indent error.
doesn't it mean, combined with a single cache across contexts, that we may get access from one context to another if a latter context will request a resource that has already been loaded for the first one?

In such case the cached resource will be returned, and it feels like it will hold reference to the wrong context (the former one)
Would it also not be better to pass in an Interval instead of the separate start and end parameters? That way you would get the isStartBeforeEnd check for free.
This should be done by client code. You don't know what the type of expression is or should be.
Please work out via area51 how the style renames should be handled as right now it is my impression that we wanted to allow style renames.
I'm not sure. I never even opened the file, I just let it be automatically generated.
[Yes](https://github.com/imkingdavid/prefixed/blob/develop/config/services.yml)
It was, but this naming scheme will probably change so this does not need to be done.
Returning false also does not imply that this is an error. It's just telling that there is no data to display for this avatar driver.
Why not require `style_version`, too?
trailing comma is invalid in json
Source directory is a project root (where CMakeLists.txt is located)
I'd recommend to place spaces around binary operators.
Why is this CSS inline?
in this case it is more appropriate to return immediately (the item is an inprogress submission so to discover the right collection you should queries the workspace and workflow tables)
This should not be hard-coded to Red Alert SHP names. It will break other mods including d2k.
Yes, topbar will be common. However, is there a way to add the URL host view dynamically in topbar in the login app?

The reason is we don't want this *very rare* button most of the time, then if the user can't log in, they see the login screen and can change the HOST value.
@bblay - what say you?
Guessing coordinates are never passed now...
make it 32, not 16 as newer GPU do not have a half-warp size.
Any reason for -10 here, or would any number other than 0 be ok here?
Should we do a similar check in tensor.get_constant_value too, if a dense Op has a sparse input?
You could use ``any`` here as well
please movit to pagination mixin
may contains // after joining

'/'.join(a.strip('/'), b.strip('/')
What makes the variable "size" special?
It seems like it shouldn't be necessary to call `lists:flatten/1` on every recursion of this function … it should only be needed once at the top level (in `aggregate/3`?).
Wouldn't the bootstrap process load these two plugins automatically?  What is the need to load them implicitly here.

In the future, I'm thinking of decoupling Settings further, eg: when changing theme, Extensions plugin will trigger a CakeEvent,  that will be caught by  Settings plugin.  It will then perform the the database update and settings.json.  But this change can be done separately from this PR.
add units to return value.
There can be different data units, I guess of different lengths, increment using the data_unit_len
We should probably still check that the pointers aren't null before we operate on them. Could save us some troubles if we make a change and are calling it incorrectly and then it just blows up.
I personally against of inclusion of such feature, because users can easily abuse it.
`$` => `jQuery`
Some sort of non-string expression or a function call
This block has a control flow without a return.
Hmm, @Sharpie knows, he is the MPI expert.
And can you submit this upstream (if you or Debian haven't already).
do we need this file? if not it's also inside xcode.proj.
Obvious comment is obvious, but an alternate option for cases like these where there are a metric ton of imports is, of course, to import the module and use `<module>.<Class>`, e.g.,

```
from r2.controllers import validator
...
@validator.VAdmin
```
should we make these settings dicts (like extension and middlewares) and use `scrapy.utils.conf.build_component_list` to load them?.

any particular reason why you went with lists instead?
remove this unnecessary doc.
Accidental.  Fixing.
```js
var parts = rule.split(' ');
      
      return {
        regex: new RegExp(parts[0]),
        replace: parts[1],
        last: !!parts[2]
      };
```
It's rather dangerous to use regular expressions to parse and format XML. Under ordinary circumstances, I'd suggest remove this code and find a more robust solution before pushing it to the project repo. But given our demo deadlines and the fact that we don't want to be juggling multiple branches, I think it's better to push it and fix it next week. You'll notice that the underlying SAX parser provides an example of how safely format XML documents. We should modify (or replace) the JSON mapper to take this into account.
Do you have a reason to not use `Tmdb.default_language`?
The indentation doesn't match the rest of the file. Could you fix that?
settings.xml was copied from maven installation. I may of course delete this unnecessary part.
Your attention should be in </servers> section necessary for deployment. The sourceforge/maven central credentials should not be pushed to github.
noted and considered...
If we explicitly set findNextCalled = false in setInitialSearchQuery() (one of my suggestions above), then I think this is unneeded.  (And I guess this holds even moreso if we follow my _other_ suggestion, where the prepopulated text would be handled by calling findFirst()... because then we'd _definitely_ have to explicitly set findNextCalled = false in the prepopulation-related code higher up).
Drive-by comment: is it worth factoring this so the rename functionality is programmatically accessible?  People can't really call the raw fs.rename() directly since it doesn't send out notifications or update any of the UI.
This function is not needed--you can just pass `UpdateNotification.checkForUpdate` to `setInterval()`.
The _matchPlatform() function just above here is also now unused & can be removed.
I saw your message one one of the other tickets about syntax errors. Does this do something unexpected that I haven't seen? If so that should be its own issue/PR/commit.
I actually think it's very important to keep .rvmrc in version control. [So does the rvm team](https://rvm.io/rvm/best-practices/).
Kevin, your always hacking late! and from what I've seen, never wrong ;)
I think it would make sense to specify an encoder when creating the request. Perhaps we could add a new constructor?

```
- (id)initWithURL: (NSURL *)URL encoder: (id<XMLRPCEncoder>)encoder;
```

This would then become the designated constructured, `initiWithURL:` could just call this new constructor with the default XMLRPCEncoder implementation.
Removed in db5eba9.
the suse user is named icecream - so I think we need some configure option to set the default user.
With a temporary variable, this would look a lot nicer.
Hmm, I'm thinking, because the nav itself is a list of nav item, and a nav item potentially has a sub-menu, can we instead of having a 'li's with divs, can we improve our semantics by just using lists (either 'ul' or 'ol')?

So we'd have

<ul>
  <li>
    <a href="#">Americas</a>
    <ul>
      <li><a href="#">Canada West</a></li>
    </ul>
  </li>
</ul>

That way we can keep the semantics.  It seems we're switching to divs for layout-related purposes.  :)

We can talk more about this if you'd like!
Can you put a link to our main GitHub repository?
ReST markup for inline code?
i also suspect they don't work. i will Do Something About It.
space right bracket.
Ah, good call.

That check no longer makes sense.
Because it wasn't as robust as the code that Dave added for loading configs, which was incredibly simple to copy & paste from right below this code. Perhaps we can merge that code in for a better XHR wrapper.
If we're going to have this as a mixin, better to call it `.transformAnimation` or something, since this is not a generic `keyframe` function, but rather one that specifically transforms something from `startProperty` to `endProperty`.
They aren't,  AFAICT
It's either specify that I only want it to build the transition property from the manifest or throw in hidden: true everywhere. I much prefer this.
That's great, thanks! Optional bonus points if you want to move this into a test_proxymanager.py :)
No, it is the condition that makes it possible. If you append unconditionally with a constant, you make it impossible to produce a collision.
Можно использовать `assert.match()` в [chai](http://chaijs.com/api/assert/)
ttl probably not.. Prio needs to go in because you need to be able to update a MX/SRV record. (this is part of RDATA normally).
If you do not included it, it will result in multiple MX records being updated. The dyndns-update-replace-mx test was created for this.

Although, i might be wrong with the analisys that you need to be able to replace a single MX record :)
It would also be possible to express timezone offsets as ±15-minute increments, ranging from -48 for UTC-12:00 to +56 for UTC+14:00. That's only 103 possible values, so it can be represented with an `Int8` value easily. This avoids needing a lookup table and seems likely to make computation with timezones a lot easier and more immediate.
I'd add maybe a comment here that this is not a simple bypass and permissions are checked later on.
can be product None?
in such case len(None) throws exception
war ne heiden arbeit...
why not using a JsonFormatter directly ?
EventUtils.synthesizeMouse can generate 'mousemove' event
Ok - should I remove the reference to your script and just describe ``hub``, or should I leave yours?
I think you are missing a `cos(lat)` factor in `dlong`?
If so this is apparently not covered by the unit tests.
Yes. Once you've modified it once it's global.
Their full names are CBlock::CURRENT_VERSION and CTransaction::CURRENT_VERSION; I'll modify the code to use their full names.
AFAIK, its never really displayed anywhere, and if it is, Id guess its clear ;).
Anyway, Id kinda like to leave the Revert commit to just revert and nothing more...feel free to add more useful stuff in a separate pull, Id say.
Unless we accept -discover=on, this should read "default 1 iff listening and no -externalip; 0 otherwise"
> isnt it better to check for -1 ?

Why? I normally check for _any invalid values_ <=> _x < 0_;
If you want to check for _the specific response that there is no such elem_ you would check for _x == -1_;
This is basically a question of taste (is it not?).

> lastIndexOf because of filenames like foo.jpg.bar.test

No; basically I did this: 

    ext `elemof` Crafty.image_whitelist

because _ext_ should always be the last extension:

    ext = current.substr(current.lastIndexOf('.') + 1).toLowerCase();

Using _lastIndexOf_ forces the programm to check every element, while _indexOf_ may terminate at the first occurence, and therefore might be a little faster.
uppercase `String` and `Boolean`. And use TryParse
An instance of `Redis` is a hard dependency of this class. To avoid confusion, you should add a constructor that accepts an instance of `Redis` as a required parameter.
This is going to be reused for char assets; it should be in evelink.parsing somewhere.
It is a bit icky that you still need empty parens when using the default parameter - I never noticed that before.
I think it would be fine to avoid this by writing `def remoteCommandLine = remoteCommandLine(None)`, since this still leaves all the logic in the main version of the method.
What objects throw `TypeError` when they're duped?
sorry, this is not a if/else.
it is a if/if
I will reindent
Yes, the kill/terminate methods should be defined everywhere we run, and on Windows kill is just an alias to terminate.
I was wondering, as there is only one argument for the `callbacks`, could we not directly build it ourself and use `complete_reply_callback` as an argument of the function ? We can even support both by looking at wether the third argument given to the function has a `complete_reply` key or not...

Same  for `object_info_request` I think
yes, need the `#id` to pass it as the selector for the constructor.
`toolbar` class is added by js.
changing id to `#maintoolbar`for consistency.
looks sensible, but see next comment.
This is the part I think that @tanoku will like the least...
I spent a couple of minutes looking into this and did not see a way to get around this problem. WinHTTP requires the Content-Length value up front.
minor comment.

if we are adding documentation here,

lets do a little more

define what special/ reference / etc mean here...
This is really more of a generic modal rather than a video-specific modal, especially because sometimes there is no `#video` on the page when it is called.

I suggest adding an "onclose" function argument that is run once the done button is clicked or esc key is pressed. Then, you can create a videoModal function:

```javascript
function videoModal(url, desc) {
    var content = '<video id="video" src="' + url + '"> controls autoplay type="video/webm"><p class="desc">' + desc + '</p>';
    modal(content, function() {
        $('#video')[0].pause();
    });
    $('#video').focus()[0].play();
}
```
probably put it before "research" (alphabetize)
Not sure if you meant to keep that commented out line in ^?
If we're testing this to make sure urls don't change in the app (maybe because these urls get linked to often), then we should test against an actual expected string rather than a calculated one. e.g. this test would be:

    eq_(t.get_absolute_url(), '/%s/%s' % (t.forum.slug, t.id))

That way we're testing against some specific expected string rather than a calculation where if ``reverse()`` changed, the test would still pass, but the urls could be different.
Oops--that comment is wrong. I'll fix that.
oops, I forgot to mention you can just do `revision(is_approved=True, save=True)` and save a line or even access document in the same line and save two.
Ah I see. So in this case the test method name is misleading. Mind changing it to testWaitForFalseAfterTrue or something similar? Then it would be ok.
Pretty sure this will need an OrgId arg.
This can be done in the function declaration:

```php
spawn($file, array $args = array(), array $options = null)
hfdlfjdifjd fjdkln ye kya bhakschodi hai !
We'll come back to this one :), hard question indeed.
typo: cookie
see the place where it is used: a unmapped form in the hierarchy
Is there a better way to provide this or line 138s error report?
This is not really correct. I would think it better to explicitly case 251 as SQL NULL, and throw an exception for 255, as it implies corrupted data or out of sync client/server, since it's not a valid value. Continuing your read after getting a 255 here would end up with an exception in some other unrelated place.
yes, but in UIKit there is `completion:` (`animateWithDuration:animations:completion:` and others) which is stronger for me

but do as you wish - it's just matter of personal taste
I first thought about doing it this way, but i changed my mind after and removed the parameter name as i had only one thing to store. 
But in fact it is quite dangerous to do without it ... I'm changing everything about the database.
spacing: `Error( "` (same for all three)
add test for when using the default signature but the value exists
Ah, that's something I was looking for! :) Thanks.
dict comprehension is unfortunately not supported on the ancient Python 2.6, which we still support. So as much as it sucks, use ``dict()`` + generator expression.
Why is the file above namespaced with window.CMS.$ and this one with window.CMS?
small performance gain, use location.href instead > http://jsperf.com/location-tostring-vs-location-href
Faut installer Lombok???
.setReplyType(ModelType.LIST)
.setReplyValueType(ModelType.STRING)
Needs i18n, here and in other places
should we be explicitly setting debug to true? if debug mode is off, wouldn't this test pass with or without the actual code change in this pull request?
This is used just once, with the overwrite option. How about just dropping the option arguments and making overwrite the default?
Deny access to these directories (basically those that have a `.htaccess` in them denying all web access)

* `/cache`
* `/config`
* `/inc`
* `/scripts`
I think using .on('end', function() {}); should alleviate this memory issue. node-get tests currently don't have huge files since it runs with travis and would fail, but https://gist.github.com/3555717 demonstrates the memory problem, triggered by setting a callback. Not using a callback will hopefully stop request from putting e'rything in mem.
We should certainly not catch all exceptions.  Is there a specific expection we want to suppress?  If so, why would this code be causing exceptions and would we want to know about them?  They will be buried if we catch them here.
Ups, it should be '-1' instead '1'. I'll use notEqual for better readability as well :)
why not use `[data-type="edit"]` instead?
Why is there a `href` here?
Nice catch. Thx!
TO DO: check if hide class is really needed.
It will need to be re-factored for the "scrolling address bar off screen" feature to make it part of the part that scrolls off the screen! Added issue no. to comment.
Turn the results of querySelectorAll[Not array] into Array
btn -> button
We spoke about this on IRC and are going to implement a queue so the race condition will be avoided.
Sure! But please focus on the added/removed code :D
We can make another kind of PR fixing the applications nits: redundant code, double quotes, etc...
If mozSettings is not loaded, we can still need desktopSettings.

I check the mozSettings inside desktopTesting, check below ;)
This pattern is used in 2 places. Create a |toggle| function and rename set/cancel to sounds better. Like set/unset.
Typo, the variable should be: logItemsLength
(libmeegotouch will naturally be getting a port too, btw)
Need just 2 blank lines here.
implying what?
Thirty-seven.
I just pushed in the change. Thanks for the offer. :)
There is no state maintained on the EDTS side, all breakpoint information is queried from the project node when the debug buffer is reloaded (due to entering an interpreted module) or when a new breakpoint is toggled, so only the project node has the whole truth.
Sure, both for Map and Iterable.
Returns a wrapper around a function that makes sure it's called not more often than a certain interval, but as fast as possible otherwise. Used, for example, to request new tiles on the screen while the map is dragging (so it doesn't do tile checks too often).
What do you want me to put in there?
You don't need these parenthesis, right?
The CMAKE build seems to find the library file, but not the directory sometimes. It seems to do this with the OpenCL and OCLM library, I suspect this is unique to Windows.
I concur with @Zidane's statement
Perhaps this should say "The service did not resume successfully"?
The description should probably include at least some form of the source and destination, probably.
My new unittest on rebuildBuild resulted in a failure when passing a extraProperties = None. extraProperties is tested for None and then passed to updateFromProperties where a None value is not valid. If extraProperties is not None it is not used at all This functionality has never worked (checked in 0.8.5). May be it is better to remove the extraProperties as nobody uses it.
Minor nit: We aren't consistent everywhere, but the preferred order for imports is `__future__`, stdlib, zope, twisted, buildbot. I'd include wokkel in with twisted.
this should also have ``format: uri``
typo on executs, dunno what you wanna say
Ah didn't realize this was for svg elements as well, thanks.  I'll stage this now then.
Is it guaranteed that buildDirectory ends on slash?
I am not familiar (yet) with systemd at all, but I wonder if in principle it could be possible to avoid pulling -- may be there is a way to "subscribe" to notifications upon new entries?
in ApplicationController it used in scope of current_user. In admin area it use global scope
@vsizov I'm going to merge this one
That would be an interesting way to do it, but for us to switch to custom app, it's usually just a few string replacements in the iFixit-Info plist. We have a script here https://github.com/iFixit/iFixit-iOS/blob/e35bca60ef6004cf6d51c796ffdb37bdaee25bd3/dozuki.sh that will toggle which custom app we want to use. I'm sure it's not the best way but until we start getting more custom apps, but for now it works.
Slight nitpick: no need for `.keys()`, iteration over keys is how dictionaries usually work. Also avoids a function call and a list creation (in Python 2).
Nit: Fix spacing around commas.
Another case of strange whitespace being introduced.  Why the blank line here?
Another question is whether we should use underscore on the beginning of compute_prices method. It's not meant to be accessed from the outside and at the same time it falls into the main inheritance overriding scenario.
less code is a good thing.
Please adapt to my code in memory.js and declare Cu at the beginning.
Why is this being done in index.php? Like I said before, index.php is simply for setting constants that could be required by system classes, and it can't be overwritten. What if they want a custom Router that is initialized in a different way, or no router?
already restore it to returning name
It isn't entirely clear what precedence applies to operations in this line; you should probably rewrite it in a way that makes clear what happens first (the `+` or `inject`) to people who don't expertly know Ruby precedence. :)
I probably should rename this to: `get_resource_by_reference`. This function tries to find appropriate Puppet::Resource. The reference can be a Puppet::Resource, Puppet::DSL::ResourceDecorator or a String. When resource is not found it returns the reference. It is used when setting parameters to resources in actions.rb `create_resource` and when exporting/virtualizing resources.
would you suggest constructing a new Hiera instance pointing to this file as a config file? I guess thats feasable, would need to see.  As far as actual duplication go it's actually not much.

Further I think is actually quick close to the patterns found in other backends see 

https://github.com/puppetlabs/puppet/blob/master/lib/hiera/backend/puppet_backend.rb#L46-99
https://github.com/puppetlabs/hiera/blob/master/lib/hiera/backend/json_backend.rb#L10-43

These code blocks is not particularly less complex than the code here - but I agree its not DRY and this stuff can be simpler but in current hiera code base there really isnt that much we can do about it.

I think the real problem here is captured in http://projects.puppetlabs.com/issues/10362 and only once we really address that can we end up with significantly better backends.
that's not correct. it's the plugin version and has nothing to do with it's dependencies
This isn't going to work, you want `use MooX::Types::MooseLike::Base qw(InstanceOf);`
Shouldn't this be Encoding::ISO-8859-1?
It seems to read as though that is backwards.  @pbadenski could you either clarify here or clarify the variable name(s)?
thanks -_-.
we already invoke this in the file
This looks a bit black-boxy to me. I could not decrypt that.

Additionally, mac should be String::Quote/d
@weierophinney 
It makes sense, but in the context of a view helper, maybe a lot of work for no real gain - you could do the above for other attributes such as style when it'd probably be just as easy for the user to build a classes string, or if they wanted an array, build it and implode.

i was thinking about a separate HtmlElement object that would have a tag name, easier attribute access, id getter/setter etc, as working on the table view helper has highlighted the need to build other elements inside a class that extends the AbstractHtmlElement but of course, such a class would become laborious as you'd need one for the many different html elements such as $table->addRow, $row->addCell, $formInput->getValue etc.
This changes the API, as it introduces an argument between existing arguments. The pattern needs to be the last argument.
@macnibblet What is the problem? I see this as a safe way to code.
```php
function test() {
    return 1;
}
function test2() {
    return (1);
}

function test3() {
    return (bool) 1;
}

var_dump(test());
var_dump(test2());
var_dump(test3());
```
int(1)
int(1)
bool(true)
parse error, a / to much :)
This should be `!(isset(...)) || ... != null` The aim is enable the check by default
Maybe `it "uses the slug if available"` and test the case where it exists, then the fall through case for uuid, and then the fall through case fro id.
Well the next two base packages are not separated by a line.  I'm not sure why Eclipse did that.  Perhaps it was part of my copy/paste from the original class?

I couldn't find any clear code conventions on how to format import statements.  Either we should remove the blank line, or add two more below to seperate the other base packages.

I think I'll leave it up to the Bukkit committer to decide...
Heh, oops, looks like I never tested this case. I'll do some rebase magic and fix this.
1 per page ? is it really the best default ?
@nervetattoo is on the right track with using return values (and I like the use of parameters for it, though we'd also need to pass other things), but the whole point of implementing initializers is to make them lazy, so doing them in a loop here misses the point. One of the main reasons for laziness is that currently, `'title'` has an indirect dependency on `'source'`, resulting in things being initialized more than once.

The better approach, instead of simply calling them in a loop, is to remove `$_meta['initialized']`, and rewrite `meta()` per the following:

```php
<?php

	public static function meta($key = null, $value = null) {
		$self = static::_object();

		if ($value) {
			$self->_meta[$key] = $value;
		}
		if (is_array($key)) {
			$self->_meta = $key + $self->_meta;
		}
		if (is_array($key) || $key === null || $value) {
			return $self->_meta;
		}
		if (isset($self->_meta[$key])) {
			return $self->_meta[$key];
		}
		if (isset($self->_initializers[$key]) && $initializer = $self->_initializers[$key]) {
			return ($self->_meta[$key] = $initializer($meta, $schema));
		}
	}
```
I've updated all the code here ;-).
Oh sorry, went dyslexic and misread `gcc` as `gfortran`.

The issue still remains that hard-wiring the compiler is very, very frowned upon. If the Juila buildsystem chooses to ignore user settings for `CC` and switches compilers on its own, then that is a bug that needs to get fixed upstream.

GCC will disappear from the OS X development tools soon and systems like OpenBSD are also experimenting with Clang-only builds so it is in the best interest of Julia to respect user settings for `CC`.
convoluted. Just use `if (!value.trim()) {`