Web Inspector: [Timeline] JS error when clicking in Memory Statistics view
https://bugs.webkit.org/show_bug.cgi?id=103486

Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2012-11-30
Reviewed by Alexander Pavlov.

The counter value can be null/undefined. Hence a check is needed
before we access the "time" property on this counter object.

No new tests required as UI related change.

* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onClick):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Finally remove webkitpy.common.system.deprecated_logging
https://bugs.webkit.org/show_bug.cgi?id=103624

Reviewed by Adam Barth.

Remove the deprecated logging module and its unit tests now that such logging is not
used anymore in webkitpy.

The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
The tee class is renamed to Tee to conform with the usual guidelines.

Only unit test for the Tee class is currently provided as the OutputTee is not currently
using the webkitpy Filesystem abstraction that would make its functionality testable.

* Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
(Executive.run_and_throw_if_fail):
* Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
(Tee):
(Tee.__init__):
(Tee.write):
(OutputTee):
(OutputTee.__init__):
(OutputTee.add_log):
(OutputTee.remove_log):
(OutputTee._open_log_file):
(OutputTee._tee_outputs_to_files):
* Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
(SimpleTeeTest):
(SimpleTeeTest.test_simple_tee):
* Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
* Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Page popup doesn't change mouse cursor
https://bugs.webkit.org/show_bug.cgi?id=97454

Reviewed by Kent Tamura.

The mouse cursor should change based on the page popup content and not the main window content.
On Mac the mousemove event propagates to both the page popup and main window causing the cursor to flicker.
The change to ChromeClientImpl stops that.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::setCursor): On Mac, don't update the mouse cursor if a popup is open.
* src/WebPagePopupImpl.cpp: Implement setCursor so the mouse cursor gets set based on the page popup content.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Unreviewed gardening.

Add expected results for a new test.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-11-30

* platform/qt/fast/ruby/position-after-expected.png: Added.
* platform/qt/fast/ruby/position-after-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Add support for prepare_docs and generate_docs

Follow-up to changes in Qt in how documentation is built.

Reviewed by Simon Hausmann.

* qmake/mkspecs/features/default_post.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Caret is painted horizontally in vertical writing mode when there are no visible text
https://bugs.webkit.org/show_bug.cgi?id=102359

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-30
Reviewed by Ryosuke Niwa.

Source/WebCore:

In the vertical writing mode the caret rect on an empty editable box or
an empty line is rendered as per the horizontal writing mode.

This changes though when any text is added; the caret is then displayed
in accordance with the vertical writing mode.

Test: editing/selection/caret-alignment-for-vertical-text.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
The caret rect should be transposed for the vertical writing mode. Its
width and height values need to be interchanged for it to be oriented
as per the vertical text.

LayoutTests:

* editing/selection/caret-alignment-for-vertical-text-expected.txt: Added.
* editing/selection/caret-alignment-for-vertical-text.html: Added.
Test to verify that the orientation of the caret on an empty vertical text
line or container is same as that for a non-empty container.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Unreviewed trivial fix.

Add empty.cpp back, it was removed accidentally by r129092.

* qmake/config.tests/gccdepends/empty.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Fixed use of to-be-removed compatibility functions in QWindow.

Patch by Samuel Rødal <samuel.rodal@digia.com> on 2012-11-30
Reviewed by Simon Hausmann.

* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::FullScreenVideoWindow):
(PlatformVideoWindow::PlatformVideoWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r136227.
http://trac.webkit.org/changeset/136227

Broke the Qt bots due to version mismatch

* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::FullScreenVideoWindow):
(PlatformVideoWindow::PlatformVideoWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Enable WebGL by default.
https://bugs.webkit.org/show_bug.cgi?id=103731

Reviewed by Simon Hausmann.

Source/WebKit/qt:

* Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):

Source/WebKit2:

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
TouchAdjuster move and fixup
Move event handlers to QWebPageAdapter
Move init code over to QWebPageAdapter

This simplifies things a bit.
We probably want to call initializeWebCoreQt *before* a first
WebCore::Page instance is created, but it seems like widgets-related
business can wait a bit.
move WheelEvent handler
DragAndDrop stuff
Moved context menu related stuff around.

As a consequence, QWebHitTestResultPrivate moves to libWebKit1.
Turn the static WebKitWidgets library into a QtWebKitWidgets shared library module
Avoid static library linkage into Qt5WebKitWidgets
Linking fix

Need to properly define and export a base class for QtPluginWidgetAdapater as
we subclass it and do qobject_casts.
Export the QString conversion functions of WTF::String as if they were exported WTF::String API