labofsahil/github-event-dataset-2012 huggingface dataset:
I can definitely change the val to value. is_a? and kind_of? are the same, correct? Either works for me, I'm not picky.
Ah ok, I may have missed the "complaining" bit :), no problem, as you said, it doesn't really matter either way.
Leave only one whitespace before the `#=>`
This var is not used, perhaps you can test it's type as well, to confirm it's a Topic?
This is unnecessarily inefficient, imperative, and mutational.  And given that you immediately turn it into a list, just make a list.

    val payload = List[(String, Any)](
      "versionFormat" -> versionFormat,
      "className" -> className,
      "methodName" -> macroImpl.name.toString,
      "signature" -> signature
    )
I tested L-BFGS-B and BFGS, but I will add more tests.  Any minimizer theoretically will work .  I left the default minimizer blank because it seemed more appropriate to let scipy.optimize.minimze choose it's own default (BFGS I think).  I'm tempted to make L-BFGS-B the default because it's significantly faster and more robust in my experience.  But that may just be the systems I'm used to working with.
With `count`, ActiveRecord performs the counting on the database using a `"SELECT DISTINCT COUNT(*) FROM "spree_products" …` which leads to a wrong result
I think that normal users are not granted permission to view items by default when using CanCan. CanCan is a whitelist system.
Should normal users be able to see return authorization data?
I'm afraid I'll ask for a less generic name again :-) `sim_subs`?
Please add a reference to the algorithm you are using.
I was just wondering why you were writing `assert r2._imp_(1.2)[0]`
instead of `r2(1.2)[0]`.
Again, 80 character limit. It looks like there are a few more of these.
Should we just make this l, r, c here so you don't have to do any more processing later in at L185? Also, it might be good to use strip and check that you got a valid alignment:

```
_alignment = {'<': 'l', '>': 'r', '^': 'c'}.get(alignment.strip(), alignment)
if _alignment not in 'lrc':
    raise ValueError('alignment unrecognized: %s' % alignment)
```
Please check out the new pull request.
@asmeurer , I believe you thought fiddling with spaces was a bad idea. Does stripping newlines seem ok?
Maybe you need to rebase.
Why limiting to these fields? What about, for example, `offset`?
PHPDoc's `@deprecated` [tag supports additional description](http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.deprecated.pkg.html). Maybe it would be better to slightly expand to the something like `@deprecated deprecated since 1.1.7.`? :)
There should be check for method name as well.
> This change causes that always a date value is set per default - even if no value is present. This is not desired in all cases

That is right. What is the ```isPostBack```?
The url is incorrect. The action is not appended to url for "index".
is it intended that a `datetime` object be accepted?  I think this might be confusing and perhaps should be removed (because `datetime` actual represents an actual moment in time, not an angle).
Can you comment on this?  Why is this needed for celery? Is there a reason to not just place these classes at module level, or is the Wrapper namespace needed for something?
Might be an interesting integration test at some point: Get an inventory of all MindTouch URLs from a DB export, run it through this redirect logic, see how many are hits vs misses against a kuma DB after a migration run. Ideally it should be 100% hits
These ternaries can be hard to read. Might be more readable to break them out as methods with if statements, e.g.,
```ruby
def local_template_source(name, options)
  if options[:source]
    options[:source]
  else
    name
  end
end
```
It's a bit more verbose, but the body of this main method should become a lot easier to follow.
Or you could return an object which has count and valid offset as attributes.
Please call this USER_NO_POSTS_DELETE now to make it clearer what it's for.
Should be consistent with information about style in my opinion. It looks like in the styles section we now link twice to the CDB, once to the section, once to the CDB index.
Null definition seems unnecessary.

`php -r "error_reporting(-1); class a { public \$b; }; \$c = new a; var_dump(\$c->b);"
NULL`
That is caused by inconsistent naming in the phpBB core, sometimes it is `foo_row`, sometimes it is `foorow`. These events are actually are named after the variable they are called on so it isn't strange that the naming is slightly inconsistent.
This is needed because to create the Symfony Request object (below) it uses the $_* globals, and expects an array. Even though the phpbb_request_disabled_super_global class implements the array interfaces, so it can be accessed like an array, it does not type hint as an array. As such, I have to enable the super globals. I did forget to re-disable them, as I assume we still want to.
I don't think we should advise to contact support. It might be a local network problem or something else.
Sweet, I didn't know that. I was looking at net module and I couldn't find it there :)
oh come on, its a float attribute, not a class. there is totally no difference between initializing lists and assignments for built in types but can definitely show if its a class typed attribute or not.
Yes, apparently :) I will consolidate that. I wonder if they will be different at some point!, not so sure yet.
sometimes we re-use perf variable for multiple timelines within the same code-path, segmenting the timeline into small pieces (like in "ActionContext" implementation), in which case there are 3 perf.done(); , and that just doesn't tell you which timeline is being closed, I find the name of the timeline to be useful to understand the code better. I do agree that half the sentence can be stashed, but still I want to know what timeline that code should be closing. Maybe we should pass a param that does nothing. something like: `perf.done('hb:render');`, in that case we definitely don't need the comment.
но так в итоге придется просуммировать всю таблицу с дневной статистикой(будет нужна инфа из каждой строки активного баннера)

нет, нода не будет писать в 2 места или преобразовывать. нода будет только апдейтить суммарные просмотры/клики. а крону тогда ничего не нужно будет практически считать, он просто будет брать разницу в суммарных просмотров/показов за прошедший день и за предыдущий и записывать эту разницу в таблицу дневной статистики.
3 таба, я хз как они туда попали)
Incomplete JavaDoc
Do this on all files
Why are these now being sorted?
There's another issue with this, which is that it's not clear to me what graph.variables is supposed to do.

For the code sample you wrote to work, it would need to not include "outputs", unless they are also intermediate nodes.
We don't want the gradient traversal to be able to "see uphill" past the cost.

I admit it would still compute the right thing, because initializing grad_dict[cost] with g_cost would block the traversal, but I think tensor.grad is easier to maintain if you are not depending on that happening for it to work.

So the question is, does graph.variables include "outputs"? Its docstring says it does:
def variables(i, o):
    """ WRITEME

    :type i: list
    :param i: input L{Variable}s
    :type o: list
    :param o: output L{Variable}s

    :returns:
        the set of Variables that are involved in the subgraph that lies between i and o. This
        includes i, o, orphans(i, o) and all values of all intermediary steps from i to o.
    """

However, when I ran it as a test, it doesn't:
>>> variables([y],[x])
[x]

I'd prefer to use my own function where I know what it does than to use something whose behavior doesn't match its doc. I don't know whether variables is documented wrong or is buggy.
Yes, you are right. The reason I did this is that I implemented Unique map first and add support for non-unique map later. I did not think well before doing it and changed the getCounterLET API a lot times. Fix it by reduce the unique case and do it as non-unique case because the only difference of them is the second parameter of getCounterLET() and getCounterGET(). For Unique map case, the second parameter means no difference. 

I should review the code by myself first after all the functionality is good. Thanks paul!
Perhaps -1 here feels a bit too much like a magic number. If -1 has semantic meaning here specific to functions, could we define it as a descriptive constant? Or at least decorate the places it's used with a few more comments.
In automated tests, yes. Per the comment, I was inspecting the generated tables manually using this code, which seemed good enough for testing test code, though it could be better.
Why do you need three separate forms to store a date range?
and what about when i search for the both i will need to make 3 checks to see which situation i have
any reason why the setter is 'public', while getter is protected?
Compiling with -DCYTHON_VECTOR_SIZE=X enables vectorization, with 4 meaning SSE2 (4 floats), and 8 meaning AVX (8 floats).

The new branch is called _array_expressions_rebased, but the py3k build segfaults with a refcount error. I still need to investigate that.
We could use the intersphinx ability in Sphinx here to link to the Python docs.
I know that LANGUAGE_COOKIE_NAME is the name of the cookie. 
I think that's the same name used in the session and in the cookie.

The string 'django_language' is in use only three times in the whole django tree... here and two more 

django/conf/global_settings.py:LANGUAGE_COOKIE_NAME = 'django_language'
django/utils/translation/trans_real.py:        lang_code = request.session.get('django_language', None)

The same or not?
But, if the model isn't registered in any cache at all, you don't need no dynamic cache at all in the SQLite backend. To me it seems you just need a clone of an existing model with alterations applied, but you don't want any other model to know about the clone. If the clone doesn't get registered in any cache, and the related models do not get altered by the clone, then you don't need any temp cache at all in the SQLite backend...
This comment is pretty useless
`unless` might be clearer than `when . not`.
No, this one is weird, it doesn't consider a cue timing without the separator a cue timing, so it depends on how you guys coded the internals. The error can be a big ambiguous.
Why are these specializations necessary?
In that case, if you think it could be temporary, let's call it _defaultDisplay to mark it as undocumented.
what happened to `$count = 1` parameter here?
Let's keep this as "parentNode" for readability.
Thanks. As the lmc_nid and lmc_fval are the minimum node id and feature value, i will change it to the following code. 
{code}
SELECT parent_id,
               min(id) as lmc_nid,
               min(tree_location[array_upper(tree_location,1)]) as lmc_fval
FROM %
GROUP BY parent_id
{code}
I'd like to see more comments here.  You only give the explanation about how to discrete the continuous values, but other parameters and behaviors should be explained as well.
There's no description about NULL for this parameter, while NULL is passed in the example.
word is spelled "privilege"
This is now `MacOS::CLT.installed?`
Thanks, I disliked that part also.
You do these ugly two-spaces-after-period thingy? *g*
this line was removed in a previous commit, don't know how the pull managed to put them back?
chars = pdu_opts['message_payload'].decode("hex")
?
I would say "when something goes wrong on the server side".
ja.. übersehn..
Please decorate this with `@unittest.skip("Test unwritten")` or remove the test.
Can the args stored here just be passed in normally? It's generally better to avoid **kw magic.
what about maxitems, maxrequests? Or the case where you expect to receive exactly one request (the original sep describes a returns_request contract which checks this).
Great! I'll rebase in a moment ;)
I was thinking of that as a later change - pulling these things all together into a more clear.

Also, you really really really like to have few files.
I'm currently a bit stuck - what's the motivation between sleep 5 anyway? I.e. what do you need to wait for?
* cellという変数のスコープがやたら長いです。日付の取得とcellの設定は記述位置を分けて、変数のスコープは極力小さくすることを心掛けましょう
Right. that's right. Thanks!

--  
Murphy Randle
Python Gumshoe & Git Enthusiast
http://www.MurphyRandle.com


On Monday, September 24, 2012 at 9:42 AM, Nick Ethier wrote:

> In src/model/productcontainer/ProductContainer.java:
> > } > > /** > * Validate that the ProductContainer is able to be saved into the vault. > */ > public Result validate(){ > - if(_name == ""){ > - return new Result(false, "Name must be non-empty."); > - } > - else { > - _valid = true; > - return new Result(true, "I said it was successful, but validate isn't finished."); > - } > + return new Result(false, "THIS METHOD SHOULD BE OVERRIDDEN");  
> The subclasses should do the validating such as StorageUnit and ProductGroup. Since the data is stored in the subclass its self there is no way for the superclass to do any useful validation. This is here simply to enforce the api.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/CS340Group/hit/pull/15/files#r1674285).  
>  
>  
>
Hmm.  For some reason, github appears to treat this file as if it were completely deleted and then re-added.  It makes it hard to pick out the diff.  Any idea about why this is happening?
Actually, it would be slightly more efficient to create an ArrayList of size classes.length instead of a Set. There shouldn't be duplicates.
The phrasing of the Javadoc for these enum values is inconsistent. Perhaps "Leaves the test methods in the order returned by the JVM. Note that the order from the JVM my vary from run to run."
Agreed, though even better would be to abstract scrollToElement onto the region, which I'll do now.
Why not throw an exception?
space?

I think
```
after(:all) { Chanko.config.exceptions_to_pass_through = @config_save }
```
is more better
If it's not too late, I feel like it'd be better to just pick one or the other of '/' and '.' rather than to allow both. That way if these strings are stored somewhere or written into code, they'll all look the same and be recognizable as the same thing. I guess generally things that are the same should look the same.
need to evaluate the entire block and see if the and array is non zero or not.  if it is, then yield {"and": <arr>} , else it's just {} - an and with a blank array returns the exception from elasticsearch.
For things like comments where it's trivial to reformat lines seems to be better practice to stick to pep-8 (80 char line lengths)
Not sure about these two--were those intentional? Looks like you removed these submodules?
Nice tests, thanks! However, I'd prefer `let` blocks over before/ivar combinations. For example:

````ruby
describe Muni::Direction do
  use_vcr_cassette
  let(:stop) { Muni::Route.find(21) }
````

Then in the example itself you can use `stop` like a local variable.
NO, the last default is wrong. This is already taken care in `redirect_to`. Have you checked where this value is from?
in the function definition... before we'd just overwrite it with "" haha
Can we order all of these options in the same order that http://www.jshint.com/options/ does? So it's alphabetical order, split into 3 sections: Enforcing Options, Relaxing options, and environment options.
you need the s back
lint complains with:

src/plugin/module.js: line 188, col 11, Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function.

If I do that :(
This could potentially be a method in the Entry manager (`Entry.by_user(user)`, for example), but possibly more trouble than it's worth.
should be `if (!('_shadowWidth' in this))`, ideally we shall use shadow to avoid branching.
These 3 lines are overwriting the variables you've set in your previous step.
add the ‘#’
It looks like you might not need this column, right?
Let's call it hadoop-job-runner instead
I think the simple refactoring would be fine--right now Linux is just "Unix that isn't OS X", which isn't true, but hasn't been a problem yet. I don't think we need to refactor the world yet; just DRYing this up would get the maintainability there and it should be good enough for now.
Keep in mind that we need to also support deletion changesets, so would also need 'current' environment (where current env is not Library).

e.g. assuming Library->Dev->Test

user w/ proper permissions
- can create deletion changeset in Dev & Test
- can create promotion changeset in Library & Dev
@alikins your indentation here is off which makes it confusing to read... or am I confused?
Implemeted..
This code should handle manifest.orientation but not like the old code.
The orientation backend has already landed, the only thing we're waiting for now is bug https://bugzilla.mozilla.org/show_bug.cgi?id=673922 that will let the content lock the orientation of the screen depending on the app setting.

You can just leave your comment as if for now but include the bugzilla bug number.
Include the table in a file in the "config" directory? Then, the user doesn't have to wait for astropy to update the values.
Just curious -- why is that?  Because all of the databases fail when `pedantic` is on?
Or even better, what is that 'tx' variable doing there at all?
Yes, you need to retain ipcInit as it is called. The others can go :)
It certainly works (both with - and ^), my point was that removing the
flags one by one when set gives needlessly verbose code, when you can
simply select a subset of the flags with a mask.
Default return would be a function param
done: http://trac.geoext.org/changeset/2886
> maybe if(Crafty.image_whitelist[ext]) would be even faster?

It's an array. Not a dict.

Are you suggesting to use the HashTable mechanisim for speed enhancement?
Normally I would agree, but we are dealing with very few entrys here, so it would not make a difference and if nothing else is not worthy the code-strangeness.

If not: I suggest reading this: http://blog.xkoder.com/2008/07/10/javascript-associative-arrays-demystified/
Missing line break before the function call
"month_ =" - this is rather a month start
I think this should probably be discussion.save! so that we get notified if the save fails for whatever reason
No longer relevant since we just copied in the whole data structure.
It's long, but go ahead and spell this one out to parallel the other locations - container_location_id
Erm, maybe I'm reading this wrong, but doesn't this mean that we still can't create objects without a parent? I mean, the exception is gone, but no entity is created or stored.
That a little easier to do with lstrip (that i didn't knew of), but if we start having special chars in completion, we might want to compute the `commonprefix` in the kernel and send it to all frontend with the list of completion, because right now, this seem to duplicate in every frontend.

What I can do now is compare the beginnig of the first and last word of the completion,  and check that both have the same prefix.
* `git_fetch_progress_callback`?
* `git_network_progress_callback`?
* `git_something_happened_update_your_ui`?
Can you provide an example of a partial that includes a function? I'll work on this some more tomorrow - nap time.
expected parameter was missing
We use "yesterday" in a bunch of places. We could just define it as a "constant" at the top of the module.
"Is this shortcut really necessary?" said the man that replaced it in a similar context just with the letter 'D'.    :-)
test 3 does an insert into the plugins  table where test 2 does not.
I just removed some duplication, so the same code than before is called.

According to my grep, that uses UncachedManagerBase, which in turn uses Django's Manager.filter

so I am not sure how this relates to no_transforms
20120424155606_create_logic_mappings.rb is meant
Small random detail - But I think the coding standards define lowercased boolean don't they?

@philsturgeon
If we also use param for script and lang, we don't need this if / else here, right?
but what about players that were not on the server when the first CUI user joined?
verging on useless!
should this throw rather than return?
Alright ... since also other characters are converted by rawurlencode, that one itself is probably a wrong default. How about having no custom logic here and introducing something better to https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php#L235, where I think it belongs.
missing empty line between the license header and the namespace declaration (in all files)
same comments apply as in DateType
`$this->defaultOptions->replace($option, $value)` then ?
Can there be a lock on an option that does not exist yet when normalizing? I don't think so. So you could move the `array_key_exists` check above `if (isset($this->lock[$option])) {` which saves a method call. Or as I suggested above put this logic in `all` so even save the method call to `normalize`. Somy tiny code duplication is prefered compared to slowing the code that is executed thousands of times.
It is, but it doesn't really matter :)
This is still broken if the setter has not been called
prefer 'with' usage
can we just define auth once?
Call this anchor an `identifier`, not `ID`.
A small correction; (a/d, b/d)
Actually, you should be using the time that the haproxy log said that that event happened, because it isn't necessarily the same as now.
This only includes the authentication classes if curl is available.
Y a-t-il une raison pour garder l'ancienne URL en commentaire ?
lets go ahead and rename all the `echo_data`/`get` params to `return_data`
@erikstmartin This code, too, is included in the Pull Request. It's based upon some very helpful code that John wrote for the original logger.
Yes. I'm sure there are other places as well. I need to write a script to regex some code words to test.
I think you can lose this return statement, too.  The usual pattern if you want your context manager not to swallow exceptions is just not to return anything at all from __exit__.  The implicit `None` return is then interpreted by the CM machinery appropriately.
This is not needed if you store things by line
Refactored in 261f594
`.andSelf()` enforces order, `.add()` does not. This is intentional, there should be a comment (and probably a test).
Now using button, implemented in 10732ed9523e939987bf1e1f74ce9ed54ae19716
nit: your indentation seems 4 spaces (should be 2)
I think that the lack of release might be a hypothesis for the artifacts that I hear with this approach.  Can we get a followup on file to implement a release phase?
It's a private variable Magic? The semantic sounds strange to me. :/
I know each module in System app trying to fetch the same setting at the same time is somewhat stupid.
Maybe we should let Airplane_mode module to expose that setting for other module.
Probably you need @pike or @stasm to approve changes on locales
For fixing the issue (with the new change, instead of disabling the `input` we are blocking `send` button until the message is sent, even if we go to other thread :S ) you should add `ThreadUI.sendingMessage = false;` in `cleanForm()` method of `ThreadUI`.
Sorry, last nit:
`additionalContactInfo` and `additionalInfo` are not working as variable names anymore (which one is which?)

Suggesttion:
`additionalInfoNode` and `additionalInfo`
... and so on.
any easier way to do this?
please place opening bracket on a newline
адреса можеби?
Ah - I already hate myself for this comment - because it is not necessary, BUT

´string = number.toString()`

because it is A faster (which is really not important here) and B more understandable. because that is literally what you are doing: you are casting it toString.
Maybe add a note that you should move the object code before this?
Added line to clarify what v2 is.
Add in a comment indicating why this method doesn't work - what's needed to fix it?
Extract this location to a string constant.
return

do you even test what you send me?
We shouldn't hard-code knowledge of any specific regions in the java code.  As this is at the moment, it will make it difficult to turn on any new regions without updating priam java code.
Right, both of these issues need more thought.  Regarding schedulers that run on all masters -- good point, and I think that will differ by class, rather than as a configuration option.  Regarding load balancing and failover, I think we might want to have a configured "priority" that allows schedulers to prefer a particular master.  Then users can either configure all schedulers to prefer master A but fail over to B, or configure each scheduler to prefer a different master.

I'd like to figure out a way to leave this open for later optimization, in the short term.
Here's one reference https://www.schneier.com/blog/archives/2005/02/sha1_broken.html for collisions in SHA-1.
I'm too, but since this locale is handled through WebTranslateIt this would just cause synchronization issues ;)
Is the let declaration part really important. Will it just create those in the global scope of the caller anyway?
Good point! I'll do that!
I totally agree that this constraint of being a synchronous API is confusing, but at some point we have to face this issue as we want `_("...")` method to be synchronous.
What I dislike in your proposal is that you are splitting in two modules something that should be the same.
`l10n/core` is the module reading locale files from the xpi and expose their data.
It sounds important for me that the code which read the files is the same that the one exposing their data.

Otherwise, I'm not sure playing with loader pseudo modules is simplier than a global variable in a module.
We can no longer do simple things like this: `loader.modules['@l10n/hash'] = { exports: Object.freeze(hash) }`, as `modules` property has now keys that are uri and not longer require path.

Here is an fork of this current pull request that split `core` module in two, as you suggested, but without the use of pseudo modules.
https://github.com/ochameau/addon-sdk/compare/master...bug%2F748114-alternative
It would also be nice to document in a comment (and in the "help" output for "create_perftest_project") what "small", "medium", and "large" are intended to mean. It doesn't seem self-evident.
version already calls build itself, so we can drop it from this depends list.
Hmm, not sure I understand. What concern do you have?
Please keep in mind that this will have to be updated with my changes on the other pull request.
(Reason being: I like control flow to look like Best/Good > Worse/Bad in terms of progression.)
__whimboo__ commented:
> Can we move up all this code ... ?

Because of the above detailed reasons, I won't like to make _implementation_ changes in `nightlyApp.getWindowTitleForNavigator()`.

IMHO this can't be moved up as You requested: 
 * `newTitle` depends on: this `try ... catch` URI stuff, `"titlepreface"`, `docTitle`
 * `docTitle` depends on: `modifier`, `mCurrentBrowser.currentURI`, `contentTitle`
 * `modifier` depends on: `"titlemodifier"` and the debugQA workaround stuff

I think it's too complex.
Of course I could be wrong.
another test for what happens when `/etc/release` is absent would be awesome (I am not a Solaris guy but https://github.com/cwebberOps/facter/commit/e1fc75e2f0669bd60e0b09a7a29ca23f8618ee8d indicates that an absent `/etc/release` is possible)
puppetd worked on 2.7, but isn't even present in 3.x, so this will fail hard.
Looks like we have multiple if value checks here. What is the behavior when value is nil? We should try to only have to this check once probably.
Ok, I've split the method into two; that solves this problem :)
I'm of the opinion that the code is easier to read if the RD is built outside of the returned tuple.  E.g.

```erlang
RD = wrq:set_resp_header("content-type", "text/plain", ...),
{Body, RD, S}
```

Also, why is the body both set explicitly and part of the return code?
Ordering is presentation layer. Constructing order clauses isn't. You're constructing a scope, aren't you? And ActiveRecord even provides scopes.

--  
oleg dashevskii
Отправлено при помощи Sparrow (http://www.sparrowmailapp.com/?sig)


среда, 25 июля 2012 г. в 17:11, Anton Petrunich написал:

> > @@ -102,8 +109,10 @@ def export_filename
> > "phonebook-#{Time.now.to_s(:number)}.csv"
> > end
> >  
> > + # FIXME ordering code belongs to model
> >  
>  
>  
> Ordering it's representation. One model can have different ordering in each action, so, i believe this code should be a part of controller.  
>  
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/solenko/phonebook/pull/1/files#r1233660
>  
>
css classes need to be space separated instead of comma separated.
Why did you remove the study ("S") modifier?
@Unh0lyTigg Oh, I'm aware of that, but that breaks pull conventions.

@EdGruberman Yeah, no lines in imports, you can take a look at any of the current classes to notice that. ;)

Also, Bukkit commiters don't tend to change Pulls that much for convention, instead they generally just tell the request-er to do so.
This class references ZfcBase\Mapper\DataMapperInterface, I think it needs changed to ZfcUser\Mapper\UserInterface
agreed, it also supports target="_blank" but I agree data-external would be the most semantic
->

```js
tasks push: {
    title: trimmedName,
    completed: false,
    id: id
}
```
Could you add a comment at the top of this file indicating that it is the version used for the Symas benchmark, that there is another version of the file at db/db_bench.cc? If you'd prefer I'd be OK with adding SYMAS_CONFIG #ifdefs to the code that is in db/db_bench.cc
this probably won't work long-term since some other contributor might have a different path..  There's probably an environment variable like $WindowsSdkDir that works better.
it won't make a huge difference here, but I consider it a good practice to always include the dimensions, so it won't become a problem when you have multiple issues like this
Je, ved chceme prehravat nekonecny loop:).
maybe this could go to a blogpost on blog.getpelican.com?
Style inconsistency: sometime you have x=y and then x = y and x =   y
I suggest to rename this to set, so you'll use env.set in easyblocks
I would prefer to leave this section and remove it from the "What is it?"
It is more likely to be overlooked in the beginning section.
gonna get a clown hat to go with my clown shoes
The reason I had to add this Document class is because the authentication command sent to MongoDB has to have the keys encoded in the correct order. Ideally I wanted to use plain Object type to create command structures to send to MongoDB, but because Object is a dynamic class the properties can not be iterated in a predictable order, so I made this Document object w/ the put() method. 

Do you have any suggestions for an alternate solution that would let the driver enumerate over keys in an ordinal manner?
@tenderlove: The call in `_run_suites` only uses the first value, but if you look at the project @bhenderson linked to it uses both values.
Didn't see that. Nice catch.
It might make sense to add a helper function (perhaps to `utils/probability.js`) that returns all the permutations, then you could do something like:

    <div class="set-sol" data-type="text" data-each="permutations([a, b, c, e], 3) AS P"><var>P</var></div>

Where `permutations([a, b, c, e], 3)` is a function that returns an array of all the permutations of any 3 of `[a, b, c, e]`.

The `data-each` will insert multiple `<div>`s, that way you don't have to list them all. Also, `4 nPr 3 = 24` and you've only listed 18, so there are a few missing.
It looks like `Element.getBBox()` returns `undefined` if the element was removed.. Apparently before it would actually return something (and we never checked)
The reason the null check is here is so that it will make `obj[i]`=null if the doc is null. Not sure what the desired behavior would be in this situation. If I remove the null check `foo_obj`=null but `foo` still contains the id.
Ember required 2 times.
I wonder if DocumentChanges should be an interface so that these mutator methods can't (accidentally) be called by the connector. Ideally, the connector should view the DocumentChanges as immutable (even though the implementation may not be strictly immutable).

Plus, the "withX" name seems out of place; normally, we use "withX" methods to return a new instance (e.g., "that object equals this object with something changed") while it doesn't modify the target object. (Look at ExecutionContext, for example, which is immutable but has "withX" methods that return a new copy of the ExecutionContext with several changes.
I do think this should use the non-cached version if acceptable.
The article still hasn't told me what exposed events are!
please don't use the ``_`` for protected and private properties. This is a coding standard inherited from PHP 4 and Doctrine stopped using long ago (even if code written before is still using it because of BC)
訳とは直接関係ないですが、こちらのファイルタイプは`javascript`ではなく`html`が適切だと思います。
@patrickallaert this was also my first impression while examining the original pull request [1] but @joaoinacio is right. And to be honest, I don't want  to change the behaviour of `eZURLAliasML::storePath()` which is already ugly...

[1] https://github.com/ezsystems/ezpublish/pull/383
The isset behavior seems good. We need to allow people to remove option by setting it to null.
Two useless lign here.
When I ran the test, this assert failed because the page returned " - What's this?" instead of "What's this."  Please update this and then I will merge.
has this been reported to sqlite upstream? if not, it really should be - it sure doesn't sound correct that running into an exceptional condition can't be handled at all by the caller
КОРТИНКО
This part doesn't look quite right... Some lines are superfluous and to much is copied and ifdefed.
Why apply the roll/pich to the setpoint instead of the current yaw?
And now you actually apply the yaw command when you are not in_flight as well... at least for quads this is not desired.

Probably a good idea to factor a couple of things:
- functions to get the current yaw and sp as quaternion
- pass the quaternion to which roll/pitch should be applied to as an argument
 - you can pass the saved yaw quat for "care free" or current yaw
why should ``init_error`` or ``best_error`` have type DTYPE which is the dtype of the data array? Either use np.float32 or np.float64. I tend to use np.float64 whenever possible (i.e. when memory consumption is not an issue).
Maybe the right thing to do is to set it to `Level/ALL`. The intent of that is to enable all logging, which I think is what we want. It should presumably be equivalent to `Level/DEBUG`, but semantically it's more accurate. And it's defined to be the lowest possible log level, and so we don't need to do any comparison, and can just unconditionally set it.
I don't know about doing this without deprecating first. You can use this functionality to warn the user:

```erb
<% if content_for? :before_javascript_libraries %>
  <% Refinery.deprecate "content_for :before_javascript_libraries", :when => '2.2', :replacement => "content_for :javascripts" %>
  <% content_for :javascripts, yield(:before_javascript_libraries) %>
<% end %>
<%= yield :javascripts %>
```

It complicates the view but is somewhat necessary.

Also this means you have no way to specify the order so you need to put all libraries inside `application.js` -- correct?
Usually, we move the validation into a separate test underneath.

e.g. in this case it would be a

```
it('verify create comment validation')
```
Needs to be further down.
A contexts utility function to create a mock context based on a user id might be useful?
Why don't you write `failAsValue(classOf[NumberFormatException], classOf[NoSuchElementException])` then?
Grammar Nazi: "You must send at least 1 argument to msg" s/arguments/argument. This is in several locations. Ctrl+F
My point is that `make test` and `npm test` should be equivalent, yet they're doing two remarkably different things now.
Some stupid goof in cleaning whitespace sometime over the past year. Read: OOPS!
The styleguide doesn't really touch on this...but should long function / class arrays be double-indented like this was originally?
No, that fixes the line ending problem. I did a re-fork and put the changes in for some classes. The other I just put in a 100% new file.
Пересмотрите пример в лекции. Проверка `if (self)` была введена не просто так.
Ну, это значит, что что-то пошло не так и необходимо либо отчитаться об ошибке, либо обрушить приложение пока не повредились данные :)
та же фигня
В своём проекте вы всюду ставите вручную цифру 100, и отталкиваетесь от неё. И в этом методе, в частности, по умолчанию считаете, что раз символов в последовательности 100, то можно просто посчитать, что 1 процент - это один элемент. Ваше право, конечно, однако смею заметить, что такой подход некорректный. 

Вот представьте ситуацию - допустим, что класс Cell создали не вы, а какой-то другой программист. Причём сделал так, что вам доступен лишь заголовочный файл Cell.h, просмотреть "внутренности" методов вам просто не удастся. Ок, вы сейчас знаете, что в текущей версии класса используется 100 элементов. И решили написать собственную категорию, которая позволит вам изменять х процентов последовательности. Если опираться на действительность, то всё ок. Но вот - класс изменился, новая версия, в ней элементов уже не 100, а 300. Но вы об этом даже не знаете, вот в чём засада! И продолжаете менять в своём методе только х элементов, а не процентов.

Отталкивайтесь от того, что мы помимо обучения, должны получить определённые навыки и привычки в программировании. Задавать какие-либо неизменяемые в объекте элементы как константы - очень даже хорошая привычка. Например, можно с помощью #define в заголовочном файле Cell.h задать константу, в которой будет храниться количество элементов  в последовательности:

```
#define DNACapacity 100
```

И использовать вместо "магического" числа 100 вполне себе осмысленную константу - DNACapacity. Понадобится откомпилировать объект с другим количеством в последовательности - нужно будет только изменить значение этой константы.

Но вернёмся к вашему методу mutate. Алгоритмирование в наш курс не входит, однако алгоритм выбран не самый удачный - с ростом количества элементов на замену количество итераций в методе будет только возрастать. Но есть один очень важный недостаток - нет проверки значения передаваемого параметра. На данный момент среди студентов данного курса я встречал два вполне нормальных подхода: ограничение возможных значений с изменением значения параметра на корректный и генерация исключения. Ни того, ни другого здесь нет, и методу можно передать значение 200, и тогда он войдёт в бесконечный цикл на стадии заполнения массива индексов intArr. Я уж не говорю о том, что метод не реализует строгого изменения х процентов последовательности.
Окей, пожалуй переключусь на использование проперти (хотя после лекций/документации в инете - не видел особого смысла использовать - геттер я сделал свой, а памятью в любом случае управляет автоматически что в случае проперти что в случае c alloc/init)
В любом случае, спасибо за замечание :)
Two items? Why not just a lute?
It seems like that'd make subclasses like `RACAsyncCommand` really awkward. We'd have to have async implementations of both subclasses :\ (Is this where someone chimes in about favoring composition over hierarchy?)
Same here, `change_password_url`
that's to be consistent with the other function createInputStream(in).

On Tue, Apr 24, 2012 at 10:20 AM, Raghu Angadi <
reply@reply.github.com
> wrote:

> > @@ -86,7 +87,16 @@ public CompressionInputStream
> createInputStream(InputStream in,
> >
> >    @Override
> >    public CompressionInputStream
> src/java/com/twitter/elephantbird/mapreduce/input/LzoBinaryBlockRecordReader.java(InputStream
> in) throws IOException {
> > -    return createInputStream(in, createDecompressor());
> > +    // Ensure native-lzo library is loaded & initialized
> > +    if (!isNativeLzoLoaded(getConf())) {
>
> do you need this?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/kevinweil/hadoop-lzo/pull/1/files#r727564
>
you should do this with string formating

```
"%d%d%d%d" % (kind, type, size, next)
```
it's wrong as you baseline afterwards :-/ ...

what I suggest is to create an _apply_baseline function and then compute vmin and vmax and then plotting.

btw can you send me a screen shot with colorbar as I don't see it :(
why inverting the logic of boolean indexing? indices should be where the True entries are.
forget it. Removing these comments
Ah, yeah, good catch, I would suggest to simply raise an `ImproperlyConfigured` exception in case there is no "default" index configured. It's the bare minimum for the app to work, so we should be upfront about it.
Was this file actually changed, or is a line ending oddity?
iirc, Saptarshi wrote the ext:modifyColumn extension because the normal one wasn't working for all databases.  We should use that everywhere until liquibase fixes theirs.  Can you open a ticket to fix the other changeset?
> (err error)

There is no other use of named return values in this library, so try to conform to the surrounding conventions and do not include them here.
Aah, I see there's already a file source thing that you want to support.

How about you simply rename this to SoupBinTcpParser and leave it at that?
You can change this to:

    attr_message = humanized_attributes.keys.sort_by {|a| -a.length }.detect do |attr_name|
I'm not overly concerned about the names for the demo (I'd prefer it better named, but not end of the world), but for the *actual* code behind in the `MessageBox` proposed here, it uses `btn1_Click` and `btn2_Click`, which need better names.
What was the reason for changing the visibility?
This admonition isn't rendering properly either.
Today  I happened across  the iterable filter in twig http://twig.sensiolabs.org/doc/tests/iterable.html

thus we can remove 'is_loopable' filter and  Functions.inc.php

The null test can be remover too this filter already exists http://twig.sensiolabs.org/doc/tests/null.html
Removing the previous code changes the behaviour of the class completely. The removed code _stopped searching_ after the first find. The new code does not. I don't think that is intended, especially as this class is used for multiple purposes (GPX and map files).
This shortcut seems handy at first, but unfortunately it breaks compatibility with the standard CSS font specifier. For example underline belongs to text-decoration, not font-style.
this look like a syntax error.
This won't work if `pred?` is `nil?`. And using `remove` is a bit cheesy :).
`(set (concat ...` on sama kuin `clojure.set/union`. Lisäksi `#{#{element}}` on turha, sillä `(map joint-set subset)` lisää `element` alkion tyhjään joukkoon.
Tästä ei ole enää mitään hajua miten tämä toimii :). Ajatushan on siis valita joukosta alkio, laskea loppujen potenssijoukko rekursiivisesti, ja sitten lisä valittu alkio jokaiseen saatuun osajoukkoon ja lisätä nämä uudet osajoukot rekursiolla saatuihin:
~~~clojure
(defn powerset [a-set]
  (if (empty? a-set)
    #{#{}}
    (let [elem (first a-set)
         pset (powerset (disj a-set elem))]
      (clojure.set/union pset (map (fn [s] (conj s elem)) pset)))))
~~~
Damn IDE save actions :(
vmin -> dmin etc. for consistency
@efiring I think you meant an `=` instead of a `-`.
This change introduces a typo.
I think that should be a separate issue because: 
 - The current patch solves the bug where .desc attributes weren't exported, and 
 - In the GPX.html tests, \<desc> is a test element in every literal xml fragment, as can be seen [in line 49](https://github.com/candeira/openlayers/blob/6ec50ecc8099ebf3bab71f85ccc87074c204ad17/tests/Format/GPX.html#L49) and several others.

My suggestion is to leave this commit as is, and open a new issue for the CDATA patch, which would also have to update all the literal xml strings. Then the CDATA/textnode issue could be discussed separately from the .desc attribute export issue.
This was completely rewritten in #263, so this isn't an issue any more -- it uses hex encoding now rather than `db_input`
Sorry? Is this a joke? As far as I'm concerned, someone who's willing to suggest something so patently awful has no business going near any standards whatsoever.
addressed in 7018e40 - it's more that the data are more familiar and the query is more illustrative of actual use
I verified that InstanceState startup tags are never used; however, I figured we might as well keep them up to date and consistent with CookState anyway -- a nice side benefit is that this lets us simply update CookState with InstanceState in its entirely, as opposed to overriding the value of startup_tags.

I think startup_tags in the long run should go away, and we should draw a simple rule that the instance agent does not make use of tags. (Or if it does, then it should do a fresh tag query every time they're needed.)

I suspect that other pieces of InstanceState are defunct, too ... just more tech debt for us to consume in due time.
I was not aware of this fact and usually just copied the widely used operatingsystem pattern, but osfamily sounds much saner. I did notice that you need a relative recent facter version (1.6.2) because some servers that weren't fully updated (I know, bad me) were missing the fact.
@bp323 done
Will do.

I hope Mou eventually gets support for a visual page guide so that I can see long lines.
We don't currently use this script for production, so it doesn't matter.
Can these either be just 'title' or 'translation_title' ?
We're not space limited so no need to abbreviate translation
I don't understand. I mean, I assume you didn't write all these cookbooks but grabbed them from somewhere. I'm asking whether you can commit the commands you used to grab them to the repo and then .gitignore all of these extra files. Does that make sense?
Those tabs... I changed my emacs html mode to spaces only finally.
I can do that, seems fair. Didn't think of that though, because I just wanted to provide a basic Reader implementation first that can be used as a Decorator when accessing JSON files. For a production code method, one might also want to think about a better approximation for the array size, though I guess it's ok for now.
A trait is more generally applicable than an abstract class. You can mix in multiple traits into one class but only one parent (maybe abstract) class. Mostly just traits are used and abstract classes only seldom if mixing doesn't make sense at all. Here the ability "this is a type" is more a characteristic (or a trait) than a parent and this characteristic of being a FtanType could also be used for other classes (for example we develop a different way of defining types later in a different class hierarchy. Or say we define a class FtanTypeElement which is a FtanElement and a FtanType. Since FtanElement is a class, this would be the parent class. The characteristic of being a FtanType couldn't be added, if FtanType also were a class.
Are you sure ``$method`` has the correct type as ``*`` is not a sub-type of ``string``? Please also check line 76.
How about making the return type a bit more specific; maybe use ``Select``?
How about making the return type a bit more specific; maybe use ``array<string>``?
Lastly, if you could revert back to the previous next('span') selector and replace span with label - this will get rid of some unnecessary code (see comment on line 110).
hast du das schon ins rest dokument eingetragen?
we also have `license`, `export` now
`count` can be expensive, but you could define `f` as `(fn [x] (filter (complement pred) x))` and then check `empty?`.
Mind cleaning up the duplication between this one and add_patches while you're at it?
So this passes the context down to a datastore... in what cases is it used? What datastores recognize this parameter?
Why did you change the spacing on these three lines?
please import this globally in the module; local imports like this should be avoided unless they are expensive (lots of deps) or necessary due to circular dependencies between modules
i guess so :)
опять отступы
Space before `(` in `function(data`. Put all arguments callback can receive there.