labofsahil/github-event-dataset-2012 huggingface dataset:
could you add an "update failed" message too?
Is this alright? I would have put: "be_true"
I was picturing that situation, you getting errors emails every time. Made me wonder why that bug was still there. :-)
Bad merge, removing
Great catch - didn't think about the WKT spec on xy/latlon ordering.
make this readonly and new it up inline instead of using the ctor.
This hunk is in the wrong place. It should be after the other `JSON_*` decoding flags.
>starkos is always talking about finishing 4.4

Right, but premake-4.4 is premake-stable. It has nothing to do with master for ~ year.
For the time being I am removing the need for 'owner'. Will explore this and get back to you with a fix later.
Regarding the *should*, the current page is the user documentation (I plan to have a separate page aimed at developers). Do you still think this guideline should be in the user docs here?
This function head is calling the app env the capability but in higher-level code the capability is `{App, EnvVar}`.  This is confusing.
Also include a link to our page comparing these three?
http://wiki.basho.com/MapReduce-Search-2i-Comparison.html
Yeah that will be a problem.  I wasn't sure if we were still pinning Haraka to node 0.4.x.  If there was some sort of conditional dependency logic we could totally do this.
Agree with @laanwj
I would say it's even sufficient to add the time once in the RPCConsole constructor, via ``ui->startupTime->setText(QDateTime::fromTime_t(GetTime()).toString());``, or should that stay in ``RPCConsole::setClientModel``?
Ok will remove all the array_keys within the foreaches
You are not supposed to use `debug()` in test code to check variable contents. Do you you see such debugs anywhere in the other core tests? Use *asserts* in the test cases to compare the validation errors property against expected data.
Isn't this normally CakeTime?
well, not that easy, i am afraid - it uses format() - and its doc: "integer $options if int then places, if string then before, if (,.-) then use it or array with places and before keys"
so it can be multiple things at once (which I dont like by the way)
probably want to get rid of this line if you stick with the change to the line below.
not for closures, at least in PSR-2
Instead of a list, perhaps have it be a dict with the grade as the key?
Does this seem to be an accountID? if so, it should be account_id
`fonts_to_download` is leaking globally
not sure if I'm reading this correctly, but this means that $model->title would override $object->getTitle(), right?
Opps, you removed the `locate_profile` above so the function fails with a `NameError`.
Do we really need critical logging of this and below on L257?
I don't think the 3.2 failure is anything to do with this pull request. If you want to change this case for consistency, I'll run the tests again and merge this.
If you want to do it safely, you should put it in the context manager or try-finally clause.  I'd put chdir in the TemporaryDirectory, if I need to do that.  Should I?
I think this import is no longer necessary.
This is another general bugfix. Before if you were using the object options syntax you would be adding object-style properties on an array, and the length of the array would always stay 0. Apparently array["foo"] doesn't change the length of the array... go figure.
Yeah, ok, let's not go this far. You can have more than one argument per line. :p
|stop b2g| delivers SIGKILL, but I'm not sure if it's delivered to the entire process group.  It's fine to be safe here though.
No need for this file. `apps/morzorg/tests/__init__.py` does it already.
Ah, you should put the referer into a variable and check that it isn't `None` before checking the `endswith`.
this could use a comment explaining what it's doing.  the expected input value, and what you're converting it to.
What about these ones?!
comments added.  going ahead with the merge.
I don't like that this line creates 2 vectors. Also this should be using subself.
Name not meaningful here. `$li` is singular. `$listContent` may be better for instance
minor style note: if you reorder the clauses you can remove the guard. Moreover, since you will only ever see Checksum as binary or none you could do:

    {ok, Checksum} -> Checksum =/= none % or is_binary(Checksum)

to collapse the two clauses. It is fine as-is.
I have made another group to prevent overlapping between the ellipse and the names.
Well, I don't think that a library should involve itself in the request/response flow. That's a Controller's responsibility...

We don't know why some developer calls the ParseAndVerify method, but even if the URI can't be parsed or verified, it *may* not be the HTTP client's fault. Thus, if I were that developer, I'd be mightily annoyed that the method throws that particular exception. In my opinion, an ArgumentException would be much less surprising.
Who is this? I don't think we've met.
Why does the request start in the `end` method?
In the general case, this came from the spec, which supports 8/16 bit indexes, and 16/24/32-sized entries, although, in the end I ended up with only adding in the 16-bit version of Color-mapped-files, I guess I could have supported the 24-bit variant with a palette...
indentation issue (tabs?), extra space inside the braces, and wrong naming for the variable
@jmather It is **not** a boolean. You are setting ``1`` or ``2``. A boolean is ``true`` or ``false``
drak: Well, it is a matter of whether you want this component to be generic and reusable elsewhere or just cater for your other component needs in Symfony. You might not need the headers at all in your translator component, but the question is if that is true overall to a component that wants to be a generic PoFileLoader.
why? it does not for me.
Are the original assertions in the tests still executed? It must be, otherwise we could not really test if the methods behave in a BC way.
@stof ping
missing array type hint
Haha, the first developer issue that is revealed by this change: see #5396
Style: remove semicolon.
Actually I'm a little concerned about collapsing the view all the way to 0. This can cause some unintended side effects with `NSViews`, if I recall correctly. Up for discussion here: should this only collapse the view to 1px, then hide it if the destination was 0px?
done. StringEntityManager might give the misleading sense that entity itself is a String though. StringColumnNameEntityManager is too long.
Never, ever use get. Use pattern matching and actually manage the error case - even if it's throwing an exception, at least it could have a relevant and informative message for the use to understand what he can do to correct things.
This actually *looks* lonely, all on it's ownsome.
Also, the training comma on the previous line is unwanted.
I wonder if we need to consider the version of the shapefiles too? Maybe we should address that separately as it also applies to the Natural Earth shapefiles.
The documentation is out of date (`ops` and `options`).
Error on Eclipse :/
It's not possible as the data format is not the same, I have removed the id check... as its fixed in [PR #39](https://github.com/dingproject/ting/pull/39/files)
Also, at this point if you do not have an `app` object defined in the global namespace, this code will just throw an exception. If you are not sure about `app`s existence, use an if block, use `window.app`.
There is a dedicated plumbing command to check if git can find a useable git directory.
That is not correct, the dependency specified here is met by the security subsystem not the EJB subsystem.

To reach this point the end user has configured that a realm is going to be dependent on a jaas domain supplied by the security subsystem so it is correct that this dependency needs to be met for the realm to be able to start.
this test should be removed in favor of the other test.
I'd like you to add some javadoc to explain why we have this class and your name (@author) for posterity ;-)
你总要说你这样做的原因，你把100人民币定成10刀也好20刀也好，有哪样根据，或者说有哪样优点（当然，除去不需要额外开发的优点）。 

我认为汇率换算在跨国交易里面是一个比较重要的模块，通过实践，我们都可以从中学到东西。并不是简单粗暴的说我就要两个价格。

你只需要加一个参数，定一个换算系数，不管你定成6，还是10，你相把100人民币换成10美元20美元都可以做到，并不需要往domain和数据库里面加任何东西，就可以完全实现你手动写两个价格的同样的效果。带来的好处是，明显扩展性更强。

以上是我想这样做的原因。我觉得特别简单，而且顺理成章，你咋个有点喜欢在顺理成章的事情上这么苗。

如果你坚持要这样做，你肯定需要说明这样做的好处。而这样做的坏处，我已经给你讲哦，就是程序看起来非常不得扩展性。如果我以后要支持paypal和支付宝以外的支付方式，比如说日本的公司提供的支付方式。是不是又要改程序，加一个日元价格。
this should be turned on use DEBUG=1
and this should be `keyboard-frame`
Do we really need to wait for the onload event?
We need to do more here I think, when we know the account removal has started we need to "abort" the currently running transaction.
Have you talked to UX about this change? IMO UI with a **Confirm** is better, but they need to sign off on that.
I don't have an strong opinion about this, but just to keep the same format, could we do it like } else { ?
yep, good point. All the app needs to be l10N. Is that a blocker for landing? I would prefer to land, open an issue and then solve l10n in a follow-up PR, What do you think?
I don't really understand the search algorithm or the trie data structure it uses.  I notice, however, that later in this file, the buildTrie() function goes through the prefix character by character, adding nodes for each character.  How does that interact with the code here, if you now store multiple prefixes of the same word in the index?  How does the resulting trie change?
nit: use brackets for if/else
The indicator of the current enabled layout is missing from the style.
Some tests with negative numbers would be nice as well.
Yeah, but the only alternative I could think of was throwing which also doesn’t seem right.

I could decouple the response generation so that there are two steps.

From: David Ebbo [mailto:notifications@github.com]
Sent: Monday, December 24, 2012 16:36
To: projectkudu/kudu
Cc: Henrik Frystyk Nielsen
Subject: Re: [kudu] Updates to the git-backed VFS controller (#276)


In Kudu.Services/SourceControl/LiveScmEditorController.cs:

> @@ -371,6 +387,28 @@ protected override HttpResponseMessage CreateItemDeleteResponse(FileSystemInfo i

>              return response;

>          }

>

> +        private async Task<HttpResponseMessage> GetLock()

> +        {

> +            int index = Interlocked.Increment(ref _delaySetIndex);

> +            int[] delaySet = _delaySets[index % _delaySets.Length];

> +            for (int cnt = 0; cnt < delaySet.Length; cnt++)

> +            {

> +                if (_operationLock.Lock())

> +                {

> +                    // We got a lock and can continue

> +                    return null;

> +                }

Not very intuitive that returning null means we got the lock :)

—
Reply to this email directly or view it on GitHub<https://github.com/projectkudu/kudu/pull/276/files#r2499407>.
Hi Luke,

I like the fixes, apart from this change.
Why com.jolira instead of org.stoval ?

regards,
                               Paul
Rename to `reflectRedirectedUrl` and move the function down to underneath `reflectNewUrl`.
If we describe a special case I like starting it with the word `'when ... ' `- it´s more intuitive to read, e.g `when ... it should ...`
I have tried this out and it does work just the same, and it cleans up the methods a bit. It will allow for a slight refactor later to add flac, mp4, or OGG later.
Like before, this shouldn't catch `Exception` - it should catch a well-defined Exception subclass.
As above, please use more descriptive error messages.
Added a todo(mdw) for the unit test (either I will get to some of these next week, or you can reassign this later).
It's the output of `Snappy.deflate('<body>hi.</body>')`. I should have just written it as such. Will do that before/if we merge this.
Ok, cool - just checking :)
Though you check whether pool_name and pool_target in params dict, but these 2 parameters could be a invalid value (empty string, Nonetype, e.g.), They all could make following codes failed.
def addopt(k):
    tmp = optget(k)
    if tmp:
        spice_opts.append("%s=%s" % (k, tmp))
agreed - asDict is a very ad-hoc function
The _addBuildsetForTrigger is dependent of having  'sourcestamps' to be at least {} not the trigger method as the trigger method just passes the sourcestamps value. Therefor I placed this here.
But it's not a big thing I'll make the change.
The unit test looks good.  Should there be another -- using the same data -- to confirm that sampling without replacement generates a sequence that becomes all NULL after the known GeoHashes are exhausted?
This should rather be `in_array($link->getTarget(), $b->getNames())` otherwise you don't take into account provide/replace. Same below obviously.
Ok, nevermind. I added this to scripts/add-hardware and made a explanatory comment in buttons.h. That should do.
May be you should find a way to make more fast check? (Without memory allocation for each message)
Makes sure that the number will always be parsed in 10 base:
https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/parseInt
to test the changes.
+1 for this simplification
I don't think so, this help is actually referenced from the core and not from the plugin - the same help file is used in Maven Builder and mavn-plugin
Just to clarify it's fine to keep using JRequest here, just not its checkToken() method.
Ah. So this is that whole "return it is already in there" thing? Yes?
prefer `stmt.executeQuery(sql)` (parentheses)
Why "var board = this;" ?
At the end I have in any case to open a channel (because the `charset`), and in the callback based on the `result` call the `readInputStreamToString` (because the `charset` mainly) or reject the promise. I just handle directly a `channel` because the code involved wasn't so different and I don't need to pass as source anything different than a `channel`; so the code will be more consistent with the rest of the file (`readURISync`).

I do not have hard feelings about that, I can convert to `NetUtils.asyncFetch` if you prefer. It should be mostly the same, I don't expect problems.
@seanmonstar - The original reason for not using an external template for templateManage and templateUser is because we did not include the external templates on the main site. All templates are now included everywhere to provide a common set of templates for error/wait messages and tooltips. 

Since a large change is already necessary here, now would be a good time to make a simplification and remove the manage_account specific hokiness. These templates could be moved to external files and normal rendering mechanism used to display templateManage and templateUser.
Emphatic +1. I was wondering if anybody else would have found value in abstracting those out for general re-use.
according to memwatch, it costs us  "size": "930.64 kb" of memory to cache all of our locales.
you're right.  the correct thing to do here is to use cachify and embed perma-urls into the html document.  that way we remove an HTTP transaction in the cache-full case for IE.
Looks good. Just one more thing. What about the overhead when for each node the Function object has to be created? Wouldn't it be better to define a named function outside of the loop and assign it directly?
I wouldn't put this into the same block as module requires. Also 'const { NetUtil }' isn't necessary here. NetUtil.jsm automatically gets the NetUtil namespace.
would like to see managing temp files a function that can be called from any script
already remove it from repo
You should go through and make sure your comments match the name of the class.

Does this exist *only* to support Pry?  (eg: does ruby-debug, etc, work fine without it?)
Hrm.  This duplicates Nick's comment.

No, I didn't.  This is only called internally to this object, when it delegates from the instance method to the class method.

Since all the callers already intern, and since they *need* to intern in order to return only symbols to their caller, there wasn't any need to duplicate that behaviour here.
This is pretty unintuitive.  Most readers will assume that assignment overwrites, not extends, a value.  You should probably not do this.  A better way is, likely, to simply expose the empty array, and allow natural operations by the caller:

    foo.ruby_code << proc { :blah }

...rather than the unintuitive...

    foo.ruby_code = proc { :blah }  # no, really, this appends :)
makes sense
new code is based on your fork. this is deprecated
```ruby
app.files = files | app.files
```

Though it's a mistake to include teacup files directly, so it's safe to assume no duplicates
I expect this to be < 1ms of impact for most workloads - but why not.
almost this entire function is duplicated logic
this might as well be string-only since .grep() is for regexps
Not sure about this addition, nor the following methods. While I get why you've added them, the problem I see is that they are not part of the interface, and thus we cannot rely on them being present when writing helpers. These either need to be added to the interface, or removed.
This can be done in an additional PR. It's not relevant for this particular PR.
One of those should be an alias, right? For example postredirectget -> invokable for FQCN. prg -> alias for postredirectget.
It's because there's a DateTime class in the same namespace.

On Mon, Nov 19, 2012 at 8:28 AM, ArtigianoDelWeb
<notifications@github.com>wrote:

> In library/Zend/Form/Element/DateTimeSelect.php:
>
> > @@ -0,0 +1,314 @@
> > +<?php
> > +/**
> > + * Zend Framework (http://framework.zend.com/)
> > + *
> > + * @link      http://github.com/zendframework/zf2 for the canonical source repository
> > + * @copyright Copyright (c) 2005-2012 Zend Technologies USA Inc. (http://www.zend.com)
> > + * @license   http://framework.zend.com/license/new-bsd New BSD License
> > + * @package   Zend_Form
> > + */
> > +
> > +namespace Zend\Form\Element;
> > +
> > +use DateTime;
>
> I don't now why, but there is a conflict here.
>
> Cannot use DateTime as DateTime because the name is already in use in
> Zend/Form/Element/DateTimeSelect.php on line 13
>
> This use DateTime as DateTimePhp; worked for me.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zendframework/zf2/pull/2947/files#r2166752>.
>
>



-- 
Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/
Suggested names: value, min, max, increment, hold, speed, disabled.  Also remove onChange callback - instead just do this.$element.trigger('change') and the calling code can listen for that event.
Can `.Tags` be null?
while( I do agree++ ), your original is not that clear either, since the prefix operator is not that much used.

This would would probably be the most obvious:
`for( var i = 0, l = tasks.length;  i < l; i++ ) {`

But care, this is only nitpick, do whatever you think is best ;)
interesting, haven't thought about making it responsive.

though need a few improvements in 570px:

- make the todo container will the whole width of the screen, no margin on each side.
- smaller todo text
- less top margin, maybe even just remove the whole `todos` header?
- don't use ellipsis overflowing, users want to read the whole todo
- don't center the filter bar
moved that here https://github.com/alunny/cordova-plugin-spec/issues/6
May be use 
RDEPEND="${DEPEND}
list of additional packages here"
can you put this in a separate function?
Maybe use `self.updatecfg('makeopts', 'install')` instead, such that parallel building can be/is used?

At first sight, this looks very weird.
Rebase issue.
fixed, destructive copy/paste
it's a piece of sh....

i should have done it in clj, 

anyway, you give it a java command line invokcation : `java -cp bla my/class`

and it spits a aspectum perf java invokation: `java -javagent ... -cp bla:aspectum.jar ...`
`The Mozillians workflow...`
Could we also test that an empty cues start is the expected, defaulted value?
Add back in ```var id;```
Would love to raise it (the code would look a lot nicer) but one of the goals is that it's easily installable on webhosts. What we should do is add a specific TODO comment and then refactor them once we decide to support 5.3 as the lowest version.

I'm still undecided if the cost of supporting 5.2+ is worth the upside.
I can't think `content` is suitable name:

* `fixture`
* `target` ( to check)
* `script`
not that important in this case, but normally we also add a down migration.

I'll add it when I merge - thanks!
Our parent POM uses the JBoss parent POM, and should already be at 1.6 compatibility. Why was this needed? Was a different version needed? If so, do you recall why?
It looks like this file was out of sync with the changes I recently made to it. This set of changes is also removing a feature that was recently added.
You are right, missed reverting this.
for the standard user used for tests on jenkins, there will always be something already marked as favorite, but for new users, there probably wouldn't be. i fortunately already fixed the part where, because action chains are flakey, we asume the menu isn't there, go to firebug and click on a locator which is supposed to favorite-it, but actually un-favorites it (because the same locator does both things and we weren't checking a second time).

so we can create a _assure_there_is_a_favorite_app(), but it'd probably still end up with the same logic in it. sometimes, tests just have preconditions.
Not sure whether he wants to use "Issues" on Github. The forum seems to have been working fine so far. Just because this feature is not disabled does not mean you should promote it like that.
Ok I'll do that, makes more sense
Ignore this please :-)
Whoa, a trailing semicolon :)
Would \n work on windows?
Please revert this one and line 1945, otherwise it's good. :)
I'm not sure why we're looking for a number here.
Это почему еще?
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
да. спасибо. разобрался. в лекции об этом говорилось. теперь закрепил.
Раз уж Вы пишете комменты на английском, пишите до конца, словарик откройте )
I've changed this to do through each position, but my VM has internet access blocked for now.  I will try later to get it online.  Also removed the extra line that's a carryover from where I borrowed the code (exiting the game through quit).
Can you use `django.utils.html.format_html` here?
When is `$ref` missing here? I can understand removing `$db`, as it's optional, but reference objects require `$ref` *and* `$id`.
:+1: Just want to say that this test is awesome. :sparkles:
Nitpick: <strong> is what you want here. <b> is deprecated.
is ca_file/ca_path going to be obvious to users? Can we prefix with ssl to provide context
gofmt will align this, and put whitespace above it.  Same for most of the documentation comment that offset a separate "chunk" of code.
`git://github.com/libgit2/TestGitRepository.git` *should* work
The resource *description* is exported, not the resource itself. Maybe this should be clarified?
Don't forget the periods at the end of lines
why not keeping in csr?

if it's relevant to keep as coo I would add a comment
> use tempfile see #247

we need to find a better way then auto generated random tmpfiles as if
you run the tests many times it fills up your disk. Happened last
night on the build bot…

PR welcome on this...
> why not just preload if not allready and then deepcopy? we then could omit the keyword? i can look into this. wdyt, single PR or as byproduct of ica?

if you copy with a memmap preload how are you going to name the new memmap file
if you don't specify it copy?
sure. but be warned, no channel_types ;-)


On Tue, Dec 4, 2012 at 1:59 PM, Alexandre Gramfort <notifications@github.com
> wrote:

> In mne/viz.py:
>
> >      """
> > +
> > +    if scalings.keys() != units.keys():
> > +        raise ValueError('Scalings and units must have the same keys.')
> > +    else:
> > +        plot_channels = sorted(scalings)
>
> let me know when you commit
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/214/files#r2305614>.
>
>
Please replace the multiple var statements with a single var statement:
```
var job = {
   title: item.title,
   description: item.description,
   publishDate: item.pubDate,
   link: item.link
};
jsonObj.push(job);
```
Looks likes you're not resetting the other relationship types in the for each loop
pkg/pe/rpm/... maybe?
This is really less readable than the previous version.

We should probably move the "Metaclass" aspect to BaseFactory, and use :

```
  if PY3:
    class BaseFactory(metaclass=BaseFactoryMetaClass):
      ...
  else:
    class BaseFactory(object):
      __metaclass__ = BaseFactoryMetaClass
```
this is the only change to the command
No compact only removes nils
You mean something that would default on `ruby --version` ?
`its` - no apostrophe :)
you should provide the other formats too
This is still true (except that `src/autoload.php` doesn't exists, it should be `app/autoload.php`)
如有必要，总可以
What's up with the obuscation? At minimum, please do something like this:

```scala
  private def stockDirectory(buf: ByteBuffer) = {
    StockDirectory(
      nanoSeconds              = buf.getInt
      stock                    = readAlpha8(buf)
      marketCategory           = MarketCategory.withName(readAlpha1(buf))
      financialStatusIndicator = FinancialStatusIndicator.withName(readAlpha1(buf))
      roundLotSize             = buf.getInt
      roundLotsOnly            = readAlpha1(buf) == "Y"
    )
  }
```

I'd do something like this, though, to avoid overhead of converting fields that the user doesn't need:

```scala
  private def stockDirectory(buf: ByteBuffer) = {
    StockDirectory(
      nanoSeconds              = readInt4(buf),
      stock                    = readAlpha8(buf),
      marketCategory           = readAlpha1(buf),
      financialStatusIndicator = readAlpha1(buf),
      roundLotSize             = readInt4(buf),
      roundLotsOnly            = readAlpha1(buf) 
    )
  }
```
The `ByteBuffer` part is pretty much obvious from the return type.
There are quite a lot of commented out println statements in the patch that should be removed.
Removed all but message.  It might have been structured that way to allow the sender to reconstruct and resubmit the message, but I suspect there's a better way to do that than pulling it all out of an exception. Will wait to see if anyone screams...
run the n.is_Rational first: it's very cheap compared to the other queries, and once you know it's a Rational you know it has a sign so those test are not necessary. Wait...do you mean `n is negative OR (n is a positive fraction)`?
Пробел бы перед открывающей скобкой и после запятой (и в следующем коннекте тоже).
Ya nombrábamos CS antes y también en otros documentos, por eso me pareció adecuado, por ejemplo:

> Los roles del sistema se corresponderán con grupos de Active Directory del dominio CS según el entorno:

Igualmente lo puedo cambiar fácil, ¿te sigue pareciendo conveniente?
@Naenyn -- My bad!  Those interfaces are in fact different.
add "private" to be consistent.
I don't see the problem here; if the level is greater than expected by the later tests, it will just print a larger table.  If it is smaller than expected it will print several '{ ... more }' placeholders, which also indicates the issue. 

But it might be possible to make a change local, see comments [here](https://github.com/Olivine-Labs/luassert/issues/29#issuecomment-11529179) on a similar issue.
Could you please add the tag 'title:' here like we did on 'titles' branch?
isStemmed()

as this method return a boolean
Whether `prepare` takes the `*args` and `**kwargs` or not I still think it's importand that the first three lines of this dispatch method exist. I want to be able to call methods like `get_object` in my prepare method without having to do any extra work - and these may assume that `self.args` and `self.kwargs` exist. Otherwise there's no point in the prepare, it's just overriding dispatch.
I am verifying translations with command "./main/project/localization/findmissingtranslations.sh sk". For me it's easier to see missing translations: 0 than find out there are some missing translations but they are same with english one and doesn't need to be included.
Moved above. See previous note.
Will file_names be nil?  If so, split will fail.
what's the "cacheNameToCreate" field used for?
These should all be final to ensure initialization in the constructor
yes, this is picky but, can you add a space before :data, :toggle, =>, "modal", :vimeovideoid, =>, and video["id"]
22 days ago ;)
I was just guessing. Seems like node should have support for OS independent paths by now.
PEP8 does not say anything about list comprehension. What @WeatherGod mentions is that a break should occur after a binary operator (and/or)::

    if (something_very_long() and
       something_else_ver_long():)

and not before::

    if (something_very_long()
         and something_else_very_long())
как минимум стрелочеки не с той стороны
Accident. I'm going to make both ```HTTPRequest``` for both CacheRead and CacheWrite.
Alt tags are properly showing up. Could also be leveraged for tooltip.
the class is called NullLogger
Let's just drop this trap instead of commenting it out
@jsloane `$.toJSON` has been removed from the codebase, we should use [JSON.stringify](https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/JSON/stringify) instead.
Apart from that I'm not sure whether we actually need it, can't we just do this:

```javascript
if (data.results !== currentData) {
    currentData = data.results;
```
The value should be loggedin here
@christianv I have core.autocrlf set to true, so this shouldn't be a problem (and hasn't since I set it). It'll be easier to redo the changes so I'll do that.
NICE_DENSEFEATURES???

I think something like BUFFERPROTO_DENSEFEATURES or BUFFER or PYBUFFER_DENSE etc at least remotely match the name :D
Nice method!
I have some worries: This stuff is really hard to overview due to all the recursions. On the long run, I would rather produce all combinations and choose a random one - simply because that reduces the chance of an implementation error. (The computational costs of producing all are not that large since parameter trees are small)
There are many cases of parameter trees to have in mind and now there are two places where one has to be extremely careful: this one and get_combinations. But for now, since get_combinations doesnt work, lets keep it :)
The rand function is ok btw
Ahoj, jsem doma.

Moc nechápu, co myslíš. Já neměl žádné tvoje schedule. Když jsem psal timer, byl v Kalistu nějaký schedule. Ten jsem musel změnit, protože původně obsluhoval přerušení časovače, které musel začít obsluhovat timer. A abych neměl rozbité Kalisto, tak jsem jenom upravil scheduler tak, aby využívalo timert. Ale v tom původním Kalistu, kde se mi zdálo, že to funguje. Znovu říkám, já se nesnažil něco předělávat v tvém schedule, to jsem zatím ani neviděl. Já jenom upravil původní Kalisto tak, aby se přidáním timeru nerozbilo.

Opravdu jsem nechtěl modifikovat tvoje schedule.
What stability is 1.1 at?
Yes, this! It fixes the problem I'm having.
On this line, `$.fn.get` is used, and on line 66 direct array access is used. For consistency, one style of direct element access should be used throughout. I'd recommend array access unless there's a strong reason to prefer `$.fn.get`.
Sure, just did this in 2035af0cccdb1305233a7cd356bcf596f74829b9.
Is there any way you could make the retry count configurable?
It is  SHA1 at this moment hard-coded. But it may be configurated, methinks. So 255 stays.
I commented in the .less file as well.
On Dec 6, 2012 3:50 PM, "Philip Schatz" <notifications@github.com> wrote:

> In css/ccap-biology.less:
>
> > @@ -562,6 +559,9 @@ div.end-of-book-solutions {
> >   * Index
> >   ******************************************************/
> >  .index {
> > +  text-align: left !important;
>
> I meant can you include a // comment next to "!important" explaining why
> it is important. This applies to all the other comments I made.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Connexions/oer.exports/pull/33/files#r2341906>.
>
>
I had attached a file to my message, but maybe google groups does not
support file attachments...
Please find the same file here:
https://www.dropbox.com/s/yzwxarn9p98rong/ewf-next-filter_20121108.diff


On Fri, Nov 9, 2012 at 10:25 AM, oligot <notifications@github.com> wrote:

> In library/server/wsf/router/context/wsf_filter_context_handler.e:
>
> > @@ -17,8 +17,8 @@ inherit
> >
> >  feature -- Access
> >
> > -	next: detachable WSF_CONTEXT_HANDLER [C]
> > -			-- Next handler	
> > +	next: detachable WSF_FILTER_CONTEXT_HANDLER [C]
>
> I don't really understand : what do you mean by the attached diff ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/EiffelWebFramework/EWF/pull/15/files#r2080975>.
>
>
I was going to ask how to produce a PKGBUILD but then I read line 35. On line 35 you should mention where the PKGBUILD is located.
- Are you sure the method ``filterLoad`` can be called on ``$this->filter`` (of type ``object<Assetic\Filter\HandlebarsFilter>|null``)? I also found this on lines 73, and 95.
- Are you sure ``$this->asset`` has the correct type as ``object<Assetic\Asset\FileAsset>|null`` is not a sub-type of ``object<Assetic\Asset\AssetInterface>``? I also found this on lines 73, and 95.
Why no taunting as well?
I know, 5.8 should just die already, but I'm still on Ubuntu Hardy, and I don't see any 5.10-specific features in your code besides `//` operator. Can we get rid of it?
Add a comma after environment.
could you register ``Doctrine\Tests`` here ?
This breaks if the predicate is something like `nil?`:
~~~clojure
(boolean (first (filter nil? [1 nil 2])))
;=> (boolean (first [nil]))
;=> (boolean nil)
;=> false
~~~
These I'm not sure I like.  The others I'm fine with.
Yes, it'd be best if we had a consistent way of managing all JavaScript libraries, which would provide a way for admins to specify CDNs of their choosing. I was trying to avoid addressing CDNs specifically, since I don't know whether that has a good enough shot of making it into core.

Perhaps now would be a good time to revisit the JavaScript library manager concept. I'll create another branch that implements that, as well as jQuery.
Since this class now extends JFormFieldText, it falls back on the setup method there, so it should have access to the $placeholder property
Since this is a restartless addon, be sure to unload the JSM in shutdown() via Components.utils.unload(...);
There are alias overriding on [line 55](https://github.com/korjavin/oh-my-zsh/blob/a8d795872989ddce5bbda0926f5ebca1d769ff6b/plugins/debian/debian.plugin.zsh#L55)
Doc please. At least have a `@see {@link ...}`.
But `getAssignmentsForHIT(task.evaluation.mturk_hit_type => task.mturk_hit)` might be nil or empty, right? (If no judge has yet responded. I forget which it is.)

Yeah, multiple Turkers can answer a specified question. We don't currently have this functionality in Clockwork Raven, but we should. (it's possible through Mechanical Turk's self-serve platform)
I would try to do it. I think (from the code), that you have to do:

```
user = models.User(
    username=self.cleaned_data['username'],
    first_name=self.cleaned_data['first_name'],
    last_name=self.cleaned_data['last_name'],
    email=self.cleaned_data['email'],
    gender=self.cleaned_data['gender'],
    birthdate=self.cleaned_data['birthdate'],
)
user.set_password(self.cleaned_data['password2'])
user.save()
return user
```

goes to `form.save` method (you have to define it). Then in `form_valid` you do:

```
result = super(RegistrationView, self).form_valid(form)
auth.login(self.object)
return result
```

And this should be it.
Two spaces. One space missing before `{`.
Do you understand difference between `mongoengine.DateTimeField(required=True)` and `mongoengine.DateTimeField`?
that dot looked like stain on my screen :)
Import only modules. So import just exceptions. And then access through that.
Always use quote key/label names as strings, not bare like this. So `'center'`.
You can make this more readable with using normal if-sentence. Return `''`.
You added just JavaScript and not also the CSS and icons?
I guess you could simplify this slightly:

    class Helper < PayflowLink::Helper

Unless I'm missing any potential issues with not using the absolute constant path here.
Tabs @ EOL
In that case, you would not use the configuration from the bundle but you would directly set the seed provider in the security configuration.
Include information about election here
We likely wouldn't specify a version as this changes too often. We'd probably just test against latest stable version.
I meant only to move it so that the jspFile version of the registration would also go though this check.
Done.  If we read() 0 that means the pipe was closed by pagespeed and the request is complete.
Because I was using `ngx_int_t` as a return type I wanted to make sure no one later tried to return `NGX_DECLINED`, `NGX_DONE`, or one of the other status codes.  Better would be just to switch the things I'm calling to return `bool`s.  Done: 1709532
Arf... I see now. It should be:
sessionSettings.cache_size = cache_size ? cache_size * 64 : -1;

I missed one. You can fix it in the same patch.
The problem with this is that you're redefining the array on each iteration instead of only once.
See comment above. Again, I think butting the required shape of endog in each of the functions is the best bet.
What kind of syntax is `Array.new(size=15, obj="")`? I'm afraid I've never seen passing arguments like that in ruby. And as far as I understand all you need from that array is 5th element that you retrieve in the next line. Is the any point of creating an array at all in that case?
minor thing but would be nice if we cleaned up 'unless !' => 'if @..."  to make them all consistent
Docstring above!
Please align the variables in the docblock.
Is there duplicated code between this class and the from parser?  Can these classes be more DRY?
those need to come out.


On Thu, Nov 15, 2012 at 11:42 AM, msweaver <notifications@github.com> wrote:

> In
> Product/Production/Services/DirectCore/src/main/java/gov/hhs/fha/nhinc/direct/DirectMailClient.java:
>
> > @@ -155,7 +155,10 @@ public void sendMdn(Address recipient, MessageProcessResult result) {
> >      public int handleMessages(MessageHandler handler) {
> >
> >          Session session = getMailSession();
> > -
> > +        session.setDebug(true);
> > +        session.setDebugOut(System.out);
>
> should these be here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CONNECT-Solution/CONNECT/pull/174/files#r2140962>.
>
>



-- 
Michael Landis
Software Engineer
www.5amsolutions.com | Software for Life(TM)
phone: 866.526.6042 x774
email: mlandis@5amsolutions.com
skype: mlandis5am
maybe lose the second dot? ;)
You don't seem to be setting the scale in the returned image here.  Do you want the default scale=1?  It may not be a problem if you are keeping track of dx separately, but I just wanted to make sure you've thought about it.
I suppose a tab/space change, not sure
You can push new commits to a PR, no need to open a new PR each time (though I think with the line ending thing it made since to have a new one).
Yuck to auto-generated hashCode and equals methods! Understand that it required less code for you to write, but it's certainly more code to maintain.
I like `return Objects.hashCode(additionalOptions, commands, hardware, hardwareId, ...)`
I think that when trying to show examples we should put the code in 
brooklyn-examples or some such. The top priority for test code is to be 
clear and maintainable IMO.
Worth including a FIXME or something, so that IDEs / searches will find that there is something here needing addressed.
Note to Scott: this should be reverted because the page won't be seen anyhow and leaving this text will make it easier for SG to use the code.
bah franchement si. tu peux pas balancer des affirmations comme ca sans les appuyer sur des chiffres. c'est donner le baton pour se faire battre au cas ou ce soit faux, et c'est vraiment choquant. Moi quand je lis ca je me dis (preuve?)
I don't think this is required now that we use Bundler. Historically, this just means to prefer the system installed rspec ahead of rubygems's version.
IIRC, this was removed in a previous PR.
Always using the new `_getRoute()` means that themed files will not have the correct URL's generated.  At least based on my reading of the changes the urls for themed assets will be `styles.css?theme=red` instead of `red-styles.css` so the static generated files will not be found.  The test for this behavior was removed as well (line 474 for helper tests).
Ah! True. Arguably you can do things like this:

```python
def test_something(self):
    BrowserIdBackend.User = SomeOtherThing
```

However, this issue only really matters if the instances of the class go into some sort of stored state. Which they don't. They're just classes. 

So, r+ on this issue.
Use `dict` here to create a copy, otherwise you're just modifying the root one.
`self.assertEquals()` does much better job print out the difference on stderr if the test fails.
A lot of console.logs in here.  Those should probably be removed for production.
Maybe cache the result  of `Ember.keys`?
Don't think you need this second ``save``
You're missing a comma after this line, causes a syntax error.
this is .bak file better to add a correct file
Change the name of recursiveTimeout to cycleMessages...
It's probably worth having a patch where you reapply the const to the stdperiph lib.
This could be an alias. Also, it makes no sense as far as I can tell.
I'd expect that the hex string be padded with leading zeros if the length is 1, or not a power of 2.
I don't think we expect the highlighter to work for chrome docs, but there is lots of code to do chrome in the inspector. @paulrouget what should we do here?
I think, we do not need to create copy of string if "thisString" is already converted.
add to this that the default value for click_arrow is True?
this is a copy from XBMC? can we just add a method to XBMC's API if you need this?
how are you using this?
I have a suspicion that this won't work on Windows, because you cannot open a file twice.
Cosmit: it doesn't hurt to use full english words for variable names `threshold_indices `. It makes the code so much more readable for the newcomers.
done :smiley:
good catch. I'll fix it in the next commit, coming soon.
we usually add the license too
as current_module is ``linear_model`` you need ``:class`sklearn.lda.LDA` ``
`Y /= np.sum(Y, axis=1)` is better for readability :)
Where is this function used. I must be dense, but I don't understand its use.
> It is entirely consistent that two labels both have a 90% probability of applying to a given sample. 

Yes, makes perfect sense!
I really dislike this kind of trailing backslashes
You could rewrite this as

return ( node_id in self.names_to_nodes
        and any([isinstance(n, ast.Name) 
              and ... )

taking advantage of the parenthesis to write multi-line code
точно? тести назва яких починається з "_" не виконуються
probably should be a global constant of a class-level method on `Room`
return (radius <= maxMeasurementPointRadius && radius >= minMeasurementPointRadius);
getClass.isInstance should NOT be necessary.

player.getEntity().getController() instanceof MinecraftPlayer

That should be all that is needed.
As I mentioned on the other PR, I would leave this out of this repo.
It's leftover code as originally I was planning to print a diagnostic that says 'property' rather than 'function' if a function is a property function. I'll fix this.
just replace file_time with (longlong)om->file_time
Déplacer la fonction dans l'objet
Ok. I don't see it as a big issue to have this manual either. In fact I use the web UI. Maybe worth adding the commands you are using to https://community.jboss.org/wiki/ReleasingHibernateSearch so that we can learn as well ;-)
I thought we concluded that distribute,SKEW does NOT keep the order.
I don't like this pattern of returning a const char * from a function that takes a StringBuffer reference - it is liable to encourage callers to hang on to pointers to the data after the StringBuffer goes out of scope. It also tends to fool the caller into thinking the original StringBuffer that is passed in is not modified by the funciton.

In some cases, we have found it useful to return a StringBuffer& from functions that manipulate a StringBuffer, though here I suspect you would be better just returning void.
if the code is useless , you should remove it, not comment it.
I think something like this is also a better solution:

```
class UnroutableResource < StandardError
  def message
    "Un-routable resource"
  end
end
```

and you can always change the `initialize` to accept more arguments and use it to build dynamic message.
The click event could go in the post_view.js, I guess, which would be the systematically correct place for it
In fact in first case I meant to say if "you omit error handler, the error will propagate to `bar`". Would that make it clear ?
I'm in favor of `require('url/io')`. It sounds to me that we should move at least also `url.fromFilename` and not only `url.toFilename`. What about `resolveResourceURI`? Could be considered in the same category? Moving these functions could clean a bit `url` module itself. I think we should add a "deprecated" warning in `url` module for a while, but then we could easily remove them.

Is `require('url/io').read` good enough to understand that is a local URI? I named the function as I proposed before for the moment (`readLocalURI`), copied the approach used by @Mossop in bootstrap to have mostly the some code even if duplicated.
this is just an assertSame
This is an important file, I think keeping it for 30 days is not long enough. Change to 365? (same in other files, of course)
依赖与 -> 依赖于
We probably want a sanity check here to ensure that one or the other was provided, not both and if both *were* provided, raise `ValueError` complaining that `template_name` is not `None`.
I have already added for loop
This will not check the elements on the last page because the next button is not visible on the last page :)
Why not just store as an array of numbers to begin with instead of all this manipulation?
Why not install the client in the default recipe?
The "world domination" comes a tiny step closer ;-)
Bug, fixed and directly pushed to upstream.
Agreed, it's probably a bug.  But fortunately it's an easy one to work around.  I don't think anything needs to be removed from `allUniforms` because the first element uniform (`whatever[0]`) is treated as an array of size 1, and later element uniforms are added to the `UniformArray` created for the first element.
So where do we draw the line with inconsistency between the JSON and javascript versions? Right now the only inconsistency is in the base materials with the `source` field, but that wouldn't be a problem to anyone else unless they have an external shader file and are writing the material in JSON. 

Now we will allow not having quotation marks around properties and also using string constants. Do we also make a constant for `agi_defaultImage` and `agi_defaultCubeMap`? Should the sandbox examples avoid these JS shortcuts and constants?
Well, never mind, I dont know how to implement this using Array.filter() either:( Sorry. However, Array.filter() is doing exactly the same thing as `select()` defined below. So we don't need `select()`
I kinda think that this is more readable but I have no issues with changing this to the pattern above. For camel case, do we still require the 'test' prefix even if the @Test annotation is being used?
String.replace matches on the first instance in this case. You need to use a global regex to match the whole string. e.g.

"a/b/c/d".replace('/','_')
results: 'a_b/c/d'

"a/b/c/d".replace(/\//g,'_')
results: 'a_b_c_d'
Use a heavyweight window for winRoot and we can see that tabgroup.close() works.
Is there some reason to not condense this to

```
UIView* headerView = [[self tableView] tableHeaderView];
[headerView setFrame:[headerView bounds]];
```