labofsahil/github-event-dataset-2012 huggingface dataset:
Yes, that is exactly what caused the merge conflict: it was an l10n patch by stas and kaze.  I'm glad you caught the incorrect 'cardinuse' string later on.  I had seen that, then when I tried to fix it, I couldn't find it, so I convinced myself that I was remembering something from the other branch...
Please use a two-space indentation everywhere.
I have to check which alarm item is needed to remove from DOM.
that syntax is imposed by the Oauth protocol thus I would keep things as they are
setAttribute('mozbrowser', 'mozbrowser'); 

It's not pretty but someone told me this is the html5 way of doing it.
Since you have changed the background image of the .folder-scoller-region and according to the visual design,
https://www.dropbox.com/sh/2tmvc7qyxmxba07/otjHdKf0kM#f:Email_drawer_vpg_V06_0001_01.png
We can also change <strong>.fld-acocunt-selected</strong> and <strong>.fld-folder-item.fld-folder-selected</strong> to fit the visual.
try
<code>background-color: rgba(0, 0, 0, 0.5);</code><br><code>font-weight: bold;</code>
This is needed for avoiding iframe border. I will change the selector to make it clearer
add a line break about (i will skip the comment afterward)
no need for this blank line.
Do we really want to do this? In fact, the refreshing bug of the Call Log has to do with this bug https://bugzilla.mozilla.org/show_bug.cgi?id=814684 If we land this code proposed by @arcturus , once 814684 is solved we may end up refreshing the Call Log twice, one because of this new code and another one because of the mozvisibilitychange event being notified to the Communications app (see https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/dialer.js#L278 )
Yep, you are right, at some point wanted to decouple the fact that icon an app are tied, will recode to remove this.
The leading `#` sign is used to mark the whole line as a comment, please remove it (here and in other files).
I added tracing, but only when we actually need to create the file, so that it doesn't always show up.
ok, we can live with this.
Oh.. I just realized that is not necessary ...
Use relative imports here please
In what way is this broken?
So presumably this will break if I try to join a pipe of ```(Int, String)``` and ```(Long, String)```?
Still need a more descriptive name here, and document the params you're passing in.
Erase this line, since it isn't doing anything.
I'm sorry to keep spinning you in circles. I goofed on the line 527 reference. On line 243 of formula.jl, you can replace:

    return hcat(dfs)

with 

    return hcat(dfs...)
You need the threadID when replying to a thread, but we need to remove it otherwise, so

```coffeescript
    # prevent errors
    if threadID is 'new'
      threadID = null # <--------------------------------- this
      if g.BOARD in ['vg', 'q'] and !reply.sub
        err = 'New threads require a subject.'
      else unless reply.file or textOnly = !!$ 'input[name=textonly]', $.id 'postForm'
          err = 'No file selected.'
    else
      unless reply.com or reply.file
        err = 'No file selected.'
```
i believe rawExecutor can never be SimpleCommand ;)
In theory CommandSources could be in several channels talking (I don't want to limit it in the Engine, that will be up to plugins to handle it correctly and play nice).

it is called broadcastMessage because the chat commands themself where using the original (still existing) broadcastMessage methods.
Ah yes, I see what you meant originally now, but I agree the latest change makes it more obvious - thanks!
I think this should be ``if method == 'subpixel' and subpixels < 1``
This has been our definition of master identity for a while (just in the objects table), so I don't think we need to change it at this point.

I can do the rename from master_name to name, though.
Hi Rolando,
Did you check the offical document about gc? https://developer.mozilla.org/en/docs/SpiderMonkey_Garbage_Collection_Tips

Avoid malloc'ing temporary storage that contains unrooted jsvals:
/* Bad! */
jsint i, len;
jsval *vec;
JSString *str;
JSObject *myArrayObj;

len = NumberOfNativeStrings();
vec = JS_malloc(cx, len * sizeof(jsval));
if (!vec) return JS_FALSE;
for (i = 0; i < len; i++) {
    str = JS_NewStringCopyZ(cx, GetNativeString(i));
    if (!str) {
        JS_free(cx, vec);
        return JS_FALSE;
    }
    vec[i] = STRING_TO_JSVAL(str);
}
myArrayObj = JS_NewArrayObject(cx, len, vec);
JS_free(cx, vec);
if (!myArrayObj) return JS_FALSE;
OtherStuffThatMightGC();
*rval = OBJECT_TO_JSVAL(myArrayObj);

/* Good! */
JSObject *myArrayObj;
jsint i, len;
JSString *str;
jsval val;

myArrayObj = JS_NewArrayObject(cx, 0, NULL);
if (!myArrayObj) return JS_FALSE;
*rval = OBJECT_TO_JSVAL(myArrayObj);
len = NumberOfNativeStrings();
for (i = 0; i < len; i++) {
    str = JS_NewStringCopyZ(cx, GetNativeString(i));
    if (!str) return JS_FALSE;
    val = STRING_TO_JSVAL(str);
    if (!JS_SetElement(cx, myArrayObj, i, &val))
        return JS_FALSE;
}
OtherStuffThatMightGC();
Note that this example also shows tip #3 (root as you go).
It's literally a copy of the user project creation area. There is no ajax_loader, so I'd say no, and it can probably be removed from the user area too.
I still think it's worth keeping the `@tabBorderWidth` variable, just because there's a dependency between the two uses of it so it makes sense to keep it in sync.
First makes sense.

Would it be better if there was only one way of determining a pages required bootstrap? If that can't be accomplished fully with client-side URL regex, then why not accomplish it fully by embedding meta data on the server-side, especially as it is quicker?

I think this is fine for now, by the way. I'm just prodding.
Achtung! The default encoding is locale-dependent, not always UTF-8. This won't do what you expect on Windows, in cron jobs, and so on.

(This is one thing where I think they really screwed up with Python 3, but it's been discussed before and apparently it's not going to change)
I think jenkins doesn't use wild-card imports.
Ok, I've removed the debug message in b263285
Definitely not.

The spec Rails team justified there change by the following: http://www.w3.org/TR/html401/appendix/notes.html#notes-line-breaks

> SGML (see [ISO8879], section 7.6.1) specifies that a line break immediately following a start tag must be ignored, as must a line break immediately before an end tag. This applies to all HTML elements without exception.

But the rails in its `assert_select` itself only ignores leading newline, not trailing newline (https://github.com/rails/rails/commit/1141f71601ff61fb299c86d814c07209f1430024)

I am feeling a bit awkward about all these specs being so ambiguous, but the advantages of this change are:
1) Rack-test driver behavior closer to real browsers
2) Fix the tests in Rails apps where textarea is generated by form helper.
Ugh, why this? You set it to true above, so you need not to test it, right?
In my own patch, I have `break nil` at this location.
BTW we also do verify `contentScript`, `contentScriptFile`, `onMessage` and other listeners in bunch of other places. It would be great to share one validator code to reuse code & more importantly make sure we're consistent in requirements.
use expectedText[0] here
This is added but never used.
:D  the parsing of HTML is pretty hokey, but seems good enough for all the strings we currently have.
what is this secret?  what's its utility and intended configuration in production?
yes, these must be verified every time and served with etag.  I don't know if we want to do a temporary redirect to a permaurl on cdn, or not.
This is fixed by setting the `height: auto` on `html, body`
So ... if You would like to separate Nightly's (non-existent ;) ) logging output (one prefix for screenshooting, one for titlebar customizing, other prefixes for other NTT features, etc.) then file that new issue.

IMHO in other case it's not needed to restructure `Logging.jsm` to export only one object. The pollution was my fault.
Why do we think that there is a security concern here more then there ever was? Facter is not setuid root (at least it isn't set that way by us) - its ran as the user. If a users PATH is questionable, then the same can be said for any command. One could always achieve the same result by putting a hacked 'facter' in the way to be accessed using a relative PATH. We don't actually stop much by fixing relative paths ourselves, the problem as it were, is bigger then us.

What is more interesting is that removing relative paths may keep facter runs consistent, so we don't pull in binaries that are in a users home 'bin' directory for example. I think though if consistency was our aim - we would keep paths in a config file somewhere, and drop the usage of the PATH environment variable completely.
@zaphod42 yeah, same here
This is the condition I added so that you could add 'nopk' to the migration file.
I generally prefer these as anonymous classes inside the example. Workable?
@dbussink I think this is not an easy fix:

```
>> RUBY_VERSION
=> "1.8.7"
>> require 'socket'
=> true
>> :DGRAM.to_i
=> 16501
>> Socket.socketpair(Socket::PF_UNIX, :DGRAM, 0)
Errno::EPROTONOSUPPORT: Protocol not supported - socketpair(2)
	from (irb):11:in `socketpair'
	from (irb):11
>> Socket.socketpair(Socket::PF_UNIX, 16501, 0)
Errno::EPROTONOSUPPORT: Protocol not supported - socketpair(2)
	from (irb):12:in `socketpair'
	from (irb):12
```

Rubinius X18 mode:

```
>> require 'socket'
=> true
>> :DGRAM.to_i
NoMethodError: undefined method `to_i' on DGRAM:Symbol.
>> Socket.socketpair(Socket::PF_UNIX, :DGRAM, 0)
TypeError: Tried to use non-reference value 0xe70e as type Bignum (10)
>> Socket.socketpair(Socket::PF_UNIX, 16501, 0)
=> [#<Socket:0x1344>, #<Socket:0x1348>]
```
This actually makes the code harder to read. The previous line fit within the 120 character limit.

If it _did_ break the 120 character limit, the better change would be:

```
foreach ($this->_rules['allResources']['byRoleId'] as
    $roleIdCurent => $rules
) {
    ...
}
```

This is more consistent with other rules - like putting implements on the following line, or, in the case of long parameter lists or conditions, putting the closing paren and opening brace on a line by themselves.
ah, I had misunderstanding.

This change is 
Zend\Queue\Exception\ConnectionException extends Zend\Queue\Exception\RuntimeException (implements Zend\Queue\Exception\ExceptionInterface) . so this is makes sense.

sorry.
Could you explode it into two lines? It is just a question of avoiding `--` since this block can be confusing :)
I'd hate to do this to you, @bjyoungblood, but could you add a usage example? :)
The indentation here is strange.  I don't think you need to break the line (I'm fine with up to 120 characters), and if you do want to break the line then I'd rather just have a double indent (8 spaces)
I'm quite sure Jira runs on servers other than Apache Tomcat.
I would remove all those `* **text**` in titles and replace just with `####` which would render an nice  `<h4>` elements.
As above, add name of env in path.
The rar binary requires that `rarfiles.lst` and `default.sfx` be in the same directory as the executable. I'm not sure if these could be stored in `libexec` and a symlink used for rar, or if a script would need to be made to emulate the same thing.
-> `$( this.domElement.innerHTML ).html( this.template( data ) );`
@anti Wheressä otunnus, tunnus ja perheid2. Osataanko käyttää oikeeta indeksiä? Pitäiskö laittaa USE INDEX?
true, yes, i spell it out as being optional in soil, but in thinking of it some more - if we're loading files up in our caches, we might as well make it a requirement because memcached doesn't work at all in the long run. I can remove it here.
changing the indentation is wrong here
please remove the leading underscore in the property name
Thats not working. Better add the license to the license directory in the overlay.
also: are we removing translations here?
split line like this?

["%s%s" % (libprefix, x) for x in ["ifcore.a", "ifcore.so", 
                                               "iomp5.a", "iomp5.so"]],
Typo `unknown`.
Nit, but I feel like this would make more sense:

    """Return an attribute's value on a locale associated with this banner.

    If the attribute is empty or no locale is found, return the attribute on
    this banner instead."""
`asyncTest` takes a second argument for the number of expected tests, so we can remove the `var expects = 6` and `expect( expects )` from below
This seems to be part of the SAML spec
We need to remove bundler description here, we need to install it only via gem install howitzer
@kellyredding - Again, I like this feature and the convention for defining views using `<name>/lib/<name>.rb`.
there should be: 
```ruby
resource = options[:resource] || get_resource || raise("No resource to process")
```
I'll fix it in next commit
replyTo _must_ be outside of the closure, otherwise it has zero effect
This makes me a bit sad, because its yet another sorta bad response from Nexus when you do something wrong. This one is extra ambiguous.
If we are going to use a block and split it onto multiple lines, we use the `do` style.

`parsed_params.each do |param|
      ...
end
`
additionally, you may want to create a separate function for uploading and resetting options instead of overloading this one function with "actions"
Ignore, read the code wrong
The last inline code block is too long, please put it in a code block.
CS.  And no way around the fetch? ( Might not really make a difference as content_read operation is having such a tax to begin with though )
Either you modify your ```notes``` for ```url``` parameter or remove ```user``` and ```password``` params. The point is that you put notes that user can specify ```user``` and ```password``` in ```url```, but you never use them, but use separate ```user``` and ```password``` params instead. In ```url_monitor.rb``` plugin they use ```uri.user``` and ```uri.password``` after parse ```url``` string. Make sense?
ну так и назови edgeIds
у тебя по-моему любая рекурсивная функция называется dfs
This is configure a route if you don't want to use default /api/docs
This is invalid as the reset gets a reference and that is forbidden.
is the throw option not used in this case?
The line above could be declared as a Tuple, because you never change it
self.allows_less_indentation = ('else', 'elif', 'finally', 'except'). One question... Have you tried the code with non python files to check nothing crash?
Rails uses dependency injection - so gems are expected to inject their config at a specific point in the load process.  In turn the app is expected to wait for injection to be completed before it reads those config.

In the long run you don't even need this block, because plugin.rb can be executed at load time in the engine.
Choose randomly from a given list of languages, otherwise every repo is gonna have a different one (useless on filters)
The comment for this method should be updated as well. It currently says:

`Get all of the groups that are directly and indirectly associated to a resource.`
Right, I think this means that it's possible that getContent might still be necessary.
LOL. I can't see it... :-)
Using this as a property is a nice idea, but you need to run the test suite before you issue pulls like this- code throughout the rest of the project depends on calling '_type_node' as a method.
Don't limit it to just 2 subclasses, if bukkit adds a new thing that we want to subclass, it's no good to have to add new variables all over the place. Split on -, and the loop through the sub types.
Should be `string|null`
Ah dus we versnellen righting the player als we m zien?

Je moet code hebben dan ook om weer te onversnellen als de player uit zicht raakt.
Да, наверное, это уже лишнее.. А если меньше 0 ? =)
Если хочется, чтоб код был гибким, соответствовал правилам ООП, а так же полностью выполнял все пункты ТЗ, то да стоит придираться к любым мелочам. К тому же это обучение :)
C этим согласен. Нужно было округлить и проверить на 0-100.
А для чего нужен этот метод? По задаче его нигде нет, в коде тоже не заметил.
Было бы круто если бы вы использовали его внутри метода init, это убрало бы дублирование кода который почти на 100% одинаков для этих двух функций.

Т.е. нужно было сделать init, initWithCount и fillDna: size, в fillDna реализовать инициализации массива с произвольным числом, а потом в методах init вызывать его initWithCount. В init вызывать со значением size = 100 а в initWithCount  в произвольным значением переданным в метод.
С чего тут массив с числами от 0 до 9???
проверку встроил, сейчас залью. Я так понимаю, благодаря ей угроза бесконечности сокращается?
The font rendering code in gfx/fonts/fonts.c works by rendering the glyphs to a bitmap and drawing them as a texture, while the OpenVG code takes the draw paths of the glyphs and draws them directly from the paths. If this is a problem, the current code can be scapped and the font code in gfx/fonts/fonts.c can be used.
For ```OFN_PATHMUSTEXIST```, the docs don't say that it would only be valid in an Open File Dialog.
This comment is confusing. This ``if`` block applies to the default(?) case when the shift key is not down.
this test was failing because "event" variable was not declared and was used in it block

it("logs the summary", function () {
      summaryFormatter.handleAfterFeaturesEvent(event, callback);

 it("calls back", function () {
      summaryFormatter.handleAfterFeaturesEvent(event, callback);
The middle paragraph also sounds redundant with the new phrasing.
Missing command doc.
Reiterating my point from above: it also applies here. epochs_list, method. And we wouldn't have to edprecate, as this is post 0.4 -- right?
and Evoked. Thanks
A suggestion to simplify this decision tree: 

if isinstance(key, str): convert key to slice/index

procede like for slice/index keys
are you sure about the -1 ?
Please add logging to your code. This would help in tracking your code and debugging it. (H&E)
console.log(...) or console.info(...)
console.error(..) in case an error occurred
That looks great, but as I mention in the commit there are minor tweak we should do. I'm not fully comfortable to just deactivate extension without the user knowing what exactly happened to the other extension.
I think it should be "mostly" mutable, not "misty.
callback is more an action or func.
I see the requirement for `observers`, but Is `journey` required? Or is it a dependency of something else?
Yeah, I haven't messed with to_python() at all yet. It's last priority, since it isn't actually called from within the lib.
I think this is C/P error, the *XO classes are generated here but with the wrong package
(see https://github.com/sonatype/sisu-litmus/pull/8/files#L8R32)
OK. Sorry : )
Cache is not needed in Twig.
May be, you should link to twig doc and remove doc about cache. It will make code more simple.
设置缓存文件描述符在多长时间内没有访问就关闭；

这样可能更好
A yes true. I cannot think of anything more than just using a function that would return the prefix trait (given a default value). This would cut down the amount of repeated code.
for the _list_outputs() to have the prefix and find the file

On Mon, Feb 27, 2012 at 12:12 PM, Chris Filo Gorgolewski <
reply@reply.github.com
> wrote:

> > @@ -48,6 +48,8 @@ class SliceTimingInputSpec(SPMCommandInputSpec):
> >      ref_slice = traits.Int(field='refslice',
> >                             desc='1-based Number of the reference slice',
> >                             mandatory=True)
> > +    out_prefix = traits.String('a', field='prefix',
> > +                               desc = 'slicetimed output prefix')
>
> BTW why do we need the default? Doesn't SPM have it's own default?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nipy/nipype/pull/304/files#r490667
>
I'd actually like your input on that. For C I think 80 works fine, but, IIRC, the mere declaration and initialization of an iterator in C++ could take up more than half that.
How about  `poly_gens = [v.name for v in symbols(poly_gens)]` so then one can do `LPoly('x1:3', QQ)`.
Yep, `nodeByKey = Object.create(null)` should work here too. ;)
затроллел ты меня :-(
@edolopez  se quedó uno vacío :trollface:
No se que paso, lo agrego esa linea.
I could. But I don't like a trivial thing like this to pollute every forthcoming HTTP request. Besides, all supported browsers have sessionStorage. I would rather add userData for IE7 and lower, and test again in Opera, which should support sessionStorage, too. Anyway, for those browsers the behaviour shouldn't change. Read: I hate cookies.

Users on Konqueror will run into graver problems before this one, imho.
Would it better to raise an exception here? Wouldn't the user assume a successful migration? Where would the exception go?
If this isn't changed to allow more parameters fake mode will break.
I like this now :)
Where do you call "instanceof ClientCommand" ? Btw, in terms of annotations, this now get index at build time, so should be pretty fast.
Why skip locking?
This is technically "megabits." Megabytes is MB.
Yep… I ummed and arred about this for a while… I can't think of any better solutions though :/
I would compute this value in the DI ext
Wow. ```o``` is perhaps **the** worst variable I can think of (although ```l``` is right up there too). Not your fault, and not something you should address in this PR. Just wanted to draw some attention to it.
`_get_top` is the only inconsistent wrapping here.
The comment needs removing, as far as I can see, this try block will never fail.
You don't need a backslash here. End the literal and start another string on the next line. Python automagically parses them as one string.
Also not going to limit the total scale factor (because it uses pinch.scale), and this will fail for images where height > width. Calculate the actual effective scale factor as it would be after resize, bound that, and apply it.
Казалось бы не должно быть raw тута
always use {} for if; try to pack the requests into more speaking sub methods
according to http://www.quirksmode.org/dom/w3c_core.html IE problems are only with comment nodes, which doesn't apply here. However, can easily change to childNodes if you like
It was only used by the code that was commented out.
This isn't a template, it's an example of a trivial (and optimized) embedding of the friendlycode widget.
```load_counts``` populates multiple instance variables, including ```@metric_counts```.
That's not true: if you open the statistics for an LSM tree (say), this statistic will give you the number of entries in the tree.  They are aggregated in lsm_stat.c.
I like this `with-open`
I'll also drop the FIXME even though it still applies
Should the return type not be ``null``?
If it's possible, is there a way to check if the text is actually inserted _after_ the cursor position as well? One of the biggest use cases for this is like adding things like a MD image tag or something where you're typing so:

```
Starting text. |

```

If the `|` is my cursor and I do `insertText('End')` it should put `End` at the end of the line. Can we check the indexOf the inserted text and make sure it's in the correct place?
refactor into private method (in your new shiny class).
Consider linking Dart in Action directly
This should really have a blank line above the comment.
Do people actually write code like this?  Since XPath isn't valid for a symbol literal in Ruby, people would actually have to do extra work for this to happen.  Supporting "what if" use-cases like this makes me sad.
Not sure. I imagine this would be treated as an ambiguous case, but there should still be a test for it.
Just an FYI, don't care if you leave it: you can also remove the ampersand.
This should probably be at the end of one line before. There is no open parenthesis at this indentation level you are closing here.
*Form for processing an e-mail address confirmation token.*
You mean something like a template tag function,  {% get_name profile %}  ?
Ups. Fixed
Hm. You could just move this to some `common.js` which would be included from all templates (in `base.html`).
There is one method on `user` object to send messages to her.
But, hm. It is not clear to the user if he has to submit form again or not, when dependent panels are automatically selected. With current code, because you are misusing errors, it is not saved until she submits again.

So I see two options:
 * you display and error but don't fix the value automatically
 * you fix the value automatically but use Django messages framework to display an error (or warning), not form errors

For later you will have to have access to request, which you can pass as a constructor to the form (see `UserCurrentPasswordForm` for example).
Yes.

Use `'` for constant strings.
Organize imports. Built-in modules are on the top.
Wrap into new line after `}`.
No. Not sure on 100%.  need more research what's why i ask for QAston as he work with it.
But I think that getting first passenger is enough.
Ah whoops; I didn't catch that because the `.pyc` file was stil present in my version. This line should be removed.
I'm not sure what you mean. I've tried to add the dependency to the service directly or using the scope = 'request' but that didn't worked either.
If there's a recommended way of doing it? I need to get the service in order to retrieve the URL from the extension else I'll just pass the paths as parameters but I don't really like that approach.
I think there was a reason I did that. I tried to remove it before and it fails all the time... Don't remember why... Ha yeah ! Because then we call $this->metadata->getIdentifierValues(). If $valueOrObject is an integer, this fails, as it's not an object.
So I can delete this ?
signal.signal возвращает предудущий обработчик, полезно на него переподписаться когда сервер завершился
E.g. to extend an existing array with a return value of map.
Going for LOCAL_URL_TYPES within window.templates.network now. We have TEXT_TYPES there, they seem similar.
System index for the system path of the current system in the upcoming loop.  Needed because the hyper target, selected, and current are stored as system paths so the current system is needed in system path form for comparison, I'll check to see if I can name it better.

It's probably named what it is at the moment because Near sector view rendering always had it as 'num' and I must of done a copy/paste of the check after I changed the near sector view code. So I'll check whether I can rename it there as well.
pref.diskCacheSize() is called once with my code, but twice after your change. It can only make performance worse.
May be its just me, but the whole if else pattern here throws me off a little bit. I would prefer something like this

https://gist.github.com/71f761c9d118cf0bd921
Add some ns docs, yo.
This should take an existing axis as a keyword and return the figure. See this function for how we work with matplotlib by convention

https://github.com/statsmodels/statsmodels/blob/master/statsmodels/graphics/factorplots.py#L6

The preferred way to work interactively with matplotlib is something like this

```
import matplotlib.pyplot as plt
fig = plt.figure() # only use of plt ever except maybe show
ax = fig.add_subplot(111)
ax.plot(...)
```
Yes, I've been using that extensively, it is very convenient.
Well the superclass method for servers returns an array of strings but the rack/rails code tries to call the alive? method on each server so we need to return an array of objects which implement that.

The only reason I wound up adding set_servers is so that the reset method works, as it saves the current server list (from servers) and tries to restore it with set_servers and that was failing when servers returned server objects.
No, I think that is perfectly clear.
Hardcoded Fall2012 == course, good
Out of curiosity, why return `CustomAggregatingEnricher<Number,Double>` rather than `CustomAggregatingEnricher<N,Double>`?
Would be good to say which entity in log message (for if running big app, where not obvious which entity type or entity instance this came from). e.g. `if (LOG.isDebugEnabled()) LOG.debug("No serverStatus data for {}: service not up", entity);`
is this validated anywhere?
This is really hard to test for.. and will everywhere except on your machine :(
skip any argument that starts with `-` to avoid parsing other args.
why is update function not used?
you should use docComments to provide the phpdoc, not regular comments
It'd be cool if these were alphabetical.
This was duplicated
PHP54 doesn't have any references to this option, which was my primary reason to remove it. I'm going to leave it in PHP53 because it's a valid option there. PHP54 uses `libedit` instead of `readline`, and since `libedit` is built in to OS X, there really isn't a reason not to build with support for it.
Don't use it, there is a bug in homebrew that makes it not work :(
Sorry those two statements totally confused me... Can you please clarify? Are you saying

```js
var str = 'one/';
str[str.length - 1];
```
Will scan the entire string? Would the regex be faster in this case?
We should just call this PageRegion
why not simply using the ``|markdown`` filter to do the rendering part, passing the content of the file here ?
I'm guessing you deleted the earlier comment about Windows compatibility. I just tweaked this bit of code because the way I was using this context-manager was confusing.
That's true, but I also put a random `d` in there.
2012/8/30 Olivier Grisel <notifications@github.com>

> In sklearn/linear_model/tests/test_sgd.py:
>
> > @@ -135,6 +135,13 @@ def test_multiple_fit(self):
> >          clf.fit(X[:, :-1], Y)
> >          assert_true(True)
> >
> > +    def test_input_format(self):
> > +        clf = self.factory(alpha=0.01, n_iter=5,
> > +                           shuffle=False)
> > +        Y_ = np.array(Y)[:, np.newaxis]
> > +        clf.fit(X, Y_)
> > +        assert_true(True)
>
> assert_true(True)? is it necessary for a smoke test? Just put a # smoke
> test before the fit call to make it explicit that this is just a smoke
> test.
>
no - not necessary - just a habit - makes it explicit that once you reach
the stmt its fine - I'll remove it

>  —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-learn/scikit-learn/pull/1084/files#r1494397>.
>
>



-- 
Peter Prettenhofer
What is the multi-class SAMME algorithm?
This is somewhat conflicting with #1381
or ``accumulate_scores`` ?
Isn't this just `TransformerMixin.fit_transform` with a different docstring?
Normalied => Normalized. But I agree that the lack of adjustment for chance make NMI lie a bit:)
smells like copy paste for `dirs`/`files`

also `arr.push(UTIL.format(` repeated often -- maybe `function pushFormatted(arr, str /* args* */)`?
Rename here as well
`index` >> `indexes`
`it instantiate` >> `it instantiates``
Yes it's great; don't try visualizing two threads, but think it's more: one
it's owning the lock and spending quite some time to reload some large new
segment; when it finishes you have got several other request waiting in the
lock: only one will get it and do a single check on behalf of the whole
group, all other threads can then return quickly without more I O
On Oct 22, 2012 9:39 AM, "Hardy Ferentschik" <notifications@github.com>
wrote:

> In
> hibernate-search-engine/src/main/java/org/hibernate/search/indexes/impl/SharingBufferReaderProvider.java:
>
> >  			try {
> > -				IndexReader beforeUpdateReader = current.reader;
> > -				try {
> > -					updatedReader = beforeUpdateReader.reopen();
> > +				if ( refreshOperationId != preAcquireVersionId ) {
> > +					// We can take a good shortcut
> > +					current.usageCounter.incrementAndGet();
>
> Is this a measurable improvement? The code is quite complex as is.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hibernate/hibernate-search/pull/347/files#r1901149>.
>
>
As it's in a transaction, I think you can roll the two for loops together..
i.e. throw an error having already added some subs if you detect already present..

Renato please confirm it will rollback as expected if so..
Should possibly be renamed.
Indeed, it prevents deletion, my bad.
with filename_max at 4096 on modern systems, that starts to get a little large to allocate on the stack.
Ah, this is nice. Thanks
I think it's clearer to explicitly format the date e.g. .strftime('%Y-%m-%d')
this is assuming that all users will want this patch. This needs to be somewhere separate.
Huh? this is not rolling two things into a single setting. The SENDGRID_CREATE_EVENTS_AND_EMAILS_FOR_NEWSLETTERS setting will only control exactly what it says, creating events and emails for newsletters. If any other functionality is added (i.e. SENDGRID_CREATE_MISSING_EMAIL_MESSAGES) that setting will be added and handled accordingly. We could put that setting in now but it won't be controlling anything.
Ah, all tests still passed but I didn't consider that scenario.

Do you see any possible complication if we just do:

     for name in self.table.sequence:
They do add up to 12?
 I've changed it to a normal row. This was a while ago when I was just making everything fluid, just in case...
I don't want to use DFBase' s navigateTo() methods due following  reason:
1. In a test class I need to create an object so whenever the object is called , a new object would be created in memory to perform any functionality. So i would prefer to use static method for navigate to the page.suppose if there are five test case and all are using navigate method then 5 objects would be created for navigateTo().
@yuhunglin for instance here I would just add a callback to the function & pass in the `loadCourses` function on line 99
Maybe revert changes for GitExtensions.csproj?
`(contains? (:authors book) author)` palauttaa booleanin sellaisenaan.
If this is is a url encoded string, let's urldecode it properly and then split on space, rather than hardcoding %20.
Same with this one — it should be based on the redis_failover root node, right?
Es geht vmtl. nicht um eine Benachrichtigung --> "Admin einschalten" passend zu "Admin abstellen"
If you're only concerned with undefined, why not check for that directly rather than using isNaN?  In my mind, an actual floating point NaN value is even less likely than null, and checking for undefined is faster than checking for NaN, right?
I add the min(imageWidth, imageHeight) to the old size, then multiply by the scaling factor. Also, any problems with me including the scalingFactor in the constructor object literal (but not forcing anyone to set it), or should that be completely hidden from view?
Yes.  The dynamic texture atlas changes that @IanLilleyT certainly made things simpler, but TextureAtlasBuilder is still needed.  It works at the Image level rather than the texture level and handles asynchronous loading as well as handling the case where an Image is already in the atlas, and therefore doesn't need to be re-added.  In theory, we could roll this into TextureAtlas if we wanted, but I thought it was better to keep it separate for now.
Perhaps we should move the `show` check to `update` for all primitives now.  We are going to do it sooner or later since `render` is going away.
Ah right because the texture coordinates are going to be wrong.
Could you do this before merging?
From an efficiency standpoint, we only need to loop through the tabs that are not the active tab since the following call to setTabBackgroundSelectedColor takes care of the active tab
We never want to throw an NPE. If we don't catch that exception, the worst that can happen is the app crashes which is bad.  Failures need to be handled gracefully, and it should be an error that is relevant to the situation, not an NPE.  The better thing to do would be for us to check for null, and print out a warning or error so the user knows why something went wrong.
Is the locks required here since the method `children` is synchronized by the same lock
This doesn't look right: input.value = input.value
Is this the best function name? Move what float? The other functions names like _MoveForward are clear to me, but _MoveFloat, not so much.
other functions are returning `1` or `0`. might just want to be consistant here for callers
The package name should be in the params file, even if it's the same on all the platforms we currently support. This will make any future porting to other platforms a little bit easier.
This could also be a string comparison:

    function == "function_" + arguments[0]
Будет. Велкам ту языки без гигиены. Не надо так делать. :(

Ну, там достаточно адекватная совместимость, но тебе решать. Просто обратил внимание.
"Most people will agree that example 1.3 is the best for three reasons: [...] The differential sign ‘d’ is set in upright type, so under no circumstance will ‘dx’ be mistaken for ‘d × x’." 

I'd like to know who these "most people" are.  The credit to "most people" has logical fallacies in that it is an appeal to common practice. Note, the source I referred to is a source recommended by the AMS (**the** source for mathematics in the United States) and has gone through peer review.  If "most people" prefer this convention, why do all my print LaTeX books have the italic 'd'?  Why do all the textbooks easily reachable have the italic 'd' -- including the textbook used for PreCalculus at the school I work at?

Note that Helin Gai says in http://math.ecnu.edu.cn/~latex/docs/Eng_doc/LaTeX_Manual_8_6.pdf "With LATEX, you are not supposed to be concerned about the style—everything should be pre-defined and fully at your call. You enter your text and LATEX takes care of the formatting."  The predefined style for an integral or derivative includes the 'd' in italics, so this work around suggested doesn't seem to fit this.

The argument for using the upright type is, in my opinion, specious.  'dx' is a variable with two letters.
Is your custom struct supposed to be `true` for `isIntegral` somehow? I thought that it was only `true` for the built-in integral types. If that's the case, what's the purpose of this change? Or is it somehow possible to get `isIntegral` to be `true` for custom types?
should 40 be a formal constant?
std.conv sounds like a good place
Yes, but in a separate pull. Note that this pulls contains only obvious fixes for most nasty bugs of `std.conv` and `std.typecons`.
It's an "intermediate" pull. "Finally fixed" `emplace` is in #949.
Pulls with "finally fixed" other function will follow once `emplace`'s "finally fix" will be merged.
nice use of cascades here!
Yes but auto-completion will make it a pain. But like Gunnar, I can't find any good name alternative. Maybe `@Hibernate` but that's carries some other problems.
The []s seem unnecessary; I've been getting rid of them in my projects as I come across them (kinda like the #add_dependency section above).
It seems when you merged in the changes from https://github.com/jayjanssen/resource-agents-prm/commit/913ad8a9ef2d714ba7a6900a4cab0489d0adcd61 it didn't merge correctly. These lines were removed and put in the if else block right below it to see if we can flock the lockfile. See https://github.com/y-trudeau/resource-agents-prm/commit/beb464fad781d7cda0b28f7870b4a26219f6e44e line 561
Nevermind, I missed the input = this.element[ 0 ] above.
no empty lines in ArcBees inf.
comment feels redundant ;-)
Don't need the ~n
I was getting xml parse errors with metalink docs encoded outside ascii as without base64 the string is assumed to be ascii in the data uri standard and other charsets dont work, base64 encoding can work with all charsets
I do use JSON
Thanks for pointing :)

On 29.12.12 11:05, lucapette wrote:
> In 01-introduction.md:
>
>> @@ -22,21 +22,19 @@ considerable ease.
>>
>>  I won't tell you which operating system you should use - there is an interesting discussion on
>>  [hackernews](http://news.ycombinator.com/item?id=3786674 "hackernews"). I leave it free for the reader of this book
>> -which to use - basically you are reading this book to learn Padrino.
>> +which to use, becaus ebasically you are reading this book to learn Padrino.
>
> typo :P
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/matthias-guenther/padrino-book/pull/24/files#r2519698>.
>
>


-- 
Mit freundlichen Grüßen,

Sebastian Günther
the default value is 200. You can find it from keystone github  page   https://github.com/openstack/keystone/blob/master/etc/keystone.conf.sample
Fixed up in 57e647d
Maybe we could delay that until it is actually needed to decrease the performance impact that has?
So 32 is the user-facing definition, is what you're saying?
I think those are good and even considered them, but they are *so annoyingly long*. Perhaps just `Ordering`?
RSS results class
Fixed before this comment as I noticed it right away once started to review the PR
If a user attempts to run this using something like `raxmon-alarms-changelog-list --entity-id=""`, I believe that it makes more sense to give them a 400 error for an invalid entityId, rather than give them an unfiltered response.
this is changed by mistake — which value do we need? doesn't matter too much I suppose
Tip I never mentioned, if you add true as the fourth parameter to this call, the property defined/reference event is not fired. It's not part of the spec and undocumented, but I think we should use it here.
Is that the name we want to go with? I'm happy to change the repo name once more after this PR but we've got to reconcile:

- Fody.AsyncErrorHandling (repo name)
- Fody.AsyncErrorHandler (README)
- AsyncErrorHandler.Fody (NuGet package)

Anyone have a preference?
Looks like a `TODO` I wrote :).  Why not expose these?  Should be trivial?  Or is there no value-add?
The names `from` and `to` are a little ambiguous, especially since these are references to the users table.
I'd recommend `from_user_id` and `to_user_id` for clarity, and a code comment on why you chose not to enforce the foreign key relationship to the users table.
Maybe KeyspaceManager, since Keyspace stuff is all we do here, but we do Cql stuff everywhere?
"-MS3" would result in "-3"
and since the parts are split at '.' the first char will not be '-' (only for something like "1.0.3.-bla" which will not be used)
remove > utf-8" string
Yep, I copied the code from shufflesplit before you fixed the issue...
Remove this line. checklogin sets $user via the cookies
Please don't duplication the `sql_for_distance` calculation here - just add an extra parameter with a default value (`scale = 1`) and then make this routine call it with a different scale.
Does it really make sense to roll these two cases into one interceptor? I would have thought there is a _NoopInterceptor_ which is the default and represents the current behavior
Empty path here will become: ```file://```, which means root dir. Existence should be checked elsewhere, I think.
This sounds mandatory, as though if you don't implement anything here then somehow the properties won't survive (as if you were responsible for taking the properties and storing them somewhere.)  I think it should be more like "Implementing classes can use this method to examine the properties passed into the proxy."
you need to check if the service exist and maybe provide a small explication.
To trick south, there have to be the models or at least imports in the app's models.py.
And why not make models.py the new fb.py, where users of the library find all models at one place?
We should also be allowed to set the maxRows attribute, currently we don't allow the user to specify the maximum number of rows per poll.
If retries are really needed (see my previous question), there's a fair of code repetition here. You might wanna have a method that does the try/catch and in the try, it calls Callable.call(). Then callers would pass a Callable instance with what to execute. For an example of this, see org.infinispan.test.TestingUtil.withinTx() method in Infinispan source directory.
I can't seem to build locally without this flag.  I actually have the same problem with the connection extension but I've been just manually adding the -lang-c++ flag for that.  This happened after the cmake file was changed to get native unit tests working.

I remember @jkeshavarzi having trouble with connection in the SCM build because this flag wasn't there.  Is this flag still needed for SCM for the connection extension?
can someone explain once again what this tag is designed to do, I know we talked about it but I don't remember now
you can't add * to the test-app, it will defeat the purpose of whitelist test cases
Changed the logic to send the local:// to require.js to signify that it should jump the bridge for the file.
delegate is deprecated too, use of on is recommanded
make default privacy and test with unit test (for both methods)
The greeting block needs a rule to add a bottom border to match the one under the `tabnav` block - currently the border stops after the tabs.
So my problem is that's 'll breack admin for all people using  You're editing the object "{{ YourModel.title }}"
You should mention that the speeds are slow because most people don't have a phone with Simple Mobile (T-Mobile's network) GSM bands and that you get EDGE. If you had a phone that supported it, you could get 3G or LTE.
 
Now I read further in your comments, do they actually throttle or is that just EDGE?
I would name this function drawPolarLine
Agreed.

As per the comments, they're jsDoc comments, so they get turned into documentation. You can view the docs for this repo in our github pages (there is a link from the readme)
Так ведь енто ж постинкремент.
Сначала проверяется условие, i == 1, а потом выполняется --, и в цикле имеем i == 0
Поставьте alert(i); опосля while(i--) {, и увидите.
>переменная j - лишняя.
Егда постов у юзверя в хранилище под пару (а то и с дестяок, чем черт не шутит) тысяч, то выполнение шесть раз умножения i*3 в функции может добавить к ея выполнению лишнее връмя..