labofsahil/github-event-dataset-2012 huggingface dataset:
Fixed required doctrine dependency in composer.json
Fix Issue 8969 - Document __parameters in is expression.

http://d.puremagic.com/issues/show_bug.cgi?id=8969

I don't know if this is D2 only or not though.
Updated gems to use rails 3.1

I am having success in a rails 3.1 application.

The only thing I'm unsure about is the 2nd file of tests passing. I'm having a problem loading the schema that is being defined. Could you help with that perhaps?
Add a webservice interface to IonisInfo::search
Great, I was just about to start debugging this.
Why not `{value: false}`?
Ok I will try it
About testing:
I went to a testing server and gave myself gm rights to test it :)
whu not over scaling data?
Sounds good. Started on something. I wonder... @jimfcarroll  is it okey to take a CSharedLock after a CExclusiveLock ? i'm not sure how those work anymore.
@drak @planetenkiller I could still use your input on this please.
This doesn't seem to work for scalars at least:


>>> (np.sign(-0.5) != np.sign(0.5)).nonzero()
()
>>> (np.sign(-0.5) != np.sign(-0.5)).nonzero()
()
>>> (np.sign(0.5) != np.sign(0.5)).nonzero()
()
>>> (np.sign(0.5) == np.sign(0.5)).nonzero()
()
>>> (np.sign(-0.5) == np.sign(0.5)).nonzero()
()
This function is no good.  If you carefully look at its logic and think about the way cyclus works, it becomes apparent that compositionIsTracked returns -1 every time.  And indeed - I checked with callgrind, and it does return -1 every time.  compositionIsTracked needs to be deleted.  It is just a performance reducer.
Thanks.. I missed this while refactoring :(
I thought about this again and i think we should propably add a checkbox to the configuration options to activate the LTS-check. The default behavior is suggested and wanted for most of the websites running with contao i think. A option would be great. (e.g. if i write to my own blog it's nice to see if there's a new version)
@Tie-fighter In my opinion it would have been a proof-of-concept had he done it with repos of his own and comments of his own. The moment he started affecting other people (the user that posted the comment he deleted, the user who he posted as (@dhh) and the admins and other users of the repo he hijacked) it became exploitation. The user, @dhh, the Rails core team and all the people who care about the rails/rails repository are innocent in GitHub's forgetting to protect its attributes.
I will add it again later when I work on the icon support.
But I don't want it in this function.
I will move it to somewhere else since it don't looks clean here.
конфиг временный вообще. я его уберу потом
Thanks to jbickar for the fieldset code!
This needs to be reverted, strings are seq'able

```
user=> (seq "Hello")
(\H \e \l \l \o)
```
Implicit ordering is a great use of implicits, [Ordering.by](https://github.com/softprops/ls-server/blob/master/src/main/scala/conversions.scala#L124) is sweet.
Thank God this was found.
How is this breaking stuff again? The code looks alright from a cursory glance, what makes it blow up?
丢失倒不至于吧，顶多是迟缓，我是打算先搭框架了，之后调研一下select以及多线程
This line now reads "We will Let's begin with".
Makes sense to me. I think there shouldn't be too much knowledge about the control flow analysis outside of the control flow analysis code. That's what object oriented design was designed for. :)
Technically it is ambiguous, it could be ignoring cancelled events, or ignoring the cancelled state.
Ah, that one-liner... =) Yeah, I did! =)
Thanks for doing this I never got around to it.
can we abstract this so we're not copying pasting from `collection_detail`. not sure if this is within the scope of this bug, but we have `acl.check_collection_ownership(request, collection, True)` checks all over the damn place in all our damn views here.
Also renamed some structs and file names.
Tem sim. Foi por causa da indentação que configurei no netbeans. No máximo amanhã envio novamente.
works great. really adds to the playability
not StatET-1.0.1, but StatET-2.0.1
Not sure but should this be `names(aesthetics) %in% names(.$geom_params)`?
see #376
Nice h2s.
And what about "formated"? ;)
I guess I have to use -L when linking so that arpack, for example, can find BLAS and LAPACK, and then -rpath when building the binary so that all the dependencies can be resolved when running julia.

-viral



On 04-Mar-2012, at 2:09 AM, JeffBezanson wrote:

> I get this:
> 
> ```
> /home/jeff/src/julia2/julia/lib/libarpack.so: undefined symbol: dzasum_
> ```
> 
> I don't see what `-rpath` is doing, since if we use our own blas it is still statically linked. Also, rpath needs to be set on the executable. But, if we do that it seems it will tie it to a particular path and binary distributions won't work.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/JuliaLang/julia/commit/35595917556334a7282cae27fa7e7fa97a7cdf8e#commitcomment-1039256
I did a quick test and this is only about 2.6x slower than printing an integer. I'm quite pleased with that, considering the extra objects and indexing and such involved. Still might make sense to try to max out performance though.

In related news, it may be time for the built-in integer printing methods (based on printf) to die:

```
julia> @time for i=1:1000000; string(1); end
elapsed time: 1.094998836517334 seconds

julia> @time for i=1:1000000; dec(1); end
elapsed time: 0.2381420135498047 seconds
```
Do you have a testcase showing a colorscheme that is improved by this change?
10-4 good buddy
why have you messed it so upside down O.o
Your option_id 1 has npc_option_flag 16 ?
no no, I didn't ban any player yet. But I use the "hack" and myself appear in log.
testing this in a few hours when I come out work :D
`defaultValue`?  `false`?
С учетом всех недочетов с предыдущего комита соберись духом и исправь все. Изменения заливай по инструкциям дока п.6
Tried applying this patch on dev, breaks the specs for empty custom attributes.
can you fix the [marketplace tests](https://github.com/mozilla/zamboni/blob/master/mkt/developers/tests/test_views_edit.py) too? :)
Его там быть не должно. Стереть забыл.
this method doesn't do anything else so you don't have to override it... you just inherit it...
Good Work on Profiler . How do we plan to use logging ?
Nope, the lhs can be any expression. I agree that it's not perfectly clear in the spec, but I'm pretty sure that `f(i++)?.x` shouldn't increment `i` twice.
typo - negative
and changing a "i" to "j" in `<script src="impress.js">` ;)
be sure to back out the helpers as well
Whoa, can this work? I think the class should be named Root, doesn't it?
Just a test on GFM...

`Is this displayed as code ?`

```Is this displayed as code as well ?```
you just need to run script/server or sass manually to create them.
Is using 'object-type.#.new' a common convention is message queues? I would have guessed 'object-type.new'.
this tells travis that tests should be run 3x with 3 diff sets of env vars.
I agree, This is a very cool layout!
great patch!
only, i wonder.. how can we see now if a plugin generates lag? ping?
(for example, when i migrated WhoPlacedIt plugin to mysql, i noticed massive lag, with a little debug i just added an index to the database, the lag was gone..)
Oh, derp. Appearently stuurt Github iedereen een mail als er ergens op gecomment wordt.
On retrospect this should have a constant name, in case someone dicks around with OBJDIR and causes a conflict.
Pathing is ALWAYS expected to increase CPU. That's a big reason retail realms run on 4 separate server blades.
Thanks, acheetham, these changes are a good start. Could you extend the behaviour to also support the "error" callback since it is inconsistent to just support function resolution for one kind of callback and not the other. Also, could these two test cases be refactored to remove the code duplication? Note that the contents of the callback function are the same, as is the driver, error checker and expect count, url, etc.

Cheers,
Antranig
:) Ha yes sir it is. There was a group of us that were huge users of Google
Reader and its social features (sharing posts, commenting on posts, etc.),
which Google took away in an effort to get people to move to Google+. We've
waited a few months for someone to develop some kind of replacement, but
nobody's stepped up. I thought I'd take a crack at it myself.

What have you been up to? How's 10gen? We oughta catch up sometime -- I'm
busy until the beginning of march but after that I'd love to grab a beer or
something.

- James

On Sat, Feb 18, 2012 at 8:27 AM, Tyler Brock <
reply@reply.github.com
> wrote:

> cool, new project jimbo?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/jsomers/readertron/commit/ff27a9a8e42a6203b9ce563954566356397dce62#commitcomment-981030
>
if (spellProto->AttributesCu & SPELL_ATTR0_CU_BINARY)
     if (victim->GetTypeId() == TYPEID_PLAYER)
        if(victim != this)
       {
            int32 tmp = int32(averageResist * 10000);
            int32 rand = irand(0, 10000);
            return rand < tmp ? 100 : 0;
       }
       return 0;

Possibile Fix problem for self cast
maybe:

`mootools-*.js`
woops those werent supposed to be commited thats for something else. ill fix this
ya lo prob y funciona.

> Date: Wed, 15 Feb 2012 17:25:28 -0800
> From: reply@reply.github.com
> To: matiasjose78@hotmail.com
> Subject: Re: [CommonJobs] Fixed .markdown files to workaround mmd2pdf issue (15291c1)
> 
> ok, igual cuidado que la ruta tiene que ser relativa al archivo markdown, es decir debera seguir siendo `Images/Gantt.png`. Tal vez convenga invocar a mmd2pdf.exe desde la carpeta del archivo markdown, supongo que de esa manera va a funcionar correctamente.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/matias78/CommonJobs/commit/15291c16dbfdf99a69c306dfc1479870ac6445e7#commitcomment-972170
It's much better to defer the creation of the message until after the drop if() statement.
It should be better that add a space before "%d". You can amend this commit using interactive rebase: git rebase -i 402bcd3^
Alright, I checked that in yesterday afternoon. I believe it should be working. The only thing to watch for is the material import. The first line of simpleInitApp() determines where the material definitions are found.
补充一下，你这么改会额外在初始化时update target，这个没必要且易错
I think this idiom should not be encouraged, because the underscore character is already idiomatically overloaded  -- ``_`` is also the conventional way to import "gettext"-type functions (a convention that extends beyond Python code) and is also used to refer to the result of the previous expression in the Python interactive shell.
No need to mention Service Builder here either. Although it could fit a note for those interested. Something along the lines:

Note: Liferay's developers use a tool called Service Builder to expose their services via SOAP automatically. If you are interested in using this tool for your own services, find out more about Service Builder in chapter X
Well, not is matches company format.
Raynar aqui te cargaste algo creo :S
"Probably" isn't so great here, no? Do we need to add a method/exception to the server so you can better detect pyramids?
why was this moved. did something break?
El crash se produce aca, por el me->getVictim().
OMG OMG OMG OMG
One basic page to show changes in img.src will result in a new image from Google Charts

No significant server side code at this point. MVC template is convenience only.
Used KnockoutJS for no other reason that it's neat right now!
Tested:

    * Go to the Screens tab, browse a plate.
    * When thumbnails are displayed, when you click on the Plate or Plate acquisition, you should have the same display.
    * Now import a plate (e.g. flex from test_image_good)
    * When import is completed, click the browse button.
    * When thumbnails are displayed, when you click on the Plate or Plate acquisition, you should have the same display.
I also added a bunch of documentation too :)
Jeremy, thanks for looking at the code. I like the idea of the data_required{rep1[attributes],rep2[attributes]}.
No more listing those many fields in different places. And thanks for putting in the suggested code implementation.
I fix the bug of multi-login when resume the imps container activity
i think the case heading == 202.5 might not be handled?
Wcięcia w komentarzu.
Sorry, for some reason I used the modelid1 instead of the lootid value.
Agreed with the above comment. Makes more sense to do this in the boss' script instead.
Also, there should be no error if developer was not defined. There should be a test to cover that case.
WHAT?! Why u cares, who use your work? Less donatig or what? Not sane reasons for this.
OOOh, that's what that was complaining about
Comment on this commit should read "Fixed Problem with Stress Reports throwing an exception because of lack of an erb tag in a segment of the stress_reports index"
Причём здесь гуиды, петушок?
Still doesn't work for me :/
Yeah.  I should revert that commit like you did also.
If the crontab entry is root. Otherwise it would depend on the user and OS.
Ah, in my case building for NS I never came across that, good to know.
That's shady...

On Jan 5, 2012, at 13:16, Scott Bressler<reply@reply.github.com> wrote:

> Looks like you did it: eda7755f3b450f447b054e91654121de9976f3ec and then undid it: 48216cc412acdd774a57374ac010c47e26f15898
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/danielbachhuber/Edit-Flow/commit/181bca6f965d229c718d0c3c1d2d8ee795aff964#commitcomment-841734
Careful... http://issues.mollyproject.org/browse/MOLLY-232 could be tripping you up here, you'll need to check that none of the views are parents to any other views and if they are, that entity in the context is always guaranteed to be the right entity.
As far as breaking changes, you could cast it to (List<String>) and be just as type-unsafe as you were before. getStringList simply calls toString() on all the values.
Die Anführungszeichen um "Hülle" kommen an mehreren Stellen vor. Ich lasse es erst einmal so, da der Ausdruck nicht gebräuchlich ist und nur verwendet wurde, weil "Container" vorbelegt war.
dir("asdf")
type(5.0)
Overall I am really pleased with this approach.
blade is 6002 or 6102 I think. You could try backporting arcee's 2.6.35
module to 2.6.32.

The module provided by ZTE is compiled against the kernel source they
provide, so it will load in kernels built with that source as long as all
the related bits are configured correctly.

On 26 February 2012 22:43, Ricardo Pinho <
reply@reply.github.com
> wrote:

> It work well on the 2.6.35.x branch of the z71 kernel, but most use a
> 2.6.32.x kernel because the .35 has problems with battery drains (around 3%
> to 5% per hour). Blade uses AR6002 or the AR6003?
>
> I thought the source was needed to compile a module so we can link it to
> the kernel so it actually loads it.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/TomGiordano/kernel_zte_blade/commit/f4c15a5f8363cbb5400445c2b43ea464b6930a18#commitcomment-1012232
>
thanks :beer:
first of all thanks for taking out your time for trying it and comments
I posted it in such locations for some 3party review, so this type of comment is exactly what it was meant for.
Other ways didn't got such feedbacks... so it was worth.

The gem is half baked (not the algo), and  I'm building upon it. 
The 1st point is new to me, thanks for that. I was aware of 2nd and am in process of fixing it.

The performance bit wouldn't be much problem if you implement it 
http://justfewtuts.blogspot.com/2011/11/xml-motor-v003-mine-xml-once-multiple.html

> str = %Q{<root><a i="1"\nj="2">i=1,j=2</a>\n<a i=1 j='3'>i=1,j=3</a></root>}
> xNodes = XMLMotorEngine._splitter_ str
> xTags = XMLMotorEngine._indexify_ xNodes
> result1 = XMLMotorEngine.pre_processed_content(xNodes, xTags, "h1")
> result2 = XMLMotorEngine.pre_processed_content(xNodes, xTags, "div", "class='wanted'")
I looked in more detail at the pull tester and it was passing the Phobos unittests.  It was only failing the DMD tests, because they were using deprecated functionality, not because any bugs were introduced.  I merged it because I thought it would be trivial for someone the infrastructure already set up to fix these tests.  Since I appear to have ticked some people off, I'll take responsibility and make a pull request to fix the DMD tests myself.
Sorry to bump here, but isn't here an issue with the call to ```ofDrawGridPlane( scale,  ticks,  labels)```, but there is just ```drawGridPlane(float scale, float ticks, bool labels)``` that is defined ?
Why django_selenium, and not django?
I agree with abev66. It actually does not improve performance at all.
Don't disable LINT. Fix the error instead: https://github.com/hanging-gardens/hanging_gardens_registry/blob/master/reg/jquery-cookie/1.0.0/lib/core.js#L91
Please push the git tags!
This commit is bugged.

Please refer to https://github.com/in4systems/activerecord-sqlanywhere-adapter/commit/fe289e8a317d9c4b917d95e8988368fff742ed82
Теперь понятно. Закоммитил.
`return U.toJson(this, nodes, links);`
Your *old console based editor* is presented to you on a modern high-resolution wide-screen display ... :smiley: 

We discussed this some time ago and came to the conclusion that the 80-chars limit is a little bit antiquated today. I hope you do not get in :rage2: about it!
agreed, see comment above
Use `Y.Array.each()`, not `Y.each()`. `Y.each()` incurs extra function hops and hides whether you're working with an array or an object.
Might as well throw them away, or what did you have in mind?
I haven't seen Zend included as a vendor lib. How do you suggest to include it?
we can probably do the HttpBasedServiceCrednentials.getClass().toString ?
It used to be `{@link org.jasig.cas.support.oauth.OAuthConstants.THEME}`. Now it's `{@link org.jasig.cas.support.oauth.OAuthConstants#THEME}`.

Replaced the dot with the hash tag, so it becomes a javadoc link.
utils is not imported?
I've fixed it to understand both. Will push in a sec.
I agree. In a way this is monkey patching, but it should be done by the test code, not the live code.  I'm tempted to create a new issue for this, instead of fixing it in this branch.
asInstanceOf
Unit == (), use that instead of getting it inferred as when using {}
I think the idea is to cut akka-cluster.jar when we release 2.1 and mark it as unsupported/experimental
true


On Sat, Dec 8, 2012 at 12:20 AM, Viktor Klang (√)
<notifications@github.com>wrote:

> In akka-camel/src/test/scala/akka/camel/ProducerFeatureTest.scala:
>
> > +    var lastMessage: Option[String] = None
> > +    def endpointUri = uri
> > +
> > +    override def transformOutgoingMessage(msg: Any) = msg match {
> > +      case msg: CamelMessage ⇒ if (upper) msg.mapBody {
> > +        body: String ⇒
> > +          if (body == "err") throw new Exception("Crash!")
> > +          val upperMsg = body.toUpperCase
> > +          lastSender = Some(sender)
> > +          lastMessage = Some(upperMsg)
> > +      }
> > +      else msg
> > +    }
> > +
> > +    override def postStop() {
> > +      lastMessage.foreach(msg ⇒ lastSender.foreach(aref ⇒ context.parent ! (aref, msg)))
>
> for(msg <- lastMessage; aref <- lastSender) context.parent ! (aref, msg)
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/akka/akka/pull/933/files#r2355032>.
>
>



-- 
Raymond Roestenburg

code: http://github.com/RayRoestenburg
blog: http://roestenburg.agilesquad.com
twtr: @RayRoestenburg
book: http://manning.com/roestenburg
Ahh, don't turn me on like that...
.filterNot(mergedUnreachable.contains)
This more elegantly than

```php
$user = Auth::instance()->get_user();

if (! $user)

{
  // Don't do this as a fallback in the Session::get() call because it can trigger unnecessary
  // work.

  $user = self::guest(); //Guest user
}

return $user;
```
Yes, we could move it there. In io there is a bvecstxt module from Bago which I had a look at and later created those functions. So, I could put them back to io.  Module name btable.py in io?
if you have test_t_contrast_add then it should be test_f_contrast_nd_ols
Could these two routines share some base?
Needs documentation. Also need to actually create a function "cast" that has this as its cl_type.
ага, ну теперь ясно где это искать, ну кстати в данном случае я за первый вариант, как достаточно безобидный, по сравнению с хранением истории, там явно напрашивается join
There are lots of lines very wide, please stick to 120 characters if possible.
Putting spl.hostid under environment seems a bit strange to me, since it doesn't affect the environment. Maybe something like boot.spl.hostid is better?
Shorter: FetchCatalog()
Ah, the words! They make sense! Thanks, I honestly did not know how to describe that after thinking in code for a bit.
This doesn't describe what `cache` is or does. You don't have to explain that cache is interpreted as callback if the third argument is omitted, optional arguments always work that way in node.
Wrap the expression in parentheses. You won't have to use backslashes that way.
What do these changes have to do with the actual fix?
Maybe we also want to exten Iterarable<ByteBuf> ?
Won't this cause strange behavior if somebody is embedding the phpinfo() page in a page already overwriting window.onload? People are embedding phpinfo() in installers or configuration areas for different applications.
'Enable the debugger'
I was basing the assertions on the existing assertions.  I will add them.
Nope. That's the whole point of this pull request. Renaming a table in postgres does not rename any sequences that happen to be associated.

For example, in the tests, the table `test_models` gets renamed to `octopi`. After the table rename, the table's ID sequencer is still named `test_models_id_seq`. Hence the need in postgres to rename the sequence as well.
I think the text could be joined together as a paragraph, with your fixes. Also, please squash your commits into one. Thanks.
The object isn't invalid until it is saved here.
@drogus 
I've tackled this issue a few day, and my answer is https://github.com/kennyj/rails/commit/5fc8bd06a9af3e95f454ef2a2fd9fab47d6cd48b .
I tried to change a behavior of stale_target? method. But its changing impact is greater, and I couldn't change it ;-)
Thanks for that, it was in my todo list for some time already :)
@fxn you are right. I think so.

@carlosantoniodasilva thanks for your reply. I'll try to remove unused variables for testcases.
Sorry, I didn't explain fully - before we get to this point we need to fail if the response was a redirect
The only reason is I saw it's frozen in actionpack/lib/action_dispatch/http/parameter_filter.rb, so I did it just to be consistent.
Create a dummy socket and pass sock.fileno() here. Otherwise the test will not work on Windows.
Here some imports are missing:

    from scipy import signal
    signal.lti/bode
    import matplotlib.pyplot as plt
    plt.semilogx
Ok, then when should wrap it in a paragraph instead of a h6
They are still there.. I just moved them up in the file so they are closer to the rest of the map properties.
On 11.05.2012 14:18, raoulb wrote:
>> @@ -50,7 +50,7 @@
>>       "Shi":"shi",
>>       "Chi":"chi",
>>       "Si":"si",
>> -    "Ci":"ci",
>> +    "Ci":"ci"
>
> Do I really have to undo this now?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sympy/sympy/pull/938/files#r808348
>
I guess not
This assert statement is not a very strong check. There are many things that it may permit even though they would result in garbage output. Do we care about this?
I think you can change the ``>>>`` to ``>>`` and it won't run the doctests, tho I'm not sure what that will do to the sphinx docs.
Is this useful for ImmutableSparse as well? If so should it be part of SparseMatrix
Just a question for understanding, why are booth classes in one file as CActiveFinder only requires CActiveRecordArray if 'isArray' is true (if I haven't missed something.)
I only fix conflict with line below it . if condition is empty data then we don't need if (!empty($this->Controller->data))

`
			if (!empty($this->Controller->data)) {
				      $this->Controller->data = array_merge($this->Controller->Session->read($this->sessionPath), $this->Controller->data);
			} else {
				     $this->Controller->data = $this->Controller->Session->read($this->sessionPath);
			}
`
Since these three numbers above are mutually exclusive perhaps they could be combined in to one?
what are the semantic implications of returning None instead of "" here?
yes probably good, forgot to disengage hacker mode
It is - it seems like there's only one subclass instance of AbstractMapJoinKey for any # of join keys. For one/two keys, the key objects will be wrapped in MapJoin(Single/Double)Key, and for > 2 keys, the key objects will be in an object array wrapped in MapJoinObjectKey.
add an ignored test? :-)
I would have used the `abort()` method instead (so that you can also remove one use statement).
Yikes, there was a couple lines that had spaces instead of tabs. I don't know how I missed this. I'll fix it quickly. Looks like 4-6 lines that had spaces instead of tabs.
Nice clean up as well.
Is there any reason to restore it? Otherwise just set it to false afterwards, that should be enough.

While at it, could you also edit the commit message? Let's stick to this format: http://wiki.jqueryui.com/w/page/25941597/Commit-Message-Style-Guide
ну и html5 заголовок, а то используете html5 теги например <footer> а доктайп XHTML 1.0
You might want to make this affect only the main password field, and add a separate check for the confirmation matching. Of course, the other check should be triggered when typing to both the main field and the confirmation field.
Used this scaling strategy in manual testing to avoid actually spinning up new nodes. Agree that it should be part of unit tests.
depends on how structured you want it - if you use backbone it's more of a minimal mvc.. otherwise you can use ember or shipyard
Hmm... probably leftover from a change I made earlier and never removed it.
It might be cuased by the collation
hm... Ok
this was just moved from 3.0, so we haven't made all of the php5 changes yet.
When joining two or more tables the namespace is gone...
I just untabbed the code. everything about changing the code in here should have another ticket
Ideally the file driver would have no clue that it is caching data returned from a SQL database. This should be addressed but might require major changes in the sql cache (e.g. it should still be possible to drop all cached data associated with a specific table).
https://github.com/phpbb/phpbb3/pull/1100/files#r2381657
@p Rather than duplicating the name in services configuration and task implementation, the name is now simply passed to the task from its service definition in the dependency injection container, hence it's become mutable.
Should be $this->port
Also, is there a reason this class cannot be made into a service, instead of passing the container into it?
când request.method e 'GET', va da eroare, pentru că nu returnează nimic și nici nu redirectează
aici cred că trebuie adăugat external_id=level.
Inline стиль это плохо. Плюс, не порушат ли такие стили версту bootstrap, например при размере экрана меньше 1000px
"where the bed the bed is at" - maybe something like `The location of the bed"?
Indeed this is what I did in the past in many of the nix expressions I
authored (including this one).  But later I noticed that it is often
annoying when you want to cut&paste the url (e.g. to call wget or
nix-prefetch-url).  Moreover, this make the code a little bit longer and a
little bit less clear for little value.  I don't have a strong opinion on
this matter and I understand your point, but if no general guidelines
enforce this, I prefer this style.

2012/9/4 Michael Raskin <notifications@github.com>

> In pkgs/applications/science/logic/isabelle/default.nix:
>
> > @@ -12,8 +10,8 @@ stdenv.mkDerivation {
> >    inherit name theories;
> >
> >    src = fetchurl {
> > -    url = http://isabelle.in.tum.de/website-Isabelle2011/dist/Isabelle2011.tar.gz;
> > -    sha256 = "ea85eb2a859891be387f020b2e45f8c9a0bd1d8bbc3902f28a429e9c61cb0b6a";
> > +    url = http://www.cl.cam.ac.uk/research/hvg/isabelle/dist/Isabelle2012.tar.gz;
>
> Maybe even use version here, too - so that name and actual package do not
> get out of sync on the next update
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/NixOS/nixpkgs/pull/122/files#r1522282>.
>
>
while, getDate() and getFullYear() responds the same way it should. 

I guess, it's the right time to figure out areas where else getMonth() is wrongly used in our system.
Did you test this by searching for a drug which *doesnt* exist, to verify that it fails? 

Just want to make sure, since if getStore doesn't find a store, I think it will return NULL... which in javascript is "sort of" greater than -1.
http://stackoverflow.com/questions/2910495/why-null-0-but-not-null-0
ok i do..
this file should not be deleted.
A result of the now sorted attributes in _xml_id().
Same attributes changes as above.
I think this has been sub-setted too much. Scientifically, it is not an appropriate representation of the data that it claims to be.
This is where #52 is needed. The code is commented out, ready to use after #52 has been brought in.
what does `_setDomainName` actually do?
Yes. I see now that this case is covered there.
I love this change. Awesome.
I know this was broke when you found it, but we prefer the .h corresponding to a .cpp to be the FIRST header it includes to ensure that the header compiles "on its own" without prerequisites.
unix/linuxでファイル所有者とapacheユーザが違っても使えるの？エラー出ない？
renameできるならrm -rf したほうがユーザにとって消す手間なくていいんじゃない？
"please read about django fields to know how they work exactly"

Also, don't just say "wrong", say what is wrong with it, because it is not obvious here.
Drop the "is_", it should simply be named: venture_and_role_exists
If you explicitly instantiate a form field like this, Django assumes that you want to completely define its behavior; therefore, default attributes (such as max_length or required) are not drawn from the corresponding model. If you want to maintain the behavior specified in the model, you must set the relevant arguments explicitly when declaring the form field.
These calls just before the `prevent_keepalive/0` calls are not necessary. `prevent_keepalive/0` sets a flag to tell Mochiweb to close the socket at the end of this request, instead of attempting to try to read another request.

…on the other hand, we will need them once we implement a better fix than using that flag, which is an undocumented Mochiweb feature.
brief is good - params/return directives are totally redundant with your brief.
Well, the original plan was to have this in 1.5 and develop the migrations as a separate app that could then just be dumped into contrib, but it's become apparent that migrations are going to need more extensive integration into Django, so I'm not sure what rushing this into 1.5 gains us, whereas if I merge it in just after the 1.5 branch there's loads of time to then fix up the cache stuff, change the field APIs, and get a decent migration runner all done.
I don't think having `.html` file extension in your django app urls is *silly*, while having `.php` ones definitely is imho.
as is, for
I think I would drop assoc-set entirely.

``` clojure
(ORSet. (dissoc m elem) (update-in t [elem] union (get m elem)))
```
I see. In that case, your fix seems best.
I explicitly removed the jQuery.css for performance. This is a tight loop in animation.
I can think of sufficient plausible (if unusual) reasons for keeping it as a property to prefer it that way:
* measuring actual frequency
* calling a `tick` early
* suppressing `tick`s
* conditionally ignoring or inserting a special Tween
* forcing `percent` for manual step-throughs
* animation overrun/indefinite duration
> `$.ajax()` is providing the functionality, not `$._evalSrcHook()`. `$._evalSrcHook()` is nothing but a few lines of code extracted from `$.domManip()` in order for them to be overriden. A thin wrapper for a narrow use-case.

Right... if `$.ajax` is not available, we need the manipulation to fail in a way that devs can prevent by providing a definition for `$._evalSrc`. I don't think we disagree here.

> If we remove the ajax module, `$._evalSrcHook()` is still needed

No, a *call* to it is still needed... but the functionality itself must be provided by someone else. Why would we define a method that is guaranteed to fail?

> If we remove the manipulation module, it is not needed anymore because it is not used by any other module in the whole library.

The manipulation module is not excludable. Making it so would be a tremendous effort with little obvious benefit, especially since we use it so much internally. Your points become much more germane if we ever get to that point, but right now I'm just not seeing the value.

> If you put them inside `$.domManip()` where some undefined method is called, you're really not showing them much love.

I started out disagreeing here, but there's such a small difference between the two approaches that I'm now neutral on it.

> It will fail silently for cross-domain requests to non-CORS compliant servers is a big issue) but it certainly isn't helper material, not in the slightest.

**+1**. The former in particular is a problem right now, and might even be big enough to drop this crap completely.

I've already put far more effort into this than I think it's worth. Forgive my short reply here, but I doubt that either of us is going to convince the other. That being said, it's obvious that you care about this much more than I do, and I have no *strong* objections to seeing the hook in manipulation.js. Does someone else want to weigh in?
Fine, but why? This is most definitely a problem elsewhere (a test leaking or the global being defined some place outside of test) that has been shadowed here. If the global wasn't detected as leaking, I guess it means the latter?
Firstly, some papers use median and some others use median. Median is not explicitly superior to average.

Secondly, I don't know a median implementation in gpdb that runs as efficient as average.
You are right. If the sql is wrong, the execution above will pop an error. As a result, I removed this check.
I'd change this comment to:

```
# TODO: change to route based on user agent.
```

It's easier to find TODO items marked as such than it is to parse comments like this.
Typo'd.

Should read "Is the system version not enough here?"

OS X provides libxml2, so we usually add a comment like `# system version is too old` or something if a newer version is necessary.
Do you seriously think that the performance hit will be noticeable when compared to compiling source code? If so by all means do a benchmark, I will eat my entire wardrobe of hats if there is a difference greater than 0.1%.
Use https for github checkouts, and the `:using => :git` isn't necessary.
This won't be needed anymore because we're hosting the api at a subdomain rather than a url
possibly: min([int(x) for x in days.split(',')])
I think we should have an option in __init__ for this and the ability to read it from config.
We're going to return an array every time, so the value in this loop will never be nil or false. Seems more semantically correct to make it `Enumerable#each` though, since we are not relying  on the functionality of `#all?` any more.
Change to `${_("compare selected")}`
It actually does...removing
Oh, yeah, no problem.
I noticed you didn't use double brackets anywhere, I guess you did that for compatibility reasons. That's why I avoided using the regex operator =~ with these ifs.
nm, this is just uncommenting.
Using a special variable RET does not look very nice - maybe use echo ... or setup $@ instead?
It looks like `IOException` would be consistent with what JDK7 would do:

http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#createFile(java.nio.file.Path, java.nio.file.attribute.FileAttribute...)
Please update error message.   Trying to set [...] but it is not accessible.  Please declare the field public.
Cases should be tabbed from the switch statement.
yep. I'm nuts about code neatness.
Awesome comments! :D
Very cool!  I think this is worth doing a 'pattern of the day' on at some point -- I bet not a lot of people other than Jason know about this.
In the future when the tree supports multiple selection we don't want to deselect all here in order to allow the user to shift-select multiple files and execute a command from the context menu. Maybe leave a comment about this here for future reference?
Ah, yes. I meant ``measure: measures``.
I agree with you for clarity, but there will be a JSLint error saying ["all"] is better written in dot notation. And I can't find any JSLint option to suppress this type of errors.
For consistency it would be nicer if everything went through callbacks where possible, so could we do `callback(frame)` instead of `ide.dispatchEvent(.....)`?
If you're going to stick with regex: 
 - Sanitize/Escape your inputs
 - No case-insensitive flag
 - Use the newline-safe `\A` and `\Z` beginning and end anchors 

```ruby
re = /\A#{Regexp::escape(queue).sub('\\*','.*')}\Z/
```

either way, the way you're chaining methods on the tail makes me think you're not entirely sure what's getting returned. How about this:

```ruby
  def wildcard_queues(queue_with_wildcards)
    re = /\A#{Regexp::escape(queue_with_wildcards).sub('\\*','.*')}\Z/
    Resque.queues.sort.select{ |queue| queue =~ re }
  end
```
I didn't catch this the first time around, but `String#gsub` is likely a better bet, since it would allow multiple substitutions.

I *really* recommend at least taking a look at `File::fnmatch` though. Why not use a built-in, well-tested method that does the same thing and much more? Re-inventing the wheel is not generally a good idea.
could be further reduced to return {"domain": None}. which then causes me to wonder why this function is needed at all
This is a helper class, which each of the three original functions in this module calls. I took care to leave the API of this module the same as before, except that I got rid of `version` because 1.x is not supported.
Rename firstLimit (see above).
I know that. What I meant was that in java a ```long``` is auto-magically widened to a double. This is valid java:
```java
long l = 42;
double d = l;
// the cast below is not needed
// double d = (double) l;
```
Your cast is valid but is just visual pollution:
```java
mapControl.getMapTransform().setScaleDenominator(newScale); // OK :-)
```
I don't understand the problem? Something is a form and something is a view? Those are two different things. ;-)

Now we are using class-based views so it is enough just to tell which form to use and everything else is done automatically.
I meant email :)
Maybe `"flickr.com/photos/"` should be specified at the top like these: https://github.com/mozilla/butter/pull/1007/files#L6R11
Same question here..
Oh I see... maybe the qualified name for `Data.ByteString.Base64.URL` should be `B64` or something. I was confused by this... Coolio though
The above two lines should get indented 2 more spaces.
Je pense que ça porte mal son nom. Je pense que ce mapper doit avoir deux fonction : ban et unban (ou quelque chose comme ça).
That's a GitHub-ism. Just look for a username there (we probably ought to have a URL parser somewhere.)
Rather than using 'demote', would recommend something like:
"Using a changeset, please delete the repository from existing environments before deleting it."

Ideally, it would also be nice to give the user a little more information on which environments it needs to be deleted from (or possibly a count); however, if they can easily retrieve the list using content search, that may be sufficient.
Let assume my upgrade log path will be set to "/mnt/samba/Profiles/Miroslav Suchy/logs/"
Not sure if @path can contain spaces too.
Maybe we could extract this duplicity
you can remove all these annotations. It does not add much value and makes things harder to maintain the testsuite
Sure, though I'm sure we'll only ever have one hehe.
You better include gems in gemspec file. Gemfile should stay unchanged since gem was generated by bundler.
I just realized that the current implementation will (for some time formats like TimeJD or TimeDeltaJD) just use a ref to the user-input `val` or `val2` if provided as `ndarray`.  This seems bad.  The reliable hammer approach would be to a make a copy of the user input in `_make_1d_array` at the expense of potentially creating an extra temporary array for other formats.  The less-hammer approach would be for each TimeFormat method to be responsible for making a copy of it's inputs as needed.   This requires developers to remember to do this.  I guess the third way is to have the input data validation method of `TimeFormat` (mentioned in a comment below) which is adjusted as needed.

Thoughts?

@mdboom @astrofrog @iguananaut  @eteq
Instead of being an argument to `convolve_fft`, can you make `use_numpy_fft` a `ConfigurationItem`?  perhaps similarly with `nthreads`.  They are both more about configuration than about the actual function's action itself.  To see how to use `ConfigurationItem`, see http://astropy.readthedocs.org/en/latest/configs.html#for-developers (or just ask me if that isn't clear)
写的时候我其实还是支持用方法替代key，把hook作为数据存起来的需求我觉得。。感觉会很混乱

读优化的角度上，是个方法我读起来就非常顺畅，写起来还有自动提示，既不用去记顺序，也不用去其他
hook里面copy一组key过来。
Is there anything you know about that uses `status_v2` that would be affected by the renames here? Stands out only because it's a versioned record. On the other hand, I can't seem to find anything in Riak that really does much with this record. So, no idea.
Maybe `UseProxyFor` ?
Ahh, Hungarian.

Since it's user facing though, I'd still use the english writing convention of n-required for the rpc docs.
Shouldn't we add it only for openbsd, then?
A mistake indeed.
Also not sure if this boolean try to empty string conversion is necessary. Can just directly specify separator like `array('separator'  => '')`.
You can use either null or false to denote no separator.
Isn't this a behavior change as well, the count could be > 1 now and pass.
It'd make more sense to do that the plugin's `init` method.
It doesn't, if you already have some text in the box (assuming it isn't a slash command) it will prefix it with `/msg <username> `.
Yeah, I will eventually do that :)
The ids on the ranges are no longer needed.
Ditto: https://github.com/forkcms/coding-standards#13-indenting-and-aligning
There is no loading of parameters.yml before going through the autoloader, which cannot autoload anything without these two constants present.
Because there is no globals file present when Fork is not installed yet, I have to provide this fallback for the autoloader to work during the Fork installation process.

It's either this or moving the constants out of the autoloader and replace them with their values inline.

@tijsverkoyen requested to leave the loading of other parameters (besides database) for later btw, [this is in a comment](https://github.com/forkcms/forkcms/pull/323/files#diff-46) further down below.
Just use `_checkinOptions.CheckinComment` directly, or set shelveset.Comment equal to the return value from the function call. That temp variable is a waste.
I really don't see the point of using `package.skeleton`, and I'd much rather just do everything ourselves.
python can detect the platform it is running on (see http://stackoverflow.com/questions/1854/python-what-os-am-i-running-on )
You could define the  default-command in a case-statement, something like:

import platform
case platform.system() in
    Linux) gxmessage...
    MacOs) growlnotify...
    Windows) whatever...
What do you mean by L3 and L4?

I've used camelcase because there are other names like makeDisposition, so I followed that style.
These changes also need to be made in sandstone-resp.less
Could you add a comment explaining that we want the cache to be disabled and a link to the bug?
This will only work if the array is sorted. We don't care much about ordering, so this might be headed in the wrong direction. 


R-
This line is too long, split it or use variables
I liked this. What ain't broke....
This is a good idea, and now captured in issue #44.   In order to work in the usual workflow the bash script would start getting too complicated (for me) so it'll be something in Python.  It needs to support configurable start and end times.
What you have here is good for now. If you want, we can profile this later and see if that is indeed a hot spot.
Note to myself: Clean up
There are several of it, like every ExceptionInterface.
adds overhead, but i guess we still work with the assumption that we can afford overhead during the compile phase?
@ircmaxell just FYI. we put the variable OK on the right as a defensive programming approach. as you type it a typo could turn it into an assignment
Exception message is wrong (property).
http://www.scala-lang.org/api/current/scala/util/DynamicVariable.html

Think of it as a stack. Everyone with lexical scope (e.g. is in the same class) to see the variable sees just the topmost value. Calls to withValue{ } push onto the stack going into the block, and pop off the stack when exiting the block. This way, you can have code inside your class that just calls for the current value and doesn't need to worry about the particular code path taken on the way there.

I was thinking about adding a withValue { } block around most of the apply() methods, and would be happy to do that.
not a fan of the magic constants for view.tag recognition... done quite often in the code base.  can these be moved to #defines in the relevant header file?  something to consider for future standards at least.
stojce took a look at the casing and decided it was consistent with the rest of the dialog buttons.  leaving for now.
uncommented and raked
Yep good call https://github.com/yammer/sched.do/commit/9abf8a1fa0c1a64f8c8779c202879a0a8b0594f7
This may also be available in the FreemanChain class.
Alright.  The WHO reply is weird (who decided that the hopcount should be grouped with the gecos in the same parameter, anyway?), so I didn't know if it'd be a problem in that function.  I'll adjust that now.
But that one, in ops log.
Fair call. Will do.
If you push any changes to your branch, the PR will get updated.
I was debating whether to put the API Verifier in a separate module but didn't want to create even more repositories. So I put this link in as a stop-gap measure until we get a chance to talk about it. Sounds though that setting up a repo for the API Verifier is the lesser of the evils, so I will make it happen.
We'll definitely want to add a section about the return values work. Not everyone has experience writing custom sorts and will know what -1, 1, and 0 mean. Otherwise, looks good.
Thanks for the feedback, Brian! I have a question about this. It looks like HostControllerInfo.getNativeManagementInterface() returns the logical name of the interface (e.g., "management"). How would I go about getting the actual IP address that corresponds to this interface?
This kills all domain integration tests....
Replace DESCRIBE operation on rootRegistration with
rootRegistration.registerOperationHandler(DESCRIBE, GenericSubsystemDescribeHandler.INSTANCE, GenericSubsystemDescribeHandler.INSTANCE, false, OperationEntry.EntryType.PRIVATE);
I'm just going to @Ignore this test class.
Won't this proxy itself over and over for each element? We're inside a `this.each()` where each iteration is using the same `options` object.
You should add `grunt-cli` to the package.json file so users, including Jenkins, can run `grunt` after `npm install` and be certain to have the right one.
is this a placeholder for something we know we need, or just for the future in general?
Needs an `isset` or `empty`, also does not match coding style (needs spaces after each parameter comma).
I think this still makes sense in ParserUtils, as it's not terribly related to timestamps.
For painting messages I need it in reverse way than data from DB. I will check if 'reverse' API call is working and if It is I will remove in next pull.
Would 
    
    Places.removeBookmark(this.currentTab.url, this.refreshBookmarkButton);

work / be cleaner?
`<i>` is not the correct markup there.