labofsahil/github-event-dataset-2012 huggingface dataset:
I do agree it makes it a little hard to find all of the edges without the diagrams.  I didn't change much here.  I think this is worth an issue, to investigate alternatives at least.
But, isn't the top-level actor the next bottleneck?
Apart from that this pattern is not usable for bulk-operations. In that case a parent actor should create/call/initiate the actions.
The issue of a bottleneck might not be the question. Anyway I will present a solution as you mentioned.
Good question. Bigger question. Discussed with Roland some time ago. Currently a cluster can include multiple actor systems, but this should be changed to only allow a single one.
Yes, that's the intention as stated in the pull request comment.
It looks like this isn't actually working.  I think this may be at the root of some rule cache bugs.  What I think is happening is that when it iterates through cards via wql (item_cards), that it doesn't seem to be finding the locally cached card that was accessed above, it has a different object_id, which I don't think it should have.  Theoretically, it could be being re-created from the external cache or db, but I think that is unlikely.

Any thoughts?
Again, the use of the bitwise and `&` operator is not recommended here. Another way to write the expression is the following:

`is_SA_between_05_1 = isinstance(imt, SA) and 0.5 < imt.period < 1`
Probably it's something else
I think I will remove this section entirely. Might create another class for q-space at a later stage. Otherwise I think it will be difficult to explain and connect at this point.
yeah I was just looking at the diff on this pass and some code appeared to have moved there :)
I like the renaming to _LOG, it fits much more in line with our current conventions.
For task groups, all tasks are always returned, even the completed ones.
The display_status will display the completed task information once, which means they'll see the sync info on a status even if it's completed and the publish is the one that's running
Might want to sleep before logging the retry so anyone tailing the log wont think it's retrying when it actually sleeping.  I'll have to rely on you judgement as to whether the random sleep time makes sense.
also agree that we need a broader pattern for translations.  At this point these cards are just a glorified hash of { codename => name }, right?

if it would speed up integration, would you be willing to consider just doing this as a hash until we better English plans?
(I get where the id is going in now, but if it's only in @local, it still seems like the deoptimization comment applies.
Lets not name things that arent actual <iterator> objects, "iterator"; Also, you surely love these deepcopies...
utils/output.js has been removed.  Either use `console.log` for "normal" output, or require("npmlog") for log output.
These are two words -- they should be separated by an underscore (i.e. SYNC_FLAGS).
Default is 15_MINUTES
Use errors! pattern like signup and make sure user_errors functionality is rolled in.
This might read better as a guard:

if pid:
   self.children.add(pid)
   return
This seems odd to me. 
The default decommission date appears to be the time of initialization. 

Shouldn't the default be the end of the simulation? 

You may have meant  
```
setDecommissionDate(TI->simDur())
```

Please let me know if I'm off base.
It may be better to have the date in a more standard format, say ISO8601:

request.user.localtime(t).isoformat()

It probably makes even more sense to always render in UTC and let the receiving application do time localization if it feels it necessary:

t.isoformat()
this will throw a notice if the namespace is not initialized yet
Can you please change this to use dot syntax, to match the lines below?
If the click count is _less than_ two, it should not be a repeated mouse down event.
I use this indentation code in my application- it forms a very visually appealing source list. It's just that there are no pre-configured elements to see it in use.
La classe est utile?
Minor style nitpick: comments above code line.
Fixed.
Since I need to ensure that the order is consistent between calls, I think I should use:
```
n_inds = list(enumerate(excluded.intersection(range(nargs))))
...
    for _n, _i in n_inds:
```
won't this change INI_STR("sendmail_path")?  (at least if !rpath || !rpath[0] )
That doesn't quite work, because `original_time` is used later in the method, both in the `if` condition testing for a change, and as the value for `write_attribute`.

I could change it to `original_time = original_time.presence` if that's preferred.
I don't see a default value for `config.assets.clean_after_precompile` set, so cleaning will happen by default. We keep old asset digests around so stale references to them still work (such as assets referenced from old emails)
Just a PR away.  :-)
right, I'll write some proper docs and submit a new commit
`typedMacroBody` features a lot of validations and very often subsequent validations need preconditions established by previous validations.

Therefore I either need to introduce a bunch of `hasError` checks everywhere (which leads to spaghetti), or I can implicitly replace all those checks by having failed validation throw an exception that is lives exactly one stack frame.

Speaking of placement for `MacroErrors`, the `MacroXXXError` methods do issue type errors (they just throw the exception to indicate the necessity to bail). So I think this is an appropriate placement. What do you think?
hmmm...why does this fail?
Maybe better to say "a *generic* Symbol".
I think this should be tested (or did I overlook that?)

On 29.03.2012 14:56, Matthew Rocklin wrote:
>> +>>>  square_iterable = iter(squares)
>> +>>>  for i in range(4):
>> +    ...     square_iterable.next()
>> +    1
>> +    4
>> +    9
>> +    16
>> +    """
>> +    def __new__(cls, lambd, base_set):
>> +        return Basic.__new__(cls, lambd, base_set)
>> +
>> +    lambd    = property(lambda self: self.args[0])
>> +    base_set = property(lambda self: self.args[1])
>> +
>> +    def __iter__(self):
>> +        return (self.lambd(i) for i in self.base_set)
>
> We now keep a set around and check if we've seen the return value already.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sympy/sympy/pull/1155/files#r621095
>
I think at the very least unit_triangular -> triangular. What exactly is the definition of unit triangular, though?
these 3 lines can be merged as `border: solid 1px #B0B0B0;`
Need `#` here.
I think we should start doing it. There are excellent wiki articles and other resources explaining things in detail. Still these things are a bit too much to be in the guide itself.
Should test inherited fixtures as well.
Since `key` is no longer explicit in the args, it would be a good idea to add to the docstring of these routers that the "key" used is the first value in `args`.
Come to think of it, probably not.  In a private repo, you may be asked to enter a password, but this is a public repo. My bad.
I'm new to this, but a not so simple way would be to add a method like Pimple::share that scopes to the request, e.g.

``` php

 class MyApplication extends Application
 {
     public function requestScoped(Closure $callable)
     {
         return function($c) use ($callable) {
             $request = $c['request'];
             static $services;

             if ($services == null) {
                 $services = new SplObjectStorage;
             }

             if (isset($services[$request])) {
                 return $services[$request];
             }

             $services[$request] = $callable($c);
             return $services[$request];
         };
     }
 }


```
Use if/else here.
at line: 79
    ::FileUtils.mkdir_p PID_DIR
concider remove redundant :: and use:
     FileUtils.mkdir_p PID_DIR
Could it be slightly awkward, not being able to explicitly ask what the hard and default limits for a domain are? Since the effective limit depends on the system hard limit, the domain hard limit and the domain default limit, it seems there could be potential for frustration at not having visibility of the values of each. Maybe a nice to have?
I missed that one?? Will definitely add it

On 20 Oct 2012, at 05:39, Ben Hood <notifications@github.com> wrote:

> In kernel/src/test/scala/net/lshift/diffa/kernel/config/WindowRefinerTest.scala:
> 
> > +    WindowRefiner.forPeriodExpression("")
> > +  }
> > +
> > +  @Test
> > +  def shouldAcceptEmptyOffset() {
> > +    try {
> > +      WindowRefiner.forPeriodExpression("P1D").withOffset("")
> > +    } catch {
> > +      case ex: IllegalArgumentException =>
> > +        Assert.fail("Empty offset was incorrectly rejected")
> > +    }
> > +  }
> > +
> > +  @Test
> > +  def shouldAcceptDateOnlyRanges() {
> > +    WindowRefiner.forPeriodExpression("P1D").refineInterval(null, "2012-10-10")
> What is the expected result of WindowRefiner.forPeriodExpression("P1D").refineInterval(null, "2012-10-10")? Could this not be put into the test function as an assertion?
> 
> —
> Reply to this email directly or view it on GitHub.
>
This should not be here anymore?
Please use double quotes like `“Sent messages”`
I don't see why this should hold up the merge but I do agree that the template engine should be usable standalone for reasonable definitions of standalone.

I'm still not completely certain what it is exactly that needs to be done code-wise to address your comment.
perhaps we should update the initialize function to create an dummy callback when it's nil?.  the :rebuild function could act the same way.
test should check value of `err` here?
I believe these 6 states will work out: 

    Default, Handshake, Deactivate, Primary, Running, Done
My bad, sorry :)
This condition can be replaced with:

`dir = Y.Array(dir);`

which guarantee an array as a result.
I have corrected it! Sorry! :-(
I will investigate as soon as I can find the time, and will fix what needs to be fixed. I did my change to make things backwards compatible, but a newly compiled unit tests might not expect the new behavior and fail for that reason too. I need to understand what happened first...
do you use ```l```?
Use newPatientUuid here and below x4 times
Definitely wrong commit, needs to be fixed back to HOST. Cannot hard code HOST name
I know you've inherited them, but the file names in the Iris examples are crazy! The complicated directory structure stuff is just an artefact of the original data zoo. We need much more user-friendly names. E.g. perhaps just "VAAC.txt" for this one, or "NAME.txt".

And certainly, there's no need for any of them to have a "_subset" suffix.
Would the fix just to be to use ``sys.maxsize`` here as well? (may need to be careful about the string conversions though)
You don't know that z or b are contiguous, so memset should not be used.
Couple of typos in that sentence:
- *to* the end
- remove the second ``file``
it crash, I'll fix it.
I should also add that "bug" was the wrong term for this, it's mainly a lack of planning in the C interface, and you're probably right that it is not localized to this one function.
runner.call_proc() aborts on failure with a message including the response.
all tests are ok,
Using active read repairs was discussed, unfortunately it was brought up after freeze deadline, so it's been slated as a future improvement.  If there are more gets active than the hard cap, there is a 100% chance that a read repair will not happen. It is a trade-off, as one would rely much more heavily on AAE if the system is loaded enough to constantly skip read repair.
If all autodoc is removed now, we can remove this, too. Including the `settings.configure()` call.
Good point - I've just made this change.
My bad, it was such a long time ago I last read that issue that i remembered it backward. will reset to remove the second dispatch rule.
is a good idea to wrap this into a context manager `with TDS1012(args.port) as osc`:
This should be an empty object for consistency.
Two points:
* The existing logic ensured a numeric `percent` in all cases, but this change makes it possible to get NaN. I don't think we care, but it's worth pointing out that there is in fact a functional change.
* I was unable to reproduce your problem with the emulated sub-2.3.5 clients available on BrowserStack... could you be more specific about the error you encounter? Could it be fixed just by wrapping the division in parentheses instead of introducing a ternary expression?
Two more bytes could be gained by replacing this test with `if ( tuple[ 3 ] )`, but that would be ever-so-slightly slower and make less obvious the acceptability of `tuples[ 1 - i ]` three lines down. For that matter, the `1 - i` there could just as easily be `1 ^ i` or `i ^ 1` without changing file size; I just think those are a little bit less clear.
`ns` is leaking globally because you've not initialized anywhere
@gibson042 @mikesherov - I think you two are the only ones who might be able to give a solid opinion on this change.  I moved `tick` outside of `animation`. I don't think it needed to be in there for any reason.  It is still possible to override with your own timer if you use a prefilter.

Any thoughts?
This is odd.. why instantiating this? The classmethods can be called without instantiating:

atomac.NativeUIElement._getApps() for example.
Patch looks fine, apart from this strange duplication of the error.
Why not at least have a link to mopidy.html page, would be nice as simple way to get people to where they need to be to see if this is working. Or you could even go all out and have the same type of demo content in this placeholder.
Is the Apache license compatible with Fjord's License?
Out of curiosity, why move about to the bottom?
`1>/dev/null 2>&1` (as it was before) is fine.
@Sharpie setting these should not be necessary or am I getting it wrong?
rather use `//` for one line comments (please)
touche!  I didn't realize that when I setup appraisal in that project.  It'd be interesting to see what thoughtbot recommends in terms of whether or not to commit the lock files to source...
新しく作るところは出来たらforn_forとsearch_logic使う形に出来たらいいなぁと思いますが、難しいかもしれないですね
Ok going back over this I think we're ok. This file is for performance testing. The itest.erl file has more cases, including going over batch boundaries.
It's not the jurisdiction of the importer to track what's been orphaned. The Pulp database is the knowledge base for what's in a repository. If a distributor needs to know the difference from one publish to the next, it should be tracking any extra information it needs rather than relying on a separate plugin to provide that information.
That's not actually the link to the user guide, is that what you intended? I think what you have makes sense, but wanted to double check it wasn't a placeholder.
More repetitive code that could use some meta-programming to DRY it up,
@daniel-uzunu: this line contradicts the description of the ``_createCustomRequest()`` method. This says that there won't be any request object, and the other one says that it exists but only contains the session
確かに。
How about "Attached links to files below the base directory will be stored relative to the base directory."?

If there's room, we could even continue with something like this: "This allows you to access linked files on multiple computers that have the same files in different places." ("in different locations"? "in different filesystem locations"? "with different paths"?)
Comments for inc are not enforced. Remove or fix?
Done and done. Thanks :)
Nice solution to the chrome file:// loading problem!

This wording is a bit misleading - it implies that it is possible to run Brackets in a browser, which isn't true yet. I think it would be best to stick with the same wording used in the other dialog: "Oops! Brackets doesn't run in browsers yet. ..."
This line is giving a JSLint error. It should be `window.setInterval()`.
Global find/replace error. The first parameter needs to stay the same:

.replace(/'/g, "&#39;")
It would be nice to have a documented public constant.
Please use "```ruby" here instead of indented code blocks.
Sorry, I could have been more clear: “hyphen” would be a better variable name, since the code isn’t dealing with dashes. A dash is something completely different from a hypen, and modern programs do deal with dashes sometimes, so it may be good to be precise in the language, and call a hyphen a hyphen.
Pass and use also size in the template.
The second argument is unnecessary. Put that into TODO if you want. :-)
same as above, no vendor prefixes necessary
Mind removing the `text/javascript` to make these all the same stylistically?
Why use ems?
If these are the plain @VERSION@ strings, I wonder if we should use Date.now() too?  Something like:

butterVersion: Butter.version === "@VERSION@" ? Butter.version + " - " + Date.now() : Butter.version;

And same for Popcorn.version.  This way we at least get some historical sense of what you were looking at when you ran the test.
This doesn't look right to me. The path above looks relative to /src, but this path is relative to / ?
This should probably be indented again.
Yeah - I guess that's fine then. If we're using an external lib it's a good idea to go with the conventions that they provide for us
__name__ instead of "geonode.people.management.commands"
カンマの後にスペースつけてください (see PEP8)
minor: definition vs devfinition
Please wrap these messages in _() for localization
should this be notify.exception?
This is just proposed way to do it, those messages could be a bit longer, so it would be more cleaner to define them off-code.
Spacewalk?
Also add a "the" before the word Library?
minor mod
```ruby
readable = Repository.enabled.libraries_content_readable(current_organization).select("repositories.id").collect{|r| r.id}
```
`and` has a greater precedence than `or`, right?
Maybe we should report the statusText as well whether or not the responseText is set.
> Actually, reading this discussion a little more carefully, I'm actually not even sure anymore who's saying what or who I agree with. So I'll just say that there's nothing wrong with Coordinates(blah blah blah, system='foo') returning an instance of a subclass of Coordinates. It's perfectly fine to do that in this case in my opinion. If that's what the argument is about.

@iguananaut  - Some of the issue here is that it does not return a subclass of `Coordinates`, but instead `SphericalCoordinateBase`.
To reiterate a discussion that I know realize occurred in specutils and not here: I see this is very non-intuitive behavior, and would lead to a lot of confusion.  I agree this how to organize masks is an issue, but I think it's much more confusing to implement this at a mask level than it is at the level of a specific type of `NDData` (e.g. a `Spectrum1D`)
I would also vote for one function - the ``vicenty`` function could easily be optimized further (avoiding re-computing sines and cosines) so the performance difference might not be that large.
I'm not sure I understand the nomenclature here. Why `var`?  I would think something like `register` would be more clear.  I was trying to figure out how to do exactly this, but my eyes kept passing over "var" because it didn't seem relevant.
Yes on caching and yes, please do the metaclass PR.  :-)
To be honest, I really don't recall, why I changed this ... it's no problem to revert to a timed_receive() :D.
OK, fair enough. Can you add a comment saying this? Then we know when it can be removed, in the future.
I re-indented these ones, as they had an extra level of indentation from when jrbasso brought the class in.
Ah, I just try to avoid triple nested conditionals if possible.  As for removing the redirect() call, one benefit to redirect() being used is other components can hook into the redirect and cancel it through the beforeRedirect callback.
Ceeram enlightened me that the "on" is the controller action as the test uses url "/party/on".
booleans should be written lowercased according to the Doctrine coding standards
oups, I forgot the end :)
It's the name of the type; and the id is also for the type. I could change the parent key to `ship_type` but that seems needlessly verbose.
indeed. as is for nodes that are neither property nor collection. fixed.
I'm not sure exactly how `system.file` gets used by other packages, so it's hard for me to say.

If we want to go that route, I'll revert this change and do that on a separate branch.
oh that's awesome.
throw new SkipException("reason why we are skipping")
this class has large reformatted only portions. If the new format complies with jclouds (3 spaces and 120 cols) AND there are changes then we should leave it, if not revert and/or reformat.
Extract this into a class

ResolveToBackendIdPredicate extends Function<Predicate<NodeMetadata>, Predicate<NodeMetadata>>

Then inject a member of this to the field resolveToBackendIdPredicate
Lots of spurious changes in this commit.
prefer calling super.setupContext() vs copy/pasting
This doesn't match the signature. One pointer too many?
All we need is the commit's name, asking for a commit object seems overkill. While the commits will usually be at the tip of a branch, I'd rather not force it. There's nothing wrong with asking about two commits in the middle of a branch (I'm not sure how useful it is, but limiting it seems quite arbitrary).

We can have another API that gets a ref and shows the relationship to the upstream branch, as that's a popular thing to do, but that should figure out what commits its interested in and use this.

The `git_count` namespace seems odd, as we'd probably only have this. Maybe this would be better named `git_graph_count_ahead_behind` or `git_graph_ahead_behind`?
``res not in ('y', 'n')`` (or this might even work: ``res not in 'yn'``)
Also, this has a lot of bad edge cases. If the length of the value is less than diff, then this doesn't work right.

I don't see you using the ``key=None`` case. Plus I think that case is fraught with danger and/or should be reworked. My vote is that you require a key and only truncate the value of that key. Leave the ``key=None`` case for later when someone actually needs it.
I think you can just do `{{ field.max_length }}` and kill that `max_summary_length`
I will ignore anything else. Nice catch on `elif`.
but you already have the UUID value. your SQL is actually an "exists" operation. Anyway, it's an extremely trivial difference. Leave it as it is.
The `string` module has `letters` and it's faster:
`''.join(random.sample(string.letters, 10))`
Javadoc says plugins, class name says extensions. Can it be clarified which it is (or if it is both?).
Word. This is done.

-----Original Message-----
From: "Phil Sturgeon" <reply@reply.github.com>
Sent: Wednesday, July 11, 2012 10:44am
To: "RyanThompson" <service@aiwebsystems.com>
Subject: Re: [pyrocms] Feature/streams core filters (#1541)



>  		$data['pagination'] = create_pagination(
>  									$pagination_uri,
> -									$CI->db->count_all($stream->stream_prefix.$stream->stream_slug),
> +									$CI->db->select('id')->get($stream->stream_prefix.$stream->stream_slug)->num_rows(),

You can use `count_all_results()` instead of `num_rows()` here, it's more performanct and respects the like() criteria.

---
Reply to this email directly or view it on GitHub:
https://github.com/pyrocms/pyrocms/pull/1541/files#r1141582
Can you remove this space?
Instead of using an arbitrary u32 to denote interval times, I recommend using tick_t (in HighPerfClock.h) as the time type, which is unified and not special frequency to this system. Alternatively, use a rate float telling 'how many times per second?', since that's a measure that stays comfortably close to zero (typically 0-100).  What do the values  '1000000000' and '250000000' here mean?
_constructor [...] and [...] classes now_ **match** _[...]_
Yep, I just wanted to draw your attention to #5187, so it gets merged too ;)
chmod sometimes returns null, for example : this return ``null`` :

```php
var_dump(@chmod(__FILE__, 'hello'));
```
Why did you change this method?
the point is that the public property is not part of the [Common interface](https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Persistence/Mapping/ClassMetadata.php) so it may become an issue
Yes, `Form::getTypes()` is deprecated.
what is ``$time`` here ? it seems undefined and unused
sorry, it was a wrong copy-paste :) fixed
The API does not specify that isValid should have a return value:

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/ConstraintValidatorInterface.php#L28
$consoleCommand can be renamed to $command.
Yes, this can be done, but is it really useful? All scalars can all handle the min max,  something like:

   $builder->stringNode('word_range')->min('a')->max('d')->end();

Can be valid (even if nobody is never going to use it...)
```earlierDate``` returns ```NSDate``` which has to be compared again to some date in order to decide which date is earlier. e.g. 
``` if ([[fireDate earlierDate:[NSDate date]] isEqualToDate:fireDate]) {```
which looks messy to me
Not using Guard anymore, so please remove this file
Good one. Thanks.
nit: '= null' not needed
If really want to squeeze every last drop of performance out of this, we can probably just change this to `[baseValue].concat` since the fact that `concat` doesn't exist means we already know it's not an array.
this was a pretty big refactor to make sessions like datalists and corpus in that they only have 2 views
See https://github.com/jbossas/jboss-as/blob/7.1/host-controller/src/main/java/org/jboss/as/host/controller/descriptions/HostRootDescription.java#L183
I'm not sure I understand; since this is the conversion of the response, all that is necessary is to be able to wrap the original response content with the callback. How can one require less than being able to map the callback itself into T?
@scottgonzalez does that fit what you had in mind?

Considering that our current demos don't really cover this, can we add at least one demo or visual test (/tests/visual/dialog) to check this?
仅移动
I will also include some code to manage the 'success" event.
Could we just add that white space in the html? If not please use a `margin-left: 0.3rem` instead of `:after`
Thx!
How about moving the waitingScreen show/hide control into message manager?
The lastChild of this.history should always be a ul element
yep we should add the l10n key for those ones
I think lock screen camera should be below the lock screen ...
Ah, https://bugzilla.mozilla.org/show_bug.cgi?id=819207
File bug.
Did we loose this part?

Putting it back in seems to be a great help performance wise.
> @etiennesegonzac the concept behind this is not only picking a contact but also to show FB information in the Contacts app and enabling certain additional communication operations (send message to the wall, send a message to the contact etc.) FB information is persisted in a separate DB because of FB requirements for information quarantine and to avoid that other apps may get access to this info. 

@jmcanterafonseca understood, it makes perfect sense in this context.

I'm afraid the current specs are halfway between the centralized Comms App and the separate apps then, which is really bad. It's weird to let the user send a _Facebook_ message from the _Contacts_ app but then ask him to switch to a separate _SMS_ app.

We need the product/specs to be crystal clear in one direction or another. Otherwise we're just loosing time debating the technical implementation of a fundamentally half-assed solution.

@cleemoz @jcarpenter
unprefix plx!
again, is this the brother of the contacts_shortcuts.js ? :)
Can you add param docs? I am not good about this everywhere but it is nice
`slientMode` controls the behavior of incoming phone ring/vibration, and it has nothing to do with system master volume.
```js
   if (number <= 1) {
      number = 1;
    } else if (number >= 4) {
      number = 4;
    }
```

This block was repeated twice here, please think over how to encapsulate this logic into a function.
Prepopulated?
What about `gc_enabled(self):`?
:+1:  Maybe in a next step (there some more places to fix)
cell_values are entities. The naming of these functions are off, as we're doing key/value/columns, and not entities per-say. We'll need a new issue to go and fix this misnaming since it was used in previous versions as well.
From the VirtualMachineMonitor agent this would be extra RPC with the VirtualMachineManager.
Let's see whith the new multisite redesign
Don't forget to rename your `recoding` to `recording` where appropriate.
This name is to verbose and should end in "Exception".

Maybe "ChannelRemovalException" or "DefaultChannelRemovalException"
Just FYI, the dl.* should go away as soon as get my hands on a wildcard cert for the domains. It's probably a good idea to handle this case though, because the cert is valid for both dl.getcomposer.org and getcomposer.org, and works just fine in all browsers for example.
This is an instance of us using "CurrentRevision" instead of "sha".
due to the bug -> due to bug
is not -> it is not
Why not `harnessOptions.preferences || null` ?
I'm thinking about the current state of Add-on SDK: we have a bounch of modules that are marked as deprecated, but we don't have already a full functional alternative for each of them. So, to me we mark as deprecated a module when the module shouldn't be used, because we're going to deprecate it soon or later. Then the situation could be:

1. We already have a full functional replacement for it (redirect the devs)
2. We don't have a full functional replacement for it yet (e.g. `window/utils` compare to `window-utils`)
3. We don't support that functionality anymore (e.g. for platform dependency), or it was an experimental low level API (e.g. `cortex`, `traits`, etc). We can suggest alternative approaches, but not an equivalent module.

The common denominator is "mark as deprecated" means "be aware that we're not going to support this module anymore, and we're going to remove it as soon as we can, but not earlier than 18 weeks".

Mark a module as deprecated is useful when we have internal dependencies with these modules: so we can't remove it yet, but we want to be sure that the devs are not going to use them – or, if they use them, at least they know very well that are deprecated.
This is so far the most common case we have currently.
In can stop handling these cases if you feel really strong about it, but I can think of cases which we may have (this function maybe be used first to resolve against requirer with relative uri and then against absolute baseURI). Also since loader.js will be for public consumption this easily may end up to be a case.
Maybe return transparent icon and log error that getter is not implemented ?
Can this object be abstracted into the fixture so that it is easy to call testidp2.enablePrimarySupport?
Let's consider.  First, your university has implemented persona support:

    { "authentication": "/blah.html", 
       "provisioning": "/blahblah.html",
       "public-key": { "blah": "blah" } }

Now, the university wishes to transition to delegating their authority to some other domain (say it's a university and they've centrally implemented persona support).  So they just add a key:

    { "authority": [ "secure.myschool.edu", "secure.myschool.edu" ], // they messed up!  they thought they could specify multiple domains for redundancy
      "authentication": "/blah.html", 
       "provisioning": "/blahblah.html",
       "public-key": { "blah": "blah" } }

Is it better for:

1. us to continue using this domain as a primary.
2. us to take over and perform secondary auth.
3. us to tell the user that the idp is broken.

in my mind, the answer varies whether you're talking about verifiers or implementations.  I think implementations should do #3, and verifiers should still honor certs.

so agree with you @benadida, and think it uncovers the larger issue that our verifier and implementation should *not* behave in the same way in their parsing of well-known docs.

/cc @callahad
Can the app continue without this storage? If not, we should have a global flag somewhere to bail and show an error message to the user.

If this is just a performance enhancement or we have other workarounds, than this looks good.
confirmed.  no issue with IE for css.
Put the return info in 
  # @return [Object, nil] the fact, or `nil` if no such fact exists.


The return of a type nil adds a nice superscript ? in the output
The bulk data delete file logic here should be moved to the bulk_data class.  Something like data.delete_files.
don't need this, right?
My point is not to depent on provider data length restrictions.
`$this->count = $count > 0 ? $count : 0;`
This would only help prevent the vulnerability for *any* arbitrary class name and limit the scope of the vulnerability. It would not, however, fix the vulnerability. In this case, _any_ class with a definition (instance name) in DI would still be vulnerable.
Well, previously, Checkbox has useHiddenElement to true by default, while MultiCheckbox has to false. There must be a reason for that (that I don't know).
I was not suggesting you need to remove $classes entirely -- I was suggesting:

* have it as an optional third argument
* if not passed, check for a "class" attribute, and, if it's an array, set $classes to it
* normalize the $classes array, and then add it to $attribs under the 'class' key

This would provide the flexibility you were trying to achieve earlier while addressing the most common use case (adding attributes). 

Make sense?
Invert this, so that the actual work of the method is not done inside a conditional. E.g.

```php
if ($this->application) {
    return $this->application;
}

// initialize application instance, and then return
```
// Less verbose #not_in_java
var factoryConfig = new DataCacheFactoryConfiguration 
{
   Servers = servers,
   SecurityProperties = factorySecurity
};
Does this line even execute without a fatal error?
I can empathize with that.  But in this case I'm just thinking "huh, a spec that does `rm -rf`... seems like it could be dangerous".  :smile:

Really, I'd like to start using [`FakeFS`](https://github.com/defunkt/fakefs) for testing and forget about stubbing all these specific methods.  That's a longer term goal, but if you'd ever like to take a look at doing that, by all means.  All your involvement is very appreciated.
yes. I was lazy
Use maybe a bit mask option like in `registerInternalConfigArray()` ? More consistent IMHO
Erroneous new line?
Similarly, this could be `from pages.log_out import LogOutPage` and then later hidden away in `click_log_out`
That's okay! Labels not lining up is the type of thing we can fix with CSS (that way, we won't have to rely on translators remembering to insert the space). If you want to add a screen capture of the problem and your browser information to the issue, we can make sure it gets fixed. I tried it on Safari, Chrome, Firefox, and Opera and it looks fine, though.
needs a blank line at the end to compile on Windows, not that it actually works in Windows but I've been chipping away at it.
@kellyredding - the end "on", maybe instead "that is about to be run".
yes, It's following the original ionotifywait output format: 

%w This will be replaced with the name of the Watched file on which an event occurred.
%f When an event occurs within a directory, this will be replaced with the name of the File which caused the event to occur. Otherwise, this will be replaced with an empty string.
@aurimasv This was wrong before the cleanAuthor changes, but maybe cleanAuthor should only be adding periods after Latin letters (in any alphabet)? We don't want to add periods in this case, and we probably don't want to add periods after single characters from Asian languages.
Thanks for the tips but I tried both and always get refresh 0    :-(

I added you to the repo as collab, be free to try other variations
Also you want the `data-each` on the `li` and to get rid of the `span`.
We're already doing this in line #8
I'm just curious as to what other options you were thinking would be useful to have as well.
This should do a cleanExit(), otherwise rest of execution continues as normal.
а как понять кратность отсюда?
WARN? Exception?
Ah, I think you're right. I think I added it to the .gitignore, but then never actually git rm'd the file. This is probably fine then, since there are the database.yml.sqlite and database.yml.mysql files still in the repo for examples.
heh, interesting as we already tried to find a good name for it on irc. +1 on `is_trusted_issuer`
Uppercase here as well.
Isn't contexts already an array?
id of the content.
Unneeded colon
Why does the UI need the execution context? I'd like to keep the me feed as clean as possible.
Wouldn't it make more sense for the execution context to be part of /api/tenant?
This should be User|Group
Looking at the permissions module, I think it has everything that's needed to do this check.
`moduleId` needs some sanitization. It shouldn't be `null`, `undefined`, shouldn't contain slashes, and probably shouldn't have `..` .

Alternatively, we should consider pre-parsing the docs on start-up in a deterministic way, and then `getDoc` simply grabs from a pre-computed cache rather than reaching out to the file-system on a user-specified path fragment. `getDoc` is then just a synchronous function that pulls from a hash.
I think that would create a circular dependency between redis and pubsub.
This allows popping off the top behavior which could be problematic, since `currentBehavior` is just `behaviors.top`. In Akka you can never pop off the initial behavior- you might want to do the same here.
угу :)
thanks, use $this->isInstanceOf now. $this->equalTo just did not work.
I think the front end to this would be better handled in channel, with something like:

const char *channel_icon(channel_t*ch);

That could make calls into the logo stuff of course.
Here, you might want to rename "OpElement" to "CopyinElement". Update the method names accordingly.
do you miss "f" hrere? why -fhicuda become -hicuda?
And you should only write from settings to store if the settings are
present and the store is blank.
You got an email.
Parenthesis around the condition here would make it a bit more readable, moving the values to the next line even more:

    $this->_migration_regex = ($this->_migration_type === 'timestamp')
        ? '/^\d{14}_(\w+)$/' : '/^\d{3}_(\w+)$/';
`AND` -> `&&`
Does the removal of the first argument signify a BC break, or would this public method never be called by the user. I assume perhaps it's further down the line from `DocumentManager::refresh()`, so users wouldn't call this.
The iterative behavior is different from what I'd typically expect. I think it'd be wrong to force that everywhere.
I would go ahead and `return shake['id']` here, so you can avoid the vaguely named `rvalue` variable entirely.
+1 to try to avoid to the *args and **kwargs
+1 for epoch_idx
Should probably be called `Certs`
Think this is the only change of relevance:

<import feature="org.eclipse.mylyn.reviews.feature" version="0.8.0" match="greaterOrEqual"/>

Basically changing the version requirement to be more relaxed and allow the 1.0.0.xxx release that is now available.
the curly brace should be on the next line according to the Symfony2 CS.
We should be consistent between the different examples with our hosts and path. So, we should pick one hostname and one doc root and use them on all examples (e.g. `symfony.local`).
Looping is a bit ugly.

I would prefer something like this (after renaming the other `messages` to `expected`):
`val messages = (0 until expected.size).map(Source.next)`
`messages must equal(expected)`
this is a restructured text markup. note the periods

```
.. note::
  start note at an offset
```
да. Нормальные посоны юзают временные переменные.
Лучше брать локалеспецифичный формат, не все привыкли к `dd-MM-yyyy`.
tabs look a little mixed here.
You may be able to simplify this test case through JUnit4 annotations, with the `@Expected`
Let's add a TODO for this.
You can send another option into this for `:message => 'must begin with http://'` to add a custom message. You may also want to tweak your regex to make sure the match starts at the beginning of the string and to allow for https
The formatting of this whole file needs to be fixed.
Good to know! Can you add a short comment to this effect?
yeah this needs to be fixed because this is the nova id instead of the rdl id right now. we will need to fix this later.
this method doesn't seem to be used.
Ok, in another words leave this line of code as is :-)
-1 to a commons package...

We already have util, but don't think Hash really belongs there, maybe just have org.infinispan.hash package.
You're right! I fixed it now.
let's give `_cond` a descriptive name like `was_oauth_signed` — would make the logic here a lot clearer.
why don't you put the if inside the foreach, if you do, there's no need for the array.
to be safe use === for the equation
Should we limit ourselves here?  As you pointed out, there's no way to know what the complete selection is until a backend has been selected, but it could include other things, such as emf, gif, jpg depending on the backend.  I think it best to just make this "any string" and let it be verified by the backend upon saving.
Thanks Mike. As I said, I think this line would benefit from a comment indicating what hatch_style is likely to be.
Turns out this is bad. Reverted in #1176 (along with a suitable test).
I think at this point the `version` needs to be cast to a string so it can be selected
nitpick: Technically, you could implement this by putting a ParallelAnimation containing two NumberAnimations (for the relevant opacities) here, instead of ScriptAction, PauseAnimation, and Behaviors.

That isn't a reason to not merge, though - just a sidenote.
@croby Can we convert this to the new style guidelines?
yeaaah good catch. Will change it in the next commit.
@nicolaasmatthijs Shouldn't this `return` be outside the if loop?
what if we will heve 30 special events clases? GenericEvent shouldn't be used everytime.
Having a hard time following this, can we just make it "return dayFloor(dt.minusDays(dt.getDayOfWeek() -1)"?

Sorry if I'm being dense, but I can't understand the reason for the withMonth/withDay/withYear code.
How does this test work? The extension foobar, doesn't actually exist. The point of tests is not so you can test once after installing the extensions, but so the tests can be automatically executed after every change, to confirm that this is still working. Your tests are going to have to provide the actual extension.
- Are you sure that the method "getEvent()" exists?
- Are you sure you want to override the parameter ``$redirect``? This often makes code less readable.
Is it possible to define the element type for the returned array (using ``array<SomeType>``, or ``SomeType[]``)? Please also check line 171.
Could you please update this and (and some other lins too) to match the 4 space indentation used elsewhere?
I was actually waiting for Indy to come slashing through the brush myself
I did this edit at github web interface. I used white space copied from elsewhere to keep it in sync with the rest,
Why don't you use `Package|ClassOrInterface` as the return type for `getFromObject()`?

Muahahahahaha ;)
This should do the trick, but please test since I don't have GNU netcat myself
I believe the above should be `this.on(events, unbind, this)`.

```js
var context = {};
obj.on('event', function(){}, context);
// Dies because `unbind` is called with `context` instead of `obj`.
obj.trigger('event');
```

Also, I think the convention would be to return `this`, though I'm tempted to use the simpler form and return `unbind` for offing the handler.
Почему массив?
Или если нужен массив, то почему метод public?
Denne hardkodede pathen er ikke helt topp. På Azure er riktig path `/usr/lib/jvm/java-1.7.0-openjdk-amd64/`.

En ting jeg tenkte på er vel at `elasticsearch.deb` selv deklarerer en Java-dependency.. trenger vi egentlig å ha det med i puppet i det hele tatt? Kanskje det er nok å oppdatere JDK_DIRS på linje 50 i init-scriptet til å inkludere de pathene vi kommer over.
@janmoesen This is exactly why you should have a blog. Thanks!
Same here...can this be shorter?
my comment seems to be in the wrong place, but you knew where I meant..

..
if (!me)
  me.setown(MakeMultiException("Transaction"));
me->append(e)
..

if (me)
  throw me.getClear()


Not exactly unclear, but nor is yours.
alright .. i will look into changing it to a start/end date.
as for renaming the ``PublishWorkflowCheckerInterface`` i would rather want to keep it as is. we can revisit the topic when we wrk on ACLs. onc ewe have the ACL system in place .. we would do an ACL check inside the ``PublishWorkflowChecker`` .. once PHPCR has implemented ACLs this would then be a no-op since the ACL checks would already be doen on the storage level.
I :heart: you Piotr!

On 6/07/2012, at 10:35 AM, Piotr Sarnacki wrote:

>> @@ -107,9 +107,18 @@ def chdir
>>           end
>> 
>>           def export
>> -            Array(config.env).compact.select { |line| line.present? }.each do |line|
>> -              shell.export_line(line)
>> -            end if config.env
>> +            export_travis_specific_variables
>> +
>> +            if config.env
>> +              Array(config.env).compact.select { |line| line.present? }.each do |line|
>> +                shell.export_line(line)
>> +              end
>> +            end
>> +          end
>> +
>> +          def export_travis_specific_variables
>> +            shell.export_line "TRAVIS_PULL_REQUEST=#{(!!commit.pull_request?).inspect}"
>> +            shell.export_line "TRAVIS_SECURE_ENV_VARS=#{(!commit.pull_request?).inspect}"
> 
> Good question,  I was rather thinking about `TRAVIS_SECURE_ENV_VARS` as a way to tell if you can have them, not if they're actually available. If you have a travis.yml file you should know if you have them or not.
> 
> But after your question I guess it's not good - I think we should do what you suggested. I forgot that in travis you can have builds with 2 sets of `ENV` vars, like:
> 
> ```yaml
> :env:
>  - [{secure: "..."}, "FOO=bar"]
>  - "BAR=baz"
> ```
> 
> and in such situation you can't just say: ok, I put secure env vars, so I have them.
> 
> I'll fix this.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/travis-ci/travis-build/pull/22/files#r1111497
Should I also do it with Twitter?
(I vote for image.)
It's so we can change which panels the user ticked if they didn't select all of the prerequisites. If we're not changing the selection anymore (not using form errors) then it'll probably not be neccessary anymore.
This is not needed, MongoEngine already has [create](http://mongoengine-odm.readthedocs.org/en/latest/apireference.html#mongoengine.queryset.QuerySet.create) method.
You don't have to send JSON to them. :-)
Not really, it is still being used right below on [ValueObject::InstanceMethods#with](https://github.com/fgrehm/virtus/blob/master/lib/virtus/value_object.rb#L59) ;-)
replace double space to single
If you want to check for the extension as requirement, you could always do that with composer for those using composer to install modules.

I know `"ext-intl": "*"` will check for the Intl extension, so I assume a dependency in composer called `"ext-fileinfo": "*"` will check for the fileinfo extension (and thus the `finfo()` method)
actually this test looks exactly like the one below (minus the typo)
Add: 
				OnEffectHit += SpellEffectFn(spell_mage_frostbolt_SpellScript::HandleEarlyFrostScript, EFFECT_0, SPELL_EFFECT_APPLY_AURA);
Remove german yells^^
To import something from sqlalchemy in an importer/parser module, it is a clear code smell. Could you suggest with a TODO comment which are the outstanding refactorings needed to avoid this?
De li class kan waarschijnlijk weg, en anders zou ik het optioneel maken met `$options['li_class']`
Here you changed the API. I'm not sure if this is necessary, as most people probably will use getReleaseDate().toDateTime() to get a DateTime object. Same consideration also goes for Artist#getBeginDate and Artist#getEndDate. As said, I think it's good to have an implementation for a PartialDate, I'm just not sure if it needs to be exposed.
alpha: 0.2
'public' and 'private' should be indented one space from 'class'.
remove this timer