Add DeviceController base-class to remove duplication of DeviceXXXControler
https://bugs.webkit.org/show_bug.cgi?id=96894

Reviewed by Hajime Morita.

Source/WebCore:

Add DeviceController which is extracted from DeviceOrientationController to remove duplication.
And soon-to-be-added DeviceMotionController and ProximityController.

Covered by existing tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DeviceOrientationClient.h:
* dom/DeviceOrientationController.cpp:
Remove member functions to move to DeviceController.
- addListener(), removeListener(), removeAllListeners(), isActive()
(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore::DeviceOrientationController::didChangeDeviceOrientation):
(WebCore::DeviceOrientationController::client):
(WebCore::DeviceOrientationController::hasLastData):
(WebCore::DeviceOrientationController::getLastEvent):
(WebCore::DeviceOrientationController::from):
(WebCore):
* dom/DeviceOrientationController.h:
(WebCore):
(WebCore::DeviceOrientationController::~DeviceOrientationController):
(DeviceOrientationController):
* dom/Document.cpp:
Remove suspendEventsForAllListeners() and resumeEventsForAllListeners() function calls.
These calls can be made by checking activeDOMObjectsAreSuspended() and activeDOMObjectsAreStopped() before dispatchEvent.
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
* loader/EmptyClients.h:
(EmptyDeviceClient):
(WebCore::EmptyDeviceClient::startUpdating):
(WebCore::EmptyDeviceClient::stopUpdating):
(WebCore):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):
* page/DeviceClient.h: Added.
(WebCore):
(DeviceClient):
(WebCore::DeviceClient::~DeviceClient):
* page/DeviceController.cpp: Added.
DeviceController has extracted functions from DeviceOrientationController and DeviceMotionController.
- addDeviceEventListener(), removeDeviceEventlistener(), removeAllDeviceEventListeners(), dispatchDeviceEvent()
All kind of device event controller which has DeviceClient can be inherited from DeviceController.
(WebCore):
(WebCore::DeviceController::DeviceController):
(WebCore::DeviceController::addDeviceEventListener):
(WebCore::DeviceController::removeDeviceEventListener):
(WebCore::DeviceController::removeAllDeviceEventListeners):
(WebCore::DeviceController::dispatchDeviceEvent):
(WebCore::DeviceController::fireDeviceEvent):
* page/DeviceController.h: Added.
(WebCore):
(DeviceController):
(WebCore::DeviceController::~DeviceController):
(WebCore::DeviceController::isActive):
(WebCore::DeviceController::client):
(WebCore::DeviceController::hasLastData):
(WebCore::DeviceController::getLastEvent):

Source/WebKit/qt:

Change client() to deviceOrientationClient() to get DeviceOrientationClient*.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setMockDeviceOrientation):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[AC][EFL][WK2] Rename PageViewportControllerClientEfl::m_pageViewportController to m_controller
https://bugs.webkit.org/show_bug.cgi?id=100933

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-01
Reviewed by Kenneth Rohde Christiansen.

PageViewportControllerClientEfl::m_pageViewportController has to be renamed to m_controller
to keep consistency with other ports. Assertinons were also added.

* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::setVisibleContentsRect):
(WebKit::PageViewportControllerClientEfl::didResumeContent):
(WebKit::PageViewportControllerClientEfl::setController):
* UIProcess/efl/PageViewportControllerClientEfl.h:
(PageViewportControllerClientEfl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Memory instrumentation: do not report memory occupied by RenderObjects referenced from CSSImageGeneratorValue
https://bugs.webkit.org/show_bug.cgi?id=100934

Reviewed by Alexander Pavlov.

* css/CSSImageGeneratorValue.cpp:
(WTF): Skip rederences to RenderObjects from CSSImageGeneratorValue when collecting
memory usage data.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSSRegions]Former auto-height regions should not ignore their defined height
https://bugs.webkit.org/show_bug.cgi?id=100749

Reviewed by Julien Chaffraix.

Source/WebCore:

When a region with height auto has its height defined, we should also clear the override logical content height.
Otherwise, the region will use the wrong height when laying out content from the associated render flow thread.

Test: fast/regions/autoheight-definedheight-changenotdetected.html

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):

LayoutTests:

Add a test in which we flow content into a region chain with 2 regions, the first one having height auto.
After a first layout, the region with height auto has an override logical content height, which should be
cleared when the first region has its height changed from auto to defined.

* fast/regions/autoheight-definedheight-changenotdetected-expected.html: Added.
* fast/regions/autoheight-definedheight-changenotdetected.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][Qt][AC] Remove an unnecessary connection to X-Server.
https://bugs.webkit.org/show_bug.cgi?id=100628.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-11-01
Reviewed by Kenneth Rohde Christiansen.

With Changset: https://bugs.webkit.org/show_bug.cgi?id=100523
GraphicsSurfacePrivate should always use the Display returned by offscreenwindow.
However, in GraphicsSurfacePrivate constructor we call XOpenDisplay before asking
display from offscreenwindow.
This patch removes unnecessary call to XOpenDisplay made in GraphicsSurfacePrivate.

* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update average StylePropertySet size estimation.
<http://webkit.org/b/100940>

Reviewed by Antti Koivisto.

Use sizeForImmutableStylePropertySetWithPropertyCount(2) as the average StylePropertySet
size to keep it in sync with the changed object memory layout.

* css/StylePropertySet.cpp:
(WebCore::sizeForImmutableStylePropertySetWithPropertyCount):
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::averageSizeInBytes):
(WebCore::StylePropertySet::reportMemoryUsage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Remove obsolete code from JavaScriptSourceFrame
https://bugs.webkit.org/show_bug.cgi?id=100594

Reviewed by Yury Semikhatsky.

Removed obsolete WorkingCopyCommitted listener.
Removed redundant code that removes breakpoints from _innerSetContent.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._innerSetContent):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133149 268f45cc-cd09-0410-ab3c-d52691b4dbfc