labofsahil/github-event-dataset-2012 huggingface dataset:
Csv replace header

In the action helper Centurion_Controller_Action_Helper_Csv : 

Set the flag $replace of getResponse()->setHeader at true because sometimes, there are already defined in the application.
And we do not necessarily clear all predefined headers, but some browser (like Chrome/Chromium) not support several time the same type of header in the same server anwser
updated example to use softwareVersion instead of model

correct an error in the fix for issue #144
Set default value after press "Apply" button

It nessesary when user press "Apply" button without calendar manipulation
Rewrite networking barclamp to make a bit more failure-proof. [8/22]

Rewrite network barclamp to manage interfaces directly.
    
    Making the distro tools handle reconfiguring network interfaces for us
    was needlessly fragile, since we were rewriting the network config and
    changing the state of the interfaces while we were in the middle of
    converging the node -- if we happened to do anything that would try to
    talk to the chef-server while any of the interfaces needed to talk to
    the admin network was changing, we could easily wind up in a state
    where manual intervention would be needed to recover.
    
    Additionally, the network barclamp had to have a good deal of
    special-casing to handle all the distro-specific caveats that went
    along with using ifup/ifdown directly to manage the nics.
    
    This code does away with all that by teaching the network barclamp how
    to manage our interfaces directly, reducing the distro-specific code
    to what is needed to write out the proper configuation for ifup/ifdown
    on the operating system.
    
    New features:
    
     * All interface manipulation happens early in the compile phase of
       the chef-client runs, and the recipe will pause for up to 60
       seconds to verify that it can ping the node with the provisioner
       role (if one is assigned).  This should ensure that the chef-client
       run succeeds with minimal delay even when we are forced to do
       something that may trigger a spanning tree update on the
       network. This frees the rest of the barclamps from having to care
       about sleeping due to network configuration changes.
     * The network barclamp posts its state on
       node[:crowbar_wall][:network] to allow other barclamps to easily
       see what interfaces are members of what network and what IP
       addresses are assigned to the node.
     * Switching between single, dual, and team mode is more or less
       seamless now. You can easily switch network modes even when nova VMs are
       up and running without dropping more than a packet or two. The sole
       exception I have seen is Nova running in tenant_vlan mode.
     * It is trivial to deploy with a configuration that does not use vlan
       tagging at all.  The network barclamp will manage our interfaces
       correctly by assigning multiple IP addresses to the appropriate
       interfaces for each network, and it will handle moving addresses
       and routes around as needed.  Debian and Redhat config file
       generation has been updated to handle binding multiple IP addresses
       to interfaces so that a rebooted node will come up with the proper
       configuration before chef-client runs.
     * Helper classes have been added to the barclamp recipe that model IP
       addresses (including IP address ranges) and network interfaces.
       Those helpers also inject convienenece routines into the CHef::Node
       class to make it easier to find interfaces and addresses for each
       of our networks.
Performance and memory

This pull ended up mostly being cleanup but I had some things in the next few commit that I thought it might be best to make separate.

The changes I made are:

* Replaced about 7 `addEventListener` calls per comment/post with single `jQuery.live` calls.
* Made a standard method for debouncing (coalescing bursts of input into a single event)
* Made a standard method asynchronously iterating through an array in chunks.
* Restored functionality in Opera.
* Another SnuOwnd update in preparation for the new wikis and to work with Opera's new loader.
* Disabled MutationObserver in WebKit since that has a nasty leak.
Fixed Formatting

Fixed the formatting on the Purchase History page which shows the currency as well as the correct decimal/thousand separators.
Updates for upcoming 'glue' plugin for WPML

The wpml-config.xml file will be part of the plugin instead
Updating compass to work with v1.x

Hey,
  I really enjoy using this bundle with ruby/coffee and did some work to get the validator working with the new `compass` interface.  Thanks for maintaining - Cheers!
Access to global object in ES3, ES5 and ES5-strict with partial eval.
"onfocuslost" event - fires when focus is lost, but mask isn't complete.
openvmtools: add explicit hasstatus on vmware-tools service

In puppet 2.7.x, hasstatus defaults to true which will give an error when
we want to 'ensure => stopped' a service which might not be installed.
Make sure to get a storage dependent valid file name when handling uploaded files

Django doesn't play well with uploaded files containing non-ascii char.

On way to get around this issue is creating a custom storage backend.

```python
import unicodedata

from django.core.files.storage import FileSystemStorage

class ASCIIFileSystemStorage(FileSystemStorage):
    """Convert unicode characters in name to ASCII characters."""
    def get_valid_name(self, name):
        name = unicodedata.normalize('NFKD', name).encode('ascii', 'ignore')
        return super(ASCIIFileSystemStorage, self).get_valid_name(name)
```

And defining it as the default storage backend in you settings.

```python
DEFAULT_FILE_STORAGE = 'common.storage.ASCIIFileSystemStorage'
```

However django-form-designer's upload mechanism doesn't honor the storage dependent valid file name scheme. The attached pull request fixes that.
LPS-23998

Hi Sergio,

This is the updated pull request, I've merged your source formatting, and I've also refactored the request object what we were talking about.

Thanks,

Máté
HTML5 playbook

Thoughtbot's playbook has updated to a HTML5 version.  
I've made some modification to adapt it.  
This is my first time to participate in open source project.  
Advice me for any possible improvement.  
Thank you.
Added required boot mehtod

The ServiceProviderInterface of silex requires a boot method to be implemented
Beginning visual work

Added html and css mockups. Began image creation.
Refactor scm manipulator and add feature : scm status sync
add LibraLocale module. Provie milti-language for site
拉取：邹帆审阅第二课后，崔晶的修改版。
Rack::Lint::LintError: No Content-Type header found

Instead of having a "401 Unauthorized" response when oauth is not authenticated (oauth.no_access), it's being raised a "500 Internal Server Error" with "Rack::Lint::LintError: No Content-Type header found" exception.

I had this problem using Sinatra in development environment and running a Rack server (rackup). It happens because rackup servers automatically add Rack::Lint in development mode.

To ensure Rack protocol is being followed, there must be a Content-type header in all responses, except when the status is 1xx, 204 or 304.

Following this idea, rack-oauth2-server needs to add a Content-type header when returns an unauthorized response:

return [401, { "Content-Type"=>"text/plain", "WWW-Authenticate"=>challenge }, [error && error.message || ""]]
Gemspec update for compatability issues with bundler and state_machine 

I updated the gemspec to be more compatible with later versions of bundler and state_machine.
Fixed some HTML validation problems in the generated HTML pages.

Hi,
I have tested the html pages of the website using the W3C validator and I fixed some errors. 
Not all errors have been fixed, the are still some problems with Twitter and Facebook iframes; in fact the attributes **allowtransparency**, **frameborder** and **scrolling** are obsolete. I did not move them in the CSS, as suggested by the validator, because I do not know if this can break compatibility with some browsers. 
Maybe I can substitute the iframes with the javascript code. Maybe this is only a workaround because the JS will generate the iframe with the same obsolete attributes...

In addition to fix the validation issues, I have removed some ^M characters at the end of the "layouts/default.html" file and fixed the indentation of some html elements.
LPS-25041
Test Fixes

portal/tags/blogs

http://issues.liferay.com/browse/LPS-4325
Refactor Travis install script
Cleaned up whitespace

2-spaced soft tabs everywhere!
Solved problem with session_key

This is small fix discussed in https://github.com/trevorturk/flash_cookie_session/issues/10
Use View.visible_region() instead
base.html messagelist wrapper

My first-ever pull request, so please let me know if I'm doing this wrong.

Wrapped the messagelist ul in the base admin template with Bootstrap's "alert" div
updated twitter-bootstrap to v2.0.1

updated twitter-bootstrap to v2.0.1 ... that's all.
Only apply the translation once on childless DisplayObjectContainers

When DisplayObjectContainers without children calculate their bounds, they get a Matrix relative to the target space that includes their translation. Then the translation is included again in the calculation of the position by the matrix. This change removes the translation from the call to the matrix.
Dec 2012 list
Remove csrf_protection in FilterTypeGuesser.php

The filter guesser force disabling of csrf_protection for integers. This is already done in ``Builder\DatagridBuild::getBaseDatagrid``.

This PR is required for sonata-project/SonataAdminBundle#725
option to remove numbers from email subjects so that they thread

This removes numbers from the subjects of emails, so that different instances of the same exception are more likely to be collected into the same thread by the email client.
Added nose to requirements.txt

otherwise make test won't work
Changed info.xml

Jordanoff became Jordanof.
lets do this

now
Proper disconnect handling

Handles socket connection drops / other player quitting now instead of freezing. Upon a connection loss the game now shows a 'game over' screen with a silly disconnect message
That's fine; I didn't catch that check.
Making individual headers separately expandable from the entire set of headers feels wrong to me. It just gets too fiddly.
rename to "removeKeysToIgnore" ?
This is cool! Do you think it will work with jQuery 1.3.2 (don't laugh!) ?
tomaswindsor: user v tomhle případě znamená uživatel frameworku, tedy vývojář. Znamená to tedy, že vývojář může nyní u potomků UI\Presenter použít konstruktor pro předávání svých závislostí (DI).
Great, now my CruiseControl.rb installation is working! Looking forward to 3.2.2 stable
That's what we want to do. At the moment there is no container generated at all … ;-)
Added this to v1.5. if you can do a pull request next time I will fix it faster. Thank you very much though!
Hi,

this commit is not without problems, as it breaks many existing (but broken) SSL implementations. It seems Java might be one of them... Googling on the flag gives a number of pages where people have reenabled the flag as a workaround, such as http://bugzilla.mcs.anl.gov/globus/show_bug.cgi?id=5811
Do you have any ideas how we could deal with this, especially on the Java side?

Mischa
name your vars properly noob
Let's use bourbon or my checkit for luvit tests. It would allow to not disperse forces
I see,  thanks for the information :)
It depends on what you want to achieve.  If you just want to deal with production logs, then you should log the pid of your process.  The default logger from stdlib will automatically log the PID for you, so you can use it instead:

![log the pid](https://img.skitch.com/20120124-dywurw9inn48n34fp49dsa2hqa.jpg)

Maybe we should switch to use it by default.
ok, I will change the formatter to it.
We'll have to get a new batch of t-shirts printed now.
Ok, think about it this way. There is a very low chance that they reach MAXSCORE at the same time. Since the checker time and maxscore an be configured. Think of call of duty, if you have ever played domination, its like this.
This requires a bit more investigation. The connection would always crap out with "SSL_shutdown: failed (Success)". Ideally, it should be caught at a higher level, but I couldn't get that to work with cathI or inumCatch.
@sritchie take note of this commit.  #^:private doesn't seem to work on defmulti
> Found Gullerud patch just now:
>
> @@ -608,6 +608,8 @@ proc run_commands { prompt command } {
>       set command "set logging session disable;$command"
>   } else {
>       send "terminal length 0\r"
> +            # Also attempt to turn off timestamps in newer IOS
> +            send "terminal no exec prompt timestamp\r"
>   }
>   # match cisco config mode prompts too, such as router(config-if)#,
>   # but catalyst does not change in this fashion.

You will need similar patches for IOS XR. The commands are:
"terminal no-timestamp"  # XR 3.6 style
"terminal exec prompt no-timestamp" # XR 3.8+ style


-- 
Pelle

"D’ä e å, vett ja”, skrek ja, för ja ble rasen,
”å i åa ä e ö, hörer han lite, d’ä e å, å i åa ä e ö"
- Gustav Fröding, 1895
See how `util/lang` is included here? I would love you to make `util/time` in which we could throw useful functions like the rounding one you created. That's probably better than attaching it to the `Butter` object.
Ah yes, misread that (duh). Will do this - much cleaner. Thx
This is a good idea, would have saved me a couple of hours working out what was going wrong :-)
Correct.
What I dont understand now is why the crash is happening during panning also on PC.
Example. Reset to default profile (system FULL RESET).
Run in Sim mode on pc,   screenview pan ON
Pan slowly on the left, when you reacj a position between CADORAGO and LOMAZZO, sw is crashed.
I used the short dr for dated reminders
I can't wait to kill kill kill these function-level imports. They almost always indicate you've drawn your module boundaries wrong.
Please open different pull requests for different patches :-)

PS: Also, compilation on Windows is only supported with MinGW...
I don't think it should be raw by default as it can be a XSS hole if the user is not aware of it. Adding this filter is easy as the label is rendered in its own block
It would be better to keep RFC allowed chars separate from other ones and not put them all in one bag (string).
Die Commit-Nachricht stimmt wirklich -.- Da REPO_NAME immer wahr ist, wird kein einziger Eintrag geladen -.- Da freut man sich drüber - Kein Wunder, dass immer mehr Tests net gehen^^

Ist BTW schon gefixt ;)
I'd determined that the whole ReviewerId and SubmitterId type distinction is just annoying. Not to mention the excessive error checking. No need to return the actual error, imo.
Есть один маунт, через него у меня игроки могут на одном месте несколько сотен мобов оставить. Это возможно оно?
* Remove noise from your patch:
  - ViewGroupAction:110,38
  - no real changes in AlgoAction and AbstractGroupAction
  - Fix indentation
* Remove debugging message like AmibeDataObject:81 and 113 (keep them in a debug branch if you like)
thanks, fixed.

On Wed, Feb 8, 2012 at 9:19 PM, Ricardo Diaz <
reply@reply.github.com
> wrote:

> @ayende Now that null can be in the return collection, this line:
> https://github.com/ravendb/ravendb/blob/50f1613ba19cfda4a42c26748c47b77fc668b929/Raven.Client.Lightweight/Document/SessionOperations/MultiLoadOperation.cs#L55
>
> ..can throw a NRE. We have this happening in our current codebase.
>
> I can provide a test case that shows this if need be.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ravendb/ravendb/commit/47a72930888dab02a9af4f094b8d1b1613e933d9#commitcomment-946519
>
Hi, we are unable to upgrade as we have rubygems 1.7.x in production due to Ubuntu packaging. I was wondering if you could tell me whether this version is a verified requirement or just as a convenience as that's the version you have installed?
Since votes.vote is a boolean, have you tried simply matching against true/false in your CASE instead of forcing the cast? Seems to work for me over here.
This patch looks good.  I'm going to test and merge, but wanted to answer your questions now.

1. Why NOTFOUND is returned as 0 in read(). It seems YCSB wants a non-zero value for not found?

This is just an artifact of my thinking about "SUCCESS/NOTFOUND" as common cases for a GET, while other values are actual errors.  I don't think YCSB ever triggers a NOTFOUND, so this fix should not break anything.

2. Under which condition, interres.has_key(key) is false in convert_to_java()?

This is just a safety net to get things quickly working.  YCSB's core workloads have username and field[1-10] as attributes.  My tests create this space, but I wanted things to be robust.  Perhaps we should error out and abort the test.  This is yet another case of being over-cautious without ever triggering the condition being tested.

The diff which enables "convert_to_java" will not affect the flow of operations in the benchmark.  It's just going to copy an extra 1KB of data per row, which should be lost in the noise.
If the battery is not available put a small sentence such as "na".
thanks - I took care of this in c61bb4e
This is outputting `The provided compiler '' is LLVM based...` for me, it looks like `$(__rvm_selected_compiler)` ends up empty.
In the future, please never put whitespace changes and real changes in the same commit.

Why did you rename sock_t? I don't understand the reason for that.

Why are xmpp_conn_write and xmpp_conn_read exposed in the API? They should not be.

I also don't understand the purpose of the write callback. Can you elaborate on what that is used for?
This breaks all:
    >>> ERROR: Pattern match failure in do expression at Data/Conduit/Util/Conduit.hs:54:13-17
Note--Tracate has same name as its Order. Disambiguate with trToharot? or leave alone?
Please advise.
Category feed shows textile text without convert it to html. Example http://snupt.com/categories/linklog/ (see img lines)
This is causing a compilation error when ```using namespace std;``` is omitted.
Hehe, I was thinking today about doing something like this :)
Heh, I know all about the 'hammered' thing: I'm still looking for that
elusive 48-hour day.

Anyway, when you get to it, also check the pull req conversations of leafo
& me as a few details are changing right now. Should be stable of sorts in
a week or so, I guess.

Cheers!



Met vriendelijke groeten / Best regards,

Ger Hobbelt

--------------------------------------------------
web:    http://www.hobbelt.com/
        http://www.hebbut.net/
mail:   ger@hobbelt.com
mobile: +31-6-11 120 978
--------------------------------------------------



On Tue, Feb 14, 2012 at 3:06 AM, Brandon Holtsclaw <
reply@reply.github.com
> wrote:

> Ahh , great, yea I had actually planned on working a little more rebasing
> into this and making a proper name-spaced class/set of classes sometime
> very soon, just been hammered the last few weeks. I see light at the end of
> the tunnel though and will jump back in this soon as I have some other
> ideas to get pushed too.
>
> Thanks!
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/pixeldrop/lessphp/commit/1af6bd6148fe3c41b0892437cb50dea92cb346fe#commitcomment-962958
>
Yep. That's good point. I was trying to explain Abbrev mode
(only active minor mode in default cc-mode), but I decide
not to explain that because I use ysnappet rather than abbrev.

On 02/02/12 at 05:29pm, Namhyung Kim wrote:
> Is this screenshot helpful? I don't see anything related to dynamic abbreviation here.
> Wouldn't it be better to use 'C-h f dabbrev-expand' instead of 'C-h m'?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/tsgates/emacsbook/commit/8d4b8377213736b7af829b749e2b02a03aeaa14e#commitcomment-928621
I was only commenting on this, because I feel it's a bad idea to keep magic numbers in the code; better to use constants everywhere. Wasn't opting for making it variable
FD doesn't have an act break element style? Really?
Actually, handlebars templates are a bit different. I might just fork this repo in order to make special accommodations for handlebars templates.
Did you by any chance mean to say "introduce some `magit-show-item` action"?  Assuming so, I guess I have a hard time seeing how it wouldn't be quite similar to `magit-view-item` in many cases.  For instance, wouldn't the actions for commits and stashes be exactly the same?  Would such `magit-show-item` have meaning in the status buffer, and when applying it to a file (or even a diff / hunk) there, how would it's actions be different that the current visit behaviour?  If the behaviours overlap to large degree, I would suggest that's evidence that in fact they're the same operation.

If I'm understanding you correctly, you're concerned about two things:

 - `magit-view-item` should always take you somewhere that you can "continue working".
 - How to distinguish between the various different instances of a file that the user might be interested in: the current working directory version, the pre-commit version, or the post-commit version.  (Does a merge commit have even another, ie, the common ancestor?)

For the former,  I would argue that when looking at a diffbuf, the user is looking at an immutable view of some change in the repo.  Given that, it feels reasonable to me that "continue working" can reasonably include "inspect the result of that immutable change in more detail".  For the latter, I think that visit-item on a hunk/diff in a diffbuf needs to choose the "most useful" (and there, of course, lies the difficulty) of those possible instances to display.  For me, obviously, the "most useful" is the post-commit version of the file.

I'm not quite sure how to proceed.  I can continue to try to justify my position, but I don't want to waste your time if you're definite that `magit-view-item` shouldn't change in this way.  Do you have any slightly more concrete thoughts on how your alternate perspective might look?  That might give me something I could react to more constructively.  Finally, we can just agree to disagree and I can maintain this on my own.

Thoughts?
you do everything right here from the phpcr user perspective, except for this call to refresh which should not be necessary at all. i think that this call does have any effect is a clue to track down the bug in jackalope.
If *buf is not used why declare it __attribute__ ((__unused__)) ? why not remove it's definition?

Also I hate the use of "register" keyword. It's totally dumb. The optimizer just ignores it and does what's right. And the -o 0 ignores it as well. If it would help even with a 0.00001% we'd use it in the Kernel, we don't believe me it's stupid.

Cheers
Boaz
And this is desireably because?
On 02/24/2012 04:08 PM, Siamak Sadeghianfar wrote:
> No! I'm surprised to see it there to be honest. Shall I remove it and send a new pull-request?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/siamaksade/jboss-as/commit/71f5984172dd518b5ac360bd9ba53235970846e0#commitcomment-1007865
>


Look to https://github.com/jbossas/jboss-as/pull/1598/files#diff-0 there 
are other stuff that needs cleaning.
justification of paragraphs, etc
CONDITION_QUEST_STATUS_NOT_TAKEN = 1
CONDITION_QUEST_STATUS_ACTIVE = 2
CONDITION_QUEST_STATUS_COMPLETE = 4
CONDITION_QUEST_STATUS_REWARDED = 8
CONDITION_QUEST_STATUS_FAILED = 16
Are the only conditions needed
Thank you so much. Good work, i'll report a few bugs but keep it up. Waiting for putricidio, LK, etc.
Ya, I guess if you use non-English characters in column names it would screw up eh? Got a better RegEx we can use maybe? In any case, it's at least possible to change it with set().

I'll write some tests soon to show what this actually fixes.
If the dir is like this  c:\\\\\\dir\file3.ext ... The preg_replace works. But If You want Speed use only str_replace like You did  

Ricardo Sismeiro

No dia 04/01/2012, às 01:38, Pedro Mata-Mouros <reply@reply.github.com> escreveu:

> Why the preg_replace(), a str_replace() wouldn't suffice? Could this be replaced by
> ```php
> $this->_dir = str_replace(array('\\', '//'), array('/', '/'), $this->_dir);
> ```
> or am I missing the point?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/rasismeiro/cintient/commit/a409c1570864de3da1a86d4cd33503fefe0edb00#commitcomment-835603
Yeah, I did. Thanks.
u serious? xD
One of the reasons I have not done this myself is because i did not want to get into all the sanity checking; I will give this a try.

Also so I can see the diffs for the embedded scrips in a somewhat wore readable form could you take a look at [dak180/-wzXcodeScripts] (https://github.com/dak180/-wzXcodeScripts) ?
I love Addressable. I would use it over stdlib at any time. However in Rick's projects there were probably other gems that specified their Addressable dependency too tightly, so in the end they were incompatible. I agreed that we probably don't need Addressable because we don't use any of its features. However one can configure Faraday to use Addressable by subclassing Connection and overriding the `URI()` method there.

I'm a little worried that this change might break a lot of middleware. In most my middleware I've used `query_values` method to get & set GET parameters. Now I'll have to do much more manual work. I'm thinking about subclassing URI::HTTP to add `query_values` to it, and having Faraday pass those around, however URI classes are a bitch to instantiate (very poor OOP design).
lost sql for spawn boss in world
You are talking about python terminal. If you do "python run.py" in bash terminal, the string '\x00\x00' doesn't show up as '\x00\x00' because it contains non-printable character.
any chance of having the comment in this file not do /*! so that it will get stripped with yui when compressing/minifying?
Again, I hear you -- note that the leading paragraph states "In the absence of project-specific requirements".  The intent is that there should be *some* documentation, and if you don't have a policy in place, this should be the default policy.  Is that acceptable, or do you think it still needs to be removed entirely?
like omg no wai.
I created a new pull request #15.
sure - but as of flamelash example we require to take a small look into these bosses before removing them - scripts might be wrong
This is a really bad idea - you should not pass local variables to a template via globals as it will clash with something eventually. I know you're using `load_template` which doesn't accept an `$args` array but just implement your own template loading method that that does.
What is wsgiref?
The rect params are already set to all 0s in the default constructor and we return the same default rect above in line 640/648.
Bogdan has some work in save_person.php
If it's only a boolean that's necessary I'd prefer it yes :)
Stef doesn't care as far as I know (we've had these discussions before).
Although the truth is that the Builders aren't as "clean" anymore as they used to be.
Still that doesn't mean we should just give up on trying to depend as little on the model as possible.
So if you don't mind, I'd appreciate it.
Thanks to @bluepeppers for the history snippet, which I adapted from PyClojure
How different is this file from pr2_manipulation.launch? It looks really similar. I think you should put your additional stuff (if any) directly into pr2_manipulation.launch.
Looks good to merge otherwise to me
Great commit message.
try to avoid using `<br />` to lay out a page. Try using margins instead. For example, Something like

    #wrapper {
      margin-bottom: 2em;
    }

should work
Also, can this method be inlined?
What is going on here?!
Oh Nay made a funny
voy a revisarlo...
The first one looks correct.  The second is all to do with where the png and jpg files are stored... but I'll go with JOhn's version.
haha, not a problem!
Actually I think part of my confusion comes from the fact
that assistant field is  implemented in AD 2003 as  msExchAssistantName  (
my production env) , but is "assitant" in  2000 ( my old testing env - I
know it is OLD)

Anyways this allowed for easier debugging. I can remove it if you want.


On Wed, Feb 8, 2012 at 2:08 PM, nick gorbikoff <nick.gorbikoff@gmail.com>wrote:

> Hi Richard.
> I'm implementing an internal app for hr, and some of the attributes that
> they need to access are: assistant and employeeid . They are not
> implemented as separate methods. Most likely cause they are  not used a
> lot. So this allows for a quick access to those values without implementing
> a separate method. Maybe a more appropriate thing would be to make them
> attr_reader at this point to avoid screwing up the record accidentally.
>
> The proper solutions is of course to implement proper methods just like
> User.manager but who has time? :-) May be I'll do that and do another pull
> request in the future.
>
> Nick
>
>
> On Wed, Feb 8, 2012 at 1:58 PM, Richard Navarrete <
> reply@reply.github.com
> > wrote:
>
>> Hi Nick,
>>
>> I haven't had a need for this - can you give me an example of how this is
>> useful for you?
>>
>> Thanks,
>> R
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/konung/active_directory/commit/2325f1875cc12fc363c1db4c8c8dda1bce00691c#commitcomment-946679
>>
>
>
>
> --
> --------------------------------------
>
> Nick Gorbikoff
> nick.gorbikoff@gmail.com
>



-- 
--------------------------------------

Nick Gorbikoff
nick.gorbikoff@gmail.com
hmm this else block looks like a case of the YAGNI.

the rest looks interesting, though.
The ...TooltipLine1 and ...TooltipLine2 were supposed to be in mixed case, since their variable width font includes lower case characters. Tooltips look a bit ugly now. Would it cause a problem in non-English locales to keep the mixed case for just those entries?
Don't return! return quits the whole function, just use break. Anyway i fixed it on my repo.
— Build what? 
— Query.
— What query?
— UpdateFrontSideText query.

Something like this. ‘Query’ should be in the end at least.
if (!mdl || !mdl.open()) maybe corrected ?.
finally ^^
The 8 bytes a part of a guid most probably.
This was fixed in another commit. Why cry about it now?
I actually had a much longer form for this page originally.  The problem with a big form was too many things were going on at the same time. 

On the other hand a small form needs several forms.  It might be good for me to look at other solutions.  (magento / ZenCart)
Can you combine this with the `Gemfile`?
btw. it this is @FernFerret's fault :P 49ffb4dcec79646f6f1f8059cf39e80f11f88160
Vielleicht noch die erwartete vs. tatsächlich Anzahl von Parametern in die Fehlermeldung mit aufnehmen?
that would be nice
I found it more convinient to use $controller->redirect(array()); (https://github.com/dereuromark/cake-auto_login/commit/cb557e1f276319f3efebba3c6d3dfbc0acc60878)
This sounds like one negative too many. From what I can tell it fails if the access token *contains* bearer.
I'd user FILTER_UNSAFE_RAW for passwords because we don't want to strip any characters from a user's password.
en deze ook niet...

Bedankt voor de check!

fijne vakantie!

Kees-Jan

Op 24 februari 2012 10:42 schreef Gideon van Melle <
reply@reply.github.com
> het volgende:

> NOOIT
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/MIUI-Dutch/Translations-Dutch/commit/75e8c325e9b19bb0b0067e89240e630dc4e488e2#commitcomment-1006660
>
If the upload fails, we won't try again. I suggest you define a sentinel value for the server client record timestamp, which will persist across syncs: set the timestamp to -1 here, and *don't* update the timestamp if it's -1 and we aren't in the upload handler.

That is:

* Process commands. Set timestamp to -1.
* We fail to upload. Timestamp is still -1. Sync aborts.
* New sync. We download our client record; it still has commands. (Hmm, process or not?)
* We *do not* fast forward our upload timestamp, because the local one is -1.
* In shouldUpload, we decide to upload.
* In the success handler, fast-forward the timestamp as usual.

Alternative: if we fail to re-upload, and we were re-uploading because of commands, do we need to do this? We'll always re-upload after commands, right?

Argue with me!
Just wrapped up some of the suggestions you had regarding the RNG and pushed to random1.  See the individual commit messages for details. The only thing I didn't get around to was a deterministic seeding option but any way I thought about it there seemed to be complications.  Still something I'd like to see added eventually.

Otherwise, how do you think 0.3 is progressing?  Are there any areas you're focusing on?  I'll feel better once the capture stuff is ironed out.  Otherwise I'm keen on getting flatMap working, so if you'd think that's something I can help with I'd love to hear your thoughts on an approach.
Production token changed
Yep, thanks, I'll take care of it
Pas d'url en dur!! Regardes ce qui a été fait pour l'url de l'image uploadée dans 'add'
I don't understand this move. Why do you no longer return `MethodConstraintViolation`? Aren't they all `MethodConstraintViolation`s in this case?
just try it, Lol xD
Hey, you should come on irc.quakenet.org and join #wcell and say hai (I'm jaddie in there) can probably help you out with irc related stuff + suggest a good library to use in C# :)
P.S I would have messaged you however you don't have an email paired with your github account
Don't get me wrong but IMHO you should not commit changes before you've checked that they work. Just my opinion....
It would be great to have new dot release of gem with this change - now that RoR 3.2 is out.
would prefer to see the :even and :odd jquery selecters put into action. (http://api.jquery.com/even-selector/)
So something like

    rows.filter(':even').removeClass('2').addClass('1');
    rows.filter(':odd').removeClass('1').addClass('2');
In my extract-files.sh I have defined this when creating device-vendor-blobs.mk:

vendor/__MANUFACTURER__/__DEVICE__/proprietary/sec_touchscreen.kl:system/usr/keylayout/sec_touchscreen.kl \\
vendor/__MANUFACTURER__/__DEVICE__/proprietary/sec_touchscreen.kcm:system/usr/keylayout/sec_touchscreen.kcm \\

This should tell the compiler to copy both sec_touchscreen.kl and sec_touchscreen.kcm to the target files.
But there is still some headache about why it's not doing that. I have to all the files which are defined in device-vendor-blobs.mk to the correct place in the target directory.
Probably could just delete this line? I mean, POTI does own the (c) to portions of the code but it's also openly licensed...the app itself after we compile though, isn't their copyright anymore since it's a derivative work. I think we just need to credit them in the license that appears when you click the "about nightingale" menu item.
*sigh* I PM'd you on XDA because I keep an eye on a bunch of AOSP repos here on github, when I noticed all your Android repos disappeared I wondered if you made them private, hence why I asked. You replied on the 7th February, and if you bother to look on the XDA Desire S forum, you'll see we've been pushing CM9 builds with camera code since the 17th Jan.

I only pushed the code onto gerrit because Kali and I had been discussing it on IRC and he requested to see what I had working. As we both know, gerrit doesn't let you squash commits and credit every author, and if you check my github you'll see your repo forked there with it's full history.

At the end of the day, I made a mistake for not putting an author list in the initial commit, but again it's all marked -2, it won't be committed in the current state, if at all, and had Kali not requested to see it I wouldn't have even pushed it in the first place. What you believe is your prerogative, but I haven't mislead anyone or lied about the source of the code.
Works either way for me, if that's the case the new commit sticks with .last for everything.
Please do give them better names. You now have our best understanding of this code. If our understanding changes, we can always rename.
Is this line needed anymore?
`dist` here is a setuptools Distribution object that we know is installed.
why convert it to a InstallRequirement and run `check_if_exists`?
we're checking that a dist that we know is installed is installed?

as for how req is used later.  2 properties are called.
- req.installed_version is text-parse routine of PKG_INFO, that just finds what we already know from dist.version
- and req.name is just a property that returns dist.project_name

I guess you might argue we should limit/isolate our use of pkg_resource interfaces for some future refactor, 
but this seems too tangled, unless I'm missing something.
Is it better to use the {{apiDocs}} variable instead of /yui/docs/api/?
Per conventions, this should just simply be `log`.
can these factories be cached as instance variables?
missing newline before
is this artifact name going to be correct? (don't we publish binary scala version in artifact id from 2.1?)
foreach doesn't return an iteratee
oops didn't think about that. it's the ConsumerConfig info I need to pass on I'll separate that out.
ah, that’s a good point, will take out.
mpd won't return anything with the current command unless it's actually playing. Should I just remove the test then?
I think this is redundant, and it would be better to leave this out and use is_file() instead of exists() on line 102.
I stlil maintain that using a numeric convention like this is an antiquated approach that was needed in C and looks very out of place in Python.
See comment above concerning m_strArtist and m_artist.
@Montellese: implications?
So I thought about this, and I'm not sure if its better to put the format definition here (the parser), or into the actual sample configs (which is what people will look at when they're trying to figure out what is going on)

If you move it out to the config files, you might want to include it in both, the test config and the aws config.
why do you need this ?
break for 80 characters.
@galaxas0 is it mentioned in the GH conventions? I don't see it.
Ooh, nice! I'll do that.
Does this mean that clients will simply get new sessions all the time?
Older discussion at a93925f628815dd48d42f8d2a811de5002e2bd68 (wiped by amend)
Missing else for when `dom_import_simplexml` doesn't exist
I think it maybe be confusing as the user may think that readable() will make the channel readable again.
`AbstractOioByteUnsafe`
Just out of curiosity, what happens if N or M is zero?
Done: https://github.com/asmecher/php-src/commit/823ddbf2f3605743ebd845ba355bb1682ad0b607
how about  remove duplicated return:

else if (*DATEG(default_timezone)) {
      php_error_docref(...)
} else {
      php_error_docref(...)
}

return "UTC";
Please write one combined changelog entry describing the new input helpers
`:default   => [:"errors.format", "%{attribute} %{message}"],`
Done =D

https://github.com/rails/rails/pull/5540
this lines should be kept
This is a highly useful method.  Note: You can define abstract traits in src/partest that you can extend in these tests.   I'd love to see intercept there.

Also note:  `scala.util.control.Exception.catching` should probably look like this a bit too.
It wouldn't do any good to inline it.  It will still create an array, put all the args in the array, wrap the array in a WrappedArray seq, and then take everything out of the wrapper.
this and further occurrences need to be refactored after previous comments applied
See https://github.com/sympy/sympy/pull/1385
1.0 works fine
>>> p=1.0*ImmutableMatrix([1,2])+Integer(2)*ImmutableMatrix([3,4])
>>> p
1.0*[1]
[2] + 2*[3]
[4]
>>> print pretty(p)
2*[3] + 1.0*[1]
  [ ]       [ ]
  [4]       [2]
>>> print latex(p)
2 \left[\begin{smallmatrix}3\\4\end{smallmatrix}\right] + 1.0 \left[\begin{smallmatrix}1\\2\end{smallmatrix}\right]
At the beginning I was using a tuple, but Aaron suggested the idea of a dict (#1940) to let the possibility to extend and to not fix a priori the number of different dimensions.
I hate to say this, but you should convert this entry to addb format ...
I personally prefer raising errors. I tihnk that lots of the users for this library will not be experts and are bound to make several mistakes. Additionally this module has a steeper than usual learning curve for SymPy. I think that some guidance as to what is valid and not valid really helps direct new users to proper behavior. 

For example I as a user might think that I can represent a Point with a tuple `fx((1,2))`. This is garbage, yes, but we shouldn't expect a new user to understand that. They should receive an error that tells them that they made a mistake. 

This is, at least, my philosophy on this topic. Different communities think differently. Sociologically I think that the Python user-base is filled with more novice users than say, the Scheme community of the original paper.
I mean, doesn't the sympy codebase have a self-imposed limit of 80 characters per line or so? If you can, it would be nice to wrap the test.
missing opening bracked, and "incomplete" instead of incomplite
On 11.06.2012 15:37, Christopher Smith wrote:
>> @@ -517,26 +517,26 @@ def homogeneous_order(f):
>>           return tdeg
>>
>>       def LC(f):
>> -        """Returns the leading coefficent of `f`. """
>> +        """Returns the leading coefficent of ``f``. """
>
> cent->cient
>

Done (5 times).
On 17.04.2012 11:13, Christopher Smith wrote:
>> +        """
>> +        Compute the ideal generated by the union of ``self`` and ``J``.
>> +
>> +>>>  from sympy.abc import x
>> +>>>  from sympy import QQ
>> +>>>  QQ[x].ideal(x**2 - 1).union(QQ[x].ideal((x+1)**2)) == QQ[x].ideal(x+1)
>> +        True
>> +        """
>> +        self._check_ideal(J)
>> +        return self._union(J)
>> +
>> +    def product(self, J):
>> +        """
>> +        Compute the ideal product of ``self`` and ``J``.
>> +
>> +        That is, compute the ideal generated by product `xy` for `x` an element
>
> set off "an element of ``self``" with parens or commas?
>

done
oops -- I see that this function is merged with the previous. I misread the diff.
Yes, was thinking about it, will handle this one.
yes, found it helpfull to add it here too.
Just a minor thing - should this be BOUNDARY_CONDITION_DOF_MIXED=2 since the variable used previously to define a mixed bc (BOUNDARY_CONDITION_MIXED=7) has been deleted below.
Perhaps move this line and make an example of it.

Mentioning you can change the global format is also good:

```
$this->Time->niceFormat = '%Y-%d-%m';
CakeTime::$niceFormat = '%Y-%d-%m %H:%M:%S';
```
at line 48:  TIMEOUT = 20
concider making this a Params parameter. Any reason it is not?
nvm, there's an error on the console

this is probably an issue in itself
Is there any reason this isn't wrapped up in a JST file? Specifying it like this breaks the pattern of being able to put a single `<div>` in a page to see a whole widget. If there is a desire to make the widgets function separately, then create a meta-widget that places the entire HTML slab onto the page and then triggers the sub-widgets (like the tree rings list widget).
mention what the previous behavior was.
How did this reached here?
Is this new after the rebase?
Err right, true I meant :)
I'm not positive on this, but AFAIK new code in develop should use access keywords (public/private/protected). You don't have to change existing code, but I think this needs to be changed at least.
http://area51.phpbb.com/docs/31x/coding-guidelines.html#namingvars
Yes it needs to be consistent, hence there are guidelines.

One reason to do this is when you have a stand alone system that doesn't use phpBB template files, the frontpage of one of my sites for example. Until now, I haven't seen anything that would break that with 3.1, however this change will instantly nuke my frontpage. I've said this before in a similar discussion, you can't guess which third party relies on phpBB functions/behavior and if you say that only major releases break BC, then only major releases should break BC.
Otherwise this needs to be properly discussed and announced so that you don't get caught by surprises if you maintain such package and don't track every single commit that goes into the phpBB core.
There are guidelines for these kind of situations and we should stick to them, I don't have the time to make a comment like this on every commit that breaks BC ;).
parent for a top-level style (which actually has no parent) must be either empty or identical to the display-name element.
Creating the array in the method call makes the call quite messy to read. Would IMO be better to first set the array and then pass a variable into the call.
Why the nested if statements?
No, I think it's fine.
Not to kans: make this a UUID or something we can split on dependably.
ai folosit " ' " pentru siruri de caractere peste tot, folosește și aici, te rog.
To match how other tests are organized withing source/lib/tests. the controller test should go in here instead:  `source/lib/tests/autoload/mojits/HTMLFrameMojit/controller.server-tests.js`.
The indenting is messed up.  Try using spaces (instead of tabs).
Identation problems (hard to read)
почему сюда не перейдет код если все хорошо?
получается если все ок, то птрид подвисает? ну тогда он только 1 ребенка запустит, нет?
Shouldn't this be the binding config rather than separate properties for each binding config option?
> I wonder now if it should not be np.asanyarray to allow ndarray-subclasses to not waste memory/time

probably, even if this is a highly theoretical situation...
awesome suggestion Nathan... Can you please add this to the https://raxaemr.atlassian.net/wiki/display/RAXAJSS/Code+Style+Conventions+for+JavaScript
not removed -- would like buttons to be centered but causes a bug where buttons stay even though page navigates.
https://raxaemr.atlassian.net/browse/RAXAJSS-371
Does grib really not have a lbhem equivalent?
Further to an earlier refactor comment, this might look like ```fake_message = create_fake_message(edition=1)```
break after return is misleading -- the compiler really didn't complain with a warning promoted to an error?
My fault - I should have proof-read.
fix comment cut&paste error
if kwargs['type'] in {ComponentType.memory}:
Why unindent?
This one is because each line in an INI section is technically an option so receives a "--" prefix during docopt translation (inifile.optionxform). Here we get rid of the prefix.
Dialyzer bitches about this.  Use non_neg_integer or integer.
Тоже копипаст? Надо вынести в отдельный util для тестов.
Not sure I understand the semantics of select. Is it a boolean? Please make it so if it is. Also, is it an action? Then why is it variable? Please find the better name.
Presenter=Workflow=Activity, I use the term workflow when I use the editor to work with form. Good observation about the order of the parameters. I think this is an issue we need to discuss and agree on one way to do it.
Why remove this? `return if page.nil?` prevents gollum from crashing when a page can't be found.
What is this about? Can you tell us more?
When ```fn == null``` and ```data == null``` and ```typeof selector === "string"``` - this code will be called after commit, in contrast to before code
The difference here is 11 bytes, and this block is only executed on initial creation of a Deferred. I think it's worth the small difference.
This behaviour isn't changed, look closely
I'm curious -- in what case could you end up with duplicate services?
I just pushed a new commit for the fix in this branch. Would you rather have a new pull request? Or you can fix it if you want.
Oh right. Variables in urls would work well. Lets do this. bd
"anyway"
Again, would like to know source of patches.
Was the removal of the `amalg` build option intentional?
Don't align on the quote.
Perhaps "Mark the object as read".

You can replace object with item or thing if you prefer.
this should be ``_formatFirefox``
Spaces around `:`
(I almost did this change last PR but it was getting too big - leave it for later if you want.)
How about making your own Charsets class?
This file doesn't belong, but if it won't hurt anything, no biggie.
nb, I think just `File.read` would work here.