labofsahil/github-event-dataset-2012 huggingface dataset:
This use of ``this`` and ``that`` in ``showDialog()`` is a bit confusing now. On top of that, some of the event handlers are bound and others aren't: _handleItemSelect, _handleItemFocus, _handleKeyUp, _handleKeyDown, _handleResultsReady. 

Also, just for consistency, I noticed _handleFilter and _handleResultsFormatter aren't wrapped in a wrapper function like the event handlers are. I'd actually prefer if we remove all the wrapper event handler functions (line 927-932) and change the signatures instead. It might be worth renaming _handleFilter and _handleResultsFormatter too since they aren't actually event handlers.

This is probably more refactoring than necessary, but I think at least we should fix the first issue with this/that and bind.
Why don't we just use the document passed in the event since DocumentManager always passed it in?  
You can just replace "data" with "doc" and then remove the next line.
"Sort Recent" doesn't sounds like it will sort the working set by the MRU order (recently view order). I think it sounds like it would use the most recent order instead. Maybe "Sort by View Time" or "Sort by Selection".
I think I fixed this now
Our coding guideline is to use double quotes for all strings and the one nested inside then can use a single quote. So can you switch to double-quotes in all your test cases?
Which of these parameters are required and which are optional? In particular, is `command` required, or can I just add a `click` handler? What happens if I specify both--which order do they apply in?

I wonder if it might be simpler to only have commands for now, and not click handlers. Overall, I think we need to keep our API surface as simple as possible given that we don't know how we might need to morph it for native menus. (Alternatively, to vet that we can actually support all these APIs in the native case, we'd need to actually think through how they'd be implemented there, to avoid promising functionality we can't support.)
Would be nice to have added scm and rkt extensions to lisp, for Scheme.
same comment about {% empty %}
is this domain? even though we call them "projects" in the UI now it sorta feels like we should be consistent in the code and stick with domani
notice in the old code: `git config --get-regexp github`, we should just have an additional value there: `github.oauth`
You can combine last two into one line. Also do `edit as edit_views`.
Structure code as we have structured this things otherwise (each pair in its own line).
Thank you. Please grep over whole source code and change any occurrence of *she* to *they*.
Space before the last `*`.
Wrong word used. We have only one. What i meant is that i aded language column in database ``language=settings.LANGUAGE_CODE``. that is what i save in DB
I don't follow. Don't we want to display results in the current page without any redirections? This way the results are shown above any main content. To restore to previous page just close search results (within main content). Would you rather have it toggle between current page and search results?
Looks like duplication of `adding_tag` file
I don't think this needs to be separated from `butter-scroll-bar` since it's an integral piece wrt to the of the code for this feature (which is right inside `src/util/scrollbars`.
How come this title was removed completely?
Right.

So if ui is enabled, leaveDialog can be disabled or enabled.

But with ui off, I think it makes sense to have the leaveDialog inside the ui block, because we don;t use the leaveDialog with ui off, so people might get confused as to why it is not showing. By putting it in the ui, it is obvious it is off if ui is off, but with ui on, it can be on or off. This was my intent, and I think you produced that.
What... changed here?!
Same as https://github.com/mozilla/butter/pull/1316/files#L8R108.
"...in development mode"
just after this line, it will `callback(null, null)` anyways. plus, its inconsistent with the other crud methods in this file.
`var` can be removed
Should be modified to be called "processAlias" or something similar
nominated -> specified
@xsuchy ok ACK, thanks for the info
This was originally written to require a user to pass in an environment in order to reduce people accidentally requesting repos for a product across all environments (which we've never really needed).    The use of @repo_cache[0] is very confusing, and I'm not really sure I like it.  

Do you actually need to request all repos across an environment?
I don't think it matters.. At the end of Manage nurses, I say to go to Rules, and at the end of Rules it says go to Year.
我错了。。。是Not，must_not后面是个query。
We could define a constant for (unsigned int) -1, as it's a magic marker value we use in many places.
I missread this file and had the impression the code for == "version" was moved or removed ... I was wrong, sorry :).
IMO this was a much better/simpler way to do it... ;)
I'm fine with it moving to protected, @sitedyno makes some good points.  Also 2.3 hasn't gone stable so this isn't a big break in compatibility.
Not sure what method(s) call this, so this may not make sense but.... we could catch the exception and handle it without crashing the simulation.
hm, this is a valid point you make here. but i really don't see how we could handle that without getting even more complicated. before i started with the interfaces, there was just the 3 classes extending node, so everything was mixed together. the interfaces just separate definition and instance and make the inheritance more obvious.

we could have the NodeDefinition contain a type/property/collection instead of having type/property/collection extend the nodedefintion. and the same for concrete instances. but then you would have to ask the node for its rdf element to operate on that. but for the children you would need to have the property/collection know about the node again, otherwise the hierarchy would be lost.

shall i change to code in that way? have the nodedefinition contain a type/propertydefinition/collectiondefinition and render it? then when you ask the node for its children, it could go through its type to give you the node containing that propertydefinition...

i guess the model would indeed be cleaner, but its a hell lot of object models.
Accidentally included?
Oops, I forgot I had made a pull request from this.  Fixed.
You can write this more simply as `modues.pop('__init__', None)`.
There shouldn't be anything missing in more recent pyzmq. If you do encounter such a thing, please report it as a bug.
Two blank lines is enough.
The name of the remote is only relevant because the default remote branch mapping uses it. It'd generally be silly to use anything else, but this information should be taken from the refspec.
Maybe here a javadoc is not the best option, but somewhere the semantics of the configuration should be documented.
`self` is not referenced anywhere within the scope of this function so it's fine that it was not re-added.
We follow pep8 (http://www.python.org/dev/peps/pep-0008/) pretty strictly. One of the things that it enforces (for better or for worse) is 80 column width.

For something like this, you can either calculate the second half on the line above:

```
today = datetime.datetime.now(tz=convert_tzinfo).toordinal()
if convert_value.toordinal() == today:
```

Or something like:

```
if (convert_value.toordinal() ==
    datetime.datetime.now(tz=convert_tzinfo).toordinal()):
```

Up to you :-)
Our 'users' are machines, and they understand error codes better than strings. More detail will be available in our logs if people ask.
This should be `if ( !fileSystem.fileExists( file.getAbsolutePath() ) )`
Looks like this should be: 

    <td><a id="market_url" href="#"><?php _e("Download manually"); ?></a></td>

instead as it's the anchor tag that's incomplete.
You can use row() here, and add LIMIT 1 to make it more efficient. This will return ALL sites, instead of just one.

Then you wont need $r[0], just $r.
.live() has been deprecated in jQuery 1.7. Use .on() instead, but beware that the semantics of .live() and .on() are not identical.
I'll refactor it to if/else condition.
I hate to be Jesse, but UTF_8 ?
Dates and currentTimeMillis are crappy for measuring elapsed time. They don't necessarily increase: if the user adjusts his clock, this can flow backwards! I also recall it being more expensive to sample currentTimeMillis than it is to sample nanoTime
I get it now, thanks. I made a fix for that.
It's probably better to use `curl -s http://getcomposer.org/installer | php`. The installer will do some basic checks and do things like retrying to download `composer.phar` (since that sometimes fails while the new .phar is built).
wrong English. `valuesContain` would be correct but is not really nice anyway.
Further down the line, we do a check for `$value instanceof \Closure`. Since the instanceof check performs far better than `is_callable($value)`, I left both the instance check and the type hint here in place. We can always make this constraint less restrictive, should it ever become a problem.
$block is an unused variable, same on line 62.
Adding new methods in the interface is a BC break for implementors.

@fabpot is it fine for 2.2 as the component has not been flagged as being part of the stable API ?
This test should be skipped on Windows as it would trigger the binary, which will not work.
you are right .. i thought this way would be faster .. but since the bundles array already exists .. it was infact quite a bit slower. correct it ..
コメントありがとうございます。
確かに使わないファイルなので、以後注意します。
macros should be avoided, it's good idea for NSLog, but rest could be implemented using function calls (it's more secure and allows future extension)
应该具体说明是第几章，第几节或者是哪一块内容即可
参考文献就带着弄吧，应该尽量避免repo里面出现不该有的代码
Both quick fixes are available for this code snippet:
fun test(value : String) : String {
  return value!!.toString()
}

I suggest to forbid one from UnnecessaryNotNullAssertionFix if warning is in the middle of DOT_QUALIFIED_EXPRESSION.

By the way, Sergey, what tools do you use for monitoring PSI tree. I don't remember did I tell you about Tools->View PSI structure of current file?
These member variables should get Doxygen comments.
I think you've got to be careful here regarding the madness that is windows API string handling.  In particular, the type of LPTSTR may be either char* or wchar_t*, depending on whether UNICODE is defined when compiling the project.  (If it's compiled as a unicode project, the cast and assignment to win32Error will probably fail horribly!)

Here's what I think should be done: Call FormatMessageW rather than FormatMessage, and set the type of lpMsgBuf as wchar_t* (that is, LPWSTR).  Then you'll get out a unicode string in UTF-16, you can use WideCharToMultiByte to convert to UTF-8, which can then finally be stuffed safely into a std::string.  For an example of converting these strings, see Filesystem::path_from_windows_native in libutil/filesystem.cpp.  Actually I think we should just move path_from_windows_native into include/strutil.h, rename it, and use that.  Suggested signature:

```C
std::string utf16_to_utf8(const std::wstring& utf16str);
```

(Aside: Yikes, what were the microsoft API designers thinking when they made this string handling stuff up?  Oh, that's right, they weren't.)
> That's fair. I'm working through where the issues came from and will merge your request when I get some free time later.
I told you - it was the merge commit. Anyway I refactored all that code.
So I'm not sure its worth spending much time on it.

Surprisingly nobody noticed for a long period of time.

The VimL Layer is pretty small anyway.

If you wonder why I introduced autoload. Because you can debug using
commands. s: functions are not available.
Let's leave out the `#{err}` and just say "Server application error".
``required``.
activities is the new name for activityHistory, and it is a collection of Ativties stored in the user. this is an intersting design consideration that i think i like, let me know if you disagree. what it means is that if the user logs in to any computer, they will putll down alltheir activties and see them in their activyt feed, thus they get their activity feed even when offline, becaue whey they first synced that device they got them. of course the activiites will be out of date if the user uses two computers offline. right now the server is not do ing a diff on users, it is replacing them. so if the user is using two computers, the one that synced most recently will over write the data rahter than merging it. TODO add issue to add a merge logic to the server
when you want to add a Saved doc, simply send in its pouch id and it will get added to the array of ids that the app knows about
Missing space character.
@scottgonzalez My other idea was to check if `window` was undefined, but even that can be misleading. There doesn't seem to be a generally "right" way to check for node.js. Not sure what AMD is referring to in this context.
@scottgonzalez `that` is needed here to use regular `menu` callbacks. Any idea how to replace it here?
"...more complex application.."

I think you meant "applications" here
Yes, the "Cancel" word is from the wireframes.
Here the cancel button reset the search and back to mix page, so "Clear" button should be another one that dose the clear work. So I added a clear button inside the input, to let users to clear their search string.
I already did a comment last time about pDate/pTime. Let's fix those names.
Ideally this code should be rewritten a bit differently. you likely want to attache a mousemove/mouseup listener during the mousedown and only if there a photo in the details of your contact. And then instead of the position = 0 trick you can use var startPosition = evt.clientY do a |var currentPosition = evt.clientY| in mousemove and check if the diff of those if > to a certain threshold.
You may want to add a method that does that since you do it above too. The only difference beeing the target you append the element too.
I think you forget to set it back to zero when a new popup is being requested. Does the about:blank issue only happen at the first popup since boot up?
typeof title === 'string' may be cleaner?
remove this line if style is not used.
switch(m.type) {

case 'trace':
case 'friendRemoved':
.......
Yup, will do
Die Pakete heißen schon immer mit -x-sie sowohl für automod, als auch phpbb https://www.phpbb.com/customise/db/official_tool/automod/
I guess it should be `else if`
I might put an assert(w == width, "Mismatch on width") or something.
Which one is it? I don't think the relative path would work.
This command doesn't include `/root/appscale/AppServer_Java`, so how does it work?
Not fixing this since the test is making sure no exceptions at all are tossed.
Note that it also validates where the interface.py file is and changes the path.
We still want the `'No file selected.'` error, so add `threadID = 'new'`.
It looks like you're changing the default value from `UIPrintInfoOutputPhoto` to `UIPrintInfoOutputGeneral`. For backwards compatibility, I'd avoid that.
isWhitelisted pl0x
Looks like you're mixing 1 space and 2 space indents.
Hmm, I'd rather not, because:

 * They functionally concern to different uses (whether to print or not collors, supressing output conveniently)
 * To access colors, I'd have to access the replaced sys.stdout, which would be cumbersome. Better to restrict such hacks to the very minimum amount of code.
The BaseScheduler expects the ``codebases`` property to be set. The ForcedScheduler has not done this yet. Here it is time to do so. The properties coming from gatherPropertiesAndChanges contain all information to set ``codebases`` properly. Now the ForcedScheduler can work like the SingleBranche scheduler but without incoming changes, just call self.addBuildsetForChanges without passing changeIds.

Using ``codebases`` in this way will change the default set of codebases after each forced build. Therefor the ``__init__`` should not pass ``codebases`` to the BaseScheduler but preserve it in this class to be used as initial set that is merged with the properties from gatherPropertiesAndChanges().
Before you lecture me, please take a look at `.gitignore` – it contains eclipse related already. :)
Next indentation issue, you really should check the syntax checker I linked earlier.
Please revert this change and use M4 for Sty.c.
I propose for first event:
 ENGINE_SET_EVENT(p, IPV4_IN_IPV6_PKT_TOO_SMALL);
And for the second
ENGINE_SET_EVENT(p, IPV4INIPV6_WRONG_IP_VER);
OK with that ?
what about

return node == NULL ? NULL : steel_avl_node_to_elem(sat, node);
I think this should just be ```slist.h``` instead of ```include/slist.h```
self[key] is basically the same thing as self["@fields"][key], wht is the goal here? If you want to return nil, return nil instead of tok. No need for the extra 'subvalue' stuff ?
Btw, I just had a few details from the JS team. They confirm that, currently, `bind` is actually slower than regular closures.
I don't see why `base` would contain `..` nor `.`.
This method lacks of `;` and comments.
Nope, good catch!
r+ on database changes.  we have some challenges here with migration.  aside from the basic issue of getting the mysql tables altered, all outstanding verification links will be broken - they won't have a password set.  we need to figure out how to handle this.

The easiest possible way to address this would be to delete URLs from the stage table at the time we do the migration, but this will have user impact.  We could mitigate this by improve the page displayed to the user when they validate an email with an invalid link (secret no longer exists in database).

hmm.
Yeah, I was confusingly mixing the concept of "threshold" and "parent data for executing a test". Clarified on IRC that what's meant here is the latter option I mentioned ("looking for a parent that, when used as parent data, causes the current revision to pass the test"), so the wording should just be updated to make that clearer.
__xabolcs__ wrote
> Should I file a separete issue about that or a just a commit here would be enough?

OK! Noted the double indentation. Thanks for pointing that out! :)
No need for extra commits, issues!
@vrthra `resource[:ensure] = :installed`
Ah ha! I like it.
By the way, in Japan, we finally almost moved to UTF-8. When we process non-UTF-8 strings, any sane system immediately encodes to it.
This file is being read and parsed repeatedly, once for every ACIS observation.  It gives the right answer but is not efficient.
do you need these "override" keywords?
```php
null === $activationStrategyOrPriority;
```

is better than 

```php
$activationStrategyOrPriority === null;
```
I'm not 100% convinced we need this one; the only place you'd really need it is if you were creating a custom `EventManagerInterface` implementation.
@Freeaqingme Done.

@b-durand I didn't add any code to getConsoleUsage(), which makes that out-of-scope for this PR.
The message of exception can be more explicit like MongoCollection can be empty or must be defined.
I see you checking it in
No, it isn't  "most optimized", but I guess that optimizing that doesn't have any sense anymore, because the method is well optimized. Also, this TODO has been here for a long time, and I believe that has to be changed - look at the first point.
Adding a comment to test comments in div
it needs to be ``pecl -q install sundown-beta``
You're right, I was looking at the wrong todo app...
Couldn't these just be `assets/ie.js` ?
use a Module instead of many entries in the YAML bindings file...
ah, yeah. I now understand what you wanted to do. that's probably worth a comment :-) Thanks for clarifying it.
Can we just load all of the stylesheets on initial load?  Is there a problem if they are loaded all at once?  I don't like manually editing the DOM to change the sheet if not necessary.
change this line to :unknown_value => :andy
json is not php, this broke the build. i fixed it now.

@piotras please make sure to always use the latest composer.phar . well, maybe the syntax check was made stricter since you opened the pull request...
docstring should be on a single line?
add module docstring

something like

"""
Utility function for environment variables.
"""
Why not use traceback.format_exc() ??
In fact, it uses sys.exc_info() to retrieve the same information in a thread-safe way instead of using the deprecated variables.)  but returns a string instead of printing to a file.

You can get rid of cStringIO, the finally and tb...
This is because the welcome application uses the root context. You can't deploy an application into the root context if it is already in use. Shall I update the readme to make this clearer?
I am not sure that behavior is right.
The spec says: "When the splice method is called with two or more arguments".
Is that mean that when __splice__ method is called with one argument it should do nothing? All major browsers have implemented a different behavior "[1,2].splice(0)->[1,2]"
Just checking... this is still correct, right? (We did some shuffling of photo paths and just wanna double-check.)
Hmm, interesting. I saw what looked like a jingo-minify block in the settings, guess I was wrong.

I imagine `collectstatic` doesn't work on remote JavaScript files, nor should it. You should always refer to the remote `include.js` instead of pulling it into your compilation process. I'm unsure how to make collectstatic work like that, though. I haven't used it enough myself.
If this is a synchronous `test()` then you don't need an explict `start()`
This means that track will only get trackremoved if it has a teardown defined. I don't think that is right, and this should be moved outside this if block; maybe right below the `indexWasAt = index;` statement?
sweet it has the new volumes stuff now!
Yeah, it's hardcoded to look for the association that is added when you call `has_associated_audits`
Nit: Lint will complain about an "unnecessary semicolon" w/ for loop.
Yes, I ran

rails g controller Mating

I usually use the generation command to generate controllers/models/etc because then it creates the stub tests and other files, though, they can be cleaned out if you don't plan on using them.
will do, yes.
i love that my style is catching on by passing in vars that get redefined :)
This is a problem we have been running into with `NDData`: 
```python
q1 = Quantity(5, u.cm)
q2 = Quantity(5, u.km)
q3 = q1 + q2
```
What unit does q3 have? I suggest that it should have SI units so that `q3.unit = u.meter`.

thoughts?
Not any more, ugh, that was from my attempt to serialize to JSON instead of PEM. Will remove.
No, it doesn't. ;)

see http://nodejs.org/docs/latest/api/all.html#all_process_stdin
на примитивные типы ссылки не предают. их просто копируют.
There should be a space between the colon and the value here: `text: item.name` (if you want to use the 1.9 hash syntax)
My preference would be to have this be a tiny banner across the top of the page. But in any case, having it at the top means that people are more likely to see it. Plus, that's consistent with what Chrome and Firefox do for notifications.

It might be nice to have a small banner at the top of the page anyways, or at least something that says:

    PuppetDB X.Y.Z          Docs   Bugs   Contribute!

I quite like the way the Reimann site looks: http://aphyr.github.com/riemann/

I'm happy to help on the styling and whatnot...to put my money where my mouth is. :P
Moved over to oae-config.
Unused. Can be removed.
You can define the comments array just above this line. No need to declare it any sooner.
The message states that a tenant should be provided, yet you check the title?
This is going to be tricky as well. The full list can easily have 100+ groups, and getting that from Cassandra for every search a user does could be very expensive.
I'd make expires optional and if not provided it default to predefined value.
As this is a private function, it might make sense to assume that the user has access to the content and not do a check over here. There's a few internal methods in this API that already do this, it just needs to be added to the documentation. As far as I can tell, _getComment is called twice, and both cases already do an access check. Removing it from this function would thus save an expensive permission check.
OK; just making sure you were thinking about it.


On Mon, Nov 26, 2012 at 9:56 AM, nicolaasmatthijs
<notifications@github.com>wrote:

> In node_modules/oae-content/lib/api.js:
>
> > @@ -822,6 +823,292 @@ var _updateContentMetadata = function(ctx, contentId, metadata, callback) {
> >      });
> >  };
> >
> > +
> > +///////////////////////////
> > +// Comment functionality //
> > +///////////////////////////
> > +
> > +/**
> > + * Retrieves a single comment from Cassandra and returns a Comment object in the callback function.
> > + *
> > + * @param  {Context}    ctx                 Standard context object, representing the currently logged user and its tenant
> > + * @param  {String}     contentId           The ID of the content to get the comment from
>
> @bdarcus <https://github.com/bdarcus> : Thanks for your comment. The goal
> of the design was that a contentId can be used as the target in case it is
> a general comment, or contentId#targetIdentifier can be used in case of an
> annotation. This is quite a common way of storing things in Cassandra. Once
> we need to store more metadata about the target, we can split that off into
> a separate Column Family, but I don't think that's necessary yet.
>
> [image: :+1:] on renaming contentId to target though.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sakaiproject/Hilary/pull/256/files#r2222426>.
>
>
Rally not Mingle.
how's it look in the updated commit?
`'0' == FALSE` so current test fails on file/dir name "0", which I think really can be encountered.

I think my fix proposal is clearer than that another possible fix: `trim($file, '.') !== FALSE`
Здравствуйте, мне назначили вашу работу на ревью.
В задании явно не указано что делать при выходе значения процентов за границы диапазона, но на мой взгляд лучше выбросить exeption или написать в лог об ошибке, чем приводить значение к нужному нам диапазону.
Из элемента A можно получить только элемент T (например). Мутация явно не рандомная.)
вот тут готов поспорить. длина массива - всегда актуальна. а отдельно хранить количество - это 1) избытычность информации 2) дополнительный "обвес" для его актуализации
Не самый быстрый алгоритм, хотя все верно.
Документация советует для сравнения двух строк использовать isEqualToString — он быстрей
А почему это отладочные? Просто показываю сначала какие цепочки ДНК сравниваются.
Мне кажется что перемешивание массива не совсем правильно, ведь даже без реальной замены элементов массива (т.е. если далее не выполнять цикл while (countIndexesForMutate) {...), при проверки на равенство двух DNA они будут различаться.
стесняюсь спросить, а у вас включено Automatic Reference Counting? я просто не знаю, но вроде как у нее должна кукушка съехать. нет?
So that's rubrics/index.html not up to date ;)

More information here: http://railscasts.com/episodes/8-layouts-and-content-for and http://guides.rubyonrails.org/layouts_and_rendering.html#using-the-content_for-method

I created a ticket here: https://github.com/MarkUsProject/Markus/issues/918
should we put this in environment variables?
It should be documented that structure and union types are unsupported.
Er det noen grunn til å ikke bruke en `id` på dette elementet? F.eks. `#feedback-handle` siden den er unik på tvers av hele siten.
@codyhoag It would be helpful to show an image of the configuration dialog with the URL pasted in it.
I'd like to add Travis CI to this project for running the tests, too, but that can come in a future enhancement.
please be more careful with your docstrings (line too long + missing ---- below parameters + Adjust ... not on the same line as """)
Locale.US == new Locale("en", "US")
"default version of protocol" - which protocol, IP?
"linux" vs "Linux"
Same comment as above about the arguments.
``Closure``
mising ``that``
You must use double backtricks for inline code.
此时将使用代理服务器的主域名和端口号来替换。如果端口是80，可以不加。
Just adding my two cents, the original model was:

  * User uploads a video.  The MediaListenerImpl's handleFile gets called with the poolId, which calls MediaCoordinator.maybeMarkAsMedia

  * maybeMarkAsMedia looks up the mime type of the content object and asks the MediaService if it accepts that mime type.  If it does, it sets the mime type of the content object to the mime type used by the media service (e.g. application/x-media-brightcove)

  * After that, all checks to see if I given content object/version is supported by the MediaService are performed by isMedia, which just does a dumb string comparison to see if the object has been tagged with the mime type of the media service.

My thinking here was that calling `mediaService.acceptsFileType(mimeType, extension)` could be potentially expensive--it might actually need to interrogate the remote media server to answer that question.  Since we call isMedia a lot (at least once for every updated content object, and once for each version if that object turns out to be a video) it needs to be very cheap.  So the model was "do the expensive query at upload time and tag the object with a known mime type, and then just check for that mimetype from thereafter"

Would another option be to modify the MediaService signatures to support multiple mime types?  I'm thinking maybeMarkAsMedia could look like:

      if (isAcceptedMediaType(mimeType)) {
        String extension = MediaUtils.mimeTypeToExtension(mimeType);

        obj = cm.get(poolId);
        // Modified getMimeType here to include parameters, giving the MediaService the option of assigning different
        // mime types to different file types.
        obj.setProperty(FilesConstants.POOLED_CONTENT_MIMETYPE, mediaService.getMimeType(mimeType, extension));
        obj.setProperty("media:extension", extension);

        cm.update(obj);
      }

and then isMedia could just be:

     private boolean isMedia(String mimeType) {
         // Push the string comparison into the MediaService.  For a MediaService with multiple mime types this could look up the mime type in a set?
         return mediaService.isMedia(mimeType);
     }
Yes. you are correct, just realized this else is not needed as concept.null is checked by super class. Pls ignore above comment. Removed the else!
but i did as said by scolobb ..
should use InputMultiPath
I will look at it
There are lots of ways to be wrong. Try to make the test positive,

```
e = (conjugate(A)*A)
assert e.is_Mul and e.args = (conjugate(A), A)
```
So to summary I write it as 
Optional Role based access Management and describe what it means.
Что-то мне кажется, что эти три функции не пользуются состоянием объекта, поэтому не нужно им быть мемберами. Можно запихнуть их в локальный анонимный namespace в .cpp.
А может "<em>%1</em>" ?
La "imagen" tiene dos imágenes y dos attachments, el original y el
thumbnail y eso ya estaba de antes, no está relacionado con el cambio
actual.

On Sat, Aug 25, 2012 at 12:11 PM, Alpha <notifications@github.com> wrote:

> In source/CommonJobs/CommonJobs.Domain/SlotWithAttachment.cs:
>
> > @@ -10,5 +11,36 @@ public class SlotWithAttachment
> >          public string SlotId { get; set; }
> >          public DateTime Date { get; set; }
> >          public AttachmentReference Attachment { get; set; }
> > +
> > +        public static IEnumerable<SlotWithAttachment> GenerateFromNotes(IEnumerable<NoteWithAttachment> notes)
> > +        {
> > +            return notes
> > +                .EmptyIfNull()
> > +                .Where(x => x.Attachment != null)
> > +                .Select(x => new SlotWithAttachment()
> > +                {
> > +                    Attachment = x.Attachment,
> > +                    Date = x.RegisterDate,
> > +                    SlotId = "__NOTE__"
> > +                });
> > +        }
> > +
> > +        public static IEnumerable<SlotWithAttachment> GenerateFromImage(ImageAttachment image)
>
> En este método ¿una misma imagen puede devolver varios slots con
> referencias a attachments? ¿Es eso correcto? No entendí bien por qué y no
> me hace mucho sentido.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/164/files#r1459708>.
>
>
¿Le cambiarías por `No hay datos disponibles`?
You could also just replace Company with %s and then input CATEGORY when you're using the template. I think that might be best.
For clarity I suggest changing this wording to something like: "#ask may now disallow the caller from interrupting prompts by specifying :interruptible => false"
Why are you using _$rootScope_ and _$compile_ here?  Have I missed something clever?
This and BaseDistStateTransferConsistencyTest look fairly similar, can we avoid code duplication ?
Do you really need this to extend AbstractNamedCacheComponentFactory? Are we gonna have a map reduce manager per cache? Looking at what MapReduceManagerImpl's instance variables, seems to me it should be a global component. If so, the MapReduceManager (interface or impl), should have @Scope(Scopes.GLOBAL) and then the factory should extend AbstractComponentFactory (instead of AbstractNamedCacheComponentFactory)
You are right. The new code uses UUID (which uses a SecureRandom generator under the covers)
Oh hang on, this is the config builder.  Why is this config parameter deprecated?
comma shouldn't be line wrapped here
someone should put here ```parsed_page=get_page(page)``` and then:
We should give this a unique class name. TestBrowserCellData?
As vezes compilar com o `make all` demora muito, especialmente quando o projeto é grande. Além disso, ele escreve muito na tela. Por isso o `draft`.
use constants, more methods, ... anything to make this code less magical
and more readable

On Tue, Aug 7, 2012 at 4:38 PM, François Thillen
<notifications@github.com>wrote:

> In testproject/Protocols/TCP/TCPProtocol.cs:
>
> > +        public TCPProtocol() { this.SocketNumber = -1; }
> > +        public TCPProtocol(byte[] message, int SocketID)
> > +        {
> > +            this.message = message;
> > +            this.SocketNumber = SocketID;
> > +        }
> > +        #endregion
> > +        #region Public methods
> > +        public IProtocol ConvertToProtocol(Object message)
> > +        {
> > +            ASCIIEncoding asci = new ASCIIEncoding();
> > +            return new TCPProtocol(asci.GetBytes((String)message), -1);
> > +        }
> > +
> > +        public IProtocol ConvertToProtocol(byte[] message)
> > +        {
>
> if the socketnumber is smaller then 0 means that this protocol can be send
> to any socket. I wanted to add this to the documentation or should I add it
> some where?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1321892>.
>
>
should this not be tileSize instead of this.tileSize?
I don't like the fact that you add the constructor in the interface. The constructor is part of the way you instantiate the class, which is tied to the implementation anyway so I don't see the reason to forbid implementors to have other required dependencies.
@bp323 We shouldn't have a debug.log message in here.
Moved that into the search page
Thanks @raydavis! I love that our code reviews are bidirectionally educational.
@philschatz (setting color twice/orriding it 2 lines later)Lines 261/263 are deletions not additions. Those where the lines you were referring to?
Both forms are valid. Nvmd.
Are you sure the method ``unlock`` can be called on ``$this->store`` (of type ``object<Symfony\Component...l\HttpCache\Store>|null``)? Please also check line 73.
Yes thanks Tatyana, i looked for it, but must have used the wrong keyword and didn't find it.
Wohl schon, stimmt.
Looks like you may have snuck in some tabs here? Would kick ass if you could verify that indentation is all done with spaces, and that there are no trailing spaces :)
same pattern as above should work for all of these. as long as you have a "dynamic document" variable (or getter) declared first
eh, I was matching conventions already present in the file...
Awesome, I've always used `/>`.  It feels awkward putting it there, glad its not necessary.
don't believe so, since jquery covers that for us. but they should probably be px.
Not sure here, do we need to catch the db error to maintain the same behavior?
Probably just thought it was missing. Will remove that - thanks for clarifying.
I think you should move the `self.content_settings('NEEDS_TRUST')` in `can_creator_be_trusted`, it makes sense.
And then `is_fake = not flag_instance.can_creator_be_trusted()`
That should work. I'll look into doing something like that.
T

2012/10/20 Lukas Kahwe Smith <notifications@github.com>

> In Resources/scripts/check_symfony2.py:
>
> > +
> > +        except Exception, e:
> > +            self.log.warn("Could not connect to url: " + self.url +" res:" + str(e))
> > +            self.badChecks.append("config_error_in_nagios")
> > +
> > +        self.measures = [nagiosplugin.Measure("Num_failed_checks", len(self.badChecks), warning=self.warning, critical=self.critical, minimum=0 )]
> > +
> > +
> > +    def default_message(self):
> > +        if len(self.badChecks):
> > +            return "The following checks failed: %s" % (", ".join(self.badChecks))
> > +        return "All checks pass."
> > +
> > +
> > +    def fetch(self, url):
> > +    #    passman = urllib2.HTTPPasswordMgrWithDefaultRealm()
>
> yeah .. maybe make it a variable to choose to enable this?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/liip/LiipMonitorBundle/pull/15/files#r1897415>.
>
>



-- 
__________________
Tarjei Huse
Mobil: 920 63 413
His name really is Seth.
what is the expected output of this call?
I don't like name `deferred` for this. This should be something like `map_loaded`.
Space after `()`.
And where can I save number of columns?
Sorry, I just remembered. It would be great to do a check here. Add after this line:

```
assert newuser is not None, form.cleaned_data['username']
```
But style is done with underscores. Now what :-)
Link to user facebook account (complete URL).
Don't do docsting, a comment please. With `#` at the beginning.
Indent one less. Combine `}` and `);` together.
It didn't work like this. Because only 3 (or 2) plural forms are defined. And an argument tells which form to use.
Why, oh why. Why you copy-paste code and change bit here and bit there? Why you don't embrace the beauty of object oriented programming and simply just extend django-browserid's `Verify` view in a way that request is passed?

Always when you start copying some chunk of the code from somewhere else to modify just one line you should stop and think what are you doing wrong.
Maybe better to have `ul`/`li` for this?
the 2 divmod changes were made here
Looks like the new version of Visual Studio 2012 changes newlines to `CR+LF` by default.. (This file wasn't edited by hand.)
ah that was a hasty merge will fix.
Undelete this and remove the annotation in views.  This will prevent circular imports.
Is this definition used anywhere? It looks confusing as internally we are still using the long established "geneid:" namespace
with ImageField this method has no sense
shouldn't it be ``doctrine.security.*`` to follow the best practices for the service naming ?
In kl.cpp, MR is really doing multithreading. The KL tool crates a RuntimeServices object; if you were calling RuntimeServices::ExecuteParallel() it should just work directly... (once you do the modif proposed above to have 'report' working properly)
$term => $result
I can't really get this to work, also shouldn't it use our standard key handling?
Unrelated whitespace fixes should preferably go into a separate commit. Even more preferable is not adding them in the first place, of course. :-)
The ifs can be combined. `if [[ -n "$WORKON_HOME" ]] && (( $+commands[virtualenvwrapper.sh] )); then`.

What about "$PROJECT_HOME"?
console.log does not belong here
I was originally using Sublime's EventListener for updates, but working with the ```on_selection_modified``` event was quite finicky. I'm thinking this may be the cause for the (very few) "this plugin may be making Sublime Text unresponsive" errors. I'm really only speaking for the Mac platform, as I  have only tested minimally on Windows and Linux (which haven't given any such errors).
OK. You are probably right. Sorry.
simple. -> simple  (remove period)
Yep, agreed.  Actually did this in the tests above but am a lazy so-and-so and forgot to do the same here on returning to the code later.  Fixed and pushed.
Ultimately we will have a GREAT3 server and will recommend that people download from there directly, I think, so we anticipate the file location to change on the several-month timescale (not many times, just once when we get the server and then another time when we update the training sample).  I don't think it'll be a huge burden to keep this links in sync, but this does seem like something that might benefit from being wikified.  @barnabytprowe , what are your thoughts?
Are we going to regret putting NoEmail on here?

Or can we look at doing something with consumer type?
will change to POST, we will be allowing multiples
Nope, but i guess that tells you where my mind was ;)
Disregard
Since Stripe is using cents, I suggest we use cents to store data. But, UI can still appear in dollars. For example, when admin create a project, the UI for goal is dollar, but we convert it into cents before storing into the model.
good catch thanks!  fixed
I like explicit return values over implicit ones, but could be convinced otherwise.
Alternativly... I propose:

    if (empty($response)) {
        throw new ObjectNotFoundException(
            'User with email:"' . $email . '" was not found.'
        );
    }

Makes us all happy?
Correct, just did that for convenience of knowing. Rather it be changed?
Comentario sin importancia: se permiten acentos con UTF-8 ¿no? Mejor que los html tags. :D
Ok, cool. I'm down.
Можно и public сделать... Но по моему это не хорошо открывать внутреннее устройство класса только для того чтобы можно было использовать эти методы, тем более что в java есть reflections...
Fixed on latest commit.
It is setting a new access token.
s/Show/Shows/
double import of Highlighter.jsm
it should be _apps_locator because it refers to all the apps
is the index 8 going to be fragile? is it the last chunk (could -1 be used)?
Could this tutorial also be converted to sphinx and included in the documentation?
Peerdns is getting fixed in a separate commit.
This piece of code is reused several times, maybe add an inline function `histogram_increment` and `histogram_decrement` for this?
This ain't necessary.
Why do input validation at all? It just slows things down :)
Alright, what about:

*Any attributes that have been estimated from the data must* ***always*** *have names ending with a trailing underscore, for example... blah blah*
To help debugging, it is useful to insert "but '%s' was given" at the end of the error message, were "%s" is the 'obs'
The plot looks rather cluttered. Maybe use `n_samples=1000` instead?
Do you think approximating the normalization with a `randomized_svd` with an apriori fixed rank would futher speedup the computation?
2012/10/6 Gael Varoquaux <notifications@github.com>
>
> In sklearn/feature_extraction/text.py:
>
> > +    def _assert_nonempty(self, vocab):
>
> Where is this function used. I must be dense, but I don't understand its use.

Nowhere, I forgot to remove it. Force-pushed a new version.
BTW, a docstring is missing here :)
Got a typo: "attribut" is missing an "e".
Indeed, you're right, this is useless.
le même principe s'applique içi.
I think we can make things more simple.
- If `e1->type->ty == Tenum`, dereferencing `e1` is meaningless, because enum type object has no indirection.

And then, `pointsToVoidNull` will become completely unnecessary. Is this correct?
Why do you comment that you fixed something?
Does this syntax work for other databases? If not can you give some indication that this is only for postgres?
Another parenthesis looks like on the wrong side (the first one). Am I midunderstanding, was it on purpose to address a sense of exclusion from the range ? I'm used to other notations for that, in that case it might make sense to ontroduce the notation you intend to use.
git plumbing is a standard way of accessing and extending git, and as such should be expected to remain compatible. I didn't want to use a library precisely because of OS / future support issues (I know that git can be installed everywhere and will be maintained for the foreseeable future, I can't say the same about libgit2)

"libgit2 is still in early development, and although it's already quite feature complete, there are no official binary releases available yet. Interested early adopters must compile the library by hand -- which is easy enough to do." - from the website.

I don't see any safety issues here. People could install a git executable that mimiced the official one but actually read different files - if so, good for them, they've managed to add a new feature to our system...
This appears to be a slightly different issue being fixed. The commit comment should at least refer to it?
Should check if oldsize > newsize.  Could possibly happen if a realloc decided it was worth completely freeing the data (because newsize << 1Mb)
Couldn't determine if the array would clean the memory on ensure (AFAICS it just uses realloc). I may still need to clean it...
In fact, it's a redundant check already. If rc_allMem it will be disabled.
I will change.
Don't defined variables that don't contain business logic far away from where they are going to be used. 
If it was something like this instead `var TAX = 0.0125` it would be a sin to repeat it more than once but you're only using `window.location.search` in two places and `window.location.search` won't change.
@peterbe @rhelmer perhaps we should include both options, either install lessc as a global (general module) or install it locally for the current project and then provide the needed steps to add it to your path so that django-compressor finds it.
Should actually be named Query, as this route works against a query (key value parameters), not the string (or is "Query" a reserved keyword?).
La tu pourrais faire un mixin
```css
@mixin list-icon($type, $x:"top") {
  background: url("images/list-icon-#{$type}.png" no-repeat $x left; }
}
```
Yeah, but it's all commented out at the moment anyways. Right now it does an ajax call for all the events and teams (about 150KB) once you click on the search bar instead of using the first few letters typed to return a limited set.
A method or property in a page object should represent the page, however this method is loading additional pages and combining the result. :-1:
This step doesn't work but I tested a solution adding `> a` to the locator and it works perfectly
I'd expect that the queryparser always returns unicode strings, so I think it is not possible. I think adding a utf-8 encoded string with special characters will break p.a.querystring anyway. I will try to write a test to verify that.
Instead of crafting this from scratch, you should use Rex::MIME::Message. Here's exactly how to do that:

	data = Rex::MIME::Message.new
	data.add_part(@csrf_form_key, nil, nil, "form-data; name=\"splunk_form_key\"")
	if @enable_overwrite
		data.add_part('1', nil, nil, "form-data; name=\"force\"")
	end
	data.add_part(file_data, 'application/x-gzip', nil, "name=\"appfile\"; filename=\"#{archive_file_name}\"")
	post_data = data.to_s
	post_data = post_data.gsub(/^\r\n\-\-\_Part\_/, '--_Part_')
elsif ret =~ /refused/
Note, that dictionaries are NOT ordered, so you cannot get the first argument of the kwargs.

The function signature can be easily changed. I forgot about that.
Gotcha. Will do.
Some weird indentation happenin' here.
Shouldn't these two removals from settings be outside the if? Presumably we want to remove/tidy them regardless of whether they are enabled or not. I guess it's worth noting that this will stop people from rolling back to a previous version and retaining the settings? Maybe no big deal?
That's Edgar, meow.