STYLE: Provide more output to the user when missing parameter values issue #2517

From: naucoin <naucoin@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21408 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Remove SWidget tcl related code

Keep the Slicer3Adapter.tcl around since it's still required by EMSegment

Later on should also remove the slicer.sliceWidet* object since these
ones can be accessed using the slicer.app.layoutManager() object.

See http://na-mic.org/Mantis/view.php?id=2735
Fixes #2735

From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21409 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Remove extra initialization associated with "pkgIndex.tcl"

Since the file "pkgIndex.tcl" has been removed with r21407, it shouldn't
be imported.

See http://www.na-mic.org/Bug/view.php?id=2735
Fixes #2735

From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21411 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Prevent Slicer from hanging when restarting

See CTK commit ad15090

// ------------------------
Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

Ensure ctkFDHandler can be enabled/disabled multiple times

To give the opportunity to the thread to exit the polling loop, the
character "\n" is now written when disabling the handler.

The pipe is also setup each time the thread is enabled. Additionally,
the reading side of the redirection pipe is also closed when the thread is
disabled.

Tests have also been updated to enable/disable the handler multiple times
in a row.
// ------------------------

See http://na-mic.org/Mantis/view.php?id=2535

Fixes #2535

From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21414 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Fix windows build error using function prefixed with "_"

See http://na-mic.org/Mantis/view.php?id=2535

Fixes #2535

From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21416 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Remove SWidget related code from Performance test

This is a follow up of commit r21404

See http://na-mic.org/Mantis/view.php?id=2735
Fixes #2735

From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21418 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Fix build error occurring when disabling QtTesting

See http://www.na-mic.org/Bug/view.php?id=2760

Fixes #2760

From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21420 3bd1e089-480b-0410-8dfb-8563597acbee
STYLE: fix spelling error in variable name

refrencingNode -> referencingNode

From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21423 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: fix leaks on scene close - related to issue #2512

Use vtkSmartPointers to rather than bare C pointers
to manage lists of node references.  This avoids dangling
pointers to already deleted nodes (and hence prevents
crashes).

Also STYLE: add at least some documentation to the header
file describing what these methods are meant to do and
how the data structures are managed.

From: pieper <pieper@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21424 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Add method to streamline loading of scalar volumes

* Update DICOM scalar volume plugin to use the new method name.

Adapted from topic proposed by Andriy Fedorov
Credit: Andriy Fedorov, Julien Finet and Steve Pieper

See http://na-mic.org/Bug/view.php?id=2748

Fixes #2748

From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21426 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Apply redesign to glyphable volume slice display nodes

In r20910, model display nodes had a demand driven pipeline redesign.
However, this redesign wasn't applied to glyphable volume slice display
nodes.
Issue #2374

From: finetjul <finetjul@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21432 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Model displayable manager now supports any displayable node...

...that has display nodes with a non null output polydata.

Issue #2374

Conflicts:
	Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx

From: finetjul <finetjul@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21433 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Restore 2D slice glyph display

When display nodes where added to a volume node,
vtkMRMLVolumeGlyphSliceDisplayableManager was not notified so it couldn't
observe the glyph diffusion tendor display node modify event.

Issue #2374

From: finetjul <finetjul@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21434 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Update display when tensor display properies are modified

When the properties node is modified, the event must be propagated so that
the 3D and 2D displayable managers are notified and trigger a refresh.

Closes #2374

From: finetjul <finetjul@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21435 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Move light box renderer manager proxy to abstract displayable manager

Suggested by Steve Pieper
Contributed by Jim Miller

Moved the LightBoxRendererManagerProxy up to the superclass of the
DisplayableManager hierarchy so that all (2D & 3D) displayable managers
can interact with a lightbox.

Note that light boxes are only currently supported on 2D viewers, so the
proxy is only configured in qMRMLSliceView. CTK will need to be changed to
put the LightBoxManager into ctkVTKAbstractView to make it accessible to
both ctkVTKSliceView and ctkVTKRenderView. Then qMRMLThreeDView could also
create and initialize a LightBoxManagerProxy and set it on its DisplayableManagers.
Here, we would also want to move qMRMLSliceViewPrivate::vtkInternalLightBoxRendererManagerProxy
class to a place where it could be used by both types of VTK widgets.

The proxy can now be set on the DisplayableManagerGroup which
broadcasts the proxy to all the DisplayableManagers in that group.

See http://www.na-mic.org/Bug/view.php?id=2732

Fixes #2732

From: jcfr <jcfr@3bd1e089-480b-0410-8dfb-8563597acbee>

git-svn-id: http://svn.slicer.org/Slicer4/branches/Slicer-4-2@21436 3bd1e089-480b-0410-8dfb-8563597acbee