labofsahil/github-event-dataset-2012 huggingface dataset:
`#{result.klass}` could alternatively be written as `association(:#{target}).klass` and, although it references the same object (exactly, I think), could potentially be seen as a "cleaner" way of accomplishing the same.  The difference here is in the meta:

```ruby
class Forest < ActiveRecord::Base
  acts_as_paranoid
  has_many :trees
end

class Tree < ActiveRecord::Base
  belongs_to :forest, :with_deleted => true
end
```

Using `#{result.klass}`, results in the following meta code being output:

```ruby
def forest_with_unscoped(*args)
  return forest_without_unscoped(*args) unless Forest.paranoid?
  Forest.unscoped { forest_without_unscoped(*args) }
end
```

And `association(:#{target}).klass`:

```ruby
def forest_with_unscoped(*args)
  return forest_without_unscoped(*args) unless association(:forest).klass.paranoid?
  association(:forest).klass.unscoped { forest_without_unscoped(*args) }
end
```
Great. Link added to website: 3a8bc76faaf53f1ad41d357153ed4a2bb651869a.
can we factor these out into /js/{audio,comments,main,etc}.js and use the asset manager?
An exception has been thrown during the rendering of a template ("Unable to choose a translation.") in SonataAdminBundle:CRUD:base_list.html.twig at line 80.
Isaac, I've been looking at the bi041p_ts.c code for the past few days, both your version and original. I've been using your version mostly up until yesterday, then I tried the stock one and it seems more reliable (it ignores touches less often). Then today I optimized it a bit more (eliminating unnecessary calls (esp in the first part of the bi041p_isr_workqueue, where it detects 1st touch, release, 2nd touch & release). I have a feeling that now that the code is more efficient, it's more reliable and smooth during gaming because CPU cycles are precious and more efficient code paths are better (like in the stock version) since this ISR_workqueue gets called many times a second, little savings add up. I will publish my changes soon and let others test to see if they notice the same. As far as I've tested, your updates are functionally the same as stock, (no cross-axis problem, just magnetism problem).
Does it even MATTER!?
Awesome sample data ;)
this worries me a bit as I'm not testing the signature itself, a core part of the logic I had to implement. It'd be a shame if a regression was introduced down the the track and it wasn't picked up.

The value for temp_url_sig is dependent on the account's rackspace_temp_url_key set in ~/.fog. Is there any way we can make that value predictable?
Why not have all the Regexps in this object?

Also I think `REGEX` is a better name.
I don't agree with that. I think that flexibility here is important, since we don't know what kind of tests the programmer will want to write. As a matter of fact I had to find some special turnarounds due to harcoded things in the elgg installer. Also, while not included here to make things simple, the original plugin allows for per-test configuration, so that if you place a config.ini in the same directory that the test, that configuration would take precedence over the global one. This allows to have per-test fixtures (e.g. a different users table) and being able to change things like the the user that will log-in.
How about https://github.com/Jasig/cas/blob/master/cas-server-core/src/main/java/org/jasig/cas/authentication/principal/WebApplicationService.java?
Much like my other comment above, I believe this class and `AuthenticationViaFormAction` would benefit from having the same parent, that at a minimum, would encapsulate the logic of error resolvers and and populating the context.
TODO for dev branch
OUCH! (I really would like to have compiler support in catching these: `context` must not ever leave the actor’s context, because that would be completely illogical ;-) )
Is it important that we don't throw away integers? I thought the numbers where only used to correlate the snd and rcv actors.
Ideally line breaks should be done virtually by "formatting" in your editor. Since that is not the case, I don't think we should sacrifice readability for people using unix terminals from WWII. 120 is a good modern limit.
I think doc demo code belongs to `src/test/scala`, or `akka-contrib/docs/*/code`
No. Will fix.
yes, it might be better, but remember that consistent hashing will "always"
be used with remote routees, so we are not spending time on the bottleneck.
If we think it is important I can take a stab at it, or I can create a
separate performance ticket.

On Thu, Sep 13, 2012 at 6:10 PM, drewhk <notifications@github.com> wrote:

> In akka-actor/src/main/scala/akka/routing/ConsistentHash.scala:
>
> >      }
> > +    ring.getOrElse(hash, nextClockwise)
>
> Yes, true, because it has to maintain red-black property for the resulting
> tree, I think. Log(n) still, but it materializes only for large trees.
>  Might just be better of with an array and linear find.
> Even better: sorted array and binary search.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/akka/akka/pull/698/files#r1599242>.
>
>
new replace old is what I think is best

is there a way to lookup the supervisor from the actor ref path in the Terminated msg?
supervisor is always it's parent, but it's a bit more tricky than that for those remote deployed

if we can derive and lookup the supervisor then this map wouldn't be needed

however, it doesn't solve the devilish scenario
ActorCell must implement both, and ActorContext does not expose the Java variant, AFAICS
wel, what I mean is that tasks just start with local method calls like "namespace".   there are no Classes or modules, so their loading must be implicit.
I think this is a mistake, both need to be there, I think.  the second maybe in a pack
The translatable string on line 784 should use the string.format :

  _('Unauthorized to read resource {resource}').format(resource=id))
There is a paster command `paster --plugin=ckan datastore create-read-only-user`.
i really don't like raw excepts - and again below - line 642
Ah, good catch :)
Are we going to RST docstings? Please say yes, please, please...
It's already done in OnFilterItems() which is called by OnFinalizeFileItems() which is called three lines further up. But I can re-add it here if requested.
return dirty; here, and take care of it in Process() ?
If the shape isn't regular LINESTRING format, then it's the MULTILINESTRING format.

http://en.wikipedia.org/wiki/Well_Known_Text

Either way, _allCoordinates below will correctly flatten the result, changes to this method aren't required.
тут тоже нельзя убирать. Иначе тоже будут попадать лишние накладные в список
Rinse & repeat
The name/description of this function is unclear, consider changing it.
remove comments :)
It is initialized automatically because pash_stack_ is NOT a pointer despite being a container of pointers.  It needs no explicit init - the compiler does this automatically using std::vector's default constructor.
I still think that you should break this condition, to avoid to iterate over the whole array and do the same condition over and over again, as you could do it only once. Something in this lines :

```php
<?php
// ....
protected function checkConstantExpression(Twig_NodeInterface $node)
{
    if (!$node instanceof Twig_Node_Expression_Constant && !$node instanceof Twig_Node_Expression_Array) {
        return false;
    }

    foreach ($node as $n) {
	if (!$this->checkConstantExpression($n)) {
            return false;
        }
    }

    return true;
}
```

I know it isn't a _huge_ optimization, but still.
:star: This description is much better, though the last line is probably redundant.
Do you mind putting this `return` on its own line (for consistency with the `if` above)?
I think I have got rid of it all now...
Does it actually work? I thought the thing with `V8::TerminateExecution()` was that JS *cannot* catch it?
I'm not sure if contents of this method should be wrapped in `try {} catch { $this->selection = NULL; }`, what do you guys think?
newTimeout() accepts 'delay', not 'dead line'.
I would like this to be a bit more general, so that a function can return a list rather than a tuple for example.  Originally I tried `hasattr(outputs, '__len__')` but this changes the behaviour when the output is a string which should probably be treated as a single type.  This needs some more consideration.
Should we add all the parallel files? Missing: parallel_alpha_diversity.py, parallel_beta_diversity.py, parallel_blast.py, parallel_identify_chimeric_seqs.py, parallel_map_reads_to_reference.py, parallel_multiple_rarefactions.py, parallel_pick_otus_blast.py, parallel_pick_otus_trie.py, & parallel_pick_otus_uclust_ref.py
Any reason to keep commented out code?
I think this comment should be moved with 196
This will raise error when `inheritance_column` is set to nil (disabling STI case)
I think you can use the variable `original_root_in_json` instead, wdyt?
So let's leave it with just the `:lock` call. We are not supposed to accept both ways unless explicitly documented. Also, can you indent the if block?

    fresh_object =
      if options.present? && (options[:lock] || options['lock'])
        self.class.unscoped { self.class.lock.find(id) }
      else
        self.class.unscoped { self.class.find(id) }
      end

Thanks!
This was done in ebb906d23ae321, then rails updated and sprockets-rails is outdated, this need to be done in sprockets-rails
In the scaladoc model package object contents are squashed into the package.
Nope, that's the canonical definition of a category.
According to the description of `get` [here](http://docs.python.org/library/stdtypes.html#mapping-types-dict):

> get(key[, default])
> Return the value for key if key is in the dictionary, else default. If default is not given, it defaults to None, so that this method never raises a KeyError.

And indeed, doing `(x*y).as_real_imag()` works nicely for me in this branch.
not sure for that... in general wiki articles are additions to the guide, not complements to the guide and they are created after the guide... 

As I see this the guide should give a short introduction or description and that's all... the wiki is an additional information explaining a certain topic for those that will search for it.
Logs with category `system.CModule` exactly?
Should be `boolean $isAuthenticated whether the authentication is successful.`
@cebe, thanks! Added. :white_check_mark:
DBAL 2.1 ? Please change it. The 2.1 serie is unmaintained except for security issues
Don't create a new exception if `importFailed` already got one as an argument.  Just bubble it up,`fallback(ex)`.
Just copypasted this from line 169 -readFromURL:ofType:error:
you have to enable it on a per database level.
we should probably move this note up to the before the reference section somewhere. seems like a lot to scroll through for nothing, you know?
Looks like a pdb breakpoint needs to be snipped out?
anyway, up to you to consolidate or leave as is.. other than that looks good! go ahead and merge if you wish :)
These lines don't make sense (in logical sense, that is).
Why do you use that $message variable for two completely different purposes?
I think something like:
`$user->lang[($mode == 'edit') ? 'POST_EDITED' : 'POST_STORED']  . '<br /><br />' .
sprintf($user->lang['VIEW_MESSAGE'], '<a href="' . $redirect_url . '">', '</a>');`

Would make more sense and sounds easy enough to read.
Other solutions exist but that solution does not sound correct...
Those browsers aren't used at all, so its not an issue.
So would you rather the parent element have an empty string value if no parent is given? I'll go ahead and do that.
suggestions, please?
If phpbb does not use them keep them where all log files are located, i.e. /var/log. On systems that are not properly configured the log files should be dumped somewhere not under web server document root.
`$error[] = $user->lang("$e");` is a shorter way of casting it to a string.
Need docs, but otherwise looks good. One change worth considering given that the RESTController is not exposed:
rename `show` to `restShow`, `index` to `restIndex`, etc. (of course renaming `restIndex` to `_restIndex` or something like that).
This way we can use the module without always "qualified importing" it. But, Frank is the same, so maybe not.
Good point. I'll change it to `toAttr`.
Можно просто добавить третье состояние - inactive (будет удобно в ноде потом юзать). И, может быть, добавить поле с причиной неактивности(я не уверен, может быть можно будет и просто каждый раз вычислять причину)
Same comment about cross browser. Double check if there's a JQuery way to do this.
Ok, doing that.
I suspect that this simple renaming is not sufficient to transfer the variable. How do I declare that GpuWait should use the same storage for its inputs and outputs?
Wow, not sure how that happened. I shouldn't have been making changes here. Thanks.
I changed this a bit. Check out my upcoming commit to see if you think it's the right approach.
Is UTF8 a valid charset name, or is it UTF-8? The following page lists UTF-8 but didn't say if UTF8 is an alias.

http://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html
PEP8-ify arguments too?
Use ``m = re.search(r"([1-9][0-9]*)", handle)`` so you can later simply call ``m.group(1)`` to get the match.
The other thing that came to me was that we might be able to make use of the adapterForType logic and simply have multiple adapters.
changed to well from gray.  I proposed in a review that we fix the well style to have a gray background color.
`return` isn't needed, it's coffee.
yvonne all the things! :)
Sometimes it is helpful/appropriate to state/list other methods invoked by a method (if they are the same access/visibility), but usually I try to avoid this.
Two things to note here:
1. I don't like much the dependence on settings.DEBUG. Either unconditionally raise, as done in other parts of this file, or make usage of the logging infrastructure (getLogger('django.template'), logger.error(...)).
2. I'd like to keep the return statement at the end, if possible
Add a brief summary like the other ref pages have and a link to the topic guide?
this annotation should be removed as it will not be replaced anyway
Instead of looking at "start" and "end" events, you only have to look at the "end" events. In fact, it's actually better if you do that. We've had (intermittent) parser problems in the past with trying to parse child element from the "start" of an element. (Thus, you could simplify your if/elif expressions by removing the `event == "start" and`.)

This thread describes the problem exactly:
http://stackoverflow.com/questions/8129329/lxml-iterparse-mising-child-nodes

I vaguely recall that this only becomes an issue with large XML files (which is why you don't see this issue with the current tests and sample files). The thread author alludes to this as well.

Long story short, parsing the "end" of an element is always safe.
Oh, heh, looks like a bug fixing the bug :-P Sorry, I misread your comment.
I think we should do this first https://github.com/maccman/spine/pull/363 I hate changing stuff without a test harness :)
If the random number sequence is the same, each time we will sample the same data set. 

But we should get different set for each sampling operation.
Same here - seems like the only difference between this and the oauth2 version is the version parameter send to `login`. That could be an argument to a generic function in accounts-oauth-helper
`::` would open up the HTTP server to other hosts than localhost, breaking our "secure defaults".

The ideal would be a mix of `127.0.0.1` and `::1`, and CherryPy claims that `localhost` should work as a combination of those, but when I tested, it only made the server available on IPv4.

I don't think it's an coincidence that CherryPy provides exactly the same choices and semantics as we do with our own MPD server.
For reference, my accept-language is "en-US,en;q=0.8,en-ca;q=0.6,en-gb;q=0.4,en-us;q=0.2"

Based on that, I wonder if we should just split on ",", and then for each code throw away the ";q=.*" part…

Or, if we're going to use regexps, perhaps we should split on "(;q=[^,]*)?,"  (Let me know if that makes sense or not, okay?  ;)
Just omit it
At least libspiro was recently added due to user request, so it should remain at least as an optional I would think.
If register_runner doesn't exist on 1.8, can we Test::Unit::AutoRunner.respond_to?(:register_runner) as the check here?
What would the long term fix for this be?
How about.

Downvote object. If there already is a vote, replace it.
Es werden jetzt .htaccess und _readme.txt-Dateien nicht mehr nur auf der obersten Ebene ignoriert..
I think we're ok with using `map` and `filter` in house.
Explicitly handled in 8c63a915e and 14de55bb
I thought Google was nitpicky. :)  I would really like to get some sort of style thingy written down so I don't have to have you mention things ad-hoc - for your convenience as well as mine.  Also done.
We have decided to make a change from calling headers ``.h`` to ``.hpp`` this makes it easier to differentiate between C and C++ code.
Yes, it sure it, will fix.
But `$action` is still loop-invariant and therefore should be computed only once, before the loop.

Ideally, though, you'd check if it was actually deleted or just trashed. If it involves doing an additional query per post, then forget it. :)
ditto with keys.
I could imagine liking that...
"Notice that the Selection in the example above, see assignableTo, is default and might be left unused."

I don't understand what this means.
Because if we write this error, maybe the user will try to search in his code where he has written @Parameter(index).
According to me it's not the same meaning, but if you prefere we can write this error.
Could you add a test where starting() throws an exception?
Should probably null out options.into before deleting it.
Could you stick the env and the request on the error so client code could inspect it should they so wish?
Don't forget `setInnerHTML`, `removeNode`, and `appendChild`
Do you need to check for 'apply'? Are you just trying to check that it's a function that can be hitched? I can't see a case where it would exist, but not be a function. Also, there's `dojo.isFunction()`.
add linebreak after }
Ahh, good call. I should remove that. I was going to use that based on some of the discussion above, but I'm going to wait until ProjectManager gets re-factored before moving some of the resize logic into a function like notifyResize() that changes the properties. But I forgot it was still in there. I'll strip it out.
I just realized we don't have to do this programmatically any more. Before this change, the template had to render early and couldn't wait for the buildInfo to resolve. Now that we build the template just-in-time, we can update the template to use a ``BUILD_INFO`` template var.
Bottom panels are now resizable (when hooked up to resizer module), so I don't think "fixed px height" is required. Maybe I am not sure what you mean by that.
Should be utils/AppInit instead of utils/Ready
Yes, this is not used even though it sounds like being used for used colors (added in the next function addSwatches). I tried to click on  used color swatch and it still works without this function.
removed. also cleaned up a few other tests.
Yes or the "exit" event on apf
Yes, maybe it should be changed to have a `service_unregistered` function.
is this even valid html? seems like it would have been trivial to throw this in a normal template.
The @interact decorator is not imported. This code probably only works in Sage. I would recommend either making the code supporting execution with or without Sage, or clearly state that Sage is required in the module docstring.
The offending missing error...
Right. The point of the test is to ensure the extension is working as intended, i.e., the classes actually exist. The test will fail with a Constant error if one of them does not (as was indeed the case before the fix to rugged.c). What actually gets asserted is more-or-less irrelevant (we could test for object self-similarity for all I care), but this assertion does the trick fine.


On Dec 16, 2012, at 6:34 PM, Rick Bradley <notifications@github.com> wrote:

> In test/errors_test.rb:
> 
> > +      Rugged::ReferenceError,
> > +      Rugged::ZlibError,
> > +      Rugged::RepositoryError,
> > +      Rugged::ConfigError,
> > +      Rugged::RegexError,
> > +      Rugged::OdbError,
> > +      Rugged::IndexError,
> > +      Rugged::ObjectError,
> > +      Rugged::NetworkError,
> > +      Rugged::TagError,
> > +      Rugged::TreeError,
> > +      Rugged::IndexerError
> > +    ]
> > +
> > +    error_classes.each do |err|
> > +      assert_equal err.class, Class
> It's actually kind of a weird test, in general... Seems like by naming the constants and not having things blow up (before you get into the meat of the assertionizing) you're asserted that the classes exist. I guess the test currently makes sure they're not modules or something. I suppose the point of this is that this is the interface the library gives to callers, and so you want to make sure that these exception classes exist. It's a weird one.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Hm, this is not really what I had in mind. We should save the language into the user object and then from there configure the language. I am also unsure of having the language changed in the header. I would move it to the footer (like Facebook has). We have language changer in the header on main homepage because we do not have really users there and it is content-centered webpage. Here we should have this in footer and in user account settings.
In short, no.

Byt this point, Butter has loaded in it's default saved-data project. If the conversion of the localStorage value fails, `checkForBackup` will return undefined, so we know to not try and load in the recovered project.
width = Math.min( minWidthPix, width );
space on right bracket here and line 20.

Also... maybe I'm alone here but I hate seing decimal numbers like <pre>.2</pre>. I think they should be <pre>0.2</pre> but I don't think we have anything concrete about this kind of styling.
Popcorn.plugin( "words" ) is safe, you don't need the nops.
Since we now also store images on the server, a project delete will remove associated images you uploaded as well.  Can we modify this message to be more clear about that?  Maybe:

"Are you sure you want to delete {projectTitle} and any uploaded images?"
Is it worth point all of these `description` issues out?
So this selector targets a pretty specific group of elements -- sequential items in inline lists that are NOT the first item in a given <li>. It provides a little bit of extra spacing for readability's sake. We *could* add a class to those items, but that would mean adding a pretty large number of `class="spaced-item"` or whatever, over the course of a large-ish list page. Screenshot shows the elements targeted just for a group of three stories in a list.

http://cl.ly/image/340v3H460m3a

It seemed like a lighter-weight solution to go with the nasty selector, especially because it's just for a small aesthetic tweak.
oh, the confirmed flag isn't in solitude yet. Maybe you can add it when you work on the decorator. Either way, this seems like a good to add uuid_pin_is_confirmed, etc.
and this is not indented properly, what style are you guys using ???
OH "exit() is my free()" :)
This could be ``key, val = changes[fn_].items()``
Added id in 4b1af7d39f3ad67409218da5e6a146e256b8d692
if you're going to use File.join, might as well go all the way with it:
```
@gem_path = @gem_home + ':' + File.expand_path(File.join(@path_to_project, 'vendor', 'bundler_gem'))
```
Shall we rename it to toBeCommittedPaths ?
I'll add the comment. It is because in those controllers (where `:organization => nil`) we don't want to assign any organization to created notices.
As someone pointed out, there aren't really any other types of open source projects with interfaces that put the copyright everywhere.  And I think this will make sense to have downstream, but consensus from talking to members of both Katello and Conductor team is to keep this off of upstream.
That's cool. Totally understandable.
50 points is an overkill, 10 should be more than enough.
Resharper said that uri cannot be null, so the else was unreachable
Yes, using the singleton from here is not a really good idea, I certainly am open to a better approach.
This filter out exceptions that are caught by a `catch` statement.
Ok, so you mean we'd do ``log.warn``, ``log.info``, etc.? I'm fine with that, but just wanted to check.
This is fine. But Python 3.2 has a `concurrent.futures` module (http://docs.python.org/dev/library/concurrent.futures.html) for this purpose. There is a very clean backport for >=2.5 available at http://pypi.python.org/pypi/futures (I'm not sure, but, I think this was the original version of the package before it was added to the stdlib).  It might be worth adding to Astropy if we have a need for this sort of thing, now that there's a "standard" implementation.
I had some problem before that in some of the tests things that were Tables also had `dtype`. But, I quickly tried that now and maybe I can move it back.
And not that there's anything wrong with this either, but by putting `_in_setup` in `__builtins__`, in `astropy/__init__.py` we could put:

```
try:
    __ASTROPY_SETUP__
except NameError:
   __builtins__. __ASTROPY_SETUP__ = False
```

That's pretty much what Numpy does, which I've always kind of liked.  Though I don't think there's necessarily any advantage to it either.
Is there a reason this class isn't included in the "public" API (e.g. imported into the `config` package?)  Right now it doesn't have any docs, because they're autogenerated for `config`, but that doesn't include this.
Ok, this is fixed in 85b5822
直接把Url类换掉把。

不过Request有点太长了，而且很常用，需要有个shortcut，'Req' ?

我建议我们先把名字换掉，url类里面可以先保持不动。如何？
On Windows (winsock2.h) SOCKET_ERROR has the value -1.
It was introduced by this commit from @BlueMatt:
https://github.com/bitcoin/bitcoin/commit/c6710c7a70658536ab0217dff18a45622ea08680
toDate
filter forEach mu yapsak ya?

once ignore icindekilere filter edip, sonra kalanlari degistirsek mi?
Splitting in 2 LOC
Does this work? Where is `widget_type()` defined?
Why the double bonus key nesting?
Might be worth adding a few comments on the bits involved here. Same below for the other masks.
Instead of a whole file-level indentation, it would be cleaner to use

```
try:
  import cython
except:
  __test__ = False

def test()...
```

That will make [nose skip the whole module](http://readthedocs.org/docs/nose/en/latest/finding_tests.html) if cython isn't around, without the ugliness of indenting the whole file.
I have confirmed that this resizing of figures completely messes up non-svg figures.  We simply can't do this.
Not after this PR ;), since we were using os.getcwd before, this is precisely what was happening.

Basically I doubly fixed the issue, which may be overzealous:

1. use os.getcwdu(), so we aren't passing non-ascii str objects
2. don't let that similar mistake in the future cause crashes
careful.  taking out Supplier means you will be performing I/O in the injector, which is not a good idea.  Can you please revert this to a Supplier?
getAttachmentForVolumeOnServer(volumeId, serverId)
I am stripping "use strict" for the browser build for now. I had some issues with using ICAL.js in a worker initially this may actually work fine now.
I like it. So I keep it.
These are gone!
There's not really any proper event listener system in place.

Take a look in the KF.js module:

~798: _refreshKPDB - this is called when we need to update the KF toolbar with potentially changed state (such as KeePass being logged in or closed).
~807: _refreshKPDBCallback - after the call to getDatabases (and subsequent JSON-RPC response from KeePassRPC) this function is called and in turn calls various UI update functions. One possible approach is to call the common dialog update code from here but I think that won't work because we won't know which common dialogs (if any) are actually open at that time.

A better approach, and one that I'd probably have to do soon anyway when I add support for more UI entry points in a future KF version (e.g context menus, keyboard shortcuts) would be to set up some kind of event registration system and then notify all listeners of that event from within _refreshKPDBCallback. I'm not sure quite how to go about doing that but guess using something like https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIObserver might be worth investigation.

Ultimately, those event listeners might be called from elsewhere and the toolbars could subscribe to them too but as a first step it might be easier to just leave as much of the existing code path untouched as possible.
Does the line above it not do that by calling the URL with the data? Here I want to get the first item item in mail.outbox
Oh, I see! Yeah! So on the last iteration, retries will equal MAX_RETRIES. The problem that causes is that MAX_RETRIES is the length of the RETRY_TIMES tuple, so if we do `RETRY_TIMES[retries]`, that throws an IndexError. Thus we need to check it before it gets that far.

Also, I'm +1 on the statsd call. I'll add that now.
You're undoing changes that were suggested by contributors recently. Plus "kitsune" is used ambiguously here, so if someone really did want to use a different username or database name, they're kind of screwed unless they know the syntax here already.
This is not doing what you expect. The second parameter to waitFor is a string and not the timeout value.
rm. This is the same as waiting till the next line when it does `return self[name]`
Can you add a test to show these aren't included if package size is not large?
Dont we have (L)C_FLAGS doing that already?
I'm fond of the `Array` method for coercing things to an array. `Array(nil)` returns `[]`, which means this line could be `codes = ["xxx"] if Array(code).none?`.

What you have works fine, so there's no need to change to the `Array` version, but I wanted to mention in case you didn't know about `#Array`.  It's a nice way to be able to confidently treat an object as an array without worrying about special casing nil.
we can optimize this call on PHP > 5.3.6 by using the `DEBUG_BACKTRACE_IGNORE_ARGS` constant.
Why was it buggy? Sorry, but I don't get it.
agreed, but it should be a separate discussion :)
I should be deprecated in 2.2 and removed in 2.3.
You mean like this?

```php
<?php

    private static $mongo;

    public static function setUpBeforeClass()
    {
        if (!class_exists('\Mongo')) {
            self::markTestSkipped('Skip test, "mongo" extension not loaded');
        }

        try {
            self::$mongo = new \Mongo();
        } catch (\Exception $e) {
            self::markTestSkipped('Skip test, can\'t connect to mongodb server');
        }
    }

    protected function setUp()
    {
        $this->options = array('database' => 'sf2-test', 'collection' => 'session-test');

        self::$mongo->dropDB($this->options['database']);

        $this->storage = new MongoDBSessionHandler(self::$mongo, $this->options);
    }
```
Great point. I had to check this earlier too and forwardings table uses (table_id, base_source_id)  as its primary key so there will be at most one row per each forwarding. I'll add some comments to clarify it.
This is called a [Data Clump](http://martinfowler.com/bliki/DataClump.html).

`ActionMailer::Base` is a weird one, because you don't control the constructor. That means that you can't construct a `UserMailer` with the common data and then just invoke `deliver_invitation` or `deliver_reminder`.

It's interesting that `Guest` has two methods which accept `sender` and `event`, though. Worth keeping an eye on.
Good call. In fact we should probably ack it up and knock 'em all out at once.
I guess I've been caught with simple assertions like this passing while the test was actually broken.

Might just be me, but I'm looking to my tests for confidence and more specific assertions verifying I've done what I described give me more confidence.
Please put the binary operator at the end of the previous line. PEP8: "The preferred place to break around a binary operator is after the operator".
```
You can find more information on connecting to an instance on the official [Amazon EC2 instance guide](http://docs.amazonwebservices.com/AWSEC2/latest/UserGuide/AccessingInstances.html).
```
Ah, this isn't what I was expecting (also there's clearly a hole in my testing).   The intent here was to default to standard out if no file target was give.  Will fix.
it's spelled "received"

maybe this message should be changed because it's not really a HUP signal?
`target_hash`
для отображения поста же
Bad indenting.
Apparently open issues and unmerged pull requests are no reason not to be included in CDNJS, because [chosen was in fact added about a month ago}(https://github.com/cdnjs/cdnjs/pull/430). Perhaps this is not the most urgent issue considering the amount of open issues, but maybe it is an issue that can can be easily fixed by changing the links as I suggested this pull request and cleaning up the gh-pages branch.
The instructions are still in the default data list for every corpus. They just aren't being put in every new datalist anymore.
What about other siblings? If there is another sub deployment that is not deferred, it will still be ACTIVE, will fail with missing dependencies, and will cause the whole deployment to roll back.
sure, i know that they have different concerns. i just thought this line is relevant for setting back the original height to the element on destroy.
вот это мне не нравится, не хотелось бы в Topic иметь Section
текущего пользователя можно в модель не добавлять - template и так доступен в jsp
nit:
```javascript
if (!services || !services.length)
  return;
```
Código: 000
Yeah, forgot to remove that after playing around.
I propose to access `navigator.battery` in the handler instead of passing a `battery` to it.
I tend to think this building block do too much things. Can you remove the edit feature from it at first and ask later for a new PR once the scope of this one is figured out.
that's exactly the change. I put the p inside the label (line 315)
Are we still using this classname? Just asking!
The text of the icon is already rendered, this function is just to update the icon it self (won't modify the text).

I can split this in two functions to avoid the early return ... but I'm a great fan of them ;)
that would generate a warning in non strict mode, thus i prefer to leave as it is
Ah, you're right. This was worked around with a hack in

http://meego.gitorious.org/meegotouch/libmeegotouch/blobs/master/src/corelib/notification/mnotificationmanager.cpp#line52

I can't remember why arguments()[0] wasn't used. Well, if it works now, let's use that, then.
We can, I didn't know if you wanted to leave it in there in case @pengwynn fixed the bug in the Github API we were talking about.
agreed. making the change.
It doesn't look like a paragraph. A `<span>` would be a better choice.
Doing something 100,000 times slows down the test suite, too.  `sleep` is just less obtuse and more explicit.

Just make sure to use a low value (e.g. `sleep 0.1`).
这个我不大清楚，我想有个分割符。很多小说换场景的时候我都觉得有些突兀。。。。你有idea么？
do we need this operation?
Can you make these properties instead of functions?

When debugging later or if we want to export a QuickSWF file as JSON data or something in the future, it would be nice to see all the conditions as booleans instead of having to call these functions all the time.
The :class: references don't work as expected here, since WithProperties and Interpolate are not documented as classes (not something we should try to fix right now!).  You'll get better links with ``:ref:`WithProperties` `` and similar for Interpolate.
Shouldn't this file not be assembled dynamically like the other web server files?
Why mm files are mac-only?
making methods public
If you are hiding the password in another way, we can remove DBsettings.pl and settings.pl
This is not the best boundary (it is also the one from the LGPL code we are removing from this project.)  This should something long and random.  Perhaps a constant combined with a UUID.
Ok I see what you mean now
We don't actually include this in the SDK configuration do we?
Yes please do. Also once done feel free to land.
Oh right, makes sense!
Btw, is there going to be one global loader instance, or each addon will have its own?
What about m-c code, is devtools going to share a loader with other part of m-c?
Do I understand correctly that this implementation fail (as in "not work", not as in "reject") if all promises reject?
Please use relative form instead.
NOTE:  I did *not* implement ngettext - we aren't using it anywhere.  It is not too hard to implement if we do want to start using it to handle phrases that talk about some number of thingamabobbers.
Reading through the docs for Components.Exception it tells me that those should be used for XPCOM components. Here we do not have a XPCOM component implemented in JS so I think we should better throw an Error.
another PR could be to fix these stuffs (just saying ;))
bad CS here too
Propel has its own exceptions, you should use Propel\Generator\Exception\InvalidArgumentException.
Even if they're all being set in the same place, a test should have exactly one reason to fail and there are several instances of `Facter.fact().value.should ==` in one test which is not a good practice.  You don't just necessarily want to test the functionality of the method.
Can Puppet.settings contain a hash? This all looks to be a duplication of all of the logic that is in Hiera itself, but I don't think Puppet needs to duplicate all of that (the clue to that is that your test only covers the file missing case). I think that the real fix to this is that Hiera::Config needs to be fixed up so that it can be instantiated separately from Hiera, modified by puppet to override the logger, and then handed to Hiera.

Also, we need to warn the user that we are overriding the logger that they might have set in the hiera config.
Also, the warning about the config file being missing should say what we are doing instead of reading from the file.
@zaphod42 do we still have `puppet queue` in master? does it rely on the side-effect of `Puppet.features.pson?` loading pson?
Since the default values are constant, these can be written with the two argument version rather than the block version, which should be a little faster.
can we get this merged and make a new issue/pull to rewrite it ?

On Mon, Nov 12, 2012 at 11:07 AM, Evan Phoenix <notifications@github.com>wrote:

> In lib/rubygems/core_ext/kernel_gem.rb:
>
> > @@ -0,0 +1,53 @@
> > +module Kernel
> > +
> > +  # REFACTOR: This should be pulled out into some kind of hacks file.
> > +  remove_method :gem if 'method' == defined? gem # from gem_prelude.rb on 1.9
>
> The comment should be replaced with one that explains why we remove gem
> more verbosely.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rubygems/rubygems/pull/395/files#r2101041>.
>
>
The escaping can be avoided using double quotes and formatting:
"The module '%s' is not installed." % d
pow() result here is machine dependent, will produce different precision results on 32bit and 64bit machines
will add more comments though
This should likely check the validator type; otherwise, it's possible that the next line would call an undefined method if the validator type is not what is expected.
I think there is no sense.

With "call()", i think you must pilot the "$soapClient" propertie, the \Soapclient class.
The goal is use the \SoapClient class, not the Zend\Soap\Client which is just a wrapper.
Not sure about the exceptions yet. I think I'll have to ask Ralph about that...
I'd return early on that, feels much more readable
I think you over checked a little with `!===` :) Also `substr(-1)` should be enough.

Thanks!
My guess is you actually want to use PythonContext.LessThan instead of Compare - that'll match the Python version of bisect.py (which isn't calling cmp).  But one other fun binder trick you can use here is SiteLocalStorage:

private static int InternalBisectRight(CodeContext/*!*/ context, SiteLocalStorage<CallSite<Func<CallSite, object, object, bool>>> storage, ...)
            if (storage.Data == null) {
                storage.Data = context.LanguageContext.CreateComparisonSite(ExpressionType.LessThan);
            }
     
            ....
            if(storage.Data.Target(item, litem))
                 hi = mid;
            else
                 lo = mid + 1;

This lets you keep and use a call site locally that's specialized to the caller and the binder will provide you w/ the SiteLocalStorage<T> automatically.  That'll give better performance than using a shared call site which will be specialized to some random types.
my miss, forgot to change on hex
Use something like deferInit, instead of the ambiguous dfdInit, same with the below.
Space inside parens. Applies multiple places.

`function(selector) {` -> `function( selector ) {`
Why not just ```#define STBTT_assert(...)``` (i.e. an empty definition)?
I think we can drop this comment now
I've created two classes because I'm not sure yet if these are the definitive arguments we should pass to these events. I've only pass them the connection but, for example, maybe "onBeginTransaction" could receive the unit of work. The thing is that I don't know if, at that point, you can modify anything in the unit of work. Although it could be useful to ask which entities are about to be inserted, updated, removed, etc.
can be simplified to:

```ruby
return false unless role
```
Please remove this `id` check. **Always** return next/prev on the basis of the position in the playlist. Remember that the order in a playlist is user-defined. It is not always on the basis of Video.id.
Each version will set it to the next version, long ways down the road versions could be condensed when possible.
Are `$File$` and `$Date$` still supposed to be here?
Unfortunately, v5.0.0 is has bugs, as documented in http://lists.eecs.utk.edu/pipermail/ptools-perfapi/2012-September/002517.html ; probably this implies that it's better to remove this easyconfig version completely.
Remove space before ,
the authorship should be preserved as part of the code in the AbstractResourceOwner comes from the previous GenericResourceOwner, and so from Alexander and Geoffrey
I don't see why you are activating CDI, you don't use it...
i do not know that :D
what if was set to release and then selected to no release?
unnecessary semicolon here
you should probably check for the `popcorn.plugin.debug` flag here. Otherwise this should "fail gracefully" as they say
いいけど，スペースの代わりに \s および \S を使うのがよさそうに見えるかも．あるいは \p{blank}
@ohadlevy , I thought that constraints(:id => ...) wouldn't include constraints(:host_id => ...) but I delete it and it works fine.
can combine these into one line statement
I would get rid of the s here. (The degree is an adjective.)
Added the specific subtypes and threw in a link to the BSON Spec
删掉这些，不需要注释。
Lol what, why is this happening?
я, читая название функции, ожидал, что мне добавят одну вершину. А тут вообще нечто с чем-то происходит
you're probably right. We are using probably a lot though ;-)
Why this change? IDs should be unique in a given document, thus I don't understand why you need the extra class part.
hmm. would it be better as a member of Notification? seems a little strange to place it here given it only accesses the data from Notification
This should be a precondition.
`Url` is probably better written `URL`. :)
options has only just been created. Is there any point in doing `options.providerURL = options.providerURL || 'https://www.google.com/accounts/o8/id';`
Can you unwrap this? I'm fine with using ternaries for simple stuff but this is a bit dense
Removed `.config`.
The convention so far has just been to do:

```
loginId = loginId || {};
```
Class name injection is a grotesque hack that has bitten my in the butt more often than not. Let's not do that. :-)
@brandonrosage, I had to use <code>`<p>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</p>`</code> here because there was no way to add a space to the right or left of a button. Possible to add a style that adds something like a **margin-right** or **padding-right**?
see https://github.com/brion/WLMMobile/blob/6b321409e224304f012d5abe8ac935a2c6d0191c/assets/www/js/app.js#L936
should be able to give this a class toggle-page and set values to page names
Why are you including all these files? You are not using any of them.
Your IDE/text editor seems to be automatically appending new lines to the end of all files. We prefer the opposite ... please change your settings and update those.
да, тут только на размер 100 рассчитано, просто это было жестко задано в
задании, поэтому не стал добавлять гибкости. Алгоритм - это алгоритм Кнута,
описание например есть тут: http://stackoverflow.com/a/1608585. В двух
словах - мы проходим по всем элементам, выбирая каждый с вероятностью
количество_оставшихся_элементов_массива /
количество_элементов_которые_еще_нужно_выбрать. Если в какой-то момент эта
вероятность становится равна 1, то выбираются все элементы до конца массива.

Best regards,

Grigory Loskutov


On Tue, Nov 6, 2012 at 8:36 PM, tarpaha <notifications@github.com> wrote:

> In DNA/DNA/main.m:
>
> > +//
> > +
> > +#import <Foundation/Foundation.h>
> > +#import "Cell.h"
> > +
> > +@interface Cell (Mutator)
> > +-(void)mutate:(int)percent;
> > +@end
> > +
> > +@implementation Cell (Mutator)
> > +
> > +-(void)mutate:(int)percent {
> > +    int percentMutated = 0;
> > +    srandomdev();
> > +    for (int i = 0; i < [[self DNA] count] ; i++) {
> > +        if (random() % (100-i) < (percent - percentMutated)) {
>
> Не будет работать при DNA count отличном от 100.
> И вы не могли бы в двух словах объяснить алгоритм? Просто у меня не
> получилось восстановить алгоритм по коду.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Hexlet/osx-project-1/pull/31/files#r2044758>.
>
>
Definitely! Sorry :(
if this line is not necessary anymore, or delete it, or give a comment of why you are commenting it
It looks like my comment here got collapsed.

The explicit `NSValue *` return type on the literal here should be unnecessary.
When people usually contribute to an open source project the license is usually the one of the actual project. If the license differs to the `hubot-scripts` license, then people should release the script in it's own package in my opinion.
considering it.  The problem I find with that is that if one user is destroyed, or one comment, then the entire conversation is moot.  I'd ideally set it up like Reddit, where when someone deletes a comment/user, there is a placeholder that says [deleted], to maintain the thread. Guess I would set the comment & user to "deleted" in that case.
Same as above - I will update to be a `long`.
would be nicer to return an array with dtype=np.int

```
times = (np.asarray(times) * self.info['sfreq']).astype(np.int)

if use_first_samp:
    times += self.first_samp
```
or fair enough. Maybe just add a comment :

# XXX : width and height are here assumed to be equal. Could be improved.
why not keep both options? try import from sklearn and if get ImportError try joblib directly?

thanks for taking the time to submit the patch
Message: should be defined
Don't align assoc array values.
I think the default is false, so you can get rid of the attribute
No problem, @ugisozols  what can I do for you?
I'm pretty sure Devise needs the notice line in order to show a login failed message, or would you just put it in relevant templates?
So, let's just get rid of these aliases.
"last three commands in one"  or "commands combined by"
Yes, this is new, BUT, I think that we no longer have the `_form_is_choice_selected` or `_form_is_choice_group` functions.
Add a period after `This will render a CSRF token` - I think we should have 2 different sentences here.
We should stil require a server here, if there is a default specified maybe use a checkbox or something to indicate it.
I swear I changed it to use Duration.parse - dunno what happened...
I suggest removing this as this goes against how Extensions are normally used within the system. Make your Extension named Node instead so you can do: Node(system)...