labofsahil/github-event-dataset-2012 huggingface dataset:
It's not that this change is bad. It's that your pull request is about fixing spawns. If this gets merged, it messes with history. The change is totally unrelated. Ignoring `.rbenv-version` may be a good thing to do, but it's a separate issue, you know? Does that make sense?
There's a lot of copy-pasted code in these four lines, and it's unclear what the intended result is. It looks like Tim used `d.replace(' ', '+')` when he really meant "encode this for use in a url", which can be achieved by urllib.urlencode or some such util. It looks like you're doing something similar with the `"?region"` stuff. In general, there should be a better way to separate the data, and what you're using it for. I.e., here the "data" is the various things you can sort on broken down by type, and what you want to do with it is use in  URLs later.

If you can think of an easy clean way to clean that up, go ahead; if not just remember it for later. (I would have said this to Tim if we'd been doing pull requests at the time...)
It always sorts by ascending order. How do you sort by descending order then?
The slash is not needed, it works perfectly with "..". About netBeans config it is ok. So for accept the pull request, it would be needed make a revert of ".." stuff.
No. ;-) For import of mongoengine.django.auth.
Strange, but then we still have to develop that. ;-) In some other pull request. Leave it as it is and fix other issues.
If we're really trying to support the full RFC here we will need to support quoted-string as well, which this does not. Commas can be embedded in quoted-string.
Mostly because I disagree with smushing all of your variable declarations together, separated by commas when they can be more meaningfully splayed. What do you think?
These don't appear to be used for anything.
I'm actually OK with this, though some REST fanatics will fight me on it.

There are hundreds of irregular plural forms though. I wonder if there's a JS library that handles it for you. Don't worry about it -- no need to go crazy on that issue, but I do wonder.
The only previous step is:
```
Given A Database exists
```

Where am i overwriting them?
This is a legacy step that i should have deleted after the reactoring
Relying on the second clause here looks a little dangerous;

`(AppType.get(project.app_type_uuid) rescue nil)`

There could be an exception for all kinds of reasons, like maybe a threading or memory or network-related exception.  We don't want to replace an existing app_type_uuid due to [exogenous exceptions](http://blogs.msdn.com/b/ericlippert/archive/2008/09/10/vexing-exceptions.aspx).

I would take a more cautious approach and just remove that second clause entirely, so if there's already an app_type_uuid then Agi will not try to replace it.  If that turns out to impose an operational burden when the uuid is wrong, then we'll figure out how to solve that problem when it comes up.
对，我首先认为NGX_CMD_IPSTAT是本模块独有的命令
@katsuyoshi The tag doesn't match the version, which is '0.2.1'.
For layers that are uploaded with XML metadata, the update mechanism always forces the user to upload a new XML file.
Yes, I believe this was written like this in the scala version just to avoid a function call.
Accept the org object NOT the id.
Was it really just off by 1 pixel?
Not a good idea to do self.save! in the model unless its absolutely necessary. I 'd recommend adding the save call in the same location as 
```ruby
user.default_org= org
user.save!
``
That's very handy, thanks.
The current validation will not allow the user to set the usage to unlimited (i.e. -1).

May need to enhance to something like:

if not value.nil? and (value < -1 or value == 0 or (value != -1 and value < record.usage_count))
yes. If you look at the lines that used to precede the continue, they had nothing to do with expr. So if expr had become a number then the loop would exhaust itself with the continue and then exit. Now it just breaks immediately.
OK, but the problem is when you unsubscribe the connection is removed from connections list and you can't find it with getConnectionByAlias later.
- Server needs a user mode buffer that flush drops to.
- ClientConnected needs to be active polled in .net 4
Wrong kind of exception. This should throw ArgumentOutOfRangeException. Also, this should look like:

```cshap
Assert.Throws<ArgumentOutOfRangeException>(() => config.KeepAlive = -1);
```
Because the  value '0' is also false and should be passed.  (this is shown in the test)
No -- this is about defining new units that have a name.  `(u.km / u.h)` creates a new unit, but doesn't give it a name -- `def_unit` has to be used for that.
Thanks for noticing, it's a typo :)
"bitcoin-miner" for consistency...
if (fClient) would mean that if we are a SPV node, we should not respond to mempool requests, as other SPV clients should not be asking peers that can entirely not check transactions for transactions.
Why convert to a string here first?
Did you actually check the [wincache_ucache_inc](http://php.net/manual/en/function.wincache-ucache-inc.php), how is it a constant? If you really want to initialize it set it to null not 0.
missing type (string here)
I think an approve method should look more like this:

```ruby
def approve
  @membership.approve!
  flash[:notice] = "Membership approved"
  redirect_to @membership.group
end
```

I can see you have a comment there to much the same effect, but I don't think we should get in the habit of merging in pull requests that still say something like "TODO: refactor this". Refactoring the code into the design you want is a key step in coding, and shouldn't be separated from the other steps in case it gets forgotten.

Drop me a line if you need a hand understanding the acts as state machine library. Basically if you define a transition called :approve, you'll get an approve! method for free.

You'll note that I also didn't have the @membership = Membership.find(params[:id]) line in my example code. That's duplicated across all these methods. You could move it into a before filter, or into a lazy-loading method like the "resource" method that inherited resources uses.

Same ideas can be applied to remove_admin and make_admin.
I bet it'd work, I'm just not used to the "if not anchor:" idiom so tend to be uncertain if the empty string is false.
Do we need to resolve this TODO before merging?
Don't think we need it here, but no harm done as it is just a comment.
It's canonical to either put this in the
```python
if __name__ == '__main__':
```
block, or in a `get_parser` function. That way the code isn't run if someone imports your module as a library.
Couldn't you just check if the locale is prefixed with `en`?
From what I could tell, it is new in python 2.7?
You are right, we need to handle that. I'll search for a similar case in the codebase.
wow.  good catch.  yeah, I just removed this method as it did nothing.  I did lots of hashing on these methods to get down to what was needed and useful, and apparently I missed this being replaced...  thanks!
it seemed to work, but I fixed it anyway.
success_message should be "An email has been sent to your account."
How did that even get there...  I'm aware of the intended usage of Debug, must've been careless when committing that.  I'll just throw that out.
Alright, perfect!
Yet another case of "was commented out when I checked out the original WME Lite"
missing `@` before return.
These 2 methods are specific to HttpKernel
please remove the trailing whitespaces
You can inline the `type` with default here so you don't need to set it before.
These method is [deprecated](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/AbstractType.php#L68).
@fabpot your screenshot does not work. The link gives us ``Not found``
Do you really want to remove this class ?
Ah yeah... will fix it today
just `raise` with no argument will also preserve the stack trace of the original error
No. This is gonna break the post in the main page.
It should be renderTemplate(m);
how? Does ruby support some two level return? What I want achive here is to stop execution after calling problem. Of course it could be solvable by exception that is catched, but I don't want to do such massive changes.
just confirm that this doesn't do anything horrible when tapping on that user's icon to switch to their profile?
You don't have to change it, but in C/C++/ObjC is good practice to use this: `if (0 == self.selectedIndex) ...`.
It will prevent this kind of bugs `if (self.selectedIndex = 0) ...`. It will save you a lot of time debugging. ;)
Agree. I would probably assert that `User.find_by_email` got called, but it's overkill for sure.
Is this options parameter different than the typical optional parameter?
hehe, yes, i'd love to add that (back in :smiley:)
Not sure about this one being deleted - it is useful and I have some documentation which uses it waiting to get a polish and be revealed...
Would you mind removing this comment?
This makes owslib a core dependency (when using matplotlib). I'm not sure that is good. Lazy import would be preferable.
Not a change in this commit, I know, but it would be more idiomatic to call this method has_value?
is HHTP a very new protocol? ;)
flask and mock should have a blank new line around them.
MinimumVersionFilter?
Talked with bstansberry and ozizka and well that is the conclusion. Adding another execution with set of exclusions and inclusions would make integration/basic pom even more unreadable.
are you sure it’s safe to remove the `onerror` here?
This selector looks weird to me. Don't we have any other easiest way to select that text?
okay, added, and also will file a bug after this merged.
Typo in 'manifest'
> then we should rediscuss the complete cli probably --

:+1:

> `visor root scale` doesn't really make a lot of sense imo

It doesn't, but it was not possible to implement it as `visor scale` which was originally intended.
I love these examples. So awesome.
Why not something like:

(previousVector - nextVector)
  .mapValues {math.abs(_) }
  .sum
  .write(Tsv(diffLoc))

If we can't write matrix code staying in the API, I usually view that as a sign that the API is missing something.
please return Pipe.
There for interface signature matching
This is useful. It's probably better to define `is_group` for the type `Index` and then define your new method based on that.
Maybe we could call `scratch` `translater`: whatever you speak (assign) to the translater will get translated for its subject (target). Just an idea.

I think "translater" works well for when the resulting proxy is supposed to be the untranslated source, i.e., when the focus is on its outgoing validators. Perhaps "translated" will work well for the opposite direction (but implemented with the same proxy of course).
For superuser actions, I switched over to using parameters from the URL to pass around user identification data (like in django's tutorial) instead of using the session like I had previously.
I'm just curious if the regex match would work without proper escapes since urls contain <tt>/</tt> characters.
I have updated the `PartPresenter` to follow that pattern but left the `PublicationPresenter`. The `PublicationPresenter` doesn't access the data uniformly, eg `body` has moved into the details hash whereas `title` has not. Also many variable names have changed, eg `type` on a publication is now `format` on an artefact.
Is this one should be the virtio serial port name which can be got from vm.virtio_ports?
So far all the options have the same names as attributes. Having it as --tag will break that convention.
This was the reason I have ended up with --tags.
Agree with you, though - --tag does look better.
build.bat/sh are part of dojo tarball
Maybe we should add an additional argument to pass the repository? This may require something other than `split_file` :(
It's possible.  But the services were getting stopped correctly, and should have been destroyed once the WebStatus went out of scope.
agreed that he needs to add a css class, but I think he can leave it a pre so that the default style is good enough.
Hm, that narrows the race condition, but you're right that it would still be present in a replicated context.  We *do* want to support replicated databases, with minor degradations in behavior.  This would be one such degradation.  I'll add it to the to-do list.
yeah totally, understandable. It's tempting to not even including JSON support at all, just less stuff that other implementations will have to support. I can't think of many reasons to have JSON support really, it's easy to take any json and just add a `module.exports = ` to it
```php
if (count($packages) === 0 || (isset($packages[0]) && strtolower($packages[0]) === 'nothing')) {
```

With such you could remove the `if` below as well, as the `array_map()` and move `strtolower()` into just last loop (with change of `$lowercasePackages` to `$packages`).
yes, on the line on which I commented
This all looks pretty good!
These can't have spaces in them,  as per Richards request for his parsing.
I guess declaring var is unnecessary, but... eeww.
buffer_len is set to 0 at the start and isn't reset to a new value right before the end.  So at the point you specified, it's 0.
I believe you can remove the `onReady` callback and the `tab` variable as well; just use `w.tab` inside `onAttach`, see [worker.tab](https://addons.mozilla.org/en-US/developers/docs/sdk/latest/packages/api-utils/content/worker.html#tab).
> instead of inheritance

@Yoric What do you call regular inheritance or how is it not regular inheritance ? For example:


```js
let proto = { ... };
let promise = defer(proto); // This is similar to -> Object.create(proto);
Object.getPrototypeOf(promise) === proto // true

```
What's a point of catching and re-throwing more detailed errors from `rm` if they are ignored anyway ?
yeah, that's right, we're checking for the string 'null'.  When you use our sample RP and want to simulate a session where the user is logged out (to check out how events are surpressed) you can type 'null' into the session box.

IOW, if you type 'null' into the session box, then `null` will be passed to `.watch()` as the loggedInEmail argument.
Is it now a secondary or a primary? Below the test implies the address is now a primary.
Sure https://github.com/mozilla/browserid/issues/2776
Weird comment. "If True, then each Namespace"
This credit goes to you. Also please update the year. I hope that we can have a patch for the MPL2 license soon. Would you be interested in doing that?
I don't dig separate header/footer includes. You rare look at layout, and when you do it's nice to have it not be a mess of includes itself.
同一个数据为什么会分两种数据类型处理?
The more I think about it, the more I think that @alindeman's idea to return the new constant value makes sense.  That allows easy chaining (e.g. to stub the constant with a mock object, then stub things on the mock object).

So, I think there's just one remaining question: do we expose a public API that projects like rspec-fire can use to find original values for stubbed constants (such as `ConstantStubber.find_original_value_for(constant_name)`)?  Or is the responsibility of rspec-fire to implement that itself?  I'll be implementing it either way (in one project or the other...), but it would definitely be easier to implement it in rspec-mocks, because the implementation can use private internal APIs if it's on rspec-mocks; if I put it in rspec-fire, I only want to rely on public APIs so it'll be a bit trickier to implement.  Is it generally useful enough to include in rspec-mocks?  Or will it just be bloat here?
This should be in `application.yml` I don't see the need for multiple files, just make a `disqus:` key.
This difference from the other Zend\Form\Elements, which only use one validator (as opposed to an array), is interesting. I'm wondering if we should standardize the other Elements to use arrays of validators as well.
allowNonSepa can not be null
-> Please remove the null default value and comparison against null
same observations as above
IMO that the asterisk is hard to understand. `for i18n features` is enough for me
@PHPGangsta Go rid with that constructors
The intent is clearer with an explicit cast.
On Sep 22, 2012 1:14 PM, "BilgeXA" <notifications@github.com> wrote:

> In library/Zend/Mvc/MvcEvent.php:
>
> > @@ -235,7 +235,7 @@ public function setResult($result)
> >       */
> >      public function isError()
> >      {
> > -        return $this->getParam('error', false);
> > +        return !!$this->getParam('error', false);
>
> I am casting. Why is it better? Just because you've never seen it before?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zendframework/zf2/pull/2406/files#r1667949>.
>
>
And we're checking for Tags != null immediately below.
You don't have to explicitly test for undefined, since the else-branch of your ternary operator uses tome[key] as an object. Truthiness would be enough, ie: `tome[key] ? tome[key].valueOf() : undefined`
prob we should do it -- without it the preview won't show the alternative format contact email address in the attachment block
what about filtering by type *and* tag ?
all places showing an example with annotations :)
Is this is a typo or github is failing to render the right parenhesis?
Yes, I should actually remove it there (since they will also call this function).
Could you remove this commented line since you are getting the nodeName from the ServerEnvironment in the next line?
Nothing will work if you don't have a schema... For now we probably get an exception if that happens. We could use the binary type to store unknown schema fields in a generic way if that becomes an issue. When datasources are in HCatalog we want always a schema anyway. So I would think we would chase the cases where you don't have a schema and fix them instead.
Short answer: we should check if there is a schema and fail with a meaningful error message when there is not.
<%- should be <%=

why does the test pass?
Should be _clusterlist_actions.register?
I believe this works, using `in`:

```ruby
found = where(@klass.friendly_id_config.query_field => id).first
found = includes(:translations).
        where(translation_class.arel_table[:locale].in([I18n.locale, I18n.default_locale])).
        where(translation_class.arel_table[@klass.friendly_id_config.query_field].eq(id)).first if found.nil?
```
Or does this sucker actually return the listings themselves that have tour of homes? If so, disregard what I said above.
host.location.name ?
Again, `is_authenticated()`?
I won't be able to fix this for at least another 8 hours, so if someone else wants to change it, that would be great.
Perhaps add `&& ( CONST_2 !== 0 )`?

http://sandcastle.khanacademy.org/media/castles/beneater:measuring-segments/exercises/measuring_segments.html?problem=midpoint&seed=115
You might want to put labels/context here, like "The answer is" or "An answer is"
I will ping you to discuss a bit on this subject to clarify for myself how
it works. At the moment I don't have a clean understanding on this subject

On Aug 2, 2012 10:25 PM, "Randall Hauch" <
reply@reply.github.com>
wrote:

> @@ -1331,12 +1331,6 @@
>                  <scope>test</scope>
>              </dependency>
>              <dependency>
> -                <groupId>org.mongodb</groupId>
> -                <artifactId>mongo-java-driver</artifactId>
> -                <version>${mongo.driver.version}</version>
> -                <scope>test</scope>
> -            </dependency>
> -            <dependency>

This shouldn't be removed, as this is in the "dependenciesManagement"
section (which we can think of as defaults for modules that declare the
dependency with the "groupId" and "artifactId". It should also probably use
a scope of "provided" (meaning that if people want to use it, they have to
explicitly add the MongoDB driver to the classpath, and we'd just find it
and use it; but anyone not using the MongoDB BinaryStore won't require the
MongoDB driver on the classpath).


---
Reply to this email directly or view it on GitHub:
https://github.com/ModeShape/modeshape/pull/465/files#r1296150
Yes, texture armors HD
Yep, this makes sense. (you might want to just add that as a comment, that it produces a new `Quantity` to distinguish from `in_` or whatever below.)
maybe using this? https://github.com/isaacs/node-which
The busy-wait here should be replaced.  Suggestion: use a condition variable---whenever the state is changed to `Idle` elsewhere, the `notify_all` method is called on the condition variable.  Then in this method you just wait on that condition variable.  You'll still need the 'while True`, since condition variables on some OSs are subject to `spurious wakeup`, which means that notifications can happen even when the state hasn't been changed.
i wouldn't trust in the result of file_get_contents, exactly because the error happens with copying a file but the result is  0 bytes. so, the function does not return FALSE, returns an empty string, and we end up with a 0 byte file, the present problem exactly. maybe just an == false, or checking the size of $contents to be bigger than zero. would be better.
название не очень говорящее
I think you have to fix this part: "Let's tell it we where we want..."
I probably should have mentioned, but general convention is to wrap at around 80 columns - it's not a hard limit, if it's only a few over or only a single line etc, feel free to ignore it, but I think these docs would look better wrapped
What is the purpose of the "!!" here?
I don't understand this comment (which probably indicates I'm missing something important). Can you explain
That makes sense. Should we change the library keys to userid#loggedin, userid#public instead of userid:loggedin, userid:public?
In order to be consistent with our other APIs, this should probably be 'createComment'.
Thinking about it, this function should actually be private and should not be module.exported.
What's the plan for Sakai Docs? Will pages be stored as files as well?
except for the provider, i am not sure its a good idea to inject more things in the constructor here than the base generator. there was probably a reason for the core not to inject. i think the context lead to tricky problems about cache warmup.
Won't need this if you use new search function and set appropriate params.
Missed a semicolon at the end. And you shouldn't be making any changes to this file anyway.
hammingDistance - коммуникативна, т.е. не зависит от порядка  вызова. 
Нужно оставить
Там будет или мусор или NO (0) при создании
я к тому, что на последних из 10000 мутаций будет много лишних раз перебираться randomNumber, что совсем не оптимально
Ваш код прост и лаконичен, однако рекомендую в этом случае переписать геттер, иначе он будет возвращать ссылку на ваш DNA, и с ней можно будет что-нибудь сделать.
здесь должно происходить сравнение массивов и вычисление дистанции между ними, то есть различия, а не совпадения
Since `datas` is an array and not an object/hash, it's better to iterate over it with `Array#forEach()` in node. You can also use `Array#filter()` to make the code more readable and filter out empty rows.
Please use spaces between operators:

``` javascript
        for (var i = 0; i < infomaniac._listeners.length; i++) {
```
Good points. If it's alright with you, I'll put it on the main queue, so it behaves like `+interval:`. Also this way if a program is single threaded it doesn't need to worry about it.
Can you please add a space after the keyword: `if (disposable != nil)`
That's kind of funny, also was thinking about this before. You mean as alternative value on Epochs construction, right? Would be somewhat more fidgety witht regard to serialization, etc. but not impossible. Let's collect voices and I'll add it if we want this.
Can you send me a PR on top of this branch?

I ll have time to take a look later this afternoon
picks should come after raw
from what I see you use this file ghaleb-khaled/task1-express/Logic/NewsJSON.js for that which has the same code. Isn't that the case?
POST request for logging out, awesome!
You would rather not catch the exception
Put it in if (log.isDebugEnabled()) {
log.debug...
}
This will save us some memory if debug is off.
Yes, the jsp needs to use the provider search widget instead. It shoudl be done in the same ticket here.
no need, but is it possible to make it so it is explicitly fails (not timeout)?
I tried and had some issues, but that was a while ago.
HAHA! Cause I like to watch the world BURN!
PNG图像的alpha通道中的透明度一直会被保留。
那么只有状态码为200、300和302的响应会被缓存。
Do you verify that this exception is indeed thrown?
This can become annoying if there's many retries
нет конечно. Тебе же урл копировать надо как-то =)
а ничего, что тут вообще кода нету?
Тоесть будет QVariant
Sure all my apologizes, I  misunderstand the -7 :( You're right !
¿Estos cambios son del commit del menú o se te escapó y no debería estar acá?
Same here. This could return several question rows (one for each language)
This line fails to compile on Linux using g++ 4.7.2 / Boost 1.52.0:

/home/glyn/Development/cpp-netlib/include/network/protocol/http/client/connection/async_normal.ipp:83:63:   required from here
/home/glyn/Development/boost_1_52_0/boost/bind/mem_fn_template.hpp:610:69: error: no matching function for call to ‘get_pointer(std::shared_ptr<network::http::http_async_connection_pimpl>&)’
This is indented kind of awkwardly. Any chance I can convince you to use `all` here?
It runs on all members, but it is inactive on all members but the coordinator. In ClusterTopologyManagerImpl.handleNewView every member checks if it has become coordinator, so if the coordinator changes the new one becomes active.
You can pass the request here:

```
$app->before(function ($request) use ($app) {
    return $app['authorization']->authenticate($request);
});
```
This method only has a single tree argument, though. We could just call it `+diffIndexToTree:…`.
I'm not sure what the behaviour is if the preference is not set.  What happens in that case?  IMHO, we should just not start the server.
Looks like trouble!
What does the `{//}` do?
We used to only use 1 in the widget loader, and saw occasional collisions there. After we switched to 2, we haven't seen the issue again. I figured we could just use the same.
@bp323 can't we do the following instead:

```
filter = $(this).data('filter').addClass('selected');
```
well the linux kernel guys do it the very same way so please obey :D
keeping .get
Why add a "transactional" configuration string (and the WT_CONN_TRANSACTIONAL flag) to wiredtiger_open?

It's only tested when starting a transaction,  we don't allocate any different memory or take different code paths based on it.
Done in c98d0b89.
I would really prefer to have a space after //
This should be the other way around, so typically only class_exists() is run, and not file_exists.
Include this file where it is needed.
Fix indentation and line endings
@DenisBaryshnikov  что означает константа 60 и почему она именно 60, а не 42, к примеру?
"code that" -> "code, which"
"add the \bin"?
Should this be 2.7 or is it not synced to the Python version?
Я думаю вам стоит обратить внимание на такое понятие как layout
That's strange, may as well use `pystring::replace` in that case
makes perfect sense when you put it that way. I had subclassed OutOfKitchenError as that was the only specfic error class i could find. 
And out -of-kitchen seemed like a generic cooking metaphor :-) 
It might be a good idea to create a KnifeSoloError class ?
This exception should be logged
I'm using `extra` in the "Markdown Extra" section below, so let's use something different here.
I double checked `bundler/setup` and it does exactly what I want, so I simplified the [boilerplate code](https://github.com/ronin-ruby/ronin/blob/master/bin/ronin#L5-16).
We don't use camelCase in Python. Also, we use_underscore in JavaScript. [See the style](https://github.com/wlanslovenija/PiplMesh/pull/199#commitcomment-1707793).
Yes, this is wrong. This should go to Django templates. JavaScript files are static files and are not processed by Django. They could be. But we are not doing that with this file.

You can:
* move this to `home.html` template
* create a view returning this JavaScript code
* you can do the later through templates, if you want
No, in the `authenticate` method.
Not good. It should redirect back to initial page. This is not necessary home. You can add TODO here.
No. <p> should stay outside the translated part. So put each paragraph inside of blocktrans, but links can be inside, because it could be language-specific where in the text the link should be. Don't have newlines in blocktrans.
Yes. For new views. But in ticket #197 it is explicitly written:

> Check how built-in Django password recovery (called password_reset there, maybe we could also name it like that) is done, maybe try to reuse it.

So, have you tried to reuse and found some problems which forced you to define your own?
Yeah, it got moved. I just think that it should either be CamelCase (without the _ prefix) or _under_scored, but not both.
This class seems "utility" for me. Contains methods to check if process is already running and activate process if it IS already running.
you are good teacher Master's Yoda thx )
Naaaja...
This is kinda weird. I guess `categories` should not be there at all.
Can you please check it's exact type? Your `var_dump` looks like PHP's native one...
To clarify,  SessionOwner.getAutoCloseStrategy() would return AutoCloseStrategy.

AutocloseStrategy would have a method shouldAutoCloseSession(Session session) which could properly determine whether to auto-close the session.

This would allow SessionFactory to implement SessionOwner.
nit: Selenium Grid hub is not running
The mouse button has to be pressed down. It doesn't use the standard key handling because then it would depend on Dragonfly UI code.
Please don't append "..." here. We use this only if it opens a new dialog.
I started looking at ANOVA again to see if we could separate if from formula information, but we can't calculate things without the formula information either way, so it's a moot point.
maybe we should move that into phpcr_odm.xml service fragment like the
rest controller, so you can enable all default sin one go?
Either change cx -> x, cy -> y or clarify what the "c" stands for ("pointX", "pointY", "centerX", "centerY"?)
Actually, I think I take that back.  By removing here, you're effectively removing the worker from the set of workers while it still may have more processing to do.  Principally, the on_failure hooks still need to run.  Being able to get the list of workers still processing is a massive debugging help.  It's usually the first thing I look at when workers get stuck, that way I can get the hostname, PID, and the job payload.
Patient Discovery responses have error codes we may want to use (although I'm not clear what error codes for event logging means).  See Section 4 in:

https://developer.connectopensource.org/download/attachments/65601729/NHIN_Patient_Discovery_Production_Specification_v2.0.pdf
This should probably be a build parameter.
a bird worshipping code dweller
As long as the file is on github, I'm alright with doing this in markdown functionality. I noticed though that the Puppetlabs forge site uses plain text versions instead. We may have to change that in the future.
Are these prints to `dbg` always present here, or only under a debugging switch? (Also, I see `dbgout` being initialized, but not `dbg`... am I missing something?)
Would be worth explicitly pointing out that the output optical PSF image has a different pixel scale? (presumably so the details can be seen)
Changed as same as above
we had it commented out previously.  it is handy to have commonly useful log categories indicated somewhere i think.
when we have a prod setup these might be used.  but it needs testing/tweaking so i haven't built a prod setup yet.
I don't think we need this exception check, or catching exception in the submitted callable. Can we just rely on `return f.get(60)` propagating the exception if the task failed?
The `description` parameter isn't used; I think the line below needs to be updated as well.
refactored here
Sorry, I should have been more clear. I meant "readable" as in "you should read it to yourself in your head that way, so why not write it that way?". The syntax highlighting should really make it no problem at all.
> what's the motivation behind the fact that you usually ship with the doc?

* To have the documentation :)
* To let people generate/read it in the form they want (pdf, rest) etc
good call.  Can you stop the copy/paste error?
@Tobion keep it
The new CSS isn't minified.  Is that deliberate?  There is a helper script for generating CSS once the less files have been changed (https://github.com/tangentlabs/django-oscar/blob/master/oscar/static/oscar/less/generate_css.sh) - I presume you're compiling the less files by hand...
Consider writing the SQL like this:
Post.find("SELECT p FROM Post p, IN(p.author.friendedBy) u WHERE u.from.id = ?1 and (U.accepted = true or u.to.id = ?1) order by Date desc",
                      this.id).fetch();
I'm not sure it's master-capable - where would it store notification history?
Mind adding a "\The" before [usr]?
What documentation? This is the first I've heard of it - I thought it might have been the cause of the issue with 0 pressure.
For this the directory structure has changed. This has to be put target specific.
Do you want a callback to is invoked later on, I guess that's more generally for Store (since long running operations could block). However the Store is not a priority for 1.0 - so we could do it later.

Based on thoughts, I will file a JIRA - or not :)
I copied the template from the other methods.  I guess since I already defined it in galaxy, the resource should be valid, unless someone accidentally removes it.
Actually no, as I said, this is the template code I copied from other methods in the same file.
lol emacs.  you probably already know but just in case, i set this in .emacs

(setq backup-directory-alist (quote ((".*" . "~/.emacs_backups/"))))
Некорректно. Надо использовать String.CASE_INSENSITIVE_ORDER
Встаёт вопрос - а имеет ли вообще смысл работа word counter`а на бинарных файлах? 
Если да - то существует ли какой-то способ минимальными потерями заставить Scanner переваривать бинарные файлы, или только написание собственного аналога?
https://github.com/igrigorik/em-http-request/blob/master/lib/em-http/http_encoding.rb#L16
On Linux, the gradient is: `hsla(212,7%,57%,.35), hsla(212,7%,57%,.1)`
why are these 2 locators in the method than the PO?
I'm sure this loop could be refactored in a better way using `array_chunk` and `array_map` no? `array_slice` isn't the most readable tool unforunately.
Might be better to use ``PyArray_ZEROS(1, n_total_samples, np.NPY_BOOL, np.NPY_DEFAULT)`` ?
> >  'R' is a single-letter non descriptive name. It would be much better
 to find a better name

> This should go on twitter ;)

Hahaha, done: https://twitter.com/ogrisel/status/249984920519311360
is this save?
I think you mean regression here.
Ok, so actually, I should remove even more.
As all estimators define ``score``, this code doesn't make any sense.
How would you use it?
You can simplify this by using the "default value" parameter of `util.Properties::readString()`. Just let it return `"util.log.LogContext"` if no value was configured and the whole if block disappears.
Yes, this is merge conflict, we didn't change this class for our purpose.
This is not what the comment was aimed at.  Hiding it in a macro doesn't doesn't change the fact that we're still managing memory and pointers ourselves when we should be using lib functions to do it for us.  The gains from this micro-optimization do not outweigh the added complexity.  Unless you can prove that this gives us an appreciable performance gain, there are no valid reasons not to use data structures that already implement a get size function.
I think we can wait/query for a specific process state activiti
Mas a constante podia ser VOID_TRANSACTION_URI, pois CANCELLATION-TION é muito parangolé...
What about commenting on another comment?
As long as I remember it was just "!". The coding style definitely does it that way and I have been coding this way for as long as I remember. Looking at the code base I can see both
Is including an extra #include really such a big deal?
I think no need. Changed
this could use some whitespace cleanup
Autocompletion :-)
This is misprint from the old Zend_Config, I'm removing it.
Why do you need to specify a location, and what location is defined by this body?
I like this structure a lot better, good cleanup in a fuzzy area of code!
I had a local definition of db since my References were returning a None on _DBRef__database. Would look into DBRef and my Mongoengine model definitions.
```NT AUTHORITY``` is localized, hardcoding breaks non-english systems.
If it happens repeatedly then it means the box with a meterpreter isn't talking correctly to a domain controller. If the option is left blank it runs gpresults to pull the DC address out, if that DC was down when you ran it, it could be why. I've updated with some more useful error and status messages. I'll do more testing to see if I fubared something though, sorry about that.
If you're using send_request_cgi(), you should take advantage of 'vars_post' instead of 'post'.
I agree that it's a very marginal case where something would get passed that has a non-callable write attribute, but why not be explicit?
I think this should only be called if `out_range is None`.
Would you mind moving the `depth` keyword argument after the `mode` kw? I find the `mode` one to be more important (unfortunately, this algorithm is quite slow and memory-consuming, so that it is often really worth selecting the best-performing mode).
It's not required in our API (pickup_phone_number, delivery_phone_number)
yes, please, do you think anyone will want to deploy application from different ruby/gemset then the strored in .rvmrc - or other from the new project file formats ? -> https://rvm.beginrescueend.com/workflow/projects/#ruby-versions
Check docblock
Isn't this already handled here: https://github.com/ezsystems/ezp-next/commit/2c1d67e9030e966e4f0869d90ca66c3862a99969#L2L348
I think removing both these options should only be done silently when `va_file_naming_format` is still the default value, asking the user if it's not is probably a good idea.
Rolling back is still possible - in fact, you can roll back and not care about `va_file_naming_format` at all in the version you rolled back to (unless you want to disable `use_va_format` after rolling back).
You might want to `validate_presence_of :course` everywhere you have `belongs_to :course`, since it's required.
Exception potential, like above
Should add "@Override".
hmm, why not Log.w?  I think Log.e should almost only be reserved for true Exceptions.
Thank you. Will fix in a minute.
On Oct 18, 2012 10:50 PM, "Claude Paroz" <notifications@github.com> wrote:

> In django_localflavor_pt/pt_regions.py:
>
> > @@ -0,0 +1,25 @@
> > +# -*- coding: utf-8 -*-
> > +from django.utils.translation import ugettext_lazy as _
>
> Add also: from *future* import unicode_literals
> Thats what allows the code to consider them unicode strings without the u
> prefix on Python 2
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/django/django-localflavor-pt/pull/1/files#r1884234>.
>
>
I should just create a key utility that does this.  I do it a lot in the code something that takes an arbitrary number of arguments and separates them with "_"
This should be an illegal invocation since you can't invoke a method on the prototype. `proto` should be `this` which refers to the calling Storage object.
the bundle requires other deps too:

- symfony/framework-bundle: ``>2.0,<2.2``
- symfony/twig-bundle: ``>2.0,<2.2``

You should also suggest DoctrineBundle and DoctrineMongoDBBundle (we cannot require them as they are not required at the same time)
I actually really like the idea of this, but I agree with the other comments that it shouldn't be mandatory.  I think that the repo URL should be overridable, and that there should probably be a parameter to disable the repo management entirely.  Not 100% sure whether I'd prefer for that to default to true or false.
la reput.... por comitear rápido :trollface: 
me lo tumbo?
Это задаёт структуру того, как они храняться в прицепленном под таргер жкуери-объекте. Если мы пишем точечку после uploadcare, то все uploadcare-события сложатся под один одноимённый ключ (и там дальше поделятся по неймспейсам). Не могу предположить, чем это может грозить, пока не появится нативное событие uploadcare, что маловероятно.

Но с точки зрения апи жкуери это хак, да. Если не нравится, можем заменить на минусы.
Угу, перебор. Я сначала, как видишь, поставил там `close()`, а потом слишком много подумал.
can we process the string in a method 
It will really help with the readability 

you could create a new one "user_count_value" or modify the existing one it's your choice
> certainly doesn't consider an `int` to be a static array of length `0`.

Not a length *0*, `int` is a *zero-dimentional* static array of length *1*.
Is somewhere stated that there is no  *zero-dimentional* static arrays?
This is not needed here. distributionManagement is already included in the parent/parent pom. Add this to your .m2/settings.xml and you should be able to deploy to sonatype:

    <servers>
    <server>
      <id>sonatype-nexus-snapshots</id>
      <username>your-jira-id</username>
      <password>your-jira-pwd</password>
    </server>
    <server>
      <id>sonatype-nexus-staging</id>
      <username>your-jira-id</username>
      <password>your-jira-pwd</password>
    </server>
    </servers>
Note that you're relying on the order of `readyToWrite` applying to the bulk insert. That's fine, but best to document it.
The security-impl is actually used in the unit-tests. It would take some time to replace it all with mocks
use {} instead of string concatination
Perhaps being more explicit here would be a good call:

`href="{$PHP.BASE_URL}/spraddr"`
why this line is eliminated?
We can declare this outside of this function so it only needs to be declared once
Should we just use `.hide()` here instead?
I haven't gotten around to doing the discussed changes yet.
Yes; I didn't realize it was new in 2.2.
Absolutely no purpose. Removed
Fixed, I believe
Is necessary have indentation here
The old code looked like it tried to handle the case where url.Host and url.scheme were not set.
If you are assuming they are set, you should assert that they are not nil.
Where in your code are you actually enforcing that Host and scheme exist?
... just realized how all of that that came out totally douche-y. sorry about that. should have said: thanks for noticing the error! i wasn't aware of those changed in Backbone. i'll get this pulled in for the next release. :)
Disconnect a node (it isn't an event :)
this documentation is a bit messy -- clean it up or just get rid of it ... typically we'd like to have docs for all of the methods in this class, but it's a module so it is okay to leave them out.
I have modified neighbors to use `strong_parameters`. Since I haven't used them before, please take a look at 0ec8c96584dcb06c60d5c2cb90019a210fd80a12 to make sure I am on the right track before I include it as part of this PR.

If you like this approach, then I'll convert all the other controllers/models to use a similar pattern.
So, won't each iteration of that gearbox_data_bag['searches'].each loop overwrite results in turn?  Shouldn't you be appending the results of each loop?
M2 is up on cloudsoft's maven repo
Line 205 that is.
Using this now gives the error: 
<pre>
error: unrecognized arguments: --version=2</pre>
The initialize.py stuff didn't get fixed this pull request, I just made it look prettier (I had to because over half the junk in test_config that I needed to rip out was being used only by the initialize module). We can add it whenever we solidify this piece.
Would make sense to reuse `replace_query_param`: https://github.com/tomchristie/django-rest-framework/blob/master/rest_framework/templatetags/rest_framework.py#L35  [Tho poss. first move that function into rest_framework/utils/__init__.py]
Ah, that makes much more sense. Thanks for all your contributions by the way.
same reply as above
We should set the `d` parameter in the URL with `image_path "users/images/large.png"` as the value so that our default image gets used.
s/headers/header/ for terminology consistency.  (I can see the argument for 'headers', of course, but I already picked 'header' and 'body', so here we are :)
`compact` is a shortcut to compress an array to non-nil values.
```ruby
[1, 2, nil, 3].compact
#=> [1, 2, 3]
```
Will try)))
We probably should have an example that not only shows the dialog, but acts upon the button pressed. Not necessary for this PR, but while we're on the subject..
I don't remember why I thought I needed that. removed.
Extend constructor to take name, too. Then we can make `ClientRecord` immutable…
`this` instead of `super` for these. Avoids bugs later when you extend the most-specific constructor.
Added more comments for the following step. Now this one doesn't feel lonely anymore :)
This will not be translated, since the translated string is different. ``Add to favorites`` is already translated, please use this one.
Think about how these are filtered based on the state of the competition.
No worries. Still not sure how practical it is, but a much, much easier to keep your layout in check.
Magic numers!
`... a base class member ...`