labofsahil/github-event-dataset-2012 huggingface dataset:
It's actually kind of a weird test, in general...  Seems like by naming the constants and not having things blow up (before you get into the meat of the assertionizing) you're asserted that the classes exist.  I guess the test currently makes sure they're not modules or something.  I suppose the point of this is that this is the interface the library gives to callers, and so you want to make sure that these exception classes exist.  It's a weird one.
Good point.. I should probably just initiate the path element with no path then do a check here and set the path to nothing if all attributes aren't present.
Yep, keeping it is a waste of space at the moment. If we wanted to do something else depending on whether user was logged in through facebook then we could always add it back in.
Or you have removed it?
Same inquiry as above.
I'm not loading Google maps. it's actually coming from the parent window.

The issue is that dropping a track Event on a template target will open up the editor right away, and in that case, the parent window may not have the google script ready.
also missing a whitespace between )+
Yeah, we can take this out now since we don't have the load button anymore.
Do you need to add `HTMLMediaElement` as well?
Why do you keep state twice here?  Why not just track the negative once?
`command -v ` is equivalent to `which`, any reason why this is needed?
also use >=
I know understand that this ```</nobr>``` maybe the matching the ```<nobr>``` I accidentally removed line 46. But it is misplaced.
I meant to write a protocol item to transmit this information, for zero-copy using anonymous mmap. Didn't get around to it, yet!
@ehelms No, I was just mirroring the candlepin attributes; I'll change from camel in glue/candlepin/pool.rb and subsequent uses.
Thanks for putting parents are this. It's much more readable.
This is wrong. What you should do is overwrite the ``getDefaultFormatter`` method
Is not really needed, but is there after some tests regarding the "overflow" problem commented in the Pull Request description.
We opened a thread in the list as well

https://groups.google.com/forum/#!topic/mozilla.dev.webapi/el6ORJNMB5c

What's your opinion about this issue?
Include an error message `raise ValueError('Target path is not a directory')`.
Your article should be wrapped in an article tag. The hierarchy should be similar to this:

html
head
body
header
  h1 Article Title
  nav
/header
article
 p Paragraph text
 h2 Secondary Title
 p Paragraph text
 h3 Third Title
 p Paragraph text
 ....
/article
footer
  nav
  small copyright
/footer
/body
/html
I know this is taken from `numpy`, but I'm not sure the answer to this: is the `fill_value` attribute used by anything other than the `filled` and similar functions/methods?  That is, is it used in arithmatic or `sum` or something?  If not, what do you think about eliminating it?  I've found this to generally be a confusing aspect of masked arrays the few times I've used them (that there's both `fill_value` and the arguments to the functions).
just to be clear, it still does not require a unit tuple by default if you give a string that is unambiguous (e.g. if unit=(None, None) ). So I left this section in but tried to clarify why they're treated differently.
IMO this one should be modal
This could be an ``else if``.
This code does not follow the coding standards.
Should default to an empty object instead of an empty array.
consensus, this looks good.
Can we use HEREDOC syntax here?
``DummyAnnotationWithImportedClass`` ? why ? I don't see anything about an imported class in this annotation.
Will be done :)
wanneer?
More specifically, how does this work with the numbering? Will it show the line number of the first identical entry, the last one, or is it arbitrary?
hu... ok, hum not sure I understand. 
Just the if statement, or the methods called inside ? 
because `this.add_drop_down_list();` might not exist exist on other subclasses...
```ruby
ENV["TURNIP"] = true
require 'spec_helper'
```
I'd love to see usage of this function, aside from the testcase.  I agree we should work on the API here and maybe we can also improve performance by somehow linking the recurrence exceptions to the master event. Need to watch out for mem leaks due to cyclic references though.


With "component base component" did you mean VCALENDAR base component, or something else?
You are right that detect is not the best name, but I'm stumped: cannot think of a better one.
Looks like this might be left over debugging code..
Please rename `amount` to `total_support` to go with the displayed name changing.
Agreed. I tried several versions of this but couldn't get anything to work. Since the views and things use the pre-instantiated product_details instance, I had to create the new one and monkey patch it in, but was failing for some reason. 

Also YES!!! I'm going to try to remember to submit a PR for product_details to add that.
Please change those lines to:
```
grants.sort(key=attrgetter('grantee'))
grants.sort(key=attrgetter('year'), reverse=True)
```
Calling ``len(result)`` implicitly uses the ObjectResults which fail because elasticutils assumes ``_id`` is an int which isn't true anymore. Changing to use ``.count()`` doesn't.
What gets passed is by default NOW() (UTC). If it failed yesterday, the date will be yesterdays. 

I see now, that the default "target date" should be today - 1 day
https://github.com/mozilla/socorro/pull/640/files#L2L38

Also, thanks to you spotting this I noticed that it's not a `datetime.datetime` that the procs want. It's a `datetime.date`. I'll fix both of these things.
ya, it is a little redundant.
orelse is fine, but a ';' would work as well
When ever you accept a host name you should also accept a port (`email.port`)
Can we remove netrateBool and netrateValue, and have the SyncManagers themselves parse the --netrate command line option when they're created?
Of course this can happen. `setParent` and `setPrefix` are public, so sure this case can be brought about.
And where is it made sure that the root cannot have a prefix?
How about `if (null === $this->getParent() || '' === $this->getPrefix() || 0 === strpos($prefix, $this->getPrefix()))` above?
Registering this one should be optional. The GetSetMethodNormalizer is broken (by design) as soon as you have a cyclic object graph (you have an infinite loop when calling getters), so forcing to register it is a bad idea (expecially as many people tend to use bidirectional relations in their entities apparently)
Correct, thanks
Yes. I was thinking about caching `getNumberOfColumns()` and `getColumnWidth()` results. It will add some complexity, and improve performance. I will check some large table benchmarks and decide if this optimization have sense.
Thanks!
you should also add them in the suggestions
@pborreli Thanks, fixed.

@schmittjoh +1 for OAuth. We will see this in another PR. Can you review this one ? And answer questions
this should be removed as this is done when we release, but a note in the CHANGELOG should be added instead.
Just do something like...

```js
var path = require('path');
var fs = require('fs');

var existsSync = fs.existsSync || path.existsSync;
```
Instead of new-style vs old-style/legacy, can you call them class-based vs function-based parsers? Legacy implies that it's going to go away, but we'll want to keep function-based parsers since not all log parsers need to be stateful.
Inline assembly does not work with MSVC 64-bit. The macro ```YieldProcessor()``` compiles to the same instruction at works both for 64 and 32 bits. However the [MSDN Documentation](http://msdn.microsoft.com/en-us/library/ms687419%28v=vs.100%29.aspx) says this requires at least Windows Server 2003 or Vista.
Not related to this review, but check out the new C++11 std::unique_ptr if you haven't already: it's a really neat replacement for both boost::scoped_ptr and boost::scoped_array.
Not consistent with line 45.
should this be 1 instead of 0?

Also, can you add a check to confirm that the warning is the one you expect, for instance
expect(messages[0].message, contains('ignored script tag'))
No worries; for others: Murali and I have been pairing on unit tests, and he's been catching up on some reading. This is all in the process of getting refactored.
As I didn't know what name to give to these parameters, I've taken thos in the Ember.compare function, see: https://github.com/emberjs/ember.js/blob/master/packages/ember-runtime/lib/core.js#L148
I think the problem is in the inDOM state for destroyElement. The comment says that the view should be transitioned to "preRender" state but it never happens.
Maybe I am missing something, but how will this help since _control will go out of scope as soon as Python exits this scope?  In which case _control will be gc'd anyway.
something it is even better to do the following, if the design is adapted

if attached foo as l_foo then
   l_foo.do_something
else
   check foo_attached: False end
end

Otherwise if one can really not avoid "check" ... then use only the "check /= void then ... end" pattern, and always add the associated precondition or invariant assertion that prove in the code this "check" assertion.

But in any case, if you use "check then end", there should always be a precondition or an invariant related to it   (this is recommended)
Otherwise in practice, it appears those "check then end" cases ... are violated due to misunderstanding of the code during migration to void-safety.
I'd recommend adding validation here. At the very least roundtrip it once to verify it contains to syntax errors. This also clears out any whitespace or other oddities.

Ideally it would also walk through and validate the contents, but that could be added later.
I don't understand why do you need this because it is already manipulated in https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/window_manager.js#L1604 although it is not perfect code path.
You need a .bind(this) on this line
Currently it is failing and reporting an error to the console.
I think it is better to name this variable as 'numFriendsProposed'
changed to pass the linting
Why are we returning 2 contacts? Shouldn't we keep returning 1 but replacing the enrichedContact or savedContact in the getContactById method?
what about 'select-all'?
Yup you are right, when we started to work, just with downloading wasn't enough cause we were having weird attribute values, with latest patches in platform it's not necessary any more, so simplifying as you say.
It's a hack for avoiding CSS styles applied for tag "SPAN". This issues has to be reviewed because CSS is, sometimes, a mess (IDs styles based instance of creating CSS classes,no HTML5 markup, apply global styles when it is not necessary...). We have to review CSS and how to make it more clear.
Nit: empty line above the comment + 2-space indentation please
you don't need the extra (( ))
Change it by "Resaltar área redibujada"
cause when the button is pressed, we need to retrieve the data from the event, in this case the target (the button itself) and get the specific data for the callback
Services.tm.currentThread?
the uuid can be the pk, no reason why not.
I removed the two require statements from this file. Instead I inserted 
conditional loading into the controller.rb, like this:

         if (config.persist_mode == :mongo)
           logger.debug "Using Mongo plugin"
           require "project_razor/persist/mongoplugin" unless 
ProjectRazor::Persist.const_defined?(:MongoPlugin)
           @database = ProjectRazor::Persist::MongoPlugin.new
         elsif (config.persist_mode == :postgres)
           logger.debug "Using Postgres plugin"
           require "project_razor/persist/postgresplugin" unless 
ProjectRazor::Persist.const_defined?(:PostgresPlugin)
           ...

On 2012-10-24 18:19, Daniel Pittman wrote:
>
> In lib/project_razor/persist.rb:
>
> >  require "project_razor/persist/controller"
> >  require "project_razor/persist/mongoplugin"
> > +require "project_razor/persist/postgresplugin"
>
> Razor should probably load these dynamically, based on the chosen 
> engine, rather than statically loading them all.
>
> You can just treat them like any function call in Ruby, so doing in a 
> conditional out of the controller is fairly reasonable. (Albeit slow; 
> we should try not to put a call to |require| in a hot path.)
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/puppetlabs/Razor/pull/224/files#r1930430>.
>
怎么改？我倒是的确觉得老师这么叫不大好，不过我又不想在这里就出名字。撤退被修改，我是觉得按照她的性格不会这么说而已。
It seems like this doesn't use any object state inside `AliasSet`. Could this be feature envy? What about having a method inside `Mapper::AttributeSet` that does this work and returns the index?
了解、直した:+1:
Why not JSON? Isn't json easier to parse?
What is t? variable names should be descriptive unless they are loop control variables.
what is this change good for?
No comment. :D
I wouldn't.  I am just trying to suppress some worthless and confusing info output here.  I'm still not happy with it, as it could hide real errors, which will make debugging customer failures easier to fix.
I've only now found a case where this is actually useful.

Redis uses the type of "current_connections" and instance_type of "clients", so that would be "current_connections-clients" and "current_connections-slaves"

That actually makes more sense and is more usable than "gauge-clients" was.

I'll re-think this one
well, first, adding the spaces around the ternary operator makes it more readable :)

And the syntax I suggested is consistent with other places in composer
this is confusing.
What is the purpose of this alignment?  Is it just bundle alignment?  I'm unfamiliar with the ARM sandbox model
Let me check if it's still needed, now that BaseNotebookManager is back to
NotebookManager.

Thanks for all the work. It's great.

Benjie


On Fri, Aug 10, 2012 at 8:11 PM, Brian E. Granger
<notifications@github.com>wrote:

> In setup.py:
>
> > @@ -80,7 +80,7 @@
> >
> >  def cleanup():
> >      """Clean up the junk left around by the build process"""
> > -    if "develop" not in sys.argv:
> > +    if "develop" not in sys.argv and "egg_info" not in sys.argv:
>
> Although, can you submit a separate pull request against ipython/master
> for this change. I want to get other people to review it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ellisonbg/ipython/pull/5/files#r1356491>.
>
>
Fix brackets ;)
I think something is not right with [installation instructions for master branch](https://github.com/gitlabhq/gitlabhq/blob/master/doc/installation.md), because there **indeed** `GL_BYPASS_UPDATE_HOOK` is not used...

```bash
sudo -H -u git git clone -b gl-v304 https://github.com/gitlabhq/gitolite.git /home/git/gitolite
sudo -u git -H sh -c "PATH=/home/git/bin:$PATH; gitolite setup -pk /home/git/gitlab.pub"
```

it will create `~/.gitolite/` and generate hooks, nothing from `pu` branch is used so there isn't any place with `GL_BYPASS_UPDATE_HOOK`

while following [stable installation](https://github.com/gitlabhq/gitlabhq/blob/stable/doc/installation.md)
`sudo -u git -H sh -c "PATH=/home/git/bin:$PATH; /home/git/gitolite/src/gl-system-install"`
it will create thoose hooks in `~/share/gitolite/hooks/`
Why is there the limitation that Linux can only have one core?  Why limit it from having 3, 5, or 10?  Where does this complicate the code?
If we go down this route, it would be better to have `/demos/index.html` and then put all the demos in that directory.
That's exactly what this is doing.

```ruby
  Rows.new(self, locators)
```

If you specified an `:index` in the `locators`, it would only grab that one.  If you did not, `ElementCollection` keeps grabbing all of them.  So after the above executes, you have all of the rows.  After that, then it applies the other locators and only includes those that match with a `Enumerable#select`:
```ruby
 Rows.new(self, locators).select { |row| match_all_other_locators_besides_index?(row, locators) } 
```
product:
  class: sfDoctrineRouteCollection
  options:
    model:                product
    module:               release
    prefix_path:          /release
    column:               id
    with_wildcard_routes: true
fixed in @afe91b22270d2d086ca4136136d95a5bd40cb818
What if `this.options.returnEvent` is undefined? Are you relying on Backbone handling an `undefined` argument in a particular way?

Recommend performing an explicit null-check on `this.options.returnEvent`.
We need some JavaDocs here.
This is almost right, and it is very simple and straightforward.. The trouble here is that we're specifically enhancing weiqi code to anticipate the needs of the tests.  There is nothing wrong with this, but my instinct is that this code belongs in the test suite. 

e.g. in casper, Casper.options.clientScripts you can inject an arbitrary set of scripts into the running DOM. We can, just as in the above code, set up event hooks that trigger DOM event percolation from the analogous Backbone events (If I understand, that is what this code does).
I think [nsIDOMParser](https://developer.mozilla.org/en/nsIDOMParser) is the right way to go about this.
This file renaming is really weird! find-tests.js becomes namespace.js.
could you please export get, set, ... as they were before and add just another export `Branch` instead.
Should signatures be unique? Is it okay to use `ACCOUNT_CANCEL` for two different events?
You can ignore me :)

I was confused by a link n IRC, which I had already responded too and then the link loaded this line (instead of what you were actually talking about)
'aIndex === undefined' should be enough, or?
Opening bracket at the same line as the function definition.
Those three lines bother the heck out of me.  It looks like `@seen` is state that is used by, eg, `list_format_tree`, but it isn't passed around, it is an implicit global.  Is that actually true?
Why is this here? It seems unrelated to the rest of this change.
Thanks. That's actually what I did on my fork:

    option_boostrap = [python.encode('utf8'), bootstrap, '-d']
            if options.config:
                option_boostrap.extend(['-c', options.config])
            
            
            cmd_bootstrap =' '.join("{0}".format(iter_el) for
                                    iter_el in  option_boostrap)
            
            if subprocess.call(shlex.split(cmd_bootstrap.encode('utf8'))):
                    logger.error('Failed to bootstrap.')
                    sys.exit(1)
            
            # call buildout
            if options.config:
                subprocess.call(['./bin/buildout', '-c', options.config])
            else:
                subprocess.call(['./bin/buildout'])
Yes, it is called a `NodeList` -- https://developer.mozilla.org/en-US/docs/DOM/NodeList

You should be able to loop over it using a `for` loop.
yeah yeah -- I know ;)  but some times art is above some tools whining!
The correct indentation are 4 spaces
I think that this is only needed for `testFactoryUsesDefaultAdapter` and then is not necessary set this in the setUp()
This is only to test like a HTTP client. Without that, the framework use always console because we are in CLI.

In AbstractControllerTestCase, there is :

// we use our own override only if we want http simulation
         if(!$this->useConsoleRequest) {
                $consoleServiceConfig = array(
                    'service_manager' => array(
                        'factories' => array(
                            'ServiceListener' => 'Zend\Test\PHPUnit\Mvc\Service\ServiceListenerFactory',
                        ),
                    ),
                );
                $appConfig = array_replace_recursive($appConfig, $consoleServiceConfig);
            }
            $this->application = Application::init($appConfig);

Flag $useConsoleRequest provide possibility to switch in console or HTTP mode.
Why don't put this vars in TestConfiguration.php?
Its better to strip these once when you put them into listOfWords, instead of stripping them every time you use them.
Good point, moved into own folder, as well as `OwnerManager`. With later refactoring, an Solr indexer probably will go there too, but not yet =)
else if ;)
Please notice I got rid of conversion of the key to underscores... how many modules it is going to break? :)
This require_once is useless so please remove it
Again, this is just coding style so I'm not going to block, but this if/else could be reduced to:

propertyToSearch = (valuesArray.length > 0) ? 'id' : 'value';
please add the leading ``\`` to have a FQCN or rely on the use statement
I think "(as ORM)" doesn't really add anything to this sentence...
Shouldn't we replace the `@...` with the contents of `...`, that is, append to newargs? (and filter out the `@..`s)
By deleting all those and creating them, won't it break existing Banner Instances out there every time we add a locale?
It turns out data: URLs are always treated as unsecure content in older versions of IE (I think before 8). If that's a concern here you might have to do this as an external image, but if IE7 isn't of great concern then an embedded image is better anyway.
forget*
Is this just for showing an icon? A `<span>` would make _more_ sense, but can't we just attach a thing with CSS to the button?
Changed the labels! And inserted the correct markup. I swear, when I did it the first time it was all wonky, but this time when adding ul tags, it fixed itself. Er...yay?
yes that's not safe, alas, the translated text should be assumed unsafe content. you want: 

<%= ts("in") %> <%= link_to_tag(@tag) %>

(if you could fix the other one too that would be great)
It's fine, I share a bit of the frustration with creating command structures with this Document object. I have some ideas for alleviating some of that, I think I will add those when I merge your pull request. Its a good discussion to have though, if we can find a different solution around this Document object.
Why not filter all RGB channels?
your bundler file seems correct, for more info on how foreman uses it, see http://theforeman.org/projects/foreman/wiki/Bundler_groups.

Foreman has two type of settings, one that is used for application boot, and other that can change while the app is running.

the first one, is located at config/settings, and it get initialized at the application boot (see config/boot.rb)

so this make it pretty easy to wrap the require line with an if statement... 

hope this helps
There's a weird bug where excluding username and password from fields (or adding it to exclude_fields) doesn't work for this form, because it's based on the usereditform from django admin.  This was the offered solution online - I'll try to find the reference.
double  space
Shouldn't logging happen before fixing the issue ? (ie. switch the two lines above)
I've changed in this module and all the solutions packs.
The module is XML::DOM. Parser is part of that.
I used curl -T in previous revisions of the code because I couldn't get the restclient.put method working for some unknown reason. Did you try using restclient here?
Do we really need/want to log this in production? Doesn't really matter to me. If you have it a debug, it'll just log in dev mode. info logs in production (by default).
oh crap, canSprint misses () it has to be canSprint(), wait a sec, I will change it
very good (`str/repr`). It should be unit as it's one unit (it should be `unit` in `NDData` as well - will change this in `NDData` once this is all consistent. 

we should also be able to access the quantities unit/value: I suggest `q1.value` and `q1.unit` , similar to `nddata.data` and `nddata.unit`.
just remove it.
don't we need to check if our transport can do JCR_SQL ? jackalope-doctrine-dbal can't afaik. the same actually holds for xpath queries. we should throw InvalidQueryException if the transport can't do that language.
This will segfault if the property is not found.

`atoi` also doesn't report errors.  `strtol` doesn't exist on Windows, so OpenSlide uses `g_ascii_strtoll` and `g_ascii_strtoull` for error-checking int conversions.
without this filter all repos are gonna be listed on search results even your own repos.
Do you find this better from user perspective?
Thanks! 8d8b5e09dd9ad5db786c76b8b41891b1b307578b
Is this the schema for all types of resources?
Do we want any extensibility for this when we're adding other stuff to the search index?

Also, I think this could benefit from some abstraction. (Shouldn't be part of this PR though)
It would be good to document the accepted values here.
Wouldn't it be better to have 2.9.x specific values inside this profile? (and maybe have the 2.9.x profile active by default) I'm guessing there is a problem with doing so :)
Think this should be after the Channels link since they are somewhat related.
I wonder if `'/'` should be a default internally?
if check here too
revert changes here please :)
I'm referencing the line for:

    postgresql_port: <%= node['postgres']['port'] || 5432 %>

not the user/password.
I remove default value of ip_address field.
Ensures a single slash instead of double. Same technique is applied in various places throughout CI codebase - just being consistent here.
You're right, $fp seems to be a more accepted name for a file pointer. I'll change it.
I do, that was the fix for the classes I didn't 100% copy over from my last commit :P.
лучше было бы проценты перевести в количество заменяемых ячеек :)
during mouse interaction, IF we just stopped resizing (i.e. we let go of the mouse button), we remove the document-level listener functions that are necessary while doing resizing. They're named functions, so all we're doing is removing the listener on document (the functions themselves stay available when we need to re-resize later on)
Is this better, @jamill? It makes the tests pass.
Just by reading this enum I can say I like the way you designed it :P
can you also check that the data a 4 times smaller and that the new sfreq is correct?
My purpose for this method was making whole-brain plots illustrating the evolution of the signal over time. 
 - Is there already a better way to do this?
 - if not, a proper `resamples()` method might in time be added to the crude `bin()` method?
I love that you took the time to update tests.
We cannot use `.new` with a block because it may not be supported across different ORMs. We can do `resource_class.new.tap do` instead.
var context = null;
why removing the index entry ?
You should add one `=`
There should be no space between `(` and `$loader`.
you need to document somewhere that these services **must** be public ones
This should be:

        $this->providerKey
    );
这里不使用<var>$remote_addr</var>变量，而使用<var>$binary_remote_addr</var>变量，将每条状态记录的大小减少到64个字节。
This should be `Clearance::Constraints::SignedInConstraint`. How about changing that to just `Clearance::SignedInConstraint`?

Alternatively, `include Clearance::Constraints` at the top?
These transfer* methods do not seem to refer to the END_FRAME_MARKER, which seems like a bug?
"file" isn't a very helpful name for this field, how about "basePath"?
Где это тут `const T*&` вылезет?
В смысле { smth } ?
Dialog всегда называем же и ui тоже.
`.pics`
Ahhh, entiendo, me parece que no es posible, por lo menos no de la misma forma que lo hace Form (para la único que sirve el using en Form es para no olvidar cerrarlo)

Solo no entiendo en que es diferente el `template normal` del `templateGigante`, creo que serían iguales.

Lo que se puede hacer es un `if` clásico, pero no me gustaba porque tengo que repetir el nombre de la acción y controlador:

```
@if (Html.HasActionPermission("GenerateOrder") {
    //template donde se repite "GenerateOrder"
}
```
Lo debe haber puesto Web Essentials. Luego lo investigo. Gracias.

2012/10/20 Alpha <notifications@github.com>

> In source/CommonJobs/CommonJobs.Mvc.UI/CommonJobs.MVC.UI.csproj:
>
> > @@ -143,6 +143,9 @@
> >      <Content Include="Content\DragAndDrop\DragAndDrop.js" />
> >      <Content Include="Content\EditCommon\icon-edit.png" />
> >      <Content Include="Content\EditCommon\Suggest.js" />
> > +    <Content Include="Content\EditEmployee\EditEmployee.css">
>
> Creo que este archivo no debería ser parte del proyecto.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/203/files#r1897738>.
>
>
Doesn't the use of "Debian testing" risk breaking (or force upgrading) wheezy installs once it becomes stable ? Wheezy installs (that do refer to "wheezy" and not "testing" in the apt config) will become stable, but it seems this will pull upgrades from the new testing.
I Can do it :) 
That said, this method is a copy paste of the code used in others binder subclasses (CPTextField, CPColorWheel, CPCheckBox ...). We should have it in CPBinder and create 2 sub-methods (that can be subclassed in specific binders) for 1. Applying the regular value on the source or 2. Applying the placeholder value.
I'll open an issue for this.
I don't think this check is necessary - a state transfer put should have the CACHE_MODE_LOCAL flag, so the tx shouldn't have any modification anyway.
I don't think you need to keep the 'original' value.
I think this means that a `put(k, v, 0, TimeUnit.SECONDS)` will use the default lifespan as well. Is it intentional?
Yes, it would require a `Boolean` param.

I know you mentioned there's other similar fields, but I think they also look a bit of a kludge. I would have preferred a single configuration option (a Boolean would have been fine with the right documentation of what null means vs true/false) and then let other components figure out the actual setting based on the combination of other configuration options.
not a big one, but this should be logged as trace as it happens on a per request basis. Debug is used for lifecycle events..
http://docs.jboss.org/process-guide/en/html/logging.html
There will be decoder for each connection created, so this is probably not the right place for this. If anything, I'd put it in the HotRodServer class which is singleton.

Alternatively, this code was set in place to avoid ending up with asymmetric clusters which used to be an issue. We should now be able to start caches on the fly without problems. But it's probably too late in the 5.1.x series to remove this limitation (we'd have to test it thoroughly...etc).
On 2012/08/29 3:48 AM, Michael Droettboom wrote:
> In lib/matplotlib/figure.py:
>
>> @@ -1424,16 +1424,15 @@ def tight_layout(self, renderer=None, pad=1.08, h_pad=None, w_pad=None, rect=Non
>>
>>          from tight_layout import get_renderer, get_tight_layout_figure
>>
>> -        no_go = [ax for ax in self.axes if not isinstance(ax, SubplotBase)]
>> -        if no_go:
>> -            warnings.Warn("Cannot use tight_layout;"
>> -                          " all Axes must descend from SubplotBase")
>> -            return
>> +        subplot_axes = [ax for ax in self.axes if isinstance(ax, SubplotBase)]
>> +        if len(subplot_axes) < len(self.axes):
>> +            warnings.warn("tight_layout can only process Axes that descend "
>
> I think the word "descend" here is a bit confusing. I think the more
> commonly used term in OO is "inherit". If there's no objections, since
> this is already merged, I'll just go ahead and fix this directly on master.

I agree; I noticed the same thing, but didn't think to correct it.  Go 
ahead if you have not already done so.
I agree - I will rework the code so the default is 0.
FYI: All tests which use pyplot should either be an image test, or use the cleanup decroator.
Is there any reason you didn't make this a `"""` docstring?
This sleep (if needed) should be elsewhere. If we can't find a suitable wait for now (either after enabling or before connecting) then the sleep should go in the tests between the two calls.
Imports should be grouped in the following order:

    standard library imports
    related third party imports
    local application/library specific imports

So please put the datetime import first
Вообще ведь попапу всё равно где именно он в куске дома, к котому он относится.
Может просто это класть в конец самого вернего элемента, к которому он относится?
It's only for the tests - we don't mind the extra code there:

    for (var p in OpenLayers.XBrowser.cssCache) {
        delete OpenLayers.XBrowser.cssCache[p];
    }
I think clojure 1.4 supports `(integer 4)`, by the way.
This is only used from `Pusher`. I don't see why we just can't have just this method and merge the code from `find_or_initialize_version_from_spec` in here.
@jsloane makes total sense, as you're saying it is probably best to leave it in here.
@jsloane The reason I am asking is because jQuery is going to remove `$.browser` in their next version [1]. They already deprecated it since version 1.3 [2].

You're also right about the fact that Modernizr is to detect certain CSS3 and HTML5 features, however, it can also be used to see whether a certain bug is present or not. Maybe for us, `jQuery.support` would be a better fit [3]

[1] http://blog.jquery.com/2012/06/22/jquery-1-8-beta-1-see-whats-coming-and-going/
[2] http://api.jquery.com/jQuery.browser/
[3] http://api.jquery.com/jQuery.support/
Can you split this up on to multiple lines?
@jsloane can we avoid the change to this line?
Couldnt you break the the loop once you got true from the recursion?
Also, false is returned if the desired parameter is in a child node
Have removed these changes
there should be no indentation nad docblock comments should start with /**
Makes sense. Let me see what I can whip up.

In as far as using the same base importer class, I would think that the similarities between the two are far too few to have a base importer class?
o I only did this to make tests pass, was ttly going to comment on the appropriate behavior here myself on your future code review LOL.
but as it stands, I recreated the behavior in mock_adapter (for tests).
for the other adapters, just return true if the enabled attribute is nil.
since set_experiment_enabled is only called internally, we'd only be passing booleans in so we shouldn't have to worry about random strings..

& no this does not rely on enabled?==true; see new definition of enabled? in ab_test.rb
I'm not sure this is the best place for the assignment.
Why is this call made here?

It seems to me that it would be called from __wt_connection_open(), just like __wt_cache_create() (which makes me think that __wt_cache_create() should  be merged with __wt_conn_cache_pool_config(), why are there two, differently named, cache creation functions?)

That said, I don't think the lines here are well-defined, it's been awhile since anybody looked at this and tried to make a coherent picture out of it (for example, why is __wt_cache_create() getting passed a connection handle, not a session handle, got me), but I don't understand why you made the decision you made.
They're in flux but yes, they should be formally defined.

No brackets on simple tests is a bad habit (I do find it more readable, but it's probably better to avoid anyway); I can fix it up.
Are you sure ``function ($result) {    ...n is_string($result); }`` has the correct type as ``object<Closure>`` is not a sub-type of ``array``?
Is it possible to add a ``@param`` annotation for parameter ``$event`` which defines the array type; using ``array<SomeType>``, or ``SomeType[]``?
Are you sure ``version_compare($install...Version, '5.3.4', '>=')`` has the correct type as ``*`` is not a sub-type of ``boolean``?
Stupid question: who calls this?
I do like the way it ended. I assume that this delivery is going to fuck him up.
Also, perhaps this should read "make can take falsey values for content" since we'd like to handle `''` as well.  Some extra test cases to that effect would also be nice.
more consts? will these be created each time you fire this function?
What am I doing wrong here? Trying to get the date.day.to_s to print out but its not. :(
I loved that line! Y U NO leave it there?
Need to convert numerator or denominator to a float.
Just for testing. Will remove
I would not use id, because there might be a conflict with some other XHTML id. So, use class (`class="panel {{ id }}") or prefix the id, like `id="panel-{{ id }}"`.
No. This is not good. Don't copy bad example from horoscope panel. :-)

Use lxml Python library and Xpath to extract information. See my comments on pull request for horoscope panel.
Why attaching post data again? This is not good. You should search over posts, and then once you find a post, you find also comments. (You can limit jQuery selector to search just under some other element, the post you have found.)
I think that `panel in panels_with_dependencies` is nicer than `typeof panels_with_dependencies[panel] != "undefined"`.
you can ask for a specific sdk platform, version, and variable like this:

```
$ xcodebuild -version -sdk macosx10.7 Path
/Applications/Xcode44.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.7.sdk
```

I'm not sure what the behavior is for all versions of xcode, but for 4.4 it will give you an actual SDK path for 'macosx' instead of the system (sdk-less) path:

```
$ xcodebuild -version -sdk macosx Path
/Applications/Xcode44.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk
```

This path can be deceptive, at least at the moment, as the version of xcode for 10.8 runs on 10.7, but still returns '10.8' as the current version when a version string is omitted.
instead of `.` maybe this should be `source`, `.` does not work with zsh but `source` works with both.
oh, so glad to see that this is using a deferred now! i'd have opened a pull request myself on that in the next day or two :)
Yeah, I must have been holding on to a partial lock without realizing it.
 I switched it all to non-ref-counted locks and verified the partial lock
behavior with extra debug outputs (that are not in the commit).


On Thu, Nov 1, 2012 at 5:30 PM, Moxie Marlinspike
<notifications@github.com>wrote:

> In src/org/thoughtcrime/redphone/call/LockManager.java:
>
> > +      case INTERACTIVE:
> > +        setLockState(LockState.FULL);
> > +        disableKeyguard();
> > +        break;
> > +      case IN_CALL:
> > +        //TODO(Stuart Anderson): Use proximity wake mode during calls.
> > +        setLockState(LockState.PARTIAL);
> > +        disableKeyguard();
> > +        break;
> > +    }
> > +  }
> > +
> > +  private void setLockState(LockState newState) {
> > +    Log.d("LockManager", "Entering Lock State: " + newState);
> > +    switch(newState) {
> > +      case FULL:
>
> "Wake locks are reference counted by default."
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/45/files#r2012265>.
>
>
Emoji Cheatsheet ist toll, was? ;)
can we not use something like 

```ruby
IntercomRails::ScriptTag.should_receive(:generate)
```
elephant-bird/build.xml:100: The specified destination is a directory
I am mostly thinking about DEFAULT_ENDPOINT_SUB and the likes, since they are used elswhere

I think using a constant for TIMEOUT='timeout' is overkill though, because it will never change and is used in a single spot
Are the above methods really needed? Why not just set the property directly?
I was shoddy of changing the interface mainly ;-). But yeah, it doesn't really matter so I'll change the signature instead.
Imports should go at the top of the file.
small change, a bit faster, I expect

h = np.empty(n)
h.fill(epsilon)
can this file be removed?
Seems the `toString()` function is using a wrong indentation (maybe tabs instead of spaces).
As we discussed, some sections are used in archipel-core.
search self.configuration in archipel-core module, and keep used section/tokens only
Fine with me.  I think I just brought this over from the dox in SBProfile.cpp, but I agree a more directed explanation (with instructions as you have done) is very useful here at the front, front-end. Thanks!
On Sep 21, 2012, at 5:26 PM, Mike Jarvis wrote:

> In galsim/shear.py:
> 
> >  class Shear(object):
> > +    """
> > +    @brief A class to represent shears in a variety of ways.
> > +
> > +    The python Shear class (galsim.Shear) can be initialized in a variety of ways to represent shape
> Is galsim.Shear working in doxygen now? We used to need galsim.shear.Shear, which shouldn't be necessary anymore, but I thought Rachel had a comment recently that the links with just galsim.Shear were still not working. Anyway, worth checking this to see if it's ok on this branch.
> 
> 
Yeah, I couldn't get galsim.Shear or just Shear to work.  This confuses me because there are a bunch of other classes where we put the name (not even with the galsim.) and doxygen does it automatically.
This last line isn't necessary anymore, is it?  (I think this was for when the doc wasn't in random.py.)
There is also `img = galsim.fits.read(file_name)`.  This should go either here or in section 5.
ugly indenting here, can you fix?
They do indeed, fixed at 2576220
can this in helpers/dashboard_helpers.rb? (or users_helpers.rb if we use users controller)
If this will be used outside of the dashboard then put it in application_helpers.rb

Theres no route that corresponds to this so it shouldn't be a controller and clutters the controller
~/.brooklyn/brooklyn.properties is ignored. You can define locations either by editing the .yaml config file or by making REST calls to /v1/locations.
Too many spaces. ;)
whoa *mind blown* didn't know this API existed.
Whats your thoughts?  Standardize on one process mgr?  We should discuss what to support for service mgmt.
Nice catch!
Updated.
I don't get why we would like to have this? if it's a 200, we don't care about the value returned, right?
Should the test verify that the results contain "Mountain View" in them?
same here.  btw you may be able to refactor a good bulk of this since there's a lot of duplicate code?
I guess I don't get it all yet. 

Are you saying that the way it's defined here means the 2.1.* tag which points to the master branch and dev releases, and what I intend to do is to point to the 2.1 branch which is the stable release? How should I point to the latest stable 2.1 release?

Or are you saying that the SE is meant to always use latest commits and not as a starting point for new projects built on stable releases?
this needs to append the 'sql_class_where_clause' at the end, look at how the SQL_UNION_GEOM template is used in stats_query for the sake of consistency
HI Andreas

Will speak to you on Monday, why is build in each individual directory.
Does not npm install, install all files in build/Release drectory

Regards
Habib

On Fri, May 25, 2012 at 10:24 PM, Andreas Botsikas <
reply@reply.github.com
> wrote:

> > @@ -5,34 +5,56 @@
> >      'dependencies': [
> >
>  'webinos/common/manager/certificate_manager/binding.gyp:certificate_manager',
> >        'webinos/common/manager/policy_manager/src/binding.gyp:pm',
> > +       'webinos/common/manager/keystore/src/binding.gyp:keystore',
>
> Do we use gyp for Android? Since we do load the module in windows, we can
> provide the dummy implementation for the time being and have it working for
> linux since the work is done.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/webinos/Webinos-Platform/pull/40/files#r884389
>
Aha, it makes much more sense in that light; hadn't seen the context specifier before
Oh, cool! That'll be fine as long as they're inserted in the same order.
should be owner
the other way was so much sleeker :(
Revert this part.  That proc does exactly what you repaced it with.
unicorn не ставился
Pai este scris acelasi lucru 2 linii mai jos in comentariul functiei.
You can use `Process.uid == 0`.
I think this will always result in an empty email address (if the field is empty)?
Could you elaborate on how it makes difficult to debug?
Is it a infusion community style or a specific problem which people face when debugging this code?
Perhaps we should make the function take a tab rather than gBrowser. I wanted to have a name that discouraged non-command use.
This should probably be a comment, not a docstring.  We should actually put a docstring that tells what the function does
I don't use them at this moment, but they are parts of user's profile. So, i decided to have them just in case.
Technically, :dynamic is meta that annotates the var.  There is some documentation here: http://clojure.org/vars
The labels are reassigned inplace in line 106, so I thought another np.unique() was needed.
We lost that comment in the process, and I think that it was useful. Could you please adapt it to your current version.
+1
``sklearn.neuralnet``?
good catch - thx
I think I would rather transpose here instead of doing it in all the other places.
I'm not sure about the type here. Are there other things besides that list of sockets that a person writing a hook here might be interested in? Will there ever be? If so, I'm going to have to go through a deprecation cycle in order to change this method without breaking user code. Perhaps a more future-proof way to do this is to define an opaque datatype for the arguments, i.e.:

    , startupHook :: Maybe (StartupHookData m a -> IO ())

We should then be able to make more arguments available to these hooks without going through a deprecation cycle.
No problem, it's xml
How do I test for a missing object.d file when it's not missing during testing? :)
There should be no tab if we stick to DMD src style, or there was a particular reason to add it?
Changed to `suppressed_output` and saving it off to an attribute; `@suppressed_output`.
The Ti docs say that Resources/<platform> will be put wherever the stuff in Resources goes and that the other platform folders will be ignored. As for the the name and location of the assets dir I think it depends on the platform. I would have preferred to use "Resources" instead of "assets" but I don't see any benefits that outweigh the extra work.
For documentation for the Studio user I don't see a point since they won't care what's in the bar file. It's our code that needs to know.
http://docs.appcelerator.com/titanium/2.0/index.html#!/guide/Supporting_Multiple_Platforms_in_a_Single_Codebase section "Platform-specific resources"
the else close should be logged too
I find this pretty weird.. but since it's safe and fix one problem, why not
Better than "now", speak about the "version 1.2"
Removing this changes behavior, as it will attempt to load the object repeatedly if find_by_id returns nil. If you wish to change to an attr_accessor, you will need a separate @loaded variable.
I think this also means it will now be compressed when it wasn't before.  Correct?  Could that cause any issues?
Possibly, but they never have done... Can open a separate issue for that if you like
Shouldn't this just be a break?
I remember, it was a patch from @Mossop because a problem with OS X, but it was only during the start up or something like that.
Yes, I didn't think about unified in bootstrap but just in the other modules.
What about add this to function to `url` module?

Wonder if it's better use XMLHttpRequest approach, or the "channel" one – with the proper encoding and everything. Due the past experience with OSX, could be worthy using the channel, maybe. @Gozala, what do you think?
small issue - yoda code - backwards reads this does.  putting constants to the left of == is holdover from the c null pointer days.  even if typeof returned null or undefined, putting it on the left has the same effect.
Ça sa sert que pour le dev nan ? Si oui met le dans group :dev.
Поехала табуляция.
Use equals with strings in java
Use List methods
@raydavis would it make sense to have this in :development and :production group only?
I like how cleanly this still nets out in the tests.
This is exactly the reason why I intentionally did not add doc blocks.
This is the same as
~~~clojure
(or (and (= 2 (apply max ma)) (= c 3))
    (= 4 (apply max ma)))
~~~