v8.4: Fixing vm_compute bug #2729 (function used to decompose constructors
did not handle let-ins and was wrongly specified). Thanks to Pierre
Boutillier and Pierre-Marie Pédrot for pointing out the source of the bug.

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15028 85f007b7-540e-0410-9357-904b9bb8a0f7
v8.4: Fixing bug #2732 (anomaly when using the tolerance for writing
"f atomic_tac" as a short-hand for "f ltac:(atomic_tac)" for "f" an
Ltac function - see Tacinterp.add_primitive_tactic).

More precisely, when parsing "f ref" and "ref" is recognized as the
name of some TACTIC-EXTEND-defined tactic parsable as an atomic tactic
(like "eauto", "firstorder", "discriminate", ...), the code was
correct only when a rule of the form `TACTIC EXTEND ... [ "foo" -> ...] END'
was given (where "foo" has no arguments in the rule) but not when a rule
of the form `TACTIC EXTEND ... [ "foo" tactic_opt(p) -> ...] END' was given
(where "foo" had an optional argument in the rule). In particular,
"firstorder" was in this case.

More generally, if, for an extra argument able to parse the empty string, a rule
`TACTIC EXTEND ... [ "foo" my_special_extra_arg(p) -> ...] END' was given,
then "foo" was not recognized as parseable as an atomic string (this
happened e.g. for "eauto").  This is now also fixed.

There was also another bug when the internal name of tactic was not
the same as the user-level name of the tactic. This is the reason why
"congruence" was not recognized when given as argument of an ltac (its
internal name is "cc").

Incidentally removed the redundant last line in the parsing rule for
"firstorder".

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15042 85f007b7-540e-0410-9357-904b9bb8a0f7
v8.4: Removing redundant entry int_nelist and removing extra space when
printing occurrences list.

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15045 85f007b7-540e-0410-9357-904b9bb8a0f7
v8.4: Yet another subtlety with bug 2732: when several grammar rules of a
TACTIC EXTEND block possibly parse the stand-alone name of a tactic,
then only the first rule must be registered in the atomic tactic table
so as to be consistent with what happens when the tactic is invoked
directly via its parsing rules and not via the interpretation of a
reference in the atomic tactic table. Concretely, this affects TACTIC
EXTEND blocks of the form

TACTIC EXTEND foo
  [ "bar" tactic_opt(tac) -> ... ]
| [ "bar" constr_list(tac) -> ... ]

where both rules parses "bar" alone but only the first rule must be
registered in the atomic table,

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15047 85f007b7-540e-0410-9357-904b9bb8a0f7
Arguments/simpl: allow ! even on non fixpoints

It is now possible to tell simpl to unfold a constant
that hides no "match" but is applied to concrete arguments.

Arguments id _ !n.
Goal forall x, id x = id 2.
intros; simpl.

x : nat
========
id x = 2

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15050 85f007b7-540e-0410-9357-904b9bb8a0f7
Fixes bug: #2692 (Arguments/simpl off by 1)

simpl was accessing the reduction stack at position n when
the length of the stack was exactly n.

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15051 85f007b7-540e-0410-9357-904b9bb8a0f7
Bug 2709: Duplication in coqdoc index entries

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15054 85f007b7-540e-0410-9357-904b9bb8a0f7
v8.4: Hopefully complying with camlp5 < 6.00 syntax

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15056 85f007b7-540e-0410-9357-904b9bb8a0f7
v8.4: Continuing r15045-15046 and r15055 (fixing bug #2732 about atomic
tactic arguments of ltac functions).

Added support for recursive entries in ARGUMENT EXTEND, for right-hand
sides of ARGUMENT EXTEND raising exceptions and for right-hand sides
referring to "loc". Also fixed parsing level of initial value in
create_arg (raw instead of glob). Thanks to the Ssreflect plugin for
revealing these problems.

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15066 85f007b7-540e-0410-9357-904b9bb8a0f7
v8.4: Fixing alpha-conversion bug #2723 introduced in r12485-12486.

The optimisation done of Namegen.visibly_occur_id did not preserve
the previous behavior when pr_constr/constr_extern/detype were
called on a term with free rel variables. We backtrack on it to
go back to the 8.2 behavior.

Seized this opportunity to clarify the meaning of the at_top flag
in constrextern.ml and printer.ml and to rename it into
goal_concl_style. The badly-named at_top flag was introduced in
Coq 6.3 in 1999 to mean that when printing variables bound in the
goal, names had to avoid the names of the variables of the goal
context, so as to keep naming stable when using "intro"; in
r4458, printing improved by not avoiding names that were short
names of global definitions, e.g. "S", or "O" (except when the
at_top flag was on for compatibility reasons).

Other printing strategies could be possible in the
non-goal-concl-style mode. For instance, all bound variables
could be made distinct in a given expression, even if no clash
occur, therefore following so-called Barendregt's
convention. This could be done by setting "avoid"
to "ids_of_rel_context (rel_context env)" in extern_constr and
extern_type (and then, Namegen.visibly_occur_id could be
re-simplified again!).

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15068 85f007b7-540e-0410-9357-904b9bb8a0f7
v8.3: Fixing alpha-conversion bug #2723 introduced in r12485-12486.

The optimisation done of Namegen.visibly_occur_id did not preserve
the previous behavior when pr_constr/constr_extern/detype were
called on a term with free rel variables. We backtrack on it to
go back to the 8.2 behavior.

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15069 85f007b7-540e-0410-9357-904b9bb8a0f7
v8.4: Fixing bug #2724 (using notations with binders in cases patterns
was provoking an anomaly instead of a regular error).

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/coq/branches/v8.4@15071 85f007b7-540e-0410-9357-904b9bb8a0f7