labofsahil/github-event-dataset-2012 huggingface dataset:
Sorry but what do you mean by wrap?

On Fri, Jun 8, 2012 at 2:24 PM, jlee-r7
<reply@reply.github.com>
wrote:
>> +#   http://metasploit.com/
>> +##
>> +
>> +require 'msf/core'
>> +
>> +class Metasploit3 < Msf::Auxiliary
>> +
>> +     include Msf::Exploit::Remote::HttpServer::HTML
>> +     include Msf::Auxiliary::Report
>> +
>> +     def initialize(info = {})
>> +             super(update_info(info,
>> +                     'Name'        => 'WPAD.dat file server',
>> +                     'Version'     => '$Revision$',
>> +                     'Description' => %q{
>> +                                     This module generates a valid wpad.dat file for WPAD mitm attacks. Usually used in combination with DNS attacks or nbns response spoofing.
>
> Wrap, please.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rapid7/metasploit-framework/pull/456/files#r953334
I think the number labels are switched here (i.e. `a0 <-> a1`, `b0 <-> b1`). The equation in the docstring matches the matrix in the code, but the matrix in the docstring doesn't match.
spacing of line below
To be honest, I'm not even sure why we need this function.  I looked at the pieces of code that use it and to me it looks like the code would be cleaner if it didn't use combine and instead did things manually.  I could be wrong though, as I'm not super familiar with that area of the source.
It doesn't make our API self-documenting; it makes client code self-documenting.  For example, what does this do?

`var clock = new Clock(new JulianDate(), ClockStep.SYSTEM_CLOCK_DEPENDENT, 1.0, new JulianDate().addDays(-0.5), new JulianDate().addDays(1.0), ClockRange.UNBOUNDED);`

I know you know what it does, but what about a user not familiar with the API?

Now what about this?

<pre>
var clock = new Clock({
   currentTime : new JulianDate(),
   clockStep : ClockStep.SYSTEM_CLOCK_DEPENDENT,
   multiplier : 1.0,
   startTime : new JulianDate().addDays(-0.5),
   stopTime : new JulianDate().addDays(1.0),
   clockRange : ClockRange.UNBOUNDED
});
</pre>

It's now much more obvious what the arguments are.
By adding points in processDataPointsHook, flot is able to do the rendering !
What this method does?
Use TiC. PROPERTY_DOMAIN
Should be `configuration "2"`
This came straight from the port but I should have changed it.  Will do.
Why is this a nested if and not a conjunction?
Pretty sure you can just write `guess[0] % (2 * PI)`.
Can you use Rails routes helper as expectation: `routes.foo_path`

Like in spec below: 

``` ruby
evaljs("Routes.things_path()").should == routes.things_path
```
OT: but just LOL ;)
Fair enough. Thanks for the clarification. Any idea why AppDirect was accepting the responses on other end-points but not the signup one?
Not sure how to handle these if bioconductor gets it's own home...
Why not set `closed` last?
Why is there a space in the label tag? Other than that, looks good.
I think we need some docs here to make the params clearer as well.
in fact, it seems like the rest loader does not support imports properly. It will always load them itself instead of asking the resolver to find the appropriate loader according to the type
please don't use a mock for this. You should use the real class you are testing. Your test is currently testing the mock object, not the real class.
Shouldn't this be 1 ? After all we have first the unsaved entitiy which should be equal to the saved entity (same instance) which then should be equal to the foundEntity (sameId). I think if we cache the initial-hashcode that should be the case.
I think that is how its supposed to be defined, the same pattern is followed in the [PowerShell Tool Project File](https://github.com/WindowsAzure/azure-sdk-tools/blob/master/WindowsAzurePowershell/src/Management.CloudService/Management.CloudService.csproj)
you should not add trailing whitespaces
libxml2 was already in 0.8
The arrows should be aligned and those strings in double quotes should be in single quotes as per the puppet style guide
There has to be a better way to test for ndarray-like objects.  At the very least a "isinstance()" test?
moved this into the CaseImporter now, since it's the only thing that imports tags directly.
Double lock Kung-Fu? )
That can't work since ```nxutils``` was removed in master... see #732 for example of how to get around that one.
MINOR: Comment should include (or id of process we are logging on behalf of).
Hello
You don't override this two methods...
IMHO it is redundant and should be removed.
The puts debug messages should one day become log messages or something.
Yes, my eclipse code formatter configured to use spaces for intendation because Android code style recomends to use spaces only. Sorry, I'll follow code style of this community next time. Should I publish the patch with tabs as another pull request?
Why not use [bootstrap-sass-rails](https://github.com/yabawock/bootstrap-sass-rails) instead?  That requires fewer dependencies (no rubyracer, for example).  @stevenharman pointed this out to me.
Actually I kind of appended on purpose here, because the fact that checks for a modified `auth.conf` does a check for something in the first line.
Do those dimensions work well for both iPhone, iPad and iPad/Retina?
Can combine these two lines into `git commit -am`
Yeah why not! :+1: awesome
Is not no longer required... does it default to 1.1?
Clean up after myself? What am I, an adult?

Yeah, I'll put a loop around that.
Alphabetical order. :-)
Yeah that's what I meant by 'checking some aspects'.
As you see in the test: I checked if query strings are actually redirected, as they should. Without this meta[querystring] stuff, just the URL would have been redirected - as you seemed to figure out yourself.
If there would be another way to 'transmit' the querystring: open for suggestions. Otherwise: looks like best solution for me - though it looks strange.
Now that I think about it: will check the django implementation of redirects but guess will be something like mine.

Send from my mobile device

Am 16.11.2012 um 22:10 schrieb "Tom Christie" <notifications@github.com<mailto:notifications@github.com>>:


In rest_framework/views.py:

> +    view_name = None
> +
> +    def get_redirect_url(self, request, *args, **kwargs):
> +        """
> +        Return the URL redirect to. Arguments and Keyword arguments from the
> +        URL pattern match generating the redirect request
> +        are provided as kwargs to this method.
> +        """
> +        try:
> +            url = reverse(self.view_name, args=args, kwargs=kwargs, request=request)
> +        except:
> +            return None
> +
> +        query_string = self.request.META.get('QUERY_STRING', '')
> +        if query_string:
> +            url = '%(url)s?%(query_string)s' % {'url': url, 'query_string': query_string}


Okay guess that makes sense actually, just surprised to see .META['QUERY_STRING'] is actually a thing

—
Reply to this email directly or view it on GitHub<https://github.com/tomchristie/django-rest-framework/pull/418/files#r2157055>.
Seems okay.  I guess an alternative take might be for `.m2m_data` and `.related_data` to be lists of dicts in the iteration context.
clearing out the dashboard info, this works with our new login flow
Good ideas, I'll apply them
I think if there's an error, you should call jqUnit.start() to continue to the next test
Here we are just testing that we see a message, we are not really testing that the user is really signed in, perhaps something like:

Then I am inside the system or
Then I start a new session or
Then I am signed in
Better raise a `ValueError` rather than use `assert`.
Btw, you could simply this even more by removing this file and using the autoload.php directly in phpunit.xml.dist
Creating a SpotlightController without the configuration file would use a toy-server-in-jar.xml configuration file, which would use the default index packaged in the jar.
It would make it consistent with the existing code back and general Java style guide. All the usual "that's why you should use curly braces" reasoning from C and other languages also still applies :P
The purpose here is to be notified a property is changed
why do you have this empty else-if statement ?
The list here, and the one below on `getUnits()` need to be the actual constant names, not String representations. You should include:

* TypedValue.COMPLEX_UNIT_PX
* TypedValue.COMPLEX_UNIT_PT
* TypedValue.COMPLEX_UNIT_DIP
* TypedValue.COMPLEX_UNIT_SP
* TypedValue.COMPLEX_UNIT_MM
* TypedValue.COMPLEX_UNIT_IN
* TiDimension.COMPLEX_UNIT_PERCENT
* TiDimension.COMPLEX_UNIT_AUTO
* TiDimension.COMPLEX_UNIT_UNDEFINED
These should be typeof undefined checks for consistency
Should we spit out an unsuccessful message?
Please don't use ``live``. It is deprecated. Use ``delegate`` instead.
Do we allow deletes of submitted entities?   Do we need to keep a copy of the entity?  There are question for our end-users.
again remove the <version>
Do not let the user set the ownerId.
you forgot to change the typehint here, so it is broken
-an