labofsahil/github-event-dataset-2012 huggingface dataset:
I must admit I didn't reverse engineer the other usages this flag fully. Perhaps that comment refers to the fact that self/super constructor arguments can't be adapated by an implicit class member? I'll dig into it a bit more and document my findings.

In general, the different handling of the in-scope implicits and the regular scope give me the creeps, though. (See this comment for another example: https://github.com/scala/scala/pull/697/files#L1R648)
Placing a mutable map in a var is always the wrong thing. Either "var" or "mutable" give you all the mutation you can eat.
For my benefit, can you explain this one slowly?
I don't know if it's much different but this could be `"i%s" % self.O`
It is publicly available as `blocks`
@resurtm I think with error_reporting E_STRICT it will complain. This change should at least be documented in UPGRADE file.
Works on my tests, Swapped it over to aforesaid implementation.

-A

On Mon, Dec 3, 2012 at 11:48 AM, Craig Spitzkoff
<notifications@github.com>wrote:

> UIKIT_EXTERN NSString* const kAppBladeErrorDomain; UIKIT_EXTERN int const
> kAppBladeOfflineError; UIKIT_EXTERN int const kAppBladeParsingError;
> UIKIT_EXTERN int const kAppBladePermissionError; UIKIT_EXTERN NSString*
> const kAppBladeCacheDirectory;
Looks like it got mixed up with the meta directive. Should only have 1 `.. meta::` for the page.
please use 4-space indentation. Also, you're missing a "var" declaration - this will cause leakage into the global scope. Also, the parens around the ternary conditional are unnecessary, and the regular expressions should be a regex literal and not constructed via new RegExp.

In addition, because line 85 is only ever evaluated once, you don't need to check if it's already been defined. just do `var re = /foo/i;`
well, in this case, the config file wouldn't have the `nil`, it is just the caller is passing the option in a way that would result in a `nil`.

I don't know how often such code is written, but I think I would prefer the way it was working, that just lets that work.
typo here :)
This is not good. In many cases I want parameter as nil and in specific runs I will set it to some path or string or number.
The nil value let me do:
copy(Params.path) unless Prams.path  # If Params.to is nil, copy will not execute.
Instead of defining the method ````toggleCredit````, can your javascript just be ````"$(.alc).toggle();"````?

Also, probably better to use a more descriptive class name.
you got a curly getting closed by a square here.  Not a problem, but is weird :P
the find() and geoFind will 

what are they?
We should come up with a better term for that. 

I think Jenna's doc has the right idea.
need appropriate warning.
that's another bug/feature/PR that les is doing.
Should just remove tests.py if there are no tests.
At opower we use the older version though. :(
If this is a complete rewrite, then the other copyrights should not apply. If it is not, we should keep the other authors as well.
In update case I think it is fine to rely on signature. As for new boards we will grant it to everyone except newly members group
To prevent injecting HTML via `$phpbb_adm_relative_path`.
Or to be more specific, CompilerPassInterface. I'll change it later.
or $xmlDataSet renamed to $xml_data_set?
You can copy the tab characters from neighboring lines if your editor "fixes" indentation for you.
Consider adding that it supports both /* */ and -- comments.
It's unclear to me which interface you consider to me the primary public interface for this class.  Is it the hash style `[]`/`[]=` methods?  Or `get` and `set`?  It might be good to make one public and one effectively private (i.e. document it as private).  I try to keep the public interface on my projects very small since a small interface is an easily maintained interface :).  Later on if there's a need for both interfaces to be public you can always declare them public at that point.
I initially had to add this to get 'json' to load. Does it come installed by default in more recent versions?
From URL ...?next=something ... Is this not ok?
This is a free game, how about you donwload the regular client from the game's web site and then we can have support for both the steam and regular download version?
The indentation in this file is not correct https://github.com/dot-i/Nancy/blob/4edd7b0cef0de5fa955c0dbc96e03bff1d302062/src/Nancy.Hosting.Self.Tests/IsCaseInstensitiveBaseOfFixture.cs
I'd prefer a more descriptive name like ```simple_4d_with_hybrid_height()```
I think we should remove the jQuery dependency from this.
опять же непонятно, зачем перехватывать исключение и добавлять одну бессмысленную строку
See comment in ExecutionSite.java about AsyncCompilerAgent dependency concern.
re-open the div that you closed.
Ya this is only used internally (but I would say its public within internal APIs).
remove decorators. prefix
Why not just return text.trim() rather than core_trim.call?
`if( ` => `if ( `
The error is a segfault. The following is output from the LG Esteem that exhibits the behavior: https://gist.github.com/33772b893b28f543484b I assume the behavior is similar for the other devices mentioned in the bug thread, but I don't have those particular devices on hand to test.

I also hoped that wrapping the division in parens would avoid the bug, but the crashing behavior persisted.

When I tried removing the `|| 0` without other changes, there was a test failure ("Animations with 0 duration don't ease (#12273)"). With my proposed fix, the test remained green.

If an alternative fix would be preferable, I'd be happy to test it on this device.
It's been forever. 5.3 is fine! closures, namespaces, late static binding.... huzzah!
Oops, my bad, inside `[]`, `.` is literal, so the first line is any single letter, number, white space character, or character from `-:,;.#%!`.
Ok. filters and queries are totally different and you really want to use filters here, so you should switch it.
This could be a docstring.
Weird. I just redownloaded and I got `a392683c84f121dc22115ffb9db41ea9`. Is this not a reliable source for some reason?
`header_prefix = "#{MacOS.sdk_path(10.7)}/Developer"` (preferred) or `header_prefix = MacOS.sdk_path(10.7).to_s + "/Developer"`.
Use double quotes or escape the ' using \'
Seems like it should be set as an error that the validator can, optionally, check.
Technically, I think it is different, not extra.  I keep forgetting to switch to inserting tabs instead of spaces in this old code.  I've fixed this spot, and I'll do a full tab to space conversion after this release.
Maybe just remove it and leave it as `{$machine_name}_updated_messages`.
ok, I will do my best.
It's not clear to me why we do this. `fListeners` is final, and the constructor we are calling here does not make a deep copy
Consider this as feature request.
It's not necessary to create an empty rule for this class, and you already explain this for the mousedown handler in brackets.js .
Jasmine continues running the test code even when an assertion fails (unlike JUnit, etc.), so I think it wouldn't actually prevent an exception.
Done. The `node()` function returns immediately and the RemoteAgent highlight events are only added if the experimental flag is set.
http://static.fjcdn.com/comments/fuck+this+shit+_d9c3f045869ee46ad3bd37bb74782ca4.jpg

I am not quite sure if it was being checked on everyone. I will check on this on this...
Why not to use `alias_method`?
Indeed! I'll write "nonnegative".
Comments denoting what these member variables do would be really good, so neither you nor your professor/TA has any questions about what they are used for.
Yup, I've already removed `trans_type`.
I'm really proud of it :-) It was really hard to find a way to improve this well-written method :-p
For `destroy_*` I was planning on using `MSG_NOTFOUND` instead of `MSG_FAILED` when Redis cannot find a value. Perhaps `MSG_FAILED` would be valuable when catching a database connection exception.
Maybe order it? Like constants on the top. Values on the bottom?
This is not true. Read documentation about default values.
No need for this, since you have other tests here, and you use t.plan() to set the expected number of tests. Nuke it from the other tests as well.
`toInclude` is leaking to the global scope
Needs an ignore line.
Can you change this comment to a doc string so that it appears in the documentation please ?
"This whole plugin has been deprecated in favor of a new set of Maven Plugins."?
should add a new line above
Don't like this code. Change the name of `BuildActionsDictionary`. This looks unclear.
Add this as a link don't duplicate it.
My testing indicates that is does *not* work with the `/` at the end.

But this
https://github.com/andreasgal/gaia/blob/master/apps/homescreen/js/homescreen.js#L958

works fine!
I wonder why this isn't `switch () { case }`
I'm confused as to why this is a module-level variable.  Even the docs for `AngularSeparation` say there should be an `AngularSeparation.distance_function` class attribute, but I might be missing something.
This is also missing a description - oh, and note that this could be just ``astropy.units.format.Base`` and I *think* Sphinx is smart enough to automatically add the `` ` ``s (although that part is fine as-is, too)
bit of code duplication - could just use app_helper:get_env(riak_core, stat_specs, []).
This is the 3rd of fourth time this line appears, suggest either/both that the default target_n_val be in a macro (DEF_TARGET_N maybe) as it is fetched so often or a local private fun get_target_n_val(). Kind of thing that is easy to miss in one instance when we change it, and weird things ensue.
Nope. Will change.

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Sat, Dec 15, 2012 at 4:08 AM, Luke Steensen <notifications@github.com>wrote:

> In app/controllers/videos_controller.rb:
>
> > @@ -9,6 +9,8 @@ def index
> >
> >    def show
> >    	@video = Video.find(params[:id])
> > +    @comments = Comment.where(video_id: @video).scoped
>
> Any reason to do this instead of just using @video.comments?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/26/files#r2428154>.
>
>
This skeleton is a little specific.  If I end up using something similar elsewhere I'll see if I can make it generic.
I'm suspicious here. What is this test stuff about? Could it be put in a TestStack object?
This is just a helper method diogo. The roles_in_context mechanism already exists and is what makes possible the interaction between the SupervisorRole and the DjangoRole, for instance.
Delete commented-out lines that are obviously now useless.
I presume this means to be 'return status'
Pedantic, but since we aren't reading `stdout` or `stderr` best practices would suggest redirecting them to `/dev/null`.  In Python >= 3.3 this would be as simple as `stdout=subprocess.DEVNULL`, but instead the code gets a bit uglier:

```
with open(os.devnull, 'w') as devnull:
    proc = subprocess.Popen(..., stdout=devnull, stderr=devnull)
    proc.communicate(raw)
```
I moved it to a variable and made it configurable.
no value in 3 lines for this.. just return ImmutableMap
https://github.com/kaltura/mwEmbed/commit/df3a0a7886e0ad7617bb5d653085ae79edcf4719#L2L227

Good point.
The reason why I didn't try to override time display and play head is the totally different functionality. I did not want to depend on any of our events, preferred a total separation.
Might be a weird place to expose this?
Why did you change the defaults?
This doesn't work either; the last iteration would be `i=36` which makes us write into `oid->id[20]` which causes invalid access exceptions. The correct formula would be `oid->id[1 + i/2]`, as we've only actually written to the first byte of the hash.
do we really need to iterate all fields in the input for each wildcard field in the schema?

couldn't we use this loop instead in buildIndexingReqs? currently that method is iterating all fields in the schema instead but the addField call is skipped if val is null. this change would only potentially affect schemas without wildcards where the number of fields in the schema is much smaller than the number of fields in the json object.
I've removed this, for a cleaner pull request.
Another option is to add a extra select. Something like: https://github.com/mozilla/kitsune/blob/master/apps/questions/views.py#L88

You could get the count of helpful and unhelpful votes with each answer in the one query.
I think rather than defining next(), just give the anonymous function above a name (I've been simply using 'reentry' in most places) and use it as the callback instead. This way errors won't be silently discarded if rmdir() or delete() should fail for some reason.
整个校友录的程序不一定是跑在root path下面的（比如测试的时候其实是http://localhost/xiaoyou/...），我在每个页面都定义了一个东西叫`window.siteBase`，这个`images`应该是相对于`siteBase`的
Line 16 seems like an odd comment. Is this necessary? How do we refactor the code to make this clearer?
d30943c added the info to UPGRADE-2.1 so i thought i would do the same thing. there is no 2.2 changelog yet. or do you want me to add this to the 2.1 changelog and it can be part of the next minor version?
As you are using the event dispatcher (which was rejected by @fabpot in the discussion btw), this compiler pass is totally useless as it does *exactly* the same than the normal listener pass, and the normal listener pass is able to register listeners to these events
This should be suggests then?
Those methods do more than just calling the default failure/success handlers (also events, resetting tokens etc etc). For clarity it's nice to keep them separate imo.
`str_repeat()`  to avoid the loop ? or at least avoid to `count()` on each iteration
I think you should always call this method, to do the algo check instead of receiving a warning.:

```php
private function hashPbkdf2($algorithm, $password, $salt, $iterations, $length = 0)
{
    if (!in_array($algorithm, hash_algos(), true)) {
        throw new \LogicException(sprintf('The algorithm "%s" is not supported.', $algorithm));
    }

    if (function_exists('hash_pbkdf2')) {
        return hash_pbkdf2($this->algorithm, $raw, $salt, $this->iterations, $this->length, true);
    }

// The fallback algo implementation here
}
The resource type is implementation specific. In this specific implementation the resource is the data of a block (see also the doc comments in FormRendererEngineInterface).
I like what you describe, as opposed the example you show. :)

`ambrose-detail-pane-cascading.js`

Once we have a real impl for cascading we can use this pattern. The stuff in index.html I plan to remove before we merge, or make into documentation somehow.
Looking at http://maven.apache.org/plugins/maven-compiler-plugin/ we see:

"at present the default source setting is 1.5 and the default target setting is 1.5"

What jdk & maven versions are you building with?
> Could you break out this change into it's own feature branch (since it's
independent of the other code)?

Sure. Easy enough.

> I'm not sure if the HSV colorization is any easier to read than the
blue->red gradient colorization. I wonder if both modes could be useful,
maybe as some sort of select (or two buttons)?

I find the wider variation in colors preferable over the two color
gradient, but it may just be a matter of preference. Perhaps a choice is a
good idea, along with some predefined palettes.
Maybe this is detailled below but can the polyhon be open ?
If it could be, maybe a concept of circulator would be better than a concept of  Sequence ?
I am thinking of having a single histogram function without histogram_impl.

ImageBufAlgo::histogram does input validation literally in 5 lines and then
it calls histogram_impl. I think we should put the code in one function.
It made sense to separate 'over' in two functions because the input validation
was complex and we needed parallelization.
Maybe provide a default then? That would be the consistent approach for kwargs.
shouldn't it use the new close method here ?
That's fair. I'm working through where the issues came from and will merge your request when I get some free time later.


Thanks!
I would tend to align consecutive assignments by the operator when there is no extra line between them.
Since we don't actually use `'html'` anywhere, why not just make this `.get('format')`.
Lines 118-121 are better done as:

JSFResourceDefinition.DEFAULT_JSF_IMPL_SLOT.marshallAsAttribute(context.getModelNode(), writer);
Should validation happen before applying to the config?
Yes this change removes the dependency on jython (as well as sosreport).
Still, I don't get why you do something like:

https://github.com/jquery/testswarm/commit/474494b#L0R12

```php
return $settings;
```

In what scenario this line is useful? Pardon my PHP, I haven't been using it in years so it's a little bit rusty.
Not sure what convention you are using, but it would be niceto have a description telling what this method does.
renamed to facebook.css
We can extract this in the method on `CallHandler` in order to avoid the crazy nesting.
I think we said that it can be a setting in the system app directly?
On 05/06/2012 17:33, Etienne Segonzac wrote:
>> @@ -1,8 +1,8 @@
>>   
>>   #lockscreen {
>>     position: absolute;
>> -  z-index: 20000;
>> -  top: 0px;
>> +  z-index: 2147483647;
> I wish I had a better solution for this to suggest...
>
> What about leaving a comment explaining the INT_MAX hack?

done.
please rephrase — I don’t understand this comment.
nit: != -> !==
Oh, last time I checked these strings still didn't work, but I'll add this to the top of the file.
Can we add them to the locales and use _() in the meanwhile?
add spaces between : and the value
Yeah, that was my feeling, too.  Originally, I had this as `#parse`, but my preferred one (based on availability, features, and performance) would be Rack::Utils, which doesn't follow that pattern.  So, since `#method` always returns a callable object and obviously lambda/proc do, as well, it felt like the next best option.
The indentation should be 4 spaces and you should use `PDO` directly, not `\PDO`
Force spacing would be useful, yeah.
These are async functions and at the very end there is a test.finish()... What you want to do is run each test one right after the other. The node-async library helps with the nested callbacks. async.series or async.waterfall is a great pattern to follow to run things in order, but in an async manner.
() to （）
I agree with this ponderance, an exception would be better than a None return. please make this change
As I was trying things out and figuring out how this code works, that printout got annoying, but I'll change it back.
Could you elaborate on this a bit?  Do you mean I can avoid defining these functions altogether?
I think that the issue was that $fileinfo['error'] contains both image extensions and every other extension (pdf, zip etc), which was the original issue in the bug.
`'new'` is just there to know that we're making a new thread, it's not used by 4chan.
`resto: threadID` is sent to 4chan to tell that this post is a reply in the thread n.`threadID`.
Lack of `resto` -> new thread.
`resto` is a number -> response to.
What @Dinduks means is : use a [global gitignore file](https://help.github.com/articles/ignoring-files) for these.
added "active_model/railtie"
Although '/etc/modprobe.conf' probably doesn't exist on different platform, as you said, we should record it into log file
at least. thanks.
These network related classes looks nice, but could we put them into a separated file? our virt_utils module becomes larger and larger.
remove meaningless comment?
This comment should be deleted
This is one for the wiki, not public source. Can you remove please?
hasChildren is deprecated, can you change to count?
With amd, one can have the same version of the code running on the browser and server. I find dependency management a lot easier in shared code when this works nicely. Hence all these changes are the tweaks necessary to allow the browser code to run on the server as an amd module.
Ah, you're right about it being a string -- unfortunately it still seems not to take into account the alternative names in the certificate. I tried with `'CN_match' => $this->fileUrlParts['host'],` and it still fails for getcomposer.org and packagist.org because the CN is for dl.getcomposer.org and dl.packagist.org -- we need to check the alternative names, and it seems PHP doesn't do this. Perhaps I'm doing something wrong.
Why is this `printf`? Please change it back to `echo`.
`return no_commit_message if safe_message.blank?`
Needs
````
require File.expand_path('../counting_client', __FILE__)
````
Think we should set frame_buf to NULL here to be safe.
sig_cnt can be greater than 255.  The array size is sig_cnt.  But the array member type is uint8_t to store a flag.
Apologies that it has taken me so long to respond!

These are good points and I partly agree with your analysis. However, this means that there will be no way to specify a different filename for the output file (since it will always have the same basename as the input file). I agree that it should be made clear to the user that converting a notebook will potentially result in multiple output files. However, it seems to me that this is rather a documentation issue and there is no need to sacrifice functionality for it. (I'm willing to bet that eventually people are going to complain if they can't specify an explicit output filename when only converting a single notebook.) Moreover, currently an invocation such as

```
convert --format=latex notebook.ipynb
```

doesn't convey this either imho. How about we add an explanation to the help string of the ```--format``` switch to say that for certain formats there will be multiple output files?

I think the behaviour of browsers when one saves a webpage (including its contents) is quite instructive. They allow one to specify any output filename and silently create a directory ```webpage_files``` (or something similar) alongside ```webpage.html``` if the webpage contains images, etc. This is precisely what ```nbconvert``` currently does, with the restriction that the user can't specify the output filename explicitly.

Is there any harm in allowing something like the following?

```
nbconvert in.ipynb /foo/bar/output.tex
```

... which would create a directory ```/foo/bar/output_files/``` alongside the actual TeX output file? I'd expect TeX users to be aware of the fact that figures need to be included externally and thus to expect that such a directory gets created when converting to TeX format. Again, this is essentially a documentation issue (and very close to current behaviour) so imho shouldn't impose any UI restrictions.

Regarding the conversion of multiple notebooks in one shot, I totally agree that's a very useful thing to have. So having an ``---out``` switch as you suggested is definitely a good idea. But I'd still argue that it would be very convenient if its argument can be either a directory or a filename.

So how about we let ```nbconvert``` essentially behave like ```cp``` does, except that if the input file is specified as the only argument then it assumes ```--out=os.curdir``` (and a few similar corner cases)?

I was going to write up a detailed specification for the behaviour I have in mind, but it turns out I'm very bad at writing concise and clear prose. :) So if you are willing to give me the benefit of the doubt then I'm happy to implement what I have in mind and add tests for all cases which can serve as a basis for scrutiny and further debate. This should be much easier than discussing it here since code is always clearer than words. :-)

However, if you still have fundamental objections then please do let me know. I'm also happy to discuss this further before proceeding.

Thanks again for all your time and helpful suggestions!
これは :so% した時に、前回の状態を復帰させる(0で上書きするのを防ぐ)ため?
I'm not sure I know of a way to do this. Here we are modeling the event queue in a declarative manner. As I understand it the Steps correspond to Events. Once there are no more steps, there are no more (equivalent) events.

let me rephrase your question as I see the problem: How can you test for an async side effect in zombie that happens after the event stack is emptied?
should be `hostFrame.then(function(hostFrame) {` right?
If you inherit from `EventTarget` it will take care of registering these listeners.
It would allow us to handle them in a next step. 
One alternative would be to use another kind of xpcom that will register itself in a category to instanciate it at app startup.
But as soon as we will have to handle command line arguments, we will have to use this form back.
Very cool. This makes sense.
I know of no easy/automated way.
sorry about this
ternary operator instead here?
you can remove all this dead code as the method returns above
I thought that the test threw an exception if it failed, in which case the cleanup line won't get executed. The being...ensure block you had relied on that behavior in order to skip the cleanup and so I thought it was much cleaner to just remove the ensure block to drop that extra noise.

I also removed the comment, because without the ensure block the stanza that it refers to turns into a single line and so not as bad. I agree that it would be nice to be able to register before and after handlers, but it didn't seem like this was the place to point that out.
Trying to make travis do its thing...
Here we leverage Turbolinks for faster reloads on file changes.
The check for `isDefaultPrevented()` allows the user to call `e.preventDefault()` in their event handler. For the `show` and `hide` events, if the user calls `e.preventDefault()`, it means they want to stop the `show` or `hide` function before it happens. However, for the `shown` and `hidden` events, the action is already done and there's nothing to stop.

Yes, I could do the patch by myself but it was your idea and you've done well so far so you deserve the credit for it. I'm just trying to help and I'm learning most of it at the same time as you.
yes, if you use a component, i expect exceptions from its exception interface, not from a different component, but we can add the stdlib exception as previous one, so it don't get lost
Rewrite the above as:
```php
if (isset($message['message'] && isset($message['translation'])) {
    $messages[$message['message'] = $message['translation'];
    continue;
}
$messages[array_shift($message)] = array_shift($message);
```
this could just be "if elPlayerA and elPlayerB:" since getChild will never return 0 nor False.
Only human's have hunger, no?
Why is this 1?
-> TodoController
I might have agreed if JS had a clean way to do multiline strings, but string concatenation of HTML is just plain ugly and I would honestly prefer if we didn't teach that pattern of doing it. Having HTML in an HTML file makes sense. Looking at Web Components with the `<template>` tag, this is the way to do it moving forward, and having it in a `<script>` tag until we get it is a good temporary measure.
Remove this line ^
I get your point. In my specific use-case, I have the exact same JSON payload coming across a websocket as I do from my REST API. So, I want to be able to create a new resource from the websocket payload - and hopefully going through same decode process. I could try to figure out how to expose the decoder out of the resource so I could use it from my websocket proxy.
should we really add a default ? It would mean that the url for RSS is ``/feeds/packages``
even if this code is not part of the changes, it is not safe. This uses string concatenation to set the ids, not a query parameter.  you should be writing ``$qb->where($qb->expr()->in('p.id', ':ids'))->setParameter('ids', $ids)`` (array parameters are available as of Doctrine 2.1)
Well, some path change needs to be done, since catogories and node titles can conflict if we don't change it.
If they conflict it is not possible to see the category listing, the node will take precedence.
Immutability is based on the value object itself. Being public doesn’t make the value object itself mutable.
what about STATE_MOVED ?
Use the $ instead of "jQuery"
Read known issues ;-)

This allows you to log in as a user with a req. header (X-Test-User: 14) in order to have permissions.

This is *of course* temporary ;-)
Yeah, yeah – recanted.
With RSpec You can use order-insensitive array comparison, like this:

```ruby
paths = described_class.all.map { |p| p.path }
paths.should =~ %w(foo_spec bar_spec baz_spec)
```
this @param documentation is kind of useless, no?
It is MySQL, but making it fail early is a good idea, rather than have it fail midway.
extra space after `options.autoplay`
s/greather/greater/
Why does PageProvider extend Page?
do you need this? `kb_new_article = PageProvider(mozwebqa).provide_kb_new_article()` should work
I'll update the [Developing](https://github.com/team-umlaut/umlaut/wiki/Developing) wiki page to reflect the travis changes.
can you add a oneliner telling the users whats the diff between the org options?
hmm.. does it replace or add to the line above it?
I'm fine with either approach: if an implementation does change it, it will be only for the sequencer instances of "that type", so it won't influence all the sequencers.

Maybe a method is more "clean" for subclass though.
Might want to make this path configurable, since it's configurable in both chef and vagrant.
será que tá certo?
Why don't you return from here ? What is supposed to happen next ?
Nope. Sounds ok ;)
That's my rake db:migrate
error handling needs to be consist - see function error() in mongo-store.js, and how it is used
Hmm, yeah, that makes sense.  I was only thinking of literal functions, but I guess there is no good reason why it shouldn't work for the case you describe.
And this block.
Once the functions in cassandra use our CONFIG, this can probably go.
Oh underscore, your utilities amaze me.
Just added notification permission here
This one is part of a cosmetics patch.
This is a lot of wasted code. It performs the same job as my existing routine but with a slightly different return. In essence mine is a specialisation of yours.

So while I don't have a problem with have this particular routine, don't duplicate the code. Replace my existing functions with calls to yours that simply map the returns.

Bit more tricky for the split routine, but still better than code duplication.
Why do we need implement hasKeys in SlopStorageEngine?
I think `source_files` is also wrong? should be `template_files`
Seriously? This one tells nothing and the rest below are way too obvious.
Default values should also be the same in both Joomla versions.
Still not good :P
Oh, and PREF_BRACKETS_BASE should be given a more generic name like PREF_APPSHELL_BASE, too.
It is kinda ugly, but it allows us to test multiple Ruby versions with no config changes. Hence: neat!
Why are you removing these exclusions? i think this was done because they were getting duplicated since spring i think shipped with them.
But if all the tests still pass, you can ignore my comment
**ext:**modifyColumn and not modifyColumn, the changeset with id '20121007-test_order_laterality' was written before we started using ext:modifyColumn. modifyDataType might be fine but am not sure if it addresses the issues with modifyColumn since it is the replacement
Could you add a short comment pointing to tox docs (http://tox.readthedocs.org/en/latest/) for users unfamiliar with tox?
You can introduce with your sentence : 

> Translation is a plugin of the templating layer (Twig or PHP Templating) and has to plugged into that

Then, continue with twig code as example ?
I don't think you need a `\` prefix if you use a function?
empty line between sections
Just checked in the whitespace change.  Cheers!
why use a tuple if you only care about singletons? Why not just pass the expr? Or will you eventually support more than one argument?
No need to cache it since the data is already cached by _deleteParams or _putParams.
не думаю, что это обязательно
Оно точно тут такое пустое нужно?
If a Jamal command is executed from a non HCSMPBot user, it will go not do anything
As these variables are declared using `var` and inside the object, they won't be exposed anyways if you don't want to prefix with an underscore.
Should be a list.
Yups, sorry, I missed one of the IFs.
An improvement I learned from class
```
@my_string.size
```
Can we just remove nils from the collection up-front?
you do not check the values elsewhere in the code
task_id should be camelCase
This would accomplish what I suggested, but I think the specific implementation for apertures has been tortured into matching the PSF API. To me it is unintuitive to have a single CircularAperture object represent the apertures for multiple objects across the image. If anything it should represent multiple apertures for a single source. Also, having `Aperture` objects accept arrays makes it significantly harder for a user to define their own aperture. For now, I would change apertures and psfs to follow these conventions:


    ap1 = CircularAperture(1.)
    ap2 = CircularAperture(2.)
    ap3 = CircularAperture(3.)

    # single identical aperture on each object:
    results = aperture_photometry(image, (x, y), ap1)  # x, y can be any length

    # single different aperture on each object:
    results = aperture_photometry(image, (x, y), [ap1, ap2, ap3])  # x, y must be length 3

    # 3 identical apertures on each object:
    results = aperture_photometry(image, (x, y), [[ap1, ap2, ap3]])  # x, y can be any length

    # 3 different apertures on each object:
    results = aperture_photometry(image, (x, y), [[ap1, ap2, ap3], [ap4, ap5, ap6], [ap7, ap8, ap9]])  # x, y must be length 3

The requirement is that `apertures` must have shape `(n_objects, n_apertures)` or be broadcastable to such. This way, `len(apertures) = len(x) = len(y)`.

I would have the PSF functions work the same way. The functionality of returning a different PSF as a function of position should be left to the caller or a higher-level function. This would parallel aperture photometry, where determining the parameters of the aperture for each source (e.g., MAG_AUTO radius), would be done by a different function.

We can evaluate later whether we want to have `CircularAperture` support arrays.
Why don't you use `fm` which is an instance variable?
my bad, misread the diff.
So this delete overrides the one in FreshInstance. So the delete_resources part is going to be skipped so is the queue delete
I thought the code *was* the comment :-D
This change is also in https://github.com/infinispan/infinispan/pull/1322 - I presume that was a mistake?
I still use VisibleOwnerReentrantLock if lock striping is used.  Saves on the extra memory footprint of an unused ref counter.
Actually, I have a file called 'secrets.py' which is in .gitignore, it is also imported in the main settings file
Maybe we could move the converts to the package `scalaz.contrib.converter`. What do you think?
That's what `-enumerateObjectsUsingBlock:` and similar methods do. I see no reason to break the convention.
I don't think you need to `+` strings if they're on different lines.
did you mean for this to be <code>Assert.equal(report.product, product, "unexpected product " + product)</code>?
ruby-compass is only currently in debian testing, which might need explaining in the docs?
compass is needed only for the current FixMyStreet design; I guess we want the default 'unbranded' install to look like it, but there's no reason it has to.
libhaml-ruby isn't needed if ruby-compass is installed (as ruby-compass depends on ruby-sass in testing, it's been split up).
почему eval ?
Should the namespace not be ``Psr``?

// cc @drak
`> 0` and `!== ''` can be dropped here.
Why did you change this file?
Can this naming be more informative? I am not sure but may be you would find some better name
Done. Will need testing with the actions top branch at some point.

I've browser tested on Chrome, Firefox, IE9 - IE7, and it seems to work.
Remove $created if not used
This should be moved further into the factory and track the type of event as well, differentiating between pull request and normal push.
Are you talking about the extra spaces in 506, 507? the commas should be at the same level as `this.assert`?
And it IS in my github repository. Not sure why you are not seeing it.

On 11 December 2012 19:20, Colin Adams <colinpauladams@gmail.com> wrote:

> I HAD already removed it. My memory isn't faulty after all. It must be my
> git skills that need polishing. I'll try and get it committed.
>
> On 10 December 2012 08:19, Jocelyn Fiat <notifications@github.com> wrote:
>
>> In library/server/wsf/router/wsf_router.e:
>>
>> > @@ -53,6 +53,9 @@ feature -- Mapping
>> >  	map_with_request_methods (a_mapping: WSF_ROUTER_MAPPING; rqst_methods: detachable WSF_ROUTER_METHODS)
>> >  			-- Map `a_mapping' for request methods `rqst_methods'
>> >  		do
>> > +			if attached rqst_methods as l_rm and then l_rm.has ({HTTP_REQUEST_METHODS}.method_get) then
>> > +				l_rm.enable_head
>>
>> I guess the change in map_with_request_methods is not relevant anymore.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/EiffelWebFramework/EWF/pull/16/files#r2361207>.
>>
>>
>
>
You don't need the () in the two lines above. If you put them, it has to be a "def" in the parent class. If you don't put them, you can either request a "val" or a "def". One of the advantages of scala is that it doesn't make this distinction when requesting val/def. As stated above, this enables you to replace functions by attributes (for example replacing your "def getSize"  by "lazy val getSize" in a later optimization step or values by functions (for example using a getter or setter instead of the public attribute) without having to change the code using the class. If you write "base.read()" and the parent class somehow would change "read" to be a value instead of a function, your code would't work. This is possible even for a function like "read", because a value can also contain a function but be declared as value (higher order functions from functional programming).
In this case here I think it isn't that important, because I don't think java.io.Reader will change their implementation. So it is only a question of convention to omit the ().
Are you sure that the method "setPassword()" exists?
How about making the return type a bit more specific; maybe use ``false``?
refactor into private method handleRegisterAction (in your new shiny class).
Weiss noch nicht, guter Punkt!
"that reinitialises the any dimensions" => "that reinitialises the dimensions"
Adding a `required=True` field after the fact with no `default` makes upgrading a pain in the rear
CS, добавить пробел перед "{" и между аргументами
remove tab idents
Just what the `set->predicate` does :)
We need compiled css in the tree to support thimble
Resolved with be00d2a.
So, we have contact information and education. What about job experience, etc? Maybe add those to the input json file (resume.json) and incorporate those in the plain text output?
`public/assets` нужно игнорить
I am not aware of width being changed. Anyway, prepare bounds in a way that it supports maps of non-square sizes. And yes, write a comment to tell how this value is computer if there will ever be a need to change it.
OK, just make sure everything is consistent.
You can combine multiple classes into one call to `addClass`.
Because this is boolean flag of FunctionExpression, so I think this line isn't necessary.
Okay, this pull request is ready then.
although there is only one place where this method can be called falsely and this is when
the actual iterator over the sequence would not check hasNext() before a call to next().
The iterator in question is not publicly visible and is guaranteed to be used correctly --
when it would be not, the sequence iterator would have screwed it up and this would
be an implementation / internal error which should never happen.
lower case faction_X and unit_class (linux is case sensitive, it's fine on windows)
It not occurred to me another way of doing that puts the debuff to players to get scent of blood.
I did consider this when writing the code.  Both are fine solutions, but I prefer the solution I chose since it makes it really explicit that we're changing the order and it lets the reference be to a List instead of a LinkedList.
Note that this can occur. Try running this valid SQL query and look at your profiler after that: ``SELECT '<script type="text/javascript">alert("XSS owns your profiler");</script>'``
Lo siento, pero no entiendo lo que quieres decir aquí, a mi me sale esto :S

> Un
> 
> solo puede tener
> como hijos, ¿puedes añadir
> a esta línea?
Is Java logging the standard for EB?
Yes, and I confirmed it on our cluster so seems fine.
I had thought to use context.getWorkingDir() but that returns an HDFS path.
turns out we use specific APIs from zmq 2.x,  so we need pyzmq >= 2.2.0.

pyzmq 2.0.x will not work
Need to take care of accumulating group IDs also on og_group()
Extra space before the comment.
I just moved that from the crafter, but yes, can fix that.
Looks like it might print `undefined`, maybe should have a check and fall back to "".
Sudden change to single quotes
Agree, but we don't have `Array#second` from `ActiveSupport` here, so `final.first` and `node[1]` won't look nice together. That's why I thought about creating a `Node` class. But, as I said, I decided against it eventually and implemented everything with plain arrays and raw indexes =)
That makes sense, though I'm not exactly sure how a setter fits into the existing structure of the MediaPlayer, which is built around receiving media ids rather than media items. Is there something I'm not seeing, or does creating a setter for its media attribute going to require substantial reworking?
ditto spring managed injection
https://www.google.com/search?q=ahmedhack14%40yahoo.com
The `model.view = someView` pattern.  Comment is 4 lines too high.

@github #fail!
I see that in the docstrings we've consistently talked about "flux in photons", so this is consistent.  Is this what we want?  I'd be happy to go and make the changes, but wanted to raise the question.
You're right.  Fixed.
alpha these please
oh wait that's a different e :) i've gone with entity
Indeed, thanks for spotting that.

Done
Perhaps add javadoc comment that list-of-lists is deprecated, so we can remove this in a couple of versions time?
This compiles identically, but feels like it shouldn't. For a more clear example:
```coffeescript
x = {y: () -> @ == x} # Thoughts on the {'s here? I think they make it more obvious to read.

x.y()    # Looks like what it is, the value of @ will clearly be x
do x.y   # Looks like it evaluates x.y, and then calls the result. Value of @ would be the window.
```
js/javascriptsではあるまい
parens? ;)
Yep! On it.
Oh, this is so ugly name. :-) But I do not have a better one.
There was already an inconsistency about indentation in this file. The rest of the project only allowed coding style with soft tabs but if you trace back the history of this file, it's initialized with hard tabs. I'll provide a fix it in a later commit.
actually yes, when using nat+host-only we need at least two adapters each in its own slot
agreed, that is actually something we need to do in multiple places. maybe in a different issue?
So, this was incorrect, not actually incrementing the counter value. Of course, fixing this led to the test failing since this was using the "status" fixture instead of an empty repository. I fixed the callback to actually increment the counter and then had to fix the tests so that the empty repo test could really run with an empty repo.
Making the doc path configurable wouldn't work so well for automated tools anymore. Is it necessary?
Isn't it "emotion**al** trauma"?
pushed

Summers Pittman
>>Phone:404 941 4698
>>Java is my crack.




On Wed, Nov 14, 2012 at 12:03 PM, Bruno Oliveira
<notifications@github.com>wrote:

> In test/org/aerogear/android/impl/pipeline/RestAdapterTest.java:
>
> > @@ -99,6 +99,45 @@ public void testPipeFactorPipeConfigGson() throws NoSuchFieldException, IllegalA
> >          gson.toJson(new ListClassId());
> >
> >      }
> > +
> > +     @Test
> > +    public void testSingleObjectRead() throws ParseException, InterruptedException {
> > +        GsonBuilder builder = new GsonBuilder().registerTypeAdapter(Point.class, new RestAdapterTest.PointTypeAdapter());
> > +
> > +        final StringBuilder request = new StringBuilder("");
>
> Looks like the live above can be removed.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/aerogear/aerogear-android/pull/37/files#r2126765>.
>
>
Согласен, но jsLint с нами не согласен: просит все в одну var затолкать
Ох, это не очень хорошая практика. Если код встроить в работающее приложение, начнутся "чудеса".
why parametrize this if you're only going to use one parameter and name the test case specifically for the parameter?
Are you going to remove this so I can merge this in?
Also, I would argue that we don't care if it does a better job than `ShuffleSplit`. We just care that it does the job as expected. So, I would just remove the above inequality assertions (comparison with `ShuffleSplit`).
Never mind the previous comment. We need to know `X.shape[0]`, of course.
Maybe it would be easier to list allowed types?
has an unexpected behavior
don't modify self.random_state in fit otherwise a cloned version won't behave the same
just to random_state = check_random_state(self.random_state)
and use random_state
Does it also include the _attachments size? As the response on IRC sounds it's not included. But I can't believe it.
For refrence, these numbers are stored in the entities datatable
I was following a similar idiom used elsewhere in dmd.
subjects should be sent as a parameter - see the resting workflow.
Also do these changes for NativeTextFieldObject
This usage string is not correct anymore if adding optional params but making them look like mandatory.  It's probably worth it to use the default usage instead of requiring that the usage string be manually adjusted every time there's a change to the params.
runOnce means 'it's been compiled into a standalone executable that should run once and then terminate. Such a setup NORMALLY is not given a dali (but can be) and should assume dynamic/late file resolution.

standAloneDll means that there is a single query dll (either linked into the executable or loaded via topology file) rather than a set of then loaded via a querySet or passed i via a queue. If runOnce is NOT set, then that query is to be run repeatedly (every time XML parameters are received on a socket). If standAloneDll is set but runOnce is NOT set, then file resolution should be early just as in the standard QuerySet mode.
I'm not convinced you can break here you could still have later items which are now unreachable.  As you say it is debatable whether it is worth it.
As far as I can understand it this just means any expression that contains annotations is ignored.
Please change this to:

```django
<option value="{{ product_name }}" {% if product == product_name %}selected{% endif %}
>{{ product_name }}</option>
```

To avoid possibly DRY.
osfamilies are capitalized
And, it is removing the leading zeros, so it matches the AbnAmro format
Sounds good to me. I really had no idea on this :)
would it be hard to add a test for that?
You can get rid of all @uses annotations
you should also list them in the suggest section, explaining why they are suggested (see Composer for instance) so that composer suggests them to the user when installing
do not put the entire path to the jar. Look at how it is done above.
This should be `{% load thumbnail %}`
Maybe call it payment then since modal is a bit generic?
Not relevant to put in the properties in my opinion.
Lisa, please add and commit these files, as well:
INetworkPage.java
D3NetworkPage.java
N3NetworkTest.java
@shacker can we fix the double space before the `data-`?
`Integer/valueOf` heittää poikkeuksen jos `(str (numit fst))` palauttaa tyhjän merkkijonon, minkä se tekee jos `fst` ei löydy `numit` taulusta. Lisäksi `(numit fst)` palauttaa jo sinällään kokonaisluvun, joten `Integer/valueOf` kutsu ei ole tarpeen.
double space here, also, cuddle like you did the else:

} else if (context == ....