labofsahil/github-event-dataset-2012 huggingface dataset:
Do we need to worry about support language keys or anything like that?
Whitespace looks broken.
This was mainly to avoid calling `git_buf_free()` and `git_config_free()` then return -1 each time an error occurred. 
My goal was rather to reduce the code noise and ease the reading.

Considering this explanation, if you still prefer to avoid the `error` variable as much as possible, I'll gladly comply.
If you see the coverage that line is a dead line, it is never executed :)

http://linkedin.github.com/dustjs/cover_html/dust.js.html
automatically, as long as ``query_data`` is used inside the ``queryset`` method (which is the default).
Nitpick: A better name for this function would be `validate_reps_domain`. Even better, call it 'validate_domain` and pass in the list of valid urls as an argument.
Oops, lost in the [comments](https://bugzilla.mozilla.org/show_bug.cgi?id=768218#c2) was the idea of an ON/OFF switch for displaying or not. Everybody agreed that this was a good idea for setting up a new product for example without having it visible in the UI until everything is ready. (It would also allow us to have special products hidden from the UI if we ever end up needing that.)
This definitely looks wrong, I am not sure why it is working. But it should probably be passed a user instead of a profile.
I think this might be a good time to learn about jinja2 macros and create one for this instead of copy/pasting everything.

It would go here: https://github.com/mozilla/kitsune/blob/master/apps/search/templates/search/includes/macros.html

To see some example of other macros, check out https://github.com/mozilla/kitsune/blob/master/apps/wiki/templates/wiki/includes/document_macros.html for example.
Would You mind to change the beginning of the line too?

> Takes a __canvas__ as input ...

to
> Takes a __canvas.toDataURL()__ as input ...

or just
> Takes a __dataURL__ as input ...
The get() call above will thrown an exception if the user isn't found, so an 'if' statement doesn't make sense.
Always use 'you', not 'u'
I'm never too sure about this! But I needed the method 'strtod' defining, and this website http://www.cplusplus.com/reference/clibrary/cstdlib/strtod/ suggested I needed to include stdlib.
I think you meant retrofit-http
Can we drop `statusCode < 500`? Seems like we should still be reporting 500 errors back.
They are different, the getter provides the last used time of the session, as the array key stores now, which will be the the last used of next time the session is loaded.
For example if one read the cookbook entry about varnish and decides to 
install it, he will typically end up with apache listening to port 8080 
for eg. and varnish to 80. But if he didn't put any concern about 
security at system level, apache socket could be publicly accessible, 
thus making any client being able to fake user's IP by requesting 
"host:8080" with the forwarded-for header, this wouldn't be possible 
with the new method.
It's quite correct IMO (correct alignment of variables and descriptions), look at next line, as well as at others phpdocs in this file.
because the umask is a reversed bitset, so ^ does the same as ~ with the mask reversed with 0777. Both of those are true:

```php
var_dump(
    0755 === (0777 ^ 0022),
    0755 === (0777 & (0777 & ~ 0022))
);
```
Is the str_replace() still needed?
I would rather mark the test as skipped than tweak the expected value
you could write it using the JS way to handle default values for params:

```js
function minimizeLeftPanels(state) {
     displayState = state || Sfjs.getPreference('menu/displayState');
}
```
missing space after ``use``
@mvrhov But you have now `addViolationAt()` which behaves like the old `addViolationAtSubPath()`, please look few lines below.
yeah, if you need to do this in another place... i suggest extending uilabel and using a solution such as http://stackoverflow.com/questions/2711297/underline-text-in-uilabel

good for now though.
This somewhat violates our previous constraints that if something is a specific API call, it gets its own function and not trying to overload the base calls. i.e. there should be a retrieve_bindings and retrieve_binding
```ruby
describe "custom tag types" do 
  subject { TaggableModel.custom_tag_types }
  it { should include("language", "skill", "craft", "need", "offering") }
  it { should_not include(Tagtical::Tag::Type::BASE) }
  it { should == @taggable.custom_tag_types }
end
```

^^ Can you write rspec tests like this moving forward, I believe this is more inline with how rspec was meant to be written.
The way this has been designed, the ellipse is not propagated as is the case for the superclass. I think it needs to be.
В 90 строке по сути копипаст из `getRegistry()`
Надо подвинуть в начало списка импортов: сначала внешние либы, потом локальные
Is it not possible to remove comments in the view/display mode, so we don't need to do it in tpl's ?
I actually pulled that code straight from the red lines in https://github.com/drapergem/draper/commit/aeac106de53b69480cdfa224872cb4114174f3ac.
It looks really awesome. And from what I see the issue reported by @heynemann could be solved simply by adding something like this before calling paste_rectangle:
```
if (row_stretchy && col_stretchy) {
    target_x += target_width;
    source_x += source_width;
    continue;
}
```
This way the intersection between the stretching parts would be left with the original content avoiding the necessity of transparent pixels. As this may not always be the desired effect, what do you think about adding an additional parameter to the filter?
I changed the way that the app guesses what type of file or text block it is. So the user can just drag and drop text in the text box, or type it and the app will try to use some heuristics to import the data. 

The above object importType is created to hold confidence values and the corresponding function that should be called for that import type. If we add more import types, they shoudl be added here, and an if should be added below with some sort of measure to guess the import type.
Go look at the code before you made the change. The old signature had a force flag. You removed that and didn't update the places that called the method.
I really should get used to writing a code with notices turned on. Thanks.
Right again, putting this in a function
In handled_call.js, I mean :-)
nit: i would invert the logic, no need for negative logic where it can be positive :)
yes, fair enough for the sake of consistency but let me say that the type is redundant as per the HTML5 spec ... if no type JS is assumed thus we are writing redundant code  :)
no for the same reason than before

https://github.com/crdlc/gaia/blob/230ec01727a5651a0c465528821cee62697ca925/apps/communications/contacts/js/fb/fb_import.js#L703

in that case you are deleting from existingFbContactsByUid
Nope, is for avoiding using width: 100% and height: 100%, is just a different way to do it full app viewport :D
```
if (!this.previewRingtonePlayer)
```
You should keep var target = event.target, or you cannot get target.
And (!target.classList.contains('msg-peep-bubble')) will always be false.
Two things here:

1. The validity_time should be defined in one of the functions, perhaps right here before you fetch it.  Otherwise, as it is now it will only be set once when this library is first read, so it will be stuck in the past instead of reevaluating 'now' as it should.

2. I think you can make expired a normal Smartmin view which might be nice for consistency, it always feels a bit messing mixing Class based views like Smartmin's and the old Django views.. something like this maybe?

    class Expired(SmartView, TemplateView):
      template_name = 'smartmin/users/user_expired.html'
Why not do it here too just to make sure?
You should not add extra spaces after the opening bracket, not before the closing one.

     public function cleanDelimitedIdentifiers($identifier) {

Otherwise, should this method be `public`? I don't think. To set the visibility to `protected` seems better.
Sigh. I am a noob.... ;-D
Why are we deleting comments?
s/（スレッドカウント）//
Why is this ugly? Just because it's raw sql? :D

If you manage to produce this query string with ActiveRecord I'm happy to change it :-)
This should use the logger, using sentence case.
Good suggestions. Done.
I think this needs to be serializable.
This should never happen if route is validated correctly
https://github.com/MayhemYDG/4chan-x/blob/master/script.coffee#L645

But alright, I'll change that.
Changing that will return undefined from somewhere.
"nope" is not a good name for a login page, and you should be using the login page to handle login errors. Instead of doing customer `nope_num` error handling, use Django's form system and error handling instead. There's a built in contrib.auth form that handles this, or you can use one of several open source django apps that help here. No need to re-invent this wheel.
even easier :-) ok... I will close the pull, try to make my 2 commits one, sign the commit and PR again
This isn't needed any more.
incorrect indent.
I started not being a very big fan of RowVector and ColumnVector be different classes from Matrix.
This is not an unreasonable example, although the default `revlink` handler automatically handles github urls. (see https://github.com/buildbot/buildbot/blob/master/master/buildbot/revlinks.py#L36)
I think it should be moved under `href is undefined or` because if href is undefined, it will throw an error
Couldn't this break things for other people? How does amd know that we are providing less? Excuse my ignorance at AMD - can you point to any online resource about it?
I'm all for having auto support for a local settings file, but it should probably be its own issue/pull request. I'm not up on my latest Django best practices so it'd be nice to quickly figure out if this is the best way to handle it.
I get a ".git/hooks/post-checkout: 17: [[: not found" warning when running that. Do you know if know if there's a way around having the warning not pop up?
Hm, I think we should refactor this `:javascript` blocks to a js file or whatever. instead of adding more of them.
absolutely agree :)
Just mean don't sweat about stuff that's not on the list of things to deliver :)
Minded to split this in this in to a separate bootstrap as per chat with @ironsidevsquincy
ok. i fixed that in 2a079920072eeabc54ffae19c43425e9c58d52e6
Duplicate code: please factor out. https://github.com/jamescasbon/PyVCF/pull/42/files#L1R213
Could we do same as with `get faveicon` with a tile size matching one returned by desktop version of `getThumbnail` ?
I moved this code to bootstrap.js and now use a setTimeout before cleaning the loader.
Can you take another look?
@ochameau well if main module is relative `./main` all the relative dependencies (including nested ones) will also start with `./`. For example:

```js
"./main" // require('./foo') => ./foo
"./foo"   // require('./foo/core') => ./foo/core
"./foo/core" // require('../bar')  => ./bar
```

Not sure how to mention that in the docs though. Is it actually worth mentioning ?
Nit: I would encourage to stick full naming `event` used elsewhere.
oh ok.  that sounds good.  fixed.
this is definitely dead code, used for compatibility but the function is never called
This can just be `=$`, which is marginally cheaper, or even `name[-2..-1] == '='`, which is likely cheaper still.
It would be better to patch Exception and add `multiline` support, then handle the case where it doesn't do anything nice.

Also, please speak with @cprice-puppet about chained exception support, and using standard paths to report exception objects, in Telly.
Is it necessary to do the encoding check in each iteration of this loop? I think the compatible encoding could be determined once and only set afterwards then on each sub part.

Also determining the compatible encoding should probably only be done if the encodings are different. These kind of changes can have significant performance impact if not applied carefully. You could run the benchmarks in benchmark/core/string/bench_gsub to see if they have a big impact on performance or not.
We should just patch Sage here to send the right messages, rather than overriding the functions at this point.  In fact, we already have patches for the old Sagecell to send such messages; we just need to update the patches to send messages with the new IPython.
The data file that is output here is not easy to read outside of Python, and even there requires writing a dedicated script.
great point, hand't considered nesting in the factory case at all.

Also, how did you know my bank password?
I would find more logical to use a boolean for ``setDisabled`` than a string ``'disabled'``
I'd not do this as an elseif -- I think doing:
```
if (is_int($filter)) {
    $filter = new Filter\Priority($filter);
}
if (is_string($filter)) {
    $filter = $this->filterPlugin($filter, $options);
}

if (!$filter instanceof Filter\FilterInterface) {
    /* ... */
}
```
makes the flow more readable. I'll take care of this during merge.
Changed to 'zero or more' for readability, as well as to match the usage of 'zero or more' in the sentence that follows.
I didn't want to rely on any still obfuscated names in case they changed in the future. But if CraftBukkit were to de-obfuscate that method, then I can certainly change this code to use it.
Ah well we just crossposted :p
Superfluous cast + sizeof(char) is always 1.
I don't understand why you do that: the default value in ContextSettings doesn't necessarily matches whatever default value the attribute will have if not explicitely given.

The code would  be much simpler without it:
```
int attribs[] =
{
    GLX_DEPTH_SIZE, settings.depthBits,
    GLX_STENCIL_SIZE, settings.stencilBits,
    GLX_DOUBLEBUFFER, 1,
    GLX_X_RENDERABLE, 1
    0, 0
};
```
And didn't you forget the antialiasing? What's the purpose of the GLX_X_RENDERABLE flag?
I think we settled on `_normalizeLineEndings`. Also, I would probably have this return `array('expected', 'result`)` so the usage would be `list($expected, $result) = $this->_normailizeLineEndings($expected, $result);`
I think there might be a method in the BlockIterator that does this (finds the first hit block)?
Oh, yeah. You are right.
> another way is to create a "server" and "client" dir... so, everything in "server" dir is made available only on the server

Can you do that here too, with the libs?

> implemented todomvc with authentication, where i used this approach

Nice! 

Can you add it to our Wiki with a short description? 
https://github.com/addyosmani/todomvc/wiki/Other-implementations
+1 if we can avoid overriding this in JS that would be great. It also allows us the flexibility to make changes to the template in the future without worrying about anything other than markup and CSS.
+1 for content :)
Were these tests move somewhere else or made redundant or were they just not helpful?
wrong indentation (one level too much
Maybe we could receive the dict as argument (the default would be Orddict.new) and simply call `Dict.put`? This way a developer can pass any type that implements the Dict protocol as argument :)
Looks like the implementation of ```getName()``` in the other field types relies on ```acceptValue()``` which makes sense.
I will therefore do the same here and this will also throw a InvalidArgumentType in case of bad inpu.
This comment belongs down below with the GeoDist class
This is added because we create new instances of self inside. 
So user can change default behavior for all instances at once.
what'S the benefit of doing that?
In this case, isn't `returnValue = fn()` sufficient?
You could make it easier to avoid rerunning multiple times if mutiple keys are missing, since log.error will exit. For example,

~~~~
missing_keys = [key for key in self.mandatory if not key in local_vars]
if len(missing_keys) > 0: # or missing_keys == [], whatever floats your boat, I prefer the latter, others the former
    self.log.error("The following mandatory variables were not provided: %s" % (missing_keys))
~~~~
No need to zero the time components since they are not asked for in the bit mask
Sande why is there a / after README.md in the link? It's not usual...
Likewise, it's not necessary to declare a `lazy_attr_reader` if you're going to define a custom reader, like this one. It should be one or the other.
Just a suggestion: should this be parametrized? If one link fails the loop will exit and the test doesn't provide coverage on the other links.
I'm gonna switch to using is_element_visible which will show the actual element with the error. For example

self = <tests.test_mission.TestMissionPage instance at 0x101b81d88>
mozwebqa = <mozwebqa.mozwebqa.TestSetup instance at 0x101b98440>

    def test_sidebar_links(self, mozwebqa):
        missionPage = MissionPage(mozwebqa)
        missionPage.go_to_page()
>       Assert.true(missionPage.are_sidebar_links_visible)

tests/test_mission.py:10: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <pages.desktop.mission.MissionPage object at 0x101b8f990>

    @property
    def are_sidebar_links_visible(self):
>       self.is_element_visible(*self._mission_sidebar_link)
A docstring here describing what types index, start and end are expected to be would be helpful.
Isn't there a better way than this "busy waiting" implementation?
I believe we'll want to convert this to `listenTo` but will do that in a 0.9.9 branch after we merge.
Since you ended up not using the Framework (http://www.zotero.org/support/dev/translators/framework), you can remove this line.
I see your point about seeing that things happen. Maybe it should be as simple as a System.out.println in that case, so people will know not to reuse it :)

You get a counter framework by integrating with base, and I think use of it should be mandatory. But I guess we can put that on the backlog for the next phase along with the archetypification.
minor nit.  need a period
don't assign the instance variable at all if you're not going to use lazy loading
Didn't even notice i did that. Wholly unnecessary - but technically nicer ;)
i.e. the makefile is just a scaffold. TJ, perhaps the ability to define your own scaffolds would solve these types of issues.
Yes, indeed, but it is kinda entropic IMO :)
proving me wrong by providing evidence. I like it!
We could pass this as data instead of username (the User interface is freeform)
@bretman could you fix the indentation for this controller?
interestingly enough, when i used self.timeout, the native tests were still failing, but when i switched it to hard-coded they passed.
The description is in the link.
Or the ketchup? We have a lot of condiments to catch up on
MUCH cleaner
This isn't right. According to the standard, "Request and Response messages MAY transfer an entity if not otherwise restricted by the request method or response status code" (section 7). 

Only TRACE method explicitly forbids the inclusion of an entity body.

Seems like what we actually want to do is to not include entity headers unless we're including an entity body.
I'm not certain this mapping behavior is appropriate for this function to do. I understand it's common, but it's something the caller needs to know regardless. So in that case, I'd prefer to make it more explicit by having the functions applied by the caller rather than passed in here.
This can perhaps be a separate card, but for reports i think we absolutely need to implement "spool to disk on error" behavior. Unlike catalogs and facts, I don't think we'll get another shot at storing a report if the first attempt fails.
This should also take an optional replyTo parameter, in favor of the function below.
This can be ``private``
Here I divided up these sections to apply them to the new outline:

- Features of Liferay WCM [move to 5i]
- Simple content creation [move to 5ii & iii]
- Publishing content [move to 5 iv]
- Structures and Templates [move to 6 i-iii]
- Permissions [move to 6 iv]
- Tags and Categories [move to 6iv]
- Staging and Workflow [move to 6v]
This is the old plugin base class module. Have you read [How to Write a Plugin] (https://github.com/sosreport/sosreport/wiki/How-to-Write-a-Plugin)?
should just have used a page-link class with appropriate data attribute?
Don't do this in memory do it in a query.

Add a finder method called activated and just call `Cohabitant.activated' here instead

```ruby
# /app/models/cohabitant.rb

def self.activated
  where(activated: true)
end

```
Ups ... ;-)
@fljot Спасибо за обьяснения. Хотя, пока что я не вьехал в эти тонкости, но думаю, со временем, ко мне это придет.
Категорию лучше вынести в отдельный файл (в Xcode есть специальный шаблон для этого).
Согласен, но это всё пока что на что хватило моих знаний. Выбор случайных для меня пока не под силу.
Менять нужно "**СТРОГО Х ПРОЦЕНТОВ**", чего ваш метод вдвойне не гарантирует, так как помимо использованного индекса замена может произойти на самого себя, что в конечном итоге заменой не будет являться вовсе.
согласен, например, #define MAX_HROMOSOM 100
Так по умолчанию делаюет ObjectiveC
Я с вами обсуждаю реализацию механизма. Если я вижу, что механизм реализован не верно, то в main.m я могу и не смотреть.
Why not just "return impl == null ? null : impl.getServer();" ?
Replacing this with (flag << 1 == ROOM_GODROOM) or (flag << 1 == godroom) or either method with quotes around the god room string still fails.  I searched the code for references to things like "<< 1" or "<< 1 ==" and didn't find any references to strings after "==".

How is this supposed to work?
highlight "user"?
tiny thing, but when I have code like this, I like to use

```python
params.update({
    "indicators": ...
})
```
just more readable, less noise
`Expr.php` has:

```
public function getQuery()
{
    return $this->dm->getUnitOfWork()
        ->getDocumentPersister($this->class->name)
        ->prepareQuery($this->query);
}
```

Perhaps we can test this in the functional QueryTest class?
Sending `RACUnit.defaultUnit` seems more appropriate, since that's what other methods send as a placeholder value (e.g., `+whenAll:`).
This should be changed to `Robot = require('hubot').robot()`.
One hubot convention is actually `foo me`. So, if you wanted to go with that, it'd be more like:

     robot.respond /(commandlinefu)( me)? *(.*)?/i, (msg) ->

You would also not want to capture commandline all these groups. The commandlinefu part actually doesn't need any parens around it. For the `me`, you can add `?:` inside the parens to do that:

     robot.respond /commandlinefu(?: me)? *(.*)?/i, (msg) ->

That would mean it'd be msg.match[1] below.
I would actually prefer `HUBOT_JENKINS_USER` and `HUBOT_JENKINS_PASSWORD` which makes it easier for users to set up and use.
没有的吧，builder可以build不用loader的cache。
I was going to ask about the test. I added this one just to make sure that repo.Config could be enumerated. I think I'll change it to check for certain values (from the other tests) in the enumeration.
fair enough but let's make it nice for circles first IMHO
why do you need to store self._epoch_step if you have self.downsample?
let's take care of this in the ICA PR then.

if you're ok close this one for now
remove blank lines btw parameters
@rrjamie If the `bld` doesn't exist - this will fail. We probably want to fail if we can't remove it, but not if it doesn't exist?
if it's not needed remove it.
It's too brittle to add this snippet to all validators. It shouldn't be necessary if ValidateUtil.validate was used consistently in all places.
This and all others should just say @since 1.9.2 (since nothing in the 1.10 line is actually released)
It feels like there's an extra comma in the previous sentence after "a decision has to be made".
nothing changed, just moved
This should be 

    // ... you might log something here
``tricky``
I think you need to mention that the Request class has methods that do the work for you and list them.
The temporary `Array[Byte]` buffer makes no sense. Just use the proper `ByteBuffer.put` API.
I'd suggest removing all these hard-coded StringProducer and ProtobufProducer and whatnot since it both pollutes the namespace, is hardcoded and doesn't really provide any value from my perspective. When using Akka Serialization I don't even see the need for them. Wdyt?
Эм, щито? Ты добавляешь аккаунты в сторедж из вкладки-редактора? Этим скорее ядро или какой accmanager заниматься должен.
Acá falta un espacio, puede que esta instrucción no esté funcionando.
Una búsqueda rápida me mando a:
http://www.utnianos.com.ar/foro/tema-gremio-de-sistemas?page=2

La matricula sería un dato más, que le parece importante a la cátedra y
creo que no nos perjudica agregarlo.


2012/11/6 Alpha <notifications@github.com>

> In entregables/site/Docs/Proyecto/Retrospectiva-Proyecto.markdown:
>
> > +
> > +* Separar el rol de edición de postulantes del de empleados de manera de permitir a otros empleados editar los postulantes sin acceder a información confidencial de los empleados.
> > +* Indicar que tan reciente es la información de los postulantes.
> > +* Indicar que empleado realizó una entrevista.
> > +* Indicar las entrevistas de idioma
> > +* Sistematizar la carga de las entrevistas de manera que pueda ser útil para seleccionar postulantes.
> > +* Medir efectividad de las búsquedas.
> > +* Publicación de búsquedas en redes sociales. Que el que siga el link caiga en página para registrar sus datos como postulante, quede automáticamente asociado a esa búsqueda y se envíe notificación por mail a RRHH.
> > +
> > +### Administración de los almuerzos diarios
> > +
> > +Si bien no es una tarea puntual del area de RRHH, es una resposabilidad de esa area y ahora mismo no está funcionando bien. Considerando el tiempo invertido por cada empleado en mantener su menú actualizado y las confusiones que constantemente ocurren, creemos que sería bueno sistematizarlo. CommonJobs es la plataforma ideal para hacerlo. Eso además permitirá que el sistema sea utilizado más ampliamente en la empresa y que se proyecte como plataforma (uno de los objetivos originales).
> > +
> > +### Empleados
> > +
> > +Se agregará la matricula a los datos del empleado y en la página de legajo.
>
> ¿De dónde sale esta matrícula? ¿Es algo que Gabriel tiene? (¿Es el número
> de legajo?)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/216/files#r2042286>.
>
>
This should be private and a protected accessor used if necesary
Fixed (along with others) in commit 119eb7f5e19b495566b74e14e0990ab743bfe894
Thanks for noting!
Don't we need to drop this?
Another on to be removed. No System.out calls.

If you wanna log something, using the logging framework we provide and add meaningful messages :)
Typo in the javadoc
yes, this is picky but, can you add a space before the '.video-container a' string?
I just used it because it appeared to be needed. Will be fixed in the next commit.
Thank you for catching that. I will push an updated fix soon.
You might want to note here or elsewhere (footnote?) that the qualitative schemes here are illustrative, and that ordinarily they should be generated as discrete maps for the particular number of colors needed, not at quasi-continuous maps.   You could even include a reference to the colors.ListedColormap class.
Actually, I think that the most simple example possible with matplotlib should be front-n-center

However, isn't "ipython -pylab" deprecated for "ipython --pylab"?  Of course, we would have to consider when they starting allowing the double-dash.
Unless I am mistaken, this is going to have a side effect on subsequent tests. Perhaps the image comparison decorator should accept a dictionary of overwriting rc params...
Aha! Typo. Wow that took much longer than I expected.

It should be `from numpy.testing.utils import assert_array_equal, assert_array_almost_equal`. You will also need to change the call to this method in the symlog test.
Had a look at this and typically we would wait for an element to appear that signifies the alarm has been created.

We could do it here by creating a unique label at line 33 and then waiting for that to pop up after you have clicked Save.
I tried that at first, it does the first cross fade nicely, but anymore after that. Couldn't figure out how to reset it for each round (tried increasing loops count, etc), so I chose that approach instead.
и нормально берется константа из интерфейса? не знал ....
Not sure it's really necessary if we only use it once.
@bp323 Since there are no changes, we shouldn't be modifying this line.
I'm actually not sure how screenreaders would handle this, could you try and get in touch with Joe or look at similar cases in the UI?
@christianv - /dev/images/signup_commentbox_bg.png is a single flat color (#e3f0f6).
@arnodeclercq Please use single quotes here.
No need to define a function and then execute the hover functions. We can just do something like `$widgetsExposed.hover(hoverIn, hoverOut)`.
Again, I think this method can be shared across the ContentQueryHandler classes.
If exposed interfaces are enumerated only those that are enumerated are used.
so import_array() is always done?
You should add a `set_enabled(false)` in here
A lot of these `use`s are never used. Same goes for other `Commands`.
This is a test of a comment. Play Nice.
"Your" => "The" (in all of these down through DELETE_FAIL) ?
Could do without the part in parentheses (erm, I mean, brackets).

Possible rewording?

> Are you sure you wish to data this extension's files and clear its data? This cannot be undone.
If you know a sensible way to do that that doesn't involve a ton of work, I'll be happy to add it. However, this is not all that important here because the user has to manually put the plugins into the plugins folder. If we want to have plugins downloaded from a server, we need to pay much more attention to security measures.
vllt. aber ich weiss nicht ob wir das wirklich noch vor dem review machen wollen....
Can we render this as a "No valid CAS token supplied" error?
нарушение CodeStyle (CS)
I'll fix those up in the next batch.
Deleted :-)
Awesome, looks a lot cleaner this way!
Super nitpicky: If the actual numbers aren't important here, might be better to use strings like 'a', b', ...
Hm, but it works nicely. :-) OK.
In case key is not present exception will happen and will not execute that statement. I'll fix it anyway.
A comment describing this form template would be useful.

Also `spaceless` tag is useful to remove all this newlines and so on. Because newlines in HTML are understood as spaces in inline context, you could get some unwanted space around labels, buttons and so on. Maybe in our case this is nothing wrong. But check it, maybe things get better. Or not.
I would set those values only if they were specified in registration? Or do you prepopulate from existing user object? So if fields have values from linking?
```
if (!$(this).val().trim()) {
```
Name this variable better, please.
I was tried to fix this. Check if it is correct.
Missing `;` at the end.
I totaly forgot about this comment. I will delete this.
Dne 26. apr. 2012 18:33 je "Mitar" <
reply@reply.github.com>
napisal/-a:

> > @@ -0,0 +1,32 @@
> > +from tastypie import authorization, fields as tastypie_fields
> > +
> > +from tastypie_mongoengine import fields, resources
> > +
> > +from piplmesh.account import models as account_models
> > +from piplmesh.api import models as api_models
> > +
> > +#override dispatch_details ali pa post_detail / obj_create
>
> Write as a TODO comment, when you do such comments. :-)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wlanslovenija/PiplMesh/pull/148/files#r739858
>
Sorry for the delay. I've tagged v0.1.0.  That's our first tag!
Ah yes. No need to log for ==.
The line right before it. I have to turn the generator into a list.
No need, it will fail anyway once passed to the `MapResolver` or `PathStack`. Better to let it fail hard with a noticeable recoverable fatal.
The thing is there are 3 possible ways to call getBalance:
you can: Not pass ReturnAllCurrencies (it's an optional field)
you can pass '0' as ReturnAllCurrencies
you can pass '1' as ReturnAllCurrencies

The docs don't seem to indicate what the default behavior is, so I am trying to not guess it but respect the 3 ways that you can call the method
https://cms.paypal.com/us/cgi-bin/?cmd=_render-content&content_ID=developer/e_howto_api_soap_r_GetBalance
I feel like this needs to be harsher. He'll just trade away Ally cards with Trash effects.
What does "It" refer to here?
Might set the url to a variable just above this with a TODO comment for students to fill out.
I had to do this so that it would not use the uafthesis that is installed with texlive
Does this give a meaningful error message if fs is null? If not, it would be good to add one.
yes, it is inadequate, and I would like to implement it the way you explained. However I think dvryaboy would like to maintain it in order to preserve the single-arg constructor for backwards compatibility. I'm thinking in three constructors: the no-arg constructor, a single-arg constructor for backwards compatibility and a two-args constructor with the options.
I see - so use hasattr and check that callable(getattr(received, 'join')) is True?
Missing ui string?
`\u0009`, `\u000A` and  `\u000D` are valid characters in XML, they don't need to be escaped.

Has someone tried to run DFL in text/html? There are some unknown elements, but that shouldn't be really a problem technically?
The pattern here is partial invocation. I would try to do that always with bind, e.g. have the returned function signature as state, token and then bind it with state where you need it.
Never mind. Not sure what went wrong in my brain when I was looking at this, but for some reason I couldn't see that `num` is being used below.
Technically it is called twice (in your code too) if the right conditions are met.
this will break if loc is not passed, which it has to be sometime, no?  That is why there is the `variable=None` structure.
`$(which fasd)` is not necessary. It checks for its presence on line 9. 

Zsh has a bunch of useful associative arrays: `$commands`, `$aliases`, `$functions`.
... or if n_obs is too large before n_vars.
missed a property substitution - I'll merge the pull request & fix it
я забыл, у нас их же несколько может быть? давай сделаем .split() и for?
Good point, this is left over from printf style debugging and should be removed.
> > -        # store some more information
> > -        self.interpolantxy = interpolantxy
> > +        # Set default interpolant if none given
> > +        if interpolant is None:
> > +            interpolantxy = galsim.InterpolantXY(galsim.Linear())
> > +        elif isinstance(interpolant, galsim.Interpolant):
> I can add that warning, but FYI this was also the case previously. Any InterpolantXY was accepted and used without checking if its i1d is a Linear instance. I just added the functionality of not requiring the user to hand-wrap a 1-d Interpolant into an InterpolantXY.
> 

Yes, that's because before, if someone tried to interpolate on the grid, they would be told that that functionality wasn't implemented.  (For that reason, the keyword for interpolant was kind of pointless before - it was a placeholder for the future intended usage at non-gridded positions.)
I think this should probably be moved into the PowerSpectrumRealizer `__call__` function.  That's the only place that uses it, so that's really a better place for it.  Also, the `from math import log` line should be removed.  It's only used by the NFWHalo `__ks` function.  Since the other function in that class use `np.log` instead of `math.log` or just `log`, it would probably be better to use `np.log` in that function as well.
I understand your reason for replacing this parameter, but this is an interface from our devices and I was not planning to change this interface.
Java 7 has glob support, targeting file paths: http://docs.oracle.com/javase/7/docs/api/java/nio/file/FileSystem.html#getPathMatcher%28java.lang.String%29
as linked to from http://stackoverflow.com/questions/1247772/is-there-an-equivalent-of-java-util-regex-for-glob-type-patterns

Most people say there's not one, but there are links to jakarta's GlobCompiler and GlobEngine. Not worth pulling in other dependencies for this, I think.

But shall we ensure we exactly follow the same syntax as Java 7 FileSystem, so that we can easily document it?
Do we want to continue to support this kind of discouraged non-static effector?
Do you view the "discouraged" warning as like deprecated, where we'll remove support in one or two versions time?
And are we leaving support in because it's necessary for backwards compatibility?
Validate and throw InvalidArgumentException if invalid.
Great, I'm really glad you like it! I wish more people/languages would express the difference between a *"function"* and a *"procedure"*.
buildING :) mais sinon c'est mieux oui
위에 얘기했듯 변경안하기로 결정했습니다.
Split into two. Different expected output for replicaset and standalone
@zberentey Hi Zsolt, please clarify what is intended by the part of the description that states "..., this method must , ...". It seems as though some text may be missing. thanks.
I think there is utility in still providing a mechanism for checking the driver has found a legit device (i.e. the device ID checks here previously) so we can enter a sensible panic state if not.
Lets use the same implementation for both reg season and round robin and rename this to populateFutureMatches() for now.  Still need discussion on how to get this functionality closer to the plugin, if possible.
Line wrapping seems weird here.
There's not much difference anyway. The only dismiss block I see has a 

```
if (1 == buttonIndex) {
//...
} else {
//...
}
```

So -1 would have the same effect as 0.
Yeah, but the mechanism only allows passing one thing back, and this is certainly not sufficient in this case.  Everything doesn't fit into a "one string and one string only" methodology. I'm open to alternatives, of course.
Perhaps we could use a string template for this instead.
Not called `aSuperNode` in the function. There are a couple "supernode" references in this PR, but it looks like you decided to go with "selection", so you might want to go through and change all of them.
How about an out of range test? 0,5?
I would suggest changing 'user' to 'credentials'
Changed.

Well put.
The principal reason I did it using a signal was the usage of threads in the application. Using signals it is easier to support errors even from threads in the future.

But if my worry is unfounded, I can change this in few days like you outlined - it's not a big change.
I guess you could omit  the second param 'false' here. JS defaults to  'null' if a param isn't there.
for readability it might be ok to have it here though.
Watcha think?
seriously.  :)
The "PCD" paper kind of undersells it, what you want to look at is the Laurent Younes paper "On the convergence of Markovian stochastic algorithms with rapidly decreasing ergodicity rates", which he cites (the contribution of the PCD paper was basically making this known to the ML community and demonstrating it on RBMs). There you get guarantees of *almost sure* convergence to a local maximum of the empirical likelihood, provided your initial learning rate is small enough. If you see things start to diverge or oscillate then your learning rate is probably too high.
Shouldn't ``svd_restarts`` be incremented here?
I think you should just not implement it instead of raising a ``NotImplementedError``. We often use duck typing.
I  would say: 

The non-determinism comes from comes from the ordering of the dataset: deciding on which cluster...
Maybe add `centroid (mean)` ?
@glouppe What numpy version do you have? I use ``'1.6.1rc3'``, maybe that's the problem...
I think we can't get more from that SCR call.
Couldn't this be combined in one if? Also don't we need check on NULL here for obj?
We should get the version number from the same place the mobile sdk gets its version number.  Not necessary now, but a TODO at minimum so it doesn't fall in the cracks
because this signal wasn't implemented, i commented this connect function
Native BB10 has a call to get screen properties:

screen_get_display_property_iv()

We can use the parameter SCREEN_PROPERTY_PHYSICAL_SIZE and SCREEN_PROPERTY_NATIVE_RESOLUTION to calculate the DPI.
Changements sur le doc sql : done.

Oui on a besoin d'un chemin pour les docs. Au début j'avais fait sans : pour récupérer la propale de l'étude 212XXX, il suffisait de prendre le fichier PC-212XXX.docx dans le répertoire de l'étude. Mais ça impliquait beaucoup de choses : 
    -  lorsqu'un admin uploadait un fichier, ce dernier était renommé pour correspondre au bon nom et qu'on puisse ensuite le retrouver. Du coup l'admin n'était plus maître du nom de son fichier, et s'il allait "manuellement" dans Trace par la suite, ça pouvait le troubler de ne plus trouver son fichier (genre 2semaines après).
     -  le fichier sur l'ordi de l'admin n'avait plus forcément le même nom que dans Trace -> là encore ça rend tout confus.
Why .map instead of .each?
spacing before column ;)
There is only a special CHqlDatasetParameter because all datasets implemetn the IHqlDataset interface.  Currently dictionaries don't have a special interface.
which see?
missing a ```return true;``` here
CONFIG_SOURCE_DIR from "build-config.h" can be used instead of ENVIRONMENT_SOURCE_DIR
yep.
I think if (t && link) - would be an error, but handled before gets here.
WIth that loop you'll end up with a sentence like:

```
foo, bar, and baz
```
when grammatically it should be
```
foo, bar and baz
```
Look to use `{% if not forloop.last %}`
See https://ci.mozilla.org/job/socorro-crashstats-github/57/console
Also, you said `|string` is to convert `None` to `''` which to me feels totally wrong.
Is this really a routing issue? Routing doesn't know about the existence or not of an appropriate dispatch logic behind a matched request.
Done


On Thu, Sep 20, 2012 at 2:29 PM, dmansen <notifications@github.com> wrote:

> In src/main/java/com/cloudmine/api/CMApiCredentials.java:
>
> > @@ -47,11 +48,14 @@ public static synchronized CMApiCredentials initialize(String id, String apiKey,
> >                  throw new CreationException("Running on android and application context not provided, try passing getApplicationContext to this method");
> >              }
> >
> > -            Class.forName("com.cloudmine.api.DeviceIdentifier").getMethod("initialize", contextClass).invoke(null, context);
> > +//            Class.forName("com.cloudmine.api.DeviceIdentifier").getMethod("initialize", contextClass).invoke(null, context);
>
> ah, got it. we should take out the commented line regardless though
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cloudmine/cloudmine-javasdk/pull/18/files#r1653951>.
>
>
You may want to just set units to 'km' instead of throwing an exception - we assume a default of km in most places.
@shacker this feels pretty inconsistent with the groups implementation. In /groups we have the actual site_url property, here we don't. You don't need to fix it in this jira, but could you open a jira for this?
This `if` can be simplified to:

~~~clojure
(and (<= x1 x x2)
     (<= y1 y y2))
~~~
I like ```.nil?```  =)
We must think about code reuse
Imho t's just misleading in this case, as this attribute only defines which unknown variables will be selected from the design matrix and 8 is always part of `_coeffs`. You say logic is not the reason for your concern and I don't think the list concetenation makes much of a difference in terms of performance, does it? So, what is the actual reason for your suggestion?
I think `kind` is not really shadowing the outer scope variable since the outer scope `kind` is not visible from the inner scope (unless a `nonlocal kind` is added to the inner scope)
Since 1.3.1 :-)
Why don't provide a sensible default for `projection` like we do elsewhere?
If a function sometimes returns something and sometimes not, I would usually do `return undefined`.  If a function never returns anything (as if it were void), then just `return` is fine.
Done.  Thanks.
@mrmattf  I improved these specs to make better use of the Jasmine spy system, which already has the ability to capture and assert on the parameters that were sent by our code to the mock XHR class.  Take a look.
I am wondering if we can fix this by doing a few things:
1. Create a CircleView
2. Use Wheels domain object (model), since this is the object we are actually sketching.
3. use the Wheel.shape = draw.circle(action[1], action[2], 4);
4. Create a CircleRenderingHandler
5. bind the view events to the CircleRendering Hanlder and to a given channel. Behind the scenes we are binding the events to the circle (shape) handlers.

This way we are dealing with a model (circle or wheel). I am confident this may fix the problem. The fact that all this code, the one dealing with drawing a circle, is handled in the view breaks the MVC. This code will be better place in a model object rather in the view.

I am willing to discuss this approach if u want to.
`final` not needed here .. Same for other methods in this class without anonymous class instantiation.
Fold the driverGlobal.harnessTemplateDir and * into the path.join
len doesn't appear to be used but once...could remove it and just use windows.length - 1 to save some bytes.
I didn't want to put more into Paul's pull request, but I've opened a new ticket to supplement the existing doc for Ti.Proxy.
https://jira.appcelerator.org/browse/TIDOC-668
remove inline styles and replace with a class.
For some reason I'm not seeing your original comment about this (yay github?). It's not the JavaScript way to use unnecessary parens (code size trumps all afterall), but since this is server-side code and not being transmitted over the wire, then it's not a big deal.
android has INPUT_BUTTONMODE_NEVER as well
Methods should start with a lowercase letter.
Actually `self.embedded_list_docs` is used to verify we are adding to the current document when processing a list of embedded documents.
Just use native method `forEach`
There is no need to reply fixed to each line note, it will show up in the discussion as ` discussed an outdated diff 4 days ago Show outdated diff` 

You can leave one final comment when you're ready to be re-reviewed.
I think I added this issue in previous html rewrite. I've opened issue https://github.com/jquery/download.jqueryui.com/issues/65 to fix this.
I'd say this is backwards - we should only specifiy `fail_fast` in the code in the cases where we *must* or *can't* fail fast, so the argument should override the config
We should add some tests with null functions, and also one where we pass in no functions, and one where we pass in just a function. You get the idea.
How about reordering attributes as in http://svn.apache.org/viewvc/maven/archetypes/trunk/maven-archetype-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml?view=markup
That is: namespace declarations first (with `xmlns` before `xmlns:xsi`; and they fit on the first line), then `schemaLocation`, then _real_ attributes for the element (on their own line, as the `schemaLocation` is a very long line already).
nits aside, I think you've used color really effectively in these exercises!
Agreed. I was just getting used to using xformat exactly because of format's problems.
I don't think popFront was supposed to be property, you'd better check this.
nit: add empty line above /**
We should consider refactoring this and the service recipe stuff into a library
... and a space here, after `(array)`.
I think newPost and insertPost should be separated. That is - clients should have to write:

insertPost $ newPost myprms

or just rename newPost createPost or something.
the format should be determined via https://github.com/FriendsOfSymfony/FOSRestBundle/blob/master/EventListener/FormatListener.php#L101

aka imho this code should rely on the format being set properly. if necessary move the FormatListener up in priority.