[V8] Clean up V8DOMWindowShell's reportUncaughtException
https://bugs.webkit.org/show_bug.cgi?id=95126

Reviewed by Eric Seidel.

This patch changes reportUncaughtException to operate in terms of a
DOMWindow rather than a Frame. In general, the bindings should use
DOMWindows rather than Frames because a DOMWindow is specific to a
given Document whereas a Frame displays many Documents over its
lifetime.

I've also updated some variable names to be more consistent with WebKit
naming conventions.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportUncaughtException):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] Clean up reportFatalError in V8DOMWindowShell.cpp
https://bugs.webkit.org/show_bug.cgi?id=95124

Reviewed by Eric Seidel.

We don't need a PLATFORM(CHROMIUM) ifdef because MemoryUsageSupport has
a stub implementation on non-Chromium platforms. These comments are out
of date. We've been "temporarily" calling CRASH here for as long as the
bindings have existed and we don't plan to stop.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportFatalError):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix compiler warnings in TextureMapperLayer.cpp
https://bugs.webkit.org/show_bug.cgi?id=95128

Reviewed by Noam Rosenthal.

Fix the warnings caused by -Wsign-compare.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::shouldKeepContentTexture):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Gardening: Skipping tests due to JSC::Bindings::Instance::createRuntimeObject(JSC::ExecState*) crashes.
https://bugs.webkit.org/show_bug.cgi?id=95116.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-27
Reviewed by Sam Weinig.

editing/pasteboard/paste-TIFF.html
platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html

* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Make RenderBox::computePositionedLogicalHeight const
https://bugs.webkit.org/show_bug.cgi?id=94984

Reviewed by Ojan Vafai.

This is step 1 in making computeLogical{Height,Width} const.
computeLogicalHeight calls computePositionedLogicalHeight, so this patch
makes that const first.

No new tests, just refactoring.  Covered by fast/block/positioning/differing-writing-modes-replaced.html
and others.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight): Call const version of computePositionedLogicalHeight.
(WebCore::RenderBox::computePositionedLogicalHeight): Make const, fills in struct instead.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Make const
and pass in a LogicalExtentComputedValues struct instead of 4 separate args for the results.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced): Make const, fills in struct instead.
* rendering/RenderBox.h:
(WebCore::RenderBox::MarginsComputedValues::MarginsComputedValues):
(MarginsComputedValues): Struct of just margins.  Not used yet, but will be for
computeInlineDirectionMargins and computeBlockDirectionMargins.
(WebCore::RenderBox::LogicalExtentComputedValues::LogicalExtentComputedValues):
(LogicalExtentComputedValues): Struct to be used by computeLogical{Width,Height}. Only used by
computeLogicalHeight so far.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Clean up dependencies of WebScrollbar and WebScrollbarLayer
https://bugs.webkit.org/show_bug.cgi?id=94996

Reviewed by Adrienne Walker.

Source/Platform:

This moves the WebScrollbarLayer::create factory out of #if WEBKIT_IMPLEMENTATION and expresses it in API terms
only so anyone who can get a handle on a WebScrollbar can construct the layer. Also removes the ::create() from
WebScrollbar, anyone who currently has access to a WebCore::Scrollbar also has access to WebScrollbarImpl.

* chromium/public/WebScrollbar.h:
(WebScrollbar):
* chromium/public/WebScrollbarLayer.h:
(WebScrollbarLayer):

Source/WebCore:

Moves WebScrollbarImpl into WebCore/platform/support to make it accessible to chromium-specific WebCore code and
uses it to construct WebScrollbar instances around WebCore::Scrollbars.

* WebCore.gypi:
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
* platform/chromium/support/WebScrollbarImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarImpl.cpp.
(WebKit):
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::isOverlay):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::location):
(WebKit::WebScrollbarImpl::size):
(WebKit::WebScrollbarImpl::enabled):
(WebKit::WebScrollbarImpl::maximum):
(WebKit::WebScrollbarImpl::totalSize):
(WebKit::WebScrollbarImpl::isScrollViewScrollbar):
(WebKit::WebScrollbarImpl::isScrollableAreaActive):
(WebKit::WebScrollbarImpl::getTickmarks):
(WebKit::WebScrollbarImpl::controlSize):
(WebKit::WebScrollbarImpl::pressedPart):
(WebKit::WebScrollbarImpl::hoveredPart):
(WebKit::WebScrollbarImpl::scrollbarOverlayStyle):
(WebKit::WebScrollbarImpl::orientation):
(WebKit::WebScrollbarImpl::isCustomScrollbar):
* platform/chromium/support/WebScrollbarImpl.h: Renamed from Source/WebKit/chromium/src/WebScrollbarImpl.h.
(WebCore):
(WebKit):
(WebScrollbarImpl):

Source/WebKit/chromium:

Fix up tests for API changes.

* WebKit.gyp:
* src/WebScrollbarLayerImpl.cpp:
(WebKit::WebScrollbarLayer::create):
* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove uses of TypedArray ClassInfo from SpeculativeJIT::checkArgumentTypes
https://bugs.webkit.org/show_bug.cgi?id=95112

Reviewed by Filip Pizlo.

Removing these checks since we no longer need them.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Hook procedure should check to see if hook has already been removed before attempting removal.
https://bugs.webkit.org/show_bug.cgi?id=95118

Reviewed by Simon Fraser.

When the hookFired method in LayerChangesFlusher.cpp gets called in response to a message posted to the message queue
it calls CallNextHook to pass the message to the next hook procedure in the hook chain.

Sometimes, the message can get passed to another hook procedure that can dispatch another message.
This message gets passed back through the hook chain and we eventually re-enter the hookFired method.

When that hookFired call completes, it may remove the hook.
When CallNextHook returns, the original call to hookFired may try to remove the hook as well.
However, there is no need as the hook as already been removed.
This results in an assertion failure, assert(m_hook), when we call removeHook.

* platform/graphics/ca/win/LayerChangesFlusher.cpp:
(WebCore::LayerChangesFlusher::hookFired):
Simply check to see if the hook has already been removed before actually trying to remove it.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening.

* platform/chromium/TestExpectations:
Marked some position: sticky tests as failing due to sub-pixel layout.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r126772.
http://trac.webkit.org/changeset/126772
https://bugs.webkit.org/show_bug.cgi?id=95137

"This change breaks news.qq.com" (Requested by leoyang on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-27

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Test expectation for fast/js/constructor-length.html
https://bugs.webkit.org/show_bug.cgi?id=95125

Patch by Leo Yang <leoyang@rim.com> on 2012-08-27
Reviewed by Yong Li.

* platform/blackberry/fast/js/constructor-length-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126808 268f45cc-cd09-0410-ab3c-d52691b4dbfc