labofsahil/github-event-dataset-2012 huggingface dataset:
Yes.

--
William Durand | http://www.williamdurand.fr


On Thu, Nov 8, 2012 at 4:05 PM, Vyacheslav Slinko
<notifications@github.com>wrote:

> In lib/capifony_symfony2.rb:
>
> > @@ -182,6 +185,14 @@ def write(s)
> >            end
> >          end
> >
> > +        ["symfony:composer:install", "symfony:composer:update"].each do |action|
> > +          before action do
> > +            if copy_vendors
> > +              symfony.composer.copy_vendors
> > +            end
> > +          end
> > +        end
>
> I found that way to make before depended on :copy_vendors. Is it ok?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/everzet/capifony/pull/274/files#r2070493>.
>
>
You don't need an `else` after a `return`.
Was this meant just for testing? This doesn't look right.
I think there are two potential issues with it:

- Just because you had permission for the original lookup does not mean you necessarily have permission for the resulting link lookup if you have bind and lookup permission for a particular area of JNDI then you could simply bind a link to any other area to get access to the whole JNDI tree.

- User ObjectFactory code is run in the context of these lookups, which could result in this user code being run with elevated privileges.
Or fix jsmin
@levidehaan: Yes and yes. One README to rule them all. I'd say take out step 3 in the main README (step 3: handle htaccess stuff), and create an additional section after the last step "Configure web server" with sections "Apache" and "NGINX".

Where apache would basically be:
* Copy `./config/.htaccess-sample` to `./.htaccess`.
* Set `RewriteBase` in `./.htaccess` to match your `web.contextpath` setting

And NGINX:
* Copy `./config/nginx/testswarm.conf-sample` to your `/etc/nginx/sites-available/` directory and rename it to `domain.conf` (where domain is your hostname). For example: <br/>`cp ./config/nginx/testswarm.conf-sample /etc/nginx/sites-available/swarm.example.org.conf`
* _(something with contextpath here...)_
It's just not online right now. Will file.
It does. The problem comes from when you create a Debian source package from a source directory, it assumes the source directory is post-patching, not pre-patching, and so it tries to reverse the patch before creating the source package. If the file isn't present in the working dir, it fails to reverse the patch, and so fails to create the source patch.

Comes from Debian's idea that you have a pristine source directory that you then add the debian dir and patches to, it's not really well designed around the idea of including the debian dir with the source, unfortunately.
Thanks for clarification.  
In Magento 1 I always use Varien_Event_Observer, but I saw some changes in Magento 2 in that regard. Some observers (like in Mage_Backend) don't use any type for the argument, and most of the observers in Magento 2 return the observer instance $this. WIll this be changed again?

Personally I second deprecating the event instance wrapper for the event parameters :)
Nit: plural ;-)
// XXX: If processed is bigger than file length, show an unknown progress
Remove the <tt>_</tt>. Two reasons: it is not a module-level member and you are not using the prefix in the previous variables.
Revert these change, thanks.
imho variable name should not be based on the tag name but on what element they express (like title, or header). Because if you decide to change the tag name you don't want to rewrite the other parts of the code.
I am fine since this should be an l10n issue...r+=me.
Yes cause Yoshi is testing with this code ... and since STK testing should be done in Brasil probably we'll need Vivo guys testing it there and sent us log captures.
Please add comments or remove the unused code.
@vingtetun Remember this is an example page :D, that Js is not part of the component in self, is just to show how the animation looks like when you trigger the edit mode :)

Remeber that is placed after the comment that says :  "This style and link is only used for the example code, is no needed for the real case use". Maybe we should add "script" also to that comment
#2026 does not comes with this function though.
nit: `var activity = null;`
you also want a constructor name check here as code is used by other errors with other meanings
What we do with the vertical-alignment in that case? I don't think that the `menu` is a `footer`. You have a content, and some actions to do with it, not an additional information at the bottom.
remove this `this`
if (!hand)
  return;

And save some indents.
Región -> región
Let's say "you can manually set up the account", to use the same phrasing as the button.
The Contacts app does that for me ... as before showing it it will display the literal localized, that' why I have used the 'personal' string
As per my comment below, we should be able to get rid of the special case of "local-mode-zmq?" here. Both local and remote should use a virtual port, the only difference being the kind of port bound to by the virtual port function.
Can you explain the use case for this?
sharp eyes! thx
Made this PR a month ago when the limit was still 128, haven't bothered to update it.
bitte extend ember object sonst kommen wir nur noch mehr durcheinander. Die path klasse usw wird auch noch umgeschrieben. Es erzeugt praktisch keinen Overhead, bringt aber Konsistenz ins Projekt und wer weiß, vielleicht werden wir computed properties etc. noch brauchen.
might be helpful to note that the size of the heavyHitters set is always less than 1/heavyHittersPct.  So, 1% means at most an additional 800 bytes of data to store the heavy hitters (in most cases much much less since most distributions don't have so many heavy hitters).
Requires investigation to clearly document this. This portion was yanked from AppServer code.
Don't forget whitespace around operators:

```js
binding = ...
```
I used instanceof just in case somewhere someone uses new BAAOpenInProgress instead of using BAAOpenInProgress.getInstance(). I could do it, but this looks a bit cleaner.
OK, changed that
I had tried to do so once before, but was thrown off when the resulting button appeared to the left of new/load/save functions, which looks a bit unnatural. We'd briefly discussed adding some means of determining sorting or priority, which I'd planned to look at eventually.

I suppose it doesn't really hurt to do now, though. :)
You may keep the current implementation and let's see how it evolves in future iterations.
Ok, that works too...
Any benefit from this change?
Now mac port works well.
Does SQLServer have a "bytea" type?
Yes, for mailer service to lazy-load twig
I've replied to that thread. As far as this pull request is concerned I think it's better if you look at whether Boost.Filesystem does what you want to do before you abandon this work. If it doesn't then it might be worth adding this functionality to that library because this is about filesystem paths already and not URIs.

About not wasting time, the best way to avoid this is to let us know what you want to work on and communicate with us how you intend to do it or while you're doing it. Thanks for the effort and I'm looking forward to your other contributions in the future.
This should be moved to a conf/ .properties file and not hard coded in the module
yeah... now I have to parse the options strings (comma separated). I am not yet familiar with the parsing functions in suricata, which one would be the best one to use for geoip:a,b,c,d,e,(...); (variable number of options) ?
I don't like this way of passing the buffers as we assume it's size. I prefer an approach where the buffer length is also passed to this function.
On Wed, Nov 28, 2012 at 1:44 PM, Victor Julien <notifications@github.com>wrote:

> In src/detect-engine.c:
>
> > @@ -492,12 +494,28 @@ static void *DetectEngineLiveRuleSwap(void *arg)
> >
> >      for (i = 0; i < no_of_detect_tvs; i++) {
> >          int break_out = 0;
> > +        int pseudo_pkt_inserted = 0;
> > +        usleep(1000);
>
> Are you updating the patch for that?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/inliniac/suricata/pull/228/files#r2247326>.
>
>

It's not really necessary although if I wrote it now, I'd put it before the
for.  Will re-update it later on in another of my commits.  This is okay
for now.

-- 
Anoop Saldanha
please resolve merge conflict
it was removed by mistake, it should not be in this commit, only  forum_row.ctp fix is valid (it generated undefined index errors in default setup)
This is cross package dependency that should not exist. Please submit followup bug and point to it via comment.
I think "Failed to read: " + uri + " (status: " + request.status + ")" would be better.
Why not just `system.env.CFX_OPTIONS_FILE` ?
ditto here for the comment in complete email addition.
This test fails here: `E       AttributeError: 'SignIn' object has no attribute 'sign_in_add_another_email'`

The definition seems to be missing from `sign_in.py`.
my personal preference for change logs is if things are pretty much the same to have them on the same line and then comma separate the issue numbers

e.g.`Add ant script to build the extension for easier releasing (#35, #36)`
public function ? (for gradient descent)
u mean change the line to 20px?
@mmoll I'd rather see this as a string XOR a symbol. It's a bit difficult to quickly parse as both.
Good catch, that is hold over from a previous attempt where I was using the metrics directly. I will fix it and update this request
That is going to mismatch if ` # start on` is present, or a bunch of variations.  You want to use the regexp match and the results of that on the right.
I think I prefer type safety over compliance with JavaScript :-)

I've started work to work locally now, I'll show you my results in a bit
Not sure if it's really an issue for us anymore either.
the rest looks good, not sure I like the leading `;` for this UI though, maybe just go js-style `"// this is ignored": `
All `@namespaces` has been removed from the project
Yes, I saw that there is already "DASPRiD" that does the same thing and more! ... I did not know there was already something in ZF2, thank you friends.

We can close this PR?
Don't break this line into two -- makes it harder to understand the array hierarchy.
$hash is (last) part of $header and $header is for assertion in the last line of the test. Good enough?
remove spaces in the brackets
Have you checked that EVERYTHING in admin UI works OK?
Should this use apr_strnatcasecmp for consistency?
classnames should start with uppercase letter.
That will break Python 2.5 functionality, which I think otherwise works.
I personally would have used a special string like `'_all_'` to indicate all values. An empty string is not very readable.
This is used this way throughout the whole DocumentManager, mongodb-odm does the same, couchdb-odm has no check (which might result in some php warning). 
I would prefer to remove this here completely and check this in the UnitOfWork.
It does, as match with multiple properties is used in all cases.
I changed this in new commit anyway, to keep consistent with other multiple version fields already in fixture.
The official URL is http://ugent.be/hpc, as dictated by the UGent portal team. The HPC-UGent page is part of the portal, hence...
`note`
Nit: Newline not really needed.
The default value should mean this isn't needed, but I have included it now.
This needs a bit of work, it'd benefit from being dried out a bit, since creating audio and video elements is a very similar process. Also needs to have checks for undefined values.
is this comment relevant?  I don't see it throwing `NoMethodError`?
every time someone calls settings[x], this method will rebuild "configs" even tho it will not be used.
What do you think of this? Did this so we can just override it as necessary so I didn't have to pull in anything like active_support/inflector. Edit: check below in lib/spark_api/models/saved_search.rb for an example.
Two blank rows between defs and other defines at the top level (ie. not in classes). 

Should be like that in all files.
Hmm, I'm surprised umlaut's multi-threading stuff works at all with sqlite3.  But if the tests pass and we need the sqlite3 database.yml for travis, okay fair enough -- except please remove the comments preceding this line, so they aren't lying, explaining why we're keeping database.yml out of git when we ain't. Or change them to explain the database.yml is used by travis. 

(sorry, just noticing this pull request)
i think that value is required too
I hope Camel cleans this up if nobody ever replies?
Do we want to make these `li`s more `git` friendly by formatting them more like the `_header` layout?
I think this looks cleaner if it starts out with a larger square, maybe 3x3.
Change last arg to be "lsv" this is equiv, however some bugs have been noticed using LUA
奇怪的是master已经监听了80端口，为什么worker还要监听端口呢？
Why return false or true?, Those values are never  used
Please change the complete domain for these examples files from:

xxx.pmos.colosa.net

to

mydomain.com


and change use always the workspace workflow (in all new installations the installer creates the workspace "workflow")
I think it would be cleaner to stick this in a utility function at the top of this file, then anytime it is needed, `getFlickrAPIKey()` can be called.
feel like filing a Django bug? If they write their SHA1 hasher properly, they can make SHA1, 256, 512 work with minimal extra code
hmm... hadn't thought of configuration having implied lifecycle.  My intent here was to consolidate nonspecific inputs for use by swagger.
Node::orderBefore seems to rely on this method to throw the ItemNotFoundException. if we remove it here, the check has to be added in orderBefore
please add the original exception as second argument for easier debugging
Yep, got it working using: self.awards.create(:badge_id => badge). Pushed.
html5 doctype doesn't require the />
Is there a reason why not to use Qt's dbus module here?
We don't set it at present. We probably should. But I know that people will often forget to update it. :-)
It's defined as static in the header.
It seems strange that this is a mixin, rather than a subclass of `VideoLoader`.  Is this functionality useful other than when mixed with `VideoLoader`?
This was doing some weird shit. Do we need it?
So this is gonna break...
Forgot to do this, but I will. Sounds good.
This shouldn't be on the command itself; this is a transport responsibility, not a "transported thing" responsibility.
The problem with that, aside from the less-important cross-dependency issue, is that the `associateLoginId`API method would need to allow an anonymous user to associate a login id to an account, which is obviously dangerous. Having the "create and map" method in the authentication API provides the internal method to do this without authentication.

An alternative is that we could construct a context for the user after the user is created to pass in to the `associateLoginId` method from PrincipalsAPI. I saw `createUser` on AuthenticationAPI being overall a better option since we also have `getOrCreateUser`, for example.
Shouldn't this be using the keyspace name from CONFIG ?
This reasoning behind this is that we need the global configuration to be able to aggregate the rest of the configuration for tenants. with a `for else` we'd have the problem of not having the global config every time.
What happens if files cannot be read for some reason? I assume they'll be pulled into cache later when they're path is hit but wanted to be sure.
Superminor jsdoc remark: The parameter is  `principalUuids`  (plural)
Are subclasses expected to be thread-safe? That is the sort of information that I think it owuld be useful to provide to implementers of this pure interface.
I think all `BRIDGE` methods should be filtered out first, and then additional checks may be necessary, if more than one are not bridge (which can happen with specialization, since each specialized method is non-bridge, but may not be the one you want).
Ok, I changed my mind I think Integer() is better. Being angry is better here.
if it requires a key, then it should **not** be null ;)
On 03/05/12 17:06, Timothy Warren wrote:
>> +| 'QUERY_STRING'	Use QUERY_STRING   (CGI standard)
>> +| '_GET'			Use _GET   (the php array, in case even QUERY_STRING fails)
> I'm just wondering if `$_SERVER['QUERY_STRING']` is not more reliable than $_GET.
>
> Personally, I've seen issues with $_POST due to bad PHP configuration settings, and since $_GET is parsed from the query string, I would think it would be more probable to have issues with `$_GET` in the first place, making the use of `$_GET` a redundancy over `$_SERVER['QUERY_STRING']`.
Absolutely.  Right, I checked out the PHP interpreter code, and I don't 
see custom code for _GET in any of the SAPIs.

I withdraw _GET as an option, and I will remove the code in the 
*current* AUTO option, which falls back to $_GET.

Thanks
Alan
$secure = (bool) $config['cookie_secure'];
    $http_only = (bool) $config['cookie_httponly'];

... and remove the `if()`'s below, second one is erroneous anyway - there's no `$config['http_only']` setting.
Нужно заменить Х процентов, а не Х ячеек в массиве. Если не 100?
Так же numCell может быть несколько раз одинаковым, что приведет к замене одной и той же ячейки несколько раз и сократит количество замененных ячеек.
Не понял! Вы считаете количество одинаковых символов, а нужно-то совсем наоборот!
Есть конструкция switch, возможно, вам понравится больше.
Если вы хотите обрабатывать ошибки то пусть ваш метод mutate возвращает YES, если все ок, и NO в противном случае.
В этой функции не должно быть вывода в лог.
Предлагаете менять на определенный "ген", например на следующий?
I dont get what you mean by this.  If I combine everything into one step then it doesnt make sense to even have the scenario does it.  I already have a function that is called login user which is the shortcut.  So in what you are saying I should just have 

Scenario: Existing users should be able to login
     Given I can login
let's un-x these?
The only problem I can see with making it default is that the code will be unreadable in browsers that don't support sourceURL since I have to eval/Function everything.
Yeah. To be honest, as you can tell from the commit log I've not been actively working on this.
Naming this `shardKeys` would also help readability (same point as my comment about the annotation).
ODM uses "document" in place of "entity" in its documentation.
I would emphasize more on the "not". Reading fast, I first read: "you should run the... as root".
Maybe it should reference "main thread" instead? I think it's important to make it clear that it's not that RAC considers it the "main" scheduler, but that it's equivalent to the thread Cocoa expects you do UI operations on.
If I’m not mistaken, this and all following `Disallow` entries won’t work as expected; they should include `DJANGO_BASE`.
I'm fine with removing the tests, though, so it works on windows---it's embarassingly parallel, so I don't think it /needs/ a test case.
I did a search on the repo and couldn't find a tris_connectivity function. I don't mind adding one, though...
remark: can you convert your emails to text as it appears always a
mess when you reply to comments by email. I always have to reformat to
answer :(

> I'm afraid the API get's shaken... But yes. So just to draw a tiny dependency-map of the method relations:

yes

> '-->' for left invokes right:
> (get_sources, pick_sources) --.> sort_sources
>
> (plot_sources, find sources, pick_sources) --> get_sources so in depth sort_sources does the default ordering job. get sources gets the sources (calling sort_sources, internal scoring) and find_sources gets scores based on comparison with a target vector (external scoring). How to unify this?

if target is None then the score_func expects only the sources and if
not None it is passed as second argument to the score_func.

order = ica.argsort_sources_epochs(epochs, …)
ica.plot_sources_epochs(epochs, …)

> I'm a bit -1 for adding more accessing-methods, It would get confusing at some point. But extending / altering functionality and / or renaming would be fine. The candidate I see is sort_sources We could try to merge sort_sources into find_sources or allow it to return scores and make it a internal-score version (index based on one input vecor) of find_sources or something like that. Then the top level functions could access both scoring functions via keys or so. However I'm a bit afraid of fumbling around with it. The whole picking depends on consistent sorting which took some time. Basically you have to make sure, that pick_sources draws the sources in the same order as your decision-maker (human, correlation-algorithm via find_sources/ get_sources /sort_sources) If you see a quick way +1 for this. What do you think?

I am not sure. I'll get back to you later.
I'd say nitpick all the nits there are to pick. We will all have to live
with accepted changes (not to mention the end-users!), so it's better to
annoy the fewest people in the long run -- even though it might mean
annoying the committing coder in the short run :)


On Tue, Dec 11, 2012 at 4:15 PM, Martin Luessi <notifications@github.com>wrote:

> In mne/fiff/raw.py:
>
> > @@ -452,6 +452,7 @@ def apply_hilbert(self, picks, envelope=False, n_jobs=1, verbose=None):
> >      @verbose
> >      def filter(self, l_freq, h_freq, picks=None, filter_length=None,
> >                 l_trans_bandwidth=0.5, h_trans_bandwidth=0.5, n_jobs=1,
> > +               method='fft', iir_params=dict(N=4, ftype='butter'),
>
> PS: I was thinking about commenting on this too.. but then I felt bad
> about nitpicking too much ;)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/249/files#r2387100>.
>
>
It should return the deathdateEstimated value instead of calling isDeathdateEstimated().
Oh is that the point of it!
Again, major DRY violation. This module should be placed somewhere where it can be used by background.js as well as by the tests, so that the code only exists once.
Yeah, but the opposite happens if you then go on to fill it with the specified number of elements: http://jsperf.com/array-declaration-test/2

Still though, the with cardinality syntax is pretty verbose.
This is a bad example. ``fixXmlConfig`` already takes care of this difference
You don't need to repeat `.gridline` here since Stylus is indentation-based: [http://learnboost.github.com/stylus/docs/selectors.html](http://learnboost.github.com/stylus/docs/selectors.html)

    .gridline
        (...)
        #gridlineV
Using what encoding?
What's with all the `*`s? I'm guessing these may be reST errors, why not use `-`s?
doesn't this have to be in position 1?
no clearfix if no float
Yo lo decía porque el null también se puede utilizar para luego generar el
404. Pero la excepción me parece bien, cuando andemos cerca de ese código
lo modificamos.

On Mon, Mar 12, 2012 at 10:33 AM, Alpha <
reply@reply.github.com
> wrote:

> > +        }
> > +
> > +        //TODO: Duplicated code
> > +        private string GetAttachmentPath(string id)
> > +        {
> > +            var folder = id.Substring(0, 2);
> > +            var filename = id.Substring(2);
> > +            return Path.Combine(UploadPath, folder, filename);
> > +        }
> > +
> > +        public override Stream Execute()
> > +        {
> > +            var path = GetAttachmentPath(Attachment.Id);
> > +            if (!File.Exists(path))
> > +            {
> > +                //TODO: es conveniente disparar una excepción?
>
> Sí, deberíamos disparar un FileNotFound o algo de eso. Luego atraparlo y
> si queremos en el UI podríamos generar un 404 o algo así.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/30/files#r545573
>
you can delete the two lines, I though I already did it.
You changed the English locale to Italian?
use parent::pause ?
! done ! for the whole code as a new method 'processLoop()' ok for appbox AND databox
if PDO sql is catched, please specify PDOException
Also, we should test first and then sleep, so that each `service mongodb restart` doesn't take a minimum of 15 seconds (after the initial allocation, starting MongoDB should take <1s, in my experience).
Like that: `git rev-list --count --left-right '@{upstream}'...HEAD` ?

I tried that with `upstream` and `origin` (I only have `origin`) and I keep getting this:
```
fatal: ambiguous argument '@{origin}...HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions
```

(I also tried with and without quotes)
I want it for piston, so it's going in 2.3.

I added the check b/c i'm afraid that one of us will install a new openstack-gridcentric.deb without the new vms.deb. This kind of snafu happened when we changed the vmsfs interface.
Actually, just the common bits. Needed for the package madness. I might name it nova-gridcentric-common.
you could close the above list brackets and save a line (think about the electronic trees :)
Steps 2-4 are missing.
Got a merge conflict here.
As above, consistent spacing here would make this:

```objc
- (void)testCanRevparse
```
For mpl developers: Is there any guidance on whether the ```from pylab import *``` is discouraged? Should there be?
Sorry, I was referring to ```hatch_style[2]```.
The thing is that we actually never make use of it. If it should be for API consumers we should better handle that via the start and end test listeners. Jeff, I will remove it for now and land the patch. If you have concerns please speak up and I will land a follow-up patch which will reimplement this property and resets it at the end.
Is this code essentially duplicated now in GaiaData & GaiaTestCase?

If so, I'd rather figure avoid duplicating and instead ensuring there's only one codepath here.
I took it from there actually... Another proof that copy-pasting is evil :)
..why?
Isnt there already some code that looks like this ? Can we factor to a helper class ?
is this really required
Put field names on different lines.
Why is this code not included in the sanitize action above? (line 106)
Oh, does it actually not work? I was reading this and figured it was because of that: https://github.com/travis-ci/travis-cookbooks/issues/89
We have confusion matrix computation func in CMulticlassEvaluation :)
Instead of using globals, can we use $form->controller->redirectBack() instead?
...I think this might actually be part of the actions top changes.
That's the wrong file for this rule, UploadField.scss only deals with generic upload styling, not specifics like the tabs of the "insert media" cms logic. Should go into admin/scss/_style.scss
OK: how about "objects" open in the cache, I'm trying to stay away from "files".

On a more general note, is this the correct statistic, do people want to know the objects open in the cache, or the number of file  handles currently open (that is, a lower-level statistic of file handles), or both?
and most people use 16.666666666666667
I'll update the filter example to show you one possible use case.
I'm not sure whether I'm even allowed to change the signature. Existence of this method is forced by the abstract base class and it requests for (Array[Char], Int, Int), so you probably can't change that. Also, I don't want to hurt Java Interop. Your comment seems fair otherwise, though, and I myself would have used None instead of -1 in Python.
Are you sure you want to override the parameter ``$pathInfo``? This often makes code less readable.
I guess that should be handled by `KJSencha\Frontend\Bootstrap` at set-time and validated... That's the easiest way to avoid having users do unexpected things, and is also quite self-documenting :)
Hm, not sure about this. I'd probably keep the default relatively conservative. If you'd prefer a faster update you can still set it to 10 manually. What do you think?
s/userinfo/ogranization info ?
`apikey` debería ir en el config.coffee. Algo estilo:

```coffee
plugins:
  tiny: 'esta es mi apikey'
```

Y luego en el plugin:

```coffee
module.exports = (bot, apikey) ->
  ...
```
I'm confused... what is this code doing?  Does the `muc` object do something special after `#deliver_deferred` is used?  Doesn't look like this code is using `muc` at all after joining.
Pois, aí não tinha bem a certeza, como nas categorias e nas tags também adicionei um activity_id, achei por bem meter também.
Oops. Thanks. I'll do that.

On Fri, Sep 21, 2012 at 10:30 AM, Fredrik Ehnbom
<notifications@github.com>wrote:

> In sublimeclang.py:
>
> >      try:
> >          if len(tu.var.diagnostics):
> > +            print len(tu.var.diagnostics)
>
> @rorydriscoll <https://github.com/rorydriscoll>, looks good save for this
> print. Could you remove it please?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/quarnster/SublimeClang/pull/133/files#r1663647>.
>
>
ID of the panel is key to mapfield.

Yes, I didn't think about the number of columns. So let us think a bit. What all should we have in panel settings:
 * if panel is enabled or disabled (currently all panels are disabled)
 * if enabled, it can be collapsed or not
 * and moved around, where we store different position based on number of columns

The question is, if the position/order is really a panel setting or not?
(Or add TODO for that.)
One empty line above. Each library into its own group.
Good, but indent once more those three lines.
I must say that I am a bit lost why you are storing only ID here.

In some way it is a bit a lot to create a new Post object, just to store ID of it here. :-)

But OK, let it be.
`.text(node.name).append(' | ');` works?
some check should be here, I think
shouldn't you use `request->attributes` here ?
Where's `registerForPushNotifications:withUser:callback:`?
Because a new loader is used anyway in each of the functions like dbalLoad / ormLoad and because it's a separate scope for what we want to do.

I've added a new file because it isn't related neither to DBAL nor ORM so I didn't saw a point in having the extension in either of them.
how about ordered array?
But as this doesn't appear to change the behaviour on timeouts.. I suppose it is okay as is.
actually, `filename_prefix()`
This seems wrong: the above call to `renderer->SetBlendMode` should be changed to `BLEND_ALPHA_PREMULT` instead of calling `glBlend` here.
having to add a ``missing`` keyword everywhere is not nice.
also, where do we need to put a ``singular`` or other keywords? Is this approach extendable?
ここは日本語で。
@camertron, thanks. I should definitely learn to respect backward compatibility. Added a couple of specs to make sure next guy who deletes this method will get punished =) 

Regarding delegation I replaced variable length arguments list in `get_resourse` with the same arguments list as in `resource_for`. Though, I'm still not sure which solution is better. Unlike it was before `get_resource` has a meaningful signature now, but it'll be broken if someone changes arguments list of `resource_for`. On the other hand that's why we have specs and thanks to them broken `resource_for` won't be unnoticed in that case.
"... bytes that are greater ..."
How about extracting these three lines into a method that can be used both for `FastGettext` and `I18n`?
no longer initialize empty objects. instead, catching all exceptions (null point exception) in intforkey and stringforkey
The logic here is a bit confusing. Why not

```javascript

if (currentPage && e.page.name !== currentPage.name)
   return;

switchOrClose();
```
widget, fixed.
Why was this comment removed?
Barney, your proposal for handling the transformations seems fine to me.  Another variation would be to factor out the parts of SBDistort that handle composing transforms into a separate *composable* Transformation object, and then have the GSObjects hold *one* of those, and then use that to create the SBDistort when requested.

I agree with Mike that it'd be best to do that before merging this ticket if the alternative is disabling tests.  But you could implement that object on another issue, merge it to master, and then merge master to this branch, if you'd prefer to keep the features separate for organizational purposes.
Let's talk about this on monday.
what's the point of this line (above)?  can just say:

    new ParallelTask(activationListeners)

in the line below.  (also we can avoid the task var, just invoke .get() directly...)
perhaps rename variable to be less specific (e.g. just `file`)
Pareil exemple ?
How about "Note that the changes have already been implemented in the user front end, here we show you the code that we needed to modify."
While it's true that such reports are really verbose, as a developer I always find it helpful to know what actually went wrong. :-) Users will appreciate being able to submit more useful bug reports perhaps.
Python 3 complains about the former, saying it can't import `cornice` (presumably because we're in `cornice/__init__.py` so this is sort of circular, but only in Python 3) - it seems there was some change in how intra-package imports are handled. `from . import util` didn't work either. I wonder if the actual problem here was something else like a problem in `util.py`. I should probably double-check that this is still needed.
Send this one to death in the molten lava at the centre of the earth too :)
seria melhor utilizar o operador `ìs``: Exemplo:  ``if availability is None:``
я десь в тестах привязувався до .grid_12? це ж безглуздо
That's not commenting it. It's removing the already commented lines.

Currently policy manager overwrites the handleMessage function to do its work.
Isn’t this going to set `parent` as an array? Last I checked, `parent` was a single tag or `nil`: did this change?
@philsturgeon Thanks...fixed.
Also, spacing more like this:

```objective-c
- (GSNamedPipe *)initWithController:(GSMenuController *)controller;
```

(I'm just being nitpicky :)
I looked into this a bit more. `instance.load_remote_errors` does get errors from galaxy, but ActiveResource::ResourceInvaild isn't doing anything with it when we new it up.
assertion added.
It is OK, if it is empty, just fall through and then path=emptyString.
Renamed to the new DRF2 convention. Same applies to BlogPostDetail below.
Still a little uncomfortable with all of this code here.  It really feels like it should live farther down.
Does using the min/max values of float/double make sense here?  They are so far out of the range of the long type that it would make more sense to use min/max for long here.  Because these defaults are (I think) only intended as fallbacks for if it's not possible/too expensive to compute the true min/max, they are just a best effort guess; but due to the range of float/double being so huge, I'm not convinced that it's possible to provide a sensible default, or if this change is meaningful--what is the behaviour of the (long) case in this case; do we get something sensible back?  For float/double, I'm not sure that the range (min,max) will ever result in a viewable image.
If removing the Latest Features section, should we move all these sub-sections up one level? Or remove the Introduction section?
well the first returns np.uint8 the latter an int (wich I realize could be np.uint16)
I would prefer have the default `%memit` run only one iteration instead of 3 by default.
Include <stdbool.h> and use false.
Will

```python
postmerge = kwargs.pop('postmerge', True)
force_truncate = kwargs.pop('force_truncate', False)
```
work here?
Shouldn't be committed. Don't git commit -a
Since we're adding a new attribute here, we should make sure it has a default set in the attributes file.
according to documentation , creatStream should take one and only one argument,  do we need to check it here?
There are two sources for nativeObject, one that increases the ref count and another that doesn't.  But it's always getting released.  That's likely a bug.
minus signs
Sigh.  Apologies.  That was a hand-application of a change made on a test host.  Fixed in a new commit.
I would prefer to not swallow the original error, even if we want to change the message.
It's make me crazy and never works: raises `SyntaxError`.
Move this to a node definition.
what's this name for?
_with another center than_ (instead of centere)

and I would say "than the query" rather than "than the search"
@richardkchapman are ACLs still going to be EE only?
You learn something every day!

I'm not going to r- but I think stuff like this is easier to debug and to maintain in python inside the views.py instead. Too much complexity in templates leads to tears one day.
this file does not seem to be included
This test won't run on 1.8.7 :(
The whole thing could be abstracted in a best TestCase class though if you want.
99% of this file is just an import of a third-party library for processing command line options.  I made some minor changes to it in the third commit of this series.
So, the short answer is "very hard", for several reasons:

The code invokes other stuff, but is otherwise pretty opaque.  I could probably break it out some to make it more testable, but that is fairly hard work and makes the code much harder to read, I think.

The test is actually "did this sequence of events occur in order", and is dependent on time, which makes it quite hard to actually fake out the system enough to do the right stuff.

After half an hour of effort I have no useful tests; better suggestions welcome.
Yeah, was aware of that, I was just pointing at it. If I'm alive later this evening I'll read further :)
d'oh! Spaces, not tabs.. even had it underlined. Sorry to make you go through all those!
Additional note from conversation: You're right. `approved` isn't in the `unique_together` constraint, so you're going to need to store it as part of the key for lookups.
@shacker That is correct!
Ah, the preview window was focused on an odd place. Will do.
Are you sure it is relative to the target folder? I would have thought it is relative to the project base dire but the default value the proguard directory within the target folder (build output folder). Please check and confirm or update ..
This is fixed. Also saw the same with OrientationChange - fixed it there, too.
use const char, don't create static instances of things that aren't POD

also, is there a reason to have these as class members when they aren't used outside the class?
I can't parse this sentence.  Did you mean "This module is designed to listen on a port for PJL..." ?
I might need some direction on this one. I need the module to always have the 'WebServer' action, and then exactly one of the 'RTYPE' actions/options. (e.g. it wouldn't be as straightforward as other modules I've looked at, like tftp_transfer_util or http_put)
This is no longer needed, we don't use svn.
sure res couldn't be nil here?
So, each specialization of the model just needs to know: where are the coefficients that I'm trying to estimate, and what are the values of the others that are now fixed.
Can we use Transform instead of Transformation?
Please replace with spider picture: http://www.27bslash6.com/overdue.html
The error is masked because the test is xfailed. Xfail will mask both test failures and framework failures.

The error is that it can't access login_pg, it is no longer imported in. Easiest way is to remove the xfail and run it again or look at the results/index.html report.
na dige, daghighan hamoon ebarat ke neveshtam
nazarehs too parantez
Shouldn't this be `this._northPoleCommand.boundingVolume = BoundingSphere.fromExtent3D(extent, this._ellipsoid, this._northPoleCommand.boundingVolume);` to reuse the existing instance?
This has been renamed to `resizeWidgetOnWindowResize`.
You're correct.  It needs to be changed to only match 0 or 1 occurrence.  I'll add a test case for it and fix it.  While this particular case is a bug on my part; my general goal was to make sure all valid dates work and catch "most" of the invalid ones.  For example, according to the spec, only the first two dates below are valid, but right now it will parse all of them as August 1st, 2001.

2001-08-01
20010801
2001-0801
200108-01

I'd love to check for this case, but my limited knowledge of regex is pretty limited.  I wanted to get this 99% working and then go back and tweak the regex later rather than worrying about every edge case up front.
Or does getTaiMinusUtc always expect UTC?  The doc doesn't make that clear.
Go with `Rectangle` then since its a bit cleaner.  I promise not to comment on this topic - but not necessarily this pull request - again.  You should too. :)
Let's have line breaks at 80 chars, to prevent difficulty in future code reviews :-)
Could suggest either. In general I tried to keep the tiers separated out so that:

1. User level gives enough information to the application developer to report a bug
2. Debug level gives enough information to Appcelerator to report a bug
3. Running in Developer mode gives enough information to track down bugs

Where possible I erred on the side of higher log levels (generally only Titanium developers are going to be interested in threading issues).
Hmm, we accept dictionaries all the time in our APIs, and I don't think we go through this  warning suppression and HashMap casting.  What about just KrollDict?  (Or did we lose that after V8-integration?  My memory is f*$&"d.
If this was for module developers to extend and use this functionality, then we need add a description, and a module.api annotation
You indeed moved that line, but it was in add: method which was only called when we add a subview to the view.
Wouldn't it be more simple to just store the stack on the ActivityProxy that is on top when opening the window?
This would avoid all this searching as well.
Makes sense, but a little hard to follow.  Anyway this can be refactored into a s couple smaller methods?
no, this would break on symfony.com, the paths need to be relative.
Your input has made me question the legibility of the slicing syntax in this context, is operating on the `Sequence` as though it has no state a valid operation? And perhaps this is out of scope of the current implementation.

The slice `[0 .. 5]` is from the start of the sequence (regardless of the `Sequence._n`); where it might make sense that the slice `[0 .. n]` is actually `[this._n .. this._n + n]`.

Alternatively (and perhaps the only option permitting these changes), the slicing *could* be relative to the `Sequence` instead; but this may be misleading.

I'm not sure which is appropriate
Sorry for taking so long to get back to this; was at PyconAU.
I haven't used `$D_PARAM` in ages, and when I did before, it was either wrong or unnecessary (since function parameters are automatically highlighted).
So 'to' was ForwardRange all this time, nice.
Same for me ;-)
Seems like this should default to an empty string rather than "Unknown". We can infer unknown from detections that don't have a language specified. Outputting "Unknown" seems like it might cause confusion, or concern, and it doesn't give any benefit that I can see. If a non-empty string doesn't work for some reason, at least say something like, "No primary language detected."
what is '[ ]' ? \s?
I've been holding out on this because I would like our store tracking to be timestamp aware — that is, when we track a record to ignore, we only ignore it if it doesn't get modified again at a later time, and that allows us to mostly dispense with untracking.

But yes, it's horrible, so perhaps I'll find a better way to fix that later.
Move to above #initialize
agreed.  fixed.
I think that should be the case - it would be worth checking.
It's not bad, i never had such issues, but i can see how an automated process can save time if nothing has changed in the js sourcebase...

If it becomes an issue we can make it optional so the user would have to explicitly declare it in the options...
Just my preferrence, but those brackets are not really needed :)
Okay, then what's the point of the unprefixed method?
Don't you need to `Chronic.parse` the start and end times?
Yet the same line in `irb`  behaved differently. Yay, Ruby!

I'll see about creating the stubs in the morning.
this comment should be removed. Moving it here does not ensure anything about the order in which the annotations are found
Can you explain the reasoning behind this? If you expect an integer, why is null permissible?
пока не надо.
use /** */ like javadoc.
oh cool.  fixed
Moved it into content.css where it gets picked up.
> thread must be enregistered

Agree.

> top and bottom are pretty confusing (top is the smallest address)

I think in the public API, the stack top should be the most recent stack frame. At least that's what I would intuitively expect.

> probably one function which returns both would be better

I'm fine with either approach. As long as the information is there.

> So if you can come up with a nice API we can definitely add this functionality though I don't see any reason why it would need to be a prefixed extern(C) function.

I just thought Sean prefers it that way for low-level stuff like that.

How about:

`void* thread_stackBottom() /* oldest stack frame */`
`void* thread_stackTop() /* newest stack frame */`

?
Don't do this unless we need it (see comment below)
Should be &lt;interfacename&gt;
See previous comment - line 877
please remove 110-113 and use resource attributes directly in  db_postgres_set_privileges
```
  db_postgres_set_privileges "setup db privileges" do
    preset new_resource.privilege
    username new_resource.privilege_username
    password new_resource.privilege_password
    database new_resource.privilege_database
  end
```
Does the option resolver not throw an exception here? 

General static code analysis is beyond what this bundle can do, I think. It is much more complex :)

I think we can also remove the comment a few lines below.
should we not rather create a custom menu provider than a renderer? this has nothing to do with rendering...
Yes, you should really avoid using inspect.
You don't have to use 'return' in Ruby... the last executed code in a method will always return. You can use returns to early return a method, something like this:

```
attr_reader :my_tent

def default_tent
  return 5 if my_tent.nil?
  calculate_tent
end
```
Where do I pass a string? I pass a string to `RailsAdapter::LoadedTooLateError` which is a subclass of `StandardError` which is defined above, but this is `RailsAdapter`.
Please revert. We're not modifying spelling right now. :)
Action needs to be translated to. You can use the``$admin->trans($this->getLabelTranslatorStrategy()->getLabel($action, 'action')),``
Can you rename the event ``sonata.collection-item-added`` ?
I am not really sure this is necessary because `ToManyField` implements a very similar function which already  does almost the same thing?
Would suggest that rather than adding a new view, we just add `.patch` to the existing `UpdateAPIView`, so it has both `put` and `patch` methods.
There's a method in utils for this which we should be calling for consitency.
Changed assertion to match one of the 3 expected strings
K, that sounds good to me
in che tegiye akheeee !!!!!
The schema is invalid for nested records with no xml tag, and I'll open an issue to fix that.  But roxie does as you suggest here, I'll make the change.
Ah cool

On Tue, Nov 6, 2012 at 4:38 PM, Joe Hoyle <notifications@github.com> wrote:

> In wprp.compatability.php:
>
> > +	// TODO: Handle this array. Hardcoded in the wprp? or should it ping the app?
> > +	$security_plugin = array( 'better-wp-security', 'bulletproof-security', 'wordfence', 'wordpress-firewall-2' );
> > +
> > +	$active = get_option( 'active_plugins', array() );
> > +
> > +	$plugin_matches = array();
> > +
> > +	// foreach through activated plugins and split the string to have one name to check results against.
> > +	
> > +	foreach ( $active as $single_active ) {
> > +
> > +		foreach ( $security_plugin as $plugin_name ) {
> > +
> > +			$regex = '"' . $plugin_name . '"';
> > +
> > +			if ( preg_match( $regex, $single_active, $match ) ) {
>
> He is doing it the other way round, i.e. loop through all active plugins
> and check if there are in the black list, is_plugin_active() would require
> knowing the plugin path
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/humanmade/WP-Remote-WordPress-Plugin/pull/13/files#r2044791>.
>
>