labofsahil/github-event-dataset-2012 huggingface dataset:
I strongly disagree. 
Reason being that you might be reading the code in a smaller context. When you see something like "modifyLinks" at the 0th level indentation you immediately think it's globally available. But it's not. The wrapping does matter.
Another totally random style thing I've seen.. apparently _ is considered the 'right' variable name to use in closures and list comprehensions.. after being a bit skeptical I kind of like it, it makes it clear that the variable is only temporary..

so:
```
[ dict(id=_.pk, text=str(_),) for _ in context['object_list'] ]
```
Changed to creating to avoid confusion about different variations of the word. (The correct American English uses a z.)
@tmm1 -- What issues did you see with utf-8 over stdin in the past?
Document why you would except this to occur, since doing a `pass` on it means this is normal and expected.
I haven't looked ->authorise(), i will take a look with ->authorise()
This is the type of response I get on /f/ every time.
http://pastie.org/5388714
What do you mean by filtering twice? Currently, the app displays Zendesk problem tickets updated or created in the last two weeks (which is the limit set by nt_limit) that don't have associated GitHub tickets, but there is no part in the app that monitors GitHub tickets that aren't associated to a problem.
/me has no idea how I would go about doing that
s/built/build/

`which each get` sounds kind of odd. `that get`?
If `path` is required, then we shouldn't be setting a default for it, we should instead be reporting an error. With respect to `branch`, we are trying to deprecate `None` as referring to the default. Perhaps it should be required (but allowed to be `None`) as well? Or default to `''` in the dict case only, which I guess is what would happen if we default it to `''`, since a tuple always has a branch.
Add yourself here mate ;)
Just *en.yml, never edit others.
Any reason for this to no longer be a singleton?
value attribute is better than text because text should be inside tag (<cut>text</cut>)
Meaning utilizing [get_plugin_data()](http://codex.wordpress.org/Function_Reference/get_plugin_data)
prefer 'do' not '{' for big blocks like this.
@erikvold would you be able to take a look at this and confirm that I implemented preferences correctly in JS?
Awesome cleanup with this taken care of at a lower level.
I think you should be able to do something like:

```
self.close("primary_user", infoBeforeItWasModifiedByCheckEmailIssuer);
```

This is only a theory.
Cool. Patch looks good. I'll merge when the branch is green.
Woah, how'd that \n get yanked out?
Where is this value set? It seems to be checked before it's set and the check is against disparate types... unless I'm misreading the callback flow...
Please obey the 2 char indentation for prototype methods and properties. Also the opening brackets should always be in the same line as the function name. And there is a missing semicolon.
It's always safe to have them. It makes it more obvious when you run into conversion issues.
While we change those two lines, can we modify the first entry so it says pushlog between last and current build? Otherwise people will wonder what the other item is.
I suggest replacing this '''@property''' with a method like so:

'''    def click_first_tag_link(self):
        self.selenium.find_element(*self._tag_locator).click()
        from pages.tag_results import TagResultsPage
        return TagResultsPage(self.testsetup)'''

When you then call this method from test_search_tag it will return the page object you expect at which point you can work with it.
should be `$schemas`, not `$ads`
It allows to write helper functions that change the behaviour depending on that flag. It was also available in previous DSL and it was retained.
Short answer: No.

Long answer:

We are using an explicit `source encoding` because of the special characters used in the Face documentation related to tree output. We need to specify an encoding of `UTF-8` so that Ruby 1.9 will read the source file, as by default it assumes US_ASCII everywhere. 

This encoding header should not effect the `internal encoding` or `external encoding` used by Ruby when encoding strings or reading files.
Why don't we just have this set the timeout, and then have the heartbeat take care of checking it each time it pings and then kill the kernel if needed?
This reminds me of a surprise I had ages ago when asked "what are the possible return values for `strcmp(3)`.  The answer is "any int between -MAXINT and MAXINT".  I had always seen use of `strcmp` coded up as:

```c
int ret = strcmp(a,b);
if (ret == -1) {
  // lessthan
} else if (ret == 1) {
  // greaterthan
} else {
  // equal
}
```

The documentation for this method also says "a negative lim", not "a limit with the sentinel value of negative one".  Just as the documentation for `strcmp` states:

>  The strcmp() and strncmp() functions return an integer greater than,
>  equal to, or less than 0, according as the string s1 is greater than,
>  equal to, or less than the string s2.
This switch was formerly necessary but now it can be deleted.
Confusing; keep all elements of a single condition on the same line.
Also `@return Color`
this is broken. the cases are booleans and ``$days`` is an integer
I just noticed that the issue was fixed by @half-ogre in a recent commit: 513f257e6818391345edd2a7301ce6a018d585d0
As this was the main reason for the PR, I'll close this and open a new one for the formatting issue.
'Dispatcher::applyRules' makes sure both the library key and the controller library prefix (lib.controller) are set, since some users use the library key, others the prefix. I also think this 'magic' is needed to make the route self-aware of it's context (it's part of the library x). I've been using this fix for a month now, unsetting $url['library'] in the router hasn't shown any issues for me so far. I hope this makes things a bit more clear from my perspective...
Looks like http://www.wiki.vg/Pre-release_protocol is not updated then. Says 46 over there
why is the length assignment happening inside the loop?
Add in that the user has to do `npm install` and install brunch first.
not needed, we already provide that class
Seems appropriate not to grow the scope of this fix, defer.
I might be missing something... but I think you need an `expand_path` here.

(Aside: That's a common pattern that we might consider refactoring.)
Delete all these lines and make return @unknown_value unless @names.has_key?(name)
We can use `false !== this.options.selectable`. So the only way to do not selectable is setting to false.
You could also link to a small `domready` micro-lib if you don't want jQuery.

https://github.com/ded/domready

It's so small you might even inline it.
My bad, I forgot to remove them :)
You can specify multiple helper methods you want to expose in your views in one shot: 

    helper_method :current_user, :logged_in?, :check_login
This bit doesn't make sense: `is_private.get('yt$state').get('reasonCode')`

The `.get()` call is used when the key may not exist, but if it does not exist, the following `.get()` will fail. Your line should be:

`if is_private is not None and is_private.get('yt$state') and is_private['yt$state'].get('reasonCode'):`
libpng version is incorrect (1.5.1 vs 1.5.10), and libreadline doesn't have a version in the filename at all

for both easyconfig files, the correct files were also available, so these can be simply removed
note that for the access_token, both the https url (in the sentence) and the and the http url (in the code snippet) are used.
Glad I was able to and thanks for all the great libs. :+1:
These should be lined up with `action`
*needed
And the commands don't look quite right next to each other. May need the "::" and blank line?
Really this whole test kinda sucks... it may be better to split up into multiple ests but I think thats out of the scope of this pull request.
http://stackoverflow.com/questions/47789/generator-expressions-vs-list-comprehension

`[a, getattr(self, a) for a in attrs]` would return a `dict()` for you.
I would just read PORT. Having PORT override OPENBADGES_PORT seems confusing to me.
My takeaway from the jsperf: inside or outside makes no difference. Thus to stick with the style of the rest of the code, let's put em outside.
Github shows you just removed the line...is it supposed to just be a correction?
Nag, nag, nag -- same thing here with "contact Open Doors."
My thought here is at this stage of maturity of the project, to keep the
download location consistent/predictable across all installations. Instead
of conditional on I/O errors.
On Nov 9, 2012 10:56 AM, "jikamens" <notifications@github.com> wrote:

> In zipline/data/loader.py:
>
> > @@ -44,10 +59,8 @@ def dump_treasury_curves():
> >          tr = (date_as_tuple, curve)
> >          tr_data.append(tr)
> >
> > -    tr_path = os.path.join(os.path.dirname(__file__),
> > -                           "treasury_curves.msgpack")
> > -    tr_fp = open(tr_path, "wb")
> > -    tr_fp.write(msgpack.dumps(tr_data))
> > +    with get_datafile('treasury_curves.msgpack', mode='wb') as tr_fp:
> > +        tr_fp.write(msgpack.dumps(tr_data))
>
> Should we first be trying to save the data in the old location, and only
> saving it in ~/.zipline/data if the old location isn't writable?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/quantopian/zipline/pull/15/files#r2084620>.
>
>
Could you please change scope of `myfaces-impl` to `${dependency.scope}` ?
afaik, the validation would fail here regardless as such a setting already exists
No need to change it. Seems reasonable. I was just curious.
This line could be moved into the `setUp` , otherwise it's just switches to the same frame every time.
Extending classes like this when tuque is not installed will cause white screen, as the parent class cannot be found.
the id isn't necessarily invalid. the user may have passed conditions to filter out data. 

if there's a suffix just use it and leave the original alone. please add tests for both singe property population and population of arrays.
I agree, if you look up a bit at line 24 there is a TODO that mentions the inflexibility of opt parsing in Knife.

I want a user to be able to say, `knife berks install -- shims` and have the option of leaving a path off. With Knife you can't do this, if you don't provide a value for --shims it needs to be marked as a boolean opt.

This spawns a bigger conversation. Should we just use Thor? Our code is well encapsulated and allows us to swap out our CLI of choice.
I thought of using it instead of innerHTML, but no need for it. Removed.
Send $uid[0] and before validate if exists
Added optional "sortable" property to column definitions. Default value is true to keep backwards-compatibility.
I would use URL with 4.x instead of 4.7.
почему он публичный?
@bretman - I use the [Gravtastic](https://github.com/chrislloyd/gravtastic/) library for this already - perhaps you could use this instead? 
You can pass in a size attribute like this:

``` ruby
current_player.gravatar_url(:size => 50)
```

(See https://github.com/joshmcarthur/Latter/blob/master/app/views/players/_profile.html.erb#L3 for where I do this at the moment)
Probably a naive question, but is there no way to get the StaffType from the note instead of passing it and do something different if the stafftype is a  a StaffTypeTablature and not null? The signature of the method just feel weird from the outside.
Instead of removing this existing test for LowercaseUnderscores, can we supplement the lowercase underscores test with an additional test for dashes? Doing so will help us ensure both deserialization approaches stay working after future changes.
I'd guess this would be an array of groups.
Can you make this a bit more descriptive. I'm not entirely sure what's meant here.
That's a good point and going against what is currently implemented. At the moment administration for tenants is happening on the tenant port. I suggest we make a story point out of tenant admin on global server, I'll take that one.
This should probably be 'Could not delete from S3'.
Will this be used for load and unit testing purposes only? Would it worth moving this to its own directory?
To be consistent with the codebase, I think we can just use `rows` instead of `pagedRows` here.
Bad boy!
In the same vein I wonder if it should be the Mapper that throws the ResourceNotFound exception as it is in a better position to provide useful details. Hmm…
shad eplugin -> shade plugin
Maybe this should be:

```
@response && @response['_links'] && @response['_links']['self'] && @response['_links']['self']['href']
```

And then the has_url? method should be just:

```
!!url
```
Hmm, vi kan ikke flytte denne inn i `app/views/home/index.html.erb`? Er det fordi den skal ha full bredde? Kanskje det er ryddigere å bruke `<%= yield :mega_header %>` her og la `index.html.erb` ha en `content_for :mega_hader`-blokk, framfor sjekk på instansvariablen.
`InvalidOperationException` it is. I will look at moving the checkout tests into a separate `CheckoutFixture` file next.
clustering (not clutering :) )
I think it would be more consistent with how we've been coding things to set this attribute to None if it doesn't exist, and here check `if self._unmixing is not None:`, unless there's a compelling reason not to code it that way.
duplicated import pyflakes :)
This should be done in the same format as the rest of our docs
conceptDescription.getDescrption() will always be empty here so maybe it's better to log conceptDescription.getId() or not  to log it at all.
In js, do you get any performance gain initializing the array with a number of elements? If so, then this is good. But if it's just a "let's try to feel like Java" hangover, lets just do `result = [];`
Ok, so I can change that to "without any unhandled Exception or any Errors"?
我们斟酌了一下，觉得还是”默认页”比"首页"更好
This would be easier to read without the `if` surprise.

This is a bit of a change, right? Previously the user could set `s3_server_side_encryption` to `''` (the empty string) to disable it. Now, they have to use either `nil` or `false` to disable it, and they can use a symbol instead of a string now too.

That's not a problem, just verifying that this was intentional and desired.
Translation are supposed to be modified on http://l10n.xwiki.org. You should only commit ApplicationResources.properties
`if(name.contains('/'))`... soon...
which I'm guessing you just noticed at the same time!
Кто накостыляет?
The URL here is absolute, I did the test under a subdirectory and it failed because it just returned "/generate-captcha"
I think we should use the URL generator to generate this URL
Is there a way to automate generation of version so you don't need to specify it with every change?  Or maybe just remove it since it's specified in the POM.
Shouldn't that test also check that status_is(404) ?
please use the route name
Check language & load it instead of ''
With the strict option or no, capp_lint just isn't reporting this.
Fixed by next commit
Yes, your solution is better.
Maybe `B` for Before and `A` for After?
More import spacing
An more toString(), please remove them all. The fact that you mark '%s' is enough for the logger to know it needs to call toString()
please undo ;)
Merge with what other existing results?  We have an empty dictionary and patch_cattr.  If patch_inside is false, then patch_cattr is also empty.  It is only if patch_inside is True that any possibility of a non-empty dictionary comes back, in which case, I may want that information.  A particular usecase I can think of is selecting the contour labels interactively.
My rationale was to make it semi-consistent with hist return value.
Mmm yeah. I don't know how long the APC key can be, which was my worry. I'll do some looking, maybe we can store the DSN in the key.
Addressed in 9070c2e3dd8b8520b39c4422aeacd0c20373aad0.
Tim Smith says use this, maybe.
What's wrong? Did you try?

This code is tested and doesn't produce such replacement as you say. $create_query contains only table structure definition. Whitespaces on each side guarantee that this can be only the field type. It can't be field name because of any MSSQL field needs to be quoted.
Move js to a js file.  Use `{PSU_JS}` to include it.
Sure, I would like to do that, but I wanted to make sure that it's worth it.
Instead of using a Tuple, just use two parameters. Also, the casing should be `getSafeProperty`
@bp323 Is there a need to make this variable global to this widget?
It seems to be only used in `renderThemes`
we usually add a private: statement again for member variables - btw - why do the others below have to be protected? isn't private sufficient?
no that is totally fine. I would expect examples to have more dims than there are classes ...
Does a default nginx setup have a crt and key generated? Is it SilverStripe specfic? If not, I would leave this out of the instructions for simplicity - it can easily be found as a generic nginx tutorial on the web, right?
try <script type="text/javascript" src="//ajax.googleapis.com/ajax/libs/jquery/1.7/jquery.min.js"></script>
:+1: from me for ViewFactory
Yeah true, but also all other values (port and chunk_size) will be removed, so I *only* have the id left in the array.
I don't like this change, it removes .bg1 and .bg2 and requires style to implement .reported background. It would make more sense to add .reported in addition to background color, like this:

<div class="post <!-- IF topic_review_row.POST_ID == REPORTED_POST_ID -->reported <!-- ENDIF --><!-- IF topic_review_row.S_ROW_COUNT is odd -->bg1<!-- ELSE -->bg2<!-- ENDIF -->">
acp_customisations ?
You mean the colon for member functions? I would say there is a lot of other ugliness in the code...  

w0w.. didn't even know we could do this commenting in lines. O.O
I couldn't find a nice way to pretty print a tree the other day either. I don't think such a thing exists yet. Maybe it's time we fixed that.
"a Environment..." => "an Environment"
You shouldn't need to add this check - after having reset the defaultenginename pref, originalDefaultEngine is garanteed to be present and represent the the build's default engine, unless its default value is corrupt due to e.g. an addon, but I don't think we should try to handle that case.
`@return  boolean  True on success.`
Totally agreed! This part of the code is just part of the "this is only a gross-looking proof-of-concept that glues together all our cool stuff" state of the code right now... will convert to your suggestion next.
Prior to the addition of this method, the only version that existed was:

* Job.create(String query, Map args)
Private fields please.
I've changed the interpreter to make it more compatible with different python installations.
Why you have not reused views from `django.contrib.auth`?
You should create this URL better. This is not the correct way. (You will need to have a view for about page defined, which is not yet defined, but you can prepare an empty page for that.)
Have you been on lecture where professor explain the best structure of form?
Why are you changing this? What is wrong with button?
You mean like this:
```from piplmesh.api import authorization```
```from piplmesh.api import models as api_models```
Man i hated it. form.html didnt work the way I wanted so I made a new one.  Will think of better way on next request.

My idea was that i show you design (login window) and then if you like it i'll continue with the idea and expand it on the whole app.
OK, here is solution how to do it: https://github.com/MongoEngine/mongoengine/issues/140

You have to define that indexes should be sparse.
`r` missing here.
This document isn't included in any table of contents & `make html` complains about it.
I think the version suffix is not needed here because homebrew does only link `bin lib share sbin` (and a few others) but not `gcc`.
It remains at `/usr/local/Cellar/gcc/4.7.2/gcc`.
Oh, and the sha1 should be a string, e.g. `'d0543623d21663d075c64ba050f2eef54f679f5e'` instead of `d0543623d21663d075c64ba050f2eef54f679f5e`.
What is with the extra space?
```c++
-if (!sSpellMgr->GetSpellInfo(spell->Effects[1].BasePoints))
+if (!sSpellMgr->GetSpellInfo(spell->Effects[EFFECT_1].CalcValue()))
```

basepoint is -1
Since both methods are called UnSummon, have you considered making it a virtual instead of this casting?
I see an issue here: if you register DoctrineBundle after SecurityBundle, this will overwrite the service configured explicitly by the suer in the SecurityBundle config
hmm, I based this off Rails' reopening of module to add `mattr_reader`, `mattr_writer`... There are other methods of doing this though if you don't like it.
oh wait it is not sorted
This is really just for testing, it will gone as soon.
well this is odd, idk why it is here, anyway the pull request for badges can be accepted and this will be fine
isn't this for loop just a numpy indexing
``H[nz_idx[:,None], nz_idx]``
I guess [`#each_with_index`](http://ruby-doc.org/core-1.9.3/Enumerable.html#method-i-each_with_index) would look a bit nicer here. 

Also, I believe every `gsub!` call iterates through the whole string, and you can get the same result with a single walk through like that:

```ruby
format.dup.gsub!(/\{(\d+)\}/) { elements[$1.to_i] }
```
Of course, it doesn't matter if you deal with short arrays as in this case. Just sharing an idea.
I don't think console.warn is a cross-browser-compatible solution. Dygraphs has a series of methods which you should look at (e.g. Dygraphs.WARN, or is it warn, or warning? I can't remember.)
We could use space and just make the object type an argument, which would make it more consistent with how groups and clients are specified in the command below.  This would also make processing the arguments a bit easier.

I like the `knife node acl` syntax as well, which could be accomplished pretty easily with a bit of metaprogramming.

For now I think I prefer just using a space.
What about multi-extension fits file as in demo script 2?  Could be useful to keep that option if someone is simulating many galaxies of very different sizes, for which requiring output images to all be the same size (as in a data cube) would result in tons of wasted whitespace around the images of the smaller galaxies.
Why is ```default=None```?  I would think that the default for FITS output should be ```.fits```.
I am sorry, I am reviewing the wrong pull request
I'd name this removeAll(MachineSet) or remove(MachineSet).
Naming convention in things like BigDecimal is add() and subtract(), so I think that's what people will be used to.
I think we want to do manage and then start.
I don't follow. Three lines have changed text. But the first two have just changed white space: they now have a 9 space indent. Hence me saying that there is just a strange white space change here.
Quite right.  Patch incoming.
あ、そうですね。使ってないので消します
As this Login PAge doesn't exist anymore delete this and move the `login` function (which works perfectly) into the Base Page.
i realized later that `#convert?` checks both if unit converter is defined AND if convert options are present... so really your logic is not wrong, it's just that it can be unraveled/DRYed.

    if convert_options_present?        # if the user has specified any options
      value = convert_units value, row # inside this method, raises unless unit converter is defined
    end
Yes, we'll have to for Storm eventually. I'll open a Jira.
I agree with you and updated the tests accordingly except for ``test_dashboard_update_page_valid_url_unchanged`` which I think is easier to test within the same method.
This line - I think we should slurp up the index.json file into a variable then output it.
```php
if (! file_exists($path . 'index.json')
{
   Response::error('202');
}

// The decode here might not be required.
$index = json_decode(file_get_contents($path . 'index.json'));

return Response::json($index);
```

This is because the Response method uses the correct headers for a JSON file, otherwise Laravel is essentially returning a HTML doctype, which may cause headaches down the line.
Looks good, but there is a virtualFieldSeparator property, I think on the driver class, we should use it instead.
this function is not easy implement in MongoTrials, if design needs it, may need to be rethought.
Please change the name of id parameter to ownerId or userId.
Shouldn't this have an ending `()`. Nitpicky I know.
`$client = new APSource();`
Yea, this should be elsewhere.
Forgot a line here.  I will add it in the morning.  Zones share between themselves twice, so the value for sharing with unsimulated turfs should be doubled, to produce the correct value.
Line needed: "ratio *= 2"
I don't think it matters for comparison or equality. For display though we should definitely be converting to the timezone of the region of the deal

```ruby
[Time.now.to_i, Time.zone.now.to_i]
=> [1350588397, 1350588397]
```
i forget - does this break if you aren't using mptt or does it fail gracefully?
Actually, we have to think about mDNS based serverless and non-local serverless (e.g. with IP address).  In the latter case, we *would* want to use a proxy / tor.

It would probably be best to separate these two cases into separate providers (almost same code really, with a flag deciding whether to use mDNS, etc.).
I understand that we want to get rid of tab references, but here, it's justified. The goal of this command really is "toggle toolbox for tab". In the future, we will have other commands to open the toolbox for "chrome", or to start a toolbox for a remote target.
Yeha Sia and I battled this a bit on Friday. I found a solution that worked for me using the wait_for_page in page.py over my grid but it didn't work for her.
We'll have to revisit or remove the assertion as otherwise the test is spot on. and we've had problems with this page load action on marketplace before. It's a bit tricky.
How about making this more flexible and less json specific?

Maybe like this?

```
request_format:
    method: accept_header|format_param
    format: json|xml|anything
```
I'll push through updates with extra space removed
Some of these links are specific to the OMERO documentation. Better to repopulate this list when running linkchecker on bioformats documentation.
Can you add a test that uses `load_svmlight_files` too?
should be convit is deprecated
Square was mad? :P
Should not print purity if it is the default.
Is this test duplicated in testInvalidIsIndexableCallbacks? - there looks to be a similar invalid callback in the data provider
Don't see any cases when nextEventId becomes < 1. When that would happen?
This method feels very specialized and like it's doing a bit too much.  Maybe we should just make this a `- (NSURL*)defaultDocumentsCacheURL` and not automatically set it as the downloadCacheDirectory.
This isn't very prescriptive but it's better than nothing for now.
It would clearer/more maintainable if you did the :
>pThor->queryPropTree(sThorMasterProcess.str())

once.

Also, looks like you can common up these two branches, once you've established whether you're wanting to setup the new pProcessNode (and add it) or set properties into existing 'pMasterNode' , both can be same setProp* calls.
Yes, just like those ;)
No, not yet, it will easy enough to add, but want to make a separate commit
Shouldn't this (and the ones above) be:
params[key] = value ...
?
Arh! I'm a complete idiot. I have no idea why I managed to get myself so confused. I'm sorry.
why does the compute node need this? I think this was left here by mistake.
this is going to cause a lot of conflicts b/c pip could be installed by other services. You may want to look into ensure_resource from stdlib.
Debug output left over here.
I'm not sure it's worth it really. For example we could change event/core completely, but that should not affect `EventTarget`  and it's tests, so I thought it was a better choice.
I think `a` isn't usefull here:
`In the Add-on SDK we follow [CommodJS Promises/A]`
This is directly return the PHP `file_get_contents` method. What do you suggest?
null | string?
please remove the extra empty line and the extra space in ``elseif``
@shacker can we nest this?
@shacker Well it will actually use `image_url` beneath the cover, which then uses `asset_path`. `image-url` can only be used in SASS, not bare CSS. We had to do this since we can't do `@import *.scss.erb`.

I've also added a link to more docs on the commit itself:
http://rubydoc.info/github/petebrowne/sprockets-sass/master/Sprockets/Sass/Functions
The surrounding `if` is not necessary. `(= (width rectangle) (height rectangle))` already has the right boolean value.
why not <=2.2-dev? does the bundle not work with the current master anymore?
extra empty line, and missing space after the typecast
Is this necessary? I find it reduces readability.
@bodepd thanks for the notice, this is now fixed :wink:
Try:

	password = ::Rex::Text.to_utf8(some_string)

Rex functions are in Metasploit lib.
Throughout the PR, spaces after type, e.g. ``image : (width, ...``.
PEP-8 also says ""A style guide is about consistency. Consistency with this style guide is important. Consistency within a project is more important. Consistency within one module or function is most important."""

I never, ever use two spaces, whether in prose or in code (to separate variable, statements or comments).
This is definitely wrong. What are you doing here?
If I do that, then if someone passes a non-numeric type into the method they don't see the exception.
Should this logic be in a `configure` function in `PerspectiveOffCenterFrustum`?  In general, implementing the perspective frustum with a "has a" relationship to the off-center frustum is initially a bit confusing.
I got rid of ellipsoidIntersections (there was already an equivalent method in IntersectionTests that I missed before).  The keydownHandler is extremely useful for debugging, though.  But maybe it detracts from the example.  I'm kind of torn, honestly.
Yes, I do remember the discussion and also remember that we were going to guarantee that methods names would be unique. Therefore, rather than reusing them and do this hack, then we should have unique names that may delegate calls to the mixins u want to reuse. 

All I can say this goes against a policy we all agreed. It is your call.
Can this be simply:
```JavaScript
target: opts.target,
```
?
Let's just replace `:error` with `condition` and use that downstream.
Is this a read-only property? If so, add "permission: read-only".
Well...hmm...perhaps it would be better to just minify the output from PHP instead of hand minifying. That way it can be turned on and off for debugging/production.
I don't believe this type is consistent with how we document callbacks. Do you prefer the layout this way?
I wasn't thinking this to be a tool that geneartes js code to check in, but to generate js code when you want to deploy the samples or test samples in a non-dartium browser. I was thinking at some point the samples would be on a live site.
it's not going to download it every time! BTW tests are configured to connect to a running AS if you have one already, or start this one embedded if you don't. I like to have tests covering all configurations also when building locally.
Это не марк, марк происходит в момент драга. Это просьба делать марк вот на этом элементе, пожалуйста.
Sorry, I forgot to account for that.
Pushed fix here:  paulegan@a77210c85314c8b1c7dbc6411840eb92a88bb7ec
I'm trying to remember if I changed something in the ajax loader to make things work, but I don't think I did. I see why the red is above now. :)
This is bogus here!
Or just :

* XmlMetaDataProvider
* AnnotationMetaDataProvider
* ProgrammaticMetaDataProvider

This does also not conflict with _ConfigurationSource_
On that note, wouldn't it be nicer to turn things around? _ValidatableParamters_, _ValidatableReturnValue_ and _ValidatableBeanMetaData_. Which leads me to _BeanMetaData_. Maybe that should just be _ValidatableBean_?
Put docstrings in triple quotes.
This must be the magical rake tasks that @bousquet used the other day.  I figured those were custom rake tasks in `thincloud-authentication`, didn't know bundler provided them, I'll restore.
I agree with Theo, better to remove the first sentence.
I did an update in the recipe after merging this.
Ok, I created a pull request for is_https() function...

https://github.com/EllisLab/CodeIgniter/pull/1094
false  >>  FALSE
We keep them on github. However, TODOs are not there; usually such cleanup work is a part of the exit criteria for a milestone.
Typically, the XML namespace is managed by the DOM, and should not by specified directly.
Is the .toString() really required here?
Instead of providing a new plugin manager; would it potentially make sense to utilize the module to inject the view helper much like the others or is there some unintended consequence that I am not seeing?
It was from my original visitor implementation...I'm removing since it's not affecting anymore.
Ah you're right - I thought sass-rails specified 3.2. Thanks, I'll add the dep now.
`is on channels`
why not determineScore()?
Good point. In fact the way I structured the code was done with the goal that XML should win/override annotation
/**
	 * Obtains the lock associcated with the parameter object.
	 * @param lockRoot The object with which the lock is associated.
	 * @return The associated lock.
	 */
Then a documentation entry needs to be added to the XSD mentioning that POST is the default. While at it, the mutual exclusivity also should be documented (typically we say "this attribute cannot be provided if X has a value" or something similar).
ouch! youre right. missed that one. thanks.
Definitely. That was a mistake I made. Just waiting to see if Louis is already working on this.

Thanks Rob.
ok sounds good. it's removed.
Woops I thought these were functions given that the original devs do the same thing
Yes you are right about building it. Java is needed to run it after its built.
-----Original Message-----
From: James Keshavarzi <notifications@github.com>
Date: Wed, 05 Dec 2012 13:41:51 
To: blackberry/BB10-Webworks-Packager<BB10-Webworks-Packager@noreply.github.com>
Reply-To: blackberry/BB10-Webworks-Packager <reply@reply.github.com>
Cc: Mike Robinson<badtoyz@gmail.com>
Subject: Re: [BB10-Webworks-Packager] Updating README.md - Adding info for
 prereq step to build node on Linux (#229)

> @@ -7,6 +7,7 @@ This repo contains the code for the BlackBerry 10 WebWorks Packager and submodul
>  2. Install [BlackBerry Native SDK](https://bdsc.webapps.blackberry.com/native/).
>  3. Install [BlackBerry 10 WebWorks SDK](https://developer.blackberry.com/html5/download/sdk).
>  4. [*Windows*] Add Git bin to PATH. i.e. `*Installation Directory*\bin`
> +5. [*Linux*] Build node[v0.6.10], ensure it works on your distro and copy the binary into `third_party\node\linux\` folder

Why does it need OpenJSK @badtoyz? What exactly requires java?
Should be able to build without it?

---
Reply to this email directly or view it on GitHub:
https://github.com/blackberry/BB10-Webworks-Packager/pull/229/files#r2327600
I'm not sure whether a Paypal sub-namespace makes sense, after all we are in the Paypal bundle.
The `margin-left` and `border-left` bits of this will need to go in `ltr.css` with reversed versions in `rtl.css`.
isn't this implemented on the base class?
I don't like this; this should rather be limited in some way at least... e.g. ms

On Tue, Jul 24, 2012 at 9:05 AM, Peter Grman
<reply@reply.github.com>
wrote:
>> +    /**
>> +     * The type of the requirement (New feature, improvement, ...)
>> +     */
>> +    public Type getType() {
>> +        return type;
>> +    }
>> +
>> +    public void setType(Type type) {
>> +        this.type = type;
>> +    }
>> +
>> +    /**
>> +     * The time estimated to develop the requirement starting from when it has been approved.
>> +     * Can be defined as man-days, man-weeks, ...
>> +     */
>> +    public String getEstimatedTime() {
>
> I defined it as string so that users can write what ever they want - I don't know it it's used usually by issue trackers or only for the planning
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-domain-requirement/pull/1/files#r1222632
No need for this. Do something like this:

<pre>
int updated = db.update(TBL_HISTORY_EXT, cv, where, args);
if (updated > 0) {
  // Log
  return;
}
db.insert(TBL_HISTORY_EXT, null, cv);
</pre>

The update *is* a query, followed by an in-place update on the cursor within the same transaction. Might as well save the round-trip and such.
Again we need to conform to the drupal naming conventions.
http://drupal.org/coding-standards#naming
I would prefer a more comprehensive message to the user looking at the build log. And then the stacktrace to the logger that the admin is looking at (naming the build since that context is lost there).
FWIW, I changed this into `if (element != document.activeElement) { … }` which is equivalent in functionality but avoids some function call overhead. See 5a01d981b6c75dbe50af347b5ede746917abdffc.
А, раз у вас оно действительно причиняет проблеммы, то и пес с им тогда.
This line was deleted in the deltaRobotNode manifest. The package obviously doesn't exist in ROS, so the link is dead.