labofsahil/github-event-dataset-2012 huggingface dataset:
Hi Juan,
this piece of code is creating a list of runtime portlet ids. So, this way, you will have on the client side a list of runtime portlet ids, the same way you already have a list of "normal" portlet ids through "Liferay.Portlet.list" variable. In my previous commit I fetched this list via selectors, but Nate said that I should put runtime portlets in Liferay.Portlet.list variable. But instead of that I have created a new list to distinguish runtime portlets from normal portlets because if they are in the same list, you will not be able to find out what are runtime portlets after in the code. The same behavior is on the server side. You have a list of normal porltets and a list of runtime portlets
This is not good, I'll try look at it during the weekend.
It is not as if I am using the raw IP address. Your story can be said for every url used in CP. nzbmatrix, couchpotatoapp, nzbs, themoviedb, etc. 
depiraatbaai.be is using the same nameservers as thepiratebay.org
Your request is very specific and not required by most of the users. Also, as discussed in #3552, there is the duplicate content problem. Since you can easily implement the feature as extension, there is no need to add it to the core.
why not connect QDialog::rejected with onAutoDelete() instead ?
or even better: connect finished() with onAutoDelete()
btw, onAutoDelete doesn't sound right, there is no "auto delete" action here.
rename onAutoDelete into autoDelete ? (but why "auto" ? 
-> find a better name)
I had a wrong feeling about the commits status. This is my second try to commit the code just before you find out that I was trying to push changes to a wrong repository. When I wrote the second comment I tough that the first comment was lost, but actually it was just ready to be pushed into repository. My intention was to make just a single commit and a single push.
You can replace the sequence of 'if / elseif / elseif' with a case / when structure.
use .to_i instead of Integer()
m_bIsHeroic is true for 10heroic and 25heroic (">", not ">=" 25normal)

I didnt compile it, virtual members were declared in wrong way. More clear and maybe proper way here: https://github.com/michalpolko/scriptdev2/commit/52310e72dbd02c2616592e43be3c7afdbcfae836
The overlays open inside the toolbar iframe (which is transparent and extends to cover the whole page when this happens.)
Space is not a number or a letter. Neither is `(`, `)`, `[`, `]`, `{`, `+`, `/`, `<`, `>`, … you get the point.

1. Change the message to "must contain one of `!@#$%^&*?_~-` at least twice".
2. Change the regexp to `/([^a-z0-9][a-z0-9]*){2,}/i`.
Please note this will most likely break active record.
Right on, thanks for the heads-up!
this  makes the following release noop
Would be nice to include a non regression test :)
That may help...
If I recall correctly the portal is friendly for the players, and would therefore have any player in its treatlist.
Even if that wasn't the case it still probably won't work, in theory it is possible that the script select the same player in every cycle. In that case not every player gets buffed, it might be better to use MoveInLineOfSight to apply the buff.

In any case it isn't blizzlike, so I wonder why you would include this way of buffing?
You removed MojamComponent?
Nice!
But shouldn't the tdata member be removed completely then?
Kenji keeps using and re-introducing it in his pull requests.
o.O What?!?! :(
Because url starting with  ```// ``` are protocol relative urls that lets the browser decide between https or http see for example : http://blog.wikimedia.org/2011/07/19/protocol-relative-urls-enabled-on-test-wikipedia-org/
You might be leaking data here.
The preface reads too much like a brochure, it should introduce the policy manual, not the company and it's direction. Also, I notice you pretty much re-wrote my section. We should talk about the style of the document because clearly we have some disagreements and I'm sure you don't want to have to re-write everything I do. especially when we get to the proposal.
Should be able to write this as

    jvmArgs "-javaagent:${configurations.jacoco.asPath}=destfile=${buildDir}/jacoco.exec,includes=org.springframework.integration.*"
Where?  I've searched through both files here and see none.  When I originally wrote the commit I searched the sapphire and cms code bases and the only hard-coded ones I found were either updated with my commit or else were in tests - which don't need to be changed.
WAT ?!
Nice to hear that it works seamless :)
I'll test. Thanks. :)
Hi, i'm using your horizontallistview with remoteImageView ignition lib (https://github.com/kaeppler/ignition) which is basically implementing async loading of web image. However there seems to be an issue when I use the view inside the horizontalListView. The image can't load anymore, even not showing the progress spin. I have tried to use default ImageView and it works fine, so I guess the issue is within the async loading
You're not including a column for commands.

I don't honestly know if that's a problem, but think about it for a moment, please.
vprint_status()
yeah I get it, I made a mistake, I don't need to be talked to like a
child, thanks.

On Wed, Mar 7, 2012 at 12:51 PM, Scott McClaugherty
<reply@reply.github.com>
wrote:
> And that's why wou always check your commits before you push.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/gamefreak/Reddit-Enhancement-Suite/commit/90cda982613181cb01bd719c421331423cc3600f#commitcomment-1054994
You might want to fetch and rebase again. I did push BVAL-270 :)
Delete
/dev/msm_vidc_reg 0660 system audio
/dev/msm_vidc_dec 0660 system audio
/dev/msm_vidc_enc 0660 system audio

Add
/dev/msm_vidc* 0660 system graphics

Video is fixed
A short description describes what the purpose of the function or method is - it doesn't just repeat the name of the entity.

 > Returns the latest version of the plugin according to the readme file on Github.

would be a better short description here for instance.
My old console based editor let me see at most 80 chars in a single row.
aggreeded, I will move this out into Tag.collection_to_string
at the time, I was just focused on it's use as a member of a RequirementSet.
I see your pt.  I'll change it.
Oh you're right, my apologies. That's what I get for trying to read the diff on an iPhone. I agree with you that it's clearer to have upgrade be a property of `InstallRequirement`. Additionally, I think the test I was using for subrequirements is a bit fragile (it tests whether the `comes_from` property is an instance of `InstallRequirement`).

What do you think about also passing a keyword argument to `InstallRequirement` indicating whether the requirement is a dependency (i.e. subrequirement)? It might be useful if pip ever wants to add a prompt feature similar to what you see in apt, yum, and brew that lists the packages that will be installed / updated and dependencies that will be installed/updated.
Navbar doesn't have an icon, only buttons in navbar have.
Lets make this public, this could be handy for consumers of DbUp and then you don't have to use InternalsVisibleTo in the assembly info.
The error that it raises is not great when someone typos a file with -l.  I'll add some better error handling here.
yup: http://www.ietf.org/rfc/rfc2396.txt
That is not obvious to me ATM. What would we use it for? Also, we have lots of Configurators and FactoryProviders, and none of them extend Creator[], which is only used for actors anyway. When would you want to abstract over the thing which is created?
I still say that it should log LogEvent an EventStream and not use Futures or ExecutionContexts.
Don't use type annotations for local variables.
Yes, that's the java idiom, "By convention, any method that exits by throwing an InterruptedException clears interrupt status when it does so".
Will add better comment.
It's not immediately obvious what this means
Right. Saw your comment now. Good.
This message seems a bit odd, also, if we get multiple Failure(e: AskTimeoutException) we schedule multiple joinSeedNodeTimeouts
why change? clean() is *very* side-effecting
To me that code is a WTF since it looks analogous to:

something match {
  case Some(x) => Some(x)
  case …
}
yes, it looks a lot more funny outside of Eclipse.
?? then it wouldn't be very optional
Here we go.. https://github.com/akka/akka/pull/786
This assumes DATADIR is PREFIX/share, but the user of the Makefile might theoretically have set it to something else.
Also, maybe we should default BINDIR to PREFIX/bin, and use BINDIR instead of that, below
Card[:css].  yeah, we've definitely got to use the existing fetch mechanism as the codename api.
Probably we don't want this, but if it is used that code needs to use your latest error procesing
its very handy to have a simple example at bottom of files and eventually a more complicated in the examples dir
We should change it in recline itself.
Perhaps a use case to indicate how you'd actually use this (a test case could reasonably "install" something in ~/LibraryFrameworks and subsequently attempt to load it)?
Default of all chunks
Shouldn't this and the NoTaskPersistance be object instead of classes?
zygote may have died (and reaped) before we actually read the message. Not a problem as long as we manage the accounting data (zygote_collection) properly. I think we manage the collection properly with these changes. Updating application (HUP) continuously with active clients I didn't see any issues regarding that.
imports must be relative otherwise node 0.6 cannot run the tests
Can you check your formatting here, and below? It looks like you have two tabs extra padding on both.
It's automatic-- look at our setter method.

--  
Aditya.


On Saturday, November 10, 2012 at 11:06 AM, Jonathan Willing wrote:

> In lib/UIKit/TUIScroller.m:
> > + [self _updateKnobAlphaWithSpeed:TUIScrollerStateChangeSpeed]; > + } > +} > + > +- (void)_refreshKnobTimer { > + if([NSScroller preferredScrollerStyle] != NSScrollerStyleOverlay) > + return; > + > + TUIScrollViewIndicatorVisibility visibility; > + if(self.vertical) > + visibility = self.scrollView.verticalScrollIndicatorVisibility; > + else > + visibility = self.scrollView.horizontalScrollIndicatorVisibility; > + > + if(visibility != TUIScrollViewIndicatorVisibleNever) { > + self.hideKnobTimer = nil;  
> Just setting the timer to nil isn't enough, it should be invalidated as well.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/github/twui/pull/109/files#r2091551).  
>  
>  
>
Ok no worries @royvandewater, thanks to @netzpirat for the fix!
Please remove the two lines above.
I suppose not "at" since that's used in atropos
Though, I should also note for the record that it'd be much better to just fix the multi-iter to handle 0-d arrays instead of adding another layer of hacks here... (The phrase "for the record" means that I'm not really opposed to merging this as a temporary fix if no-one steps up immediately to do the proper fix.)
But why send both args.serializers, args?
What's up with the spaces here? Can you check that (and the other below)?
I'm pretty sure CSS people use dashes. Not 100% on this. @chriseppstein?
I think we need to make this explanation more clear. Maybe with one example of the behavior
Ok, i can do it.
prefer one-liner here
ahh I see what you tried to explain. Sorry :sweat:
no, there was one more case in the meantime and I didn't revert when that went away, will fix
Maybe create a data type for the result here.

```
sealed abstract class SearchResult {
  def insertionPoint: Int
}

case class Found(foundIndex: Int) extends SearchResult {
  def insertionPoint = foundIndex 
} 
case class InsertionPoint(insertionPoint: Int) extends SearchResult
```
Technically, yes? In practice, I have difficulty seeing it coming up much.  I'll do it anyway.
What would atPos do if it traversed through positioned nodes? Nothing should be wrapping trees within other trees without establishing that the resulting tree is properly formed; that includes not having a type unless all the trees below it have a type, and not having a position unless all the trees below it have a position. I'm not saying we're anywhere near this right now, only that almost everything assumes that those invariants are maintained.
You're correct, it doesn't get set. I'm getting rid of the ```@entries``` variable and the setting of it via ```||=```. Since neither of them are really needed. We use memoization on the calls to methods that call ```entries```.
it should def take the timerange object.
the product of 5/16*16/5 is a floating point number and its result is 1.0 , until and unless the user type it as S(5)/16 and S(16)/5, so, sin((2*pi)*1.0) is not equal to zero(I assumed like this) and hence, will return the same output.

So, the user has to input as S(5)/16 and S(16)/5. I was asking about this to Mr. Sean Vig (flacjacket) over IRC channel and he also said the same thing , that it depends on users input.
```
>>> from sympy.rules import rm_id
>>> squash_zeroes = rm_id(lambda x: x==0)
>>> squash_zeroes(Basic(1, 0, 2, 0, 3))
Basic(1, 2, 3)
```

so it clearly remove all zeroes.
Did you mean "this PR", or is there another PR related to this?
Another problem is that all constructors are inherited by principle:
`def constructor(self, *args, **kwargs):
    if ...
        return inherited_class_obj
    return super(...)
`
thus, we can't correctly implement unimodular argument check.
Oh yes, sure :-D Sorry, fixing.
It is not possible. lens and file path belongs to class and it is needed from instance. It is in ruby two different objects so you need public access. What reason do you see to not have it public?
I can change it to public getter and protected setter, but then in client you need to write
```
self.file_path = "something"
```
which  I found not so nice as it is now.
What's the point of the temporary variable here? Why not just assign directly?
Richard,

That may just be habit on my part. *.beam in the top level makes it
ignore beams everywhere. I can fix that and resubmit the pull request
if you like.

Eric

On Mon, May 7, 2012 at 2:04 AM, Richard Carlsson
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,2 @@
>> +_build
>> +*.beam
>
> why a *.beam at the top level? it's already in bin/.gitignore
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/etnt/gettext/pull/9/files#r779922
It seems arguable whether a right-floated "more" or a simple link-looking "..." is better. I'm okay with either.

The `.split(" ").slice(0, -1).join(" ")` seems like nonsense, though. What are you trying to do? From the looks of it, the code you have would truncate to 180 characters minus one word.
abhor the first person.
add whitespace between x==y==True
Can you make it so that -m can be passed into `ghar commit` instead?
Once your board is on a webserver supporting rewrite, you can not move to a webserver not supporting rewrite, because then all your old URLs no longer exist. Maybe rewrite could be left on and beautiful path settings managed from the ACP.
For binary updates this will need to have the arch
Yeah that sounds good to me.
Yup. Will eventually convert this to a grunt task. That's why it's in the grunt folder. Will do this after we are sure we're happy with this approach.
This information is nice to have at the top of the definition. Especially when you first dive in to it.
Good.
On Jul 19, 2012 10:10 AM, "Jeremy Malczyk" <
reply@reply.github.com>
wrote:

> > @@ -305,6 +312,26 @@ mol.modules.map.query = function(mol) {
> >                               }
> >                           );
> >                           _.each(
> > +                             $('.eol',$(infoWindow.content)),
> > +                             function(button) {
> > +
> if(button.value==''||button.value=='null') {
> > +                                    $(button).click(
> > +                                         function(event) {
> > +                                            var win = window.open('
> http://eol.org/search/?q={0}'.format($(this).data('sciname')));
>
> As far as I can tell, there is no JQuery method for opening a window, and
> window.open is supported across all browsers.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/MapofLife/MOL/pull/112/files#r1198862
>
Ah yes, and here as well of course.
Should that be "self.inputs_val = inputs_val?"
Also, I would replace None by [], so that the "for val in self.inputs_val" below works.
The "if op_version" is important. In the case where op_version is empty, we must also return an empty tuple. Otherwise we use caching when the scalar op doesn't support it.
I made a PR for this. If the 4d are contiguous, we reshape it to make it work.

https://github.com/Theano/Theano/issues/726
ditto (one big structure to compare)
It would be nice to also print sometihing allowing us to identify the specific issue, like the issue ID
Why is this here?
If we want to change transitions to 300 ms, we should do it in the UI (maybe a param?) where the animations are handled, this here might cause some iPhone "blurryness" - this is the initial reason why we removed it.
this function determines is it internal or user -- don't know this as this point
cfr_kept_internal is Mongo DB keyname
Same as above and as discussed :)
Is this correct - shouldn't the value still remain at 1 here?
yes - it is documented
s/md5um/md5sum/
Can you please move the asterisk over in this cast:

`(NSNumber *)`

or cast to `(id)` instead?
> There is a test that I believe should have caught this,

You'd have to edit a non-existent page to trigger the crash. That test looks for creation.
Is this code no longer used?
One bracker ] is removed , is this fine ?
I'm about nested capture. Isn't this right?
```
var x = 5;
var f = () ::shared> {//checking what is x. It is int32. Make it SharedPtr
    forward x = lambdaUnpack(closure);//x is a reference to a dereferenced SharedPtr
    var y = x + 1;
    var g = (z) ::shared> {
        forward x = lambdaUnpack(closure);//checking what is x. It is int32. Make it SharedPtr
    }
}
``` 
vs
```
var x = 5;
var f = () ::shared> {
    forward x = lambdaUnpack(closure);//x is a SharedPtr
    var y = x^+1;
    var g = (z) ::shared> {
        forward x, y = lambdaUnpack(closure); //Checking what is x. It is a SharedPtr. Ok, just copy it. Make y SharedPtr
    }
}
```
What are the use cases? If we don't expect to expand the signature then i definitely like four args vs the verbosity of `$.extend`.
Hmm this fix will only work for height but will break width?
My c++ is rusty, but it seems to me having empty functions should be acceptable and from an interface point of view it is better to call them than leave them commented out so that the implementation may do something in the future.

Florian, do you have a recommendation here?
Weird newline changes in this file.
This may not be necessary.
Does this need to be commented out? or is this just something that is left over from testing?
So "index" is probably the wrong word to use--you probably want to name this "get_mapping_type". This is fine to have. The other way we could do it is that mapping types register themselves as being a mapping type for a Django model, so we could add a "get_mapping_type_for_model" function to fjord.search.index.
"packages that need compiled" should probably be "packages that need compiling"?
Same nit as above, and for the instances below.
Squash it and force push to this branch, thanks.
Another bugfix/change - in order for us to work on full directory trees, we must check that we're in the same directory...
Added some explanatory docstrings.
Should this have some notion of a padding character that it strips from the field? E.g. if there's an age column with a 9-year old in, it shouldn't come out as `' 9'`.
why is this called `MongodbSession` since it's just a session (nothing specific to it).
Isn't eat easier to use as a splitRegExp a \S ?
Ich finde es so passend, höre mir aber auch gern Gegenvorschläge an ;)
We haven't picked the strategy.  Two ways to do that. First is to extend Dagger to support those Guice use-cases we are willing to support (without compromising Dagger).   The other strategy is to move Guice in Dagger's direction, so that at some point, Guice is a superset.  

To be honest, I'd vastly rather extend Dagger, since its source is cleaner and smaller, though not in this repo (i.e., either a fork, or extensions if we find the right seams without creating more indirection than you can stomach.)
The default queue size shouldn't be infinite, it can default to be fairly large though
willDestroyNode
Old syntax was way more natural, is it possible to retain it, at least in some form?
Can we call this SimpleDataItemExtensions?
If possible, we should find a way to handle this with local fixtures instead of hitting external servers for the tests. These could fail intermittently due to things out of our control.
Nit: whitespace between `if` and `(`.
Eventually we would run these tests as individual tests that get compared to expected values. I think it's worth splitting them up now and maybe even plugging in reasonable upper bound values.
Seems like it's possible to get into the opposite state than what is desired with the hidden class because you assume it's applied and toggleClass() will remove it. Same comment for handling "click" event: it assumes hidden is not applied and toggleClass() will add it.

 I think it will be safer to be more explicit about your intentions by using removeClass("hidden") here and addClass("hidden") when handling the "click" event.
By convention, we 'declare' instance variables on the prototype. This gives a handy place to hang documentation.
Bugfix: if we do not get a versionInfo, brackets would crash here.
Probably nice to XML escape this one too, for all the files with a "<" in the name.
Duplicates coll_type above.
curiousity question here - would a with statement on the return response be safe on closing up tidily here too?
if durations is empty, numpy.average returns NaN
Here you need to specify the member's array index you want to modify. Again, using `count` is bad since it is used by other parts of the program and can be changed easily from under your feet. Instead use another variable like `member_index` and make sure you set it to the member number you want to modify. All of the data in your arrays is linked by common indices - presumably each member has an assigned index and their data is available at that index in each array (so if my index was 19 my first name would be at First_Name[19], my age would be at age[19], etc... Again, using classes would simplify this: members[19].age and members[19].first_name, etc...)
Maybe it is better to set the map-window below the description text of the example:

        x: 20,
        y: 250,
Ah, so confused.  Let's try and get it sorted out in our meeting later today.
Why empty and not `true === $this->bulkDelete`?
This spacing too.
Maybe you can use `firstChild` instead.
Oh yeah -- this is what atul is going to be using for badges. I suppose I will take it out though, for us
Removing all of them, yep
When moving a plugin, these always evaluate to `NaN` because `options.minHeight` and `options.minWidth` are undefined, which causes height and width to always be set to `NaN`
also can these 3 ( or 2 ) for loops not be joined into 1 single one? Seems like they are looping over the same data each time.
wow, I derped reading that
Why create an empty function?
We could, but I feel it's more trouble than it's worth. For example, here's a valid and working sqlite config:

```json
{
  "database": {
    "options": {
      "dialect": "sqlite"
    }
  }
}
```

And here's a mysql config:

```json
{
  "database": {
    "database": "popcorn",
    "username": "popcorn",
    "password": "popcorn",
  }
}
```

Sure, you get a completely useless error message when your config is set incorrectly:

```
Jons-MacBook-Pro:butter jon$ node make server
### Serving butter
/Users/jon/Dropbox/Sites/butter/cornfield
Templates Dir: ../templates
Publish Dir: view
HTTP Server started on http://localhost:8888
Press Ctrl+C to stop
Executing: CREATE TABLE IF NOT EXISTS `Projects` (`id` INTEGER NOT NULL auto_increment , `data` TEXT NOT NULL, `email` VARCHAR(255) NOT NULL, `name` VARCHAR(255) NOT NULL, `author` VARCHAR(255) NOT NULL, `template` VARCHAR(255) NOT NULL, `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, PRIMARY KEY (`id`)) ENGINE=InnoDB;

/Users/jon/Dropbox/Sites/butter/node_modules/sequelize/node_modules/mysql/lib/client.js:370
    this.user.length + 1 +
             ^
TypeError: Cannot read property 'length' of null
    at Client._sendAuth (/Users/jon/Dropbox/Sites/butter/node_modules/sequelize/node_modules/mysql/lib/client.js:370:14)
    at Client._handlePacket (/Users/jon/Dropbox/Sites/butter/node_modules/sequelize/node_modules/mysql/lib/client.js:290:10)
    at Parser.EventEmitter.emit (events.js:88:17)
    at Parser.write.emitPacket (/Users/jon/Dropbox/Sites/butter/node_modules/sequelize/node_modules/mysql/lib/parser.js:71:14)
    at Parser.write (/Users/jon/Dropbox/Sites/butter/node_modules/sequelize/node_modules/mysql/lib/parser.js:576:7)
    at Socket.EventEmitter.emit (events.js:88:17)
    at TCP.onread (net.js:396:14)
server process exited with code 1
```

But ehhhhh the config required to validate a config for sqlite or mysql doesn't feel worth it.
You don't really want the default here. You just need to specify if you want the target manifest ignored completely.

<pre>
target: {
  hidden: true
}
</pre>
function name => `CFFHeaderClosure`
Yeah something like that. It's also becoming increasingly clear that you may need to re-run part(s) of the bootstrap process. I'm going to hold off on this because it's the first thing that would require ssh'ing out to be something that config knows how to do. Eventually there should be some kind of remote command runner at which point this would be much easier.
@kellyredding - Curiously, why does it go from 2 `\` to 6?
This is very confusing. `done` sounds like a boolean variable but you're putting essentially an enum in it. Perhaps it's better to decompose this into multiple variables?
When I read this line I get a little confused because it looks like we call ```merge_iq_with_medistrano_pir``` and then ```merge_pir_with_iq```, which look like two names for methods that do the same thing.  What's the difference between those methods?  It would be nice to make it more obvious why, after calling ```merge_iq_with_medistrano_pir``` you still need to call ```merge_pir_with_iq```.
I've renamed the step to:
```
And the app on the page should have a link to a database named "commondb"
```
Was this step failing before?  I don't see any code changes that would change this input.
Thoughts on making this an `if [ -e ...]` check instead?  Dropbox constantly mucks with my plugins and such since it converts symlinks to actual files.  Right now it looks like all of my plugins are disabled since they're all real files.
My fault, seen now.
Hmm, odd since both pass locally and on the grid - the only thing I can think of is your system somehow resolves 'missing' to an actual IP (ie. InetAddress.getByName returns a valid address). Since we can't mock out  InetAddress' static method we'll need to find some name that InetAddress.getByName always fails to find, possibly by adding in a few weird characters. It would also be good to add some kind of IT, using a proxy in-front of Nexus to avoid regressing NEXUS-959.

Wrt. expected behaviour, I couldn't find a definitive description of what this class should do - ie. how much trust to place on the XFF header (which can be spoofed). Adding extra verification steps can be expensive and since this method is called often then there's a trade-off between finding the definitive client IP in all cases and finding it in the general case, especially since this is used more for logging/auditing rather than security.

Anyway I'm happy to hand responsibility of this over to the Nexus team (can raise a JIRA issue if you wish), just wanted to report back some of the issues that bentmann, vlad, and myself found when re-using this code over in Insight.
Normal comment only // next 2 lines also
I'd rather not fix all the deficiencies of this script now, but suffice to say, this bash isn't particularly defensive. On platforms where spaces in paths are more common (Windows) you could get into trouble if path vars are not quoted.

http://mywiki.wooledge.org/BashPitfalls
Would be great if the readme could just be merged as is. Just append your awesome docs to the original ones?
It's part of MVVM Light framework for associating a View with it's ViewModel, it automagically generates that when you create a MVVM LIght app, if you'd like I can change it to be MVVM without the MVVM Light framework. (You are right, it might be a bit 'overkill' for such a basic sample.)
Why not do `overloads.FirstOrDefault(o => o.Matches(parameters))`
The way this is currently implemented requires conversion to a new Time object every time you access these attributes--it would think it would be better if this were cached?  Or maybe it doesn't matter.  Or maybe it could be optionally cached?
here can use "db" local variable instead of reference from Sequel::DATABASES.
Perhaps we could also mention the other RST documentation directly in the tree, which is readable also in a local checkout.
Because d.connect() takes two strings.
It was static for a reason: this function was not used outside of the util.cpp compilation unit, no?
as you asked for coding style errors: please indent this break the same depth as the printf :)
Need space after "if"
missing documentation comments
They are covered by the same area of Shell definition which issue #1 refers to.
I think we're talking about two different things here: "childtypes" instead of "types" is fine for me, because it designates types in the sense of TypeInterface. My last remark was about the key "type" (i.e. the one where the value is "collection")
Is that a typo?  And why do we need a try statement?
Yes.  There is no exit code checking when `wait=False` is given.  You cannot check if "editor exits immediately with an error"  unless you define how immediate immediate is.  You can add sleep right after subprocess.Popen and check if the process is finished and what is the error code.

But the try-catch in `magic_open` is not needed because `editor` will never raise the error.  Thanks, I didn't notice that.  I will remove the catch-clause if this PR is going to be accepted.
A comment should explain that for compatibility with IPython terminal, a BS at EOL is effectively ignored because it is treated as a change in print position rather than a backwards character deletion.
Not just for Python 3, I think - this is liable to break with non-ascii characters on Python 2 as well.  I think the best thing is to use `io.open(fname, 'w', encoding='utf-8')`.

Cython, like Python 3, assumes UTF-8 source code by default, so we don't need an encoding cookie: http://docs.cython.org/src/tutorial/strings.html#source-code-encoding
uhh.. did either of us write this ? :P
I think *"The total node count is collected in stats."* is a leftover. Could you clean it as well?
TestNg supports "expected exceptions":

```Java
@Test(expectedExceptions = IllegalArgumentException.class)
public void testWithEmptyList() { ... }
```
I don't know what this does. I don't have it in my configuration and I don't see any references to REDIS_TEST_BACKENDS. Why did you add this?
because the profile gets recreated
change `'description'` to `<description>` follow the syntax of the rest of the help.
out => our
Whitespace issue...  line up those ='s! :)
Why is all of this in here?
I still dont like this.
I think it is still accurate since *ts* is assumed to be in calendar time relative to number of seconds since the Epoch, and the `_local` function calls `localtime_r` to convert it to the user's local time zone.
I would need the location of the graph_templates, and I do not have it here. I think that in that moment it needed a mayor refactor... call me lazy.
good, I've changed the name to @stof proposal.
it is not deprecated. It is removed. (deprecated methods are still there and will only be removed in a later release)
This does not return a key
If someone passes "false/true" to the generate function, I would need to convert that in I18nRouter, no?
The name `hostnamePrefix` is now even worse because it's not the prefix of the hostname or something. Then lets rather stay with hostnamePattern. Anyway, as mentioned earlier, it's not good that the hostname is only set one some routes, whereas the defaults and requirements on all. This can lead to some unintentionel behavior, like when the requirement is overriden for a route, but the hostname not.
IMO it would be best to remove this param from this method and instead use the `setHostnamePattern` for it, which already does the same thing.
Upgrade it to `setHostnamePattern($pattern, $defaults, $requirements, $override = false)`.
With $override = true it will override the pattern, defaults and requirementone for sub-routes that already have a hostname pattern set. When its false, it will only set them on routes that have no hostname pattern yet.
don't see any reason how 'n/a' would be assigned here
then, why? because in both cases, you'll use the sorted array.
you cannot rely on that fact that $exceptionHandler is symfony's handler. It may be overwritten in AppKernel::init
Keep the interface simple. Just accept the full espg code (e.g. "espg4326") which we can capitalise if necessary.
This is how the installer understands https://github.com/composer/installers/blob/master/composer.json#L23
Is het altijd de schuld van de file?
Rename wr to workrestart if you want, but using thr_id is not any clearer and much less efficient.
can we combine these with using "\n" as the separator when its multi-line?
In fact, if the CMS never moves a plugin around in its tree, why should any of the tests? In which case, I don't see a need to make these tests do that.
I'm not sure if this does anything in my use :)
I was wrong! it works on JDK7 but not on 6 :(
ok, I'll amend the patch and use the context.
@selfthinker, I'm guessing you checked, how do these changes effect the toolbar demo in IE7. I literally just landed this so I want to be sure :-)
I think would be useful allowing custom css selectors instead based on [name=field]
Nit: please re-indent the whole HTML file.
// find out which alarm is being fired.
Remove this part. You don't need `SettingsListener` to sync `this.reservedSettings.data` if you are getting that when entering the flight mode.
Yeah, I guess we are talking of the same here. I mean, the USSD functions will be asynchronous but in case the timeout expires the front-end will be notified by means of an onerror invocation on the DOMRequest. Is this what you are proposing, @etiennesegonzac ? The point is who controls this timeout. @etiennesegonzac proposes the backend to control it (if not already been done, which I think it is not or the timeout is currently much bigger than 10 seconds :-) ) What do you think, @ferjm ?
Just a small suggestion: You could return  while if (MessageManager.lockActivity) at first for reducing the indentation.
For this block, could we sync the naming style,
`minangle` -> `minAngle`
`hourangle` -> `hourAngle`

Besides, maybe better to create a function for this:
```js
function setTransform(id, angle) {
    var hand = document.getElementById(id);
    // Set an SVG attribute on them to move them around the clock face
    hand.setAttribute('transform', 'rotate(' + angle + ',0,0)');
}


setTransform('secondhand', sec * 6);
setTransform('minhand', min * 6 - inverseAngle);
...
```
The file.type of mp3 format seems to be missing, and that's why I used filename extension to filter them. Ogg file is fine, though.
I cannot find a related bug so I note this issue first on comments.
(Desktop build is OK, this problem is on B2G devices)
Deja vú? refactor this common code into some helper method.
I think deciding whether we expose the error or not should be in another level, this only throws an exception, the caller should catch this if needed to hide the actual error.
This isn't the class I meant. (I know it's confusing). It's this one https://github.com/projectkudu/kudu/blob/master/Kudu.Core/Infrastructure/Executable.cs.
I think we're going to have some sort of criteria related page in the platform user guide that talks about it conceptually as well as how the command arguments work. When that's in place, we can link from here.
I've commented this in https://github.com/puppetlabs/hiera/pull/29
Why is the arity checking required? Obviously I could be missing something, but I didn't think that `Proc` instances getting extra arguments was problematic unless they were lambdas.
Should be able to get rid of the conditional:

```ruby
filter_run :full_description => Regexp.union(*Array(description).map {|d| Regexp.new(d) })
```

Works on MRI 1.8 and 1.9 :)
I think this could be expressed in a simpler fashion:

``` ruby
command = rspec_autotest.make_test_cmd(@files_to_test)
command.should include('"')
command.should_not include("'")
```

The regex seems more convoluted and doesn't actually verify that double quotes are included....which seems kinda important.
Why don't use the `distinct` method on `List`?  Wasn't there when this was originally written.
This method is an automatic converter for the MySQL tables. There is no reason whatsoever that previous MySQL installations should be allowed to remain on the old format. It doesn't store many flags on a server reload. This update code will automatically recover more flags than the current worldguard setup will even allow to be parsed on server reload, such as Double and Integer flags.
It can't recover ALL the flags, but it does NOT drop any flags that work under the current mysql setup, and it DOES recover more flags than would be present on a reload.
It leaves the old region_flag table in legacy_flag as a backup.
This is run AUTOMATICALLY if the code detects that the current region_flag table is NOT the new region_flag format.
why hide the output here? It's quite helpful if something is failing as you can replay the commands by hand (helped me to debug some stuff).
** Пожалуйста, ** - запятая
Send back a proper json error response and raise it as a ruby error here.
Looking at the code again, both mappings call `ragtagHtmlComplete`, but `<C-X>/` prepends "</" to it.

Anyway, I am leaving this up to you to document. Thanks.
I'm referring to the code starting at line 107 (and ending at 118). The code for selecting the Recording tab looks like it's at line 96-100. (GitHub shows all diff'ed code from your commits as highlighted. You need to look at the line number where comments start to see what the comments refer to.)
What do you mean by including those we haven't done ?
Here is the logic of getting GPS, if not test server and GSPenabled, return real location, otherwise, mock location is returned.
Yes, I forgot to update that. It should be applied on unformat method, but
the implementation would be,

amount = if @divisor isnt `undefined` then amount / @divisor.func() else amount
Nested ternaries. Nice. We're in the big leagues now.
yeah, I actually took it out on purpose, because it seemed like it might be faster to skip it. The logic was that the x check is done `nx` times, but the y check will be done `nx * ny` times... a lot of checking. And most of the time, the y check will be True anyway... we are usually passing array dimensions that are "tight" around the aperture.

It probably doesn't actually make much difference in performance either way though. I'll put it back for now.
Similarly, this will only ever be dealing with old-style `Change` objects.
same here regarding the return value: it should be ``null``
Why adding the localRepo here ? It will always be the same.
curious about the dropping of `case` objects
I Don't mind at all, Geoffrey.

Sorry for any hassle this pull request has caused :)

Also, I sent you and Mike an email about the unpublished changes to 5.3, it'd be great if you get a second to answer.

Cheers
Lee

----- Original Message -----
From: "Geoffrey De Smet" <notifications@github.com>
To: "droolsjbpm/guvnor" <guvnor@noreply.github.com>
Cc: "lcarlon" <lcarlon@redhat.com>
Sent: Tuesday, October 2, 2012 5:22:02 PM
Subject: Re: [guvnor] Update guvnor-docs/src/main/docbook/en-US/Part-Developer-Guide/Chapter-I... (#66)



In guvnor-docs/src/main/docbook/en-US/Part-Developer-Guide/Chapter-Integrating_Rules/REST-API.xml: > -
> -              <entry>PUT</entry>
> -
> -              <entry>application/json and application/xml</entry>
> -
> -              <entry>multipart/form-data</entry>
> -
> -              <entry>Updates the asset {assetName} in the {packageName}.</entry>
> -            </row>
> -          </tbody>
> -        </tgroup>
> -      </table>
> +         	<title>Accessing Rules by Package</title>
> +		<para>
> +			Use the URLs listed below to access rules assets by package. The 
> +			examples below assume a base URL of <link xlink:href="http://localhost:8080/drools-guvnor/rest/">http://localhost:8080/drools-guvnor/rest/</link>. 

Before 5.2, the community war used to be named "drools-guvnor.war". Since then, the are for example called "guvnor-distribution-wars-5.5.0.Beta1-jboss-as-7.0.war" (which should probably be renamed to "guvnor-5.5.0.Beta1-jboss-as-7.0.war"): 
https://repository.jboss.org/nexus/content/groups/public/org/drools/guvnor-distribution-wars/5.5.0.Beta1/ 

Anyhow, mind if we replace "drools-guvnor" with a docbook variable in all these url's so it can automatically fill in the correct version? 

— 
Reply to this email directly or view it on GitHub .
現在のビューの中にあるDOM要素を対象にする形で要素のルックアップをjQueryに委譲する。
もし可能な場合、この方法は全体に対するルックアップを行うよりも推奨される。
plz make this static
I only made some <li>s here because docs-jelix-org lists repos between other items (tutorials, API reference). So indeed, it would be logical to make the <ul> here but it would prevent us from using this zone for docs-jelix-org submenu. Or may be a zone is not what we need (just a method, using, events, ... ?)
I just kept the previous name, but I agreed it's confusing. Do you have any suggestion?
I'd add one more test here, checking that rp_logo cannot have a ```"``` in it, I think that's the only way to break out of the ```<img src="``` context.
I wonder if the truncate_revision method could be called ``node_to_revision`` or even just ``to_revision``?  When I saw truncate, I thought SQL truncate initially.  Just a thought.
This deletes first item of the history.
Do we want to delete the existing api key, or the created one?
I'm assuming you want to delete the created api key, and if this is correct you need to change the method to delete the last api key, since that is the created one.
A matcher with such a generic name, but that only compares a single, specific object type is pretty bad.  This should have a name that reflects what it really does.
please try to use `{ }` especially when the body is not trivial and there's an `else` (Crockford)
good unittest would also excercise this exception -- look for assert_raises among existing tests
Or simply if ($name === '') as suggested by ocramius ?
0x1018 calls the strncpy routine, which has a length limitation, i think you meant to call strcpy which is 0x1017
Sorry :(

Anything else I missed?
Ooh, I didn't know to test for that. I figured that in any other case, it would be redundant in setting the DefaultCursor or something (which would trigger the cursor change).

If the ActiveDocumentChanged event does not solve this problem, I think there's also the possibility of maybe the zoom not being updated in time or something. This seems possible because there are 2 differences: Document change and zoom change. It could potentially be caused by both in combination too. I'm only saying this in case the event doesn't work and I forget about this thought.
why did you remove .toString() ?
In fact we could have used `Ember.compare` :)
Missed it, my bad.

https://github.com/emberjs/ember.js/blob/3b60016c2b6b38646d954014d10f74fcfe1a3d54/packages/ember-runtime/lib/core.js#L100-110
I'd suggest just referencing this file from the public google code location rather than copying it here manually.
Two blank lines between classes on module level (PEP 008)
`.equals` will trigger reflection. Any reason to not use `=` here? `=` will trigger a call to `.equals` if the object does not implement `.equiv`
function declarations need not `;`
this doesn't look i18n related
so we now have a process _metadata and a parse_metadata?

I found it weird and counter intuitive: what the two are doing in relation t oeach other?

Otherwise, I would like to have comments in this piece of code to understand what it's doing. I see that we're having a special case for "summary", and I don't understand why, for instance.
OK, I'll try and clean this up...
isn't the latter TBB-version specific? if so, figure out the exact string using code (e.g. using os.listdir + regex) instead of hardcoding it
`korzystając z `
I agree, I just don't see that indenting the `{% for %}` line improves readability; it implies that the tag above it contains whatever the for loop outputs, which isn't the case.
You should also patch product_details to ensure that Firefox 13 is considered a current version.
So I couldn't find `urlparams` and will just use the `+ '#services'`  way
server "otw3.ao3.org", :web, :app
server "otw4.ao3.org", :app

As otw4 doesn't have a nginx or a squid instance.
Added, as per Naomi's comment in Coders on 2012-06-10 a link to the OTW backup form.
まぁよいでしょう
What if `tags == ' one,,  two , '`?
I don't think so, can you describe a test case for me to code out a little more explicitly?
Doesn't off do this?
We don't need it because it calculates automatically by plugin. See https://github.com/0x000000/OmniWindow/blob/master/jquery.omniwindow.js#L77
throw exception, bad aguments etc.
I think that fetch should be dependant on read and write to be more DRY
This is one of the changes we need to be sure we want to do. The `context.isDeltaContainingChangesEnabled()` method always returns `false'`, which means we always create a simple DocumentEditor (rather than an ObservableDocumentEditor that creates and records the operations). Even when we're using a version of Infinispan that correctly applies the Delta, we would use the DocumentEditor in local cache configurations. Since most of our tests are local caches, most of our tests would be without any Operations being recorded.

Note that I think this is acceptable now, because Infinispan 5.1.2 thru 5.1.8 do not correctly merge a Delta to an entry that's been evicted, which means we never can use the diff-based Delta and thus never need to use the ObservableDocumentEditor that constructs the diff-based Delta. But at some point, perhaps with Infinispan 5.2, we'll want to re-enable diff-based Deltas and this section of code will mean diff-based Deltas are only used in clustered cases.
what does 80 means?
This is totally fake, btw
oh damn, that's right :p I'll fix that
btw the `get_instance` method can be wirtten in just a few lines without many `if`-`elif`. should I?
I'd like to think it's possible to avoid `eval`. Could something like this work?

```coffeescript
[
  gets_card ["1A7gaf", null],
    error: null
    status: 302
,
  gets_card name: 'Not A Real Card',
    error: null
    status: 302
,
  ...
]
```
пользователь может не ожидать, что это так долго работает..
а может сделать это поэффективней? три вложенных цикла с отвратительными отступами и строками по 120 символов --- это отвратительно читать.
this can go away
Hah! I worried that the pull request might be too much at once, so I didn't really think about the code comment.
don't think this is used anymore.
Could you be more elaborate? I don't know how to fix this the way you want based on this comment.
see comment below about enumeration
The standardized properties (in the `openslide.*` namespace) use `lower-case-with-hyphens` naming.  The vendor properties don't seem to have a well-defined convention, but `lowercaseInitialLetter` doesn't seem to be used anywhere else.  I don't have a strong opinion about it, but for consistency you might want to use `lower-case-with-hyphens`.
This is probably true for all your widget renders. If stuff is static, just contruct the sub-widgets at the start.
Same as above--this code is just moved.