labofsahil/github-event-dataset-2012 huggingface dataset:
What about having a RemoteRouter-wrapper that handles the nodes-setting and wraps the original "local" router?
Or a "root-path-provider" that gets put into the Router?
We already discussed that option and decided it would be a terrible idea.
This is actually incorrect; the "virtual" keyword should not be here.
Shouldn't it be www.redminebacklogs.net ?
No it's not :-)

Fix was the #define REG_SIZE. The other thing is just a leftover that might come in useful one day.

On Feb 27, 2012, at 20:41, Ron Babich<reply@reply.github.com> wrote:

> Is this a typo?  Ditto for line 370 below...
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/lattice/quda/commit/834281d640fc7b6cdbb34ebd54adddba9c244966#commitcomment-1018232
Yeah, the change should be reverted. The Apc handler should point to the Apc class, the Array handler should point to Ephemeral.
Also FYI the old message still exists as well as this new one, so don't remove the old one please!
Hm, this is a valid point, but can't we use something in AS::Cache for this? Do we really need our own QueryParams module?
I am not sure if I understand you but there is not other function to get current players in game... or I am wrong :)
Yes, true. Noticed that myself after I did the commit and pushed. I didn't quite want to revert the commit from the repository because its some nasty thing.
I think we should be very careful to separate the grammar of the parser and our internal data structure. What this file is, is basically our internal representation.
哥们，有在IE,chrome,ff上测试过没啊， 我现在没订票，再加上没IE可以测试。
Never mind, found it: http://es5.github.com/#x12.2.1
Yeah, I figured that "npm test" works well and it's clean.  

Why everybody is just clicking "watching" on github? tower.js is cool!  
I am considering about using tower.js for my next project.
But since my node.js experience is too shallow. I am reading the tower.js source now.
I hope I can contribute to tower.js and make it more awesome.

Thanks for the hard work. I love tower.js!

BR,
Jai-gouk


BR
Jai-gouk Kim


■ Contacts  
    - http://jaigouk.com
    - Twitter @jaigouk
    - Skype jaigouk
    - Mobile  +82-10-9861-5849


On 2012년 3월 8일 Thursday at 오후 6:01, Lance Pollard wrote:

> nice, you already did it :)
>  
> ---  
> Reply to this email directly or view it on GitHub:
> https://github.com/jaigouk/tower/commit/d981744e8b6127f613929eeff0858ce630d672ee#commitcomment-1063824
>  
>
Sometimes invalid is a better default. What is this "default skill" and why should damage that has no explicit skill assigned use it?
Good evening, I was tempted to join: 

Shouldn't both versions actually perform at around roughly the same speed?
Personally I think the `!isEmpty()` version is just a little bit more concise and friendly to read.

http://www.docjar.com/html/api/java/util/ArrayList.java.html =>

```java
 /* 238 */       public boolean isEmpty() {
 /* 239 */       return size == 0;
 /* 240 */     }

```
which boils down to ! (size == 0), versus:

```java
  /*229*/       public int size() {
  /*230*/           return size;
  /*231*/       }
```
which boils down to (size > 0)
`assertFalse(empty($value['asdf']))` and same below.
This patch assumes IPv4. The whole project seems to use IPv4 but keep in mind this will probably have to change soon :)
What if it's a one sample test?
Please don't use tap() unless you are dealing with a single line, single statement call like:

```
obj.tap { do_something_with(obj) }
```

I had [proposed using this technique](http://blog.rubybestpractices.com/posts/gregory/011-tap-that-hash.html) via the RBP blog a while back, and it was met with great resistance due to the superficial level of indentation it causes and the fact that it forces the code reader to backtrack. That was enough to convince me :)
Why doesn't this work?

    # github tarballs, like v1.2.3
    %r[github.com/.*/(zip|tar)ball/v?((\d\.)+\d+)$].match to_s
    return $2 if $2

For:

    url "https://github.com/sam-github/libnet/tarball/libnet-1.1.4"
`import`s should be alphabetized
One more minor correction: Can you move the update call from the Engine class to the update function in RenderingManager, please? We try to keep the bloat in the Engine's framelistener to a minimum. OEngine::Render::OgreRenderer really belongs to the rendering subsystem (MWRender) anyway. It's created in the Engine class only, because OGRE is a bit picky about initialisation order and moving it to the RenderingManager entirely might be somewhat to highly non-trivial.
@dkubb my exact same thought when I added it
All you look at here is members of the object, but everywhere else in Kotlin extensions would be considered as well. 
Please, see the ControlStructureTypingVisitor.checkIterableConvention() and its usages.
this assumes there are no other classes on the html element which might not be the case. Can I suggest using classList, e.g.
`if(!html.classList.contains("view")) return;`
`html.classList.remove("view");`
I missed the fact that you create a new map
Reader и Writer это копипаст, необходимо их сделать одним классом, с выделением какой-то абстракции которую уже будут реализовывать конкретные реализации, сейчас это огромный копипаст!
И это тоже не порядок!
@wazy yes it works
This will always return undefined.
I’ve updated it! :)

@escoz You can remove a tag from git with `git tag -d v0.3` for your local clone and `git push origin :refs/tags/v0.3` for the remote (GitHub). If you do so, please update the spec as well, I’ve currently made it point to the ‘v0.3’ tag. Finally, how you call the tag exactly isn’t relevant to CocoaPods, only the `version` attribute.

@floere Sorry about that, you now have push access.
I believe this would conflict with `options.animationOptions.complete`, if set by the user.
the core is still referencing to 1.5.3
We could potentially wrap a reactor (stact) around this instead of doing polling: sample: https://github.com/haf/fs-zmq/blob/master/src/fszmq.extensions/Server.fs
Нету здесь dll под 64 бита. Кто-нибудь знает, как скомпилить dll под 64 бита без дельфи? @boxa, сделай длл, пожалуйста, а то прийдется ревертнуть это дело.
Ошибок нет, если берется чистая база, на которую заливаются запросы, но 2 раза подряд файл не накатится ни на одну базу.
Также имеют значение параметры конфига: если стоит '' преобразовывать в 0 для чисел, то зальется, но если значение по умолчанию для поля стоит 0, то 0 и должен быть.
Были запросы, в которых в поля вставлялись данные, превышающие размер поля, ошибки должны быть.
try one-by one.
No more crashes in SpellAuraHolders with this commit :P
@AlbertoMonteiro any comments ?
wrong. try again.
Ah, nice catch! I think, however, that the easiest way to fix this is to handle the case where the RHS is nil:

	if value.nil?
		@values.delete( attrtype.name.to_sym )
	else
		@values[ attrtype.name.to_sym ] = value
	end
Can you please remove the old README file, and rename README.txt to README?
I thought about it some more, and I think the only logical conclusion
is to keep Application living in ResourceT, and change ResponseSource
to live in (ResourceT IO). Do you disagree?
You appear to have not shared your build scheme
Same fix I recon, also got crash with it in headless: https://github.com/realXtend/naali/commit/042fc7728b57146e748730cf614a5eb268d9b258 Already went in in the fixed pull request, I guess this wont hurt either.
Uh, so bad typo.. Sorry, I don't know where this id came from, I meant 68080 ofcourse :)
Reviewed, looks good.
yes it is... - i'll check it with the infra team later on.
Question
 * What were the cases that were failing that lead you to this improvement? What works better as a result of this fix?

Comment
 * I started writing stats using the solve method as you use here. Its actually easy to generalize it to many variables. We're effectively doing this 
http://en.wikipedia.org/wiki/Random_variable#Functions_of_random_variables
 I then found that DiracDelta did most of this work but with a few flaws. I decided to use it rather than re-implement much of the code. At one point I started writing a newer, better Dirac integration function but stopped. If we chose to do the full solution using solve we may want to put this code inside deltaintegrate. DiracDeltas serve as a nice abstraction. 

Answers
 * Transformations on Intervals. This only works if f is monotonic. Consider abs(Interval(-1,1)). The code you have above gives the interval [1,1]. One could think about minimizing f over the interval however. This could be done by considering all relative minima of f over the interval. I.e. something like  min(solve(diff(f, x)))
 * Symbols valid on intervals. It agree that it would actually be nice if x carried the interval around with it. This is a substantial bit to add to the core though. You could bring it up on the listhost. People might have ideas on how it could be done or if there is some issue with it. I like this much more than the is_positive/is_bounded stuff. If the first bullet point worked then these bounds would make a powerful assumptions system. 
 * Adding a "real" keyword to solve wouldn't be hard. You should start an issue for this at code.google.com/p/sympy/issues . 
 * The simplest way of doing this is f = lambdify(*Density(expr)) ;    f(g)
Since this left nave based menu does not respect the menu 'priority' order and doesn't merge LBF and regular forms very well, I think it should be off by default.  You're opinion may vary. :-)
you beautiful man!
Will this work for paths longer than 1024 characters?
Wieso unterscheiden sich Versuch 1 und Versuch 2 im Ergebnis? Versuch 2 sieht aus, als würde es da eben nicht nach iso-8859-1 konvertiert (wegen %C3%9F für das "ß").
Und was soll "%25DF" in Versuch 1 sein?
Currently if no music-video is provided the background would just fall back to the normal video. Theme designers can not rely on users to have videos in their songs, so a normal video is still needed. Therefore I think the option should rely on the user's choice. What we could do is saving the last known option in the Config.xml to have the videos starting up straight if they were prior enabled.
We made a mistake, in release build we turned off the debug messages at all. Now we have only warnings for debug on users. I have another idea to add a command line argument "--debug". If the program is running with it, then qDebug func print messages.

In this line, we replace qWarning to qDebug.
In ordinary life, the user receives only the important warnings, but if he will need more information, he can start program as "razor-power  --debug", he can see what providers not found.
ge -> get
Who is the class-description?
hahaha it was pretty easy :) I'll make a commit but need to test the rest of diem. :)
Haven't tested it yet, the win vm I've got a setup is on another VM, which
is slightly painful. Will try today.

On Mon, Jan 9, 2012 at 11:33 PM, Mikko Koppanen <
reply@reply.github.com
> wrote:

> did it work?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ianbarber/php-svm/commit/f3147670a10dd6e6bf828c6009c62d9755e8b629#commitcomment-851452
>
I'm trying to bring the tvheadend configuration to a normalized form...
this is a simple converter script in python, to show a possible new structure of the configuration files.
I'm having issues with EPG and my setup with a multifrontend DVB-s adapter and one DVB-T adapter.
Trying to solve this, I understood that the problem lies in the data structure, and I'm currently implementing the reading of the new file structure...

What are you doing with tvheadend ?
This is also the wrong fix.  The deadline has to be set before each operation.  It's a very different operation than SetTimeout.
It's only needed to fix linker errors when building the tests.
Clang does not seem to support gcc's __thread specifier, which seems to by used by gtest.
The -pthread flag cflags enables in libc some subs.
In different modes it is useful that the same trigger does behave different, so make ``surround-paris-alist`` a local variable.

For example in markdown-mode it is useful for \` to surround with the default, while in emacs-lisp-mode the pair \` ' is useful and in rst-mode even \`\` \`\` makes sense.
we are adding an option to supply the key, I think we should add another json file, whcih has a server w/ keyName?

Server.getKeyName mark @Nullable and say this is only here when keyName is supplied and at least running version X, whatever X is
I did miss the "||", sorry about that. That change does however have a syntax error that I am about to submit a pull request for. It also causes the mobile version to appear on the iPad, which I'm ok with if everyone else is. I do think most users would prefer a full site on a tablet though.

Jay - My username is kborchers, thanks.
if .present? is truthy and makes more sense to me. :-)
is this enougth comment to this file?
Would it be possible to add a spec for this?  Otherwise I can't pull it until I have time to add a spec.
@forresty 注释掉是为了避免我不小心再执行一次造成数据错乱，而这个对于没数据库的新环境是有用的。
那我搞回来
oui je sais j'ai pas eut le temps de corriger ca :(
le lense aussi du coup est cass :( je fait la modif !!

2012/2/11 Fabien Castan <
reply@reply.github.com
>

> Ca a cass le plugin de pinning. Il manque p-e juste la meme modif que
> celle dans Resize, non ?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/tuttleofx/TuttleOFX/commit/782ddcd9fb9f37bb173c0a70ff2800c7b24c7437#commitcomment-956290
>



-- 
Marc-Antoine* *ARNAUD
Software Engineer

Mikros Image - Digital Post-Production for Video and Film
www.mikrosimage.eu
Did you test 2.0.2 or just 2.0.1 and 2.0.3?
This is a very good idea. :thumbsup:
Re testing fwk, this is what happens if you use AbstractMockingComponentTestCase. 

See also the comment in the implementation of AbstractMockingComponentTestCase:

        // Step 1: Register all components available
        // TODO: Remove this so that tests are executed faster. Need to offer a way to register components manually.
        this.loader.initialize(this.componentManager, getClass().getClassLoader());

However AbstractComponentTestCase will also load all components, so all abstract test methods would need to be modified and the way to register components changed...

In the meantime we need to find another solution
oh, there are a couple of patches in the wip-osd-encoding branch that add several last_* fields!
mage resistance correct work 80 resisit in 80 lvl
I wish we could merge this sometime.
Ok, while we are here - can you also help please to join & minify all js files from twitter bootstrap within play compilation?

Currently in Twitter's makefile there are 2 simple instructions for this:

```
cat js/bootstrap-transition.js js/bootstrap-alert.js js/bootstrap-button.js js/bootstrap-carousel.js js/bootstrap-collapse.js js/bootstrap-dropdown.js js/bootstrap-modal.js js/bootstrap-tooltip.js js/bootstrap-popover.js js/bootstrap-scrollspy.js js/bootstrap-tab.js js/bootstrap-typeahead.js > bootstrap/js/bootstrap.js

uglifyjs -nc bootstrap/js/bootstrap.js > bootstrap/js/bootstrap.min.js
```

Any way to reproduce it with Play framework & Google Closure Compiler?
hi @tmm1 - I started to "fix" this using [ideas from childprocess](https://github.com/jarib/childprocess/blob/master/lib/childprocess/jruby.rb#L19), for example...

    channel = ::JRuby.reference(obj).channel
    begin
      channel.getFDVal
    rescue NoMethodError
      fileno = channel.fd
    [...]

but then I realized a lot of tests were failing anyway in JRuby 1.6.6.

Are you and @rtomayko still interested in fixing this gem for JRuby?
Translate and escape this:

Now have shortcuts for htmlspecialchars (they are much easier to use):
attr($string) -- same as htmlspecialchars with ENT_QUOTES
text($string) -- same as htmlspecialchars with ENT_NOQUOTES

AND even gace shortcuts for when also translating the string:
xla($string) -- same as xl(attr($string))
xlt($string) -- same as xl(text($string))
After discussing with @cneves, this seems to be an acceptable change as it's internal and really only used by him anyway.
&amp; here!  :-p
Carsten-

I think it's critical to get the repository right for personal, community and maintenance reasons. 

Although I'm thrilled that 1.92 is now released, and people can now use Git to more easily add features, I'm dismayed that my entire history of contribution could be lost.  I've devoted all of my spare time for 10 months to the the project, totally re-writing the front-end, but a newcomer reading the Git history wouldn't see my name listed at all on GitHub after the garbage collection runs.  Instead, if people do "blame" on the code, it will look like EM was written by the most recent person do do a merge origin/dev  dev.  Losing the whole history of my contributions would be incredibly upsetting.

If we can't get the attributions right, other members of the community may feel the same way.  People may be less inclined to donate their time and code if there is no guarantee that their contributions will be remembered.

Lastly maintenance will be much harder if we don't get this right.  It will be hard for the community to collaborate if they can't use Git to figure out who is really authored and modified sections of code rather than who did the most recent merges.

So, yes, although it may be a bit of a pain to fix this, and the 10 people who forked LS would need to re-clone their repositories, I think it's critical to fix this.

Perhaps Dragooon can help.  I'm also expecting you could do a new fork and branchto manage the fix, and once it is right in a new branch, then merge or re-base it back into master (e.g. so that this fix doesn't have to slow down development of Yii)

/Tom
Yes. I'm running them normally before pushing.
I haven't tested yet, but I think I read the other trick you did was to only register one callback, which is going to get rid of my ERROR: Undefined
Also, the code for the BlockPlace event was throwing up errors while testing, and makes absolutely no sense. I have absolutely no idea what the code was supposed to do before, but didn't seem to be succeeding anyway. So I've gone and commented it out ^_^
ユーザ名（完全一致）と「送った or 受け取った」をクライテリアとする検索条件。
isn't this just going to crash the program since no exception handler >_>
We might want to add that that's just the CO2 from using the oil and the oil is "extra dirty" due to the way it's produced.
You need `");\n"`, because single-quoted strings don't parse escape sequences.
> That being said, it is the benefit of a VCS that nothing *has* to happen
> fast.

Well yes. The problem here: additional_plugins is not only a VCS, it is also the source of Spartacus..
Yes, Markdown is a major pain in the ass - I have to continually write stuff like (double underscores)some_define(double underscore) t get past the 'Markdown' typesetting.

Anyways, I can find only two places in the code right now where types.h is included:

/home/twin_aphex/local-repos/genesis-next/src/sound/eq.c:#include "types.h"
/home/twin_aphex/local-repos/genesis-next/src/shared.h:#include "types.h"

if I just include stdlib.h in m68kops.h - I get this if I try to make a Linux build:

cc -o src/m68k/m68kcpu.o -c src/m68k/m68kcpu.c -O3 -DNDEBUG -fPIC  -std=gnu99 -Isrc -Isrc/sound -Isrc/input_hw -Isrc/cart_hw -Isrc/cart_hw/svp -Isrc/m68k -Isrc/z80 -Isrc/ntsc -Iutils/zlib -Ilibsnes -DUSE_15BPP_RENDERING -DLSB_FIRST -DHAVE_ZLIB -D__LIBSNES__
In file included from /usr/include/stdlib.h:320:0,
                 from src/m68k/m68kops.h:4,
                 from src/m68k/m68kcpu.c:46:
/usr/include/sys/types.h:153:22: error: duplicate ‘unsigned’
/usr/include/sys/types.h:153:22: error: two or more data types in declaration specifiers

I think it would probably be prudent to rename types.h to something other than a system header file so that there can't be any possible conflicts - just as a safety measure.
source should be an enum and not a #define
Ну, например, мы кое-где используем. 
По скорости они, кстати сопоставимы, только в сокетной реализации pconnect не сделать.

Плюс, не стоит забывать, что pecl реализации есть прослойка, которая иногда меняет данные. Например, невалидные ключи pecl даже не будет отправлять, а длинные - сам обрежет и тебя никак не предупредит.
Je ne le lis pas encore car ça a l'air d'être compliqué et surtout un peu long ^^
Du coup je vais attendre a demain pour modifier qqchose de guyTest, je ne modifierai que les particles, en ajoutant la doc et voila...
actually no. #3433 is completely not related to what this commit is supposed to fix
thank you ill look into it
ok fixed on ff31ba956bf96cc1a858bc111c8eedc8e8e345d8
For bm directory, I'll try it today. I think the krypt-core related resources is better fit for krypt-core repo, and make krypt-core-jruby just refer it at this moment. krypt -> krypt-core -> {krypt-core-c,krypt-core-java} is what's their ideal hierarchy, and you decided to call krypt-core + krypt-core-c as 'krypt-core', I thought.
Sorry. Just pushed a fix for that.
I'm sure you didn't mean this. 
Pull request #1
Doesn't the OrderedHash have some way to get the last key? I don't think we should be sorting at all, since we don't really know how...
merge all these hide commands
e.g. $('#history,#searchresults').hide()
for readability
Ye, still looks ugly...
@credomane https://github.com/blog/967-github-secrets
Nice! I could also use this lib in another project I've been working on.
Committed to master g-s-d with the error handling fixed, guards added to the function, and leaks fixed.
Hi Seamus, Thanks for looping me in!   This looks fine.   Think it means my remote_table usage rescue block needs to handle:
Errno::ENOENT, RuntimeError and ArgumentError.  All good.

~K
Why? Any issues with stdlib's JSON?
well i think there is no need to commit a patch.
Just pull the changes in the  TooTallNate´s branch or in my own one.

That would really make further merging a lot easier too!

I would not have merged this if i wouldn't consider the commits as useful. 

So keep up your work :)

ps: I am 50% done with WSS. But i could not work on it the last weeks because i think that the overall compatibility was more important.
Also this :3
В старых версиях Оперы, ассоциативный массив мог содержать мусорныя объекты, известный баг.
Is this true? We *always* reupload after we process commands, so the only reason to track that time is to make sure we don't re-execute the same commands, which is a totally different kind of tracking, right?
Firefox 9

http://iichan.ru/b/arch/res/133325.html
http://dobrochan.ru/b/index.xhtml
http://www.ponychan.net/chan/pony/
http://2--ch.ru/b/0.memhtml
TypeError: a is null
Yes I did, because I want it easy to get build :D
Note to self: make galaxyr_defconfig
This line shouldn't be removed in this commit. It is re-added in this commit: c53c1af0321e6aaa72e897a9d9ab3d77ad842122
Might be worth adding a "|nothing" to the end of this content replacement in case of custom content types without descriptions.
error: error reading /root/.m2/repository/org/bukkit/bukkit/1.1-R3-SNAPSHOT/bukkit-1.1-R3-SNAPSHOT.jar; error in opening zip file
With extended logging added in other commit.
java.lang.AssertionError: cpuDetails.size= 4 != sockets: 2 * coresPerSocket: 2 * threadsPerCore: 2
	at vanilla.java.affinity.impl.VanillaCpuLayout.<init>(VanillaCpuLayout.java:50)
	at vanilla.java.affinity.impl.VanillaCpuLayout.fromCpuInfo(VanillaCpuLayout.java:123)
	at vanilla.java.affinity.impl.VanillaCpuLayoutTest.testFromCpuInfoOthers(VanillaCpuLayoutTest.java:70)
You can do this

```
try:
    import tinyurl
except ImportError:
    pass
```

here, and later on where you use tinyurl

```
try:
   blabla
   url=tinyurl.create_one(message.body[1])
    blablabla
except NameError:
    pass a e3.Message.TYPE_INFO message through gui_message that tells you to install tinyurl
```
I like the way you ping each repository before releasing to any of them.  I think that's a pretty good reason for supporting multiple repos, rather than using multiple plugins in the dist.ini (as I had suggested).
you are the king of commit messages ;-)

https://github.com/torvalds/subsurface/blob/master/README#L161
Creo que lo de Linkedin no va a funcionar bien así... por ejemplo mi perfil es http://es.linkedin.com/pub/ricard-clau/1/7a0/744 y en cambio el tuyo es http://es.linkedin.com/in/adanlobato. No sé a qué es debido pero es así. Por tanto, creo que deberíamos configurar en el array todo el querystring, no crees?
OK, buckwheat
This is nitpicking, but in my opinion, there is little reason for commit messages to be in the past tense. It's shorter and just as clear to use present tense (second person).
This looks really interesting, would love to try the example app out. Currently I am working on a community news site and the related content filtering is not always optimal. This looks like it has some very complete filtering abilities.

But, I had some issues getting the example to work.
I was trying to install it, but after installing tagging and completion, then I got an error about basic.places.
Would it be possible to add a requirements.txt to the example app too? 

Thanks!
He is, just don't have the date locked in.
On Jan 17, 2012 8:39 AM, "Clint" <
reply@reply.github.com>
wrote:

> No mention of Scott and WordPress, is he still on board to present at
> another meeting?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/CoMoRichWebGroup/Announcements-January2012/commit/16f92421f800e4c2d61f4ec3659e7c78e44cac1a#commitcomment-874438
>
ok, this is picky, but maybe "--build-wheel" instead?  otherwise, people might not realize that this feature actually builds the wheels from source dist (which is cool) *then* caches them.
One other question that I had was about this prompt thing... Is it really necessary for any other reason?
Damnit—silly typo. Even sillier that I made it twice (in the commit message too) :cry: Sorry bout that!
Agreed. @ghinch, I'm in the process of merging this in now, so I'll go ahead and fix this. Thanks for the patch!
Stick with the global context, imho. There are a few other random places in the lib that use Y as a default context, but I find this confusing and would prefer to stamp them out.
I'm fine changing it to global.

The current signature, again based on jq, accepts n args, all treated as callbacks (or promises or result values), so there's no room for a config object unless the signature is changed.

[Promises/B](http://wiki.commonjs.org/wiki/Promises/B) defines a signature for when() as `when(value, callback, errback)`, which handles only one promise, so more closely resembles [Promises/A](http://wiki.commonjs.org/wiki/Promises/A) `promise.then(callback, errback)`.

If I were to alter the signature for when(), I'd be more inclined to change it to `Y.when( <array of callbacks, etc> [, callback [, errback]])`.  The array of callbacks/promises would be wrapped in a tracking deferred as the current implementation is.  If no callback or errback is passed, the wrapping deferred's promise would be returned.  If either _were_ included, it would internally call `wrapperPromise.then(callback, errback)` and return the resulting promise from that then() chain.
With the removal of shared singleton cache managers, there's no need to fork tests into a new VM every time. The cache itself would be prototyped for each test execution.
Please put the same warnings/explanations/rationale as on the trait, people might overlook them.
`private[testkit] def roles`
Yep, reminder of a refactor. Thanks!
a comment as to why 90 is chosen
So this field is here to guarantee that two remote actor refs using different transports but points to the same actor on the other end will compare equals? What happens when actorFor is used with different schemes?
Right, I'll leave the callback only for specialized access to the channel, but will make the messaging part more explicit, by just sending the Message to the channel actor.
60 seconds is very long, why?
I prefer that you use `within`
It can be used at the top `taggedAs LongRunningTest in within(20 seconds) {` or further down

    within(20 seconds) {
      awaitCond(clusterView.members.filter(_.status == MemberStatus.Up).size == roles.size)
      awaitCond(clusterView.clusterMetrics.size == roles.size)
    }
It was "moved" to sbt site plugin. I still think it is rather urgent, or are we going to hardcode the artifactId for pom.xml instructions (or don't we have any of those?
https://www.assembla.com/spaces/akka/tickets/2461
https://www.assembla.com/spaces/akka/tickets/2431

Here you don't need it, and not the parsed-literal either.
2.1-SNAPSHOT is replaced by the release script, so that is another thing.
Yes, it's passing :/ Dunno why, normally, thoses are wrong:
```
NO: self._index%len
OK: self._index % len
NO: len(self.slides)-1
OK: len(self.slides) - 1

Missing one empty line between next_slide and the previous function.. etc.
Why it's not working O_o
You can pass a tag name into iterparse(), which then behaves essentially like .iter(tag), but during parsing. So it's affected as well.
I don't know if this is in response to https://github.com/nipy/dipy/issues/92 but that warning is being caused by line 985.

I don't think we should catch the warning here because the denominator cannot be zero.
That sucks but I think we are stuck with it.

Maybe change the comment to something like your last comment here as the # FIXME: feels more like # MOAN:  ;p
Ah yes, I think that made it's way in after a confusing merge. I'll  remove it.
Oh wow, this is awesome. Really elegant way of handling finding matching or all without a lot of complication.
Same here. See comment above.
"This guide covers the generic, core features of the Pulp Platform." Feels a bit out of place. Consider adding something short like "... core features for managing repositories in the Pulp Platform". I know it's under the repo section, and perhaps this is simply because I'm reading it with a critical eye instead of as a user, but this line felt unscoped.
This stuff is clearly something that should be generated by @jimfcarroll code generation stuff at some point in the future.
shouldn't it be "m_subtitleLanguage.clear();"?
Isn't this just:

```python
if conf_path is False:
    return None
elif conf_path is None:
    return find_mrjob_conf()
else:
    return conf_path
```
It's a lot simpler to keep the testing moduless from being installed if they're not in `mrjob/` to begin with.
Be careful that the table name is not enough to identify it. You need the "fully qualified name": <datasource>.<table>
add "in a single transaction".
Next question, "using the first found" is risky for an undocumented search algorithm, we can never change the algorithm without breaking backwards compatibility :-(

I would prefer something like an exhaustive search of possibilities, and combine them. Raising an exception if anything collides. By explicitly using *all* annotations which can apply in a particular case, we have a known algorithm, and will create fewer hard to track down bugs (why wasn't this annotation applied? oh ithis other method was used, ugh -- I can see taking someone way too long to track down).
Shouldn't matter - `sender_ = sender` should be right above it.
Extra indent in here :)
Closing over this
As I mentioned before, It would be a fairly large overhead to convert to and from a `CTLineRef` to truncate it.
Thanks Ben.
Just corrected the splitted line to one line.

You can LGTM the 2 commits in this pull request.

Cheers,

-- Mike


On Wed, Mar 28, 2012 at 07:54, Ben Noordhuis <
reply@reply.github.com
> wrote:

> > @@ -446,6 +456,8 @@ class TypedArray {
> >
> >  class Int8Array : public TypedArray<1, v8::kExternalByteArray> { };
> >  class Uint8Array : public TypedArray<1, v8::kExternalUnsignedByteArray>
> { };
> > +class Uint8ClampedArray : public TypedArray<1,
> > +v8::kExternalPixelArray> { };
>
> This fits on one line.
>
> Otherwise LGTM.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/joyent/node/pull/3021/files#r615392
>
Very minor issue but argv[] (no explicit length) > argv[1] here.
ici tu as déclarer une mixin ou tu en utilise une?
Yes you're right !
I change it again. 

Should I make a new pull request ?
Force outputtype here == 'AFNI_1D'
MapIterBind currently has a void return type, which is why the next line checks for a iter->ait NULL value as a cheap workaround. I'm going to remove this call to MapIterBind though, so it's irrelevant now.
A much better fix has been included...
Give me an actual example of someone directly embedding phpinfo() into a page and maybe I'll agree with you.
This is perfect idea! Thanks :+1:
Ok, now I looked the entire method, thanks.
I mean this kind of code:

```ruby
module Delegation
  mattr_accessor :delegated_to_scoped_klass
  self.delegated_to_scoped_klass = [].extend(Mutex_m)
```

Synchronization will be performed rarely enough and takes way less time than `eval` in `delegate_to_scoped_klass`.
Can we make the default be the empty regexp `//`. It will be faster.
Why this special case? There's no guarantee that fixture_table_names is all strings
good point. i'll change that.
may not what?
paulp says: all Unit-returning methods which aren't println/logging are bugs.
Sometimes all you need is a good name. I like this one.
We could probably go either route here successfully.
Put the notify in a finally block?
I think `_pade5` is duplicated here
n1.Logic is appreciated :)
You mean that `n` and `n_digits` have to be numeric? Well, yes. I doubt there will be any need for symbolic versions of these. The `n_digits` is pretty much the same as in `.evalf(n_digits)` which is also just numeric.
I really do not understand what is the use of this decorator.
Two things:

* The creation of the symbol is out of the control of the test writer, and opaque to readers.
* You get tests that depend on a global state, and can thus influence each other in unpredictable ways.

Looking at abc.py, I see that the "arbitrary magic" isn't as bad as I thought, since it's only an exec statement (but still, you can't know that just by looking at the import statement).
Agreed.  I think that might be a mis-type on my part, because I think
Tip instantiates a Loader vs. extending it.  I'll double-check.

-Jim G


On Fri, Apr 6, 2012 at 1:21 PM, Robert Martone
<reply@reply.github.com>
wrote:
>> @@ -2,23 +2,25 @@
>>   * Tooltip class
>>   * @class Tip
>>   * @constructor
>> - * @extends Abstract
>> + * @extends Loader
>
> I am not sure I like this extending Loader. Tip is not a type of loader. Tip should manage Loader, if a url was specified. We are going to run into the extend v. other patterns a lot. Let's come up with some loose guidelines.
>
> I'll spend some time with Tip in our upcoming milestone.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Iheartweb/Lu/pull/69/files#r656601



-- 
jimg at yojimg dot net
No, @stof. The code is correct. `getController` checks the object cases first and then returns early. `createController` only handles the case of translating from a non-function-name string to a callable, which is exactly what is happening here. Applies to your incorrect comments below as well.
What are those comments, please remove.
ob_end_clean() call ob_clean() directly
License header .....
hmm, i suspect that if value doesn't find anything, it returns None by default. so you don't need to check `if value == None` just check `if value`

the default will always return None.
Ça doit foutre le bordel dans le style de Bootstrap ça. En faisant, ça tu imposes à tout les `div` de classe `row` (qui devrait être `row-fluid`) une marge à gauche de 0. Tu devrais plutôt ajouter une classe spécifique qui fait exactement ce que tu veux.
Missing @return documentation - you might also want to add @return null to functions without return value.
They are not autoloaded, removing these lines results in a fatal error.
Yeah I noticed that when I went back to change the count() to sizeof(). It has been fixed now.
im not sure about the "override" here, you can not only override it...
Please put a comma after "see". Without it, I had to read the sentence 4 times before I got what you are saying. Or you can just remove the "he can see", but a comma should still be put after the word right before "the number".
(19:22:58) nx-: that file had an a9 which is i'm assuming iso-8859-1 but not utf-8
(19:24:25) nx-: c2 a9 is valid utf-8
(19:24:31) nx-: github must be misrendering it
(19:24:56) nx-: it renders the new version correctly
(19:25:16) nx-: obviously it is impossible to render 8859-1 and utf8 mix correctly
(19:25:49) nx-: i would suggest going through all existing files grepping for a9 not preceded by c2
(19:25:51) nx-: and fixing them
So in that case, just change "title" to "subject" in the language part, and then do igorw's request below and I think this is about ready to merge.
sentence is formatted wrong:
`Only users with f_read_other and the topic starter can view the topic.`
"Do not use trailing commas." sounds better to me than "You must not use trailing commas." But either will work, I suppose.
I might be missing something but it looks like return value of acquire never influences execution path above. If acquire() does not block, what is the point of using a lock?
This is not a good idea. The id refers to the full editor. While it might be a good idea to add an id here, it should not be the same as for the full editor.
It's for IE :D 

This thing supports interactive SVG only in xhtml
Yeah - it's one area of Google style that always bugs me - three lines to do what feels like one line.  I'm not even a fan of the curlies here.  But I'll revert to google style.
Sure.

All I'm trying to say is that, if all marks/timelines for a request are separate from other requests, then there is no such thing as a "collision".  I should be able to do the following in my code, without warnings:
```javascript
for (...) {
    ...code...
    Y.mojito.perf.mark('libfoo', 'got here');
    ...code...

}
```
If we're going to keep this file it'd be nice to comment the various functions in it. Many are uncommented.
the strip here is unnecessary
Hmm did you miss the "of course you'll have to add in the generic stuff as well" ? You had some code before that checked the generic argumetn type of generic types. My code does not cover that. Not covered by a test?
Watch out for this one - it'll need converting from km to m.
similar comment for the indices and indprt field.
Неее, ну это даже как-то грустно видеть... :(((

Вы копи-пастите процедуру в 25 строк в процедуру в 40 строк, это никуда не годится.

необходимо объединить все в одну процедуру с параметром "исправлять или нет".

 иначе никак.
and please move it to the bob
Different hostnames. It always manifested as a generic inability to find/connect-to a node in some later operation. I forgot to note that the last time we monkeyed with this was back in the R13 days, so it's even possible that this is no longer an issue.
link to "Running tests" in topics/testing/overview?
Fair call - I'll factor this out into a manager method.
white space before the header value is optional, if present it may be more than one
The previous version was installed from geonode bundle too.

We can add an echo that explains the upgrade anyway.
Wrong style. Please read the [jQuery Core Style Guidelines](http://docs.jquery.com/JQuery_Core_Style_Guidelines).

Correct:
`if ( rnotwhite.test("\xA0") ) {`

Also applies to the other if statements.
Ensures that the Gecko-specific method is always defined of time so QUnit doesn't bitch about it being "created" when running in Firefox etc.
`function(jqXHR, textStatus)` => `function( jqXHR, textStatus )`
Yes, this should point to MADLIB-499 and subtasks.
Just fix this annoyance and it can be merged
Yeah seems like a new method on server designed for this would be ideal.
I've seen various formula where binaries are executed by their names alone and assumed to be findable by PATH.
Check your indentation here. ;)
We define present? on Object in core_ext - use that instead.

    if arg_switches.present?
Yep right! thanks :)
Can you put that in a comment?
Is it actually an error if SQLite doesn't switch? It'll be slower, sure, but shouldn't we continue if possible?
Probably. I need to do a pass over the docstrings and such once the code has stabilised. (Which has happened already, I think.)
This isn't really a pypy issue, but I kept hitting it while working on this branch so I just fixed it here. If you kill the tests before everything gets cleaned up, this test finds multiple stored items instead of the single stored item it expects.
Save had this when I started and I wanted to preserve peoples docstring if possible. Plus I wanted to make unsave match save. Iĺl change it to

Unsave the object.

And do the same for Save.
Ya I saw at a couple of places, like in repo delete, we were going and deleting all distributors with that repo id and then it result in an error if it can't find a particular type if for that distributor, so just to avoid those kind of situations just in case.
Remove commented lines, fix spaces and add JSDoc.
Can we open an issue for that?  I can go through all of the repos and make sure they're defaulting verify to true.
dagger-compiler?
I wouldn't do that - the group of the name of the user may not be existing. If required, get he users group in an explorer before and use it or remove this code block.
Remove the trailing whitespace here - this does not belong into this patch.
Pull this out into a top level (not inner) class and make it public, so users can use this if implementing their own DirectoryListingFormatter.
In production of release versions we should deploy to maven central
https://oss.sonatype.org/service/local/staging/deploy/maven2/

but for testing purposes temporarily to
https://oss.sonatype.org/content/repositories/snapshots/

My plan here is to deploy withou gpg signatures.
Normally we should encrypt the artifact which are above to deploy using gpg-maven-plugin .
I did this for my FTP server and it works pretty well.
Avoiding gpg-maven-plugin would save the size of this xml been more readable for others.
So i would like to test the mavenization in snapshots repository.

that's the reason why now 
https://oss.sonatype.org/content/repositories/snapshots/

did i answer your question?
Sweet. Man, CoffeeScript sure is sensible.
How do we move the banner in Android, then? (If, say, we want to scroll it up or down based on the UI hiding/showing?)
General comment: a bunch of APIs used below have been moved to Document, so when you merge with master you'll need to change: editor.getLineText() -> document.getLineText()
cm.operation() -> document.batchOperation()
cm.replaceRange() -> document.replaceRange()
I did a separate one because it was a new require. I can move it.
Yup, I think I'll use the behavior from #2142 once that's merged.
I don't think "Rename..." should have ellipses, since it uses inline editing (i.e. it does not invoke a modal dialog).
This is probably one of those style/preference things, but to me it feels weird that "All" is inserted as a string key above, but written like an identifier here.  I'd prefer to write this as ```_topLevelSuiteMap["All"]``` to avoid mixing the two styles.  (Also, if we ever use Closure we can't safely mix the two).
Only do this once, not for every mousemove.
selectedItem may be null. Does this need to be validated?
Anyway, `enable`, `disable` and `destroy` has a trivial implementation
bad merge (likely my fault).  we want leveldb::NewBloomFilterPolicy2
Please change `c` to something more description, like `dir`.
{{ block.super }}
As a style thing, in python it really makes a lot of sense to end every line in a comma (rather than begin all but the first with one) because a trailing comma in a list/tuple/dict literal is legit. It's nice because it makes adding/removing new things to a multi-line list/tuple/dict literal easy have a really clean diff.
Can you break out date/time-validation into it's own reusable functions so that it's clearer what the function is logically doing?
I don't do static imports.
So far, I have not yet worried about function overloading. My plan is to not support generic C++ UDFs, i.e., C++ user code should not query AnyType objects for the type it represents. I do eventually want to allow UDFs that are template functions, but they would be called (and instantiated) by platform-specific code (that possibly would be generated from a specification). In other words, I currently do not plan to have dynamic type resolution in C++ user code, but only static type resolution.

Whether a SQL function like "norm2" will later call a PostgreSQL-specific function "norm2" which then calls the appropriate C++ function (say, norm2_dense and norm2_sparse), or whether the overloaded SQL functions call  norm2_dense or norm2_sparse directly, I have not decided yet.
nit-pick: alphabetize :)
Same, use HMapIV?
*text* -> *comment*?
That's bad practice, since it needs to be one of block, inline, none, etc.
Needs some spacing fixed between the () brackets.
Again, we don't need this prefix right?
Fix the spacing here
Why should it be -5%?

I just picked a fairly random number that looked decent. You?
You should mention what each of these are, you only really deal with one of them.
204 - No content
Don't use exceptions as a way to verify if script is valid UTF8 string (e.g. regular expressions can be used `/^([\x00-\x7F]|[\xC0-0xDF][0x80-0xBF]|...`)
Is either `$options['vhost']` or `$options['host']`required? Otherwise you should probably check if `$options['host']` is set.
Similar thing applies in other places.
this seems unrelated?
One of the points of litmus is to consolidate the dependencies and version management for junit/hamcrest/etc.... so that projects simply have to depend on litmus to get the right version of everything.
Yeah, settings documentation. I wanted to get started on these for a while. :-)
I was figuring I'd bootstrap and then hit some point where I'd do a localization pass and set up a translations workflow. It's good to see you adding those pieces now, though.
Sweet! Changed version uploaded.
Correct, I'll add parenthesis
https://fedorahosted.org/katello/wiki/RubyCodeConventions
Honestly, I just couldn't find a good semantic name to represent this color scheme and it was the only place it was used.  I suppose I could name it....   

`$collapse_button_background-color;`
Um what?
use document.location.host instread of hardcoding gaiamobile.org.
I'm a bit hesitant here. I wonder if we need to let the exception propagate. I guess in practice this could be helpful.
I did a quick test, and it looks to me like the creation time on this object is non-trivial, so it might make sense to cache this. I've issues a PR to @mdboom's branch to fix this (mdboom/astropy#7)
I think it would be clearer to define local variables

```Om, Ode, Ok, w0, wa = self.Om, self.Ode, self.Ok, self.s0, self.wa```

At the beginning of this function. It would make the subsequent equations more readable and shouldn't add too much overhead.
These should all be astropy-syle `ConfigurationItem` objects once this is more finalized
I do like the idea of suppressing messages about the sysmon itself. I wrote it that way at first, but then went back and changed it, but if you agree, I'll reinstate that behavior.
That's not on purpose, I obviously didn't run dialyzer on this.
Yes, static builds are being used. And libdl is not only linux. I'm on a
solaris system right now that has it.
I think every progress here is a good thing. Perhaps luke can merge your changes. Have you setup Git on your machine yet?
Typo: it instead of ir
Looks like some bonus whitespace here.
No reason other than that this is how its done in other places in the code and I was just being consistent.
thats not a fix. that breaks it for good :) the if case will never return true now.
Just the methods or the variables too? (private static readonly string _contentFormat = blah vs private static readonly String _contentFormat = blah)
I would name it ``static`` instead of ``parser``. And you should rename the ``$psr0Parser`` variable
They actually may need newlines in the string itself as well, so it fits in a console window.
This section is actually largely specific to the CLI, so probably belongs there.  The deploy.json documentation makes sense here though.