labofsahil/github-event-dataset-2012 huggingface dataset:
I guess I meant something like:

```
    @classmethod
    def load_results(cls):
        with open(os.path.join(basedir, 'lastresults.pkl'), 'rb') as f:
            obj = pickle.load(f)
        obj.__class__ = cls
```
I concur with @minrk here, especially because eventually we may completely remove the py3compat module alltogether, whereas getdefaultencoding is something we're likely to want to have in general.  So it should go into its own module, and if py3compat needs it, then it can import it from its own location.  Otherwise when the day comes to remove py3compat, we'll have to disentangle bits and pieces of it and hunt imports of it all over the place.

Sorry from my side as well for coming to this after such a long time, things have just been insane.

The overall PR looks really good, so with this small fix (and my other comment about a docstring), this should be good for merge in short order.  @gbrandonp, let us know if you need a hand with any of it, and thanks much for the contribution!
responses.clear
in looking at properties.. I think that rather than have a set of setting property for each thing in AdminAccess, make something like TemplateBuilderSpec or CacheBuilderSpec called AdminAccessSpec.  Use this instead of POOL_NODE_USER, POOL_NODE_PASSWORD.  probably the replacement would be POOL_ADMIN_ACCESS with a value like adminUsername=nodepool,adminPassword=fubar,adminHome=/var/nodepool
Unfortunately correct.  I may need to add some extra layers for writing files back if that is necessary.
If there is a better alternative please advise.
Let me explain how this works because the pieces are all over this file.

What this does is require a ``transdoc`` to have at least one revision that hasn't been reviewed and rejected. If it has no such revisions, then we still get a row, but the transdoc portion will be null.

This gets used in ``MostVisitedTranslations`` and causes the sql data for ``transdoc.title`` and ``transdoc.slug`` to be None. That causes ``_format_row_with_out_of_dateness`` to go through the ``else:`` clause since the ``slug`` argument is None. And that yields the coveted "Yo! I'm untranslated!" gold star. Yay!
i should sort model instead
A very minor naming thing: "update" is usually a POST action that modifies data.  Could you rename the action to something like "stats" or ???
Only because that's where we've been putting the return data, so I thought
this was more consistent. You could move it into the error object though if
you think that makes more sense.

On Thu, Oct 25, 2012 at 3:03 PM, felix <notifications@github.com> wrote:

> In lib/tools/index.js:
>
> >            }
> >            try{
> >              data = JSON.parse(data);
> >            }catch(e){
> > -            console.log(data);
> > -            callback({
> > +            return callback({
> >                error: 500,
> >                msg: "Bad response from server. Check response data"
> >              }, data);
>
> Ah, that's interesting. Fine to leave it as is. But why not add it into
> the error object?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ordrin/api-node/pull/5/files#r1945142>.
>
>



-- 
Jason Teplitz
I'm just defining the current function. If you think we should change it, well in all honesty I agree.
no need to use ``else`` here
you should simply use ``if`` as the previous ``if`` returns
this is here for debugging, not for production... removed
It's a bit strange to have getPropertyMetadata() in the PropertyMetadataInterface - mostly you won't need it there. So I'd have expected a general MetadataInterface containing nothing about containing properties, then maybe have a simple PropertyContainerMetadataInterface or so that adds the method?
Extreme optimization, I'll remove it as most likely it won't be a problem given the amount of variables we expect to have in this array.
Please remove this (you should fix the DBAL phpdoc instead)
This is not used anywhere. And `meta` property doesn't even exist.
any reason to not use a case class?
I feel like my two pervious comments might be too brief. Let me elaborate to make sure there is no miscommunication. The method being tested 'find_user_by_email_or_create_guest' calls a method that includes the line above 'User.find_by_email(email) || Guest.find_by_email(email)'. If we add the assert you suggested it would always fail. And to add the inverse wouldn't make sense, because we don't care if User.find_by_email got called. The order of the calls is irrelevant. So for the sake of ensuring the correct query gets run this test is adequate.
Realizing this was part of the story. Please ignore.
Ah fair enough then, I think I missed a beat on the error handling stuff.
I'd use:
```python
same_projection = (isinstance(transform, ccrs.Projection) and
                   self.projection == transform)
```
> better to just fake the server in the first place.

I agree. One word of warning: It is worth remembering that it takes an awful lot of effort to mock a complex service, and without the full complexity you cannot be certain that the mock is fully representative of what you are mocking. 

That is not to say that I think we should implement a complex mock WMS service, but I do think it is probably worth *actually* testing a WMS service as a complimentary test which fails as a KnownError if the server is not available.
No, but it is preferable so that should I change the axes projection, the image still "works".
Yeah you are right, I shall remove some of those. Had to split the materials up sometimes to find certain 'TODO' area's back.
will look into it.   in the mean time, what do you think the right thing to do is?  Default to something like the user's homedir? require an absolute path?
I can do that, updating and redeploying
En fait l'email on l'a déjà, c'est le login :-)
Here we probably need a more orderly shutdown. What is the contract of StandaloneServer.stop() ?
consistent naming - should be: bundle-d.wab
I thought about this for a while before doing it and decided I shouldn't have it set the value incorrectly before then setting it correctly. Also, setting it twice seemed silly but I also understand not duplicating the base logic. I will update ASAP.
You need to release the lock in the else close.
`nameElement.textContent`. Doing so then you don't need to `escapeHTML()`
I think the event listener should be on the button rather than the list element, which it will be if you remove the list elements altogether I guess.
debug logs removed on new commits ;)
(LOL)
Thank you for remembering implementing async loop
you need `var self = this;` above line 44
Why does it happens? stopPropagation prevents the event to be dispatched further but if you have an event listener at the same level it will still receive the event which is the expected behavior.
space vs. empty string argument to join().  Intentional?
Nit: can you indent the "case" blocks?
Object.getOwnPropertyNames! Sounds like you will be an hipster soon :)

Why not Object.keys here to stay consistent? (and to not break the 80 columns rule - i will launch bot.io to verify this assertion!)
ok perfect although i like adding comments but you are right
Should this read `The PIN code was incorrect`?  Or `PIN code was incorrect`? `Incorrect PIN`?
We need to use a method which update headers when needed, but as anonymous function? I've commented for talking with you about if is necessary to change this method to other part, or create in other way...
if I assign the value only inside the for, it may exit it without value, hence, an error.
Remove this check. You've already did this in L219
I corrected the typo, and modified "views-sublist-header-default-image" to "views-sublist-header-default"
Did you mean to leave this in? Also, $self->log->debug is useful here.
No, takhle jsem to udělal hlavně proto, že když píšeš sám vlastní testy, tak se nemusíš prohlížet kód samotnýho testování, ale stačí ti dokumentace k T, Tn a test a vše by mělo být jasný.
typo: 'pointing'
Ya. I should have added a bit of an explanation here. I totally agree with your comment. The only reason we are doing that right now is because apache conf files get loaded alphabetically and for some reason, apache doesn't like pulp_puppet being loaded before pulp_rpm.conf. I am still trying to figure out why that is happening, but until we do, since this fixes the issue, we decided to rename it for this release.
I see this pattern repeated a lot, provided = something, then a function call using that value, then no other use of that value. Should we just do like
```javascript
v.check({ a: 'invalid/' }, function(err, cleaned) {
```
?
Yay!!!  I have a local clone of docs up and running, with the installfest served up via localhost.  Next steps will be to rebase my fork and generate a clean PR.

Reiterating an earlier question -- shall I do one big PR to catch up, or is it easier to deal with in smaller chunks?
all the commented code below should probably not make it
I'm not sure why we need the try catch block, isn't there a way to do this without having to rescue something?
The reason I did it this way was so that I could explicitly call it in some code that is doing a "star-join" which we don't have a good handle on yet in scalding.

I think having this as a static function is useful (for instance, Yifan will likely use it in Java).
:+1: 
```javascript
function(){}
```
Good catch, I will work on that branch next.
A variable may expand to more than one word (ie, it contains spaces). See CFLAGS in the example JSONMakefile I gave you.
This breaks, because now when you try to run subprocess.check_call, it tries to treat the things separated by spaces as one option, rather than different ones.
Category subscriptions
The layout of the change account settings page makes it clear that the changing password and changing profile forms are separate from each other. I guess I can't say for sure since I'm not the end user, but I doubt anyone would think that they could fill out and submit both forms at once.
Can we not check the return value of `setMasterState` and only send the message if we updated the state?
Ok, I did it :)
Again a `read`.
えー、結局こういう持ち方にするの…まあいいけど…
Would you please explain why you use 200ms resolution when the minimum time for conversion is about 800ms? I would even increase this to 1s.
just run `cucumber`
`#define`ed  constants should always be upper case.  This should be called `ITER` to stay consistent with C naming conventions.
This is in iFixit-Info, but everything iFixit has been replaced by Tesla?  not really sure how iOS works but this seems strange,  shouldn't we have a *-Info file for each of our apps?
e.printStacktrace is evil.  Log please.
Can we use plugin info instead for this?
Nit: Swap condition order to match if statements above.
I need some feedback on this, can I remove the if statement there?
What is this change, not sure I understand what it achieves.

Also need some test coverage if possible.
Sure but, you add bunch of boilerplate code that you could have avoided by using bind instead. I'm fine either way since hopefully content-proxy code will go away sometime in a future.
exceptions are logged via `console.exception` in this test we intentionally throw to verify that other listeners are called even if one of them throws. But we don't want to log these exceptions into output so we override `console.exception` to ignore it.
got to rm this
[bug 792644](https://bugzilla.mozilla.org/show_bug.cgi?id=792644) let's handle it there.
> Couldn't we just use Object.freeze instead of this lamba method? Object.freeze has some chances to be already known by code reader. lamda doesn't. > Object.freeze has a name with a clear meaning. lambda doesn't.

They do different things! `lambda` not only freezes but also sets prototype to undefined before freeze so it can't be used for exchange data between parties that shouldn't. Lambda is also pretty well known term in CS http://en.wikipedia.org/wiki/Lambda_calculus

The main reason to wrap all exposed functions into `lambda` is described in the comments fro `lambda` function. Since loader will be shared across add-on's any mutability may be used by untrusted code to exchange data. So we need to deep freeze everything.
Why is this the only animation to get a default 250ms? Should it have a default at all?
I think these cron commands need a days_ago param added
Move this file to a more self-contained setup.py (see skimage/sthor example).
btw what's the aim of this method?
Would it be better to return an empty collection rather than nil when the resource isn't virtual?  That might simplify caller interactions; they would be able to use things like `realize(...).each` safely without a "nil" check in the middle.
If we used `Object.instance_method(:method)`, would we need this case?
Looks like you've made a typo here.
I'd rewrite the above as:
```
if ($name === null) {
    return $this->headers;
}

if ($this->headers->has($name)) {
    return $this->headers->get($name);
}

return $default;
```
This set will be overwritten by the parent
Why don't you just put a
`var res_send = res.send;` here…
oc.tc should be a final static variable
Nice idea. Will update.
ADmad: no - empty array would mean that clearing of cache groups is disabled from DebugKit panel, same thing as $engines - that empty string means it is allowed to clear all engines/groups at once
What is the impact of removing the headers param?
Minor nitpick, since you're using core.logic you don't need to fully qualify protocols like this `IWalkable` is sufficient.
@harjis Missä muuttuja $_kassalipas setataan?
Align all `=`
i wonder if we should not extend the exception and have a factory method to avoid repeating this long explanation?
where did the real cleanup go to? (in case of success)
``oauth/v2/`` for OAuth1 ? Is it really so weird in their API ?
Could we add a few comments into this file? I think it could do with a bit more explanation (not really related to your changes!).
This sentence is an instruction to you, not to be included in the end result!
only one blank line
These locales are not associated with BannerInstances at all. BannerLocales just define what locales a Banner is available in, and Banners are used to create BannerInstances. So deleting the whole set will only make it so that users can't create any new BannerInstances using that particular banner.

Also, the list is recreated below based on the locale list selected by the admin user, so this shouldn't affect users at all.
Now that result_text is a property you can remove the () :)
I would say from my research most providers follow that convention, and ovirt seems to be the first exception I've seen.  Why the ovirt developer chose not to follow that convention I cannot say.  It was very obvious in my reading of Fog code, email threads, and other comments, that the 'Save' function in Fog generally does not perform an update.

IMO foreman would be better off following that convention, and providing a patch to ovirt to bring it into line with other existing providers might be time better spent than trying to make foreman work around all that.  Unless you want to focus foreman on ovirt primarily.

I am checking with the Fog maintainers to see if they intended for the 'Save' functionality to follow a convention, so that I'll know more about what the best course of action might be.
should sorting move into the model?
Should probably avoid global cache vars. `context.configCache` provides a better option as the lifecycle is managed for you and it doesn't have any concerns about shared data if someone attempted to do concurrent exec (unsure why they would do this but...)
I also like automatic fixing of these types of stuff, but you can assume that everyone uses their own preferred way. A simple way to avoid (most of) these problems is to enable eclipse, or any IDE, to only fix the lines you yourself have changed. It helps you keep your code like you want, but also does not attempt to fix every other person's IDE changes.

As long as we do not have a company wide enforced standard for this...

I do not remember how to do this in eclpise.
It looks like the angle could be 2º, but we'd just draw it as 30º (i.e. not to scale)? Do we just not get enough variety otherwise?
I still don't think the distinction is very clear. While the class `Quantity` may not have a physical interpretation, an _object_ quantity surely does. I'm not sure I understand your argument, because a raw number doesn't need a unit to have meaning -- a raw number is a raw number! I also don't understand the notion of a `point in space` not having units. If a point in space has no units or uncertainty, as you say, why not just use raw numbers or arrays? 

The `Coordinate` object can hide the details of how data is stored, but still be built on the same framework (`NDData`). The API can in fact be exactly the same -- `angle.degrees` could just call `angle.value_in(degrees)`, etc. In fact, you don't even have to internally store everything as radians anymore -- it actually seems like a nicer solution to me.

My main point is that It now seems weird to have this special `Angle` class that operates as a scalar or an array, when for any other quantities with units and uncertainties we say "scalar = `Quantity`, array = `NDData`". Let me give you a specific example. Let's say I have three arrays representing Galactic X,Y,Z distances. Those are valid coordinates, and most certainly have units and uncertainties associated with them. Why do I have to use `NDData` to represent those, but when I transform them to `RA` and `Dec` I now have this new `Angle`-like class to deal with?
Unnecesary for statement, you can use directly:

unset($_SESSION['_DBArray']['data'][$oData->PU_UID]);

Maybe you need a "if" statement to check if the element exists in the array before to unset
would prefer
```
try:
  from ...
except:
  pass
else:
  sync...
```

In case sync_design_docs() imports anything.
This line is not present in master. Is there any conflict with fbe25d5 in this PR?
Well, nvm, it's not worse then the original code anyway.
Yeah, I need to clean up some of the unused code.  Sorry.
Well, that's right. But I wouldn't set the default to True. The else case can always be executed but if no time information is present the if case would fail. So I think it's better to opt-in for the additional filter.
Sure, I'll look into it.
I'd like to keep it around since it's currently being used for the fields for Facebook authentication. We can probably move it out once we add special handling for those fields.
Another possibility could be that the item is added to a re-indexing queue and is processed on a dedicated machine. I think this is the plan for activities as well, and they could be combined into 1 dedicated indexing/activity/preview processing server.
This should at least be optional. When the user is private, the publicAlias should have a default value. I'm thinking that username is probably a reasonable default.
That's true. I added a ticket: [#1001273](https://www.assembla.com/spaces/scala-ide/tickets/1001273)
Would it make sense to introduce a ``NoIndex`` object (null pattern)?
we need to remove the 'magnum' refs
This PR should be closed :)


Le 17 oct. 2012 à 14:15, Markus Bachmann <notifications@github.com> a écrit :

> In tests/Geocoder/Tests/Provider/ChainProviderTest.php:
> 
> > @@ -12,10 +12,9 @@ class ChainProviderTest extends TestCase
> >  {
> >      public function testAddProvider()
> >      {
> > -        $mock = $this->getMock('Geocoder\\Provider\\ProviderInterface');
> > +        $mock = $this->getMockProvider();
> I don't like factory methods that create mock objects, because it make small tests less readable.
> @willdurand What do you think?
> 
> —
> Reply to this email directly or view it on GitHub.
>
is now: handleMovementDetection *FIXED*
Since this function does practically the same thing as the function above it, can you do the conversion of `iterator_to_array` first & then let the next function utilize it?
Not sure if narf will see this.  Just adding corrected handle:
@narfbg
Согласен, спасибо.
[someCell mutate:100]; // заменить 100% последовательности днк. Если элементов 100 - меняем все 100. Если элементов 500 - все 500. Процент указывает, какую часть от общего количества нужно заменить

[someCell mutate:50]; // заменить 50%, половину от общего количества ячеек в ДНК. 100 элементов? Изменено должно быть 50. 500 элементов? К замене 250.
Вы правы, моя оплошность. :)
I tested your proposal, but it didn't work. It comes back to the value never actually being below the min or above the max. If it did the line you wrote would be perfect.
be patient
Don't send the object as it is in the response; Convert it to string first like this 
``` 
var responseText = JSON.stringify(jsonR);
res1.send(responseText);
```

Also rename res1 to something more representative.
Why is this commented out? I think we want to be able to update these fields. Is the reason because we do the update to the incoming user record in the resource and so don't need to pull the data out of the EJSON? If that's the case, please remove the commented code and add a comment describing how this stuff currently works.
"are jobs running" should possibly be "jobs scheduled to run" or the like.
Please don't use asterisk imports.
Let's add a few more details here explaining the value behind this. We might say something like "sometimes you need additional information about each service that's tagged with your tag. For example, in our TransportChain..."
I don't understand, what should I change?
let's remove those commas where it is not needed
No WordSpec here?
Por si quisiera poner un filtro en el buscador de archivos para mostrar
solo los archivos de los empleados o de los postulantes.

On Sat, Aug 25, 2012 at 12:12 PM, Alpha <notifications@github.com> wrote:

> In
> source/CommonJobs/CommonJobs.Infrastructure/AttachmentSearching/Attachments_QuickSearch.cs:
>
> > @@ -62,7 +66,9 @@ select new
> >                      RelatedEntityId = (string)null,
> >                      ContentExtractorConfigurationHash = (string)null,
> >                      IsOrphan = false,
> > -                    HasText = false
> > +                    HasText = false,
> > +                    RelatedEntityType = "Employee",
>
> ¿Para qué vas a usar el RelatedEntityType?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/164/files#r1459709>.
>
>
Pondering on your remark I found out that it was mere gut feeling that let me do this, than a conscious decision at that time.
For me it feels better WRT to responsibility. LocalStorage shouldn't know Settings, I think. But the check and decision should be moved to one method in cgData perhaps.
If  we do not check it here, then if --zoom, --fit-width, --fit-every is presented it would create unwanted results, because in document with different page sizes this method *min_element(zoom_factors.begin(), zoom_factors.end())  on some pages will return zoom value on some calculated zoom value from --fit-width value.
Ya cuz there is magic in the wsgi layer that makes the kwargs of a method necessary in the services. So unless we add those both to every public api method we have to delete them :)

Sent from my digital shackles. 

On Jun 1, 2012, at 9:25 AM, Nirmal Ranganathan<reply@reply.github.com> wrote:

>> @@ -34,6 +34,10 @@ class ReddwarfContext(context.RequestContext):
>>     """
>> 
>>     def __init__(self, **kwargs):
>> +        self.limit = kwargs['limit']
>> +        self.marker = kwargs['marker']
>> +        del kwargs['limit']
> 
> Is there a need to delete the kwargs here?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hub-cap/reddwarf_lite/pull/86/files#r914917
¿donde esta la data()?
Actually, this is not a shared cacheloader. Each node has its cacheloader so I had to put data into each. I agree that I should make a test for shared cacheloader.
Some unused imports were left behind.
I will need to add another commit that fixes the interrupt table. Some vectors are the same, but not all. The vectors I was able to test are the same, hence why everything worked for me.
A fair point. I must say that I do like the consistency with `pyplot.hist` (which also exposes a `log` option) that this set provides. That being said, if documented clearly the correct approach really isn't any harder than the the special-cased kwarg (if only a bit less discoverable).
On 2012/10/17 11:29 AM, Damon McDougall wrote:
> In lib/matplotlib/backends/backend_pdf.py:
>
>> @@ -1556,7 +1556,10 @@ def draw_markers(self, gc, marker_path, marker_trans, path, trans, rgbFace=None)
>>              return
>>
>>          self.check_gc(gc, rgbFace)
>> -        fillp = gc.fillp()
>> +        if rgbFace:
>
> This is |check_gc|:
>
> def  check_gc(self,  gc,  fillcolor=None):
>          orig_fill  =  gc._fillcolor
>          gc._fillcolor  =  fillcolor
>
>          delta  =  self.gc.delta(gc)
>          if  delta:  self.file.output(*delta)
>
>          # Restore gc to avoid unwanted side effects
>          gc._fillcolor  =  orig_fill
>
> It looks like the last line restores it. Might that be the cause?

Yes, I missed that.

@mdboom,
I think a better alternative would be to modify the gc.fillp() method to 
take an optional rgbFace arg (not a kwarg); draw_markers would then call 
it with that arg, and all other uses would call it without.  If the arg 
is present, it would be used inside fillp() in place of self._fillcolor.
What is the difference between this line and the one at line 106?

```
>>> a = numpy.arange(12).reshape(3, 4)
>>> len(a)
3
>>> a.shape[0]
3
```
It didn't seem to be necessary, particularly after the tests were changed to use non-antialiased text.  This was just slowing things down.  But I agree it might be better to just remove the lines of code.
Nevermind; I was being retarded.
As far as I can see, strings would just work for the new values whilst keeping the integers for the old would avoid breaking any backwards compatibility?

None the less, this doesn't need to be done here for this pull request to be useful. In its current form this pull should be considered for merging into the 1.1.x branch.
Why remove the assertTrue here?
`class="form-actions"`
You should be able to remove this line.  This should be done automatically by `PSU\Template`
Whenever you have something like

```clojure
(if (odd? x)
   true
   false)
```

You should really just be writing

```clojure
(odd? x)
```
This event is backwards. It should be `updatedTitle.worldsettings.sakai`
Latest 2 it is, I was too optimistic.
Already checked. That code does not include an ACL for Group.ADMINISTRATORS_GROUP.
@thecarlhall Since pages don't have this property, it seems to result in a `500` exception: http://cl.ly/GWhb
I have an alternative PR at #784
We don't need to call them via CLI. I [generate the session key file](https://github.com/michalochman/SilverStripe-Behaviour-Testing-Framework/blob/master/features/extensions/SilverStripeExtension/src/Behat/SilverStripeExtension/Context/Initializer/SilverStripeAwareInitializer.php#L124) using CLI.
We agree on that point, but I'm also saying that `set_experiment_created_at` having initialization logic is bad since the name of the method is only marginally related to initialization; if anything, we should have an `init(experiment)` method. `set_experiment_created_at` should do nothing but, well, set the experiment's created at (if it doesn't exist). Optimally, `set_experiment_created_at` would not be a method at all since created_at should be set inside init().

The problem is that there's two representations of an experiment. There's the ruby object, and there's an entry in a persistent database. These two should always be in sync with each other and have a well defined relationship. Initialization *is* the process of setting up this relationship, so the relationship is going to be wonky beforehand. `set_experiment_created_at` is initialization code, and its invocation is part of the syncing between the two representations. `set_experiment_enabled` is not limited to initialization code and can be invoked whenever, so it shouldn't be doing initialization all the time. Now, this contradicts the code I have now since I'm doing initialization in the form of `create_if_not_exist`. Again, this is something that would be fixed in an init() method.

So what do you think about having an init() method and getting rid of `set_experiment_created_at`?
Так писать нельзя. Нужно писать так:
```javascript
$(document).ready(function() {...})
```
ато у тебя получается вызов функции $ с параметром твоей функции - бред. В некоторых браузерах я думаю слетит такая вещь. Тебе же нужно выполнить функцию при загрузке страницы, а не проинициализировать jquery при загрузке скрипта
Isn't this from https://github.com/phpbb/phpbb3/pull/545/files ? Why is it here?
Are you sure ``$length`` has the correct type as "double" is not a sub-type of "integer|null"?
Are you sure that the method "prg()" exists?
``$translation_db`` does not seem to conform to the naming convention (``^[a-z][a-zA-Z0-9]*$``). I also found this on lines 33, and 32.
How about making the return type a bit more specific; maybe use ``array``?
New JS interop example added to article.
Agreed. See new code.
this looks like an unwanted change? then again the URL should likely be changed to something more generic like "symfony-standard.lo"
hmm. Actually I think that we should use [`ActionView::Helpers::TranslationHelper.translate`](https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/translation_helper.rb#L46) here
Just the `SplunkException` class. No s.
do we need to v2 this?
Wouldn't it be better to let it raise instead of silently swallowing it? I see this being similar to:

```ruby
1 > :a
#=> ArgumentError: comparison of Fixnum with :a failed
```
You should leave the update query as it was before, complicated and atomic. Just limit the user objects over which we go over.
Spaces around `+`. Add TODO about hard-coded user link. Spaces after `,`.
You will then do not this anymore.
You are not really using it bellow in `get_full_node_id`.
`from piplmesh.api import resources` would be enough?
I know. But it is still in pull request and is on the way to the repository. It is nothing wrong if it stays in (with TODO), but it should work for anybody who tries it. And then others can build upon that commenting interface.
Seems very similar to how I am doing it:

https://github.com/wlanslovenija/django-datastream/blob/master/django_datastream/signals.py

So it must be right. :-)

Of course you should be using single `'` and tuple there.

I am just not sure about arguments. Why simply not pass `obj` as an argument and this is it? So signal gets new post object and if necessary, they can do from there. Compare with Django's native [post_save](https://docs.djangoproject.com/en/dev/ref/signals/#django.db.models.signals.post_save).
Ah thanks, I missed those.
помойму это не фабрика
This is just my ignorance of the PayPal API, but what's the difference between this and a normal ```authorize```? I see that this takes a transaction id, but am not clear on how it would be used.

Might be worth adding some simple docs for each of these methods, actually.
OK. I have refactored this class. Now the formula path finding is a separate class
The referenced Infinispan configuration ...
...but the point is that `settings.tokenValue` might not be `'id'`, it is a setting that can be overridden. In the false case of the ternary, this could reference `item['my-custom-JSON-field-name-that-is-not-id']`.

FWIW though I had to make some further changes to the code in this pull request for it to function correctly for my need, but though they are small, I haven't rigorously examined whether they are generically working for all combinations of config settings/use cases. That's kind of difficult without unit tests for this plugin, but I'll see about submitting a pull request if I can be reasonably confident.

If it's helpful to others trying to make it work for your own needs, basically I just replaced the `displayedItem[settings.tokenValue] = input_box.val();` line in the `handleCreation` function with an entirely new object attribute, `displayedItem['newTokenName'] = input_box.val();`, and then replaced the ugly ternary line in question above with `item.name = item.newTokenName;`. So the question of whether this works for all cases is at least isolated to the new creation feature, it would have no impact on prior plugin functionality.
It changed because it's a syntax error according to the spec and broke Firefox and Chrome. But I think it was an accident that this was merged to this branch.
I don't think this breaks anything in Opera (or does it?), so we can probably just keep it.
"responsecode" (no underscore) and "responsesummary". Could use "response_code".
I'd change it. :) There's no real benefit, only makes it harder to read.
We should reparent ApacheRewriteDriverFactory and NgxRewriteDriverFactory to a new class OriginRewriteDriverFactory & factor out as much as possible.  Please add a TODO.
Proper C++ casts?
Is this true? We pass the longley test for near perfect multicollinearity.
faudrait virer ces fichiers inutiles
Import only modules. ;-)
No, we do not official `ModelBackend` anymore if we have `CaseInsensitiveModelBackend`.
Ok. That's some comfort, but I'm still really not enthusiastic about fixing an issue with the attr plugin by removing code from the test loader. I'd really like to find some other way.
Maybe it's time to not support servlet API based containers anymore - http://tomcat.apache.org/tomcat-55-eol.html
pylint? :-)
Recommend we switch this to example.org as well.
Same comment re:List vs. Set.
Reads better.
This class isn't complete yet.
I was just being a smart ass, "the" is misspelled.  I only notice because I perpetually make the same typo.
All...!
It's not obvious from this notation that `g1,g2` must be kwargs, not regular arguments.  Same with the other options below.
good catch, thought i got everything.

On Thu, Aug 9, 2012 at 12:21 PM, Greg Sadowski <notifications@github.com>wrote:

> In GroupCommerce.SDK.V3.PublisherConsumerApp/Form1.Designer.cs:
>
> > @@ -812,6 +860,12 @@ private void InitializeComponent()
> >  			this.panel1.SuspendLayout();
> >  			this.grpSubscriptions_GetSubscriptionInfo.SuspendLayout();
> >  			this.grpSubscriptions_GetSubscriptionLists.SuspendLayout();
> > +			this.tab_CartManagement.SuspendLayout();
> > +			this.groupBoxCartManagementCreate.SuspendLayout();
> > +			this.groupBox5.SuspendLayout();
>
> rename groupbox5 and 6
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/GroupCommerce/sdk.dotnet/pull/69/files#r1343975>.
>
>



-- 
Avi Lederman
Software Engineer  |  Group Commerce Inc.
alederman@groupcommerce.com
Assuming the `rules_string` variable has been declared, it is more appropriate to use an `if-else` block than a `try-except` block here as the conditions deal with easily predictable values that should not produce an exception/error.
On that point, the heading in this file talks about "climatology" but not about oceanography. The iris documentation itself says the inverse... perhaps we should update both to list all three...
destroy protected. 

how to let admin access all the routes?
What would be the added value?
This must be forced to run after testListEntities?
That's a really nice format!
Ah, I see. You duplicate the file-name-generation in the else block.
If a source only ever has one listening room, why store it as a hash?
> I believe we should insert an evert at the time of occurrence and not be the time they arrive to our server.

No, we should not require clients to have precise clock. This should be done on the server. Server can do much better job at it.

> The router might log events on the local network and do not have connection with the internet for some reason. But as soon as the connection is established it should push all the events to the nodewatcher and those should be logged appropriately.

Good example.

I was thinking later, that we could extend API with "import" call, where you would be able to provide a set of datapoints to import. It could be used when migrating to our system, for dummy data, and also for batch adding points.

But I would not extend the insert with timestamp, because it would make easier to misuse it.
Could you please use `<-` for assignment, and put spaces around infix operators? (e.g. `=`)
This test fails for me (Linux x86_64).
I genuinely don't understand this! First of all, surely args should be to the right so the extra ones are checked last.

Lastly, I think we should change the return codes to a single value: None, True or False. To begin with, there is no loss of information between those 3 and the 3 tuples you already have. 

Also, I'm thinking that instead of return codes should be only for the predicate, not for the action. Instead, for the action, it should either just run or it should raise a ActionError exception.

Django does that pattern for its HTML Form framework. Every input field has a validator function (either defined or implicit by type) and each validator function returns the value or a ValidationError exception which is wrapped and swallowed by the `myforminstance.validate()` which upon being false sets ``myforminstance.errors``.

Also, tuple return codes are generally more trouble I think.
Turn it into an enum, so looks less ugly? I.e. kGOAudience. Just a thought
I have ;-)
Ok, ce fichier ne devrait pas être commité.
You'll get used to it ;)
Was this change intended?  It seems like GPSOnly is a more sensible default value (although doesn't make a lot of sense as a sensor)
The idea is that HttpProviders are 1:1 with requests so I like the idea of setting the headers on each one.  This was done in a universe where things like OTP exist and the header may be changing rather rapidly.
Maybe rephrase it to HttpRestProvider implementation and what this class really does?
Лучше обходить с помощью charAt (не создаётся лишний массив)
Кажется, я говорил, что start() вызывать в конструкторе - не очень хорошая идея.
seems not seams - not a blocker
This is an API wrapper, so let's call it MarketplaceAPI
default is useless here as you don't have anything in it
In my opinion the way we form class names shouldn't have such a strict policy, code quality is much more important, class names shouldn't be consistent just for the sake of consistency.

As discussed in another thread, recognizable names can stay as is.

I'm +1 for FactorAnalysis and DictionaryLearning. One doesn't read PCA as PrincipalComponentAnalyzer, right?

Real people will always do Fact<tab> anyway.
is this method only for dense? Maybe use array2d?
Nothing is said about the generator behavior.
Neither do I, but it's a long-standing convention.

As for mimicking NB: I've been considering changing it's behavior, I just never got round to it. It does some stuff differently from all the other estimators, and I feel it should be more like the other linear models.
вижу уже есть :)
Neat stuff. Thanks to both of you for contributing. :)
When is this lib going to be final? Even though this is a testsuite dependency I'm sure adding a non-Final dependency is going to stir up a fuss.
For the !t case, it should return an error saying that a type is expected.
> In this case, using (storage_class & STC_TYPECTOR) && !isThis() is more short and identical.

Sorry, this is incorrect...
I think the code should be as like

```d
        OutBuffer buf;

        buf.writeByte('(');
        if (arguments && arguments->dim)
        {
            HdrGenState hgs;
            argExpTypesToCBuffer(&buf, arguments, &hgs);
        }
        buf.writeByte(')');
        if (ethis)
            ethis->type->modToBuffer(&buf);

```
Try:

    e->error("%s is not mutable", e->toChars());
@l3l0 done and push.
Tell me if it's not ok
There is a `platforms` for the change event's reason property, but I don't think that's for the event itself. Please check with Appcelerator
Delete all blank herlpers
TDXjobtemp's too - more so probably as TDXtemporary's are probably never published in hThor (they are only published in Thor if checkpointing is on).
This file seems to be missing
I agree, before this commit, getNextSorted() transferred ownship, in a bit of an odd way, by avoiding freeing any (in killSorted) behind those that had been got, those behind 'finger'...

But now killSorted clears the array and 'getNextSorted' isn't linking.

I think what you really want/should be doing here is calling DynamicRoxieOutputRowArray::getClear(), to transfer ownership.
the writer (out->putRow) will take ownership and free.
You don't want another releaseHThorRow.
Also the +16 appears to be assuming that the average size of the filename part of an inotify_event is 16 bytes?
Generally best to remove comments once they no longer apply.
I'm not sure this is worth checking - it would be a fairly major bug if allocations returned fewer than requested.
Not critical in this case I don't think, but you should also do this:
```self.urlencode_params(params)```

@peterbe, I think we really should make that part of the built-in fetch(), perhaps params should be passed to it as a dict so it builds the URL? This will probably be missed if not.
Don't dispair. Git submodules are tricky. Especially so when it's nested. 

I think I'm personally over it now but it took me a long time to really feel comfortable around submodules.
"The name SENDGRID_CREATE_EVENTS_AND_EMAILS_FOR_NEWSLETTERS sounds to me like it will create the missing emails for newsletters only."
That's exactly the intention. Now that I think of it if you're talking about events that come with an id but dont exist. that might be using this setting and you're right that it shouldn't be. I'll check and fix this later.
Reading through this again  http://wiki.opscode.com/display/chef/Templates
Had to remove this animation to make it work on every page load.
@yuhunglin Can we rename `data` to `dataBSpace`?
yep. I remember a few events last year with multiple webcasts
In my mind, this is just one extra place to possibly introduce an error. If you rename category to "discussion_type", you need to update this line of code too. Putting the names in there does make it a bit more self-documenting, but comes at a high cost in that sense. Instead, what I think is best is for Discussion.search to have some adequate tests and documentation.
no, but it will be totally broken as it will return ``null`` for the parent, meaning it will not inherit any logic from the ``form`` type
This execute lacks a not_if, which makes me sad.  I'm also able to understand that rsync is idempotent.
Makes sense. Status should be `200`
should this include?

 # Managed by RightScale 
 # DO NOT EDIT BY HAND
Good call! For some reason I had always assumed isdigit() did what its name implied — checked for *a* digit. Should I make the change or do you want to do it after merging?
This file should remain untouched, as it comes from a third-party source. Leaving it unmodified means we can drop in updated versions without worrying about stomping on potential changes.
rather than defaulting here, we probably should put that in the `settings.py` dict which already contains default vars.
I thing this could go to the page.py file.
@davehunt  is it ok to move this there?
Are you sure this needs to be deferred? It seems to be working fine according to the translator tester.
Related, non-review, question; is the lack of a depth buffer the reason picking only returns a single item right now, rather than a list of items at the same pixel?
Looks like a sensible default for most folks... I have to say that we still run chef 0.9, so I don't think that variable is accessible. Let's just have a guard that prevents the handler from crashing. Something like:

    unless node.attribute?('chef_environment') and node.chef_environment == '_default'
最好还是不要直接返回一个场景，而是将旧的场景从dt::StateManager里pop出去并且把新的场景push进去。这样调用者就不用自己每次都进行pop/push了，提高了代码的重用性。
I think a test should be added for `order_id` since we'll use the arbitrary options to pass `user_id` through the system. Maybe the test is separate from `test55 `.  Thoughts?

```ruby
assert_equal '55', response.params['litleOnlineResponse']['authorizationResponse']['something']
```
So what would happen if you didn't set the 'full name' property instead of setting it to some default?  I noticed that for other properties such as middleName, it's possible that the property is not set at all.  It almost seems like we should do the same instead of setting it to default (unless the full name property is required)
Remove this blank line before the case statements.
Also we indent the case statements to watch the existing style of the code
There's a mixup of words here, not sure what was meant.
[Okay.](https://github.com/Thynix/wininstaller-staging/commit/07b1a55dd49b7521d76d2281c32602abb9ef5088)
Should probably read:

```python
for field_key, field_tuple in form.field_dict.iteritems():
```
Source formatting note: This choose block should be tabbed over, and no new line above it (c:if statements usually have a new line, but not c:choose)
To directly use the doctrine service. Should I switch back to the `getDoctrine()` method?
Does your implementation of require in the browser use the identical require.cache implementation as node?
Тут свалится с `undefined`. Надо как-то так:

```coffee
uris = dt.getData('text/uri-list')
upload('url', uris.replace(/\n$/, '')) if uris
```
Can we make error triggering optional? Turn it on by default, but allow the user to toggle it as necessary.
Does too much
I think its better to check for the presence of this file and conditionally source it. We don't want to hardcode java paths.
Maybe, such type test should be ```static assert```.
See other Phobos modules.
Sounds good. Though after call to mergeAt they need to be reloaded as it changes stack.

I increasingly suspect that Tim Sort is best described as a stateful process.
A state consists of stack, temporary space and initial array to sort. And most of helper functions inevitably access this state in various ways. The swath of ref parameters seem to underline this point.

Then  top, second, third are then methods of said intermediate object. I'll try to re-write it this way and see 
- if it helps readability/removes redundancy
- has any negative effects on performance
* Remove the old unittest. The new unittest is more than adequate.

* I rearranged the new unittest into a couple of nested functions which will allow a CTFE unittest to be added in the future. [See here](https://github.com/Xinok/XSort/blob/master/timsort.d#L566).

* Somebody merge this already!!!
could be unfutured and used with or
nice to see these simplifications :)
Maybe "Demonstrate how to call an asynchronous EJB, and then perform another task whilst waiting for the result."
Might want to move this out into an Activity which has access to the SyncService instead
were these removed deliberately?  It looks reasonable.  I don't think it will cause problems with old workunits since not called from an inline function
I'm not convinced.  Should probably be a SourceActivity until more work is done.
Can you please add some docs here? It isn't clear what users, groups, contentUsers etc... all means.
kolan dashtam amoozehs midadam
Hm, maybe it makes sense to allow both options in this case. Or a different approach would be, that we put in the variables using <env /> into the phpunit.xml.dist and comment the whole block with xml comments, see http://www.phpunit.de/manual/current/en/appendixes.configuration.html#appendixes.configuration.php-ini-constants-variables

That way one could either use the phpunit.xml configuration, or inject using environment variables. This allows both jenkins and "users" to configure the testrunning easily and the commenting of the <env/> variables still serves as a good documentation what to adjust.
according to the phpoc of the interface, it should be ``event``, not ``name``. either the phpdoc need to be fixed or the compiler pass
Ich weiss, das ist jetzt Pingelig... Aber versuch doch konsistent einzurücken... Einfach, dass es schön wird :D
Greg, I added another pull request to fix this: https://github.com/gregbell/active_admin/pull/1115
:-1:

Alignment, see my [comment](https://github.com/php-fig/fig-standards/pull/16/files#r532945).
Totally agree, that's part of the optimizations we'll be doing later this year.