labofsahil/github-event-dataset-2012 huggingface dataset:
On 12.06.2012 14:23, Sergiu Ivanov wrote:
>> +
>> +    def __hash__(self):
>> +        return hash((self.name, self.domain, self.codomain))
>> +
>> +class Category(Basic):
>> +    r"""
>> +    An (abstract) category.
>> +
>> +    A category [JoyOfCats] is a quadruple `\mbox{K} = (O, \hom, id,
>> +    \circ)` consisting of
>> +
>> +    * a (set-theoretical) class `O`, whose members are called
>> +      `K`-objects,
>> +
>> +    * for each pair `(A, B)` of `K`-objects, a set `\hom(A, B)` whose
>> +      members are called `K`-morphisms from `A` to `B`,
>
> Nope, that's the canonical definition of a category.
>

Wikipedia defines hom(A, B) to be a class, calls a category small if 
both K and the hom-classes are all sets, and locally small if the 
hom-classes are sets. That's the terminology I'm used to. But I don't 
think it matters much, so stick to whatever JoyOfCats uses as definition.
I totally agree that `commutative_diagrams` is better, but isn't it too long?
There is now a sort=True flag for __print_Boolean.

/c
Not only that, but you should never hash against str.  Not only is it way too slow for hash, but it's possible for `str(x) == str(y)`, but not `x == y` (e.g., `Symbol('x')` and `Symbol('x', real=True)`).
This needs to be changed to use SymPyDeprecationWarning.  By default, it uses UserWarning.
If I'm not mistaken, the evaluation works from the inside out so this 2nd test can be deleted. It is essentially the same as the first.

`Abs1(Abs2(Abs3(x))) -> Abs1(Abs3(x)) -> Abs3(x)`

Can you then squash the commits together and then this is ready to go.
Is there any reason not to just make `is_Trig = True`?
looks like a left over :)
If we add `controllerNamespace`, we should not use this default because the property already solves the problem while the default unnecessarily enforces some rule.
Potentially we could, on a success, take the timestamp out of the clients request and delete all sessions that occurred before it. Right now I'm blocking deletion of the file until all session clients have finished (and the last client session report request succeeds). see 6eeb71c for the syncronization.
Current session start time is stored in a property, so there's no risk of deleting the current session. There is actually a greater risk of duplicates.
Nice try, but that no longer serves files that _do_ exist.
If there is not previous commit, you want to the notification.
This needs a comment explaining why it's swapped when i == 0.
If you rewrite this code, make it a spec.
Put it under spec/file_copy/...
Comment no longer relevant?
No, you've done that only in mcp_topic.html

Other files have <div> or </div> on same line as corner span, so this issue doesn't affect other files.
I wonder what this does.
You can drop the `? true : false` everywhere
It is really not complicated. Pull all columns and check column values under a single loop. Please leave all conditions in the query (i.e. don't just retrieve all users being messaged) as that is also very easy.

Efficient use of the database is important.
Delete closing tag.
This constructor should be on phpbb_cache_driver_sql_generic.
It's being handled: `&$error`
Yup I should definitely comment this more.
Why no type hinting?
avatar's
Are these two lines really needed? They seem to fix an other issue?
use $path_info here, it has the value of getPathInfo()
Shouldn't we then rather have a constant that tells phpBB not to load the composer class loader?

I'm also unsure what exactly the point of PHPBB_AUTOLOAD is. the include of vendor/.composer/autoload is prefixed with $phpbb_root_path, so why would some phpBB script need an environment variable?

Maybe you can create a topic on area51 explaining why exactly we can just do require($phpbb_root_path . 'vendor/.composer/autoload.php');? None of the 3 points in the comment seem to be answers to that. But I suppose a few examples would help to explain things like "might be useful".
IE, use `path.absolute` on the result, and make sure the prefix is `DEFAULT_CUSTOM_PLUGINS_PATH `
так твоя сумма за предыдущие дни равно моему полю last_shows же? текущее количество нужно чтобы знать истек лимит или нет

что если нода будет и делать инсерт в таблицу дневной статистики, и апдейтить суммарные просмотры/клики? а крон будет только проверять истек лимит или нет?

мне просто очень не нравится вариант без хранения суммарной статистики в базе, т.к. она нужна крону каждые 5 минут для проверки лимитов
I already tried that in fdbd852c9f2f392c4d451e98a55f96d077d980f9, but changed in de92b02e6ac784bf06c63b0449598ba0cbc64410, because this leads to an error when running rails:

```
expected instance of Binding::LexicalPath; send of :binding or :eval not supported (ArgumentError)
```
The error is raised in [bnd.__set_lex_scope(lex_path)](https://github.com/MagLev/maglev/blob/fdbd852c9f2f392c4d451e98a55f96d077d980f9/src/kernel/bootstrap/Module.rb#L313), right when [checking the arguments](https://github.com/MagLev/maglev/blob/fdbd852c9f2f392c4d451e98a55f96d077d980f9/src/kernel/bootstrap/Binding.rb#L38-40)
Do you have an idea on why this is affected by (not) using ensure?
still says 'hi' :)
This `else` clause is not needed. If it's GeogCS or RotatedGeogCS then use the spherical code, otherwise use the Cartesian code.
pip is probably advisable for numpy, but something such as the ```netcdf```` library would be a good candidate.
omg, important spottings, many thanks @rhattersley.
There are two levels of cache, Model and AQL,  if there are changes to the parsing, we would change this.

See: `Model::getMemKey()`, this sets the key using `$mod_time`.
Gone already.
Don't just throw empty Error(), provide some error message.
missing __unicode__ method
brunch is 100% async, so this should use async version. it uses callbacks anyway
Should probably use the CompMap massFraction method instead.
I think it would be cleaner to define an API to remove content on HttpResponse classes (like `truncate(update_length=True)`)
Should have a consistent wording.... FetchStyle vs. FetchMode
I'd argue these leading underscores are unnecessary; sure, technically these are "private" variables, but given there are no *public* variables (this class is not part of Fabric's published API and is unlikely to be in future) there's no point and it looks a little fugly ;)
"openquake.nrml" can be removed, "openquake.bin" cannot because during the packaging process one of the fiew modifications is to move "bin" directory into "openquake" directory.
Where is "bundle-version"?
I agree. It's a more readable code.
Crazy --- I thought we sufficiently argued against that one...

I guess I'll change my `ajaxQueue` to put it in the right order... ;)

Continue on, the fix is indeed putting the "then" last.
If we have guaranteed that CM_TRANSVAL_INITIALIZED() then why do we need to make this copy?
MADLIB-500, MADLIB-501
Do we really need this check? If so, we should explicitly document the cases in which it happens.
Please note that I'm not one of the main contributors of Meteor. Just suggesting things to think about...
Yes looks fine.aren't there any tests to prove i didn't ruin anything ? :)
I think it is good for it to safely operate on at least `None`. Maybe this is a peculiarity unique to me, but I often write `request.GET.get('foo', None)`, in case the query string doesn't contain what I'm looking for. For example this is how all the search parameters in the dashboard get fetched. That page is the reason we have `smart_datetime` and `smart_int`, so I think it is not unreasonable to follow that example.

Side note: I realize that `.get('foo', None)` is actually redundant, since the default value is already `None`, but I prefer the explicitness of the former.
Version 2.3 is out now.
Use the full path to the binary, like

```rb
system "#{bin}/mpicc", "-show"
```

or whatever is appropriate.
Earlier in `__init__`, there's this line:

```python
self.data_source.initWithModel_(self.model)
```

Should we be un-initing the data source as well?
Я бы исправил концовку на "возьми ничто в моём репозитории и сделай, чтобы в `[удал. ветка]` было то же самое"
Das passt schon so, denke ich. Denn wenn subpage leer, aber gesetzt, soll $subpage auch "settings" sein. Da würde der Default nicht greifen.
Yeah, that's why I'd asked. :P
I still wish you'd do full assertions comparing one set against another!
Can we use simple quote here?
`typedef` the struct in the declaring expression (as the remaining structs in OP2 C).
Actually, you are using both. Please remove the other one.
Ditto -- old name still referenced in CSSInlineEditor-test
This line has trailing whitespace that is giving a JSLint warning.
Good idea. I'll fix them up.
This whole suite is failing for me. I think you need to change this line to 

```
JSUtils = require("language/JSUtils")
```
already in module scope as $projectTreeContainer
Our code's a bit inconsistent about this, but it wouldn't hurt to include an JSDoc `@override` annotation here
Can you revert the indenting change?
I suspect that the memory problems were on this line, not the StringIO, no?
add format: 'json' in the query string to make easier the parsing
Different docstring formatting.  As a matter of style, kaa uses `"""` everywhere (with `"""` always being on dedicated lines).
Use decorator `@lastuser.requires_permission('siteadmin')`.
Too late :(

also:

import mongoengine

from django.conf import settings

def get_initial_language(request=None):
    return settings.LANGUAGE_CODE

class LanguageField(mongoengine.StringField):
    def __init__(self, *args, **kwargs):
        kwargs.setdefault('max_length', 5)
        kwargs.setdefault('choices', settings.LANGUAGES)
        kwargs.setdefault('default', get_initial_language)
        
        super(mongoengine.StringField, self).__init__(*args, **kwargs)
        
    def get_internal_type(self):
        return "StringField"
Add a note about how we bind IP/port in the cornfield config files, people always ask.
Wat se heck?
we should make all these guys objects right away: they are the typeclass implementations that we want to refer to.
different methods for outOfOrder and notCreatedLists were written so that if either of them is not required in a use case then only outOfOrder/notCreatedLists can be returned instead of both. Needed that in the testcase but can be modified.
oh, wait I am reading it incorrectly
Thnx, indeed it is better.
I fixed it.
Don't like it, either. Ok, we'd better stay with deserializing parameters before passing to the `Invoker` - it's much cleaner. But I'd get rid of static extension methods in favor of something like. `IParameterResolver` interface + implementation, that'd do the same. Much easier to override, if needed.
Change hub to hubDescriptor
I guess my XXX-comment is not clear… unless I misunderstand your question?

There’s no way at the moment to detect when a setting has been really changed, but it should happen within a few milliseconds after the mouse click, so I’m using an ugly 100ms timeout here.
Yes.  This header was actually only working by "accident" -- the wcslib parser is fuzzy about FITS headers with carriage returns.  It doesn't complain -- it reads some cards that don't overlap an 80 character boundary and silently rejects others.  I didn't notice this problem with this header until, in this PR, the header needed to be re-parsed by `io.fits` in order to read the `NAXIS` card.
I always liked how Numpy uses `__NUMPY_SETUP__` for this purpose, and sometimes felt that we should have something similar but name it `__ASTROPY_SETUP__`.  Not that the naming matters so much, since it's just a hack.  But it looks more "important" like this.
Sure, I understand. The effect is probably negligible anyways.

On Tue, Sep 11, 2012 at 2:42 PM, Michael Droettboom <
notifications@github.com> wrote:

> In astropy/units/format/generic.py:
>
> > +    A utility decorator to help debug the parser.
> > +    """
> > +    def run(self, s, loc, toks):
> > +        if DEBUG:
> > +            print(func.__name__, toks, end=' ')
> > +            try:
> > +                result = func(self, s, loc, toks)
> > +            except Exception as e:
> > +                print("Exception: ", e.message)
> > +                raise
> > +            print(result)
> > +        else:
> > +            return func(self, s, loc, toks)
> > +        return result
> > +
> > +    return functools.update_wrapper(run, func)
>
> I know this is less efficient, but I find it convenient to pop up the
> debugger, set DEBUG to True and start getting tracing from there on out. If
> this is all determined at import time that doesn't work. Maybe I'll add a
> TODO that once the parser is well tested in the wild we change this to what
> you suggest?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/astropy/astropy/pull/370/files#r1579186>.
>
>
So just to make sure I understand (and this was probably discussed before) why are these functions defined separately from the classes, rather than have them be methods on the Cosmology objects? If they were methods (e.g. ``WMAP7.kpc_comoving_per_arcmin``) this would actually remove the need for the whole default cosmology, since one would always explicitly import the right cosmology? You don't need to change it, but just curious.
Could just do a negative amount, that would save making/decoding a tuple and matching on it.
These can change too, btw. Not a big deal, just so you know. 

```ruby
redirect_to "new", notice: "Video upload failed"
```
If "explicit" and "report error" are independent flags, and "none" is the base state, why does none need a bit?
The target should be 'post.index', not 'post'

Basically, I followed this guide and had a working app. Afterwards I updated to the latest version of Ember (which included the change to using Route, instead of State), and the app stopped working, until I figured out that this line was the issue.

I don't know if this is actually a bug in Ember now, or if it wasn't supposed to work previously but did.
copy this test example for the comments made above.
Please review the existing code style -- Thanks
Co je zac ten code? Preco je to niekedy cislo a niekedy pismeno? Je jeho vyznam urceny kdekolvek okrem produkcnej db?
Can we push this down into HashAndInsertObject? GitIndexInfo doesn't need to know how to create the blob, it just messes with the index.

Also, there used to be a [TemporaryFile](https://github.com/git-tfs/git-tfs/blob/e1d1326e5436a2e502327ccb09880fbf6b551f6a~/GitTfs/Util/TemporaryFile.cs) class, that you might find useful here.
I meant that devtools would insert it in the namespace environment of every package loaded with `load_all` - then you can always rely on `system.file` to find the files
Needed a quick rebase to pull it out of the merge, but it's gone now.
A custom action is probably overkill.  It's probably easier to just do

```py
_unspecified = object()

# ...
@magic_arguments.argument(
    '-l', dest='limit', type=int, nargs='?', default=_unspecified,
    ...
)
# ...
def history(self, line):
#...

    if args.limit is None:
        args.limit = 10
    elif args.limit is _unspecified:
        args.limit = None
```
Rather than looping manually, I'd just let the writelines method do it for us:

```
writelines([
   u"# GENERATED BY setup.py\n",
   u"commit = '%s'\n" % repo_commit,])
```
I wrote in the pull request, that a field `lock_version` (INT) is needed for this. An sql error will be thrown if it does not exist. 

It behaves in the same way like `public static $timestamps = true;` which needs also to fields to be set.
I think the `">` should be removed at the end (this is in a few of the buttons as well).
we have a `|urlparams(asked_by=profile.user.username, sort_by=....` helper to take care of all of this.
You will have to remove all the created screenshots.
not a big deal here as you probably do always want json, but as a general rule in a utility method like this it's less surprising to the caller if you provide defaults rather than overriding something they may have specified. i.e. here if the caller specifies a format you'll override it with json; but you could instead of `params.setdefault("format", "json")`, and then you'd defer to a format they explicitly ask for.
Is that really a good test? Could we not do something like `netstat -nptl 2>&1 | grep 11211`.
Would that work?
Ah, you're right, I forgot to commit the template change. I'll update as soon as my tests finish running.
unnecessary `title`
Use the method parameter, not the instance variable.
I think that in such case you should return proper exit code, so it is easier to indicate if it succeed or not. ( it depends how early you plan add it ). But if you plan to release it, I think it should be added.
Attempt 1!
So what is the host and scheme for the subrequest? Even if you don't care for your specific controller, if the host is really `localhost` it would be pretty bad in general and people might wonder what's going on if they use similar code.
It would be better to not do that in the setUp method as most of the tests do not use this. What about just creating the directory when you actually need it?
why using a static call for non-static methods ?
addRoute() adds a route or sub-collection to the collection

and addAllRoutes() adds all routes from the given collection to the collection
```
} else {
    if (!is_dir($filename)) {
        $filename = $this->getApplication()->getKernel()->locateResource($filename);
    }

    $files = Finder::create()->files()->in($filename)->name('*.twig');
}
This is wrong, should be: `$ex = new DisabledException('User account is disabled.');`
To match route `baz` there is now a performance decrease because the simple equality check is wrapped by 2 prefix tests.
So the question is whether there is an optimization for the average case at all. It depend on the number of sub-routes. 
So the perfect optimization would also consider this fact and adjust the wraps depending on the number of sub-routes.
I mean `SELECT COUNT(token) FROM sf_profiler_data WHERE token = :token LIMIT 1`
Ok, I'm reverting my change as Request::create() already take care of keeping the host and the scheme (the information is already part of the `server` array).
seems like unnecessary error-prone-ness. why not just require worker_id? `fork_workers()` is the only callsite not passing worker_id, but it has `i` *right there*
weiiird yeah i dont recall this at all hahaha, you're right though it makes no sense
Security issue mentioned above.
id is an object.. (strong, nonatomic)  unless we allow for deallocated delegates.. in which case weak.
Readability request for these three:

```ruby
users = yammer.get('/users/by_email', email: email)

# ...

private

def yammer
  Yam.new('123', 'https://www.yammer.com/api/v1')
end
```
文字描述太多，真的，请相信我，用的时候没有人会有那么大耐心看这么一堆文字……
This is what's new in this file. Once there are more than 5 static imports, a .* import is used.
should these be merged instead of one or the other?
New syntax to tag metrics.
Yes! I didn't know about that one. Thanks @esc24!
> That's very disappointing.

That may be a little harsh. I learnt something new in tracking this down, and it confirms my suspicion that there is no interpreter optimisation going on:


```
>>> import dis
>>> def test():
...    a = range(5)
...    fn = lambda v: True
...    r = filter(fn, a)
... 
>>> dis.dis(test)
  2           0 LOAD_GLOBAL              0 (range)
              3 LOAD_CONST               1 (5)
              6 CALL_FUNCTION            1
              9 STORE_FAST               0 (a)

  3          12 LOAD_CONST               2 (<code object <lambda> at 0x7f89404599b0, file "<stdin>", line 3>)
             15 MAKE_FUNCTION            0
             18 STORE_FAST               1 (fn)

  4          21 LOAD_GLOBAL              1 (filter)
             24 LOAD_FAST                1 (fn)
             27 LOAD_FAST                0 (a)
             30 CALL_FUNCTION            2
             33 STORE_FAST               2 (r)
             36 LOAD_CONST               0 (None)
             39 RETURN_VALUE        
>>> def test():
...    a = range(5)
...    fn = lambda v: v > 3
...    r = filter(fn, a)
... 
>>> dis.dis(test)
  2           0 LOAD_GLOBAL              0 (range)
              3 LOAD_CONST               1 (5)
              6 CALL_FUNCTION            1
              9 STORE_FAST               0 (a)

  3          12 LOAD_CONST               2 (<code object <lambda> at 0x148deb0, file "<stdin>", line 3>)
             15 MAKE_FUNCTION            0
             18 STORE_FAST               1 (fn)

  4          21 LOAD_GLOBAL              1 (filter)
             24 LOAD_FAST                1 (fn)
             27 LOAD_FAST                0 (a)
             30 CALL_FUNCTION            2
             33 STORE_FAST               2 (r)
             36 LOAD_CONST               0 (None)
             39 RETURN_VALUE 
```
Same here. Try not to use repetitive Object creation, where possible.
Sorry, libvirt_vm.normalize_connect_uri(uri) function just returns "qemu:///system" or "xen:///". It doesn't contain the IP address and "ssh" connection.
Good point, but  `name` is a Unicode trait, and `Undefined` is not unicode...
I'll use that version and amend the code. thanks
this could use some autoformat :P
should be without implementation. just this

abstract void onSelect(int selectIndex);
Yes, there is always a space inside parens.

NOTE: There is actually one exception which is when a string is the only parameter, the quotes count as a space.
I deal with the inlines on https://github.com/mozilla-b2g/gaia/pull/5849, so I guess that the first one that lands will make the other to change :smile:
Maybe the skin should be 'skin-organic' for being consistent with their provider name, if it has to be in this way, i do not have anything to say :D
Remove this code
as now we don't perform any disabling I would suggest to rename it to 'markExisting'
Also, weird line break and block here.
You can omit the first three arguments and just pass the callback to enumerate.  Since you're enumerating by filename, there will be no duplicates, and 'nextunique' is not necessary. The default is 'next' which will be fine here.

For efficiency, have you considered caching the results of the enumeration?  For really large music collections maybe that would take up too much memory... I don't know.

Here's something you could do for efficiency, though.  Suppose the user types 'a' into the search box and you enumerate and display all matches.  Now if they type 'b', you want to find matches for 'ab'.  But because this new search term includes the old one, you don't actually have to enumerate the entire db again.  You can just traverse your list of matching items and remove those that do not match 'ab'.

If the user moves the cursor backward and types c, so the search term is 'acb', then you can't do that anymore and have to start over again with a full enumeration, of course.

I suspect that there is even some clever way to allow the user to type new letters of the search term while an enumeration is still in progress, without having to restart it.

And in order for this optimization to be strictly correct, I suppose you might have to use escape special regexp characters in the search term, or use toLowerCase.indexOf() to do the searching instead of using a regexp.
What's the difference between these two CSS files? HTML that gets comment out deserve a explanation.

If it's not worthy of leaving it comment out, then remove it (and the file).

        <!-- A Simple CSS that do blah blah ...
        <link rel="stylesheet" type="text/css" href="style/keyboard-simple.css">
        -->
nit: use an early return
Yes we want `home` to get us to the homescreen.
Hmm, I think we actually want the nodeload link here. I'm :+1: for following redirects, but in this case we need to just return the value of the `Location` header. Maybe a second method that follows and does the download?
I've changed the word to creating, no confusion between British and American English then.
As far as visor is concerned, the reason for the restart is caller dependent, unless the interface is explicit about the restart reason.
GitHub's diff viewer is mangling UTF-8 here. The actual UTF-8 character is visible here:
https://github.com/square/java-apns/blob/jwilson/fix-encoding/src/test/java/com/notnoop/apns/internal/UtilitiesTest.java
abstract is not necessary her since all interface methods are abstract
I'd prefer lazy.
No, my point was that #report_timing messages the channel.. and returns whatever session.msg returns.

This will message the channel twice.
I don't get what `ret` is.
Extract this location to a constant.
consider making this a constant
comment instead of remove?
Should be `return false;` to be consistent with other adapters.
Currently you can take the message id from the attachment and use that to get message object:

$message->authorise('attachment.read');

But we could even have that function inside of attachment.
ah i see haha my bad
We might want to make sure that Name is not `"current"` and print an error if it is.
Callback function needn't  to be virtual function.
this one?
```javascripts/vendor/mbp-respond.min.js```
Any particular reason for this? I used to have the project under http://localhost/trnsprt.ch/web/ so I don't need a virtual host.
fixed `Key.find_by_identifier(identifier).try(:user)`
I don't like the !strcmp notation, I always read it as "not equal", while it means the opposite. Thats why I always use explicit == 0. Also, why the strNcmp? ConfGet returns a normal string, so a regular strcmp is fine.
There's no error if there are multiple documents; it simply stops after the first one.

If want to support multiple files, but not multiple documents, we can use load_stream and the count is greater than one present an error. That said, I looked at the feature request for multiple files and I'm not sure I see the benefit.
indent this by 2 more spaces
does the Base referred to in this file expect (self, mozwebqa) or (self, selenium, timeout)? there was no change to the import, nor a change to base.py in this directory.
jsonselect ftw
Accidentally duplicated this line?
Can you remind me where 'data' is coming from?
Missed that we have the same code in tests. I would say lets make this pref a public member so tests can access its value.
Please file a new issue for the logging module that we do not pollute the global namespace but export a Logger object.
Doesn't set what?
I have forgotten to delete it. Now it is deleted. Regarding my
previuos question, is it like I have written?

2012/5/19 aipp <reply@reply.github.com>:
>> @@ -0,0 +1,18 @@
>> +package org.openpixi.pixi.physics.solver.relativistic;
>> +
>> +import org.openpixi.pixi.physics.ConstantsSI;
>
> this import is obsolete
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openpixi/openpixi/pull/19/files#r849660
Thinking about this a bit more, I wonder if putting `setcode` inside of the conditional means that `zfs` will only be checked once, when the fact is added.  Do we want the behavior to have Facter check if zfs is available every time the fact is resolved so that a persistent process could configure ZFS and have the fact automatically reflect this change in configuration?

I've already merged this change set in, so we might just want to change the decision tree in each of the affected facts.
this is commented out so i'm not sure why it's here.
This implementation concerns me in a couple of ways:

* `const_defined_on?` sounds like a side-effect free method up to now, but you're changing the behavior specifically to add side effects.  I think it's generally a bad idea to complicate an existing side-effect-free method with side effects if there's a different way to do it.
* I'm a bit concerned about the extra perf hit it may cause to attempt to get the const at each level of nesting, each and every time this is called.

If we're going to add this functionality, I'd prefer to see something more explicit in `ConstantMutator.stub`.  For example, we could add a call to `recursive_const_get` on the first line of `ConstantMutator.stub` to explicitly force the loading of any lazily loaded constants.
Thanks, looks like figured out how to update the PR :)
I think that `elseif` don't affect to readability and still beeing clear without to do an unnecessary check
The convenion is only one class per file
remove space between method name and openening parenthesis
true the difference is in that we are trying to do things without a system loading any extension, so basically just trying to put only the needed things to just get the yaml generation of the configuration of the bundle
@jails: Thank you, that was the explanation I was looking for! :)
This shouldn't generate a chunk nor load one as you would be in the chunk itself and it would be loaded.
You're right (it's done)
I agree with you on everything, except that Crossroads.js can be used on both server and client-side. Our [Knockout app](http://addyosmani.github.com/todomvc/architecture-examples/knockoutjs/index.html) is using Crossroads.js client-side.
In JS my example is in my opionion more clear, but I can't really argue about a language I don't know. Only nitpick anyway.
@ param   mixed \Doctrine\ORM\PersistentCollection ?

this seems wrong
This is way too much code, can you move it into a private function called by the constructor?
-noconsolecontrols option nezabranuje tomu aby mplayer reagoval na vstupy, neviem preco.
To co tam mam teraz je spomenute aj v manuale k mplayeru ako sposob dosiahnut toho co chceme.
@asm89 It is possible (the Security Bundle does it) but requires extra work. and it cannot be done by tagging a service. It would require registering something in the bundle class. For HWIOAuthBundle, I'm not sure it is worth adding this complexity as other bundles will probably not need to provide their own oauth provider config for the bundle.

But I'm thinking about a small refactoring of the DI extension to have a nicer way to handle it (I will work on it this evening and send you a PR, but it can be done after merging this one)
Aside from being consistent across all projects there is higher level protection in the py.test plugin that reads this tag. Basically if you don't mark it with nondestructive there is no way it will run on the production environment!
I merged everyones pulls into one so it might be that someone had  this in theirs
Why remove the app name from the import? Seems more explicit.
Why not just do list comprehension if you're gonna cast it as a `dict()` anyway? Also, you can probably just return it instead of assigning then returning on the next line.
ruh roh, whats up w/ this extra space?
Awesome catch, fixed
I would do this in the view instead of the form unless there's a strong reason to do it here.
(Call bullshit here if I'm wrong :) )
There are a few places throughout the app that we rely on the order of event execution being the order they are registered. This should not be an issue if explicitly registered in the thorax codebase as it will run before every custom event defined by the user.
This is so because `xcodeproj` is nil as there are no xcodeproj files in the current directory. However if `config.integrate_targets` is set to false an `xcodeproj` should not be required. If I'm correct, it only affects the `xcconfing` files that in this case I would generate as a convenience.

As related note,  currently `pod install` fails ungracefully if there no only an `xcodeproj` file in the current directory (dirname called on nil). I think that it should raise a pod informative.

I will change the hardcoded path (simply return the path variable) and return it relative to the `xcodeproj.dirname` if available.

> In general it’s better to add a fix in a separate commit together with a test to ensure we don’t introduce a regression regarding this in the future. 

gotcha.
@94m3k1n9 I'll look at setting it up as to future-proof that a little bit. The trade manager will have to do more to track trades but a framework can be put in place.
So does this mean we should be wrapping everything in media queries, even the "base" screen dimensions?
@ehelms ^^^
"version" should be "versions"
Or even just `var topic = new ros.Topic({`.
I see what you're saying, but the problem is that the most convinient API for coordinate-related tasks that we outlined before is not compatible with forcing units into the coordinates.  We *could* do it using some sort of clever `wcs`-like thing, but then we'd have to throw out all the work we've done on `coordinates`.   And I think, practically speaking, that would delay all of that for ~1 yr.

Put another way, `Coordinates` are focused on how you represent a point or points in spherical coordinates, while `NDData` and `Quantity` are about representing arbitrary numbers that may or may not have specific physical meaning (and it's the context that really determines that).

We may want to later change the internals of `Angle` to use an `NDData` object if that turns out to be the most convinient way of getting arrays in there... But the API as seen by the user still can't include units, so it can't directly subclass from `Quantity` or `NDData`
Why the blockquote? Also, `(3.x)` -> `(3.0.x)`.
Yep, it can be dropped, we never came to using it.
Nitpick: might be useful to let $asObject to true so that this call fills the in-memory cache (see https://github.com/ezsystems/ezpublish/blob/master/kernel/classes/ezcontentobject.php#L924)
That's the stupidiest name 've ever gave :/ .
The analogous code in master checks if scroller.clientHeight is nonzero. However, that breaks autosizing with the new scheme, because the scroller no longer has any children with content to prop it open if it's set to auto height. I'm not sure why the original code was checking for a nonzero clientHeight--I'm guessing it was to avoid doing work if the editor isn't visible, but this isn't doing all that much work anyway.
Maybe, but I don't think that should be part of this pull. Maybe when we refactor the feeds?
<pre>
15:05 grim_radical: kerminator: clojure (time (dotimes [n 100000] (pr-str "Hello")))
15:05 kerminator: grim_radical: "Elapsed time: 467.873541 msecs"
15:05 kerminator: grim_radical: nil
15:05 grim_radical: kerminator: clojure (time (dotimes [n 100000] (if (string? "Hello") "Hello")))
15:05 kerminator: grim_radical: kerminator at your service!
15:05 kerminator: grim_radical: "Elapsed time: 6.935672 msecs"
15:05 kerminator: grim_radical: nil
</pre>

...indeed, it's definitely slower!
So, after discussion, we stuck with IllegalStateException for this for the time being, and added code to resources.clj to catch that and return a 500 instead of a 400.
Yes, I added a test as well.
Is there any time you would execute readConfig without issuing a callback to do something with it? Seems like that should be mandatory, not optional here?
I think this would be OK:

```scala

@tailrec
private def scan(pos: Int, shift: Int): Option[scalariform.lexer.Token] = {
  if (pos <= 0 || pos > tokens.length) 
    None
  else {
    val token = tokens(pos)
    token.tokenType match {
      case WS | LINE_COMMENT | MULTILINE_COMMENT => scan(pos + shift)
      case _ => Some(token)
    }
  }
}
```
drupal-specific
you mean "not prevents" right?
even when i delete the last upload the screen doesn't seem to refresh..
Why? We don't do that for any other providers. There is a link in the doc.
This fixed my 404 error
```about``` needs a "must resolve to an instance of type ```Place```" restriction.
Не, с ошибкой не вывалится)
Let's remove all non -webkit vendor prefixed css. This only runs in chrome :-)
"There should be no implicit requirements before running feature"

That's why I made it explicit by putting it in the Given step in the background.

I agree with your point re. scenario independence.  I think the confusion for me is that I am coming to this from a background of using Gherkin to facilitate specification workshops, where the first thing you do is capture the preconditions that need to be in place before an action can be performed. 

I can now see that this is not the case at the code level.  At the code level you are 'put[ting] the system in a known state' - https://github.com/cucumber/cucumber/wiki/Given-When-Then

Very happy to lose the ENV VAR if you can provide an alternative mechanism for matching the uris.
I wasn't sure what was needed here, so thanks for the tip. I'll drop the `[MarshalAs...]` decorations.
... or repeat the module pointer below the heading... 

nevermind, for now I'm happy with the restructured reference

On 26.12.2012, at 13:36, Christian Brodbeck <notifications@github.com> wrote:

> In doc/source/python_reference.rst:
> 
> > @@ -198,11 +150,20 @@ Functions reference
> >  
> >     compute_proj_ecg
> >     compute_proj_eog
> > -   find_eog_events
> > +
> > +Detect Artifacts and ICA:
> Hm, this intermediate heading might make it ambiguous what module the following functions are from
> 
> —
> Reply to this email directly or view it on GitHub.
>
I think these should all be separated by a newline.
Set tab stops to be 2 spaces rather than 4.
Why use a module here? I won't just put the mocked up chrome API straight into the test spec file. If you think it is too big or likely to grow bigger, and you want to keep things modular, at least give the module an understandable name like "fakeChromeAPI".
We have to remove this for now - since the ResourceWatcher PR is still pending. We can add the note back later when it's been added.
I prefer to add `symfony/symfony` in an inline code-block, the same as we do with Composer packages:

    ... on the main ``symfony/symfony`` `Git repository`_)
We use the `expected == current` method in Symfony2:

    if ('' == trim($value)) {
never mind, it's a typo. i deleted it
Instead of having to override methods I'd prefer something like:

override def consumerConfig = ConsumerConfig(activationTimeout = 10 seconds, endpoint = "file://data/input/CamelConsumer")

That means that ConsumerConfig can be evolved in the future to add moer fields without risking method name clashes in the actor.
should we use ``behat:failed`` as label to distinguish labels used by behat from other labels used in the issue tracker for other purposes ?
En realidad, en el caso óptimo tenemos los datos de la postulación. Si tenemos un error no atrapado, no sabemos realmente qué lo causó, y cabe la posibilidad de que no dispongamos de esos datos.

Creo que si vemos uno de estos, ya luego podremos acortar posibilidades y sabremos que un error inesperado es inesperado porque es catastrófico.
Same comment related to your other pull request https://github.com/PrestaShop/PrestaShop/pull/67#discussion_r2303815
Also need to test that the redirect does not happen.
Please add explanation
shouldn't it be the task::log method called ?
Why did you remove it here? Shouldnt it still be the default?
A little web-pi is still hanging out in here.
Please use strtoul and if content_length_ is made an optional<size_t> this will handle sizes better.

http://en.cppreference.com/w/cpp/string/byte/strtoul
i dont think there is a self.context in this scope.
Per cluster node (maybe the wording per "Infinispan node" is better than "per Infinispan cluster node"). Your idea about DistributedTask implementing Future is very good. Let me think about it and see if there are any unforseen obstacles. Anyone else?
I pushed your commit as it was, although I think the chances of someone caring about VersionAwareMarshaller (and only VersionAwareMarshaller) trace logs are very slim :)
What if the cache is async ?
This will work fine and I don't think it makes much difference for a single cache manager, but if you're using multiple ones,  you can make stop procedure is quick, highly recommend calling `TestingUtil.killCacheManagers(cm1, cm2...)` which stoppes all caches before stopping the cache managers, which avoids rehash on stop.
SSH URLs aren't valid URLs.
Whoops, I thought I got all the cruft.  I will take care of that.
I'm happy to remove the new keyword, but I do feel uncomfortable about not being able to make a simple statement about how to disable it. Maybe, given that mpl has been around so long, such functionality *really* isn't needed, in which case, I could simply remove this line...
They do for me with Sphinx==1.1.3
s/selenium.open/selenium.get/
Hi, I tried to modify this. But I failed because this will introduce circular dependency for CMath and SGVector. Any suggestion for how to fix this?
verkoop in relatie tot ... iets in die richting zoek ik
Why not simply `$this->versions[] = $version;`?
Please also add a comma at the end of the last array item:
```php
'TITLE'     => $qm_ary[1]
 ```
should be 
```php
'TITLE'     => $qm_ary[1],
```
wow. Thanks for these. where's the embarrassed emoticon?
Fixed in new patch.
ahh good point.. i guess we'll have to differentiate between them in the list somehow
Is `#attributes` still around?
I know this line has nothing to do with the pull request, but why would the line be prefaced like this?  Seems like there's an error in the tests, unless it's a syntax I've never seen.
`"--chmod=ugo=rwX" if windows_client?` would be preferred here too.
This should be ignored by your chefignore file. This is for Travis, because it needs to know where to install the cookbook
I think you can replace lines 178-182 with:

    if INamedImage.providedBy(info.field):
        pf = info.fieldname
    use_blob = INamedBlobImage.providedBy(info.field)
Hardcoded path? Ugly! This should not be like this.

You can define HTML fragment in template, use CSS to hide it, and then clone it here from the DOM, and inject it whenever you want.
Dot at the end or not?

What now, do we have accounts or users? What are we linking?
Maybe it is slower, but it returns the right results. :-) So, what if some entry is missing in the database? One type of prediction is not made for one timestamp?

If you can make it better, please. :-)
`final`? Didn't we rename this?
You could maybe use something like [this](http://stackoverflow.com/questions/736513/how-do-i-parse-a-url-into-hostname-and-path-in-javascript) to get full URI from `resource_uri` and then compare that?
Well we have to have two forms. UserBasicInfo should be just fields for registration (alongside username and password). and AdditionalInfo are extends only accessable in account form. (we dont want to have avatar selection and other stuff in registration - registration should be simple (only required fields))
Personally I like the three-line version as cleaner, although I can understand the attraction to shorten it if there's a whole bunch (10+) of returns like that in a row. Even so I think I'd still go with the three liner, still easy to glance over / ignore :-)
we can directly coerce to int with `type=int` in argparse. See http://docs.python.org/dev/library/argparse.html#example
Also, it would be safe to recycle when going into maintenance mode.
I think there could be more details here to handle the exception because when the parameters we passed to the requests are incorrect, this command may not succeed. However, current logic would work, we just leave the customer to figure out what to do if something goes wrong.
It is generated normally, but I added this manually. We should switch to the generated version, but it will most likely be the exact same thing, only with "1.1" in the file name.
Space around "==".
don't put a space between `ngx_event_t` and `*`
nginx style is type on a separate line, which we've been doing here.

I'm fine with switching to google style, but that should probably be a separate style-only change to keep the history clear.
It’s a terrible name and `isDocked` would be perfect. Unfortunately, this method is being called externally by the plug-ins, so renaming it would be problematic. (But not impossible. I’m open to discussing it.)
You probably want to make ``h0`` a keyword argument, so the user can specify an initial guess if he wants. For a default you could use a rule of thumb estimation (Scott/Silverman) instead of hardcoding 1.0.
ну вообще можно ну ладно %) :shipit: потом
do we need the try/catch wrapping the whole example?
What I don't like, though, is that we could change the class on the spinner div and this test would pass -- or we could add a spinner div that *should* be present, and this test would fail. Is there anything that appears on the page only when it's successfully loaded?
if we have one of these for cli and app, should we have one for builder as well?
Okay, i'm glad this could be handled using shared_ptr
Mention at top: currently only linux, max osx supported - not windows?
Almost. If p1 is in the dict, it returns it. So it's a bit like get_or_create()
Is this spec necessary?
Looks dangerous: create() is called by the super-constructor, so all fields here will still be null.
Also, it access the `name` field but where is that ever set?
Why final? That prevents it being used/extended in ways that we haven't yet predicted.
I know that thread-safety can be much harder if you are "writing for inheritance", but is it worth preventing careful users extending this to avoid the risk of careless users breaking something?
Without the templates it's not very useful I think.
Why not return the Credentials result here and eliminate the need for `GetUserCredentials` altogether?

Like this:

    bool credentials = await authenticator.ConfirmPin(pin);
    if (credentials.Valid)
    {
        var session = new UserSession(credentials);
        var profile = await session.GetProfile(credentials.ScreenName);
    }
Where is that metadata? I'm not seeing it obviously on apps/local.
I think we should have a Predicate<Y> Predicates.transform(predicate<X>, function<x,y>)  probably should ping guava on this
and I have the opposite opinion.  The args and kwargs are not for the method itself, but to be used by the function that's passed in.  I'll rename the vars to make that clearer, but I think using the *args, **kwargs form here would be misleading.
Since GUIO_GAMEOPTIONS1 is a string (as all of our GUIO defines) that is not possible.
The point is there's got to be a better way than storing three independent strings in the object.
I'm fine with it the way it is, was just making an observation :smile:
mis-spelled "absorbs"
A test for that was already added in #12d4b971
Pentru prima conditie ar trebuie folosit <a href="http://docs.oracle.com/javase/6/docs/api/java/lang/String.html#isEmpty%28%29">isEmpty()</a>. Pentru a doua <a href="http://docs.oracle.com/javase/6/docs/api/java/lang/String.html#compareTo%28java.lang.String%29">compareTo()</a>.
this check is more complex than it needs to be.  You can simply check directly on the env var like so:
  if ENV["AEOLUS_CLI_CONF"]
I apparently did not receive the notification. stupid github! you may have to specify my name or the team's name I think
Какая-то кривая кодировка у твоего ответа.
со строчной буквы
We should make "all_tags_element" private.
This is perfect! Getting the text for the one that we know is selected (it is identified by the `.selected` class). 

It is a good bit of information to be returning as it should change depending upon which day filter is selected, but this method is not influenced by the data we are testing with (7, 14. etc days)
can you add a <code>_data_body_class =</code> property 
Even a empty one until the dev's add one
True. That was a leftover from something else I was trying. Removing in the next push.
I would return null instead of such weird signature. "No value" is not meant to be represented by ``false`` but by ``null`` (and it still works for your test above)
What? This is a very merry little message to bring joy to nerds that watch the console log! :-P
I've removed the reference to tsreader. It's not required for the NextPVR addon.
Why is all_bugs a global?
@ahojnnes  Concerning that point, I forked a version of scikit-image that was prior to the inclusion of bilateral filter. 
In order to compare both method I guess I need to `merge` or to `rebase` my branch on a more recent version of the master branch ?
Is it a clean way to do that ?
While you're at it... Can you get him to add sgemm too? :) Fused types would make it really easy to do stuff natively in single precision now, which would be huge for some applications.
I think 'asserted' is not correct here.
111111111111111111111111L ?