labofsahil/github-event-dataset-2012 huggingface dataset:
Não é uma boa idéia inicializar tipos mutáveis como parâmetros de funções/métodos. 
É melhor fazer:
def get_sample_publisher_dataform(dict_params=None):
    if dict_params is None:
        dict_params = {}
    ...
if (!empty($this->comments))
are you saying you want me to make it assert break_when_n_done > 0?

Otherwise, is there anything else bfore merge?
if `an_iterable` is an iterable, you should be able just iterate on it.
I moved it into a controller but then I couldn't get the boolean to return in news.html. This is only checking if there is a relationship between the two users. It isn't causing a page change so I don't think it needs to be in a controller. What are your thoughts on this?
Not sure this really is relevant here - perhaps a section about differences between tinydns and this backend?
Please provide some arguments here on why this is necessary. Use of `ABC` as label provides global look-and-feel, and it applies to non-Latin keyboards even to Chinese keyboard. Arabic shouldn't be the exception here.

iOS also follow this approach.
I AM 12 AND WHAT IS COPYRIGHT
For example:

https://github.com/symfony/Yaml/blob/master/Parser.php#L13

https://github.com/symfony/Yaml/blob/master/Parser.php#L45
Ok, that is cool then, I'll merge this in
Правильнее new Date() вызывать, чем создавать Calendar, а после из него Date.
А для чего эта проверка?
In any case just checking the length merely checks that the title is present, rather than checking that it's correct.
let twice? Please keep const.
Here, we could create a new helper function which takes the two functions as arguments:

    def foo(func8, func16, image, selem, out=None, mask=None, shift_x=False, shift_y=False):
        selem = img_as_ubyte(selem)
        if mask is not None:
            mask = img_as_ubyte(mask)
        if image.dtype == np.uint8:
            return (image,selem,shift_x=shift_x,shift_y=shift_y,mask=mask,out=out,p0=p0,p1=p1)
        elif image.dtype == np.uint16:
            bitdepth = find_bitdepth(image)
            if bitdepth>11:
                raise ValueError("only uint16 <4096 image (12bit) supported!")
            return _crank16_percentiles.threshold(image,selem,shift_x=shift_x,shift_y=shift_y,mask=mask,bitdepth=bitdepth+1,out=out,p0=p0,p1=p1)
        else:
            raise TypeError("only uint8 and uint16 image supported!")

And then just return:

    foo(_crank8_percentiles.threshold, _crank8_percentiles.threshold, ...)

Better maintainability if we need to change something at a later point.
I don't think this is a bug, it is an undocumented feature ;)
Maybe adjust the docstring accordingly?
"analysis of" or "analyzing"
a `transformer_weight` option to give more importance to some transformers could be useful!
@mblondel OK if there's a parameter query_id={False, True} in the function call to turn on/off the output of the query_id vector (possibly empty). Otherwise you would have a method that returns a different number of parameters but you wouldn't know that number until the function returns, IMHO a bad idea.
actually, this looks wrong, it should be a boolean and not a string, e.g.
:facts => true, vs :facts => "true"
Maybe make this into a constant with a comment to this effect.
By performing the call inside a fork, anything that gets modified occurs in a separate process, so any expected effects don't happen in the calling process.  I suspect the following will happen:

```ruby
a = "foo"
grep_stdout(/.*/) do
  puts a
  a = "bar"
end
puts a

# Expected output:
# foo
# bar
#
# Actual output:
# foo
# foo
```
You will get all the content with `#readpartial`, but it doesn't guarantee that the output will not be separated in the middle of a line, which will break the `grep` call.  This is because `#readpartial` has a max length.

To illustrate this better, suppose that we used a max length of 10 and did the following:

```ruby
$stdin.readpartial(10).grep(/string/)
```

And the following output was piped into the process:

```text
This is a string.
Also a string.
```

These are the strings that successive calls to `#readpartial` would get:

```ruby
"This is a "
"string.\nAl"
"so a strin"
"g.\n"
```

As a result, you end up with just the output:

```text
string.
```
This is not up to date. Please update it with a line for each command like the following:
```
build  --type TYPE --project_path PROJECT_PATH --ndk_path NDK_PATH
run   --type TYPE --project_path PROJECT_PATH --ndk_path NDK_PATH --ip_address IP_ADDRESS [--device_password DEVICE_PASSWORD]
```
Actually, a better solution would be to create an OptionParser for each command like we were doing with the sub-parsers. Then they could have their own usage and required options. Also then we probably wouldn't have to manually enter the usage text. Please give it a try.
Should be blackberryNdk instead of blackberryndk
This needs casting back to a memsize_t (for 32bit systems)
You could make this function more efficient if there were multiple quote characters, but I don't think it is worth it.
This should check sscanf returns 2.
Oh, I see, the last is the default case. That's kinda tricky, but I get why it's this way. I was expecting it'd return null (or similar). We have to make sure the docs are clear about this.
Here is the contribute plugin call
What does that mean?
It looks like a loop. If `promise`is resolved, try to resolve it again?
Still thinking of better names. Or inverting it so the instance of T comes first (if that's even possible to write in C#)

    "foo".MatchesAny(predicates)
Also it should be 'does not match'
I changed it. It is done with the domXML() function which set the default value to true within the designer and does not change the default class.
i tried and not match. Waiting...
The :app_env and :rails_env have equal values. IMHO use two similar variables isn't good idea. Therefore I have removed :app_env variable and put this code inside this block.

FYI: I have found other solution of this problem in other fork (but don't test it): https://github.com/pivotal-ghostchips/capistrano-resque/commit/fc68b6093a24cd5b1259f427ee79ae40d7b40821
I think this is a weird error to show users, since it actually *is* implemented ... we just can't determine something to exclude.

I think we should define a custom error like so and raise it:

```
class CouldNotDetermineValueOutsideOfArray < StandardError
end
```
too funny... that code has changed a number of times.
_zoomWheelHandler for consistency with the other handlers?
It removes clutter.
Y轴反转应该合并到输入控制设定中去
use path.join here and below
default: 200 ms. in Release 2.1.1 and later. Platform-specific default in earlier releases.
Ah, indeed. I was thinking about this but at the time there was only 2 methods so it didn't worth the hassle. Fixed
this could be merged into a else if, instead of an else containing an if
Should this be a relative pixel size? 0.875em or 1em?
i don't understand this. it is constant for any class instances, why does it need to be constant across all children too? if this needs changing, feel free to write toolchain from scratch
I think you're right, changing the type parameter from '? extends OpenmrsObject' to '?' doesn't cause any compilation issues for existing code depending on the module, i will make the change
Bit crap...
Don't make `opDollar` a property.
That's kind of an artefact from the previous alignement edit.

It *was* (IMO) cleare before, but may not warrant a line break anymore.
spaces around operators please
Since the bodies are so different it would make sense to define two functions with different constraints.
Generated documentation should not depend on the platform it was generated on. People looking at dlang.org will probably think that `expandVars` is *always* an alias to `expandPosixVars`.
Why do this? `str[0  ..0]` works just fine, and with ranges in general, you need to use `range[0 .. 0]` rather than `range[$ .. $]`, because there's no guarantee that the range overloaded `opDollar`. strings obviously have `$`, but I'd argue for just keeping them consistent with ranges in general and return `[0 .. 0]` and not `[$ .. $]`. I see no benefit in this change.
UDL suffixes will work for C++11 only, why did you change the c++11 style back to "classic" assignment style?
+1 That seems like a very reasonable initial set of checks to me. Some good coding practices without too much noise.
I disagree...

The original is "... on the web", not "... about the web". So, I think that the best translation is "na internet" and not "sobre a Web".
Care to factor these long lines so it's not quite as long?  Other than that, looks good to merge.
Why `5`? Could this test be easier to read with `2`?
Idea doesn't like me removing the version
Move the `.reverse` below from the Ruby/Rails layer into the DB layer.  See http://guides.rubyonrails.org/active_record_querying.html#ordering

    @registrations = Registration.all(:order => "time_end DESC")
you should not inject the full container but only your dependency (the router in such case)
Usually having UT relying on one another is not such a great idea as if you disable one, or if something very specific is broken everything stops working. Also, maybe we want to test something else other han a simple happy path...
How about let's call it HttpContent because Content is too generic a name.
Why has this moved? Do we need pry on production?
The incompatibility thing was something I had actually noted as a caveat in the original commit for this, so I am perfectly aware of it.  My suggestion might have been to have created a separate major release the captures this, if not a branch altogether.  It is regrettable, but I don't think statics for configuration are in any way ideal.

Good catch on the ``attr_reader :configuration``!  That is technically not needed and should be dropped.  I apologize for this.  Good on the code review process.

As for the initializer, this is not strictly needed.  In fact, if you look at ``Messaging::Client.configuration``, it makes explicit notice that like ``Messaging::Consumer.on_message`` that such a method is not implemented and needs to be implemented by the user.  Because, in your example, you made use of this identical configuration in multiple places, I had simply wanted to inject it via the constructor.  There is nothing preventing one, by way of ``Messaging::Client.configuration`` for instance on relying on the old static behavior.

Is this reasonable?
Can you change the title to just "Code Adventures"?
Bit of minor feedback ... more as an academic point than as a legitimate issue: don't forget about duck typing, e.g. someone might pass you a TonyHash or something that acts like Hash but isn't. So:

if something.respond_to?(:[]) is the kinder check to perform... but it's academic since it nobody will probably pass you anything but a Hash or filename.
http://de.wikipedia.org/wiki/CSV_(Dateiformat)

Visualisierung würde ich dann im Excel machen!!
should capitals be used in metric names? sessioncurrent -> sessionCurrent
or perhaps use underscores? sessioncurrent -> session_current
missing space before the `{`
The only assertions here should be that the test is created, that it has no steps, and the warning.
same for 'productversion` vs `product_version`, actually
Stylistic nitpick: Empty line between module declaration and imports.
I'm looking at a sideview diff.
Why not add these methods as overloads? Then we don't alter existing public API (which is important for compat and other reasons) and it remains easy for people using the default Azure instance.
Fixed globally
Same as for parsing files.
Could you add a space before "=", and maybe rename "CG" (code generated) to "RG" (route generated)?
カラム名が書いてないと、何番目が何の値か分かりません。
Actually, this is a bit logic-y, I'd probably move this to a method on InventoryUnit, then you can do ```inventory_unit.disabled?```
docblock is missing
parameter should be type hinted as ContainerInterface
I think this could extend LzoBaseLoadFunc. LzoBaseLoadFunc is misnomer (it is not lzo specific), but has lot useful stuff commonly used in out loaders.

It is the LzoBaseStoreFunc, i think can go away, I was mistaken on our chat.
remove the parameter for this method, making it `eligible()`
The constructor should take a TextReader instead of an array of bytes.
I'd rather use ```^ro.pa.version=$V.*``` and replace ```export V=9``` by ```V="PARANOIDANDROID"
left align the text and add an disclosure indicator. That will give a visual clue that this cell leads to a different screen
Zoals je kan zien staat deze hieronder in de foreach loop die er al stond.
The same here, we should test:

Then I am outside the system
shortcut:
```ruby
Array.new(options[:plugins]).each do |plugin|
```
in slideshow ba zepto kar nemikone :(
This is ***BULLSHIT.***
Tabs vs. spaces makes this look weird. Please use 4 spaces.
Added it :-)
We may want to document this workaround for the known android bug. Make it clear why we are testing keyEvent for null.
The message contains the type, so you can use $this->getBackend($message->getType())->publish($type, $body);
`-implementation` is generic, `-backend` or something might be better suited for the current use case, but more specific.. I don't think many people will use that and I'm pretty sure they won't follow whatever this package sets as a "convention", so don't sweat it too much :)
Интересно, что лучше поставить здесь? Для лисы можно использовать свойство `mozHidden`. Что делать с остальными браузерами? Предполагать, что тред сразу становится открытым?
but if you look at our geolocation test under the HTML tests on the test app you will see that it pops up the dialog 20 times.
do you mean do three different tests for the three modes
external image?