labofsahil/github-event-dataset-2012 huggingface dataset:
I realize this code predates this commit, but regardless, let's take care of it:

If you're going to throw an exception, don't throw Error and don't throw new XXX period without some really great reason.

This usage is simply an assert. Using assert allows it be managed uniformly with other assertions and prevents it from getting entangled in the rest of the logic of this block (it means there are only 3 cases in the if/then/else instead of 4, which is a benefit.)

assert(sym != NoSymbol, "...")
That's nice, btw. More regular than before.
I was actually thinking it might be useful to also have a class corresponding to each hash function which is mutable and allows cumulative hashing, as is the case with the old `MurmurHash`.
Whatever we call it, it is important to Scaladoc it well enough that someone doesn't need to read the source code to know which throwables are caught.
Oh, I see.  There are examples of this at http://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.lfiltic.html and http://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.lfilter_zi.html  

So if a function is in the same file, it should just be a link like `function`, and the namespace should only be included if it's in a different namespace?
I agree that it's nicer to have the actual code and error message naturally in the code. 

It's unfortunate that this generates a doctest error - I think that this trumps aesthetics.Maybe someday we'll have a more clever documentation doctester.
ahh yes. I understand the intent of your comment and you are right. Instead of doing a straight comparison to the True one could make the True the second arg of `fuzzy_and` as

```

>>> fuzzy_and(True, True)
True
>>> fuzzy_and(1, True)
True
>>> fuzzy_and(None, True)
>>> fuzzy_and(0, True)
False

```

and `fuzzy_bool` could be used to safely turn anything into a bool value: it returns None for arg=None else bool(arg).
Ah, thanks.  Got it.
imports at the top of the file, please
I'm considering the possibility to avoid expanding generators here.  It will make the last `elif` branch of this function slightly harder to follow, I think.   I'll try this shortly and will report here.
> You shouldn't abuse Dummy like that, it **will** cause you trouble.

Could you be more precise? Is it performance concerns? Or just that
this should be done like in Symbol? Why?
调用StringEscapeUtil.escapeURL时，加入encoding参数。
Better to call it `getBody()`, because not only POST request has the body.
NULL added here: https://github.com/php/php-src/blob/master/Zend/zend_builtin_functions.c#L1818
It is not included from any headers.
We're checking for WS_POPUP, which is a generic window style that isn't necessarily full screen. We can only assume that WS_POPUP windows are the fullscreen when we're in the game client. Let's ignore the fact that CLIENT is pretty much always defined in our code :/
Strictly this doesn't belong into this feature branch / pull request, but it's needed for the folder_view.
I think this line warrants a comment or some descriptive temp variables.
Not sure what you're asking here. Are you asking if we're already sure threadNum isn't 0 by this point?
This should be `"You can only unload a loaded, non-dirty record."` (note the comma and hyphen).
With the defaulting above, this is going to need to be `if @only && !@only.empty?` — same with the `@except` one.
structur**e**!
desable => disable
maybe break "check the version of an index" and "build an oldstyle index" into different sections just for clarity.
No edit to make here but this is an important point which may deserve a callout.
MongoDB with journalling *will* likely double the amount of VM required
why keep this file at all?
May be undefined?
I'm guessing either for those servers where index.php is not configured, or for situations where index is not index.php (portal? blog?).
Someone already asked this on IRC. I'm just doing what is already done in the posting page. Otherwise, we get questions when people notice that every time they submit a post from quick reply there is "#preview" at the end of the URL. Sure it doesn't hurt anything, but it's unnecessary and inconsistent behavior to what is already there.
Should there be an assertion that you actually received a login form in the response?
these are extensions, as mentioned above, this should be EXT_ and not MD_
s/unarchive/unpack?
Don't the language files define this anyway?
This must be changed to make sure the `_pluginPath` is UNDERNEATH the `DEFAULT_CUSTOM_PLUGINS_PATH`, otherwise you can pass in a path like `/bin/sh` and `path.join` will come out with that.
Perhaps a sleep and retry? Probably nothing to worry about for now unless we see it in the wild.
What's with the z?
L-am pus:) 
https://github.com/rosedu/wouso/commit/8feb54f7a495dacbb277c0d483413e4ffc04367b#L2R232
Please make sure to use the same standard property order as all the other parsers. Whitespaces are also relevant.

```
#disclaimer
  ...


#domain
  ...

#domain_id
  ...


#status
  ...

#available?
  ...

#registered?
  ...
```

The same applies to the Ruby parser definition.
Slick. Probably overkill but it might be nice to extract as a reusable function:

Y.mojito.loadSync: function(name, path) { ... };
same sync load logic for loading the store.
Для одного запроса можно не делать START TRANSACTION и COMMIT
I see that the 8.6.8 release is on sf now. I'll certainly fix that.

I vaguely remember there being no tarball release for 8.6.7 when I was upgrading. 

Curiously, ascidoc is written in python, so the only additional dependency is mercurial, right?
Either is OK... but I think there's a preference for the extra "s" in British English.
I think the exception being raised is not a problem but a symptom (probably just semantics :-) ). The underlying problem is that linear is changing the input cube. It happens to change it in such a strange way (due to a numpy bug, as you correctly point out) that the data and its mask are different shapes, so that ```str(data)``` or indeed ```data == orig_data``` will raise an exception. I agree that adding a shape comparison will not really add anything, but I propose you test that the cube is unchanged. This is a stricter test and enforces the behaviour we want from ```linear```.
Shouldn't that be ```t_last = cube[-1, :, :]``` ? 

Otherwise it's just the <i>second</i> time slice, not the last.
连续用到的变量，先做一个临时引用
var customEvent = conf.customEvent;
这个方法应该是地图自身的一个方法。
declare local function as static (in the plain old C sense)
The documentation consistently uses the term `startup action`. Might worth using the same term (vs. just `action`) in these fatal messages?

http://voltdb.com/docs/UsingVoltDB/RunRestart.php
zzz?
meh, loops don't create scopes, this can lead to stupid bugs i've encountered already.

but it can be shorter with prelude-ls. `keys(files) |> each (language) ->`
This is deliberate -- otherwise we have a 'chicken and egg' situation. In order for get_user_model() to run, you need to have the app cache parsed; but the app cache can't be fully populated until all the models are loaded.
I think this could be turned into a do .. while loop as the first statement is always a raw_identifier. Also consider including eof() in the while condition.
This is a bit unclear. Please replace it with something like this:
<pre>
# job_id is always assumed to be the first argument passed to the task,
# or a keyword argument
# this is the only required argument
</pre>
Care to elaborate? Is the style too goofy? I can introduce an explaining variable if necessary.
I did a quick look when i was trying to solve the "`$('<div>abc</div>')` has a parentNode" problem in 1.8.1 and just decided the whole method was too far gone to clean it up until 1.9. Since the `isDisconnected()` method doesn't return `false` for html conjured from strings, it doesn't have its intended non-effect there--but why should it be a no-op for that case anyway? Also, it's one of the few methods that do a *conditional* `pushStack()` which seems totally wrong because you can't reliably do `$(selector).find(something).replaceWith(content).end()` and be assured you're in the right place. Finally, it only accepts its first arg as content and not all its args like the other ap/pre-penders, although that could be fixed by passing `arguments` instead of `[ value ]` in this patch. Plus Rod's bug. So yeah we need much better test coverage here.

In general we don't reliably support anything but `nodeType===1` in collections do we? If it works on other node types that's great, but if there's extra work required to support replacing comment and text nodes I'd prefer not to do it.
This is an issue that we went back and forth on.  Sometimes, the math is very simple when coef is a vector, and sometimes the math is simple when coef is a matrix.  We ultimately decided to leave coef stored as vector, but cast it into a matrix when it simplifies the math.
Elsewhere in Ninja (and I think in Chrome too?) we never use mutable references, only pointers.
I guess the real question is, should meteor provide a native way to fetch data from other services with signed oauth requests or does meteor want to just allow for authentication and let the developer use a package to handle signed oauth requests. Personally I'd love for meteor handle the former. Just out of curiosity, how do I make a request to another server from meteor? Is there some request api on the server side so that I can make an http request out?
This was moved to `fjord.base.middleware`
Do any parts of this work without this module? Or should it be declared as an external dep?

```rb
depends_on 'Chipcard::PCSC::Card' => :perl
```
Check line 440, `makeURLAbsolute()` makes this obsolete.
Might be worthwhile providing defaults for `monitor_loop`, `window_size` and `flight_lifetime` since it won't be obvious what reasonable values are (obviously they are aggregator dependant though). They should also be documented in the class doc string.
This function signature is confusing me a bit, why allow for `rkey` to be specified if this is `dispatch_inbound`?
Uh, did you test the performance impact of this?
This doesn't make sense to be here.
NameError: There's no such thing as `self` in a classmethod.
Instead of just "subreddit", could you include the /r/name of the subreddit here and for the listing below?
That's an assertion I'm not so sure about.  It's 25% more memory per node, and there's no iteration order guarantees required here.  I can do it, but neither I, nor a bunch of the team, feel that the case is quite as strong as you're arguing here.

Having said that, I"m not opposed, and I"ll make the change... I just am not so sure about the intensity.  Maybe you can rant this at me over a drink later, and I'll just put in LinkedHashSet for now pending clarity.
Well... only sort of... best case of one configuration (codegen falls back to reflection) may well have a logged exception from the code-gen provider.  I wonder if we shouldn't actually gather and log/throw all of the errors if we throw at all, so you can see.  'cause if there's a missing $InjectAdapter, it'll log Level.FINE but that's really the problem.

That said, I don't know if I want to allocate storage to store exceptions where it's not needed.  *grumble*
Actually it is '--columns' for podtidy.
Indeed JDK 6 javac compiles it (using -source 5) but JDK 5 javac does not; bug in JDK 5 which ecj perhaps copied. I submitted: https://github.com/KentBeck/junit/pull/403
The `super` has to happen first, which will unset `@node` and `@placeholderNode`, but in this case, we need to keep a reference to them so we can destroy them after the `super`.
log the error too? :)
I don't see this being applied to anything? I think it can be deleted?
These comments are no longer true
The old code stripped the project root path off of the beginning **and** the final slash off the end. The replacement code only strips the trailing slash.
You can specify this in 1 property:

padding: 3px (@triangle-size * 2) 3px 0px;
Any reason you removed the checks for minSize?
you should use
util.replaceStaticPrefix(css)
to replace the static prefix
Uses and declarations are already maintained here: https://github.com/ajaxorg/cloud9/blob/master/plugins-client/ext.jslanguage/scope_analyzer.js#L268 so why do that again? On the Var(...) node you should be able get the current scope (`node.getAnnotation("scope")`), from which you can fetch the `Variable` object, which has an array of declarations.
Does not matter, if it does not contain `http://` it will still display just fine.
Oh yeah, forgot that we usually do full path names, which I don't have a problem with.
I decided I didn't care. _id is probably the right thing to use in python
world


On Wed, Nov 14, 2012 at 12:56 AM, Biyeun <notifications@github.com> wrote:

> In corehq/apps/commtrack/helpers.py:
>
> >      """utility function to register 'verified' phone numbers for a commcare user"""
> >      u = CommCareUser.get_by_username(username)
> >      for phone in u.phone_numbers:
> > -        u.save_verified_number(u.domain, phone, True, backend)
> > +        u.save_verified_number(u.domain, phone, True, backend._id)
>
> are we going to be consistent with get_id or _id? Mike was pro get_id and
> Cory complained earlier that _id was being used.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/core-hq/pull/235/files#r2120537>.
>
>
sorry didnt add it where I expected
```javascript
if(typeof cb !== "function"){
    //the pending block
}
//else is on next line istead of the same line
else {}
```
There are two different problems.

1) The sample based beta tests wait for a fix.
2) The tests for insured losses need new data from a reliable implementation (as it is changed the algorithm and the expected output).

I would remove such tests instead of keeping such dead code. What do you think?
What are these too doing here? There should not be any dependency to them right now (before the SQL Console / beanshell import from master that @nicolas-f is currently doing)
This looks like an error, I think they should go for now.
我不小心多複製到的QTL
sorry
You should test! So if there is nothing in `next` or anywhere (if person just opens URL directly), what happens? It should be redirected to some configure URL. No? It is?
???

I think there was some misunderstanding here. ;-)
OK. Better. But for the value you will want a bit better. Check how it is done in nodewatcher.

```
{% with next|default:context_processor_next|default:request.get_full_path as next_url %}
```

So we allow three values:
* from context
* from context_processor
* from request

(In this order.)
I guess I have to use fields.py and extend mongoengine.StringField? Or do you mean to just add field arguments to mongoengine.StringField in models.py?
No, |0 to get it to be an integer always, and 0 if it's anything else.
Do you need to do this here again? `default.js` calls `createTitle` explicitly.
also _element = null;
See https://github.com/mozilla/butter/pull/1015/files#L1R819
This spacing is definitely wrong :P.
As I mentioned before, the example.jade page isn't currently being used. I only have it there for reference. In the future, I'm going to turn it into an example page for users who aren't logged in (hence the file name) so they can see how napkin works. That's why it seems like this form is being used multiple times even though it's only in the actually served page (index.jade) once.
Let's remove this line: there is no way to get details for DSK-354448
Remove the '#if' and '#else'-block. the reason is: e is not serializable (due to stack information?) and postMessage will fail (for B2G or not).

Let's address this later. Or you can create UknownErrorException class similar to InvalidPDFException.
This breaks on Python 3.
See http://docs.python.org/3/library/json.html#json.dump
I guess you meant your repo on github? :) https://github.com/ekdevdes/SJNotificationViewController
Not an InvalidArgumentException. Make an IOException or FilePermissionsException or something
Why do you need to do the tr(' ','_') ?
```ruby
context "loading a serialized Money via YAML" do
  it "uses BigDecimal when rounding" do
```
`var Term = function term(phrase, freq) {`
I think 10MB is too specific. Perhaps instead of a flag on whether to shrink or not, perhaps a flag on what size to shrink at (with zero meaning never shrink)?
Yep.

Em 03/07/2012, às 22:27, Mark Story
<reply@reply.github.com>
escreveu:

>> @@ -301,6 +301,22 @@ public function testPutParsing() {
>>    }
>>
>> /**
>> + * test parsing json PUT data into the object.
>> + *
>> + * @return void
>> + */
>> +    public function testPutParsingJSON() {
>> +        $_SERVER['REQUEST_METHOD'] = 'PUT';
>> +        $_SERVER['CONTENT_TYPE'] = 'application/application/json';
>
> Shouldn't this be `application/json`?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cakephp/cakephp/pull/702/files#r1097862
spaces are required around operators.
This is pretty subjective, but I don't really approve of commenting out a method and leaving it that way. We have a code history. If you don't want that method, I'd just delete it.
On Wed, May 9, 2012 at 2:12 PM, Brian E. Granger
<reply@reply.github.com>
wrote:
> Trying to keep `_` out of filenames.

Just curious: why?  I actually find that some of our filenames are too
long to read with out `_` in them... PEP 8 explicitly says:

"""
Modules should have short, all-lowercase names. Underscores can be
used in the module name if it improves readability.
"""

Which basically means: if short, great; if it's getting long,
underscores are explicitly OK.  For example, looking at some of our
files, I much rather prefer

_process_win32_controller.py

to

blockingkernelmanager.py

because I can actually read the former, where as the latter is awful to read.

So let's follow PEP8, and use underscores judiciously when they do
improve readability.
I think we can change both to 'call signature', then. That's actually more accurate:

```
In [1]: f = lambda x,y: None

In [2]: %pdef f
 f(x, y)
```
I wouldn't pre-emptively set `__class__` - that could have all sorts of unexpected effects.
looks good to me.  this line could be removed, if you like. 

There are a lot of merges in the pull request, which is odd.  I think you should be able to just rebase the branch on top of master -- `git rebase -i master` -- squashing both commits together while you are at it.
please put ordering of builders consistent with other code like Tag

https://github.com/jclouds/jclouds/blob/824ea1fd0a25fdd825abd89927d875f358d4a69f/apis/ec2/src/main/java/org/jclouds/ec2/domain/Tag.java
Under the hood this will use chai's assert.deepEqual which is a type+equality check .

So for example:

````js

assert.deepEqual([1], [1]); // pass
assert.deepEqual(['1'], [1]]); // fail

````

I actually found this by using the assertion to verify the parse results.
How about just `return $method == 'POST'`?
As Swee points out, it's not possible for a race for tasks executed by the engine. However, there is one way we can have a race: direct cancellation of the task by the user. Ultimately that cancellation should probably go through the engine. For now, we should give this code proper treatment for concurrency.
Please just write `self.class.human_enum_name(attr_name, self.send(enum_cd)) unless self.send(enum_cd).nil?`
Added one line each to specify the additional marker (tip).  The left, top and id do not differ according to platform, because, this market sits invariably at the same position, above the screenshot in all the platforms. Hence, the position is same for all platforms.
If I recall correctly, the video CDN url was hardcoded into the swf file for security reasons.
haha, DANGER DANGER DANGER!!!!
missing `_()` here too
We do not need this case. Simply ensure that if an error condition has been met the following two cases will be executed. Otherwise the return statement at the end of the method will be called.
missing comma here ^
If we are renaming files we can make this title the same as the filename. So not to have Changelog in CHANGES.rst but to make this two the same word.
I'm using `.css` here as I now can know that the style attribute has a width set. Equally viable would be `.width()` here.
seems logical to me

    W _ _ W
    X N N X


W = water, N = netherrack


also it's generally not a good idea to change basic functionality like this and call it cleanup, it deserves its own PR
I would write here

    if (val != null)
original code doesn't do a manual hoisting, so don't change the style.
is this a hardcoded logcat limitation or something?
I dont think so because the it only list the params that are missing. If its after mandatory params it would suggest that it list all required params.
UnexpectedTypeException is also thrown.
This could be simplified:
```php
$start = $end = 0;

if (null !== $start && is_integer($start)) {
    $date = new \DateTime('@'.$start));
    $start = $date->getTimestamp();
}

if (null !== $end && is_integer($end)) {
    $date = new \DateTime('@'.$end));
    $end = $date->getTimestamp();
}

return $this->storage->find($ip, $url, $limit, $method, $start, $end);
```
Thanks. PHP-CS-Fixer looks really useful. Ran it and pushed.
it does not matter as the HeaderBag is normalizing the header names
Do I need to remove it or I can leave it. I've added them, because I find it easier to read.
@stof ah yeah forgot about that, thanks, good point @schmittjoh
I'm not sure that using fully qualified names is so much better than doing `from ... import ... `.  I'd recommend following the strategy of only doing the modifications which are really needed only, but others may disagree.
for all public interfaces here: include return types. it serves both as (in code) documentation and it also fixes the types, which is important; otherwise refinement types may be exposed unintentionally, causing API conflicts later:

  http://twitter.github.com/effectivescala/#Types%20and%20Generics-Return%20type%20annotations
Should be a model of CDigitalOrientedShape  (hence isInBoundary and operator() based on the shape method orientation(), ....)
A user who didn't configure Cacti at all will have no error because they won't have the configuration in their agentConfig (or it will be none) and they will hit the `return False` two lines above the line you commented on
I don't think this needs to be virtual, does it? It's not in the public ImageCache interface.
Ah, ok, fair enough.  I will merge the error printing stuff, then you can make a second pass on this if you want.
This is a problem. It stops users passing through transform instances. I will fix this in #106.
I didn't do that because I want to add dot notation later, so we can reverse to child parameters of objects. it's proven to be super valuable in asyncBuilder's actual usage
print statement just go to heroku logs

if `function` get several argument , i just run the non-cached function not to crash the website...
then i can just look at the log to see what went wrong.
This could be 10995, saving 5 ids.
I agree with you and don't really have an issue with the way it is currently and like you said the big stack traces make it obvious that some things has gone wrong. Just thought that the task might be a way to get more familiar with the code base and that this was something that had be decided to be implemented.  
Could you add your comments to the jira (https://issues.jboss.org/browse/AS7-1189) as perhaps reject it?

thx
This function will try to 'normalize'  text (removing accents and special chars). For emails won't remove the '@' or the '.', which means that will match any string containing thouse.

Perhaps we could remove those chars from any searchable string, what do you think?
Filed bug: https://bugzilla.mozilla.org/show_bug.cgi?id=775576
That hack has been since replaced by *real* Web Activities. Check with @fcampo if in doubt though.
Oops, I find my typo.
What happend to landscape orientation here if no longer listen to resize?
In persona dialog case, with keyboard showing up.
can we have a comment here indicating what is this animation and why is needed. On the other hand a more descriptive name could help, something like 'dom_animation_end' or something like that
if (...) {
      } else if ( ... ) {

brackets is required if you use `else`.
totally out of scope for this, but perhaps we should have polls timestamp every response automatically ?
can share code with GitFetchHelper
damn! you're right ;)
This is separate functionality with ESX system installation and not involved in OS installation.
Ah!  I missed that - that makes perfect sense, of course.  :)
We just discussed this, but for the record, I want to try using the ipv6 library's IPv4 Address class for this.
Wow, this all reads much better now.
The game controllers `destroy` calls the `destroy` of the game loop controller :)
Well, the key thing on SmartOS is to avoid PATH mangling, because PATH is set correctly, and /opt/local holds all the software RVM cares for in this case (e.g. GNU tools). I'll give this another thought.
You are correct; I fixed it.
And array() in here (and in all the following functions).
Much nicer, ain't it?
Yes, but I'd rather keep it this way for now, it could use some refactoring in the future.
These pickles should never be changed.
We convert php notices/... to exceptions like in sf debug, it's just way easier to manage things that way.
``elseif`` should be written without space according to the Symfony2 CS (which are used in Composer)
Done, using ExpressionRewriter as suggested below
If it's a plugin, you can't store the data in the main schema
Should I put an outer <div class="row"> for <div class="span12"> ?
I'd say define instead of register.
I think removing .json string files is a great idea. We'll want to make @fetep aware of this, as he may be able to improve how he updates l10n preview, since these language files are no longer in the main browserid rpm.
It will be a normal variable, but you're right -- the const isnt as important as I thought it would be here. I think this was just habits from C++ but I'll change this :p.
Given that we do not plan to put any content in this node please use the short version without a separate closing element.
I like the idea of a subnamespace, like the validation constraints in Symfony2 (`Constraints\[NotBlank|Unique|..]`).
Getting rid of this duplication is very nice!
It needs to be `self.up` and `self.down` in order to work under rails 3.0.x.
this is a breaking change. you need to still bind to html.
La frase ha poco senso con `il namespace del modulo`. Cosa intendevi?
give or be? :)
`scriviamo il seguente codice`
Please move this to styles.
Yes, instead of adding the component in human, add it onPlayerJoin in VanillaListener please. :)
[Sometimes it's okay to put an if/for/while with a small body on the same line](http://www.python.org/dev/peps/pep-0008/#other-recommendations)
Rather than having a completely different constructorDataParsers, I think in most cases it would likely just use the _same_ decode/encode as the factory definition. So, no need for a constructorDataParsers parameter - rather,  the copy(value || {}, this) would use the  decoder passed into the resource factory.  So:
function Resource(value)
   copy(dataparsers.decode(value, 'constructor') || {}, this )
}
why does this need to be here?
In any case, `GenDict.extend` was only an example, `GenDict.put` could also be written as `GenDict.Dict.Record.put`.
`field.value.email` is not an array. So would be either :

```jinja
{% if field.value.email is not null %}
```

or

```jinja
{% if field.value.email %}
```
OK, tak nechaj takto.
This looks pretty fugly. I realise you do this for the default -1 option value, but isn't there a more clean way? The default value should be the base case, no? All negative depths are now treated in the last case, while they're probably the result of a typo, i.e., adding a - ?
spaces everywhere = and ,
I'm using 2 spaces for indentation, could you fix this so the code is properly indented?

I'd like to merge your code, thanks!
Can this be trusted?
I agree. I think the overview needs to be removed or made clear that it's an overview. How about this:

This quickstart takes the following steps to implement EJB security:
1. Define a security domain in the `standalone.xml` configuration file.
2. Add an application user with access rights to the application.
3. Add a security domain reference to `WEB-INF/jboss-web.xml`.
4. Add a security constraint to the `WEB-INF/web.xml` .
5. Add a security annotation to the EJB declaration.
I guess this is a matter of taste, this catch clause just adds some context information so adding the message allows to see the actual error right away instead of in the "caused by" section. I don't feel strongly about this. I should also use a more specific exception.
Correct me if the question is misguided but would we want to know which links aren't visible or is the solution good-as-is?
Looks like lines 90 - 93 got indented one too many times.
This should read

```js
var url = baker.getDataFromImage(opts.imagedata);
```

to prevent `url` from leaking into the global scope.
done and done :)
Convention makes sense to me, perhaps even a helper is in order for that.
Can we default to the last commit hash here instead of ‘HEAD’?
- document hooks: islandora_required_objects() and islandora_viewer_info().
Oh.. I never learned about negative zero.. lousy public education...
There must be a better way to do this than writing to the actual file location
oh, そうですね。
ここだけ FactoryGirl を使っていないのも、ここでcreateしていないのも、
最初に作ったuser_specを見ながら、そのまま同じように書いてしまったためです ><
ちゃんと考えて書き直します!!
_```javascript_ にした方がシンタックスカラーが入るので良いかと思いました。
I think the part of the description "according to the parameter & the new placeholders" is not right. "According to" express that you rewrite the query to fit the new parameter requirements. In fact, you create them by expanding from the original parameter and type. So, to me the description would mor likely be "Rewrites the query parameter & type by expanding them into the new parameters & the new placeholders.".
а функция for_each?
мне кажется, что лучше возвращать другой тип
I think the `totalProfiles` should actually be multiplied by the number of tenants to get the real throughput, right?
We usually pass in null when we want the first results.
Fixed up a number of them. Let me know if you find any other that need fixing.
I think this method should be implemented with knowledge about the specialization name-mangling scheme. If we know the name of the enclosing class for a method, we know what it's specialized on, and the same for methods. Then we could infer a bit better wich one carries the implementation. It's not straight forward though, so there will always be some heuristic involved.
Is this only used by ``wrapInErrorStatus``? If yes, maybe it's better to move it in the method body.
That is OK only if  subclasses of ``ScalaStep`` are thread-safe, or you will run into threading issues. Make sure to make this clear in the documentation of ``ScalaStep``.
Describing it with apt-get is pretty standard for installation instructions - the user can just copy and paste the command. Users who want to install the packages by other mechanisms can easily see what packages are listed. Once we've made a `scipy-stack` metapackage, we can present this much better.

For now, I think we should still be steering newcomers towards Python 2. Not all of the core packages have releases supporting Python 3 yet, and we'll want non-specified packages like PyTables to be ready as well before we recommend Python 3. Again, users who know that they want Python 3 versions can find those themselves.

Links might be interesting, but they're not particularly relevant to someone wanting to install the stack, and linking to seven packages (not counting Python itself) for however many distributions will make this page very unwieldy.

To summarise: this page isn't meant to be a comprehensive description of the relevant packages in each distribution. I want to provide very brief descriptions of how to get the standard set of packages installed. This is intended largely for newcomers, so it needs to be concise, and free from extraneous information. People with more specific needs can find information elsewhere.
Here, you should resolve the conflict by removing this entire piece, because it is replaced by ParseCastExpression later on.
Umm, the ClosedChannelException is being logged, isn't it? Regarding the selector manager, I'm closing it to avoid a memory leak and too many open files errors (check the stack traces in the previous pull-request.
Also if you are really sure about any extra change that's needed, don't hesitate to do it ;)
I don't like factory methods that create mock objects, because it make small tests less readable.
@willdurand What do you think?
@willdurand A classmap would be better here, what do you think?
Deze functie kan weg nu denk ik
What's the purpose of this line? It doesn't actually save anything, it just switches the "character" being used.
Тут могу посоветовать пересмотреть лекцию 3, в которой рассказывается о методе description.

Ещё один совет: нужно стараться писать классы, методы которых будут возвращать какое-то значение, чтобы его потом можно было проанализировать. Сами методы выводить на экран, по идее, ничего не должны.
It probably doesn't need to be as current as I made it, but 1.399  
doesn't support the Node.reconfigure method which I need to override.   
The earliest version that contains that would do fine.

Harry

On 24 Jun 2012, at 20:11, Frank Bille wrote:

>> @@ -4,7 +4,7 @@
>>   <parent>
>>     <groupId>org.jenkins-ci.plugins</groupId>
>>     <artifactId>plugin</artifactId>
>> -      <version>1.399</version>
>> +      <version>1.424</version>
>
> What is the reason for the upgrade? By upgrading the required  
> version, we cut away all the existing installations, that is still  
> running 1.399.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jenkinsci/ec2-plugin/pull/20/files#r1039261
恩，这是错误的，修改过来了。
Ah, I think in our branch we exposed it as a property. Why would you make this internal and not give me anything else I can use to know exactly what the error is? Parsing exception messages is piss poor and likely to change. Reaching into the Data property is ugly too.
see my fix from today in mne.fixes in1d does not exist on old numpy
No, in general it could be any dimension where neighbors are defined by immediate proximity ind the array indexing. I'll clarify.
Yes definitely (both).
This one looks sparse because i wasnt happy yet with the seed...
Thanks for the great pointers and comments, I'll look into that tomorrow. I think we're getting closer ;-)

On 27.09.2012, at 23:27, Alexandre Gramfort <notifications@github.com> wrote:

> In examples/artifacts/compute_ica_components.py:
> 
> > +from mne.fiff import Raw
> > +from mne.artifacts.ica import decompose_raw
> > +
> > +from mne.datasets import sample
> > +data_path = sample.data_path('examples/')
> > +raw_fname = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw.fif'
> > +
> > +raw = Raw(raw_fname)
> > +
> > +picks = mne.fiff.pick_types(raw.info, meg='grad', eeg=False, stim=False)
> > +
> > +start, stop = raw.time_to_index(100, 115)
> > +
> > +sources, mix = decompose_raw(raw, noise_cov=None, n_components=25, start=start,
> > +                             stop=stop, exclude=raw.info['bads'])
> > +
> if you want the example to be rendered with a plot in the doc its name should start with plot_
> 
> I would fix the seed of ICA and try to find a component that looks like heart beat to plot it. If ICA works it should be present.
> 
> —
> Reply to this email directly or view it on GitHub.
>
fixed this, waiting for more issues before committing / pushing


On Sun, Dec 16, 2012 at 4:54 PM, Alexandre Gramfort <
notifications@github.com> wrote:

> In mne/viz.py:
>
> >      data = epochs.get_data()
> >      if vmin is None:
> >          vmin = data.min()
> >      if vmax is None:
> >          vmax = data.max()
> >
> > -    erf_imshow = partial(_erfimage_imshow, scaling=scaling,
> > +    erf_imshow = partial(_erfimage_imshow, scaling=scalings,
>
> Can you make the naming consistent?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/221/files#r2430100>.
>
>
Yeah... I did that at first, but then bunched them up because they're all pass-throughs. I'll break them up again.

Also, I'll take out that print statement.
I guess this makes sense as viewed as a temporary hack. If we thought this would be useful, we could have this be `delete_key_if_null(Key, Ejson)`.
You can also use backtick to avoid the noise of backslash escaping:

```
`"` + me.String() + `"`
```
this should also be a link to the api doc (probably using the interface instead of the class)
Or perhaps you're asking a different question. What would you say the
correct value is, the DB value? or the cached value?

On Tue, Jun 12, 2012 at 2:12 PM, Geoffrey Hichborn
<reply@reply.github.com>
wrote:
>> @@ -1090,12 +1090,6 @@ def do_after_all; end
>>        assert_equal now.to_i, @dummy.avatar.updated_at.to_i
>>      end
>>
>> -    should "return nil when reloaded and sent #avatar_updated_at" do
>
> This should be updated to ensure the correct value for avatar_updated_at is returned after reloading the model.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/thoughtbot/paperclip/pull/914/files#r969391
Sorry - just realized this is Twiml.
Ah. Done
ok, i think it's better
Well, maybe we can have a convention like "if there is a slash at the end, it is a folder", but I actually have just changed my mind. Convention is only good if there are configuration possibilities.
Always use getBytes with a specific charset
If you make the AMQP an Akka Extension just use the same pattern as for the otehr extensions, add your own config option in your reference.conf for the akka-amqp module.
You might want "self.toString" though
This still has the ability to leave an app unprotected,  just put an else in the case statement and remove the code from protect_with_forgery
Aaron, why do you think it shouldn't be here?  It's a very nice and simple example, IMHO.

Prateek, I believe Aaron doesn't refer to the location of the whole section, but rather to the fact that some of the examples shouldn't be included in the tutorial.
perhaps indent the K(0) and K(1) and O(?)?  I don't understand the connection between lp.K and K(i)  -- do you meant lp.K(0)?
Лучше инклюдь `<phonon/audiooutput.h>`, а то иначе проблемы были с какими-то фононами под какими-то системами.
И зачем ты поудалял те два?
@ninfaj Please do not catch all exceptions, because this includes e.g. ConflictError.
Catch only the expected exceptions.
Yeah, that is a hack. The correct way to do this would be to make tests and the directory above it be packages. To tell python that a directory should be treated as a package, it just needs to have a file in it called __init__.py. The file can be empty or contain code; either way, python will know to treat it as a package and allow imports. See documentation for [modules](http://docs.python.org/tutorial/modules.html#packages)
see above re: smoke test
Please remove "through setvar and RECORD_ variables". Users don't care *how* this works.
cc.KeypadDispatcher
Yeah... man page should be modificated if you decide to accept this change.
Hmmm, thought that might be the case, so this is a parser for the command executed within the CLI itself? Just wondering, doesn't the antlr grammar come with some way to parse this for you too? I mean, once you've given the grammar, it should be able to split the command into the different arguments? Maybe I'm missing something here...
header double-commented again
cool! and thanks for the pull
In one of the most confusing aspects of Cocoa, convention is to use `is` method names only with bracket syntax, and use the actual property name otherwise. For example:

```objc
STAssertFalse([repo isBare], @"Standard repo should not be bare");
STAssertFalse(repo.bare, @"Standard repo should not be bare");
```

Although what you wrote will compile, it's not idiomatic. We prefer the second form above.
Minor: probably best to stick to US spelling, since that how the variables are named.
Substance: this first sentence might be, 'By default, each line is assigned a different color taken sequentially from a "color cycle".'
Seriously, what the ever loving fuck were they thinking?
This positioning code could be replaced by using flex box CSS.  Check it out here.   

http://www.netmagazine.com/features/five-things-you-didnt-know-web-could-do
I think you can replace it with `update-in`.
it's gonna be a tiny namespace, but yeah much easier to follow and who knows we might find more stuff to do with request later ;)
It seems to me, that `response.body` is a Data object, both from looking at the `BW::HTTP` code (https://github.com/rubymotion/BubbleWrap/blob/master/motion/http.rb#L194-195) and from playing in the REPL:

    BW::HTTP.get("http://www.google.com") { |response| puts response.body.class } # => NSConcreteData
James, while you're in the area could you fix the variable declarations above this one?
@gsilver What was the reason for adding this in? Won't it be less accessible this way? Could we leave it out?
Unfortunately, all parameters that are transferred from the request into the properties map are run through the ClientUtils.escapeQueryChars. Because of this, I cannot reliably get some parameters that need to be "exact" (i.e., the userid here).

This is something I think we'll have to deal with post-1.4.0, but for now, at least some of the "property clean-up" that I do here will need to stay. The logic for building _au and _all, however, has been moved to the "custom query string" method.
Isn't this code doing the same thing as you've added above? There's two `if(activeTabs)` blocks with the same code but slightly different formatting?
It changes the filters.
no... that's a "ctrl-f gone wrong" >_>
I think I gave this comment once before, but the code has changed a few times since then. Don't we want to wait to insert the font-face rule until right before we make the second measurement, so that we're sure (as we can be) that the browser is still treating it as a web font and hasn't "figured out" that it's invalid yet? If we actually want to do that, then I think we should move line 50 here to just after line 75.

Or maybe this isn't important enough to change and then do all the testing over again... What do you think @bramstein?
See new middleware class
(As opposed to a set.)
new Model();
Can we clean this whitespace?
Vastaavasti kun `my-some`:
~~~clojure
(empty? (filter (complement pred) a-seq))
~~~
Tai `my-some`:n avulla:
~~~clojure
(not (my-some (complement pred) a-seq))
~~~
oh, your right. fixed in a17850dd4ef3d86ba2f062a91f3a5300a4b1b4b6
Thanks for pointing this out, I've thought about this during the summer but haven't had time to change it then and after that I've forgotten. I started the package this way because most Facebook GET requests for public data don't require authentication. Anyway I think it's better to have the OAuth client in the base class. I'll commit the change soon.
There is no new line at the end of the file
I've swapped actual and expected here so that the diagnostics tell you what you were expecting but didn't get, rather than the other way round.
Лицензию верни и впишись туда сам, как контрибьютор. Коммент с vim modeline тоже верни :)
unless ?
This variable isn't used?
Yeah, thanks. As I've just got a nonreproducible crash on 1.9.3-p320, I'll leave it as it is.
You tell me :). At the begining I had them 20x20, but they seemed to small and the addtitional user info didn't loohk so good next to the image. That was also one of the reasons I made them bigger.
Ehm, this is really the simplest way to do it?
Don't use `<br/>` for space. Use CSS.
Be more verbose with variable names, *boundCoord*.
One empty line here in-between, please.
Settings -> Account.
It is so in Djnago documentation:
<code>
{% blocktrans count list|length as counter %}
There is only one {{ name }} object.
{% plural %}
There are {{ counter }} {{ name }} objects.
{% endblocktrans %}</code>
This change shouldn't be included in the patch.
this changes automatically here cause i have two monogame version on the same solution.
Is this a problem ?

i can switch back if it is.
I was worried if sqlite would convert the values correctly, but I just checked and it does.
I don't know why we're removing it. I was just told that I'm supposed to remove it. Personally I think we should keep it.

Can someone explain why we're removing it before I modify the DB? @JSiu @snuriel92
don't understand , do you mean same Y coordinate for the new "clear" button?
I assume this should be set back to 15 mins.
Pretty sure this has been removed and if it hasn't it will be in favor of SyncManager. You'll want to update the store manually in your success callback until SyncManager is available.
Jaja, die guten alten Security-Diskusionen... Von mir aus kann mans gern 8 Zeichen lassen... Ich seh einfach jetzt schon genervte Casual-User (user: john, pw: god) ;)
missing space between the ``if`` and the parenthesis
ok, yes I agree. I put it there, but my instinct was to put it in Mat44. thanks. I'll do this.
I had a problem that even using set VERBOSE true the exception was not being show. So I changed to printstacktrace to not suppress the exception.
I like it. I'll update, and add a "real" unit test which execs the udf within pig runtime.
Maybe, better use `settings.FILE_CHARSET`?
nitpick = you should replace '/' by os.sep
I thought pids() was more consistent with the existing status() and numprocesses().  I'm not partial either way, so will change it to get_pids() unless I hear otherwise.
"to be _a_ promise"
I copied this syntax from:
ui_framework.layouts.js_rough_layout
ui_framework.layouts.profiler_rough_layout
and co
add_listener.
`var posting_object = this._is_main_context ? this._service : this;` is short and clear.
There you would need to ensure every call is eventually executed, I think that's a different use case.

But yeah, add a comment, I think that's enough, no need to implement stuff we don't use.
You should simply remove the tag if any, then read it again. It would help if thing changes in future.

```python
if xmldesc.getTag("commandline"):
    xmldesc.delChild("commandline");
# regenerate it
```
This test and the previous one share a lot of code.  Extract the common code into a helper.  Test code needs to be DRY.
![Screenshot from 2012-12-12 14:56:57](https://f.cloud.github.com/assets/566159/8263/31a18c8e-446c-11e2-8524-5f3dd172d5e8.png)
WAIT! He's got more skilllz here: https://github.com/ahmedalex/CoderDojo-Kata/commit/14a639cf4e333a2a2038c87642f482627d597454 there's hardcoded credentials and everything else a modern expert coder needs
Maybe a second parameter "filter" in the controller so you would include it like this in you code?:

    {% render 'EvercodeBannerBundle:Banner:view' with {'place': 'Main_horizontal', 'filter': 'banner_main_horizontal'} %}
Why "directory(s)"?  Is plural actually an option?  I don't think so (or it shouldn't be).
I think I'd remove the description of the AngleUnit constructor.  It will be extremely rare for the user to ever need their own specialized AngleUnit object.  So I'd start this item with "There are five...".  If you want to keep the AngleUnit constructor, that could be the third item in the top level itemize in this section, but like I said, I think it can just be removed.
It is of course equivalent to `if not 'no_save' in base:` but I think it reads better.  Seems weird given python's maxim of "only one obvious way", but there you go.
So... sticking with this new format for indicating mainpage, but making the ```@mainpage``` miniscule?  I can play with that plus different headers later.  (Or, you're welcome to do it now.  I'm in a meeting that I'm supposed to pay attention to.  ;)
any error handling for 'tag' inputs which are not in the dict?
why not treat locations as null as same as empty as i suggested?
Oops, I did not notice.
I can honestly say that this is the second time in my live I have seen >= used inline with an assignment operator..
It looks so weird :)
Why not > 0 ?