Victor,

I noticed that at least one of the files on GIthub is not the correct
version (no_translate.xml). I think my inexperience with Github may have
resulted in some errors while trying to remove some previous changes, so I
will check all files and let you know when I am sure that they are all
correct.

Car

On Tue, Feb 21, 2012 at 1:46 AM, Car Michael <cargmichael@gmail.com> wrote:

> VIctor,
>
> I have updated and committed the code to the Measurement branch after
> analysing the structure more carefully (in the absence of a published API)
> and believe I have now restored the base code to original with only minor
> modifications.
>
> I have now:
>
>    1. Externalised all strings
>    2. Added a new 'planningLayer'
>    3. Moved most of the changes to the MapActivity class into a separate
>    MeasurementActivity class
>    4. Added new functionality to provide creating/editing/saving/loading
>    gpx files for manually created tracks. This is great for planning trips and
>    provides a graphical gpx editor.
>
> I find the intention and use of the 'GPX file...''' and "Favourites"
> options in the "Define views" menu rather confusing. When a GPX file is
> loaded using the 'GPX file...''', the points are loaded as favourite points
> and which can only be displayed by turning on 'Favourites'. Turning on the
> 'GPX file''' actually clears the favourites loaded, hence if the user
> returns without loading a new gpx file, the favourites originally loaded
> are no longer available.
> It is not clear whether the 'GPX file'' map menu option should be a check
> button or just a button to open the file selection menu.
>
> Is the intention that the gpx files only contain favourites? Are
> favaourites and historical tracks considered to be the same thing?
>
> I found the 'Define view' option title misleading and suggest that it be
> changed to something like "Configure Layers".
>
> Regards,
>
> Car
>
>
>
> 0 AM, vshcherb <
> reply@reply.github.com
> > wrote:
>
>> > @@ -56,6 +60,10 @@
>> >       private Drawable boxLeg;
>> >       private float scaleCoefficient = 1;
>> >       private Rect textPadding;
>> > +
>> > +     private LatLon tempPoint;       //For measurement mode support
>>
>> Including the code is only first and simplest step. It should be clear in
>> sense of future scalability and maintainability. Many efforts were put for
>> simplication main activities but still they are very hard to maintain.
>> http://code.google.com/p/osmand/issues/detail?id=872.
>>
>> About possibilities : you can create 2 layers with different priorities
>> that's ok.
>>
>> Main message : if there are no tools to do it now we need to try to
>> create that Public API. That is strong requirement for now in order to
>> allow other developers create nice tools for Osmand and keep the code out
>> (or partially integrated).
>> So MapActivity, not the best place, ContextMenuLayer (not the best place
>> to extend). New Layers - ok! If you have problem to add smth to context
>> menu feel free to extend OsmandLayer interface and introduce some general
>> code into ContextMenuLayer.
>> FYI : every layer can propogate action into object context menu already
>> and that's right decision.
>>
>>
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/osmandapp/Osmand/pull/158/files#r442330
>>
>
>