labofsahil/github-event-dataset-2012 huggingface dataset:
FWIW, `instanceof` always returns `false` for `null` values.

> At run time, the result of the `instanceof` operator is `true` if the value of the RelationalExpression is not `null` and the reference could be cast (§15.16) to the ReferenceType without raising a `ClassCastException`. Otherwise the result is false.

(http://java.sun.com/docs/books/jls/third_edition/html/expressions.html#15.20.2)
I don't see a readability improvement here. Seems like a personal preference.
This is a best way how language contributors should be mentioned.
In our DB. It seems to be happy there. Read the commit message again and start to figure out how the sql part can be. Good luck.
You should really have tested this on your own server before committing it.
Please be a bit more careful in the future :)
In fact, the same happens if I use non-transparent image for 64x32 tiles. Am I missing anything? I followed your tutorial twice.
Is there a common CSS3 rule for this? If there is, we can use it, as our CSS minifier knows how to create rules for all browsers.
No, I just didn't see the bug at all :)
I think this is addressed by pull #652.
+ The Lable at scrollbar changed to "Explosion Delay" instead "Explosion Speed".
Lol Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios Thanks Naios
Are you sure `$rbenvdir/bin` is what you are looking for my `~/.rbenv` only has

```
shims    version  versions
```
> Why would that be a solution? There would also be that dangerous time
> frame (the other night)

It would just enlarge the "window" to correct errors, but as Garvin
pointed out, it's not an option anyway. Nevermind.
당도라는 말은 좀 어렵네요.
I don't think you can add arbitrary methods to a deftype - they have to be part of a protocol or interface. I wonder if there are optional interfaces for mojos,, and whether we should leave open the possibility for a user to implement additional interfaces in the defmojo? (I would tend to think not, but I am by no means an expert on mojos).

Having the log globally available is a convenience, in my opinion, since passing the log as a argument is just incidental complexity, while passing parameters is more in line with functional style code.
Is there a way to transform a child list into an ```HqlExprArray```? You could combine these two if there was, no?
Typo maybe? "must TO be 15" should be "must be" instead IMO.
Aritmética
is this paramater required?
I asume it is easy to rename, yes. There is only one place where it is used in plone.batching and if people customized this method, which I doubt, they still can import it as an alias. The method is a left over from ancient Zope2 code.
So are you going to forward this to Sun now? or are we not done proving to the world that an opinion has the ability to be right or wrong.
> This class will be exactly this size no matter how many languages we add (it even has support for Swedish as we speak!).

Yeah but it will grow with each string we add. Once the project will have 100 different strings, the Texts class will be huge. Plus it's annoying to set up a specific method every time you want to add a single line of text to the game.

> It is of utmost importance to not format texts where they are used. Different languages use different grammar, some with verbs at the beginning and some with verbs at the end. Or if you want to add a currency, you should be able to have "10 gold" or "$10".

Indeed, that's why "printf"-like functions are powerful. Here it's not a problem, for instance:

      MessageFormat.format(texts.getString("hasDied"), playerName(team));

will stay the same whatever language you choose (you can set the "hasDied" line to `{0} has died!` or `blah blah {0}`).

Here is an example from my mod:
https://github.com/mkalam-alami/inventory-tweaks/blob/master/src/InvTweaksLocalization.java
https://github.com/mkalam-alami/inventory-tweaks/blob/master/src/InvTweaksGuiSettings.java (l. 43 to 47 for instance)
you dont release static strings. they are in the non changable memory and therefore should not be released
defaultText is relying on an accurate detection of whether the <option> has the selected attribute in the html, if the <option> has the attribute selected="selected" the plugin shows the selected value rather than the defaultText variable which is the expected behaviour. It seems that jQuery in Chrome 17 and IE9 (I haven't checked other IE versions) report the first <option> in the <select> as selected even if the attribute is not set, which causes the defaultText variable to be ignored in favour of the selected option. This doesn't seem to happen in Firefox. I think it may be best to remove this option in favour of the developer putting something like <option>Please select...</option> in the html, as this then mimics the behaviour of a standard select box.
from testing both spells, in multiple enviroments this is why i landed on this chosen spell.

* 88747 is a correct trained spell (player spell)

* 88747 allows only 3 'shrooms to explode, causing damage.

* 88747 is the only of the two that actually spawns fungal growth

* 78777 allows not only multiples out as does the one above, but all will detonate as well

* (20+ shrooms that all go boom = bad fail) 

** **
issue:
 (Effect#1(Summon (47649)Value: 3)). is what should be happening with either one, 
both are ignoring that effect value.
It might be better to use --exec-prefix= here. This is what I did to the portage ebuilds to address a bug reported to Gentoo:

https://bugs.gentoo.org/show_bug.cgi?id=365485
@Kresshy : figyelj majd, hogy "eltűnt" a csereigény panel a kezdőlapról az [isVisible](https://github.com/Kresshy/kurzuscsere-wicket/commit/e4cde7c76d73f3e478527f950e1e62f220073a58#L0R101) metódus miatt.
Adj meg teszt felhasználó adatokat, ezeket beteszi db-be és beállítja a sessionbe -> megjelenik a panel
Why would we write three catch-statements when one would be enough?
should we check for division-by-zero?
By adding a condition on the where statement here you are making it so that you can NEVER create a listing where the download is expired or inactive. As I believe this is not the functionality you are looking for I am going to reject this commit.

What you should consider is adding a bool to the functions (ex: Download::findById($id,$includeexpired=false) ) and then add the where statement to the one that is already. You will also likely need to make changes to the admin section to show the expired or disabled downloads so that you can edit or delete them.
If you have tested this, please make fork and send pull request
This doesn't work. There is no session attribute on a Response object.

'HttpResponseRedirect' object has no attribute 'session'
Just to clarify, which front end do you mean? The one for judges to see what they’ve rated?
@reedy have a try as soon as you can ^^ thanks!
Oh right, the mutex will protect for that.  Sounds good.

The first part was from the commit message: "Unfortunately,
the lock is held during the call to ceph_mdsc_put_request(req),
which translates to a kref_put(), which can end up sleeping."
I found some defects in the fluid version at smaller screen sizes so I'm just going to cancel the pull request. Thanks for pointing me to Crunch, it looks very nice.
I defer to you. Feel free to undo the merge. Thanks!
Sorry, this came in right before I left, I'll have a look in the coming week.
what is 2?
It's hanging around here because it's intended to make code shorter; if it were in Utils we'd need

<pre>
Utils.trace(LOG_TAG, m);
<pre>

which — if used frequently — would still warrant a local helper. But you're right that the core of the trace logic should be lifted up.

Logging: the Android Log class doesn't print anything in JUnit 4 desktop tests, but System.out.println isn't ideal for on-device logging. For trace-level stuff it's handy to have the option of both, so you can "printf-debug" tests.

Use Log unless you have a good reason to do otherwise.
Please start the script with the perl shebang.

#!/usr/bin/env perl
Different song, but a more civilized four and a half minutes http://www.youtube.com/watch?v=neSQgkEy_xQ. Better?
Hi there,

Be careful with plugin.xml file. It will not work with the latest maven assembly plugin (2.3).
See here for details : https://github.com/elasticsearch/elasticsearch-transport-memcached/pull/1

BTW, I don't see your assembly plugin in the pom.xm file. So I'm not sure we can download you plugin from your repository (you only upload jar file, not the zip file).

HTH
David.
It's a little bit funny that the where clause generation is duplicated, but this is good enough to merge.
`fields` is unused.
No worries, I've checked in support for recognising symlinks (and other, more unusual file types). However, I very strongly do not want to resolve symlinks from that method.

1. It wastes time for apps which have no need to
2. As your comment above notes, there's no good way to communicate any errors that occur from resolving the symlink

It's better to let the client deal with all that.

I'm not using this code at present, but you never when it might come in handy, so happy to include such functionality in the repo!
I think if ppl should use button, why are we adding 'type=submit' ?
Ok, kužim, onda ako nam zatreba da dignemo neki event ili nešto onda lako i kolekciju proslijedimo kao parametar.. ok!
There is probably a more effective way to go about this if you know the exact implementation of the --add-algorithm, I just had no time to look into that. As always, feel free to tweak it with your knowledge ;-)
Good point.  I've been spoiled developing for Chrome only for a while.
 We'll have to add it to index.html as well then.  Let's do that once the
common header is done so that we only have to add it in one place.  Cool?

From Tom


On Wed, Dec 19, 2012 at 11:39 PM, BK. L <notifications@github.com> wrote:

> In about-beliefs.html:
>
> > +            <li><a href="contact.html">Contact</a></li>
> > +            <li class="selected">About</li>
> > +            <li><a href="programs.html">Programs</a></li>
> > +            <li><a href="http://sermons.lincolnroadchapel.ca/">Sermons</a></li>
> > +            <li><a href="calendar.html">Calendar</a></li>
> > +          </ul>
> > +        </nav>
> > +        <time>Sunday Services - 9:30am, 11:00am</time>
> > +        <address><a href="directions.html">145 Lincoln Road, Waterloo ON</a></address>
> > +      </div>
> > +    </header>
> > +
> > +    <h1><a href="about.html">About</a></h1>
> > +    <h2>Beliefs</h2>
> > +
> > +    <nav>
>
> If you use HTML5 tags, you will need html5shiv<https://www.google.com/search?q=html5shiv+cdn>
> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WCF/LRC/pull/1/files#r2474042>.
>
>
oh yeah thats a good one :)
What happens if a write is attempted when buffers are full?
Turns out I needed to remove this when I got rid of the Future, that's all it was used by.
Or it's just confusing to have it named "decay-half-life-duration" if you just mean "decay-half-life"
I'm all for it. That was originally something I asked for, but at that time someone (can't remember who or why) was opposed to it.
It is far more universal if we use the standard akka actor path syntax. Don't know how users are going to use it, but one less translation would be nice. The only thing is the options of course, which is the camel way of passing in options, but the options we actually support (autoAck and replyTimeout) are not really something I think the user would set on the path. So we could change it to just be the actual actor path in akka syntax, or the actor path in akka syntax with the options at the end, which is less 'compatible', what do you think?
Thank God it's not a D100 ;-)
register a single onComplete instead of onSuccess and onFailure separately
Clean up these, NonFatal should be grouped wit h the others from util
didn't look to closely at the usage: why does the handle need to be mutable?
Those 2 lines above seems OK to me.
Didn't look like rendered? and escaped? was used at all anymore so I stripped it out.
antipodal
This needs to be 
from dipy.core.ndindex import ndindex
for index in ndindex(3, 2, 1):
that is a better name
This is not needed if we get here we would return None by default also the blank line makes it less clear it is related to the function and does not aid readability
I just left it there for future brogrammers
Can we move this to the configuration section that describes QPID over SSL? I was thinking install is the basic stuff and then each configuration section is a tweak you'd want to make, but those sections would be pretty self-sufficient in that they describe all of the steps (including this RPM install).
May be intentional.

I wonder if it is related to having closed the ticket?

Makes sense the closed tickets would modify the view of the diffs.
Another case here, bind the initial account from setup.  Each of these will be a card function soon
Isn't it dangerous to store that in a cache? If a user of that class takes for granted that he can't double watch using always the same cb and the caches empties, then he may get more than one notification at the end.
Do we really need .asInstanceOf[Option[AnyRef]]
Would make line more readable.
if you mean the include, no.  See that std::min/max are used below.
Just leave it as it is.  The hole multipath thing will be sorted after Frodo.
That's the point of the commit, you should never get to `objectMerge` if `to` is undefined/null. If you look into the two places outside of this method where `objectMerge` is called, there is a provision for avoid null/undefined. Then within the method, we have a new provision for avoid calling the recursive `objectMerge` with a null/undefined value as well. Probably I can add a couple of tests to demostrate this.
^ same as above.
Why `__init__()` `object`?
Asegurate que esta prueba pasa al 100%
rename these to libmm?
If you were asked to remove them then you forgot @BeanProperty on RemotingErrorEvent below
Crap.  Sorry - auto format twitch.
Deprecated-- which is why I didn't use it.
Yep! Really thorough code review though :)
Lets do an explicit check against nil here.
Mismatched types.
I am not a fan of exposing the entire settings object. This is ripe for overload and can become a problem as it would be difficult to tell were the settings came from when working with an instance.

Please only expose individual properties.
:thumbsup: This might be hard to remember but I think it's the best choice. Having to do `then(function (a) { a[0].data }` get painful fast.
I could break the decrement outside the conditional, but figured I'd save a byte or two. Will change for readability.

How dare you suggest my code would cause lint to complain ;) (it didn't, though I was using `shifter --lint defaults --strict` because of an issue in shifter)
@is_pending ||= true

est équivalent à

@is_pending = @is_pending || true

donc @is_pending sera mis à true s'il est nil en entrant.
Changer la clef ici aussi.
Uh, these strings aren't meaningless... they actually define which kwargs people can write. The docs also define which kwargs people can write. But the code and docs don't match.

(The best solution is probably to just not accept kwargs in the code -- it's easier to extend APIs later if you know that existing callers aren't playing funny buggers with kwarg ordering and stuff.)
...though if comparing to arr[obj], we should make clear that this implements 1d indexing only, since that's a pretty substantial difference.
Ah, that's true.  I'll throw that in. (both NOTICE and PRIVMSG)
оно закомментировано, оно ни за что не отвечает :)
Perhaps we could just kill the argument, since it is apparently not used inside the initializer body?
Yes, I'm changing.
Decrementing by exactly 1 is what we want to do here. I have amended the specs to prove it :wink:
I could store it somewhere during `cleanup`, but I'm not sure where so that it's visible later during `icode`. Will look into it.

Also, maybe `findMember` could help.
I'll take care of it together with reviews from other PR, as I need to rebase this one anyway.
How can a `Long` be possibly larger than `Long.MaxValue`? :-)
I think this at least deserves being moved to the docs
have a look at `treeInfo.catchesAllOf`
``outliers`` is never used, I assume it can be removed?
is there any reason to import these at function level?
FiniteSet.elements should probably be named FiniteSet._elements. It's really not intended for external use - mostly it is used internally so that some set interactions (like unions and intersections) can be accelerated. When you think you want .elements you probably want .args (a tuple) or just more likely just self. elements is a frozenset, self is a FiniteSet, args is a tuple - they all hold the same things. What exactly are you trying to do here?
Drop the `for ... ` to the next line.
looks like it needs a newline at the end of the file.

Do you know how to copy the author information to a commit? (see git commit --help)
I think the only difference is that `is_Mul` will only work on a subclass of Expr, since it otherwise won't be defined.  And I guess technically anyone could define `is_Mul` to be True on their class, though that would be unsupported.
I thought powdenest or powsimp would handle this...but no.
The solver should be able to solve such systems, however this is not implemented in this pull request. I will leave it as it is and mention it clearly in the tests. The fact that the solver has rough edges is mentioned in the docstring.
This looks like debugging output and should be removed, I think.
Space between `,`. Run it through the pep8 tool. There are a lot of these throughout the code.
I'm not sure if it's a good idea to use a float literal, especially if it isn't a terminating binary decimal.
this 8 looks like a magic number :)

it should be obtained from this.cap's size in constructor (or createElements method, as referenced in the above comment) so that we don't need to re-obtain it every time.
The commented imports perhaps should go away.
there should be some documentation on this property...
Same here. See line 1049.
It can be set using `CWebModule::setControllerPath`. Do you think you can find a use-case when it will break?
Using of “serialize($options)” is unacceptable. 
During the issue discussion we have fond there is a use case, when developer registers multiply Meta tags with the same name and parameters. Such approach is used for specific Meta tags, which should be parsed by some external application or JavaScript or else. So they should be considered as the XML based values, which means it should be possible to register identical (same name, same options and same content) Meta tags. 

I do not like the idea of mixing different logic keys inside the single array: it is potentially a source of troubles. For me it is better to fully separate these values.
Yeah, I'm generally a fan of **including** stack traces, not excluding them.
I get it now, CakePHP installations are not vulnerable to that kind of attack, though. But adding it should not hurt, unless running PHP on a separate server.

Anyone has objections on adding it despite it possibly breaks something?
Any way to make it more clear that it is Erlang process spawn options, and not Meck specific spawn options?
Do you have unicode issues? I don't.

Plus, it's cleaner. Look at Github's search bar. Don't you think the placeholder looks good?
Now change it.
Sure, I'll try to do some typo's checkup next time and fix everything with find-replace.
oh
nvm.....
Without this change, published questions with nil question setup would fail validation.
This code reads the post and updates the partial credit text field re: losing it when the validation occurs. Also updates the correct values for the radio buttons/ displays the partial credit box if needed.
Make private please :-)
wouldn't 

     db.databases.find( { 'partitioned" : true } ) 

give you the needed result set?
this triggers requests like https://developer-local.allizom.org/en-US/dashboards/revisions?term=groovec&locale=

I would expect it to send `user=groovec&locale=` since the input name is `user` ?
since all three of these input fields have the same classes, it probably makes sense to refactor 'input-text big' to the parent div
You have to use quotes around the constants here, as this will otherwise be replaced with the value of the constant, hence this would actually say `if(!defined('phpbb_auth_openid_assoc'))` which is not what you mean at all.

It's also missing spaces after if, and the opening curly braces go on a separate line.
All cases. See the ticket I linked to above.
New functions should be prefixed with `phpbb_`, so in this case `phpbb_generate_template_pagination` would be the proper function name.
My bad, didn't notice that
tweaked, but there is something later on in the file.
fixed in c077885
Should this be a third state off of default like "Primary"
Thinking about this some more, I don't know if it is necessary to refactor this out. Some of these steps like `xvfb` and the display port I would not expect anyone to run outside of the Travis environment. I think the other three steps would just be a documentation issue. Given that, I don't know what advantage we get by moving these into separate files.
The RS skips files that start with a dot, and vim swap files start with a dot.
Hardcoded path, this may cause problems with windows.
It would be better to use File.separator or get the complete path from the configuration.
We probably can by patching the .cabal file and possibly minor modifications to the source. However, I didn't bother to do so yet. I suggest we just wait for the next release.
Yes, Sencha theming is done in the very streamlined compiled language SCSS ( that, in turn, generates CSS).  This makes it essential that all the ui elements we use are Sencha, not HTML.
Well spotted @bblay!

There's been a slight update to the requirement that you weren't to know about. We decided that ```model_level_number``` is perhaps <i>more</i> meaningful to the user than ```level_height```, so it has priority over it. Hence the change.
I don't think I understand.
Make it bare?
We need the ```num_ticks = None``` so that would have to move above the try.
Or perhaps we'd prefer ```num_ticks = kwargs.pop('num_ticks') if 'num_ticks' in kwargs else None```?
I'm a little uneasy about this too, but improving the unit handling is a significant chunk of work. Although this differs from the rest of the loaders (which don't attempt to catch the exception) I think it's reasonable workaround. I think a warning is in order though to let the user know the units could not be parsed and have been squirrelled away.
> But I'd hope that we end up with a well-defined, self-consistent ordering.

Its easy enough when there is just points, and I think it should be obvious what to do when both have points & bounds. For me, the problem comes when one has points and the other has points & bounds. What makes this more complex is that using these operators in constraints is desirable. For instance:

```
a = 10
b = Cell(point=10, bounds=[2, 12])
```

*For constraint syntax*, I would want:

```
a in b == True
(a == b) == True
(a > b) == False
(a >= b) == True
(a < b) == False
(a <= b) == True
```

Hope that's useful to somebody...
I can see that a lazy=True/False/None parameter is handy for running tests, but I don't think that we need to expose that parameter here. It's confusing because 'vm' can also mean lazy, depending on the graph... but this interface makes it look like 'vm' is the non-lazy version and vm_lazy is the lazy version.

I suggest removing vm_lazy.
implement -> implements

and maybe capitalize Op since you do it other places?
This is good. We did that in the past. There is a better syntax that we use for new test. I don't ask that you change it, but I tell you just to let you know. You can do it like this:

self.assertRaises(ValueError, self.cmp_dot, rand(5), rand(0))
on a more serious note - this whole text block seems like an accidental duplicate. True?
Is it worth putting a warning-level log here?
-1 is a valid value?
Space between if and (. Next statement as well.
For now this list is only used by InstallController, but i think this list may be used by "Plugins" plugin in future
Because we're only testing 2 or 3 parts of the code and therefore only 2 or 3 tests should be needed. If you want to make sure it works over many values you can just change the values 50 and 10 to something more random or repeat it with a range of values, or even randomly cut the body chunks.

No need for complicated solutions.
I would change this message to something like this:

`"Please specify the ID of the hazard output to be used with this calculation (using '%s')" % HAZARD_OUTPUT_ARG`
You could, but if hideTitle had been specified or if a derived class is used that puts the legend or layer title on the bottom, rather than the top, then you can't be certain that the layer title label element is the first in the collection. By using find, you unambiguously get the first label or label derived component.
I'd like to see this condition go a little bit further and only convert *canonical* representations to numbers: `jQuery.isNumeric( data ) && +data + "" === data`.

Even if we believe that people are taking advantage of conversion from exponential formats etc., major releases give us a chance to clean up some past mistakes.
> Since the interface we need is ajaxy, it seems most logical to put it in ajax.js

Bingo.
tried all of that, didn't help. gzip really loves seeing repeated strings rather than new variables. I suppose I can try again now to see if it helps.
I don't understand your first question.
self.inWIth should be checked in the update method. Good observation.
In the past, not dropping the temporary table has been very useful for debugging and workaround. The state table is most likely not too large, so I want to keep it around. After all it is temporary anyway.
Having gone as far as creating "+=(LMFModel)", why doesn't that operation handle the weighting based on numRows?
`"-isysroot #{MacOS.sdk_path(10.7)}"`
This explicit return isn't necessary. Ruby methods always return the last return value from within the method, and `p << 'foo'` returns the modified array.
I only did so because the full URL is 114 characters (>80) long :) Will remove, and change the other stuff you suggested.
I think saying "version update" is clearer than "software update".
Obviously I still don't fully understand how names are bound in Ruby.
And we still do. It is done in self::delete() where permission checks are done correctly.
Actually, it should be part of the format string. I'll move it there.
Я бы всю эту часть сейчас переделал, честно говоря. Чтобы было типа такого:
"Давайте рассмотрим простой пример ветвления и слияния с таким процессом работы, который вы могли бы использовать в настоящей разработке. Мы проделаем следующее:
 
 1.     Поработаем над веб-сайтом.
 2.     Создадим ветку для новой задачи, с которой вы будете работать.
 3.     Выполним некоторую работу на этой ветке.

На этом этапе вы как бы получите звонок о том, что сейчас критична другая проблема, и её надо срочно решить. Затем сделаем следующее"

Но в общем-то это в данном случае не важно :)
nicht anonyme callable objecte? was sind anonyme callable objecte?
Die beiden Antworten haben sich überschnitten ;)
I don't think this method should take an argument just to return it as default.
The usage should be:

``` ruby
level get_level || 2
```

It should not be the work of the method to return the alternative value. It's confusing.
Spaces around `:`.
I'd be tempted to rephrase this to be about graphs and math rather than dependencies. If you'd like to avoid having me nitpick every character here, just leave it and I might circle back after to describe it that way.
Undelivered messages will be send by server again at the next login
Also we use the theme as the textdomain right now but what should we provide as a default value if none is set?
I would suggest `Attaching links to files stored in the base (sub-)directory will keep them as relative links`, but yeah, it's not an easy thing to get across concisely. 

If you go with this, the basePath should then also say `Base directory:` and resetBasePath `Clear base directory`. IMO directory is clearer than path.
runs a test -> runs tests
yes (see my response to greenideas' comment below)
This subtraction only works if the values are on the same line
I guess it would be possible. The prefix and suffix would be added on a new line and on the column 0. So checking that they are alone in the line and in the column 0 to remove new lines, could remove almost every other case.
Is the goal of this just to return a copy of the `_dirtyPaths` array? If so, since you just need a shallow copy, it's more idiomatic to just do:

```javascript
return Array.prototype.slice.call(this.dirtyPaths);
```
Fixed. The encoded url is shown in the list and inserted in the page.
This remark still stands, no numbers in this regex?
I promise I was about to merge until I saw this. Aside from the double negative which is awkward, I don't think most programmers would expect to have to pass an option to raise an appropriate error. That is, in my mind, attempting to drop a non-existent table should either fail gracefully or raise an attribute error stating that cards has no table with the given name. 

In fact, I'm leaning toward the AttributeError (as silent failures can be a pain during debugging), which would result in the following in client code:
```python
if 'cards' in db.tables:
    db.drop('cards')
````
unused atm, could be used for the treshold implementation
I think that this is code that belongs in the particular views (not the layout). For instance, we wouldn't want to have this on the map or about us pages.
It needs c(0, 0.5) to work properly; if you use c(0, 0), there's not enough space.
This should probably be in the main raphael.js file.  I already have to override getComputedStyle to check if its executed on a Raphael node to return the correct value when someone calls ```selection.style('foo')```
I like more the approach through code. I am skeptical about support for that selector. It is true that our portal will require a modern browser, but still. It is a good exercise. :-)
Is removing this really necessary? It caused a lint error (CSS_POLL_INTERVAL isn't used anymore). So, perhaps it's easier to just leave it in. Does the checkFn continue to fail after the CSS loads?
Are we good here?

I did this because the media size can change after initial creation of the editor.

By doing this, we assure we always have up to date sizes.
You should store console.log in a var, then set console.log back to the normal function once this test is done
super nit picky but we generally add`i` and `rLen` to the top of the function, no?
Default is ROADMAP, so you should be consistent in code.
Is RuntimeError really what we want to rescue here?
same comments here as for getTemporaryDirectory()
sonatype/nexus#605
Why are you storing the offset in the `toc_data` instead of using a local variable?
create table lauseiden mukaiseksi.
Почему это не часть теста, а `beforeEach()`?
Done and done. :-)
callback in this case is actually returning the content of the render (similar to how Express does it)
Move this code to a `Formatter` would be great. 
@claylo What do you think?
nit: e.detail -> detail
This should take an equivalency kwarg.
I added a reference to hub, and left yours for now (since hub can be a bit of a pain to install)
interable -> iterable
As I commented above, I think it makes more sense to put this in the ``docs`` directory so it doesn't get included in the source.
Isn't this the same as 'composing units' above?
shouldn't be changed, looks like you had merge conflicts in here and never resolved them.
And you probably don't need to be creating most of these anyway. Indexes are for columns you often search by. Premature optimization blah blah.
Perhaps you mean:

If true, the possible ``roundValues`` will be multiples of 10, 100, ... of the submitted ``roundValues``.
The latter values should then be contained between 1 and 10.
Thinking more about this... the step should probably be: `Given I am an admin of the group "Enspiral"` (you could put whatever you want inside the quotes for the group name), and then in the step definition title there should be a regular expression to catch the name of the group and perform a Group.find_or_create!(:name => group_name). This will make things way eaiser (since all of the step definitions won't have to hard-code the name of the group).
@flack, @bergie: can we even have multiple partOf in this situation?
Any idea @josh ?
All the AWS deployment support and tasks should have a separate package. This implicit would fit nicely in the package object of that package. Otherwise, here will do.
Agreed.  I've pulled it back into the main readme.
ok, makes sense.  It seems like this can go in, then.
even 
```
return index || this.get_selected_worksheet_index() || 0
```
should be equivalent to this whole block.
hard-coding?
I'd prefer a combination of both, just like it is possible for strings.
I don't understand this test. It logs in with a user account where the password is disabled... and gets an http 200. Is it testing that the user can't actually log in because the password is disabled or is it testing that this situation doesn't die with an ISE?
same mis-spelling
ahh, of course.  that's lots cleaner!  :)  thanks for the tip.  fixed.
I notice in the ESR section, the equivalent where clause fragment is using "ILIKE" instead of "=".  Is one correct and the other not?  Or does it not matter?
blank? is a function from ActiveSupport. When using the web ui on a rack server, blank? is not available.
this is faster
It's just consistency.
Hmm, that's odd. I remember Eclipse having a Play! plugin. Maybe that would help? Not sure...
1. I'm not sure.

2. Guessed. Too big? Too small?
ttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt
Moving this private internal structure outside the driver won't happen.

Your second line makes no sense.
I don't see this in the model definition. Is this relevant?
Use `this.window`. However, you should be aware that a lot of the overlay code will be changing in 1.10, see #452
I think "trans === undefined" should work across everywhere; IE6 nightmares?
`save`
please could you explain me it? thanks a lot
Yes, bad habits got started early on and now are just done for consistency. There are a lot of things I'd like to refactor in the browser, maybe in v2 :)

Thanks for merging!
Right, I'll move everything inside the suite. Thanks!
`'localized'` can be called more than once. Do you want to be `init()` more than once?
Array.slice(...)
What is `mozSetMessageHandler`?
I don't understand sorry
It's on Line 1 and not shown here... :P
This does not sound like a correct activity name. It seems like you will not really import facebook contacts to a different app but import them inside the contacts app. It would be cleaner/simpler if you remove this activity handling from this application and then add a very small facebook_import file to the application that will render the FTE. I also believe the UI should be different between the FTE and the other time you want to import contacts?
This function should throw an exception if the slot is already assigned.
I think that a missing dependency should be logged as a `critical` (`this.logger.critical`)
extra space before the last parenthesis, and a space is missing after `if`
We want to treat this event as if its what the default behavior of a link would be...This stops this from happening if a previous even handler prevents default behavior. but doesn't stop propogation.
All of these are in English.
Not in F#.
These shouldn't be globals - put them inside the class please.
Remove "host".
This sounds like it just removes the keys. Doesn't it also delete the values associated with those keys?
I would default on null and not update topic icon if it isn't provided in the template. Otherwise some templates may cause icon to be changed to the default one.

We have also setting that disables user defined topic icons. I'll put it into the next comment
Broken quotes, extra " in the end.
We don't want to be "flexible" in how arguments are processed!  The docs say `when_timestamp` should be an integer, and that's what the fake method implements, so this should just assume it's an integer.
Should be `try (...) {`
VcsArchivers have a format support method (zip, tar, etc.) but also a source type support (plus a sourceRef property). So we use them differently.

If you want to homogenize all archivers, I can had those properties to the interface (sourceRef and sourceType), but it will have no meaning for basic tar/zip archivers.
I love this! I was planning to do something similar, but didn't have time to do it yet.
This finally  makes us able to report an error if a closed window receives command.

BUT, I don't think that's the right place for this.
What about putting this in the super class (RequestHandler)?
Or, even better, a new "SessionedRequestHandler" or a less ugly name?

I just think that any class that does or will interact with the session should have this utility.

What do you think?
Sorry, didn't have time to look at this any sooner...

I mean this `%h`, which will become a `<h></h>` element in html, but `<h>` is not a standard element (at least not in [this list](http://www.w3schools.com/html5/html5_reference.asp))
;)
see previous comment and the same applies to all fields in this factory.
but contents of `~/.gitolite/hooks/common`
```
post-receive -> /home/gitlab/lib/hooks/post-receive
update
```

vs `~/share/gitolite/hooks`

```
gitolite-hooked
gl-pre-git.hub-sample
post-receive.mirrorpush
update
update.secondary.sample
```


where `~/.gitolite/hooks/common/update` is generated
```perl
#!/usr/bin/perl

use strict;
use warnings;

use lib $ENV{GL_LIBDIR};
use Gitolite::Hooks::Update;

# gitolite update hook
# ----------------------------------------------------------------------

update();               # is not expected to return
exit 1;                 # so if it does, something is wrong
```

and [~/share/gitolite/hooks/common](https://github.com/gitlabhq/gitolite/blob/pu/hooks/common/update)

so in gitolite 3 there isn't reference to `GL_BYPASS_UPDATE_HOOK`
done in c1f67603c08411e33418dcc918db92dd137ebd11
I was considering this,  if I remove the monitor status (which I think we probably do not need) then this becomes trivial and will easily go in there
should be <machine name="pc2" address="$(arg pc2)" default="true"/>
The only way for the region to be nil is some kind of failure.
I could probably implement some retry policy, but it would be a bit tricky.
Another option would be to fail this plugin completely; that would arguably be better than dropping events.
So if you want a single-line text area but don't care about the return event, you have to pass a dummy event name? This behavior seems unexpected.

I can imagine code like:

```javascript
new Ribcage.TextArea({'returnEvent': 'dummyEventToMakeSingleLine', ...}
```

...which doesn't look great. This is not unreasonable, given that certain code may just listen for changes to the `s` event which is already being fired on every keystroke.
This cross-package dependency is very bad. Please submit a bug to fix this an refer to it in the comment here.
I did the same in all other tests with `readURI` with `sync` options. That's because it's much clear than it is synchronous if you read the code, because the other `async` versions have the variable at the `assert.equal` empty; so you can actually see what happens here in the test, that the `resolve` function is called before going to the next line of `readURI`.

Or you meant something different?
@6a68 Awesome, works great.
just curious.  why did you remove this error text?  is that something that's actually already handled by make_option?
Right, not anymore.
Conflict markers need to be cleaned up here.
@vStone I think changing the regex to only match when there is at least one space preceding the backslash would be sufficient:

<pre>
when /^\s*(.*?) +\\$/
</pre>

It is possible you could have a path `c:\puppet\var    \`, but then 1, that's insane, and 2, quoting it would eliminate any ambiguity `'c:\puppet\var   \'`
Yeah, it will be as it's loading Augeas with the default settings which is to load everything (about 0.75s for me).  The same delay happens when you run a resource on a client.  We could stub it out easily - we do it in every other test, but my hope was to test it fully as we're missing any other sort of end to end tests.  Should I look at moving these to acceptance tests or something instead where longer runtimes are acceptable?  I'm not familiar with how acceptance tests are used yet...
This is enough data to build all type of data binding backends. +1
I think `ProjectAssignment` class name would be better as it could be a real use case.
Ordering it's representation. One model can have different ordering in each action, so, i believe this code should be a part of controller.
can you remove the spaces here? thanks!
no printlns. maybe log, but be careful not to log too much.
Can't do this one. You're forcing *every* header to be uppercase. What if I don't want the headers to be uppercase? The user should send uppercased headers to the grid, not having them automatically changed no matter what.
Needs to be added to pe-ap-ie.scss too
I know it was `Client` before, but I think this should be `HttpClient`, actually. Below it uses $client->setAuthSubToken() which is a method of `Zend\GData\HttpClient` and not `Zend\Http\Client`.
This same comment is true for the other helpers as well.
Shouldn't this be !$this->headers[...]?
In places where there is no clear PSR-x standard that we've adopted, we should leave the code alone.  When it comes down to it, someone else is maintaining that piece of code (the component lead), and its better to let them dictate the smaller aspects of how they want the code to read.  Since there is nothing to refer to (PSR-wise), this change is as arbitrary as the original code in the first place.

Nice idea though.
passing ``null`` to ``strpos`` could also lead to some issues IIRC
ok.. will do in the other too... good morning :-)
`pluralizer: count - completedCount === 1 ? '' : 's',`
It is a good question which we are already disscussing in doctrine-common https://github.com/doctrine/common/pull/175
Should we overwrite or add. I have no good answer for this question :(
Please fix the CS. A space is missing after ``foreach`` and around the ``=>``. And I don't see why you need to get ``$annot`` by reference
Err, here's a link, sorry: https://github.com/rdegges/pelican/commit/ad10edc3145a819e24b7255987ec3bb0bd961784
use LdapFilter instance
""" insted of '''
Is it intentional that you're dropping documentation for the last two? `ignoreLeaks` in particular is important for CoffeeScript users, because leak detection is not needed with CS.
I adopted it from the mapserver file, for some reason (unfortunately I can't remember anymore) it didn't work with the above line. (Also I have to admit, this was the first ever spec file I worked with, and my skills with makefiles are at least a bit rusty too!)
Is this what line 74 is referring to? Even if not, seems confusing to have one "post_share_banner" and one "post_banner_share".
Nit: Isn't it `'en-US'`?
This needs indentation.
I tried to have it show 2 results by having another photo upload and ES update but it just didn't seem to show me both of the users.
I agree on principle that if the Popcorn API is bypassed then there's very little we can do about it. However, as a user watching a Popcorn video, what if I paused the video by using the media controls directly? That would bypass the Popcorn API and continue to fire the frame function while paused.

To fix this, all that is needed to do to remove the `self.data.state.paused` additions that were made in this ticket, and use `this.media.paused` directly.

I've built this fix on top of my t953 branch at https://github.com/jbuck/popcorn-js/tree/t953 the commit is at https://github.com/jbuck/popcorn-js/commit/50dbff80d3e5bc0d12e0f8ea1775ccc2481c194c

If you take the test that I did in that commit and put it into your t953 branch, you'll see it fail.
Average number of seconds?
他のコントローラーで使うならapplication_helperに、このコントローラーでしか使わないならmunoh_helperに、というように、置き場所については少し意識していてください。
Esto esta mal porque no matchea CSS
nit: I might add some text like "problem permalink:" because things like "0 #162" are kind of vague in what they lead to.
I can play with this a little with .css changes.  The breaks were to space it essentially as single space rather than double space.
![](http://tifr.us/storage/post-images/Tim-Eric-Mind-Blown-__SQUARESPACE_CACHEVERSION=1316658161000.gif)
yeah, as in dan's comment, you should fix the `_computed` `computed_` discrepancy.
no need to use ``else`` here as the ``if`` returns (exactly as it was done previously)
:heart: this, I freaking love removing code
Dave I know where you're coming from and this is not really a closed loop logic system like the ones you shouldn't put into a page object. 

With the search_for method placed inside each `if` block then you would only be able to search if you are calling it from one of those page objects. Thus the workflow is dictated entirely by the previous step of the test, not by something on the page. If the previous step has the wrong page object class then this method will not work. It is not checking the page without knowing which pageobject/class it is and making a decision - its flow is far more rigid than that.

The only path for which this isn't true is for the `else` block but we can simply replace that with an if for `Home` and `SearchList` which will only allow searching from those page objects and is sufficient for this test coverage.

If the wrong page object is returned then the following step of the test will fail but that is indicative of either an app failure or the test not using the correct page object in the step prior to this method, not this method.

In effect this is the same as placing `search_for` in every page object as if you call it from a page it is not valid from then the step will fail, but with less code duplication.

As it is now however it's a bit of a bug it will return the wrong page object!
Right, I missed the point that MessageComplete is called regardless of whether or not the message is correctly parsed.
`console.log` should be removed. While you're there, the `// remove it:` comment should begin w/ a capital
I don't think doing them one by one is necessary, and it makes the function a lot more complex, as well as requiring a bunch of individual queries that are no longer batches. I'm happy to switch the setRoles and batchQuery around, so that we can re-generate the content members and libraries from the roles table. This will prevent us from giving access to people that shouldn't have access.
Should document the arguments of the callback function.
We usually put single quotes around code and msg.
the second parameter should be userId.
Named arguments for the boolean values would improve readibility.
there is always the problem of name clashes with these things, yes.
Don't think this is necessary
at least one expression as argument*
???? indeed...
Spacing looks weird here. Could you fix that and add a changelog entry in *user_guide_src/source/changelog.rst*?

Other than that - it looks good, although I would like a second opinion.
Зачем? Гораздо проще избавиться от лишних строк и сделать проверку

`if ([[self DNA][i] isNotEqualTo:[c DNA][i]])`
Ah, yes. I passed :aid => @assignment.id, as locals to this view.
this doesn't seem to have any effect
single quotes when not using string interpolation, please
If was possible, I would use.

The API only accepts string values for this.
will the modules change to Crowdtastic?
Mainly because no one has removed them yet ... :)

I'd prefer to switch over to more standard (non-Windows) types overall... that's coming with time. I did that for some things already.
TY, I will fix.
nop: seems you did 2x copy/paste here!~
Should remove unused code
Dat kan zeker, maar paste niet meer binnen de tijd die'k gekregen heb
here what happens if you have 2 ECG channels?