labofsahil/github-event-dataset-2012 huggingface dataset:
hi,

 There are many lines changed in GraphicsDevice.  I cannot easily find the
> actual changes due to Github's diff showing whitespace changes, so I cannot
> comment on the functionality changes.

The changes were only in DrawUserPrimitive and DrawUserIndexedPrimitives.
Theses functions had a memory access bug.
Sorry for the whitespace issues ....

There are also substantial changes to Vector3.cs.  It is very difficult to
> see what has changed and why.

Most of the changes were minor performance issues and Modularization.
Others were about to fix some bugs :
Functions:
Transform
Transform Normal

Iam using BepuPhysics API that i converted to Monogame, so to make it works
correctely, i needed to fix these functions in Vector3.
This class is heavily tested, and is used in anx project also.

See the wiki (linked at the top of the page) for the description of how to
> use submodules and submit a pull request.  I'm not sure what the decision
> was on using latest OpenTK for Windows.

The main reason to use the new OPENTK were:
The latest official Opentk is VERY OLD (more than 1 year)
I need some functions like Mouse.SetPosition , that are not avaliable in
current version. (In original Monogame, this function is dummy implemented,
it does not work yet, in some plataforms like MAC, people went native ...)
Also, the last version of OpenTK fixed some "minor" issues with performance
and leaks in drawing functions.

Att,
Thiago Dias Pastor


On Wed, Feb 15, 2012 at 8:35 AM, Steve 'Sly' Williams <
reply@reply.github.com
> wrote:

> There are many lines changed in GraphicsDevice.  I cannot easily find the
> actual changes due to Github's diff showing whitespace changes, so I cannot
> comment on the functionality changes.
>
> There are also substantial changes to Vector3.cs.  It is very difficult to
> see what has changed and why.
>
> See the wiki (linked at the top of the page) for the description of how to
> use submodules and submit a pull request.  I'm not sure what the decision
> was on using latest OpenTK for Windows.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/tpastor/MonoGame/commit/f5acd195d692d9a7b24c3b38075afea9565f61a9#commitcomment-968794
>
нулями не инициализируется?
What is the difference when placed directly from the overall_header.html?
1. 'ASCF' is the official text from the french AIP, so I think we should support it.

2. I used 'UTF-8', but I see that you use 'UTF-8 without BOM'
I don't know what the difference is, or what I should use

3. Can you indicate which file?

Thanks.
Wim
Fixed in b323b92dc98a560174801bddf649c854ddb566a2 (I removed the empty lines).
Oh, I thought there is a `$this->pass()` as a contrary to `$this->fail()` hmhmhm... (it was in simpletest and in some reason it is the same in phpunit)

Ok, false alarm then ;-)
This is exactly what I've been waiting for.  Do you have a notebook example?
this is for recommendations. don't remove this code.
Okay. 
Problem solved. :-)
This patch causes two test failures in ThreadTest and VerifyTest (one of them is a new test, you might want to pull the latest version):

   [testng] ===============================================
   [testng] TestNG
   [testng] Total tests run: 567, Failures: 2, Skips: 0
   [testng] ===============================================

Also, your field should be called m_userDefinedMethodInterceptor.
True, but we really should query the webdev team first and try to figure
this out.

I know a lot of the new folks hate vendor/ and it would be nice to not
support two things somehow. ... and if it were up to me, it'd be in a way
where requirements.txt was the only thing maintained.

On Thu, Feb 23, 2012 at 3:20 PM, Kumar McMillan <
reply@reply.github.com
> wrote:

> I guess we could set up a separate CI builder that didn't clone vendor and
> tried to run tests after a ``pip install -r requirements/prod.txt``
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mozilla/funfactory/commit/4884c0b7e9fd5d7db920a28f6c4d0b233c336253#commitcomment-1004901
>
Sorry for waste your time guys, but can you take a look in the file? xD
http://pastebin.com/9MiL0R2c
I can not be right but if someone can tell me which file should I load for Argent T. Why do I ask? When loading old file with the sql, there is a lot of errors caused by differences in the columns in the table - for example in quest_templates ...

BR
CrioGen
Если логин пуст? ШТО?
Hmm, you mean hooking OnUnitTargetSelect on the script or correct the TARGET_95 on core? Because i think the real problem is on how the core handles that type of target.
imo you just need to select passenger during spell trigger
Yeah. Laziness got the best of me after I started tearing all the examples apart.
The new expression now accurately captures NCBI standardised filenames for multi-part db's. It should also now be ready for future db's with 100+ volumes.
During crawl, this line throws this error sometimes:


Notice:  Undefined property: stdClass::$postalCode in /Users/gina/Sites/thinkup/webapp/plugins/foursquare/model/class.FoursquareCrawler.php on line 411


Maybe do an isset check first, before assuming this property is set.
закэшируй в лкоальном филде с мапой!
@iscra, I am not clear, why would I need the mysql2 gem when I am using postgres?
There is a error when producing the jpg file, where the resulting image is a salmon colour don't know why will look into it
I will cherry-pick your commit, and fix typo in your commit log.
Note the since 1.6 part. iirc Spoutcraft is supposed to be 1.5-compatible.
Does it work when you define an empty timer isr?
```
EMPTY_INTERRUPT(TIMER0_OVF_vect)
```
Does BeatClock even need to take tempo in __init__ ?

Maybe default to None and setTempo if it is passed otherwise self.tempo in None?
FUCK EDDY !
Same thing here, the indentation doesn't reflect to which function call it is refering.
the only browser that is slower invoking fns via bracket notation is Safari. All the other browsers including IE perform equally well or sometimes better when using it. http://jsperf.com/bracket-vs-dot
Hi Logdog82, Thanks for taking the time to submit this pull request.  Would you please update the test name from 'delete-bla' to something that explains what the test is asserting?  Thanks! --Tyler
We should set array() by default
The only thing I think may confuse ppl is that it may fail to open some std headers that are in the compiler's private paths, like stdarg.h. But otherwise I think it's probably good to have this.
У Psi+ есть официальная векторная иконка. Причем уже не первая по счету. Всего варианта 2-3 лично я видел...
Should be: `(var+'run').mkpath`
I'm a bit confused as to how this patch could help. Are you sure you didn't mean:

```
import Data.Monoid hiding ((<>))?
```

Also, I think that `(<>)` is only exported by Data.Monoid in ghc 7.4; so to retain the ability to compile on earlier versions, wouldn't some CPP conditionals be needed?
Comment this before compiling to have parameters be case sensitive, or un-comment it so that parameters are not case sensitive.
Are you saving much by specifying this :select as opposed to just letting it select * ?
This may actually be caused if you didn't clear the cache after updating. Run `:PowerlineClearCache` and the problem should be solved. I'll bump the cache revision later so nobody else experiences this issue.
-- Adds editurl = None to the class body.
-- added a new optional argument to the get_config method. If set to True, while validate Integer and Float using Jqgrid's built in validation
-- Other validation's can easily be added by following the above methodology. No forms are required to be passed in.
why did you overwrite existing files with complete different functionality?
Why "clazz" instead of "class"?
Does this method need to be public? I'd quite like to hide away al the URL Part stuff if we can
Please use CollectionFactory.createStringMap() instead HashMap
Heh, Yes, at some point that will be absolutely necessary!
Can anyone write a version for CouchPotato that generates PyTivo metadata?
I do agree with the wp-* adjustment. There are quit a few plugins that use the "wp-" prefix.
**Important:** this was vulnerable to a **JavaScript injection**, because it wasn't escaping `\`. So for example:
`\"` in the input becomes `\\"` in javascript.
Besides, we can call the function directly from Java (see below).
heri,

you shouldn't need to do geo code validation in datawinner (entity/helper.py). The geocode validation is already done in mangrove. please rework on the fix. Lets discuss the implementation.
could you also put better comments in the commit (example Fixing sheet1 line 22 doesn't provide much information)
Hi,

I see you access it after payment request with request_payment method. I think there is noway to access it with recurring profile_id with using profile method because I couldn't find transaction_id at Response object. http://www.paypalobjects.com/en_US/ebook/PP_APIReference/RecurringPayments.html#2717594 

Thank you very much for your answer. 
Best Regards.
If there is no way to remove attributes from the SVG elements we have, feel free to implement this.
Having the two different String be ```True``` and ```true``` is just.. plain stupid. There are so many options, depending on what you want to do. Using enums, booleans, flags or strings that make sense like: "true", "false", "verbose" or "silent"
This leads to crashes, since stream.session is used at many places - espectially in callbacks (socket close(xmpp-proxy.js) - for logging, stream terminate in bosh.js.
Null check, for safety?
changed field separator to ':' from ',' since all values in last field are comma separated, this will allot for distinction.
Typo in comment (doh!). First word s/b fulltime.
popcorn mode on
+1 to consider this
Ok,  this kind use of `Internal` I'm not immediately concerned about.
 I did clean up your code a little bit
[here](https://github.com/lpsmith/persistent/commit/c28937aeba5f2874bea2e545219e5da35aa388b5);
 the use of withConnection would have avoided the breakage.  ;-)
However, there are a few things to point out:

1.  Beyond the process running persistent,   this isn't really a
"streaming" interface;  exec blocks until the PostgreSQL backend is
finished returning results.

2.   I have attempted some approximation of a streaming interface
[here](https://github.com/lpsmith/postgresql-simple/commit/bce0d389fd16a35a88841bb8434fab264b824993),
  note the caveats (although judging from your code they don't apply
to you)

3.  Your second point might be an interesting one.
Pikachu I suggest you the SiyahKernel source for SIO :
https://bitbucket.org/gokhanmoral/siyahkernel/src/4b7a08ee8bcc/block/sio-iosched.c

This one is fixed and I use it in my kernel.
백작가님..ㅋㅋ
Keeping things compatible is sometimes a bit ugly.
should be enough. what camera are you using? i am on vacation right now, will check on that by next week
@sandal @ryanlecompte  thanks I will write up a summary of this discussion and post it to mendicant-research.. unless you want to announce about Newman there first greg?  To me this points to moving to use some form of composition rather than mixins when your interface starts to get huge.
This pattern: Object.new, class << Object. Repeat over all code.

I don't understand this. Could someone explain me? Why  not use Singleton for ex.?
Well actually to be honest the CVV does get saved in the session for a short time during the checkout because of the way how 3-D Secure works…
Maven doesn't have Android 4.0.3 available in central (yet). I'll get in touch with them and see if I can move things along.
>>> It's a subtle difference, but I truly do not like mixing 2 programming paradigms in the same method.
I agree. But I don't like compiler warnings even more and use -WError.

In the project's readme you claim to support both ARC and non-ARC compilers.
I use only ARC target in my fork because it uses a newer runtime and generates less compiler warnings. Your source code has not been changed (except of those warning related workarounds). The only difference is "CLANG_ENABLE_OBJC_ARC = YES" flag in the respective target.

You can create a separate target for retain/release style. Just copy my library and framework targets and set "CLANG_ENABLE_OBJC_ARC = NO".
I'll do it as soon as I have some spare time.
oh right - it was in gles1.0, but i think they removed it in 2.0 (i should really get an iphone...); can easily wrap into an ifdef tonight
I think the more efficient way is to pass the ResultSet directly to TT and iterate over it in the template.

in Controller
```$c->stash->{items} = $rs;```

and then in template

```
[% WHILE (item = items.next) -%]
[% END -%]
```
Fail :P

make ARCH=arm ..._defconfig
make -j2 (no spaces :P)
You mean _@ValidateOnMethodCall_ or _@ValidateMethodCall_, right? I think we haven't decided for a final name yet, but _ValidateGroups_ seems extremely unintuitive. But I think you might be onto something in this case ;-)
Added stmt_init() to make the use of prepared statements possible
Your version of qc-ril is pretty old, and perfectly standard. LGEQualcommRIL is only for the latest generation radios.
I'm not using the updated skia. I only committed it to have on file for after the Droid build is fixed.
As far as I can tell, this is only used to save the info into the Database. And the way it was, it was never saving the id's in my database. I had a friend use siri on his 4S since I made that change, and it saved the id's and before it never did.

The way it was coded it would only save if the other one was empty. Which should never happen. With the !=nil command in there, it will do the else, and not store anything...

So I don't see how there can be banning issues, unless someone has admin access that works at apple and gets the id's and puts them into the ban list...  On my personal server, the webinterface is only available on my Intranet at my office, or when i VPN in.
Parece que el problema está en los saltos de línea, debes tenerlos raros o algo
maybe use <(bee_find ...) instead of reading all elements to an array (files)..
I think the `set()` conversion is unnecessary and maybe even harmful... Have you checked this?
I'll fix the comment on the dockblock :)
url is actually a different parameter.  It was only used to display something on the JSP page itself.  We've disabled it for security reasons.  service was a common "hack" to support redirects.
Done in latest commit. I forgot to take out the commented lines, apologies..
This should be put into a template.  Also I know the foundation uses Xml::element a lot but I have no idea why. It complicates code unnecessarily and it makes grepping source difficult.
Is this intentionally global? Otherwise it should have "var" in front of it.
Is there a null object for MetricsGossip so we don't create a new empty one?
But can it be "existenceConfirmed" AND "addressTerminated"? If not, I think it should be one field with different possible values.
in case you didn’t know (it sure is not documented yet): you’ll need to run `akka-docs/sphinx:generate-html` in SBT to get the right HTML output
this is begging for memory leaks, please adhere to in-order reception policy
what if endpoint doesn't exist in the map, should throw exception here?
fair, I agree that explicitness is preferred even though this isn't a repeated *ticker*
non negotiable?! You got to be kidding. Oh well, in this case I will just have to stick to coding standards that make sense and grant you the privilege to refactor the code however you see git. FYI, it's a CI fork bro' and instead of wasting my time and yours being bitchy about left - right, right - left conditions, just use it to refactor the code-base so you can actually say there are rules.
Cool.


On Wed, Oct 24, 2012 at 8:40 PM, Stefan van der Walt <
notifications@github.com> wrote:

> In dipy/reconst/tests/test_dti.py:
>
> >
> > +    # Test fitting with different methods: #XXX Add NNLS methods!
> > +    for fit_method in ['OLS', 'WLS']:
>
> Oh, no, I'm fine with having both!
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nipy/dipy/pull/82/files#r1937029>.
>
>
it's always good to try to catch the specific exception eg ImportError

Imports like this are a pain as if you have a syntax error it gets silently ignored
and it would be valuable to define the "query_params" parameter in a doc block.
should only be called if there are errors.
OR Instead we could pass the 'parent' id (which would be the album or tvshow) as a param to the Announcement ? That's all I need.
@Voyager-xbmc @jmarshallnz : you're checking the boundaries of selectedFiles here anyway. So wouldn't it be better to get rid of the if here and make sure that selectedFile is always between 1 and movieList.Size()?

<code>
if (selectedFile <= 0) selectedFile = 1;
if (selectedFile > (int)movieList.Size()) selectedFile = (int)movieList.Size();
</code>
My understanding is that for new files we just need the current year (ie 2012)
If you didnt have this stateful 'min_days' variable, you wouldnt need to use getattr ;) ;) ;)

lets move those into function signatures.
Just re-read, misinterpreted attr/method stuff.

There are already too many attributes that are just aliases for config options. Option logic should stay in `OptionStore`!

I'd be okay with `self['interpreter'] = self['interpreter'] or self['python_bin']` in the `RunnerOptionStore` constructor.
Should raise an exception?
What is an APT processor?
Is there a reason for not having the fully qualified name `Predis\Connection\ClusterConnectionInterface` here and above?
I changed the method if block. API developer can now use 7 HTTP Verbs supported by requests.
Please put the asterisk next to the parameter names, instead of next to the type.
@galaxas0 No need for the accessors/ivars in those cases then, right? I was just following the established pattern in this case.
uv_stream_t? gcc complains about it:

```
[12/18] CC obj/deps/uv/src/unix/libuv.stream.o
../../deps/uv/src/unix/stream.c: In function ‘uv__write’:
../../deps/uv/src/unix/stream.c:763:5: warning: passing argument 1 of ‘uv__handle_fd’ from incompatible pointer type [enabled by default]
../../deps/uv/src/unix/stream.c:702:12: note: expected ‘struct uv_handle_t *’ but argument is of type ‘struct uv_stream_t *’
```
Good catch! Fixing.
it is a bit weird that the ordering is different in each case.
Not related to this commit, but I wish if we can rename it to `newWorker` for consistency.
Indeed, very interesting, nice work @jayvius!
Yes, void pointers can't be used in arithmetic. I just wanted to make sure we fixed all the spots where it could be an issue.
For the records, you could write something like `status = 200 if success else 409`, but it's matter of taste.
It may be useful to copy over one or two examples here as well, wdyt?
I'd put both `Hashing` and `MurmurHash` in `scala.util.hashing`, perhaps, and put deprecated aliases in `scala.util` for `MurmurHash`.

As for the type class hierarchy - currently `Hashing` is not extending `Equiv`. If such a thing is problematic, I do not think we have to do it yet.
The only current use-case for `Hashing` are `TrieMap`s and the `areEqual` method is not necessary there. Do you think we should have it on `Hashing` otherwise?
Actually now I remember why I didn't use 'qual.tpe.memberType' - it is actually what makeAccessibel/checkAccessible is calculating and it forces dealising of Repr which is erroneous, hence ErrorType. Or maybe we should checkBounds here rather than delaying it (though it wasn't so easy when I looked into it + it involves some code duplication probably) ?
Did we loose something here?
This is much nicer.
I wanted this method off `Macros.scala` to simplify the code, but there's no `typeInfo` object unlike `treeInfo`. After doing some search I figured that people using methods in `Types` for this purpose. What'd be a better place to put my method into?
I was trying to force use of lib64 (auto detected) through all the files, but it looked like to complex for my first attempts, the symlink looks a lot easier - one fix and ready ...
no, good call. it should check for None and put in None. We should perhaps update parse_time. It should return None if given None. That would fix this problem.
Are multiple plots with the same range supported here too?
Shouldn't these relations be tested? It seems to me the only test for this PR is the one line at the very end:
```
assert Dagger(A).is_commutative == False
```
so this PR should be much more tested.
why was this deleted? (And if it was accidentally and no test failed then we should add a tests for that.)
Would it be nicer to have this return {{1,2}, {3}}? If you subclass from Union it will handle arg sorting for you.
I believe this is the only thing stopping this from being merged.
`using its regular method`?
You'll have to explain to me why this is better to do, but I went and did it in 5f865d2
iVars removed.
good god, you're right. This is... WTF? OK, let's try this again.

* `so` is ignored entirely
* `fTarget` is removed
* `fLight` is set to `nil` if fTarget had a non-nil value

This is all stupid.

How about:

    void plLightModifier::RemoveTarget(plSceneObject*) // argument intentionally ignored
    {
      fLight = nil;
      plSimpleModifier::RemoveTarget(fTarget)
    }
mock的方式不对。先记下来，用完再还原。
It's worth noting here that the design is meant to follow Mako, and put in a link to the doc for that function.
Great idea. I like this a lot better than the unnecessary hash.
Should probably still namespace this as Netrc::FileUtility, just in case.
I think so. Even if handled elsewhere, should still be defensive here since the UI always gives empty instead of null.

On 20 Oct 2012, at 05:26, Ben Hood <notifications@github.com> wrote:

> In kernel/src/main/java/net/lshift/diffa/kernel/config/WindowRefiner.java:
> 
> > +    if (offsetExpression == null || offsetExpression.equals("")) {
> > +      end = now;
> > +    } else {
> > +      DateTime startOfDay = now.toDateMidnight().toDateTime();
> > +      end = startOfDay.plus(periodFormatter.parsePeriod(offsetExpression).toDurationFrom(startOfDay));
> > +    }
> > +    DateTime start = end.minus(periodFormatter.parsePeriod(periodExpression));
> > +    this.windowInterval = new Interval(start, end);
> > +  }
> > +
> > +  public boolean isRefinementOf(String start, String end) {
> > +    return intervalFromRange(start, end).overlaps(windowInterval);
> > +  }
> > +
> > +  private Interval intervalFromRange(String start, String end) {
> > +    String iStart = start != null ? start : "1900-01-01T00:00:00Z";
> In addition to checking for null strings, should we not also check for empty strings?
> 
> —
> Reply to this email directly or view it on GitHub.
>
> what it does
That seems fair. I'm still getting my head around the notion of a participant though, and how this code fits in. UserScanningParticipant seems like a good choice though.
Introduced unused import, also some other legacy unused imports here (IDE identifies them correctly)
No, because the ID auto-creation (eg. `wiki.content.injectSectionIDs`) isn't a part of the processing chain here, and that section does not actually have that ID without it.
Good point;  added.
Ah, yes. You're right. I'll change the code accordingly.
Sorry, I should have looked more closely at the code before dashing off that comment. Yeah, that makes sense. I still think it makes more sense to separate the RegExp-string-building logic from the caching, though. So it would be invoked by something like `RegexpCache.get escapeRegexString str`.
I don't agree, please scrub password at least.
Per comment above, I think it should be 0
You should probably be using xargs for this, as then you don't have to use echo_e at all (same below):

```bash
xargs grep "^Parse error:" $errors
```
Well I did that now, but recognized one problem.

If you updated your files, but not your database yet (f.e. files were updated through git and you just want to run the install/database_update.php, you can not visit your forum anymore:

```
Fatal error: Uncaught exception 'Exception' with message 'DateTimeZone::__construct() [<a href='datetimezone.--construct'>datetimezone.--construct</a>]: Unknown or bad timezone (2)' in E:\phpBB-development\htdocs\phpBB-git\timezone\phpBB\includes\user.php:131 Stack trace: #0 E:\phpBB-development\htdocs\phpBB-git\timezone\phpBB\includes\user.php(131): DateTimeZone->__construct('2') #1 E:\phpBB-development\htdocs\phpBB-git\timezone\phpBB\index.php(24): phpbb_user->setup() #2 {main} thrown in E:\phpBB-development\htdocs\phpBB-git\timezone\phpBB\includes\user.php on line 131
```

Maybe we should bring this back then? or atleast default to UTC instead of displaying a white page
Is $style_id taken?
!empty() is not really needed, is it? You should be able to do just:
`if ($exists_who_can_read && $cannot_read_topic)`
Use INCLUDEJS
Well my concern with it wasn't so much the "inline" part but the "javascript" part. But I guess there's no way around it.
Well at least it should use the mock then
could this be changed to automatically register auth types like i suggested for adapter classes somehow?
这里用 sequence，方便无脑批量创建。

FYI: https://github.com/doitian/19wu/commit/43af16ad79302c73ecc7ec68aef92bbe6d813acf

`sample` 是让每次运行值不一样，强迫写测试不要直接依赖 factory 里写死的值。
Could be shortened to
```js
this.repeat = options.repeat - options.repeat % 1 || 0;
```
Single-line if-statement should be wrapped in curly-braces
Add new line before // Then
The baked-in RAisms all through this are the main reason it hasn't been
merged ;)


On Thu, Dec 6, 2012 at 10:23 AM, Matthias Mailänder <
notifications@github.com> wrote:

> In OpenRA.Mods.RA/Widgets/WorldCommandWidget.cs:
>
> >
> > -				if (!World.Selection.Actors.Any())
> > +			if (e.Event == KeyInputEvent.Down)
> > +			{
> > +				if (e.Modifiers == KeyConfig.ModifierToCycle)
> > +				{
>
> This should not be hard-coded to Red Alert SHP names. It will break other
> mods including d2k.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/OpenRA/OpenRA/pull/2000/files#r2327326>.
>
>
Is it possible that any of the following is responsible for #2455?
All strings belong in shared strings.xml file (this may not be solvable before you commit this code. Still, it will need to be done in the very near future if not within this commit). see https://raxaemr.atlassian.net/browse/RAXAJSS-151 and ask Tarang how he is handing this.
jsbeautify awesome tool.. thanks :)
Make sure to watch the tabs/spacing (run through jsbeautifier.org if you need to see how it should be) -- also, let's keep this docked to the left for now.
Need to create a JIRA ticket to track any such TODOs, ~"add supporting for taking photo of family's home".
There should be a link to that ticket from the code.
This conforms to the pep but not to the Iris coding conventions,
which require a newline after the quotes for multi-line docstrings.

Apologies for this most trivial request, especially as it is pep-compliant.
remove parameters (use properties)

add description of what this function does:
determine page_path, scripts, vars (db folder)
I think you need to update the grad signature to take as inputs the same variable as what is in the apply node. I ran all the sparse tests and this didn't raise error. Can you check that this op grad method is tested?
Even in the general expression case, the list of underlying base columns that triggers an index update is useful.
On the fast path, it also continues to serve as the description of the index key. 
I don't see a lot of leverage in layering on a list of pass-through TVEs, and I am hoping to keep the original code pretty much intact as a fast path.
Can we go a couple steps further, here and make this truly simple AND more effective?
First, there's no need to pass the plan into the recursion -- it's just used as a fancy hook on which to hang the send node -- if we simply return the send node, the caller can attach it to the plan:

plan.subPlanGraph = recursiveFindFragment(plan.rootPlanGraph);

OR maybe just inline the whole routine: 
<pre>
    List<AbstractPlanNode> receives = plan.rootPlanGraph.findAllNodesOfType(PlanNodeType.RECEIVE);

    if (receives.isEmpty()) return;

    assert (receives.size() == 1);

    ReceivePlanNode recvNode = (ReceivePlanNode) receives.get(0);
    assert(recvNode.getChildCount() == 1);
    AbstractPlanNode childNode = recvNode.getChild(0);
    assert(childNode instanceof SendPlanNode);
    SendPlanNode sendNode = (SendPlanNode) childNode;

    // disconnect the send and receive nodes
    sendNode.clearParents();
    recvNode.cacheDeterminism();
    recvNode.clearChildren();

    plan.subPlanGraph = sendNode;
</pre>
This is removed from the base class, as it is handled differently in each subclass.
I don't see this as a hack. We are using model forms in a slightly different way than was originally intended; this is clearly documented.

And there is a reason for overriding is_valid; have a look at the geometry validation that's happening there. Is there something particular that isn't clear in the code?

I implemented it this way (instead of using per-field validators) because I didn't want all of the boiler plate required for defining all of the form fields. As you can see from this pull request, the validation is quite simple to extend for new calculators: just define a validation function for each new field, then define the list of fields you want to validate. That's it.
Oops, the `if` statement should read `if (bigout < std::numeric_limits<T>::min() || std::numeric_limits<T>::max() < bigout)`; it's tautological as is.
I'd like to avoid having numbered identifiers. This seems like something that belongs in the support module.
As I said previously and still feel very strongly about: I'd like to avoid creating new API. "_" prefixing doesn't cut it.
In the event that the file is truncated, the old code would alert for failure in the event that the input file was truncated, and did not contain an even multiple of 4 bytes.  This change will silently stop processing, which is a behavior change.
On my systems it's always `/dev/ttyUSB0` as I use a USB-to-serial dongle, and only got one of those, so I believe the current default is a good guess.
I totally agree. +1 for nixing that line.
Well, since these docs assume the password is 'password', this needs to be here.
That's an odd place to put the open bracket, and for symmetry, let's add brackets around the first == condition, too.
No, unfortunately they perform visible actions regardless of which options they are passed. I am simply testing for existence; is this done elsewhere?
It also needs `libz` as a dependency, how do I add this? I think that's why I had X11 as a dep.
These new types are public. They are used to define input/output of public functions. I will rename  them with a sqerl_ prefix.
Or better example https://github.com/owncloud/3rdparty/blob/master/Sabre/CalDAV/CalendarObject.php#L74
Better would be to use 'user_help' and 'admin_help' as route names, and add the route definitions with mode set.
Can we put a TODO or something in there noting that we need to handle disconnects and reconnects better once we've updated the SSMI library to make it possible?
This module is already loaded through universal. on line 17
Also consider `words.map { |w| ["%#{w}%"] * 2 }.flatten` probably pull the 2 out as `number_of_fields_to_search = base_search.scan('LIKE').count`
The Class instance comes before the test name in all of the creational methods that take a Class, so I think we should order the constructor parameters similarly.
@marcphilipp 
@dsaff 
@kcooney 
@dharkness 

I would be very happy to remove the constructor Timeout(int), but i am worry about what would happen if i do.
So i simulated this scenario, where your tests dependent on 4.10 using Timeout(int) suddenly change the junit version without recompiling the tests based on junit 4.11.

This will happen:

Exception in thread "main" java.lang.NoSuchMethodError: org.junit.rules.Timeout.<init>(I)V

If it's the rule to update the documentation, then we should do it. If not, then i will remove this constructor.
Separate method isn't needed now.
I think Adapter is probably fine, but if we went with something else I'd say `_ContentAdapter`, which dovetails with the `ExternalContent` model.
I don't think this has any effect, and it could be deleted
We should decide on a consistent terminology. We've got 'www_build', 'browser', and 'mobile_web'. I think 'web' would be a good compromise for all of them, since that's really the difference - it's on the web and not installed on the device, and 'mobile' is superfluous. Until we sort that all out, I'd rather keep this consistent with the target and call it `is_browser`
Commented added. Ultimately I think we want test media that we can make public so that anyone can run the tests. I commented about this too
The acceptance criteria specified limiting it to "n", so the number was somewhat arbitrary. I picked 8 since Coda and Sublime have that limit. They don't show scrollbars for hinting which is likely where there is a limit. I noticed DreamWeaver shows more, but shows scrollbars as well. I think we should leave the limit for this sprint and then revisit when we get more designs from Garth and talk about whether to have scrollbars with hints.
Typo ``errorw``?
Since we're starting to build this external metadata file, we might want to take a look at the `package.json` format that npm uses. It might be useful to have our format be compatible with that unless we have a particular reason not to, just because various bits of tooling in the JS space tend to assume a package.json-like structure for metadata. (That said, I don't have a specific use case for this in mind--one might be if we wanted to deploy Brackets as a node module, a la what the AppJS guys are trying to persuade us to do :))
```text()``` automatically HTML-escapes, so no need for the second escape (which will actually break formatting if any escapable characters are in the name)
why'd this get removed?
Really? Do we need these comments?
This seems like it shouldn't work? the intention of popover is to apply it to a specific element...not the entire document?
this works. was going to deal with the args and kwargs all over the place at some point, and this helps. i started on the args and kwargs path as an inspiration from couchdbkit...guess that isn't the ideal place to find best practices.
check out what set_key_kwargs is doing…

On Sep 13, 2012, at 2:56 PM, Daniel Roberts wrote:

> In corehq/apps/adm/models.py:
> 
> > +    def row_columns(self):
> > +        return ["name", "description", "couch_view", "key_format"]
> > +
> > +    _couch_key = None
> > +    @property
> > +    def couch_key(self):
> > +        if self._couch_key is None:
> > +            keys = self.key_format.split(",")
> > +            key_vals = []
> > +            for key in keys:
> > +                key = key.strip()
> > +                key_vals.append(self.key_kwargs.get(key, key))
> > +            self._couch_key = key_vals
> > +        return self._couch_key
> > +
> > +    _key_kwargs = dict()
> 
> Setting _key_kwargs to dict() out here makes all instances share the same key_kwargs. Is that intended?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Can you make pinUnpin throw if it doesn't work?
Sorry I didn't read or respond very clearly.  We need to say something like x and y are scaled, but other aesthetics are not.
That definitely looks wrong - if there was no facetting variable it should be duplicated across all the panels in the plot.  But I don't see how to get that info, because it's the facet functions that are in charge of adding the data.
Actually the last line is first translator. Somewhere lower is last translator
Why did you remove these 3 deftests and the 2 deftests below.
Clean up this indentation perhaps?
that's a flaw in the tooltip system. 

IIRC, I kept it similar to the old tooltip setup which returned the tooltip element and not the object created. probably so It wouldn't break code elsewhere.

perhaps we should just change that?
add the iframe-template class back
extra space after closing ]
(or its CSS above)
did you mean for this to be 2 spaces indent not 4?
But then that part is like article..
See org.sonatype.nexus.rest.model.XStreamConfiguratorLightweight as this affects nexus-client-core too (actually all clients using it)?
Shouldn't in clients this happen in opposite way then, if this change is applied on server?
显示的时候怎么没有换行了？还有下面的concat_ignore_file_error也是这样。
Uhh any reason this isn't the full license header?
If the POST doesn't have a tags key, then ``data.get('tags')`` returns None which isn't iterable. So then this dies. Probably want to do ``data.get('tags', [])``.
Could we take a step back here, and figure out what the problem is?

We all seem to agree that 'uniqueness' is paramount (?).

But what you seem to suggest is to use a static IQN (com.sun - or better - org.zfsonlinux) with a 'random number of digits'. I fail to see why this is better than my solution.

Imagine hundreds, maybe thousands of targets, all with a large number of digits. There's no possibility to figure out or distinguish between them. Can't remember if it's possible to 'backtrace' the iqn to the ZVOL, but even if so, it will take some administration overhead.

As an administrator, what would you prefer? A nice readable list where the share name is in (almost) clear text, or a list of random digits?

I.e.:

  iqn.2001-04.org.zfsonlinux:01:13104831232857787788:43214

or

  iqn.2012-01.com.bayour:share.test1

Neither of these are 'forbidden', the're both part of/allowed by the standard. Granted, I have interpreted the "date that the naming authority took ownership of the domain" to mean 'date when the target was created/shared". But this seem to be a valid interpretation, at least if one looks through the big, bad 'Net :). Besides, the IQN is supposed to be the domain you're running on, not a generic one (com.sun or org.zfsonlinux). Or at least that's how i interpret "reversed domain name of the authority", although your interpretation could stand as well.

And about the 'domain names can change ownership', if that happens, a lot more changes have to be made on the system/site/network and not just a iSCSI target name.
For consistency, should this be `if !session[:original_uri].nil?`
This should not be there :/ I've committed it by mistake. `__END__` stops Ruby interpreter from evaluating rest of the file. I kept the old implementation around just for me to better see the changes and not to forget about something. I'll remove it.
That's fine too since I guess there are no falsy charsets :P
I wrote it myself specifically for this commit. I can give it whatever license is most convenient for SignalR.
Or just point it at `/` and avoid any doubt. `/search` is already hard-coded.
Is there ever a use for running test.sh without running emulator.sh?  Could you just merge that file directly here?
This may also apply to @mdboom's PR he submitted to @astrofrog - I didn't look...
Wouldn't it be saner to just extend the enum? The reason that enums can't be extended is that the compiler and programmer can make assumptions on what values to expect. This breaks that assumption.

If there's a good reason to do it this way (I suppose so) please add a comment describing that.
You set ``info2`` here, but use ``info`` below ... why not just re-use info?
thank you for making this failure explicit.
That is exactly true. Two of the test case where causing some sort of deadlocks during the execution. The task system of the Application was not running properly. The ugly workaround for me was to bypass all that. See the mock_application.py (line 223) : 

```
    def schedule(self, callback, args=None, kwargs=None, priority=0):
        # FIXME: there is a deadlock when relaying on the ScheduledTask
        callback(*args, **kwargs)

```
We use the format `station_id` etc.
ups, seems i left it out when developping and forgot to test it. done.
It would be good to put some pending specs in for the tag model itself as well -- always nice to ensure that the building blocks are sound, when we get to it.
PHP error :-1:
We should clarify this a bit - 'the caller' would normally mean the frame in which this is called, whereas this actually looks at the frame above that.

Possibly the function should take an optional depth argument similar to `extract_vars`.
Should this be ImmutableMap instead of ImmutableMap.Builder since we only assign to this field and do not mutate it?
I'd change this to Iterable as opposed to List.  Lists don't add value in this case (order or ability to add duplicates)
yeah you are right .. correcting that right away :P
Agreed. I fixed this before merging.
Because READ_INDEX and WRITE_INDEX get computed from settings... but settings_test hasn't stomped on the settings at the point the module gets loaded.

The other way to fix this was to make READ_INDEX and WRITE_INDEX functions that calculate the strings every time. But ...I was kind of wishy-washy about it. It's cheaper processing-wise to do it this way, though it's a little grosser here.
total nit but could we alphabetize these properties?
I don't understand this method. Something's got to give. 

If this method just continues where `__init__` left off, then make it a private method and do call it from `__init__()`. Are clients of this class supposed to call this method more than once?
用户没有登录的时候查看文章会抛异常，我已经在merge中修复此问题。
тут би ще перевіряти чи мило відправилось. Ігор знаходив приклад
Performance wasn't the primary motivation of this PR, but I agree I should have added some performance numbers.

> To match route baz there is now a performance decrease because the simple equality check is wrapped by 2 prefix tests

On average the performance increases: There are also extra prefix tests added on previous routes, so at the time the tests of this particular route execute, the matcher already gained some performance due to previous non-matching prefix tests. For each non matching prefix test, at least two route matching are saved.

I did a simple test that matches all possible routes in this test case 50K times each:

master: 7.4s
routing-php-dumper-simplification: 6.4s

The improvement should be bigger as more routes are added and less explicit route collection prefix are used. However you are right, there is a small performance loss on the few first routes of the matcher. I'll see if I can improve that.
platform... is it a typo?
Also, this is because of the PSR proposal attempt, or whatever that is, from one of those two earlier tickets.
There's still no direction to actually know what interface should actually be implemented so I've just implemented that and I hope to get some feedback on it.
Unit test :)
I prefer plain English to be consistent with other message catalogues.
you need to add an empty line in the phpdoc after the short description
Hmm, its FOS_facebook auth break all
Try `build_stubbed` here.
The boost version won't work, since (dimension - m) isn't known at compilation, I used the other one
Agreed. Fixed with 15a08f7.
I'm totally happy to leave things are they are for now, and potentially indefinitely.
This takes the import with the maximum confidence value as the one to try.
`typeToSkip`
Now we are dealing with to states for a pending SMS. This is for differentiate between error messages while we were sending to network and SMS that are not sent to network yet.
Bloqueo -> bloqueo
Create 'ThreadListUI.pendingListDel' or similar in order to store pending messages for deleting when execute 'done' action.
We should probably make this a constant defined at the top of the file. Also, what's the expected size of a 'good' thumbnail? Is it below 10kb?
Please note that I've had to pull data from the settings since radioState is not exposed as cardState is. Maybe it would be better to expose it, or do you think the solution pulling state from settings is enough ?
Could we create some classname like `.fbdialog { display: none; }` and the another rule like `.fbdialog.visible { display: inline-block }` ?
In this way we will avoid  50 lines of css that all of them do the same.
I don't see the string 'confirm' defined in the locale file anywhere.
After talking with Silvia (UX) and she has nothing related to increase height of input in bottom bar... I've removed this effect (I have kept the code of this functionality) and we are going to check again next week after our 20th release what happens with it.
Why do you have to check for null here?
It is independent. I left this in since allowing for overrides via JVM_OPTS seems to be the more standard java approach for application specific configuration. Since storm currently isn't ipv6 compatible, I think that the ipv4 fix made better sense as a part of the exec_storm_class configuration.

This piece probably makes sense as part of a larger refactor of this script, would you like it removed?
This code should be pulled out into its own function since its used in both spout and bolt code paths.
What that weird character? BOM?
I might recommend injecting these classes into your constructor instead of hard coding them here, eg:

```ruby
def initialize(mappers, edge_builder = RelationRegistry::Builder, mapper_builder = Mapper::Builder)
  # ...
end
```

I mentioned this to @snusnu in irc with a bit more detail: http://irclogger.com/.datamapper/2012-10-27#1351379401-1351379924
I´m not quite sure but shouldn´t this happen before the controller gets destroyed? Or is this exactly what happens? This is just a question :wink:
Sorry. It's trash. My bad.
These two lines should be in if clause.
I think line [196](https://github.com/philipvr/hotdrink/blob/9ddc7d2bc6cc1e9f20fd8da2386f1b04eba67c93/lib/model/proxies/array.js#L196) should read `ASSERT(vv.cellType === "interface",` (I probably already made this change in my jslint branch.)
If we're just going to re-raise it, there's no need to handle it here.
ID field will be hidden so errors should be redirected to visible element
It'd be useful if this had a message as well.
Indeed, the idea kind of makes my head hurt.
you are right!
run proj.linux$ ./bin/debug/HelloCpp error
proj.linux/bin/debug$ ./HelloCpp right
Anyway it seems fine for now so I'll merge, but if you think you can improve according to what I just wrote, feel free to send a new PR.
There is a specific error to throw (see in errors.js): `_errors.createInvalidReqMissingCommandParameterEH(req)` is the method to use.
agreed^.  I can't beleive we have not made custom excpetions to this point.
Take care of the naming for ecmd files: http://old.ethersex.de/index.php/ECMD#Eigenen_ECMD_Befehl_erstellen -> Vorbereitung
are those real ip?  if not, no need to blame Chinese for no good reason ;)  lets use 192.0.43.10 corresponding t o reserved example.com ;-)
It's in C code to decide the CPU id.
per our conversation on irc i will try using Stub::interval instead of rufus scheduler.
Any particular reason for the setTimeout? Is `reset()` asynchronous? If yes a comment would be helpfull.
I don't quite get the latter example here yet, the former one I can agree with though.
Also, it's hard to see value in some of this features until using promises extensively.
"as a commonjs module from a module"
I wonder if it would make more sense to do `let stack = error.stack || Error().stack` instead and rest of the frames, `lineNumber, fileName` normalizations from the above outside of `if / else`.
fixing this...
Shouldn't the IdP be interpolated into the span before format puts it into the string... or do we do this via a DOM manipulation?

It's nice that you've kept HTML out of the string... but it also increase the risk of a XSS. We'll need to be careful about validation with email addresses before we parse out a domain name.
You'll want to ask Crystal about this. This was the approved copy that I was given :)
use background is enough, no need the image. and i think you don't have to keep typing "background-image" for different browser. You can fit all into one property.
Simplify to 
  #@return [Boolean] if debugging is on or off

?
Does this comment still apply now that the helper methods have been added?