labofsahil/github-event-dataset-2012 huggingface dataset:
See my comment about the question whether it would make sense to expand subject and title arrays so records would have a single title and subject only (https://github.com/bartvde/geoext/commit/b52d053fb7224cf4a9c630a00392b1e40d561920#L1R7).
To address the FIXME above, you could store a reference to ```data``` in ```this.raw``` - we already have this in the library for the StylesReader, and will also add it to other readers (e.g. WMSCapabilitiesReader) at some point.
It was intentional, it seems to me like instructions to help creating new projects, like building new packages based on Theano, and I don't think that is in the scope of that documentation.
Could this be changed to endswith? ```--batch %10``` is a little bit less intuitive than ```--batch 10%```
On 25/01/2012 01:53, Philipp von Weitershausen wrote:
> You're gonna want to check the origin here.
The origin does not make sense at this point since everything is serve 
from the same.
> Otherwise any app can totally fake these. Also, "answer" and "hangup" for event names seem awfully generic.

You're right. I have fixed them.
yes very intresting "cake" the solution to everything
There are three 20011 (one too much zero)
und es ist zusätzlich böse: emp remove ../../.bashrc ... löscht selbige ;)

Wieso > 2? Es müssen doch genau 2 Argumente sein ;)
hmm mby the same reason why we have lags after some hours uptime on GC too.
угу, типа того. если заработает не забудьте в R2 залить...
I have problem in Trial of the Crusader, when speak with announcer, boss it's come for 1sec and it's gone ! Why ?
это все одно и то же...
@Thermaltake

http://img827.imageshack.us/img827/20/topuptime.png

This machine was running for 612 days as a DNS server, i decided to reuse it for mangos testing and change DNS machine. But this uptimes are normal at least in linux servers.
да, действительно, в комплекте три собранные dll и все под x86. непонятно нафига. еще в комплекте либер и линкер от дельфи, но они тоже только х86 могут, да и вообще дельфи х64 без левых извращений не умеет, потому что померла очень давно...
теперь неудивительно, почему оно у boxa стала втрое меньше памяти жрать - пустите версию скомпиленную на x32 под x64 ОС - то же самое будет. ну и в скорости этого добра сомнения стали еще больше - не верю я что написаный на паскале псевдокод будет быстрее голого асма... так что пользуйте STD_MALLOC как и раньше и не страдайте херней.
you could do a `join` http://jinja.pocoo.org/docs/templates/#join
Great! I was thinking about to add this to the FAQ.
It seems reasonable to me.  Let me CC to the mailing list in case
someone can think of an argument why these functions should to take a
constant pointer arguments.

On 2012-01-16, Ivan Maidanski wrote:
> There exists some other candidates for constantization: GC_[debug_]end_change_stubborn, GC_exclude_static_roots, GC_add/remove_roots, GC_general_register_disappearing_link(const obj), GC_finalized_malloc. Correct?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/paurkedal/bdwgc/commit/9d07ead2d0bc217a3ded434372952f7a8db6c17a#commitcomment-871027
Yeah - kinda sloppy - i will fix. I am 'inheriting' the 'P' field from l_model; but wanted to keep the comment
why can't `assert_no_validation_errors` check that there are no error messages? seems like it'd be convenient
I assume this improves the JavaScript performance on this? If so, should definitely apply it to give JavaScript the fairest possible comparison.
需要注意若结合django自身的comments来使用django-simple-captcha，则要修改django的comments包的源码。forms.py文件中，在CommentDetailsForm类里面添加字段：from captcha.fields import CaptchaField   captcha= CaptchaField()。 comments.py文件中，在# Otherwise create the comment这句下面添加： human=True
Credit for pointing out the fix goes to yyuu: https://github.com/boronine/pypyenv/pull/6
Hm, I just notice that in prototype style simply adding a `null` check is probably not sufficient because the method would lose its `this`. This might be more complicated than it initially seemed.
But why it was ok with a python and bad with a nose? I don't understand the difference :(
Fixes the next stacktrace

ERROR 08/03/2012 07:44:39 [ClientRequestExecutor]/SelectorManagerWorker  
java.lang.NullPointerException
	at voldemort.store.socket.clientrequest.ClientRequestExecutor.read(ClientRequestExecutor.java:186)
	at voldemort.utils.SelectorManagerWorker.run(SelectorManagerWorker.java:98)
	at voldemort.utils.SelectorManager.run(SelectorManager.java:194)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:662)
IMO lost_pwd_page should also be added to this list of pages.
space seperates the /
Change merged manually.
Thanks for this patch. A couple of comments:

1. I would prefer it if you used strtol to do the actual conversion. Should be simpler.

2. You wrote: "I'm not 100% sure if this is correct. It works for posix.chmod, but I don't know if I should "and" the result with the input "mode" value or not for other functions (umask?)." I think your current design is the correct one: if you write an octal mode as a parameter where a mode is required, the mode should simply be set by the parameter.
@ozten - "Tooltip Anchor" is for front end unit tests only.
Make that definitely look at services/update.py
I wonder if we could make __init() filterable instead of having `instanceMethods`
FWIW, I usually prefer to do test cleanup before a test instead of after. Doing so has two advantages, neither of which may apply to an in-memory backend:

* It leaves test data in the db at the end of the test run in case I want to inspect it.
* It ensures that even if I have a test get interrupted part way through, the next test run is unaffected.

The more I think about it, the less I'm convinced this applies due to this being in-memory, but figured I'd mention it regardless.
maybe add `target="_blank"'`
This is actually here so that the "cannot change a protected metatable" error message is thrown in whatever called the setmetatable function. With this commented out, the error line will be line 82 of this file and not the script.
well thats a valid question .. imho a phpcr-implementation has to require phpcr so it would be redundant.
I didn't saw forum :) maybe before 2 months.. :) but thanks for your reaction, and GL!
There is no name of the database tables only.
These queries are adjusted in parallel with other files, which are poured into the database.
I know this is consistent with the rest of the code but MY EYES MY EYES
you cannot just go and comment out code like that. Somebody else might need that.
API, Impl, Precondition checks, Tests.  Beautiful.  Though I think I'll just change the command to "move" because that'll be more consistent with the other operation names like "remove" instead of "rm" and "addAsDirectory" instead of "mkdir".
good point, i will fix that
Nope. It surely does not.

> empty() is the opposite of (boolean) var, except that no warning is generated when the variable is not set.

http://php.net/empty
Why remove the default? Seems like it's sane to have 'id' or something be the default key to look for. As long as it's documented not sure I see the harm in having it there.
Eh, sorry i'm stupid. >: But this goes to Registry or the Client? As far i know the server doesn't directly connect to the Client Registry. Only the Registry connects directly to it.
/flame
Here @raymondcrandall : http://stackoverflow.com/a/6944827/144833
An excellent patch, taking it over to master, thanks!
`256 ** digits`
oops. this closes #3.
please change the version of Tag to 1.0.1 also
This guy deserves a cookie.
Looks got. I'll look into the text bounds issue & let you know.
haha :D happy new year ;)
Re: plan, do you have a work item for this? "- parts of the implementation of the rest of the cryptographic primitives (these will simply wrap existing functionality comprised in native libraries - OpenSSL for the C part (krypt-core-C) and JCE for Java)" I can help this if you like, I think.
I don't think I understand this change, once txComplete is true it can never go back to false - so why not return right at the beginning if txComplete is true, without any synchronization?
I am the only one who just can navigate trough only 4 buttons? But not the last one...
what i had meant by (codestlye) was " plr -> player, "
and snake traps are in scripting...
i think your clear with the other traps haven't fully looked.

also i'm still scratching my head on the
Dont Remove Stealth From Camouflage
was that just a typo in comment? or is that what you were really trying to do?
if so, that's not going to work
stealth and camouflage, first of all, only shares 1 thing in common with one another ...
invisibility types. enums.

~granted "snakes from that trap" should not be able to detect invisible players...
unless your character was the one that actually triggered that trap (camouflaged) by stepping on it..
then yes it will go pop and break the spell,

as far as stealth goes, as of patch 2.3.0 you can't even get with in range of a trap
there's a flare on the traps...
so even using disarm wont work for the rogue.

also...umm you are aware, that
// Immolation Trap
// Ice Trap
// Freezing Trap
// Explosive Trap
are all AoE traps, which that damage should break All forms of stealth..

again just questioning exactly what you were trying to do with those trap spells...
i could be looking at it all wrong but... /shrug
Just an FYI, this doesn't *require* you have "show" in the path.  That is, you could shorten it to:

`Router::addRoute("/applicants/:id", "Applicants", "show");`
Should go back also be initialised as disabled when the app starts?
Should be "UTF-8" instead of "UTF8".
Fixed, will commit later.
@main-- Basically you throw a couple extra lines into your config file (load the [`SuppressWithNearbyCommentFilter`](https://github.com/PneumatiCraft/OpenWarp/blob/master/config/sun_checks.xml#L25) and [`FileContentsHolder`](https://github.com/PneumatiCraft/OpenWarp/blob/master/config/sun_checks.xml#L28) modules), then append `// SUPPRESS CHECKSTYLE CheckName` to the line containing a problem you don't want Checkstyle to warn on. For example, I suppress the need-braces check on a bunch of `if` statements on OpenWarp, as seen [here](https://github.com/PneumatiCraft/OpenWarp/blob/master/src/main/java/com/lithium3141/OpenWarp/commands/OWStackPopCommand.java#L51).
* changed scikits.learn in the ipython code on line 39 to sklearn
I thought we had already fixed this.  In any case, looks good.

The fact that `merge()` modifies the object itself brings up another point, though: shouldn't merge and other manipulators return a new object rather than modifying an existing one?

Then `$pages = $pages->merge($livePages)` would be easy to implement on DataList (albeit still inefficient).
Will work on it.
是这意思

    *-config -> config
it meant to be a class for the translations currently the class for the translation is "ayah ltr" using chrome inspector, if you add the class trans to the translation the text size should decrease.
These strings also need to end up in Aurora ASAP. Please add to strings bug.
Name doesn't say what this does.

Change to "pinFieldsCompleted", add JavaDoc explaining what it does and what it returns.
New Pseudo-Classes and Elements are in there. The new properties are not. I wanted to merge this status however for now.
It should be ==, no?
Just to let you know you can't change the damage of hunter shots from spell_bonus_data try it =)
tpruvot   i made my first rom CM9-ICS-MR1-120201-jordan.zip today after your help.  i will upload it .
Does it work with 2.3 kernel (cm0). i am confused as you realease 1 rom for defy 31 Jan. 
so i want to confirm if my cm rom that build from your github shell be work with 2.3 kernel ,

many thanks
jeff
Syntastic plugin told me it was not used, and it didn't seem to break anything, tell me if i'm wrong ;).

it was mostly to test the commit bot we now have on usf-game, though. :)
Did you also solved ts in this, or is it to be added?
Any reason you didn't change the connection and developerConnection tags here as well?  I just updated the HFE pom, but don't really know how to test if it is configured correctly until I try the next release:prepare.
Trying to see what ics defaulted to I meant to change it back but haven't
had time
On Jan 22, 2012 9:17 PM, "turl" <
reply@reply.github.com>
wrote:

> Why was that removed?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/photon-dev-team/android_device_motorola_olympus/commit/2743bb68ad7bb9049135112e7ba7021fa9abd586#commitcomment-890990
>
Is bind(0, bind, null, 0) for binding `bind` and/or `bind.call`?
The API should be that widget->canEdit is all we need to check. Otherwise it's a bug in the API, IMO.

@ewinslow @brettp Who knows this system well? And does anyone know why $owner would be passed in rather than pulled from the widget?
Do we need this check here?
Since this is the current behavior, let's go with "if it ain't broke don't fix it."
Not sure I understand the need for this method throughout the code. How may this be used?
Okay, simplified it accordingly.
Question if the defaults for 2.0.4 should be the exact same as for 2.0.3 (2.0 with a very high max) so we don't change semantics, but we allow people to configure it on an as-needed basis?)
Perhaps use a Deadline instead?
Sure

11 jun 2012 kl. 16:52 skrev Jonas Bonér<reply@reply.github.com>:

>> @@ -878,6 +887,25 @@ class Cluster(system: ExtendedActorSystem) extends Extension { clusterNode ⇒
>> 
>>   /**
>>    * INTERNAL API
>> +   */
>> +  private[akka] def heartbeat(): Unit = {
>> +    val localState = state.get
>> +
>> +    if (!isSingletonCluster(localState)) {
>> +      val liveMembers = localState.latestGossip.members.toIndexedSeq
>> +      val unreachableMembers = localState.latestGossip.overview.unreachable
>> +
>> +      // FIXME use unreachable?
> 
> OK. So @patriknw, if you agree, will you change the code to reflect this? 
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/akka/akka/pull/533/files#r960119
There's no apparent semantics tied to this method
Yes, new branch. I'm getting with that idea and flow of it.
agreed. just waiting for the right moment in the change flow to make this change.
, Fixed.
part of me suspects the deep solution will involve namespaces.
Hmm.. there is no guarantee current mode is desktop so you can't overwrite it with current mode.
Instead of quietly switching formats, I would log "failed to parse _file_ as JSON, trying CSV"
`pop()` takes elements on the end, so you're adding jobs in the reverse order that they're used. Intended behavior?
Python 3 tests doesn't run at the moment because of syntax errors so we have to just write compatible code without interpreter help now. I'm not sure nltk can be even imported under python 3 at this point. How do you test the code unser python 3?
Wystarczy:
{if $serverTime}
that should be the first check in the loop
Now the reference chunks need to update themselves when you change a referenced cardname.
I think you are missing ! for the expression to be `if (!fw || !fw[row])`
I asked in the prev. review, but got no answer: Do you want it to extend  
Function1, or have a getCurrentMillis() method instead (Java style)?
How so? A responder can still be active if the window is main, even if it's not key.
also the handling in the catch block ?
It is dangerous to apply the configuration of a container to one of its children. I think you did this because you wanted this component to work as an instant replacement for an EditorForm or EditorGrid. But it would be better if the editor config option would take a configuration object for the editor child of the VersionedEditor.
[AbstractHtmlElement::_htmlAttribs](https://github.com/zendframework/zf2/blob/master/library/Zend/View/Helper/AbstractHtmlElement.php#L84) escapes on* attributes separately (using JSON encoding)
в .ts и .qm. .qm — это бинарник, который по .ts генерится. его нужно тоже коммитить
Ah, I see why this happened now.
I think that this should not be here.
should I adapt the text?
I can give it a less imperative and more suggestive reading
We missed this reference `Rails.application.routes.routes`. Moving the inspector was the easy part, getting rid of that line will require more code changes. Right now railties builds routes using ActionDispatch, but ActionDispatch doesn't actually know what routes it has. This is the method in railties for `Rails.application.routes`.


```ruby
def routes
  @routes ||= ActionDispatch::Routing::RouteSet.new.tap do |routes|
    routes.draw_paths.concat paths["config/routes"].paths
  end

  @routes.append(&Proc.new) if block_given?
  @routes
end
```

My first reaction is to keep ActionDispatch agnostic about where the routes come from, but to store the results, so that Railties can inject the path where it wants the routes to be drawn from. ActionDispatch, rather than just spitting out routes can hold onto them.

```ruby
def routes
  @routes ||= ActionDispatch::Routing.set_from_paths(paths["config/routes"].paths)
    
  @routes.append(&Proc.new) if block_given?
  @routes
end
```

Then we could have a getter in ActionDispatch along the lines of `ActionDispatch::Routing.routes`, how does that sound?


(on a side note we should also make Journey an injectable dependency rather than hard coding it into ActionDispatch, though this isn't the place or time for that)
o_O that was pure magic ...
Yep, perfect place for it.  I forgot where to find it and made a dumb assumption.

Looks like `SystemProperties` needs an `int` method to go along with `bool` and `str`.
I was very surprised to learn that there is no serialization suite for the collections lib.
On Tue, Jun 05, 2012 at 11:07:34AM -0700, Jacob Vanderplas wrote:
> >          M,N = self.shape
> > -        coo_todense(M, N, self.nnz, self.row, self.col, self.data, B.ravel())
> > +        coo_todense(M, N, self.nnz, self.row, self.col, self.data,
> > +                    B.ravel(order='A'), fortran)
> 
> I think there's a problem here: you never check whether B is contiguous.  If it's not, then B.ravel() will return a copy and the output won't be written to the original array.

Good catch. f2py has this annoying problem as well for non-Fortran
contiguous inputs, I wouldn't want to accidentally introduce more of that.
Yeah, you're exactly right. The tuple+string solution was supposed to be temporary. named tuple sounds like a better solution.
should this check for `self.args[0].nonzero`?
Ya even the rest of boolalg.py file itself does not follow that convention. Maybe I will keep it that way if it's okay with you, as its not a pep8 error anyways.
On 12.06.2012 19:11, Sergiu Ivanov wrote:
>> +    commutative in a :class:`Category` by supplying the argument
>> +    ``commutative`` in the constructor.
>> +
>> +    Examples
>> +    ========
>> +
>> +>>>  from sympy.categories import Object, Morphism, Diagram, Category
>> +>>>  from sympy import FiniteSet
>> +>>>  A = Object("A")
>> +>>>  B = Object("B")
>> +>>>  C = Object("C")
>> +>>>  f = Morphism(A, B, "f")
>> +>>>  g = Morphism(B, C, "g")
>> +>>>  d = Diagram([f, g])
>> +>>>  K = Category("K", commutative=[d])
>> +>>>  K.commutative == FiniteSet(d)
>
> Well, in `isympy`:
> ```
> In [6]: A = Object("A"); B = Object("B"); C = Object("C")
>
> In [7]: f = Morphism(A, B, "f"); g = Morphism(B, C, "g")
>
> In [8]: d = Diagram([f, g])
>
> In [9]: d.premises
> Out[9]: {A→A: ∅, B→B: ∅, C→C: ∅, f:A→B: ∅, g∘f:A→C: ∅, g:B→C: ∅}
> ```
> which is fairly not bad IMHO.  Do you think I should be using the `pretty` in the doctests?  (`use_unicode=False`, maybe)
>
> I felt reluctant to do that at the time of writing :-)
>

Yes, I think that is a good idea.
OK, I'll drop this test then.  I do get the point that the sort key is more of internal stuff and may change freely as long as it works as expected.
http://php.net/manual/en/function.create-function.php#80904
http://php.net/manual/en/function.create-function.php#14322

A lot of people relying on it (i've googled a bit). I don't think PHP team would broke this behavior in future.
Moreover it's working on PHP 5.2, 5.3, 5.4, 5.5-alpha1. I've tested it on 5.1
`Yii::app()->charset` should be passed as a fourth argument.
Wont' this block until the request is complete since we're not giving it a handler? If this is blocking we need to make sure this is never called from the UI thread. Seems like we're using the PostCrashReportTask to execute this in the background, but I'd like to make sure.
you get the idea by now
Maybe comment that this is the mesh element number?
it seems like it should be 0 to me. Lines up with the baseline of the username in both FF and Chromium.
http://en.wikipedia.org/wiki/Blank_node

    _:b4711

The number can change on each request. But I would use an increasing counter instead of random numbers.
opps forgot documenting..
right. mybe use: print_global_params
The name of this test is a bit confusing
I don't think this line is required.
I do not understand how that PR is related to an insert involving varbinary.
Then with the only variable being $table, use `table_name in ($table_names)`.
Use `$is_plupload` instead? Add docblock and use visibility specifier (probabaly `protected`) instead of `var`.
file looks good.
Yeah -- the python style comes through :-) Trying to let go of this habit
Can you stick with lower class attribute names please? :)
Why is this change part of that pull request?
All TODOS should have an associated issue in JIRA which tracks the TODO's completion. If needed, created a new issue to track this TODO. Add a hyperlink to the issue directly from the code. Don't resolve the issue until the todo is completed.
Related to @pelson's comments on the expected usage of this function, it'd be nice to have this more obvious in the function name... e.g. `project_nearest_neighbour` (although that's perhaps a bit long-winded).
I would have voted for adding an additional couple of methods instead of making this public. But I won't insist. :)
The break doesn't seem to do anything here given the assertion.

Does ".keySet().iterator().next();" make more sense? Maybe not.
Just don't give priority a default value
I feel that this file was copy-pasted from file_edit functionality. Please extract and reuse common stuff.
The message is pretty short, please keep it on single line.
See previous comment - there is a lot of inconsistency in which headers we are adding/removing across these files.
Just working off diff here but is that missing a self. ?
Not sure what is best doc approach here - CusomUser is not an actual shipped model - but documenting a hypothetical example and/or the included test model
If I'm not mistaken, `ModelForm.is_valid()` "cleans" all of the model (`self.instance`) fields. In other words, numeric fields will automatically convert their assigned values to the correct type before this validation function is called.

In short, the `isinstance` check is redundant.
I think this should this be an ``elseif``
Terence, we would appreciate it if your team was willing to take on this stewardship. This API was written by John and Yasuhiro.
At the beginning, the state table might still be empty. But the user might still want to check some argument. -> OUTER JOIN
Well, it's not a class member function, in which case 'static' means to make it not exported, which doesn't work since it's used from elsewhere.
Windows distributions for bash don't come with many of these by default, so we do soft checks instead of failing hard.
If these are to be public fields the names should be capitalized. Also maybe less cryptic names and/or some documentation on what they do?
Don't know if settings makes much sense, as this is the maximum limit of what Spotify is willing to return. Of course, we could allow people to set it lower, but I vote for waiting until someone requests a setting for adjusting this.
These five lines can become just one line using `models.CSSProperty.objects.create(...)`
Don't need this statement.
@Julian @jacknagel @Sharpie Pushed a new version with warning about 1.4.1.
This fileNames can be deleted right?
Why don't you wrap this line? Also it probably could be simplified.
admin_password and admin_tenant_name variables are not set.. this will break.. i think
Could just be `pages = list(pages)`.

Also, I think you should be using `tdb_cassandra.max_column_count`, though there's been talk of refactoring some of that.
Makes sense. Good call on adding the comment.
Why did this need to be done? Could this break any other feature?
You can use `#each_with_object` here so that you don't have to return the `hash` as the last statement in the block.

Don't forget to change the `#respond_to?` call on the line above too.
Oh!  Woops.  Srory - don't merge.  I'll fix.
Please delete tests ;) :P
Again, please no commented code.
yes, this code is just copied and pasted in from the ChildBrowser plugin distro.  don't think it's worth editing it for style.
This variable is unnecessary as the same information is stored in DOMAgent.url + the way it is used here is superfluous as the NetworkAgent will also match the original html file against wasURLRequested().
This only bails if we find more than FIND_IN_FILES_MAX results in a single file, and ignores all subsequent files. This leads to unexpected results.

For example, if you search the brackets repo for "brackets", you get 1362 matches in 193 files. If you search for "e" in the Getting Started project, you get 100 matches in 1 file (all in the html file) and the css file is ignored.

We're going to need a new "totalMatchesFound" variable, and bail once that reaches the limit. I think it would be best to have that limit larger than the FIND_IN_FILES_MAX, as mentioned in the bug comments.
Could you add a note here clarifying that (unlike `addMenuItem()`), this doesn't touch keyboard shortcuts at all?
For all these function args, we should document the expected signature.  E.g. for filter: ```{function(string):Array.<string>}```
Or rather, setting prototype.constructor on a subclass is necessary if you want subclassInstance.constructor === Subclass instead of === Superclass.  (I've yet to hear a satisfactory explanation of why this _isn't_ needed for base classes, though... is the default prototype object special somehow?).

But anyway, it seems like we might as well set both here for completeness.
Should we have autosave related variable here ?
Can this be moved to autosave plugin ?
A, right :).
I'm not sure about this. R and boost booth use location.
Ex. If the dashboard program id doesn't exist for dsr/fcts, the tab link should be updated before its displayed, so that the link contains the program id that *will* display when you nav to the dsr/fct page, which is needed to correctly set the top-level program filter tree, report table headers, etc. When the program id contains the erroneous dashboard program id, those things are incorrectly set (displaying "Blah" as the selected "currentProgram" when the program tree doesn't contain "Blah", and displaying "Blah" as the current program in the report table headers, and the page displaying no data, all of which are unhelpful to the user, and when I was testing, looked sloppy to not reset to the root program).

On the other hand, maybe we could grab the program tree in the controller instead of createLinkByTabs, and compare against that and update the model before displaying the view (or redirect), its essentially what the createLinkByTabs method does, which would achieve the same thing, but without also fixing the tab links.
I think you can do `! = repl.inheredoc`
why `c(0, 0.5)`?
`{}` + indenting here
The methods arguments are not used.
To set default language choices.
Should these not also be `em` now?
Might as well make this comment lineup too.
webkit should come second.
We totally could add a mixin for the prefixed bits here.
space after for
Oh, you clone it down here. Whoops, sorry!
People need to be able to include multiple classes. Ideally this should be a 'checkbox set'
I added this in to be consistent with `components.js`, which has exactly the same structure. See https://github.com/mozilla/napkin/blob/master/lib/components.js#L28-44. But you're right in that this is both unnecessary and inconsistent within this file. Since I plan to decompose all these CRUD methods anyway, as `components.js` and `elements.js` are almost exactly the same, I'll edit this back to its original form for now.
Let's capitalize caption words at least for English. That's how it is used in titles, e.g. "Go to First Page" (we can omit 'the' as well) Same for the lines below
Here is an official demo video: http://www.youtube.com/watch?v=BaW_jenozKc
Does the #XXX mean the function does not yet work?
Nah, in this case key is the converted value and k is value from the model prior to conversion to camelcase.  The models define the fields with underscores (i.e. account_id) and they are then converted to camelcase for the actual SOAP call.  

It's basically the same code as before I just added the if block in the middle to account for custom fields (__c).
这里能不能加个判断，FreeBSD7以后，默认已经把jemalloc整合到了libc，你这个选项能不能忽略判断，并且不要加-ljemalloc了。
sam, what is going on with ignorePresses % 3 == 0?
capture/yield
Would be nice with a few comments in here. Maybe describing the type of requests or just what happens in the apply method
This isn't necessary, it as added by default, together with `-all_load`.
Measure tool added back in w/editing tools
with value it's being fulfilled / rejected with.
So one thing to note here is that this function search all of pulp to see if the name exists.  I think what we may want to do is just search all of library for that organization (or just all of that organization).
So each MethodDescriptor needs to remember to call Adjust. That's the only part I don't like.
Which order is that? Those guidelines are both nascent and unclear.

On 13 Aug 2012, at 17:51, Kushal Pisavadia <notifications@github.com> wrote:

In app/assets/stylesheets/ancillary-pages.css:

> +
> +#wrapper .browse-sections dt:nth-child(1),
> +#wrapper .browse-sections dd:nth-child(2) {
> +  border-top:none;
> +}
> +
> +#wrapper .browse-sections dt {
> +  font-size: 2.25em;
> +  font-weight: 300;
> +
> +  margin: 0;
> +  width: 33.3333333%;
> +  float: left;
> +  clear:left;
> +  padding:0.5em 0;
> +}

These blocks should be ordered as the CSS
styleguide<https://github.com/alphagov/styleguides/blob/master/css.md>outlines.

—
Reply to this email directly or view it on
GitHub<https://github.com/alphagov/static/pull/15/files#r1363945>.
Right!
/me feels *really* silly
Is it possible to write tests that run the actual `jspinyin.js` instead of copy-pasted code here?

I won't block the pull request merging for this though.
The idea is that the ``Getting Started`` section should show people the most straightforward/simple things to do, and moving more complicated interfaces to the ``Using ...`` section.  So a fair number of people may only read the ``Getting Started`` section. Given that, I would say it should start with the simplest thing so they don't have the "too hard" reaction.

Maybe add a reference to the note about it generally being better to use an explicit cosmology, though? http://sphinx.pocoo.org/markup/inline.html#cross-referencing-arbitrary-locations explains how to do that, if you don't know.
恩，方法我也同意。
Agreed #150 needs a bit more thought on how things should work.

What about computing the list of never started secondaries, start one and if the tail is non-empty send an event to recompute. The vnode manager will block while it starts the vnode and any queued messages will have the opportunity to be processed before startign the next fallback.

Not sure if you'd have to factor out the start secondaries from the management_tick code or if it would be safe to run the mgmt code more frequently than every 30s.
On second thought, it does call 'checkChangedBalance' immediately before starting or restarting the timer - so it won't be delayed, but might actually be a bit costly if a bunch of transactions come in very quickly. Perhaps it would be better to remove the call to 'checkChangedBalance', and remove the condition that is there, and just check 'isActive' like you suggest. I.e.

// checkChangedBalance();
if(!pollTimer->isActive()) pollTimer->start();

Would that make more sense?
Didn't know that, but I think the names are more speaking than a simple -1 :), look how we guessed what that -1 means here. Would not have happend if we used the error codes.
I would argue that given it's a log message, as long as the message can be correlated to the code, then that's all that matters. I don't see a strong argument for filling debug.log with more bytes than needed to communicate what is happening. In fact, there's an argument that it doesn't need to be human readable at all, but then that would require additional tools to translate it into something human readable. This patch was an attempt at a convenient in-between between excess data, but keeping it human readable/understandable.
IMO placing the request into the router was a hack for a problem hard to solve, this can also be considered a hack, one that I would rather not have.
unqueriedLayerTitle: 'Diese Ebene kann nicht abgefragt werden.',
Yes, that's what WIF recommends. The logic is not "call the default one if it fails", it's more like "always call the default one unless fed auth is enabled and the incoming request is wsfederation token post". 

This is the pseudocode of the validator:

```
if (!fedauthenabled)
   run default validator (base.validate())

if (request is wsfederation response)
   return request is valid

run default validator (base.validate())
```
Please don't typehint the closure. Forbidding other callable types does not make much sense (we have this issue in the Collection interface which cannot be changed until 3.0 unfortunately)
Huuum, I agree on the thread issue ...  What do you think of the latest change ? I simple used the QActionPipe and QDeferredCaller to solve the asynchronous messaging issue. It runs like a charm and never blocks.
Okay, though the fact that you can change settings to see what the issue is makes this less valuable IMO. The downside of doing separate assertEquals is that if the overall list of keys changes, this won't catch that. If you're going to do it this way, can you also add an assertEquals for the set of keys?
Wait, shouldn't `FBTest.inspectElement` change the selected node? (`Inspector.highlightObject` doesn't do that I hope.)
Looks a bit gross, in any case. Event simulation > calling internal functions.
yep, i think @flack is right. we can discuss on tuesday @adou600 if its unclear.
I wouldn't compare strings with each other but use timestamps.
Remove this, should be set in bootstrap
Well when supported css3 is native, so much faster and less load on JS VM. And as tooltip fading is not that important I thought it was a good trade not o have it if not supported... I can try with jquery
Sorry for the bug, I wrote the code.

I think we should throw away the output.  Pipe was added to not contaminate
the terminal output:
https://github.com/ipython/ipython/pull/1861#issuecomment-6166295

Does the devnull solution work for all platform including windows?
I like the solution if so.  I think returning None is consistent when it
failed.  It is used only for sympyprinting extension and it uses other
display method when latex_to_png returns None.
Ah crap, sorry. Forgot to reset intellij settings - will fix it.
Presuming input is not null, its one line to instead do input.equals(checkNotNull..
Same thing in this file. The 'enabled' references seem to be okay.
You're right! I'll take care of this when I enhance the cloning.
You should use an `|` instead of addition here. Otherwise things get fuzzy when adding negative numbers.
Likewise.

~~~~c

static void assert_signature(git_signature *expected, git_signature *actual)
{
	cl_assert(actual);
	cl_assert(strcmp(expected->name, actual->name) == 0));
	cl_assert(strcmp(expected->email, actual->email) == 0));
	cl_assert(expected->when.offset == actual->when.offset);
	cl_assert(expected->when.time == actual->when.time);
}
~~~~~
Although you removed the reference from base.html, it's still in base-resp.html so pages using that template throw a KeyError. 

Remove {{ css('tabzilla') }} from line 23 in base-resp.html (it's not in this diff so I can't comment on the line directly).
Needs i18n: `{{ _('Thank you for getting in touch! You will hear from us soon.') }}`
Some comments here and below explaining that you're testing the case when LANG_FILES is a string and when it is a list would be appreciated (even moreso if I'm wrong and you're doing something else! :P).
Yeah since we know it's only ever 6 items I think I can find a workaround for this.
Totally. That helps a ton. I didn't know it existed.
It should check that we correctly handle an exception, which could be thrown by `NetUtil.asyncFetch()`. The test should not  be aborted.
I think if you didn't specify anything the field labels would be the same as you are specifying here.
Is this comment wrong or the code?
should be $this->getHeaders()
Why do you use the $categories here and the other two are rendered templates?
Don't try to absolutize ``paths/app-root`` if it is not given; this is so because it would raise an error otherwise; and if you specify all urls manually, then the ``paths/app-root`` setting is simply not required; nor does it make sense in such cases where no ``index.html`` exists (i.e. a Python webapp, where all static serving is virtualized and spread across  multiple directories).
Could you break down this in multiple lines ?
This is becoming pretty long.
Yep. Filed @ #130
sucks that these aren't all final. It would probably make it worse, but you could change the code to have a static factory method that does all the parsing and then calls the constructor with all of the ready-to-go values.
та сама фішка з шляхами
The singular is needed when the limit is set to 1
mixed ? Isn't it a float ?
no need to return anything if you already thrown exception just before
instanceof does not trigger autoloading.

On Fri, Nov 2, 2012 at 1:40 PM, Tobias Schultze <notifications@github.com>wrote:

> In src/Symfony/Component/Routing/Generator/UrlGenerator.php:
>
> >      {
> >          $this->routes = $routes;
> > -        $this->context = $context;
> > +        if ($context instanceof Request) {
>
> Does it trigger autoloading? If so it would make HttpFoundation a required
> dependency. But the condition can be switched, so it isn't.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony/symfony/pull/5895/files#r2015580>.
>
>
You can save 1 byte by using /(LT|L{1,4})/g
And the same here:
```ruby
context = registration_params[:options]
```
again, performance concerns suggest we keep the controller around.
no need to check if `[CPCheckinHandler sharedHandler].pendingAutoCheckInVenue` is `nil`. `[CPCheckinHandler sharedHandler].pendingAutoCheckInVenue.venueID` will return `nil` if `pendingAutoCheckInVenue` is `nil`.

Only reasonable case to test it is when `venue_id` could be `0` then it will work as not expected (`nil == 0`) - you have to decide, I don't know if `venue_id` could be a `0`
I've made the changes in the commits below.
I'd like to discuss the pattern of extracting as many helper methods as possible when dealing with methods of around ten lines. I see value in helper methods, but there is a point of diminishing returns. It's a pain to read a method when you constantly have to scroll down to the bottom of the class and read a bunch of one or two line helper methods. Let's discuss Monday.
Nu mai avem nevoie de un sql că oricum ele se încarcă din bază.

Mai pe urmă le vom filtra pe săptămână și pe lună.
Cf #369, CInteger must be replaced by CCommutativeRing
it's a bit misleading to say it's -1 to avoid the newline, because it works to avoid the separator the exact same way, the difference is that we started at sep_pos+1 so we have to '-(sep_pos+1)' ... but see my comment just below
for putting in these two nulls it's a bit more straightforward to skip the math and the new pointers:
```c
((char*)(EVBUFFER_DATA(req->input_buffer))[sep_pos] = '\0';
((char*)(EVBUFFER_DATA(req->input_buffer))[j] = '\0';
```
also notice the case where ```j == req_len```; is it ok to write outside of the buffer? this would be a drawback to jay's proposed technique (although only for the very last value, and never for a key)
I assume $res means "regular expressions" but it's slightly confusing because it has the same 3 start letters as "result".  How about "$regexps" instead?
This should be handled in the collection not in the view.
Je vais te faire confiance sur celle là :-)
Allowing an expression here means a management API version bump.
Why does this need its own Phase? BundleInstallProcessor does not appear to handle information from multiple deployment units, so I am not sure why this can't just be appended to the end of the PARSE phase?
Yup. Without unindenting, codesniffer complains that there are 4, 8 or 12 spaces where 0, 4 or 8 are expected.
Thx for the extensive explanation I will try to have it in mind while exploring TestSwarm code base :)
Why do you prefer the method call?
On 23/06/2012 03:19, Michal Budzynski wrote:
>> -        alignCard(currentDisplayed);
>> -      } else if (difference < 0 && currentDisplayed > 0) {
>> -        currentDisplayed--;
>> +
>> +    var touchPosition = {
>> +        x: evt.touches ? evt.touches[0].pageX : evt.pageX,
>> +        y: evt.touches ? evt.touches[0].pageY : evt.pageY
>> +    };
>> +
>> +    // if the element we start dragging on is a card
>> +    if (evt.target.nodeName === 'LI' && MANUAL_CLOSING) {
>> +      var differenceY = initialTouchPosition.y - touchPosition.y;
>> +      if (differenceY > removeCardThreshold) {
>> +        // Without removing the listener before closing card
>> +        // sometimes the 'click' event fires, even if 'mouseup'
>> +        // uses stopPropagation()
> The strange thing was that it didn't happen always, and I was not able to repeat it each time. But I think that trying to run app we want to close is useless, so removing the listener isn't bad in here, is it?

It's not but I would like to understand what is the issue beeing this 
strange click behavior.
I see. Well, in this case a querySelector() is fine, maybe you could use something like:
```javascript
var actualSection = document.querySelector('section#' + section)
```
I realized you were just changing the numbers, but Gecko unprefixed calc, so let's lose the prefixed versions too.  Thanks.
It is just a question, defer indicates after dom is loaded. Well in this case it is not important, after or before.. :)
If the function is private, please replace with <tt>_getOffset</tt> just to maintain coherence within the same file.
one id is enough :)
Same here (`//XXX`)
we should make this return something when `phoneNumber` is odd, and `undefined` when even.
then rework the `handled_call_test.js` to test bost cases.
No need for if/else here since you're using |break|. You can remove the else.
It can use jQuery but should not require it.
This method isn't needed, as users can just use LocalCluster#submitTopology method
I understand that point, but I'd rather avoid unnecessary configuration parameters. The path used for local storage implementation should always just be STORM_LOCAL_DIR + "/nimbus".
applicationFilePath here too
Converting this into a function means that body-form is going to get executed before the directory switching takes place. That is not how this should work.
As noted in the original ticket, I'm not hot on adding legacy browser support for this stuff. Needlessly balloons the code base.
side note: you can use an assoc array where the key is the desc.
Forgot to use the boss_client here. I guess we just want to merge this and do it afterwards
Maybe we can add a command line argument to specify which branch you want to use? I know internally we would mostly use testing.
Like in other code, consider a max backoff time.
The interface between SOAP services should be standardized. I've noted this here:
https://github.com/AppScale/appscale/issues/115
Why the params on `(order_info...)`? It looks unnecessary to me.
Maybe we can put a warning not only when the check fails, i think it will be interesting to have a warning elsewhere
Must be from an earlier version of the typography mixin in frontend-toolkit. This will go away once the mixins are being used by the app. But perhaps the toolkit gem needs updating in prototyping. Will check.
This isn't deferred now
This will end up being a single string, while otherwise `projects` is a list
It will be, per my IRC message from yesterday.
`static::$keys` would be better
Not sure what the hell happened to this file, but we still need it :)
@Seldaek The git protocol is simply a tcp protocol, and has no signatures; only when over SSH or SSL are signatures checked.
yep, its just a normal jar artifact. that will just trigger the manisfest generation at eclipse pde and will be integrated with m2e builder. the manifest will be generated at target (as any other artifact) and pde will know that project is a bundle.
並び順に関わらずモデルのセット用に標準的なコレクションクラスを提供する。
`comparator`が指定されている場合、コレクションはモデルが追加、あるいは削除された状態のままの並び順を保持する。
if all this code is commented, please delete it. If we need it lateron, we have the git history.
consider just making this if(this.s.dev_UA) {
Below, that.$el.text(...) escapes its arguments. that.$el.html(...) would be unescaped. There shouldn't be any injection possible here.
This library is not involved in this change, it should be removed.
Please remove if unnecessary. If necessary please stick to same naming convention either **tabs-fennec** or **fennec-tabs**
could you write helper function `isFload` and use it here `if (isFloat(value)) ....` would be much easier to understand.
I think it would be great if `Tab` could take just `rawTab` from which it will be able to find parent `window`. That way code can be simplified to:

```js
tabs = getTabs(window).map(Tab)
```
Didn't we want these to be in resource://gre/modules/toolkit/ ?
not sure these should be .error() level messages.  That one we reserve for codepaths that should never be executed in production.  I'd hope that the failing dependee process would have .error() messages that tell us why its failing, OR if it's related to the hardware or environment outside of our APP, we'll have warnings in our logs, and the absence of errors will point ops to the rest of the deployment infrastructure.  suggest .warn() for heartbeat failures.
so looking at this question: "should add email and reverify use the same apis and email?"

**APIs**:
 
  * `complete_reverify` and `complete_email_addition` are nearly identical
  * `stage_reverify` and `stage_email` are completely different
  * `status` calls are very different

So I think that we should send the same email for add email address and for reverify email address.  the landing page should be the same.  But I think we should use 'confirm' instead of add.

This is a tiny thing, but I like confirm because it's more general and applies to both email addition and email reverification...  I'll add a change for your review.
@lloyd - There are going to be a lot of text changes in the coming weeks with the copy-writer doing copy-write things.  I think we should wait until we get updated text before we inundate our localizers with two large sets of translations.
Do we still need this if statement?
Is the timestamp as transferred in microseconds? I don't think so, or is it?
Spaces around operands make things more readable to me.
Macroify as well?
Nope that's correct. `string` has one extra character than `mixed`.
I'm sorry, are you talking about some API added to Puppet after 2.7 or something?  The only other argument to raise is an array containing the backtrace, which the previous exception doesn't match.

I also don't think that having a backtrace that points *literally* two lines further up the stack adds much value, to be honest, or that it will in any meaningful way change the ability to debug failures.
Yes, it probably should. :)