labofsahil/github-event-dataset-2012 huggingface dataset:
I think we should emphasize that RapidSMS backends communicate via HTTP here and the difference between urls.py and INSTALLED_BACKENDS. Backends receive HTTP requests via Django's main HTTP thread (defined in urls.py). Backends send messages using the module defined in INSTALLED_BACKENDS with the appropriate name. Most likely these outgoing messages will use HTTP, but it's up to the backend (as long as it's non-blocking).
This should probably be `.media-list` or `.media-group` for consistency with the rest of BS.

Besides media is already the plural form of medium so medias isn't grammatically correct. :)
spaces surrounding = `var j = 0`
I'm thinking the first line should better be 'Shut down all writers'. In IDE's, often only the first line is shown. As such, I think the first one should be most descriptive.
The package published is not official and point in the background to a different repository. That package shouldn't be suggested by ZF2
This sounds like `X - Y + Y = X`
Please fix CS.
and if there is a good reason, add a comment regarding the choice made.
Why the second argument is converted to a string?
oh ya, of course.
This code is deprecated, but I changed it...
`throw new CommandException(message)`
When running this I got:

`Failed RPC connection to the node ejabberd@localhost: nodedown`

?
sorry my fault I thought in that moment that it was introduced in 2.6..
this is wrong IMO. 2.3 is already in RC so it should be added in 2.4 only
I wouldn't store the instances in ClassMetadata. I would create new class, that would provide them.
$id is a scalar when people call $entityManager->find("Entity", 1); Thats why the method is about normalizing.
why is a missing translation an invalid argument? isn't invalid argument meant for when i call a function with something invalid?
Yea, let's sit down tomorrow.
Manage a rollback mechanism if remove() throws an IOException.
Hmm na tento kod som zabudol, bola to nejaka cast examplu na ktorom som staval:).
install by copying everything from build dir to install dir
Yeah, forgot to change after some refactoring that were done...
Maybe even better is to generally use "JBoss server" - JBoss Server isn't a thing, we're just describing a "server from JBoss".
이 패치를 적용하면 static file 수정시, url 을 변경해줘야 합니다.
한달 동안은 사용자 local disk 에 cache object가 저장되기 때문이죠.

대신, 한번 사용자가 받아간 object는 한달동안 서버쪽에 요청을 하지 않습니다.
ok, wilco
Let's point it out to the doc/template authors to see what they want.
using this method this way we have some false positives
we should use:
<code>return self.is_element_present(*self._participate_img)</code>
Also, this list is exhaustive, not additive. None of those fields are guaranteed to be filled in, a better list is probably something like:

```python
list_display = ['user__username', 'user__email', 'is_vouched', 'display_name', 'ircname']
```

(which might need to be line-wrapped).
yeah, that one line `if` needed a double take.
Not sure if it's better or not, but this is why south passes that `orm` object into the forwards method. If you use it like `orm.UserProfile.objects...`, it uses the frozen signature for the model to avoid issues with future versions of the model. I'm sure this works, but the South docs are pretty clear about not doing it the way it was done before, and to always use `orm`.
I think they added it sometime after 1.3. Or maybe in 1.3. So nice.
This is done on purpose as this is the default behavior of browsers.
right, that'd work, thanks  - but now that I have this all written out and
working - and I think it's quite reliable - I'd leave it as is.

On Wed, Aug 29, 2012 at 9:10 PM, Simon Kornblith
<notifications@github.com>wrote:

> In BibTeX.js:
>
> > @@ -1896,6 +1910,34 @@ function writeField(field, value, isMacro) {
> >  	if(!isMacro) Zotero.write("}");
> >  }
> >
> > +
> > +function mapHTMLmarkup(characters){
> > +	//converts the HTML markup allowed in Zotero for rich text to TeX
> > +	//since  < and > have already been escaped, we need this rather hideous code - I couldn't see a way around it though.
>
> I think you could escape all characters but < and >, call mapHTMLmarkup(),
> and then escape the < and > characters. I'm not convinced that's a net win,
> though, since it makes the code above more complicated and thus more
> fragile.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zotero/translators/pull/447/files#r1493193>.
>
>



-- 
------
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
leftovers.  fixed.
Why do these methods combine the `setChildren(...)` and `addChildrenPage(...)` methods? Having this in one step makes it very inconvenient. Ideally, I'd like to be able to add regular children to this document using the other `addChild` methods of the DocumentWriter, and after I've written enough children to then say something like `addNextPage(...)` (which corresponds to the `addChildrenPage(...)` method).
Is `mx-module` really needed as opposed to simply `module`? I don't know whether they both exist and whether they both end up in modules/ or not, but it seems unneeded to me.
*without* 関数と似ていますが、other引数で指定した配列に存在しない値を返します。
публичный typedef обычно делают, чтобы не писать везде так длинно
Perhaps a later refactor?
indent all of this
I had this in a query-related namespace, but then based on other suggestions in this series of commits, it ended up being the only function left in that new namespace, so that didn't seem to make a lot of sense.  Nick's new query namespace seems to present itself as being really specific to compiling queries, but I'll go ahead and move it there I guess.
I'm not sure what you mean by full path.  We certainly can't use an absolute path, because the tests are being launched on a different machine than where this script is run, and there may be an entirely different directory structure outside the rethinkdb repository.

As for a relative path, that's exactly what it's doing.  Tests are executed from a temporary directory at rethinkdb/test_data, so ".." refers to the base directory of the repo.  I suppose I could leave $RETHINKDB in the command, but I removed it in the first place because it was getting evaluated before it was supposed to, and I didn't want to deal with passing it all the way down.
There should be a space between before and after the equal sign
This might be a bit verbose. There are some suggestions out on https://groups.google.com/forum/?fromgroups=#!topic/jsdoc-users/3mphXzlXvGA or https://groups.google.com/forum/?fromgroups=#!msg/jsdoc-users/03PTdjapZ3U/YamE0pVHR9MJ
I've made it more robust, It's still rather long but preferred over this one.
The only reason I left it here is so that we have all URLs occupying the /api/user/* space in one spot. I'm fine with either, so I'll move it unless you tell me I've swayed you ;)
well i am starting to wonder if we have to have 2 separate branches, one for 2.1 and one for 2.2
This method should not be necessary if you're using NotifyPropertyWeaver now.
You should probably add `$key =>` to the foreach instead of `key()`ing twice.
Просто вы сами не разобрались в том, что написали. =) Первой строкой цикла вы меняете элемент. Ну, если быть точным, то делаете предположение, что замена произошла. Затем вы это проверяете. То, что отработало тело "if" уже говорит о том, что замена произошла. Но затем вы что делаете? Генерируете новый индекс rnd! А потом по свежесгенерированному индексу выводите ячейку текущего объекта и ячейку копии. Естественно, они равны, так как вы не успели толком мутировать свою последовательность!
Не проверяется замена на такой же символ.
Я не согласен с вами.
Тут создаются локальные переменные, которым так же нужна память, для чего проверка происходит [super init] на nil? в основном это на достаточность оперативной памяти в данный момент, ну и удачно ли создался объект (не валидные данные передали). 
Тут выделяется память, если ее нет (что произойдет? выпадет ли на этом этапе exception?), допустим выполнение кода пойдет дальше, далее проверка super init идет в initWithArray и присвоение там уже переменных объекта self идет уже после self init и проверки. Так что все верно, имхо.
_arr будет создаваться для каждого объекта Cell. лучше вынести его в свойство класса
в нашем случае массив 100 элементов, так что работать будет, но согласен что нужно сделать универсально
I am pretty sure you will find a good solution soon, anyway ! :smiley:
Please don't change the indentation here
Yes, I like your suggestions, please use these messages in all drivers, thanks!
nothin'.
O que é params[0] ??? talvez valha a pena definir melhor estas variáveis.
Can we write a test for this in browser_tests.dart?
I don't really like the duality here – it could be unnecessarily confusing, because the difference is very slight. I think we should just keep `RAC_OBJ`, perhaps with a rename to just `RAC`.
Can you please add a test which verifies the `RACTuple` behaviors, and then also a test for plain `+zip:`?
Should use `image_with_fallback`
I think I just found something wrong here. When we use percent jump here, the page we jump to is the one that we don't want to record in jump stack. But we still want to save current page to jump stack right?
why not copy_raw argument but it will be unaccessible but the user in the getitem
Nevermind, it is being used because of time_ago_in_words
I'm not sure we want to make this a requirement for release. Can we add this as a development dependency if we need it?
what about ``Adding additional attributes on tags`` ? This way, the title says what it is about
indeed, it is only kept for BC until 2.3
this example should use a configuration block to show the annotations, the yaml, the XML and the static PHP ways IMO
you should add the use statement for this class
Link name path is broken.
part1, part2, part3, part4  are not very meaningful? can we replace those with better semantics? and can these pipelines be used standalone as in be useful standalone?
This object is no longer used and will be removed in subsequent commits.
Зачем оно публичное? Да и вообще, вряд ли тут функция нужна, ты ж везде только флаг выставляешь, и все.
Когда в следующий раз буду собирать мингвой - пофикшу
Exactamente. Eso es justamente lo que necesito para que se vea bien en
ambos casos.

Igual es cierto que no es muy previsible, tal vez debería usar
GetSecurityTrimmingHelper
en lugar de BeginSecurityTrimmingForm y adentro poner un `if`.


2012/12/6 Alpha <notifications@github.com>

> In source/CommonJobs/CommonJobs.Mvc.UI/Views/MyMenu/Order.cshtml:
>
> > @@ -12,38 +12,38 @@
> >
> >      <div class="alert alert-error alert-block" data-bind="visible: isOrdered">
> >          <div class="row">
> > -            @Html.HasActionPermission("GenerateOrder", @<text>
> > -                @using (Html.BeginForm(item.ActionName, item.ControllerName))
> > +            @using (var form = Html.BeginSecurityTrimmingForm("GenerateOrder"))
> > +            {
> > +                <div class="span3">
>
> Pero no sabés si va a estar dentro del form, ¿verdad? Es decir, si no
> tiene los permisos necesarios, no va a mostrar el form, pero sí va a
> mostrar este div. Si en cambio tiene los permisos necesarios va a mostrar
> el form y adentro el div.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/246/files#r2335719>.
>
>
À moins de faire erreur ```<b1>``` n'est pas un tag HTML valide? Pouquoi ne pas juste utiliser une classe css ```<b class="green-label">``` ou un truc du genre...
Missing backslash Exception will never be catched
I've always meant to upgrade this to 1.51 -- would you mind changing this to 1.51 now?
Why is this needed? When I work with Cucumber-JVM and IDEA I just open the top-level pom.xml as a project and IDEA does the rest.
Typo, oepnstack
Why are we removing the license from this file? It seems to be common practice to have this in all files regardless if the file is empty.
I know this is in but I'm reverting this dependency since it helps the IDE find the annotation processor in the classpath without the need to point it externally. Btw, we had this discussion already back in October: http://lists.jboss.org/pipermail/infinispan-dev/2011-October/009348.html
Gotta close the XMLStreamReader.  Thank you.
As per PEP8, please keep lines under 80 chars long.
Don't you mean "FileMovieWriter" here?
I don't think so, but I often use this "trick" to make floats instead of integers. Maybe another input would be good on this point.
But will this then still ensure the sound is off when tests are run? Seems like it will only turn the sound off at the end of a test or set of test runs.
Мы в наноблоках ничего про view не знаем, увы.
Поэтому лучше возвращать попап ровно туда, где он был.
Что кстати тоже не решает все проблемы -- если то место, которое мы
запомнили, куда-то делось,
то будет что-то нехорошее.

2012/5/12 chestozo
<reply@reply.github.com>:
>>      this.hasTail = !!this.$tail.length;
>>
>> -    //  FIXME: Может быть это нужно делать не тут, а где-нибудь в _show()?
>> -    //  Переносим ноду попапа в самый конец документа,
>> -    //  чтобы избежать разных проблем с css.
>> -    $('body').append(this.node);
>> +    // Храним исходное положение попапа, чтобы возвращать его на место
>> +    var previous = $node.prev()[0];
>
> Я понимаю.
> Под концом самого верхнего элемента я имел ввиду view.
> Выразился непонятно, да.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nanoblocks/nanoblocks/pull/63/files#r812187
Есть конфиг файл с адресами баз в каком-то виде. А тут вообще жёстко так захардкожено.
Better call it "Default" or "Simple" ExceptionHandler.
Also include some info about how this handler handles Exceptions here.
Changed to 80% of the max.
I removed the `s3d-hidden` class since I couldn't find a place we were using it.
It also adds some confusion with the `fl-hidden` class.

I created https://jira.sakaiproject.org/browse/SAKIII-5996 to follow up on this.
Can we try to avoid `!important` in here?
@arnodeclercq would definitely be a better approach.

Would the following work as well?

`#entity_download.s3d-dialog-container .s3d-dialog-header {`
(without the `h1.`)
@bp323 I now changed it to use `getUserLocale` so we have less code duplication.
It's probably still a good idea to wrap this in an API function.
:-1: If it is python2.6 the path will be wrong.
I agree outputting something is nice. Both versions from your comment look fine to me, so up to you.
WTF?   Why are we freeing a hazard reference array in the cache pool destroy function?
Public method. Apidoc.
Ging davon aus, dass diese nicht unbedingt gleich lauten wie in der Datenbank.
NodeProperty sind ja die Properties, die in der Datenbank verwendet werden.
Werds anpassen.
NOT reviewing css, cuz you are awesome
you probably want to use ``stderr``
Basically missing scheme is what causes parse_url in  php in general not to work correctly ( because it will mistake the host for a string if there is no scheme) but that doesn't necessarily mean that there is nothing to parse or worth parsing.
I think that although it would be slightly cleaner.  It's not worth moving these core messages. And although they will be in seperate packages cognatively it's not a large jump to nav_msgs.
To be honest, if I have such a situation (when a method may or may not defer), I assert that it must *always* defer, so that the interface is simplified. If the implementor does not need or want to return a ``Deferred``, one can always use ``twisted.internet.defer.succeed``. On the plus side, you automatically know that whatever is returned from the method, you can always call ``addCallback`` on it.
When migrating to use UnsupportedOperationException, please remove the throws clauses on the method declarations. UOE is a runtime exception so the clauses are not necessary.
Archlinux yes, and some other too. Overly old (debian) and extremely mainstream ones (ubuntu-like) don't however.
Group constants first, then variables. Maybe we could also add an empty line inbetween.
*izberi*, *tvojega*
There is some default subject prefix in settings.
I think it would be much easier if you would simply change:

```
user.gender=form.cleaned_data['gender']
```

to:

```
if form.cleaned_data['gender']:
    user.gender=form.cleaned_data['gender']
```
Добавить сеттер (setSchema)
indentation here and below
on sniffs ive just seen 8  and 9 values with that packets so i thought this were the correct size
Please change the regex to this: /(Acceptance|Integration)( ?Test)?\z/i
s/william/William
what about ``join``, ``order by``, ``having``, ... ?
The kernel module must be build the first time the live usb is running.
And i have a problem with installing xtables-addons-common  xtables-addons-source during the build, it remove packetfence.
So by hand.
How can a user understand what this means? He doesn't need to know what ipset is (implementation details), doesn't know what an entry means, what they are for and then there's store.. storing where? storing what?

Should be rewritten with the user in mind. What is the impact for PacketFence's inline mode of that limitation.
why is there &apos here twice?
Cglib has this convention, and many others. I'd really use nodep.
Is there a way to set the project version in one place and have all sub projects use it? I could see these version strings getting out of date, not just for the EB release, but for stuff like protobuf. Can we reference properties or something instead?
If the sort is lazy, no keys may be created here because nothing is done, so i think this test is not good.
Maybe encapsulate the call with a "list" can do the trick
Remember the rule: "it's" is the abbreviation of "it is". If you are unsure, replace all occurrences of "it's" by "it is". Then replace occurrences of "it is" that are obviously wrong by "its".
Insert here usual bracket-related m-c nit.
The content of the template is sanitized and saved in the DB.

Instead of allowing any python tokens or evaluating anything in the template HTML I just append the token to the actual response
I can other information in the discussion about the line
The sequence I'm doing is different than numbering in MSDN
This memory barrier needs to go before the write to lock_, or non-volatile loads and stores in the lock region are not guaranteed to complete before the lock is dropped (though they'll complete before Unlock returns).
What about those poor 32 bits users? Not to mention *BSD or OS X users?
DoctrineSelectableAdapter has **nothing** to do with the ORM. So why would the check use the ORM version ?
You can remove one of the branches here by initializing payloadSize to 0 at the start.
(And I think a comment that something faster exists is a good idea.  Mike, I volunteer to edit if it's a help?)
This can be found on the V3Publisher.PromotionalDiscountPercent.
The problem is that there is no active editable when the attributes are changed the first time (Aloha.activeEditable is null).
Maybe it's a recent change? Try to pull from dev and open the demo under /src/demo/boilerplate/captioned-image.html
Is it strictly necessary that the pool be the same size as the list of hosts? M:N seems perfectly reasonable to me.
Oh, i misread the code. The exception message should be rewritten to say "hostports cannot be larger than pool_size". That makes more sense, but maybe it should still be `pool_size * len(hostports)`, where `pool_size` is small. That way you don't get certain hosts arbitrarily preferred over others.
if you think so... have changed.
For no good reasons. I've switched to filtering all concrete classes that implement EntityLocal.
I wonder about best pattern for defining and using test apps/entities (e.g. we have TestApplication in core/src/test/java.
But this is fine.
(minor) -- I just noticed that javascripts/student_roster.js  has some unconventional javascript function names.  This isn't important, just thought I would mention that for ruby we like to use underscores for method_names, and in javascript we like camelCaseNames. )
I'm not sure about this one - `true` and `false` represent the abstract concept we're looking for just as well as `yes` and `no` do, and there is value in consistency with other languages. 

Using both `true`/`false` and `yes`/`no` in the same code feels pretty wrong. I don't know how much that matters, but it seems like there should be a single word for each truth and falsity. I can't substantiate that with a strong reason, though.
I converted return code of all file for my environment, seems made a mistake that time.
I will check it and recover.
I think the Travis-CI tests are currently relying on this. If so, we probably just need to update the `.travis.yml` file so that the ChromeDriver is in the path. Can you check, and make sure this pull passes in Travis?
What's with the excessive whitespace here? :-)
`42` is enough since it already is an integer
Agreed. I think first we would need to abstract Refinery::User to something else as @joemsak suggested
That was my first though too -- but then I saw that option names would have to be re-mapped in the migration process from wallet.dat. Let's keep it simple :)
Why are you adding this? Get the latest repo. We moved this method. 
git pull upstream master 

be aware of merge conflicts
It's great, simply add a mention to check the commands.md file
It's not called often enough. There are actually many runtimes where A.zone is null down this function.
I know http://amos.sourceforge.net redirects to the longer url, but I think `http://amos.sourceforge.net` is the main one (e.g. when they change their homepage in sourceforge)
Use `{@intheritDoc}` instead.
I'll look into that, and agree, but normally only the widgets subscribe to UAVO updates so there can be issues (prob not).
I'm fine however..  I've traditionally seen it with Copyright but that's when it isn't in an author line either.
Fixed. Thanks for the sizeof() suggestion.
Yeah, that was on purpose.  The GPS Only code path is much more sane in the airspeed module so better to default to that.  I've opened issue #138 for @kubark42 to take a closer look at the airspeed module.
TAG will be moved to Constants.TAG and will be used in all exception.
Is this good to hard-code to "off"? Does this pertain to CA validation? If so, prolly best to make it an attribute in the Nagios attributes/default.rb file...
Yep, make sense.
И как же можно узнать - какой именно класс несколько раз указан?
Кроме пробела могут быть и другие разделители.
Есть компаратор для -i : String.CASE_INSENSITIVE_ORDER
Можно написать компаратор, когда -i не указано. После чтения ключей создать нужный и использовать его во всей программе.
Вместо этого надо использовать LinkedList или ArrayDeque.
The following problems with their score and the rank:
A: -1 rank 0
B: -3 rank 1
C: -3 rank 1
D: -5 rank 3

I believe this code will have D have rank 2 instead of 3.
Determining whether the game is finished now relies on a boolean field, which is actually a bit cleaner than checking for the presence of a display message.
test  -h and test -L are the same thing.

I would normally use $0 as well, but the suggested solution for this problem that I found on stack overflow used BASH_SOURCE[0].  I don't know that it really matters.
`left, right, right` ? The third one will get the default value.
I think it should be first_free_hosted_app
can we make this locator more simple:
ex:
      list = self.selenium.find_elements(*self._featured_list_locator)
      list.find_element(B.CSS_LOCATOR, ' a h3').click()
This "embedding PyTest" thing is not my favorite thing (though I can live with it).
Your header dictionaries are case sensitive. They should be case insensitive.
By the way, split packages may be a real issue the moment you export them twice (http://wiki.osgi.org/wiki/Avoid_Split_Packages), which is not happening in the worksheet plugin, i.e., I'm not exporting that package.
What is the standard  import? The goal is thave these functions bound early.
Hint for next time: you don't need to declare loop variables when iterating over `xrange(N)` where `N` is declared as an integral C type.
Casting to `<double>` is no longer required here.
нет, здесь выбирается в форме категория, которую мы запросом вытянули из базы (38я строка)
$file_id = $data->file_id
    // do smth with a file

?
This is an unintentional reversion and shouldn't be part of this pull request.
These should stay un-indented.
This is reinventing MODtoBuffer().
It's useful when doing edits. 

It makes it harder to add more-test cases without it, because if you add another output line you have to change all line-numbers. So you have to do copy->paste from the output pane, and (in my case) `fail_compilation/` is also missing, so it's more work..
This is not thread-safe. Please use the following:
```
static TiTimeoutManager instance;
return &instance;
```
use v8ToNativeBridge instead
Actually bar-descriptor.xml not supported publisher or copyright (I haven't found that in docs) and will ignore it silently.
It should actually be possible with the compromise of losing access to the `Query` stuff :)
rtlMalloc calls cannot be changed in the same way.  It is quite likely that we will soon use a different allocator.
This may be a problem for combining expressions, ie. when comparing them, unless the comparison also doesn't care about it.
I'm not convinced this is going to buy you that much.  
If all the other buckets have spilt then you are probably best off spilling this as well.  Otherwise you will dedup a few items on this bucket, but be more likely to miss any near-neighbour dedups on the the other buckets.  I suspect on average you will be worse off (if the duplicates tend to be close to each other).
The code would be simpler as well.
yes, the HPCCResultSet class determines the appropriate index to use based on the where clause (and the select columns).
I don't think record can ever be NULL
This message is combined with `Unable to load URL: http://example.com/` with a colon; not sure if the formatting you have here makes sense for that.

How about this: drop the colon on line 161 and downcase the 'B' in "Because".

    Unable to load URL http://example.com/ because of an error loading http://example.net/: could not find The Net.
removing the `unlike!` method will break backwards compatibility. Can you alias the `unlike!` method to `cancel_like!`? That will preserve intent of the method.
Should I have something like this in the controllers
```
reject_non_displayable(Artist.all)
```

then in domain model:
```
def reject_non_displayable(artists)
   artists.reject {|artist| artist.displayable_artwork.empty?
end
```
should the enalbed API's be dependent on cinder?
create a dynamic name to work around the performance issue. generate random name from a random number.
agreed - no rule without exception ;-)
these comments don't seem to add much given your named constants, and clutter up your if () { } else { } flow, maybe just remove them
one more trick which we'll have to do, is to set DEFINES += HAVE_QRENCODE, and in the source, guard all includes/usages of API with it
Imo we should check `if setting.value.present?` first and only then check `if setting.value.is_a? String`
This looks good and is sane. There's a minor whitespace issue in the commit (tabs vs. spaces related I assume); can you adjust this line so that it aligns with the ones above it? Otherwise this looks good to merge. Thanks!
return false, right?
This type of hardcoded path concerns me too.
Should we check for these 2 attributes knowing core site sets them?  Seems that these will _always_ be set so no reason to check.  Other things should break before even getting to our recipes, right?
By the way, wouldn't a regular expression suffice here? Apache has built-in support for them, see `ap_regcomp()` and `ap_regexec()`.
Then use `develop` and `target` in deps file :P
How about

```python
    people = []
    try:
        people = paginator.page(page)
    except PageNotAnInteger:
        people = paginator.page(1)
    except EmptyPage:
        people = paginator.page(paginator.num_pages)
```

and then remove the initial people = []
A param name in square brackets indicates that they are optional, and a default value of undefined is implied, I think.
I don't understand how accidentally passing an object to a function that takes an index parameter is any more or less likely than accidentally passing null.  But I'm over it.
I suppose it's good practice to use their permalinks instead of just the main page though, otherwise what's wrong with wikipedia?  I think it's a great source for things like this.
fixed in https://github.com/jkudish/P2-Resolved-Posts/commit/c4b59b0641f32eea2fbcb12db9724dd1f0f809ae
Seems liek we keep on reimplementing this for the different cmdlets. Going forward we need to think of a way to converge the different project codebases into a common base "cmdlet" structure.
Instead of "plain", I think I'd say, "empty".
hm, it might be z-order issue. disregard my above comment then.
Unless you are saying the interpreter take absolutely zero cycles to process a declaration statement, the declaration before the error check is wasted performance (you mentioned it was king) in the event of an error.  I go on the assumption that the style guide (like the Java and Object-C guides) assume a certain degree a flexibility so that the developer can use their good sense and avoid obvious exceptions or edge cases.
Change to ...when *adding* and deleting...
horizontalRowHeight should be updated here as well
`horizontalRowHeight = Math.max(horizontalRowHeight, childHeight);`
The problem is that code size == performance. In fact, code size is typically the most important performance metric in web apps. If you look at jQuery, Dojo, Enyo, or any other toolkit, the only performance metric they talk about is how small their apps are. Ideally the output of the PHP file would be passed through a minifier to strip away all the extra white space, but that's a little more complex.

In the web dev world for typical apps, reducing code size > memory usage > cpu usage > readability in terms of priority.
I think the quotes are meant to wrap the value.
I dont think so. If you look at my commit i only moved that line from the proxy to there
https://github.com/Akylas/titanium_mobile/commit/02d32516fe61e301947facddd99f675b3ea3adb8#L1L152
Pleases address this comment.
Yeah, I generally agree about helpers, but wanted to minimize my changes here.
please have . instead of , before the "the following is an example..."
Thing is, the widget file button and the file button inside the dialog reuse the same construction code. Well, I suppose we can move it somewhere, although, not sure where exactly. It can be utils for now.
re: staging. может в .latest там всегда лог, а в релизе без лога?
а еще можно в debug тупо эвент слать и пусть кто как хочет его ловит
I'm just not so sure how I feel about being told I'm wrong at English by non-native English speakers and a yank ;)

That said: http://www.googlefight.com/index.php?lang=en_GB&word1=cannot&word2=can+not
*grumble* ... I'm still not happy to accept this, it looks ridiculous, I'll use "can't"...
Lambda seems to be a workaround more than new functionality. This should just work:

    static assert(allSatisfy!(a => a < 7, 1, 3, 4, 2));

I also have difficulty figuring some good use scenarios for this.
It seems to be necessary.

    $ dmd test.d
    test.d(5): Error: static assert  (isIntegral!(foo)) is false
    $ cat test.d
    import std.traits;

    enum foo { bar, baz }

    static assert(isIntegral!foo);
Are you 100% certain that this does the same thing as the `inout`  trick above? Though TBH, I confess that I don't entirely understand what `inout` is supposed to be doing there in the first place.
Yeah, I know. I just see the problem that one could accidentally add the old name to new files, too. But we can see how it's going to work out.
La dernière version de symfony2 utilise composer.
Tu devrais indiquer que pour sf 2.0.x il faut télécharger l'archive phar et la mettre dans vendor alors que pour sf 2.1.x il suffit de modifier composer, comme indiqué dans le chapitre 1
I think it would be simpler just to use g_ptr_array_free (array, TRUE) here.
Either put this in some non-setup `Constants` file, or just move each version into, say, `BookmarkRecord`… after all, the record structure is the main thing being versioned.
Hopefully this won't affect how integration tests are run; I was getting a "Unable to determine domain" error if I didn't change this in .NET 3.5.
in kara chiye !!!!
fahmidi bahso ?
chera sare class naporsidi
remarks and its content should be in separated lines like this
<remarks>
adkfja;ldsjf;lajf;lajfdsdfafd
afdasdf;lasdkfsafd
</remarks>
I guess this changed made a test failed on travis:

```
1) UniversalErrorCatcher_Tests_CatcherTest::shouldThrowRecoverableErrorIfCatherConfiguredThisWay
32Failed asserting that exception of type "PHPUnit_Framework_Error_Notice" matches expected exception "ErrorException". Message was: "Only variables should be passed by reference".
```
There will need to be more arguments passed here eventually. I use source => 'http://mywebsite' when using provider => gem in my manifests. 
Is there a puppet equivalent  of $* or **kwargs or some way to take an arbitrary number of arguments to a define?
The guessing looks broken here :)
This is odd.  I got the email here, but couldn't find this comment in the github pull page.  Anyway, it's a good point and, yet again, I agree with you.  :)  I changed this so that SuiteImporter just creates its own ImportResult on instantiation, so it will mark any add failures to it.  Then on import, it updates that result obj and returns it.

Feels cleaner to me that way.  :)

-Cam

----- Original Message -----
From: "Carl Meyer" <reply@reply.github.com>
To: "camd" <cdawson@mozilla.com>
Sent: Friday, February 24, 2012 1:10:16 PM
Subject: Re: [caseconductor] Json import (#2)

> +    def import_data(self, productversion, case_data):
> +        """
> +        Import the top-level dictionary of cases and suites.
> +
> +        Return an object that has the number of imported and skipped items.
> +
> +        """
> +
> +        # the result object used to keep track of import status
> +        result = ImportResult()
> +
> +        # map of suites to cases.  Map the initial dict, if one exists.
> +        suite_importer = None
> +        if "suites" in case_data:
> +            suite_importer = SuiteImporter(productversion.product)
> +            result.append(suite_importer.map_dict_list(case_data["suites"]))

No, I was wrong here, I thought only the actual import methods returned an `ImportResult`, but actually `map_dict_list` (or `add_dicts` if you rename it) also does. I'm not a huge fan of that - I think it'd be better to be consistent about which methods return an `ImportResult`. Currently this one is the only non-import method that does - I think the external API of `SuiteImporter` would be nicer if it didn't, and any warnings/errors were just delayed and added to the result when you actually call the `SuiteImporter`'s import method. But given the internal structure of `SuiteImporter`, since the dict of suites is keyed by name, you can't actually add a suite without a name. So I guess you'd need to add a separate internal list of "suites without names that someone tried to add". Up to you, I don't feel that strongly.

--- 
Reply to this email directly or view it on GitHub:
https://github.com/mozilla/caseconductor/pull/2/files#r487319
Time for a change? :)
What if there are more than three args? Do you want to silently ignore the extra ones, or assume the user did something unintentional and display the usage message? I'd think the latter is preferable.
@amolnayak311 Commit 35f0dd5 leaves that check in `onInit()` in place. Overall, the behavior of the adapter will actually now be slightly stricter in 2.2 as we now always validate the directory for each message.
Just a reminder for all these new setters. I am assuming the null checks are handled elsewhere or nulls ate valid values.
it's actually already merged in the original repo, (https://github.com/ktheory/rack-active_record_status/pull/4) but it is unclear if that will make it to rubygems, and since we probably shouldn't be relying on the repos of ex-employees (ktheory) it's best to merge this in the mdsol repo.
@davisagli is this ok that buildout for 4.1 is removed?
The `ActiveRecord` `#cache` method is implemented on the connection object like this:

```ruby
# pseudo code
def cache
  @activate_query_cache = true
  yield
ensure
  @activate_query_cache = false
end

# still pseudo code
def select_all_with_query_cache(query)
  if @activate_query_cache 
    read_from_query_cache_or_execute(query)
  else
    execute(query)
  end
end
alias_method_shizzle_nizzle
```

This change nests all `cache` methods, so that the instance variable gets activated on each connection. This means each connection manages its own query cache.  The `inject` does basically this:

```ruby
def cache(&block)
  master_connection.cache do
    slave1_connection.cache do
      slaveN_connection.cache do
        block.call
      end
    end
  end
end
```
Use `'` for constant strings.

There is no reason to have `select` prefix here. `#` means match by ID and only one element in DOM can have that ID. So there is no need to say that it is also select (except that you could not match it if you later on change it to div).
This phrase sounds really odd, i suggest it to be changed like this, 140-142:

**ВАЖНО:** Код, взаимодействующий с фреймворком, но не являющийся его частью
(например, код приложения или библиотеки, распространяемый не
 компанией Zend или одним из ее партнеров), не
I see these being used, but could you explain them?
@rande  If there is no standard route, we should throw exception.

@stof Show action added.
Funny. I wonder whether there are a few too many dots ;-)
> Do we have these rules for HV as well? 

Yes, but of course not enforced. I am trying to stick to this rule and you might have noticed that I change \<code\> every now and then in seemingly issue unrelated classes. I try to fix things as I come across them, eg when browsing code to investigate a implementation detail. 

> I think at least {@code} vs. <code> is not handled consistently. 

Right. That's the most common one. Then again, it is not really wrong to use \<code\>.

> If you don't have objections I'll add this to the wiki 

Not at all. I should probably have done it a long time ago

> and create a Jira issue to clean this up one day.

I guess we can to a once of cleanup, but imo is has low priority. Having an issue though might manifest our long term goal though :-)
does it really need? https://github.com/cursedcoder/DarkTranslationBundle/blob/master/Browser/Tracker.php#L75
That change is extremely tied to the agents infrastructure.
You can use the GridImpl id for that reason and don't share the same nodes if you don't want to.
You can also define different node names using the agent name for that right? 
I will test the pull request to see if it doesn't break any grid test, if it doesn't I will merge this code
The problem is since its black box we can't reach into the code.

Honestly in a perfect world we'd define the client as its own project and define the strings there, then reference it from both these black box tests and our actual code. Even so eventually it'd be nice to put those strings in the client.
please keep using the string concatenation instead of the interpolation
added corpuses view to user read modals
jamesladd note for you
No, I no longer test for these rat holes. But that's a good question, should we test for them. There might be a usecase we simply have not foreseen. And I am a bit reluctant to restrict them. Opinion?
Usually the beta tag is followed by some information (although it doesn't have to I guess) (You can see the advertising docs for an example)
HI Matt - we're going to deprecate $eventdata->files soon which is why it was removed from the master code - do you have custom code that uses/relies on this?
better "Android-only".  I had to read that twice.
Not, it was not, this PR it c hanges. You have almost used oldest file to test these changes.
This cannot be done like this, you cannot inject this settings through the DIC. This value must be configurable, please a look to the DateType class and the formatter option.
На некоторых бордах (форчан, например) внутри делформы так же может быть постформа, а там могут быть чекбоксы. Потому производится дополнительная проверка, что чекбокс находится внутри поста.
To make this test case more readable, you can use forEach (built-in in Array) to loop through batStat.event.eventDetailsArr and do assertions. Then you don't have to manually set the index to 0 then 1 and copy and paste the same lines for the expect calls. Same applies to the removeEventListener test case.
Why not test the args passed as well with ````toHaveBeenCalledWith()````
just meant when it fails, it isn't always fun to get rid of 20-30 alerts but clearly is manageable.
you need to clone the planets, or you will have them perform calculations on themselves
Стоит заметить, что выполнение `replaceDelform(post);` для каждого поста обходится дороже, чем один раз на всю форму. Однако это нивелируется тем, что эта функция выполняется в своём псевдо-потоке (js одно-потоковый язык). С этой заменой на глаз скрипт выполняется быстрее.
Should this be `console.info` instead?