L::Util: Rename and promote _parse_dpkg_control_iterative

Rename _parse_dpkg_control_iterative to visit_dpkg_paragraph and add
it to EXPORT_OK.

Made a slight alteration to how visit_dpkg_paragraph calls its CODE
argument for consistency with its "pattern".

Signed-off-by: Niels Thykier <niels@thykier.net>
L::Util: Add flag for disallowing comments in dctrl files

Change the "DEBCONF_FLAG" argument of the dctrl parsers to FLAGS and
interpret FLAGS as a bitmask of flags.  Add DCTRL_NO_COMMENTS that
causes the parsers to consider comments a syntax error.

Signed-off-by: Niels Thykier <niels@thykier.net>
c/shared-libs: Remove use of "OTHER_DATA" from objdump-info

OTHER_DATA (previously $objsomething{$file}) is an obsolete way to
mark a file as an "object file" (incl. SOs).  This is easier too see
when looking at the "original" checks/shared-libs (i.e. the root
commit aka. 020888).

One of its use today happens to filter some symlinks from a code path,
which can just as easily be achieved by checking for:
 $objdump->{$file}->{name}.

Signed-off-by: Niels Thykier <niels@thykier.net>
c/shared-libs: Break out of SONAME branch earlier for symlinks

Re-order to checking if a symlink or file "needs ldconfig" to be run.
Once this has been determined, symlinks only causes duplicate warnings
and is therefore skipped.

The checking of symlinks was added in commit ae2ef04a to avoid
false-positive "*-useless-call-to-ldconfig".

Signed-off-by: Niels Thykier <niels@thykier.net>
c/files: Extend icon-size-and-directory-name-mismatch check

Extend icon-size-and-directory-name-mismatch to cover all icons directories.

Useful directories include:
/usr/share/icons
/usr/share/kde4/apps/amarok/icons
c/files: Add raster-image-in-scalable-directory tag
d/changelog: Add entry for Felix Geyer's icon patches

Signed-off-by: Niels Thykier <niels@thykier.net>
t/: Fix hardening warning in s-l-non-pic-i386 test

Signed-off-by: Niels Thykier <niels@thykier.net>
coll/java-info: Compress java-info output

Signed-off-by: Niels Thykier <niels@thykier.net>
Add Apache2 checks
rename wrong-* to non-standard-*
c/apache2: Add description for deprecated config check
Implement apache2-deprecated-auth-config tag, add a test case for it
c/apache2: Remove some unneeded capture groups

Signed-off-by: Niels Thykier <niels@thykier.net>
c/apache2: Replace some loops with rel->visit/rel->matches

Signed-off-by: Niels Thykier <niels@thykier.net>
d/changelog: Add changelog entry for the apache2 check

Signed-off-by: Niels Thykier <niels@thykier.net>
d/changelog: Correct placement of tags in summary

Signed-off-by: Niels Thykier <niels@thykier.net>
c/debconf: Ignore missing db_purge calls for debconf providers

Also, fix a regression causing "missing dependency on debconf" for
debconf providers.  The regression appears to have been introduced in
the 2.5.7 development cycle as the regression does not appear on
lintian.d.o.

Signed-off-by: Niels Thykier <niels@thykier.net>
c/scripts: Ignore missing exec bit on debconf shell modules

The public debconf "confmodule" (and "confmodule.sh") are known
scripts that should be sourced rather than executed, so ignore
the missing exec bit.

Signed-off-by: Niels Thykier <niels@thykier.net>
c/menu-format: Check strong depends for menu icon

If a package is missing a menu icon, check its direct strong
dependencies built from the same source (if any) for the icon.  This
fixes false-positives menu-icon-missing in some cases.

Signed-off-by: Niels Thykier <niels@thykier.net>